platform/upstream/freerdp.git
6 years agochannels/server: Silence false positive warnings from covscan
Ondrej Holy [Tue, 21 Aug 2018 07:11:19 +0000 (09:11 +0200)]
channels/server: Silence false positive warnings from covscan

Change the code a bit to silence false positive warnings from covscan.

leaked_storage: Ignoring storage allocated by "audin_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpsnd_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "cliprdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "echo_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "drdynvc_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpei_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "remdesk_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "encomsp_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpgfx_server_context_new(NULL)" leaks it.

6 years agochannels/server: Format code by astyle
Ondrej Holy [Wed, 22 Aug 2018 11:12:35 +0000 (13:12 +0200)]
channels/server: Format code by astyle

Run ./scripts/format_code.sh before the following changes.

6 years agochannels/serial: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 11:55:56 +0000 (13:55 +0200)]
channels/serial: Fix leak found by covscan

leaked_storage: Variable "ids" going out of scope leaks the storage it points to.

6 years agochannels/remdesk: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 11:52:38 +0000 (13:52 +0200)]
channels/remdesk: Fix leak found by covscan

leaked_storage: Variable "pass" going out of scope leaks the storage it points to.

6 years agochannels/rdpgfx: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 11:47:24 +0000 (13:47 +0200)]
channels/rdpgfx: Fix leak found by covscan

leaked_storage: Variable "s" going out of scope leaks the storage it points to.

6 years agochannels/rdpgfx: Format code by astyle
Ondrej Holy [Wed, 22 Aug 2018 11:11:28 +0000 (13:11 +0200)]
channels/rdpgfx: Format code by astyle

Run ./scripts/format_code.sh before the following changes.

6 years agochannels/rdpdr: Prevent buffer overflow found by covscan
Ondrej Holy [Fri, 17 Aug 2018 11:43:18 +0000 (13:43 +0200)]
channels/rdpdr: Prevent buffer overflow found by covscan

buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->PathName" of size 256 bytes might leave the destination string unterminated.
buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->ExtraBuffer" of size 256 bytes might leave the destination string unterminated.

6 years agochannels/rdpdr: Format code by astyle
Ondrej Holy [Wed, 22 Aug 2018 11:07:46 +0000 (13:07 +0200)]
channels/rdpdr: Format code by astyle

Run ./scripts/format_code.sh before the following changes.

6 years agochannels/rdpdr: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 10:56:45 +0000 (12:56 +0200)]
channels/rdpdr: Fix leak found by covscan

leaked_storage: Variable "newbuf" going out of scope leaks the storage it points to.
leaked_storage: Variable "keys" going out of scope leaks the storage it points to.
leaked_storage: Variable "pKeys" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
leaked_storage: Variable "computerNameW" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.

6 years agochannels/rail: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 10:51:19 +0000 (12:51 +0200)]
channels/rail: Fix leak found by covscan

leaked_storage: Variable "s" going out of scope leaks the storage it points to.

6 years agochannels/drive: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 10:43:49 +0000 (12:43 +0200)]
channels/drive: Fix leak found by covscan

leaked_storage: Variable "outStr" going out of scope leaks the storage it points to.

6 years agochannels/addin: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 10:41:34 +0000 (12:41 +0200)]
channels/addin: Fix leak found by covscan

leaked_handle: Handle variable "hFind" going out of scope leaks the handle.

6 years agochannels/audin: Fix leak found by covscan
Ondrej Holy [Fri, 17 Aug 2018 10:30:33 +0000 (12:30 +0200)]
channels/audin: Fix leak found by covscan

leaked_storage: Variable out going out of scope leaks the storage it points to.

6 years agoMerge pull request #4808 from akallabeth/tls_extract_pem_fix
Martin Fleisz [Tue, 21 Aug 2018 08:01:47 +0000 (10:01 +0200)]
Merge pull request #4808 from akallabeth/tls_extract_pem_fix

Fixed #4806 broken bounds check.

6 years agoFixed #4806 broken bounds check.
Armin Novak [Tue, 21 Aug 2018 07:08:33 +0000 (09:08 +0200)]
Fixed #4806 broken bounds check.

6 years agoMerge pull request #4795 from akallabeth/rpm_build_fix
David Fort [Mon, 13 Aug 2018 13:21:49 +0000 (15:21 +0200)]
Merge pull request #4795 from akallabeth/rpm_build_fix

Deactivated FFMPEG support for redhat systems (deps not in repo)

6 years agoDeactivated FFMPEG support for redhat systems (deps not in repo)
Armin Novak [Mon, 13 Aug 2018 12:34:06 +0000 (14:34 +0200)]
Deactivated FFMPEG support for redhat systems (deps not in repo)

6 years agoMerge pull request #4794 from akallabeth/drive_find_first_file_fix
Norbert Federa [Mon, 13 Aug 2018 12:33:49 +0000 (14:33 +0200)]
Merge pull request #4794 from akallabeth/drive_find_first_file_fix

Drive find first file fix

6 years agodrive_file_query_information: Use GetFileAttributesExW
Armin Novak [Mon, 13 Aug 2018 11:23:52 +0000 (13:23 +0200)]
drive_file_query_information: Use GetFileAttributesExW

6 years agoFixed #4793: Return correct file handle for existing directory
Armin Novak [Mon, 13 Aug 2018 11:17:56 +0000 (13:17 +0200)]
Fixed #4793: Return correct file handle for existing directory

6 years agoMerge pull request #4789 from akallabeth/nightly_ffmpeg_rpm
akallabeth [Thu, 9 Aug 2018 08:41:56 +0000 (10:41 +0200)]
Merge pull request #4789 from akallabeth/nightly_ffmpeg_rpm

Enabled ffmpeg support on RPM based systems.

6 years agoMerge pull request #4788 from akallabeth/multimon_fullscreen
David Fort [Thu, 9 Aug 2018 08:22:24 +0000 (10:22 +0200)]
Merge pull request #4788 from akallabeth/multimon_fullscreen

Fixed #4786: Added fullscreen handling for dynamic resolution.

6 years agoAdded requirement check for WITH_DSP_FFMPEG
Armin Novak [Thu, 9 Aug 2018 07:58:56 +0000 (09:58 +0200)]
Added requirement check for WITH_DSP_FFMPEG

6 years agoEnabled ffmpeg support on RPM based systems.
Armin Novak [Wed, 8 Aug 2018 11:31:52 +0000 (13:31 +0200)]
Enabled ffmpeg support on RPM based systems.

6 years agoMerge pull request #4783 from akallabeth/nightly_audio
akallabeth [Wed, 8 Aug 2018 11:10:07 +0000 (13:10 +0200)]
Merge pull request #4783 from akallabeth/nightly_audio

Enabled FFMPEG for nightly builds.

6 years agoFixed #4786: Added fullscreen handling for dynamic resolution.
Armin Novak [Wed, 8 Aug 2018 11:04:26 +0000 (13:04 +0200)]
Fixed #4786: Added fullscreen handling for dynamic resolution.

6 years agoEnabled FFMPEG dependency.
Armin Novak [Mon, 6 Aug 2018 05:55:30 +0000 (07:55 +0200)]
Enabled FFMPEG dependency.

6 years agoMerge pull request #4778 from akallabeth/2_0_0_dev_4
akallabeth [Wed, 1 Aug 2018 13:59:34 +0000 (15:59 +0200)]
Merge pull request #4778 from akallabeth/2_0_0_dev_4

Started next development cycle

6 years agoStarted next development cycle
Armin Novak [Wed, 1 Aug 2018 10:33:34 +0000 (12:33 +0200)]
Started next development cycle

6 years agoMerge pull request #4777 from akallabeth/changelog_2_0_0-rc3 2.0.0-rc3
akallabeth [Wed, 1 Aug 2018 13:27:31 +0000 (15:27 +0200)]
Merge pull request #4777 from akallabeth/changelog_2_0_0-rc3

release: version 2.0.0-rc3

6 years agoMerge pull request #4776 from akallabeth/fixes_cleanups_etc
Martin Fleisz [Wed, 1 Aug 2018 13:16:07 +0000 (15:16 +0200)]
Merge pull request #4776 from akallabeth/fixes_cleanups_etc

Mac audin Fixes and cleanups

6 years agoAdded const to function buffer pointers
Armin Novak [Wed, 1 Aug 2018 09:58:24 +0000 (11:58 +0200)]
Added const to function buffer pointers

6 years agoFixed expression ambiguity
Armin Novak [Wed, 1 Aug 2018 09:57:18 +0000 (11:57 +0200)]
Fixed expression ambiguity

6 years agoFixed invalid return value type.
Armin Novak [Wed, 1 Aug 2018 09:56:47 +0000 (11:56 +0200)]
Fixed invalid return value type.

6 years agoFixed funtion to function pointer argument mismatch
Armin Novak [Wed, 1 Aug 2018 09:56:04 +0000 (11:56 +0200)]
Fixed funtion to function pointer argument mismatch

6 years agoFixed invalid format string.
Armin Novak [Wed, 1 Aug 2018 09:54:45 +0000 (11:54 +0200)]
Fixed invalid format string.

6 years agoFixed missing array initializer values
Armin Novak [Wed, 1 Aug 2018 09:54:18 +0000 (11:54 +0200)]
Fixed missing array initializer values

6 years agoFixed mac audin
Armin Novak [Wed, 1 Aug 2018 09:44:45 +0000 (11:44 +0200)]
Fixed mac audin

6 years agoFixed mac server compile issue.
Armin Novak [Wed, 1 Aug 2018 08:04:00 +0000 (10:04 +0200)]
Fixed mac server compile issue.

6 years agorelease: version 2.0.0-rc3
Armin Novak [Tue, 31 Jul 2018 09:29:59 +0000 (11:29 +0200)]
release: version 2.0.0-rc3

6 years agoMerge pull request #4773 from akallabeth/drive_multi_fix
MartinHaimberger [Tue, 31 Jul 2018 11:35:05 +0000 (13:35 +0200)]
Merge pull request #4773 from akallabeth/drive_multi_fix

Remember if drive was added by automout.

6 years agoMerge pull request #4774 from akallabeth/audin_leak_fix
Martin Fleisz [Tue, 31 Jul 2018 09:13:29 +0000 (11:13 +0200)]
Merge pull request #4774 from akallabeth/audin_leak_fix

Fixed leak in audio format processing.

6 years agoMerge pull request #4240 from akallabeth/wl_client_fixes
Martin Fleisz [Tue, 31 Jul 2018 09:03:39 +0000 (11:03 +0200)]
Merge pull request #4240 from akallabeth/wl_client_fixes

Fixed wayland issues.

6 years agoAdded default return value.
Armin Novak [Tue, 31 Jul 2018 08:45:04 +0000 (10:45 +0200)]
Added default return value.

6 years agoFixed leak in audio format processing.
Armin Novak [Tue, 31 Jul 2018 08:33:19 +0000 (10:33 +0200)]
Fixed leak in audio format processing.

6 years agoMerge pull request #4758 from akallabeth/dsp_fix
MartinHaimberger [Tue, 31 Jul 2018 08:22:22 +0000 (10:22 +0200)]
Merge pull request #4758 from akallabeth/dsp_fix

Audio/microphone fixes

6 years agoMerge pull request #4762 from mmattes/issue/4757
akallabeth [Mon, 30 Jul 2018 11:31:32 +0000 (13:31 +0200)]
Merge pull request #4762 from mmattes/issue/4757

Fix for #4757

6 years agoRemoved obsolete winodws path hack.
Armin Novak [Mon, 30 Jul 2018 11:16:45 +0000 (13:16 +0200)]
Removed obsolete winodws path hack.

6 years agoFixed windows automount drive arguments.
Armin Novak [Mon, 30 Jul 2018 10:58:15 +0000 (12:58 +0200)]
Fixed windows automount drive arguments.

6 years agoAdded automount flag for windows and macos implementations.
Armin Novak [Mon, 30 Jul 2018 10:37:19 +0000 (12:37 +0200)]
Added automount flag for windows and macos implementations.

6 years agoRemember if drive was added by automout.
Armin Novak [Mon, 30 Jul 2018 10:31:11 +0000 (12:31 +0200)]
Remember if drive was added by automout.

6 years agoMerge pull request #4741 from akallabeth/find_file_fix
Martin Fleisz [Mon, 30 Jul 2018 10:29:18 +0000 (12:29 +0200)]
Merge pull request #4741 from akallabeth/find_file_fix

Prevent FindFirstFileA from accessing parent directory

6 years agoMerge pull request #4755 from akallabeth/dyn_resize_fix
Martin Fleisz [Mon, 30 Jul 2018 10:28:38 +0000 (12:28 +0200)]
Merge pull request #4755 from akallabeth/dyn_resize_fix

Fixed #4679, #4753 dynamic resizing

6 years agoFixed callback parameter checks.
Armin Novak [Mon, 30 Jul 2018 09:22:11 +0000 (11:22 +0200)]
Fixed callback parameter checks.

6 years agoMerge pull request #4765 from mmattes/fix/double-import-xinput2
akallabeth [Mon, 30 Jul 2018 08:47:34 +0000 (10:47 +0200)]
Merge pull request #4765 from mmattes/fix/double-import-xinput2

Removed double ifdef WITH_XI, XInput2.h already included

6 years agoFixed missing argument checks.
Armin Novak [Mon, 30 Jul 2018 08:46:20 +0000 (10:46 +0200)]
Fixed missing argument checks.

6 years agoMerge pull request #4772 from Mandar-Shinde/master
akallabeth [Mon, 30 Jul 2018 08:37:50 +0000 (10:37 +0200)]
Merge pull request #4772 from Mandar-Shinde/master

macosx: Bring newly launched freerdp window to front

6 years agomacos: Bring RDP window to front
Mandar [Fri, 27 Jul 2018 10:24:57 +0000 (15:54 +0530)]
macos: Bring RDP window to front

To bring RDP window on top of all the windows

6 years agoRemoved double ifdef WITH_XI, XInput2.h already included
Markus Mattes [Tue, 24 Jul 2018 12:03:45 +0000 (14:03 +0200)]
Removed double ifdef WITH_XI, XInput2.h already included

6 years agoMerge pull request #4759 from mfleisz/audin_srv_fix
David Fort [Mon, 23 Jul 2018 20:06:09 +0000 (22:06 +0200)]
Merge pull request #4759 from mfleisz/audin_srv_fix

audin: Fix server-side dsp decoding

6 years agoFix for #4757
Markus Mattes [Sun, 22 Jul 2018 18:00:25 +0000 (20:00 +0200)]
Fix for #4757

6 years agoCode Cleanup
Armin Novak [Thu, 19 Jul 2018 14:21:03 +0000 (16:21 +0200)]
Code Cleanup

6 years agoaudin: Fix server-side dsp decoding
Martin Fleisz [Thu, 19 Jul 2018 13:54:40 +0000 (15:54 +0200)]
audin: Fix server-side dsp decoding

The decoder format was never set and so dsp_decode always failed
on the server side.

6 years agoUpdated experimental list.
Armin Novak [Thu, 19 Jul 2018 13:38:44 +0000 (15:38 +0200)]
Updated experimental list.

6 years agoFixed FFMPEG backend: Do not drop samples for package alignment.
Armin Novak [Thu, 19 Jul 2018 13:17:54 +0000 (15:17 +0200)]
Fixed FFMPEG backend: Do not drop samples for package alignment.

6 years agoFixed mixed declaration.
Armin Novak [Thu, 19 Jul 2018 10:20:14 +0000 (12:20 +0200)]
Fixed mixed declaration.

6 years agoFixed winmm backend logging.
Armin Novak [Thu, 19 Jul 2018 09:53:36 +0000 (11:53 +0200)]
Fixed winmm backend logging.

6 years agoFixed opensles compilation errors.
Armin Novak [Thu, 19 Jul 2018 09:46:54 +0000 (11:46 +0200)]
Fixed opensles compilation errors.

6 years agoMerge pull request #4754 from akallabeth/expose_cert_redirection_flag
Martin Fleisz [Wed, 18 Jul 2018 14:32:53 +0000 (16:32 +0200)]
Merge pull request #4754 from akallabeth/expose_cert_redirection_flag

Expose redirection flag for certificate.

6 years agoExpose redirection flag for certificate.
Armin Novak [Mon, 16 Jul 2018 15:08:26 +0000 (17:08 +0200)]
Expose redirection flag for certificate.

6 years agoFix #4752: Provide message free function for channel queue.
Armin Novak [Wed, 18 Jul 2018 13:16:50 +0000 (15:16 +0200)]
Fix #4752: Provide message free function for channel queue.

6 years agoFix #4752: Unsubscirbe all PubSub in dynamic channel.
Armin Novak [Wed, 18 Jul 2018 12:29:22 +0000 (14:29 +0200)]
Fix #4752: Unsubscirbe all PubSub in dynamic channel.

6 years agoFixed number of samples returned.
Armin Novak [Wed, 18 Jul 2018 10:33:52 +0000 (12:33 +0200)]
Fixed number of samples returned.

6 years agoFixed DVI_ADPCM mapping.
Armin Novak [Wed, 18 Jul 2018 10:33:39 +0000 (12:33 +0200)]
Fixed DVI_ADPCM mapping.

6 years agoFixed alignment issues.
Armin Novak [Wed, 18 Jul 2018 10:14:37 +0000 (12:14 +0200)]
Fixed alignment issues.

6 years agoFixed #4679, #4753 dynamic resizing
Armin Novak [Wed, 18 Jul 2018 07:31:04 +0000 (09:31 +0200)]
Fixed #4679, #4753 dynamic resizing

Simplified resize logic, do not check before setting current resolution.

6 years agoFixed alsa and pulse backend receive buffer sizes
Armin Novak [Tue, 17 Jul 2018 12:55:19 +0000 (14:55 +0200)]
Fixed alsa and pulse backend receive buffer sizes

6 years agoFixed ima_adpcm encoder bug.
Armin Novak [Tue, 17 Jul 2018 10:57:57 +0000 (12:57 +0200)]
Fixed ima_adpcm encoder bug.

6 years agoUsing dynamic logger again.
Armin Novak [Tue, 17 Jul 2018 08:57:08 +0000 (10:57 +0200)]
Using dynamic logger again.

6 years agoFixed override of stream data in dsp_encode methods.
Armin Novak [Tue, 17 Jul 2018 08:30:35 +0000 (10:30 +0200)]
Fixed override of stream data in dsp_encode methods.

6 years agoMerge pull request #4745 from akallabeth/redirect_fix_follow_up
Martin Fleisz [Fri, 13 Jul 2018 11:54:03 +0000 (13:54 +0200)]
Merge pull request #4745 from akallabeth/redirect_fix_follow_up

Fixed channel reconnect after redirect.

6 years agoFixed channel reconnect after redirect.
Armin Novak [Fri, 13 Jul 2018 11:11:38 +0000 (13:11 +0200)]
Fixed channel reconnect after redirect.

6 years agoRemoved debug log messages.
Armin Novak [Wed, 11 Jul 2018 14:37:29 +0000 (16:37 +0200)]
Removed debug log messages.

6 years agoFixed errno reset.
Armin Novak [Wed, 11 Jul 2018 14:27:14 +0000 (16:27 +0200)]
Fixed errno reset.

6 years agoMerge pull request #4742 from mfleisz/fix_wave2
Martin Fleisz [Wed, 11 Jul 2018 13:41:05 +0000 (15:41 +0200)]
Merge pull request #4742 from mfleisz/fix_wave2

rdpsnd: Fix sending of wave2 PDU

6 years agordpsnd: Fix sending of wave2 PDU
Martin Fleisz [Wed, 11 Jul 2018 13:06:31 +0000 (15:06 +0200)]
rdpsnd: Fix sending of wave2 PDU

According to MS-RDPEA 2.2.3.10 the Wave2 PDU's header BodySize field
should be equal the size of the PDU minus the header (4 Bytes).

6 years agoFixed pattern detection if path is already a directory.
Armin Novak [Wed, 11 Jul 2018 08:58:37 +0000 (10:58 +0200)]
Fixed pattern detection if path is already a directory.

6 years agoCode cleanups and more logging.
Armin Novak [Wed, 11 Jul 2018 08:53:26 +0000 (10:53 +0200)]
Code cleanups and more logging.

6 years agoMerge pull request #4738 from akallabeth/connect_timeout_retry
Martin Fleisz [Tue, 10 Jul 2018 15:31:08 +0000 (17:31 +0200)]
Merge pull request #4738 from akallabeth/connect_timeout_retry

Automatic timeout reconnect after callbacks

6 years agoFixed PEM certificate reading.
Armin Novak [Tue, 10 Jul 2018 12:57:13 +0000 (14:57 +0200)]
Fixed PEM certificate reading.

6 years agoMoved automatic reconnect after timeout to freerdp_connect.
Armin Novak [Tue, 10 Jul 2018 11:26:25 +0000 (13:26 +0200)]
Moved automatic reconnect after timeout to freerdp_connect.

6 years agoAdded automatic reconnect if freerdp_connect fails due to timeout.
Armin Novak [Tue, 10 Jul 2018 10:49:46 +0000 (12:49 +0200)]
Added automatic reconnect if freerdp_connect fails due to timeout.

6 years agoMade internal functions static to help compiler optimize.
Armin Novak [Tue, 10 Jul 2018 10:21:38 +0000 (12:21 +0200)]
Made internal functions static to help compiler optimize.

6 years agoUpdated reconnect to handle cases where PostConnect was not called
Armin Novak [Tue, 10 Jul 2018 10:04:27 +0000 (12:04 +0200)]
Updated reconnect to handle cases where PostConnect was not called

freerdp_reconnect might be called after a freerdp_connect failed due
to a TCP timeout waiting for user input.
In such cases we need to know if PostConect was already called and
do that if not.

6 years agoRemember accepted PEM cert to avoid unnecessary user input.
Armin Novak [Tue, 10 Jul 2018 08:03:49 +0000 (10:03 +0200)]
Remember accepted PEM cert to avoid unnecessary user input.

6 years agoFixed async input return value check.
Armin Novak [Mon, 9 Jul 2018 15:45:50 +0000 (17:45 +0200)]
Fixed async input return value check.

6 years agoMerge pull request #4727 from akallabeth/new_error
Martin Fleisz [Thu, 5 Jul 2018 14:37:15 +0000 (16:37 +0200)]
Merge pull request #4727 from akallabeth/new_error

Added no or missing credentail error.

6 years agoAdded no or missing credentail error.
Armin Novak [Thu, 5 Jul 2018 13:20:52 +0000 (15:20 +0200)]
Added no or missing credentail error.

6 years agoMerge pull request #4726 from akallabeth/bitmap_cache_fix
Martin Fleisz [Thu, 5 Jul 2018 07:50:03 +0000 (09:50 +0200)]
Merge pull request #4726 from akallabeth/bitmap_cache_fix

Fix #4725: Need to copy data.

6 years agoFix #4725: Need to copy data.
Armin Novak [Thu, 5 Jul 2018 06:44:42 +0000 (08:44 +0200)]
Fix #4725: Need to copy data.