dotnet-maestro-bot [Fri, 15 Sep 2017 16:51:17 +0000 (09:51 -0700)]
Update CoreClr to preview1-25715-02 (dotnet/corefx#24071)
Commit migrated from https://github.com/dotnet/corefx/commit/
f2f561315df5d58121f6d13cf6d81d75c9a3a343
Andrius Bentkus [Fri, 15 Sep 2017 14:14:33 +0000 (17:14 +0300)]
Do not use zero width spaces (dotnet/corefx#24069)
Fixes dotnet/corefx#24068
Commit migrated from https://github.com/dotnet/corefx/commit/
13db0aefa78577e9c9fd5574103178383c16508e
Stephen Toub [Fri, 15 Sep 2017 11:16:55 +0000 (04:16 -0700)]
Ignore unhandled exceptions from ManagedWebSocket keep-alive pings (dotnet/corefx#24055)
ManagedWebSocket has configurable timer-based keep-alive pings it sends to the remote server. If such calls fail, such as due to the connection getting closed, we just swallow the exception. But the way the exception is currently being swallowed results in a faulted task whose exception is never observed, resulting in the unobserved exception event being raised. Since our intention is to eat these errors and completely ignore them, we don't want the event raised. This commit just observes any such exceptions.
Commit migrated from https://github.com/dotnet/corefx/commit/
edecb1207cbe6194cb9a9f1bc862ef8d1ebb3ef4
dotnet-maestro-bot [Fri, 15 Sep 2017 06:31:19 +0000 (23:31 -0700)]
Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25715-01, preview1-25714-02, beta-25715-00, beta-25715-00, respectively (dotnet/corefx#24058)
Commit migrated from https://github.com/dotnet/corefx/commit/
3c54f59eb397ccf46259e502108c41220a90dea1
Maryam Ariyan [Fri, 15 Sep 2017 02:53:35 +0000 (22:53 -0400)]
Refactoring code. No changes made to logic. (dotnet/corefx#24060)
* Refactoring code. No changes made to logic.
Applying code review comments requested from pr24017
* removing unnecessary else statement
Commit migrated from https://github.com/dotnet/corefx/commit/
4854f643d8cc7448faa59511fe1c88a8da2ea49b
Maryam Ariyan [Fri, 15 Sep 2017 00:42:34 +0000 (20:42 -0400)]
Fixing assertion failure happening on some of the unix machines (dotnet/corefx#24017)
* Refactoring Process.Start to simplify logic
This also fixes the following existing issues:
- allows user to successfully open folder (23969) with UseShellExecute
- throws when opening a missing file with UseShellExecute
this makes these behaviours consistent across win/unix machines
Updated existing tests to comply with these new fixes
* Simplifying condition checks in Process.Start
* Applying code review comments
Commit migrated from https://github.com/dotnet/corefx/commit/
a16368dc4694c0334a8794107a9e868020f0bed5
Lakshmi Priya Sekar [Fri, 15 Sep 2017 00:22:43 +0000 (17:22 -0700)]
Merge pull request dotnet/corefx#24045 from Priya91/credentialmh
Fix Dns tests on OSX.
Commit migrated from https://github.com/dotnet/corefx/commit/
751ad52f47a045cbab872177e621af58b180cad8
Tarek Mahmoud Sayed [Fri, 15 Sep 2017 00:05:34 +0000 (17:05 -0700)]
Fix globalization tests to work with setting customization (dotnet/corefx#24052)
We used new CultureInfo in many places to check the NumberFormatInfo properties values . these tests can fail if the user customized the user settings on the running machine. The fix here is to use GetCultureInfo which always ignore the change in the settings and return the original values we need to test against.
Commit migrated from https://github.com/dotnet/corefx/commit/
708c20ad05f2474ed8b144ec6c3345d809c7843b
Tarek Mahmoud Sayed [Fri, 15 Sep 2017 00:01:19 +0000 (17:01 -0700)]
Enable disabled date parsing test on Linux (dotnet/corefx#24051)
Commit migrated from https://github.com/dotnet/corefx/commit/
b77c715ce2a7b27c61b56d9cf510a967ac3355f3
Shin Mao [Thu, 14 Sep 2017 23:47:52 +0000 (16:47 -0700)]
Generate ThisAssembly.cs to get Package Version. (dotnet/corefx#24050)
Commit migrated from https://github.com/dotnet/corefx/commit/
74d55bb454f4b00b09235fa4466fd60b00b750bd
Pent Ploompuu [Thu, 14 Sep 2017 23:31:05 +0000 (02:31 +0300)]
Fix TimeSpan tests for cultures using ',' in place of '.' (dotnet/corefx#24047)
Commit migrated from https://github.com/dotnet/corefx/commit/
da2d8d073371a2ceee52b47bf8bd03c2ba97f858
Shimmy [Thu, 14 Sep 2017 22:45:43 +0000 (01:45 +0300)]
ICollection<T> support in MinLengthAttribute and MaxLengthAttribute (dotnet/corefx#23664)
* Updated in MinLengthAttribute and MaxLengthAttribute to support ICollection<T>
* Added tests
* Fixed typo
* Trying to address two failing checks:
- Linux x64 Release Build
- UWP CoreCLR x64 Debug Build
* Implemented changes requested in review
- Extracted Count checking to an external helper to obey DRY
- Removed dependency of ICollection<T> and changed to simple reflection Count property lookup
* Added requested tests
Commit migrated from https://github.com/dotnet/corefx/commit/
f711317e1955770a462f6e15e6f86c0061d9796e
Eric Mellino [Thu, 14 Sep 2017 21:27:10 +0000 (14:27 -0700)]
Merge pull request dotnet/corefx#24023 from mellinoe/fix-compat-pack
Change the netfx compat pack to only ship stable packages, plus System.Drawing
Commit migrated from https://github.com/dotnet/corefx/commit/
5fe1d6902e4de8b852fb835040158c76f2b33957
Lakshmi Priya Sekar [Thu, 14 Sep 2017 20:09:59 +0000 (13:09 -0700)]
Add comment about change.
Commit migrated from https://github.com/dotnet/corefx/commit/
43d57385ba00001db19b97e1f9840c15c84a5249
Huangli Wu [Thu, 14 Sep 2017 20:15:47 +0000 (13:15 -0700)]
Fix the output message in SGEN. (dotnet/corefx#23949)
* Fix the output message in SGEN.
* Use 'code' in message instead of file.
Commit migrated from https://github.com/dotnet/corefx/commit/
9d1b728707902fe018c39761302865b2848adb8c
Jan Vorlicek [Thu, 14 Sep 2017 19:59:35 +0000 (21:59 +0200)]
Enable end to end Alpine corefx build (dotnet/corefx#24035)
This change enables full end to end build of corefx including
managed code on Alpine Linux.
Commit migrated from https://github.com/dotnet/corefx/commit/
0688e035d58ec2395049c4035c619529e884cf37
Eric Mellino [Thu, 14 Sep 2017 19:32:22 +0000 (12:32 -0700)]
Add WCF dependencies to the netfx compat pack.
Commit migrated from https://github.com/dotnet/corefx/commit/
0ed9243e67a9736e232f429af14ebcdeb59718db
Lakshmi Priya Sekar [Thu, 14 Sep 2017 19:00:34 +0000 (12:00 -0700)]
Fix Dns tests on OSX.
Commit migrated from https://github.com/dotnet/corefx/commit/
02ce63d315590d85aaff63e78165f5651fe2a562
dotnet-maestro-bot [Thu, 14 Sep 2017 15:36:09 +0000 (08:36 -0700)]
Update Standard to preview1-25714-01 (dotnet/corefx#24037)
Commit migrated from https://github.com/dotnet/corefx/commit/
49ba44706fb971f9c1e7488bbbe4cad5f81d7eb3
dotnet-maestro-bot [Thu, 14 Sep 2017 06:32:30 +0000 (23:32 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25714-00, beta-25714-00, respectively (dotnet/corefx#24032)
Commit migrated from https://github.com/dotnet/corefx/commit/
cdf87336afaa612d503c5102aa935223acebc4c8
Stephen Toub [Thu, 14 Sep 2017 06:15:55 +0000 (23:15 -0700)]
Merge pull request dotnet/corefx#23987 from stephentoub/stream_memory_overrides
Override memory-based Read/WriteAsync APIs on System.IO streams
Commit migrated from https://github.com/dotnet/corefx/commit/
d3c060a20f9a4264674e80a06e1aebbcf1fb1e94
Stephen Toub [Thu, 14 Sep 2017 01:07:37 +0000 (18:07 -0700)]
Add uap configuration to System.IO.Compression.Tests
Otherwise we run against an implementation that has the new stream methods but the tests don't realize it.
Commit migrated from https://github.com/dotnet/corefx/commit/
8d40fac24b4a1fdaacd46ae923f3258da1996e16
Stephen Toub [Tue, 12 Sep 2017 20:57:38 +0000 (13:57 -0700)]
Override BufferedStream.Read/WriteAsync(Memory)
Commit migrated from https://github.com/dotnet/corefx/commit/
d8939807cd72df458665503716a832dc79b8a338
Stephen Toub [Mon, 11 Sep 2017 21:25:58 +0000 (14:25 -0700)]
Override PipeStream.Read/WriteAsync(Memory)
Commit migrated from https://github.com/dotnet/corefx/commit/
e58048b5d5acbec3a087a57b733eb3698563ab92
Stephen Toub [Mon, 11 Sep 2017 19:28:23 +0000 (12:28 -0700)]
Override Deflate/GZipStream Read/WriteAsync(Memory)
Commit migrated from https://github.com/dotnet/corefx/commit/
2eabb76eac47d348728dcde54e1867530386c5e6
Lakshmi Priya Sekar [Thu, 14 Sep 2017 04:30:16 +0000 (21:30 -0700)]
Make ping tests reliable on OSX. (dotnet/corefx#24021)
Commit migrated from https://github.com/dotnet/corefx/commit/
5c671b14f74350907a939001b3d5c24c4e10b5aa
dotnet-maestro-bot [Thu, 14 Sep 2017 04:15:56 +0000 (21:15 -0700)]
Update BuildTools, CoreClr, CoreSetup, Standard to prerelease-02014-02, preview1-25714-01, preview1-25713-01, preview1-25713-01, respectively (dotnet/corefx#24003)
Commit migrated from https://github.com/dotnet/corefx/commit/
a2a3c6b676bf851d8fb9a9b761ad82fff8d5de2f
Tarek Mahmoud Sayed [Thu, 14 Sep 2017 01:27:01 +0000 (18:27 -0700)]
Fix Mongolian date parsing test (dotnet/corefx#24020)
Commit migrated from https://github.com/dotnet/corefx/commit/
0e1bf9d8256b73d1ab0a06d896c56ff7804c79db
Tom Deseyn [Thu, 14 Sep 2017 00:47:05 +0000 (02:47 +0200)]
Fix return value of partially successful Socket.Send (dotnet/corefx#24005)
* Fix return value of partially successful Socket.Send
* Fix Assert.InRange range
* Fix SocketError return
* move successfulSend outside loop
* Test: buffer size 100M -> 5M
* Disable test on Windows because all data gets sent
Commit migrated from https://github.com/dotnet/corefx/commit/
e758b9a156351cda34d7da172bb10e9dfdbe05c2
Jan Kotas [Thu, 14 Sep 2017 00:46:04 +0000 (17:46 -0700)]
Replace JitHelpers.UnsafeCast with Unsafe.As (dotnet/corefx#24019)
Both methods to the same, but the latter one is the offficial public name for the functionality
Commit migrated from https://github.com/dotnet/corefx/commit/
dc9f75d81e91a531f7235c95ee9c18a047332dc6
Tarek Mahmoud Sayed [Thu, 14 Sep 2017 00:12:27 +0000 (17:12 -0700)]
Fix Console Title test when running on RS2 (dotnet/corefx#24016)
* Fix Console Title test when running on RS2
* Fix the typo
Commit migrated from https://github.com/dotnet/corefx/commit/
4be1dea0b0220d9b8dfe86bc20c4d06c852d9ce6
Eric Mellino [Wed, 13 Sep 2017 23:46:04 +0000 (16:46 -0700)]
Change the .NET Framework compat pack to only ship stable packages, and System.Drawing.Common.
Commit migrated from https://github.com/dotnet/corefx/commit/
3d7288f764b764c6f98758ae3414eee8acacff82
Eric Mellino [Wed, 13 Sep 2017 22:27:24 +0000 (15:27 -0700)]
Merge pull request dotnet/corefx#23991 from mellinoe/system.drawing-misc-cleanup-3
Re-organize and clean up some Unix Drawing code.
Commit migrated from https://github.com/dotnet/corefx/commit/
0db86283df5bb08dced21e556a9a475c93e7bd6c
Maryam Ariyan [Wed, 13 Sep 2017 22:18:38 +0000 (18:18 -0400)]
fixing test failure on some windows machines (dotnet/corefx#24007)
Commit migrated from https://github.com/dotnet/corefx/commit/
f59f25f75cb31497e1b0d9a935bcfac6c73df9bc
Huangli Wu [Wed, 13 Sep 2017 21:00:00 +0000 (14:00 -0700)]
Add /casesensitive parameter so the command works on linux when the path contains capital letter (dotnet/corefx#23947)
* Add /casesensitive parameter so the command works on linux when the path contains capical letter.
* Set casesensitive as default for the path.
* Add an empty line after }
Commit migrated from https://github.com/dotnet/corefx/commit/
7fe8643547987c844fad93ccccd946fd1ed7fd00
Eric Mellino [Wed, 13 Sep 2017 20:01:39 +0000 (13:01 -0700)]
Fix a spurious test failure in System.Drawing.Common.Tests (dotnet/corefx#24009)
* Fix spurious failure in FontTests.cs
* The FontSize in FromLogFont_ValidLogFont seems to be dependent on system
state, and not a constant value.
* Add better error message to AssertDefaultPageSettings.
Commit migrated from https://github.com/dotnet/corefx/commit/
99ac27f1223460424a2ebc0899895884e6c5c191
Stephen Toub [Wed, 13 Sep 2017 20:01:15 +0000 (13:01 -0700)]
Add ReadOnlyMemoryContent to System.Net.Http (dotnet/corefx#24006)
* Add ReadOnlyMemoryContent to System.Net.Http
Allows `{ReadOnly}Memory<byte>`s to be uploaded in HttpClient requests.
* Address PR feedback
* Address more PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
d183fd34074fba9633f025fe2251e7d7883c7f25
Stephen Toub [Wed, 13 Sep 2017 20:00:48 +0000 (13:00 -0700)]
Disable MulticastInterface_Set_AnyInterface_Succeeds test on Fedora (dotnet/corefx#24010)
All Fedora runs hang because of this.
Commit migrated from https://github.com/dotnet/corefx/commit/
2ad41da209006b99878beaf09f50b8c4bbd49f9a
Wes Haggard [Wed, 13 Sep 2017 18:37:36 +0000 (11:37 -0700)]
Merge pull request dotnet/corefx#23942 from hqueue/fix/run_test
Update run-test.sh to follow up recent change
Commit migrated from https://github.com/dotnet/corefx/commit/
a0b003da3774d7db9779a51bec6594960142745f
Lakshmi Priya Sekar [Wed, 13 Sep 2017 18:14:28 +0000 (11:14 -0700)]
Merge pull request dotnet/corefx#23995 from Priya91/ping6
Make tests reliable around osx ping6 bug.
Commit migrated from https://github.com/dotnet/corefx/commit/
f1aceffe8fdcd14923c7f0f712df7d2e495c68af
dotnet-maestro-bot [Wed, 13 Sep 2017 11:59:39 +0000 (04:59 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25713-00, beta-25713-00, respectively (dotnet/corefx#23998)
Commit migrated from https://github.com/dotnet/corefx/commit/
96fb7c99326866923eb92d47f3fb652124014cf5
dotnet-maestro-bot [Wed, 13 Sep 2017 04:42:56 +0000 (21:42 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to prerelease-02012-02, preview1-25713-01, preview1-25712-02, preview1-25712-02, beta-25712-00, beta-25712-00, preview1-25712-01, respectively (dotnet/corefx#23993)
Commit migrated from https://github.com/dotnet/corefx/commit/
860123c95c8b5b709bfce924e6b951a2702857b6
Hyung-Kyu Choi [Wed, 13 Sep 2017 03:13:50 +0000 (12:13 +0900)]
Remove netstandard fallback logic
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
dae79ee4ca7a0b061f1621cad53c81ab1ba6d3a0
Eric StJohn [Wed, 13 Sep 2017 02:31:55 +0000 (19:31 -0700)]
Merge pull request dotnet/corefx#23978 from ericstj/serializerTest
Re-enable XmlSerializer.Generator tests
Commit migrated from https://github.com/dotnet/corefx/commit/
6b948ddc5c37989ecd2cbd8fc597f9ce35a7d84d
Lakshmi Priya Sekar [Wed, 13 Sep 2017 02:09:33 +0000 (19:09 -0700)]
Make tests reliable around osx ping6 bug.
Commit migrated from https://github.com/dotnet/corefx/commit/
81c177804ae1b9918a03efb06d3d241b58546e54
Lakshmi Priya Sekar [Wed, 13 Sep 2017 01:55:50 +0000 (18:55 -0700)]
Merge pull request dotnet/corefx#23868 from Priya91/credentialmh
Remove duplicate bug ids in source code.
Commit migrated from https://github.com/dotnet/corefx/commit/
82a45b73d9754ae5e82ce1c699b0c86db712e4fa
Sven Boemer [Wed, 13 Sep 2017 00:57:53 +0000 (17:57 -0700)]
Use linker from ILLink.Tasks (dotnet/corefx#23945)
* Try to use ILLink.Tasks
* Use new linker package without netstandard cecil
* Update illink path based on host environment
Commit migrated from https://github.com/dotnet/corefx/commit/
4c540ae9a9525196390a32c96a1f0bc76e33969a
Lakshmi Priya Sekar [Wed, 13 Sep 2017 00:36:53 +0000 (17:36 -0700)]
Move test to windows specific.
Commit migrated from https://github.com/dotnet/corefx/commit/
b95d60789528d2d920e4d58238ee3fd3260585de
Eric St. John [Tue, 12 Sep 2017 19:13:55 +0000 (12:13 -0700)]
Reenable Microsoft.XmlSerializer.Generator.Tests on unix.
Commit migrated from https://github.com/dotnet/corefx/commit/
43e9165afdacfa79ff1ffc87759da34ecf6ab3b9
Ahson Ahmed Khan [Tue, 12 Sep 2017 23:02:48 +0000 (16:02 -0700)]
Making dangerous Span APIs less discoverable. (dotnet/corefx#23965)
Commit migrated from https://github.com/dotnet/corefx/commit/
155a46c0c59fddefc009c2a4affd0fd2b3bac2b3
Eric St. John [Tue, 12 Sep 2017 19:13:00 +0000 (12:13 -0700)]
Update BuildToolsVersion to 2.0.0-prerelease-02012-02
Needed for https://github.com/dotnet/buildtools/commit/dotnet/corefx@
fcddc57cac0738e4ad0de79a3b094664a56d39fc
Commit migrated from https://github.com/dotnet/corefx/commit/
e1c6a3026adff5f9e7c7af955e352e535af8863a
Eric Mellino [Tue, 12 Sep 2017 22:48:58 +0000 (15:48 -0700)]
Re-organize and clean up some Unix Drawing code.
Commit migrated from https://github.com/dotnet/corefx/commit/
97aec401633ef56a56542597bc0b40460cc24464
Eric Mellino [Tue, 12 Sep 2017 22:23:34 +0000 (15:23 -0700)]
Merge pull request dotnet/corefx#23964 from mellinoe/system.drawing-unify-printing
Fix, clean up and re-organize System.Drawing.Printing code
Commit migrated from https://github.com/dotnet/corefx/commit/
b587dc3d0ed68b3c37ea93e5afc472ba2e815dad
Dan Moseley [Tue, 12 Sep 2017 20:55:56 +0000 (13:55 -0700)]
Disable Drawing tests on Server Core (dotnet/corefx#23983)
* Add IsWindowsServerCore
* Disable tests for Server Core
* Redundant check
* Mssing ref
Commit migrated from https://github.com/dotnet/corefx/commit/
612c36d672297d0308058e1edc803a19dba9811d
David Shulman [Tue, 12 Sep 2017 20:40:27 +0000 (16:40 -0400)]
Disable broken HttpWebRequest timeout test (dotnet/corefx#23979)
The HttpWebRequest test,
Timeout_SetTenMillisecondsOnLoopback_ThrowsWebException, doesn't work
reliably. It's trying to test timeouts on requests but doesn't actually
create stable conditions with the loopback server (i.e. to make it slow
to respond).
dotnet/corefx#22627
Commit migrated from https://github.com/dotnet/corefx/commit/
8dce38d1875607c3bfa21ff176d8b2a156a79bef
Jan Vorlicek [Tue, 12 Sep 2017 20:15:14 +0000 (22:15 +0200)]
Fix check for in_pktinfo and ip_mreqn (dotnet/corefx#23976)
This change fixes the check for in_pktinfo and ip_mreqn. It was broken and was
always succeeding even on platforms where these structs were not present.
Commit migrated from https://github.com/dotnet/corefx/commit/
f81809ca36ff01384bbfb284b996dc438cedd927
Eric Mellino [Tue, 12 Sep 2017 19:53:10 +0000 (12:53 -0700)]
Clean up PrintingServices.Unix.cs more.
Commit migrated from https://github.com/dotnet/corefx/commit/
95094889c03a65991270226d986ad4143ae2b3c3
Eric St. John [Tue, 12 Sep 2017 19:11:45 +0000 (12:11 -0700)]
Only use test shared framework for XmlSerializer.Generator tests on netcoreapp
The tests will also run on desktop (and potentially UWP).
In those cases we'll use the tool's shared-framework for GenerateSerializationAssembly since we don't
have a test shared framework (since we're not building netcoreapp).
Commit migrated from https://github.com/dotnet/corefx/commit/
0d01a211be07dae633119a5d9b8c278a6d08c3ce
Maryam Ariyan [Tue, 12 Sep 2017 18:35:04 +0000 (14:35 -0400)]
Merge pull request dotnet/corefx#23705 from maryamariyan/temp-unix-fix
Improving UseShellExecute implementation on Process.Start
Commit migrated from https://github.com/dotnet/corefx/commit/
e670fd396d1c2a6ae99f2bb0ec24a81e30c668e7
Dan Moseley [Tue, 12 Sep 2017 18:21:09 +0000 (11:21 -0700)]
Log InstallationType key on Windows (dotnet/corefx#23973)
* Log InstallationType key on Windows
* Avoid registry for UAP
Commit migrated from https://github.com/dotnet/corefx/commit/
d47a6f3de852b88b88a936194a3d8eef728d359d
Xing Mao [Fri, 18 Aug 2017 22:27:24 +0000 (15:27 -0700)]
Fix dotnet/corefx#22779
Commit migrated from https://github.com/dotnet/corefx/commit/
f05d1d6e43c86b94bb8bd790c2065410e41f8c58
Xing Mao [Thu, 17 Aug 2017 23:54:01 +0000 (16:54 -0700)]
Fix dotnet/corefx#22778.
Commit migrated from https://github.com/dotnet/corefx/commit/
5d7d440848e8798e9945e73a764fbafcd2d30fcd
Xing Mao [Thu, 17 Aug 2017 00:07:16 +0000 (17:07 -0700)]
Fixed a bug in GetCollectionMethods.
Fix dotnet/corefx#22777
Commit migrated from https://github.com/dotnet/corefx/commit/
781e6f4235b755bb18d7e5aa834e2b9d4cf64e22
Xing Mao [Wed, 16 Aug 2017 20:14:58 +0000 (13:14 -0700)]
Fix test with DataSet serialization.
Fix dotnet/corefx#22776
Commit migrated from https://github.com/dotnet/corefx/commit/
68e145a4dd2eab39fe8cda4c1c943d68d00f4274
David Shulman [Tue, 12 Sep 2017 17:32:07 +0000 (13:32 -0400)]
Move Socket UDP related tests to OuterLoop (dotnet/corefx#23980)
The DualModeConnectionless* tests have been unreliable in CI. Moving
them to OuterLoop pending further analysis.
dotnet/corefx#17681
Commit migrated from https://github.com/dotnet/corefx/commit/
76a0e3c2d8c5dccffe1e202ea86037f27a9398d6
Maryam Ariyan [Tue, 12 Sep 2017 17:28:31 +0000 (13:28 -0400)]
uncommenting OuterLoops and fixing conditional test
Commit migrated from https://github.com/dotnet/corefx/commit/
3a5c6c3a8922afbe121ea343d9bd0e90d127da31
David Shulman [Tue, 12 Sep 2017 17:13:01 +0000 (13:13 -0400)]
Fix Socket Shutdown_TCP_CLOSED_Success test (dotnet/corefx#23975)
This test has been failing at times with an exception being generated
from the client socket due to the loopback server terminating the
connection with RST instead of FIN.
The problem is that the server socket needs to use Shutdown() before
Dispose() to ensure a clean FIN after the data gets sent back to the
client.
Fixes dotnet/corefx#13539
Commit migrated from https://github.com/dotnet/corefx/commit/
338ddc649308c7e3b97a37c8803a1cc5e5e3bd59
David Shulman [Tue, 12 Sep 2017 17:09:51 +0000 (13:09 -0400)]
Disable unreliable Http diagnostics logging test (dotnet/corefx#23977)
The Http test, SendAsync_ExpectedDiagnosticCancelledLogging, has been
failing at times.
I am going to disable this test until it can be made more robust. It is
not a reliable test because cancellation cannot be guaranteed to occur
with a certain time especially on a busy machine.
dotnet/corefx#23209
Commit migrated from https://github.com/dotnet/corefx/commit/
839ace982010b10bef94c9aac1d2eb991f76c383
Maryam Ariyan [Tue, 12 Sep 2017 16:24:41 +0000 (12:24 -0400)]
Applied second round code review
Commit migrated from https://github.com/dotnet/corefx/commit/
3682f8adfab388dce57429bee0069b3b518adc1d
Eric St. John [Tue, 12 Sep 2017 16:01:18 +0000 (09:01 -0700)]
Renable XmlSerializer.Generator tests
Previously these were disabled if the generated dll was missing, now they'll fail if the DLL is missing.
Commit migrated from https://github.com/dotnet/corefx/commit/
cf8a4cb2841f4eedafc80fcf40ae11b3a9f794a8
Eric St. John [Tue, 12 Sep 2017 15:59:27 +0000 (08:59 -0700)]
Binplace the serializer assembly to the TestPath
This was needed after https://github.com/dotnet/corefx/commit/dotnet/corefx@
664ca9508a03483a7fb2714b55b9cba885593d90
changed the tests to run from a binplaced location rather than the outputpath of the test.
Commit migrated from https://github.com/dotnet/corefx/commit/
598053e4d98f59e8300f16fc92cce5a3ad95ba63
Eric St. John [Tue, 12 Sep 2017 15:57:07 +0000 (08:57 -0700)]
Run dotnet-Microsoft.XmlSerializer.Generator on the test CLI
The test CLI uses the binaries that were just built as opposed to the tools CLI, which was previously
being used, which contains whatever binaries were in that LKG version of the shared framework.
Commit migrated from https://github.com/dotnet/corefx/commit/
4fcf1420e711cf3025965109e6912c62e60f9f0a
Eric St. John [Tue, 12 Sep 2017 15:55:18 +0000 (08:55 -0700)]
Reuse RuntimeConfig from tests when running dotnet-Microsoft.XmlSerializer.Generator
Commit migrated from https://github.com/dotnet/corefx/commit/
bd567c2fe66ee926f4f537c396da87d291b4f24d
Eric St. John [Fri, 8 Sep 2017 17:47:47 +0000 (10:47 -0700)]
Allow copy-local ReferenceFromRuntime
Tests may want to copy a ReferenceFromRuntime to the test output directory.
To do this, a test can set Private=true (same as you would for a Reference).
By default we don't do this, because anything in the runtime folder will be
part of the shared framework that the test runs on.
In the case of Microsoft.XmlSerializer.Generator it's reference is an
application and the project expects this to be next to the test assembly.
Commit migrated from https://github.com/dotnet/corefx/commit/
a938b3b95063b442981078b9d11ff66296daf51f
David Shulman [Tue, 12 Sep 2017 14:12:24 +0000 (10:12 -0400)]
Fix WinHttpHandler when building certificate chain (dotnet/corefx#23951)
* Fix WinHttpHandler when building certificate chain
Unlike SslStream, WinHttpHandler was not using all the certificates
obtained from the TLS/SSL handshake when building the chain. In
addition to the end-entity server certificate, there were other certs
available in the native cert handle that could be passed along
to the chain build operation.
As part of fixing this, I refactored the Common schannel and crypto
interop code so that it can be used in both SslStream and
WinHttpHandler.
I tested this manually because this cannot be easily tested in the CI
system. Added traces in WinHttpHandler to support this.
Fixes dotnet/corefx#23827
Fixes dotnet/corefx#4473
* Address PR feedback
Check for null IntPtr.
Commit migrated from https://github.com/dotnet/corefx/commit/
dcc29528c9c4633e81b1937e7dd9fde7115a938c
Viktor Hofer [Tue, 12 Sep 2017 10:29:54 +0000 (12:29 +0200)]
Cleanup code in System.Runtime.Serialization.Formatters.Tests (dotnet/corefx#23940)
* Cleanup code in System.Runtime.Serialization.Formatters.Tests
* Moved UnitySerializationHolder serialization test to System.Runtime.Tests
Commit migrated from https://github.com/dotnet/corefx/commit/
705dc4196a6139b70dcf818c109b01aa295edcb1
Maryam Ariyan [Tue, 12 Sep 2017 01:44:17 +0000 (21:44 -0400)]
fixing failure on linux
Commit migrated from https://github.com/dotnet/corefx/commit/
fc03dc4f74da1df872958d4e087e46b38b02f04c
Eric Mellino [Tue, 12 Sep 2017 00:37:20 +0000 (17:37 -0700)]
Better emulate PInvoke exceptions in FunctionWrapper.cs
* Constructing a FunctionWrapper should no longer ever throw an exception.
* Like PInvokes, calling the wrapped delegate may now throw a DllNotFoundException
in addition to an EntryPointNotFoundException. These are now catchable at usage-time,
as expected.
Commit migrated from https://github.com/dotnet/corefx/commit/
a6dbbdb7663c132823191fe6aa118f5134235f73
Maryam Ariyan [Mon, 11 Sep 2017 20:43:38 +0000 (16:43 -0400)]
Applying code review comments
fixes dotnet/corefx#22299 and dotnet/corefx#19956
Commit migrated from https://github.com/dotnet/corefx/commit/
1a22357d316cd39bd4cf163009480ac7689a8ddb
Viktor Hofer [Mon, 11 Sep 2017 23:38:42 +0000 (01:38 +0200)]
Adding dbnull to dbtable (dotnet/corefx#23959)
Commit migrated from https://github.com/dotnet/corefx/commit/
15c191b29a5efb4d5dbc59784feb7af54ddbe8d5
Dan Moseley [Mon, 11 Sep 2017 23:36:08 +0000 (16:36 -0700)]
Rename IsNotWinRT (dotnet/corefx#23963)
* Rename IsNotWinRT
* Remove redundant clause
Commit migrated from https://github.com/dotnet/corefx/commit/
4e529f5ddf30c69815c21211d3b1cc5d0b205070
Eric Mellino [Mon, 11 Sep 2017 23:13:56 +0000 (16:13 -0700)]
Remove a couple of bad assertions in PrinterSettingsTests.cs.
Commit migrated from https://github.com/dotnet/corefx/commit/
7204b1dff4e1b92a8796cace7d5905c48ccb2cdf
Eric Mellino [Mon, 11 Sep 2017 23:08:58 +0000 (16:08 -0700)]
Merge pull request dotnet/corefx#23957 from qmfrederik/drawing/pathgradientbrush-pinvoke
Simplify P/Invoke logic in PathGradientBrush.InterpolationColors and SurroundColors
Commit migrated from https://github.com/dotnet/corefx/commit/
558920119d099ee3b84bd8dcfec4a13c30e723a8
Eric Mellino [Mon, 11 Sep 2017 22:47:48 +0000 (15:47 -0700)]
Merge pull request dotnet/corefx#23958 from qmfrederik/drawing/pen-pinvoke
System.Drawing - Simplify Pen.get_DashPattern P/Invoke code
Commit migrated from https://github.com/dotnet/corefx/commit/
839f044a48f46fef0771e2fd255d061c0a9fcb44
Eric Mellino [Mon, 11 Sep 2017 22:38:05 +0000 (15:38 -0700)]
Move Unix Printing types into regular folder structure.
Commit migrated from https://github.com/dotnet/corefx/commit/
04efcad64f3731801eeabe10661c430ae51aa42a
Eric Mellino [Mon, 11 Sep 2017 22:14:43 +0000 (15:14 -0700)]
Merge pull request dotnet/corefx#23956 from qmfrederik/drawing/pinvoke
System.Drawing - Fix and simplify PathGradientBrush.Blend and GdipSaveImageToFile_delegate PInvoke code
Commit migrated from https://github.com/dotnet/corefx/commit/
3a09bd39562d6af40caaddeb7783976c2755d3a3
Ahson Ahmed Khan [Mon, 11 Sep 2017 21:44:24 +0000 (14:44 -0700)]
Enable S.R.CS.Unsafe and System.Memory tests for UAP (dotnet/corefx#23905)
* Enable S.R.CS.Unsafe and System.Memory tests for UAP
* Disable tests failing on uapaot with issues 23952 and 23953.
* Fixing typo in issue#
Commit migrated from https://github.com/dotnet/corefx/commit/
7b6024a58127ca855823a3f007c76d240f89db64
Ahson Ahmed Khan [Mon, 11 Sep 2017 21:43:44 +0000 (14:43 -0700)]
Adding log message containing actual number of compares for Span API tests (dotnet/corefx#23901)
* Logging actual number of compares on test failures.
* Simplifying log message as per PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
2f83f08a343920e60391bed3b09eb38223e6c78a
Eric Mellino [Mon, 11 Sep 2017 21:32:19 +0000 (14:32 -0700)]
Allow libcups to be absent.
Commit migrated from https://github.com/dotnet/corefx/commit/
359cf6ed31bea58fa5a68841a63f8356b02ce3cc
Eric Mellino [Mon, 11 Sep 2017 21:29:32 +0000 (14:29 -0700)]
Use manually-loaded libcups functions.
Commit migrated from https://github.com/dotnet/corefx/commit/
ea29f0ad53cd14bd2463db7b1a5d365d31393bb9
Frederik Carlier [Mon, 11 Sep 2017 21:29:05 +0000 (23:29 +0200)]
Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6351e27655cc8aec281acdf35e4c9c2397580904
Eric Mellino [Mon, 11 Sep 2017 21:26:49 +0000 (14:26 -0700)]
Fix formatting of FunctionWrapper.Windows.cs.
Commit migrated from https://github.com/dotnet/corefx/commit/
927c89c3f03777047d1b5e2621c24b15321405bb
Frederik Carlier [Mon, 11 Sep 2017 21:14:10 +0000 (23:14 +0200)]
PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
2827f05456d52e4509bb72bf58f20b0c9e5642f2
Eric Mellino [Mon, 11 Sep 2017 20:49:59 +0000 (13:49 -0700)]
Move FunctionWrapper into Common folder.
Commit migrated from https://github.com/dotnet/corefx/commit/
50bafd080289e6ef67cdc77bb19020849eb27b7f
Viktor Hofer [Mon, 11 Sep 2017 20:49:26 +0000 (22:49 +0200)]
DbNull serialization with tests and forward (dotnet/corefx#23897)
* DbNull tests and forward
* UnitySerializationHolder deserialization test added
Commit migrated from https://github.com/dotnet/corefx/commit/
9ab8189268fbc6c4e98f8d10a6753d0477ef3239
Frederik Carlier [Thu, 7 Sep 2017 11:39:20 +0000 (13:39 +0200)]
Save Pen.cs using UTF-8 encoding
Commit migrated from https://github.com/dotnet/corefx/commit/
c75e0a7c6fa4f3075a81f3c2056f478c570f7fdf
Frederik Carlier [Thu, 7 Sep 2017 07:08:54 +0000 (09:08 +0200)]
Pen: Try to replicate exact Desktop System.Drawing behavior, cross-platform.
Commit migrated from https://github.com/dotnet/corefx/commit/
5ebd22464238bc1bd84e635e554c317220d0fc03
Frederik Carlier [Wed, 6 Sep 2017 21:43:31 +0000 (23:43 +0200)]
Further fine-tine the PenTests
Commit migrated from https://github.com/dotnet/corefx/commit/
161d15ecd63d0b67fe66de1af3cb3b37c1af0cad
Frederik Carlier [Wed, 6 Sep 2017 21:30:57 +0000 (23:30 +0200)]
Simplify Pen.get_DashPattern, improve libgdiplus compatibility.
Commit migrated from https://github.com/dotnet/corefx/commit/
22d0801f6bd285c884b4a9649e666b682c88d4e2
Frederik Carlier [Wed, 6 Sep 2017 21:17:19 +0000 (23:17 +0200)]
Simplify PathGradientBrush.set_SurroundColors, to better match Desktop behavior
Replicate the Desktop behavior in PathGradientBrush.set_InterpolationColors
Commit migrated from https://github.com/dotnet/corefx/commit/
8690ad7eefdfd54b59b7e4054f902104792e74c3