Pirama Arumuga Nainar [Thu, 21 Oct 2021 17:56:43 +0000 (10:56 -0700)]
Revert "[compiler-rt/profile] Hide __llvm_profile_raw_version"
This reverts commit
69708477be258dbea2711f6a35c02685659b49d3 to unblock
instrprof-darwin-exports.c failure on MacOS bots.
Craig Topper [Thu, 21 Oct 2021 16:44:59 +0000 (09:44 -0700)]
[RISCV] Expand scalable vector CTTZ/CTLZ/CTPOP.
Differential Revision: https://reviews.llvm.org/D112233
Arthur Eubanks [Thu, 21 Oct 2021 17:48:41 +0000 (10:48 -0700)]
Revert "[IPT] Restructure cache to allow lazy update following invalidation [NFC]"
This reverts commit
baea663a6e9bc52f80995d02bb8149934c825612.
Causes crashes, e.g. https://lab.llvm.org/buildbot/#/builders/77/builds/10715.
Aaron Ballman [Thu, 21 Oct 2021 17:38:02 +0000 (13:38 -0400)]
Add the papers that were applied to the latest C2x working draft
Petr Hosek [Thu, 21 Oct 2021 17:32:01 +0000 (10:32 -0700)]
Revert "[CMake] Cache the compiler-rt library search results"
This reverts commit
0eed292fbae22a8856682b07e1cb968424b49941, there
are compiler-rt build failures that appear to have been introduced
by this change.
Florian Hahn [Thu, 16 Sep 2021 15:49:52 +0000 (16:49 +0100)]
[SLP] Add additional tests which caused crashes with versioning.
River Riddle [Thu, 21 Oct 2021 17:07:18 +0000 (17:07 +0000)]
[mlir:GreedyPatternRewriter] Add debug logging for pattern rewriter actions
This effectively mirrors the logging in dialect conversion, which has proven
very useful for understanding the pattern application process.
Differential Revision: https://reviews.llvm.org/D112120
River Riddle [Thu, 21 Oct 2021 17:07:07 +0000 (17:07 +0000)]
[NFC] Clean up a few methods within GreedyPatternRewriter
Move a few methods out of line and clean up comments.
Ahmed Taei [Wed, 20 Oct 2021 00:56:55 +0000 (17:56 -0700)]
Avoid infinity arithmetics when computing exp approximations
Otherwise this can result a poison value on some platforms see https://bugs.llvm.org/show_bug.cgi?id=51204
Reviewed By: ezhulenev
Differential Revision: https://reviews.llvm.org/D112115
Ben Langmuir [Thu, 21 Oct 2021 17:01:23 +0000 (10:01 -0700)]
[test][ORC-RT] Disable x86_64 tests when target arch does not match
When cross-compiling, these tests will fail. For now leave the host arch
check that was already there since I don't know why it was added.
Valentin Clement [Thu, 21 Oct 2021 16:44:47 +0000 (18:44 +0200)]
[fir] Add Character helper
This patch is extracted from D111337. It introduce the
CharacterExprHelper that helps dealing with character in FIR.
Reviewed By: schweitz, awarzynski
Differential Revision: https://reviews.llvm.org/D112140
Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: V Donaldson <vdonaldson@nvidia.com>
Sanjay Patel [Thu, 21 Oct 2021 16:21:37 +0000 (12:21 -0400)]
[VectorCombine] fold shuffle-of-binops with common operand
shuf (bo X, Y), (bo X, W) --> bo (shuf X), (shuf Y, W)
This is motivated by an example in D111800
(although that patch avoids the problem for that particular example).
The pattern is shown in reduced form with:
https://llvm.org/PR52178
https://alive2.llvm.org/ce/z/d8zB4D
There is no difference on the PhaseOrdering test from D111800
because the aarch64 cost model says that the shuffle cost is 3 while
the fadd cost is 2.
Differential Revision: https://reviews.llvm.org/D111901
Arthur Eubanks [Wed, 6 Oct 2021 20:57:29 +0000 (13:57 -0700)]
Reland [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()
This clears the memory used for the Clang AST before we run LLVM passes.
https://llvm-compile-time-tracker.com/compare.php?from=
d0a5f61c4f6fccec87fd5207e3fcd9502dd59854&to=
b7437fee79e04464dd968e1a29185495f3590481&stat=max-rss
shows significant memory savings with no slowdown (in fact -O0 slightly speeds up).
For more background, see
https://lists.llvm.org/pipermail/cfe-dev/2021-September/068930.html.
Turn this off for the interpreter since it does codegen multiple times.
Relanding with fix for -print-stats: D111973
Relanding with fix for plugins: D112190
If you'd like to use this even with plugins, consider using the features
introduced in D112096.
This can be turned off with -Xclang -no-clear-ast-before-backend.
Differential Revision: https://reviews.llvm.org/D111270
Fraser Cormack [Thu, 21 Oct 2021 14:21:38 +0000 (15:21 +0100)]
[RISCV] Add a test showing incorrect VSETVLI insertion
This test case, reduced from an internal test failure, shows how we may
incorrectly skip the insertion of VSETVLI instructions when doing
cross-basic-block analysis.
The entry block ends in a `e32,mf2`. Its single successor, %bb.1, ends with a
`e8,mf8`, but for a mask-type instruction, so is considered compatible.
This means that the info %bb.1 is merged into its predecessor so
produces a `e32,mf2`. When it comes to the last block, which requires a
`e32,mf2`, we skip the insertion of a vsetvli because all predecessors
were determined to preserve the right vtype.
However, when %bb.1 is actually laid out it does actually need a
`e8,mf8` vsetvli, since the previous instruction has a different tail
policy. This means that when execution flows from %bb.1 to %bb.3, the
`vadd.vx` is misconfigured.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D112223
Philip Reames [Thu, 21 Oct 2021 16:15:08 +0000 (09:15 -0700)]
[IPT] Restructure cache to allow lazy update following invalidation [NFC]
This change restructures the cache used in IPT to point not to the first special instruction, but to the first instruction which *could* be special. That is, the cached reference is always equal to the first special, or comes before it in the block.
This avoids expensive block scans when we are removing special instructions from the beginning of the block. At the moment, this case is not heavily used, though it does trigger in GVN when doing CSE of calls. The main motivation was a change I'm no longer planning to move forward with, but the cache optimization seemed worthwhile as a minor perf win at low cost.
Differential Revision: https://reviews.llvm.org/D111768
Aaron Ballman [Thu, 21 Oct 2021 16:14:44 +0000 (12:14 -0400)]
Update the title and encoding for the C++ status page
Aaron Ballman [Thu, 21 Oct 2021 16:13:19 +0000 (12:13 -0400)]
Update the C++ and C status pages now that Clang 13 has been released
Arthur Eubanks [Wed, 20 Oct 2021 22:43:10 +0000 (15:43 -0700)]
[clang] Don't clear AST if we have consumers running after the main action
Downstream users may have Clang plugins. By default these plugins run
after the main action if they are specified on the command line.
Since these plugins are ASTConsumers, presumably they inspect the AST.
So we shouldn't clear it if any plugins run after the main action.
Reviewed By: dblaikie, hans
Differential Revision: https://reviews.llvm.org/D112190
Ben Langmuir [Wed, 20 Oct 2021 17:37:32 +0000 (10:37 -0700)]
Reapply [ORC-RT] Configure the ORC runtime for more architectures and platforms
Reapply
5692ed0cce8c95, but with the ORC runtime disabled explicitly on
CrossWinToARMLinux to match the other compiler-rt runtime libraries.
Differential Revision: https://reviews.llvm.org/D112229
---
Enable building the ORC runtime for 64-bit and 32-bit ARM architectures,
and for all Darwin embedded platforms (iOS, tvOS, and watchOS). This
covers building the cross-platform code, but does not add TLV runtime
support for the new architectures, which can be added independently.
Incidentally, stop building the Mach-O TLS support file unnecessarily on
other platforms.
Differential Revision: https://reviews.llvm.org/D112111
Kazu Hirata [Thu, 21 Oct 2021 15:58:19 +0000 (08:58 -0700)]
[clang] Use StringRef::contains (NFC)
Yonghong Song [Tue, 21 Sep 2021 00:08:46 +0000 (17:08 -0700)]
[DebugInfo] Support typedef with btf_decl_tag attributes
Clang patch ([1]) added support for btf_decl_tag attributes with typedef
types. This patch added llvm support including dwarf generation.
For example, for typedef
typedef unsigned * __u __attribute__((btf_decl_tag("tag1")));
__u u;
the following shows llvm-dwarfdump result:
0x00000033: DW_TAG_typedef
DW_AT_type (0x00000048 "unsigned int *")
DW_AT_name ("__u")
DW_AT_decl_file ("/home/yhs/work/tests/llvm/btf_tag/t.c")
DW_AT_decl_line (1)
0x0000003e: DW_TAG_LLVM_annotation
DW_AT_name ("btf_decl_tag")
DW_AT_const_value ("tag1")
0x00000047: NULL
[1] https://reviews.llvm.org/D110127
Differential Revision: https://reviews.llvm.org/D110129
Yonghong Song [Tue, 21 Sep 2021 02:53:19 +0000 (19:53 -0700)]
[Clang] Support typedef with btf_decl_tag attributes
Previously, btf_del_tag attribute supports record, field, global variable,
function and function parameter ([1], [2]). This patch added support for typedef.
The main reason is for typedef of an anonymous struct/union, we can only apply
btf_decl_tag attribute to the anonymous struct/union like below:
typedef struct { ... } __btf_decl_tag target_type
In this case, the __btf_decl_tag attribute applies to anonymous struct,
which increases downstream implementation complexity. But if
typedef with btf_decl_tag attribute is supported, we can have
typedef struct { ... } target_type __btf_decl_tag
which applies __btf_decl_tag to typedef "target_type" which make it
easier to directly associate btf_decl_tag with a named type.
This patch permitted btf_decl_tag with typedef types with this reason.
[1] https://reviews.llvm.org/D106614
[2] https://reviews.llvm.org/D111588
Differential Revision: https://reviews.llvm.org/D110127
Mark de Wever [Sun, 10 Oct 2021 13:40:50 +0000 (15:40 +0200)]
[libc++] Use addressof in vector.
This addresses the usage of `operator&` in `<vector>`.
I now added tests for the current offending cases. I wonder whether it
would be better to add one addressof test per directory and test all
possible violations. Also to guard against possible future errors?
(Note there are still more headers with the same issue.)
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D111961
Jez Ng [Thu, 21 Oct 2021 15:23:34 +0000 (11:23 -0400)]
[lld-macho] Simplify lc-linker-option.ll and re-enable it on Windows
While attempting to simplify it, I discovered a concerning discrepancy
between our handling of LC_LINKER_OPTION vs ld64's. In particular, ld64
does not appear to check for `-all_load` nor `-ObjC` when processing
those options. Thus, if/when we fix this behavior, no duplicate symbol
error will be expected regardless of the use-after-free. As such, I've
removed the test logic that tries to induce the duplicate symbol error.
We can just rely on ASAN to do the verification.
In order to make the test run on Windows, I've removed the symlink
logic. Both ld64 and LLD handle this un-symlinked framework just fine.
I also capitalized the framework name, since that's the typical
convention.
Reviewed By: #lld-macho, oontvoo
Differential Revision: https://reviews.llvm.org/D112195
Lang Hames [Wed, 20 Oct 2021 20:51:50 +0000 (13:51 -0700)]
[ORC-RT] Remove stray printf debugging output.
These were accidentally picked up in an earlier commit.
Nicolas Vasilache [Wed, 20 Oct 2021 19:51:21 +0000 (19:51 +0000)]
[mlir][Linalg] Improve conv vectorization for the stride==1 case.
In the stride == 1 case, conv1d reads contiguous data along the input dimension. This can be advantageaously used to bulk memory transfers and compute while avoiding unrolling. Experimentally, this can yield speedups of up to 50%.
Reviewed By: antiagainst
Differential Revision: https://reviews.llvm.org/D112139
Jon Chesterfield [Thu, 21 Oct 2021 15:14:28 +0000 (16:14 +0100)]
[libomptarget][DeviceRTL] Generalise and simplify cmakelists
Step towards building the DeviceRTL for amdgpu.
Mostly replaces cuda-specific toolchain finding logic with the
generic logic currently found in the amdgpu deviceRTL cmake. Also
deletes dead code and changes the default to build on systems
without cuda installed, as the library doesn't use cuda and the
amdgpu-only systems generally won't have cuda installed.
Reviewed By: Meinersbur
Differential Revision: https://reviews.llvm.org/D111983
Sanjay Patel [Thu, 21 Oct 2021 14:37:16 +0000 (10:37 -0400)]
[InstCombine] generalize reassociated Demorgan folds
This updates the recent D112108 /
b92412fb286be26d
to handle the flipped logic ('or') sibling:
https://alive2.llvm.org/ce/z/Y2L6Ch
Sanjay Patel [Thu, 21 Oct 2021 14:07:01 +0000 (10:07 -0400)]
[InstCombine] add tests for DeMorgan with reassociation; NFC
These are direct mutations of the tests added for D112108 -
we should handle the sibling folds for 'or'.
Kirill Bobyrev [Thu, 21 Oct 2021 14:21:10 +0000 (16:21 +0200)]
Do not downcast uint64_t to unsigned in UniqueID hash computation
Context: https://reviews.llvm.org/D110925#inline-1070046
Louis Dionne [Tue, 12 Oct 2021 19:59:08 +0000 (15:59 -0400)]
[runtimes] Properly handle the sysroot/triple/gcc-toolchain
In 395271a, I simplified how we handled the target triple for the
runtimes. However, in doing so, we stopped considering the default
in CMAKE_CXX_COMPILER_TARGET, so we'd use the LLVM_DEFAULT_TARGET_TRIPLE
(which is the host triple) even if CMAKE_CXX_COMPILER_TARGET was specified.
This commit fixes that problem and also refactors the code so that it's
easy to see what the default value is.
The fact that nobody seems to have been broken by this makes me think
that perhaps nobody is using CMAKE_CXX_COMPILER_TARGET to specify the
triple -- but it should still work.
Differential Revision: https://reviews.llvm.org/D111672
Anirudh Prasad [Thu, 21 Oct 2021 13:48:21 +0000 (09:48 -0400)]
[SystemZ][z/OS] Initial implementation for lowerCall on z/OS
- This patch provides the initial implementation for lowering a call on z/OS according to the XPLINK64 calling convention
- A series of changes have been made to SystemZCallingConv.td to account for these additional XPLINK64 changes including adding a new helper function to shadow the stack along with allocation of a register wherever appropriate
- For the cases of copying a f64 to a gr64 and a f128 / 128-bit vector type to a gr64, a `CCBitConvertToType` has been added and has been bitcasted appropriately in the lowering phase
- Support for the ADA register (R5) will be provided in a later patch.
Reviewed By: uweigand
Differential Revision: https://reviews.llvm.org/D111662
Sanjay Patel [Thu, 21 Oct 2021 13:06:37 +0000 (09:06 -0400)]
[DAGCombiner] fold bit-hack form of usubsat
(i8 X ^ 128) & (i8 X s>> 7) --> usubsat X, 128
I haven't found a generalization of this identity:
https://alive2.llvm.org/ce/z/_sriEQ
Note: I was actually looking at the first form of the pattern in that link,
but that's part of a long chain of potential missed transforms in codegen
and IR....that I hope ends here!
The predicates for when this is profitable are a bit tricky. This version of
the patch excludes multi-use but includes custom lowering (as opposed to
legal only).
On x86 for example, we have custom lowering for some vector types, and that
uses umax and sub. So to enable that fold, we need add use checks to avoid
regressions. Even with legal-only lowering, we could see code with extra
reg move instructions for extra uses, so that constraint would have to be
eased very carefully to avoid penalties.
Differential Revision: https://reviews.llvm.org/D112085
Anirudh Prasad [Thu, 21 Oct 2021 13:45:33 +0000 (09:45 -0400)]
[SystemZ][z/OS] Additional test coverage for validating dialect instructions for SystemZ
- There are certain instructions most notably those with extended mnemonics that restricted to only the gnu/att variant
- There are also certain instruction aliases/mnemonic aliases that are restricted only to the HLASM variant (see https://reviews.llvm.org/D97581, https://reviews.llvm.org/D94250 and https://reviews.llvm.org/D92185 for reference)
- This patch adds a few tests to check for the behaviour introduced in the above patches. The testing coverage could not be added in at the same time, due to parallel work being done introducing the HLASM syntax
Reviewed By: uweigand, abhina.sreeskantharajan
Differential Revision: https://reviews.llvm.org/D112172
Alexey Bataev [Wed, 15 Sep 2021 14:47:17 +0000 (07:47 -0700)]
[SLP]Unify vectorization of PHI and store nodes with improved tiny tree vectorization.
Vectorization of PHIs and stores very similar, it might be beneficial to
try to revectorize stores (like PHIs) if the total number of stores with
the same/alternate opcode is less than the vector size but number of
stores with the same type is larger than the vector size.
Differential Revision: https://reviews.llvm.org/D109831
Matthias Springer [Thu, 21 Oct 2021 13:16:36 +0000 (22:16 +0900)]
[mlir][linalg][bufferize] Fix bufferizesToMemoryWrite for TiledLoopOp
This is the same fix as for scf.for.
Differential Revision: https://reviews.llvm.org/D112218
Matthias Springer [Thu, 21 Oct 2021 12:54:54 +0000 (21:54 +0900)]
[mlir][linalg][bufferize] Fix bug in getInplaceableOpResult
Differential Revision: https://reviews.llvm.org/D112123
Matthias Springer [Thu, 21 Oct 2021 12:45:34 +0000 (21:45 +0900)]
[mlir][linalg][bufferize] Avoid creating copies that are never read
Differential Revision: https://reviews.llvm.org/D111956
Matthias Springer [Thu, 21 Oct 2021 12:33:07 +0000 (21:33 +0900)]
[mlir][linalg][bufferize] Eliminate InitTensorOps of InsertSliceOp sources
An InitTensorOp is replaced with an ExtractSliceOp on the InsertSliceOp's destination. This optimization is applied after analysis and only to InsertSliceOps that were decided to bufferize inplace. Another analysis on the new ExtractSliceOp is needed after the rewrite.
Differential Revision: https://reviews.llvm.org/D111955
Jon Chesterfield [Thu, 21 Oct 2021 12:09:55 +0000 (13:09 +0100)]
Relax assert in ExprConstant to a return None.
Fixes a compiler assert on passing a compile time integer to atomic builtins.
Assert introduced in D61522
Function changed from ->bool to ->Optional in D76646
Simplifies call sites to getIntegerConstantExpr to elide the now-redundant
isValueDependent checks.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D112159
Jan Svoboda [Thu, 21 Oct 2021 11:10:18 +0000 (13:10 +0200)]
[clang][deps] Make resource directory deduction configurable
The `clang-scan-deps` CLI tool invokes the compiler with `-print-resource-dir` in case the `-resource-dir` argument is missing from the compilation command line. This is to enable running the tool on compilation databases that use compiler from a different toolchain than `clang-scan-deps` itself. While this doesn't make sense when scanning modular builds (due to the `-cc1` arguments the tool generates), the tool can can be used to efficiently scan for file dependencies of non-modular builds too.
This patch stops deducing the resource directory by invoking the compiler by default. This mode can still be enabled by invoking `clang-scan-deps` with `--resource-dir-recipe invoke-compiler`. The new default is `--resource-dir-recipe modify-compiler-path` which relies on the resource directory deduction taking place in `Driver::Driver` which is based on the compiler path. This makes the default more aligned with the intended usage of the tool while still allowing it to serve other use-cases.
Note that this functionality was also influenced by D108979, where the dependency scanner stopped going through `ClangTool::run`. The function tried to deduce the resource directory based on the current executable path, which might not be what the users expect when invoked from within a shared library.
Depends on D108979.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D108366
Pavel Labath [Thu, 21 Oct 2021 12:01:24 +0000 (14:01 +0200)]
[lldb] Fix a thinko in
2ace1e57
An empty plugin name means we should try everything.
Picked up by the windows bot.
Kerry McLaughlin [Thu, 21 Oct 2021 10:30:31 +0000 (11:30 +0100)]
[SVE] Fix selection failure when splitting extended masked loads
When splitting a masked load, `GetDependentSplitDestVTs` is used to get the
MemVTs of the high and low parts. If the masked load is extended, this
may return VTs with different element types which are used to create the
high & low masked load instructions.
This patch changes `GetDependentSplitDestVTs` to ensure we return VTs with
the same element type.
Reviewed By: david-arm
Differential Revision: https://reviews.llvm.org/D111996
YunQiang Su [Thu, 21 Oct 2021 07:46:22 +0000 (10:46 +0300)]
[MIPS] Fix switching between 32/64-bit variants of r6 target triples
If clang driver gets 64-bit r6 target triple like `mipsisa64r6` and
additional option forces switching to generation of 32-bit code, it
loses r6 abi and generates 32-bit r2-r5 abi code.
```
$ clang -target mipsisa64r6-linux-gnu -mabi=32
```
This patch fixes the problem.
- Add optional `SubArchType` argument to the `Triple::setArch()` method.
- Implement generation of mips r6 target triples in the
`Triple::getArchName()` method.
Differential Revision: https://reviews.llvm.org/D110514.diff
David Green [Thu, 21 Oct 2021 12:03:18 +0000 (13:03 +0100)]
[ARM] Add new abs test. NFC
Jan Svoboda [Thu, 21 Oct 2021 11:51:22 +0000 (13:51 +0200)]
[clang][deps] NFC: Rename building CompilerInvocation
The dependency scanner works with multiple instances of `Compiler{Instance,Invocation}`. From names of the variables/members, their purpose is not obvious.
This patch gives descriptive name to the generated `CompilerInvocation` that can be used to derive the command-line to build a modular dependency.
Depends on D111725.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D111728
Jan Svoboda [Thu, 21 Oct 2021 11:50:57 +0000 (13:50 +0200)]
[clang][deps] NFC: Rename scanning CompilerInstance
The dependency scanner works with multiple instances of `Compiler{Instance,Invocation}`. From names of the variables/members, their purpose is not obvious.
This patch gives a distinct name to the `CompilerInstance` that's used to run the implicit build during dependency scan.
Depends on D111724.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D111725
Jan Svoboda [Thu, 21 Oct 2021 11:50:42 +0000 (13:50 +0200)]
[clang][deps] NFC: Remove redundant CompilerInstance reference
The `ModuleDepCollectorPP` class holds a reference to `ModuleDepCollector` as well as `ModuleDepCollector`'s `CompilerInstance`. The fact that these refer to the same object is non-obvious.
This patch removes the `CompilerInvocation` reference from `ModuleDepCollectorPP` and accesses it through `ModuleDepCollector` instead.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D111724
Jan Svoboda [Thu, 21 Oct 2021 11:28:05 +0000 (13:28 +0200)]
[clang][deps] Ensure reported context hash is strict
One of main goals of the dependency scanner is to be strict about module compatibility. This is achieved through strict context hash. This patch ensures that strict context hash is enabled not only during the scan itself (and its minimized implicit build), but also when actually reporting the dependency.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D111720
Aaron Ballman [Thu, 21 Oct 2021 11:08:18 +0000 (07:08 -0400)]
Revert "AddGlobalAnnotations for function with or without function body."
This reverts commit
121b2252de0eed68f2ddf5f09e924a6c35423d47.
The following code causes a crash in some circumstances:
struct k {
~k() __attribute__((annotate(""))) {}
};
void m() { k(); }
Benjamin Kramer [Thu, 21 Oct 2021 10:58:10 +0000 (12:58 +0200)]
[lldb] Silence -Wpessimizing-move warning
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3635:10: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
return std::move(merged);
^
Pavel Labath [Mon, 18 Oct 2021 08:39:58 +0000 (10:39 +0200)]
[lldb] Remove ConstString from GetPluginNameStatic of some plugins
This patch deals with ObjectFile, ObjectContainer and OperatingSystem
plugins. I'll convert the other types in separate patches.
In order to enable piecemeal conversion, I am leaving some ConstStrings
in the lowest PluginManager layers. I'll convert those as the last step.
Differential Revision: https://reviews.llvm.org/D112061
Benjamin Kramer [Thu, 21 Oct 2021 09:57:16 +0000 (11:57 +0200)]
[mlir] Fix a crash when creating a 1d zero element LLVM constant
Fixes a regression introduced in
f9be7a7afda3c90b99c9f50e5eff1624da5a6511
Differential Revision: https://reviews.llvm.org/D112208
Adrian Kuegel [Thu, 21 Oct 2021 10:45:37 +0000 (12:45 +0200)]
[mlir] Use empty() calls where possible.
These are based on findings from the ClangTidy
readability-container-size-empty check.
Jaroslav Sevcik [Sat, 25 Sep 2021 17:29:04 +0000 (19:29 +0200)]
[lldb] Add omitted abstract formal parameters in DWARF symbol files
This patch fixes a problem introduced by clang change
https://reviews.llvm.org/D95617 and described by
https://bugs.llvm.org/show_bug.cgi?id=50076#c6, where inlined functions
omit unused parameters both in the stack trace and in `frame var`
command. With this patch, the parameters are listed correctly in the
stack trace and in `frame var` command.
Specifically, we parse formal parameters from the abstract version of
inlined functions and use those formal parameters if they are missing
from the concrete version.
Differential Revision: https://reviews.llvm.org/D110571
Dawid Jurczak [Thu, 21 Oct 2021 10:07:07 +0000 (12:07 +0200)]
[NFC][LoopIdiom] Make for loops more readable
Patch simplifies for loops in LIR following LLVM guidelines: https://llvm.org/docs/CodingStandards.html#use-range-based-for-loops-wherever-possible.
Differential Revision: https://reviews.llvm.org/D112077
Mikhail Maltsev [Thu, 21 Oct 2021 09:40:05 +0000 (10:40 +0100)]
[libcxx] Throw correct exception from std::vector::reserve
According to the standard [vector.capacity]/5, std::vector<T>::reserve
shall throw an exception of type std::length_error when the requested
capacity exceeds max_size().
This behavior is not implemented correctly: the function 'reserve'
simply propagates the exception from allocator<T>::allocate. Before
D110846 that exception used to be of type std::length_error (which is
correct for vector<T>::reserve, but incorrect for
allocator<T>::allocate).
This patch fixes the issue and adds regression tests.
Reviewed By: Quuxplusone, ldionne, #libc
Differential Revision: https://reviews.llvm.org/D112068
Mikhail Maltsev [Thu, 21 Oct 2021 09:38:56 +0000 (10:38 +0100)]
[libcxx] Support allocators with explicit c-tors in vector<bool>
std::vector<bool> rebinds the supplied allocator to construct objects
of type '__storage_type' rather than 'bool'. Allocators are allowed to
use explicit conversion constructors, so care must be taken when
performing conversions.
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D112150
Valentin Clement [Thu, 21 Oct 2021 09:36:10 +0000 (11:36 +0200)]
Revert "[fir] Add Character helper"
This reverts commit
e4ce92245c96cea9492767d7149eb9e30dee0d16.
Buildbots not happy with the tests.
Frederic Cambus [Thu, 21 Oct 2021 09:18:52 +0000 (11:18 +0200)]
[clang] Support __float128 on DragonFlyBSD.
Differential Revision: https://reviews.llvm.org/D111760
Frederic Cambus [Thu, 21 Oct 2021 09:10:18 +0000 (11:10 +0200)]
[docs] Fix broken link rendering in the LLVM Coding Standards.
Michał Górny [Thu, 21 Oct 2021 09:08:05 +0000 (11:08 +0200)]
[lldb] [Host/SerialPort] Add std::moves for better compatibility
Michał Górny [Thu, 21 Oct 2021 09:00:17 +0000 (11:00 +0200)]
[lldb] [Host/Terminal] Add missing #ifdef for baudRateToConst()
Michał Górny [Thu, 21 Oct 2021 08:54:02 +0000 (10:54 +0200)]
[lldb] [unittest] Disable SetParity() tests on Linux entirely
Attempting to enable PARENB causes tcsetattr() to fail on the Debian
and Ubuntu buildbots, so let's skip these tests on Linux entirely.
Michał Górny [Thu, 7 Oct 2021 21:14:23 +0000 (23:14 +0200)]
[lldb] Add serial:// protocol for connecting to serial port
Add a new serial:// protocol along with SerialPort that provides a new
API to open serial ports. The URL consists of serial device path
followed by URL-style options, e.g.:
serial:///dev/ttyS0?baud=115200&parity=even
If no options are provided, the serial port is only set to raw mode
and the other attributes remain unchanged. Attributes provided via
options are modified to the specified values. Upon closing the serial
port, its original attributes are restored.
Differential Revision: https://reviews.llvm.org/D111355
Evgeniy Brevnov [Wed, 20 Oct 2021 09:42:19 +0000 (16:42 +0700)]
[NARY-REASSOCIATE][NFC] Simplify min/max handling
In order to explore different variants of reassociation current implementation uses "swap in a loop" approach. Unfortunately, the implementation is more complicated than it could be. This is an attempt to streamline the code. New approach is to extract core functionality into a helper function and call it explicitly as many times as required.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D112128
Matthias Springer [Thu, 21 Oct 2021 08:29:02 +0000 (17:29 +0900)]
[mlir][linalg][bufferize][NFC] Change findValueInReverseUseDefChain signature
This commit is in preparation for scf.if support.
* `condition` in findValueInReverseUseDefChain takes a Value instead of OpOperand*.
* Return a SetVector<Value> instead of a single Value. This SetVector always contains exactly one Value at the moment.
Differential Revision: https://reviews.llvm.org/D111928
David Sherwood [Wed, 22 Sep 2021 09:54:05 +0000 (10:54 +0100)]
[SVE][Analysis] Tune the cost model according to the tune-cpu attribute
This patch introduces a new function:
AArch64Subtarget::getVScaleForTuning
that returns a value for vscale that can be used for tuning the cost
model when using scalable vectors. The VScaleForTuning option in
AArch64Subtarget is initialised according to the following rules:
1. If the user has specified the CPU to tune for we use that, else
2. If the target CPU was specified we use that, else
3. The tuning is set to "generic".
For CPUs of type "generic" I have assumed that vscale=2.
New tests added here:
Analysis/CostModel/AArch64/sve-gather.ll
Analysis/CostModel/AArch64/sve-scatter.ll
Transforms/LoopVectorize/AArch64/sve-strict-fadd-cost.ll
Differential Revision: https://reviews.llvm.org/D110259
Michał Górny [Sun, 3 Oct 2021 18:25:01 +0000 (20:25 +0200)]
[lldb] [Host] Add setters for common teletype properties to Terminal
Add setters for common teletype properties to the Terminal class:
- SetRaw() to enable common raw mode options
- SetBaudRate() to set the baud rate
- SetStopBits() to select the number of stop bits
- SetParity() to control parity bit in the output
- SetHardwareControlFlow() to enable or disable hardware control flow
(if supported)
Differential Revision: https://reviews.llvm.org/D111030
Peixin-Qiao [Thu, 21 Oct 2021 08:30:46 +0000 (16:30 +0800)]
[MLIR][OpenMP] Add support for ordered construct
This patch supports the ordered construct in OpenMP dialect following
Section 2.19.9 of the OpenMP 5.1 standard. Also lowering to LLVM IR
using OpenMP IRBduiler. Lowering to LLVM IR for ordered simd directive
is not supported yet since LLVM optimization passes do not support it
for now.
Reviewed By: kiranchandramohan, clementval, ftynse, shraiysh
Differential Revision: https://reviews.llvm.org/D110015
Matthias Springer [Thu, 21 Oct 2021 08:23:15 +0000 (17:23 +0900)]
[mlir][linalg][bufferize][NFC] Check return value of getResultBuffer
In a subsequent commit, getResultBuffer can return a "null" Value. This is the case when the returned buffer from an scf.if is not unique.
This commit is in preparation for scf.if support to keep the next commit smaller.
Differential Revision: https://reviews.llvm.org/D111927
Matthias Springer [Thu, 21 Oct 2021 08:00:31 +0000 (17:00 +0900)]
[mlir][linalg][bufferize] Bufferize using PostOrder traversal
This is required for bufferization of scf::IfOp, which is added in a subsequent commit.
Some ops (scf::ForOp, TiledLoopOp) require PreOrder traversal to make sure that bbArgs are mapped before bufferizing the loop body.
Differential Revision: https://reviews.llvm.org/D111924
Raphael Isemann [Thu, 21 Oct 2021 08:01:02 +0000 (10:01 +0200)]
[lldb][NFC] clang-format CPlusPlusLanguage.cpp
Valentin Clement [Thu, 21 Oct 2021 07:47:33 +0000 (09:47 +0200)]
[fir] Add Character helper
This patch is extracted from D111337. It introduce the
CharacterExprHelper that helps dealing with character in FIR.
Reviewed By: schweitz, awarzynski
Differential Revision: https://reviews.llvm.org/D112140
Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: V Donaldson <vdonaldson@nvidia.com>
eopXD [Sat, 16 Oct 2021 16:11:44 +0000 (09:11 -0700)]
[NFC][LoopIdiom] Add more test case to runtime-determined memset size
This patch supplements missing test case for D107353.
- Fix wrong descriptions in 64-bit mode test case
- Added testcase under 32-bit mode
Reviewed By: bmahjour
Differential Revision: https://reviews.llvm.org/D108507
Daniel Jalkut [Thu, 21 Oct 2021 06:52:07 +0000 (12:22 +0530)]
[LLDB] [NFC] Typo fix in usage text for "type filter" command
When you invoke "help type filter" the resulting help shows:
Syntax: type synthetic [<sub-command-options>]
This patch fixes the help so it says "type filter" instead of "type synthetic".
patch by: "Daniel Jalkut <jalkut@red-sweater.com>"
Reviewed By: teemperor
Differential Revision: https://reviews.llvm.org/D112199
Yi Kong [Thu, 21 Oct 2021 05:56:14 +0000 (13:56 +0800)]
[opt-viewer] Use safe yaml load_all
Differential Revision: https://reviews.llvm.org/D112075
Mehdi Amini [Thu, 21 Oct 2021 04:53:45 +0000 (04:53 +0000)]
Revert "[MLIR][OpenMP] Add support for ordered construct"
This reverts commit
dc2be87ecf10f2f1cf05f638a72256387c78f1c1.
Seems like this broke all the CI bots.
Igor Kudrin [Thu, 21 Oct 2021 04:37:52 +0000 (11:37 +0700)]
[ELF] Avoid adding an orphan section to a less suitable segment
If segments are defined in a linker script, placing an orphan section
before the found closest-rank section can result in adding it in a
previous segment and changing flags of that segment. This happens if
the orphan section has a lower sort rank than the found section. To
avoid that, the patch forces orphan sections to be moved after the
found section if segments are explicitly defined.
Differential Revision: https://reviews.llvm.org/D111717
Vitaly Buka [Thu, 21 Oct 2021 03:44:41 +0000 (20:44 -0700)]
[NFC][msan] Add NormalArgAfterNoUndef testcase
Vitaly Buka [Thu, 21 Oct 2021 03:24:11 +0000 (20:24 -0700)]
[NFC][msan] Rerun update_test_checks.py for a test
Vitaly Buka [Thu, 21 Oct 2021 03:00:10 +0000 (20:00 -0700)]
[NFC][msan] Break the loop when done
We have nothing to do after the Argument
is found.
Vy Nguyen [Sat, 25 Sep 2021 01:39:30 +0000 (21:39 -0400)]
[lld-macho][nfc] Added some notes on deliberate differences btw LD64 vs LLD-MACHO
For future references and to help with debugging crashes, this could be useful.
Differential Revision: https://reviews.llvm.org/D110464
Shengchen Kan [Wed, 20 Oct 2021 09:11:08 +0000 (17:11 +0800)]
[Codegen] Set ARITH_FENCE as meta-instruction
ARITH_FENCE, which was added by https://reviews.llvm.org/D99675,
should be a meta-instruction b/c it only emits comments "ARITH_FENCE".
Reviewed By: pengfei, LuoYuanke
Differential Revision: https://reviews.llvm.org/D112127
Volodymyr Sapsai [Wed, 22 Sep 2021 19:37:46 +0000 (12:37 -0700)]
[modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.
While working on https://reviews.llvm.org/D110280 I've tried to merge
decl contexts as it seems to be correct and matching our handling of
decl contexts from different modules. It's not required for the fix in
https://reviews.llvm.org/D110280 but it revealed a missing diagnostic,
so separating this change into a separate commit.
Renamed some variables to distinguish diagnostic like "declaration of
'x' does not match" for different cases.
Differential Revision: https://reviews.llvm.org/D110287
Peixin-Qiao [Thu, 21 Oct 2021 01:16:04 +0000 (09:16 +0800)]
[MLIR][OpenMP] Add support for ordered construct
This patch supports the ordered construct in OpenMP dialect following
Section 2.19.9 of the OpenMP 5.1 standard. Also lowering to LLVM IR
using OpenMP IRBduiler. Lowering to LLVM IR for ordered simd directive
is not supported yet since LLVM optimization passes do not support it
for now.
Reviewed By: kiranchandramohan, clementval, ftynse, shraiysh
Differential Revision: https://reviews.llvm.org/D110015
Brad Smith [Thu, 21 Oct 2021 00:59:46 +0000 (20:59 -0400)]
[Driver][OpenBSD] Some improvements to the external assembler handling
- Pass CPU variant for ARM
- Pass MIPS CPU in addition to the ABI
Craig Topper [Thu, 21 Oct 2021 00:29:02 +0000 (17:29 -0700)]
[ARM] Use correct name of floating point ceil intrinsic in test.
The intrinsic is called llvm.ceil not llvm.fceil. The checks weren't
strong enough to notice that a call to llvm.fceil was emitted in
the final assembly.
Nikita Malyavin [Wed, 20 Oct 2021 23:53:50 +0000 (16:53 -0700)]
[msan] Add stat-family interceptors on Linux
Add following interceptors on Linux: stat, lstat, fstat, fstatat.
This fixes use-of-uninitialized value on platforms with GLIBC 2.33+.
In particular: Arch Linux, Ubuntu hirsute/impish.
The tests should have also been failing during the release on the mentioned platforms, but I cannot find any related discussion.
Most likely, the regression was introduced by glibc commit [[ https://github.com/bminor/glibc/commit/
8ed005daf0ab03e142500324a34087ce179ae78e |
8ed005daf0ab03e14250032 ]]:
all stat-family functions are now exported as shared functions.
Before, some of them (namely stat, lstat, fstat, fstatat) were provided as a part of libc_noshared.a and called their __xstat dopplegangers. This is still true for Debian Sid and earlier Ubuntu's. stat interceptors may be safely provided for them, no problem with that.
Closes https://github.com/google/sanitizers/issues/1452.
See also https://jira.mariadb.org/browse/MDEV-24841
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D111984
Jez Ng [Thu, 21 Oct 2021 00:04:37 +0000 (20:04 -0400)]
[lld-macho] Temporarily disable lc-linker-option.ll on Windows
It's currently using a symlink, which is not supported on Windows.
Arthur Eubanks [Tue, 12 Oct 2021 01:51:37 +0000 (18:51 -0700)]
[SelectionDAG] Bail out of mergeTruncStores when not optimizing
With unoptimized code, we may see lots of stores and spend too much time in mergeTruncStores.
Fixes PR51827.
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D111596
Pavel Kosov [Wed, 20 Oct 2021 23:39:01 +0000 (02:39 +0300)]
[ARM] Fix inline assembly referencing floating point registers on soft-float targets
Fixes PR: https://bugs.llvm.org/show_bug.cgi?id=52230
Reviewed By: nickdesaulniers
Differential Revision: https://reviews.llvm.org/D112135
OS Laboratory, Huawei Russian Research Institute, Saint-Petersburg
Ben Langmuir [Wed, 20 Oct 2021 22:32:06 +0000 (15:32 -0700)]
Revert "[ORC-RT] Configure the ORC runtime for more architectures and platforms"
Broke on aarch64-linux. Reverting while I investigate.
This reverts commit
5692ed0cce8c9506eef40ffe6ca2d9629956c51c.
Louis Dionne [Wed, 20 Oct 2021 21:43:55 +0000 (17:43 -0400)]
[runtimes] Rename CI job from "Runtimes build" to "Bootstrapping build"
Louis Dionne [Wed, 20 Oct 2021 21:40:23 +0000 (17:40 -0400)]
[libunwind] Revert "Use the from-scratch testing configuration by default"
This reverts commit
5a8ad80b6fa5cbad58b78384f534b78fca863e7f, which broke
the Bootstrapping build. I'm reverting until we've fixed the issue.
Differential Revision: https://reviews.llvm.org/D112082
Louis Dionne [Wed, 20 Oct 2021 21:36:13 +0000 (17:36 -0400)]
[libc++abi] Guard include of <unistd.h> behind __has_include
This doesn't change anything on platforms that have <unistd.h>, but
it will allow this file to compile on platforms that do not.
Nikita Popov [Wed, 20 Oct 2021 20:15:51 +0000 (22:15 +0200)]
[Tests] Add tests for non-speculatable ephemeral values
The loads in these examples are currently not considered ephemeral
because they are not speculatable.
Valentin Clement [Wed, 20 Oct 2021 20:43:13 +0000 (22:43 +0200)]
Revert "[fir] Add Character helper"
This reverts commit
02d7089c239075a5c2e148087d2824d253fc3d5f.
Sanjay Patel [Wed, 20 Oct 2021 20:09:15 +0000 (16:09 -0400)]
[x86] add special-case lowering for usubsat for AVX512
This is a small extension of D112095 to avoid another regression
seen with D112085.
In this case, we allow the same conversion from usubsat to ALU
ops if the target supports vpternlog.
That pattern will get converted later in X86DAGToDAGISel::tryVPTERNLOG().
This seems better than putting a magic immediate constant directly in
this code to create the exact vpternlog that we need. It's possible that
there are other special-cases along these lines, so we should try to
keep all of the vpternlog magic in one place.
Differential Revision: https://reviews.llvm.org/D112138
Louis Dionne [Wed, 20 Oct 2021 20:24:55 +0000 (16:24 -0400)]
[libc++] Fix incorrect main() signatures in the tests
Those creep up from time to time. We need to use `int main(int, char**)`
because in freestanding mode, `main` doesn't get special treatment and
special mangling, so we setup a symbol alias from the mangled version of
`main(int, char**)` to `extern "C" main`. That only works if all the tests
are consistent about how they define their main function.