platform/upstream/curl.git
19 years agoUse the same work-around for the memdebug stuff as in the command line client,
Daniel Stenberg [Thu, 27 Jan 2005 22:40:56 +0000 (22:40 +0000)]
Use the same work-around for the memdebug stuff as in the command line client,
to allow the contents of the env var decide the file name.

19 years agoa slightly involved work-around to prevent the debug-tracing from logging
Daniel Stenberg [Thu, 27 Jan 2005 15:59:01 +0000 (15:59 +0000)]
a slightly involved work-around to prevent the debug-tracing from logging
a free-without-alloc as the first call

19 years agoMake the debug build get the debug dump file path from the environment
Daniel Stenberg [Thu, 27 Jan 2005 15:51:03 +0000 (15:51 +0000)]
Make the debug build get the debug dump file path from the environment
variable to allow the test suite to better control where it ends up.

19 years agoverify a part of the PORT line
Daniel Stenberg [Thu, 27 Jan 2005 12:59:40 +0000 (12:59 +0000)]
verify a part of the PORT line

19 years agoMake the server ignore the given PORT address, to make it possible to test
Daniel Stenberg [Wed, 26 Jan 2005 23:18:31 +0000 (23:18 +0000)]
Make the server ignore the given PORT address, to make it possible to test
curl's -P option easier.

19 years agoadded more official web and download mirrors
Daniel Stenberg [Wed, 26 Jan 2005 12:05:33 +0000 (12:05 +0000)]
added more official web and download mirrors

19 years agonew curlpp URL
Daniel Stenberg [Wed, 26 Jan 2005 11:53:49 +0000 (11:53 +0000)]
new curlpp URL

19 years agofixed sort, mention C, the java binding is now maintained by Vic Hanson
Daniel Stenberg [Wed, 26 Jan 2005 11:53:12 +0000 (11:53 +0000)]
fixed sort, mention C, the java binding is now maintained by Vic Hanson

19 years agoadd number to the bugs to make them easier to refer to
Daniel Stenberg [Tue, 25 Jan 2005 23:40:35 +0000 (23:40 +0000)]
add number to the bugs to make them easier to refer to

19 years agotwo known bugs
Daniel Stenberg [Tue, 25 Jan 2005 22:21:42 +0000 (22:21 +0000)]
two known bugs

19 years agoIan Ford asked about support for the FTP command ACCT, and I discovered it is
Daniel Stenberg [Tue, 25 Jan 2005 22:13:12 +0000 (22:13 +0000)]
Ian Ford asked about support for the FTP command ACCT, and I discovered it is
present in RFC959... so now (lib)curl supports it as well. --ftp-account and
CURLOPT_FTP_ACCOUNT set the account string. (The server may ask for an account
string after PASS have been sent away. The client responds with "ACCT [account
string]".) Added test case 228 and 229 to verify the functionality. Updated
the test FTP server to support ACCT somewhat.

19 years agoA minor "syntax error" in numerous test files corrected
Daniel Stenberg [Tue, 25 Jan 2005 21:45:03 +0000 (21:45 +0000)]
A minor "syntax error" in numerous test files corrected

19 years agonew web mirror
Daniel Stenberg [Tue, 25 Jan 2005 13:59:48 +0000 (13:59 +0000)]
new web mirror

19 years ago--protocols is added in 7.13.0
Daniel Stenberg [Tue, 25 Jan 2005 12:06:12 +0000 (12:06 +0000)]
--protocols is added in 7.13.0

19 years agoDavid Shaw contributed a fairly complete and detailed autoconf macro you can
Daniel Stenberg [Tue, 25 Jan 2005 09:29:05 +0000 (09:29 +0000)]
David Shaw contributed a fairly complete and detailed autoconf macro you can
use to detect libcurl and setup variables for the protocols the installed
libcurl supports: docs/libcurl/libcurl.m4

19 years agoUse plain structs and not typedef'ed ones in the hash and linked-list code.
Daniel Stenberg [Tue, 25 Jan 2005 00:06:29 +0000 (00:06 +0000)]
Use plain structs and not typedef'ed ones in the hash and linked-list code.

19 years agotwo options less
Daniel Stenberg [Sun, 23 Jan 2005 00:08:56 +0000 (00:08 +0000)]
two options less

19 years ago\fI marked \fP more function calls etc.
Daniel Stenberg [Sat, 22 Jan 2005 22:43:04 +0000 (22:43 +0000)]
\fI marked \fP more function calls etc.

19 years agoIf you're using libcurl as a win32 DLL, you MUST use the CURLOPT_WRITEFUNCTION
Daniel Stenberg [Sat, 22 Jan 2005 22:24:17 +0000 (22:24 +0000)]
If you're using libcurl as a win32 DLL, you MUST use the CURLOPT_WRITEFUNCTION
if you set CURLOPT_WRITEDATA - or you will experience crashes.

19 years agonext release will be 7.13.0
Daniel Stenberg [Sat, 22 Jan 2005 19:26:37 +0000 (19:26 +0000)]
next release will be 7.13.0

19 years agoadded a few items I plan to do
Daniel Stenberg [Sat, 22 Jan 2005 09:03:55 +0000 (09:03 +0000)]
added a few items I plan to do

19 years agoFTP third transfer support overhaul. See CHANGES for details.
Daniel Stenberg [Fri, 21 Jan 2005 09:32:32 +0000 (09:32 +0000)]
FTP third transfer support overhaul. See CHANGES for details.

19 years agoclarify the struct name for CURLOPT_HTTPPOST
Daniel Stenberg [Fri, 21 Jan 2005 08:56:04 +0000 (08:56 +0000)]
clarify the struct name for CURLOPT_HTTPPOST

19 years agoAdded support for "verify" => "stripfile" to strip contents of the file that
Daniel Stenberg [Thu, 20 Jan 2005 22:48:43 +0000 (22:48 +0000)]
Added support for "verify" => "stripfile" to strip contents of the file that
is being checked.

Also made the server retrying sleep only one second instead of three, to reduce
some waiting when fooling around with the servers.

19 years agoSupport file names passed to RETR that don't start with a number. In that
Daniel Stenberg [Thu, 20 Jan 2005 22:47:31 +0000 (22:47 +0000)]
Support file names passed to RETR that don't start with a number. In that
case, all non-numeric prefixing letters are cut off to figure out the test
number.

19 years agoPhilippe Hameau found out that -Q "+[command]" didn't work, although some code
Daniel Stenberg [Thu, 20 Jan 2005 22:22:12 +0000 (22:22 +0000)]
Philippe Hameau found out that -Q "+[command]" didn't work, although some code
was written for it. I fixed and added test case 227 to verify it.  The curl.1
man page didn't mention the '+' so I added it.

19 years agoadd support for NOOP
Daniel Stenberg [Thu, 20 Jan 2005 22:05:44 +0000 (22:05 +0000)]
add support for NOOP

19 years agoIf you give a *_LARGE option you MUST make sure that the type of the passed-in
Daniel Stenberg [Thu, 20 Jan 2005 14:24:56 +0000 (14:24 +0000)]
If you give a *_LARGE option you MUST make sure that the type of the passed-in
argument is a curl_off_t. If you use CURLOPT_INFILESIZE (without _LARGE) you
must make sure that to pass in a type 'long' argument. */

19 years agoadded test226 too
Daniel Stenberg [Wed, 19 Jan 2005 22:00:54 +0000 (22:00 +0000)]
added test226 too

19 years agoStephan Bergmann made libcurl return CURLE_URL_MALFORMAT if an FTP URL
Daniel Stenberg [Wed, 19 Jan 2005 21:56:02 +0000 (21:56 +0000)]
Stephan Bergmann made libcurl return CURLE_URL_MALFORMAT if an FTP URL
contains %0a or %0d in the user, password or CWD parts. (A future fix would
include doing it for %00 as well - see KNOWN_BUGS for details.) Test case 225
and 226 were added to verify this

19 years agotoday's proxy fixes
Daniel Stenberg [Wed, 19 Jan 2005 18:05:56 +0000 (18:05 +0000)]
today's proxy fixes

19 years agoDon't copy 'stderr' for Win-CE in IPv6 code. Don't call
Gisle Vanem [Wed, 19 Jan 2005 10:20:55 +0000 (10:20 +0000)]
Don't copy 'stderr' for Win-CE in IPv6 code. Don't call
GetCurrentProcess() twice; use a local variable.

19 years agoadd a URL to an article about making Apache support PUT
Daniel Stenberg [Wed, 19 Jan 2005 10:09:15 +0000 (10:09 +0000)]
add a URL to an article about making Apache support PUT

19 years agoStephan Bergmann pointed out two flaws in libcurl built with HTTP disabled:
Daniel Stenberg [Wed, 19 Jan 2005 09:36:44 +0000 (09:36 +0000)]
Stephan Bergmann pointed out two flaws in libcurl built with HTTP disabled:

1) the proxy environment variables are still read and used to set HTTP proxy

2) you couldn't disable http proxy with CURLOPT_PROXY (since the option was
   disabled)

19 years agoskip sys/socket.h on windows CE
Daniel Stenberg [Tue, 18 Jan 2005 15:13:23 +0000 (15:13 +0000)]
skip sys/socket.h on windows CE

19 years agocheck for errno.h
Daniel Stenberg [Tue, 18 Jan 2005 14:34:50 +0000 (14:34 +0000)]
check for errno.h

19 years agoCody Jones' enhanced version of Samuel Díaz García's MSVC makefile patch.
Daniel Stenberg [Tue, 18 Jan 2005 10:17:34 +0000 (10:17 +0000)]
Cody Jones' enhanced version of Samuel Díaz García's MSVC makefile patch.

19 years agoAdd support for server 'ftp2' which is a second FTP server. Useful for 3rd
Daniel Stenberg [Mon, 17 Jan 2005 20:20:34 +0000 (20:20 +0000)]
Add support for server 'ftp2' which is a second FTP server. Useful for 3rd
party transfer tests or tests that need two FTP servers.

19 years agosupport the new --id command line option, that allows a second (or third or
Daniel Stenberg [Mon, 17 Jan 2005 19:49:12 +0000 (19:49 +0000)]
support the new --id command line option, that allows a second (or third or
whatever) instance to run without overwriting the previous' logfiles

19 years agomention the name-prefix protocol guess thing
Daniel Stenberg [Mon, 17 Jan 2005 14:57:21 +0000 (14:57 +0000)]
mention the name-prefix protocol guess thing

19 years agoupdated the wording for -B/--use-ascii
Daniel Stenberg [Mon, 17 Jan 2005 09:18:04 +0000 (09:18 +0000)]
updated the wording for -B/--use-ascii

19 years agoAlex aka WindEagle pointed out that when doing "curl -v dictionary.com", curl
Daniel Stenberg [Sun, 16 Jan 2005 08:51:52 +0000 (08:51 +0000)]
Alex aka WindEagle pointed out that when doing "curl -v dictionary.com", curl
assumed this used the DICT protocol. While guessing protocols will remain
fuzzy, I've now made sure that the host names must start with "[protocol]."
for them to be a valid guessable name. I also removed "https" as a prefix that
indicates HTTPS, since we hardly ever see any host names using that.

19 years agomention --netrc in the -u description
Daniel Stenberg [Sun, 16 Jan 2005 08:34:18 +0000 (08:34 +0000)]
mention --netrc in the -u description

19 years agoerrrno can by freak accident become EINTR on DOS or
Gisle Vanem [Sat, 15 Jan 2005 09:26:07 +0000 (09:26 +0000)]
errrno can by freak accident become EINTR on DOS or
Windows (unrelated to select). select() can never set errno
to EINTR on Windows.

19 years agooutput better error detection, like when ipv6 can't resolve
Daniel Stenberg [Sat, 15 Jan 2005 09:21:51 +0000 (09:21 +0000)]
output better error detection, like when ipv6 can't resolve

19 years agoAdded README.hostip
Daniel Stenberg [Fri, 14 Jan 2005 13:43:29 +0000 (13:43 +0000)]
Added README.hostip

19 years agoverify the protocol too
Daniel Stenberg [Fri, 14 Jan 2005 09:39:20 +0000 (09:39 +0000)]
verify the protocol too

19 years agoInspired by Martijn Koster's patch and example source at
Daniel Stenberg [Thu, 13 Jan 2005 21:51:48 +0000 (21:51 +0000)]
Inspired by Martijn Koster's patch and example source at
http://www.greenhills.co.uk/mak/gentoo/curl-eintr-bug.c, I now made the
select() and poll() calls properly loop if they return -1 and errno is
EINTR. glibc docs for this is found here:
http://www.gnu.org/software/libc/manual/html_node/Interrupted-Primitives.html

This last link says BSD doesn't have this "effect". Will there be a problem
if we do this unconditionally?
S: ----------------------------------------------------------------------

19 years agoAdded dependencies.
Gisle Vanem [Wed, 12 Jan 2005 15:32:41 +0000 (15:32 +0000)]
Added dependencies.

19 years agoAdded '-bd' option; target is a DLL.
Gisle Vanem [Wed, 12 Jan 2005 15:32:26 +0000 (15:32 +0000)]
Added '-bd' option; target is a DLL.
Added dependencies.

19 years agosupport for retrieving used IP addresses
Daniel Stenberg [Tue, 11 Jan 2005 22:26:00 +0000 (22:26 +0000)]
support for retrieving used IP addresses

19 years agoDan Torop cleaned up a few no longer used variables from David Phillips'
Daniel Stenberg [Tue, 11 Jan 2005 20:22:44 +0000 (20:22 +0000)]
Dan Torop cleaned up a few no longer used variables from David Phillips'
select() overhaul fix.

19 years agoRemoved CURLTOOLDEBUG. It caused libcurl_wc.dll
Gisle Vanem [Tue, 11 Jan 2005 17:08:47 +0000 (17:08 +0000)]
Removed CURLTOOLDEBUG. It caused libcurl_wc.dll
to fail in mysterious ways.

19 years agoRenamed easy.h and multi.h to easyif.h and multiif.h to make sure they don't
Daniel Stenberg [Tue, 11 Jan 2005 15:25:29 +0000 (15:25 +0000)]
Renamed easy.h and multi.h to easyif.h and multiif.h to make sure they don't
shadow our public headers with the former names.

19 years ago".\lib\easy.h" shadows for <curl/easy.h> in Watcom.
Gisle Vanem [Tue, 11 Jan 2005 14:59:24 +0000 (14:59 +0000)]
".\lib\easy.h" shadows for <curl/easy.h> in Watcom.
Force including ../include/curl/easy.h.

19 years agoFix '!if' expression.
Gisle Vanem [Tue, 11 Jan 2005 14:52:42 +0000 (14:52 +0000)]
Fix '!if' expression.

19 years ago".\lib\multi.h" shadows for <curl/multi.h> in Watcom.
Gisle Vanem [Tue, 11 Jan 2005 14:32:09 +0000 (14:32 +0000)]
".\lib\multi.h" shadows for <curl/multi.h> in Watcom.
Force including ../include/curl/multi.h.

19 years agoCyrill Osterwalder posted a detailed analysis about a bug that occurs when
Daniel Stenberg [Tue, 11 Jan 2005 14:00:45 +0000 (14:00 +0000)]
Cyrill Osterwalder posted a detailed analysis about a bug that occurs when
using a custom Host: header and curl fails to send a request on a re-used
persistent connection and thus creates a new connection and resends it. It
then sent two Host: headers. Cyrill's analysis was posted here:
http://curl.haxx.se/mail/archive-2005-01/0022.html

19 years agoBruce Mitchener identified (bug report #1099640) the never-ending SOCKS5
Daniel Stenberg [Mon, 10 Jan 2005 23:32:14 +0000 (23:32 +0000)]
Bruce Mitchener identified (bug report #1099640) the never-ending SOCKS5
problem with the version byte and the check for bad versions. Bruce has lots
of clues on this, and based on his suggestion I've now removed the check of
that byte since it seems to be able to contain 1 or 5.

19 years agoUse Curl_easy_addmulti() to clear associations from easy handles to multi
Daniel Stenberg [Mon, 10 Jan 2005 11:42:20 +0000 (11:42 +0000)]
Use Curl_easy_addmulti() to clear associations from easy handles to multi
handles. Include multi.h to get proto.

19 years agoedited wording
Daniel Stenberg [Mon, 10 Jan 2005 11:27:02 +0000 (11:27 +0000)]
edited wording

19 years agoPavel Orehov reported memory problems with the multi interface in bug report
Daniel Stenberg [Mon, 10 Jan 2005 10:07:07 +0000 (10:07 +0000)]
Pavel Orehov reported memory problems with the multi interface in bug report
#1098843. In short, a shared DNS cache was setup for a multi handle and when
the shared cache was deleted before the individual easy handles, the latter
cleanups caused read/writes to already freed memory.

19 years agoHzhijun reported a memory leak in the SSL certificate code, that leaked the
Daniel Stenberg [Mon, 10 Jan 2005 09:48:39 +0000 (09:48 +0000)]
Hzhijun reported a memory leak in the SSL certificate code, that leaked the
remote certificate name when it didn't match the used host name.

19 years agoNote about the static lib requirement; -DCURL_STATICLIB.
Gisle Vanem [Sat, 8 Jan 2005 16:35:03 +0000 (16:35 +0000)]
Note about the static lib requirement; -DCURL_STATICLIB.

19 years agoWatcom additions.
Gisle Vanem [Sat, 8 Jan 2005 16:15:06 +0000 (16:15 +0000)]
Watcom additions.

19 years agoAdded Watcom targets.
Gisle Vanem [Sat, 8 Jan 2005 16:12:27 +0000 (16:12 +0000)]
Added Watcom targets.

19 years agoNew file.
Gisle Vanem [Sat, 8 Jan 2005 16:06:37 +0000 (16:06 +0000)]
New file.

19 years agoAdded Makefile.Watcom to EXTRA_DIST.
Gisle Vanem [Sat, 8 Jan 2005 16:03:45 +0000 (16:03 +0000)]
Added Makefile.Watcom to EXTRA_DIST.

19 years agothree recent bug fixes
Daniel Stenberg [Fri, 7 Jan 2005 21:14:57 +0000 (21:14 +0000)]
three recent bug fixes

19 years agodisable the valgrind log checking
Daniel Stenberg [Fri, 7 Jan 2005 21:11:24 +0000 (21:11 +0000)]
disable the valgrind log checking

19 years agofixed the valgrind log check and make it possible to disable it for a specific
Daniel Stenberg [Fri, 7 Jan 2005 21:11:13 +0000 (21:11 +0000)]
fixed the valgrind log check and make it possible to disable it for a specific
test, see test 509

19 years agoadded test 199
Daniel Stenberg [Fri, 7 Jan 2005 21:09:50 +0000 (21:09 +0000)]
added test 199

19 years agoprevent a single byte read outside the string in test case 39
Daniel Stenberg [Thu, 6 Jan 2005 22:54:37 +0000 (22:54 +0000)]
prevent a single byte read outside the string in test case 39

19 years agofixed #1097019, multiple GET posts (-G) error
Daniel Stenberg [Thu, 6 Jan 2005 22:25:35 +0000 (22:25 +0000)]
fixed #1097019, multiple GET posts (-G) error

19 years agorecent events
Daniel Stenberg [Wed, 5 Jan 2005 14:12:06 +0000 (14:12 +0000)]
recent events

19 years agoChanged curl.dll to libcurl.dll.
Gisle Vanem [Tue, 4 Jan 2005 16:16:03 +0000 (16:16 +0000)]
Changed curl.dll to libcurl.dll.

19 years agoMinor comment fix.
Gisle Vanem [Tue, 4 Jan 2005 16:13:58 +0000 (16:13 +0000)]
Minor comment fix.

19 years agojust narrowed some text to fit within 80 cols
Daniel Stenberg [Tue, 4 Jan 2005 16:01:34 +0000 (16:01 +0000)]
just narrowed some text to fit within 80 cols

19 years agoRemoved _WIN32_WINNT to support IPv6 under Win-2K.
Gisle Vanem [Tue, 4 Jan 2005 16:00:14 +0000 (16:00 +0000)]
Removed _WIN32_WINNT to support IPv6 under Win-2K.

19 years agoMarty Kuhrt's VMS update
Daniel Stenberg [Mon, 3 Jan 2005 19:17:10 +0000 (19:17 +0000)]
Marty Kuhrt's VMS update

19 years agoreverted the bad naming of the implib names
Daniel Stenberg [Sun, 2 Jan 2005 21:15:29 +0000 (21:15 +0000)]
reverted the bad naming of the implib names

19 years agoAlex Neblett's minor update
Daniel Stenberg [Sun, 2 Jan 2005 19:19:32 +0000 (19:19 +0000)]
Alex Neblett's minor update

19 years agonah, don't use the system's getpass() function since it too often is limited
Daniel Stenberg [Sun, 26 Dec 2004 09:17:38 +0000 (09:17 +0000)]
nah, don't use the system's getpass() function since it too often is limited
to 8(!) or similar lengths passwords

19 years agoissue 54 - this takes sweat
Daniel Stenberg [Sat, 25 Dec 2004 23:15:45 +0000 (23:15 +0000)]
issue 54 - this takes sweat

19 years agoTest case 241 fails on all systems that support IPv6 but that don't have the
Daniel Stenberg [Sat, 25 Dec 2004 22:51:37 +0000 (22:51 +0000)]
Test case 241 fails on all systems that support IPv6 but that don't have the
host name 'ip6-localhost' in /etc/hosts (or similar) since the test case uses
that host name to test the IPv6 name to address resolver.

19 years ago--protocols, license, src/config.h.in
Daniel Stenberg [Sat, 25 Dec 2004 22:30:31 +0000 (22:30 +0000)]
--protocols, license, src/config.h.in

19 years ago./src/config.h.in is now removed from CVS. It is copied from the
Daniel Stenberg [Sat, 25 Dec 2004 22:10:38 +0000 (22:10 +0000)]
./src/config.h.in is now removed from CVS. It is copied from the
lib/config.h.in file by buildconf

19 years agoMy reimplementation and cleanup of the getpass source code. We officially no
Daniel Stenberg [Sat, 25 Dec 2004 22:08:02 +0000 (22:08 +0000)]
My reimplementation and cleanup of the getpass source code. We officially no
longer use Angus Mackay's getpass code due to the weirdo license his code was
donated to us under.

19 years agomention the new --protocols
Daniel Stenberg [Fri, 24 Dec 2004 09:02:23 +0000 (09:02 +0000)]
mention the new --protocols

19 years agoDavid Shaw added --protocols, and thus the --feature no longer mentions what
Daniel Stenberg [Fri, 24 Dec 2004 08:59:44 +0000 (08:59 +0000)]
David Shaw added --protocols, and thus the --feature no longer mentions what
protocols that are disabled.

19 years agoAdded LDAP library issue.
Dan Fandrich [Thu, 23 Dec 2004 22:34:00 +0000 (22:34 +0000)]
Added LDAP library issue.

19 years agorecent changes
Daniel Stenberg [Thu, 23 Dec 2004 22:31:39 +0000 (22:31 +0000)]
recent changes

and Merry Christmas!

19 years agoDavid Shaw fixed the disable variables so that curl-config --feature works
Daniel Stenberg [Thu, 23 Dec 2004 08:48:59 +0000 (08:48 +0000)]
David Shaw fixed the disable variables so that curl-config --feature works
correctly!

19 years agoissue 47 in next release?
Daniel Stenberg [Wed, 22 Dec 2004 22:46:05 +0000 (22:46 +0000)]
issue 47 in next release?

19 years agoRune Kleveland fixed a minor memory leak for received cookies with the (rare)
Daniel Stenberg [Wed, 22 Dec 2004 22:33:31 +0000 (22:33 +0000)]
Rune Kleveland fixed a minor memory leak for received cookies with the (rare)
version attribute set.

19 years agoMarcin Konicki provided two configure fixes and a source fix to make curl
Daniel Stenberg [Wed, 22 Dec 2004 22:28:10 +0000 (22:28 +0000)]
Marcin Konicki provided two configure fixes and a source fix to make curl
build out-of-the-box on BeOS.

19 years agoC ensures that static variables are initialized to 0
Dan Fandrich [Wed, 22 Dec 2004 20:12:15 +0000 (20:12 +0000)]
C ensures that static variables are initialized to 0

19 years agoadded CURLINFO_HTTP_CONNECTCODE
Daniel Stenberg [Wed, 22 Dec 2004 12:31:55 +0000 (12:31 +0000)]
added CURLINFO_HTTP_CONNECTCODE

19 years agouh, fixed!
Daniel Stenberg [Wed, 22 Dec 2004 09:21:04 +0000 (09:21 +0000)]
uh, fixed!

19 years agoAdded: 4 protocols we _could_ support and the CONNECT HTTP/1.0 detail we might
Daniel Stenberg [Wed, 22 Dec 2004 09:19:29 +0000 (09:19 +0000)]
Added: 4 protocols we _could_ support and the CONNECT HTTP/1.0 detail we might
fix one day.