Bernhard Miklautz [Thu, 21 Sep 2017 12:50:34 +0000 (14:50 +0200)]
Merge pull request #4116 from ChickenPeanut/patch-1
Fixed BadValue with XCreateWindow
Martin Fleisz [Tue, 19 Sep 2017 11:51:09 +0000 (13:51 +0200)]
Merge pull request #4138 from akallabeth/ak/nla_free_fix
Check and invalidate handles on free.
Armin Novak [Tue, 19 Sep 2017 10:33:33 +0000 (12:33 +0200)]
Check and invalidate handles on free.
Ondrej Holy [Mon, 18 Sep 2017 08:47:56 +0000 (10:47 +0200)]
Fix colors on big endian (#4135)
* client/x11: Fix colors on big endian
The bitmaps are recieved in little endian byte order (LSBFirst in terms
of X11). This is a problem on systems, where bitmaps are expected in big
endian byte order (MSBFirst). X11 client tries to handle this situation
by different color formats (e.g. RGBX vs. BGRX), but this doesn't work.
BGRX is not MSBFirst variant of RGBX, it should be XRGB. But this would
work only for 32/24 depths, where color channels matches bytes. Let's
say to the XServer that all the bitmaps are in LSBFirst encoding instead
of changing the color formats on big endian systems.
https://github.com/FreeRDP/FreeRDP/issues/2520
* client/x11: Fix cursor color on big endian
The cursor color is wrong on big endian systems. It is not probably
possible to force bitmap_order for XcursorImage as it is possible for
XImage. Fortunately, cursors are always 32 bit so we can use ABGR
instead of BGRA to deal with.
https://github.com/FreeRDP/FreeRDP/issues/2520
* client/x11: Fix comment indentation
The comment has wrong indentation for some reason, let's fix it.
* client/x11: Fix BGR vs. RGB detection
The BGR vs. RGB detection code is leftover from history and I am conviced
that it is wrong with the current color handling, where invert flag is TRUE
by default. However, I suppose that the detection still makes sense and
XServer may use the inverted formats in some cases. Maybe we can force XServer
to use our masks somehow, but let's just fix the value to FALSE now.
* client/x11: Remove unused color shifts
The color shifts are lefover from history and are not used in current
code. Let's remove them.
David Fort [Mon, 18 Sep 2017 08:17:43 +0000 (10:17 +0200)]
Merge pull request #4121 from ondrejholy/setsurface-segfault-fix
Various fixes from #4117
David Fort [Tue, 12 Sep 2017 21:16:39 +0000 (23:16 +0200)]
Merge pull request #4052 from akallabeth/mac_fixes
Mac drive fixes
MartinHaimberger [Mon, 11 Sep 2017 14:34:24 +0000 (16:34 +0200)]
Merge pull request #4127 from mfleisz/avc420
channels: Don't send gfx capversion 10 if AVC420 is requested
Martin Fleisz [Mon, 11 Sep 2017 10:05:03 +0000 (12:05 +0200)]
channels: Don't send gfx capversion 10 if AVC420 is requested
Ondrej Holy [Tue, 5 Sep 2017 08:25:15 +0000 (10:25 +0200)]
cache: Use Bitmap_Free instead of free
Bitmap_Alloc is used to allocate memory of bitmap, Bitmap_Free should
be used to release that memory. Let's change free to Bitmap_Free.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Tue, 5 Sep 2017 07:56:00 +0000 (09:56 +0200)]
orders: Fix OFFSCREEN_DELETE_LIST allocation size
The size of OFFSCREEN_DELETE_LIST list allocation was incorrectly changed
by commit 99b1481 and consequently fixed incorrectly by commit
8a0fe086.
Let's count the allocation size based on new size and not based on current
size in order to prevent some memory issues.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Tue, 5 Sep 2017 06:58:37 +0000 (08:58 +0200)]
orders: Fix ORDER_TYPE_GDIPLUS_END check
Commit 6fd03ab introduced security checks for orders, but
ORDER_TYPE_GDIPLUS_END check fails in case of success and vice versa.
Let's add the missing question mark.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Mon, 4 Sep 2017 16:48:25 +0000 (18:48 +0200)]
cache: Check return value from offscreen_cache_get
Currently, SetSurface is called regardless of return value from
offscreen_cache_get. It may happen that bitmap is not found in a
cache from some reason, which may lead to segfaults. Let's check
the returned value before use.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Mon, 4 Sep 2017 16:22:49 +0000 (18:22 +0200)]
client/X11: Check arguments in xf_Bitmap_SetSurface
Arguments of xf_Bitmap_SetSurface are not checked before use currently
which may lead to segfaults. It may happen if bitmap is not found in a
cache from some reason. Let's check the arguments before use similarly
as it is done in client/Windows/wf_graphics.c in order to avoid segfaults.
https://github.com/FreeRDP/FreeRDP/issues/4117
ChickenPeanut [Sun, 3 Sep 2017 22:52:34 +0000 (18:52 -0400)]
Fixed BadValue with XCreateWindow
xf_FixWindowCoordinates occasionally set the dimensions of the window to invalid values (0) because the minimum value check was done at the beginning of the method rather than at the end
David Fort [Thu, 31 Aug 2017 08:22:43 +0000 (10:22 +0200)]
Merge pull request #4079 from akallabeth/channel_pubsub_fix
Dynamic channel signal disconnect after the fact.
Armin Novak [Thu, 31 Aug 2017 07:57:49 +0000 (09:57 +0200)]
Removed unused variable.
Armin Novak [Thu, 31 Aug 2017 07:06:59 +0000 (09:06 +0200)]
Unified dynamic channel cleanup code.
David Fort [Wed, 30 Aug 2017 08:19:12 +0000 (10:19 +0200)]
Merge pull request #4063 from akallabeth/auth_fixes
Fixed leaks, certificate comparison and channel context cleanup
David Fort [Tue, 29 Aug 2017 09:06:13 +0000 (11:06 +0200)]
Merge pull request #4104 from abma/master
Revert "Possible fix for #4081 and #2707 (#4087)" (Part of #4096)
Bernhard Miklautz [Tue, 29 Aug 2017 08:35:45 +0000 (10:35 +0200)]
Merge pull request #4050 from akallabeth/rdpefs_server_client_name_fix
Mask out ignored bits from UnicodeFlag.
Bernhard Miklautz [Tue, 29 Aug 2017 07:09:38 +0000 (09:09 +0200)]
fix clang warnings, directly include wtypes.h (#4097)
* build: clang use -Wno-unused-command-line-argument
With clang 5.0 builds are quite noisy otherwise.
* Directly include wtypes.h
Directly include winpr/wtypes.h where _fseeki64 or _ftelli64 is used.
* fix build warnings with clang 5
clang version: 5.0.0-svn310678-1~exp1 (branches/release_50)
Warning: parentheses-equality
* fix build warnings with clang 5
clang version: 5.0.0-svn310678-1~exp1 (branches/release_50)
Warning: tautological-compare
* fix build warnings with clang 5
clang version: 5.0.0-svn310678-1~exp1 (branches/release_50)
Warning:
incompatible pointer types passing 'size_t *' (aka 'unsigned
long *') to parameter of type 'UINT32 *' (aka 'unsigned int *')
[-Wincompatible-pointer-types]
David Fort [Sat, 26 Aug 2017 08:17:02 +0000 (10:17 +0200)]
Merge pull request #4100 from mmeyer724/wayland-opaque
wlfreerdp: improve performance by making the window opaque
David Fort [Sat, 26 Aug 2017 08:13:42 +0000 (10:13 +0200)]
Merge pull request #4099 from mmeyer724/wayland-fullscreen
wlfreerdp: mirror display resolution in fullscreen mode
abma [Tue, 22 Aug 2017 20:42:58 +0000 (22:42 +0200)]
Revert "Possible fix for #4081 and #2707 (#4087)"
This reverts most of commit
6b7b60237042a891221d71a596fc683d850bcb4e.
Part of #4096
Michael Meyer [Thu, 17 Aug 2017 21:32:26 +0000 (17:32 -0400)]
wlfreerdp: improve performance by making the window opaque
Michael Meyer [Thu, 17 Aug 2017 17:33:44 +0000 (13:33 -0400)]
wlfreerdp: mirror display resolution in fullscreen mode
Bernhard Miklautz [Thu, 17 Aug 2017 13:18:04 +0000 (15:18 +0200)]
Merge pull request #4098 from akallabeth/fix_rsa_generation
Fixed RSA generation for OpenSSL >= 1.1
Armin Novak [Thu, 17 Aug 2017 11:16:32 +0000 (13:16 +0200)]
Fixed RSA generation for OpenSSL >= 1.1
Bernhard Miklautz [Thu, 17 Aug 2017 08:46:16 +0000 (10:46 +0200)]
Merge pull request #4095 from mmeyer724/wayland-scrolling
Fix scrolling crash in wayland client
Michael Meyer [Wed, 16 Aug 2017 17:54:45 +0000 (17:54 +0000)]
Fixes scrolling crash in wlfreerdp
An "axis discrete" handler is required since protocol version 5:
https://code.woboq.org/qt5/include/wayland-client-protocol.h.html
Crash output: "listener function for opcode 8 of wl_pointer is NULL"
Bernhard Miklautz [Wed, 16 Aug 2017 11:28:11 +0000 (13:28 +0200)]
android: fix a regression with remote program (#4091)
Commit
54a7d799d1e9dc7698425b7172a8bf81a4147168 introduced a problem
where /app was used instead of /shell causing a black screen when remote
programs were used. The Android client doesn't support remote apps
therefore /app can't work. "Remote program" just sets the selected
program as shell to run.
Bernhard Miklautz [Wed, 16 Aug 2017 11:26:47 +0000 (13:26 +0200)]
Merge pull request #4092 from akallabeth/afreerdp_no_client_name_escape
Do not add quotes to client hostname.
Armin Novak [Wed, 16 Aug 2017 09:31:33 +0000 (11:31 +0200)]
Do not add quotes to client hostname.
Bernhard Miklautz [Wed, 16 Aug 2017 08:04:13 +0000 (10:04 +0200)]
Merge pull request #4088 from akallabeth/file_api_64bit_fixes
fseeko and ftello for 64bit file support.
Bernhard Miklautz [Wed, 16 Aug 2017 06:09:31 +0000 (08:09 +0200)]
Merge pull request #4085 from akallabeth/file_warn_fix
Fixed FileSetFilePointer warnings
Jiang, Zihao [Mon, 14 Aug 2017 08:16:14 +0000 (16:16 +0800)]
Client/X11: Fix h264 context leak when DeleteSurface (#4089)
Kai [Mon, 14 Aug 2017 08:10:53 +0000 (10:10 +0200)]
Possible fix for #4081 and #2707 (#4087)
* detect openbox automatically
* format code
* copyright update
* free prop at the end of the function
Armin Novak [Fri, 11 Aug 2017 08:07:46 +0000 (10:07 +0200)]
fseeko and ftello for 64bit file support.
Bernhard Miklautz [Thu, 10 Aug 2017 15:39:34 +0000 (17:39 +0200)]
Merge pull request #4084 from psumbera/master
On Solaris use standard conforming getpwnam_r().
Armin Novak [Thu, 10 Aug 2017 14:51:55 +0000 (16:51 +0200)]
Fixed FileSetFilePointer warnings
Petr Sumbera [Thu, 10 Aug 2017 14:36:25 +0000 (07:36 -0700)]
On Solaris use standard conforming getpwnam_r().
MartinHaimberger [Wed, 9 Aug 2017 08:35:37 +0000 (10:35 +0200)]
Merge pull request #4076 from akallabeth/SetFilePointer_fix
Set file pointer fix
Bernhard Miklautz [Tue, 8 Aug 2017 19:17:01 +0000 (21:17 +0200)]
Merge pull request #4070 from yurashek/master
Sun keyboard - cursor keys
Armin Novak [Tue, 8 Aug 2017 08:52:11 +0000 (10:52 +0200)]
Fixed file seek.
Armin Novak [Tue, 8 Aug 2017 08:51:50 +0000 (10:51 +0200)]
Fixed SetFilePointer, added SetFilePointerEx
Jura Sasek [Wed, 2 Aug 2017 11:52:45 +0000 (04:52 -0700)]
Sun keyboard
David Fort [Thu, 3 Aug 2017 07:32:29 +0000 (09:32 +0200)]
Merge pull request #4071 from bmiklautz/debian_fixes
Fixes from the Debian project
Mike Gabriel [Thu, 3 Aug 2017 06:41:50 +0000 (08:41 +0200)]
Fix warning in man pages
"warning: can't find macro file `www.tmac))'""`"
Mike Gabriel [Thu, 3 Aug 2017 06:38:05 +0000 (08:38 +0200)]
Fix typos in some error messages
David Fort [Wed, 2 Aug 2017 09:25:08 +0000 (11:25 +0200)]
Merge pull request #4066 from akallabeth/input_event_fixes
Fixed capability checks for mouse and unicode input.
David Fort [Wed, 2 Aug 2017 07:53:38 +0000 (09:53 +0200)]
Merge pull request #4069 from yurashek/master
Build on Solaris
Armin Novak [Mon, 31 Jul 2017 10:16:47 +0000 (12:16 +0200)]
Fixed capability checks for mouse and unicode input.
David Fort [Sat, 29 Jul 2017 06:33:33 +0000 (08:33 +0200)]
Merge pull request #4064 from floppym/gst-detect
Fix gstreamer-1.0 detection
Mike Gilbert [Fri, 28 Jul 2017 20:31:41 +0000 (16:31 -0400)]
Fix gstreamer-1.0 detection
Armin Novak [Tue, 18 Jul 2017 12:37:46 +0000 (14:37 +0200)]
Channels with a context must free it themselves.
Armin Novak [Tue, 18 Jul 2017 11:23:22 +0000 (13:23 +0200)]
Free credentials on exit.
Armin Novak [Tue, 18 Jul 2017 10:54:00 +0000 (12:54 +0200)]
Unexported internal NLA functions.
Armin Novak [Tue, 18 Jul 2017 10:43:55 +0000 (12:43 +0200)]
Fixed certificate check return.
Armin Novak [Tue, 18 Jul 2017 09:38:59 +0000 (11:38 +0200)]
Fixed uninitialized values and leaks.
David Fort [Thu, 27 Jul 2017 08:55:00 +0000 (10:55 +0200)]
Merge pull request #4061 from vakartel/master
Fix build with LibreSSL
Valery Kartel [Wed, 26 Jul 2017 14:12:14 +0000 (17:12 +0300)]
Fix build with LibreSSL
Bernhard Miklautz [Mon, 24 Jul 2017 13:47:49 +0000 (15:47 +0200)]
Merge pull request #4056 from akallabeth/disable_jpeg
Disable JPEG codec support if not compiled in.
Armin Novak [Mon, 24 Jul 2017 13:23:36 +0000 (15:23 +0200)]
Disable JPEG codec support if not compiled in.
Norbert Federa [Mon, 24 Jul 2017 08:46:54 +0000 (10:46 +0200)]
Merge pull request #4055 from akallabeth/talos_v3
Security fixes and code cleanups
Armin Novak [Mon, 24 Jul 2017 06:53:21 +0000 (08:53 +0200)]
Added return check for ConvertFromUnicode.
Armin Novak [Thu, 20 Jul 2017 10:35:43 +0000 (12:35 +0200)]
Fixed missing unicode conversion for mac drive redirection.
Armin Novak [Thu, 20 Jul 2017 10:33:56 +0000 (12:33 +0200)]
Ignore gdi_resize if not initialized.
Bernhard Miklautz [Mon, 17 Jul 2017 13:21:58 +0000 (15:21 +0200)]
clipboard: fix possible invalid memory access
Fix an possible issue found by Sébastien Duquette.
Armin Novak [Thu, 13 Jul 2017 11:29:00 +0000 (13:29 +0200)]
Fixed missing include.
Armin Novak [Thu, 13 Jul 2017 11:28:00 +0000 (13:28 +0200)]
Fixed resource cleanup.
Armin Novak [Thu, 13 Jul 2017 10:19:10 +0000 (12:19 +0200)]
Fixed uninitialized values.
Armin Novak [Thu, 13 Jul 2017 10:08:25 +0000 (12:08 +0200)]
Fixed double free.
Armin Novak [Thu, 13 Jul 2017 09:42:50 +0000 (11:42 +0200)]
Fixed wrong type for AuthenticationLevel.
Replaced type BOOL with INT32 as according to MSDN they are typedefed.
This keeps the ABI compatible and fixes the wrong data type.
Armin Novak [Tue, 6 Jun 2017 12:01:41 +0000 (14:01 +0200)]
Fixed use of reserved keywords for include guards.
Armin Novak [Tue, 30 May 2017 08:46:43 +0000 (10:46 +0200)]
Fixed clang malloc integer overflow warnings.
Armin Novak [Mon, 29 May 2017 08:50:22 +0000 (10:50 +0200)]
Fix TALOS issues
Fix the following issues identified by the CISCO TALOS project:
* TALOS-2017-0336 CVE-2017-2834
* TALOS-2017-0337 CVE-2017-2834
* TALOS-2017-0338 CVE-2017-2836
* TALOS-2017-0339 CVE-2017-2837
* TALOS-2017-0340 CVE-2017-2838
* TALOS-2017-0341 CVE-2017-2839
akallabeth [Thu, 20 Jul 2017 06:52:54 +0000 (08:52 +0200)]
Merge pull request #3956 from dodo040/smartcard
redirect specific smartcard readers
dodo040 [Thu, 22 Jun 2017 08:35:51 +0000 (10:35 +0200)]
fix format code
dodo040 [Tue, 20 Jun 2017 15:59:58 +0000 (17:59 +0200)]
fix smartcard argument parsing
dodo040 [Mon, 15 May 2017 15:17:08 +0000 (17:17 +0200)]
fix wrong declaration
dodo040 [Mon, 15 May 2017 11:43:51 +0000 (13:43 +0200)]
redirect specific smartcard readers
Bernhard Miklautz [Wed, 19 Jul 2017 10:02:53 +0000 (12:02 +0200)]
Merge pull request #4044 from akallabeth/disable_h264_if_not_compiled
Disable h264 if no backend compiled in
Armin Novak [Wed, 19 Jul 2017 09:36:28 +0000 (11:36 +0200)]
Fixed variable assignment.
Bernhard Miklautz [Wed, 19 Jul 2017 09:24:57 +0000 (11:24 +0200)]
Merge pull request #4047 from akallabeth/win_gfx_fix
Always use software GFX for windows client.
Armin Novak [Wed, 19 Jul 2017 07:54:42 +0000 (09:54 +0200)]
Added warning on GFX channel load that it does not support acceleration.
Bernhard Miklautz [Tue, 18 Jul 2017 14:17:37 +0000 (16:17 +0200)]
Don't use an option for WITH_GFX_H264
CMAKE_DEPENDENT_OPTION the option is initialized on the first run and
then saved. Later configuration changes are not considered anymore.
Therefor use an variable instead of an option here.
Armin Novak [Wed, 19 Jul 2017 07:41:58 +0000 (09:41 +0200)]
Mask out ignored bits from UnicodeFlag.
Armin Novak [Tue, 18 Jul 2017 06:27:14 +0000 (08:27 +0200)]
Always use software GFX for windows client.
Armin Novak [Tue, 18 Jul 2017 05:46:51 +0000 (07:46 +0200)]
Reordered backends with regard to feature completeness.
akallabeth [Mon, 17 Jul 2017 10:26:48 +0000 (12:26 +0200)]
Merge pull request #4041 from wayk/PathMakePathA
Fixed PathMakePathA (returned true even if it can't create the last f…
Armin Novak [Mon, 17 Jul 2017 09:38:06 +0000 (11:38 +0200)]
Readded H264 struct pointers, keep API compatible.
Armin Novak [Mon, 17 Jul 2017 09:37:53 +0000 (11:37 +0200)]
Add 10.3 capability check.
Armin Novak [Mon, 17 Jul 2017 08:56:45 +0000 (10:56 +0200)]
Fixed config option.
David Fort [Mon, 17 Jul 2017 08:45:32 +0000 (10:45 +0200)]
Merge pull request #4043 from rjcorrig/kb4020322
winpr: Updates time zone data to July 2017
Armin Novak [Mon, 17 Jul 2017 08:37:15 +0000 (10:37 +0200)]
Deactivated all H264 related code paths.
Armin Novak [Mon, 17 Jul 2017 07:32:34 +0000 (09:32 +0200)]
Disable WITH_GFX_H264 if no backend compiled in.
Armin Novak [Mon, 17 Jul 2017 07:28:08 +0000 (09:28 +0200)]
Removed H264 dummy, did not work (crash on use)
Armin Novak [Mon, 17 Jul 2017 07:00:57 +0000 (09:00 +0200)]
Disable GFX H264 if no backend compiled in.
Robert Corrigan [Fri, 14 Jul 2017 21:16:08 +0000 (17:16 -0400)]
Update time zone data to July 2017
Robert Corrigan [Fri, 14 Jul 2017 21:15:32 +0000 (17:15 -0400)]
Change documented source of windowsZones.xml file