commit-queue@webkit.org [Wed, 11 Apr 2012 01:15:30 +0000 (01:15 +0000)]
Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/
Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.
https://bugs.webkit.org/show_bug.cgi?id=80200
Patch by Greg Billock <gbillock@google.com> on 2012-04-10
Reviewed by Adam Barth.
* Modules/intents/Intent.cpp:
(WebCore::Intent::create):
* Modules/intents/Intent.idl:
* WebCore.gypi:
* bindings/v8/custom/V8IntentCustom.cpp: Added.
(WebCore):
(WebCore::V8Intent::constructorCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 11 Apr 2012 01:09:07 +0000 (01:09 +0000)]
Cleanup wtf/Platform.h and config.h files
https://bugs.webkit.org/show_bug.cgi?id=83431
Reviewed by Eric Seidel.
The ENABLE() and USE() macros take care about the case when the flag
isn't defined. So there is no need to define anything with 0.
Also move duplicated code from the config.h files to Platform.h and
merge a few preprocessor commands to make the file more readable.
Source/JavaScriptCore:
* config.h:
Source/WebCore:
* config.h:
Source/WTF:
* config.h:
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Wed, 11 Apr 2012 00:56:02 +0000 (00:56 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
* platform/chromium-mac/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 11 Apr 2012 00:37:04 +0000 (00:37 +0000)]
DFG should flush SetLocals to arguments
https://bugs.webkit.org/show_bug.cgi?id=83554
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
This is necessary to match baseline JIT argument capture behavior.
But to make this work right we need to have a story for arguments into
which we store values of different formats. This patch introduces the
notion of an ArgumentPosition - i.e. an argument in a particular inline
call frame - and forces unification of all data pertinent to selecting
the argument's data format.
Also fixed an amusing bug in the handling of OSR on SetLocals if there
was any insertion/deletion of nodes in the basic block. This is benign
for now but won't be eventually since the DFG is getting smarter. So
better fix it now.
Also fixed an amusing bug in the handling of OSR on SetLocals if they
are immediately followed by a Flush. I think this bug might have always
been there but now it'll happen more commonly, and it's covered by the
run-javascriptcore-tests.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArgumentPosition.h: Added.
(DFG):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::addVariable):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGDoubleFormatState.h: Added.
(DFG):
(JSC::DFG::mergeDoubleFormatStates):
(JSC::DFG::mergeDoubleFormatState):
(JSC::DFG::doubleFormatStateToString):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::doubleFormatState):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeDoubleFormatState):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):
Source/WTF:
Reviewed by Gavin Barraclough.
Added an isRoot() method that is a faster shorthand for saying
find() == this.
* wtf/UnionFind.h:
(WTF::UnionFind::isRoot):
(UnionFind):
LayoutTests:
Rubber stamped by Gavin Barraclough.
Added a variety of tests for reassigning arguments prior to function.arguments
retrieval.
* fast/js/dfg-inline-arguments-become-double-expected.txt: Added.
* fast/js/dfg-inline-arguments-become-double.html: Added.
* fast/js/dfg-inline-arguments-become-int32-expected.txt: Added.
* fast/js/dfg-inline-arguments-become-int32.html: Added.
* fast/js/dfg-inline-arguments-reset-changetype-expected.txt: Added.
* fast/js/dfg-inline-arguments-reset-changetype.html: Added.
* fast/js/dfg-inline-arguments-reset-expected.txt: Added.
* fast/js/dfg-inline-arguments-reset.html: Added.
* fast/js/script-tests/dfg-inline-arguments-become-double.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-become-int32.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-reset-changetype.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-reset.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 11 Apr 2012 00:17:42 +0000 (00:17 +0000)]
Source/WebCore: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
As recommended by David Hyatt in
<https://lists.webkit.org/pipermail/webkit-dev/2010-July/013536.html>,
we should phase out support for -khtml- and -apple- vendor prefixes in
CSS (in favor of -webkit-).
As noted in <https://bugs.webkit.org/show_bug.cgi?id=42093#c29>, Dave's
proposal is a bit too agressive. These prefixes appear to be needed
for a number of dashboard widgets. For that reason, this patch limits
the prefixes to ENABLE(LEGACY_CSS_VENDOR_PREFIXES).
This patch enables ENABLE(LEGACY_CSS_VENDOR_PREFIXES) on apple-mac and
apple-win, which will let us learn whether removing these prefixes
causes a compatibility problem on the broader web.
* Configurations/FeatureDefines.xcconfig:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
* css/CSSParser.cpp:
(WebCore::cssPropertyID):
Source/WebKit/chromium: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
* features.gypi:
WebKitLibraries: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
* win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests: Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
Skip these two tests, which are testing that -apple- and -khtml- vendor
prefixes work correctly.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 11 Apr 2012 00:15:36 +0000 (00:15 +0000)]
Remove unused NonNullPassRefPtr from WTF
https://bugs.webkit.org/show_bug.cgi?id=82389
Reviewed by Kentaro Hara.
Source/JavaScriptCore:
* JavaScriptCore.order: Remove nonexistent symbols referencing NonNullPassRefPtr.
Source/WTF:
NonNullPassRefPtr seems to be unused since JSC allocation was
restructured in r84052.
If someone decides they need this later, they can always revert this patch.
* wtf/PassRefPtr.h:
* wtf/RefPtr.h:
(RefPtr):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 11 Apr 2012 00:09:45 +0000 (00:09 +0000)]
Unreviewed build fix after r113791.
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 10 Apr 2012 23:44:26 +0000 (23:44 +0000)]
Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83604
Reviewed by Julien Chaffraix.
Removing unnecessary definitions of absoluteRect and replacing them with a single public
version that's more explicit about its contract.
Also correcting a LayoutUnit misuse, as rects in absolute coordinates should be returned
using integers, not LayoutUnits. See https://trac.webkit.org/wiki/LayoutUnit for details.
No new tests. No change in behavior.
* editing/Editor.cpp:
(WebCore::Editor::firstRectForRange):
* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::absoluteRect): Pixel snapping the local rect before converting
to absolute coordinates.
* editing/RenderedPosition.h:
(RenderedPosition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 10 Apr 2012 23:40:51 +0000 (23:40 +0000)]
Initial support for fixed position elements in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=81786
Reviewed by Noam Rosenthal.
.:
* ManualTests/fixed-position.html: Added.
Source/WebCore:
When the setting acceleratedCompositingForFixedPositionEnabled is true, we update
the position of fixed layers, and send updates to the UI process as we scroll.
Before painting, TextureMapperLayer receives a delta of the scroll positions between the UI
and the web processes, and adjusts its transform position accordingly.
* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setScrollPositionDelta):
(WebCore):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
Source/WebKit2:
Turn on the flag acceleratedCompositingForFixedPositionEnabled when using fixed layout.
As we scroll, we keep track of the delta in scroll position between the UI and web processes,
and adjust the position of all the fixed layers by that delta.
When WebLayerTreeRenderer receives a new scroll position from the web process, it keeps it as pending,
and commit the new scroll position in flushLayerChanges.
This patch does not address scrolling overshoot and it does not fix the wrong positioning
that occurs when we zoom. These issues will be addressed in future patches.
* Shared/WebLayerTreeInfo.h:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::updateSize):
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setContentsSize):
(WebKit):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::didChangeScrollPosition):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.messages.in:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::boundedScrollPosition):
(WebKit):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setContentsSize):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebGraphicsLayer):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeHostQt::syncFixedLayers):
(WebKit::LayerTreeHostQt::setVisibleContentsRect):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 10 Apr 2012 23:34:52 +0000 (23:34 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
* platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Removed.
* platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Removed.
* platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
* platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 10 Apr 2012 23:16:06 +0000 (23:16 +0000)]
Remove empty directories.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 10 Apr 2012 23:10:20 +0000 (23:10 +0000)]
Clone any baselines chromium is using from mac-leopard and mac-snowleopard into chromium dirs.
https://bugs.webkit.org/show_bug.cgi?id=83401
Unreviewed, baseline shuffling.
* platform/chromium-mac-leopard/accessibility/aria-tables-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/lists-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/media-element-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-attributes-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-cell-spans-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-cells-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-detection-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-sections-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-with-rules-expected.txt: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-TIFF-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/designmode-no-caret-expected.png: Added.
* platform/chromium-mac-leopard/editing/spelling/grammar-expected.txt: Added.
* platform/chromium-mac-leopard/editing/text-iterator/findString-expected.txt: Added.
* platform/chromium-mac-leopard/fast/backgrounds/animated-gif-as-background-expected.png: Added.
* platform/chromium-mac-leopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
* platform/chromium-mac-leopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/disabled-author-styles-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/font-weight-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/outline-auto-empty-rects-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/gc-10-expected.png: Added.
* platform/chromium-mac-leopard/fast/events/keydown-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
* platform/chromium-mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/inline-object-inside-frameset-expected.png: Added.
* platform/chromium-mac-leopard/fast/images/pdf-as-image-landscape-expected.png: Added.
* platform/chromium-mac-leopard/fast/reflections/inline-crash-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/pdf-as-image-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/font-initial-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bold-bengali-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-selection-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/inspector/console-websocket-error-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/misc/favicon-as-image-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/misc/slow-loading-mask-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/navigation/error404-goback-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/navigation/error404-subframeload-expected.png: Added.
* platform/chromium-mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
* platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/style-attribute-font-size-expected.png: Added.
* platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac-leopard/svg/hixie/error/012-expected.png: Added.
* platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Added.
* platform/chromium-mac-leopard/svg/hixie/mixed/007-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Added.
* platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-mac-leopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
* platform/chromium-mac-leopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-mac-leopard/transforms/2d/zoom-menulist-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/set-colors-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/preloader/document-write-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/preloader/document-write-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/media-queries-print-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/style-attribute-font-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/mixed/007-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/viewbox/001-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/viewbox/002-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 10 Apr 2012 22:59:52 +0000 (22:59 +0000)]
Add a chromeless view to the individual tests view
https://bugs.webkit.org/show_bug.cgi?id=83541
Reviewed by Daniel Bates.
This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testHtmlForIndividualTestOnAllBuilders):
(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):
(htmlEscape):
(runTests):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Tue, 10 Apr 2012 22:59:04 +0000 (22:59 +0000)]
[CMake] Do not pass -P to the preprocessor when running make_names.pl.
https://bugs.webkit.org/show_bug.cgi?id=83225
Reviewed by Rob Buis.
This is necessary to make CMake-based ports build with the
recently-released GCC 4.7.0, whose preprocessor seems to ignore
empty lines when -P is passed to it. Such behavior breaks
make_names.pl (in fact, InFilesParser.pm), which expects an empty
line to separate common and specific sections in .in files.
A fix for this same problem has been supposedly done in r84123,
but as the CMake-based ports always pass --preprocessor to the
Perl tools the fix never reached us.
The idea is to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS
for (!MSVC && !QNX) and use it in the macros which call
make_names.pl.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/WebKitMacros.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Tue, 10 Apr 2012 22:52:42 +0000 (22:52 +0000)]
Unreviewed update to test expectations
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 10 Apr 2012 22:41:33 +0000 (22:41 +0000)]
[Chromium] Fix test_expectations.txt from r113776.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 22:39:39 +0000 (22:39 +0000)]
Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types
https://bugs.webkit.org/show_bug.cgi?id=83390
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-10
Reviewed by Yury Semikhatsky.
Intermediate classes InspectorObjectBase and InspectorArrayBase are created. They have all raw methos
protected. InspectorObject and InspectorArray now inherit the corresponding base classes with exposing
all their protected methods.
"Open types" are left inheriting from InspectorObject, plus field name constants are generated for
an easy random access to all properties.
All the client code is fixed to use type-safe API rather than raw access methods in function parameter
and return types and bodies.
* inspector/CodeGeneratorInspector.py:
(RawTypes.Object):
(RawTypes.Object.get_setter_name):
(RawTypes.Array):
(RawTypes.Array.get_setter_name):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Array):
(Generator):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator.process_types.GenerateContext):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didPause):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::styleWithProperties):
* inspector/InspectorValues.cpp:
(WebCore::InspectorObjectBase::~InspectorObjectBase):
(WebCore::InspectorObjectBase::asObject):
(WebCore::InspectorObjectBase::openAccessors):
(WebCore):
(WebCore::InspectorObjectBase::getBoolean):
(WebCore::InspectorObjectBase::getString):
(WebCore::InspectorObjectBase::getObject):
(WebCore::InspectorObjectBase::getArray):
(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::remove):
(WebCore::InspectorObjectBase::writeJSON):
(WebCore::InspectorObjectBase::InspectorObjectBase):
(WebCore::InspectorArrayBase::~InspectorArrayBase):
(WebCore::InspectorArrayBase::asArray):
(WebCore::InspectorArrayBase::writeJSON):
(WebCore::InspectorArrayBase::InspectorArrayBase):
(WebCore::InspectorArrayBase::get):
* inspector/InspectorValues.h:
(InspectorObjectBase):
(InspectorObject):
(WebCore::InspectorObject::create):
(WebCore):
(InspectorArrayBase):
(WebCore::InspectorArrayBase::length):
(InspectorArray):
(WebCore::InspectorArray::create):
(WebCore::InspectorObjectBase::find):
(WebCore::InspectorObjectBase::setBoolean):
(WebCore::InspectorObjectBase::setNumber):
(WebCore::InspectorObjectBase::setString):
(WebCore::InspectorObjectBase::setValue):
(WebCore::InspectorObjectBase::setObject):
(WebCore::InspectorObjectBase::setArray):
(WebCore::InspectorArrayBase::pushBoolean):
(WebCore::InspectorArrayBase::pushInt):
(WebCore::InspectorArrayBase::pushNumber):
(WebCore::InspectorArrayBase::pushString):
(WebCore::InspectorArrayBase::pushValue):
(WebCore::InspectorArrayBase::pushObject):
(WebCore::InspectorArrayBase::pushArray):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 22:37:59 +0000 (22:37 +0000)]
[Chromium] defaultDeviceScaleFactor != 0 should set deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag for debugging purposes
https://bugs.webkit.org/show_bug.cgi?id=82757
Patch by Tim Dresser <tdresser@chromium.org> on 2012-04-10
Reviewed by Darin Fisher.
If there is no viewport tag, the deviceScaleFactor is set to the defaultDeviceScaleFactor.
Tested by: WebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag.
* src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* tests/WebFrameTest.cpp:
(WebKit):
(FixedLayoutTestWebViewClient):
(WebKit::TEST_F):
* tests/data/no_viewport_tag.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Tue, 10 Apr 2012 22:36:48 +0000 (22:36 +0000)]
Remove unnecessary calls to RenderSVGShape::createShape()
https://bugs.webkit.org/show_bug.cgi?id=83598
Reviewed by Rob Buis.
RenderSVGShape::strokeContains contains calls to fall back to path stroke hit detection
in several cases (dashed strokes, for example). One of these cases, a check for isStyled,
is not needed and is always true for Ellipses, Circles, and Rects (all styled elements).
This change removes the check for isStyled.
No new tests as this only affects performance, not test results.
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeContains):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 10 Apr 2012 22:33:40 +0000 (22:33 +0000)]
<rdar://problem/
10912486> CanvasRenderingContext2D does not expose its backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83619
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/canvas/2d.backingStorePixelRatio.html
Added a backingStorePixelRatio attribute to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The attribute
is prefixed with “webkit” for now.
* html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::deviceScaleFactor): Added this getter.
* html/canvas/CanvasRenderingContext2D.h:
(WebCore::CanvasRenderingContext2D::webkitBackingStorePixelRatio): Added. Returns the canvas
element’s device scale factor.
(CanvasRenderingContext2D):
* html/canvas/CanvasRenderingContext2D.idl: Added webkitBackingStorePixelRatio as a
read-only attribute.
LayoutTests:
* fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
* fast/canvas/2d.backingStorePixelRatio.html: Added.
* platform/mac/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
* platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Tue, 10 Apr 2012 22:26:47 +0000 (22:26 +0000)]
[EFL][DRT] Top level SVG rebaselines
https://bugs.webkit.org/show_bug.cgi?id=83585
Unreviewed, EFL rebaseline.
Landing bug 83562 enables us to do a bigger rebaselining and
unskipping of EFL SVG testcases. This is part one.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10
* platform/efl/Skipped:
* platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
* platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
* platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* platform/efl/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/efl/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 22:24:16 +0000 (22:24 +0000)]
Segmentation fault in JS drop-down menus in facebook.com
https://bugs.webkit.org/show_bug.cgi?id=82896
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-04-10
Reviewed by Chris Fleizach.
Make sure changes introduced with r110819 affect to the Mac
platform only, since they depend on platform specific behaviour,
as not all the platforms treat attachments in the same way.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateChildrenIfNecessary):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::detachFromParent):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::detachFromParent):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 22:18:16 +0000 (22:18 +0000)]
Fix fast/images/exif-orientation.html WebKitTestRunner failure
https://bugs.webkit.org/show_bug.cgi?id=83627
Reviewed by Sam Weinig.
Handle overriding the WebKitShouldRespectImageOrientation preference.
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 10 Apr 2012 22:17:14 +0000 (22:17 +0000)]
Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624
Add failing tests to skipped list.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 10 Apr 2012 22:15:30 +0000 (22:15 +0000)]
remove 'win' from chromium-win, chromium-linux fallback paths
https://bugs.webkit.org/show_bug.cgi?id=83613
Reviewed by Ojan Vafai.
The chromium ports no longer need to look at the apple 'win'
directory for baseline results.
Also remove the old '-gpu-' entries from the flakiness dashboard
map since I'm touching lines nearby.
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort):
* TestResultServer/static-dashboards/flakiness_dashboard.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Tue, 10 Apr 2012 21:57:51 +0000 (21:57 +0000)]
REGRESSION(r113588): 15-30% perf. regression on CSS/CSSPropertySetterGetter.
<http://webkit.org/b/83540>
Reviewed by Antti Koivisto.
Changed the behavior of getPropertyCSSValueInternal() to actually return the internal
value rather than a cloned one. There is an assertion in the CSSValue bindings that
will catch anyone trying to expose these values to the web.
This avoids constructing "safe" CSSValue objects in the bindings layer, for the cases
where we only want to extract the cssText or numeric value. These cloned objects are
only needed when exposing fully-fledged CSSValues to the web, which must be tied to
a single document.
* css/CSSStyleDeclaration.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Tue, 10 Apr 2012 21:52:39 +0000 (21:52 +0000)]
[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675
Source/WebCore:
Added WebCore::GraphicsSurface, a wrapper class to a platform-dependant
surface that can be accessed efficiently by both the CPU and the GPU.
This will allow fast texture uploads for WebKit2, and in the future
fast copies for 2D canvas and WebGL.
The first implementation is for Mac using IOSurfaces.
TextureMapperGL had to be modified to use GL_UNSIGNED_INT_8_8_8_8_REV
for textures on Mac, since that's the native pixel format of BGRA
IOSurfaces.
Though this feature is not written in a Qt-specific way, it's currently
only enabled for Qt and is protected by USE(GRAPHICS_SURFACE).
Reviewed by Kenneth Rohde Christiansen.
Covered by existing API tests.
* Target.pri:
* WebCore.pri:
* platform/graphics/surfaces/GraphicsSurface.cpp: Added.
* platform/graphics/surfaces/GraphicsSurface.h: Added.
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp: Added.
* platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp: Added.
(WebCore::GraphicsSurface::didReleaseImage):
(WebCore):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::isOpenGLBacked):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::toBitmapTextureGL):
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore::BitmapTextureGL::isOpenGLBacked):
(WebCore):
Source/WebKit2:
Added ShareableSurface, a class allowing the use of GPU-enabled
surfaces for bitmap transfer between the web and UI processes.
Since GraphicsSurfaces may not always be available, ShareableSurface
uses a standard ShareableBitmap as a fallback backend.
The necessary plumbing was added in WebKit2 for passing updates via
ShareableSurfaces instead of ShareableBitmaps. SurfaceUpdateInfo was
added, as to not make UpdateInfo more complicated.
Reviewed by Kenneth Rohde Christiansen.
* Shared/ShareableSurface.cpp: Added.
* Shared/ShareableSurface.h: Added.
* Shared/SurfaceUpdateInfo.cpp: Added.
* Shared/SurfaceUpdateInfo.h: Added.
* Target.pri:
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.messages.in:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::updateTile):
* UIProcess/WebLayerTreeRenderer.h:
(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):
* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::updateTile):
* UIProcess/qt/LayerBackingStore.h:
(LayerBackingStoreTile):
(LayerBackingStore):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.h:
(WebKit):
(TiledBackingStoreRemoteTileClient):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(WebKit::UpdateAtlas::surface):
(WebKit::UpdateAtlas::size):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::beginContentUpdate):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
Tools:
Enable graphics surfaces on Mac for Qt.
Reviewed by Kenneth Rohde Christiansen.
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 21:52:13 +0000 (21:52 +0000)]
Add fast/dom/inline-event-attributes-release.html to the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 21:45:35 +0000 (21:45 +0000)]
Web Inspector: split nodes and edges array in heap profiler serialization.
https://bugs.webkit.org/show_bug.cgi?id=83465
Frontend is now able to read format when nodes and edges arrive
in two separate arrays.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-04-10
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype._parseIntArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
LayoutTests:
* inspector/profiler/heap-snapshot-loader-expected.txt:
* inspector/profiler/heap-snapshot-loader.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 21:41:08 +0000 (21:41 +0000)]
CSS box-shadow default color should be something other than transparent
https://bugs.webkit.org/show_bug.cgi?id=58511
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-10
Reviewed by Simon Fraser.
Source/WebCore:
If box-shadow or text-shadow color is not specified, color defaults to
the value specified in the 'color' property of the element (as specified in W3C
spec).
Test: fast/text/text-shadow-no-default-color.html. Also existing
tests ietestcenter/css3/box-shadow-002 and ietestcenter/css3/box-shadow-003
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
LayoutTests:
Added new test for the case where no color is specified for text
shadow. This test and two others are marked as expected fail pending
rebaseline.
* fast/text/text-shadow-no-default-color.html: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 10 Apr 2012 21:28:57 +0000 (21:28 +0000)]
AudioParam must support connections from audio-rate signals
https://bugs.webkit.org/show_bug.cgi?id=83524
Source/WebCore:
Reviewed by Eric Carlson.
In the Web Audio API, it's possible to connect one AudioNode to another AudioNode.
Similary we should allow an AudioNode to connect to an AudioParam, thus controlling
a parameter with an audio-rate signal. This is important in many audio processing
applications.
Test: webaudio/audioparam-connect-audioratesignal.html
Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().
* Modules/webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::process):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::connect): Add connect() method from AudioNode -> AudioParam.
(WebCore):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::finishDeref):
Use AudioNodeOutput::disconnectAll() instead of AudioNodeOutput::disconnectAllInputs().
* Modules/webaudio/AudioNode.h: Add connect() method from AudioNode -> AudioParam.
(WebCore):
(AudioNode):
* Modules/webaudio/AudioNode.idl: Add connect() method from AudioNode -> AudioParam.
Implement support for an AudioNodeOutput to fanout to multiple AudioParams.
* Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateRenderingState): Update rendering state related to AudioParams.
(WebCore::AudioNodeOutput::pull): pull() must now take into account fanout to AudioParams for in-place processing.
(WebCore::AudioNodeOutput::fanOutCount):
(WebCore):
(WebCore::AudioNodeOutput::paramFanOutCount): New method keeping track of number of connections to AudioParams.
(WebCore::AudioNodeOutput::renderingParamFanOutCount): New method keeping track of number of connections to AudioParams for rendering.
(WebCore::AudioNodeOutput::addParam): Add a connection to an AudioParam.
(WebCore::AudioNodeOutput::removeParam): Remove a connection to an AudioParam.
(WebCore::AudioNodeOutput::disconnectAllParams): Remove all connections to AudioParams.
(WebCore::AudioNodeOutput::disconnectAll): New method to disconnect all AudioNodeInputs and AudioParams.
* Modules/webaudio/AudioNodeOutput.h:
(AudioNodeOutput):
Allow an AudioParam to accept a connection from an AudioNodeOutput, thus being controlled
by an audio-rate signal.
* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateSampleAccurateValues): Calculates sample-accurate values from timeline or an AudioNode.
(WebCore):
(WebCore::AudioParam::calculateAudioRateSignalValues): Calculates sample-accurate values from an AudioNode.
(WebCore::AudioParam::calculateTimelineValues): Calculates sample-accurate values scheduled on the timeline.
(WebCore::AudioParam::connect): Connect from an AudioNodeOutput for control from an audio-rate signal.
(WebCore::AudioParam::disconnect): Disconnect from an AudioNodeOutput.
* Modules/webaudio/AudioParam.h:
(WebCore):
(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::hasSampleAccurateValues): Change name from hasTimelineValues() and return true
either if we have timeline values or if we've been connected from an AudioNode.
(AudioParam):
Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().
* Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):
LayoutTests:
Reviewed by Eric Carlson.
* webaudio/audioparam-connect-audioratesignal-expected.txt: Added.
* webaudio/audioparam-connect-audioratesignal.html: Added.
* webaudio/resources/audio-testing.js:
(createLinearRampBuffer):
(createConstantBuffer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 21:16:54 +0000 (21:16 +0000)]
[CMake][WIN] Add /MP flag when using a compiler with support for it
https://bugs.webkit.org/show_bug.cgi?id=83577
Reviewed by Daniel Bates.
* Source/cmake/OptionsWindows.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 21:14:45 +0000 (21:14 +0000)]
[CMake] Add missing DERIVED_SOURCES_WEBKIT_DIR variable
https://bugs.webkit.org/show_bug.cgi?id=83573
Reviewed by Daniel Bates.
We need this variable when ports want to generate files in the WebKit target.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 10 Apr 2012 21:12:14 +0000 (21:12 +0000)]
Remove unused data member from Lexer class
https://bugs.webkit.org/show_bug.cgi?id=83429
Reviewed by Kentaro Hara.
I noticed that m_delimited was "write-only", so I deleted it.
* parser/Lexer.cpp:
(JSC::Lexer::setCode): Removed code to set m_delimited.
(JSC::Lexer::parseIdentifier): Ditto.
(JSC::Lexer::parseIdentifierSlowCase): Ditto.
(JSC::Lexer::lex): Ditto.
* parser/Lexer.h: Deleted m_delimited.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 21:07:26 +0000 (21:07 +0000)]
[CMake] Enable USE_FOLDERS property
https://bugs.webkit.org/show_bug.cgi?id=83571
Reviewed by Daniel Bates.
.:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* Source/cmake/OptionsCommon.cmake:
Source/JavaScriptCore:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
* shell/CMakeLists.txt:
Source/WebCore:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
Source/WebKit:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
Source/WebKit2:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
Source/WTF:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* wtf/CMakeLists.txt:
Tools:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* WinCELauncher/CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 21:05:26 +0000 (21:05 +0000)]
[CMake] CMake SVG Code Generation fails to generate code for extra defines
https://bugs.webkit.org/show_bug.cgi?id=83562
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10
Reviewed by Rob Buis.
Fixing CMakeLists.txt to generate correct extra defines for SVG code generator.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 10 Apr 2012 20:32:16 +0000 (20:32 +0000)]
Crash due to captions list not updated after section recalc.
https://bugs.webkit.org/show_bug.cgi?id=83552
Reviewed by Julien Chaffraix.
Source/WebCore:
Test: fast/table/table-caption-not-removed-crash.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): no need to set the need for
section recalc. It was needed in old code when we had more than
one caption and we need to call section recalc to destroy the other
captions.
(WebCore::RenderTable::recalcSections): need to rebuild captions list.
This is how the old code worked before r100177. Basically, children can
moved without calling RenderTable::removeChild, so we should depend on
recalcSections to update our captions list. Also, fix a style nit of aligning
case labels with the switch statement.
LayoutTests:
* fast/table/table-caption-not-removed-crash-expected.txt: Added.
* fast/table/table-caption-not-removed-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 19:55:18 +0000 (19:55 +0000)]
[BlackBerry] Crash when tearing down web page rendered using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=83567
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-10
Reviewed by Antonio Gomes.
Fixed by checking if there's a layer renderer before calling into it.
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 19:48:06 +0000 (19:48 +0000)]
Unreviewed, rolling out r113611.
http://trac.webkit.org/changeset/113611
https://bugs.webkit.org/show_bug.cgi?id=71541
Broke fast/forms/basic-textareas.html
Source/WebCore:
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):
LayoutTests:
* fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Removed.
* fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Removed.
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 19:45:47 +0000 (19:45 +0000)]
Unreviewed, rolling out r113734.
http://trac.webkit.org/changeset/113734
https://bugs.webkit.org/show_bug.cgi?id=83606
causing a bunch of unrelated test failures (Requested by
simonjam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-10
Source/WebCore:
* Modules/battery/BatteryController.cpp:
* Modules/battery/BatteryController.h:
(BatteryController):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
Source/WebKit/chromium:
* WebKit.gyp:
* features.gypi:
* public/WebBatteryStatus.h: Removed.
* public/WebBatteryStatusClient.h: Removed.
* public/WebView.h:
(WebKit):
(WebView):
* public/WebViewClient.h:
(WebKit):
* src/BatteryClientImpl.cpp: Removed.
* src/BatteryClientImpl.h: Removed.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 10 Apr 2012 19:41:41 +0000 (19:41 +0000)]
Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=83528
Reviewed by Kentaro Hara.
Instead of using a run-time call to isActiveNode to determine which
map to put a Node wrapper in, generate the proper call in the CodeGenerator.
This was originally part of r112318, which got rolled out due to OOM concerns.
I'm splitting it into smaller pieces so that each can be landed and
watched for issues seperately.
No new tests, no change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use new GetDomMapName function to
figure out which setJSWrapper to call.
(GenerateNamedConstructorCallback): ditto.
(GetDomMapFunction): Delegate to GetDomMapName for logic.
(GetDomMapName): New helper factored out of GetDomMapFunction.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Assert !isActiveNode instead of branching on it.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): New method split ouf of the above.
Assert isActiveNode instead of branching on it.
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 19:36:14 +0000 (19:36 +0000)]
Pass PropertyHandler by reference in CSSStyleApplyProperty.h.
https://bugs.webkit.org/show_bug.cgi?id=83551
Reviewed by Kentaro Hara.
No new tests / cleanup only.
* css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyHandler):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 19:31:04 +0000 (19:31 +0000)]
Pass FontDescription as const reference instead of by value in CSSStyleSelector.h.
https://bugs.webkit.org/show_bug.cgi?id=83548
Reviewed by Kentaro Hara.
FontDescription is relatively large, so pass-by-reference is preferred.
No new tests / code cleanup only.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 10 Apr 2012 19:23:48 +0000 (19:23 +0000)]
Add TestNode.idl to run-binding-tests
https://bugs.webkit.org/show_bug.cgi?id=83599
Reviewed by Adam Barth.
TestNode.idl is a minimized version of Node.idl with enough attributes
to exercise CodeGenerator.pm's handling of Node subtypes.
* bindings/scripts/test/CPP/WebDOMTestNode.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestNode.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestNode.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h: Added.
* bindings/scripts/test/JS/JSTestNode.cpp: Added.
* bindings/scripts/test/JS/JSTestNode.h: Added.
* bindings/scripts/test/ObjC/DOMTestNode.h: Added.
* bindings/scripts/test/ObjC/DOMTestNode.mm: Added.
* bindings/scripts/test/ObjC/DOMTestNodeInternal.h: Added.
* bindings/scripts/test/TestNode.idl: Added.
* bindings/scripts/test/V8/V8TestNode.cpp: Added.
* bindings/scripts/test/V8/V8TestNode.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 19:15:36 +0000 (19:15 +0000)]
msqrt's implied mrow should do operator stretching
https://bugs.webkit.org/show_bug.cgi?id=82353
Patch by David Barton <dbarton@mathscribe.com> on 2012-04-10
Reviewed by Julien Chaffraix.
Source/WebCore:
An <msqrt> with more than one child is supposed to surround them with an implied <mrow>.
This patch does this, and thus includes vertical operator stretching. We also fix some
problems with the old RenderMathMLSquareRoot.cpp: possibly shared RenderStyles were
being modified, and layout() was using heights of children without checking whether they
needed layout themselves first.
To leave room for the radical sign, we use intrinsic padding. This is simpler and more
efficient than using anonymous RenderStyles.
Added tests to mo-stretch.html and style.xhtml. Regression tests are in roots.xhtml.
* css/mathml.css:
(msqrt):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore):
(WebCore::RenderMathMLSquareRoot::addChild):
(WebCore::RenderMathMLSquareRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLSquareRoot::computeLogicalHeight):
(WebCore::RenderMathMLSquareRoot::layout):
(WebCore::RenderMathMLSquareRoot::paint):
* rendering/mathml/RenderMathMLSquareRoot.h:
(RenderMathMLSquareRoot):
LayoutTests:
* mathml/presentation/mo-stretch.html:
* mathml/presentation/style.xhtml:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/style-expected.png:
* platform/mac/mathml/presentation/style-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 19:10:53 +0000 (19:10 +0000)]
Don't allow fallthrough for CSSPropertyBaselineShift in CSSComputedStyleDeclaration::getSVGPropertyCSSValue().
https://bugs.webkit.org/show_bug.cgi?id=83536
Reviewed by Daniel Bates.
Add a return statement to the case CSSPropertyBaselineShift so that we don't fall through to the next case statement.
No new tests / code cleanup from coverity static analysis.
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 10 Apr 2012 18:56:57 +0000 (18:56 +0000)]
2012-04-10 Alejandro G. Castro <alex@igalia.com>
[GTK] Build fix TextureMapper compilation and solve warning.
Reviewed by Martin Robinson.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderManager::getShaderProgram):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 18:46:38 +0000 (18:46 +0000)]
Add fast/events/drop-handler-should-not-stop-navigate.html.
Like fast/events/drop-with-file-paths.html, this expects eventSender.beginDragWithFiles to be implemented.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 18:44:05 +0000 (18:44 +0000)]
Add fast/events/drop-with-file-paths.html to the WebKit2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Tue, 10 Apr 2012 18:29:09 +0000 (18:29 +0000)]
[GTK] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83152
Reviewed by Martin Robinson.
Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.
No new tests, refactoring only, covered by existing canvas tests.
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::encodeImage): Output the encoded image to the provided GOwnPtr<gchar>&
buffer. Update GTK document reference to a valid URL. Round the quality argument
to an int like the toDataURL() implementations of other ports. Ditch the success
variable; instead test the GError* error return to indicate success.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Format the dataURL encoding of the mimeType
encoded image data buffer herein.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Tue, 10 Apr 2012 18:20:10 +0000 (18:20 +0000)]
Add test expectations for Mac debug builds.
Unreviewed.
* platform/chromium-mac-snowleopard/fast/dom/shadow: Added.
* platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 10 Apr 2012 18:17:53 +0000 (18:17 +0000)]
[chromium] Defer texture id allocation for copies until the actual copy executes
https://bugs.webkit.org/show_bug.cgi?id=83514
Reviewed by Adrienne Walker.
Source/WebCore:
This allows for queuing a texture copy operation into a ManagedTexture whose texture ID has not yet been
allocated. The ManagedTexture* serves as a promise that an ID will be available when the copy is executed.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::appendManagedCopy):
(WebCore):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
(ManagedCopyEntry):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
Source/WebKit/chromium:
* tests/CCTiledLayerTestCommon.cpp:
* tests/CCTiledLayerTestCommon.h:
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 10 Apr 2012 18:14:43 +0000 (18:14 +0000)]
Add ref test expected result.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 10 Apr 2012 18:14:20 +0000 (18:14 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83595
<rdar://problem/
10443278> Overlapping text in table cell across column break
If a cell's height changes such that it is taller than the overall row height because
of pagination, then grow the entire row height to enclose the cell instead of shrinking
the cell.
Reviewed by Dan Bernstein.
Added fast/multicol/cell-shrinkback.html
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83595
Add new layout test for cells paginating across columns.
Reviewed by Dan Bernstein.
* fast/multicol/cell-shrinkback.html: Added.
* fast/multicol/cell-shrinkback-expected.html: Added.
* platform/mac/fast/multicol/table-vertical-align-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 18:10:45 +0000 (18:10 +0000)]
Remove unnecessary null check in void SimplifyMarkupCommand::doApply().
https://bugs.webkit.org/show_bug.cgi?id=83535
Reviewed by Kentaro Hara.
No new tests / code cleanup only.
currentNode cannot be null within the loop body.
It is dereferenced before and after the removed line without checking.
Additionally I have added an assertion to express this loop invariant.
* editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 17:47:50 +0000 (17:47 +0000)]
Add Encrypted Media Extensions methods to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82971
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
Source/WebCore:
Tests: media/encrypted-media/encrypted-media-not-loaded.html
media/encrypted-media/encrypted-media-syntax.html
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitEncryptedMediaEnabled):
* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::exceptionCodeForMediaKeyException):
(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):
(WebCore::HTMLMediaElement::webkitCancelKeyRequest):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::showingTrackWithSameKind):
(WebCore::HTMLMediaElement::didAddTrack):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(NullMediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayer::generateKeyRequest):
(WebCore::MediaPlayer::addKey):
(WebCore::MediaPlayer::cancelKeyRequest):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::addKey):
(WebCore::MediaPlayerPrivateInterface::generateKeyRequest):
(WebCore::MediaPlayerPrivateInterface::cancelKeyRequest):
Source/WebKit/chromium:
* features.gypi:
* public/WebMediaPlayer.h:
(WebKit):
(WebMediaPlayer):
(WebKit::WebMediaPlayer::generateKeyRequest):
(WebKit::WebMediaPlayer::addKey):
(WebKit::WebMediaPlayer::cancelKeyRequest):
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit):
(WebKit::WebMediaPlayerClientImpl::generateKeyRequest):
(WebKit::WebMediaPlayerClientImpl::addKey):
(WebKit::WebMediaPlayerClientImpl::cancelKeyRequest):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::isMediaStreamEnabled):
(WebKit::WebRuntimeFeatures::enableEncryptedMedia):
(WebKit):
(WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled):
Tools:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
* media/encrypted-media/encrypted-media-not-loaded-expected.txt: Added.
* media/encrypted-media/encrypted-media-not-loaded.html: Added.
* media/encrypted-media/encrypted-media-syntax-expected.txt: Added.
* media/encrypted-media/encrypted-media-syntax.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 17:28:25 +0000 (17:28 +0000)]
[chromium] Add Battery Status API support.
Source/WebCore:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
This change is covered by tests in batterystatus/.
* Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::updateBatteryStatus):
(WebCore):
* Modules/battery/BatteryController.h:
(BatteryController):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
Source/WebKit/chromium:
The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-
20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
* WebKit.gyp:
* features.gypi:
* public/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):
* public/WebBatteryStatusClient.h: Added.
(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):
* public/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):
* public/WebViewClient.h:
(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):
* src/BatteryClientImpl.cpp: Added.
(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):
* src/BatteryClientImpl.h: Added.
(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 10 Apr 2012 17:25:01 +0000 (17:25 +0000)]
getShaderFormatPrecision should return sensible values
https://bugs.webkit.org/show_bug.cgi?id=83520
Reviewed by Kenneth Russell.
Source/WebCore:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Fix getShaderPrecisionFormat values.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
* platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
LayoutTests:
* fast/canvas/webgl/shader-precision-format-expected.txt:
* fast/canvas/webgl/shader-precision-format.html: Add tests to make sure getShaderPrecisionFormat returns sensible values.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 10 Apr 2012 17:18:27 +0000 (17:18 +0000)]
Web Inspector: Add Galaxy Nexus to the list of emulated user agents
https://bugs.webkit.org/show_bug.cgi?id=83589
The new record contains the device display metrics and the User Agent string.
Reviewed by Pavel Feldman.
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 10 Apr 2012 17:11:10 +0000 (17:11 +0000)]
Add missing methods and operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=82403
Reviewed by Eric Seidel.
Add missing methods and operators and from branch version of
FractionalLayoutUnit. Also fix overflow assertion and add const keyword
to a couple of methods.
No new tests.
* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::abs):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
(WebCore::FractionalLayoutUnit::floor):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator<):
(WebCore):
(WebCore::operator-):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 10 Apr 2012 17:07:21 +0000 (17:07 +0000)]
2012-04-10 Zhenyao Mo <zmo@google.com>
Unreviewed, roll chromium to 131469
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 10 Apr 2012 17:04:41 +0000 (17:04 +0000)]
WebAudio: propagate a silence hint through the AudioNode graph.
https://bugs.webkit.org/show_bug.cgi?id=74553
Reviewed by Chris Rogers.
No new tests; optimization of existing code path, so covered by existing tests.
Introduce the concept of a "silent" channel:
* platform/audio/AudioChannel.h:
(WebCore::AudioChannel::AudioChannel):
(WebCore::AudioChannel::set): Clear silent bit.
(WebCore::AudioChannel::zero): Set silent bit.
(WebCore::AudioChannel::clearSilentFlag): Clear silent bit.
(WebCore::AudioChannel::isSilent): Accessor.
Optimize a few channel operations when the source or destination channels are silent.
* platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::scale): No-op on a silent channel.
(WebCore::AudioChannel::copyFrom): zero() when source is silent.
(WebCore::AudioChannel::copyFromRange): possibly zero() when source is silent.
(WebCore::AudioChannel::sumFrom): No-op when source is silent.
(WebCore::AudioChannel::maxAbsValue): 0 on a silent channel.
Optimize a few bus operations when the source or destination channels are silent.
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::processWithGainFromMonoStereo): No-op if source is silent and either
the destination bus is silent, or the output is not summed to the destination.
(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom): zero() if the source is silent
and the lengths of the gain values, source, and destination match.
(WebCore::AudioBus::createBySampleRateConverting): Return an empty bus if the source is silent.
(WebCore::AudioBus::createByMixingToMono): Ditto; clear the destination's silent bit otherwise.
(WebCore::AudioBus::isSilent): Return whether all channels are silent.
(WebCore::AudioBus::clearSilentFlag): Clear silent bit of constituent channels.
* platform/audio/AudioBus.h:
Make sure that classes which generate audio clear their busses' silent bit.
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process): Ditto.
(WebCore::AudioBufferSourceNode::renderFromBuffer): Ditto.
(WebCore::AudioBufferSourceNode::propagatesSilence): Propagate silence only when the source node
has nothing left to render.
* webaudio/AudioBufferSourceNode.h:
(WebCore::AudioBufferSourceNode::playbackState): Made const correct.
(WebCore::AudioBufferSourceNode::isPlaying): Added simple accessor.
(WebCore::AudioBufferSourceNode::hasFinished): Ditto.
* webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::currentSampleFrame): Made const correct.
(WebCore::AudioDestinationNode::currentTime): Ditto.
Audio nodes should not process audio data when the input is silent and the nodes will propagate silences.
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::processIfNecessary):
(WebCore::AudioNode::inputsAreSilent): Convenience function which walk over the node's inputs.
(WebCore::AudioNode::silenceOutputs): Ditto.
(WebCore::AudioNode::unsilenceOutputs): Ditto.
* webaudio/AudioNode.h:
(WebCore::AudioNode::propagatesSilence):
These Nodes can generate audio when given silent input, so return false from propagatesSilence.
* Modules/webaudio/Oscillator.h:
(WebCore::Oscillator::propagatesSilence): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 10 Apr 2012 16:40:46 +0000 (16:40 +0000)]
[Chromium] Unreviewed, add baselines for fast/dom/shadow/selection-in-shadow.html
* platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 10 Apr 2012 16:36:45 +0000 (16:36 +0000)]
It should be possible to see why a code block was not compiled by the DFG
https://bugs.webkit.org/show_bug.cgi?id=83553
Reviewed by Geoff Garen.
If DFG_ENABLE(DEBUG_VERBOSE) and a code block is rejected, then print the
opcode that caused the rejection.
* dfg/DFGCapabilities.cpp:
(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 10 Apr 2012 16:29:47 +0000 (16:29 +0000)]
Unreviewed - adding myself as a committer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 16:22:23 +0000 (16:22 +0000)]
[EFL][DRT] Catch the "title,changed" signal
https://bugs.webkit.org/show_bug.cgi?id=82174
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-10
Reviewed by Gustavo Noronha Silva.
Tools:
EFL's DumpRenderTree now catches the "title,changed" signal, and
prints out the needed information.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onTitleChanged):
LayoutTests:
Unskip tests which requires EFL's DumpRenderTree to catch the
"title,changed" signal and print out information, now that it
is implemented.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yi.4.shen@nokia.com [Tue, 10 Apr 2012 16:19:41 +0000 (16:19 +0000)]
Pressing enter on blank line after bullet deletes entire bulleted line.
https://bugs.webkit.org/show_bug.cgi?id=82690
Reviewed by Enrica Casucci.
In CompositeEditCommand::breakOutOfEmptyListItem(), it checks the empty list item's renderer's siblings
to decide which empty part of the list should be removed. However, if the empty list item's renderer is
wrapped by an anonymous block, e.g. <ul><li>hello</li><br>^</ul>, the check may fail. So, we use isListItem
on the empty list node's siblings instead.
Source/WebCore:
No new tests : added new test case in the existing test (break-out-of-empty-list-item.html)
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
LayoutTests:
* editing/execCommand/break-out-of-empty-list-item-expected.txt:
* editing/execCommand/script-tests/break-out-of-empty-list-item.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 16:15:22 +0000 (16:15 +0000)]
[EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
https://bugs.webkit.org/show_bug.cgi?id=82443
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-10
Reviewed by Philippe Normand.
Tools:
EFL's DRT needs to support LayoutTestController's
willSendRequestReturnsNull() and return NULL when expected. This
allows for several tests to be removed from the skip list.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWillSendRequest):
LayoutTests:
Unskip tests which depend on EFL's DumpRenderTree support for
LayoutTestController's willSendRequestReturnsNull(), now that it is
implemented.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 10 Apr 2012 15:50:52 +0000 (15:50 +0000)]
Web Inspector: Inspect Element - Edit as HTML - scrolling bug
https://bugs.webkit.org/show_bug.cgi?id=83563
mousedown in the scrollbar focuses the Elements tree outline container DIV element,
so the corresponding mousedown event should be consumed in the AT_TARGET phase.
Reviewed by Yury Semikhatsky.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.consume):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 15:36:09 +0000 (15:36 +0000)]
[Qt][WK2] Assertion failure on loading new page after panning/zooming
https://bugs.webkit.org/show_bug.cgi?id=83049
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.
When handling contents size change, set the visible content rectangle immediately,
instead of animating to it.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::itemSizeChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 15:35:37 +0000 (15:35 +0000)]
[EFL] LayoutTestController needs implementation of addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=82446
Source/WebKit/efl:
Add missing implementation addUserStyleSheet to EFL's
DumpRenderTreeSupport.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::addUserStyleSheet):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
so that we can unskip related tests from the skip list.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addUserStyleSheet): Implemented.
LayoutTests:
Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/user-style-all-frames.html
userscripts/simple-stylesheet.html
userscripts/script-run-at-end.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Tue, 10 Apr 2012 15:33:33 +0000 (15:33 +0000)]
Adding myself to committers.py!
Unreviewed update to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 10 Apr 2012 15:33:08 +0000 (15:33 +0000)]
[Qt][WK2] Unreviewed gardening, skip a test to try to paint the bot greener.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 15:32:18 +0000 (15:32 +0000)]
Remove the unused function WebCore::toIconIndex
https://bugs.webkit.org/show_bug.cgi?id=83037
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kentaro Hara.
* WebCore.order:
* dom/IconURL.cpp:
* dom/IconURL.h:
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 15:25:53 +0000 (15:25 +0000)]
[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
titleChanged signal is not emitted on comitting a new load.
* UIProcess/API/qt/tests/html/basic_page.html:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
(tst_QQuickWebView::titleUpdate):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::didCommitLoadForFrame):
Tools:
Set window title to default if there is no page title.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::onTitleChanged):
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jesus@webkit.org [Tue, 10 Apr 2012 15:14:55 +0000 (15:14 +0000)]
[Qt][WK2] Implement PageClient::isViewWindowActive()
https://bugs.webkit.org/show_bug.cgi?id=81143
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
Tools:
Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 10 Apr 2012 14:42:19 +0000 (14:42 +0000)]
[Wk2] Gradening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=83581
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 10 Apr 2012 13:52:42 +0000 (13:52 +0000)]
[Qt] Unreviewed gardening. Skip a failing, a timeouting and a crashing test to paint the bots green.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 10 Apr 2012 12:53:37 +0000 (12:53 +0000)]
Web Inspector: make error a string on the front-end side, not an object.
https://bugs.webkit.org/show_bug.cgi?id=83570
Reviewed by Yury Semikhatsky.
Source/WebCore:
We already expect it to be a string in all the code, we never use the error code in it.
* inspector/front-end/InspectorBackend.js:
(InspectorBackendClass.prototype.dispatch):
LayoutTests:
* inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
* inspector/debugger/debugger-set-breakpoint-regex.html:
* inspector/elements/resolve-node-blocked-expected.txt:
* inspector/elements/set-attribute.html:
* inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
* inspector/report-protocol-errors-expected.txt:
* inspector/report-protocol-errors.html:
* inspector/styles/set-property-boundaries-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Tue, 10 Apr 2012 12:34:25 +0000 (12:34 +0000)]
getElementsByTagName unable to find SVG camelCase elements imported into HTML
https://bugs.webkit.org/show_bug.cgi?id=46800
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Implement getElementsByTagName according to the algorithm in
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagname.
If the owner document of the element is html, the new class HTMLTagNodeList deals with
finding the match(es) based on this algorithm. If the owner document is non HTML, the existing
TagNodeList is used.
Implement getElementsByTagNameNS according to the algorithm in
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagnamens.
The existing TagNodeList implements this algorithm.
Cached results may have less hits after this change. Tag names that are equal when case
insensitive but different when case sensitive can't share the result due to above algorithms, i.e.
they would match differently in the non html part of the document.
Tests: fast/dom/getElementsByTagName-localName-matching.html
fast/dom/getElementsByTagName-localName-matching2.xhtml
svg/dom/getElementsByTagName-localName-matching.html
* dom/Node.cpp:
(WebCore::Node::getElementsByTagName): create TagNodeList depending on owner document type.
(WebCore::Node::getElementsByTagNameNS): do not lowercase localName for html.
* dom/TagNodeList.cpp:
(WebCore::HTMLTagNodeList::HTMLTagNodeList): add specialized TagNodeList for html matching rules.
(WebCore):
(WebCore::HTMLTagNodeList::nodeMatches):
* dom/TagNodeList.h:
(TagNodeList):
(HTMLTagNodeList):
(WebCore::HTMLTagNodeList::create):
LayoutTests:
Add tests for getElementsByTagName(NS) in html, xhtml, and svg documents.
* fast/dom/getElementsByTagName-localName-matching-expected.txt: Added.
* fast/dom/getElementsByTagName-localName-matching.html: Added.
* fast/dom/getElementsByTagName-localName-matching2-expected.txt: Added.
* fast/dom/getElementsByTagName-localName-matching2.xhtml: Added.
* svg/dom/getElementsByTagName-localName-matching-expected.txt: Added.
* svg/dom/getElementsByTagName-localName-matching.html: Added.
* svg/dom/script-tests/getElementsByTagName-localName-matching.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 10 Apr 2012 12:29:15 +0000 (12:29 +0000)]
Web Inspector: [Device Metrics] Introduce the "Fit window" option
https://bugs.webkit.org/show_bug.cgi?id=83280
Source/WebCore:
This change adds the "Fit window" option to the Settings pane of Web Inspector, which lets users
resize the FrameView to fit the WebViewImpl size. When the user resizes the browser window
in the device metrics override mode with the option enabled, the FrameView follows
to match WebViewImpl by at least one dimension.
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverrideImpl):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverrideImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverride):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverride):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::updateViewMetrics):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):
* inspector/front-end/UserAgentSupport.js:
* inspector/front-end/helpScreen.css:
(.help-content input[type=checkbox]):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
Source/WebKit/chromium:
Implement the scaling of the FrameView to the WebViewImpl size, handle WebViewImpl resizes.
Reviewed by Pavel Feldman.
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::overrideDeviceMetrics):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::setDeviceMetrics):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidthOnNavigation):
(DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::webViewResized):
(WebKit::DeviceMetricsSupport::applySizeOverrideIfNecessary):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):
(WebKit::DeviceMetricsSupport::forcedScrollbarDimensions):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
(WebKit::WebDevToolsAgentImpl::webViewResized):
(WebKit):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
(WebKit::WebDevToolsAgentImpl::autoZoomPageToFitWidth):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
* src/WebDevToolsAgentPrivate.h:
(WebDevToolsAgentPrivate):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
LayoutTests:
Update the test to follow the protocol change and test the "Fit window" parameter.
Reviewed by Pavel Feldman.
* inspector/styles/override-screen-size-expected.txt:
* inspector/styles/override-screen-size.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 10 Apr 2012 11:34:06 +0000 (11:34 +0000)]
Web Inspector: use maxJSObjectId that is provided by back-end.
https://bugs.webkit.org/show_bug.cgi?id=82451
Summary view can filter objects in snapshot. It uses maxJSObjectId for this.
There was no such field in the profile header at the
moment but I've landed a patch in downstream.
Reviewed by Yury Semikhatsky.
* bindings/js/ScriptHeapSnapshot.h:
(WebCore):
(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):
* bindings/v8/ScriptHeapSnapshot.cpp:
(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):
(WebCore):
* bindings/v8/ScriptHeapSnapshot.h:
(WebCore):
(ScriptHeapSnapshot):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.updateStaticData):
* inspector/front-end/HeapSnapshotProxy.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 10 Apr 2012 11:26:53 +0000 (11:26 +0000)]
Web Inspector: annotate front-end for newer closure compiler.
https://bugs.webkit.org/show_bug.cgi?id=83478
Reviewed by Yury Semikhatsky.
This change mostly adds annotations to bound functions and !!bool expressions.
As a result, it makes closure compiler v20120305 happy.
* inspector/Inspector.json:
* inspector/front-end/BreakpointManager.js:
* inspector/front-end/CSSStyleModel.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
* inspector/front-end/ObjectPropertiesSection.js:
* inspector/front-end/RemoteObject.js:
* inspector/front-end/Resource.js:
(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
* inspector/front-end/ResourceUtils.js:
* inspector/front-end/ScopeChainSidebarPane.js:
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.get _worker):
* inspector/front-end/WorkerManager.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 10 Apr 2012 11:26:02 +0000 (11:26 +0000)]
[Qt] Gardening after r113701.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 10 Apr 2012 10:56:10 +0000 (10:56 +0000)]
Unreviewed, skip a failing test and rebaseline another one after r113611.
* platform/gtk/Skipped:
* platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 10 Apr 2012 10:38:40 +0000 (10:38 +0000)]
[EFL] Unreviewed. Gardening Add 19 missing expectations.
* platform/efl/Skipped:
* platform/efl/http/tests/loading/simple-subframe-expected.txt: Added.
* platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
* platform/efl/http/tests/misc/acid2-expected.txt: Added.
* platform/efl/http/tests/misc/error404-expected.txt: Added.
* platform/efl/http/tests/misc/favicon-as-image-expected.txt: Added.
* platform/efl/http/tests/misc/frame-access-during-load-expected.txt: Added.
* platform/efl/http/tests/misc/generated-content-inside-table-expected.txt: Added.
* platform/efl/http/tests/misc/iframe404-expected.txt: Added.
* platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
* platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
* platform/efl/http/tests/navigation/error404-basic-expected.txt: Added.
* platform/efl/http/tests/navigation/error404-goback-expected.txt: Added.
* platform/efl/http/tests/navigation/error404-subframeload-expected.txt: Added.
* platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
* platform/efl/http/tests/navigation/postredirect-basic-expected.txt: Added.
* platform/efl/http/tests/navigation/postredirect-goback1-expected.txt: Added.
* platform/efl/http/tests/uri/css-href-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 10 Apr 2012 10:10:01 +0000 (10:10 +0000)]
[Qt][WK2] TestNetscapePlugin is broken
https://bugs.webkit.org/show_bug.cgi?id=83024
Reviewed by Csaba Osztrogonác.
Tools:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
Fix X11 availability check. embedded is always true with QPA.
* Tools.pro:
Build the test plugin if plugins are enabled for WebKit2.
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/functions.prf:
Added a convenience function to determine availability
of X11 libraries.
LayoutTests:
Remove plugins from skiplist and put the rest
of failing tests to their group.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 09:52:52 +0000 (09:52 +0000)]
[WIN] Fix build without precompiled header.
* DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 10 Apr 2012 09:30:17 +0000 (09:30 +0000)]
[Qt] Gardening. Skip failing tests because of missing DnD support and ENABLE(SHADOW_DOM) is disabled.
[WK2] Skip tests because of missing layoutTestController.setAlwaysAcceptCookies().
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 10 Apr 2012 09:20:40 +0000 (09:20 +0000)]
Web Inspector: searching document with no documentElement results in 0x0 access.
https://bugs.webkit.org/show_bug.cgi?id=83483
Reviewed by Yury Semikhatsky.
Source/WebCore:
Added the null check.
Test: inspector/elements/dom-search-crash.html
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
LayoutTests:
* inspector/elements/dom-search-crash-expected.txt: Added.
* inspector/elements/dom-search-crash.html: Added.
* inspector/elements/resources/dom-search-crash-iframe.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 10 Apr 2012 08:15:53 +0000 (08:15 +0000)]
Unreviewed, GTK baselines for two new tests.
* platform/gtk/fast/events/drop-with-file-paths-expected.txt: Added.
* platform/gtk/media/nodesFromRect-shadowContent-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 10 Apr 2012 07:40:42 +0000 (07:40 +0000)]
[WK2][GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76166
Reviewed by Gustavo Noronha Silva.
* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/C/gtk/WKFullScreenClientGtk.cpp:
(WKViewSetFullScreenClientGtk): Initialize WebKitWebViewBase
fullscreen client.
* UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
* UIProcess/API/gtk/WebKitFullscreenClient.cpp: Added.
(willEnterFullScreen): Call webkitWebViewEnterFullScreen().
(willExitFullScreen): Call webkitWebViewLeaveFullScreen().
(attachFullScreenClientToView): Initialize FullScreenClient adding
implementations for willEnterFullScreen and willExitFullScreen callbacks.
* UIProcess/API/gtk/WebKitFullscreenClient.h: Added.
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Attach fullscreen client to view.
(webkit_web_view_class_init): Add WebKitWebView::enter-fullscreen
and WebKitWebView::leave-fullscreen signals.
(webkitWebViewEnterFullScreen): Emit
WebKitWebView::enter-fullscreen signal.
(webkitWebViewLeaveFullScreen): Emit
WebKitWebView::leave-fullscreen signal.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Only return early when leaving
fullscreen, otherwise let the view process the key pressed.
(webkitWebViewBaseEnterFullScreen): Return early if
willEnterFullScreen callback is handled and returns false.
(webkitWebViewBaseExitFullScreen): Return early if
willExitFullScreen callback is handled and returns false.
(webkitWebViewBaseInitializeFullScreenClient): Initialize the
fullscreen client.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewFullScreen):
(beforeAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::keyStroke): Helper function to synthesize key
press/release events.
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/webkit2marshal.list:
* UIProcess/gtk/WebFullScreenClientGtk.cpp:
(WebKit::WebFullScreenClientGtk::willEnterFullScreen): Call
willEnterFullScreen callback if defined.
(WebKit::WebFullScreenClientGtk::willExitFullScreen): Call
willExitFullScreen callback if defined.
* UIProcess/gtk/WebFullScreenClientGtk.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 07:38:21 +0000 (07:38 +0000)]
[CMake] Add missing source files to build system
Source/WebCore:
* CMakeLists.txt:
Source/WebKit2:
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 10 Apr 2012 07:29:10 +0000 (07:29 +0000)]
Unreviewed. Fixed AppleWin and Chromium-win build failure.
Renamed 'exceptionNameDescription' to per-file variable name to avoid
name conflict.
* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore::IDBDatabaseException::initializeDescription):
* Modules/webdatabase/SQLException.cpp:
(WebCore::SQLException::initializeDescription):
* dom/EventException.cpp:
(WebCore::EventException::initializeDescription):
* dom/RangeException.cpp:
(WebCore::RangeException::initializeDescription):
* fileapi/FileException.cpp:
(WebCore::FileException::initializeDescription):
* fileapi/OperationNotAllowedException.cpp:
(WebCore::OperationNotAllowedException::initializeDescription):
* svg/SVGException.cpp:
(WebCore::SVGException::initializeDescription):
* xml/XPathException.cpp:
(WebCore::XPathException::initializeDescription):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arko@motorola.com [Tue, 10 Apr 2012 07:18:35 +0000 (07:18 +0000)]
Unreviewed: adding myself to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 10 Apr 2012 07:11:37 +0000 (07:11 +0000)]
Unreviewed. Fixed AppleWin and Chromium-win build failure.
Renamed 'exceptions' to 'exceptionNameDescription' to avoid
variable name conflict.
* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore::IDBDatabaseException::initializeDescription):
* Modules/webdatabase/SQLException.cpp:
(WebCore::SQLException::initializeDescription):
* dom/EventException.cpp:
(WebCore::EventException::initializeDescription):
* dom/RangeException.cpp:
(WebCore::RangeException::initializeDescription):
* fileapi/FileException.cpp:
(WebCore::FileException::initializeDescription):
* fileapi/OperationNotAllowedException.cpp:
(WebCore::OperationNotAllowedException::initializeDescription):
* svg/SVGException.cpp:
(WebCore::SVGException::initializeDescription):
* xml/XPathException.cpp:
(WebCore::XPathException::initializeDescription):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 10 Apr 2012 07:05:16 +0000 (07:05 +0000)]
Unreviewed, GTK rebaseline.
* platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt:
* platform/gtk/editing/selection/editable-html-element-expected.txt:
* platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/send-undefined-and-null-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kaustubh@motorola.com [Tue, 10 Apr 2012 06:33:02 +0000 (06:33 +0000)]
Unreviewed: adding myself to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 06:24:57 +0000 (06:24 +0000)]
combine two arrays in XPathException into one
https://bugs.webkit.org/show_bug.cgi?id=83442
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
* xml/XPathException.cpp:
(XPathExceptionNameDescription):
(WebCore):
(WebCore::XPathException::initializeDescription):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 06:18:57 +0000 (06:18 +0000)]
combine exceptionNames and exceptionDescriptions in IDBDatabaseException.cpp into one array
https://bugs.webkit.org/show_bug.cgi?id=83433
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
* Modules/indexeddb/IDBDatabaseException.cpp:
(IDBDatabaseExceptionNameDescription):
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc