Patrick Welche [Thu, 24 Aug 2017 13:49:04 +0000 (14:49 +0100)]
configure.ac: make xkb optional, as intended
[] is not sufficient to avoid PKG_CHECK_MODULES' default action of bailing if
xkbcommon-x11 is not found.
Ask Hjorth Larsen [Sat, 26 Aug 2017 14:23:07 +0000 (16:23 +0200)]
Updated Danish translation
Mike Gorse [Mon, 21 Aug 2017 21:48:11 +0000 (16:48 -0500)]
2.25.91
Mike Gorse [Mon, 21 Aug 2017 21:44:30 +0000 (16:44 -0500)]
autoconf: include missing meson build files
Mike Gorse [Mon, 21 Aug 2017 20:51:34 +0000 (15:51 -0500)]
meson: build translations
https://bugzilla.gnome.org/show_bug.cgi?id=786377
Anish Sheela [Sun, 20 Aug 2017 17:01:48 +0000 (17:01 +0000)]
Update Malayalam translation
Mike Gorse [Thu, 10 Aug 2017 22:18:24 +0000 (17:18 -0500)]
meson: fix org.a11y.atspi.Registry.service
The service.in file references LIBEXECDIR, but meson was setting libexecdir.
Use libexecdir for consistency.
Mike Gorse [Tue, 8 Aug 2017 02:25:13 +0000 (21:25 -0500)]
More meson fixes
Mike Gorse [Tue, 8 Aug 2017 00:07:36 +0000 (19:07 -0500)]
2.25.90
Mike Gorse [Tue, 8 Aug 2017 00:01:18 +0000 (19:01 -0500)]
meson: add support for gobject-introspection
Not 100% sure that this is done. The shared-library line seems wrong.
Pawan Chitrakar [Tue, 25 Jul 2017 09:25:28 +0000 (09:25 +0000)]
Add Nepali translation
Shinwoo Kim [Fri, 23 Jun 2017 02:02:47 +0000 (11:02 +0900)]
Decrements the reference count of session_bus
dbus_bus_get increments reference count of a DBusConnection.
It is callers responsibility to all dbus_connection_unref after use.
Rico Tzschichholz [Mon, 3 Jul 2017 17:42:48 +0000 (19:42 +0200)]
Fix a couple of introspection issues
This mainly restores the gir entry for AtspiApplication.
https://bugzilla.gnome.org/show_bug.cgi?id=784481
Mike Gorse [Tue, 20 Jun 2017 17:50:04 +0000 (12:50 -0500)]
2.25.4
Mike Gorse [Tue, 20 Jun 2017 17:45:16 +0000 (12:45 -0500)]
Makefile.am: pass headers to g-ir-scanner
Otherwise we get a bad .gir file.
https://bugzilla.gnome.org/show_bug.cgi?id=783994
Piotr Drąg [Tue, 20 Jun 2017 15:28:53 +0000 (17:28 +0200)]
Update po/Makevars
Mike Gorse [Tue, 20 Jun 2017 03:00:52 +0000 (22:00 -0500)]
Add meson build files to Makefile.am
Fix typo
Mike Gorse [Tue, 20 Jun 2017 01:46:39 +0000 (20:46 -0500)]
2.25.3
Mike Gorse [Wed, 14 Jun 2017 00:36:55 +0000 (19:36 -0500)]
Merge branch 'wip/meson'
Mike Gorse [Fri, 2 Jun 2017 21:26:33 +0000 (16:26 -0500)]
Poll direct dbus connections in the main loop
If a process was marked as hung, then we send a ping with the intention
of removing it from the list of hung processes when a reply to the ping is
received. However, we weren't necessarily polling the connection, so we
wouldn't see the reply to the ping, meaning that the process could be
marked as hung indefinitely.
https://bugzilla.mozilla.org/show_bug.cgi?id=789038
Joanmarie Diggs [Tue, 23 May 2017 16:50:48 +0000 (18:50 +0200)]
Add error-message, error-for, details, and details-for relation types
Also update documentation of description-for and described-by relation
types to help clarify which relation type is most suitable for each of
the accessible descriptions.
https://bugzilla.gnome.org/show_bug.cgi?id=782999
Shinwoo Kim [Tue, 21 Feb 2017 06:50:48 +0000 (15:50 +0900)]
Fix memory leak of at-spi-bus-launcher
Allocated memory by g_variant_new_boolean in handle_a11y_enabled_change, handle_screen_reader_enabled_change is not released.
Iain Lane [Tue, 23 May 2017 09:39:44 +0000 (10:39 +0100)]
Fix -Wmisleading-indentation warnings
There are a couple of places where code is indented as if it should be
part of an `if' block, but it isn't because there are no braces. Fix
those by unindenting.
Caught by -Werror=misleading-indentation.
Mike Gorse [Fri, 26 May 2017 02:03:45 +0000 (21:03 -0500)]
bump version
Emmanuele Bassi [Wed, 24 May 2017 13:16:38 +0000 (14:16 +0100)]
build: Modernise configure.ac
We use AM_SILENT_RULES but ask for automake 1.9 at the minimum, which
didn't have AM_SILENT_RULES (they were introduced in 1.11.2).
Additionally, we want AM_PROC_CC_C_O, not AC_PROG_CC, to find out our
C compiler.
Emmanuele Bassi [Wed, 24 May 2017 13:04:49 +0000 (14:04 +0100)]
Drop uninstalled pkg-config file
The use of uninstalled pkg-config files has always been dubious to begin
with. Builds using a separate prefix should modify the PKG_CONFIG_PATH,
instead of pointing to build directories.
Emmanuele Bassi [Wed, 24 May 2017 13:03:10 +0000 (14:03 +0100)]
build: Use modern introspection
Do not copy an older version of the introspection.m4 macro, and depend
on a recent version of gobject-introspection.
Emmanuele Bassi [Wed, 24 May 2017 13:00:26 +0000 (14:00 +0100)]
Drop intltool
We are not using any of its features, so we can simply use upstream
gettext.
Emmanuele Bassi [Wed, 24 May 2017 12:52:05 +0000 (13:52 +0100)]
build: Find sed, instead of assuming it's in PATH
Emmanuele Bassi [Wed, 24 May 2017 11:27:45 +0000 (12:27 +0100)]
build: Clean up libatspi
The sources list includes the headers twice, for good measure; the
installed headers list includes a source file. The enumeration types are
generated in the source directory, and blown away regardless if their
content did not change.
Emmanuele Bassi [Wed, 24 May 2017 11:20:00 +0000 (12:20 +0100)]
build: Ensure that libatspi depends on libdbind
With heavy parallelisation we may end up in a case where libatspi is
built before libdbind.
Emmanuele Bassi [Wed, 24 May 2017 11:18:13 +0000 (12:18 +0100)]
build: Clean up X11 detection and build
Use pkg-config, and take the build into the early XXI century.
Emmanuele Bassi [Wed, 24 May 2017 10:56:56 +0000 (11:56 +0100)]
Remove xevie support
The Xevie extension was removed from X.org in 2008:
https://freedesktop.org/wiki/Software/XEvIE/
* XEvIE has been removed from HEAD on Wed Oct 22:
http://cgit.freedesktop.org/xorg/xserver/commit/?id=
f4036f6ace5f770f0fe6a6e3dc3749051a81325a
> It's unmaintained and has been broken for quite a while; MPX finally
> smashed it completely.
Emmanuele Bassi [Mon, 22 May 2017 14:54:24 +0000 (15:54 +0100)]
Add Meson build system
Meson is a meta-build system which provides us with various advantages
over Autotools:
- it's portable to various platforms
- it's easy to understand
- it's fast
- it's well maintained
Various libraries in the GNOME stack have been ported to it, including
GTK+ itself.
Mike Gorse [Tue, 23 May 2017 01:31:44 +0000 (20:31 -0500)]
2.25.2
Joanmarie Diggs [Fri, 19 May 2017 07:58:16 +0000 (09:58 +0200)]
Add a "footnote" role.
https://bugzilla.gnome.org/show_bug.cgi?id=782820
Joanmarie Diggs [Wed, 17 May 2017 15:25:17 +0000 (17:25 +0200)]
Add roles for description list, description term, and description value
https://bugzilla.gnome.org/show_bug.cgi?id=782041
Mike Gorse [Thu, 18 May 2017 18:04:48 +0000 (13:04 -0500)]
bump version
Mike Gorse [Mon, 8 May 2017 23:59:40 +0000 (18:59 -0500)]
atspi_accessible_get_parent: move check for NULL AtspiApplication object
Now, if we don't have a cached parent, then we always either return NULL
or make a D-Bus call. This might make the code more robust, and hoping
that it will fix https://bugzilla.gnome.org/show_bug.cgi?id=767074,
though in theory it should make no difference there.
Mike Gorse [Mon, 24 Apr 2017 22:42:52 +0000 (17:42 -0500)]
2.25.1
Mike Gorse [Mon, 27 Mar 2017 17:57:35 +0000 (12:57 -0500)]
atspi_table_cell_get_position: don't crash on error
Yuras Shumovich [Sun, 26 Mar 2017 15:32:01 +0000 (15:32 +0000)]
Update Belarusian translation
Mike Gorse [Mon, 20 Mar 2017 22:21:30 +0000 (17:21 -0500)]
2.24.0
Mike Gorse [Mon, 13 Mar 2017 22:04:47 +0000 (17:04 -0500)]
2.23.92
Mike Gorse [Mon, 13 Mar 2017 21:56:34 +0000 (16:56 -0500)]
Table cell API fixes
We had a non-working get_column_index function and no get_row_index
function. GetPosition is the only function implemented on at-spi2-atk.
Removed the non-working functions, for consistency, and add a missing
prototype for atspi_table_cell_get_position.
https://bugzilla.gnome.org/show_bug.cgi?id=779835
Mike Gorse [Mon, 13 Feb 2017 22:44:58 +0000 (16:44 -0600)]
2.23.90
Mike Gorse [Wed, 25 Jan 2017 00:10:52 +0000 (18:10 -0600)]
atspi_application_dispose: clear root accessible's ref to the app
Hoping that this might fix https://bugzilla.gnome.org/show_bug.cgi?id=767074
Mike Gorse [Tue, 17 Jan 2017 02:08:04 +0000 (20:08 -0600)]
2.23.4
Alejandro Piñeiro [Mon, 9 Jan 2017 16:20:44 +0000 (14:20 -0200)]
roles: EXTENDED roles are deprecated
ATK extended roles were deprecated some years ago.
https://bugzilla.gnome.org/show_bug.cgi?id=720123
Alejandro Piñeiro [Thu, 5 Dec 2013 12:31:22 +0000 (13:31 +0100)]
events: add recently added page changed event
https://bugzilla.gnome.org/show_bug.cgi?id=719898
Alberts Muktupāvels [Sun, 4 Dec 2016 13:42:01 +0000 (15:42 +0200)]
at-spi-bus-launcher: session management fixes
Mike Gorse [Wed, 28 Dec 2016 17:40:43 +0000 (12:40 -0500)]
Revert "at-spi-bus-launcher: session management fixes"
https://bugzilla.gnome.org/show_bug.cgi?id=774441
This reverts commit
253ada975e0a374e7b1a6a07d2a483dd1d8c52fa.
Mike Gorse [Wed, 28 Dec 2016 17:40:34 +0000 (12:40 -0500)]
Revert "At-spi-bus-launcher: fix uninitialized variable"
https://bugzilla.gnome.org/show_+bug.cgi?id=774441
This reverts commit
995a8cd70cad2a1e8d434a59d87e8cebd5817612.
Mike Gorse [Wed, 28 Dec 2016 17:38:23 +0000 (12:38 -0500)]
Revert "Fix return value error in session_manager_connect"
These session management fixes appear to have been wrong, as gnome-session
waits for the bus launcher to register before entering the application
start-up phase.
https://bugzilla.gnome.org/show_bug.cgi?id=774441
This reverts commit
f66c04544575532849a60b1d145fd69fc0261352.
Emmanuele Bassi [Fri, 18 Nov 2016 11:03:36 +0000 (11:03 +0000)]
Ensure that X11 symbols are only used when necessary
Since at-spi2-core can be build with X11 support disabled, we need to
ensure that we include and build the X11-specific bits only when needed.
https://bugzilla.gnome.org/show_bug.cgi?id=773710
Emmanuele Bassi [Fri, 18 Nov 2016 10:57:42 +0000 (10:57 +0000)]
Revert "Block out X11 API with #ifdefs"
This reverts commit
27e7b242d65a78d40d68f20ac375929914c3b7a8.
The build breaks with X11 support enabled.
https://bugzilla.gnome.org/show_bug.cgi?id=773710
Mike Gorse [Sat, 19 Nov 2016 08:57:49 +0000 (02:57 -0600)]
Revert "registryd: Include config.h before checking HAVE_X11"
event-source.h shouldn't be compiled if X is disabled, so shouldn't be needed.
This reverts commit
1a09fbfebd6cf3361b29cf1386a402560c7c7b3b.
Philip Withnall [Thu, 17 Nov 2016 10:57:51 +0000 (10:57 +0000)]
registryd: Include config.h before checking HAVE_X11
https://bugzilla.gnome.org/show_bug.cgi?id=773710
Philip Chimento [Mon, 31 Oct 2016 05:24:04 +0000 (22:24 -0700)]
Block out X11 API with #ifdefs
We should not include any X11 headers when building with --disable-x11,
so put them inside #ifdef guards, and don't use X symbols.
https://bugzilla.gnome.org/show_bug.cgi?id=773710
Philip Chimento [Mon, 31 Oct 2016 05:12:46 +0000 (22:12 -0700)]
Copy in key mask defines from Xlib.h
This is to avoid including Xlib.h when building with --disable-x11.
https://bugzilla.gnome.org/show_bug.cgi?id=773710
Mike Gorse [Mon, 26 Sep 2016 01:15:08 +0000 (20:15 -0500)]
2.22.0
gogo [Sat, 24 Sep 2016 10:22:58 +0000 (10:22 +0000)]
Added Croatian translation
David King [Sun, 18 Sep 2016 10:39:10 +0000 (12:39 +0200)]
Update British English translation
Ting-Wei Lan [Sat, 16 Jul 2016 13:12:08 +0000 (21:12 +0800)]
Fix return value error in session_manager_connect
https://bugzilla.gnome.org/show_bug.cgi?id=768881
Piotr Drąg [Mon, 22 Aug 2016 18:43:15 +0000 (20:43 +0200)]
Updated Polish translation
Mike Gorse [Wed, 27 Jul 2016 16:59:29 +0000 (11:59 -0500)]
At-spi-bus-launcher: fix uninitialized variable
Mike Gorse [Mon, 18 Jul 2016 23:51:43 +0000 (18:51 -0500)]
2.21.4
Piotr Drąg [Thu, 14 Jul 2016 18:15:01 +0000 (20:15 +0200)]
Add Language headers to po files
Future versions of gettext will fail if this header is missing.
Mike Gorse [Thu, 14 Jul 2016 16:38:25 +0000 (11:38 -0500)]
at-spi-bus-launcher: session management fixes
At-spi-bus-launcher was attempting to register with gnome-session but
typically failed because it was started before gnome-session is initialized.
Now we check whether gnome-session is running and only attempt to register
if it is; otherwise watch for SessionRunning and register when se wee it.
Also, handle SessionOver.
Mike Gorse [Thu, 2 Jun 2016 23:53:26 +0000 (18:53 -0500)]
Correctly handle at-spi2-registryd dying when processing NameOwnerChanged
If at-spi2-registryd dies, then we receive two NameOwnerChanged signals,
one for org.a11y.atspi.Registry and the other for the initial dbus-issued
name. When we received the latter, we were matching it to the AtspiApplication
corresponding to the desktop and inadvertently disposing it, leading to a
crash later on.
Mike Gorse [Tue, 31 May 2016 19:44:17 +0000 (14:44 -0500)]
atspi_accessible_clear_cache: don't crash if we have no children
If an accessible is disposed, then its list of children may be NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=767075
Cédric Valmary [Mon, 30 May 2016 18:48:48 +0000 (18:48 +0000)]
Updated Occitan translation
Mike Gorse [Mon, 23 May 2016 23:39:46 +0000 (18:39 -0500)]
2.21.2
Mike Gorse [Sun, 22 May 2016 12:15:21 +0000 (07:15 -0500)]
ref_accessible_desktop: don't unref reply until we're finished with it
Oops!
dolphinling [Mon, 9 May 2016 12:21:55 +0000 (08:21 -0400)]
Allow building without Xtst, Xi with --disable-x11
This also fixes a bug where specifying --enable-x11 would disable x11
support.
Cédric Valmary [Thu, 5 May 2016 20:26:10 +0000 (20:26 +0000)]
Updated Occitan translation
GNOME Translation Robot [Thu, 28 Apr 2016 13:53:59 +0000 (13:53 +0000)]
Added Scottish Gaelic translation
Mike Gorse [Mon, 25 Apr 2016 23:43:09 +0000 (18:43 -0500)]
2.21.1
Alexander Volkov [Mon, 18 Apr 2016 14:54:47 +0000 (17:54 +0300)]
at-spi-bus-launcher: fix parsing command line arguments
Fix parsing --a11y=... and --screen-reader=...
sscanf returns the number of input items successfully matched,
and for one argument it is 1, but not 2.
https://bugzilla.gnome.org/show_bug.cgi?id=765220
Rui Matos [Wed, 6 Apr 2016 15:10:03 +0000 (17:10 +0200)]
atspi-event-listener: Plug a memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=764688
Rui Matos [Wed, 6 Apr 2016 14:40:44 +0000 (16:40 +0200)]
registryd: Avoid crashing with a NULL keystring
From a coverity check:
1. at-spi2-core-2.14.1/registryd/deviceeventcontroller-x11.c:1167:
deref_ptr_in_call: Dereferencing pointer "keystring".
2. at-spi2-core-2.14.1/registryd/deviceeventcontroller-x11.c:1169:
check_after_deref: Null-checking "keystring" suggests that it may be
null, but it has already been dereferenced on all paths leading to the
check.
(keystring, -1, &c))) {
https://bugzilla.gnome.org/show_bug.cgi?id=764688
Thomas Petazzoni [Wed, 25 Jun 2014 20:12:16 +0000 (22:12 +0200)]
Get rid of the DBIND_ALIGNOF_* definitions and directly use ALIGNOF_*
Since the AC_CHECK_ALIGNOF() macro fills the config.h header with
ALIGNOF_<type> definitions, there's no longer a need for the
DBIND_ALIGNOF_<type> definitions. This commit gets rid of them, and
also gets rid of the dbing-config.h file.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas Petazzoni [Wed, 25 Jun 2014 20:01:38 +0000 (22:01 +0200)]
dbind/Makefile.am: specify subdir-objects automake option
As recommended during autoreconf:
dbind/Makefile.am:1: while processing Libtool library 'libdbind.la'
dbind/Makefile.am:23: warning: source file '../atspi/atspi-gmain.c' is in a subdirectory,
dbind/Makefile.am:23: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled. For now, the corresponding output
automake: object file(s) will be placed in the top-level directory. However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas Petazzoni [Wed, 25 Jun 2014 19:57:59 +0000 (21:57 +0200)]
configure.ac: add AM_PROG_AR
During an autoreconf, automake recommends:
/usr/share/automake-1.14/am/ltlibrary.am: warning: 'libatspi.la': linking libtool libraries using a non-POSIX
/usr/share/automake-1.14/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas Petazzoni [Fri, 1 Apr 2016 16:29:28 +0000 (11:29 -0500)]
acinclude.m4: remove no longer needed file
Now the DBIND_CHECK_ALIGNOF() autoconf macro is no longer used, this
commit gets rid of the acinclude.m4 file.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas Petazzoni [Wed, 25 Jun 2014 17:45:28 +0000 (19:45 +0200)]
configure: use AC_CHECK_ALIGNOF() instead of custom DBIND_CHECK_ALIGNOF()
DBIND_CHECK_ALIGNOF() is a custom autoconf macro from at-spi2-core
that tests the alignment required on the current platform for a given
C type. Unfortunately, this macro uses AC_TRY_RUN(), which requires
running a test program on the target platform, which is fundamentally
incompatible with cross-compilation.
Therefore, this patch switches the configure.ac code to use
AC_CHECK_ALIGNOF() instead, which is available in the standard set of
autoconf macros, and is able to test the required alignment for C
types without using AC_TRY_RUN(). Consequently, it adjusts the
dbind/dbind-config.h.in definitions to use the definitions created by
the AC_CHECK_ALIGNOF() macros, which are not substituted by autoconf,
but directly available from config.h.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Fabio Tomat [Wed, 23 Mar 2016 17:17:13 +0000 (17:17 +0000)]
Updated Friulian translation
Mike Gorse [Tue, 22 Mar 2016 00:10:07 +0000 (19:10 -0500)]
2.20.0
Mike Gorse [Mon, 14 Mar 2016 22:12:11 +0000 (17:12 -0500)]
2.19.92
Ikey Doherty [Sat, 12 Mar 2016 16:43:16 +0000 (16:43 +0000)]
Support a stateless configuration by default
Using a stateless configuration, we ship sensible defaults in our vendor-config
file to live in the /usr/share/ filesystem, which is considered to be provided
by the vendor, and to all intents and purposes, read-only.
With this change we can fall-back to the vendor system configuration to
always do the right thing, in the absence of a local system administrator
configuration file in the /etc/ tree.
Notably, this saves users from the potential risks and pitfalls of so called
"three way merges" on upgrades, and offers the immediate benefit that one
can perform a factory reset of the software, simply by removing the relevant
file in /etc/.
This change also resolves a memory leak in the launch code, where a string
allocation was entirely unnecessary.
Signed-off-by: Ikey Doherty <michael.i.doherty@intel.com>
Mike Gorse [Tue, 1 Mar 2016 01:48:16 +0000 (19:48 -0600)]
NEWS: fix typo
Mike Gorse [Tue, 1 Mar 2016 01:35:35 +0000 (19:35 -0600)]
2.19.91
Mike Gorse [Mon, 29 Feb 2016 17:51:45 +0000 (11:51 -0600)]
Don't display warnings when connecting to an app that no longer exists
If an application starts and subsequently exits before we've had time to
connect to it, then this at the very least should not trigger a warning.
Mike Gorse [Mon, 15 Feb 2016 22:13:02 +0000 (16:13 -0600)]
2.19.90
Samuel Thibault [Mon, 8 Feb 2016 19:24:25 +0000 (13:24 -0600)]
Don't display warning if unable to connect when logged in via ssh
https://bugzilla.gnome.org/show_bug.cgi?id=761600
Alberts Muktupāvels [Fri, 18 Sep 2015 00:28:51 +0000 (03:28 +0300)]
at-spi-bus-launcher: register with session manager
This application is started in Initialization phase. In this phase
it is required to register with session manager. See:
https://wiki.gnome.org/Projects/SessionManagement/NewGnomeSession
https://bugzilla.gnome.org/show_bug.cgi?id=753931
Mike Gorse [Tue, 26 Jan 2016 17:20:51 +0000 (11:20 -0600)]
Revert "at-spi-bus-launcher: register with session manager"
Committed the wrong patch.
This reverts commit
d2004dbb0d0903548f734029718ee5bf212d107c.
Alberts Muktupāvels [Tue, 15 Sep 2015 16:31:52 +0000 (19:31 +0300)]
at-spi-bus-launcher: register with session manager
This application is started in Initialization phase. In this phase
it is required to register with session manager. See:
https://wiki.gnome.org/Projects/SessionManagement/NewGnomeSession
https://bugzilla.gnome.org/show_bug.cgi?id=753931
Mike Gorse [Tue, 24 Nov 2015 01:16:31 +0000 (19:16 -0600)]
2.19.2
Samuel Thibault [Sat, 14 Nov 2015 15:06:45 +0000 (09:06 -0600)]
Don't crash when trying to set an invalid state
https://bugzilla.gnome.org/show_bug.cgi?id=757915