Behdad Esfahbod [Wed, 16 Aug 2017 00:30:18 +0000 (17:30 -0700)]
[util] Prefix trace lines with "trace:", and error lines with "error:"
Behdad Esfahbod [Wed, 16 Aug 2017 00:12:28 +0000 (17:12 -0700)]
[util] Respect eot/bot in safe-to-break test; hook up hb_buffer_diff()
Behdad Esfahbod [Wed, 16 Aug 2017 00:12:21 +0000 (17:12 -0700)]
Fix warning about "may be used uninitialized"
Emil A Eklund (eae) [Tue, 15 Aug 2017 23:25:18 +0000 (16:25 -0700)]
Fix signed/unsigned warning (#522)
Change hb_buffer_diff to explicitly cast result of abs to unsigned when
comparing with position_fuzz to avoid unsafe signed/unsigned comparions
warnings on windows.
Behdad Esfahbod [Mon, 14 Aug 2017 22:23:10 +0000 (15:23 -0700)]
Minor
Behdad Esfahbod [Mon, 14 Aug 2017 21:49:21 +0000 (14:49 -0700)]
[util] Fix leaks
Behdad Esfahbod [Mon, 14 Aug 2017 19:36:38 +0000 (12:36 -0700)]
Fix typo
Jonathan Kew [Sat, 19 Jul 2014 22:09:09 +0000 (23:09 +0100)]
Add function to compare two buffers
Based on patch from Jonathan Kew.
Needs more cleaning up and documentation.
New API:
hb_buffer_diff_flags_t
hb_buffer_diff()
Behdad Esfahbod [Sun, 13 Aug 2017 22:10:26 +0000 (15:10 -0700)]
[graphite2] Fix warning
Behdad Esfahbod [Sun, 13 Aug 2017 22:08:34 +0000 (15:08 -0700)]
[unsafe-to-break] Mark all positions as unsafe in alternative shapers
Behdad Esfahbod [Sat, 12 Aug 2017 02:51:06 +0000 (19:51 -0700)]
[unsafe-to-break] Towards verifying unsafe-to-break in --verify
We break and shape fragments and reconstruct shape result from them.
Remains to compare to original buffer. Going to add some buffer
comparison API and use here, instead of open-coding.
Behdad Esfahbod [Sat, 12 Aug 2017 02:31:05 +0000 (19:31 -0700)]
Fix hb_buffer_append()
Ouch!
Behdad Esfahbod [Sat, 12 Aug 2017 02:06:07 +0000 (19:06 -0700)]
[unsafe-to-break] Copy flag to all glyphs in a cluster
Makes consumption easier.
Behdad Esfahbod [Sat, 12 Aug 2017 01:24:27 +0000 (18:24 -0700)]
[unsafe-to-break] Mark unsafe is cluster merging is disabled
We were relying on cluster merges not requiring unsafe flagging because
they get merged. If cluster level requests no merging, then we flag
unsafe when merge would have happened.
Behdad Esfahbod [Fri, 11 Aug 2017 22:52:06 +0000 (15:52 -0700)]
New API: hb_buffer_append()
Behdad Esfahbod [Fri, 11 Aug 2017 22:12:25 +0000 (15:12 -0700)]
[util] Add --verify to hb-shape / hb-view that verifies shape results
Right now it checks for monotone cluster values. Other checks to be added.
Behdad Esfahbod [Fri, 11 Aug 2017 18:30:39 +0000 (11:30 -0700)]
[unsafe-to-break] Fix Use-of-uninitialized-value in unsafe_to_break_set_mask
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3011
Behdad Esfahbod [Fri, 11 Aug 2017 03:54:15 +0000 (20:54 -0700)]
[unsafe-to-break] Flag in Thai PUA shaping
Behdad Esfahbod [Fri, 11 Aug 2017 03:50:48 +0000 (20:50 -0700)]
[unsafe-to-break] Flag in Hangul shaper
Behdad Esfahbod [Fri, 11 Aug 2017 03:32:02 +0000 (20:32 -0700)]
[unsafe-to-break] Flag during mark attachment
Behdad Esfahbod [Fri, 11 Aug 2017 03:27:21 +0000 (20:27 -0700)]
Fix test
Behdad Esfahbod [Fri, 11 Aug 2017 03:23:17 +0000 (20:23 -0700)]
[unsafe-to-break] Flag during cursive positioning
Behdad Esfahbod [Fri, 11 Aug 2017 03:19:15 +0000 (20:19 -0700)]
[unsafe-to-break] Flag during kerning
Behdad Esfahbod [Fri, 11 Aug 2017 03:16:15 +0000 (20:16 -0700)]
[unsafe-to-break] Flag during fallback positioning
Behdad Esfahbod [Fri, 11 Aug 2017 03:10:12 +0000 (20:10 -0700)]
[unsafe-to-break] Be careful with flag propagation when merging clusters
Behdad Esfahbod [Fri, 11 Aug 2017 02:58:05 +0000 (19:58 -0700)]
Set mask to 0, instead of 1, by default
This shouldn't matter.
Behdad Esfahbod [Fri, 11 Aug 2017 01:45:33 +0000 (18:45 -0700)]
[unsafe-to-break] Mark Indic-like clusters as unsafe-to-break
Behdad Esfahbod [Thu, 10 Aug 2017 21:25:53 +0000 (14:25 -0700)]
[unsafe-to-break] Allocate public bits from 0
Behdad Esfahbod [Thu, 5 May 2016 15:13:03 +0000 (16:13 +0100)]
[safe-to-break] Fix logic when there is no out-buffer
Behdad Esfahbod [Wed, 4 May 2016 17:51:22 +0000 (19:51 +0200)]
[unsafe-to-break] Simplify logic
Always use the algorithm for non-monotone case. It's more robust.
Behdad Esfahbod [Mon, 2 May 2016 12:47:45 +0000 (14:47 +0200)]
[unsafe-to-break] Add UNSAFE_TO_BREAK flag
Not all shapers code is updated to set this properly.
GSUB and Arabic shaper are updated.
GPOS and other shapers are NOT.
Fixes https://github.com/behdad/harfbuzz/issues/224
Behdad Esfahbod [Thu, 10 Aug 2017 05:09:01 +0000 (22:09 -0700)]
[util] Fix two other Coverity warnings
Behdad Esfahbod [Thu, 10 Aug 2017 05:06:53 +0000 (22:06 -0700)]
[util] Fix warning
Behdad Esfahbod [Thu, 10 Aug 2017 05:05:08 +0000 (22:05 -0700)]
[ft] Fix theoretical leak
Behdad Esfahbod [Thu, 10 Aug 2017 00:23:28 +0000 (17:23 -0700)]
Treat HAMZA ABOVE similar to SHADD for sorting purposes
Part of https://github.com/behdad/harfbuzz/issues/509
Behdad Esfahbod [Thu, 10 Aug 2017 00:09:21 +0000 (17:09 -0700)]
Protect against div-by-zero in CBDT extent code
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1452#c5
CC https://github.com/behdad/harfbuzz/issues/139
Behdad Esfahbod [Wed, 9 Aug 2017 01:37:03 +0000 (18:37 -0700)]
Behdad Esfahbod [Tue, 8 Aug 2017 20:17:03 +0000 (13:17 -0700)]
1.4.8
Behdad Esfahbod [Tue, 8 Aug 2017 04:37:07 +0000 (21:37 -0700)]
Two fixes to avar mapping
1. Handle segment with two entries correctly,
2. Fix rounding math. Ouch!
Fixes https://github.com/behdad/harfbuzz/issues/521
Behdad Esfahbod [Thu, 3 Aug 2017 11:34:15 +0000 (12:34 +0100)]
[check-defs/symbols.sh] Drop empty-symbol lines
Fixes https://github.com/behdad/harfbuzz/issues/510
Behdad Esfahbod [Thu, 20 Jul 2017 00:20:55 +0000 (17:20 -0700)]
[hb-shape] Rename --show-messages to --trace
https://github.com/behdad/harfbuzz/issues/506
Behdad Esfahbod [Wed, 19 Jul 2017 02:14:19 +0000 (19:14 -0700)]
[hb-shape] Improve shaping-debug output
Before, that was printed using --debug (and in both hb-shape and hb-view).
Changed it, now hb-shape has a new command-line argument called --show-messages.
When invoked, it also respects other output formatting options. The messages
are better formatted and printed to te same place that hb-shape output is
directed to. Previously they were written to stderr.
Fixes https://github.com/behdad/harfbuzz/issues/506
Ebrahim Byagowi [Tue, 18 Jul 2017 22:12:53 +0000 (02:42 +0430)]
Unbreak arm-none-eabi build again (#514)
Behdad Esfahbod [Tue, 18 Jul 2017 18:24:42 +0000 (11:24 -0700)]
1.4.7
Behdad Esfahbod [Fri, 14 Jul 2017 16:34:47 +0000 (17:34 +0100)]
[arabic] Adjust feature order again
Fixes https://github.com/behdad/harfbuzz/issues/505
Cosimo Lupo [Fri, 14 Jul 2017 16:11:46 +0000 (17:11 +0100)]
[coretext] Allow to disable kern (#508)
* Minor
* [coretext] Fix leak
* [coretext] Do not reset num_features
* [coretext] allow to disable kern; re-enabling doesn't seem to be working
Behdad Esfahbod [Fri, 14 Jul 2017 16:01:27 +0000 (17:01 +0100)]
[use] Allow up to two medial-below letters
Fixes https://github.com/behdad/harfbuzz/issues/376
Behdad Esfahbod [Fri, 14 Jul 2017 15:38:51 +0000 (16:38 +0100)]
[use] Fix shaping of U+AA29 CHAM VOWEL SIGN AA
Part of https://github.com/behdad/harfbuzz/issues/376
Also see https://github.com/roozbehp/unicode-data/issues/6
Test added, using NotoSansCham built from Noto Phase III sources.
Behdad Esfahbod [Fri, 14 Jul 2017 14:59:40 +0000 (15:59 +0100)]
[indic] Add github URL
Behdad Esfahbod [Fri, 14 Jul 2017 14:50:22 +0000 (15:50 +0100)]
[indic] Fix https://github.com/behdad/harfbuzz/issues/478
Behdad Esfahbod [Fri, 14 Jul 2017 13:14:35 +0000 (14:14 +0100)]
[indic] Disable automatic ZWNJ handling for Indic features
Fixes https://github.com/behdad/harfbuzz/issues/294
Also fixes a bunch of other Indic issues. Test results after:
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%)
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951201 out of 951913 tests passed. 712 failed (0.0747968%)
KHMER: 299071 out of 299124 tests passed. 53 failed (0.0177184%)
MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.
00185457%)
Before:
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.
00185457%)
Behdad Esfahbod [Fri, 14 Jul 2017 11:43:34 +0000 (12:43 +0100)]
[indic] Add infrastructure to disable ZWNJ-skipping in context-matching
Not used yet.
Dominik Schlösser [Fri, 14 Jul 2017 11:14:55 +0000 (13:14 +0200)]
Shaping tests for Tibetan vowels (#446)
* Shaping tests for Tibetan vowels
* Test-cases for the Dzongkha contractions with multiple vowel-signs added.
* going to be removed
* Extended contraction-test-cases to all test cases in contractions.txt that actually use multiple-vowels (113 cases)
Dominik Schlösser [Fri, 14 Jul 2017 11:14:23 +0000 (13:14 +0200)]
Fix for reordering of Tibetan vowel u (#443)
* Undone change for Tibetan vowel u
* removed comment on reordering that became invalid with roll-back
* Support for Dzongkha contractions with multiple vowel-signs
* Removed non-functional and unnecessary defines for HB_MODIFIED_COMBINING_CLASS_CCC138,140
fanc999 [Wed, 21 Jun 2017 14:19:57 +0000 (22:19 +0800)]
Win32/NMake builds: Support builds from GIT (#498)
Add Python scripts to generate the full win32/config.h.win32 and
src/hb-version.h which can be used to build directly from a GIT
checkout. Since the scripts are currently intended for building from a
GIT checkout, these are not distributed in the release tarballs.
Also, support the re-build of Ragel-generated .hh headers using the NMake
build system, and allow one to specify the path of the Ragel executable
if a suitable one cannot be found in the PATH.
Update the Win32/NMake build documentation to let people know about how
these mechanisms can be utilized.
Ebrahim Byagowi [Mon, 19 Jun 2017 10:17:09 +0000 (14:47 +0430)]
Fix arm-none-eabi build (fixes #451) (#496)
Ebrahim Byagowi [Fri, 2 Jun 2017 17:23:10 +0000 (21:53 +0430)]
Support branch prediction helpers on clang compiles (#491)
Behdad Esfahbod [Thu, 1 Jun 2017 15:44:42 +0000 (11:44 -0400)]
Handle allocation failure in hb-language code
Sebastian Rasmussen [Mon, 29 May 2017 17:53:30 +0000 (12:53 -0500)]
Avoid using strdup inside library. (#488)
If an application provides a malloc replacement through
hb_malloc_impl() it is important that it is used to allocate
everything, but the use of strdup() circumvents this and
causes system malloc() to be called instead. This pairs
badly with the custom hb_free_impl() being called later.
Khaled Hosny [Wed, 17 May 2017 18:32:47 +0000 (21:32 +0300)]
Do not skip TAG characters in glyph substitution (#487)
Hide them like Mongolian Free Variation Selectors instead.
Fixes https://github.com/behdad/harfbuzz/issues/463
Behdad Esfahbod [Tue, 16 May 2017 21:26:28 +0000 (14:26 -0700)]
Minor
Ebrahim Byagowi [Sat, 13 May 2017 17:02:56 +0000 (21:32 +0430)]
[cmake] Add framework build support (#484)
Ebrahim Byagowi [Thu, 4 May 2017 16:01:42 +0000 (20:31 +0430)]
[cmake] minor (#482)
Behdad Esfahbod [Sun, 23 Apr 2017 23:19:13 +0000 (16:19 -0700)]
1.4.6
mhosken [Thu, 20 Apr 2017 18:13:22 +0000 (19:13 +0100)]
Fix graphite2 rtl conversion (#475)
ebraminio [Wed, 19 Apr 2017 18:29:46 +0000 (22:59 +0430)]
[cmake] Final touches (#473)
Chris Peterson [Tue, 18 Apr 2017 06:25:24 +0000 (23:25 -0700)]
Fix clang -Wcomma warnings (#471) (#472)
clang's new -Wcomma compiler option warns about possible misuse of the
comma operator such as between two statements.
hb-common.cc:190:9 [-Wcomma] possible misuse of comma operator here
hb-ot-layout-gsubgpos-private.hh:345:30 [-Wcomma] possible misuse of
comma operator here
hb-shape-plan.cc:438:26 [-Wcomma] possible misuse of comma operator here
ebraminio [Mon, 17 Apr 2017 11:23:46 +0000 (15:53 +0430)]
[cmake] Remove HB_DISABLE_DEPRECATED as it seems needed for pango build (#470)
William Hua [Mon, 17 Apr 2017 05:33:42 +0000 (01:33 -0400)]
Use absolute paths of ragel generated headers (#467)
https://github.com/behdad/harfbuzz/issues/455
Dominik Schlösser [Sat, 15 Apr 2017 19:17:05 +0000 (21:17 +0200)]
Small doc fix: `make check` runs the tests (#469)
ebraminio [Fri, 14 Apr 2017 00:38:11 +0000 (05:08 +0430)]
[cmake] Fix try compile link issues (#466)
ebraminio [Fri, 14 Apr 2017 00:01:17 +0000 (04:31 +0430)]
[cmake] typo (#465)
ebraminio [Thu, 13 Apr 2017 23:55:50 +0000 (04:25 +0430)]
[cmake] Add atomic ops availability detection (#464)
ebraminio [Wed, 12 Apr 2017 21:47:16 +0000 (02:17 +0430)]
[cmake] Remove NO_MT flag (#462)
jfkthame [Tue, 11 Apr 2017 21:29:13 +0000 (22:29 +0100)]
Blacklist GDEF table in additional Tahoma versions. (#459)
There are more broken versions of Tahoma out there on various Windows releases,
so we need to add them to our blacklist to avoid broken rendering.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1279925 for details.
ebraminio [Tue, 11 Apr 2017 18:48:18 +0000 (23:18 +0430)]
[cmake] Improve third party libraries support (#461)
ebraminio [Tue, 11 Apr 2017 17:02:14 +0000 (21:32 +0430)]
[cmake] Add utils build support (#460)
Chun-wei Fan [Thu, 6 Apr 2017 10:44:28 +0000 (18:44 +0800)]
NMake Makefiles: Fix ICU builds
Fix the check conditions in config-msvc.mak and info-msvc.mak so that
the ICU items does indeed get built into the HarfBuzz main DLL, and that
the correct configuration info is displayed.
Also update the checks in detectenv-msvc.mak so that we can detect that
we are using Visual Studio 2017 (although the 2015-built binaries use
the same CRT DLL as the 2017 ones).
Behdad Esfahbod [Wed, 5 Apr 2017 13:42:11 +0000 (15:42 +0200)]
Move list of ragel sources to Makefile.sources as well
ebraminio [Wed, 5 Apr 2017 09:21:23 +0000 (02:21 -0700)]
Split ragel generated files lists and remove hardcoded rl files lists (#453)
ebraminio [Tue, 4 Apr 2017 10:33:51 +0000 (15:03 +0430)]
Add CMake build support (#444)
jfkthame [Mon, 3 Apr 2017 11:22:39 +0000 (12:22 +0100)]
avoid UBSan warning in get_stage_lookups (#450)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1336600
Dominik Schloesser [Sun, 26 Mar 2017 07:22:34 +0000 (09:22 +0200)]
Current fonttools (3.9.1) generate subset-file called font.subset.ttf instead of older font.ttf.subset
Dominik Schloesser [Sun, 26 Mar 2017 07:21:13 +0000 (09:21 +0200)]
Updated samples: record-it.sh is now record-test.sh
Khaled Hosny [Sun, 26 Mar 2017 08:48:53 +0000 (10:48 +0200)]
[tools] Make hb-unicode-code work with Python 3
Related to https://github.com/behdad/harfbuzz/pull/445
Behdad Esfahbod [Fri, 24 Mar 2017 17:24:52 +0000 (10:24 -0700)]
Blacklist more versions of Padauk
Patch from Phil Race.
Khaled Hosny [Wed, 22 Mar 2017 22:35:36 +0000 (00:35 +0200)]
[ci] Fix msys2 build on AppVeyor
For whatever reason the env variables need to be the Windows way or they
end up being empty.
Khaled Hosny [Wed, 22 Mar 2017 21:07:15 +0000 (23:07 +0200)]
Just always use strtod here
Chun-wei Fan [Fri, 24 Feb 2017 09:58:25 +0000 (17:58 +0800)]
src/hb-common.cc: Fix build on older Visual Studio
Visual Studio only supported strtof() from Visual Studio 2013 onwards, so
use strtod() instead to do the operation, which should do the same thing,
sans going to a double, not a float.
Chun-wei Fan [Fri, 24 Feb 2017 09:47:44 +0000 (17:47 +0800)]
Visual Studio builds: Fix Introspection when UCDN enabled
The sources in src/hb-ucdn and not included correctly into the NMake
Makefiles, as we need their explicit relative location as we pass all the
sources we used into the introspection scanner. This was not an issue
before as we excluded the UCDN sources in the build when we enabled
introspection (meaning GLib is enabled), but since we default on using
UCDN on all builds unless explicitly disabled, we need to deal with this.
This did not affect builds using UCDN without introspection due to the use
of NMake batch rules.
Fix this by creating a NMake Makefile module on-the-fly with the correct
subdir info, and using that list in there instead.
Chun-wei Fan [Thu, 23 Feb 2017 05:02:49 +0000 (13:02 +0800)]
Update Visual Studio builds for UCDN usage
We now use UCDN by default, so make it so in the build files; however
don't hardcode HAVE_UCDN as one may still opt not to use it (but pass
it in as a CFLAG unless one explicitly disables UCDN by using NO_UCDN=1
on the NMake command line).
Note that we are not blocking builds where UCDN is disabled along with
GLib and ICU, as that will trigger a build error anyways which will tell
the user what needs to be done to remedy this.
Behdad Esfahbod [Sat, 11 Mar 2017 07:02:28 +0000 (23:02 -0800)]
1.4.5
Behdad Esfahbod [Fri, 10 Mar 2017 21:23:02 +0000 (13:23 -0800)]
Revert "Fix Context lookup application when moving back after a glyph delete"
This reverts commit
b9b005f3a44ccf78a45b212b126287b69b9f4b40.
This introduced invalid access cases. Revert until I fix correctly.
Behdad Esfahbod [Wed, 8 Mar 2017 02:13:28 +0000 (18:13 -0800)]
Fix buffer serialize of empty buffer
Ouch!
Behdad Esfahbod [Sun, 5 Mar 2017 21:54:56 +0000 (13:54 -0800)]
1.4.4
Behdad Esfahbod [Sun, 5 Mar 2017 21:51:01 +0000 (13:51 -0800)]
Add TODO item
Behdad Esfahbod [Thu, 2 Mar 2017 19:46:33 +0000 (11:46 -0800)]
Remove TODO item that is not going to happen
Behdad Esfahbod [Wed, 1 Mar 2017 22:27:23 +0000 (14:27 -0800)]
Fix Context lookup application when moving back after a glyph delete
This was broken forever, since days that we did not allow moving
tape backwards. Works now. Reported by Doug Felt.
Behdad Esfahbod [Sat, 25 Feb 2017 21:37:54 +0000 (13:37 -0800)]
Add few tests found by libFuzzer and oss-fuzz
Behdad Esfahbod [Sat, 25 Feb 2017 21:30:38 +0000 (13:30 -0800)]
Fix buffer-overrun with Bengali reph positioning code
This has no security implications whatsoever since we always keep
and extra element at the end of buffer, just in case.
Discovered by oss-fuzz
CC https://github.com/behdad/harfbuzz/issues/139
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=660