review.tizen.org Git - profile/ivi/webkit-efl.git/log

[EFL] Define the names of view smart class
https://bugs.webkit.org/show_bug.cgi?id=76370

Patch by Eunsol Park <eunsol47.park@samsung.com> on 2012-01-30
Reviewed by Andreas Kling.

Strings of ewk_tiled_view's name were defined differently,
so the definitions were modified to make users not confused.

* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_class_new):
* ewk/ewk_view_tiled.cpp:
(ewk_view_tiled_smart_set):
(_ewk_view_tiled_smart_class_new):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[wx] Update build dirs and includes after recent trunk changes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Unreviewed test expectation change
plugins/crash-restoring-plugin-page-from-page-cache.html fails or timeouts.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Compute occlusion during paint loop
https://bugs.webkit.org/show_bug.cgi?id=76858

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-30
Reviewed by James Robinson.

Source/WebCore:

New unit tests in TiledLayerChromiumTest.cpp, CCLayerTreeHostCommonTest.cpp, CCLayerTreeHostTest.cpp

* platform/graphics/FloatRect.cpp:
(WebCore::enclosedIntRect):
(WebCore):
* platform/graphics/FloatRect.h:
(WebCore):
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::contentToScreenSpaceTransform):
(WebCore):
(WebCore::LayerChromium::addSelfToOccludedScreenSpace):
(WebCore::LayerChromium::isPaintedAxisAlignedInScreen):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(WebCore::LayerChromium::paintContentsIfDirty):
(LayerChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore):
():
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(RenderSurfaceRegion):
(WebCore):
(WebCore::pushTargetRenderSurfaceRegion):
(WebCore::popAndPushTargetRenderSurfaceRegion):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
():
* platform/graphics/chromium/cc/CCQuadCuller.cpp:

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
(WebCore):
* tests/CCLayerTreeHostTest.cpp:
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF):
(TestLayerChromium):
(WTF::TestLayerChromium::create):
(WTF::TestLayerChromium::paintContentsIfDirty):
(WTF::TestLayerChromium::drawsContent):
(WTF::TestLayerChromium::occludedScreenSpace):
(WTF::TestLayerChromium::clearOccludedScreenSpace):
(WTF::TestLayerChromium::TestLayerChromium):
(WTF::setLayerPropertiesForTesting):
(CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusion::afterTest):
* tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::setOpaquePaintRect):
(FakeLayerTextureUpdater):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
(WTF::TEST):
(WTF):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add ElementAttributeData class to replace internal uses of NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=77233

Reviewed by Andreas Kling.

Move part of non-DOM functionality of NamedNodeMap into a separate class. This is
the first step toward the goal of separating NamedNodeMap from internal attribute
storage, as described in https://bugs.webkit.org/show_bug.cgi?id=75069.

The internal attribute storage is exposed as attributeData() in Element, and when
necessary (because it has no back pointer to Element) via methods in Element.

No new tests. Except from setClass() change this is just moving the code, no new
feature was added.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Element.cpp:
(WebCore::Element::idAttributeChanged):
* dom/Element.h:
(WebCore::Element::attributeData):
(WebCore::Element::ensureAttributeData):
(Element):
(WebCore::Element::idForStyleResolution):
* dom/ElementAttributeData.cpp: Added.
(WebCore):
(WebCore::ElementAttributeData::setClass): the only caller of this function
already deal with the case when the element has no class, so don't do it here.
* dom/ElementAttributeData.h: Added.
(WebCore):
(ElementAttributeData):
(WebCore::ElementAttributeData::clearClass):
(WebCore::ElementAttributeData::classNames):
(WebCore::ElementAttributeData::idForStyleResolution):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::clearAttributes):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::attributeData):
(NamedNodeMap):
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
* dom/StyledElement.h:
(WebCore::StyledElement::classNames):
* html/ClassList.cpp:
(WebCore::ClassList::classNames):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Python code in webkit-perf.appspot.com uses camelCase
https://bugs.webkit.org/show_bug.cgi?id=77392

Reviewed by Adam Barth.

Use PEP8 style naming conventions instead of camelCase.

* Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler.post):
(CreateHandler._create_builder):
(CreateHandler._create_branch):
(CreateHandler._create_platform):
* Websites/webkit-perf.appspot.com/dashboard_handler.py:
(DashboardHandler.get):
* Websites/webkit-perf.appspot.com/manifest_handler.py:
(ManifestHandler.get):
* Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler.post):
* Websites/webkit-perf.appspot.com/models.py:
(create_in_transaction_with_numeric_id_holder):
(delete_model_with_numeric_id_holder):
(modelFromNumericId):
(Builder.authenticate):
(Builder.hashed_password):
(Test.cache_key):
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
(ReportHandler._model_by_key_name_in_body_or_error):
(ReportHandler._integer_in_body):
(ReportHandler._timestamp_in_body):
(ReportHandler.bypass_authentication):
(ReportHandler._results_are_valid):
(ReportHandler._results_are_valid._is_float_convertible):
(ReportHandler._create_build_if_possible):
(ReportHandler._create_build_if_possible.execute):
(ReportHandler._add_test_if_needed):
(ReportHandler._add_test_if_needed.execute):
(ReportHandler):
(AdminReportHandler.bypass_authentication):
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.get):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add Plumming to get graphics error messages to JS Console
https://bugs.webkit.org/show_bug.cgi?id=77238

Source/WebCore:

Patch by Gregg Tavares <gman@chromium.org> on 2012-01-30
Reviewed by Kenneth Russell.

No new tests. No change in behavior.

* html/canvas/WebGLRenderingContext.cpp:
(WebGLRenderingContextErrorMessageCallback):
(WebCore::WebGLRenderingContextErrorMessageCallback::WebGLRenderingContextErrorMessageCallback):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
(WebCore::WebGLRenderingContextErrorMessageCallback::~WebGLRenderingContextErrorMessageCallback):
(WebCore):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
* platform/graphics/GraphicsContext3D.h:
(ErrorMessageCallback):
(WebCore::GraphicsContext3D::ErrorMessageCallback::~ErrorMessageCallback):
(GraphicsContext3D):
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore):

Source/WebKit/chromium:

Patch by Gregg Tavares <gman@google.com> on 2012-01-30
Reviewed by Kenneth Russell.

* public/platform/WebGraphicsContext3D.h:
(WebGraphicsErrorMessageCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsErrorMessageCallback::~WebGraphicsErrorMessageCallback):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setErrorMessageCallback):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
* src/GraphicsContext3DPrivate.h:
(WebCore):
():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Simplify RenderLayerCompositor::frameViewDidScroll
https://bugs.webkit.org/show_bug.cgi?id=77398

Reviewed by Sam Weinig.

Remove the scrollPosition parameter from RenderLayerCompositor::frameViewDidScroll; we can just get it
from the associated FrameView object.

* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
Call frameViewDidScroll() here instead of setting the scroll layer position explicitly.

(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::ensureRootLayer):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Don't select the next selectable index when deselecting an option in select elements with size set to a value greater than one.
https://bugs.webkit.org/show_bug.cgi?id=76389

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-30
Reviewed by Kent Tamura.

This behavior matches the rest of the browsers.

Source/WebCore:

Test: fast/forms/select/option-selecting.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::optionSelectionStateChanged):

LayoutTests:

* fast/forms/select/option-selecting-expected.txt: Added.
* fast/forms/select/option-selecting.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Scrollbars don't show when scrolling on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=77396
<rdar://problem/10710736>

Reviewed by Sam Weinig.

Use ScrollAnimator::scrollToOffsetWithoutAnimation when updating the frame view scroll offset,
since that function will end up invalidating the scrollbars correctly.

* page/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::didUpdateMainFrameScrollPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Layout Test plugins/crash-restoring-plugin-page-from-page-cache.html is slow on Chromium
https://bugs.webkit.org/show_bug.cgi?id=77397

Unreviewed gardening. Marking plugins/crash-restoring-plugin-page-from-page-cache.html slow
on Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
output an empty method name (i.e. "()")
https://bugs.webkit.org/show_bug.cgi?id=77336

Reviewed by Darin Adler.

r105797 tried to detect a change outside methods, but it causes a bug that
prepare-ChangeLog can output an empty method name, like this:

    * foo/bar/baz.cpp:
    (method1):
    ():
    (method2):

This is because the cpp parser in prepare-ChangeLog cannot distinguish
'{' as the beginning of a method with '{' as the beginning of an array definition
at the top level.

    int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.

    void func() { // This '{' is the beginning of a method.
        ...;
    }

This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.

* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp): Modified as described above.
(generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
an empty method name. Ideally this should not happen but may happen, since the
parsers are not perfect.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
(NameSpace7):
(NameSpace8):
(Class109):
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

get_by_val_arguments is broken in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=77389

Reviewed by Gavin Barraclough.

When get_by_val had wad a value profile added, the same slot was not added to
get_by_val_arguments. This broke the interpreter as the interpreter falls
back on its regular get_by_val implementation.

No tests are added as the interpreter is fairly broken in its
current state (multiple tests fail due to this bug).

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
():
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetArgumentByVal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r106259.
http://trac.webkit.org/changeset/106259
https://bugs.webkit.org/show_bug.cgi?id=77395

Breaks shared builders as they also build webkittests with
-Wexit-time-destructors. (Requested by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-30

* WebKitUnitTests.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Skip inspector tests since they have been timing out.

* Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Show repaint counters in individual tiles
https://bugs.webkit.org/show_bug.cgi?id=77390
<rdar://problem/10767967>

Reviewed by Darin Adler.

* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplayInRect):
Make sure to invalidate the repaint counter rect if necessary.

(WebCore::TileCache::drawLayer):
Draw the repaint counter.

(WebCore::TileCache::showRepaintCounter):
New function that determines whether we should show repaint counters for the given tile cache.

* platform/graphics/ca/mac/WebTileLayer.h:
* platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer incrementRepaintCount]):
Add method for getting the repaint count.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/10778045> REGRESSION (r91935): text-combine fails
https://bugs.webkit.org/show_bug.cgi?id=77373

Reviewed by Darin Adler.

Source/WebCore:

Removed tests that were failing because of this bug from the Lion skipped
list.

* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill): Changed to use CTFontGetGlyphsForCharacters,
rather than wkGetVerticalGlyphsForCharacters, for non-fullwidth fonts.

LayoutTests:

Removed tests that were failing because of this bug from the skipped list.

* platform/mac-lion/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix typo in test name from my last commit.

Spotted and rubber-stamped by Darin Adler.

* plugins/crash-restoring-plugin-page-from-page-cache-expected.txt: Copied from plugins/crash-restoring-pluging-page-from-page-cache-expected.txt.
* plugins/crash-restoring-plugin-page-from-page-cache.html: Copied from plugins/crash-restoring-pluging-page-from-page-cache.html.
* plugins/crash-restoring-pluging-page-from-page-cache-expected.txt: Removed.
* plugins/crash-restoring-pluging-page-from-page-cache.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Enable memcache on webkit-perf.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=77378

Reviewed by Adam Barth.

Eanble memcache on dashboard, manifest, and runs handlers. Clear appropriate caches when new runs are reported,
or new models are created. We flush all caches when tests are merged since it's hard to figure out dependencies
in that case. Luckily, we merge tests only occassionally and manually (or hope so) so this shouldn't be an issue.

* Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler.post):
* Websites/webkit-perf.appspot.com/dashboard_handler.py:
(DashboardHandler.get):
* Websites/webkit-perf.appspot.com/manifest_handler.py:
(ManifestHandler.get):
* Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler.post):
* Websites/webkit-perf.appspot.com/models.py:
(createInTransactionWithNumericIdHolder):
(Test):
(Test.cacheKey):
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
(ReportHandler._addTestIfNeeded):
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.get):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

BlackBerry - Support Proxy-Authenticate headers when a proxy is configured
https://bugs.webkit.org/show_bug.cgi?id=77361

Though we have a proxy configured, we might not have the auth
credentials it requires. Support Proxy-Authenticate for that case.

Patch by Christopher Hutten-Czapski <chutten@rim.com> on 2012-01-30
Reviewed by George Staikos.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::handleAuthHeader):
(WebCore::NetworkJob::sendRequestWithCredentials):
* platform/network/blackberry/NetworkJob.h:
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Remove unnecessary retry logic in LayerRendererChromium initialization for accelerated painting
https://bugs.webkit.org/show_bug.cgi?id=77247

Reviewed by Kenneth Russell.

The accelerate painting setting is done differently from other capability-dependent settings for no good reason,
requiring that we retry initialization with different settings. For all other settings we set the capabilities
bit to true if the setting is requested and if the required capabilities exist on the underlying context.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/10707072>
Crashes in WebProcess at WebCore::Node::rendererIsNeeded

Reviewed by Darin Adler.

Source/WebCore:

In specific circumstances a plugin element can be without a render style at the point in time where
the page navigated and enters the page cache.

When this is the cash, the element should not enter into the "custom style for renderer" mode and should
instead use the default render style machinery.

Test: plugins/crash-restoring-pluging-page-from-page-cache.html

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache): Only setHasCustomStyleForRenderer and
  forceRecalc if there actually is a custom style to be used.
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache): Only clearHasCustomStyleForRenderer if there
  actually was a custom style to be cleared.
(WebCore::HTMLPlugInImageElement::customStyleForRenderer): This should only be called if there actually is a
  custom style to be used. Otherwise the element would have to fallback to the "normal" RenderStyle which might
  not exist.

LayoutTests:

* plugins/crash-restoring-pluging-page-from-page-cache-expected.txt: Added.
* plugins/crash-restoring-pluging-page-from-page-cache.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Show debug borders for individual tile cache tiles
https://bugs.webkit.org/show_bug.cgi?id=77388

Reviewed by Sam Weinig.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::updateDebugIndicators):
Give tile cache tiles a thin dark blue border.

* platform/graphics/ca/mac/TileCache.h:
(WebCore::TileCache::tileDebugBorderWidth):
(WebCore::TileCache::tileDebugBorderColor):
Add getters and member variables for the tile debug border width and color.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
Initialize m_tileDebugBorderWidth.

(WebCore::TileCache::setTileDebugBorderWidth):
Update the border width of each tile layer.

(WebCore::TileCache::setTileDebugBorderColor):
Update the border color of each tile layer.

(WebCore::TileCache::createTileLayer):
Set the border color and border width.

* platform/graphics/ca/mac/WebTileCacheLayer.h:
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer borderColor]):
(-[WebTileCacheLayer setBorderColor:]):
(-[WebTileCacheLayer borderWidth]):
(-[WebTileCacheLayer setBorderWidth:]):
Call through to the TileCache.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
Don't draw the repaint counter for tile cache layers, each tile will maintain its own repaint counter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

run-webkit-tests calls out to webkit-build-directory twice
https://bugs.webkit.org/show_bug.cgi?id=77248

Reviewed by Dirk Pranke.

This reduces to calls to webkit-build-directory to one call and
saves 500ms for run-webkit-tests over a single file.

* Scripts/webkit-build-directory:
If called with no arguments, print out both the top-level directory and the
configuration directory.

* Scripts/webkit-build-directory:
* Scripts/webkitpy/layout_tests/port/config.py:
(Config.build_directory):
When called with no arguments, get and cache both the top-level and configuration directories.

* Scripts/webkitpy/layout_tests/port/config_standalone.py:
(main):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configuration__notfound):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_path):
Cache the root directory in the options object so that other users
of the options object don't need to call out to webkit-build-directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

single-file input elements should refuse multi-file drags
https://bugs.webkit.org/show_bug.cgi?id=25913

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-01-30
Reviewed by Eric Seidel.

Refuse the multiple file drags onto a single file input element.

Source/WebCore:

No new tests: Covered by existing tests, updated the expected results.

* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
Setting the dragSession.numberOfItemsToBeAccepted to 0 so that drag operation is none if the
file input element under mouse is single input type and number of files dragged onto that
input element are more than 1.

LayoutTests:

* editing/pasteboard/file-input-files-access-expected.txt:
Expected result changed.
* editing/pasteboard/script-tests/file-input-files-access.js:
(runTest):
Removed the 'FIXME' debug and comment as it is not valid after this change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Use region reported painted opaque for draw culling
https://bugs.webkit.org/show_bug.cgi?id=76015

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-30
Reviewed by James Robinson.

Source/WebCore:

New unit tests in CCTiledLayerImplTest.cpp, CCQuadCullerTest.cpp, CCLayerTreeHostImplTest.cpp

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setOpaque):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::opaqueRect):
(WebCore):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(CCDrawQuad):
(WebCore::CCDrawQuad::needsBlending):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
* platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:
(WebCore::CCSolidColorDrawQuad::CCSolidColorDrawQuad):
* platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
* platform/graphics/chromium/cc/CCTileDrawQuad.h:
(CCTileDrawQuad):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(DrawableTile):
(WebCore::DrawableTile::opaqueRect):
(WebCore::DrawableTile::setOpaqueRect):
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::pushTileProperties):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setOpaqueColor):
(BlendStateCheckLayer):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(WebKit::TEST_F):
* tests/CCQuadCullerTest.cpp:
(WebCore::MakeTileQuad):
(WebCore::setQuads):
(WebCore::TEST):
(WebCore):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
(CCLayerTestCommon::coverageVisibleRectOnTileBoundaries):
(CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
(CCLayerTestCommon::coverageVisibleRectIntersectsBounds):
(CCLayerTestCommon):

LayoutTests:

* platform/chromium-linux/compositing/iframes/iframe-in-composited-layer-expected.png:
* platform/chromium-mac-leopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
* platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
* platform/chromium/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Unreviewed test expectation change.
Remove passing media/media-blocked-by-beforeload.html from test_expectations.txt
after r103509

Patch by Shadi Khalek <shadi@chromium.org> on 2012-01-30

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Source/WebCore:

The crash was caused by us assuming that every root inline box has at least one leaf,
which isn't true when we create inline boxes for an empty text run with margin, border, etc...

Test: editing/selection/move-into-empty-root-inline-box.html

* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

LayoutTests:

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

* editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
* editing/selection/move-into-empty-root-inline-box.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unexpected syntax error
https://bugs.webkit.org/show_bug.cgi?id=77340

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Function calls and new expressions have the same semantics for
assignment, so should simply share their lhs handling.

* parser/Parser.cpp:
(JSC::::parseMemberExpression):

LayoutTests:

Add new tests for correct parsing of new expressions

* fast/js/parser-syntax-check-expected.txt:
* fast/js/script-tests/parser-syntax-check.js:
(runTest):
(invalid):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed ARMv7 build fix.

* tools/CodeProfiling.cpp:
(JSC):
(JSC::setProfileTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Using OS(WIN) or OS(MAC) should cause a build error.
https://bugs.webkit.org/show_bug.cgi?id=77162

Reviewed by Darin Adler.

* wtf/Platform.h: Expand them into something that will
cause a compile error.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

css3/flexbox/cross-axis-scrollbar.html ref test fails on Windows Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=77309

Reviewed by Dirk Pranke.

It looks like the scrollbars on windows overflow by a pixel, so the
edge of the scrollbar is being covered up by the trailing green box.
Use z-order to force the scrollbar on top.

This is kind of speculative. I want to see if the test passes on the
bots before removing the line in test_expectations.txt.

* css3/flexbox/cross-axis-scrollbar-expected.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Parsing test_expecations.txt + Skipped lists takes too long
https://bugs.webkit.org/show_bug.cgi?id=77059

Reviewed by Dirk Pranke.

This saves ~100ms on the Apple Mac port.
-memoize a bunch of path methods.
-Avoid doing multiple disk accesses per line.
-Parse the skipped list directly instead of turning it into a test_expecations.txt
formatting string and parsing that.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectationParser._parse_line):
(TestExpectationParser._collect_matching_tests):
(TestExpectations.__init__):
(TestExpectations._add_skipped_tests):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_add_skipped_tests):
(test_add_skipped_tests_duplicate):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port):
(Port.test_isfile):
(Port.normalize_test_name):
(Port.layout_tests_dir):
(Port.abspath_for_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

webkit-perf.appspot.com should have an ability to merge tests
https://bugs.webkit.org/show_bug.cgi?id=77250

Reviewed by Adam Barth.

Added admin/merge-tests. This page allows administrators to easily merge test objects.

Also add the forgotten title.png and rename api/create to admin/create since we don't allow
non-admins to create new models anyway.

* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/css: Added.
* Websites/webkit-perf.appspot.com/css/title.png: Added.
* Websites/webkit-perf.appspot.com/main.py:
* Websites/webkit-perf.appspot.com/merge_tests.yaml: Added.
* Websites/webkit-perf.appspot.com/merge_tests_handler.py: Added.
(MergeTestHandler):
(MergeTestHandler.get):
(MergeTestHandler.post):
* Websites/webkit-perf.appspot.com/models.py:
(deleteModelWithNumericIdHolder):
* Websites/webkit-perf.appspot.com/static/create-models.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

!m_insideRegionPaint assertion in RenderRegion.cpp is invalid
https://bugs.webkit.org/show_bug.cgi?id=77372

Reviewed by David Hyatt.

Removing the !m_insideRegionPaint assertion that's in three functions in
RenderRegion. It's triggering in numerous layout tests and isn't valid.

No new tests as this just removes assertions.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
(WebCore::RenderRegion::removeRenderBoxRegionInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] OS(QNX) also has TM_GMTOFF, TM_ZONE, and TIMEGM
https://bugs.webkit.org/show_bug.cgi?id=77360

Patch by Yong Li <yoli@rim.com> on 2012-01-30
Reviewed by Rob Buis.

Turn on HAVE(TM_GMTOFF), HAVE(TM_ZONE), and HAVE(TIMEGM)
for OS(QNX).

* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Always pre-reserve scrollbar and scroll corner textures
https://bugs.webkit.org/show_bug.cgi?id=77251

Reviewed by James Robinson.

Source/WebCore:

Add a flag to LayerChromium that says that a layer's textures should
always be reserved. Prior to painting layers, find all layers marked
as such and reserve their textures. This will prevent texture memory
limits from being hit before the root layer's scrollbars are reserved
and painted.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::reserveTextures):
(WebCore::LayerChromium::setAlwaysReserveTextures):
(WebCore::LayerChromium::alwaysReserveTextures):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::reserveTextures):
* platform/graphics/chromium/TiledLayerChromium.h:
():
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
():

Source/WebKit/chromium:

* src/NonCompositedContentHost.cpp:
(WebKit::reserveScrollbarLayers):
(WebKit):
(WebKit::NonCompositedContentHost::setViewport):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative Windows build fix.

* assembler/MacroAssemblerCodeRef.h:
(FunctionPtr):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Disconnect the LayerTreeHost from layers when they get removed from their parent.
https://bugs.webkit.org/show_bug.cgi?id=77362

Reviewed by Noam Rosenthal.

This fixes crashes seen in layout tests under certain timing circumstances
that appeared after r106109 was landed.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative 32-bit build-fix.

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed gardening. Marking fast/js/dfg-int32array-overflow-values.html as slow
for Chromium Debug bots.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Roll Chromium DEPS from 119623 to 119700.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fast/css/fontsize-unit-rems-crash.html should use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=77351

Reviewed by Simon Fraser.

Switching the above test to only use text results as the html element is display:none.

* fast/css/fontsize-unit-rems-crash-expected.txt:
* fast/css/fontsize-unit-rems-crash.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[CSSRegions]Add support for background-color in region styling
https://bugs.webkit.org/show_bug.cgi?id=71488

Reviewed by David Hyatt.

Source/WebCore:

Based on work by Alexandru Chiculita (achicu@adobe.com).
Previous patches for region styling were touching RenderObject::style() method. After several attempts to avoid regressions
(including caching of RenderObject::style() pointer in most used methods), we decided to attempt a different approach:
Step1: before each region is repainted, we compute the style for each box that falls into the region
Step2: before paint, we store the box original style
Step3: paint the region contents using the style in region
Step4: after paint is finished, we restore the box original style (and store the box style in region for future region paint)

Tests for region styling are also enabled with this patch.

* WebCore.exp.in:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::clearRenderBoxCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
* rendering/RenderFlowThread.h:
():
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
(WebCore::RenderObject::style):
(RenderObject):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::setRegionBoxesRegionStyle):
(WebCore):
(WebCore::RenderRegion::restoreRegionBoxesOriginalStyle):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
(WebCore::RenderRegion::renderBoxRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearBoxStyleInRegion):
* rendering/RenderRegion.h:
(RenderRegion):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore):
(RenderView):

LayoutTests:

Enable the region styling tests again.

* platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore build exceeds address space on 32-bit Windows builders (again).
https://bugs.webkit.org/show_bug.cgi?id=77357

Reviewed by Adam Roben.

Add an Inspector All-In-One file, but only use it in Release and Production builds.
This differs from our other All-In-One files, but it is a better approach because it makes
debugging possible in the Debug configuration (the symbols will be in the correct .obj file
for the original .cpp files).

* WebCore.vcproj/WebCore.vcproj:
Also, let VS have its way with the vcproj file.
* inspector/InspectorAllInOne.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

IndexedDB: Add tests for structured clone data
https://bugs.webkit.org/show_bug.cgi?id=74897

Validate that the types listed in the HTML5 "structured clone algorithm"
round trip properly through Indexed DB storage. Types with incomplete
support in the Chromium port are excluded (http://crbug.com/108012).
Landing disabled since cr-linux is failing test for unknown reasons.

Reviewed by Tony Chang.

* platform/chromium/test_expectations.txt:
* storage/indexeddb/resources/test-data.html: Added.
* storage/indexeddb/resources/test-data.txt: Added.
* storage/indexeddb/structured-clone-expected.txt: Added.
* storage/indexeddb/structured-clone.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Limit periodic flushing inside ImageBufferCG to just Lion
https://bugs.webkit.org/show_bug.cgi?id=77353
<rdar://problem/10328309>

Reviewed by Chris Marrin.

* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/ImageBufferDataCG.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=77163
MacroAssemblerCodeRef.h uses OS(WIN) instead of OS(WINDOWS)

Rubber stamped by Geoff Garen

* assembler/MacroAssemblerCodeRef.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed build fix for interpreter builds.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(CodeBlock):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Memory leak caused by PeerConnection add a NULL media stream
https://bugs.webkit.org/show_bug.cgi?id=76150

Source/WebCore:

It was my missunderstanding that the IDL keyword [StrictTypeChecking] also protects against
null or undefined arguments, it doesn't. Added checks for null pointers.

Reviewed by Adam Barth.

Test: fast/mediastream/peerconnection-addstream.html

* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):

LayoutTests:

Added a basic LayoutTest for null/undefined arguments to PeerConnection::addStream().

Reviewed by Adam Barth.

* fast/mediastream/peerconnection-addstream-expected.txt: Added.
* fast/mediastream/peerconnection-addstream.html: Added.
* fast/mediastream/script-tests/peerconnection-addstream.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Windows] Optionally invert colors when drawing to a WebView's backing store.
https://bugs.webkit.org/show_bug.cgi?id=77168

Reviewed by Sam Weinig.

Source/WebCore:

* css/CSSPrimitiveValueMappings.h: Assert that CompositeDifference is
not converted to a CSS value. Exposing a new compositing operation to
CSS is outside the scope of this patch.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* platform/graphics/GraphicsTypes.h: Add CompositeDifference as a
CompositeOperator. Also, remove an outdated comment.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation): Map
CompositeDifference to kCGBlendModeDifference.

Source/WebKit/win:

* WebView.cpp:
(WebView::WebView): Initialize m_shouldInvertColors to false.
(WebView::paintIntoBackingStore): If m_shouldInvertColors is true, draw
an opaque white quad using the CompositeDifference blend mode. This
blend operation instructs CoreGraphics to take the difference between
the source pixel (white) and the background pixel, resulting in an
inverted pixel.
* WebView.h: Define m_shouldInvertColors.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Limit the shadow offset CG hack to just SL and Lion
https://bugs.webkit.org/show_bug.cgi?id=77348
<rdar://problem/10158016>

Reviewed by Chris Marrin.

No new tests, current tests cover this.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=77263
PlatformScreenMac should not rely on NSWindow for important bits of data

Reviewed by Geoff Garen.

../WebCore:

The main problem is that we cannot rely on the NSWindow for information about
the deviceScaleFactor because we cannot access an NSWindow from within
WebCore for WebKit2 windows. Instead, we can fetch it from
WebCore::deviceScaleFactor(), but we need a Frame to call that. So
screenAvailableRect and screenRect both now take a FrameView* instead of a
Widget*. All existing call sites actually sent a FrameView in anyway, so this
is not a big change, but it does require touching a lot of platforms.
* WebCore.exp.in:
* platform/PlatformScreen.h:
(WebCore):
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenAvailableRect):
(WebCore::screenRect):
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
():
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/win/PlatformScreenWin.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/wx/ScreenWx.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):

The Mac-only functions toUserSpace() and toDeviceSpace() were also updated to
take a parameter for the deviceScaleFactor.
* platform/mac/PlatformScreenMac.mm:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):

../WebKit/chromium:

These two functions now take a FrameView instead of a Widget.
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::screenRect):
(WebCore::PlatformSupport::screenAvailableRect):

../WebKit/mac:

toUserSpace() and toDeviceSpace() now take a parameter for the
deviceScaleFactor.
* WebCoreSupport/WebChromeClient.mm:
(windowScaleFactor):
(WebChromeClient::setWindowRect):
(WebChromeClient::windowRect):

../WebKit2:

toUserSpace() and toDeviceSpace() now take a parameter for the
deviceScaleFactor.
* UIProcess/API/mac/WKView.mm:
(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Enable web intents layout tests for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=77347

Patch by Greg Billock <gbillock@google.com> on 2012-01-30
Reviewed by Ryosuke Niwa.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed build fix following bug#76855

Source/JavaScriptCore:

* JavaScriptCore.exp:

Tools:

* TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
():
(TestWebKitAPI::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

CaseFoldingHash::hash() doesn't handle 8 bit strings directly
https://bugs.webkit.org/show_bug.cgi?id=76652

Reviewed by Andreas Kling.

* wtf/text/StringHash.h:
(WTF::CaseFoldingHash::hash): Added 8 bit string code path.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] enable -Wexit-time-destructors for webkit unit tests
https://bugs.webkit.org/show_bug.cgi?id=77300

Patch by Ami Fischman <fischman@chromium.org> on 2012-01-30
Reviewed by Tony Chang.

* WebKitUnitTests.gyp: Enable clang check for exit time destructors.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Kill CSSMutableStyleDeclarationConstIterator
https://bugs.webkit.org/show_bug.cgi?id=77342

Reviewed by Sam Weinig.

CSSMutableStyleDeclaration is an array and should be iterated using an index. This simplifies the code.

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::copyPropertiesFrom):
(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
(WebCore::CSSMutableStyleDeclaration::parseDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperties):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::merge):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
* css/CSSMutableStyleDeclaration.h:
(WebCore):
(WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
(CSSMutableStyleDeclaration):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
* css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
():
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::applyDeclaration):
* editing/EditingStyle.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

stringProtoFuncReplace converts 8 bit strings to 16 bit during replacement
https://bugs.webkit.org/show_bug.cgi?id=76651

Reviewed by Geoffrey Garen.

Made local function substituteBackreferencesSlow a template function
based on character width. Cleaned up getCharacters() in both UString
and StringImpl. Changed getCharacters<UChar> to up convert an 8 bit
string to 16 bits if necessary.

* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
* runtime/UString.h:
(JSC::LChar):
(JSC::UChar):
* wtf/text/StringImpl.h:
(WTF::UChar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] MediaStream API: Fix a few memory leaks
https://bugs.webkit.org/show_bug.cgi?id=77334

Reviewed by Darin Fisher.

It seems that either the behaviour of WebPrivatePtr has changed or I misunderstood
something, but I fixed a memory leak in WebMediaStreamDescriptor and safeguarded
WebMediaStreamSource.

* public/platform/WebMediaStreamDescriptor.h:
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
* public/platform/WebMediaStreamSource.h:
(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::operator=):
(WebMediaStreamSource):
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::assign):
* src/WebMediaStreamSource.cpp:
(WebKit::WebMediaStreamSource::assign):
(WebKit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Clean up putDirect
https://bugs.webkit.org/show_bug.cgi?id=76232

Reviewed by Sam Weinig.

Part 3 - merge op_put_getter & op_put_setter.

Putting these separately is inefficient (and makes future optimiation,
e.g. making GetterSetter immutable) harder. Change to emit a single
op_put_getter_setter bytecode op. Ultimately we should probably be
able to merge this with put direct, to create a common op to initialize
object literal properties.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
():
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPutGetterSetter):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JIT):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_getter_setter):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_getter_setter):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
():
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::putDirectAccessor):
(JSC):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
():
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Dromaeo tests call parseSimpleLengthValue() on 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=76649

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* JavaScriptCore.exp: Added export for charactersToDouble.

Source/WebCore:

No functionality change, therefore no new tests.

Added 8 bit patch for parseSimpleLengthValue().

* css/CSSParser.cpp:
(WebCore::parseSimpleLengthValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore decodeEscapeSequences unnecessarily converts 8 bit strings to 16 bit when decoding.
https://bugs.webkit.org/show_bug.cgi?id=76648

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added a new overloaded append member that takes a String& argument, an offest
and a length to do direct sub string appending to a StringBuilder.

* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):

Source/WebCore:

Using new overloaded append(String&, offset, length) member to build result string.
The new member properly handles 8/16 bit-ness of strings.

Functionality not changed, therefore no new tests.

* platform/text/DecodeEscapeSequences.h:
(WebCore::decodeEscapeSequences):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Not reviewed: follow up to r105625, use proper event categoty in inspector frontend.

* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION (r82580): Reproducible crash in CSSPrimitiveValue::computeLengthDouble
https://bugs.webkit.org/show_bug.cgi?id=61989

Patch by Parag Radke <nrqv63@motorola.com> on 2012-01-30
Reviewed by Simon Fraser.

Source/WebCore:

According to css3 specs when font-size is specified in 'rems' for an element implies the font-size
of the root element. In this case as HTML element has a property 'display:none' and hence renderer
is NULL causes this crash.

Test: fast/css/fontsize-unit-rems-crash.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Added a null check for the root element's RenderStyle as it can be null in case of html has a property
hidden or display:none.

LayoutTests:

Added a test case to check rems unit (css3) with html property display:none.

* fast/css/fontsize-unit-rems-crash-expected.txt: Added.
* fast/css/fontsize-unit-rems-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] WKTR: Use a software rendering pipiline when running tests.
https://bugs.webkit.org/show_bug.cgi?id=76708

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

* platform/graphics/qt/TextureMapperQt.cpp: Allow setting the context to null.
(WebCore::TextureMapperQt::setGraphicsContext):
* platform/graphics/qt/TextureMapperQt.h:
(WebCore::TextureMapperQt::initialize):

Source/WebKit2:

Animation layout tests require the graphics layers tree to be updated
to pass. WebkitTestRunner doesn't show its wrapping QQuickView, which
prevents the rendering pipeline to run and then in turn blocks the web
process from processing further graphics layer updates.

This allows the tests to use a TextureMapperQt to empty the LayerTreeHost's
message queue and render the layers in software on an offscreen buffer.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paint):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::setNeedsDisplay):
(QQuickWebViewExperimental::setRenderToOffscreenBuffer):
(QQuickWebViewExperimental::renderToOffscreenBuffer):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::setRenderToOffscreenBuffer):
(QQuickWebViewPrivate::renderToOffscreenBuffer):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):

Tools:

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::WrapperWindow):
(WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.

LayoutTests:

* platform/qt-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] Render layers do not get flushed when the scroll animation finishes
https://bugs.webkit.org/show_bug.cgi?id=77338

Reviewed by Noam Rosenthal.

Schedule a layer flush when setting the visible content rect and scale.

Fixed with the help of Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove all references to NSPasteboard objects from the Pasteboard
class interface on Mac.
https://bugs.webkit.org/show_bug.cgi?id=77261

This is cleanup work needed as first step in the direction of
removing access to NSPasteboard from the WebProcess.
This way all access to the NSPasteboard object are internal to
the class.
Removed static methods taking NSPasteboard as paramenter and changed
the constructor of the class to take the pasteboard name instead of
the NSPasteboard object.

Reviewed by Alexey Proskuryakov.

No new tests. There is no change in behavior.

* editing/Editor.cpp: Removed ununsed private method writeSelectionToPasteboard.
(WebCore):
* editing/Editor.h: Ditto.
(Editor):
():
* editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::readSelectionFromPasteboard):
* platform/Pasteboard.h:
(Pasteboard):
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writePlainText):
(WebCore::ClipboardMac::writeURL):
* platform/mac/DragDataMac.mm:
(WebCore::DragData::asPlainText):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::generalPasteboard):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::writeSelectionForTypes): Added.
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeURLForTypes): Added.
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reduce non-CSSOM API of CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=77299

Reviewed by Andreas Kling.

../WebCore:

CSSStyleDeclaration should expose the CSSOM API only. Subclasses should expose the internal API only.
This will move us closer to being able to split the CSSOM API from the internal implementation.

- Make CSSStyleDeclaration CSSOM functions virtual, internal functions non-virtual.
- Move implementations to subclasses (CSSComputedStyleDeclaration, CSSMutableStyleDeclaration).
- Make CSSOM functions in the subclasses private (making it harder to invoke them internally).
- Switch a bunch of places to use internal API instead of CSSOM.

* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

    Switch to *Internal versions of the CSSOM functions.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::length):
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

    Move copyPropertiesInSet to subclasses, devirtualize.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
(WebCore::CSSComputedStyleDeclaration::getPropertyShorthand):
(WebCore::CSSComputedStyleDeclaration::isPropertyImplicit):
(WebCore::CSSComputedStyleDeclaration::setProperty):
(WebCore::CSSComputedStyleDeclaration::removeProperty):
* css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::cssText):
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::length):
(WebCore::CSSMutableStyleDeclaration::asText):
(WebCore::CSSMutableStyleDeclaration::cssText):
(WebCore):
(WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
(WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
(WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
(WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::copyPropertiesInSet):

    Move copyPropertiesInSet to subclasses, devirtualize.

(WebCore::CSSMutableStyleDeclaration::cssPropertyMatches):
(WebCore::CSSMutableStyleDeclaration::removeEquivalentProperties):

    Move diff() to CSSMutableStyleDeclaration, rename to removeEquivalentProperties, switch to mutate
    this object instead of the argument object.

* css/CSSMutableStyleDeclaration.h:
(CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::propertyCount):
(WebCore::CSSMutableStyleDeclaration::isEmpty):
(WebCore::CSSMutableStyleDeclaration::propertyAt):

    Expose properties and property count internally (iterator should be removed in favor of these).

* css/CSSStyleDeclaration.cpp:
(WebCore):
* css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::CSSStyleDeclaration::getPropertyValueInternal):
(WebCore::CSSStyleDeclaration::setPropertyInternal):

    Add *Internal versions of some CSSOM APIs to support some editing and bindings uses.
    These take propertyIDs instead of strings names.

* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::cssText):
* css/CSSStyleSelector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::cssText):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/EditingStyle.cpp:
():
(WebCore::copyEditingProperties):
(WebCore):
(WebCore::propertyCSSValue):
(WebCore::getRGBAFontColor):
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::StyleChange::StyleChange):
(WebCore::fontWeightIsBold):
(WebCore::getPropertiesNotIn):
(WebCore::getIdentifierValue):
(WebCore::hasTransparentBackgroundColor):
* editing/EditingStyle.h:

    Adapt to changes.

(WebCore):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
* editing/mac/EditorMac.mm:
(WebCore::styleForSelectionStart):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::StyledMarkupAccumulator::appendElement):
* html/ImageDocument.cpp:
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
* html/canvas/CanvasStyle.cpp:
(WebCore::currentColor):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::revalidateStyle):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
* rendering/RenderTreeAsText.cpp:
(WebCore::isEmptyOrUnstyledAppleStyleSpan):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):

../WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::styleProperty):
(QWebElement::setStyleProperty):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: protocol validator should fail if one of response fields turns optional
https://bugs.webkit.org/show_bug.cgi?id=76452

Reviewed by Yury Semikhatsky.

* inspector/Inspector-0.1.json:
* inspector/Inspector.json:
* inspector/generate-inspector-protocol-version:
(compare_commands):
(compare_events):
(compare_params_list):
(compare_types):
(self_test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: keyboard navigation through comparison view in heap profiler should update retainers view
https://bugs.webkit.org/show_bug.cgi?id=77326

Keyboard navigation in the detailed heap snapshot view now updates retainers view.

Reviewed by Pavel Feldman.

* inspector/front-end/DataGrid.js: Added SelectedNode/DeselectedNode events to DataGrid.
(WebInspector.DataGridNode.prototype.select):
(WebInspector.DataGridNode.prototype.deselect):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._selectionChanged):
(WebInspector.DetailedHeapshotView.prototype._setRetainmentDataGridSource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2012-01-30  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix inspector front-end compilation.

        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject):
        (WebInspector.RemoteObject.fromPayload):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] remove exit time destructors from TextureManagerTest
https://bugs.webkit.org/show_bug.cgi?id=77333

Reviewed by Tony Gentilcore.

Non-trivial, global objects require an at-exit time destructor which add
unnecessary complexity and delays to shutdown.

* tests/FakeCCLayerTreeHostClient.h: added newline at EOF
* tests/TextureManagerTest.cpp:
(WTF::FakeTextureAllocator::~FakeTextureAllocator):
(TextureManagerTest):
(WTF::TextureManagerTest::TextureManagerTest):
(WTF::TextureManagerTest::~TextureManagerTest):
(WTF::TextureManagerTest::texturesMemorySize):
(WTF::TextureManagerTest::createTextureManager):
(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Node::parentOrHostElement(): Node::shadowHost() already returns an Element*
https://bugs.webkit.org/show_bug.cgi?id=77332

Reviewed by Kent Tamura.

No new tests. (simple refactoring)

* dom/Node.cpp:
(WebCore::Node::parentOrHostElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add manual tests for tap highlighting

Rubberstamped by Simon Hausmann.

* ManualTests/qt/tap-highlighting-colors.html: Added.
* ManualTests/qt/tap-highlighting-images.html: Added.
* ManualTests/qt/tap-highlighting-inlines.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Fix make distcheck.

Source/WebCore:

* GNUmakefile.am: Add idl files in Source/WebCore/html/shadow/ to
EXTRA_DIST.
* GNUmakefile.list.am: Add missing files.

Source/WebKit2:

* GNUmakefile.am: Add missing files.
* WebProcess/WebPage/TapHighlightController.cpp: Add #if
ENABLE(TOUCH_EVENTS).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] http/tests/history/replacestate-post-to-get-2.html fails with timeout
https://bugs.webkit.org/show_bug.cgi?id=76784

* platform/qt-wk2/Skipped: Unskip now passing test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: TabbedEditorContainer should save open tabs.
https://bugs.webkit.org/show_bug.cgi?id=76912

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/tabbed-editors-history.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.EditorContainer.prototype.uiSourceCodeAdded):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showFile):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype.showFile):
(WebInspector.TabbedEditorContainer.prototype._editorClosedByUserAction):
(WebInspector.TabbedEditorContainer.prototype._editorSelectedByUserAction):
(WebInspector.TabbedEditorContainer.prototype._updateHistory.tabIdToURL):
(WebInspector.TabbedEditorContainer.prototype._updateHistory):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype.reset):
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):
(WebInspector.TabbedEditorContainer.History.prototype.save):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype._innerCloseTab):
(WebInspector.TabbedPane.prototype.closeAllTabs):
(WebInspector.TabbedPane.prototype.lastOpenedTabIds):
(WebInspector.TabbedPane.prototype._tabsSelectChanged):

LayoutTests:

* inspector/tabbed-editors-history-expected.txt: Added.
* inspector/tabbed-editors-history.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: [Styles] Unable to paste and subsequently edit multiple properties in the Styles pane
https://bugs.webkit.org/show_bug.cgi?id=77209

Reviewed by Pavel Feldman.

Source/WebCore:

Check if the property value contains a ";" before kicking the freeflow text update.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

* inspector/styles/styles-add-blank-property-expected.txt:
* inspector/styles/styles-add-blank-property.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: Change Open Resource and Go To function shortcuts in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=77321

Reviewed by Pavel Feldman.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.OpenResourceDialog.createShortcut):
* inspector/front-end/ScriptsPanel.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: hide function popover in heap snapshot view before navigating to the function definition
https://bugs.webkit.org/show_bug.cgi?id=77330

Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.willHide):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] Credential backing store implementation
https://bugs.webkit.org/show_bug.cgi?id=76761

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-01-30
Reviewed by Antonio Gomes.

Implemented credential backing store database and related
operations in class CredentialBackingStore.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::clear):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Store build config immediately instead of waiting for a successfull build

Otherwise we will not pick up changes to the config if the build is aborted,
for example due to build errors or if the user pressed Ctrl+Z. We now write
the new config before starting a build, but still defer to write the SVN
revision once the build completes successfully.

Reviewed by Ossy.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

.: Manual test of number of resize events emitted during page generation.
https://bugs.webkit.org/show_bug.cgi?id=77212

Is needed to test if too many resize events are send when using fixed
layout, and needs to be a manual test because the test framework does
not currently support testing fixed layout.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-30
Reviewed by Kenneth Rohde Christiansen.

* ManualTests/resize-events.html: Added.

Source/WebCore: Only send resize events when layout size changes.
https://bugs.webkit.org/show_bug.cgi?id=77212

When using fixed layout the widget size is the size of content, therefore
resize checks must check against layoutsize and not widget size.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-30
Reviewed by Kenneth Rohde Christiansen.

Needs to be manual tests because the test framework does not currently
support testing fixed layout.

Tests: ManualTests/resize-events.html

* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Add "New Window" button to the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=77281

Patch by Alexander Færøy <ahf@0x90.dk> on 2012-01-30
Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/icons/plus.png: Added.
* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: TimelinePanel does not respect InspectorFrontendHost.canSaveAs
https://bugs.webkit.org/show_bug.cgi?id=77301

Reviewed by Vsevolod Vlasov.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._registerShortcuts):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2012-01-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix Clang build for real after r106218.

        * inspector/CodeGeneratorInspector.py:
        (Generator.go): Add virtual destructor to the ABCs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

No need to keep anonymous RenderBlock in DETAILS.
https://bugs.webkit.org/show_bug.cgi?id=77322

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-30
Reviewed by Hajime Morita.

Anonymous RenderBlock of DETAILS element was not squashed when detaching them.
However, it should be removed.

No new tests. Should be covered by existing tests.

* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Custom written CSS lexer
https://bugs.webkit.org/show_bug.cgi?id=70107

Rubber Stamped by Csaba Osztrogonác.

Do not advance pointer at the end of input, just
keep returning with END_TOKEN.

* css/CSSParser.cpp:
(WebCore::CSSParser::lex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Unreviewed test expectation change.
fast/js/dfg-int32array.html is slow on WIN DEBUG and MAC DEBUG.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

The query selector for HTMLContentElement should follow the shadow dom spec.
https://bugs.webkit.org/show_bug.cgi?id=75946

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-30
Reviewed by Hajime Morita.

Source/WebCore:

Checks the query selector of HTMLContentElement is valid.
If not valid, the selector won't match anything, and shows fallback element.

Test: fast/dom/shadow/content-selector-query.html

* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::isValidSelector):
(WebCore::ContentSelectorQuery::matches):
  When a select query is not valid, any element won't be matched.
(WebCore::validateSubSelector):
(WebCore::validateSelector):
(WebCore::ContentSelectorQuery::validateSelectorList):
  Validate selectors.
* html/shadow/ContentSelectorQuery.h:
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::isSelectValid):
  Returns true if select attribute is valid.
* html/shadow/HTMLContentElement.h:
* testing/Internals.cpp:
(WebCore::Internals::isValidContentSelect):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/content-selector-query-expected.txt: Added.
* fast/dom/shadow/content-selector-query.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed rolling out r106222.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.__init__):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::setIsPixelTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r106219.
http://trac.webkit.org/changeset/106219
https://bugs.webkit.org/show_bug.cgi?id=77083

This broke Chromium's test_shell.

Source/WebCore:

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/mock/SpeechInputClientMock.cpp: Added.
(WebCore):
(WebCore::SpeechInputClientMock::SpeechInputClientMock):
(WebCore::SpeechInputClientMock::setListener):
(WebCore::SpeechInputClientMock::startRecognition):
(WebCore::SpeechInputClientMock::stopRecording):
(WebCore::SpeechInputClientMock::cancelRecognition):
(WebCore::SpeechInputClientMock::addRecognitionResult):
(WebCore::SpeechInputClientMock::clearResults):
(WebCore::SpeechInputClientMock::timerFired):
* platform/mock/SpeechInputClientMock.h: Added.
(WebCore):
(SpeechInputClientMock):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebSpeechInputControllerMock.h: Added.
(WebKit):
(WebSpeechInputControllerMock):
(WebKit::WebSpeechInputControllerMock::~WebSpeechInputControllerMock):
* public/WebSpeechInputResult.h:
(WebSpeechInputResult):
* src/WebSpeechInputControllerMockImpl.cpp: Added.
(WebKit):
(WebKit::WebSpeechInputControllerMock::create):
(WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl):
(WebKit::WebSpeechInputControllerMockImpl::~WebSpeechInputControllerMockImpl):
(WebKit::WebSpeechInputControllerMockImpl::addMockRecognitionResult):
(WebKit::WebSpeechInputControllerMockImpl::clearResults):
(WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording):
(WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition):
(WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult):
(WebKit::WebSpeechInputControllerMockImpl::startRecognition):
(WebKit::WebSpeechInputControllerMockImpl::cancelRecognition):
(WebKit::WebSpeechInputControllerMockImpl::stopRecording):
* src/WebSpeechInputControllerMockImpl.h: Added.
(WebCore):
(WebKit):
(WebSpeechInputControllerMockImpl):
* src/WebSpeechInputResult.cpp:

Tools:

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::addMockSpeechInputResult):
* DumpRenderTree/chromium/LayoutTestController.h:
(WebKit):
(LayoutTestController):
():
* DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
* DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::speechInputController):
* DumpRenderTree/chromium/WebViewHost.h:
(WebKit):
(WebViewHost::speechInputControllerMock):
(WebViewHost):
():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106223 268f45cc-cd09-0410-ab3c-d52691b4dbfc