Pekka Pessi [Thu, 27 May 2010 16:12:45 +0000 (19:12 +0300)]
Eliminated bool, true and false from gisi
Pekka Pessi [Thu, 27 May 2010 16:12:43 +0000 (19:12 +0300)]
Use ofono_bool_t instead of bool in modem API.
Pekka Pessi [Thu, 27 May 2010 16:29:51 +0000 (19:29 +0300)]
modem: Fix inconsistent state
Keep modem state consistent if sim is removed while set_online
driver call is pending. This results in set_online callback being
called and modem entering an invalid state.
Denis Kenzior [Thu, 27 May 2010 17:36:47 +0000 (12:36 -0500)]
stkutil: Refactor parsing of data object lists
The old way wasn't working out for lists that are optional. This was
only a problem with the launch browser proactive command.
Yang Gu [Wed, 26 May 2010 14:39:14 +0000 (22:39 +0800)]
Move destructor prior to return
Yang Gu [Wed, 26 May 2010 14:39:13 +0000 (22:39 +0800)]
teststk: Add test for launch browser parser
Yang Gu [Wed, 26 May 2010 14:39:08 +0000 (22:39 +0800)]
stk: Add parser for launch browser commands
Denis Kenzior [Thu, 27 May 2010 14:26:45 +0000 (09:26 -0500)]
stkutil: Refactor SMS pdu parser
Denis Kenzior [Thu, 27 May 2010 14:25:48 +0000 (09:25 -0500)]
smsutil: add sms_decode_unpacked_stk_pdu function
Properly check the special 'packing required' sms pdus sent by SIM
toolkit.
Yang Gu [Wed, 26 May 2010 14:39:11 +0000 (22:39 +0800)]
stk: Fix the parser of send sms
Yang Gu [Wed, 26 May 2010 14:39:10 +0000 (22:39 +0800)]
test-stkutil: Add cases for send sms parser
Yang Gu [Wed, 26 May 2010 14:39:10 +0000 (22:39 +0800)]
smsutil: Check that udl is less than 140
Yang Gu [Wed, 26 May 2010 14:39:10 +0000 (22:39 +0800)]
teststk: Use check_common_text() to check string
Yang Gu [Wed, 26 May 2010 14:39:09 +0000 (22:39 +0800)]
teststk: Add check of len in byte array
Yang Gu [Thu, 27 May 2010 09:24:34 +0000 (17:24 +0800)]
teststk: Use sim bcd version
Yang Gu [Thu, 27 May 2010 09:24:33 +0000 (17:24 +0800)]
stk: Use sim bcd version
Pekka Pessi [Tue, 25 May 2010 21:14:41 +0000 (00:14 +0300)]
Add Online property to modem-api.txt
Pekka Pessi [Tue, 25 May 2010 21:14:39 +0000 (00:14 +0300)]
Add: test scripts online-modem and offline-modem
Denis Kenzior [Wed, 26 May 2010 22:45:06 +0000 (17:45 -0500)]
Fix: Go to online state if set_online is NULL
Denis Kenzior [Wed, 26 May 2010 22:43:01 +0000 (17:43 -0500)]
Refactor: no need for dummy_online_callback
Denis Kenzior [Wed, 26 May 2010 22:34:56 +0000 (17:34 -0500)]
Fix: Don't allow setting online before sim ready
Denis Kenzior [Wed, 26 May 2010 22:34:10 +0000 (17:34 -0500)]
Refactor: Break up set_online_callback
- Break up into two functions, one for online and one for offline
- No longer the need for online_pending variable
Denis Kenzior [Wed, 26 May 2010 22:32:28 +0000 (17:32 -0500)]
Add __ofono_error_not_available
Denis Kenzior [Wed, 26 May 2010 22:14:09 +0000 (17:14 -0500)]
Refactor: flush_atoms
The current implementation did not take care of the case where the head
of the list was removed
Denis Kenzior [Wed, 26 May 2010 20:19:07 +0000 (15:19 -0500)]
Refactor: Don't use ofono_ prefix
Only meant for oFono public API
Denis Kenzior [Wed, 26 May 2010 20:13:04 +0000 (15:13 -0500)]
Refactor: The macros are no longer needed
Denis Kenzior [Wed, 26 May 2010 20:09:40 +0000 (15:09 -0500)]
Refactor: Don't use ofono_ prefix
Only to be used for ofono public API
Denis Kenzior [Wed, 26 May 2010 20:09:11 +0000 (15:09 -0500)]
Refactor: Don't use ofono_ prefix
only meant for public API
Denis Kenzior [Wed, 26 May 2010 20:01:36 +0000 (15:01 -0500)]
Refactor: Don't use ofono_ prefix
ofono_ prefix is meant for public API
Denis Kenzior [Wed, 26 May 2010 19:25:38 +0000 (14:25 -0500)]
Fix: minor style issues
Pekka Pessi [Wed, 26 May 2010 14:58:06 +0000 (17:58 +0300)]
Add: Online property to modem
The online/offline state is changed with the new set_online() modem driver
method.
In order to track atoms, there are modem states as follows:
- OFONO_MODEM_STATE_POWER_OFF
- OFONO_MODEM_STATE_PRE_SIM
- OFONO_MODEM_STATE_OFFLINE
- OFONO_MODEM_STATE_ONLINE
Atoms are added with driver methods pre_sim(), post_sim() and post_online().
Atoms are removed by modem core when the state changes.
Marcel Holtmann [Wed, 26 May 2010 19:02:58 +0000 (21:02 +0200)]
Release 0.21
Marcel Holtmann [Wed, 26 May 2010 18:01:50 +0000 (20:01 +0200)]
Mention Kalle's contributions
Kalle Valo [Wed, 26 May 2010 15:36:21 +0000 (18:36 +0300)]
atmodem: fix crash during context deactivation
Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
tried to deactivate GPRS context. The reason was that gcd->chat was
unreferenced already in setup_ppp() but the chat was still accessed
later in at_gprs_deactivate_primary().
To fix the problem, change the logic instead to suspend chat session
for PPP and resume when PPP has disconnected. Now it doesn't crash
anymore.
Deactivation still doesn't work properly with Huawei E1552, and most
probably with other Huawei modems, because the modem hangs up the chat
line after PPP deactivation. This needs to be fixed separately. The
workaround is to reboot the modem, for example physically unplug and plug
it in again.
Kalle Valo [Wed, 26 May 2010 15:36:15 +0000 (18:36 +0300)]
atmodem: refactor context deactivation
The old way of using CGACT is no longer needed. It is enough
that we shutdown PPP. Recommended by Denis.
Andrzej Zaborowski [Wed, 26 May 2010 03:59:40 +0000 (05:59 +0200)]
test-stkutil: Use gcc4.3 compatible initialisers.
Reformat according to ideas on IRC.
Aki Niemi [Wed, 26 May 2010 15:43:45 +0000 (18:43 +0300)]
Fix more-messages-to-send indicator
Set the mms indicator based on remaining segment count and not on the
message transmit queue status alone.
Denis Kenzior [Wed, 26 May 2010 15:00:02 +0000 (10:00 -0500)]
simutil: Make sim_adn_build use sim bcd
Denis Kenzior [Wed, 26 May 2010 14:58:47 +0000 (09:58 -0500)]
simutil: Add sim_encode_bcd_number
Denis Kenzior [Wed, 26 May 2010 14:51:51 +0000 (09:51 -0500)]
simutil: Make sim_adn_parse use sim bcd version
Denis Kenzior [Wed, 26 May 2010 14:50:51 +0000 (09:50 -0500)]
simutil: add sim_extract_bcd_number
Denis Kenzior [Wed, 26 May 2010 14:17:25 +0000 (09:17 -0500)]
smsutil: Update the doc for extract_bcd_number
Yang Gu [Wed, 19 May 2010 10:24:46 +0000 (18:24 +0800)]
teststk: Add test for language notification parser
Yang Gu [Wed, 19 May 2010 10:24:45 +0000 (18:24 +0800)]
stk: Add parser for language notification commands
Yang Gu [Wed, 19 May 2010 10:24:44 +0000 (18:24 +0800)]
test-stk: Add test for send dtmf parser
Yang Gu [Wed, 19 May 2010 10:24:43 +0000 (18:24 +0800)]
stk: Add parser for send dtmf commands
Yang Gu [Wed, 19 May 2010 10:24:42 +0000 (18:24 +0800)]
test-stk: Add test for run at command parser
Yang Gu [Wed, 19 May 2010 10:24:41 +0000 (18:24 +0800)]
stk: Add parser for run at command commands
Yang Gu [Wed, 19 May 2010 10:24:40 +0000 (18:24 +0800)]
test-stk: Add test for setup idle mode text parser
Yang Gu [Wed, 19 May 2010 10:24:39 +0000 (18:24 +0800)]
stk: Add parser for setup idle mode text commands
Andrzej Zaborowski [Sun, 16 May 2010 14:08:29 +0000 (16:08 +0200)]
simutil: Add MMC MNC pair encoding utility
Denis Kenzior [Mon, 24 May 2010 23:11:43 +0000 (18:11 -0500)]
stkutil: Fix warning
Denis Kenzior [Mon, 24 May 2010 23:07:50 +0000 (18:07 -0500)]
stkutil: More style issues
- Make stk_tlv_builder usage consistent (builder was missing)
- Various style issues
Andrzej Zaborowski [Sun, 16 May 2010 14:08:17 +0000 (16:08 +0200)]
smsutil: Expose SMS timestamp encoding utility
The function can be re-used in stkutil.c, similarly to sms_decode_scts.
Andrzej Zaborowski [Sun, 16 May 2010 14:07:30 +0000 (16:07 +0200)]
test-stkutil: Add Select Item response tests
Denis Kenzior [Mon, 24 May 2010 22:51:21 +0000 (17:51 -0500)]
stkutil: small style issue
Andrzej Zaborowski [Sun, 16 May 2010 14:07:22 +0000 (16:07 +0200)]
stkutil: Add Select Item response builder
Andrzej Zaborowski [Sun, 16 May 2010 14:07:00 +0000 (16:07 +0200)]
test-stkutil: Add Set Up Menu response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:06:51 +0000 (16:06 +0200)]
stkutil: Add Set Up Menu response builder
Andrzej Zaborowski [Sun, 16 May 2010 14:06:43 +0000 (16:06 +0200)]
test-stkutil: Add Refresh response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:06:34 +0000 (16:06 +0200)]
stkutil: Add Refresh response builder
Andrzej Zaborowski [Sun, 16 May 2010 14:06:26 +0000 (16:06 +0200)]
test-stkutil: Add Poll Interval response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:06:17 +0000 (16:06 +0200)]
stkutil: Add Poll Interval response builder
Andrzej Zaborowski [Sun, 16 May 2010 14:06:09 +0000 (16:06 +0200)]
test-stkutil: Add Play Tone response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:06:01 +0000 (16:06 +0200)]
stkutil: Add Play Tone response builder support
Andrzej Zaborowski [Sun, 16 May 2010 14:05:49 +0000 (16:05 +0200)]
test-stkutil: Add Send SMS response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:05:39 +0000 (16:05 +0200)]
stkutil: Add Send SMS response builder
Andrzej Zaborowski [Sun, 16 May 2010 14:05:29 +0000 (16:05 +0200)]
test-stkutil: Add Get Input response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:05:21 +0000 (16:05 +0200)]
stkutil: Add Get Input response builder
Denis Kenzior [Mon, 24 May 2010 22:20:21 +0000 (17:20 -0500)]
stkutil: Various code style issues
Andrzej Zaborowski [Sun, 16 May 2010 14:05:12 +0000 (16:05 +0200)]
test-stkutil: Add Get Inkey response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:05:04 +0000 (16:05 +0200)]
stkutil: Add Get Inkey response builder
Denis Kenzior [Mon, 24 May 2010 21:02:34 +0000 (16:02 -0500)]
stkutil: Make the code more readable
Andrzej Zaborowski [Sun, 16 May 2010 14:04:54 +0000 (16:04 +0200)]
test-stkutil: Add Display Text response tests
Andrzej Zaborowski [Sun, 16 May 2010 14:04:46 +0000 (16:04 +0200)]
stkutil: Add Display Text response builder
Denis Kenzior [Mon, 24 May 2010 21:04:23 +0000 (16:04 -0500)]
stkutil: Simplify append_text
Andrzej Zaborowski [Sun, 16 May 2010 14:04:36 +0000 (16:04 +0200)]
Add STK-specific CTLV encoding utilities
Denis Kenzior [Mon, 24 May 2010 17:39:11 +0000 (12:39 -0500)]
simutil: simplify ctlv logic
Denis Kenzior [Mon, 24 May 2010 16:30:59 +0000 (11:30 -0500)]
simutil: Simplify ber_tlv_builder_optimize logic
Denis Kenzior [Mon, 24 May 2010 16:07:30 +0000 (11:07 -0500)]
simutil: Simplify ber_tlv builder set_length logic
Denis Kenzior [Fri, 21 May 2010 01:17:47 +0000 (20:17 -0500)]
simutil: Simplify builder_write_header
Denis Kenzior [Thu, 20 May 2010 23:29:06 +0000 (18:29 -0500)]
simutil: Be more type-correct
Denis Kenzior [Thu, 20 May 2010 23:05:48 +0000 (18:05 -0500)]
simutil: Get rid of ugly-named functions
Replace them by macros
Andrzej Zaborowski [Sun, 16 May 2010 14:04:28 +0000 (16:04 +0200)]
test-simutil: Add a BER-TLV encoding tests
Andrzej Zaborowski [Sun, 16 May 2010 14:01:28 +0000 (16:01 +0200)]
simutil: Add utilities for encoding BTLV and CTLV
Pessi Pekka (Nokia-D/Helsinki) [Tue, 25 May 2010 20:37:07 +0000 (22:37 +0200)]
isimodem: fix confusing log message
Pessi Pekka (Nokia-D/Helsinki) [Tue, 25 May 2010 20:37:06 +0000 (22:37 +0200)]
isimodem: fix memory leak
Pessi Pekka (Nokia-D/Helsinki) [Tue, 25 May 2010 20:37:05 +0000 (22:37 +0200)]
Fix: set correct local address for phonet on PCs
Aki Niemi [Tue, 25 May 2010 21:06:12 +0000 (00:06 +0300)]
Fix minor style issues
Pessi Pekka (Nokia-D/Helsinki) [Tue, 25 May 2010 20:37:04 +0000 (22:37 +0200)]
Add: support for EF_ICCID in isimodem.
Kalle Valo [Tue, 25 May 2010 14:23:32 +0000 (17:23 +0300)]
huawei: remove voicecall support
These modems don't support voicecall anyway. Recommended by Denis.
Kalle Valo [Tue, 25 May 2010 14:23:26 +0000 (17:23 +0300)]
huawei: send a prefix with AT commands
Kalle Valo [Tue, 25 May 2010 14:23:19 +0000 (17:23 +0300)]
huawei: properly notify sim state to ofono
Instead of using ofono_modem_set_powered(), use ofono_sim_inserted_notify()
which is the proper way to notify about sim state changes.
Now the problem is that voicecall commands fail with my Huawei E1552:
ofonod[12395]: > AT+CRC=1\r
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+CLIP=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+COLP=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+CCWA=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: drivers/atmodem/voicecall.c:at_voicecall_initialized()
voicecall_init: registering to notifications
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: > AT^SYSINFO\r
ofonod[12395]: < \r\n^SYSINFO:0,0,0,0,255,,0\r\n\r\nOK\r\n
ofonod[12395]: > AT+CGMI\r
ofonod[12395]: < \r\nhuawei\r\n\r\nOK\r\n
ofonod[12395]: EventChannel: < \r\n^STIN:0,0,0\r\n
ofonod[12395]: > AT+CLCC\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
But as I can't make voice calls with this modem anyway, I don't worry
about them right now.
Kalle Valo [Tue, 25 May 2010 14:23:13 +0000 (17:23 +0300)]
huawei: use g_at_result_iter_skip_next()
Marcel Holtmann [Tue, 25 May 2010 09:13:48 +0000 (11:13 +0200)]
Some minor cleanups for the Huawei plugin
Kalle Valo [Tue, 25 May 2010 08:48:57 +0000 (11:48 +0300)]
huawei: follow sim state change notifications
With Huawei E1552 I got sim busy errors when I plugged in the modem
and ofono was already running:
May 24 17:02:04 tukki ofonod[7619]: > AT+CRC=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n
May 24 17:02:04 tukki ofonod[7619]: > AT+CLIP=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n
Fix this by following sim state changes with ^SIMST notification and
only enable modem after SIM is ready. In case SIM is already ready
and we miss the notification for some reason, also use AT^SYSINFO
to check the state during enable phase.
Also change huawei_enable() to return -EINPROGRESS to make sure that
ofono modem is not powered too early. I believe this was a bug.
Marcel Holtmann [Tue, 25 May 2010 09:08:58 +0000 (11:08 +0200)]
Break function declaration down to two lines
Gustavo F. Padovan [Tue, 25 May 2010 08:09:21 +0000 (05:09 -0300)]
Bring back -d option without need for argument
Marcel Holtmann [Fri, 21 May 2010 09:43:30 +0000 (11:43 +0200)]
Some extra empty lines to separate chapters
Denis Kenzior [Thu, 20 May 2010 04:48:34 +0000 (23:48 -0500)]
sim: Read EFiccid after EFphase