s.kamath [Thu, 19 Feb 2015 13:05:04 +0000 (18:35 +0530)]
[MM][WebRTC] OMX codec integration on m0 target.
Added support for accelarated encoding/decoding with WebRTC.
Uses omxh264 encoder & decoder for accelaration.
Avoiding usage of convertor as camera output is in I420 format.
h264parser needed at decoder pipeline as omxh264dec take
parsed frames at src pad.
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: I28708efeb48427125c3ba708c454cd556fb205c3
Signed-off-by: s.kamath <s.kamath@samsung.com>
Youngsoo Choi [Tue, 10 Feb 2015 10:32:40 +0000 (19:32 +0900)]
[Tizen][OBS] Changes for Tizen OBS Build
[Issue]
OBS build does not support running script 'build_{target].sh'.
1) GBS Build Options
In OBS build, definitions, coming through gbs build option, can NOT be used,
such as 'chromium_efl_tizen_version'.
2) Package Name
In OBS build, using macros around property 'Name' in spec file is not allowed.
3) Supplementary Repository
In OBS build, the supplementary repository is not allowed.
[Resolve]
1) GBS Build Options
The definitions, coming through gbs repository, are used,
instead of the definitions coming through gbs build option.
2) Package Name
In Tizen v3.0, appid should be consist of '.',
but package name doesn't need to follow that rule.
3) Supplementary Repository
The supplementary repository is removed in the file 'gbs.conf'.
Currently, chromium-efl doesn't have dependency of supplementary repository.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11500
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11502
Reviewed by: Antonio Gomes, KC Park, SeungSeop Park
Change-Id: I91876dadbd3643dec2046e87d7e0658a68292d81
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
amit.kumar8 [Tue, 24 Feb 2015 07:19:57 +0000 (12:49 +0530)]
fixup! fixup! Fix ewk_view_orientation_send API
Sending following message:
rwh->Send(new ViewMsg_Resize(rwh->GetRoutingID(), params));
is causing video playback issues during orientation change.
In chromium code there is only one place that is sending
this message and it's guarded around in many ways, hence
disabling it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11476
Reviewed by: DaeHyun Ko, Siba Samal
Change-Id: I53a91c07a55d1f73cbfb364e4ba646e209ac55bc
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
Sergey Stepantsov [Thu, 12 Feb 2015 10:47:14 +0000 (19:47 +0900)]
TV Crash in Speed reading site
Lunch timer in appropriate thread
TV uses player_product.h in media_player_bridge_capi.cc,
player_prepare_async is used to prepare player to play content
callback for this returned in new thread and in this thread
timers will be lunched to update current time and buffer state. It
leads to crash, as timer should be run from the same thread.
(For phone problem is not reproducible, because phone uses
player_internal.h and callback for player_prepare_async always
returns control to UI thread).
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10941
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: Id2026e6a093410dbb173c4f7edbae20b57a6273e
Signed-off-by: Sergey Stepantsov <s.stepantsov@samsung.com>
uzair.jaleel [Mon, 16 Feb 2015 13:36:26 +0000 (19:06 +0530)]
Updated EGL samples to 4 for Mali t400
Best Supported EGL framebuffer configuration is
Red : 8
Green : 8
Blue : 8
Alpha : 8
Depth : 24
Stencil : 8
Samples : 4
Bug :http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Reviewed by: DaeHyun Ko, Siba Samal, venu musham
Change-Id: Ie758837c7be52cd8691970b629dc3ad1c4772d61
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Arnaud Renevier [Mon, 23 Feb 2015 23:12:21 +0000 (15:12 -0800)]
Fixes compiler warnings
This patch fixes various compiler warnings: initialization order of
class members, incorrect sign comparaison, uninitialized variable,
incorrect return types, incorrect enum comparaison and incorrect type
conversions.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=9706
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I6aeccb073cf9561d2cbb09c5c63e60397d81a8d1
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Youngcheol Kang [Mon, 23 Feb 2015 09:06:25 +0000 (18:06 +0900)]
[TIZEN][OBS] Excluded all Arch build from wearable profile
The chromium-efl doesn't support the wearable profile.
According to the platform team's request,
the codes for excluding the all Arch from wearable were
added into the spec file.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11507
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I6cbf89ee20fb17c867031b77604a8cfb536dc904
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
uzair.jaleel [Thu, 19 Feb 2015 14:36:24 +0000 (20:06 +0530)]
Invoke draw call to evas gl surface only for a valid texture.
Currently, texture id is not initialized for a new RWHV. So, when we
navigate to a new page, a draw attempt is made for an undefined texture
and hence we see the black screen. With this patch, we draw only when
the texture is valid.
Bug: http://168.219.209.56/jira/browse/TNEF-166
Reviewed by: Siba Samal, venu musham
Change-Id: I19665a4fa6252d86364b2fc4e4ea484d78a551cf
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Chandan Padhi [Fri, 20 Feb 2015 10:28:44 +0000 (15:58 +0530)]
[M34 Merge] Fixed that webview is crushed on resizing viewport.
webView is crushed when creating/removing IME and rotating device.
It is caused by diffrence between the size of egl surface rendered
and glViewport arguments. The arguments were set by evas geometry size,
but it was different from the size of rendered surface.
M34-merge: http://165.213.202.130:8080/#/c/69746/
Bug: http://168.219.209.56/jira/browse/TNEF-190
Reviewed by: DaeHyun Ko, Siba Samal, venu musham
Change-Id: I3e00275dc439ef04c78b6709010aaf5a49c54a84
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Arnaud Renevier [Tue, 17 Feb 2015 18:26:08 +0000 (10:26 -0800)]
fixup! Fix user agent setter unittests
Right now, utc_blink_ewk_view_user_agent_set_func.cpp fails to build
with "error: invalid conversion from ‘const void*’ to ‘void*’"
We now Eina_Stringshare instead of const char*
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10887
Reviewed by: DONGJUN KiM, Piotr Tworek
Change-Id: I2dd071569b61d59495373ff456ff1990f956b39b
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
venu musham [Tue, 17 Feb 2015 10:37:48 +0000 (19:37 +0900)]
[M34 Merge] Add default color to new initialized EvasGL
While new tab in browser is created there is black screen
visible, because EvasGL is initialized with default black
image. This change initialize EvasGL with white image and
result there is no more black screen while new tab is
opened.
M34-merge: http://165.213.202.130:8080/#/c/69924/
Bug: http://168.219.209.56/jira/browse/TNEF-166
Reviewed by: DaeHyun Ko, Prashant Nevase (OOO Feb/20 to Feb/24)
Change-Id: Ia8e337cf49db06122a496822a0e4833eb16e7afc
Signed-off-by: venu musham <venu.musham@samsung.com>
Dominik Duda [Tue, 17 Feb 2015 11:20:24 +0000 (12:20 +0100)]
Add profile for build on Tizen 3.0 TV emulator
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11434
Reviewed by: KC Park, Marcin Kolibabka, Piotr Tworek
Change-Id: I73f7c3fcdacedaaf16edd820c27344b69c921cdd
Signed-off-by: Dominik Duda <d.duda@samsung.com>
Antonio Gomes [Thu, 18 Dec 2014 15:56:32 +0000 (07:56 -0800)]
Remove unneeded pkg-config dependency: capi-appfw-application
No targets actually need it to build/link/run.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Antonio Gomes, Piotr Tworek, Viatcheslav Ostapenko, commitbot
Change-Id: I369c850b41880049ace073a55457ed4633595ae6
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Filip Piechocki [Tue, 16 Dec 2014 10:01:23 +0000 (11:01 +0100)]
Custom protocol handler test page added.
Custom protocol handlers' origin must have 'http' or 'https'
protocol and the site registering the custom handler must be
of the same origin as this handler. This implies, that the
test page's origin must have 'http' or 'https' protocol, so
we hosted this test page on GitHub:
http://jmajnert.github.io/tests/customProtocols/
and modified tests to use it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9522
Reviewed by: Antonio Gomes, Min-Soo Koo, Piotr Tworek, commitbot
Change-Id: I5bfc9ff681f1bdfde1131af6d25f88c42bc92235
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Sergey Stepantsov [Mon, 15 Dec 2014 05:18:19 +0000 (14:18 +0900)]
Added functionality to take screenshot in mini_browser phone application.
By pressing menu button mini_browser saves
screen shot of web page in /opt/usr/media/Downloads as png.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9796
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Signed-off-by: Sergey Stepantsov <s.stepantsov@samsung.com>
Change-Id: I9afb4ceb6424da106a150b57026761c64616fa05
Antonio Gomes [Wed, 18 Feb 2015 16:06:40 +0000 (12:06 -0400)]
Properly handle context menu item callbacks on desktop.
In ContextMenuControllerEfl::ContextMenuItemSelectedCallback
there is desktop only ifdef that at somepoint made it possible
to get context menu items callbacks working.
Today, the assumption and workaround in that block of code do
not apply anymore, and was making in fact breaing context menu
items' callbacks to work.
Patch removes it and unifies mobile, tv and desktop code paths.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek, arno renevier
Change-Id: I4230f336430b9e97478c9efa1f1592a5d3d18b5e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Tomasz Czekala [Fri, 20 Feb 2015 10:00:46 +0000 (11:00 +0100)]
Fix unittests for ewk_view_add_with_session_data
Added check for ewk_view_add_with_session_data and deleting webview to
remove all instances of WebContext
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9537
Reviewed by: DONGJUN KiM, Filip Piechocki, Piotr Tworek
Change-Id: I582a06562df6b67dc78a38c2b9f3626019e0a473
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 21:20:11 +0000 (17:20 -0400)]
Let tap's selection bits be handled by SelectionController
Lots of code in EWebView::HandleTapGesture did not belong there,
and should be defered to SelectionControllerEfl.
Patch pulls the trigger.
http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Tworek, arno renevier
Change-Id: If59d48daad54b05e1432e42bb5814444942d2088
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 20:54:11 +0000 (16:54 -0400)]
Let long press selection bits be handled by SelectionController
Lots of code in EWebView::HandleLongPressGesture did not
belong there, and should be defered to SelectionControllerEfl.
Patch pulls the trigger.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Grad, arno renevier
Change-Id: I157619d78cb590ae67b93564050837391fcc3a43
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 14:34:48 +0000 (10:34 -0400)]
Remove unused methods from tizen_webview/public/tw_webview.cc
In the process of slimming simplifying our code, patch
removes two unused methods from our WebView API:
HandleGesture(ui::GestureEvent*) and HandleTouchEvent(ui::TouchEvent)
Reviewed by: Piotr Grad, arno renevier
Change-Id: I2d2e369c9bf5ae717d184fb214fc77c00845db86
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Piotr Grad [Mon, 16 Feb 2015 15:16:53 +0000 (16:16 +0100)]
Fix for JS popup appearance
Because current efl for mobile doesn't pass rotate events to windows and
there are other issues with rendering windows (black screen, transparent,
flickering, etc.) popup is created now on top of EWebView instead of a
new window. Even popup is resized upon rotate its content wasn't - so
that changed min scroller height to fit display size in landscape mode.
elm_object_widget_type_get(content) was failing (platform issue) so used bool flag instead.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11390
Reviewed by: Antonio Gomes, Marcin Kolibabka, Piotr Grad
Change-Id: Id2787f74cd6f0f61d6d183ec7e8b1f8fd2ca96fc
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Venugopal S M [Thu, 19 Feb 2015 07:01:48 +0000 (12:31 +0530)]
fixup! Add initial support for Tizen 3.0 TV platform
Gstreamer1.0 is used for Mobile(Tizen 2.4). Modified
condition to enable Gstreamer1.0 support for Tizen 2.4
and above.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11476
Reviewed by: Antonio Gomes, Sharath Kamath
Change-Id: I4eb4a04f30610ab3f3c49685cc20193b2f9541ad
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
s.kamath [Thu, 19 Feb 2015 11:47:24 +0000 (17:17 +0530)]
fixup! [Tizen][WebRTC] Pixmap implementation for video decode accelerator
Fixing build error with Gstreamer1.2 update on 2.4 branch.
Reviewed by: Antonio Gomes, Venugopal S M
Change-Id: Ie1aac7f30dd98366717544afc43acb88b152cbee
Signed-off-by: s.kamath <s.kamath@samsung.com>
Bartlomiej Gajda [Wed, 18 Feb 2015 19:35:16 +0000 (20:35 +0100)]
Fix using HWBackKey on select picker changing page to previous.
[Issue] if there was previous page, and select picker was shown
clicking HW Back changed page to previous one.
[Reason] redundant GoBack()
[Note] top level BackKey to return is handled in ref-browser:
url_bar::__back_cb().
[Fix] remove this redundant call, as it servers no purpose.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11389
JIRA: http://168.219.209.56/jira/browse/TNEF-252
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I1673ab40d83c58bd59c0f2ed0622568582f3b5db
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
sonal.g1@samsung.com [Mon, 19 Jan 2015 14:56:14 +0000 (20:26 +0530)]
[Tizen][WebRTC] Pixmap implementation for video decode accelerator
Implementation of Rendering through pixmap surface.
Together with: I325093df8aac31fc0eab155da08cd87de2ab58f7
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M
Change-Id: I80a06a4fa0fa65106061a32f0a57b4e2b8a3635b
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
sonal.g1@samsung.com [Thu, 22 Jan 2015 13:42:04 +0000 (19:12 +0530)]
[Tizen][WebRTC] Fix delivery of Video Frame from encoder
A queue has been created to maintain the encoded buffers before they are send
to renderer side for further processing. Queue size goes maximum upto 4 in
usual scenario. If queue is not used then frames have to be unnecessarily
dropped when output buffers are not available.
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: I422a783871e61543052f37bf16b6536ac52829f6
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
Bartlomiej Gajda [Wed, 18 Feb 2015 12:41:48 +0000 (13:41 +0100)]
Add title to alert() and confirm() javascript popups.
[Note] There was no title set, UX document tells that there should be one.
This does not affect prompt(), as title is equal to first argument by function.
(so prompt() title won't be translated, only alert() and confirm().)
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I64c0ab61ee2ba402ebca8b0efd9402c06ae9f2b6
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Robert Jadczak [Fri, 13 Feb 2015 15:28:37 +0000 (16:28 +0100)]
Show context menu for email and phone link
Added context menu with proper options for tap event on email or phone link.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11229
Reviewed by: Antonio Gomes, Marcin Kolibabka, Piotr Grad, Piotr Tworek
Change-Id: Ia67069cf6ee76a5f26b21c897b9b4848d6d5b7ef
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
KangYong Park [Fri, 13 Feb 2015 02:32:11 +0000 (11:32 +0900)]
fixup! Fixed WebInspector inability to early report errors
DevToolsHttpHandlerImpl::GetFrontendURLInternal() returns incorrect url link.
To fix this issue, it need to change parameter when calling
content::DevToolsHttpHandler::Start function.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9549
Reviewed by: Antonio Gomes, Janusz Majnert, Kamil Klimek, Piotr Tworek
Change-Id: Id9e07fb130f03501b08de129058a686b23f09001
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Bartlomiej Gajda [Mon, 16 Feb 2015 18:59:54 +0000 (19:59 +0100)]
Fix overlapping of button labels in context menu.
[Note] This removes overridden style of context menu, which was probably
intended for icons-only menus. When it's enabled, it prevents resizing
of text items based on their length, which makes some of menu options
overlaps.
If this style will be corrected by platform owners this can be
turned back, if such need occurs.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11394
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I040c6efd7ccb926b509f9bacba0432ab01eb13ac
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Piotr Tworek [Fri, 13 Feb 2015 17:16:06 +0000 (18:16 +0100)]
Remove RenderWidgetHostViewEfl::set_eweb_view function.
It's no longer necessary since EWebView is provided in the class
constructor. We can initialize ::web_view_ on the constructor
intialization list.
Reviewed by: Antonio Gomes, Kamil Klimek, arno renevier
Change-Id: Ib1a30e78f230148f584f8be068735df588e91227
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Fri, 13 Feb 2015 17:21:40 +0000 (18:21 +0100)]
fixup! WCS Feature: Autofill and Password Manager changes
Make sure the code compiles also with clang.
password_manager_client_efl.cc:23:1: error: cannot define or redeclare
'kLocatorKey' here because namespace 'password_manager' does not enclose
namespace 'WebContentsUserData<password_manager::PasswordManagerClientEfl>
Reviewed by: Kamil Klimek, Piotr Tworek, arno renevier
Change-Id: Ie4bf056185c45bd8ff1a1ccce96cc5f43e9bc5f5
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Fri, 13 Feb 2015 14:56:12 +0000 (15:56 +0100)]
Generalize and improve current suport for l10n
Current version of chromium-efl uses two different localization systems.
First from generic chromium product (pak files), second is based around
libintl. Both systems are pretty generic and serve their purpose well
enough. The problem is our current libintl system works only on tizen,
but not on desktop. This is unfortunate considering the fact libintl is
a generic library available on almsost every unix system, not only linux.
There is no good reason to make the funcionality tizen specific.
This patch tries to fix this problem. To do this it:
1. Adds a proper gyp support for compiling portable object (po) files.
It replaces the previous solution with inline shell code in RPM spec
file. Spec is only responsible for packaging output produced during
build (ninja) step.
2. All the generic code responsible for changing application locale is
moved outside of OS_TIZEN ifdefs. The only Tizen specific part is
usage of vconf to get current system locale. To keep the alternative
simple desktop uses hardcoded english localization. (Can be improved
if necessary)
3. The bindtextdomain calls are moved to
ContentMainDelegate::BasicStartupComplete function implementations
(one for UI another for renderer). Bindtextdomain should be called
only once during application initialization. The filesystem location
of translation files is not supposed to change during app lifetime.
4. Implements necessary PathsEfl support to find necessary translation
files on desktop (out.x64/{Debug|Release}/locale.
With the patch in place all the application menus which use
libintl/gettext for translation work on both desktop and tizen. It
should make it easier to test the functionality.
On a side note I also believe that the translation files should be moved
out of ewk directory into impl. Technically they are used by the code
from impl, not ewk. Still, if we'd like to do this it might be a good
idea for a separate patch.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Tworek, arno renevier
Change-Id: I8e06778c730a7c313a08dc195d7fff513ca7e32f
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
ws29.jung [Tue, 17 Feb 2015 02:08:39 +0000 (11:08 +0900)]
Enable ME for Tizen 3.0
This patch enables media playback feature for Tizen 3.0.
Currently odriod board doesn't support ASM and CAPI.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11405
Change-Id: I4e32077f8000f830f41f93fd942b95f536893ee4
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
SeungSeop Park [Tue, 17 Feb 2015 16:01:18 +0000 (01:01 +0900)]
fixup! Add initial support for Tizen 3.0 TV platform
Fix mobile build break due to missing capi-system-sensor dependency.
Change-Id: I63ece319738badcb4d959e04940241fc5d5a08c9
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Youngsoo Choi [Wed, 28 Jan 2015 04:07:02 +0000 (13:07 +0900)]
Add spec and manifest files for supporting tizen v3.0
Tizen v3.0 has some constraints of package configuration
which are diffrent from Tizen v2.x.
1. xml file should be installed in '/usr/share/packages'.
2. app should be installed in '/usr/apps'.
3. appid should be consist of '.' such as 'org.tizen.chromium-efl'.
4. environment variable 'ELM_ENGINE' has to be set as 'gl'.
bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11063
Change-Id: I106cca288ef15c4618452602bd725960404b9f5e
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Piotr Tworek [Wed, 21 Jan 2015 14:53:46 +0000 (15:53 +0100)]
Add initial support for Tizen 3.0 TV platform
This patch adds initial build system support for Tizen 3.0 for TV profile.
Due to missing, or sometimes broken multimedia support in the current repos
the current build disables support for it.
The code has been run tested on odroid board.
Change-Id: I9de86728cca255565b31972025db585831176487
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
uzair.jaleel [Mon, 16 Feb 2015 17:00:43 +0000 (22:30 +0530)]
Fix for WRT installer error
Native buffer manager should get called in zero copy only.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11451
Reviewed by: Prashant Nevase, venu musham
Change-Id: Ib151bd2a3a721a8a8b5399863aa24d5073bc5f59
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
uzair.jaleel [Fri, 13 Feb 2015 09:42:33 +0000 (15:12 +0530)]
Fix for Bad drawable error in zero copy
Added XSync(..) call which basically flushes the output buffer
and then waits until all requests have been received and
processed by the X server with this bad drawable issue is fixed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Reviewed by: DaeHyun Ko, Prashant Nevase
Change-Id:I20aa39e43c191bf62f2f12e6f2f6bd6b2b8a1cc5
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Antonio Gomes [Thu, 12 Feb 2015 23:35:39 +0000 (15:35 -0800)]
[M40][Tizen3.0]Enabling gold linker for hawk-p TV target
Recently TV builds started suffering from the following
problem:
[ XXs] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between //usr/lib/libc_nonshared.a(atexit.oS) and output
[ XXs] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between /usr/lib/gcc/armv7l-tizen-linux-gnueabi/4.8.3/crtendS.o and output
[ XXs] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between /usr/lib/crtn.o and output
The above problem is explained in details here [1] and fixed in
gold linker itself, released as part of binutils-2.24 [2].
However, our current bundled linker gold binary (in build/prebuild)
built by Viatcheslav Ostapenko was based on binutils-2.23 [3].
Patch fixes the problem by rebuilding linker gold from [1]
and enabling it for TV builds.
[1] https://sourceware.org/ml/binutils/2012-12/msg00202.html
[2] http://ftp.gnu.org/gnu/binutils/binutils-2.24.tar.gz
[3] http://ftp.gnu.org/gnu/binutils/binutils-2.23.2.tar.gz
Patch also work arounds a Tizen 3.0 GBS QEMU problem that was causing
the following issue with linker gold:
[ XXs] eu-strip: while writing '<path>/<package>/<binary>': cannot write data to file
Problem is reported in various places, including [4], [5] and [6].
The solution applied to Tizen public requires to patch QEMU [7].
Until our Tizen 3.x QEMU is fixed, we use a home made x64 bit statically
linked eu-strip, so that we can link with gold.
[4] https://bugzilla.redhat.com/show_bug.cgi?id=
1174267
[5] http://lists.gnu.org/archive/html/qemu-devel/2014-12/msg02702.html
[6] http://bit.ly/1E8W1Uo
[7] https://review.tizen.org/gerrit/#/c/32365/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10967
Reviewed by: Antonio Gomes, KC Park, Piotr Tworek
Change-Id: Ifd5cb31b1fa6d67eac633e371574c8bbd715f492
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Maciej Piotrowski [Tue, 10 Feb 2015 10:53:20 +0000 (11:53 +0100)]
Define for MENU_ITEM_SEARCH_IN_SPOTLIGHT option in context menu
MENU_ITEM_SEARCH_IN_SPOTLIGHT menu option shouldn't be present on Tizen Mobile.
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: Iaf52620470b430deaec1e52ea589ae57eafab4b1
Signed-off-by: Maciej Piotrowski <m.piotrowski@samsung.com>
Youngcheol Kang [Mon, 16 Feb 2015 12:47:57 +0000 (21:47 +0900)]
Changed the API of the capi-appfw-application in Tizen Mobile
According to the change of API in the capi-appfw-application,
Some API were changed in the browser applications.
- Changed the 'app_event_callback_s' to the 'ui_app_lifecycle_callback_s'
Also below structures were removed about this changing.
> low_memory
> low_battery
> device_orientation
> language_changed
> region_format_changed
- Changed the 'app_efl_main(&argc, &argv, NULL, NULL)'
to the 'ui_app_main(argc, argv, NULL, NULL)'
Reviewed by: Antonio Gomes, Tomasz Weglarski, jong chul park, joonhwan kwon
Change-Id: Ib3ff835851965d6787abaf7bf3d45b424e353ff0
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Suchit Agrawal [Wed, 11 Feb 2015 15:16:44 +0000 (15:16 +0000)]
Add multisampling samples count to '4' for canvas.
Default multisampling count set to 4.
We can change it using command line argument :
--canvas-msaa-sample-count=|value|
Reviewed by: Prashant Nevase, venu musham
Change-Id: I3a33cef5542946af99dd038fa1c9b28c96b767b7
Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Venugopal S M [Sat, 14 Feb 2015 16:54:08 +0000 (01:54 +0900)]
Revert "Remove ffmpeg dependency"
FFT is used for Analyzing WebAudio track. It requires FFMPEG.
This reverts commit
f8d73fd6fe9b0a579d668667f3891a3bb6e8c03e.
This also fixes the renderer crash issue in some webaudio site.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11414
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10516
Change-Id: I93c75a7e6ae55761ddd16ca92c32dbce64ea6623
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
SeungSeop Park [Sat, 14 Feb 2015 14:36:42 +0000 (23:36 +0900)]
Revert "Bring up drag option in context menu"
This reverts commit
e421b5aaf5299487e933b131a98373d485807287.
Daniel Waślicki [Mon, 9 Feb 2015 07:39:27 +0000 (08:39 +0100)]
Bring up drag option in context menu
Starting Drag&Drop has to be started from context menu.
This patch brings up this option, by removing EWK_BRINGUP
check.
Together with: I1af148db205ae3bac19eb76c7756a22d0bf685df
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10755
Change-Id: I90e2cb7266a9aab59e393b74d269b0ab8c527585
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Tomasz Czekala [Sat, 14 Feb 2015 12:52:44 +0000 (13:52 +0100)]
temporary fix! - disable drag&drop
Drag&Drop is causing problems when long pressing links, so it has to
be disabled until it is fixed
Change-Id: I3a603790518ef275e7ee387d458177aec53fd168
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
msu.koo [Fri, 13 Feb 2015 15:03:41 +0000 (00:03 +0900)]
fixup! [Tizen][WebRTC][M0] Enable video capture port on M0
This patch fixed
- Remove unrequired format converting before returning the captured buffer
to VideoCaptureController.
- Fix the issue which the device rotation is
not reflecting to captured video frames.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11388
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: Ib9d6eb0f70784777c24b57d2a602b38e165d311c
Signed-off-by: msu.koo <msu.koo@samsung.com>
Venugopal S M [Thu, 12 Feb 2015 06:45:46 +0000 (12:15 +0530)]
[MM]Gstreamer 1.2 Upversion
- Media Element with GST works with AppSink.
- Media Source Extension works with AppSink.
PIXMAP support for video playback is not present
- WebAudio works
- WebRtc needs platform support
Merged commits:
Ib377730584f3f3ffd61776facb63d8d196f64d1f
I0cc3c9c1c43d97c2c3d518655401be40757c47c7
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10745
Reviewed by: SeungSeop Park, Sharath Kamath, Venugopal S M
Change-Id: I36675af2bbfd63d7d8c7fdfb5bf34585ca57ffd1
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
Daniel Waślicki [Thu, 5 Feb 2015 13:03:36 +0000 (14:03 +0100)]
Added implementation of Drag&Drop for EFL port
This patch adds implementation of Drag&Drop for EFL port.
D&D will be enabled after long press and allows to drag
any elements.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10755
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I3fec12f5bcbd3544b08ba4bd24b23419f828d1fe
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
hyungsun.ryu [Fri, 13 Feb 2015 11:58:48 +0000 (20:58 +0900)]
Disable CAPI port for ME and PIXMAP for Multimedia
Recently, MSE and ME is unstable due to platfrom upversion.
Hence, Using capi-player and PXMAP will be diabled until platfom is stable.
- MediaElement will work using Gstreamer
- ME, MSE and WebRTC will work using appsink.
Reviewed by: Antonio Gomes, Hyungsun Ryu, Piotr Tworek, SeungSeop Park
Change-Id: If76a10f50195c3477b759f10eefed4b7ec040f5e
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
KangYong Park [Fri, 13 Feb 2015 01:35:27 +0000 (10:35 +0900)]
fixup! fixup! Add library path to run layout_test
For importing libraries, it need to get host architecture.
And then, bash operator is used, expecially "==".
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11098
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I17ffc71d231aad7eeff00756a53f949caef5543f
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Tomasz Czekala [Fri, 13 Feb 2015 12:48:29 +0000 (13:48 +0100)]
temporary fix - add Ewk_Context to ewk_notification_showed to make WRT compile
Context was not used and we removed it, but WRT assumes that
ewk_notification_showed takes context as one of the parameters
and after our Notification API refactoring it doesn't compile.
WRT will update to the new API, but for now we need this temporary
fix for it to work.
Reviewed by: Piotr Tworek, joonhwan kwon
Change-Id: I6d1fad4c07c4bdfdbef3511864a4b71abb71b429
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Marcin Kędzierski [Thu, 12 Feb 2015 11:14:02 +0000 (12:14 +0100)]
Remove EWK_BRINGUP from ScopedAllowWait
ScopedAllowWait was disabled in impl directory by EWK_BRINGUP define,
because using ScopedAllowWait caused compilation error. The reason is
that ScopedAllowWait is private part of ThreadRestrictions. It can be
used only if it is a member of a friend class. Adding new friend class
to ThreadRestrictinos was used in m34:
http://suprem.sec.samsung.net/gerrit/#/c/1202/ . We don't want to modify
base classes so Kamil Klimek suggests to use solution taken from android
port. To create class which is already friend of ThreadRestrictions.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7271
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I10ccab9ab7b1d14c1d4153c1272daa6295914afd
Signed-off-by: Marcin Kędzierski <m.kedzierski@samsung.com>
Tomasz Czekala [Fri, 13 Feb 2015 09:47:24 +0000 (10:47 +0100)]
fixup! Refactor notification API
Moved members initialization to initialization list in unittests to make
the code compatible with older C++ and compile with our mobile toolchain
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9526
Reviewed by: Filip Piechocki, Piotr Tworek, SeungSeop Park
Change-Id: I9f6955a04e172464d8225c9dbab2da2d92f10861
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Dongjun Kim [Wed, 11 Feb 2015 11:24:30 +0000 (20:24 +0900)]
Change position of TTS engine initialization
TTS is always initialized whenever we are open the webpage.
Even if it does not have contents for WebSpeech, tts engine was
initialized.
So, we need to change position of TTS engine intialization
into the "OnInitializeVoiceList()".
TTS engine will begin when page load with tts contents.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10974
Reviewed by: Jaesik Chang, Piotr Tworek
Change-Id: I48af1aba8745f9abbffcc4f4245b6d0da6e6b295
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Bartlomiej Gajda [Wed, 11 Feb 2015 16:13:36 +0000 (17:13 +0100)]
Enable exporting blink locale pak files, and use them correctly.
[Note] This uses language settings set while browser was run,
to fill locale strings for things like Submit button.
[Requirement] WCS TC 213
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=6508
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: Ia4f21fb0bb18f37457a0c729bf1aa2fb71e9e82e
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Piotr Grad [Thu, 12 Feb 2015 14:00:31 +0000 (15:00 +0100)]
Elm objects were out off screen or not resized upon rotate.
As a workaround of platform issue this patch propagates window size change upon
rotation to all efl popups.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11223
Reviewed by: DONGJUN KiM, Jaesik Chang, Piotr Grad
Change-Id: I5dd559d2c9018819742b6c172376ef40be09d0ae
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Tomasz Czekala [Tue, 3 Feb 2015 07:41:55 +0000 (08:41 +0100)]
Fix user agent setter unittests
Unittests for ewk_view_user_agent_set didn't test it properly. Positive test
case didn't even invoke ewk_view_user_agent_set. This patch adds
meaningful tests and adds tests for empty and NULL string
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10887
Reviewed by: DONGJUN KiM, Piotr Tworek
Change-Id: Ibba46e6579a8542914310c4a3fae6c2dd38a1768
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Lukasz Krok [Mon, 9 Feb 2015 16:39:43 +0000 (17:39 +0100)]
Fix for utc_blink_ewk_view_orientation_send.TEST_0DG test.
If this test is run as first in a test suit,
the orientation will already be 0 degrees (default),
so the orientation change event won't fire
and the test will fail. Setting orientation to other
value before checking ewk_view_orientation_send()
method with 0 as argument resolves the problem.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9541
Reviewed by: DONGJUN KiM, Filip Piechocki, Kamil Klimek
Change-Id: I4e5b96c0b17ec6589aebcd8dca5ea8f3ee9e9477
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Karol Furmaniak [Mon, 9 Feb 2015 12:22:38 +0000 (13:22 +0100)]
Context popup menu is not showing.
Removed creating new efl window for popup.
Added creating context popup menu in webview window,
there is no need to create new one.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9051
Reviewed by: Antonio Gomes, DONGJUN KiM, Piotr Grad
Change-Id: Id4583df4d4c958804baa95ad8c03c5617786d353
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Piotr Tworek [Tue, 10 Feb 2015 11:36:43 +0000 (12:36 +0100)]
Remove dead code and warnings from RenderWidgetHostViewEfl
Chromium removed support for SW rendering around milestone 36.
Chromium-efl port followed upstream and currently needs OpenGL to render
web content. Still there are some code paths left behind frow SW
rendering days. Since nobody seems to be interested in resurrecting
those code paths lets just remove them.
Reviewed by: Antonio Gomes, Daniel Waślicki, SeungSeop Park, arno renevier
Change-Id: Ic3d85229272df9259bde087f95d8f1082fdf27e6
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Robert Jadczak [Tue, 10 Feb 2015 12:54:29 +0000 (13:54 +0100)]
Fix select picker
Removed creating new window for select picker and unnecessary code from radio
icon handler. Added initialization of form navigation flag. Disallowed taking
focus by radio icon.
Reviewed by: DONGJUN KiM, Karol Furmaniak, Piotr Grad
Change-Id: If9f4eba148565c4f10933e690946b63cd6af4a67
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
Robert Jadczak [Mon, 9 Feb 2015 16:53:10 +0000 (17:53 +0100)]
Auto context detection popup does not appear
Added creating popup on existing webview window insted of creating new window.
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I1dc1d4472ae7029e22fe8c5efd6c9bfda69b5d3e
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
vm.arjun [Wed, 11 Feb 2015 12:26:21 +0000 (17:56 +0530)]
[Tizen][WebRTC] Fix audio crash fix by passing ecore Display open
There is some problem with ecore_x_display_get() in chromium-efl.
So replacing the call with XOpenDisplay() as M34 does to fix the
browser crash during webRTC audio enabled.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=9217
Reviewed by: Prashant Nevase, SeungSeop Park
Change-Id: Ia12580fa78299e6dc64da50b89fb9c3d76002f15
Signed-off-by: vm.arjun <vm.arjun@samsung.com>
Bartlomiej Gajda [Tue, 10 Feb 2015 17:47:36 +0000 (18:47 +0100)]
Make buttons in javascript popups locale-aware.
[Issue] WCS TC 214 - popups (alert(), confirm()) do not have translated buttons.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=6508
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: Idd43446b9f0f37103c07ac19315386c0d7bcc245
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Piotr Tworek [Tue, 16 Sep 2014 12:32:53 +0000 (14:32 +0200)]
[M34-Merge] Make sure context cleanup routines are invoked on chromium UI thread
Tha latest version of com.samsung.browser application calls EWK context
cleanup routines from a dedicated thread. Currently chromium-efl port
does not support this. Chromium creates its own threads and has
mechanisms for recognizing on which thread a piece of code is currently
being executed. Functions like MessageLoopProxy::current rely on it.
The implementation uses TLS to store required global data. As one can guess
such TLS data won't be initialized for threads created outside of chromium.
The patch adds extra checks for EWebContext cleanup routines which
com.samsung.browser tries to call from different threads. In case the code
detects it's called from non-UI thread it uses BrowserThread::PostTask to
re-schedule itself on the UI thread. This is mostly a compatibility patch.
In case of chromium implementation of EWK com.samsung.browser does not
actually gain anything by calling cleanup functions from a dedicated thread.
The actual cleanup is asynchronous anyway.
Currently known functions called from non chromium threads:
* ewk_context_cache_clear,
* ewk_context_web_indexed_database_delete_all,
* ewk_context_application_cache_delete_all,
* ewk_context_web_storage_delete_all,
* ewk_context_web_database_delete_all,
* ewk_context_form_candidate_data_delete_all,
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5564
It seems that in M40 ClearFormCandidateDate also needs to be
launched from UI Thread. Added corresponding changes to original patch.
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I8fa5b4e9a142df091fe431378a9fb390e8bdf008
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Karol Furmaniak [Thu, 12 Feb 2015 12:34:21 +0000 (13:34 +0100)]
Do not show sugestions when Remember form data is disabled.
[Problem]: When Remember form data is disabled, popup list with
sugestions appears.
[Solution]: Check if Remember form data is enabled before
showin popup list with sugestions.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11271
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I699766a9601d651013ab7badd73fe12e371cf988
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Karol Furmaniak [Thu, 12 Feb 2015 11:26:06 +0000 (12:26 +0100)]
Do not autofill password when remember password option is off.
[Problem]: When Remeber password option is off password
is still autofilling.
[Solution]: Set PasswordManagerFillingEnabled with
Remember password option value.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11011
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I49cb4e82a31c53223ede8bed62ff61aac19a94c5
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Karol Furmaniak [Thu, 12 Feb 2015 10:01:40 +0000 (11:01 +0100)]
Stored password is not filled.
[Problem] On login page (fb.com for example)
stored password for login is not autofilled
[Solution] Mistake in PasswordFormManager::IgnoreResult.
There should be new_password_element instead of
password_element.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11011
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I8072487fbd7b973d6592cc057a0c8be194837ad0
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Piotr Tworek [Wed, 11 Feb 2015 11:27:54 +0000 (12:27 +0100)]
Revert "Only disable parallel gyp execution in case it doesn't work"
This reverts commit
6a01b928d8c8bbd0aeb0a4501cb23c2647d02d21.
Sometimes when pressing CTRL+C the GBS tries to unmount before all of
the gyp subprocesses terminate. Because python multiprocessing pool uses
/dev/shm the unmount fails. Fro what I can see this is a GBS specific
issue. GYP input.py file does catch keyboard interrupt and tells all
subprocesses to terminate. The script however is called from RPM spec
file which does not allow us to wait for it's children to terminate.
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park, arno renevier
Change-Id: I07c5abf90bb674952cc1caac33d7a5976ebc79a4
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Kamil Klimek [Fri, 2 Jan 2015 13:25:23 +0000 (14:25 +0100)]
Refactor notification API
HTML5 notification handling in chromium has changed and it made
impossible to implement some of existing EWK notification APIS. This
required us to refactor notification API. Notifications are now not
related with webview.
Deprecated:
* notification,show smart callback
- smart callbacks require webview Evas_Object
* notification,cancel smart callback
- smart callbacks require webview Evas_Object
* ewk_notification_icon_url_get
- icon is now stored internaly as SkBitmap
* ewk_view_notification_closed
- notifications are not related to webview
Introduced:
* ewk_notification_callbacks_set
- api to set callbacks for notification show/cancel
* ewk_notification_callbacks_reset
- resets notification callbacks to NULL
* ewk_notification_icon_get
- creates Evas_Object with notification icon
* ewk_notification_closed
- notify engine that notification was closed
Modified:
* ewk_notification_clicked
- return Eina_Bool to indicate if event was dispatched
- removed Ewk_Context parameter as it is not required anymore
* ewk_notification_showed
- return Eina_Bool to indicate if event was dispatched
- removed Ewk_Context parameter as it is not required anymore
* ewk_notification_cached_permissions_set
- return Eina_Bool to indicate if permissions were set
- removed Ewk_Context parameter as it is not required anymore
* ewk_notification_permission_reply
- return Eina_Bool to indicate if operation was successful
* ewk_notification_permission_request_set
- return Eina_Bool to indicate if operation was successful
* ewk_notification_permission_request_suspend
- return Eina_Bool to indicate if operation was successful
* ewk_notification_policies_removed
- return Eina_Bool to indicate if operation was successful
- removed Ewk_Context parameter as it is not required anymore
Additionaly all notification related unit tests were refactored to share
common base setup. Some unit tests were also improved to test not only
API calls but check also expected results like checking if proper JS
engine events were produced.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9540
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9526
Reviewed by: Antonio Gomes, Jaesik Chang, Janusz Majnert, Piotr Tworek
Change-Id: I0d5788b2a4e00a1af2d5dc6479244cc6150627df
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Dongjun Kim [Thu, 12 Feb 2015 08:42:42 +0000 (17:42 +0900)]
Revert "Set RenderWidgetHostImpl visibility depending on presence application on screen"
After this patch, elm_win_alpha_set() does not work on selectpicker and js popup
This reverts commit
e67c2af21f5598235bd78e4e274d738873cb8078.
Reviewed by: Jaesik Chang, Piotr Grad, Piotr Tworek
Change-Id: Iafc60a3409729cd8ba9afb06ba7b51df4fc39a6a
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Antonio Gomes [Wed, 11 Feb 2015 13:16:31 +0000 (05:16 -0800)]
[HOTFIX][GCC 4.9] build/prebuild/ld: -plugin: unknown option
In GCC 4.9, the linker (either bfd or gold) is called with the -plugin argument
which our current bundled gold linker (in build/prebuild) does not accept.
[ XXs] /(..)/chromium-efl-40.2214.38.06/build/prebuild/ld: -plugin: unknown option
Since our gold a x64 64bit statically linked binary, even if we rebuild it
with plugin support enabled, the plugin being loaded would be a 32bit ARM binary.
and load would fail.
[ XXs] (..)/build/prebuild/ld: error: /usr/lib/gcc/armv7l-tizen-linux-gnueabi/<gcc version>/liblto_plugin.so:
could not load plugin library: /usr/lib/gcc/armv7l-tizen-linux-gnueabi/<gcc version>/liblto_plugin.so:
wrong ELF class: ELFCLASS32
So, as a work around to the problem, patch disables the linker's plugins
with '-fno-use-linker-plugin', as per https://gcc.gnu.org/wiki/LinkTimeOptimizationFAQ .
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11089#c5
Reviewed by: Piotr Tworek, joonhwan kwon
Change-Id: Ibf408bdc0fb7cd464b59eef53a26215b67fc3c34
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Youngsoo Choi [Wed, 11 Feb 2015 08:46:37 +0000 (17:46 +0900)]
[TV] Disabling unsupported sensor feature on TV target
The TV target does not support sensor feature
such as orientation, accelerometer, gyroscope, and etc.
Thus, it needs to be disabled.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11280
Reviewed by: Antonio Gomes, KC Park
Change-Id: I92a96438a25bedaf6657c9881e8c90b2d56afe8f
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Michał Obrembski [Wed, 11 Feb 2015 12:36:54 +0000 (13:36 +0100)]
Fixed autofill enabled option
Autofill popup was shown even if Autofill was turned off
in browser settings. This fixes that behavior.
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I6c0763005be3a349c1be31b6709228bdb2c0a2e0
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Tomasz Czekala [Wed, 11 Feb 2015 09:31:18 +0000 (10:31 +0100)]
fixup! Implement support for autofill feature.
Fixes for the patch http://165.213.202.130:8080/#/c/73496/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9520
Reviewed by: Jaesik Chang, Kamil Klimek
Change-Id: Ia87fe79fe159b6e7b023db39fd39999aaed743fd
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Maciej Piotrowski [Tue, 10 Feb 2015 07:55:11 +0000 (08:55 +0100)]
Fix missing translation for menu option
There was missing title for Search in web option
in context menu of selected text.
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: Ib49b6420c03dfba38ae9d511799f5a3ecdb11eea
Signed-off-by: Maciej Piotrowski <m.piotrowski@samsung.com>
Lukasz Krok [Tue, 10 Feb 2015 11:59:41 +0000 (12:59 +0100)]
ewk_error_cancellation_get API added
The API job is to check if an error was caused by a cancellation.
In current chromium implementation such situtation is not possible,
after I8f4e828bfcc63377678e475f44131dbc749b9c7f change.
Thus, the API will always return EINA_FALSE.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11077
Reviewed by: Jaesik Chang, Piotr Tworek
Change-Id: Iedcf80af17747ac3330be5ea3f6f4c1e457afeca
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Kamil Nowac [Mon, 2 Feb 2015 16:59:39 +0000 (17:59 +0100)]
Enable chromedriver build for selenium testing.
To get chromedriver build add --define "build_chromedriver 1" to
build_mobile.sh command line. There will be chromedriver rpm file in GBS root
folder.
Install on the device.
run chrome driver with script: start-chrome-driver.sh
Reviewed by: Antonio Gomes, Janusz Majnert, Kamil Klimek
Change-Id: I5c00bf71813f91f5b3a5f18c389d2bdeb8f916d3
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Wojciech Wiśniewski [Tue, 20 Jan 2015 17:29:10 +0000 (18:29 +0100)]
Break pointer cycle between CookieManager and content::URLRequestContextGetterEfl.
These classes hold reference-counted pointers to each other. This was causing memory
leak.
Reviewed by: Daniel Waślicki, Janusz Majnert, Piotr Tworek, arno renevier
Change-Id: I2ea821715aac813c9e6e5f9d8c3122cf46d8ac75
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
Tomasz Czekala [Wed, 11 Feb 2015 11:00:02 +0000 (12:00 +0100)]
Fix crash when navigating with JavaScriptDialogManager
When JavaScriptDialog was present, going back to a previous page caused
crash, because in ~WebContentsImpl we check if dialog_manager_ is not NULL,
then we invoke WebContentsDestroyed on it. But dialog_manager_ is
not set to NULL when we release the manager in ~WebContentsDelegateEfl,
so web contents must be released before web contents delegate
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11031
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: I6a6f8f9d92c99e92e4c2fab2711083cf15dc3b3d
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 14:34:16 +0000 (15:34 +0100)]
fixup! Set RenderWidgetHostImpl visibility depending on presence application on screen
The code makes sense on Mobile/TV where the application always occupies
the whole screen. In case of desktop where mutiple windows can be seen
at the same time, not so much. After the patch whenever the window is
unfocused its content disappears.
Reviewed by: Antonio Gomes, Kamil Klimek, SeungSeop Park, arno renevier
Change-Id: I021b09543d5143e8ed91c9a362d7ce4e16727a61
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
KangYong Park [Tue, 10 Feb 2015 08:17:22 +0000 (17:17 +0900)]
Update TestExpectations for layout_test in desktop (chromium-efl)
When running layout tests, a number of 4000 errors occur.
Those failures slow down a full layout test run.
Skip them temporarily, so we can manage new failures.
It is related to below patch.
- http://165.213.202.130:8080/#/c/74587/
Reviewed by: Antonio Gomes, Gyuyoung Kim, SeungSeop Park
Change-Id: I156155e0568dda12ef87333457b54fab727d2851
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 13:55:56 +0000 (14:55 +0100)]
fixup! Add support for focus UI in InputPicker
Don't use internal _Eo_Opaque type. When Evas.h is included Evas_Object
typedef should take care of that. Code using evas should use always use
Evas_Object directly.
Reviewed by: Kamil Klimek, Piotr Grad, SeungSeop Park
Change-Id: Iad2ed39f9280dc50719a15be298142bb990167f0
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Robert Jadczak [Mon, 9 Feb 2015 16:40:22 +0000 (17:40 +0100)]
Return focus to ewk_view after closing input picker
Focus was not returned to ewk_view until user touched the screen.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8105
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: If1326a6adf61f583b95e48cfd8e4ea15572ae4e6
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 13:45:05 +0000 (14:45 +0100)]
Only disable parallel gyp execution in case it doesn't work
Currently we always disable parallel gyp execution when running gyp
inside of GBS. This done because on some targets (TV 2.2.1) parallel
excution does not work due to broken python multiprocessing support.
The problem is, parallel execution works fine on Mobile or TV 3.0 and
disabling it meks gyp runs longer than necessary.
This patch uses an alternative solution. Only disable parallel gyp mode
in case gyp run in parallel such mode. I've tested it on both Mobile 2.4
and TV 2.2.1 targets and both work fine with such solution. The
difference is, Mobile 2.4 gyp run is now faster than previously.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Grad, SeungSeop Park
Change-Id: Iff360c20b30435dd96255b393057ea3acfa9fa95
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Dongjun Kim [Wed, 11 Feb 2015 04:22:01 +0000 (13:22 +0900)]
Autoscroll issue after showing IME
Page is not resized if select picker menu hides item on page.
So we need to add function for auto-scroll after
"OnInputPanelStateChanged" and "HandleResize".
BUG: http://107.108.218.239/bugzilla/show_bug.cgi?id=10843
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: I2ad0a1e4830c8ead519feac10213baf9aa3a7d81
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 15:07:36 +0000 (16:07 +0100)]
uBrowser: Fix support for enabling/disbling back and forward buttons.
The idea is simple back and forward buttons should only be active when
there is actual history entry to navigate to. The feature is there, but
broken due two small bugs, fix them.
Reviewed by: Antonio Gomes, Kamil Klimek, arno renevier
Change-Id: I9f1529e23932e53af254d1b3181bc6bb2e2fb096
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Bartlomiej Gajda [Tue, 10 Feb 2015 11:47:27 +0000 (12:47 +0100)]
Add beta version of locale files for PL, and ko_KR.
[Note] Those are only for testing. Accuracy of translation
can not be guaranteed.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10689
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I2f51109e8a5a4f199d9a4b8f66e6f0a4c48dadaf
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Jongsoo Yoon [Tue, 10 Feb 2015 06:14:14 +0000 (15:14 +0900)]
Added Tizen Trace package for debugging
SQE usually use Tizen Trace for debugging.
So, it is needed to add "ttrace" package into chromium-efl
Bug : http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11213
Reviewed by: Piotr Tworek, joonhwan kwon
Change-Id: I1691caa149527b9b3e167d8e5cdd78a5514ada7e
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Anthony Liot [Sat, 7 Feb 2015 01:02:28 +0000 (17:02 -0800)]
Tizen 2.4 support the aliasing/msaa on Mali-400
The driver bug on Mali-400 was solved with the last driver
OpenGLES for Tizen 2.4
M0 device support both flags :
--gpu-rasterization-msaa-sample-count=4
--canvas-msaa-sample-count=4
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11081
Reviewed by: Antonio Gomes, Prashant Nevase, venu musham
Change-Id: I94cd50d05456bc345b56530f2187bf598c269f76
Signed-off-by: Anthony Liot <anthony.liot@samsung.com>
Tomasz Weglarski [Tue, 10 Feb 2015 09:23:43 +0000 (10:23 +0100)]
fixup! Fix SkBitmap::config() removal in chrome.
[Requirement] WCS-TC-130
This patch fixes Command::deserialize method.
Reviewed by: Hyunhak Kim, Kamil Klimek, Marcin Kolibabka, Piotr Grad, Piotr Tworek
Change-Id: I3410c70da4942f1f5513959ad0f42ef617cb80f9
Signed-off-by: Tomasz Weglarski <t.weglarski@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 15:10:32 +0000 (16:10 +0100)]
uBrowser: Use touch events by default when running in mobile mode.
The --mobile command line flag is useful to quickly test desktop build
of ubrowser in mobile-like configuration. Since tizen mobile uses touch
events by default also use them when ubrowser is started on desktop with
--mobile flag.
Reviewed by: Antonio Gomes, Kamil Klimek, arno renevier
Change-Id: I70ba80b76ba2f800cbcdd7cdd1cdc4f0aa6b7276
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Robert Jadczak [Mon, 9 Feb 2015 13:26:18 +0000 (14:26 +0100)]
Set initial value for auto contents detection flag
m_detectContentsAutomatically member of Ewk_Settings was not initialized.
Reviewed by: Antonio Gomes, Cho Andy, Piotr Grad
Change-Id: Ie6e97dea411ab927a40944a75377603061617ec5
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 14:08:20 +0000 (15:08 +0100)]
Remove dead comments and unnecesary warnings from command_line_efl
The code was commented out during M37 migration attempt. The warnings
were added to keep in mind the removed switches need to be investigated.
It's been good couple of months since that time and there is no
indication the swtiches are needed for M40. Remove the code and the
warnings as there is no good reason to keep them around any longer.
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I1162bd5a3fe379a9a2ba125c39ff1694d635ac2c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Grad [Mon, 9 Feb 2015 11:01:16 +0000 (12:01 +0100)]
Implementation for date/time picker
[Requirement] WCS-TC-164
Current implementation was showing only date picker when date/time picker was
requested. Also proper translation for headers were added.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8765
Reviewed by: Hyunhak Kim, Karol Furmaniak, Piotr Grad
Change-Id: Ibf5ff2e1a3053e45daab92fd5f69f3d805902c59
Signed-off-by: Piotr Grad <p.grad@samsung.com>
KangYong Park [Mon, 9 Feb 2015 06:47:58 +0000 (15:47 +0900)]
Allow layout_test to run on desktop with mesa software backends
Some people like to test content_shell and layout_test over ssh.
Unfortunately hardware accelerated OpenGL does not work over ssh.
The only working backend for such configuration is mesa llfmpipe/softpipe.
Those backends however are considered as unsupported and are blacklisted
by EFL. Fortunately EFL allows us to ignore it's blacklist through
EVAS_GL_NO_BLACKLIST environment variable.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Tworek
Change-Id: Ie35a5c3ece69780e52ac07e5e5617b7e3cf09435
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Michał Obrembski [Mon, 9 Feb 2015 10:56:16 +0000 (11:56 +0100)]
Added translation of Javascript BeforeUnload Dialog.
[Requirement] WCS-TC-161
JavaScriptDialogManagerEfl has hardcoded message string,
which was used in Javascript BeforeUnloadDialog.
This hardcoded string was replaced with dgettext and
corresponding translations.
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: If1a2e6d81c8780352d8454898107d23c3e5154e8
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Grzegorz Spryszynski [Mon, 9 Feb 2015 12:25:56 +0000 (13:25 +0100)]
[M34-Merge] Not showing IME in URL Box when second tap to url box
[Problem] IME is not shown after changing focus from
edit field on page to browser url bar. After that tapping
on any edit field cause no IME displaying.
[Solution] Removing internal flag (holding information whether
keyboard is visible or not) from im_context_efl and replace it
with ecore_imf_context_input_panel_state_get call.
Original commit: 165.213.202.130:8080/#/c/71929
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11168
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: Ia19b84824cd7d509dd0056b9166b8058462e3d66
Signed-off-by: Grzegorz Spryszynski <g.spryszynsk@samsung.com>