Jan Vorlicek [Thu, 8 Mar 2018 11:44:33 +0000 (12:44 +0100)]
Fix ensuring primary stack size (#16698)
1. Make it happen for Alpine only (it was incorrectly being done for
OSX too.
2. Do it only when the Initialize is called for CLR initialization
Jan Kotas [Wed, 7 Mar 2018 23:27:00 +0000 (15:27 -0800)]
Add back method needed by CoreRT
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot [Thu, 8 Mar 2018 04:32:11 +0000 (22:32 -0600)]
Update BuildTools, CoreFx to preview2-02607-03, preview2-26308-02, respectively (#16821)
Matt Mitchell [Thu, 8 Mar 2018 02:22:20 +0000 (18:22 -0800)]
Workaround coreclr issue (#16828)
VSTS does not seem to be correctly honoring the working directory for batch script steps. Explicitly qualify the setup_vs_env.cmd path
Sergey Andreenko [Thu, 8 Mar 2018 01:26:27 +0000 (17:26 -0800)]
[RyuJIt] Clean and fix gen return (#16725)
* create genSimpleReturn for arm64
* create genFloatReturn for x86
* create genLongReturn for x86 and arm
* merge genReturn
Luqun Lou [Thu, 8 Mar 2018 01:19:46 +0000 (17:19 -0800)]
Fix for issue 14144 (#16674)
Sergey Andreenko [Thu, 8 Mar 2018 00:51:56 +0000 (16:51 -0800)]
an additional assert for fgValueNumberHelperCallFunc (#16789)
Jan Kotas [Wed, 7 Mar 2018 22:47:49 +0000 (14:47 -0800)]
Delete AsReadOnly* APIs that are no longer part of the public surface (#16799)
Hugh Zabriskie [Wed, 7 Mar 2018 22:39:22 +0000 (14:39 -0800)]
Perf fix for month-day parsing ambiguity (#16782)
* Perf fix for month-day parsing ambiguity
* Use DateTime.TryCreate
Eugene Rozenfeld [Wed, 7 Mar 2018 22:16:49 +0000 (14:16 -0800)]
Remove dead code found by ILLink. (#16759)
I'm preparing changes to enable running ILLink on SPC
(similarly to what we do on corefx assemblies).
There will be a separate PR for those changes.
This PR just removes the dead code flagged by ILLink from the sources.
Jarret Shook [Wed, 7 Mar 2018 21:37:02 +0000 (13:37 -0800)]
Address issue 16800 (#16810)
kasper3 [Wed, 7 Mar 2018 21:03:35 +0000 (23:03 +0200)]
Remove libuuid from scripts and docs (#16805)
dotnet-maestro-bot [Wed, 7 Mar 2018 19:56:51 +0000 (13:56 -0600)]
Update CoreFx to preview2-26307-06 (#16798)
Fei Peng [Wed, 7 Mar 2018 14:40:45 +0000 (06:40 -0800)]
fix inconsistent AVX/AVX2 intrinsic names (#16772)
dotnet-maestro-bot [Wed, 7 Mar 2018 06:33:16 +0000 (00:33 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02606-05, preview2-26307-01, preview2-26307-03, respectively (#16791)
Jarret Shook [Wed, 7 Mar 2018 03:03:36 +0000 (19:03 -0800)]
Merge pull request #16662 from jashook/remove_vs2015_dependencies
Remove vs2015 build dependencies
Noah Falk [Wed, 7 Mar 2018 03:02:44 +0000 (19:02 -0800)]
Add debugger usage note (#16788)
Tanner Gooding [Tue, 6 Mar 2018 16:49:24 +0000 (08:49 -0800)]
Updating the x86 hardware-intrin test templates to use named format arguments
Mandar Sahasrabuddhe [Wed, 7 Mar 2018 00:42:46 +0000 (06:12 +0530)]
CoreFX #24343 Vector Ctor using Span (#16733)
* CoreFX #24343 Vector using Span
dotnet/corefx#24343
* CoreFX #24343 Vector using Span
dotnet/corefx#24343
* CoreFX #24343 Vector using Span
dotnet/corefx#24343
Jan Kotas [Wed, 7 Mar 2018 00:37:51 +0000 (16:37 -0800)]
Revert "Fix handling of incorrect assemblies on Unix (#16747)" (#16790)
This reverts commit
383736b96b643ba46ad290fc86601fc2d62a9436.
jashook [Mon, 5 Mar 2018 21:35:19 +0000 (13:35 -0800)]
Remove vs2015 build dependencies
Davis Goodin [Tue, 6 Mar 2018 23:33:27 +0000 (17:33 -0600)]
Merge pull request #16785 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx to preview2-02606-04, preview2-26306-01, preview2-26306-04, respectively (master)
dotnet-maestro-bot [Tue, 6 Mar 2018 21:27:48 +0000 (13:27 -0800)]
Update BuildTools, CoreClr, CoreFx to preview2-02606-04, preview2-26306-01, preview2-26306-04, respectively
Michelle McDaniel [Tue, 6 Mar 2018 20:37:23 +0000 (12:37 -0800)]
Disable Perf Runs on Commit (#16781)
We need to disable these jobs on commit until dotnet/core-eng#2808 is fixed.
Koundinya Veluri [Tue, 6 Mar 2018 19:42:13 +0000 (11:42 -0800)]
Fix hang on Ctrl+C when tiering is enabled (#16719)
Fix hang on Ctrl+C when tiering is enabled
- When the work thread count is nonzero at the time of Ctrl+C, by the time `TieredCompilationManager::Shutdown(BOOL)` runs (during `DllMain` for process detach), the background worker thread has already been torn down abruptly and it does not get a chance to exit gracefully and set the event, and Shutdown() hangs the process waiting for the event forever.
- It looks like there is no benefit to waiting for the work to complete, fixed by removing the wait and the event
- In the MusicStore benchmark it looks like the arch folder was missing in the 'publish' folder path. In case there is a difference in bin directory layout between the CI dotnet and current dotnet, changed to check for both paths.
Brian Robbins [Tue, 6 Mar 2018 19:31:40 +0000 (11:31 -0800)]
Convert Byte Arrays to Hexidecimal Strings When Writing to LTTng via EventSource (#16762)
Levi Broderick [Tue, 6 Mar 2018 17:11:52 +0000 (09:11 -0800)]
Fix potential buffer overrun in ClearWithReferences
Brian Sullivan [Tue, 6 Mar 2018 18:29:37 +0000 (10:29 -0800)]
Merge pull request #16700 from briansull/fix_dyn_blk
Fix morph issue with a fixed size block copy
Brian Robbins [Tue, 6 Mar 2018 10:51:22 +0000 (02:51 -0800)]
Add tracepointprovider.cpp directly to PAL instead of to a separate tracepointprovider library. (#16771)
Levi Broderick [Tue, 6 Mar 2018 02:18:23 +0000 (18:18 -0800)]
Fix whitespace
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Levi Broderick [Tue, 6 Mar 2018 02:00:07 +0000 (18:00 -0800)]
Fix whitespace
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Levi Broderick [Tue, 6 Mar 2018 01:26:38 +0000 (17:26 -0800)]
Improve performance of Span.Clear for referential T
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Ruben Ayrapetyan [Tue, 6 Mar 2018 06:37:43 +0000 (06:37 +0000)]
Fix handling of incorrect assemblies on Unix (#16747)
* Return DPTR from PEDecoder::FindFirstSection()
Change type of the function's return value
to PTR_IMAGE_SECTION_HEADER instead of (IMAGE_SECTION_HEADER *)
* Fix handling of incorrect assemblies on Unix
This fixes the regression that was introduced by #10772 and is
caused by a missing check for validity of loaded assembly file.
Related issue: #15544
Marco Rossignoli [Tue, 6 Mar 2018 03:31:06 +0000 (04:31 +0100)]
address PR feedback (#16761)
Jacek Blaszczynski [Thu, 1 Mar 2018 18:27:49 +0000 (19:27 +0100)]
Add LoadHigh, LoadLow, and SetScalarVector128 SSE2 HW intrinsics tests
Jacek Blaszczynski [Thu, 1 Mar 2018 18:26:29 +0000 (19:26 +0100)]
Implement LoadHigh, LoadLow, and SetScalarVector128 SSE2 HW intrinsics
Fei Peng [Mon, 5 Mar 2018 21:23:15 +0000 (13:23 -0800)]
Simplify SSE/SSE4.1 intrinsics
dotnet-maestro-bot [Tue, 6 Mar 2018 01:58:43 +0000 (19:58 -0600)]
Update BuildTools, CoreClr to preview2-02606-01, preview2-26305-12, respectively (#16760)
Jan Vorlicek [Tue, 6 Mar 2018 01:21:09 +0000 (02:21 +0100)]
Remove libuuid usage (#16643)
* Remove libuuid usage
This change removes dependency on the libuuid library that is used for GUID creation only.
It implements it using a random generator instead.
It also modifies return type of PAL_Random to VOID since it was always
returning TRUE and none of the existing callers were checking it.
1. Port the GUID creation to managed code.
2. Modify the PAL_Random to have 6 times better perf so that the perf of the
CoCreateGuid that is used in the native runtime doesn't degrade that much
w.r.t the previous state when the libuuid was used.
3. Use Interop.GetRandomBytes on Unix and fix Windows
JC Aguilera [Tue, 6 Mar 2018 00:35:20 +0000 (16:35 -0800)]
SCEP package version update
Carol Eidt [Mon, 5 Mar 2018 21:41:07 +0000 (22:41 +0100)]
Merge pull request #16727 from CarolEidt/NoIndirByte
Don't force byte regs for indir address
Sergey Andreenko [Mon, 5 Mar 2018 21:38:31 +0000 (13:38 -0800)]
[ARM32] RyuJIT support for profiler ELT callbacks (#16728)
* add assert that argReg was PreSpilled
* genProfilingEnterCallback for RyuJit arm
* fix genProfilingLeaveCallback for RyuJit arm
* call genProfilingLeaveCallback for arm from genJmpMethod
JC Aguilera [Mon, 5 Mar 2018 20:43:48 +0000 (12:43 -0800)]
Update SCEP package version
Tanner Gooding [Wed, 28 Feb 2018 04:53:11 +0000 (20:53 -0800)]
Updating the CompareEqual{Ordered|Unordered}Scalar intrinsics to have slightly better codegen
dotnet-maestro-bot [Mon, 5 Mar 2018 19:13:14 +0000 (13:13 -0600)]
Update CoreClr, CoreFx to preview2-26305-04, preview2-26305-02, respectively (#16755)
Marco Rossignoli [Mon, 5 Mar 2018 18:09:24 +0000 (19:09 +0100)]
Scrub error messages for missing arguments(throw new) (#16753)
Vance Morrison [Mon, 5 Mar 2018 18:08:35 +0000 (10:08 -0800)]
Change COMPLus -> COMPlus
JC Aguilera [Mon, 5 Mar 2018 17:34:47 +0000 (09:34 -0800)]
Remove ConfigFile parameter which is not set on previous tasks
Carol Eidt [Mon, 5 Mar 2018 17:33:47 +0000 (18:33 +0100)]
Merge pull request #16731 from tannergooding/hwintrin-avx
Implementing the ConvertToVector AVX hardware intrinsics
Jan Kotas [Mon, 5 Mar 2018 16:36:39 +0000 (08:36 -0800)]
Delete dead code in PAL related to file locks (#16754)
Jan Vorlicek [Mon, 5 Mar 2018 15:15:24 +0000 (16:15 +0100)]
Remove flock usage from InternalCreateFile in PAL (#16752)
This flock is causing issues on filesystems that don't support locking.
An issue with loading managed assemblies from such a filesystem due to
this issue was recently hit by someone.
Since the locking in the PAL is not really needed and due to the
advisory nature of the flock doesn't guarantee anything, this change is
removing the flock from that function.
dotnet-maestro-bot [Mon, 5 Mar 2018 04:36:47 +0000 (22:36 -0600)]
Update CoreClr, CoreFx to preview2-26305-01, preview2-26305-01, respectively (#16740)
Jan Kotas [Mon, 5 Mar 2018 04:05:50 +0000 (20:05 -0800)]
Fix encoding methods for Span.Empty (#16748)
* Fix encoding methods for Span.Empty
Encoding had a historic confusion about handling null pointers. Make sure that this confusion is not leaking into the new Span methods.
* Use GetNonNullPinnableReference helper method
Stephen Toub [Sun, 4 Mar 2018 20:55:34 +0000 (15:55 -0500)]
Delete stale TryFormat and {Try}Parse overloads (#16746)
dotnet bot [Sun, 4 Mar 2018 17:10:39 +0000 (09:10 -0800)]
Clear executable bit on several .cs files (#16743)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Sergey Andreenko [Sun, 4 Mar 2018 09:10:12 +0000 (01:10 -0800)]
fix legacy backend (#16741)
Jan Kotas [Sun, 4 Mar 2018 07:13:55 +0000 (23:13 -0800)]
Clear executable bit on several .cs files
Brian Robbins [Sun, 4 Mar 2018 05:00:42 +0000 (21:00 -0800)]
Update TraceLogging to use NULL-terminated strings instead of counted strings (#16672)
Brian Robbins [Sun, 4 Mar 2018 04:56:43 +0000 (20:56 -0800)]
Fix use of EventPipeConfiguration after it has been freed on shutdown. (#16704)
dotnet-maestro-bot [Sun, 4 Mar 2018 03:32:42 +0000 (21:32 -0600)]
Update CoreClr to preview2-26304-01 (#16739)
Ahson Khan [Sun, 4 Mar 2018 01:55:31 +0000 (17:55 -0800)]
Fix MemoryDebugView and override Memory.ToString similar to Span (#16732)
* Fix MemoryDebugView and add Memory.ToString similar to Span
* Simplify implementation of ToString
Ahson Khan [Sun, 4 Mar 2018 01:48:07 +0000 (17:48 -0800)]
Remove StringSpanHelpers and start using MemoryExtensions (#16718)
* Remove StringSpanHelpers and start using MemoryExtensions
* Address PR feedback.
dotnet-maestro-bot [Sat, 3 Mar 2018 20:56:01 +0000 (14:56 -0600)]
Update CoreClr, CoreFx to preview2-26303-09, preview2-26303-04, respectively (master) (#16730)
* Update CoreClr, CoreFx to preview2-26303-09, preview2-26303-04, respectively
* Add System.Runtime.Intrinsics.Experimental to test dependencies
Tanner Gooding [Sat, 3 Mar 2018 06:03:09 +0000 (22:03 -0800)]
Implementing tests for more of the AVX hardware intrinsics
Tanner Gooding [Fri, 2 Mar 2018 16:07:15 +0000 (08:07 -0800)]
Implementing some more of the AVX intrinsics
Fei Peng [Sat, 3 Mar 2018 00:34:03 +0000 (16:34 -0800)]
Implement AVX/AVX BroadcastScalarToVector*
Carol Eidt [Sat, 3 Mar 2018 03:15:21 +0000 (04:15 +0100)]
Merge pull request #15777 from dotnetrt/sse2part2
Implement Shuffle* Sse2 Intel hardware intrinsics
Egor Chesakov [Sat, 3 Mar 2018 00:39:36 +0000 (16:39 -0800)]
Use TARGET_POINTER_SIZE macro (#16640)
* Replace sizeof(void*) with TARGET_POINTER_SIZE in TYPEINFO in src/inc/cortypeinfo.h
* Replace sizeof(LPVOID) with TARGET_POINTER_SIZE in DEFINEELEMENTTYPEINFO in src/vm/siginfo.cpp
* Define TARGET_POINTER_SIZE as POINTERSIZE_BYTES in src/ToolBox/SOS/Strike/util.h
Carol Eidt [Fri, 2 Mar 2018 19:08:42 +0000 (11:08 -0800)]
Don't force byte regs for indir address
JC Aguilera [Fri, 2 Mar 2018 23:40:31 +0000 (15:40 -0800)]
Merge pull request #16638 from jcagme/master
Install and uninstall SCEP
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 23:33:13 +0000 (15:33 -0800)]
final set of comments been addressed
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 23:20:19 +0000 (15:20 -0800)]
Remove variable
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 23:13:55 +0000 (15:13 -0800)]
Remove creation of Auth'd nuget.config
Stephen Toub [Fri, 2 Mar 2018 19:41:23 +0000 (14:41 -0500)]
Fix netstandard build references to UnsafeTask
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Jacek Blaszczynski [Wed, 28 Feb 2018 05:11:12 +0000 (06:11 +0100)]
Add Shuffle* Sse2 hardware intrinsics tests
Jacek Blaszczynski [Wed, 28 Feb 2018 05:08:55 +0000 (06:08 +0100)]
Implement Shuffle* SSE2 hardware intrinsics
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:21:46 +0000 (14:21 -0800)]
Yet one more reverted change in PR
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:20:43 +0000 (14:20 -0800)]
One more reverted change in PR
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:19:44 +0000 (14:19 -0800)]
Merge branch 'master' of https://github.com/jcagme/coreclr
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:19:06 +0000 (14:19 -0800)]
Addressing reverted change in PR
JC Aguilera [Fri, 2 Mar 2018 22:11:51 +0000 (14:11 -0800)]
Delete scep-ops.cmd
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:08:21 +0000 (14:08 -0800)]
Changes with NuGet package approach
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 21:58:23 +0000 (13:58 -0800)]
Merge branch 'master' of https://github.com/dotnet/coreclr
Carol Eidt [Fri, 2 Mar 2018 21:04:33 +0000 (22:04 +0100)]
Merge pull request #16715 from fiigii/fixmovemask
Fix a bad marge
Sergey Andreenko [Fri, 2 Mar 2018 20:41:13 +0000 (12:41 -0800)]
[RyuJit] fix clang switch warning (#16693)
* fix clang switch warning
* Try to set throw blocks only for nodes that generates exceptions themselves.
Update comments.
Fei Peng [Fri, 2 Mar 2018 19:52:14 +0000 (11:52 -0800)]
fix a bad marge
Bruce Forstall [Fri, 2 Mar 2018 18:25:18 +0000 (10:25 -0800)]
Delete SingleGetHashCode and DoubleGetHashCode tests for arm/arm64 (#16688)
* Delete SingleGetHashCode and DoubleGetHashCode tests for arm/arm64
The tests themselves were deleted with #16567.
* Delete arm/arm64 tests deleted in #16571
StringCompare1, StringCompare2, StringCompare15
* Delete more references to these tests
Bruce Forstall [Fri, 2 Mar 2018 18:24:10 +0000 (10:24 -0800)]
Merge pull request #16703 from BruceForstall/GeneralizeRuntestExclusionFiles
Generalize runtest.sh test exclusion files
Mike McLaughlin [Fri, 2 Mar 2018 17:54:31 +0000 (09:54 -0800)]
Fix !threads -special spurious error message (#16701)
Fix !threads -special spurious error message
Generate portable PDB for SOS.NETCore.
Fix issue #16665. Incorrect command names in messages on Linux.
dotnet-maestro-bot [Fri, 2 Mar 2018 16:40:09 +0000 (10:40 -0600)]
Update CoreClr to preview2-26302-06 (#16706)
Carol Eidt [Fri, 2 Mar 2018 14:41:05 +0000 (15:41 +0100)]
Merge pull request #16646 from fiigii/insertextract
Implement SSE4.1 Insert/Extract and simplify SSE/SSE2 intrinsic
Michal Strehovský [Fri, 2 Mar 2018 09:28:43 +0000 (10:28 +0100)]
Work around MCG bug around `ref char` marshalling (dotnet/corert#5481)
The change in the P/invoke signature that came from CoreCLR triggers a bug in MCG on the TFS side.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Egor Chesakov [Fri, 2 Mar 2018 06:06:19 +0000 (22:06 -0800)]
Merge pull request #16617 from echesakovMSFT/UseCodeTTypedefArm
[RyuJIT/ARM32]Use emitter::code_t typedef for ARM
Carol Eidt [Fri, 2 Mar 2018 06:03:45 +0000 (07:03 +0100)]
Merge pull request #16669 from tannergooding/hwintrin-sse2-maskmove
Implement the SSE2 MaskMove intrinsic
Anirudh Agnihotry [Fri, 2 Mar 2018 05:53:25 +0000 (21:53 -0800)]
Fixing GetFullPath (#16670)
dotnet-maestro-bot [Fri, 2 Mar 2018 04:27:00 +0000 (22:27 -0600)]
Update CoreClr, CoreFx to preview2-26302-01, preview2-26228-08, respectively (#16702)
Bruce Forstall [Fri, 2 Mar 2018 02:10:55 +0000 (18:10 -0800)]
Generalize runtest.sh test exclusion files
Allow leading '#' as a comment character for all testsUnsupported and
testsFailing files.
Generalize testsFailingOnArm64.txt to testsFailing.$ARCH.txt
Generalize testsUnsupportedOnARM32.txt to testsUnsupported.$ARCH.txt
Eric Erhardt [Fri, 2 Mar 2018 00:51:06 +0000 (18:51 -0600)]
Vectorize String.IndexOf(char) and String.LastIndexOf(char) (#16392)
* Vectorize String.IndexOf(char) using the same algorithm as SpanHelpers
IndexOf(byte).
* Respond to feedback.
* Vectorize String.LastIndexOf
Clean up IndexOf vectorization.
Brian Sullivan [Fri, 2 Mar 2018 00:45:02 +0000 (16:45 -0800)]
Fix formatting
Tarek Mahmoud Sayed [Fri, 2 Mar 2018 00:36:39 +0000 (16:36 -0800)]
Fix Adar month name in Hebrew calendar (#16697)
The returned data from ICU has 6th month name as 'Adar I' and 7th month name as 'Adar'
We need to adjust that in the list used with non-leap year to have 6th month as 'Adar' and 7th month as 'Adar II'
note that when formatting non-leap year dates, 7th month shouldn't get used at all.