Yu Watanabe [Fri, 27 Oct 2017 03:09:26 +0000 (12:09 +0900)]
Merge pull request #7066 from poettering/specifier-update
extend unit file specifier expansion a bit + add a test for it
Lennart Poettering [Wed, 11 Oct 2017 12:09:10 +0000 (14:09 +0200)]
update TODO
Lennart Poettering [Wed, 11 Oct 2017 12:07:51 +0000 (14:07 +0200)]
test: add simple test for validating some of the unit specifiers we support
(Also, sort list of test unit files in meson.build alphabetically, to
make future additions more systematic)
Lennart Poettering [Wed, 11 Oct 2017 12:02:36 +0000 (14:02 +0200)]
core: add support for expanding state/cache/log directory root in unit files
This augments %t which already resolves to the runtime directory root, and
should be useful for units that want to pass any of these paths in
command line arguments.
Example:
ExecStart=/usr/bin/mydaemon --datadir=%S/mydaemon
Why not expose a specifier resolving directly to the configured
state/runtime/cache/log dir? Three reasons:
1. Specifiers should be independent of configuration of the unit itself,
and StateDirectory= and friends are unit configuration. See
03fc9c723cfc59467a7fccc305f34273f8564b25 and related work.
2. We permit multiple StateDirectory= values per unit, and it hence
wouldn't be clear which one is passed.
3. We already have %t for the runtime directory root, and we should
continue with the same scheme.
Razvan Cojocaru [Thu, 26 Oct 2017 14:59:04 +0000 (17:59 +0300)]
systemd-detect-virt: refine hypervisor detection (#7171)
Continue to try to get more details about the actual underlying
hypervisor with successive tests until none are available.
This fixes issue #7165.
Zbigniew Jędrzejewski-Szmek [Thu, 26 Oct 2017 13:29:03 +0000 (15:29 +0200)]
Merge pull request #7184 from keszybz/resolved-loop
resolved: fix loop on packets with pseudo dns types
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1725351,
CVE-2017-15908.
Lennart Poettering [Thu, 26 Oct 2017 08:57:00 +0000 (10:57 +0200)]
Merge pull request #7127 from keszybz/sundry-tweaks
Various unrelated small patches
Lennart Poettering [Thu, 26 Oct 2017 08:56:44 +0000 (10:56 +0200)]
Merge pull request #7142 from sourcejedi/systemd-shutdown
systemd-shutdown: avoid confusingly redundant messages
martingh [Thu, 26 Oct 2017 08:54:30 +0000 (10:54 +0200)]
Adding timer_event to wakeup as suggested by MHD_get_timeout (#7152)
Lars Kellogg-Stedman [Wed, 25 Oct 2017 11:23:51 +0000 (07:23 -0400)]
hwdb: Add ACCEL_MOUNT_MATRIX for ThinkPad Yoga 11e (#7174)
Accelerometer readings from the screen accelerometer on the Yoga 11e
need to be rotated 90 degrees around the Z axis.
Zbigniew Jędrzejewski-Szmek [Wed, 25 Oct 2017 09:19:19 +0000 (11:19 +0200)]
resolved: fix loop on packets with pseudo dns types
Reported by Karim Hossen & Thomas Imbert from Sogeti ESEC R&D.
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1725351
Hans de Goede [Wed, 25 Oct 2017 07:47:27 +0000 (09:47 +0200)]
hwdb: Document expected MOUNT_MATRIX on devices with non upright display (#7177)
On some devices the display (LCD panel) is mounted non upright
in the device's casing, e.g. mounted upside-down or 90 degree rotated.
Document the expected ACCEL_MOUNT_MATRIX settings for such devices.
Lauri Tirkkonen [Tue, 24 Oct 2017 17:40:50 +0000 (20:40 +0300)]
nspawn: EROFS for chowning mount points is not fatal (#7122)
This fixes --read-only with --private-users. mkdir_userns_p may return
-EROFS if either mkdir or lchown fails; lchown failing is fine as the
mount point will just be overmounted, and if mkdir fails then the
following mount() will also fail (with ENOENT).
Alan Jenkins [Thu, 19 Oct 2017 14:02:12 +0000 (15:02 +0100)]
core: systemd-shutdown: avoid confusingly redundant messages
After previous output from systemd-shutdown indicated a bug, my attention
was drawn to redundant output lines. Did they indicate an anomaly?
It turns out to be an expected, harmless result of the current code. But
we don't have much justification to run such redundant operations. Let's
remove the confusing redundant message.
We can stop trying to remount a directory read-only once its mount entry
has successfully been changed to "ro". We can simply let the kernel keep
track of this for us. I don't bother to try and avoid re-parsing the
mountinfo. I appreciate snappy shutdowns, but this code is already
intricate and buggy enough (see issue 7131).
(Disclaimer: At least for the moment, you can't _rely_ on always seeing
suspicious output from systemd-shutdown. By default, you can expect the
kernel to truncate the log output of systemd-shutdown. Ick ick ick!
Because /dev/kmsg is rate-limited by default. Normally it prints a message
"X lines supressed", but we tend to shut down before the timer expires
in this case).
Before:
systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel...
EXT4-fs (vda3): re-mounted. Opts: data=ordered
systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ...
EXT4-fs (vda3): re-mounted. Opts: data=ordered
After:
systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ...
EXT4-fs (vda3): re-mounted. Opts: data=ordered
I also tested with `systemctl reboot --force`, plus a loopback mount to
cause one of the umounts to fail initially. In this case another 2 lines
of output are removed (out of a larger number of lines).
Dimitri John Ledkov [Tue, 24 Oct 2017 13:28:41 +0000 (09:28 -0400)]
resolved: create private stub resolve file for /etc/resolv.conf integration (#7014)
This creates a second private resolve.conf file which lists the stub resolver
and the resolved acquired search domains.
This runtime file should be used as a symlink target for /etc/resolv.conf such
that non-nss based applications can resolve search domains.
Fixes: #7009
Lennart Poettering [Tue, 24 Oct 2017 13:25:12 +0000 (15:25 +0200)]
Merge pull request #7141 from yuwata/fix-7129
core: fix D-Bus API
Zbigniew Jędrzejewski-Szmek [Tue, 24 Oct 2017 12:48:54 +0000 (14:48 +0200)]
core: in --user mode, report READY=1 as soon as basic.target is reached (#7102)
When a user logs in, systemd-pam will wait for the user manager instance to
report readiness. We don't need to wait for all the jobs to finish, it
is enough if the basic startup is done and the user manager is responsive.
systemd --user will now send out a READY=1 notification when either of two
conditions becomes true:
- basic.target/start job is gone,
- the initial transaction is done.
Also fixes #2863.
Lennart Poettering [Tue, 24 Oct 2017 10:24:09 +0000 (12:24 +0200)]
Merge pull request #7123 from keszybz/date-formatting
Fix for time stamp formatting in timedatectl
Yu Watanabe [Thu, 19 Oct 2017 13:40:04 +0000 (22:40 +0900)]
core: fix D-Bus API
This fixes bugs introduced by
cffaed83e87bde81378b2be74192193850d0e03a.
Closes #7129.
myrkr [Tue, 24 Oct 2017 07:56:40 +0000 (09:56 +0200)]
nspawn: Fix calculation of capabilities for configuration file (#7087)
The current code shifting an integer 1 failed for capabilities like
CAP_MAC_ADMIN (numerical value 33). This caused issues when specifying
them in the nspawn configuration file. Using an uint64_t 1 instead.
The similar code for processing the --capability command line option
was already correctly working.
Zbigniew Jędrzejewski-Szmek [Tue, 24 Oct 2017 07:41:52 +0000 (09:41 +0200)]
man: update the description of interval limiting (#7128)
Fixes #7125.
Lennart Poettering [Tue, 24 Oct 2017 07:38:01 +0000 (09:38 +0200)]
Merge pull request #7148 from keszybz/dynamic-user-use-gid
Use gid for static dynamic users
Mantas Mikulėnas [Mon, 23 Oct 2017 20:56:01 +0000 (23:56 +0300)]
NEWS: start adding 236 (#7159)
Lennart Poettering [Mon, 23 Oct 2017 16:39:07 +0000 (18:39 +0200)]
Merge pull request #6948 from pfl/radv_emit_dns
Add EmitDNS= and EmitDomains= network file configuration options
Zbigniew Jędrzejewski-Szmek [Fri, 20 Oct 2017 11:00:12 +0000 (13:00 +0200)]
core/dynamic-user: use gid from pwnam if a static user was found
Fixes #7133.
v2:
- update based on review
Peter Hutterer [Mon, 23 Oct 2017 08:20:16 +0000 (18:20 +1000)]
hwdb: invert the USB touchpad integration assumption (#7161)
The vast majority of touchpads are internal, so let's assume that any USB
touchpad is internal by default (exception: bluetooth) and manually mark the
ones that are external. That's a lot more future-proof than having to mark all
internal touchpads that use USB as internal - that number is only going to
increase.
Related to #7068
Michael Biebl [Sat, 21 Oct 2017 06:32:50 +0000 (08:32 +0200)]
modprobe.d: fix directory of modprobe configuration file (#7149)
kmod upstream uses /lib/modprobe.d which means we need to use rootprefix
instead of prefix for installing the modprobe configuration file as
otherwise split-usr systems are broken.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879191
Zbigniew Jędrzejewski-Szmek [Fri, 20 Oct 2017 10:41:04 +0000 (12:41 +0200)]
core/dynamic-user: use _cleanup_ in dynamic user locking
This makes the code a bit easier to read.
Patrik Flykt [Fri, 20 Oct 2017 08:59:15 +0000 (11:59 +0300)]
sd-radv: Allocate space also for DNSSL iov option (#7144)
The iov array needs to hold five entries in addition to the number
of prefixes.
Alan Jenkins [Thu, 19 Oct 2017 14:00:57 +0000 (15:00 +0100)]
core: systemd-shutdown: add missing check for umount_changed
The assumption was that nothing changes in the final attempt. This
would be confusing if a filesystem with a process in uninterruptible
sleep suddenly became un-stuck for the final attempt, but we still give
up and don't try to e.g. unmount any parent mounts.
I don't know how possible that is. But the code will be easier to read
without an assumption that it does not attempt to justify.
Zbigniew Jędrzejewski-Szmek [Thu, 19 Oct 2017 06:29:37 +0000 (08:29 +0200)]
Merge pull request #7132 from splantefeve/fr-translation
Update French translation
Sylvain Plantefève [Wed, 18 Oct 2017 22:26:52 +0000 (00:26 +0200)]
po: update french translation
Sylvain Plantefève [Wed, 18 Oct 2017 22:26:27 +0000 (00:26 +0200)]
catalog: update french translation
Zbigniew Jędrzejewski-Szmek [Wed, 18 Oct 2017 16:47:34 +0000 (18:47 +0200)]
man: describe how machine-id should be initialized (#7051)
Zbigniew Jędrzejewski-Szmek [Wed, 18 Oct 2017 15:31:51 +0000 (17:31 +0200)]
rfkill: include the device name in error message
Zbigniew Jędrzejewski-Szmek [Wed, 18 Oct 2017 07:39:30 +0000 (09:39 +0200)]
man: recommend using /var/lib/machines in systemd-nspawn(1)
Also update the instruction to latest Fedora version.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Oct 2017 21:00:54 +0000 (23:00 +0200)]
util-lib: simplify kexec_loaded()
Zbigniew Jędrzejewski-Szmek [Sun, 15 Oct 2017 19:24:32 +0000 (21:24 +0200)]
logind: drop unnecessary braces
Zbigniew Jędrzejewski-Szmek [Sun, 15 Oct 2017 17:47:16 +0000 (19:47 +0200)]
meson: drop unneeded check for grep
Zbigniew Jędrzejewski-Szmek [Wed, 18 Oct 2017 14:15:09 +0000 (16:15 +0200)]
timedatectl: stop using xstrftime
When using strftime in arbitrary locales, we cannot really say how big the
buffer should be. Let's make the buffer "large", which will work fine pretty
much always, and just print n/a if the timestamp does not fit. strftime returns
0 if the buffer is too small and a NUL-terminated string otherwise, so we
can drop the size specifications in string formatting.
$ export LANG=fa_IR.UTF-8
$ date
چهارشنبه ۱۸ اكتبر ۱۷، ساعت ۱۰:۵۴:۲۴ (+0330)
$ timedatectl
Assertion 'xstrftime: a[] must be big enough' failed at ../src/timedate/timedatectl.c:105, function print_status_info(). Aborting.
now:
$ timedatectl
Local time: چهارشنبه 2017-10-18 16:29:40 CEST
Universal time: چهارشنبه 2017-10-18 14:29:40 UTC
RTC time: چهارشنبه 2017-10-18 14:29:40
…
https://bugzilla.redhat.com/show_bug.cgi?id=1503452
Lennart Poettering [Wed, 18 Oct 2017 13:15:29 +0000 (21:15 +0800)]
Merge pull request #7078 from keszybz/cryptsetup-netdev-fixes
Cryptsetup _netdev fixes
Zbigniew Jędrzejewski-Szmek [Wed, 18 Oct 2017 13:14:46 +0000 (15:14 +0200)]
units: make remote-cryptsetup.target also after cryptsetup-pre.target
This way people can order units before cryptsetup-pre.target and
have them run before any cryptsetup-related stuff.
Susant Sahani [Wed, 18 Oct 2017 10:38:56 +0000 (16:08 +0530)]
networkd: don't stop the dhcp server if it's not configured. (#7083)
we call sd_dhcp_server_stop even if it's not configured when link is
down resulting unwanted logs.
```
Oct 10 13:41:07 nena systemd-networkd[126]: eth0: Lost carrier
Oct 10 13:41:07 nena systemd-networkd[126]: DHCP CLIENT (0x560f2dc5): STOPPED
Oct 10 13:41:07 nena systemd-networkd[126]: eth0: DHCP lease lost
Oct 10 13:41:07 nena systemd-networkd[126]: NDISC: Stopping IPv6 Router Solicitation client
Oct 10 13:41:07 nena systemd-networkd[126]: Assertion 'server' failed at ../src/libsystemd-network/sd-dhcp-server.c:256, function sd_dhcp_server_stop(). Ignoring.
```
fixes #7047
Zbigniew Jędrzejewski-Szmek [Wed, 18 Oct 2017 09:27:23 +0000 (11:27 +0200)]
tests: rename test-time to test-time-util
It's for testing time-util.c so rename it to make things more
obvious.
Susant Sahani [Wed, 18 Oct 2017 09:12:59 +0000 (14:42 +0530)]
networkd: Consider linkLocalAddressing state while configuring ndisc. (#7012)
If linkLocalAddressing is disabled in for the interface still then
we look for ndisc configured or not in link_check_ready.
Link local is used automatic address configuration and neighbor discovery protocol.
If link local is disabled we should not configure ndisc.
Fixes #2713, #6441, #5841.
Lubomir Rintel [Wed, 18 Oct 2017 06:38:50 +0000 (08:38 +0200)]
core: fragments of masked units ought not be considered for NeedDaemonReload (#7060)
The units that are not loaded don't have dropin_paths set. This
currently results in units that have fragments to always have
NeedDaemonReload=true when masked:
$ find {/usr/lib,/run/user/8086}/systemd/user/meh.service* |xargs ls -ld
lrwxrwxrwx. 1 lkundrak lkundrak 9 Oct 11 11:19 /run/user/8086/systemd/user/meh.service -> /dev/null
-rw-rw-r--. 1 root root 49 Oct 11 10:16 /usr/lib/systemd/user/meh.service
drwxrwxr-x. 2 root root 4096 Oct 11 10:50 /usr/lib/systemd/user/meh.service.d
-rw-rw-r--. 1 root root 666 Oct 11 10:50 /usr/lib/systemd/user/meh.service.d/override.conf
$ systemctl --user daemon-reload
$ busctl --user get-property org.freedesktop.systemd1 \
/org/freedesktop/systemd1/unit/meh_2eservice \
org.freedesktop.systemd1.Unit NeedDaemonReload
b true
Zbigniew Jędrzejewski-Szmek [Wed, 18 Oct 2017 06:37:12 +0000 (08:37 +0200)]
Merge pull request #7059 from yuwata/dynamic-user-7013
dynamic-user: permit the case static uid and gid are different
Yu Watanabe [Wed, 18 Oct 2017 06:30:35 +0000 (15:30 +0900)]
man: add explanation about target's DefaultDependencies= (#7120)
Closes #7113.
Yu Watanabe [Wed, 18 Oct 2017 06:30:00 +0000 (15:30 +0900)]
man: comment a requirement about the static user or group when DynamicUser=yes
John Lin [Wed, 18 Oct 2017 06:29:19 +0000 (14:29 +0800)]
man: mention /run in systemd.generator document (#7121)
Susant Sahani [Wed, 18 Oct 2017 06:25:57 +0000 (11:55 +0530)]
networkd: Don't stop networkd if CONFIG_FIB_RULES=n in kernel (#7030)
If FIB Rules are not supported by the kernel then networkd fails to
start as it retuns error=-EOPNOTSUPP.
In this case just ignore and let start networkd.
```
sendto(5, {{len=28, type=RTM_GETRULE, flags=NLM_F_REQUEST|NLM_F_ACK|NLM_F_DUMP, seq=8, pid=0}, {family=AF_UNSPEC, dst_len=0, src_len=0, tos=0, table=RT_TABLE_UNSPEC, action=FR_ACT_TO_TBL, flags=0}}, 28, 0, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=
00000000}, 16) = 28
recvmsg(5, {msg_name={sa_family=AF_NETLINK, nl_pid=0, nl_groups=
00000000}, msg_namelen=128->12, msg_iov=[{iov_base=NULL, iov_len=0}], msg_iovlen=1, msg_control=[{cmsg_len=20, cmsg_level=SOL_NETLINK, cmsg_type=0x3}], msg_controllen=24, msg_flags=MSG_TRUNC}, MSG_PEEK|MSG_TRUNC) = 48
recvmsg(5, {msg_name={sa_family=AF_NETLINK, nl_pid=0, nl_groups=
00000000}, msg_namelen=128->12, msg_iov=[{iov_base={{len=48, type=NLMSG_ERROR, flags=0, seq=8, pid=8856}, {error=-EOPNOTSUPP, msg={{len=28, type=RTM_GETRULE, flags=NLM_F_REQUEST|NLM_F_ACK|NLM_F_DUMP, seq=8, pid=0}, {family=AF_UNSPEC, dst_len=0, src_len=0, tos=0, table=RT_TABLE_UNSPEC, action=FR_ACT_TO_TBL, flags=0}}}}, iov_len=7416}], msg_iovlen=1, msg_control=[{cmsg_len=20, cmsg_level=SOL_NETLINK, cmsg_type=0x3}], msg_controllen=24, msg_flags=0}, MSG_TRUNC) = 48
```
```
Oct 08 10:22:24 naomi systemd[1]: Starting Network Service...
Oct 08 10:22:24 naomi systemd-networkd[983]: Could not enumerate rules: Operation not supported
Oct 08 10:22:24 naomi systemd[1]: systemd-networkd.service: Main process exited, code=exited, status=1/FAILURE
```
Fixes #7027
Yu Watanabe [Tue, 17 Oct 2017 23:57:54 +0000 (08:57 +0900)]
core: fix invalid error message
The error message corresponds to EILSEQ is "Invalid or incomplete
multibyte or wide character", and is not suitable in this case.
So, let's show a custom error message when the function
dynamic_creds_realize() returns -EILSEQ.
Zbigniew Jędrzejewski-Szmek [Thu, 12 Oct 2017 20:43:58 +0000 (22:43 +0200)]
man: add a note about _netdev usage
Zbigniew Jędrzejewski-Szmek [Thu, 12 Oct 2017 20:34:54 +0000 (22:34 +0200)]
units: replace remote-cryptsetup-pre.target with remote-fs-pre.target
remote-cryptsetup-pre.target was designed as an active unit (that pulls in
network-online.target), the opposite of remote-fs-pre.target (a passive unit,
with individual provider services ordering itself before it and pulling it in,
for example iscsi.service and nfs-client.target).
To make remote-cryptsetup-pre.target really work, those services should be
ordered before it too. But this would require updates to all those services,
not just changes from systemd side.
But the requirements for remote-fs-pre.target and remote-cryptset-pre.target
are fairly similar (e.g. iscsi devices can certainly be used for both), so
let's reuse remote-fs-pre.target also for remote cryptsetup units. This loses
a bit of flexibility, but does away with the requirement for various provider
services to know about remote-cryptsetup-pre.target.
Zbigniew Jędrzejewski-Szmek [Tue, 17 Oct 2017 15:49:48 +0000 (17:49 +0200)]
test-path: fix inverted return value (#7050)
It must be <0 to indicate failure.
Fixes #7050.
Mantas Mikulėnas [Mon, 16 Oct 2017 15:17:47 +0000 (18:17 +0300)]
modprobe.d: expand drop-in to handle dummy0 as well (#7099)
Michal Sekletar [Mon, 16 Oct 2017 14:15:05 +0000 (16:15 +0200)]
mount: make sure we unmount tmpfs mounts before we deactivate swaps (#7076)
In the past we introduced this property just for tmp.mount. However on
todays systems usually there are many more tmpfs mounts. Most notably
mounts backing XDG_RUNTIME_DIR for each user.
Let's generalize what we already have for tmp.mount and implement the
ordering After=swap.target for all tmpfs based mounts.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Oct 2017 10:47:30 +0000 (12:47 +0200)]
Merge pull request #7061 from lkundrak/lr/serialized-environment
Environment serialization/deserialization inconsistently validates the variables
Boucman [Sun, 15 Oct 2017 10:22:47 +0000 (12:22 +0200)]
Display the systemctl status in green if state is "running" (#7094)
Zbigniew Jędrzejewski-Szmek [Fri, 13 Oct 2017 08:19:55 +0000 (10:19 +0200)]
Merge pull request #7062 from yuwata/test-bind-paths
test: add test for BindPaths= and BindReadOnlyPaths=
John Lin [Fri, 13 Oct 2017 08:17:43 +0000 (16:17 +0800)]
gitignore: ignore output file of mkid (#7081)
mkid is from https://www.gnu.org/software/idutils/
Christian Hesse [Fri, 13 Oct 2017 07:10:26 +0000 (09:10 +0200)]
man: update changes about gateway -> _gateway (#7085)
Commit
5248e7e1f11aba6859de0b28f0dd3778b22842f2
(resolved,nss-myhostname: use _gateway for the gateway) changed how the
gateway is resolved. Reflect the change in documentation.
Close #7084.
Zbigniew Jędrzejewski-Szmek [Thu, 12 Oct 2017 20:13:03 +0000 (22:13 +0200)]
units: add [Install] section to remote-cryptsetup.target
This makes this target the same as remote-fs.target in this regard. In practice
it probably doesn't make that much difference, because all encrypted devices
that are part of remote-fs.target (marked with _netdev) will be used for mount
points, so they will be pulled in anyway individually, but with this change any
such device will be configured, even if it is not pulled by any other unit.
Lubomir Rintel [Thu, 12 Oct 2017 06:14:25 +0000 (08:14 +0200)]
systemctl: clarify --global, --root and --runtime options (#7071)
They're not only for enabling.
Vito Caputo [Thu, 12 Oct 2017 06:14:07 +0000 (23:14 -0700)]
shared: add vectorized parse_field() (#7056)
By vectorizing parse_field() the chain of parse_field() calls in
output_short() can be replaced with a single call receiving a description
of the desired fields and their targets.
While at it, eliminate the repeated strlen() calls performed on constant
field names by making parse_field() receive the field length, and storing
it in the ParseFieldVec at compile time.
Also sort the output_short() fields so the short ones are tried first, for
a minor efficiency gain.
In addition to making the code less repetitive, gcc in my tests now inlines
the parse_fieldv() call in output_short().
Yu Watanabe [Thu, 12 Oct 2017 06:10:25 +0000 (15:10 +0900)]
core: cleanup for enforce_groups() (#7064)
SupplementaryGroups= is preprocessed in get_supplementary_groups().
So, it is not necessary to input ExecContext to enforce_groups().
Yu Watanabe [Thu, 12 Oct 2017 04:26:39 +0000 (13:26 +0900)]
test-execute: always use /bin/sh
Yu Watanabe [Thu, 12 Oct 2017 04:25:06 +0000 (13:25 +0900)]
test: add test for BindPaths= and BindReadOnlyPaths=
Follow-up for
a8cabc612b16834260831a8163ae4b479b5c33a5.
John Lin [Wed, 11 Oct 2017 18:22:51 +0000 (02:22 +0800)]
systemctl: supress enable/disable messages when -q is given (#7067)
Fixes: #7036
Lennart Poettering [Wed, 11 Oct 2017 18:21:29 +0000 (20:21 +0200)]
basic: split unit-name.[ch] into two (#7065)
It always bothered me a bit that unit-name.[ch] contains so many
definitions that aren't really have much to do with unit nameing, for
example all the unit state definitions.
With this patch unit-name.[ch] is split into two: the file now contains
only the unit naming related operations, and everything else is split
out into a new set of files unit-def.[ch]. That's mostly unit state
stuff as well as dbus path and interface name operations.
No functional changes. This just moves code around.
(Note as both .c files include each other's headers this doesn't make
the build simpler or anything. All it does is make the C files a bit
shorter, and medicate my pretend OCD)
Lubomir Rintel [Wed, 11 Oct 2017 13:05:38 +0000 (15:05 +0200)]
basic/env-util: don't relax unesaping of serialized environment strings
We wrote them ourselves -- they shouldn't contain invalid sequences.
Lubomir Rintel [Wed, 11 Oct 2017 07:29:30 +0000 (09:29 +0200)]
basic/env-util: drop the validation when deserializing environment
The environment variables we've serialized can quite possibly contain
characters outside the set allowed by env_assignment_is_valid(). In
fact, my environment seems to contain a couple of these:
* TERMCAP set by screen contains a '\x7f' character
* BASH_FUNC_module%% variable has a '%' character in name
Strict check of environment variables name and value certainly makes sense for
unit files, but not so much for deserialization of values we already had
in our environment.
Florian Klink [Wed, 11 Oct 2017 12:45:48 +0000 (14:45 +0200)]
test-dhcp-client: fix typos in comment (#7052)
Susant Sahani [Wed, 11 Oct 2017 07:08:05 +0000 (12:38 +0530)]
networkd: bridge allow AgeingTimeSec to be set 0 (#7021)
Closes #7019.
Yu Watanabe [Wed, 11 Oct 2017 05:41:13 +0000 (14:41 +0900)]
dynamic-user: permit the case static uid and gid are different
This makes systemd supports the case that DynamicUser=yes and
static user and group exist such that uid and gid of them are different.
We only refuse the operation when user does not exist but the group
with the same name exists.
Fixes #7013.
Vito Caputo [Wed, 11 Oct 2017 04:05:00 +0000 (21:05 -0700)]
Merge pull request #7058 from yuwata/fix-7055
core: fix segfault in compile_bind_mounts() when BindPaths= or BindReadOnlyPaths= is set
Yu Watanabe [Wed, 11 Oct 2017 03:46:27 +0000 (12:46 +0900)]
dynamic-user: label functions not necessary to export as static
Yu Watanabe [Wed, 11 Oct 2017 03:27:13 +0000 (12:27 +0900)]
core: fix segfault in compile_bind_mounts() when BindPaths= or BindReadOnlyPaths= is set
This fixes a bug introduced by
6c47cd7d3bf35c8158a0737f34fe2c5dc95e72d6.
Fixes #7055.
Jakub Wilk [Tue, 10 Oct 2017 19:59:03 +0000 (21:59 +0200)]
man: fix typos (#7029)
Zbigniew Jędrzejewski-Szmek [Tue, 10 Oct 2017 19:57:39 +0000 (21:57 +0200)]
Merge pull request #7044 from poettering/minidocfixes
tiny doc fixes
AsciiWolf [Tue, 10 Oct 2017 19:52:52 +0000 (21:52 +0200)]
l10n: update Czech Translation (#7049)
Zbigniew Jędrzejewski-Szmek [Tue, 10 Oct 2017 19:50:17 +0000 (21:50 +0200)]
Merge pull request #7045 from poettering/namespace-casing
some super-trivial fixes to namespace.c
Zbigniew Jędrzejewski-Szmek [Tue, 10 Oct 2017 18:55:20 +0000 (20:55 +0200)]
tests: skip tests when cg_pid_get_path fails (#7033)
v2:
- cast the fstype_t type to ull, because it varies between arches.
Making it long long should be on the safe side.
Lennart Poettering [Tue, 10 Oct 2017 08:05:43 +0000 (10:05 +0200)]
Merge pull request #7003 from yuwata/enable-dynamic-user
timesyncd, journal-upload: Enable DynamicUser=
gwendalcr [Tue, 10 Oct 2017 08:03:38 +0000 (01:03 -0700)]
rules: Add MODEL_ID for NVMe device (#7037)
To mimic MODEL_ID variable built for ATA and SCSI devices, add rules
to add MODEL_ID variable for NVMe devices.
TEST: Check on a system with NVMe device that MODEL_ID variable is
present:
udevadm info --query=all -n /dev/nvme0n1p1 | grep ID_MODEL
and
udevadm info --query=all -n /dev/nvme0n1p1 | grep ID_MODEL
return:
E: ID_MODEL=SAMSUNG...
Lennart Poettering [Tue, 10 Oct 2017 07:50:23 +0000 (09:50 +0200)]
namespace: make ns_type_supported() a tiny bit shorter
namespace_type_to_string() already validates the type paramater, we can
use that, and shorten the function a bit.
Lennart Poettering [Tue, 10 Oct 2017 07:49:20 +0000 (09:49 +0200)]
namespace: change NameSpace → Namespace
We generally use the casing "Namespace" for the word, and that's visible
in a number of user-facing interfaces, including "RestrictNamespace=" or
"JoinsNamespaceOf=". Let's make sure to use the same casing internally
too.
As discussed in #7024
Michal Sekletar [Tue, 10 Oct 2017 07:46:13 +0000 (09:46 +0200)]
namespace: fall back gracefully when kernel doesn't support network namespaces (#7024)
Sergey Ptashnick [Tue, 10 Oct 2017 07:44:52 +0000 (10:44 +0300)]
catalog,po: update Russian translation (#7041)
Lennart Poettering [Tue, 10 Oct 2017 07:43:37 +0000 (09:43 +0200)]
man: fix link to documentation of slice concept
Lennart Poettering [Tue, 10 Oct 2017 07:41:17 +0000 (09:41 +0200)]
man: symlinks are made onto "unit files", not "units"
We should be careful when talking about "units" and "unit files". The
latter should be the concept on disk, and the former, the loaded version
of it. However, as a single unit file can result in multiple loaded
units (think templates), and a units can also exist with no unit file at
all (think .device units), we should be precise.
As symlinks are created on unit files rather than units (as symlinks are
an fs object, and unit files are too, but units are not), let's say so
here.
Muhammet Kara [Mon, 9 Oct 2017 13:39:19 +0000 (15:39 +0200)]
Updated Turkish translation (#7017)
Lennart Poettering [Mon, 9 Oct 2017 13:38:30 +0000 (15:38 +0200)]
Merge pull request #7034 from keszybz/modules-load-downgrade-errors
Downgrade errors resulting from user configuration in modules-load
Lennart Poettering [Mon, 9 Oct 2017 13:22:22 +0000 (15:22 +0200)]
update TODO
Zbigniew Jędrzejewski-Szmek [Sun, 8 Oct 2017 14:21:06 +0000 (16:21 +0200)]
modules-load: downgrade error on ENODEV/ENOENT
Some kernel modules may be loaded if the hardware does not exist
(usually when the hardware is hot-pluggable), while others fail with
ENODEV. Let's make those two cases more similar, and simply log
modules which cannot be loaded because of missing hardware without
failing systemd-modules-load.service.
For modules which don't exist, let's warn, but not fail the whole
service. I think a warning is appropriate because it's likely that
a typo was made.
Zbigniew Jędrzejewski-Szmek [Sun, 8 Oct 2017 14:18:57 +0000 (16:18 +0200)]
kmod_module_probe_insert_module returns 0 on success, != 0 on failure
More specifically, it should return > 0 only for conditions specified in
probe_flags. We only set KMOD_PROBE_APPLY_BLACKLIST in probe_flags, so the
code was correct, but add an assert to clarify this.
Mike Gilbert [Sun, 8 Oct 2017 20:14:45 +0000 (16:14 -0400)]
test: skip hwdb and sysv-generator if the features are disabled (#7026)
Zbigniew Jędrzejewski-Szmek [Sun, 8 Oct 2017 13:55:24 +0000 (15:55 +0200)]
util-lib: introdude _cleanup_ macros for kmod objects
bleep_blop [Sun, 8 Oct 2017 20:01:08 +0000 (01:31 +0530)]
man: fix typo for !! in systemd.service (#7031)
!! must be very similar to !, not itself.
Piotr Drąg [Fri, 6 Oct 2017 14:10:33 +0000 (16:10 +0200)]
po: update Polish translation (#7015)