James E Keenan [Thu, 27 Sep 2012 23:05:15 +0000 (19:05 -0400)]
Clarify rationale for consulting L<feature>.
For RT #90178.
Dominic Hargreaves [Thu, 27 Sep 2012 17:31:45 +0000 (18:31 +0100)]
Revert "Add 5.14.3-RC1 to perlhist"
RC releases shouldn't be in perlhist
This reverts commit
bfec0e075afbe1005446f328adda6fefd2dc88ee.
Karl Williamson [Thu, 27 Sep 2012 03:40:22 +0000 (21:40 -0600)]
perlreguts: Fit long verbatim lines to 79 cols
Karl Williamson [Thu, 27 Sep 2012 16:12:41 +0000 (10:12 -0600)]
mktables: Mention USourceData in generated pod
These files were included by Unicode for the first time in the final
version of its version 6.2. They document proposals for encoding
Han characters in Unicode. As far as I can tell, they have no real use
except to people working on such proposals. They are considered part of
the Unicode Character Database, however, and should be mentioned in
perluniprops as data that Perl ignores from that database.
Karl Williamson [Thu, 27 Sep 2012 16:12:06 +0000 (10:12 -0600)]
mktables: Nits in comments, generated pod
David Golden [Thu, 27 Sep 2012 15:08:09 +0000 (11:08 -0400)]
perlpolicy.pod: clarify module deprecation/removal
Jesse Luehrs [Thu, 27 Sep 2012 15:03:13 +0000 (10:03 -0500)]
move perlrun to a more prominent place in perl.pod
the list of command line options in the synopsis is really not very
useful without knowing what they mean, and listing perlrun way down in
the table of contents doesn't make it very easy to figure out what they
mean.
Karl Williamson [Thu, 27 Sep 2012 02:41:58 +0000 (20:41 -0600)]
Use official Unicode 6.2
Unicode 6.2 has been officially released, and is delivered by this
commit. There are no substantive changes from the final 6.2 beta, which
this replaces.
James E Keenan [Thu, 27 Sep 2012 00:15:30 +0000 (20:15 -0400)]
Eliminate now superfluous counter.
Colin Kuskie [Mon, 10 Sep 2012 02:08:55 +0000 (19:08 -0700)]
Refactor t/op/lex_assign.t to use test.pl, and not make TAP by hand.
Dominic Hargreaves [Wed, 26 Sep 2012 22:48:48 +0000 (23:48 +0100)]
Add 5.14.3-RC1 to perlhist
Nicholas Clark [Sun, 23 Sep 2012 20:48:42 +0000 (22:48 +0200)]
Flush PL_stashcache when assigning a file handle to a typeglob.
File handles take priority over stashes for method dispatch. Assigning a
file handle to a typeglob potentially creates a file handle where one did
not exist before. As PL_stashcache only contains entries for names which
unambiguously resolve to stashes, such a change may mean that PL_stashcache
now contains an invalid entry. As it's hard to work out exactly which entries
might be affected, simply flush the entire cache and let it rebuild itself.
Nicholas Clark [Sun, 23 Sep 2012 20:21:14 +0000 (22:21 +0200)]
Restore use of PL_stashcache, the stash name lookup cache for method calls.
Commit
da6b625f78f5f133 in Aug 2011 inadvertently broke the code that looks
up values in PL_stashcache. As it's a only cache, quite correctly everything
carried on working without it.
Restoring it re-introduces two bugs first introduced when PL_stashcache was
added, by commit
081fc587427bbcef in Apr 2003.
Nicholas Clark [Sun, 23 Sep 2012 20:05:16 +0000 (22:05 +0200)]
-Do now also reports updates and use of PL_stashcache.
Nicholas Clark [Sun, 23 Sep 2012 20:01:14 +0000 (22:01 +0200)]
Test the resolution behaviour for file handles and package names.
Historical behaviour is that file handles take priority over package names,
and the use of PL_stashcache shouldn't change this.
Father Chrysostomos [Wed, 26 Sep 2012 20:12:57 +0000 (13:12 -0700)]
Restore special blocks to working order
I accidentally broke these in commit
85ffec3682, yet everything passed
for me under threads+mad.
PL_compcv is usually restored to its previous value at the end of
newATTRSUB when LEAVE_SCOPE is called. But BEGIN blocks are called
before that. I needed PL_compcv to be restored to its previ-
ous value before it was called, so I added LEAVE_SCOPE before
process_special_blocks.
But that caused the name to be freed before S_process_special_blocks
got a chance to look at it.
So I have now added a new parameter to S_process_special_blocks to
allow *it* to call LEAVE_SCOPE after it determines that it is a BEGIN
block, but before it calls it.
Karl Williamson [Wed, 26 Sep 2012 17:23:05 +0000 (11:23 -0600)]
perlreapi.pod: Reflow verbatim lines to 79 cols.
Karl Williamson [Wed, 26 Sep 2012 17:21:13 +0000 (11:21 -0600)]
porting/podcheck.t: Add test for removed files
If a file is removed from Perl that is in podcheck's data base,
it should be removed from the db at that time. This adds a check
to make sure that happens.
Karl Williamson [Wed, 26 Sep 2012 17:19:20 +0000 (11:19 -0600)]
podcheck.t: Return success/failure from ok()
This program has a private version of ok() to avoid messages that would
come from the standard one that would confuse things in these tests.
It did not return true/false prior to this commit
Karl Williamson [Wed, 26 Sep 2012 16:42:29 +0000 (10:42 -0600)]
regen podcheck after MPE port removed
Commit
b5afd3466ff5e5b70ea2921169f138f02727183e removed the MPE/iX
port, which included a file that had known (to podcheck.t) pod errors
podcheck doesn't currently check if a pod has been removed, so its data
base still contained the offending entry, which would be removed the
next time it is regenerated for another unrelated reason. This might
confuse spelunkers of perl history, so I'm regenerating it separately
now.
Karl Williamson [Wed, 12 Sep 2012 16:57:54 +0000 (10:57 -0600)]
regcomp.c: Add a less confusing #define alias
ALNUM (meaning \w) is too close to ALNUMC ([[:alnum:]]) for comfort
Karl Williamson [Wed, 12 Sep 2012 16:04:29 +0000 (10:04 -0600)]
regcomp.c: Properly handle no isblank(), isascii()
Configure probes whether or not these two C library functions are
present or not. (However until commit
1c6eef9acffe4b512210edba79119e423ea4874a it didn't find isblank() even
if present.)
However the code changed by this commit always presumed both functions
were present. That there were no failure reports from the field
indicates that Perl is being run on systems where they are present.
Karl Williamson [Mon, 17 Sep 2012 21:47:17 +0000 (15:47 -0600)]
pod/perlrecharclass.pod: Small corrections, typos
Karl Williamson [Thu, 13 Sep 2012 01:43:02 +0000 (19:43 -0600)]
perlvar.pod: Document UTF8CACHE
Peter Martini [Tue, 25 Sep 2012 12:45:43 +0000 (08:45 -0400)]
mg_get should be called before access
Father Chrysostomos [Wed, 26 Sep 2012 15:53:36 +0000 (08:53 -0700)]
Test XS registration of state subs
my subs do not currently work yet. I am not sure what the API
should be.
Father Chrysostomos [Wed, 26 Sep 2012 15:47:28 +0000 (08:47 -0700)]
Make PL_compcv visible to BEGIN blocks
This allows BEGIN { XS_func(); } to access the currently-com-
piling pad.
BEGIN blocks were unlike any other subroutine or special block in that
PL_compcv would be set to the BEGIN block itself at run time.
David Mitchell [Wed, 26 Sep 2012 09:13:03 +0000 (10:13 +0100)]
[MERGE] make regex engine handle non-null-terminated strings
David Mitchell [Fri, 21 Sep 2012 09:29:04 +0000 (10:29 +0100)]
stop regex engine reading beyond end of string
Historically the regex engine has assumed that any string passed to it
will have a trailing null char. This isn't normally an issue in perl code,
since perl strings *are* null terminated; but it could cause problems with
strings returned by XS code, or with someone calling the regex engine
directly from XS, with strend not pointing at a null char.
The engine currently relies on there being a null char in the following
ways.
First, when at the end of string, the main loop of regmatch() still reads
in the 'next' character (i.e. the character following the end of string)
even if it doesn't make any use of it. This precludes using memory mapped
files as strings for example, since the read off the end would SEGV.
Second, the matching algorithm often required the trailing character to be
\0 to work correctly: the test for 'EOF' was "if next char is null *and*
locinput >= PL_regeol, then stop". So a random non-null trailing char
could cause an overshoot.
Thirdly, some match ops require the trailing char to be null to operate
correctly; for example, \b applied at the end of the string only happens
to work because the trailing char (\0) happens to match \W.
Also, some utf8 ops will try to extract the code point at the end, which
can result in multiple bytes past the end of string being read, and
possible problems if they don't correspond to well-formed utf8.
The main fix is in S_regmatch, where the 'read next char' code has been
updated to set it to a special value, NEXTCHR_EOS instead, if we would be
reading past the end of the string.
Lots of other random bits in the regex engine needed to be fixed up too.
To track these down, I temporarily hacked regexec_flags() to make a copy
of the string but without trailing \0, then ran all the t/re/*.t tests
under valgrind to flush out all buffer overruns. So I think I've removed
most of the bad code, but by no means all of it. The code within the
various functions in regexec.c is far too complex to be able to visually
audit the code with any confidence.
David Mitchell [Sun, 16 Sep 2012 16:39:06 +0000 (17:39 +0100)]
regmatch(): fix typo in TRIE commentary text
David Mitchell [Sun, 16 Sep 2012 16:33:08 +0000 (17:33 +0100)]
regmatch() annotate ops and separate out branches
Annotate each 'case OP:' in the main switch in regmatch() to show
what regex pattern this implements. About half the ops had already been
done. Also add a blank line between each 'case' statement for readability.
(no code changes)
David Mitchell [Fri, 14 Sep 2012 15:19:10 +0000 (16:19 +0100)]
regmatch(): do nextchr=*locinput at top of loop
Currently each branch in the main regmatch() loop is responsible
re-initialising nextchar to UCHARAT(locinput) if locinput is modified.
By adding
nextchr = UCHARAT(locinput);
to the head of the loop, we can remove most of the nextchar assignments
in the individual branches. We lose slightly for the zero-width assertions
like \b which will re-read the same nextchar, but this will make it
easier to handle non-null-terminated strings.
David Mitchell [Fri, 14 Sep 2012 14:46:47 +0000 (15:46 +0100)]
regmatch(): nextchar should always be positive
Remove the one bit of code that tests for < 0, and put in a
general assert.
David Mitchell [Fri, 14 Sep 2012 11:37:33 +0000 (12:37 +0100)]
regmatch(): consolidate locinput++
There are several places in the code that increment locinput by 1 char
(which may or may not be 1 byte) then update nextchr.
Consolidate these into a single code block with the others goto'ing it.
This actually reduces the code more than it appears, since the CCC_TRY*
macros expand into several branches, each of which repeatthe
increment code.
David Mitchell [Fri, 14 Sep 2012 10:28:08 +0000 (11:28 +0100)]
regmatch(): use nextchar where available
In a couple of places the code was using *locinput, where
nextchar already equalled *locinput
Steve Hay [Wed, 26 Sep 2012 07:33:20 +0000 (08:33 +0100)]
Stop declaring non-exported externs to non-core XS modules [perl #114516]
Hide the perl.h declarations of gete?[ug]id and getlogin on Win32 since
they are already declared in win32/win32.h, nearer to their definitions
(stub functions for UNIX compatibility) in win32/win32.c.
Also only declare them, and kill(pg)?, sbrk, chown and mkstemp, under
PERL_CORE anyway since they are not exported: including declarations for
non-exported functions just hides compiler errors about the symbols being
undefined, which doesn't help when trying to fix subsequent errors from
the linker about the symbols being unresolved. (Actually, all but sbrk,
chown and mkstemp get indirected through the perlhost layer normally
anyway, but it doesn't hurt to still hide the declarations, and helps in
the case of PERL_IMPLICIT_SYS not being defined, where only kill is
redefined to something which is exported.)
The declarations of the set[ug]id stub functions remain for now because
those two symbols are currently exported.
Paul Johnson [Wed, 26 Sep 2012 00:44:44 +0000 (02:44 +0200)]
Test for errors requiring .ph files.
Father Chrysostomos [Tue, 25 Sep 2012 21:46:35 +0000 (14:46 -0700)]
Correct fm vtable in perlguts.pod
fm magic uses want_vtbl_fm, which is #defined as want_vtbl_regexp.
The definition in regen/mg_vtable.pl does not affect anything except
the documentation. It was listed as using regdata which was wrong.
Father Chrysostomos [Wed, 26 Sep 2012 01:00:42 +0000 (18:00 -0700)]
Restore perly.o build with -DDEBUGGING
Father Chrysostomos [Tue, 25 Sep 2012 21:16:13 +0000 (14:16 -0700)]
Add t/test_pl* to MANIFEST
Soon, we’ll be testing that these tests work. :-)
Brad Gilbert [Tue, 25 Sep 2012 18:12:54 +0000 (13:12 -0500)]
Make t/test_pl/tempfile.t produce more diagnostics
Brad Gilbert [Sun, 16 Sep 2012 20:28:01 +0000 (15:28 -0500)]
Added t/test_pl/tempfile.t
Brad Gilbert [Sun, 16 Sep 2012 20:23:36 +0000 (15:23 -0500)]
Rework tempfile() in t/test.pl to use _num_to_alpha()
Brad Gilbert [Sun, 16 Sep 2012 20:15:02 +0000 (15:15 -0500)]
Added test names to some tests in t/test_pl/_num_to_alpha.t
Brad Gilbert [Sun, 16 Sep 2012 19:25:19 +0000 (14:25 -0500)]
Added optional char limit to _num_to_alpha() in test.pl
Brad Gilbert [Sun, 16 Sep 2012 19:06:59 +0000 (14:06 -0500)]
Add _num_to_alpha() to test.pl
Also added testing for _num_to_alpha()
Brad Gilbert [Tue, 25 Sep 2012 16:39:45 +0000 (11:39 -0500)]
Move @letters in test.pl earlier
Jesse Luehrs [Tue, 25 Sep 2012 15:04:00 +0000 (10:04 -0500)]
apparently this actually needs to be regenerated too
Jesse Luehrs [Tue, 25 Sep 2012 08:51:14 +0000 (03:51 -0500)]
fix regen_perly.pl for bison 2.6
Father Chrysostomos [Tue, 25 Sep 2012 01:18:42 +0000 (18:18 -0700)]
[perl #56880] Allow v10 as a label or package name
Chris 'BinGOs' Williams [Tue, 25 Sep 2012 08:46:42 +0000 (09:46 +0100)]
Update Digest-SHA to CPAN version 5.72
[DELTA]
5.72 Mon Sep 24 15:22:08 MST 2012
- adjusted module installation directory for later Perls
-- As of 5.11 Perl searches 'site' first, so use that
-- ref. INSTALLDIRS in Makefile.PL
-- thanks to Robert Sedlacek for patch
Father Chrysostomos [Mon, 24 Sep 2012 23:24:54 +0000 (16:24 -0700)]
[perl #77240] Don’t warn for --subname
Father Chrysostomos [Mon, 24 Sep 2012 23:08:07 +0000 (16:08 -0700)]
[perl #77094] Stop printf +() from reading past SP
printf with an empty list was reading past the end of the stack and
using whatever it found as its format. If given an empty list, it
should treat the format as "".
Father Chrysostomos [Mon, 24 Sep 2012 15:46:56 +0000 (08:46 -0700)]
Don’t crash with existent but undefined &DB::DB
This is a follow-up to
432d4561c48, which fixed *DB::DB without
&DB::DB, but not &DB::DB without body.
Father Chrysostomos [Mon, 24 Sep 2012 06:56:40 +0000 (23:56 -0700)]
A better fix for leaking array assignment
Instead of filling up the mortals stack with as many SVs as there are
elements, just call get-magic before creating the new SV.
(This is not so easy for hashes, as we have keys as well, and
hv_common always calls get-magic on keys.)
See commits
9c744f4f4d7 and
39984de3a8, which fixed leaking bugs, but
inefficiently.
Father Chrysostomos [Mon, 24 Sep 2012 16:36:11 +0000 (09:36 -0700)]
Fix C++ build
Father Chrysostomos [Mon, 24 Sep 2012 06:47:57 +0000 (23:47 -0700)]
[perl #97958] Make reset "" match its docs
According to the documentation, reset() with no argument resets pat-
terns. But reset "" and reset "\0foo" were also resetting patterns.
While I was at it, I fixed embedded nulls, too, though it’s not likely
anyone is using this. I could not fix the bug within the existing API
for sv_reset, so I created a new function and left the old one with
the old behaviour. Call me pear-annoyed.
Jesse Luehrs [Mon, 24 Sep 2012 05:29:06 +0000 (00:29 -0500)]
don't crash with -d if DB::DB is seen but not defined [perl #114990]
Father Chrysostomos [Sun, 23 Sep 2012 19:42:15 +0000 (12:42 -0700)]
[perl #107000] Don’t leak if hh copying dies
When %^H is copied on entering a new scope, if it happens to have been
tied it can die. This was resulting in leaks, because no protections
were added to handle that case.
The two things that were leaking were the new hash in hv_copy_hints_hv
and the new value (for an element) in newSVsv.
By fixing newSVsv itself, this also fixes any potential leaks when
other pieces of code call newSVsv on explosive values.
Father Chrysostomos [Sun, 23 Sep 2012 13:02:58 +0000 (06:02 -0700)]
[perl #97466] Stop defined from propagating ref cx too far
Chris 'BinGOs' Williams [Sun, 23 Sep 2012 10:03:28 +0000 (11:03 +0100)]
Update Unicode-Normalize to CPAN version 1.15
[DELTA]
1.15 Sun Sep 23 10:43:14 2012
- perl 5.11.0 or later: Install to 'site' instead of 'perl'
(see [rt.cpan.org #79801])
Chris 'BinGOs' Williams [Sun, 23 Sep 2012 10:01:23 +0000 (11:01 +0100)]
Update Unicode-Collate to CPAN version 0.90
[DELTA]
0.90 Sun Sep 23 10:42:26 2012
- perl 5.11.0 or later: Install to 'site' instead of 'perl'
(see [rt.cpan.org #79800])
Chris 'BinGOs' Williams [Sun, 23 Sep 2012 09:57:38 +0000 (10:57 +0100)]
Sync versions of Module-CoreList and Exporter in Maintainers.pl
Father Chrysostomos [Sun, 23 Sep 2012 01:48:50 +0000 (18:48 -0700)]
Increase $B::Deparse::VERSION to 1.18
Father Chrysostomos [Sun, 23 Sep 2012 00:54:12 +0000 (17:54 -0700)]
[perl #94490] const fold should not trigger special split " "
The easiest way to fix this was to move the special handling out of
the regexp engine. Now a flag is set on the split op itself for
this case. A real regexp is still created, as that is the most
convenient way to propagate locale settings, and it prevents the
need to rework pp_split to handle a null regexp.
This also means that custom regexp plugins no longer need to handle
split specially (which they all do currently).
Father Chrysostomos [Sun, 23 Sep 2012 00:26:48 +0000 (17:26 -0700)]
regexp.h: Correct comment
RXf_SKIPWHITE is for split " ", which is special, *not* for split / /.
Father Chrysostomos [Sat, 22 Sep 2012 19:06:45 +0000 (12:06 -0700)]
Stop array assignment from leaking on croak
This made a to-do test in sort.t pass, but adventitiously, so I modi-
fied it to fail again.
Father Chrysostomos [Sat, 22 Sep 2012 14:12:04 +0000 (07:12 -0700)]
Stop hash assignment from leaking on croak
Father Chrysostomos [Sat, 22 Sep 2012 05:01:19 +0000 (22:01 -0700)]
Free iterator when freeing tied hash
The current iterator was leaking when a tied hash was freed or
undefined.
Since we already have a mechanism, namely HvLAZYDEL, for freeing
HvEITER when not referenced elsewhere, we can use that.
Father Chrysostomos [Sat, 22 Sep 2012 01:23:20 +0000 (18:23 -0700)]
Don’t leak deleted iterator when tying hash
Father Chrysostomos [Sat, 22 Sep 2012 21:46:29 +0000 (14:46 -0700)]
Oops. make regen
Father Chrysostomos [Sat, 22 Sep 2012 20:17:20 +0000 (13:17 -0700)]
Add a #! line to config_h.SH
It will get one automatically the next time config_h.pl is run, but
that time hasn’t come yet. :-)
Sawyer X [Sat, 22 Sep 2012 13:12:26 +0000 (16:12 +0300)]
add to authors
Sawyer X [Sat, 22 Sep 2012 12:48:09 +0000 (15:48 +0300)]
add shebangs where missing
Sawyer X [Fri, 21 Sep 2012 00:44:38 +0000 (03:44 +0300)]
test for files that have exec bit but no shebang
Father Chrysostomos [Sat, 22 Sep 2012 14:13:36 +0000 (07:13 -0700)]
[perl #96230] Stop qr// from reusing last pattern
qr// should not be using the last-successful pattern, because it is
"(?^:)", not the empty pattern. A stringified qr// does not use the
last-successful pattern.
Father Chrysostomos [Sat, 22 Sep 2012 05:44:00 +0000 (22:44 -0700)]
Let qr.t run from the top level
Father Chrysostomos [Sat, 22 Sep 2012 05:43:34 +0000 (22:43 -0700)]
qr.t: Load test.pl in BEGIN
so lazy people like me can omit parentheses
Father Chrysostomos [Fri, 21 Sep 2012 04:31:15 +0000 (21:31 -0700)]
hv.c: comment typo
H.Merijn Brand [Sat, 22 Sep 2012 09:59:25 +0000 (11:59 +0200)]
Add #!/bin/sh when re-ordering config_h.SH
Also add a small comment to indicate the use of this script
Based on
Subject: [PATCH] Giving config_h.SH a shebang via Porting/config_h.pl
From: Sawyer X <xsawyerx@gmail.com>
Date: Fri, 21 Sep 2012 21:15:43 +0300
Message-ID: <
505CAECF.1060600@gmail.com>
Florian Ragwitz [Fri, 21 Sep 2012 14:50:15 +0000 (10:50 -0400)]
We don't want statistics for every single blead release
Florian Ragwitz [Thu, 20 Sep 2012 13:05:36 +0000 (09:05 -0400)]
The repository is called perlweb
Nicholas Clark [Fri, 21 Sep 2012 10:22:27 +0000 (12:22 +0200)]
Remove a couple of tentacles from MiNT missed by commit
cd86ed9d430a95bb.
Nicholas Clark [Thu, 20 Sep 2012 10:04:24 +0000 (12:04 +0200)]
Remove the MPE/iX port.
MPE/iX was a business-oriented minicomputer operating system made by
Hewlett-Packard. Support from HP terminated at the end of 2010.
Colin Kuskie [Sat, 15 Sep 2012 07:53:57 +0000 (00:53 -0700)]
Refactor t/run/switcha.t to use test.pl instead of making TAP by hand.
Steve Hay [Thu, 20 Sep 2012 23:25:03 +0000 (00:25 +0100)]
Restore mymalloc build with ithreads
Broken by commit
7cd83f6573.
Father Chrysostomos [Thu, 20 Sep 2012 21:48:48 +0000 (14:48 -0700)]
Increase $File::Glob::VERSION to 1.18
Father Chrysostomos [Thu, 20 Sep 2012 21:25:38 +0000 (14:25 -0700)]
[perl #114984] Glob.xs: Extend stack when returning
If a pattern passed to File::Glob consists of a space-separated list
of patterns, the stack will only be extended by doglob() enough for
the list returned by each subpattern. So iterate() needs to extend
the stack before copying the list of files from an AV to the stack.
This fixes a regression introduced in 5.16.0.
Father Chrysostomos [Thu, 20 Sep 2012 16:56:18 +0000 (09:56 -0700)]
[perl #107002] No warnings test for require a::b+1
This used to produce an erroneous ambiguity warning. The . case
stopped warning in 5.12.0. The + case stopped warning earlier today
with commit
c31f6d3b.
Father Chrysostomos [Wed, 4 Jul 2012 19:51:31 +0000 (12:51 -0700)]
pp_hot.c: Clean up after the prev commit
Even before that it was more complicated than necessary, as
SvPV_nomg_const never returns null.
Father Chrysostomos [Thu, 20 Sep 2012 15:56:38 +0000 (08:56 -0700)]
[perl #105922] Allow any string before ->meth
The rules for filtering out what do not look like package names are
not logical and disallow valid things like "::main", while allowing
q"_#@*$!@*^(".
This commit simply lets any non-empty string be used as a package
name. If it is a typo, you’ll get an error anyway. This allows
autobox-style calls like "3foo"->CORE::uc, or even "3foo"->uc if you
set up @ISA first.
I made an exception for the empty string because it messes up caches
somehow and causes subsequent method calls all to be called on the
main package. I haven’t looked into that yet. I don’t know whether
it’s worth it.
The changes to the tests in cpan/Test-Simple have been submit-
ted upstream.
Ricardo Signes [Thu, 20 Sep 2012 16:36:48 +0000 (12:36 -0400)]
...and we have a 5.17.9 volunteer
Ricardo Signes [Thu, 20 Sep 2012 16:26:31 +0000 (12:26 -0400)]
release schedule updates
Father Chrysostomos [Thu, 20 Sep 2012 13:24:25 +0000 (06:24 -0700)]
[perl #105924] require 1 << 2
Setting PL_expect after force_next has no effect, as force_next
(called by force_version and force_word) picks up the current value of
PL_expect and arranges for it to be reset thereto after the forced
token is force-fed to the parser.
The KEY_require case should be setting PL_expect to XTERM (as it
already does) when there is no forced token (version or bareword),
because we expect a term after ‘require’, but to XOPERATOR when
there is a forced token, because we expect an operator after that
forced token.
Since the PL_expect assignment has no effect after force_next, we can
set it to XOPERATOR before calling potentially calling force_next, and
then to XTERM afterwards.
Loop exits had the same bug, so this fixes them all.
Nicholas Clark [Thu, 20 Sep 2012 08:20:35 +0000 (10:20 +0200)]
Eliminate the vestigial comment "magical thingies" from intrpvar.h
The original comment "magical thingies" was added to perl.c by commit
8ebc5c0145d2e355 in Jan 1997. It is above code which frees 4 interpreter-
global SVs in perl_destruct.
The comment "magical thingies" was in intrpvar.h since the file was created
by commit
49f531dad558d800 on 29 Nov 1997. At that time, it was followed by
a block of 13 relevant interpreter global variables. However, by commit
d4cce5f1785350c2 (30 Nov 1997) all bar two were now in other places, mostly
in thrdvar.h. With the abolition of PL_formfeed, the comment now annotates
just one "magical" thingy, PL_basetime, which isn't even one of the SVs
freed at the analogous location in perl.c. Hence the comment adds no value.
Nicholas Clark [Thu, 20 Sep 2012 08:00:35 +0000 (10:00 +0200)]
Use gv_fetchpvs() instead of gv_fetchpv(), and GV_ADD, not TRUE.
This avoids a needless strlen(), and corrects a classic usage error for the
gv_fetch*() functions.
Enache Adrian [Sat, 5 Jul 2003 19:08:07 +0000 (22:08 +0300)]
Get rid of PL_formfeed.
$^L is neither a magical variable, nor a normal one (like $;) but
it's just a little bit special :)
This patch removes PL_formfeed - IMHO, an extra gv_fetchpv per page
when using formats isn't going to cause a sensible speed regression.
I suppose that removing the intrpvar.h hunk from the patch is enough
to keep binary compatibility - unless someone used PL_formfeed from
an XS module.
[with regen.pl run as noted by the author, and an additional change to
perl.c to remove the reference to PL_formfeed added soon after this patch
was sent]
Nicholas Clark [Wed, 19 Sep 2012 20:55:37 +0000 (22:55 +0200)]
For backcompat, B::formfeed can use gv_fetchpvs() if there is no PL_formfeed.
Father Chrysostomos [Thu, 20 Sep 2012 05:03:55 +0000 (22:03 -0700)]
op.c: Disentangle apply_attrs_my from apply_attrs
apply_attrs consisted of a top-level if/else conditional upon a bool-
ean argument. It was being called with a TRUE argument in only one
place, apply_attrs_my. Inlining that branch into apply_attrs_my actu-
ally reduces the amount of code slightly.
Father Chrysostomos [Thu, 20 Sep 2012 04:53:51 +0000 (21:53 -0700)]
[perl #114764] Stop my vars with attrs from leaking
S_apply_attrs was creating a SV containing a stash name, that was
later to be put in a const op, which would take care of freeing it.
But it didn’t free it for a my variable, because the branch where that
const op was created didn’t apply. So move the creation of that SV
inside the branch that uses it, otherwise it leaks. This leak was the
result of commit
95f0a2f1ffc6.