Fix for attachment count in EXT_color_write_enable tests.

Affects:
dEQP-VK.pipeline.*.color_write_enable_maxa.*

Components: Vulkan

VK-GL-CTS issue: 3759

Change-Id: I104166abcb8169a43c6a4dc959b085585d4e2489

Fix maxImageView(MipLevels/ArrayLayers) bug in SC

Certain tests request MAX_UINT32 number of mipmap levels and array
layers, which breaks VU and ends up failing the device creation.
This change resolves the issue by convert VK_REMAINING* values
into the device-specific maximums.

Components: Vulkan

VK-GL-CTS issue: 3622

Affects:
dEQP-VKSC.*

Change-Id: I3135f93a21d46cb8be00923a933f0645ead31c14

Fix vkwsi Display control tests

Tests that attempt to interact with display via the display
control extension must not be run when other windowing systems
have display access.

Return NotSupported if Display is unavailable because the
windowing system has access.

Affects:
  dEQP-VK.wsi.display_control.display_power_control
  dEQP-VK.wsi.display_control.register_display_event

Components: Vulkan
VK-GL-CTS issue: 3804

Change-Id: I59b78cf1dc8089d1741e1b23bc7391d30c85bebd

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main

Change-Id: If28f029620cb8af4b699c3979a95f5e492ce62ac

Add image format in 2d_view_of_3d compute tests

The fragment version of these tests was already giving the format in the
shader, so adding it for the compute variant means that the test can run
on cores that don't support StorageImageWriteWithoutFormat.

Components: Vulkan
Affects: dEQP-VK.pipeline.*.image_2d_view_3d_image.compute.*

Change-Id: I34f4deace5ba4fbcb6e669a98dc3314ddd6b7ef5

Refix extension data for EXT_texel_buffer_alignment

The original fix was broken by the SC merge, so this reapplies change
0e4b820 to up-to-date branches (that is, those following the merge).

VK-GL-CTS issue: 3564
Components: Framework, Vulkan
Affects: dEQP-VK.*

Change-Id: If1873b8292f1e79ef557876ebb7d8d9cf9d7de83

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ib544f0b79e3a27eb6892932f6d8cff817d6dcb08

Fix unused result in OpPtrEqual OpPtrNotEqual tests

These tests were storing the result of a prior comparison, instead of
the result of the final "Pointers to individual columns of row-major
matrices" test.

Components: Vulkan

Affects:
dEQP-VK.spirv_assembly.instruction.spirv1p4.opptrequal.simple_variable_pointers_ptr_equal
dEQP-VK.spirv_assembly.instruction.spirv1p4.opptrnotequal.simple_variable_pointers_ptr_not_equal

Change-Id: I0320d887b1f9701037e7df6a605e51236892bbd8

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I4746c7728a783911f57a4a0307355384e5782e1f

Modify Store Op setting

Set up VK_ATTACHMENT_LOAD_OP_DONT_CARE on VkAttachmentStoreOp. If m_numRenderPass equal 1.
Set up VK_ATTACHMENT_LOAD_OP_STORE on VkAttachmentStoreOp. If m_numRenderPass is greater than 1.

Affects:
dEQP-VK.renderpass2.depth_stencil_resolve.*

Components: Vulkan

Change-Id: I226336ee9eeac5a9db14817cc8d1bec2f881ebbb

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I860e6b43aca52008fecc755bd0a377dca99e8927

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ia0fe8e8eb8f699fdcb15c85d129f5f237a60b02a

Fix incorrect staging buffer size calculation

The dEQP-VK.api.image_clearing.* tests use a staging buffer to
pre-clear the images to a known value before each test. The size
of this buffer was previously determined by taking the size from the
VkMemoryRequirements obtained for the image. This fails if the size
required to store the image is less than the size required to store
the raw texel data in the buffer, which is later to be copied into
the image. This commit changes that and instead computes the size
of the staging buffer based on image extent, format and number of
layers.

Affects:
dEQP-VK.api.image_clearing.*

Components: Vulkan

VK-GL-CTS issue: 3809

Change-Id: I2b74697d54e11ddd7598299d57d02205bd2571d5

Add missing calls to vkResetCommandBuffer

Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.header_bottom_address.*

Components: Vulkan
VK-GL-CTS Issue: 3802

Change-Id: Ieaf337e028db0bb64c3c954210a75bdda7e2e7b8

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I3f5a753e75050a8c66e4737bbd3eff861138ea60

Fix missing support check in rtp test

The binding descriptor AS tests for rtp stage missed support check
when maxRayRecursionDepth equals 1

Affects:
dEQP-VK.binding_model.descriptor_update.acceleration_structure.
ray_tracing*

Components: vulkan

VK-GL-CTS issue: 3700

Change-Id: I8f2886aa60de2855799b43c27a853e903955f422

Fix image feature checking in YCbCr view tests

The tests were using midpoint chroma sampling without checking for
support.

Components: Vulkan
VK-GL-CTS issue: 3601
Affects: dEQP-VK.ycbcr.plane_view.*

Change-Id: Iffd248b40c8d3c71cb2be28ad4fe7457bad25fa9

Fix control flow in SPIR-V test cases

Adapts three graphicsfuzz test cases to reflect changes in the SPIR-V
specification that tighten the rules for structured control flow.

Component: Vulkan

VK-GL-CTS Issue: 3612, 3613, 3615

Affected tests:
dEQP-VK.graphicsfuzz.control-flow-switch
dEQP-VK.graphicsfuzz.cov-dead-branch-func-return-arg
dEQP-VK.graphicsfuzz.nested-for-loops-with-return

Change-Id: I3b581dcdc685717421c7c7a7299bf378b3cc3b01

Fix checkSupport for pipeline bind point tests

Ray tracing tests are unconditionally skipped if VK_KHR_push_descriptor
or VK_KHR_descriptor_update_template is not supported by the
implementation, as the support check logic is mistakenly checking only
the graphics and compute pipeline usages. Fix the support checks by
first checking which pipelines are used in the test.

Affects:
dEQP-VK.pipeline.monolithic.bind_point.*

Components: Vulkan

VK-GL-CTS issue: 3820

Change-Id: Ic6f0b78ca2d4d5415db03ca1186100494201548f

Merge vk-gl-cts/github-main into vk-gl-cts/main

Change-Id: Ic174cec9274d4a81a4e5a55d8018041fd482e0c0

Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 to vk-gl-cts/main" into main

Fix duplicated file in CMakeLists

vktImageExtendedUsageBitTests cpp file is added twice instead of hpp

Components: Vulkan

VK-GL-CTS issue: 3780

Change-Id: I917d09e26554f9c01b73287fe5a6f9a7a77d5998

Add back InvalidApiVersion test for Vulkan SC

Vulkan SC may only fail with VK_ERROR_INCOMPATIBLE_DRIVER if an incompatible
variant is requested.

Affects tests:
dEQP-VK.api.device_init.create_instance_invalid_api_version.basic
dEQP-VKSC.api.device_init.create_instance_invalid_api_version.basic

Components: Vulkan VulkanSC

VK-GL-CTS Issue: 3753

Change-Id: I9064cd814b3870d9514c964ed0e5e3b1c94a4708

Fix initial color attachment layout in conditional rendering tests

Color attachments were never properly transitioned out of the undefined
layout into the general layout as specified in the render pass.

Affected tests:
dEQP-VK.conditional_rendering.*

Components: Vulkan
VK-GL-CTS issue: 3781

Change-Id: Iaa2dbe3badaa1ed6ab49c02259c7d0a626e60fde

Test additional robustBufferAccess requirements for vertex attribute

These tests verify that out of bounds vertex attribute access returns
invalid values within the same binding with different buffer memory
layouts, including both zero and non zero binding stride.

VK-GL-CTS Issue: 3067

New tests:

dEQP-VK.robustness.robustness1_vertex_access.out_of_bounds_*

Components: Vulkan
Change-Id: I727610ba60acc392af3ceb9ff72cc4325fccdb04

Remove unneeded check for graphicsPipelineLibraryFastLinking

Graphics pipeline tests using libraries that are linked into final
pipelines without using CREATE_LINK_TIME_OPTIMIZATION_BIT_EXT were
checking if the graphicsPipelineLibraryFastLinking property was set to
true. This is not needed, because

(a) it's a property and not a feature and
(b) linking pipelines without link-time optimization is always allowed.

This commit removes the check and allows more graphics pipeline library
tests run on a wider variety of implementations.

In addition, checkPipelineLibraryRequirements was checking if the
implementation supported VK_KHR_pipeline_library, but this type of
dependencies are checked in dEQP-VK.info.device_extensions.

Affected tests:
dEQP-VK.*fast_linked_library*

VK-GL-CTS issue: 3743
Components: Vulkan

Change-Id: I4c67c195b87a4ab1c24d5d28caf54ea565551b14

Test sRGB storage image writes

This commit adds coverage for "formatless" storage image writes
of sRGB images.

VK-GL-CTS issue: 3673

New Tests:
dEQP-VK.image.store.without_format.*.*_srgb
dEQP-VK.image.format_reinterpret.*.*_srgb_*
dEQP-VKSC.image.store.without_format.*.*_srgb
dEQP-VKSC.image.format_reinterpret.*.*_srgb_*

Components: Vulkan
Change-Id: I9b75ec7d5d08fecf3e03d4123cc7455fb56d2b1d

Add random tests for dynamic rendering

VK-GL-CTS Issue: 3475

New tests:

dEQP-VK.dynamic_rendering.random.*

Components: Vulkan
Change-Id: If2f6b0945e5bf855a9510968a1bc19b62c1e9c47

Add mandatory features check for VK_EXT_subpass_merge_feedback

Affects:
dEQP-VK.info.device_mandatory_features

Components: Vulkan
Change-Id: I8013c812045b3b30a1c0c97ddb71fb7c7a26b8fc

Add tests using maximum index value with primitive restart disabled

These new tests make sure primitive restart is not triggered when
using a maximum index value and primitive restart is disabled.

VK-GL-CTS Issue: 3500

New tests:

dEQP-VK.pipeline.*.input_assembly.primitive_restart.*.restart_disabled*

Components: Vulkan
Change-Id: I054ea1a0aefa1ec7f0e2b15233cb02305e0b17b0

Remove duplicate Buffer and Image classes

This CL removes duplicate Buffer and Image class definitions
that have identical implementation with BufferWithMemory and
ImageWithMemory classes.

Affects:
dEQP-VK.compute.basic.*
dEQP-VK.compute.indirect_dispatch.*
dEQP-VK.compute.builtin_var.*
dEQP-VK.conditional_rendering.dispatch.*
dEQP-VK.pipeline.*.spec_constant.*
dEQP-VK.pipeline.*.max_varyings.*
dEQP-VK.pipeline.*.multisample_shader_builtin.*
dEQP-VK.geometry.*
dEQP-VK.image.atomic_operations.*
dEQP-VK.image.astc_decode_mode.*
dEQP-VK.image.extended_usage_bit.*
dEQP-VK.image.texel_view_compatible.*
dEQP-VK.image.image_size.*
dEQP-VK.image.misaligned_cube.*
dEQP-VK.image.load_store_multisample.*
dEQP-VK.image.qualifiers.*
dEQP-VK.image.extend_operands_spirv1p4.*
dEQP-VK.tessellation.*

Components: Vulkan

VK-GL-CTS issue: 3449

Change-Id: I06f0a6e7c8ceb3a97caf7ab18e2cf61c16c31bdc

Fix SHA-1 calculation in delibs

If a message resulted in the last chunk being too small by 8 or less bytes,
the padding was being appended incorrectly.

Change-Id: I3480d02aae8490d464cf483403b4516434328026
Components: Framework

load_store_op_none - tests should disable stencil test

load_store_op_none tests do not disable stencil test, although
the comment says otherwise:

// Preinitialize stencil attachment to 128.
// Use a render pass with load and store ops none for the stencil,
// but disable stencil test which also disables stencil writes.

Affects:
dEQP-VK.dynamic_rendering.suballocation.load_store_op_none*

Components: Vulkan

VK-GL-CTS issue: 3773

Change-Id: I3dc432535aa704b4f5154fb61a26dc5f41a4d5cb

Merge vk-gl-cts/vulkan-cts-1.3.3 to vk-gl-cts/main

Change-Id: I1efc306c54a53f9499fbcc2a0ad66f77220e391d

Add missing 'FREE_DESCRIPTOR_SET' flag to a descriptor set pool

The test seems to test vkFreeDescriptors, however the pool is missing
a flag that is required for that function to be used.

Spec says: VUID-vkFreeDescriptorSets-descriptorPool-00312
descriptorPool must have been created with the VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT flag

Components: Vulkan

VK-GL-CTS Issue: 3779

Affects: dEQP-VK.api.descriptor_pool.zero_pool_size_count

Change-Id: I04c1e67fcbdffa4b0eb1bf7ffbb0231fbe0bc45d

Fix GCC 11 misleading indentation warning

Make it clearer that the assignment is not guarded by the if.

Components: Vulkan

VK-GL-CTS issue: 3555

Change-Id: If03e31c20877d99d8e10620bbda31942023ca13a

Fix aliasing issues for physical device features

Make sure we only pass in one instance of the following feature
structs (including aliases) when getting supported features from a
physical device:

- VkPhysicalDeviceDescriptorIndexingFeatures
- VkPhysicalDeviceBufferDeviceAddressFeatures

Affects:
dEQP-VK.info.device_mandatory_features

Components: Vulkan

VK-GL-CTS issue: 3792

Change-Id: I290a46f0c5d220f616237063253bfb7be6d1f026

Always include the required closest hit shader when tracing rays

The tests added in https://gerrit.khronos.org/c/vk-gl-cts/+/7865
neglected to set the SBT entry for a closest hit shader even
though the ray generation shader was calling traceRayEXT().
This can cause the implementation to dereference NULL data
and crash when it attempts to execute a hit shader.

This CL modifies the ray tracing pipeline and SBR to always have a
closest hit shader defined.

Affects:

dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*

Components: Vulkan

VK-GL-CTS issue: 3790

Change-Id: Ied3265639b6b5ab45998ac02d361106e14fa3808

Fix regresion in FSR tests

FSR tests were recently repeated few times - for pipeline libraries
and for secondary command buffers in dynamic rendering cases. As a
result there were cases where delayed group creation with
createChildren had another nested call to createChildren. This CL
modifies code to use only tow delayed group creation calls - for
renderpass2 and dynamic_rendering sub-groups.

Components: Vulkan

VK-GL-CTS issue: 3760

Affects:
dEQP-VK.fragment_shading_rate.*

Change-Id: If8da1532c0c924ef812ab055de4c71c5b9ba86b4

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ic26b0069d50734146363779c7d7f0362f5d33496

Allow sample counting after multisample coverage

Vulkan specification was modified to allow counting samples
after mutlisample coverage and fragment shading.

The test uses a fragment shader that kills all pixels with
"gl_SampleMask[0] = 0x0" and than verifies the occlusion query results.

This change allows for 0 samples to be counted by a query in case
of `early_fragment_tests` mode being used. The QualityWarning is emitted
in this case.

Components: Vulkan

Vulkan Issue: 3085
VK-GL-CTS Issue: 3778

Affects: dEQP-VK.fragment_operations.early_fragment.sample_*

Change-Id: I86cf17b2d8849a9d543e8447569ac808928c30e6

Early fragment depth test rounding issue bug fix

Small correction to vertex coordinates to avoid unexpected depth value
roundings.

Components: Vulkan

VK-GL-CTS Issue: 3732

Affects:
dEQP-VK.fragment_operations.early_fragment.early_fragment_tests_depth
dEQP-VK.fragment_operations.early_fragment.no_early_fragment_tests_depth

Change-Id: Ifa8f92a2c2e18acb4122a10498c9c21e7990e9f6

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I300e223f9f8743cc0579547d535f8af333caeada

Fix synchronization in compressed texture sampling tests

Tests sampling compressed textures contained multiple synchronization
errors, most of them related to:

* Render pass load operations not properly synchronized with previous
  writes.
* Barriers that did not properly synchronize all layers of a cube map.
* Improper initial layout transitions.

Affected tests:
dEQP-VK.image.sample_texture.*
dEQP-VKSC.image.sample_texture.*

VK-GL-CTS issue: 3763
Components: Vulkan

Change-Id: I2f2572a7f6a05c55c904014fafc3a655dbb03ee3

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I0f96a1f42fc6069ae185225b3794e37eea200a74

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ia16eafb924ac851fcda00d605e608af190b56997

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I1c3fa921a070b79cbcd31c213cfbb651c4d07530

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Id3635ffcac963dbd16ed489269205e90f92aa6a0

Change direction of IgnoreIntersection/TerminateRay tests

Changes the ray direction of the IgnoreIntersection and
TerminateRay tests such that it shoots the ray into the
center of the triangle, rather than exactly at one of
its edges.

Impacts tests:
dEQP-VK.ray_tracing_pipeline.misc.Op*

Components: Vulkan
VK-GL-CTS issue: 3771

Change-Id: Ic36cc125238323eb367412f220afe8907f700c8d

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I7ab0e9094c250af82f5aa28183fe5759e96f3e5f

Merge pull request #330 from polarina/maxiterations

Fix copy&paste typo in test name for MaxIterations loop control

Fix image feature checking in YCbCr filtering tests

The tests were using linear chroma filtering without checking for
support.

Components: Vulkan

Affects:
dEQP-VK.ycbcr.filtering.*

Change-Id: I2619667b8ebf78f3c2c1880501925a1348305b64

Fix copy&paste typo in test name for MaxIterations loop control

Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main

Merge "Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main" into main

Merge vk-gl-cts/github-main into vk-gl-cts/main

Change-Id: I0c14ad0e023537bfdd81e6a108cd3f89f5482f42

Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main

Change-Id: I9f1a96c9da4a259684498d383f33c98b5000fde4

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8

Change-Id: Ie06650ccb16867acefd03d8c053b2e4996f7bc53

Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main

Change-Id: Ie091edca0cd513ffb13143d2eb6dd7fd037edef4

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: I5eee40dacbbc0fd7b95c06a9e6f434f45ca8ecf9

Fix signed integer overflow in framebuffer fetch tests

VK-GL-CTS Issue: 3473

Affects:

dEQP-GLES31.functional.shaders.framebuffer_fetch.framebuffer_format.*

Components: OpenGL ES
Change-Id: I5c971db231c9ea95b413df417e5cb2421aa857e1

Add tests for mul extended using different bit sizes

Previously only 32bit variants of Op[S/U]MulExtended were tested.
This change tests all 8bit, 16bit, 32bit, and 64bit options.

VK-GL-CTS Issue: 3632

New tests:

dEQP-VK.spirv_assembly.instruction.compute.mul_extended.*

Components: Vulkan
Change-Id: I498062688cd738e9a019a6fa4df1c12ade1863ec

Test shader group handle alignment

This commit adds a new test group that verifies the advertised supported
shader group handle alignment in shader binding tables works as
expected.

The new tests create shader binding tables with shader record buffers
that act as padding bytes to achieve the desired alignments. These
shader record buffers are also read from ray tracing shaders and
verified to have the right contents.

New tests:
dEQP-VK.ray_tracing_pipeline.shader_binding_table.handle_alignment.*

Components: Vulkan
VK-GL-CTS issue: 3298

Change-Id: Id2d4f11ed2fcf56ce30e1a5896d38416cbaf1b82

Test XFB queries without shader writes

Transform feedback outputs should be captured even if they are never
written to. Add variants of existing query tests that omit shader
writes and check that the XFB query counters are still incremented.

New tests:
dEQP-VK.transform_feedback.simple.*_omit_write_*

Affects:
dEQP-VK.transform_feedback.simple.*

Components: Vulkan

VK-GL-CTS issue: 3624

Change-Id: I001f331eea8ff8e93075f60a890ebd5cb95f456b

Remove duplicate checkPipelineLibraryRequirements call

Affected tests:
dEQP-VK*.fragment_shading_rate.*.basic.*

Change-Id: If29cf6fb2e0feb95f9c2385f7ca0bb00c72db547
Components: Vulkan

Disable IPC primitives on android

This change disables the IPC primitives on Android.

Affects: none
VK-GL-CTS issue: 3766
Components: Framework

Change-Id: I96aa21b4ac364f35f2599ada0ba30212bd2df91a

Mix dynamic line stipple and dynamic primitive topology

On some implementations, dynamic topology can interact with dynamic line
stipple, affecting the state of it. This commits adds a new set of tests
that set the dynamic line stipple values, then switch dynamic topologies
and draw using them before finally switching to the right topology again
and drawing, so as to check the dynamic topology changes have not
affected line stipple values.

New tests:
dEQP-VK.rasterization.primitives.dynamic_stipple_and_topology.*

Affected tests:
dEQP-VK.rasterization.*

Components: Vulkan
VK-GL-CTS issue: 3667

Change-Id: Ia1930186ef3a534280cf040e1cd706a460fd9765

isExtensionSupported renaming

The purpose of renaming function name to isExtensionStructSupport
is to make it a clearer emphasis on the fact that extension structure
of passed  extension name was promoted in the core and is not guaranteed
to be supported by the device because of the optional nature of some extensions.
In most cases, the function has been replaced with more appropriate
isDeviceFunctionalitySupported.

Components: Vulkan

VK-GL-CTS Issue: 3149

Affect tests: *dEQP-VK.*

Change-Id: Ic0922bee2f1c178e5aaee9065a1d91260477410a

Additional tests for UPDATE_AFTER_BIND

UPDATE_AFTER_BIND was tested with descriptor write updates
but not with copies. This change extends descriptor_copy
tests to check also UPDATE_AFTER_BIND.
This change also moves all case requirement checks to
checkSuppport function.

Components: Vulkan

VK-GL-CTS issue: 3638

Affects:
dEQP-VK.binding_model.descriptor_copy.*

New tests:
dEQP-VK.binding_model.descriptor_copy.graphics_uab.*

Change-Id: Ibc45f4f8c7550edc7a974dd33a4dd245c51105a9

Add testing for VK_EXT_subpass_merge_feedback

This commit adds test cases for the VK_EXT_subpass_merge_feedback
extension.

Components: Vulkan

New Tests:

dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.single_subpass
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.single_subpass_disallow_renderpass_merge
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.three_subpasses
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.three_subpasses_disallow_renderpass_merge
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.three_subpasses_disallow_subpass_merge
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.many_subpasses

Change-Id: I8d969f4069a828756aae74339aba88cb70074b3f

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main

Change-Id: I867ce0fbe8b02eca111330e6d7d9625aee25e41c

Set pipeline layout for fragment_shading_rate tests

The Vulkan spec requires there be a valid pipeline layout, even
when pipeline libraries are being used.

Components: Vulkan

Affects:

dEQP-VK.fragment_shading_rate.*.pipeline_library.*

VK-GL-CTS issue: 3764

Change-Id: I83486240c2e5e15f13a5d9610ee66d2e37ef06b9

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I8bda2888165efe5813666980c95ab76b2481d7f1

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ie9da086ce3cfaa7b9aa768fdf700905f0512f446

Synchronize clears and reads in transient attachment tests

These tests use a render pass with no draw operations to clear a color
or depth/stencil attachment and use it as an input attachment in a
second render pass, but they were missing a barrier to synchronize both
operations.

Affected tests:
dEQP-VK.fragment_operations.transient_attachment_bit*

Components: Vulkan
VK-GL-CTS issue: 3717

Change-Id: Ifcd1817fa631973e4f74866546dfad4e021a16bc

Merge pull request #326 from DadSchoorse/VK_EXT_non_seamless_cube_map

Vk ext non seamless cube map

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I5830bb9dc3d462de2df81a0af118a40953315102

fix dEQP-VK.subgroups.size_control.compute.required_subgroup_size_*_require_full_subgroups_spirv16

the spirv16 cases weren't fixed in an earlier change which addressed the same problem

Affects:
dEQP-VK.subgroups.size_control.compute.required_subgroup_size_max_require_full_subgroups_spirv16
dEQP-VK.subgroups.size_control.compute.required_subgroup_size_min_require_full_subgroups_spirv16

Change-Id: Ic70024e080cff8c824ffa126774f27f2d378c52d

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I4ce72e2de0508fd24ef31b5cf2ae190ad73ad2bc

Tests for VK_EXT_non_seamless_cube_map

Consistently use tcu::Samplers with seamlessCubeMap to match core Vulkan

Update Vulkan framework for VK_EXT_non_seamless_cube_map

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ieac8dac110e196cd1d83bff11be45fdec6a72f2b

Add missing barrier in ray tracing tests

When running the CPU build acceleration structure tests, no acceleration
structure commands are recorded, resulting in a missing execution
barrier. Add the missing barrier between vkCmdClearColorImage and
vkCmdTraceRaysKHR. This barrier is the same barrier used in the
equivalent ray query tests.

Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*

Components: Vulkan

VK-GL-CTS issue: 3750

Change-Id: Ib9fc047e6e3a45165e5028846f8f10e96aca53c1

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: If7368ce72c121d0642e902c08c0f79d6c99ad73c

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I238c6805dbba58a1dddb7639663cd9c9b83b7f64

stop crashing in gl tess isolines tests if xfb is broken

if no data is returned, don't try to count the data since it will
trigger a null deref and crash

Affects:
KHR-GL46.tessellation_shader.single.isolines_tessellation

Change-Id: I4f218c033c2a7291796eb25f4e0ae159b9e054b9

Merge "Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3" into vulkan-cts-1.3.3

Fix Android build

Fixes copy & paste error.
Disables Sys V shared memory for Android as it is unsupported.

Components: Vulkan

Affects:
*

VK-GL-CTS issue: 3756

Change-Id: I45a24916e57a8c77a1fb0e88e89927ca34069b52
(cherry picked from commit c51f848880bf03bd8c303a34aee7d92185185a61)

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main

Change-Id: Ib8d390597800227dfd8133588700a1a58d3d8c37

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Icf1eec1fba1f1272f424878113e510fa6fb8a92a

Forbid implicit cast from Move<T> to bool

Take the following code:

  Move<VkPipelineLayout> smartLayout = ...;
  VkPipelineLayout rawLayout = smartLayout;

That builds and applies the following implicit conversions:

  Move<T> -> bool -> VkPipelineLayout

Which doesn't make any sense (the raw handle ends up having value "1")
and it's arguably an easy typo to make, when the second line should
actually have been one of:

  VkPipelineLayout rawLayout = *smartLayout;
  VkPipelineLayout rawLayout = smartLayout.get();

This commit disallows the implicit conversions from Move<T> to bool and
makes the typo fail compilatoin on purpose.

It also fixes one instance of such typo in the affected test, which was
causing issues when implementing graphics pipeline libraries in RADV.

Note the test also touches vktRenderPassTests.cpp, but the change should
not affect any test result there.

Affected tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.timing.compare_link_times

VK-GL-CTS issue: 3735
Components: Vulkan

Change-Id: Id968a1e74f6246e592257f7b3675c80e3363feaf

Fix extension checks in DRM format modifier tests

Some of the checks for supported extensions made the tests error out
instead of marking them as not supported.

Affected tests:
dEQP-VK.drm_format_modifiers.*

Components: Vulkan
VK-GL-CTS issue: 3720

Change-Id: I47c1f051128e425d5faae3bed5c2830218df4881

Fix device and memory allocation mix-up

compute_transfer dynamic state tests were allocating memory on one
device and binding it to a buffer created on a separate device. This
commit fixes the issue and make sure the right devices and allocators
are always used.

Affected tests:
dEQP-VK.dynamic_state.monolithic.compute_transfer.*

VK-GL-CTS issue: 3727
Components: Vulkan

Change-Id: I8f8aeffd0d4946465af1a600d5f7331e4040638a

Fix Android build

Fixes copy & paste error.
Disables Sys V shared memory for Android as it is unsupported.

Components: Vulkan

Affects:
*

VK-GL-CTS issue: 3756

Change-Id: I45a24916e57a8c77a1fb0e88e89927ca34069b52

Shrink the framebuffer in more graphicsfuzz tests

These are all resolution independent but use large framebuffers and are
executing slowly on some of our low-end platforms.

Components: Vulkan
Affects: dEQP-VK.graphicsfuzz.arr-value-set-to-arr-value-squared
         dEQP-VK.graphicsfuzz.cov-array-copies-loops-with-limiters
         dEQP-VK.graphicsfuzz.cov-blockfrequency-several-for-loops
         dEQP-VK.graphicsfuzz.cov-do-while-negative-iterator-nested-loops-increment-array-element
         dEQP-VK.graphicsfuzz.cov-dummy-function-loop-array-element-increment-never-read
         dEQP-VK.graphicsfuzz.cov-for-array-initializing-modulo
         dEQP-VK.graphicsfuzz.cov-function-loop-condition-variable-less-than-min-itself
         dEQP-VK.graphicsfuzz.cov-function-loop-copy-array-elements-based-on-arguments
         dEQP-VK.graphicsfuzz.cov-function-two-loops-limit-using-arguments-array-element-copies
         dEQP-VK.graphicsfuzz.cov-increment-int-loop-counter-mod-array
         dEQP-VK.graphicsfuzz.cov-initialize-integer-array-variable-divided-by-itself
         dEQP-VK.graphicsfuzz.cov-instruction-simplify-inst-combine-calls-for-compare-function-call-result
         dEQP-VK.graphicsfuzz.cov-integer-minus-one-increased-before-indexing-array
         dEQP-VK.graphicsfuzz.cov-loop-clamp-to-one-empty-condition
         dEQP-VK.graphicsfuzz.cov-loop-condition-bitfield-extract-set-array-elements
         dEQP-VK.graphicsfuzz.cov-loop-condition-divide-by-uniform-always-false
         dEQP-VK.graphicsfuzz.cov-loop-struct-array-field-set-value-self-dependency
         dEQP-VK.graphicsfuzz.cov-nested-functions-struct-arrays-vector-lengths
         dEQP-VK.graphicsfuzz.cov-nested-loop-not-greater-than-increment-array-element
         dEQP-VK.graphicsfuzz.cov-nested-loop-undefined-smoothstep-never-executed
         dEQP-VK.graphicsfuzz.cov-nested-loops-float-bits-to-int-increment-array
         dEQP-VK.graphicsfuzz.cov-nested-loops-global-loop-counter-do-while-accumulate-float
         dEQP-VK.graphicsfuzz.cov-nir-array-access
         dEQP-VK.graphicsfuzz.cov-optimize-phis-for-for-do-while-if-if
         dEQP-VK.graphicsfuzz.cov-optimize-phis-for
         dEQP-VK.graphicsfuzz.cov-register-coalescer-live-intervals-target-instr-info-for-discard-for-discard
         dEQP-VK.graphicsfuzz.cov-scaled-number-nested-loops
         dEQP-VK.graphicsfuzz.cov-set-output-color-function-call-nested-loop
         dEQP-VK.graphicsfuzz.cov-two-loops-global-loop-counter-shift-right-zero-increment-array-element
         dEQP-VK.graphicsfuzz.cov-unused-matrix-copy-inside-loop
         dEQP-VK.graphicsfuzz.cov-value-tracking-selection-dag-negation-clamp-loop
         dEQP-VK.graphicsfuzz.flag-always-false-if
         dEQP-VK.graphicsfuzz.nested-for-break-mat-color

Change-Id: I108ea54ee35f07911f062d89840d2577f2385528

Remove superfluous 'resolution' from graphicsfuzz test

This wasn't referenced and doesn't seem related to the point of the
test, so remove it.

Components: Vulkan
Affects: dEQP-VK.graphicsfuzz.arr-value-set-to-arr-value-squared

Change-Id: I0057ccca5adb841d0c31d9ba06fe38ba70e78ed5

Add KHR-GLESEXT.fragment_shading_rate tests

add basic test and complex test for verify GL_EXT_fragment_shading_rate
extension.
 - GLESEXT.fragment_shading_rate.api.basic
 - GLESEXT.fragment_shading_rate.api.errors
 - GLESEXT.fragment_shading_rate.complex.*
 - GLESEXT.fragment_shading_rate.render_target.*

Change-Id: I6673c0643c038bf4b1e4b717b2916daf4b79a84c

Run DR draw tests with secondary command buffers

Dynamic rendering tests in draw group were replaced with three
sub groups: primary_cmd_buff, partial_secondary_cmd_buff and
complete_secondary_cmd_buff.
* primary_cmd_buff subgroup contains previously existing dynamic
rendering tests where drawing is done in primary command buffer.
* partial_secondary_cmd_buff contains tests where drawing commands
are recorded in secondary command buffer but begin/endRendering
are recorded to primary command buffer.
* complete_secondary_cmd_buff executes tests with secondaries that
completely contain the dynamic render pass.

This change also removes 4 tests that were added 2 years ago:
* static_scissor_framebuffer_border_out
* dynamic_scissor_framebuffer_border_out
* static_scissor_oversized
* dynamic_scissor_oversized
Above tests render outside of the renderArea and are invalid.

Components: Vulkan

VK-GL-CTS issue: 3516

Affects:
dEQP-VK.draw.*

New tests:
dEQP-VK.draw.dynamic_rendering.partial_secondary_cmd_buff.*
dEQP-VK.draw.dynamic_rendering.complete_secondary_cmd_buff.*

Change-Id: If6a0d82b98948f155e9350f841931c329e474b07

Add recipe for amber-verify run mode

Changes build check scripts to include a recipe for checking that amber
device requirements match with what CTS asks for.

Changes amber-verify code to also print out the errors in stderr to make
finding the errors easier by looking at the console log.

Affects: none

Components: Framework
VK-GL-CTS issue: 3368

Change-Id: Id064420425563111ac3e2038dd27d7becdccdcb6