Jeremy Kuhne [Fri, 7 Sep 2018 01:11:06 +0000 (18:11 -0700)]
Add perf tests to System.IO (dotnet/corefx#31552)
* Add perf tests to System.IO
Add tests for measuring format writes for StreamWriter.
* Add a test validating dispatching of format calls when overridden.
Commit migrated from https://github.com/dotnet/corefx/commit/
1e1f421c8e57cbd317800e0a10287488bb05c808
Jeremy Kuhne [Fri, 7 Sep 2018 00:35:52 +0000 (17:35 -0700)]
Fix extract out of directory (dotnet/corefx#32127)
* Fix extract out of directory
Without ensuring a trailing directory separator you cannot compare paths for nesting. `/Foo/Bar` does not contain `/Foo/Barber`, but does contain `/Foo/Bar/Bell`. This adds the separator and tests.
* Skip new test on NetFX
Commit migrated from https://github.com/dotnet/corefx/commit/
a0fcd23ace1c8d692988cd0da4391cf7bf5e0ce6
spshant [Thu, 6 Sep 2018 22:15:10 +0000 (15:15 -0700)]
Merge pull request dotnet/corefx#32128 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26906-06, preview1-26906-01, preview1-26906-02, beta-26906-00, beta-26906-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
d349e8d12df38d2e77bbbf59659f1b07e56cf9dd
Fei Peng [Tue, 4 Sep 2018 22:56:42 +0000 (15:56 -0700)]
Rename CarryLessMultiply to CarrylessMultiply
Commit migrated from https://github.com/dotnet/corefx/commit/
749d932b928ab2125cf2b98473a1bf4cde31ccd0
dotnet-maestro-bot [Thu, 6 Sep 2018 13:02:29 +0000 (06:02 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26906-06, preview1-26906-01, preview1-26906-02, beta-26906-00, beta-26906-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
587b3ecb52c261e0f27b711f303f25a7c93adf11
dotnet-maestro-bot [Wed, 5 Sep 2018 17:37:34 +0000 (10:37 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03205-01, preview1-26905-04, preview1-26905-03, preview1-26905-03, beta-26905-00, beta-26905-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
219a6c71c80ba8b5b06a2a767121a49930f38cd7
Krzysztof Wicher [Wed, 5 Sep 2018 21:07:59 +0000 (14:07 -0700)]
Update TCFullEndElement.cs (dotnet/corefx#32107)
Commit migrated from https://github.com/dotnet/corefx/commit/
f78adfa78f388972e5d64a68187dd540c219f2f6
Wes Haggard [Wed, 5 Sep 2018 21:04:47 +0000 (14:04 -0700)]
Merge pull request dotnet/corefx#31856 from jnm2/document_stateless_struct_breaking_change_rule
Document breaking change rule for stateless structs
Commit migrated from https://github.com/dotnet/corefx/commit/
b1c02c9558c9c2d4b667f372a3f48d8b6a9c2421
jnm2 [Tue, 21 Aug 2018 00:49:36 +0000 (20:49 -0400)]
Document breaking change rule for stateless structs
Commit migrated from https://github.com/dotnet/corefx/commit/
7444297ba077452d87bbbc5a4e5aab38069e2a54
Tanner Gooding [Sun, 26 Aug 2018 02:04:10 +0000 (19:04 -0700)]
Enabling some skipped math and mathf tests
Commit migrated from https://github.com/dotnet/corefx/commit/
5d7f2469f4ef37e6bc6846f85d9ea55570002c8f
Filip Navara [Wed, 5 Sep 2018 14:27:22 +0000 (16:27 +0200)]
Convert GeneralNameAsn to ASNXML generation
This changes the GeneralNameAsn type and all of its field types to ASNXML generated code, fixing the lack of tags on EdiPartyNameAsn in the process.
It also replaces the manual reading of GeneralName in AppleAsnFormatter, reducing the use of the legacy DerSequenceReader type.
Commit migrated from https://github.com/dotnet/corefx/commit/
3e817a4dbed0776dff7f91723906e95237892c0e
Dan Moseley [Wed, 5 Sep 2018 02:44:42 +0000 (19:44 -0700)]
Make flaky serialport test OuterLoop (dotnet/corefx#32104)
Commit migrated from https://github.com/dotnet/corefx/commit/
4a3202082dfa74cd0c47dec1c0d2a8ab44d5fa2c
Marco Rossignoli [Tue, 4 Sep 2018 22:35:41 +0000 (00:35 +0200)]
Add System.Diagnostics.PerformanceData namespace (dotnet/corefx#31474)
* move System.Diagnostics.PerformanceData from netfx
* updates
* use type aliases, fix style, cleanup
* remove CAS attributes
* nit: extralines
* Add tests
* update tests
* update tests
* update tests,use type aliases, cleanup
* address PR feedback
* address some of PR feedback
* address some of PR feedback
* address some of PR feedback
* address PR feedback
* added retry/dispose
* update tests
* try to run new test in isolated process
* revert changes to other tests, add retry on new test
* fix netfx test fail, add comments
Commit migrated from https://github.com/dotnet/corefx/commit/
610e9c82ed930e7473e478ecb96e000a32ff7908
Dan Moseley [Tue, 4 Sep 2018 22:21:28 +0000 (15:21 -0700)]
Fix ServiceController name population perf (dotnet/corefx#32072)
* Fix ServiceController name population perf
* Split tests
* Remove dead field
* Remove new use of DangerousGetHandle
* SafeHandle all the things!
* VSB dotnet/corefx#1
* VSB dotnet/corefx#2
* Fix GLE
* Initialize machineName in ctor
* Test for empty name ex
* Null names
* Inadvertent edit
* Unix build
* Move interop into class
* Reverse SafeHandle for HAllocGlobal
* Fix tests
* Disable test for NETFX
* CR feedback
* Pattern matching on VSB
* Direct call
* typo
Commit migrated from https://github.com/dotnet/corefx/commit/
76c8587e935fb501d57b10de44826e1f99b69236
Jeremy Barton [Tue, 4 Sep 2018 19:53:06 +0000 (12:53 -0700)]
Add hybrid support for OpenSSL 1.0 and 1.1
This changes the functional code to use OpenSSL 1.1 API in the places where the API changed. "apibridge" provides equivalent methods for the OpenSSL 1.0 environment.
The following configurations have been tested:
* Non-portable against OpenSSL 1.0
* Non-portable against OpenSSL 1.1
* Portable, built against OpenSSL 1.0 and run against OpenSSL 1.0
* Portable, built against OpenSSL 1.0 and run against OpenSSL 1.1
* Portable, built against OpenSSL 1.1 and run against OpenSSL 1.0
* Portable, built against OpenSSL 1.1 and run against OpenSSL 1.1
In opensslshim, the PER_FUNCTION_BLOCK macro style has been broken up into a named purposes:
* REQUIRED_FUNCTION(fn)
* API that we use unconditionally, regardless of version
* Formerly PER_FUNCTION_BLOCK(fn, true)
* NEW_REQUIRED_FUNCTION(fn)
* API that we use unconditionally in paths that only exist against OpenSSL 1.1, is not probed for when the runtime is 1.0
* LIGHTUP_FUNCTION(fn)
* API that might not exist, must be probed with API_EXISTS checks before being utilized
* Formerly PER_FUNCTION_BLOCK(fn, false)
* FALLBACK_FUNCTION(fn)
* API that is required on OpenSSL 1.1, and when not found will bind to a method named local_#fn in the shim library
* RENAMED_FUNCTION(fn,oldfn)
* Handles a rename with no signature change from oldfn to newfn, binds appropriately based on the runtime library.
* LEGACY_FUNCTION(fn)
* API that we use unconditionally in paths that only exist against OpenSSL 1.0, is not probed for when the runtime is 1.1.
Two new #defines are available, but ideally need no further usage:
* NEED_OPENSSL_1_0
* Defined when building portable, or on non-portable when the headers are OpenSSL 1.0
* NEED_OPENSSL_1_1
* Defined when building portable, or on non-portable when the headers are OpenSSL 1.1
Commit migrated from https://github.com/dotnet/corefx/commit/
901ff58aee521984e8791f9f7d51fabfd31f910e
dotnet-maestro-bot [Tue, 4 Sep 2018 15:14:52 +0000 (08:14 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26904-01, preview1-26904-01, preview1-26903-03, beta-26904-00, beta-26904-00, respectively (dotnet/corefx#32074)
Commit migrated from https://github.com/dotnet/corefx/commit/
35fed5e0ddb8225bd9bcb1de330ca675227a3a7b
Filip Navara [Tue, 4 Sep 2018 04:42:47 +0000 (06:42 +0200)]
Fix interop signature of DsaSign to not claim ReadOnly behavior
Commit migrated from https://github.com/dotnet/corefx/commit/
816056b2a835f5c68f3b2bfaa81bd4bb5ba0932a
Filip Navara [Tue, 4 Sep 2018 04:41:17 +0000 (06:41 +0200)]
Convert S.S.C.Pkcs to ASN code generator.
Commit migrated from https://github.com/dotnet/corefx/commit/
6e6d9c39866b987bfbf8b660c69038c84afb7423
Egor Bogatov [Tue, 4 Sep 2018 03:20:18 +0000 (06:20 +0300)]
Old Linux kernels might not support SO_REUSEPORT (dotnet/corefx#31187)
* throw not supported if SO_REUSEPORT is not defined
* Ignore Reuse flag if SO_REUSEPORT is not supported
* remove redundant return Error_SUCCESS;
* move #ifdef SO_REUSEPORT up a bit
* improve #if-else-endif readability
Commit migrated from https://github.com/dotnet/corefx/commit/
3c9eb8460600d5a04bfa90bc9a777408c6ff61c3
Dan Moseley [Mon, 3 Sep 2018 02:52:00 +0000 (19:52 -0700)]
Merge pull request dotnet/corefx#31240 from bbowyersmyth/VB_Collection
Port and test VB Collection
Commit migrated from https://github.com/dotnet/corefx/commit/
2dde65cc733a1b7f4560a7246b2b959710f5b784
dotnet-maestro-bot [Sun, 2 Sep 2018 04:59:29 +0000 (21:59 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03131-07, preview1-26902-01, preview1-26902-01, preview1-26901-05, beta-26831-00, beta-26831-00, respectively (dotnet/corefx#32071)
Commit migrated from https://github.com/dotnet/corefx/commit/
75668a6bb7a3b90853a1a0e5a636c43baddf6872
dotnet-maestro-bot [Sun, 2 Sep 2018 01:09:05 +0000 (18:09 -0700)]
Update BuildTools, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03130-04, preview1-26830-04, preview1-26830-01, beta-26830-00, beta-26830-00, respectively (dotnet/corefx#31994)
Remove things that were added to BuildTools
Some support was added in https://github.com/dotnet/buildtools/pull/2151
so we need to remove them from corefx repo targets now.
Commit migrated from https://github.com/dotnet/corefx/commit/
24153497a70093e381e1b59e14613ee508e6f67a
Jose Perez Rodriguez [Thu, 30 Aug 2018 20:36:41 +0000 (13:36 -0700)]
Fixing incorrect project configurations
Commit migrated from https://github.com/dotnet/corefx/commit/
f6787466fed02bc21c4e0b453e3664bd1d9e75b8
Jan Kotas [Sat, 1 Sep 2018 16:47:13 +0000 (09:47 -0700)]
Fix build break caused by conflicting changes
Ifdef use of Reflection.Emit for netstandard build of System.Runtime.InteropServices tests. I choose to ifdef it out instead of
refactoring into small files since this change is temporary. These ifdefs should be removed once Reflection.Emit is added to netstandard2.1.
Commit migrated from https://github.com/dotnet/corefx/commit/
83cc1fe1dd028261bfed42b634bdab51e651c050
Santiago Fernandez Madero [Fri, 31 Aug 2018 22:20:29 +0000 (15:20 -0700)]
Finally fix Api Catalog drop (dotnet/corefx#32061)
Commit migrated from https://github.com/dotnet/corefx/commit/
b08e6f13daf464f8a41e0a6e1afa9dc1ca616856
Ilya [Fri, 31 Aug 2018 20:57:19 +0000 (01:57 +0500)]
Optimize RemoveAt() method in OrderedDictionary class (dotnet/corefx#32044)
Commit migrated from https://github.com/dotnet/corefx/commit/
243e24c32fd587f046b23b9770fb811c962aaeed
Max Kerr [Fri, 31 Aug 2018 19:12:14 +0000 (12:12 -0700)]
Disable test that appears to be causing a hang in System.Net.Http tests. (dotnet/corefx#32048)
Commit migrated from https://github.com/dotnet/corefx/commit/
01d396a97a5c07dd78c0da7fac80f6b4cf23cb40
Jeremy Barton [Fri, 31 Aug 2018 05:20:57 +0000 (22:20 -0700)]
Erase temporary copies of plaintext during de/padding operations
When symmetric block padding is added, or removed, the
UniversalCryptoDecryptor and UniversalCryptoEncryptor classes make a
temporary buffer to hold the padded result (for encryption this is the input to
the cryptographic transform, for decryption it is the output before calling
DepadBlock).
While these buffers are usually marked as unused by the GC in short order, and
overwritten by new objects in short order, some applications are more sensitive
to having plaintext residuals in memory; and we should clear these out before
abandoning them to the garbage collector.
Commit migrated from https://github.com/dotnet/corefx/commit/
bb54ed5540d19a1595443bab0233e3c985da9dad
Dan Moseley [Thu, 30 Aug 2018 22:58:17 +0000 (15:58 -0700)]
Merge pull request dotnet/corefx#32001 from iSazonov/fix-ordereddictionary
Exclude extra allocations in OrderedDictionary
Commit migrated from https://github.com/dotnet/corefx/commit/
92cc2668f6413853a403155bfd79c37a7f0d75b6
Hugh Bellamy [Thu, 30 Aug 2018 21:11:41 +0000 (22:11 +0100)]
Enhance existing Marshal tests (dotnet/corefx#31196)
Commit migrated from https://github.com/dotnet/corefx/commit/
f024dd1d54aa29354e8840c5ead72f4fbd8cf1de
Santiago Fernandez Madero [Thu, 30 Aug 2018 20:53:03 +0000 (13:53 -0700)]
Update compat pack dependency on System.IO.Pipes.AccessControl (dotnet/corefx#32035)
Commit migrated from https://github.com/dotnet/corefx/commit/
e4a2cc08954407a6359032641e72e6c53124bba7
Jose Perez Rodriguez [Thu, 30 Aug 2018 18:43:53 +0000 (11:43 -0700)]
Adding netstandard configuration for System.Runtime.Tests (dotnet/corefx#32032)
Commit migrated from https://github.com/dotnet/corefx/commit/
f252ef6d695176143aa46b855db5553fb6e44921
Jose Perez Rodriguez [Thu, 30 Aug 2018 17:36:32 +0000 (10:36 -0700)]
Adding the ability to build a NETStandard test suite (dotnet/corefx#31850)
* Adding the ability to build a NETStandard test suite
* Adding the netstandard vertical of the tests as a separate command to the allConfigurations leg
* Fixing System.IO.Pipelines.Tests that was broken for the netstandard configuration
Commit migrated from https://github.com/dotnet/corefx/commit/
0c5594864387aef6d9f6c8842f8a9e476ef39cc3
Viktor Hofer [Thu, 30 Aug 2018 17:03:41 +0000 (19:03 +0200)]
Rename xunit config for System.Globalization.Calendars (dotnet/corefx#32020)
Commit migrated from https://github.com/dotnet/corefx/commit/
68b76c30eafb3647c11e3f766a2645b130ca1448
Santiago Fernandez Madero [Thu, 30 Aug 2018 16:33:04 +0000 (09:33 -0700)]
Update compat pack validation to reference asp 3.0.0 package (dotnet/corefx#32031)
Commit migrated from https://github.com/dotnet/corefx/commit/
97a43d132bd235cb72edfdcb5fa680fbcf5891cb
Jeremy Barton [Thu, 30 Aug 2018 07:48:13 +0000 (00:48 -0700)]
Ensure that TrySetECDHNamedCurve is always called, enabling ECDHE ciphersuites
Moves the call to TrySetECDHNamedCurve above the early abort when the server default protocols are selected.
This ensures that when SslStream is used as a TLS server that the ECDHE ciphersuites are available for "Perfect Forward Secrecy".
By using an SslStream-based TLS server and the openssl s_client utility as a client, verified that the ciphersuite went from ECDH-ECDSA-AES256-GCM-SHA384 to ECDHE-ECDSA-AES256-GCM-SHA384 (and AES256-GCM-SHA384 to ECDHE-RSA-AES256-GCM-SHA384 for RSA).
Commit migrated from https://github.com/dotnet/corefx/commit/
18720f9b286770a08f59e866e4da220d3aadaf29
iSazonov [Thu, 30 Aug 2018 04:57:05 +0000 (09:57 +0500)]
Address feedback 1
Commit migrated from https://github.com/dotnet/corefx/commit/
5670a43510957592b2d84fd9273d87471b8950d2
Egor Bogatov [Thu, 30 Aug 2018 00:44:39 +0000 (03:44 +0300)]
Remove [Flags] from RegistryKeyPermissionCheck (dotnet/corefx#31998)
Commit migrated from https://github.com/dotnet/corefx/commit/
c904bd123b209ad5b42f48f3a4ef33616b387734
Wes Haggard [Thu, 30 Aug 2018 00:33:25 +0000 (17:33 -0700)]
Merge pull request dotnet/corefx#32014 from weshaggard/moveto30
Remap netcoreapp to netcoreapp3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
9a050ff1fe72bb8b757af1ed9d48c379f35cfcfb
Wes Haggard [Wed, 29 Aug 2018 21:20:34 +0000 (14:20 -0700)]
Update System.Io.Pipes.AccessControl.Tests to only target what we build
We only build netcoreapp and uap for this library now so only test
those configurations.
Commit migrated from https://github.com/dotnet/corefx/commit/
b12f8558e5e80f7d1e45182ace5bac226906c954
Wes Haggard [Wed, 29 Aug 2018 19:07:34 +0000 (12:07 -0700)]
Fix merge conflict with missing define for netcoreapp2.1
After the recent merge of moving the defines we need to continue
to define netcoreapp in the System.Data.SqlClient project even for
the netcoreapp2.1 build configuration.
Commit migrated from https://github.com/dotnet/corefx/commit/
5da5fd3628253da1d2578ab5c6a437202ac76254
Jan Vorlicek [Wed, 29 Aug 2018 17:58:24 +0000 (19:58 +0200)]
Add unloadable AssemblyLoadContext API and tests (dotnet/corefx#32002)
* Add unloadable AssemblyLoadContext API and tests
The change is based on dotnet/corefx#14763, but I had to change many things due to
the fact that the project.json files are not used anymore and due to the
slighly different semantics of the Unloading event, which now fires when
the unloading is about to start and doesn't indicate the unload is
almost done as before.
Additional changes:
* Tests for all remaining unsupported features:
* delegate marshalling for types in collectible assemblies
* FixedAddressValueTypeAttribute
* COM interop
* Removed checked in binary System.Runtime.Loader.Test.Assembly.dll,
modified the msbuild projects to build it at the build time instead.
* Added the new APIs to ApiCompatBaseline
Commit migrated from https://github.com/dotnet/corefx/commit/
cfb501e9b73fd472a9bc5dcc38ba72f7f4183a38
Wes Haggard [Wed, 29 Aug 2018 16:45:04 +0000 (09:45 -0700)]
Update the configurations properties in projects
Commit migrated from https://github.com/dotnet/corefx/commit/
fea86686c620242ce7e1911418f2fba7c4d52d4d
Wes Haggard [Wed, 29 Aug 2018 00:41:58 +0000 (17:41 -0700)]
Add netcoreapp2.1 placeholder configuration to System.Threading.Tasks.Extensions
This placeholder prevents the netstandard ref from being bin-placed into
the ref/netcoreapp2.1 folder which causes issues because types were moved
down to system.runtime in 2.1.
Commit migrated from https://github.com/dotnet/corefx/commit/
0c68c2fe46363690dd8c680fa29f0b72adf8a1c1
Wes Haggard [Tue, 28 Aug 2018 22:46:38 +0000 (15:46 -0700)]
Add netcoreapp2.1 build for System.Threading.Channels
Commit migrated from https://github.com/dotnet/corefx/commit/
a903f8612640ad81535078f9e5ebda1c79e403b9
Wes Haggard [Tue, 28 Aug 2018 22:27:08 +0000 (15:27 -0700)]
Add netcoreapp2.1 build for System.Net.WebSockets.WebSocketProtocol
Commit migrated from https://github.com/dotnet/corefx/commit/
0cb09ad87ce1e685700430d8065a6285af7ad1ae
Wes Haggard [Tue, 28 Aug 2018 22:22:39 +0000 (15:22 -0700)]
Remove package for System.IO.Pipes.AccessControl
We no longer need to ship an updated version of this package
so remove it as well as all but the netcoreapp and uap build
configurations. The API surface is frozen because it is inbox on
uap so we cannot do anything beyond service the package which can
happen in the servicing branches. If we need to make a larger change
to this library we can always bring back the package and harvest
all the older assets.
Commit migrated from https://github.com/dotnet/corefx/commit/
4e76a6c02552422ce07967f4249acad3b71b80ef
Wes Haggard [Tue, 28 Aug 2018 16:55:17 +0000 (09:55 -0700)]
Add netcoreapp2.1 build for System.IO.Pipelines
Commit migrated from https://github.com/dotnet/corefx/commit/
c4819047d93419d3e230e483c117ae7302dd6f34
Wes Haggard [Tue, 28 Aug 2018 16:51:38 +0000 (09:51 -0700)]
Add netcoreapp2.1 build for System.Data.SqlClient
Commit migrated from https://github.com/dotnet/corefx/commit/
9784d6aadef8e5b19ba192444b767c0f93652ff7
Wes Haggard [Tue, 28 Aug 2018 16:47:57 +0000 (09:47 -0700)]
Add netcoreapp2.1 build for System.ServiceModel.Syndication
Commit migrated from https://github.com/dotnet/corefx/commit/
0b71879a3aa8816de9c2ec575dcebb09995752f7
Wes Haggard [Tue, 28 Aug 2018 16:41:55 +0000 (09:41 -0700)]
Add netcoreapp2.1 targeting support
Commit migrated from https://github.com/dotnet/corefx/commit/
afafb2acfb41219d140d57f1cc0ce4bd4094c305
Wes Haggard [Tue, 28 Aug 2018 01:23:50 +0000 (18:23 -0700)]
Harvest 2.1 assets for Crypto libraries
Commit migrated from https://github.com/dotnet/corefx/commit/
eef0bf30fd83e22811260d0d975f3a59b4507420
Wes Haggard [Tue, 28 Aug 2018 01:02:15 +0000 (18:02 -0700)]
Set NETCoreAppMaximumVersion to 3.0 so we can build with older sdk
Need to set NETCoreAppMaximumVersion to 3.0 when building a 3.0
project with the 2.x sdk.
Commit migrated from https://github.com/dotnet/corefx/commit/
fcf67edf540033046715bb6079996c6345a6be3f
Wes Haggard [Tue, 21 Aug 2018 17:42:42 +0000 (10:42 -0700)]
Move new packages to 3.0 as supported versions
Commit migrated from https://github.com/dotnet/corefx/commit/
b45f4c09123b15a36b1f5633204e5f2c5ab583d6
Wes Haggard [Tue, 21 Aug 2018 16:38:18 +0000 (09:38 -0700)]
Remap netcoreapp to netcoreapp3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
fa4bf93546185f7bc0f7b5c3d499f785f5a4212f
Wes Haggard [Wed, 29 Aug 2018 16:32:29 +0000 (09:32 -0700)]
Merge pull request dotnet/corefx#31993 from weshaggard/harvest21
Update the stable packages and harvested package versions.
Commit migrated from https://github.com/dotnet/corefx/commit/
b89a1f8c4b2bb018bb428b1323b79fddf3d72c6d
Filip Navara [Wed, 29 Aug 2018 15:49:33 +0000 (17:49 +0200)]
Move uap, uapaot, netfx, netcoreapp and netcoreapp20 constant definitions to top-level build file. (dotnet/corefx#31470)
* Move uap, uapaot, netfx and netcoreapp constant definitions to top-level build file.
* Trying to fix compilation of PerformanceCounterLib for netcoreapp2.0 targets.
* Change netcoreapp definition to mean the current version only.
* Fix conflict in System.Private.DataContractSerialization.csproj.
* Revert change in src/shims/manual/Directory.Build.props.
* Fix condition in test.
* Bring back TargetsNetCoreApp, it was lost during rebases.
* Move definition of netstandard to top-level build file. Remove more netcoreapp/uap definitions from individual files.
* Fix vbproj compatibility.
* Address PR review and unify the definitions to use TargetGroup directly.
* Add back one "netstandard" definition.
Commit migrated from https://github.com/dotnet/corefx/commit/
ac994544e749eac3e85b60bf0012ae2f85ae0e49
Mike McLaughlin [Wed, 29 Aug 2018 04:45:13 +0000 (21:45 -0700)]
Merge pull request dotnet/corefx#31991 from mikem8361/fixrace
Fix race in the StackTraceSymbols.CoreCLR.cs metadata provider cache.
Commit migrated from https://github.com/dotnet/corefx/commit/
cf7c16a2aa71fe6a576579fc159513f46a65d643
iSazonov [Wed, 29 Aug 2018 04:27:14 +0000 (09:27 +0500)]
Replace properties with methods EnsureObjectsTable() and EnsureObjectsArray()
Commit migrated from https://github.com/dotnet/corefx/commit/
551ba9e70c3e5ace47c8ccb36a0815cfc074fb3a
Wes Haggard [Wed, 29 Aug 2018 00:56:06 +0000 (17:56 -0700)]
Update package baselines to latest 2.1 versions
Commit migrated from https://github.com/dotnet/corefx/commit/
b573a2d8737152121002c4325b902eba20caf06f
Wes Haggard [Tue, 28 Aug 2018 00:26:48 +0000 (17:26 -0700)]
Bump version of Microsoft.XmlSerializer.Generator
Need to bump the package version for Microsoft.XmlSerializer.Generator
after the 2.0.0 version was already shipped stable.
Commit migrated from https://github.com/dotnet/corefx/commit/
22d2c6c1dcbeab4f2bf52498893876a78e2fc627
Wes Haggard [Mon, 27 Aug 2018 23:30:23 +0000 (16:30 -0700)]
Remove workaound for System.Reflection.TypeExtensions package
We are now harvesting a serviced package so we can remove the
workaround for pulling from the older package.
Commit migrated from https://github.com/dotnet/corefx/commit/
8d5f259e98109a7a9d35ae995781daa124fa1806
Wes Haggard [Mon, 27 Aug 2018 22:10:25 +0000 (15:10 -0700)]
Remove System.ValueTuple package
Given that the entire library is frozen because it is inbox on
most platforms we are going to discontinue the package building
and shipping.
Commit migrated from https://github.com/dotnet/corefx/commit/
72b0075033908e747cac4e5b6842fa78cf96b853
Wes Haggard [Mon, 27 Aug 2018 21:51:38 +0000 (14:51 -0700)]
Exclude unknown version from harvested supported frameworks
A number of packages have harvested supported frameworks
that we cannot determine the version for because they are placeholders
for inbox components so we are just excluding them from
the list of supported frameworks to verify since we don't have a great
way to determine the correct versions.
Commit migrated from https://github.com/dotnet/corefx/commit/
91125724bd2d2153ca95cd2be31ffe1c5e2f1b3c
Wes Haggard [Mon, 27 Aug 2018 18:38:13 +0000 (11:38 -0700)]
Update harvested package versions
Commit migrated from https://github.com/dotnet/corefx/commit/
5312b96dbdf8d504f35903aa86baca52a3254d16
Wes Haggard [Wed, 22 Aug 2018 20:27:39 +0000 (13:27 -0700)]
Update list of stable packages in index and harvest list
Commit migrated from https://github.com/dotnet/corefx/commit/
f6d581662ceab3b2727060e6564edf56a4b7d6d6
Jiayi Yu [Tue, 28 Aug 2018 17:46:09 +0000 (10:46 -0700)]
Support deserializing empty TimeSpan (dotnet/corefx#31750)
* add empty check for timespan
* fix in reflection based and code gen
* add test
Commit migrated from https://github.com/dotnet/corefx/commit/
da1089a659b6c16d7dd676a4a806c822351a902a
iSazonov [Tue, 28 Aug 2018 15:26:58 +0000 (20:26 +0500)]
Add null check in Indexer[object]
Commit migrated from https://github.com/dotnet/corefx/commit/
c40082d2fed89b34b66a41a11e9e5b0b903c407d
iSazonov [Tue, 28 Aug 2018 14:57:07 +0000 (19:57 +0500)]
Add null check in Indexer
Commit migrated from https://github.com/dotnet/corefx/commit/
7974a16ae6854c79c523ca4cd1ec57f49b5acbf6
iSazonov [Tue, 28 Aug 2018 14:45:47 +0000 (19:45 +0500)]
Add null check in IndexOfKey() method
Commit migrated from https://github.com/dotnet/corefx/commit/
03044f0eb5a30010114e7f526932f24f0064cc26
iSazonov [Tue, 28 Aug 2018 14:40:05 +0000 (19:40 +0500)]
Add null check in Contains() method
Commit migrated from https://github.com/dotnet/corefx/commit/
5c9ac81ed5cef7b17b0e5a432e7c0a0a4688a81a
iSazonov [Tue, 28 Aug 2018 14:32:50 +0000 (19:32 +0500)]
Add null check in Count property
Commit migrated from https://github.com/dotnet/corefx/commit/
a7c75ef354acc0325028fee9cc570e17a8e50a8b
Mike McLaughlin [Mon, 27 Aug 2018 22:15:58 +0000 (15:15 -0700)]
Fix race in the StackTraceSymbols.CoreCLR.cs metadata provider cache.
Issue dotnet/corefx#19698.
Commit migrated from https://github.com/dotnet/corefx/commit/
0bab8ced15793082c390a602546dc154784b14f3
Filip Navara [Mon, 27 Aug 2018 22:40:18 +0000 (00:40 +0200)]
Change X509Certificates to use ASN type generation instead of AsnSerializer
Commit migrated from https://github.com/dotnet/corefx/commit/
7bb3ad18a7882e7067ee9e08240431a320c65482
Viktor Hofer [Mon, 27 Aug 2018 20:09:00 +0000 (22:09 +0200)]
Update and reference xunit from stable feed (dotnet/corefx#31974)
* Reference xunit from stable feed
* Update XUnitRunnerUap
* Fix flaky uap culture change
Commit migrated from https://github.com/dotnet/corefx/commit/
6b762eedf224de6f38a37b96104ecb146f41a122
dotnet-maestro-bot [Mon, 27 Aug 2018 19:46:25 +0000 (12:46 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03127-01, preview1-26827-04, preview1-26827-04, preview1-26827-01, beta-26827-00, beta-26827-00, respectively (dotnet/corefx#31938)
Commit migrated from https://github.com/dotnet/corefx/commit/
854fbe385c167753e65ca52f563767d6069199e6
Viktor Hofer [Mon, 27 Aug 2018 19:42:29 +0000 (21:42 +0200)]
Remove unused configurations and merge files (dotnet/corefx#31959)
Commit migrated from https://github.com/dotnet/corefx/commit/
a5213923741b270126d79e2870c381a37e7f62b2
Jeremy Barton [Mon, 27 Aug 2018 19:22:47 +0000 (12:22 -0700)]
Add a bytes to struct overload to AsnXml Decode
The reader-based decode cannot assert that the reader is empty, because it is
used to read values out of a collection, and fields out of a SEQUENCE or CHOICE.
It emits the answer via an out parameter to facilitate easier copying on
populating struct fields.
This new overload takes bytes, and is expected to consume all of them, so it
makes more sense to return the value. A caller wishing to do a decode of only
the first encoded value in the bytes can use the AsnReader-taking overload.
Commit migrated from https://github.com/dotnet/corefx/commit/
120de5256ba3c96ec7ce6eac0a2d852e5d15e30d
Michal Strehovský [Mon, 27 Aug 2018 19:06:34 +0000 (21:06 +0200)]
Enable ref return invoke tests on UAPAOT (dotnet/corefx#31976)
This was fixed in dotnet/corertdotnet/corefx#6194.
Commit migrated from https://github.com/dotnet/corefx/commit/
c7744f42a53b67528a77461c00941e78b3eb506c
Dan Moseley [Mon, 27 Aug 2018 18:53:19 +0000 (11:53 -0700)]
Rename Canonicalization.Tests.csproj to match assembly (dotnet/corefx#31946)
Commit migrated from https://github.com/dotnet/corefx/commit/
10c4e7ea6536a3bfd397b42e13c20d6a42de5713
Viktor Hofer [Mon, 27 Aug 2018 18:03:05 +0000 (20:03 +0200)]
Promote tests to netstandard (dotnet/corefx#31966)
* Promote tests to netstandard
* Disable uap test run
* Uncomment constant define, file condition positive
* Disable failing uap tests
Commit migrated from https://github.com/dotnet/corefx/commit/
559d5401e6bb8a487ff499f4beff5bf5d83961a3
Martin Baulig [Mon, 27 Aug 2018 13:16:52 +0000 (15:16 +0200)]
Use CryptoConfig.MapNameToOid instead of OID.FromFriendlyName
This is functionally the same, but helps Mono with a layering problem.
Commit migrated from https://github.com/dotnet/corefx/commit/
58a310782b805df19a3939b12544c39296db5ed3
Anirudh Agnihotry [Mon, 27 Aug 2018 04:03:12 +0000 (21:03 -0700)]
Using shared copy of registryvalueKind (dotnet/corefx#31922)
* using local copy of registryvaluekind and advapi32
* Moving complete file to shared
* name changed
Commit migrated from https://github.com/dotnet/corefx/commit/
39c4ddf1cbc0435d981c9b28ac0fe3aa1dcaac3b
Viktor Hofer [Mon, 27 Aug 2018 03:59:48 +0000 (05:59 +0200)]
Reenable uap tests that timed out (dotnet/corefx#31961)
Commit migrated from https://github.com/dotnet/corefx/commit/
d9365f55fc58074845c980a7d913bd9a388ac25e
Marco Rossignoli [Sun, 26 Aug 2018 21:07:26 +0000 (23:07 +0200)]
Improve BDN benchmarking guide (dotnet/corefx#31963)
* update docs
* address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
4bf7380242fa6a18569230cc37e13c0e0c0d2498
Viktor Hofer [Sun, 26 Aug 2018 15:29:38 +0000 (17:29 +0200)]
Remove old PerformanceTests (dotnet/corefx#31958)
Commit migrated from https://github.com/dotnet/corefx/commit/
6cda7c115bf5341d2dea63b03aa881acac2b7532
Tim Lovell-Smith [Sun, 26 Aug 2018 13:29:51 +0000 (06:29 -0700)]
Cleanup netfx-specific code from projects that no longer build in netfx configurations (dotnet/corefx#31818)
* Remove Crc32Helper.Managed.cs and '$(TargetGroup)' == 'netfx' conditionals from System.IO.Compression.csproj
* Remove netfx conditionals from System.Data.Common.csproj
* Remove netfx conditionals from System.Diagnostics.StackTrace.csproj
* Remove 'netfx' and 'net46' conditionals from System.Net.Http.csproj
* Remove 'netfx' conditionals from System.Net.Sockets.csproj
* Remove 'netfx', 'net462' and 'net47' conditionals from System.Runtime.InteropServices.RuntimeInformation.csproj
* Remove 'netfx' conditionals from System.Runtime.Serialization.Primitives.csproj
* Remove 'netfx' conditionals from System.Runtime.Serialization.Xml.csproj
* Remove 'netfx' and 'net47' conditionals from System.Security.Cryptography.Algorithms.csproj
* Remove 'netfx' conditionals from System.Security.SecureString.csproj
* Remove 'netfx' conditionals from System.Threading.Overlapped.csproj
* Remove 'netfx' conditionals from System.Xml.XPath.XDocument.csproj
* Trim out unused source file DeferredDisposableLifetime.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
6a0ecec8279504c03433f689e4a7cf6cd63da27c
Anirudh Agnihotry [Sun, 26 Aug 2018 03:28:26 +0000 (20:28 -0700)]
if defs removed and code moved to platformdetection.unix.cs (dotnet/corefx#31932)
* if defs removed
* using empty string for all windows flavour
* string.empty change to sglibcnotfound
Commit migrated from https://github.com/dotnet/corefx/commit/
88515750d2860e74b338360942ffdd6fe401995f
Tanner Gooding [Sat, 25 Aug 2018 03:50:19 +0000 (20:50 -0700)]
Update tools/Configurations.props to also include netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
9c325242a1151a8cb93ad559ff80ba2d6a94a16d
Jeremy Barton [Sat, 25 Aug 2018 05:49:25 +0000 (22:49 -0700)]
Use code generation instead of a reflection-based serializer for ASN (BER/DER) data.
Code generation solves a couple problems that the current serialization mechanism has (while maintaining the goodness):
* When deserialization fails it's really hard to debug why
* Solution: The genenerated code makes it easier to do things like break after a specific field decode.
* Reflection problems (rd.xml interactions, field ordering guarantees, etc)
* Solution: It's not reflection
* Perf
* Benchmarks say that the generated code is ~50x faster than the serializer
* Some of the sanity checks from the serializer can be moved into #if DEBUG cctors for one-shot verification
The principles for this generator were:
* Avoid the paradigm of "run this tool and check in the output"
* Use inbuilt MSBuild tasks (in this case XslTransformation)
Since MSBuild for .NET Core doesn't have the XslTransformation class it's a combination of "freshly built" and "checked in" for the time being.
This change only converts two types from the serializer to the generator. Others will happen in followup PRs.
Commit migrated from https://github.com/dotnet/corefx/commit/
50edd57cbc39f02234a8423125746941c211af13
Aaron Robinson [Sat, 25 Aug 2018 01:52:11 +0000 (18:52 -0700)]
Tests not supported on UAP. (dotnet/corefx#31948)
Commit migrated from https://github.com/dotnet/corefx/commit/
3ed8547c2b30b5395980447346446f7c5e78af86
Santiago Fernandez Madero [Fri, 24 Aug 2018 22:43:32 +0000 (15:43 -0700)]
Remove ActiveIssue from serialization test (dotnet/corefx#31947)
Commit migrated from https://github.com/dotnet/corefx/commit/
8f897b247a49db435e23847056e20b3d22c8cf0d
Marco Rossignoli [Fri, 24 Aug 2018 22:38:23 +0000 (00:38 +0200)]
Add TypeConverter fallback to DefaultValueAttribute tests (dotnet/corefx#31649)
* add TypeConverter fallback
* update tests
* added InternalConvertFromInvariantString helper for CoreLib, added some tests
* rename CoreLib helper method
* added fallback tests
* remove CoreLib helper
* skip fallback tests on netfx
* address PR feedback
* move from facts to theory
* rename test
Commit migrated from https://github.com/dotnet/corefx/commit/
e5b554c624136f430ca89023bc440dba98820a07
Tanner Gooding [Mon, 30 Jul 2018 15:49:09 +0000 (08:49 -0700)]
Updating S.R.CS.Unsafe to be built using the ilproj sdk.
Commit migrated from https://github.com/dotnet/corefx/commit/
203a9a3a4f018c27e6880e5844007de722bb1e58
Clinton Ingram [Fri, 24 Aug 2018 16:50:24 +0000 (09:50 -0700)]
Remove redundant code (dotnet/corefx#31923)
Commit migrated from https://github.com/dotnet/corefx/commit/
ea6b4926edebbaaaafe8f968a696697cc735e058
dotnet-maestro-bot [Fri, 24 Aug 2018 15:12:31 +0000 (08:12 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03124-01, preview1-26824-01, preview1-26824-01, preview1-26823-04, beta-26823-00, beta-26823-00, respectively (master) (dotnet/corefx#31890)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03124-01, preview1-26824-01, preview1-26824-01, preview1-26823-04, beta-26823-00, beta-26823-00, respectively
* Fix errors in Avx2.Permute8x32 and Avx.PermuteVar float, double overload signatures
Commit migrated from https://github.com/dotnet/corefx/commit/
e3e0fd92c9f5a2e11d1f7e2e1b711c85db5ee418
Adam Sitnik [Fri, 24 Aug 2018 13:11:25 +0000 (15:11 +0200)]
BenchmarkDotNet can benchmark local CoreFX builds using CoreRun (dotnet/corefx#31921)
* 0.11.1 knows how to use CoreRun to run the local CoreFX benchmarks!
* fix typos and old link
Commit migrated from https://github.com/dotnet/corefx/commit/
3475a8d8aa594bdebfeae240f509e28a75b56095
Andrew Au [Fri, 24 Aug 2018 04:22:29 +0000 (21:22 -0700)]
Merge pull request dotnet/corefx#31919 from cshung/dev/andrewau/libcfix
Avoid [DllImport(libc.dll)] for the UAPAOT scenario
Commit migrated from https://github.com/dotnet/corefx/commit/
434bf9d73e5318bc4ec46c9bd575f385ddbc7930
Viktor Hofer [Thu, 23 Aug 2018 21:57:57 +0000 (23:57 +0200)]
Add back removed install requirement in docs
Commit migrated from https://github.com/dotnet/corefx/commit/
96c41ddc8101863afb7a5ed418546ab040935d0d
Viktor Hofer [Thu, 23 Aug 2018 21:23:36 +0000 (23:23 +0200)]
Update required software and developer workflow (dotnet/corefx#30919)
* Update required software and developer workflow
* Address PR feedback
* Fix debugging packages instructions for builds
* Add desktop vs core msbuild disclaimer
* Delete obsolete file
Commit migrated from https://github.com/dotnet/corefx/commit/
d9193a1bd70eee4320f8dcdd4e237ee9acf689e9