platform/upstream/efl.git
4 years agoeet - fix loading eet files that do not have dicts
Carsten Haitzler (Rasterman) [Mon, 14 Oct 2019 11:14:26 +0000 (12:14 +0100)]
eet - fix loading eet files that do not have dicts

my performance fix for locking around the eet dict breaks if there is
no dict in the eet file. this causes a segv.

fixes T8368

@fix

4 years agocanvas vg: don't draw images if it's full transparent.
Hermet Park [Mon, 14 Oct 2019 08:52:47 +0000 (17:52 +0900)]
canvas vg: don't draw images if it's full transparent.

4 years agoeolian: fix eolian errors with EOLIAN_ENFORCE_SINCE=1
WooHyun Jung [Mon, 14 Oct 2019 07:55:52 +0000 (16:55 +0900)]
eolian: fix eolian errors with EOLIAN_ENFORCE_SINCE=1

Summary:
This is not the end of fixing eolian errors. I need to keep fixing
more.

Test Plan:
1. export EOLIAN_ENFORCE_SINCE=1
2. ninja

Reviewers: q66, segfaultxavi, zmike, bu5hm4n, Jaehyun_Cho

Reviewed By: segfaultxavi, Jaehyun_Cho

Subscribers: Jaehyun_Cho, stefan_schmidt, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10370

4 years agocsharp: updating UserModel docs.
Bruno da Silva Belo [Mon, 14 Oct 2019 04:06:49 +0000 (01:06 -0300)]
csharp: updating UserModel docs.

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8345

Differential Revision: https://phab.enlightenment.org/D10377

4 years agocsharp: updating efl_all docs.
Bruno da Silva Belo [Mon, 14 Oct 2019 04:01:10 +0000 (01:01 -0300)]
csharp: updating efl_all docs.

Summary: ref T8345

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8345

Differential Revision: https://phab.enlightenment.org/D10378

4 years agocsharp: updating efl_csharp_application docs.
Bruno da Silva Belo [Mon, 14 Oct 2019 03:53:34 +0000 (00:53 -0300)]
csharp: updating efl_csharp_application docs.

Summary: ref T8345

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8345

Differential Revision: https://phab.enlightenment.org/D10379

4 years agocsharp: Add since documentation to Async methods
Felipe Magno de Almeida [Mon, 14 Oct 2019 02:45:17 +0000 (23:45 -0300)]
csharp: Add since documentation to Async methods

Reviewers: lauromoura

Reviewed By: lauromoura

After review, fixed formatting and indentation.

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8359

Differential Revision: https://phab.enlightenment.org/D10384

4 years agoelm: Fix potential leak in cv request add
Lauro Moura [Mon, 14 Oct 2019 02:34:32 +0000 (23:34 -0300)]
elm: Fix potential leak in cv request add

Summary: CID 1405809

Reviewers: zmike, cedric, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10174

4 years agoevas filter: Implement grayscale filter in SW
Shinwoo Kim [Mon, 14 Oct 2019 02:13:15 +0000 (11:13 +0900)]
evas filter: Implement grayscale filter in SW

Summary: Initial version implementing grayscale filter in SW.

Test Plan:
1. Create filter_example with following.
efl_gfx_filter_program_set(image, "grayscale ()", "grayscale");

1. Run.
./filter_example

Reviewers: Hermet, jsuya

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10219

4 years agoevas filter: preserve text source color
Shinwoo Kim [Mon, 14 Oct 2019 02:11:04 +0000 (11:11 +0900)]
evas filter: preserve text source color

Summary:
The filter did not use text source color. Whatever color a text has, filter
used white color instead of it.

Test Plan: efl_gfx_filter_program_set(non_white_color_text, "code", "name");

Reviewers: Hermet, jsuya, cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10336

4 years agoevas_image: fix memory leak
Shinwoo Kim [Mon, 14 Oct 2019 02:09:31 +0000 (11:09 +0900)]
evas_image: fix memory leak

Summary:
On the sw engine, an im could be changed and removed by evas_cache_image_size_set.
In this case, there is no chance to free its resource and ends up in memory leak.

Reviewers: Hermet, raster, jsuya, cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10334

4 years agoevas_cache_image: drop image after replacement
Shinwoo Kim [Mon, 14 Oct 2019 02:07:01 +0000 (11:07 +0900)]
evas_cache_image: drop image after replacement

Summary:
When a newly created Image_Entry works for instead of an old one,
we need to drop it. And we did dorp it.

The line calling ref and drop was added by following commit.

   d550190 evas image cache - add lots more locking to try stamp out
           any thread bug

But it is missed by following commit.

   9f99ab1 evas cache: clear up caching locking and reference count.

Reviewers: Hermet, raster, jsuya, cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10333

4 years agogenlist: fix wrong proxy geometry set 17/217317/2
SangHyeon Jade Lee [Fri, 8 Nov 2019 09:34:28 +0000 (18:34 +0900)]
genlist: fix wrong proxy geometry set

Change-Id: I794c528e5862c9e265344e2da953c4a83c596a75
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agocheck: reset flags that used for legacy 'changed' cb 38/217138/1
Wonki Kim [Wed, 6 Nov 2019 12:46:42 +0000 (13:46 +0100)]
check: reset flags that used for legacy 'changed' cb

Summary:
in case of setting a state of check by calling a API,
the flags that used for changed cb aren't changed.
which causes that the callback not invoked when it should be.

this patch resets the flags to make it work properly.

Reviewers: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10591

Change-Id: I16406ca41b6ac235cb6ef4ab4e2905669dd78e98

4 years agoevas_textblock: content fit feature 93/217093/1
Ali Alzyod [Tue, 5 Nov 2019 11:40:59 +0000 (20:40 +0900)]
evas_textblock: content fit feature

Summary:
**Content Fit Feature for Evas_Object_Textblock**

This Feature is available at **Evas **object level.  And **Edje **level (where it is internally use evas functionality)
This feature will allow text block to fit its content font size to proper size to fit its area.

**Main Properties:**
Fit Modes        :   None=Default, Width, Height, All [Width+Height]
Fit Size Range :   Contains maximum and minimum font size to be used (and in between).
Fit Step Size    :   Step(Jump) value when trying fonts sizes between Size_Range max and min.
Fit Size Array   :   Other way to resize font, where you explicitly select font sizes to be uses    (for example [20, 50, 100] it will try 3 sizes only)

Text Fit feature was available in Edje but:
1- It doesn't effected by ellipsis or warping in font style (or do not handle the in right way)
2- Accuracy is not good (specially if you have fix pixel size elements (spaces,tabs,items))
3- No (Step size, Size Array) available.

Test Plan:
To check the Feature
> elementary_test
> fit
> textbock fit
You can modify all the modes and properties

These are two examples, One using Evas other uses Edje

**Evas**

```

enum BUTTON{
   BUTTON_MODE             = 0,
   BUTTON_MAX              = 1,
   BUTTON_MIN              = 2,
   BUTTON_STEP             = 3,
   BUTTON_ARRAY            = 4,
   BUTTON_CONTENT          = 5,
   BUTTON_STYLE            = 6,
   BUTTON_ALL              = BUTTON_STYLE+1,
};

char* BUTTON_STR[BUTTON_ALL] ={
   "MODE",
   "MAX",
   "MIN",
   "STEP",
   "ARRAY",
   "CONTENT",
   "STYLE",
};

char *contents[] = {
   "Hello World",
   "This is Line<br>THis is other Line",
   "This text contains <font_size=20 color=#F00>SPECIFIC SIZE</font_size> that does not effected by fit mode"
   };

char *styles[] = {
   "DEFAULT='font=sans font_size=30 color=#000 wrap=mixed ellipsis=1.0'",
   "DEFAULT='font=sans font_size=30 color=#000 wrap=mixed'",
   "DEFAULT='font=sans font_size=30 color=#000 ellipsis=1.0'",
   "DEFAULT='font=sans font_size=30 color=#000'",
   };

char *styles_names[] = {
   "wrap=<color=#F00>mixed</color> ellipsis=<color=#F00>1.0</color>",
   "wrap=<color=#F00>mixed</color> ellipsis=<color=#F00>NONE</color>",
   "wrap=<color=#F00>NONE</color> ellipsis=<color=#F00>1.0</color>",
   "wrap=<color=#F00>NONE</color> ellipsis=<color=#F00>NONE</color>",
   };

typedef struct _APP
{
   Evas_Object *win, *box, *txtblock,*bg, *boxHor, *boxHor2;
   Eo *btn[BUTTON_ALL];
   Eo *lbl_status;
   char * str;
   unsigned int i_contnet, i_style;
} APP;
APP *app;

char * get_fit_status(Eo * textblock);

static void _btn_clicked(void *data EINA_UNUSED, Eo *obj, void *eventInfo EINA_UNUSED){
   if (obj == app->btn[BUTTON_MODE])
     {
        unsigned int options;
        evas_textblock_fit_options_get(app->txtblock, &options);
        if (options == TEXTBLOCK_FIT_MODE_NONE)
           evas_textblock_fit_options_set(app->txtblock, TEXTBLOCK_FIT_MODE_HEIGHT);
        else if (options == TEXTBLOCK_FIT_MODE_HEIGHT)
           evas_textblock_fit_options_set(app->txtblock, TEXTBLOCK_FIT_MODE_WIDTH);
        else if (options == TEXTBLOCK_FIT_MODE_WIDTH)
           evas_textblock_fit_options_set(app->txtblock, TEXTBLOCK_FIT_MODE_ALL);
        else if (options == TEXTBLOCK_FIT_MODE_ALL)
           evas_textblock_fit_options_set(app->txtblock, TEXTBLOCK_FIT_MODE_NONE);
     }
   else if (obj == app->btn[BUTTON_MAX])
     {
        unsigned int min, max;
        evas_textblock_fit_size_range_get(app->txtblock, &min, &max);
        max -= 5;
        evas_textblock_fit_size_range_set(app->txtblock, min, max);
     }
   else if (obj == app->btn[BUTTON_MIN])
     {
        unsigned int min, max;
        evas_textblock_fit_size_range_get(app->txtblock, &min, &max);
        min += 5;
        evas_textblock_fit_size_range_set(app->txtblock, min, max);
     }
   else if (obj == app->btn[BUTTON_STEP])
     {
        unsigned int step;
        evas_textblock_fit_step_size_get(app->txtblock, &step);
        step++;
        evas_textblock_fit_step_size_set(app->txtblock, step);
     }
   else if (obj == app->btn[BUTTON_ARRAY])
     {
        unsigned int font_size[] = {10, 50, 100 ,150};
        evas_textblock_fit_size_array_set(app->txtblock,font_size,4);
     }
   else if (obj == app->btn[BUTTON_CONTENT])
     {
        app->i_contnet++;
        if(app->i_contnet>=sizeof(contents)/sizeof(char*))
           app->i_contnet=0;
        evas_object_textblock_text_markup_set(app->txtblock,contents[app->i_contnet]);
     }
   else if (obj == app->btn[BUTTON_STYLE])
     {
        app->i_style++;
        if(app->i_style>=sizeof(styles)/sizeof(char*))
           app->i_style=0;

        Evas_Textblock_Style *style = evas_object_textblock_style_get(app->txtblock);
        evas_textblock_style_set(style,styles[app->i_style]);
     }

   elm_object_text_set(app->lbl_status, get_fit_status(app->txtblock));
}

char * get_fit_status(Eo * textblock)
{
   static char status[0xFFF];
   unsigned int options,min,max,step,size_array[256];
   size_t size_array_len;
   evas_textblock_fit_options_get(textblock,&options);
   evas_textblock_fit_size_range_get(textblock,&min,&max);
   evas_textblock_fit_step_size_get(textblock,&step);
   evas_textblock_fit_size_array_get(textblock,NULL,&size_array_len,0);
   if (size_array_len>255)
      size_array_len = 255;
   evas_textblock_fit_size_array_get(textblock,size_array,NULL,size_array_len);

   strcpy(status,"Mode : ");
   if (options == TEXTBLOCK_FIT_MODE_NONE)
      strcat(status,"MODE_NONE");
   else if (options == TEXTBLOCK_FIT_MODE_HEIGHT)
      strcat(status,"MODE_HEIGHT");
   else if (options == TEXTBLOCK_FIT_MODE_WIDTH)
      strcat(status,"MODE_WIDTH");
   else if (options == TEXTBLOCK_FIT_MODE_ALL)
      strcat(status,"MODE_ALL");

   strcat(status,"<br>");
   sprintf(status + strlen(status),"Max   : %d<br>",max);
   sprintf(status + strlen(status),"Min   : %d<br>",min);
   sprintf(status + strlen(status),"Step  : %d<br>",step);
   sprintf(status + strlen(status),"Array  : [ ");
   for (size_t i = 0 ; i < 10 ; i++)
     {
        if(i<size_array_len)
           sprintf(status + strlen(status)," %d,",size_array[i]);
     }

   if(10<size_array_len)
      sprintf(status + strlen(status)," ... ");
   sprintf(status + strlen(status)," ]");

   sprintf(status + strlen(status),"<br>");
   sprintf(status + strlen(status),"%s",styles_names[app->i_style]);

   return status;
}

int elm_main(int argc, char **argv)
{
  app = calloc(sizeof(APP), 1);

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   app->win = elm_win_util_standard_add("Main", "App");
   elm_win_autodel_set(app->win, EINA_TRUE);

   app->box = elm_box_add(app->win);
   app->boxHor = elm_box_add(app->box);
   app->boxHor2 = elm_box_add(app->box);
   app->txtblock = evas_object_textblock_add(app->box);
   app->bg = elm_bg_add(app->box);
   elm_bg_color_set(app->bg,255,255,255);

   Evas_Textblock_Style *style = evas_textblock_style_new();
   evas_textblock_style_set(style,styles[0]);
   evas_object_textblock_style_set(app->txtblock,style);
   evas_object_textblock_text_markup_set(app->txtblock,contents[0]);

   elm_box_horizontal_set(app->boxHor, EINA_TRUE);
   elm_box_horizontal_set(app->boxHor2, EINA_TRUE);

   evas_object_size_hint_weight_set(app->box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(app->box, EVAS_HINT_FILL, EVAS_HINT_FILL);

   evas_object_size_hint_weight_set(app->box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(app->box, EVAS_HINT_FILL, EVAS_HINT_FILL);

   evas_object_show(app->txtblock);
   evas_object_show(app->bg);
   evas_object_show(app->box);
   evas_object_show(app->boxHor);
   evas_object_show(app->boxHor2);

   elm_box_pack_end(app->box, app->bg);
   elm_box_pack_end(app->box, app->boxHor);
   elm_box_pack_end(app->box, app->boxHor2);

   elm_object_content_set(app->bg,app->txtblock);

   elm_win_resize_object_add(app->win, app->box);
   evas_object_resize(app->win, 320, 480);

   for(int i = 0 ; i < BUTTON_ALL ; i++)
     {
        app->btn[i] = elm_button_add(app->boxHor);
        evas_object_smart_callback_add(app->btn[i], "clicked", _btn_clicked, NULL);
        elm_object_text_set(app->btn[i], BUTTON_STR[i]);
        elm_box_pack_end(app->boxHor, app->btn[i]);
        evas_object_show(app->btn[i]);
     }

   app->lbl_status = elm_label_add(app->boxHor2);
   elm_object_text_set(app->lbl_status, get_fit_status(app->txtblock));
   elm_box_pack_end(app->boxHor2, app->lbl_status);
   evas_object_show(app->lbl_status);

   evas_object_size_hint_weight_set(app->txtblock, EVAS_HINT_EXPAND,EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(app->txtblock, EVAS_HINT_FILL, EVAS_HINT_FILL);

   evas_object_size_hint_weight_set(app->bg, EVAS_HINT_EXPAND,EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(app->bg, EVAS_HINT_FILL, EVAS_HINT_FILL);

   evas_object_show(app->win);
   elm_run();
   return 0;
}

ELM_MAIN()
```

**Edje**

```
// compile: edje_cc source.edc
// run: edje_player source.edje
collections {
   styles
   {
      style
      {
         name: "text_style";
         base: "font=sans font_size=30 color=#FFF wrap=mixed ellipsis=1.0";
         tag: "br" "\n";
         tag: "ps" "ps";
         tag: "tab" "\t";
         tag: "b" "+ font_weight=Bold";
      }
   }
   group {
      name: "my_group"; // must be the same as in source.c
      parts {

         part
         {
            name: "background";
            type: RECT;
            scale: 1;
            description
            {
               color: 0 0 0 0;
               rel1.relative: 0.0 0.0;
               rel2.relative: 1.0 1.0;
            }
         }

         part
         {
            name: "text";
            type: TEXTBLOCK;
            scale: 1;
            entry_mode: NONE;
            effect: OUTLINE_SHADOW;
            description
            {
               state: "default" 0.0;
               rel1.to : "background";
               rel1.relative: 0.0 0.0;
               rel2.to : "background";
               rel2.relative: 1.0 1.0;
               text
               {
                  style: "text_style";
                  align: 0.0 0.0;
                  text: "Hello World This is Me";
                  fit: 1 1;
                  fit_step: 1;
                  size_range: 30 200;
                  //fit_size_array: 20 40 60 80 100 200;
               }
            }
         }
      }
   }
}
```

Found Task T5724 relative to this Feature

Reviewers: woohyun, bowonryu, cedric, raster

Subscribers: #committers, #reviewers, cedric

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9280

Change-Id: I4e55ddca27d69afed1c99f8f922a8e3277364932

5 years agoitem is not packed homogeneously 94/216794/1
Sungtaek Hong [Thu, 6 Oct 2016 05:35:03 +0000 (14:35 +0900)]
item is not packed homogeneously

@tizen_fix

Change-Id: I4529484a5215ed8fc4edd3462486e4e1bae535a5
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
5 years agoelc_popup: don't allow the recalculation when the content_area is calculated 48/216548/1 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/mobile/hotfix/20201027.062405 accepted/tizen/unified/20191029.012201 submit/tizen/20191029.010729 submit/tizen_5.5_mobile_hotfix/20201026.185106
Taehyub Kim [Mon, 28 Oct 2019 11:11:52 +0000 (20:11 +0900)]
elc_popup: don't allow the recalculation when the content_area is calculated

Change-Id: I166ed0ee99d3e26707e593526830b914ad675e32

5 years agoefl_ui_layout: replace efl_canvas_group_calculate with elm_layout_sizing_eval 10/216310/1 accepted/tizen/5.5/unified/20191031.005454 accepted/tizen/unified/20191023.142709 submit/tizen/20191023.080458 submit/tizen_5.5/20191031.000006 tizen_5.5.m2_release
Yeongjong Lee [Wed, 23 Oct 2019 07:49:30 +0000 (16:49 +0900)]
efl_ui_layout: replace efl_canvas_group_calculate with elm_layout_sizing_eval

ref ef11a741ad768742f120955191c6aee3bf669114
@tizen_fix

Change-Id: I756c0f841233d77b03d45036df9765fc45e28df6

5 years agoedje_entry: check empty string when key down event is called 04/216304/2
Taehyub Kim [Wed, 23 Oct 2019 07:12:28 +0000 (16:12 +0900)]
edje_entry: check empty string when key down event is called
@tizen_fix

Change-Id: I0118d46c7ce169b0dbb972b8bd963705b736e106

5 years agoelm_panel: disable efl_ui_focus_layer functions 08/216208/1 accepted/tizen/unified/20191022.222702 submit/tizen/20191022.111446
Yeongjong Lee [Tue, 22 Oct 2019 08:36:32 +0000 (17:36 +0900)]
elm_panel: disable efl_ui_focus_layer functions

This patch will be reverted with patch to disable focus manager.

@tizen_fix

Change-Id: Id8f6d6c9e5f20118f0d38500d4f19687e71ebde0

5 years agoRevert "elm_widget: disable focus manager in tizen" 07/216207/2
YeongJong Lee [Tue, 22 Oct 2019 08:34:37 +0000 (08:34 +0000)]
Revert "elm_widget: disable focus manager in tizen"

This reverts commit 754fc972036cdc95b88faacacbeb19d802d33cea.

Change-Id: Iaf0347bcba63f54d89240d52cac41f2e9ee4f1e5

5 years agoelm_widget: disable focus manager in tizen 25/216125/2
Yeongjong Lee [Mon, 21 Oct 2019 08:04:04 +0000 (17:04 +0900)]
elm_widget: disable focus manager in tizen

`@empty` tag will disable efl_ui_focus_* functions which means focus manager
code doesn't work anymore in tizen.

@tizne_fix

Change-Id: Ie7bf0c485fde997a11b171a62d53ac78eebf8573

5 years agottrace: replace sprintf with snprintf 79/216179/2 submit/tizen/20191022.050108
Wonki Kim [Tue, 22 Oct 2019 04:53:03 +0000 (13:53 +0900)]
ttrace: replace sprintf with snprintf

sprintf has a potentiality of BOF.
this patch replace it with snprintf to prevent the problem.

Change-Id: Id131277846519ecd6deae363a3da3d363590567a
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoefl_ui_layout: size should be calculated immediately 77/216177/2
Hosang Kim [Tue, 22 Oct 2019 02:56:40 +0000 (11:56 +0900)]
efl_ui_layout: size should be calculated immediately

When the child's size hint is changed, parent's size should be
calculated immediately

@tizen_only

Change-Id: Ice417e634da643ec88b6a0c61886f85a705e681d

5 years agoelm_config: replace ecore_file_cp with ecore_file_mv 52/216152/1 submit/tizen/20191021.124352
Wonki Kim [Mon, 21 Oct 2019 11:10:02 +0000 (20:10 +0900)]
elm_config: replace ecore_file_cp with ecore_file_mv

ecore_file_cp can cause elm_config eet data invalid.
this patch replaces it with ecore_file_mv to prevent the problem.

Change-Id: I5e39ab88cf5ecb70e9d9823b43ebdcc92b2cfc51
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agottrace: enable ttrace log by default in tizen 92/215992/3
subhransu mohanty [Fri, 18 Oct 2019 05:32:06 +0000 (14:32 +0900)]
ttrace: enable ttrace log by default in tizen

Change-Id: I30e338c27a9abbca01ed7477367ea9f9d3f6fcd5

5 years agoecore_evas_wayland_common: add updating window geometry. 29/215929/3
Hosang Kim [Thu, 17 Oct 2019 12:00:44 +0000 (21:00 +0900)]
ecore_evas_wayland_common: add updating window geometry.

when window is resized, but geometry information is not updated.
So window can't be resized to initial size.
Change-Id: I86a63cf093c1987ef17862caf710b048991cd3d5

5 years agoefl_doc: Remove not supported API for displaying a video 79/215979/2 accepted/tizen/unified/20191018.222526 submit/tizen/20191018.050657
Myoungwoon Roy, Kim [Fri, 18 Oct 2019 04:54:55 +0000 (13:54 +0900)]
efl_doc: Remove not supported API for displaying a video

Change-Id: I4c17227003622460031af3022d0489a9adb04e28

5 years agoRevert "vg_common_json: Apply image's alpha color" 84/215984/1
JunsuChoi [Fri, 18 Oct 2019 04:52:40 +0000 (13:52 +0900)]
Revert "vg_common_json: Apply image's alpha color"

This reverts commit 1f5fb0867658643a952b253298bb4d05fa45131e.

This revert patch made due to public release. This patch will be recovered later by migration.

Change-Id: I30634ef137927c3011315b03055912a4e3d3256c

5 years agoRevert "vg_common_svg: Support opacity attribute of <g> element" 83/215983/1
JunsuChoi [Fri, 18 Oct 2019 04:51:45 +0000 (13:51 +0900)]
Revert "vg_common_svg: Support opacity attribute of <g> element"

This reverts commit d932abddd8594f7b00d6d1fbbb00fe46b53f16c9.

This revert patch made due to public release. This patch will be recovered later by migration.

Change-Id: I5f525d2156ef616f79d893879c52ab99e027f3b9

5 years agoRevert "efl_canvas_vg : Propagates the alpha color of the parent" 82/215982/1
JunsuChoi [Fri, 18 Oct 2019 04:49:16 +0000 (13:49 +0900)]
Revert "efl_canvas_vg : Propagates the alpha color of the parent"

This reverts commit 30b5e8051386535e13539892a1da81b83f2d32ca.

This revert patch made due to public release. This patch will be recovered later by migration.

Change-Id: I8be2f230b6cd4fd617af41f2225f5f9560fe0c2f

5 years agoEfl.Access.Object: Remove eolian docs warning 77/215877/1
JunsuChoi [Thu, 17 Oct 2019 05:47:03 +0000 (14:47 +0900)]
Efl.Access.Object: Remove eolian docs warning

Change-Id: Ic32d9bda06b8a1b830bb910b2faafe291d16a2d2

5 years agoefl_canvas_vg : Propagates the alpha color of the parent 58/215858/1
JunsuChoi [Wed, 16 Oct 2019 06:12:13 +0000 (15:12 +0900)]
efl_canvas_vg : Propagates the alpha color of the parent

Summary:
The current color is affected by the parent's opacity.
If p_opacity is set, it will be applied to the current color.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10399

Change-Id: I1e7e0e061b71a6434b132c3099533b8bca62d652

5 years agovg_common_svg: Support opacity attribute of <g> element 57/215857/1
JunsuChoi [Tue, 15 Oct 2019 05:53:25 +0000 (14:53 +0900)]
vg_common_svg: Support opacity attribute of <g> element

Summary:
The <g> element can have an opacity.
Therefore, if node type is SVG_NODE_G, set color.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10371

Change-Id: I62040945a8a609ba6231694580f00308f94d109a

5 years agovg_common_json: Apply image's alpha color 56/215856/1
JunsuChoi [Mon, 14 Oct 2019 08:44:57 +0000 (17:44 +0900)]
vg_common_json: Apply image's alpha color

Summary:
This patch needs latest rlottie that contain below commit.
https://github.com/Samsung/rlottie/commit/c3ab82ec2c207cfba2df6eb51d80dd532c93a710

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10368

Change-Id: Ifc5cbe980ddf6b506c880d8c19d63fc32d148e67

5 years agoRevert "docs: fix elementary group name in docs" 54/215854/1 accepted/tizen/unified/20191017.105745 submit/tizen/20191017.024054
Myoungwoon Roy, Kim [Thu, 17 Oct 2019 02:19:53 +0000 (11:19 +0900)]
Revert "docs: fix elementary group name in docs"

This reverts commit dbb9bb501d5372dba4f6f1b0badef789b4ade76f.

Change-Id: Id1a30fa70d0252977e2c1e8610426b1d2b0ff7e5

5 years agoelm_multibuttonentry: delete ELM_LAYOUT_MIXIN 59/215659/3 accepted/tizen/unified/20191014.062450 submit/tizen/20191014.060638
Woochanlee [Mon, 14 Oct 2019 04:26:36 +0000 (13:26 +0900)]
elm_multibuttonentry: delete ELM_LAYOUT_MIXIN

Once the min size grows, it can't shrink even if recalcuate it.

@tizen_only

Change-Id: I9d828a8fd6109fa311b92fcf71320f0220aca32b

5 years agobuild: resolve migration build error submit/tizen/20191013.215822
Jongmin Lee [Sun, 13 Oct 2019 21:56:23 +0000 (06:56 +0900)]
build: resolve migration build error

Change-Id: Iac7500e5e22cdca765e5760eeed28919ab3e2291

5 years agocsharp: Add since info to members related to events.
Lauro Moura [Fri, 11 Oct 2019 21:45:41 +0000 (21:45 +0000)]
csharp: Add since info to members related to events.

Like OnFooEvent, FooEvents, etc.

ref T8359

Differential Revision: https://phab.enlightenment.org/D10382

5 years agoeolian-cxx: Make events inherit beta info from klass.
Lauro Moura [Fri, 11 Oct 2019 21:45:03 +0000 (21:45 +0000)]
eolian-cxx: Make events inherit beta info from klass.

To mimic function behavior

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10381

5 years agoeolian-cxx: Rename fields to standard naming
Lauro Moura [Sat, 12 Oct 2019 21:05:17 +0000 (18:05 -0300)]
eolian-cxx: Rename fields to standard naming

Summary: bool fields were missing the `is_` prefix.

Reviewers: felipealmeida, brunobelo, segfaultxavi, woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10380

5 years agoeio - fbsd - make fd for monitored file close on exec
Carsten Haitzler (Rasterman) [Sat, 12 Oct 2019 12:02:31 +0000 (13:02 +0100)]
eio - fbsd - make fd for monitored file close on exec

this fixes T7486

5 years agoefl_ui_panes: fix not to consider content min size for legacy panes
Jaehyun Cho [Fri, 11 Oct 2019 13:42:51 +0000 (09:42 -0400)]
efl_ui_panes: fix not to consider content min size for legacy panes

Summary:
Since legacy panes did not consider its content's min size, the
content's min size calculation logic is not done for legacy panes.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10372

5 years agoefl_ui_focus_object: do not emit focus_geometry_changed when not needed
Marcel Hollerbach [Fri, 11 Oct 2019 13:42:34 +0000 (09:42 -0400)]
efl_ui_focus_object: do not emit focus_geometry_changed when not needed

Summary:
this is emitted a lot of times, which costs time. Most of the time they
are however not needed. With this commit, these events are not emitted
anymore.

ref T8321

Reviewers: zmike, cedric

Reviewed By: zmike, cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8321

Differential Revision: https://phab.enlightenment.org/D10348

5 years agoevas/language: #ifdef guard variable which is only used inside #ifdef
Mike Blumenkrantz [Fri, 11 Oct 2019 13:42:24 +0000 (09:42 -0400)]
evas/language: #ifdef guard variable which is only used inside #ifdef

Summary:
this variable is already only changed inside an #ifdef, so declare and
free it only inside the same ifdef for clarity

CIDs 1401016, 1400807

Reviewers: cedric

Reviewed By: cedric

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10320

5 years agoefl_canvas_animation_player: fix double free
Marcel Hollerbach [Fri, 11 Oct 2019 13:42:14 +0000 (09:42 -0400)]
efl_canvas_animation_player: fix double free

Summary:
when we are returning 0 in a animation callback, the animator will be
deleted.

This fixes a crash in tab_pager.
Depends on D10306

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10307

5 years agocv: Switch to safe 32/64 bits printf masks
Lauro Moura [Fri, 11 Oct 2019 13:41:16 +0000 (09:41 -0400)]
cv: Switch to safe 32/64 bits printf masks

This should silence 32-bit warnings about long long stuff

Reviewers: vtorri, cedric, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10214

5 years agoecore_con: use only Eina_Magic infrastructure for set and check in Ecore_Con.
Cedric BAIL [Fri, 11 Oct 2019 12:51:53 +0000 (08:51 -0400)]
ecore_con: use only Eina_Magic infrastructure for set and check in Ecore_Con.

Summary:
We can not have half our code rely on Ecore magic check and the other half
use Eina_Magic or this will lead to inconsistency with Eina_Magic definition.
Depends on D10363

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10364

5 years agoecore_con: do not crash in test if nothing is returned by Ecore_Con_Url.
Cedric BAIL [Fri, 11 Oct 2019 12:51:48 +0000 (08:51 -0400)]
ecore_con: do not crash in test if nothing is returned by Ecore_Con_Url.

Summary: Depends on D10362

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10363

5 years agoecore_con: destructor are always called when finalize return NULL.
Cedric BAIL [Fri, 11 Oct 2019 12:51:43 +0000 (08:51 -0400)]
ecore_con: destructor are always called when finalize return NULL.

Summary:
This prevent crash and double free during an invalid Ecore_Con_Eet failure
to initialize.

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10362

5 years agocsharp: Add missing docs to slice.
Lauro Moura [Fri, 11 Oct 2019 09:22:32 +0000 (11:22 +0200)]
csharp: Add missing docs to slice.

Summary:
Also removed uneeded methods.

Slice also may need some API love to be actually useful later.

ref T8292

Reviewers: segfaultxavi, felipealmeida, brunobelo, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8292

Differential Revision: https://phab.enlightenment.org/D10327

5 years agoPyolian: correctly define c_type as a property
Dave Andreoli [Fri, 11 Oct 2019 06:17:56 +0000 (08:17 +0200)]
Pyolian: correctly define c_type as a property

5 years agoecore-wl2: Add support for wl_egl interface 26/211626/8
Gwanglim Lee [Wed, 7 Aug 2019 09:02:04 +0000 (18:02 +0900)]
ecore-wl2: Add support for wl_egl interface

Change-Id: I932170d2563a1760f830c97261ac646c3c13ce74

5 years agomono: encapsulate internal efl_all members accepted/tizen/unified/20191014.005021 submit/tizen/20191010.214907 submit/tizen/20191011.230442
Yeongjong Lee [Thu, 10 Oct 2019 14:15:03 +0000 (11:15 -0300)]
mono: encapsulate internal efl_all members

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, woohyun, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10347

5 years agoPyolian: improve api coverage script
Dave Andreoli [Thu, 10 Oct 2019 09:06:47 +0000 (11:06 +0200)]
Pyolian: improve api coverage script

it now also check for enums and is smarter with code comments

5 years agoPyolian: some more missing symbols defined
Dave Andreoli [Thu, 10 Oct 2019 09:05:12 +0000 (11:05 +0200)]
Pyolian: some more missing symbols defined

5 years agocsharp: Fix doc and hide stuff from strbuf.
Lauro Moura [Thu, 10 Oct 2019 08:26:24 +0000 (10:26 +0200)]
csharp: Fix doc and hide stuff from strbuf.

Summary: ref T8293

Reviewers: felipealmeida, brunobelo, woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10326

5 years agocsharp: Fix docs and hide stuff from stringshare.
Lauro Moura [Thu, 10 Oct 2019 08:24:28 +0000 (10:24 +0200)]
csharp: Fix docs and hide stuff from stringshare.

Summary: ref T8293

Reviewers: segfaultxavi, brunobelo, felipealmeida, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10325

5 years agocsharp: Document eina_value.cs
Lauro Moura [Thu, 10 Oct 2019 07:52:09 +0000 (09:52 +0200)]
csharp: Document eina_value.cs

Summary:
Added more docs alongside the since information.

For items that should be skipped from the end user of the binding but
must stay public for generated code,
`EditorBrowsable(EditorBrowsableState.Never)` was used.

ref T8293

Reviewers: brunobelo, felipealmeida, woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10313

5 years agoelm: fix legacy callback names.
SangHyeon Jade Lee [Thu, 10 Oct 2019 06:27:12 +0000 (15:27 +0900)]
elm: fix legacy callback names.

Summary:
this patch is fix of D10240.
there are few mischanges on callback names,
so fix it orginal legacy names,

SCROLL_CHANGED = "scroll"
SCROLL_ANIM_START = "scroll,anim,start"
SCROLL_ANIM_STOP = "scroll,anim,stop"
SCROLL_DRAG_START = "scroll,drag,start"
SCROLL_DRAG_STOP = "scroll,drag,stop"

Reviewers: bu5hm4n, eagleeye, akanad

Reviewed By: eagleeye

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10332

5 years agocsharp: updating eina_iterator docs and hide api.
Bruno da Silva Belo [Thu, 10 Oct 2019 04:46:51 +0000 (01:46 -0300)]
csharp: updating eina_iterator docs and hide api.

Summary: ref T8293

Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10330

5 years agocsharp: updating eina_inlist docs and hide api.
Bruno da Silva Belo [Thu, 10 Oct 2019 04:15:14 +0000 (01:15 -0300)]
csharp: updating eina_inlist docs and hide api.

Summary: ref T8293

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10329

5 years agocsharp: updating eina_inarray docs and hide api.
Bruno da Silva Belo [Thu, 10 Oct 2019 03:52:26 +0000 (00:52 -0300)]
csharp: updating eina_inarray docs and hide api.

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10328

5 years agoedje_entry: support "preedit_hilight" tag 45/215545/1
Bowon Ryu [Thu, 10 Oct 2019 12:05:11 +0000 (21:05 +0900)]
edje_entry: support "preedit_hilight" tag

separate "reverse" and "highlight" by VD request

@tizen_fix

Change-Id: I8d0221de8b321c84800924f4f729756632ac6648
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
5 years agointroduce script that generates widget hirachy accepted/tizen/unified/20191011.015425 submit/tizen/20191009.211935
Marcel Hollerbach [Thu, 5 Sep 2019 13:51:05 +0000 (15:51 +0200)]
introduce script that generates widget hirachy

this scripts generates a .svg with a hirachy like:
https://phab.enlightenment.org/file/data/jtiilbekufvfa77taf5y/PHID-FILE-5iwtamur4qxtktrcwh77/widget_hirachy.png

blue means something is stable, red means, something is beta.

This script requires ete3 to be installed. You can install it via with
pip with: `pip install ete3`

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9850

5 years agoexamples/emotion: remove dead code
Mike Blumenkrantz [Wed, 9 Oct 2019 17:22:44 +0000 (13:22 -0400)]
examples/emotion: remove dead code

this can never be reached

CID 1400928

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10322

5 years agotests/position_manager: initialize variable in declaration
Mike Blumenkrantz [Wed, 9 Oct 2019 17:07:24 +0000 (13:07 -0400)]
tests/position_manager: initialize variable in declaration

this member is never used anywhere, but it creates a CID

CID 1404747

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10319

5 years agoefl_ui/selection_manager: be explicit with sizeof() usage
Mike Blumenkrantz [Wed, 9 Oct 2019 17:19:36 +0000 (13:19 -0400)]
efl_ui/selection_manager: be explicit with sizeof() usage

Summary:
ensure we don't have issues with portability and type sizes

CID 1385141

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10201

5 years agocsharp: Respect beta for type aliases
Lauro Moura [Wed, 9 Oct 2019 14:39:38 +0000 (16:39 +0200)]
csharp: Respect beta for type aliases

Summary: Also add beta info to `alias_def` in eolian_cxx.

Reviewers: brunobelo, felipealmeida, woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10315

5 years agomono-docs: Merge Property and getter/setter docs
Xavi Artigas [Wed, 9 Oct 2019 14:18:14 +0000 (16:18 +0200)]
mono-docs: Merge Property and getter/setter docs

Summary:
Property docs, when present, should always be included in Property and Accessor
(setter and getter) docs.
Accessor docs, when present, should be included in their accessor method, and
also in the property method, as a side note.
This patch does just that.

Depends on D10285
Ref T8309

Test Plan: Generate docs and take a look at `Efl.Ui.Calendar`, for example, which has a bit of everything.

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8309

Differential Revision: https://phab.enlightenment.org/D10298

5 years agoeolian: Leave default text for libeolian users
Lauro Moura [Mon, 7 Oct 2019 08:51:36 +0000 (10:51 +0200)]
eolian: Leave default text for libeolian users

Summary:
Instead of setting the default text at the library level, keep the
summary empty if nothing is provided.

The libeolian users them are free to check if the summary was actually
empty or a placeholder text was added.

ref T8309

Test Plan: Run attached tests

Reviewers: q66, segfaultxavi

Subscribers: cedric, brunobelo, #reviewers, felipealmeida, #committers

Tags: #efl

Maniphest Tasks: T8309

Differential Revision: https://phab.enlightenment.org/D10285

5 years agoelua: fix error api in lua eolian bindings
Daniel Kolesa [Wed, 9 Oct 2019 11:19:50 +0000 (13:19 +0200)]
elua: fix error api in lua eolian bindings

5 years agocsharp: updating eina_binbuf docs and hide api.
Bruno da Silva Belo [Wed, 9 Oct 2019 01:05:34 +0000 (22:05 -0300)]
csharp: updating eina_binbuf docs and hide api.

Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10310

5 years agocsharp: updating eina_accessor docs and hide api.
Bruno da Silva Belo [Wed, 9 Oct 2019 00:49:04 +0000 (21:49 -0300)]
csharp: updating eina_accessor docs and hide api.

Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10308

5 years agocsharp: removing extra //
Bruno da Silva Belo [Tue, 8 Oct 2019 21:01:11 +0000 (18:01 -0300)]
csharp: removing extra //

Summary: dotnet warning about extras /

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10282

5 years agocsharp: Do not use the System Bus for testing.
Lauro Moura [Tue, 8 Oct 2019 20:56:37 +0000 (17:56 -0300)]
csharp: Do not use the System Bus for testing.

Summary: To allow the C# bindings running on the CI

Reviewers: zmike, brunobelo, felipealmeida, segfaultxavi, stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8313

Differential Revision: https://phab.enlightenment.org/D10283

5 years agoPyolian: rewritten tests for the pytest framework
Dave Andreoli [Tue, 8 Oct 2019 20:50:55 +0000 (22:50 +0200)]
Pyolian: rewritten tests for the pytest framework

...much more readable now, worst the pain! :)

5 years agoefl_ui/container: remove erroneous negative value checks for uint params
Mike Blumenkrantz [Tue, 8 Oct 2019 14:49:02 +0000 (16:49 +0200)]
efl_ui/container: remove erroneous negative value checks for uint params

Summary:
../src/lib/elementary/efl_ui_box.c: In function ‘_efl_ui_box_efl_gfx_arrangement_content_padding_set’:
../src/lib/elementary/efl_ui_box.c:411:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limit ]
  411 |    if (h < 0) h = 0;
      |          ^
../src/lib/elementary/efl_ui_box.c:412:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limit ]
  412 |    if (v < 0) v = 0;
      |          ^
../src/lib/elementary/efl_ui_table.c: In function ‘_efl_ui_table_efl_gfx_arrangement_content_padding_set’:
../src/lib/elementary/efl_ui_table.c:272:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  272 |    if (h < 0) h = 0;
      |          ^
../src/lib/elementary/efl_ui_table.c:273:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  273 |    if (v < 0) v = 0;
      |          ^

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10304

5 years agoevas_vg_cache: Hashkey of cache use value provider list
JunsuChoi [Tue, 8 Oct 2019 09:13:43 +0000 (18:13 +0900)]
evas_vg_cache: Hashkey of cache use value provider list

Summary:
Even if the same window, the same file, and the same size,
different images may be requested due to property changes caused by value_provider.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10303

Change-Id: I7e079a488002c4b17614a823f9138af2eee5c540

5 years agocsharp: Add some docs to MVVM infrastructure
Lauro Moura [Tue, 8 Oct 2019 08:04:57 +0000 (10:04 +0200)]
csharp: Add some docs to MVVM infrastructure

Reviewers: SanghyeonLee, felipealmeida, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10301

5 years agoevas_vg_cache: Hashkey of cache use value provider list 65/215465/1
JunsuChoi [Tue, 8 Oct 2019 09:13:43 +0000 (18:13 +0900)]
evas_vg_cache: Hashkey of cache use value provider list

Summary:
Even if the same window, the same file, and the same size,
different images may be requested due to property changes caused by value_provider.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10303

Change-Id: I9044287005ab897dab654fd47eb3f88c0c34453b

5 years agoelm_widget: Add a API to raise focus_order. 26/215426/1
Yeongjong Lee [Mon, 7 Oct 2019 09:45:37 +0000 (18:45 +0900)]
elm_widget: Add a API to raise focus_order.

This patch will fix genlist center align issue.

```
Elm_Genlist_Item_Class itc, ctc;

static Evas_Object*
_gl_check_get(void *data, Evas_Object *obj, const char *part)
{
   if (strcmp(part, "elm.icon")) return NULL;

   Evas_Object *content = elm_check_add(obj);
   elm_object_style_set(content, "on&off");
   elm_check_state_set(content, EINA_FALSE);
   evas_object_show(content);

   return content;
}

void
_btn_cb(void *data, Evas_Object *obj, void *event_info)
{
   Evas_Object *nf = data;

   Evas_Object *btn = elm_button_add(nf);
   evas_object_size_hint_weight_set(btn, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(btn, EVAS_HINT_FILL, EVAS_HINT_FILL);
   elm_object_text_set(btn, "button");

   elm_naviframe_item_push(nf, "Default Styles", NULL, NULL, btn, NULL);
}

static void
create_list_view(appdata_s *ad)
{
   Evas_Object *nf = ad->nf;

   Evas_Object *genlist = elm_genlist_add(nf);
   elm_genlist_mode_set(genlist, ELM_LIST_COMPRESS);
   evas_object_smart_callback_add(genlist, "selected", gl_selected_cb, NULL);

   itc.item_style = "1text.1icon";
   itc.func.text_get = _gl_text_get;

   ctc.item_style = "1text.1icon.1";
   ctc.func.text_get = _gl_check_text_get;
   ctc.func.content_get = _gl_check_get;

   elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);
   elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);
   // item with check
   elm_genlist_item_append(genlist, &ctc, NULL, NULL, ELM_GENLIST_ITEM_NONE, NULL, NULL);
   elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);
   elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);

   elm_naviframe_item_push(nf, NULL, NULL, NULL, genlist, "empty");
}
```
Test Plan
1. Click on&off check widget.
2. Click text item below. (button view is pushed.)
3. Click back button.
4. Check that genlist item keep center align

@tizen_fix

Change-Id: Ie0946b65d952d51c0204c5b5d82660ac3887d7f0

5 years agotizen_genlist: restore legacy focus 25/215425/1
Yeongjong Lee [Tue, 8 Oct 2019 02:42:41 +0000 (11:42 +0900)]
tizen_genlist: restore legacy focus

@tizen_fix

Change-Id: I7fe206f1bcda94deeecc2214e13e91ac2c568b92

5 years agoPyolian: implement some missing eolian functions accepted/tizen/unified/20191010.032847 submit/tizen/20191007.211537 submit/tizen/20191008.054409 submit/tizen/20191008.233305
Dave Andreoli [Mon, 7 Oct 2019 20:38:04 +0000 (22:38 +0200)]
Pyolian: implement some missing eolian functions

with tests

5 years agoPyolian gendoc: make link to events actually work
Dave Andreoli [Mon, 7 Oct 2019 19:17:10 +0000 (21:17 +0200)]
Pyolian gendoc: make link to events actually work

5 years agoPyolian gendoc: use some aux eolian functions to simplify templates
Dave Andreoli [Mon, 7 Oct 2019 18:32:05 +0000 (20:32 +0200)]
Pyolian gendoc: use some aux eolian functions to simplify templates

5 years agoPyolian gendoc: add ability to generate only the stable API
Dave Andreoli [Mon, 7 Oct 2019 17:38:50 +0000 (19:38 +0200)]
Pyolian gendoc: add ability to generate only the stable API

gendoc.py --exclude-beta

generate the docs excluding all the classes/types/etc in beta state,
a bit hackish but do the job. There are some broken links around that
refer to objects in beta state that are (correctly) not generated,
nothing we can do to fix this.

5 years agoefl_ui/win: initialize max size hints to -1 during constructor
Mike Blumenkrantz [Mon, 7 Oct 2019 16:49:19 +0000 (18:49 +0200)]
efl_ui/win: initialize max size hints to -1 during constructor

Summary:
this is just a cosmetic change for ease of debugging since it will already
be clamped to max size during eval if it remains unchanged

for max size hints a value of -1 means that the hint is unset but a value
of 0 is technically valid depending on the implementation
Depends on D10296

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10297

5 years agoefl_ui/win: fix max size hint eval
Mike Blumenkrantz [Mon, 7 Oct 2019 16:40:10 +0000 (18:40 +0200)]
efl_ui/win: fix max size hint eval

Summary:
win objects should never permit the max size on any axis to be 0, otherwise
the window will be clamped to 1px on the given axis

fixes T8304
@fix
Depends on D10272

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8304

Differential Revision: https://phab.enlightenment.org/D10296

5 years agoci: fix return value warning in test build code
Mike Blumenkrantz [Mon, 7 Oct 2019 16:40:09 +0000 (18:40 +0200)]
ci: fix return value warning in test build code

Summary: this is a void function

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10272

5 years agodocs: Remove redundant documentation
Xavi Artigas [Mon, 7 Oct 2019 14:40:50 +0000 (16:40 +0200)]
docs: Remove redundant documentation

Lots of EO files had the same information at the property and set/get level.
Removed the redundant bits, and moved to the property level the common ones.
Set and Get documentation should be used only to clarify setter-only or
getter-only behavior.

5 years agoeldbus: properly cleanup local variable during destruction.
Cedric BAIL [Mon, 7 Oct 2019 14:04:18 +0000 (10:04 -0400)]
eldbus: properly cleanup local variable during destruction.

Summary: Depends on D10288

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: zmike

Subscribers: ProhtMeyhet, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10289

5 years agoeldbus: connection are destroyed on invalidate, there is no point for any object...
Cedric BAIL [Mon, 7 Oct 2019 14:04:12 +0000 (10:04 -0400)]
eldbus: connection are destroyed on invalidate, there is no point for any object to not cleanup on invalidate.

Summary:
This solve a bug when there is a change in order of destruction and you would expect the model to still work.
Depends on D10287

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10288

5 years agoeldbus: Eldbus_Proxy require to handle self desctruction as refcounting doesn't fully...
Cedric BAIL [Mon, 7 Oct 2019 14:04:05 +0000 (10:04 -0400)]
eldbus: Eldbus_Proxy require to handle self desctruction as refcounting doesn't fully protect.

Summary:
If the connection is destroyed before the proxy, the proxy will clear itself and self destroy.
Before that it will trigger the free callback to handle proper cleanup. Refcounting it doesn't
protect it from this self destruction scenario. So it is mandatory to always have a free callback
set on a proxy to handle its death properly.
Depends on D10286

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10287

5 years agoeldbus: properly call parent finalize during creation of Eldbus.Model_Method.
Cedric BAIL [Mon, 7 Oct 2019 14:03:58 +0000 (10:03 -0400)]
eldbus: properly call parent finalize during creation of Eldbus.Model_Method.

Summary: @fix

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10286

5 years agoefl_test_multi_selectable: ensure consistant state across mode switch
Marcel Hollerbach [Mon, 7 Oct 2019 13:38:25 +0000 (09:38 -0400)]
efl_test_multi_selectable: ensure consistant state across mode switch

Summary:
When we are in multi, and switch back to single or none, we should
ensure that the state is corrently. Same applies to single -> none.

Reviewers: segfaultxavi, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10277

5 years agoefl_ui_image: fix backward compatibility issue
WooHyun Jung [Mon, 7 Oct 2019 13:38:14 +0000 (09:38 -0400)]
efl_ui_image: fix backward compatibility issue

Summary:
Previously, "anim" property was saved before checking
evas-image's "animated" stated. This patch just corrects
the issue.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10293

5 years agoefl_ui_spec: introduce tests that ensure we are not leaking objects
Marcel Hollerbach [Mon, 7 Oct 2019 13:38:12 +0000 (09:38 -0400)]
efl_ui_spec: introduce tests that ensure we are not leaking objects

Summary:
with those two tests we are checking two things:
- Check that there is no left out canvas object after the widget is
invalidated but not deleted. For now this only deals with canvas
objects.
- Additionally this also ensures that ref;del;unref as well as simple
del is never ever going to end up in a error, even with children beeing
added.

This pretty much mirrors the tests for legacy in
0d48cb46d45184608bbbbafa298f0f719e35688f , except that these tests do
not check for evas parent contsruction vs. real widget parent
construction. Which is intendet, as none-legacy widgets do error out
when a not widget object is passed as parent.
Depends on D10291

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10292

5 years agoefl_ui_datepicker: no need to delete the manager here
Marcel Hollerbach [Mon, 7 Oct 2019 13:38:05 +0000 (09:38 -0400)]
efl_ui_datepicker: no need to delete the manager here

Summary:
it is already picked up when datetime is invalidated, due to the correct
parent beeing set.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10291

5 years agoc: coverity: resource leaked when using realloc.
Bruno da Silva Belo [Mon, 7 Oct 2019 13:02:10 +0000 (09:02 -0400)]
c: coverity: resource leaked when using realloc.

Summary:
from https://en.cppreference.com/w/c/memory/realloc
```
On success, returns the pointer to the beginning of newly allocated memory.
To avoid a memory leak, the returned pointer must be deallocated with free()
or realloc(). The original pointer ptr is invalidated and any access to it
is undefined behavior (even if reallocation was in-place).

On failure, returns a null pointer. The original pointer ptr remains valid
and may need to be deallocated with free() or realloc(). ```
So a temporary to test if `realloc` failed
then use the original pointer to use `free`.
`CID1404749`
`CID1404741`

Reviewers: lauromoura, felipealmeida, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10284