platform/upstream/dotnet/runtime.git
2 years agoRemove coverlet.collector reference from LibraryImportGenerator tests (#69078)
Elinor Fung [Tue, 10 May 2022 00:54:40 +0000 (17:54 -0700)]
Remove coverlet.collector reference from LibraryImportGenerator tests (#69078)

2 years ago[mono] Avoid an assertion when cattrs with array parameters are constructed during...
Zoltan Varga [Tue, 10 May 2022 00:40:31 +0000 (20:40 -0400)]
[mono] Avoid an assertion when cattrs with array parameters are constructed during AOT. (#69077)

Fixes https://github.com/dotnet/runtime/issues/57361.

2 years agoFix namespace in error message (#69083)
Jan Kotas [Tue, 10 May 2022 00:09:23 +0000 (17:09 -0700)]
Fix namespace in error message (#69083)

DisableRuntimeMarshallingAttribute is under System.Runtime.CompilerServices

2 years agoAdd the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefi...
Lakshan Fernando [Mon, 9 May 2022 22:19:44 +0000 (15:19 -0700)]
Add the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefinitionAs (#69057)

* Fix for issue 67533

* FB

2 years ago[main] Update dependencies from 7 repositories (#68126)
dotnet-maestro[bot] [Mon, 9 May 2022 19:39:40 +0000 (14:39 -0500)]
[main] Update dependencies from 7 repositories (#68126)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20220416.9

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.22215.3 -> To Version 1.0.0-prerelease.22216.9

* Update dependencies from https://github.com/dotnet/runtime build 20220417.5

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.4.22217.5

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20220417.3

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.22215.3 -> To Version 1.0.0-prerelease.22217.3

* Update dependencies from https://github.com/dotnet/icu build 20220418.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.4.22218.1

* Update dependencies from https://github.com/dotnet/xharness build 20220419.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22219.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220418.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22218.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20220418.2

runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22218.2

* Update dependencies from https://github.com/dotnet/icu build 20220419.2

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22219.2

* Update dependencies from https://github.com/dotnet/emsdk build 20220419.2

Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22219.2

* Update dependencies from https://github.com/dotnet/xharness build 20220420.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22220.1

* Update dependencies from https://github.com/dotnet/runtime build 20220424.3

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22224.3

* Update dependencies from https://github.com/dotnet/icu build 20220425.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22225.1

* Update dependencies from https://github.com/dotnet/xharness build 20220425.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22225.1

* Update dependencies from https://github.com/dotnet/emsdk build 20220425.1

Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22225.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20220425.2

runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22225.2

* Update dependencies from https://github.com/dotnet/xharness build 20220426.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22226.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20220426.1

runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22226.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220429.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22229.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220430.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22230.1

* Update dependencies from https://github.com/dotnet/runtime build 20220501.6

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22251.6

* Update dependencies from https://github.com/dotnet/xharness build 20220502.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22252.1

* Update dependencies from https://github.com/dotnet/icu build 20220502.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22252.1

* Update dependencies from https://github.com/dotnet/xharness build 20220503.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22253.1

* Update dependencies from https://github.com/dotnet/emsdk build 20220502.1

Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22252.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220502.2

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22252.2

* Update dependencies from https://github.com/dotnet/llvm-project build 20220502.1

runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 1.0.0-alpha.1.22204.1 -> To Version 1.0.0-alpha.1.22252.1

* Update dependencies from https://github.com/dotnet/xharness build 20220503.2

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22253.2

* Update dependencies from https://github.com/dotnet/xharness build 20220504.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22254.1

* Update dependencies from https://github.com/dotnet/xharness build 20220506.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22256.1

* Update dependencies from https://github.com/dotnet/xharness build 20220506.2

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22256.2

* Update dependencies from https://github.com/dotnet/runtime build 20220508.4

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22258.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Egor Bogatov <egorbo@gmail.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
2 years ago[mono][arm64] Save the full 128 bit simd argument registers in the trampoline code...
Zoltan Varga [Mon, 9 May 2022 19:26:51 +0000 (15:26 -0400)]
[mono][arm64] Save the full 128 bit simd argument registers in the trampoline code. (#68997)

2 years agoMark "push [mem]" candidates reg optional (#68641)
SingleAccretion [Mon, 9 May 2022 18:39:58 +0000 (21:39 +0300)]
Mark "push [mem]" candidates reg optional (#68641)

2 years agoformat correctly chuncked response with Content-Length header (#69016)
Badre BSAILA [Mon, 9 May 2022 18:38:44 +0000 (20:38 +0200)]
format correctly chuncked response with Content-Length header (#69016)

2 years agoInitialize "VNFuncApp.m_func" in "VNForBitCast" (#69051)
SingleAccretion [Mon, 9 May 2022 18:08:06 +0000 (21:08 +0300)]
Initialize "VNFuncApp.m_func" in "VNForBitCast" (#69051)

2 years agoFix formatting job on windows (#69054)
Jakob Botsch Nielsen [Mon, 9 May 2022 17:23:46 +0000 (19:23 +0200)]
Fix formatting job on windows (#69054)

2 years agoRemove an allocation during CNG RSA key generation
Kevin Jones [Mon, 9 May 2022 15:38:36 +0000 (11:38 -0400)]
Remove an allocation during CNG RSA key generation

Spanify CngProperty to remove a temporary `new byte[4]`.

Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
2 years agoJIT: minor enhancement to jump threading (#69022)
Andy Ayers [Mon, 9 May 2022 15:10:19 +0000 (08:10 -0700)]
JIT: minor enhancement to jump threading (#69022)

Allow jump threading of branches with exceptions, provided the branch and the
dominating branch are in the same EH region.

2 years agoSpecify action permissions in cleanup task (#69014)
Adeel Mujahid [Mon, 9 May 2022 14:21:29 +0000 (17:21 +0300)]
Specify action permissions in cleanup task (#69014)

2 years agoAdd IL Emit support for MethodInfo.Invoke() and friends (#67917)
Steve Harter [Mon, 9 May 2022 14:11:28 +0000 (09:11 -0500)]
Add IL Emit support for MethodInfo.Invoke() and friends (#67917)

2 years agoFix packs.product subset build with gcc (#68998)
Adeel Mujahid [Mon, 9 May 2022 11:56:12 +0000 (14:56 +0300)]
Fix packs.product subset build with gcc (#68998)

2 years agoRemove GT_PUTARG_TYPE (#68748)
Jakob Botsch Nielsen [Mon, 9 May 2022 09:57:04 +0000 (11:57 +0200)]
Remove GT_PUTARG_TYPE (#68748)

This change removes GT_PUTARG_TYPE by storing the signature type of the argument inside CallArg right away when arguments are added, instead of only from morph and on.

2 years agoClean up specialized value num functions (#69013)
Jakob Botsch Nielsen [Mon, 9 May 2022 09:55:46 +0000 (11:55 +0200)]
Clean up specialized value num functions (#69013)

The reason the operator== implementation was not unrolled previously was
just because I used an early exit. Without the early exit it is unrolled
fine.

2 years agoMerge pull request #67771 from dotnet/darc-main-31d4c308-6782-4440-8589-61f58f239059
Andy Gocke [Mon, 9 May 2022 07:27:05 +0000 (00:27 -0700)]
Merge pull request #67771 from dotnet/darc-main-31d4c308-6782-4440-8589-61f58f239059

[main] Update dependencies from dotnet/arcade

2 years agorefactor SslStream internals (#68678)
Tomas Weinfurt [Mon, 9 May 2022 06:32:22 +0000 (23:32 -0700)]
refactor SslStream internals (#68678)

* refactor SslStream internals

* fix validation and certs

* update fakes

* feedback from review

2 years agoSimple runtime.yml change hoping it fixes rolling builds not triggering (#69029)
Jakob Botsch Nielsen [Sun, 8 May 2022 19:59:02 +0000 (21:59 +0200)]
Simple runtime.yml change hoping it fixes rolling builds not triggering (#69029)

2 years agoOverride CompleteAsync() in StreamPipeReader to call Stream.DisposeAsync (#67565)
madelson [Sun, 8 May 2022 16:51:58 +0000 (12:51 -0400)]
Override CompleteAsync() in StreamPipeReader to call Stream.DisposeAsync (#67565)

* Override CompleteAsync() in StreamPipeReader to call Stream.DisposeAsync().

fix #67050

* Apply suggestions from code review

Co-authored-by: David Fowler <davidfowl@gmail.com>
* Update StreamPipeReader.cs

Feedback from code review

Co-authored-by: David Fowler <davidfowl@gmail.com>
2 years agoOptimize bswap+mov to movbe on xarch (#66965)
Joni Aromaa [Sun, 8 May 2022 12:35:08 +0000 (15:35 +0300)]
Optimize bswap+mov to movbe on xarch (#66965)

2 years agoAdd Interlocked.{Compare}Exchange for UIntPtr (#68966)
Stephen Toub [Sat, 7 May 2022 19:00:05 +0000 (15:00 -0400)]
Add Interlocked.{Compare}Exchange for UIntPtr (#68966)

2 years agoCoreRT to NativeAOT renames (#68950)
Jan Kotas [Sat, 7 May 2022 18:59:22 +0000 (11:59 -0700)]
CoreRT to NativeAOT renames (#68950)

2 years agoFix typos (#69011)
Adeel Mujahid [Sat, 7 May 2022 18:55:53 +0000 (21:55 +0300)]
Fix typos (#69011)

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20220505.2
dotnet-maestro[bot] [Sat, 7 May 2022 12:22:06 +0000 (12:22 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20220505.2

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22179.1 -> To Version 2.5.1-beta.22255.2

2 years agoImplement IAsyncEnumerable source generator support (#68985)
Eirik Tsarpalis [Sat, 7 May 2022 09:43:21 +0000 (12:43 +0300)]
Implement IAsyncEnumerable source generator support (#68985)

* implement IAsyncEnumerable support for sourcegen

* address feedback

2 years ago[eventpipe] Fix environment variable parser for multiple configurations (#68552)
Stefan Schulze Frielinghaus [Sat, 7 May 2022 09:06:04 +0000 (11:06 +0200)]
[eventpipe] Fix environment variable parser for multiple configurations (#68552)

2 years agoMove away from exposing internal EventPipe wait handle to EventPipeEventDispatcher...
Johan Lorensson [Sat, 7 May 2022 09:01:00 +0000 (11:01 +0200)]
Move away from exposing internal EventPipe wait handle to EventPipeEventDispatcher. (#68320)

* Move away from exposing internal EventPipe wait handle to EventPipeEventDispatcher.

Fix for issue, #68032.

EventPipe exposed and internal wait handle to EventPipeEventDispatcher.
The wait handle is not a managed WaitableObject, but maps to runtime
specific event types:

CLREventStatic * on CoreCLR
mono_w32event_create on Mono

Overtime it appears that the underlying WaitHandle changed on none Windows
platforms, so calls like:

EventWaitHandle.Set

Assumes that IntPtr used is a WaitableObject and on Mono this will cause
a crash, but on CoreCLR, it will just be casted over to a WaitableObject
and use it, so based on memory layout this could cause issue, but looking
at the implementation, it appears it will always assume EventWaitHandle
is signaled so won't touch any of the memory (but not signal the event).

There have been an ambition in DispatchEventsToEventListeners to move
this abstraction down into native code, get away from using a handle
returned from EventPipeInternal.GetWaitHandle as a EventWaitHandle. This
PR eliminate EventPipeInternal.GetWaitHandle and adds a SignalSession and
WaitForSessionSignal icall's (Mono), qcall's (CoreCLR) and fix the
issue caused by exposing the handle to managed code.

2 years ago[mono] Fix read of image_info while raising image_unload event (#67138)
Stefan Schulze Frielinghaus [Sat, 7 May 2022 08:53:31 +0000 (10:53 +0200)]
[mono] Fix read of image_info while raising image_unload event (#67138)

2 years agoNormalize S.S.Cryptography's ref.cs file (#68993)
Jeremy Barton [Sat, 7 May 2022 05:14:33 +0000 (22:14 -0700)]
Normalize S.S.Cryptography's ref.cs file (#68993)

The order of some EditorBrowsables and Obsoletes seems to have flipped,
and the whitespace in ObsoleteAttribute DIagnosticId/UriFormat setters.

2 years agoAdd basic fake NTLM server to test NTAuthentication round-trip scenarios (#65611)
Filip Navara [Sat, 7 May 2022 03:47:08 +0000 (05:47 +0200)]
Add basic fake NTLM server to test NTAuthentication round-trip scenarios (#65611)

* Add basic NTLM fake server to test NTAuthentication round-trip scenarios

* Treat MIC as optional on Linux

* Add guard for IsNtlmInstalled

* Add comments; add protocol exchange example from NTLM specification

* Test both correct and incorrect credentials

* Check the SPN sent by client

* Replace NtlmAssert with regular Xunit Assert to get better messages

* Tweak algorithm for calculating flags in CHALLENGE_MESSAGE, add support for OEM encoding

* Set the NegotiateTargetInfo on CHALLENGE_MESSAGE; relax the check for Linux due to a bug in gss-ntlmssp

* Remove duplicate implementation of RC4.

* Fix paths.

* Rename EnableDllImportGenerator to EnableLibraryImportGenerator.

2 years agoFix wording in failure to load native library (#68995)
Brennan [Sat, 7 May 2022 00:55:56 +0000 (17:55 -0700)]
Fix wording in failure to load native library (#68995)

2 years agoUpdating Complex to implement INumberBase and ISignedNumber (#68612)
Tanner Gooding [Sat, 7 May 2022 00:19:10 +0000 (17:19 -0700)]
Updating Complex to implement INumberBase and ISignedNumber (#68612)

* Updating Complex to implement INumberBase and ISignedNumber

* Adding generic math tests for Complex

* Fixing some generic math tests for Complex to match the current behavior around -0

* Update src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.cs

Co-authored-by: Drew Kersnar <dakersnar@me.com>
Co-authored-by: Drew Kersnar <dakersnar@me.com>
2 years ago[mono][llvm] Fix support for --break + LLVM. (#68982)
Zoltan Varga [Fri, 6 May 2022 23:58:30 +0000 (19:58 -0400)]
[mono][llvm] Fix support for --break + LLVM. (#68982)

2 years agoDynamically sized stacks in EventPipe buffer manager (#68134)
John Salem [Fri, 6 May 2022 23:17:46 +0000 (16:17 -0700)]
Dynamically sized stacks in EventPipe buffer manager (#68134)

2 years agoBreak ExtensionsTests.cs into one file per type tested
Jeremy Barton [Fri, 6 May 2022 21:21:40 +0000 (14:21 -0700)]
Break ExtensionsTests.cs into one file per type tested

This change is essentially just style, no tests have been altered, added, or removed.

The tests that were about a particular extension have moved to a class named
for the type being tested (with the X509 prefix and Extension suffix omitted).
Now that the type tested is inferred from the name, the method names were
adjusted accordingly. e.g. ExtensionsTests.KeyUsageExtension_CrlSign is now
KeyUsageTests.EncodeDecode_CrlSign

The one test that wasn't about a single extension is now in the file
ExtensionsTests\ComprehensiveTests.cs, as it checks all of the extensions,
and the order of the extensions, from an existing certificate.

2 years agoRevert bad version reversions from 85d2aff4da96ac01babd461a1c76c358d4979d68
Larry Ewing [Fri, 6 May 2022 21:20:47 +0000 (16:20 -0500)]
Revert bad version reversions from 85d2aff4da96ac01babd461a1c76c358d4979d68

2 years agoUpdate dependencies from https://github.com/dotnet/linker build 20220506.1
dotnet-maestro[bot] [Fri, 6 May 2022 20:25:04 +0000 (20:25 +0000)]
Update dependencies from https://github.com/dotnet/linker build 20220506.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22255.1 -> To Version 7.0.100-1.22256.1

2 years agoUpdate libunwind to latest (#68899)
Jan Vorlicek [Fri, 6 May 2022 20:29:59 +0000 (22:29 +0200)]
Update libunwind to latest (#68899)

* Update libunwind

This change updates libunwind copy by a fix for non-4kB page sizes
that is needed e.g. for Linux arm64 with kernel set to use 64kB page
sizes (RHEL8 is one such case).

It also applies a fix for incorrect register storage in ARM64
getcontext.

* Add dummy `write` method implementation

* Update src/native/external/libunwind-version.txt

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
2 years agoAllow running System.Reflection tests on NativeAOT (#67575)
Michal Strehovský [Fri, 6 May 2022 20:05:55 +0000 (05:05 +0900)]
Allow running System.Reflection tests on NativeAOT (#67575)

Baselines/annotates anything that needs baselining/annotating.

2 years agoFix the Version.Details.xml entry for Microsoft.CodeAnalysis.NetAnalyzers (#68973)
Larry Ewing [Fri, 6 May 2022 19:54:20 +0000 (14:54 -0500)]
Fix the Version.Details.xml entry for Microsoft.CodeAnalysis.NetAnalyzers (#68973)

2 years agoSync shared code from aspnetcore (#68965)
github-actions[bot] [Fri, 6 May 2022 19:11:02 +0000 (12:11 -0700)]
Sync shared code from aspnetcore (#68965)

2 years agoThrow from MsQuicImplementationProvider if not supported. (#68833)
Radek Zikmund [Fri, 6 May 2022 19:07:09 +0000 (12:07 -0700)]
Throw from MsQuicImplementationProvider if not supported. (#68833)

* Throw from MsQuicImplementationProvider if not supported.

* Add tests

2 years agoAdd WaitAsync to prevent CI hangs (#68955)
Radek Zikmund [Fri, 6 May 2022 19:01:18 +0000 (12:01 -0700)]
Add WaitAsync to prevent CI hangs (#68955)

2 years agoDeprecate ICU ucol_safeClone and support ucol_clone (#68847)
Tarek Mahmoud Sayed [Fri, 6 May 2022 16:43:36 +0000 (09:43 -0700)]
Deprecate ICU ucol_safeClone and support ucol_clone (#68847)

2 years agoApply changes from #63356 (#68864)
John Salem [Fri, 6 May 2022 16:31:17 +0000 (09:31 -0700)]
Apply changes from #63356 (#68864)

2 years agoMerge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589...
Larry Ewing [Fri, 6 May 2022 15:25:31 +0000 (10:25 -0500)]
Merge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589-61f58f239059

2 years agoMake concurrent reads on HttpHeaders thread-safe (#68115)
Miha Zupan [Fri, 6 May 2022 15:04:28 +0000 (17:04 +0200)]
Make concurrent reads on HttpHeaders thread-safe (#68115)

2 years ago[main] Update dependencies from dotnet/linker (#68854)
dotnet-maestro[bot] [Fri, 6 May 2022 14:50:44 +0000 (09:50 -0500)]
[main] Update dependencies from dotnet/linker (#68854)

* Update dependencies from https://github.com/dotnet/linker build 20220503.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22252.2 -> To Version 7.0.100-1.22253.2

* Update dependencies from https://github.com/dotnet/linker build 20220505.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22252.2 -> To Version 7.0.100-1.22255.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
2 years agoAdd a cleanup job to backport workflow (#68596)
Adeel Mujahid [Fri, 6 May 2022 14:32:30 +0000 (17:32 +0300)]
Add a cleanup job to backport workflow (#68596)

* Add a cleanup job to backport workflow

* Add once a day schedule

* Pass GH token to the job

2 years agoDisabled k-nucleotide test on mono. (#68910)
Nathan Ricci [Fri, 6 May 2022 12:54:42 +0000 (08:54 -0400)]
Disabled k-nucleotide test on mono. (#68910)

2 years agoPhysical value numbering (#68712)
SingleAccretion [Fri, 6 May 2022 10:55:42 +0000 (13:55 +0300)]
Physical value numbering (#68712)

Value numbering supports precise numbering of field accesses using "maps":
where each access is modeled as a selection: "map[indices...]". It has been
the case until this change that said indices were always "precise" - VNs
of field handles.

This system has proven to be problematic for representing struct field access:

 1) The precise model effectively means that each field access represented
    by a unique handle cannot alias access to the same location, but using
    a different handle. This meant that reinterpretation of structs, reasonably
    common both in user code and in the IR compiler creates itself, was UB.
 2) The precise model for struct fields entailed supporting "zero-offset
    field sequences", which were maintained in a side map and caused a good
    number of bugs.

This change solves both of these problems by eliminating the need to use
precise selectors for struct fields, introducing a new kind of selector
(and maps to go with it): "the physical selector": offset plus load/store
size, with "VNForMapSelectWork" enhanced to look through physical store
maps, correctly detecting aliasing.

The precise selection rules are maintained for the maps indexing off of the
heap, where we don't have the same aliasing concerns. Physical maps are now
used exclusively for numbering locals.

This change seeks to preserve previous behavior to avoid diffs: many places
with now-not-needed pessimization are marked with "TODO-PhysicalVN". Similarly,
the field sequence infrastructure supporting the old precise selection scheme
is retained in its full generality. Future changes are expected to remove much
of it.

2 years agoFix double-validation in BoundedChannelOptions (#68938)
Armin Shoeibi [Fri, 6 May 2022 09:54:58 +0000 (14:24 +0430)]
Fix double-validation in BoundedChannelOptions (#68938)

2 years agoFix Regex handling of control characters (#68944)
Stephen Toub [Fri, 6 May 2022 09:54:43 +0000 (05:54 -0400)]
Fix Regex handling of control characters (#68944)

It was using the C category rather than Cc category.  And the test for this was missing the combined categories.

2 years agoRevert "Disable win-arm64 runtime tests on PRs for CoreCLR (#68627)" (#68922)
Jakob Botsch Nielsen [Fri, 6 May 2022 08:43:51 +0000 (10:43 +0200)]
Revert "Disable win-arm64 runtime tests on PRs for CoreCLR (#68627)" (#68922)

Testing capacity is back to a point where we have been told we can try
reenabling our workloads.

2 years agoImprove impPopCallArgs (#68736)
Jakob Botsch Nielsen [Fri, 6 May 2022 08:15:32 +0000 (10:15 +0200)]
Improve impPopCallArgs (#68736)

2 years agoAdd Mac ARM64 coverage to runtime-dev-innerloop (#68886)
Andy Gocke [Fri, 6 May 2022 03:13:45 +0000 (20:13 -0700)]
Add Mac ARM64 coverage to runtime-dev-innerloop (#68886)

* Add Mac ARM64 coverage to runtime-dev-innerloop

* Include global-build.yml

* Remove excludes entirely

2 years agoRevert "[QUIC] Adopted msquic generated interop (#68288)" (#68940)
Jan Kotas [Fri, 6 May 2022 02:20:52 +0000 (19:20 -0700)]
Revert "[QUIC] Adopted msquic generated interop (#68288)" (#68940)

This reverts commit 992b395a72d161bb2346258a726fb93b10f0d7e7.

2 years agoFix System.Collections.Immutable version in ILCompiler.Build.Tasks (#68935)
Logan Bussell [Fri, 6 May 2022 02:18:27 +0000 (19:18 -0700)]
Fix System.Collections.Immutable version in ILCompiler.Build.Tasks (#68935)

* Fix System.Collections.Immutable version in ILCompiler

* Add SystemCollectionsImmutableVersion to Versions.props

2 years agoRename CoreRT to NativeAOT (1/N) (#68888)
Jan Kotas [Fri, 6 May 2022 01:14:28 +0000 (18:14 -0700)]
Rename CoreRT to NativeAOT (1/N) (#68888)

Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
2 years agoEnable dumping of R2R manifest metadata from ildasm (#68920)
David Wrighton [Fri, 6 May 2022 00:42:43 +0000 (17:42 -0700)]
Enable dumping of R2R manifest metadata from ildasm (#68920)

Use the /r2rnativemetadata switch to dump the data. NOTE: this switch is only to be used on non-composite images. composite images can be read using the normal ildasm commands.

2 years agoMerge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589...
Andy Gocke [Fri, 6 May 2022 00:41:36 +0000 (17:41 -0700)]
Merge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589-61f58f239059

2 years agoUpdate ApiCompat to exclude UnsupportedOSPlatform["freebsd"] on Lock/Unlock (#68941)
David Cantú [Fri, 6 May 2022 00:35:37 +0000 (17:35 -0700)]
Update ApiCompat to exclude UnsupportedOSPlatform["freebsd"] on Lock/Unlock (#68941)

2 years agoSystem.Diagnostics.ActivityLink/ActivityEvent: Implement EnumerateTagObjects API...
Mikel Blanchard [Fri, 6 May 2022 00:23:03 +0000 (17:23 -0700)]
System.Diagnostics.ActivityLink/ActivityEvent: Implement EnumerateTagObjects API (#68933)

2 years agoMerge remote-tracking branch 'upstream/darc-main-f4af19cb-ce6b-425c-9c5b-dbc3910ea794...
Andy Gocke [Thu, 5 May 2022 23:55:39 +0000 (16:55 -0700)]
Merge remote-tracking branch 'upstream/darc-main-f4af19cb-ce6b-425c-9c5b-dbc3910ea794' into darc-main-31d4c308-6782-4440-8589-61f58f239059

2 years agoRevert FileSystemEventArgs/RenamedEventArgs FullPath/OldFullPath changes (#68883)
Jeff Handley [Thu, 5 May 2022 23:54:08 +0000 (16:54 -0700)]
Revert FileSystemEventArgs/RenamedEventArgs FullPath/OldFullPath changes (#68883)

* Revert daec9dc (PR #68582)

* Revert 2a1b15d (PR #63051)

* Restore additional tests adapted to match prior behavior

* Remove unnecessary PathInternal inclusion

* PR feedback

* Fix unix tests (copy/paste error)

2 years agoFix ProfileOptimization test
Dan Moseley [Thu, 5 May 2022 23:01:10 +0000 (17:01 -0600)]
Fix ProfileOptimization test

2 years agoUpdate dependencies from https://github.com/dotnet/linker build 20220505.1
dotnet-maestro[bot] [Thu, 5 May 2022 23:48:20 +0000 (23:48 +0000)]
Update dependencies from https://github.com/dotnet/linker build 20220505.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22252.2 -> To Version 7.0.100-1.22255.1

2 years agoUse more char.Is helpers from RegexCompiler / source generator (#68924)
Stephen Toub [Thu, 5 May 2022 21:52:52 +0000 (17:52 -0400)]
Use more char.Is helpers from RegexCompiler / source generator (#68924)

This PR causes regex to now specially-recognize additional categories that map to sets `char` already has `IsXx` methods for and call them, e.g. `char.IsControl`, `char.IsLetter`, etc.

2 years agoDetect the default locale name during startup on Apple platforms (#68706)
Steve Pfister [Thu, 5 May 2022 21:13:36 +0000 (17:13 -0400)]
Detect the default locale name during startup on Apple platforms (#68706)

This change adds a function to lookup the current NSLocale and extract the language + country code to load into ICU by default. Previously, we would defer to uloc_getDefault in ICU, which would return a value we would ignore (en_US_POSIX) and result in falling back to invariant mode.

Fixes #68321

2 years agoDo not fold relocatable constants into displacements (#68851)
SingleAccretion [Thu, 5 May 2022 19:32:17 +0000 (22:32 +0300)]
Do not fold relocatable constants into displacements (#68851)

The code in "genCreateAddrMode" was performing the equivalent of constant
folding ADDs, but failing to take into account the legality of doing that.

2 years agoFix VSTest and dotnet test broken on .NETFramework (#68863)
Viktor Hofer [Thu, 5 May 2022 19:27:04 +0000 (21:27 +0200)]
Fix VSTest and dotnet test broken on .NETFramework (#68863)

* Fix VSTest and dotnet test broken on .NETFramework

Fixes https://github.com/dotnet/runtime/issues/68384

For a detailed explanation why updating the xunit.runner.visualstudio fixes .NETFramework dotnet test and VSTest invocation please see the above linked issue.

2 years agoMark FileStream.Lock(Int64, Int64) as unsupported on FreeBSD (#68908)
Tarun047 [Thu, 5 May 2022 18:55:54 +0000 (00:25 +0530)]
Mark FileStream.Lock(Int64, Int64) as unsupported on FreeBSD (#68908)

2 years agoComment out assert for now
Andy Gocke [Thu, 5 May 2022 18:11:50 +0000 (11:11 -0700)]
Comment out assert for now

2 years agoadd RID for Alpine 3.16 (#68505)
Tomas Weinfurt [Thu, 5 May 2022 17:56:13 +0000 (10:56 -0700)]
add RID for Alpine 3.16 (#68505)

2 years agoTweak Regex comparison to improve subsequent bounds check removals (#68846)
Stephen Toub [Thu, 5 May 2022 17:23:06 +0000 (13:23 -0400)]
Tweak Regex comparison to improve subsequent bounds check removals (#68846)

* Tweak Regex comparison to improve subsequent bounds check removals

* Address PR feedback

2 years agoMerge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589...
Viktor Hofer [Thu, 5 May 2022 16:21:41 +0000 (18:21 +0200)]
Merge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589-61f58f239059

2 years agoAnnotating System.Text.Json library for aot form factor (#68464)
Lakshan Fernando [Thu, 5 May 2022 16:01:04 +0000 (09:01 -0700)]
Annotating System.Text.Json library for aot form factor (#68464)

* Annotating System.Text.Json library for aot form factor

* FB

* FB2

* FB3

* FB4

* Move annatation to class level where relevant with the fixed analyzer

* using consistent terminology in the annotation

* FB minus the suppression change

* reverting to pre-converter annotation status

2 years agoAdd test for multiple calls of QuicConnection.CloseAsync (#68893)
Radek Zikmund [Thu, 5 May 2022 15:40:01 +0000 (08:40 -0700)]
Add test for multiple calls of QuicConnection.CloseAsync (#68893)

* Add test for multiple calls of QuicConnection.CloseAsync

* Add test case for server as well

2 years agoFix a few more API compat inconsistencies (#68834)
Eric StJohn [Thu, 5 May 2022 15:34:20 +0000 (08:34 -0700)]
Fix a few more API compat inconsistencies (#68834)

2 years agoFix ApiCompat errors
Viktor Hofer [Thu, 5 May 2022 15:17:20 +0000 (17:17 +0200)]
Fix ApiCompat errors

2 years agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 175367...
dotnet bot [Thu, 5 May 2022 13:04:22 +0000 (06:04 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1753679 (#68870)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1752382

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1753274

2 years ago[wasm][debugger] Refactor of getProperties mechanism (#68486)
Ilona Tomkowicz [Thu, 5 May 2022 13:01:55 +0000 (15:01 +0200)]
[wasm][debugger] Refactor of getProperties mechanism (#68486)

* Merge main with @radical's refactoring.

* Fixed most tests.

* Added more Browsable tests: null + valuetype.

* Fixed trailing spaces and exposed the test.

* Fixed all GetPropertiesTests.

* Fixing RunOnCFOValueTypeResult.

* Fixed cloning to be deep.

* Reverted comments in test.

* Fixed browsable root hidden tests.

* Extended Browsable tests with a structure.

* Fixed TestSetValueOnObject.

* Add class testcase to browsable root hidden.

* All existing tests are passing.

* Cleanup, removing unused code.

* Added Browsable tests for nonstatic structures.

* Removed unnecessary comment.

* Removed whitespaces.

* Blocked tests failing/timeouting on Firefox.

2 years agoUse Docker images from mcr.microsoft.com in EnterpriseTests (#68875)
Alexander Köplinger [Thu, 5 May 2022 12:58:19 +0000 (14:58 +0200)]
Use Docker images from mcr.microsoft.com in EnterpriseTests (#68875)

We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/

The image from dotnet-buildtools-prereqs-docker can be used instead.

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20220504.2
dotnet-maestro[bot] [Thu, 5 May 2022 12:21:54 +0000 (12:21 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20220504.2

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22179.1 -> To Version 2.5.1-beta.22254.2

2 years agoReplace invalid sourcegen debug assertion with runtime check (#68828)
Eirik Tsarpalis [Thu, 5 May 2022 11:08:19 +0000 (14:08 +0300)]
Replace invalid sourcegen debug assertion with runtime check (#68828)

* Replace AttributeConstructor null assertion with runtime exception

* Remove redundand Json.NET package references

* Revert "Remove redundand Json.NET package references"

This reverts commit 5247c1f98313410fc8cff399670f9595155cef9c.

2 years ago[QUIC] Adopted msquic generated interop (#68288)
Marie Píchová [Thu, 5 May 2022 10:32:25 +0000 (12:32 +0200)]
[QUIC] Adopted msquic generated interop (#68288)

* MsQuicApi adjusted

* QuicParamHelper adjusted

* MsQuicConfiguration adjusted

* Added MsQuicException

* MsQuicConnection adjusted

* MsQuicListener adjusted

* MsQuicStream adjusted

* It compiles!

* Some test fixes

* Fixed stream read event handling

* Re-enabled IPv6 tests

* latest greatest

* Update src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicListener.cs

* MsQuic interop enum names

* 3rd Party notice, version check

* SafeHandleType

* Replaced AlpnHelpers with MsQuicBuffers generic QUIC_BUFFER* helper

* Sealed exception class

* Feedback MsQuicBuffers

* NativeMemory use

* Newest msquic interop

* Buffers feedback

* Remove MemoryHandle pooling

* Buffers feedback

* Logging feedback

2 years agoFixed the yp_spin_count_unit to be a factor of the original_spin_count_unit rather...
Mukund Raghav Sharma [Thu, 5 May 2022 09:28:29 +0000 (02:28 -0700)]
Fixed the yp_spin_count_unit to be a factor of the original_spin_count_unit rather than a continually increasing value (#68879)

* Fixed the yp_spin_count_unit to be a factor of the original_spin_count_unit rather than a continually increasing value

* Added upper bounds on the spin count

* Fixed the type of the unit spin counts

2 years agoImproving the 64-bit number formatting to better match the 32-bit algorithm (#68795)
Tanner Gooding [Thu, 5 May 2022 02:36:12 +0000 (19:36 -0700)]
Improving the 64-bit number formatting to better match the 32-bit algorithm (#68795)

* Improving the 64-bit number formatting to better match the 32-bit algorithm

* Fixing a uint cast that should've been a ulong cast

* Ensure digits: 0 is properly passed through

2 years agoUpdate message for unsupported char marshalling (#68865)
Elinor Fung [Thu, 5 May 2022 02:13:51 +0000 (19:13 -0700)]
Update message for unsupported char marshalling (#68865)

2 years agoAdd a four-element AsyncLocalValueMap type (#68790)
Stephen Toub [Thu, 5 May 2022 01:11:18 +0000 (21:11 -0400)]
Add a four-element AsyncLocalValueMap type (#68790)

* Add a four-element AsyncLocalValueMap type

We previously special-cased up to three active AsyncLocals in a given async flow, but it seems four is also very common.  Special-casing four as well results in four using ~20% less allocation and ~10% less CPU overhead.

* Fix downgrading to FourElementAsyncLocalValueMap, and clean up source

2 years agoStop escaping ' and " in generated regex XML comments (#68856)
Stephen Toub [Thu, 5 May 2022 00:13:02 +0000 (20:13 -0400)]
Stop escaping ' and " in generated regex XML comments (#68856)

2 years agoMove `CustomTypeMarshaller` APIs to `System.Runtime.InteropServices.Marshalling`...
Elinor Fung [Thu, 5 May 2022 00:11:47 +0000 (17:11 -0700)]
Move `CustomTypeMarshaller` APIs to `System.Runtime.InteropServices.Marshalling` (#68842)

2 years agoDelete stale IgnoreCaseRelation regex tests (#68857)
Stephen Toub [Thu, 5 May 2022 00:09:31 +0000 (20:09 -0400)]
Delete stale IgnoreCaseRelation regex tests (#68857)

These are from when NonBacktracking maintained its own hardcoded set of IgnoreCase-related tables.  Those no longer exist, making these tests defunct.

2 years agoMerge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589...
Larry Ewing [Thu, 5 May 2022 00:02:19 +0000 (19:02 -0500)]
Merge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589-61f58f239059

2 years agoFix singlefile on OSX ARM64 (#68845)
Vladimir Sadov [Wed, 4 May 2022 21:51:31 +0000 (14:51 -0700)]
Fix singlefile on OSX ARM64 (#68845)

* Same alignment in the bundle on OSX as on Linux

* Extra VA gap between section in casse we run from sf bundle

* Rename prevSectionEnd -> prevSectionEndAligned and make it aligned.

* Suppress assert for now on OSX

2 years agoReenable 4244 (#68615)
Aaron Robinson [Wed, 4 May 2022 20:53:32 +0000 (16:53 -0400)]
Reenable 4244 (#68615)

* Remove disable of 4244 in root compiler settings.

2 years ago[wasm][debugger] Use new image to run debugger tests on firefox (#68859)
Thays Grazia [Wed, 4 May 2022 20:21:54 +0000 (17:21 -0300)]
[wasm][debugger] Use new image to run debugger tests on firefox (#68859)

* test firefox in the docker image

* remove unnecessary comments

2 years agoClean up some Regex error messages (#68861)
Stephen Toub [Wed, 4 May 2022 19:03:44 +0000 (15:03 -0400)]
Clean up some Regex error messages (#68861)

Also delete some related dead code.