Artem Dergachev [Tue, 18 Feb 2020 06:00:05 +0000 (09:00 +0300)]
[analyzer] Teach scan-build how to rebuild index.html without analyzing.
This is useful for performing custom build system integration that works by appending '--analyze --analyzer-output html' to all clang build commands.
For such users there is now still a way to have the fancy index.html file
in the output.
Differential Revision: https://reviews.llvm.org/D74467
Artem Dergachev [Tue, 18 Feb 2020 05:40:02 +0000 (08:40 +0300)]
[analyzer] VforkChecker: allow execve after vfork.
In the path-sensitive vfork() checker that keeps a list of operations
allowed after a successful vfork(), unforget to include execve() in the list.
Patch by Jan Včelák!
Differential Revision: https://reviews.llvm.org/D73629
Brian Gesiak [Tue, 18 Feb 2020 05:32:46 +0000 (00:32 -0500)]
Revert new files from new pass manager coro-split/coro-elide
This reverts
https://reviews.llvm.org/rG7125d66f9969605d886b5286780101a45b5bed67 and
https://reviews.llvm.org/rG00fec8004aca6588d8d695a2c3827c3754c380a0 due
to buildbot failures:
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/34004
Previous revert
11053a1cc61afaabf2df2b8345d8d392c88cd508 missed newly
added files, this commit removes those as well.
Jonas Devlieghere [Tue, 18 Feb 2020 05:21:32 +0000 (21:21 -0800)]
[lldb/Plugins] Add missing initialize/terminate calls
Add missing initialize and terminate calls for DynamicLoaderHexagonDYLD
and ObjectFileJIT.
Jonas Devlieghere [Tue, 18 Feb 2020 05:14:30 +0000 (21:14 -0800)]
[lldb/Plugins] Conditionally build OperatingSystemPython.
Only build the Python Operating System Plugin when LLDB_ENABLE_PYTHON is
set to true.
Muhammad Omair Javaid [Tue, 18 Feb 2020 05:16:52 +0000 (10:16 +0500)]
Revert "[lldb/lldb-server] Add target.xml support for qXfer request."
This patch cause floating point registers to fail on LLDB aarch64-linux
buildbot.
http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/1713
This reverts commit
aedc196101e33bd58f7443c5b93398418ce55edf.
Brian Gesiak [Tue, 18 Feb 2020 04:55:10 +0000 (23:55 -0500)]
Revert new pass manager coro-split and coro-elide
This reverts
https://reviews.llvm.org/rG7125d66f9969605d886b5286780101a45b5bed67 and
https://reviews.llvm.org/rG00fec8004aca6588d8d695a2c3827c3754c380a0 due
to buildbot failures:
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/34004
Brian Gesiak [Thu, 26 Dec 2019 13:00:00 +0000 (08:00 -0500)]
[Coroutines][3/6] New pass manager: coro-elide
Summary:
Depends on https://reviews.llvm.org/D71899.
The third in a series of patches that ports the LLVM coroutines passes
to the new pass manager infrastructure. This patch implements 'coro-elide'.
The new pass manager infrastructure does not implicitly repeat CGSCC
pass pipelines when a function is devirtualized, and so the tests
for the new pass manager that rely on that behavior now explicitly
specify `repeat<2>`.
Reviewers: GorNishanov, lewissbaker, chandlerc, jdoerfert, junparser, deadalnix, wenlei
Reviewed By: wenlei
Subscribers: wenlei, EricWF, Prazek, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71900
Brian Gesiak [Thu, 26 Dec 2019 13:00:00 +0000 (08:00 -0500)]
[Coroutines][2/6] New pass manager: coro-split
Summary:
This patch has four dependencies:
1. The first in this series of patches that implement coroutine passes in the
new pass manager: https://reviews.llvm.org/D71898.
2. A patch that introduces an API for CGSCC passes to add new reference
edges to a `LazyCallGraph`, `updateCGAndAnalysisManagerForCGSCCPass`:
https://reviews.llvm.org/D72025.
3. A patch that introduces a `CallGraphUpdater` helper class that is
capable of mutating internal `LazyCallGraph` state in order to insert
new function nodes into a specific SCC: https://reviews.llvm.org/D70927.
4. And finally, a small edge case fix for updating `LazyCallGraph` that
patch 3 above happens to run into: https://reviews.llvm.org/D72226.
This is the second in a series of patches that ports the LLVM coroutines
passes to the new pass manager infrastructure. This patch implements
'coro-split'.
Some notes:
* Using the new CGSCC pass manager resulted in IR being printed in the
reverse order in some tests. To prevent FileCheck checks from failing due
to these reversed orders, this patch splits up test files that test
multiple different coroutine functions: specifically
coro-alloc-with-param.ll, coro-split-eh.ll, and coro-eh-aware-edge-split.ll.
* CoroSplit.cpp contained 2 overloads of `splitCoroutine`, one of which
dispatched to the other based on the coroutine ABI being used (C++20
switch-based versus Swift returned-continuation-based). I found this
confusing, especially with the additional branching based on `CallGraph`
vs. `LazyCallGraph`, so I removed the ABI-checking overload of
`splitCoroutine`.
Reviewers: GorNishanov, lewissbaker, chandlerc, jdoerfert, junparser, deadalnix, wenlei
Reviewed By: wenlei
Subscribers: wenlei, qcolombet, EricWF, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71899
Jonas Devlieghere [Tue, 18 Feb 2020 03:59:03 +0000 (19:59 -0800)]
[lldb/Plugins] Rename initializers to match their plugin name.
Use LLDB_PLUGIN_DEFINE_ADV to make the name of the generated initializer
match the name of the plugin. This is a step towards generating the
initializers with a def file. I'm landing this change in pieces so I can
narrow down what exactly breaks the Windows bot.
Jonas Devlieghere [Tue, 18 Feb 2020 03:46:28 +0000 (19:46 -0800)]
[lldb/Plugins] Initialize all ABI plugins by their plugin name
Craig Topper [Tue, 18 Feb 2020 03:43:26 +0000 (19:43 -0800)]
[X86] Use isScalarFPTypeInSSEReg to simplify code in LowerSELECT. NFC
Jonas Devlieghere [Tue, 18 Feb 2020 03:18:37 +0000 (19:18 -0800)]
[lldb/Plugins] Remove PLUGIN from libraries that aren't really plugins.
Although their name and location suggests otherwise, these libraries are
not really plugins but rather support the real plugins.
Jonas Devlieghere [Tue, 18 Feb 2020 03:14:01 +0000 (19:14 -0800)]
[lldb/Plugins] Rename lldbPluginDisassemblerLLVM (NFC)
Jonas Devlieghere [Tue, 18 Feb 2020 03:02:25 +0000 (19:02 -0800)]
Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"
This is still failing spectacularly on the Windows bot and I still have
no clue what's going on.
Jim Lin [Tue, 18 Feb 2020 02:48:38 +0000 (10:48 +0800)]
[NFC] Remove trailing space
sed -Ei 's/[[:space:]]+$//' include/**/*.{def,h,td} lib/**/*.{cpp,h,td}
Jim Lin [Tue, 18 Feb 2020 02:32:58 +0000 (10:32 +0800)]
[XCore][NFC] Remove trailing space
Craig Topper [Mon, 17 Feb 2020 22:49:17 +0000 (14:49 -0800)]
[X86] Add one use check to '0-x == y --> x+y == 0' in EmitCmp.
I failed to copy it when I moved this in
b62de210cf50ccb6822260e4075dd93333adb23e
Jonas Devlieghere [Tue, 18 Feb 2020 02:14:24 +0000 (18:14 -0800)]
[lldb/Plugin] Unconditionally build Darwin-Kernel
Jonas Devlieghere [Tue, 18 Feb 2020 01:20:47 +0000 (17:20 -0800)]
[lldb/Plugin] Fix some issues on Windows
- Don't initialize NativePDB.
- Initialize ProcessWindows after any Process*Core plugins.
- Don't initialize DynamicLoaderDarwinKernel on non-Darwin platforms.
Vedant Kumar [Mon, 17 Feb 2020 23:56:12 +0000 (15:56 -0800)]
[HotColdSplit] Mark entire function cold when entry block is cold
rdar://
58855712
Stanislav Mekhanoshin [Mon, 17 Feb 2020 18:29:06 +0000 (10:29 -0800)]
[TBLGEN] Inhibit generation of unneeded psets
Differential Revision: https://reviews.llvm.org/D74744
Nicolai Hähnle [Sat, 15 Feb 2020 20:18:25 +0000 (21:18 +0100)]
LowerMatrixIntrinsics: Avoid use of deprecated CreateCall methods
Reviewers: t.p.northover
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74675
Tim Northover [Tue, 17 Dec 2019 10:07:03 +0000 (10:07 +0000)]
Coroutines: avoid use of deprecated CreateLoad and CreateCall methods
Summary: Patch originally by Tim Northover
Reviewers: t.p.northover
Subscribers: EricWF, hiraditya, modocache, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74674
Nicolai Hähnle [Wed, 27 Nov 2019 03:58:14 +0000 (04:58 +0100)]
CGBuiltin: Remove uses of deprecated CreateCall overloads
Reviewers: t.p.northover
Subscribers: cfe-commits, llvm-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74673
Jonas Devlieghere [Mon, 17 Feb 2020 22:03:14 +0000 (14:03 -0800)]
Re-land "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"
This patch changes the way we initialize and terminate the plugins in
the system initializer. It uses an approach similar to LLVM's
TARGETS_TO_BUILD with a def file that enumerates the plugins.
The previously landed patch got reverted because it was lacking:
(1) A plugin definition for the Objective-C language runtime,
(2) The dependency between the Static and WASM dynamic loader,
(3) Explicit initialization of ScriptInterpreterNone for lldb-test.
All issues have been addressed in this patch.
Differential revision: https://reviews.llvm.org/D73067
Gokturk Yuksek [Mon, 17 Feb 2020 22:26:59 +0000 (22:26 +0000)]
[dsymutil] Explicitly link against libatomic when necessary
In some systems, such as RISC-V, atomic support requires explicit linking
against '-latomic' (see https://github.com/riscv/riscv-gcc/issues/12).
Reviewers: davezarzycki, hhb, beanz, jfb, JDevlieghere
Reviewed By: beanz, JDevlieghere
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69003
Vedant Kumar [Mon, 17 Feb 2020 21:53:59 +0000 (13:53 -0800)]
[LiveDebugValues] Visit open var locs just once in transferRegisterDef, NFC
For a file in WebKit, this brings the time spent in LiveDebugValues down
from 16 minutes to 2 minutes. The reduction comes from iterating the set
of open variable locations just once in transferRegisterDef. Post-patch,
the most expensive item inside of transferRegisterDef is a call to
VarLoc::isDescribedByReg, which we have to do.
Testing: I built LNT using the Os-g cmake cache with & without this
patch, then diffed the object files to verify there was no binary diff.
rdar://
59446577
Differential Revision: https://reviews.llvm.org/D74633
Brian Gesiak [Mon, 17 Feb 2020 21:46:33 +0000 (16:46 -0500)]
Re-land "Add LazyCallGraph API to add function to RefSCC"
This re-commits https://reviews.llvm.org/D70927, which I reverted in
https://reviews.llvm.org/rG28213680b2a7d1fdeea16aa3f3a368879472c72a due
to a buildbot error:
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/13251
I no longer include a test case that appears to crash when built with the
buildbot's compiler, GCC 5.4.0.
Michael Kruse [Mon, 17 Feb 2020 21:55:09 +0000 (15:55 -0600)]
[Polly] Run polly-update-format after commit 55cfb1. NFC.
Jacques Pienaar [Mon, 17 Feb 2020 21:38:25 +0000 (13:38 -0800)]
[mlir] Fix multiple titles
We have one title in every doc which corresponds to `#`, in the some
there are multiple and it is expected to be h1 headers (visual elements
rather than organizational). Indent every nesting by one in all of the
docs with multiple titles.
Also fixing trailing whitespace.
Jonas Devlieghere [Mon, 17 Feb 2020 21:53:07 +0000 (13:53 -0800)]
[lldb/Plugin] Update ProcessWindows plugin for revert
Craig Topper [Mon, 17 Feb 2020 21:08:39 +0000 (13:08 -0800)]
[X86] Add missing isel pattern for BLCFILL producing flags.
Jonas Devlieghere [Mon, 17 Feb 2020 20:32:53 +0000 (12:32 -0800)]
Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"
This temporarily reverts commit
7d6da329dee1eda1761430d9097d1323f32c4c0c
because it's causing test failures on the bots.
Matt Arsenault [Sun, 16 Feb 2020 04:22:00 +0000 (23:22 -0500)]
AMDGPU/GlobalISel: Fix RegBankSelect for G_SHUFFLE_VECTOR
Matt Arsenault [Wed, 12 Feb 2020 01:48:45 +0000 (20:48 -0500)]
AMDGPU/GlobalISel: Custom lower 32-bit G_SDIV/G_SREM
Nico Weber [Mon, 17 Feb 2020 19:37:43 +0000 (14:37 -0500)]
[gn build] (manually) merge
e9849d519
Matt Arsenault [Sun, 16 Feb 2020 03:34:37 +0000 (22:34 -0500)]
AMDGPU/GlobalISel: Allow arbitrary global values
Treat unknown address spaces as global
Craig Topper [Mon, 17 Feb 2020 19:20:36 +0000 (11:20 -0800)]
[X86] Change how the alignment for the stack object is created in LowerFLT_ROUNDS_.
We don't need FrameInfo's concept of the stack alignment. We just
need to tell it the desired alignment. Which in this case is 2.
Craig Topper [Mon, 17 Feb 2020 06:13:11 +0000 (22:13 -0800)]
[X86] Move '0-x == y --> x+y == 0' and similar combines to EmitCmp.
AArch64 handles this pattern in their lowering code. By emitting
CMN. ARM handles it as an isel pattern.
Brian Gesiak [Mon, 17 Feb 2020 19:25:10 +0000 (14:25 -0500)]
Revert "Add LazyCallGraph API to add function to RefSCC"
This reverts commit https://reviews.llvm.org/rG449a13509190b1c57e5fcf5cd7e8f0f647f564b4,
due to buildbot failures such as
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/13251.
Matt Arsenault [Mon, 10 Feb 2020 01:38:37 +0000 (20:38 -0500)]
GlobalISel: Allow running localizer earlier
This required legal and regbankselected MIR for seemingly no
reason. For AMDGPU this wouldn't see legalized G_GLOBAL_VALUEs.
Vedant Kumar [Mon, 17 Feb 2020 19:21:32 +0000 (11:21 -0800)]
Fix modules build after https://reviews.llvm.org/D73835 (IRBuilder virtualization change)
I readily admit that I don't know why this fixes the modules build, but
it seems to get things building again. Previously I saw the error
message:
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/9404/consoleFull#-
361314398a1ca8a51-895e-46c6-af87-
ce24fa4cd561
```
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/IR/IRBuilderFolder.h:18:10: fatal error: cyclic dependency in module 'LLVM_intrinsic_gen': LLVM_intrinsic_gen -> LLVM_IR -> LLVM_intrinsic_gen
^
While building module 'LLVM_intrinsic_gen' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/IR/IRBuilder.cpp:14:
In file included from <module-includes>:1:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/IR/Argument.h:19:10: fatal error: could not build module 'LLVM_IR'
~~~~~~~~^~~~~~~~~~~~~~~~~
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/IR/IRBuilder.cpp:14:10: fatal error: could not build module 'LLVM_intrinsic_gen'
```
And reproduced with:
cmake -G Ninja /Users/vsk/src/llvm-backup-master/llvm -DCLANG_ENABLE_ARCMT=Off -DCLANG_ENABLE_STATIC_ANALYZER=Off -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;lld;libcxx;libcxxabi;compiler-rt;libunwind;lldb' -DLLDB_USE_SYSTEM_DEBUGSERVER=On -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_MODULES=On
Jonas Devlieghere [Mon, 17 Feb 2020 19:20:17 +0000 (11:20 -0800)]
[lldb/Plugin] Remove PLUGIN from Process POSIX & Linux
ProcessPOSIX and ProcessLinux are not real plugins and should not be
marked as such. This should fix the Linux bots.
Matt Arsenault [Wed, 12 Feb 2020 01:51:02 +0000 (20:51 -0500)]
AMDGPU/GlobalISel: Custom lower 32-bit G_UDIV/G_UREM
AMDGPUCodeGenPrepare expands this most of the time, but not always. We
will always at least need a fallback option here. This is the 3rd
implementation of the same expansion in the backend. Eventually I
would like to eliminate the IR expansion (and the DAG version
obviously).
Currently the new legalizer path produces a better result, since the
IR expansion results in extra operations which need to be combined
out. Notably, the IR expansion results in multiplies by 0.
Gokturk Yuksek [Mon, 17 Feb 2020 18:36:18 +0000 (18:36 +0000)]
[CMake] CheckAtomic.cmake: catch false positives in RISC-V
The check for 'HAVE_CXX_ATOMICS_WITHOUT_LIB' may create false
positives in RISC-V. This is reproducible when compiling LLVM natively
using GCC on a rv64gc (rv64imafdgc) host. Due to the 'A' (atomic)
extension, g++ replaces calls to libatomic operations on the
std::atomic<int> type with the native hardware instructions. As a
result, the compilation succeeds and the build system thinks it
doesn't need to pass '-latomic'.
Improve the reliability of the 'HAVE_CXX_ATOMICS_WITHOUT_LIB' test in
two steps:
1. Force a pre-increment on x (++x), which should force a call to a
libatomic function;
2. Because step 1 would resolve the increment to 'amoadd.w.aq' under
the 'A' extension, force the same operation on sub-word types, for
which there is no hardware support.
Reviewers: jfb, hintonda, smeenai, mgorny, JDevlieghere, jyknight
Reviewed By: jfb
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68964
Matt Arsenault [Sun, 9 Feb 2020 20:48:31 +0000 (15:48 -0500)]
GlobalISel: Extend narrowing to G_ASHR
Brian Gesiak [Thu, 26 Dec 2019 13:00:00 +0000 (08:00 -0500)]
[Coroutines][1/6] New pass manager: coro-early
Summary:
The first in a series of patches that ports the LLVM coroutines passes
to the new pass manager infrastructure. This patch implements
'coro-early'.
NB: All coroutines passes begin by checking that coroutine intrinsics are
declared within the LLVM IR module they're operating on. To do so, they call
`coro::declaresIntrinsics`. The next 3 patches in this series, which add new
pass manager implementations of the 'coro-split', 'coro-elide', and
'coro-cleanup' passes, use a similar pattern as the one used here: a static
function is shared across both old and new passes to detect if relevant
coroutine intrinsics are delcared. To make this pattern easier to read, this
patch adds `const` keywords to the parameters of `coro::declaresIntrinsics`.
Reviewers: GorNishanov, lewissbaker, junparser, chandlerc, deadalnix, wenlei
Reviewed By: wenlei
Subscribers: ychen, wenlei, EricWF, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71898
Jonas Devlieghere [Mon, 17 Feb 2020 18:23:43 +0000 (10:23 -0800)]
[lldb/Plugin] Fix plugin definition for ProcessWindows
This should fix the unresolved external symbol error.
John Brawn [Mon, 17 Feb 2020 16:55:32 +0000 (16:55 +0000)]
[FPEnv][ARM] Don't call mutateStrictFPToFP when lowering
mutateStrictFPToFP can delete the node and replace it with another with the same
value which can later cause problems, and returning the result of
mutateStrictFPToFP doesn't work because SelectionDAGLegalize expects that the
returned value has the same number of results as the original. Instead handle
things by doing the mutation manually.
Differential Revision: https://reviews.llvm.org/D74726
Nikita Popov [Sun, 16 Feb 2020 16:10:09 +0000 (17:10 +0100)]
Reapply "[IRBuilder] Virtualize IRBuilder"
Relative to the original commit, this fixes some warnings,
and is based on the deletion of the IRBuilder copy constructor
in D74693. The automatic copy constructor would no longer be
safe.
-----
Related llvm-dev thread:
http://lists.llvm.org/pipermail/llvm-dev/2020-February/138951.html
This patch moves the IRBuilder from templating over the constant
folder and inserter towards making both of these virtual.
There are a couple of motivations for this:
1. It's not possible to share code between use-sites that use
different IRBuilder folders/inserters (short of templating the code
and moving it into headers).
2. Methods currently defined on IRBuilderBase (which is not templated)
do not use the custom inserter, resulting in subtle bugs (e.g.
incorrect InstCombine worklist management). It would be possible to
move those into the templated IRBuilder, but...
3. The vast majority of the IRBuilder implementation has to live
in the header, because it depends on the template arguments.
4. We have many unnecessary dependencies on IRBuilder.h,
because it is not easy to forward-declare. (Significant parts of
the backend depend on it via TargetLowering.h, for example.)
This patch addresses the issue by making the following changes:
* IRBuilderDefaultInserter::InsertHelper becomes virtual.
IRBuilderBase accepts a reference to it.
* IRBuilderFolder is introduced as a virtual base class. It is
implemented by ConstantFolder (default), NoFolder and TargetFolder.
IRBuilderBase has a reference to this as well.
* All the logic is moved from IRBuilder to IRBuilderBase. This means
that methods can in the future replace their IRBuilder<> & uses
(or other specific IRBuilder types) with IRBuilderBase & and thus
be usable with different IRBuilders.
* The IRBuilder class is now a thin wrapper around IRBuilderBase.
Essentially it only stores the folder and inserter and takes care
of constructing the base builder.
What this patch doesn't do, but should be simple followups after this change:
* Fixing use of the inserter for creation methods originally defined
on IRBuilderBase.
* Replacing IRBuilder<> uses in arguments with IRBuilderBase, where useful.
* Moving code from the IRBuilder header to the source file.
From the user perspective, these changes should be mostly transparent:
The only thing that consumers using a custom inserted may need to do is
inherit from IRBuilderDefaultInserter publicly and mark their InsertHelper
as public.
Differential Revision: https://reviews.llvm.org/D73835
Nikita Popov [Mon, 17 Feb 2020 18:01:18 +0000 (19:01 +0100)]
[Polly] Fix build after IRBuilder changes
Simply dropping the createPollyIRBuilder() function here, because
it doesn't do much. Also directly initialize Expander in
ScopExpander instead of going through the copy-constructor.
Brian Gesiak [Tue, 4 Feb 2020 03:50:39 +0000 (22:50 -0500)]
Add LazyCallGraph API to add function to RefSCC
Summary:
Depends on https://reviews.llvm.org/D70927.
`LazyCallGraph::addNewFunctionIntoSCC` allows users to insert a new
function node into a call graph, into a specific, existing SCC.
Extend this interface such that functions can be added even when they do
not belong in any existing SCC, but instead in a new SCC within an
existing RefSCC.
The ability to insert new functions as part of a RefSCC is necessary for
outlined functions that do not form a strongly connected cycle with the
function they are outlined from. An example of such a function would be the
coroutine funclets 'f.resume', etc., which are outlined from a coroutine 'f'.
Coroutine 'f' only references the funclets' addresses, it does not call
them directly.
Reviewers: jdoerfert, chandlerc, wenlei, hfinkel
Reviewed By: jdoerfert
Subscribers: hfinkel, JonChesterfield, mehdi_amini, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72226
Mikhail Maltsev [Mon, 17 Feb 2020 17:47:05 +0000 (17:47 +0000)]
[ARM,MVE] Add vector-scalar intrinsics
Summary:
This patch adds vector-scalar variants to the following families of
MVE intrinsics:
* vaddq
* vsubq
* vmulq
* vqaddq
* vqsubq
* vhaddq
* vhsubq
* vqdmulhq
* vqrdmulhq
The vector-scalar variants perform a splat operation on the scalar
operand and then perform the same operations as their vector-vector
counterparts. Code generation is done accordingly (using LLVM IR 'insert'
and 'shuffle' operations which are later converted into an ARMvdup
SDNode).
Reviewers: simon_tatham, dmgreen, MarkMurrayARM, ostannard
Reviewed By: dmgreen
Subscribers: kristof.beyls, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D74620
Matt Arsenault [Mon, 17 Feb 2020 17:08:39 +0000 (12:08 -0500)]
GlobalISel: Fix missing const
Nikita Popov [Sun, 16 Feb 2020 16:46:26 +0000 (17:46 +0100)]
[IRBuilder] Delete copy constructor
D73835 will make IRBuilder no longer trivially copyable. This patch
deletes the copy constructor in advance, to separate out the breakage.
Currently, the IRBuilder copy constructor is usually used by accident,
not by intention. In rG7c362b25d7a9 I've fixed a number of cases where
functions accepted IRBuilder rather than IRBuilder &, thus performing
an unnecessary copy. In rG5f7b92b1b4d6 I've fixed cases where an
IRBuilder was copied, while an InsertPointGuard should have been used
instead.
The only non-trivial use of the copy constructor is the
getIRBForDbgInsertion() helper, for which I separated construction and
setting of the insertion point in this patch.
Differential Revision: https://reviews.llvm.org/D74693
Nikita Popov [Mon, 17 Feb 2020 16:15:06 +0000 (17:15 +0100)]
[IRBuilder] Avoid passing IRBuilder by value; NFC
I've fixed most of these before, but missed some occurrences
in targets I don't usually build.
Matt Arsenault [Sun, 9 Feb 2020 16:24:39 +0000 (11:24 -0500)]
GlobalISel: Extend shift narrowing to G_SHL
Jonas Devlieghere [Mon, 17 Feb 2020 17:02:29 +0000 (09:02 -0800)]
[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin
This patch changes the way we initialize and terminate the plugins in
the system initializer. It uses an approach similar to LLVM's
TARGETS_TO_BUILD with a def file that enumerates the plugins.
Differential revision: https://reviews.llvm.org/D73067
Jonas Devlieghere [Mon, 17 Feb 2020 17:06:18 +0000 (09:06 -0800)]
[lldb] Fix Windows bot.
Should fix error C2039: 'toupper': is not a member of 'std'.
Raphael Isemann [Mon, 17 Feb 2020 16:59:08 +0000 (17:59 +0100)]
Revert "[libc++] Move abs and div into stdlib.h to fix header cycle."
This reverts commit
82b47b2978405f802a33b00d046e6f18ef6a47be.
This broke Clang and LLDB module builds without -fmodules-local-submodule-visbility.
I'll revert this for now until we have a fix and reland once Clang
can properly handle this code.
See also the discussion in https://reviews.llvm.org/rG82b47b2978405f802a33b00d046e6f18ef6a47be
Benjamin Kramer [Mon, 17 Feb 2020 16:55:03 +0000 (17:55 +0100)]
Hide implementation details. NFC>
Gokturk Yuksek [Mon, 17 Feb 2020 16:38:59 +0000 (16:38 +0000)]
Reland "[clang-tools-extra] fix the check for if '-latomic' is necessary""
The buildbot failures on MSVC should have been fixed by
f128f442a3d.
Matt Arsenault [Mon, 23 Dec 2019 22:34:59 +0000 (17:34 -0500)]
AMDGPU/GlobalISel: Skip DAG hack passes on selected functions
The way fallback to SelectionDAG works is somewhat surprising to
me. When the fallback path is enabled, the entire set of SelectionDAG
selector passes is added to the pass pipeline, and each one needs to
check if the function was selected. This results in the surprising
behavior of running SIFixSGPRCopies for example, but only if
-global-isel-abort=2 is used.
SIAddIMGInitPass is also added in addInstSelector, but I'm not sure
why we have this pass or if it should be added somewhere else for
GlobalISel.
Simon Pilgrim [Mon, 17 Feb 2020 13:38:20 +0000 (13:38 +0000)]
[SelectionDAG] Expose the "getValidShiftAmount" helpers available. NFCI.
These are going to be useful in TargetLowering::SimplifyDemandedBits, so expose these helpers outside of SelectionDAG.cpp
Also add an getValidShiftAmountConstant early-out to getValidMinimumShiftAmountConstant/getValidMaximumShiftAmountConstant so we can use them for scalar cases as well.
Matt Arsenault [Sun, 9 Feb 2020 05:18:04 +0000 (00:18 -0500)]
GlobalISel: Add combine to narrow G_LSHR
Produce an unmerge to a narrower type and introduce a narrower shift
if needed. I wasn't sure if there was a better way to parameterize the
target's preferred shift type for the GICombineRule, so manually call
the combine helper.
Matt Arsenault [Thu, 30 Jan 2020 01:34:32 +0000 (20:34 -0500)]
AMDGPU/GlobalISel: Select llvm.amdgcn.s.buffer.load
Doesn't try to fail on the dlc bit pre-gfx10 like the DAG lowering
does.
Haojian Wu [Wed, 12 Feb 2020 13:42:18 +0000 (14:42 +0100)]
[clang][Index] Visit the default parameter arguements in libindex.
Summary:
We are missing the default parmeter arguments when IndexFunctionLocals
is true.
Fixes https://github.com/clangd/clangd/issues/285.
Reviewers: kadircet
Subscribers: kristof.beyls, ilya-biryukov, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74610
Mikhail Maltsev [Mon, 17 Feb 2020 15:37:49 +0000 (15:37 +0000)]
[ARM] Add initial support for Custom Datapath Extension (CDE)
Summary:
This patch adds assembly-level support for a new Arm M-profile
architecture extension, Custom Datapath Extension (CDE).
A brief description of the extension is available at
https://developer.arm.com/architectures/instruction-sets/custom-instructions
The latest specification for CDE is currently a beta release and is
available at
https://static.docs.arm.com/ddi0607/aa/DDI0607A_a_armv8m_arm_supplement_cde.pdf
CDE allows chip vendors to add custom CPU instructions. The CDE
instructions re-use the same encoding space as existing coprocessor
instructions (such as MRC, MCR, CDP etc.). Each coprocessor in range
cp0-cp7 can be configured as either general purpose (GCP) or custom
datapath (CDEv1). This configuration is defined by the CPU vendor and
is provided to LLVM using 8 subtarget features: cdecp0 ... cdecp7.
The semantics of CDE instructions are implementation-defined, but the
instructions are guaranteed to be pure (that is, they are stateless,
they do not access memory or any registers except their explicit
inputs/outputs).
CDE requires the CPU to support at least Armv8.0-M mainline
architecture. CDE includes 3 sets of instructions:
* Instructions that operate on general purpose registers and NZCV
flags
* Instructions that operate on the S or D register file (require
either FP or MVE extension)
* Instructions that operate on the Q register file, require MVE
The user-facing names that can be specified on the command line are
the same as the 8 subtarget feature names. For example:
$ clang -target arm-none-none-eabi -march=armv8m.main+cdecp0+cdecp3
tells the compiler that the coprocessors 0 and 3 are configured as
CDEv1 and the remaining coprocessors are configured as GCP (which is
the default).
Reviewers: simon_tatham, ostannard, dmgreen, eli.friedman
Reviewed By: simon_tatham
Subscribers: kristof.beyls, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D74044
Matt Arsenault [Mon, 10 Feb 2020 00:42:57 +0000 (19:42 -0500)]
AMDGPU/GlobalISel: Run the localizer pass
While looking at the output on real sized programs, there is a lot of
extra SGPR spilling compared to the DAG path. This seems to largely be
from all constants being SGPRs in the entry block.
Jan Kratochvil [Mon, 17 Feb 2020 15:31:25 +0000 (16:31 +0100)]
Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map
As discussed in https://reviews.llvm.org/D73206#1871895 there is both
`DIERef` and `user_id_t` and sometimes (for DWZ) we need to encode Main
CU into them and sometimes we cannot as it is unavailable at that point
and at the same time not even needed.
I have also noticed `DIERef` and `user_id_t` in fact contain the same
information which can be seen in SymbolFileDWARF::GetUID.
SB* API/ABI is already using `user_id_t` and it needs to encode Main CU
for DWZ. Therefore what about making `DIERef` the identifier not
containing Main CU and `user_id_t` the identifier containing Main CU?
It is sort of a revert of D63322.
I find this patch as a NFC cleanup to the codebase - to satisfy a new
premise `user_id_t` is used as little as possible and thus only for
external interfaces which must not deal with MainCU in any way.
Its larger goal is to satisfy a plan to implement DWZ support.
Differential Revision: https://reviews.llvm.org/D74637
Luís Marques [Mon, 17 Feb 2020 15:21:41 +0000 (15:21 +0000)]
[CMake] Fix setting result of libatomic check for MSVC
We were skipping the libatomic requirement check for MSVC, but not setting
the corresponding variable, HAVE_CXX_ATOMICS_WITHOUT_LIB. D69869 seems to
have to failed to build on ARM MSVC because of that, and was reverted. This
should probably fix the issue. The plan is to check the result of the build
bots and then submit a more thoroughly refactored version for review.
Sander de Smalen [Mon, 17 Feb 2020 14:27:27 +0000 (14:27 +0000)]
[AArch64] Implement passing SVE vectors by ref for AAPCS.
Summary:
This patch implements the part of the calling convention
where SVE Vectors are passed by reference. This means the
caller must allocate stack space for these objects and
pass the address to the callee.
Reviewers: efriedma, rovka, cameron.mcinally, c-rhodes, rengolin
Reviewed By: efriedma
Subscribers: tschuett, kristof.beyls, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71216
Pierre Oechsel [Mon, 17 Feb 2020 14:56:08 +0000 (15:56 +0100)]
[mlir] Linalg: Extend promotion to non f32 buffers.
Summary:
Linalg's promotion pass was only supporting f32 buffers due to how the
zero value was build for the `fill` operation.
Moreover, `promoteSubViewOperands` was returning a vector with one entry
per float subview while omitting integer subviews. For a program
with only integer subviews the return vector would be of size 0.
However, `promoteSubViewsOperands` would try to access a non zero
number of entries of this vector, resulting in a sefgault.
Reviewers: nicolasvasilache, ftynse
Reviewed By: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74532
Sjoerd Meijer [Mon, 17 Feb 2020 14:49:58 +0000 (14:49 +0000)]
[DAGCombine] Combine pattern for REV16
This adds another pattern to the combiner for a case that we were not handling
to generate the REV16 instruction for ARM/Thumb2 and a bswap+ror on X86.
Differential Revision: https://reviews.llvm.org/D74032
Benjamin Kramer [Mon, 17 Feb 2020 14:49:49 +0000 (15:49 +0100)]
Benjamin Kramer [Mon, 17 Feb 2020 14:37:12 +0000 (15:37 +0100)]
Strength reduce vectors into arrays. NFCI.
Louis Dionne [Fri, 14 Feb 2020 14:19:47 +0000 (15:19 +0100)]
[libc++] Add availability markup for std::to_chars on Apple platforms
Summary:
Otherwise, one gets link errors when trying to back-deploy to older platforms.
rdar://problem/
57854364
Reviewers: lichray, EricWF
Subscribers: christof, jkorous, dexonsmith, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D74626
Matt Arsenault [Sun, 16 Feb 2020 00:18:47 +0000 (19:18 -0500)]
AMDGPU/GlobalISel: Select v2s32->v2s16 G_TRUNC
It would be nice if there was a way to avoid the tied operand, but as
far as I can tell there isn't a way to use or with op_sel to achieve
this
Matt Arsenault [Mon, 10 Feb 2020 23:06:17 +0000 (18:06 -0500)]
AMDGPU/GlobalISel: Handle sbfe/ubfe intrinsic
Try to handle arbitrary scalar BFEs by packing the operands. The DAG
gives up on non-constant arguments. We're still missing any constant
folding, so we end up with pretty ugly code most of the time. Also
handle the 64-bit scalar case, which the DAG doesn't try to do.
Matt Arsenault [Sat, 15 Feb 2020 21:46:04 +0000 (16:46 -0500)]
GlobalISel: Add matcher for G_LSHR
Tim Renouf [Thu, 13 Feb 2020 11:44:52 +0000 (11:44 +0000)]
[AMDGPU] Fix some tests that did not specify -mcpu
Summary:
This fixes some tests that did not specify -mcpu. Doing that disables
all subtarget features, which gives behavior that (a) does not
necessarily correspond to any actual target, and (b) can change as we
add new subtarget features.
Also added gfx1010 to memtime test.
Differential Revision: https://reviews.llvm.org/D74594
Change-Id: I8c0fe4fa03e9a93ef8bb722cd42d22e064526309
Benjamin Kramer [Mon, 17 Feb 2020 13:38:11 +0000 (14:38 +0100)]
[ADT] Use inherited ctors to forward to base. NFCI.
Balázs Kéri [Mon, 17 Feb 2020 13:25:16 +0000 (14:25 +0100)]
[ASTImporter] Added visibility check for scoped enums.
Summary:
ASTImporter makes now difference between C++11 scoped enums with same
name in different translation units if these are not visible outside.
Enum declarations are linked into decl chain correctly.
Reviewers: martong, a.sidorin, shafik, a_sidorin, teemperor
Reviewed By: shafik, a_sidorin
Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, teemperor, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74554
Pavel Labath [Mon, 17 Feb 2020 13:12:29 +0000 (14:12 +0100)]
[lldb] Fix build error from
07355c1c08b
The error is: no matching function for call to 'transform(std::string&, std::__cxx11::basic_string<char>::iterator, <unresolved overloaded function type>)'
The fix: replace llvm::transform with an equally simple hand-rolled
loop.
Pavel Labath [Wed, 29 Jan 2020 11:00:29 +0000 (12:00 +0100)]
[lldb/DWARF] Re-enable basic dwp support
Summary:
This patch removes the bitrotted SymbolFileDWARF(Dwo)Dwp classes, and
replaces them with dwp support implemented directly inside
SymbolFileDWARFDwo, in a manner mirroring the implementation in llvm.
This patch does:
- add support for the .debug_cu_index section to our DWARFContext
- adds a llvm::DWARFUnitIndex argument to the DWARFUnit constructors.
This argument is used to look up the offsets of the debug_info and
debug_abbrev contributions in the sections of the dwp file.
- makes sure the creation of the DebugInfo object as well as the initial
discovery of DWARFUnits is thread-safe, as we can now call this
concurrently when doing parallel indexing.
This patch does not:
- use the DWARFUnitIndex to search for other kinds of contributions
(debug_loc, debug_ranges, etc.). This means that units which reference
these sections will not work correctly. These will be handled by
follow-up patches, but even the present level of support is sufficient
to enable basic functionality.
- Make the llvm::DWARFContext thread-safe. Right now, it just avoids this
problem by ensuring everything is initialized ahead of time. However,
this is something we will run into more often as we try to use more of
llvm, and so I plan to start looking into our options here.
Reviewers: JDevlieghere, aprantl, clayborg
Subscribers: mgorny, mgrang, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73783
Sergej Jaskiewicz [Mon, 17 Feb 2020 13:06:30 +0000 (16:06 +0300)]
Revert "[CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake"
This reverts commit
801627ee490e1106380184256503dbd520c5f802.
Pavel Labath [Mon, 3 Feb 2020 16:58:37 +0000 (17:58 +0100)]
[lldb] Delete register info definitions in the x86_64 ABI classes
Summary:
These definitions are used to "augment" information received from the remote
target with eh/debug frame and "generic" register numbers.
Besides being verbose, this information was also incomplete (new registers like
xmm16-31 were missing) and sometimes even downright wrong (ymm register
numbers).
Most of this information is available via llvm's MCRegisterInfo. This patch
creates a new class, MCBasedABI, which retrieves the eh and debug frame register
numbers this way. The tricky part here is that the llvm class uses all-caps
register names, whereas lldb register are lowercase, and sometimes called
slightly differently. Therefore this class introduces some hooks to allow a
subclass to customize the MC lookup. The subclass also needs to suply the
"generic" register numbers, as this is an lldb invention.
This patch ports the x86_64 ABI classes to use the new register info mechanism.
It also creates a new "ABIx86_64" class which can be used to house code common
to x86_64 both ABIs. Right now, this just consists of a single function, but
there are plenty of other things that could be moved here too.
Reviewers: JDevlieghere, jasonmolenda
Subscribers: mgorny, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74244
Sergej Jaskiewicz [Mon, 17 Feb 2020 12:22:18 +0000 (15:22 +0300)]
[CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake
Summary:
D69169, which was necessary for running libc++ tests on remote host, got reverted. I couldn't think of a less invasive way to achieve this behavior but specify libc++abi paths in our cache file.
Reviewers: vvereschaka, aorlov, andreil99, EricWF
Reviewed By: vvereschaka
Subscribers: mgorny, kristof.beyls, ldionne, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74347
Martin Storsjö [Mon, 17 Feb 2020 12:15:53 +0000 (14:15 +0200)]
[LLDB] Fix GCC warnings about extra semicolons. NFC.
Pavel Labath [Mon, 17 Feb 2020 12:09:47 +0000 (13:09 +0100)]
[lldb] Add @skipIfXmlSupportMissing to TestWasm.py
These tests rely on being able to parse qXfer:libraries:read packet
(which is in xml).
David Green [Mon, 17 Feb 2020 11:41:16 +0000 (11:41 +0000)]
[ARM] MVE vector reduce MLA tests. NFC.
Paolo Severini [Mon, 17 Feb 2020 11:42:23 +0000 (12:42 +0100)]
[LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging
Add a dynamic loader plug-in class for WebAssembly modules.
Differential Revision: https://reviews.llvm.org/D72751
Levon Ter-Grigoryan [Mon, 17 Feb 2020 10:55:55 +0000 (11:55 +0100)]
[lldb/lldb-server] Add target.xml support for qXfer request.
Summary:
Synthesize target.xml in lldb-server to avoid a long chain of
qRegisterInfo packets, which can be slow over low-latency links.
Reviewers: jarin, labath
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74217
Kerry McLaughlin [Mon, 17 Feb 2020 10:11:42 +0000 (10:11 +0000)]
[AArch64][SVE] Add SVE index intrinsic
Summary:
Implements the @llvm.aarch64.sve.index intrinsic, which
takes a scalar base and step value.
This patch also adds the printSImm function to AArch64InstPrinter
to ensure that immediates of type i8 & i16 are printed correctly.
Reviewers: sdesmalen, andwar, efriedma, dancgr, cameron.mcinally, rengolin
Reviewed By: cameron.mcinally
Subscribers: tatyana-krasnukha, tschuett, kristof.beyls, hiraditya, rkruppe, arphaman, psnobl, cfe-commits, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74550
Sjoerd Meijer [Mon, 17 Feb 2020 10:13:47 +0000 (10:13 +0000)]
[AArch64] Fix small typos in the target description. NFC.
Patch by Tamas Petz.
Differential Revision: https://reviews.llvm.org/D74603
Simon Tatham [Mon, 17 Feb 2020 09:11:35 +0000 (09:11 +0000)]
[TableGen] Don't elide bitconverts in PatFrag fragments.
Summary:
In the DAG pattern backend, `SimplifyTree` simplifies a pattern by
removing bitconverts between two identical types. But that function is
also run on the fragments list in instances of `PatFrags`, in which
the types haven't been specified yet. So the input and output of the
bitconvert always evaluate to the empty set of types, which makes them
compare equal. So the test always passes, and bitconverts are
unconditionally removed from the PatFrag RHS.
Fixed by spotting the empty type set and using it to inhibit the
optimization.
Reviewers: nhaehnle, hfinkel
Reviewed By: nhaehnle
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74627
Jan Kratochvil [Mon, 17 Feb 2020 09:24:19 +0000 (10:24 +0100)]
[lldb] [nfc] Simplify user_id_t -> size_t
As discussed in https://reviews.llvm.org/D73206#1871895> simplifying
usage of `user_id_t`.
There is even written:
// The compile unit ID is the index of the DWARF unit.
DWARFUnit *dwarf_cu = info->GetUnitAtIndex(comp_unit->GetID());
Differential Revision: https://reviews.llvm.org/D74670
Sourabh Singh Tomar [Mon, 17 Feb 2020 09:18:25 +0000 (14:48 +0530)]
[NFCI][DebugInfo]: Corrected a Typo.
Sjoerd Meijer [Mon, 17 Feb 2020 09:13:21 +0000 (09:13 +0000)]
[X86] New test to check rev16 patterns, prep step for D74032. NFC.