Sjoerd Meijer [Mon, 17 Oct 2022 16:41:41 +0000 (22:11 +0530)]
Revert "[LoopFlatten] Enable it by default"
This reverts commit
233659c7ae9b83b64a9f739d340736bca39c3d2e.
I see some sanitizer build bot failures. Not sure if it is change
causing it, but let's see if a revert returns the bots to green...
Paul Kirth [Thu, 6 Oct 2022 23:13:26 +0000 (23:13 +0000)]
[llvm-readobj] Improve JSON output
The current implementation outputs JSON in the following way:
[{'<filename>':{'FileSummary':{},...}}]
Using the filename as a key makes processing the JSON data awkward, and
should be avoided. This patch removes that outer key, since the
'FileSummary' data also includes a 'File' field, and so we lose no data.
Reviewed By: jhenderson, leonardchan
Differential Revision: https://reviews.llvm.org/D134843
Nathan Sidwell [Thu, 1 Sep 2022 17:21:24 +0000 (10:21 -0700)]
[modules] Fix callback argument thinko
VisbleModuleSet::setVisible takes a callback, to inform of modules
being made (transitively) visible. However, we were calling it as
'Vis(M)' from a recursive lambda, where 'M' is a capture of
setVisible's M, module parameter. Thus we can invoke the callback
multiple times, passing the same value to it each time.
Everywhere else in the lambda, we refer to V.M of the lambda's
Visiting parameter. We should be doing so for the callback. Thus
we'll pass the outermost module on the outermost recursive call, and
as we descend the imports, we'll pass each import to the callback.
Reviewed By: iains
Differential Revision: https://reviews.llvm.org/D135958
Jeff Niu [Mon, 17 Oct 2022 04:27:20 +0000 (21:27 -0700)]
[mlir] Remove assert from RegionBranchOpInterface verifier
This assert is erroneous because an op implementing
`RegionBranchOpInterface` can have variadic regions and in some cases
have zero regions, in which case the only possible control flow is
branching from the parent op to itself.
Reviewed By: rriddle, jpienaar
Differential Revision: https://reviews.llvm.org/D136052
Mingming Liu [Fri, 14 Oct 2022 22:26:04 +0000 (15:26 -0700)]
[AArch64]Enhance 'isBitfieldPositioningOp' to find pattern (shl(and(val,mask), N).
Before this patch (and D135844)
- Given DAG node shl(op, N), isBitfieldPositioningOp uses (optionally shifted [1] ) op as the Src (least significant bits of Src are inserted into DstLSB of Dst node).
After this patch
- If op is and(val, mask), isBitfieldPositioningOp tries to see through and and find if val is a simpler source than op.
It helps in a similar (probably symmetric) way how isSeveralBitsExtractOpFromShr [2] optimizes isBitfieldExtractOpFromShr
Existing test cases are improved without regressions.
[1] https://github.com/llvm/llvm-project/blob/
cbd8464595220b5ea76c70ac9965d84970c4b712/llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp#L2546
[2] https://github.com/llvm/llvm-project/blob/
cbd8464595220b5ea76c70ac9965d84970c4b712/llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp#L2057
Differential Revision: https://reviews.llvm.org/D135850
Ellis Hoag [Thu, 13 Oct 2022 23:38:02 +0000 (16:38 -0700)]
[clang] Fix crash with -funique-internal-linkage-names
Calling `getFunctionLinkage(CalleeInfo.getCalleeDecl())` will crash when the declaration does not have a body, e.g., `extern void foo();`. Instead, we can use `isExternallyVisible()` to see if the delcaration has internal linkage.
I believe using `!isExternallyVisible()` is correct because the clang linkage must be `InternalLinkage` or `UniqueExternalLinkage`, both of which are "internal linkage" in llvm.
https://github.com/llvm/llvm-project/blob/
9c26f51f5e178ac0fda98419e3a61d205d3b58b1/clang/include/clang/Basic/Linkage.h#L28-L40
Fixes https://github.com/llvm/llvm-project/issues/54139
Reviewed By: tmsriram
Differential Revision: https://reviews.llvm.org/D135926
Keith Walker [Thu, 13 Oct 2022 12:56:02 +0000 (13:56 +0100)]
[ARM] Add additional targets to divide tests.
The main motivation for these additional targets is to cover the
differences in the instructions available between Thumb2 and Thumb1.
Ths shows up in these test due to the lack of the following in
Thumb1:
- Mulitply and Subtract instruction (mls) - used when calculating
a remainder.
- Unsigned Muliple Long instruction (umull) - used in certain
cases when optimising division with a constant.
Differential Revision: https://reviews.llvm.org/D135875
Michał Górny [Sat, 8 Oct 2022 16:25:49 +0000 (18:25 +0200)]
[lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks
If lots of pending callbacks are added while the main loop has exited
already, the trigger pipe buffer fills in, causing the write to fail
and the related assertion to fail. To avoid this, add a boolean member
indicating whether the callbacks have been triggered already.
If the trigger was done, avoid writing to the pipe until loops proceeds
to run them and resets the variable.
Besides fixing the issue, this also avoids writing to the pipe multiple
times if callbacks are added faster than the loop is able to process
them. Previously, this would lead to the loop performing multiple read
iterations from pipe unnecessarily.
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.llvm.org/D135516
Mark de Wever [Mon, 17 Oct 2022 15:42:00 +0000 (17:42 +0200)]
[libc++] Adds missing includes.
Fixes breakage of modular builds when including sort.h directly.
Alex Zinenko [Mon, 17 Oct 2022 12:47:03 +0000 (12:47 +0000)]
[mlir] add utilites for DiagnosedSilenceableFailure
This class adds helper functions similar to `emitError` for the
DiagnosedSilenceableFailure class in both the silenceable and definite
failure cases. These helpers simplify the use of said class and make
tranfsorm op application code idiomatic.
Reviewed By: springerm
Differential Revision: https://reviews.llvm.org/D136072
Peixin Qiao [Mon, 17 Oct 2022 15:27:17 +0000 (23:27 +0800)]
[flang] Fix the trivial type passed as value with bind(C)
In the callee side, the value cannot be used directly. For example, the
dummy argument is lhs variable or the dummy argument is passed to
another procedure as actual argument.
Fix this by allocating one temporary storage and store the value. Then
map the symbol of dummy argument to the `mlir::Value` of the temporary.
Reviewed By: jeanPerier
Differential Revision: https://reviews.llvm.org/D136009
Nawrin Sultana [Fri, 30 Sep 2022 21:10:43 +0000 (16:10 -0500)]
[OpenMP] Add upper limit to TPAUSE exponential backoff time
Differential Revision: https://reviews.llvm.org/D135003
Simon Pilgrim [Mon, 17 Oct 2022 15:19:02 +0000 (16:19 +0100)]
[DAG] visitShiftByConstant - replace constant detection with FoldConstantArithmetic
Instead of checking that an operand is constant/opaque before calling getNode() and then checking that the result is a constant, just use FoldConstantArithmetic which will just early-out if the operands are not constant foldable.
Mingming Liu [Thu, 13 Oct 2022 00:49:04 +0000 (17:49 -0700)]
[AArch64][NFC]Refactor 'isBitfieldPositioningOp' so that DAG nodes with different Opcode are handled with separate helper functions.
Using different helper functions for DAG nodes with different Opcode allows specialization.
- 'isBitfieldExtractOp' [1] shows how specialization based on Opcode could catch more patterns.
- The refactor paves the way (e.g., makes diff clearer) for enhancement in {D135844,D135850,D135852}
[1] https://github.com/llvm/llvm-project/blob/
cbd8464595220b5ea76c70ac9965d84970c4b712/llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp#L2163-L2202
Differential Revision: https://reviews.llvm.org/D135843
Alex Zinenko [Mon, 17 Oct 2022 13:37:09 +0000 (13:37 +0000)]
[mlir] stopgap for incorrect vector.contract lowering
`vector.contract` is being lowered to the default mul/add contraction
regardless if of the kind indicated. Stop the lowering completely in
this case until the correct one can be implemented.
Reviewed By: springerm, ThomasRaoux
Differential Revision: https://reviews.llvm.org/D136079
Sanjay Patel [Mon, 17 Oct 2022 14:12:24 +0000 (10:12 -0400)]
[VectorCombine] fix crashing on match of non-canonical fneg
We can't assume that operand 0 is the negated operand because
the matcher handles "fsub -0.0, X" (and also +0.0 with FMF).
By capturing the extract within the match, we avoid the bug
and make the transform more robust (can't assume that this
pass will only see canonical IR).
Nikita Popov [Mon, 17 Oct 2022 14:46:03 +0000 (16:46 +0200)]
[BasicAA] Add test for phi of geps of alloca (NFC)
Make sure we continue determining NoAlias in this case, where we
have a phi of constant index GEPs based on an alloca.
Nicola Lancellotti [Fri, 7 Oct 2022 11:14:50 +0000 (12:14 +0100)]
[AArch64] Canonicalize ZERO_EXTEND to VSELECT
Differential Revision: https://reviews.llvm.org/D135596
Simon Pilgrim [Mon, 17 Oct 2022 14:20:26 +0000 (15:20 +0100)]
Remove trailing whitespace. NFC.
Nikita Popov [Fri, 30 Sep 2022 10:13:40 +0000 (12:13 +0200)]
Reapply [InstCombine] Switch foldOpIntoPhi() to use InstSimplify
Relative to the previous attempt, this is rebased over the
InstSimplify fix in
ac74e7a7806480a000c9a3502405c3dedd8810de,
which addresses the miscompile reported in PR58401.
-----
foldOpIntoPhi() currently only folds operations into the phi if all
but one operands constant-fold. The two exceptions to this are freeze
and select, where we allow more general simplification.
This patch makes foldOpIntoPhi() generally simplification based and
removes all the instruction-specific logic. We just try to simplify
the instruction for each operand, and for the (potentially) one
non-simplified operand, we move it into the new block with adjusted
operands.
This fixes https://github.com/llvm/llvm-project/issues/57448, which
was my original motivation for the change.
Differential Revision: https://reviews.llvm.org/D134954
Simon Pilgrim [Mon, 17 Oct 2022 13:52:33 +0000 (14:52 +0100)]
[AMDGPU] Add regression test cases reported on D136042
Nikita Popov [Mon, 17 Oct 2022 13:43:11 +0000 (15:43 +0200)]
[InstSimplify] Only check self-simplify in simplifyInstruction()
InstSimplify currently checks whether the instruction simplifies
back to itself, and returns undef in that case. Generally, this
should only occur in unreachable code.
However, this was also done for the simplifyInstructionWithOperands()
API. In that case, the instruction only serves as a template that
provides the opcode and other non-operand data. In this case,
simplifying back to the same "instruction" may be expected. This
caused PR58401 in conjunction with D134954.
As such, move this check into simplifyInstruction() only. The only
other caller of simplifyInstructionWithOperands() also handles the
self-simplification case explicitly.
Jean Perier [Mon, 17 Oct 2022 13:40:39 +0000 (15:40 +0200)]
[flang] Add an enum attribute to carry Fortran attributes
Currently, Fortran attributes are mostly represented via the presence of
named attribute with special names (fir.target, fir.contiguous,
fir.optional...).
Create an enum so that these attributes can be more easily and safely
manipulated in FIR.
This patch does not add usages for it yet. It is planned to use in it in
the future HLFIR and fir.declare operations. This is added to FIR and
not HLFIR because it is intended to be used on fir.declare that will
be part of FIR, and seems also usefull for FIR operations.
Differential Revision: https://reviews.llvm.org/D135961
Simon Pilgrim [Mon, 17 Oct 2022 13:35:10 +0000 (14:35 +0100)]
[AMDGPU] Regenerate bfe-combine.ll and bfe-patterns.ll
Nikita Popov [Mon, 17 Oct 2022 13:36:28 +0000 (15:36 +0200)]
[InstCombine] Add test for PR58401 (NFC)
Oleksandr "Alex" Zinenko [Mon, 17 Oct 2022 13:28:36 +0000 (15:28 +0200)]
[mlir] fix markdown in VectorOps.td
Carlos Alberto Enciso [Mon, 17 Oct 2022 13:26:48 +0000 (14:26 +0100)]
Revert "[llvm-debuginfo-analyzer] (02/09) - Driver and documentation"
This reverts commit
fe7a3cedf77125a6309150d85cecbc20b1a31775.
Ivan Butygin [Tue, 11 Oct 2022 23:14:35 +0000 (01:14 +0200)]
[mlir][linalg] Fix canonicalizer crash for `linalg.generic` with mixed semantics
`EraseIdentityGenericOp` for `!hasBufferSemantics()` assumed fully tensor semantics and tried to access non-existent return values.
Differential Revision: https://reviews.llvm.org/D135725
Tobias Gysi [Mon, 17 Oct 2022 12:43:35 +0000 (15:43 +0300)]
[mlir][llvm] Add support for importing masked intrinsics from LLVM IR.
The revision adds support for importing the masked load/store and
gather/scatter intrinsics from LLVM IR. To enable the import, the
revision also includes an extension of the mlirBuilder code generation
to support variadic arguments.
Depends on D136057
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D136058
Carlos Alberto Enciso [Mon, 17 Oct 2022 12:46:55 +0000 (13:46 +0100)]
[llvm-debuginfo-analyzer] (02/09) - Driver and documentation
llvm-debuginfo-analyzer is a command line tool that processes debug
info contained in a binary file and produces a debug information
format agnostic “Logical View”, which is a high-level semantic
representation of the debug info, independent of the low-level
format.
The code has been divided into the following patches:
1) Interval tree
2) Driver and documentation
3) Logical elements
4) Locations and ranges
5) Select elements
6) Warning and internal options
7) Compare elements
8) ELF Reader
9) CodeView Reader
Full details:
https://discourse.llvm.org/t/llvm-dev-rfc-llvm-dva-debug-information-visual-analyzer/62570
This patch:
Driver and documentation
- Command line options.
- Full documentation.
- String Pool table.
Reviewed By: psamolysov, probinson
Differential Revision: https://reviews.llvm.org/D125777
Tobias Gysi [Mon, 17 Oct 2022 12:29:53 +0000 (15:29 +0300)]
[mlir][llvm] Use the tablegen error handling (NFC).
Use PrintError to extend the error message with location information in
LLVMIRConversionGen.cpp. Additionally, promote potentially user facing
error messages from assertions to real errors.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D136057
Florian Hahn [Mon, 17 Oct 2022 11:48:50 +0000 (12:48 +0100)]
Revert "Reapply [InstCombine] Switch foldOpIntoPhi() to use InstSimplify"
This reverts commit
333246b48ea4a70842e78c977cc92d365720465f.
It looks like this patch causes a mis-compile:
https://github.com/llvm/llvm-project/issues/58401
Fixes #58401.
Peixin Qiao [Mon, 17 Oct 2022 11:46:18 +0000 (19:46 +0800)]
[flang][OpenMP] Fix the use-associated bug in threadprivate directive lowering
The symbol may be used by use-association for multiple times such
as one in module specification part and one in module procedure.
Then in module procedure, the variable instantiation will be called
for multiple times. But we only need to threadprivatize it once and
use the threadprivatized value for the second time.
Fix #58379.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D136035
Sjoerd Meijer [Mon, 17 Oct 2022 09:06:30 +0000 (14:36 +0530)]
[LoopFlatten] Enable it by default
LoopFlatten has been in the code base off by default for years, but this
enables it to run by default. Downstream this has been running for
years, so it has been exposed to quite some code. Then around the time
we switched to the NPM, several fixes went in related to updating the
MemorySSA state and we moved it to a loop pass manager, which both
helped preventing rerunning certain analysis passes, and thus helped a
bit with compile-times.
About compile-times, adding a pass isn't free, but this should see only
very minor increases. The pass is relatively simple and there shouldn't
be anything algorithmically expensive because all it does is looking at
inner/outer loops and it checks assumptions on loop increments and
indices. If we see increases, I expect this to mainly come from
invalidation of analysis info, and perhaps subsequent passes to trigger
and do more. Despite its simplicity/restrictions, it triggers in most
code-bases, which makes it worth to enable this by default.
Differential Revision: https://reviews.llvm.org/D109958
Nathan Sidwell [Mon, 28 Feb 2022 18:13:44 +0000 (10:13 -0800)]
[demangler] Simplify OutputBuffer initialization
Every non-testcase use of OutputBuffer contains code to allocate an
initial buffer (using either 128 or 1024 as initial guesses). There's
now no need to do that, given recent changes to the buffer extension
heuristics -- it allocates a 1k(ish) buffer on first need.
Just pass in a buffer (if any) to the constructor. Thus the
OutputBuffer's ownership of the buffer starts at its own lifetime
start. We can reduce the lifetime of this object in several cases.
That new constructor takes a 'size_t *' for the size argument, as all
uses with a non-null buffer are passing through a malloc'd buffer from
their own caller in this manner.
The buffer reset member function is never used, and is deleted.
Some adjustment to a couple of uses is needed, due to the lazy buffer
creation of this patch.
a) the Microsoft demangler can demangle empty strings to nothing,
which it then memoizes. We need to avoid the UB of passing nullptr to
memcpy.
b) a unit test checks insertion of no characters into an empty buffer.
We need to avoid UB when converting that to std::string.
The original buffer initialization code would return a failure code if
that first malloc failed. Existing code either ignored that, called
std::terminate with a FIXME, or returned an error code.
But that's not foolproof anyway, as a subsequent buffer extension
failure ends up calling std::terminate. I am working on addressing
that unfortunate failure mode in a manner more consistent with the C++
ABI design.
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D122604
David Spickett [Mon, 17 Oct 2022 10:55:50 +0000 (10:55 +0000)]
Revert "[llvm] Remove redundaunt typename (NFC)"
This reverts commit
3577e606dad0fa8f54e29e24673ff63bb7dfa880.
Due to buildbot failures on Arm and Arm64.
https://lab.llvm.org/buildbot/#/builders/96/builds/30231
David Spickett [Mon, 17 Oct 2022 10:55:19 +0000 (10:55 +0000)]
Revert "[lldb] Use std::underlying_type_t (NFC)"
This reverts commit
921a4d5be4bbe3c337419dfcc313b3eb892c2870.
Due to buildbot failures on Arm and Arm64.
https://lab.llvm.org/buildbot/#/builders/96/builds/30231
David Spickett [Tue, 11 Oct 2022 14:44:11 +0000 (14:44 +0000)]
[compiler-rt] Relax pthread_getaffinity test to account for cgroups/docker
Fixes #58283
When running in a docker container you can have fewer cores assigned
to you than get_nrpoc would suggest.
Since the test just wants to know that interception worked, allow
any result > 0 and <= the global core count.
Reviewed By: MaskRay, vitalybuka
Differential Revision: https://reviews.llvm.org/D135677
Alexander Belyaev [Fri, 14 Oct 2022 17:59:55 +0000 (19:59 +0200)]
[mlir] Simplify DestinationStyleOpInterface.
Differential Revision: https://reviews.llvm.org/D135348
Nikita Popov [Mon, 17 Oct 2022 10:34:55 +0000 (12:34 +0200)]
[BasicAA] Support loop phis in pointsToConstantMemory()
When looking for underlying objects, if we encounter one that we
have already seen, then we should skip it (as it has already been
checked) rather than bail out. In particular, this adds support
for the case where we have a loop use of a phi recurrence.
Nikita Popov [Mon, 17 Oct 2022 10:31:02 +0000 (12:31 +0200)]
[BasicAA] Add tests for constant memory with loop phi (NFC)
Jay Foad [Mon, 17 Oct 2022 10:01:56 +0000 (11:01 +0100)]
[AMDGPU] Common up some generated checks in fnearbyint.ll
Also remove -mattr=-flat-for-global which is not needed for generated
checks.
Jean Perier [Mon, 17 Oct 2022 07:57:16 +0000 (09:57 +0200)]
[flang] Introduce option to lower expression to HLFIR
Preliminary work on HLFIR. Introduce option that will allow testing
lowering via HLFIR until this is ready to replace the current expression
lowering.
See https://reviews.llvm.org/D134285 for more context about the plan.
Differential Revision: https://reviews.llvm.org/D135959
Chuanqi Xu [Mon, 17 Oct 2022 07:48:13 +0000 (15:48 +0800)]
[NFC] Judge if we have std c++ modules in RenderModulesOptions
This patch moves the judgement if the std c++ modules feature is enabled
into the RenderModulesOptions function. It simplify the code a little
bit further more. It also helps further patches.
Max Kazantsev [Mon, 17 Oct 2022 05:08:49 +0000 (12:08 +0700)]
[Test] Add tests showing that instcombine does not deal with freeze(load !range)
Max Kazantsev [Mon, 17 Oct 2022 05:07:46 +0000 (12:07 +0700)]
[Test][NFC] Regenerate test check using update_tests script
Chuanqi Xu [Mon, 17 Oct 2022 02:46:07 +0000 (10:46 +0800)]
[C++20] [Coroutines] Add ReleaseNotes about addressing thread identifiaction problems
The thread identification problems in coroutines are addressed now in
1cedc51ff5a2a4f51a4c7e8bb04bd. Although the original problem occurs in
LLVM optimizer. The C++ users have strong feeling about it. So it may be
necessary to add a ReleaseNote in clang for it.
Closes https://github.com/llvm/llvm-project/issues/47177
Closes https://github.com/llvm/llvm-project/issues/47179
Chuanqi Xu [Mon, 17 Oct 2022 02:22:43 +0000 (10:22 +0800)]
[Coroutines] Don't merge readnone calls in presplit coroutines
Another alternative to fix the thread identification problem in
coroutines.
We plan to fix this problem by unifying memory effecting attributes. See
https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579.
But it may be a long-term project. And it is a pity that the coroutines
can't resume in different threads for years. So this one is temporary
fix. It may cause unnecessary performance regression for coroutines. But
correctness are more important. And this one is planned to be reverted
after we are able to unify the memory effecting attributes actually.
Reviewed By: jdoerfert, rjmccall
Differential Revision: https://reviews.llvm.org/D135550
Ting Wang [Mon, 17 Oct 2022 02:01:47 +0000 (22:01 -0400)]
[clang][PowerPC] PPC64 VAArg fix right-alignment for aggregates fit in register
PPC64 ABI pass aggregates smaller than a register into the least
significant bits of the register. In the case of variadic functions,
they will end up right-aligned in their argument slots in the argument
area on big-endian targets. Apply right-alignment for these aggregates.
Fixes #55900.
Reviewed By: rjmccall
Differential Revision: https://reviews.llvm.org/D133338
Kazu Hirata [Sun, 16 Oct 2022 23:21:00 +0000 (16:21 -0700)]
[llvm] Use llvm::find (NFC)
Florian Hahn [Sun, 16 Oct 2022 22:24:06 +0000 (23:24 +0100)]
[ConstraintElim] Fix signed integer overflow for inbounds GEP.
For inbounds GEPs, signed overflow yields poison, so it is fine for the
coefficients to wrap as well. This fixes an UBSan failure.
rkayaith [Fri, 14 Oct 2022 18:21:44 +0000 (14:21 -0400)]
[mlir][ods] Support default-valued attributes in optional groups
Add support for default-valued attributes as optional-group anchors. The
attribute is considered present if it holds a non-default value.
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D134993
Florian Hahn [Sun, 16 Oct 2022 20:53:11 +0000 (21:53 +0100)]
[ConstraintElim] Replace custom GEP index handling by using existing code
Instead of duplicating the existing decomposition code for GEP indices
just use the existing code by calling the existing decompose function on
the index expression and multiply the result's coefficients by the scale of
the index.
This both reduces code duplication and generalizes the pattern we can
handle.
Fangrui Song [Sun, 16 Oct 2022 20:15:44 +0000 (13:15 -0700)]
[CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX
When Clang is used as a cross compiler, it should respect the target
platform default. Defaulting to a configure-time CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX
does not make much sense.
When Clang is used as a single-platform compiler, we should use Clang
configuration file (https://discourse.llvm.org/t/configuration-files/42529
https://clang.llvm.org/docs/UsersManual.html#configuration-files).
The Gentoo needs from D34365 has been satisfied by a configuration file.
Reviewed By: mgorny
Differential Revision: https://reviews.llvm.org/D133375
Fangrui Song [Sun, 16 Oct 2022 19:39:37 +0000 (12:39 -0700)]
[ELF] Remove RelocationScanner::target. NFC
Kazu Hirata [Sun, 16 Oct 2022 19:33:47 +0000 (12:33 -0700)]
[clang] Use llvm::find (NFC)
Florian Hahn [Sun, 16 Oct 2022 19:24:16 +0000 (20:24 +0100)]
[ConstraintElim] Support `add nsw` for unsigned preds with positive ops.
If both operands of an `add nsw` are known positive, it can be treated
the same as `add nuw` and added to the unsigned system.
https://alive2.llvm.org/ce/z/6gprff
Roman Lebedev [Sun, 16 Oct 2022 18:38:59 +0000 (21:38 +0300)]
[NFC][X86] Test commit, add test with bad mask vector legalization
Inspired by codegen of `@test`
from `llvm/test/Analysis/CostModel/X86/masked-interleaved-*-i16.ll`.
Fangrui Song [Sun, 16 Oct 2022 19:19:57 +0000 (12:19 -0700)]
[ELF] Move R_TPREL/R_TPREL_NEG check into handleTlsRelocation
Fangrui Song [Sun, 16 Oct 2022 19:08:08 +0000 (12:08 -0700)]
[ELF] Set DF_STATIC_TLS for AArch64/PPC32/PPC64
Fangrui Song [Sun, 16 Oct 2022 18:55:38 +0000 (11:55 -0700)]
[ELF][test] Improve AArch64 TLS IE tests
Simon Pilgrim [Sun, 16 Oct 2022 17:15:44 +0000 (18:15 +0100)]
[BPF] Add (failing) testcase for Issue #57872
Kazu Hirata [Sun, 16 Oct 2022 17:11:29 +0000 (10:11 -0700)]
[clang] Use std::clamp (NFC)
Note that the constructor of MipsABIInfo guarantees that
MinABIStackAlignInBytes <= StackAlignInBytes, so we can use std::clamp
safely.
Kazu Hirata [Sun, 16 Oct 2022 16:19:09 +0000 (09:19 -0700)]
[AMDGPU] Use llvm::any_of (NFC)
Kazu Hirata [Sun, 16 Oct 2022 16:19:08 +0000 (09:19 -0700)]
[clang] Use llvm::is_contained (NFC)
bixia1 [Thu, 13 Oct 2022 15:34:36 +0000 (08:34 -0700)]
[mlir][sparse] Move routines for generating memref.alloca to CodegenUtils.
This is to allow the use of the routines in the rewrite pass.
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D135890
Sanjay Patel [Sun, 16 Oct 2022 14:01:10 +0000 (10:01 -0400)]
[InstCombine] try to determine "exact" for sdiv
If the divisor is a power-of-2 or negative-power-of-2 and the dividend
is known to have >= trailing zeros than the divisor, the division is exact:
https://alive2.llvm.org/ce/z/UGBksM (general proof)
https://alive2.llvm.org/ce/z/D4yPS- (examples based on regression tests)
This isn't the most direct optimization (we could create ashr in these
examples instead of relying on existing folds for exact divides), but
it's possible that there's a more general constraint than just a pow2
divisor, so this might be extended in the future.
This should solve issue #58348.
Differential Revision: https://reviews.llvm.org/D135970
Sanjay Patel [Fri, 14 Oct 2022 16:23:16 +0000 (12:23 -0400)]
[InstCombine] add tests for sdiv with (neg)pow2 divisor; NFC
Sanjay Patel [Fri, 14 Oct 2022 14:47:16 +0000 (10:47 -0400)]
[InstCombine] use isKnownNonNegative() for readability; NFCI
This should be functionally equivalent - both calls are thin
wrappers around computeKnownBits(). We'll probably want to use
known-bits directly in follow-up patches because that could
determine "exact" for example (see issue #58348).
Florian Hahn [Sun, 16 Oct 2022 14:51:33 +0000 (15:51 +0100)]
[ConstraintElim] Add tests for add nsw with unsigned predicates.
bixia1 [Fri, 14 Oct 2022 23:39:54 +0000 (16:39 -0700)]
[mlir][sparse] Add readCOOElement for reading a sparse tensor element from files.
Use the routine for openSparseTensorCOO and getSparseTensorReaderNext.
Reviewed By: aartbik, wrengr
Differential Revision: https://reviews.llvm.org/D135732
Jan Sjodin [Wed, 12 Oct 2022 17:57:15 +0000 (13:57 -0400)]
[OpenMP][OpenMPIRBuilder] Migrate OffloadEntriesInfoManager from clang to OMPIRbuilder
This patch moves the implementation of the OffloadEntriesInfoManager
to the OMPIRbuilder. This class will later be used by flang as well.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D135786
Fangrui Song [Sun, 16 Oct 2022 07:49:48 +0000 (00:49 -0700)]
[ELF] Move inputSections/ehInputSections into Ctx. NFC
Kazu Hirata [Sun, 16 Oct 2022 04:54:13 +0000 (21:54 -0700)]
[clang] Use llvm::reverse (NFC)
Kazu Hirata [Sun, 16 Oct 2022 04:07:03 +0000 (21:07 -0700)]
[mlir] Remove redundaunt typename (NFC)
Kazu Hirata [Sun, 16 Oct 2022 04:07:02 +0000 (21:07 -0700)]
[clang] Remove redundaunt typename (NFC)
Amara Emerson [Mon, 5 Sep 2022 20:53:41 +0000 (21:53 +0100)]
[AArch64][GlobalISel] When lowering signext i1 parameters, don't zero-extend to s8 first.
Fixes https://github.com/llvm/llvm-project/issues/57181
Peter Rong [Tue, 30 Aug 2022 21:55:59 +0000 (14:55 -0700)]
[CodeGen] Using ZExt for extractelement indices.
In https://github.com/llvm/llvm-project/issues/57452, we found that IRTranslator is translating `i1 true` into `i32 -1`.
This is because IRTranslator uses SExt for indices.
In this fix, we change the expected behavior of extractelement's index, moving from SExt to ZExt.
This change includes both documentation, SelectionDAG and IRTranslator.
We also included a test for AMDGPU, updated tests for AArch64, Mips, PowerPC, RISCV, VE, WebAssembly and X86
This patch fixes issue #57452.
Differential Revision: https://reviews.llvm.org/D132978
Nikolas Klauser [Wed, 12 Oct 2022 18:24:04 +0000 (20:24 +0200)]
[libc++] Improve error message for invalid allocators
Reviewed By: ldionne, #libc
Spies: libcxx-commits, rupprecht
Differential Revision: https://reviews.llvm.org/D135803
Kazu Hirata [Sat, 15 Oct 2022 22:06:37 +0000 (15:06 -0700)]
[ADT] Introduce StringRef::{starts,ends}_width{,_insensitive}
This patch introduces:
StringRef::starts_with
StringRef::starts_with_insensitive
StringRef::ends_with
StringRef::ends_with_insensitive
to be more compatible with std::string and std::string_view.
I'm planning to deprecate the existing functions in favor of the new
ones.
Differential Revision: https://reviews.llvm.org/D136030
Kazu Hirata [Sat, 15 Oct 2022 21:59:23 +0000 (14:59 -0700)]
[clangd] Use std::decay_t (NFC)
Kazu Hirata [Sat, 15 Oct 2022 21:52:25 +0000 (14:52 -0700)]
[Vectorize] Use std::conditional_t (NFC)
Kazu Hirata [Sat, 15 Oct 2022 21:08:01 +0000 (14:08 -0700)]
[ADT] Simplify getAsInteger and consumeInteger (NFC)
This patch replaces the std::enable_if_t trick with a "constexpr if"
so that the resulting code looks more like "normal" C++ code.
Differential Revision: https://reviews.llvm.org/D136024
Fangrui Song [Sat, 15 Oct 2022 21:02:13 +0000 (14:02 -0700)]
[Driver] Remove legacy cc1 alias -mlink-cuda-bitcode
r340193 added -mlink-builtin-bitcode as the canonical spelling.
Florian Hahn [Sat, 15 Oct 2022 20:28:07 +0000 (21:28 +0100)]
[ConstraintElim] Support unsigned decomposition of mul/shl nuw..const
Support decomposition for `mul/shl nuw` with constant operand for unsigned
queries. Those expressions should not wrap in the unsigned sense and can
be added directly to the unsigned system.
Matheus Izvekov [Sun, 14 Aug 2022 11:48:18 +0000 (13:48 +0200)]
[clang] Track the templated entity in type substitution.
This is a change to how we represent type subsitution in the AST.
Instead of only storing the replaced type, we track the templated
entity we are substituting, plus an index.
We modify MLTAL to track the templated entity at each level.
Otherwise, it's much more expensive to go from the template parameter back
to the templated entity, and not possible to do in some cases, as when
we instantiate outer templates, parameters might still reference the
original entity.
This also allows us to very cheaply lookup the templated entity we saw in
the naming context and find the corresponding argument it was replaced
from, such as for implementing template specialization resugaring.
Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Differential Revision: https://reviews.llvm.org/D131858
Kazu Hirata [Sat, 15 Oct 2022 19:50:34 +0000 (12:50 -0700)]
[clang] Fix a warning
This patch fixes:
clang/lib/Sema/SemaLambda.cpp:922:39: warning: suggest parentheses
around ‘&&’ within ‘||’ [-Wparentheses]
Kazu Hirata [Sat, 15 Oct 2022 19:48:23 +0000 (12:48 -0700)]
[clang] Fix a warning
This patch fixes:
clang/lib/Basic/SourceManager.cpp:2131:72: warning: suggest
parentheses around ‘&&’ within ‘||’ [-Wparentheses]
Kazu Hirata [Sat, 15 Oct 2022 19:43:12 +0000 (12:43 -0700)]
[Object] Fix a warning
This patch fixes:
llvm/lib/Object/XCOFFObjectFile.cpp:1001:20: warning: suggest
parentheses around ‘&&’ within ‘||’ [-Wparentheses]
Kazu Hirata [Sat, 15 Oct 2022 19:40:02 +0000 (12:40 -0700)]
[mlir] Fix warnings
This patch fixes:
mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp:171:30:
warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp:283:30:
warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
Kazu Hirata [Sat, 15 Oct 2022 19:32:20 +0000 (12:32 -0700)]
[lldb] Fix a warning
This patch fixes:
lldb/source/Commands/CommandObjectThread.cpp:66:61: warning:
comparison of unsigned expression in ‘< 0’ is always false
[-Wtype-limits]
Kazu Hirata [Sat, 15 Oct 2022 19:28:11 +0000 (12:28 -0700)]
[llvm-reduce] Fix a warning
This patch fixes:
llvm/tools/llvm-reduce/deltas/ReduceOpcodes.cpp:96:21: warning:
unused variable ‘Op’ [-Wunused-variable]
Kazu Hirata [Sat, 15 Oct 2022 19:11:59 +0000 (12:11 -0700)]
[llvm] Remove redundaunt typename (NFC)
Kazu Hirata [Sat, 15 Oct 2022 19:11:58 +0000 (12:11 -0700)]
[mlir] Use std::underlying_type_t (NFC)
Kazu Hirata [Sat, 15 Oct 2022 19:11:56 +0000 (12:11 -0700)]
[lldb] Use std::underlying_type_t (NFC)
Florian Hahn [Sat, 15 Oct 2022 17:34:02 +0000 (18:34 +0100)]
[ConstraintElim] Support signed decomposition of `add nsw`.
Add support decomposition for `add nsw` for signed queries.
`add nsw` won't wrap and can be directly added to the signed
system.
Simon Pilgrim [Sat, 15 Oct 2022 17:29:54 +0000 (18:29 +0100)]
[Mips] Regenerate unalignedload.ll
Simon Pilgrim [Sat, 15 Oct 2022 17:21:45 +0000 (18:21 +0100)]
[Mips] Regenerate return-struct.ll
Simon Pilgrim [Sat, 15 Oct 2022 17:20:26 +0000 (18:20 +0100)]
[Mips] Regenerate load-store-left-right.ll
Jeff Bailey [Sat, 15 Oct 2022 12:44:02 +0000 (12:44 +0000)]
[libc][cleanup] Docs clean up
* Make consistent heading names
* Factor out |check| into an include for reuse
* Use it everywhere (No more YES or UTF-8)
* Remove unneeded summary from pages. People know why they're there.
* Ensure source location headers everywhere.
Differential Revision: https://reviews.llvm.org/D136016