reed@google.com [Tue, 5 Mar 2013 17:49:10 +0000 (17:49 +0000)]
add SK_API to more stream subclasses (for shared library use)
git-svn-id: http://skia.googlecode.com/svn/trunk@7986
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 5 Mar 2013 16:23:59 +0000 (16:23 +0000)]
Added support for non-separable blending modes.
Fixed scalar issue from https://codereview.appspot.com/7346044
Review URL: https://chromiumcodereview.appspot.com/
12393049
git-svn-id: http://skia.googlecode.com/svn/trunk@7984
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 5 Mar 2013 14:14:58 +0000 (14:14 +0000)]
Validate that VAO functions are present in ES2 interfaces and add bit to caps indicating VAO support.
Review URL: https://codereview.chromium.org/
12447003
git-svn-id: http://skia.googlecode.com/svn/trunk@7979
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 5 Mar 2013 14:13:13 +0000 (14:13 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7978
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 5 Mar 2013 07:09:08 +0000 (07:09 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7976
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Mar 2013 21:51:24 +0000 (21:51 +0000)]
Fix an unused variable warning.
Review URL: https://codereview.chromium.org/
12398026
git-svn-id: http://skia.googlecode.com/svn/trunk@7975
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Mar 2013 21:38:50 +0000 (21:38 +0000)]
If Ashmem cache fails pinCache, do not reallocate.
Review URL: https://codereview.chromium.org/
12398021
git-svn-id: http://skia.googlecode.com/svn/trunk@7973
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Mar 2013 21:32:32 +0000 (21:32 +0000)]
Provide an option in bench_pictures to count pixel ram.
In SkLruImageCache, provide an option to keep all pixels, and document
the new behavior.
In gm/factory.cpp, set the budget for the Lru image cache to 1, to
retain (basically) the old behavior.
BUG=https://code.google.com/p/skia/issues/detail?id=1010
Review URL: https://codereview.chromium.org/
12378075
git-svn-id: http://skia.googlecode.com/svn/trunk@7972
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Mon, 4 Mar 2013 21:03:17 +0000 (21:03 +0000)]
Fixed doParse functions
For some reason, "success" wasn't set in a bunch of template specializations, causing it to be invalid when used later on.
Review URL: https://codereview.appspot.com/7370052
git-svn-id: http://skia.googlecode.com/svn/trunk@7969
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 4 Mar 2013 20:58:01 +0000 (20:58 +0000)]
Convert skhello tool to SkFlags API.
BUG=https://code.google.com/p/skia/issues/detail?id=1094
R=scroggo@google.com
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://chromiumcodereview.appspot.com/
12381087
git-svn-id: http://skia.googlecode.com/svn/trunk@7968
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Mar 2013 20:27:58 +0000 (20:27 +0000)]
Rely on libfontconfig to determine our default font
git-svn-id: http://skia.googlecode.com/svn/trunk@7967
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Mar 2013 20:03:44 +0000 (20:03 +0000)]
Address some valgrind issues
https://codereview.appspot.com/7448051/
git-svn-id: http://skia.googlecode.com/svn/trunk@7966
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Mar 2013 19:56:21 +0000 (19:56 +0000)]
Add a way to monitor cache hits and misses for deferred decoding.
Adds a new flag to bench_pictures in order to do this. Also fix
a warning.
Review URL: https://codereview.chromium.org/
12393046
git-svn-id: http://skia.googlecode.com/svn/trunk@7965
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 4 Mar 2013 19:47:42 +0000 (19:47 +0000)]
Initialize bounds even if the text length is zero.
Review URL: https://codereview.chromium.org/
12387092
git-svn-id: http://skia.googlecode.com/svn/trunk@7964
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Mar 2013 19:07:02 +0000 (19:07 +0000)]
export getter for global instance of fontconfiginterfacedirect
git-svn-id: http://skia.googlecode.com/svn/trunk@7963
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Mar 2013 17:26:02 +0000 (17:26 +0000)]
export api with SK_API
git-svn-id: http://skia.googlecode.com/svn/trunk@7962
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Mar 2013 16:41:06 +0000 (16:41 +0000)]
Created my own flag parser, based off of gflags.
Share common code between bench_ and render_ to set up the PictureRenderer.
Fix an include error in SkPictureRenderer.h.
Simplified parameter passing in render_pictures_main.
Switch to using an SkAutoTUnref for the PictureRenderer.
I also changed the input format somewhat, so the buildbots need to be updated as well: https://codereview.appspot.com/7441044/
Fixed a bug in PictureBenchmark where calling setTimeIndividualTiles(false) sets the member variable to true.
Removed setDeviceType from PictureBenchmark, since only the PictureRenderer needs to know which device type to use.
Some changes to the input format:
'--logPerIter' no longer takes a 1 or 0. Instead, '--logPerIter'
turns it on and '--nologPerIter' turns it off (with off as the
default). (Note that this is for bench_pictures; bench still uses the old format)
Change '--device' to '--config' and 'bitmap' to '8888' to be
the same as gm.
Requires '--r' before inputs (to match gm), though there can be multiple inputs following it.
Changed --enable-deferred-image-decoding (which no one uses but me yet anyway) to --deferImageDecoding, since the former is incompatible with the flag parser.
Changes to behavior:
Show a short error message on failure (rather than the explanation of all
flags).
BUG=https://code.google.com/p/skia/issues/detail?id=1094
Review URL: https://codereview.appspot.com/7230053
git-svn-id: http://skia.googlecode.com/svn/trunk@7961
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Mar 2013 16:28:33 +0000 (16:28 +0000)]
implement fonthost table methods directly in fontconfig backend, _tables now relegated to
android and windows...
Review URL: https://codereview.chromium.org/
12395015
git-svn-id: http://skia.googlecode.com/svn/trunk@7959
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Mar 2013 15:16:06 +0000 (15:16 +0000)]
refactor fonthost_tables into wrapper (fonthost) and impl (fontstream)
git-svn-id: http://skia.googlecode.com/svn/trunk@7958
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Mar 2013 14:59:55 +0000 (14:59 +0000)]
Fix Mac 10.8 64-bit Release ClipCacheTest issue
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7957
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 4 Mar 2013 14:52:02 +0000 (14:52 +0000)]
fix mac build
BUG=
Review URL: https://codereview.chromium.org/
12387084
git-svn-id: http://skia.googlecode.com/svn/trunk@7956
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Mar 2013 14:45:29 +0000 (14:45 +0000)]
enable fontconfig backend for fonthost on linux
git-svn-id: http://skia.googlecode.com/svn/trunk@7955
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Mar 2013 14:39:47 +0000 (14:39 +0000)]
short-circuit if the requested typeface matches what we've been given.
git-svn-id: http://skia.googlecode.com/svn/trunk@7954
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Mar 2013 14:29:01 +0000 (14:29 +0000)]
Add commented out code to create a core profile on windows.
Review URL: https://codereview.chromium.org/
12393044
git-svn-id: http://skia.googlecode.com/svn/trunk@7953
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 4 Mar 2013 13:56:38 +0000 (13:56 +0000)]
Change random number generator for 'tests' to SkMWCRandom. Also removes some
unused headers and fixes a couple of bugs exposed by changing the random
number generator:
First, the function SkMatrix::getMaxStretch() had an error where it was testing
the square of a number against near-zero. This led to it occasionally taking a
cheaper but imprecise path for computing the eigenvalues of the matrix. It's
been replaced with a check against the square of SK_ScalarNearlyZero.
The second case was a failure in ClipStackTest, where it hit the rare case of
a practically empty clip stack (it has a single Union) and we set a tight
bounds. The bounds rect doesn't get set by GrReducedClip::ReduceClipStack() in
this case, so when it clips the reduced stack it's clipping against garbage,
and the resulting regions don't match. The solution is to initialize the
tightBounds rect.
git-svn-id: http://skia.googlecode.com/svn/trunk@7952
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 3 Mar 2013 13:55:40 +0000 (13:55 +0000)]
remove obsolete mac-font-cruft
git-svn-id: http://skia.googlecode.com/svn/trunk@7949
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 3 Mar 2013 07:16:29 +0000 (07:16 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7948
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 3 Mar 2013 03:50:09 +0000 (03:50 +0000)]
eliminate atsuii/coretext distinction, and rename to just _mac
git-svn-id: http://skia.googlecode.com/svn/trunk@7947
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 3 Mar 2013 03:22:43 +0000 (03:22 +0000)]
try ~0U instead of ~0 to fix signed warning passing to size_t
git-svn-id: http://skia.googlecode.com/svn/trunk@7946
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 3 Mar 2013 01:57:21 +0000 (01:57 +0000)]
pass ~0 for length when we want to know the length of a table (with dst==null)
git-svn-id: http://skia.googlecode.com/svn/trunk@7945
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 3 Mar 2013 01:15:48 +0000 (01:15 +0000)]
move some of the impl in fonthost into typeface virtuals
git-svn-id: http://skia.googlecode.com/svn/trunk@7944
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sat, 2 Mar 2013 19:56:18 +0000 (19:56 +0000)]
gm self-test: make all test cases exercise transparency
BUG=https://code.google.com/p/skia/issues/detail?id=1142
Review URL: https://codereview.chromium.org/
12379047
git-svn-id: http://skia.googlecode.com/svn/trunk@7943
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 2 Mar 2013 17:45:27 +0000 (17:45 +0000)]
Move initialization to PictureRenderer ctor
https://codereview.appspot.com/7435052/
git-svn-id: http://skia.googlecode.com/svn/trunk@7942
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 2 Mar 2013 12:02:08 +0000 (12:02 +0000)]
Relanding 7914
git-svn-id: http://skia.googlecode.com/svn/trunk@7940
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 2 Mar 2013 07:01:56 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7939
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 21:34:26 +0000 (21:34 +0000)]
Revert 7932
git-svn-id: http://skia.googlecode.com/svn/trunk@7938
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 1 Mar 2013 20:30:01 +0000 (20:30 +0000)]
Remove constructors from GrVertexAttrib.
It fits our style better to use initializer lists, so the constructors have
been removed and replaced with said lists.
Review URL: https://codereview.chromium.org/
12379052
git-svn-id: http://skia.googlecode.com/svn/trunk@7936
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 1 Mar 2013 20:28:57 +0000 (20:28 +0000)]
Add freetype to skia_base_libs when building for NaCl
External users need access to libfreetype.a when they use skia_base_libs.
Review URL: https://codereview.chromium.org/
12383022
git-svn-id: http://skia.googlecode.com/svn/trunk@7934
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 20:15:18 +0000 (20:15 +0000)]
Initialize grid info in TiledPictureRenderer::init
https://codereview.appspot.com/7444053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7932
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 19:44:30 +0000 (19:44 +0000)]
Reland r7918 & r7916
git-svn-id: http://skia.googlecode.com/svn/trunk@7931
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 1 Mar 2013 18:54:50 +0000 (18:54 +0000)]
Make global static variable kVertexAttribs in GrAARectRenderer local to functions.
Chrome was choking on this static variable because it's global and initialized
using a constructor. Moved it inside the two functions that use it, so it's no
longer global.
In addition, made the constructors for GrVertexAttrib inline so hopefully they
will be optimized away.
git-svn-id: http://skia.googlecode.com/svn/trunk@7930
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 1 Mar 2013 18:21:22 +0000 (18:21 +0000)]
Resubmit r7899 and r7901.
git-svn-id: http://skia.googlecode.com/svn/trunk@7929
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 18:10:41 +0000 (18:10 +0000)]
Fix mesa issues.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
12389055
git-svn-id: http://skia.googlecode.com/svn/trunk@7928
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 1 Mar 2013 16:46:49 +0000 (16:46 +0000)]
gm self-test: disable spuriously-failing aaclip tests
Review URL: https://codereview.chromium.org/
12377049
git-svn-id: http://skia.googlecode.com/svn/trunk@7927
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 1 Mar 2013 16:18:06 +0000 (16:18 +0000)]
gm self-test: fix results that break housekeeping bot
Review URL: https://codereview.chromium.org/
12393011
git-svn-id: http://skia.googlecode.com/svn/trunk@7926
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 15:43:41 +0000 (15:43 +0000)]
Revert r7918 & r7916 due to Linux rendering issues
git-svn-id: http://skia.googlecode.com/svn/trunk@7925
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 15:36:02 +0000 (15:36 +0000)]
Add support to GrGLInterface for vertex array objects
Committed: https://code.google.com/p/skia/source/detail?r=7919
Review URL: https://codereview.chromium.org/
12379025
git-svn-id: http://skia.googlecode.com/svn/trunk@7924
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 15:32:49 +0000 (15:32 +0000)]
Revert 7919 and 7920 (committed wrong version of r7919.)
git-svn-id: http://skia.googlecode.com/svn/trunk@7923
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 1 Mar 2013 15:32:34 +0000 (15:32 +0000)]
gm self-test: use a pathologically simple test case instead of dashing2
BUG=https://code.google.com/p/skia/issues/detail?id=677
Review URL: https://chromiumcodereview.appspot.com/
12381038
git-svn-id: http://skia.googlecode.com/svn/trunk@7922
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 15:18:41 +0000 (15:18 +0000)]
Revert r7914 due to Linux rendering issues
git-svn-id: http://skia.googlecode.com/svn/trunk@7921
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 14:56:40 +0000 (14:56 +0000)]
Fix mesa build error from r7519.
git-svn-id: http://skia.googlecode.com/svn/trunk@7920
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 14:37:18 +0000 (14:37 +0000)]
Add support to GrGLInterface for vertex array objects
Review URL: https://codereview.chromium.org/
12379025
git-svn-id: http://skia.googlecode.com/svn/trunk@7919
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:24:33 +0000 (14:24 +0000)]
Fix for Mac compiler problem in 7916
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7918
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:17:58 +0000 (14:17 +0000)]
Fix for skp chunk sizes when clips are used outside of any save
https://codereview.appspot.com/7342047/
git-svn-id: http://skia.googlecode.com/svn/trunk@7917
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:12:59 +0000 (14:12 +0000)]
Collapse saveLayer/drawBitmapRect/restore trios to drawBitmapRect when possible
https://codereview.appspot.com/7387045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7916
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:10:57 +0000 (14:10 +0000)]
Replace A8 with RGBA8 when renderable A8 isn't supported
https://codereview.appspot.com/7372053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7914
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 1 Mar 2013 12:12:55 +0000 (12:12 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7910
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 28 Feb 2013 23:08:28 +0000 (23:08 +0000)]
Revert r7901 & r7899 to allow DEPS roll
git-svn-id: http://skia.googlecode.com/svn/trunk@7909
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 28 Feb 2013 22:06:02 +0000 (22:06 +0000)]
Checkpoint towards core profile support.
1) Stop calling glDisable for removed state
2) Use new GLSL names for texture sampling functions.
Review URL: https://codereview.chromium.org/
12330181
git-svn-id: http://skia.googlecode.com/svn/trunk@7908
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 28 Feb 2013 20:16:25 +0000 (20:16 +0000)]
Split GrGLContextInfo into GrGLContext & GrGLContextInfo
https://codereview.appspot.com/7436045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7905
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 28 Feb 2013 19:26:04 +0000 (19:26 +0000)]
Move the default definition of GR_USE_NEW_SHADER_SOURCE_SIGNATURE to GrGLConfig.
R=senorblanco@google.com
Review URL: https://codereview.chromium.org/
12390021
git-svn-id: http://skia.googlecode.com/svn/trunk@7904
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 28 Feb 2013 19:18:07 +0000 (19:18 +0000)]
Adding missing const for r7902
git-svn-id: http://skia.googlecode.com/svn/trunk@7903
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 28 Feb 2013 19:03:13 +0000 (19:03 +0000)]
Make SkTDArray accessors const-friendly.
This change creates const and non-const versions of SkTDArray::begin(), end(), operator[]() and getAt(). This will keep us from inadvertently changing a const SkTDArray, which the previous signatures allowed.
Review URL: https://chromiumcodereview.appspot.com/
12315131
git-svn-id: http://skia.googlecode.com/svn/trunk@7902
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 28 Feb 2013 17:15:03 +0000 (17:15 +0000)]
Fix assert in bench due to r7899. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7901
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 28 Feb 2013 17:11:11 +0000 (17:11 +0000)]
Use updated Khronos signature for glShaderSource
(const char* const instead of char**).
This is needed for new Khronos headers.
BUG=178589
Review URL: https://chromiumcodereview.appspot.com/
12310156
git-svn-id: http://skia.googlecode.com/svn/trunk@7900
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 28 Feb 2013 16:28:34 +0000 (16:28 +0000)]
Add new vertex attribute array specification.
This changes the old method of setting vertex layout to a new one where we
specify vertex attribute data separately from attribute bindings (i.e. program
functionality). Attribute data is now set up via an array of generic attribute
types and offsets, and this is mapped to the old program functionality by
setting specific attribute indices. This allows us to create more general
inputs to shaders.
git-svn-id: http://skia.googlecode.com/svn/trunk@7899
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 28 Feb 2013 16:12:39 +0000 (16:12 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7898
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 28 Feb 2013 15:50:13 +0000 (15:50 +0000)]
Only print error message in debug mode.
Currently, PictureTest runs a test of recording a bad bitmap to a
picture and then replaying the picture. We assert at the record
step in debug mode, so the test only runs in release, to ensure that
we can still play back a picture, even if it has a bad bitmap. Silence
the error message in release, so our test doesn't appear to error
(since it is actually working as desired).
Review URL: https://codereview.chromium.org/
12315138
git-svn-id: http://skia.googlecode.com/svn/trunk@7897
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Thu, 28 Feb 2013 14:01:44 +0000 (14:01 +0000)]
revert r7892
git-svn-id: http://skia.googlecode.com/svn/trunk@7896
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 28 Feb 2013 12:33:47 +0000 (12:33 +0000)]
Whitespace change: Reset skia-autogen
git-svn-id: http://skia.googlecode.com/svn/trunk@7895
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 27 Feb 2013 20:27:44 +0000 (20:27 +0000)]
Reverting r7882 (Replace A8 with RGBA8 when renderable A8 isn't supported) due Android rendering issues
git-svn-id: http://skia.googlecode.com/svn/trunk@7893
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 19:45:11 +0000 (19:45 +0000)]
resubmit after fixing assert issue: https://codereview.appspot.com/6744050
git-svn-id: http://skia.googlecode.com/svn/trunk@7892
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 27 Feb 2013 19:17:41 +0000 (19:17 +0000)]
Tests : Unused parameters cleanup
I removed unused parameters in the tests wherever it was trivial to do so. I'm trying to get the easy ones out of the way before we get into more involved discussions around this.
Review URL: https://codereview.appspot.com/7394055
git-svn-id: http://skia.googlecode.com/svn/trunk@7891
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 27 Feb 2013 19:17:07 +0000 (19:17 +0000)]
revert fontconfig gyp change for now (need to install it on housekeeper and chromeos bots)
git-svn-id: http://skia.googlecode.com/svn/trunk@7890
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 27 Feb 2013 19:07:32 +0000 (19:07 +0000)]
Sort GL extension strings and search to find.
Review URL: https://codereview.chromium.org/
12316141
git-svn-id: http://skia.googlecode.com/svn/trunk@7889
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 27 Feb 2013 19:06:52 +0000 (19:06 +0000)]
enable fontconfig by default in ports.gyp
git-svn-id: http://skia.googlecode.com/svn/trunk@7888
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 27 Feb 2013 19:06:30 +0000 (19:06 +0000)]
use fontconfig fonthost for skia (in prep for using in chrome)
Review URL: https://codereview.chromium.org/
12319150
git-svn-id: http://skia.googlecode.com/svn/trunk@7887
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 27 Feb 2013 18:43:47 +0000 (18:43 +0000)]
Assign color=0 in GrDrawState.cpp to stop tools from raising false alarms about uninit reads.
We were assigning color to oldColor but it in turn would never be read because the valid flags
would be cleared.
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/
12313150
git-svn-id: http://skia.googlecode.com/svn/trunk@7886
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 27 Feb 2013 18:35:16 +0000 (18:35 +0000)]
Change SkTileGride geometry calculations to match the Chromium compositor.
This patch changes the semantics of tileWidth/Height to include the border region, and
uses an offset to take into account the fact that there is no outer border for outer
tiles. This patch also fixes a previous bug where the right column and bottom row were
considered to be included in bounds that are expressed as an SkIRect.
Companion Chromium CL required for roll: https://codereview.chromium.org/
12221077/
TEST=TileGrid unit test
Review URL: https://codereview.appspot.com/7350050
git-svn-id: http://skia.googlecode.com/svn/trunk@7885
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 17:46:09 +0000 (17:46 +0000)]
Revert r7883
git-svn-id: http://skia.googlecode.com/svn/trunk@7884
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 16:54:44 +0000 (16:54 +0000)]
Use SkSet to fix issue when pdf generates an exp number of resources.
The problem fixed - http://code.google.com/p/skia/issues/detail?id=940 - is that getResources will recursively obtain all child resource recursively without checking for duplicates.
If we have lots of duplicates, then we try to build a very large vector (exponential with the number of nodes usually) and sooner or later we end up using too much memory and crash.
A possible solution could have been to make sure resources do not have duplicates, but that requirement is impractical, and it this leaves the solution fragile, if there is any issue in the tree, we crash.
When we emit the pdf, the large number of duplicates is not an issue, because SkPDFCatalog::addObject will deal with duplicates.
I have run the gm with --config pdf, and the images are 100% same bits, while the pdfs have the same size but some very small changes, the order of some objects.
Review URL: https://codereview.appspot.com/6744050
git-svn-id: http://skia.googlecode.com/svn/trunk@7883
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 27 Feb 2013 16:43:49 +0000 (16:43 +0000)]
Replace A8 with RGBA8 when renderable A8 isn't supported
https://codereview.appspot.com/7372053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7882
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 27 Feb 2013 15:41:12 +0000 (15:41 +0000)]
GM : Unused parameters cleanup
I removed unused parameters in the gms wherever it was trivial to do so. I'm
trying to get the easy ones out of the way before we get into more involved
discussions around this.
Review URL: https://codereview.appspot.com/7398056
git-svn-id: http://skia.googlecode.com/svn/trunk@7881
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 27 Feb 2013 14:12:55 +0000 (14:12 +0000)]
Build freetype as a standalone_static_library
Needed by external applications which don't use our libraries in-place.
Review URL: https://codereview.chromium.org/
12328138
git-svn-id: http://skia.googlecode.com/svn/trunk@7879
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:35 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7878
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:22 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7877
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:12 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7876
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 27 Feb 2013 07:10:10 +0000 (07:10 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7875
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 22:58:09 +0000 (22:58 +0000)]
fix getFamilyName by calling FcFreeTypeQuery
git-svn-id: http://skia.googlecode.com/svn/trunk@7874
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 26 Feb 2013 21:56:19 +0000 (21:56 +0000)]
Fixed sk_getMetrics_utf32_xy function
The unused parameters x and y here seems to be a mistake.
Review URL: https://codereview.appspot.com/7386055
git-svn-id: http://skia.googlecode.com/svn/trunk@7873
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 21:46:32 +0000 (21:46 +0000)]
Use glGetStringi to get extensions when available.
Review URL: https://codereview.chromium.org/
12328111
git-svn-id: http://skia.googlecode.com/svn/trunk@7872
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 17:11:07 +0000 (17:11 +0000)]
implement CreateTypefaceFromFile
git-svn-id: http://skia.googlecode.com/svn/trunk@7869
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 17:01:26 +0000 (17:01 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7868
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 16:57:16 +0000 (16:57 +0000)]
move SampleTypeface into gm/typefacestyles
git-svn-id: http://skia.googlecode.com/svn/trunk@7867
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 26 Feb 2013 16:25:04 +0000 (16:25 +0000)]
Whitespace change to test commit-queue
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/
12328109
git-svn-id: http://skia.googlecode.com/svn/trunk@7866
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 26 Feb 2013 16:01:21 +0000 (16:01 +0000)]
Removing blank lines from codereview.settings.
depot_tools/checkout.py does not like blank lines:
https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38
Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue.
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7388061
git-svn-id: http://skia.googlecode.com/svn/trunk@7865
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 26 Feb 2013 15:56:05 +0000 (15:56 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7864
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 15:50:51 +0000 (15:50 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7863
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 15:40:01 +0000 (15:40 +0000)]
Rename template param to SkSTArray to be consistent with its base class, SkTArray.
R=jvanverth@google.com
Review URL: https://codereview.appspot.com/7372050
git-svn-id: http://skia.googlecode.com/svn/trunk@7862
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 14:45:41 +0000 (14:45 +0000)]
Add files omitted from gcl change in r7860.
git-svn-id: http://skia.googlecode.com/svn/trunk@7861
2bbb7eff-a529-9590-31e7-
b0007b416f81