platform/upstream/libSkiaSharp.git
10 years agoadd new readPixels with direct memory parameters
commit-bot@chromium.org [Mon, 17 Mar 2014 21:31:26 +0000 (21:31 +0000)]
add new readPixels with direct memory parameters

BUG=skia:
R=scroggo@google.com, bsalomon@google.com, robertphillips@google.com, fmalita@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/199413013

git-svn-id: http://skia.googlecode.com/svn/trunk@13840 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd nine patch type to SkRRect.
commit-bot@chromium.org [Mon, 17 Mar 2014 21:17:30 +0000 (21:17 +0000)]
Add nine patch type to SkRRect.

BUG=skia:2181

Committed: http://code.google.com/p/skia/source/detail?r=13833

R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/196343015

git-svn-id: http://skia.googlecode.com/svn/trunk@13839 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogen_bench_expectations to generate bench expectations files.
commit-bot@chromium.org [Mon, 17 Mar 2014 21:16:29 +0000 (21:16 +0000)]
gen_bench_expectations to generate bench expectations files.

BUG=skia:2225
NOTRY=true
R=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/201423002

git-svn-id: http://skia.googlecode.com/svn/trunk@13838 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Add nine patch type to SkRRect. (https://codereview.chromium.org/196343015/)
commit-bot@chromium.org [Mon, 17 Mar 2014 19:47:40 +0000 (19:47 +0000)]
Revert of Add nine patch type to SkRRect. (https://codereview.chromium.org/196343015/)

Reason for revert:
causes tests to have infinite loop

Original issue's description:
> Add nine patch type to SkRRect.
>
> BUG=skia:2181
>
> Committed: http://code.google.com/p/skia/source/detail?r=13833

R=robertphillips@google.com, reed@google.com
TBR=reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2181

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/202163004

git-svn-id: http://skia.googlecode.com/svn/trunk@13837 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a means of extracting active operations from SkPicture
commit-bot@chromium.org [Mon, 17 Mar 2014 18:11:57 +0000 (18:11 +0000)]
Add a means of extracting active operations from SkPicture

For the "pull forward" task I will be comparing the two cases:
  analyze the whole skp and use the BBH information
  analyze only the active portion of the skp

In the first case we need a way to get the BBH information out of the picture in order to extract the relevant portions of the whole-skp analysis. This adds caching of the active ops so that work isn't duplicated between when the optimization path queries for that information and when the usual draw path queries for it.

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/195793010

git-svn-id: http://skia.googlecode.com/svn/trunk@13836 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG -- dead code
commit-bot@chromium.org [Mon, 17 Mar 2014 17:03:18 +0000 (17:03 +0000)]
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG -- dead code

BUG=skia:
R=halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/201973003

git-svn-id: http://skia.googlecode.com/svn/trunk@13834 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd nine patch type to SkRRect.
commit-bot@chromium.org [Mon, 17 Mar 2014 15:39:01 +0000 (15:39 +0000)]
Add nine patch type to SkRRect.

BUG=skia:2181
R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/196343015

git-svn-id: http://skia.googlecode.com/svn/trunk@13833 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReverting r13831 (Add a means of extracting active operations from SkPicture) due...
robertphillips@google.com [Mon, 17 Mar 2014 15:10:02 +0000 (15:10 +0000)]
Reverting r13831 (Add a means of extracting active operations from SkPicture) due to Mac compiler issue

git-svn-id: http://skia.googlecode.com/svn/trunk@13832 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a means of extracting active operations from SkPicture
robertphillips@google.com [Mon, 17 Mar 2014 14:56:13 +0000 (14:56 +0000)]
Add a means of extracting active operations from SkPicture

https://codereview.chromium.org/195793010/

git-svn-id: http://skia.googlecode.com/svn/trunk@13831 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: make intermediate JSON specify base urls for diff images
commit-bot@chromium.org [Mon, 17 Mar 2014 14:22:02 +0000 (14:22 +0000)]
rebaseline_server: make intermediate JSON specify base urls for diff images

BUG=skia:1919,skia:2230
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/196533021

git-svn-id: http://skia.googlecode.com/svn/trunk@13830 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkFontStyleSet_DirectWrite::getStyle to properly handle NULL out params.
bungeman@google.com [Mon, 17 Mar 2014 14:04:50 +0000 (14:04 +0000)]
SkFontStyleSet_DirectWrite::getStyle to properly handle NULL out params.

R=reed@google.com

Review URL: https://codereview.chromium.org/201213003

git-svn-id: http://skia.googlecode.com/svn/trunk@13829 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix result order reliance
commit-bot@chromium.org [Mon, 17 Mar 2014 12:14:48 +0000 (12:14 +0000)]
Fix result order reliance

The old tests presumed result order in a way was safe because SkPicture was sorting the paint calls.
This fixes the tests to not check result ordering, just presence

BUG=skia:
R=robertphillips@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/197813011

git-svn-id: http://skia.googlecode.com/svn/trunk@13828 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChange tilegrid test to test it directly, rather than through SkPicture
commit-bot@chromium.org [Mon, 17 Mar 2014 10:51:44 +0000 (10:51 +0000)]
Change tilegrid test to test it directly, rather than through SkPicture
This is necessary because it makes assumptions that picture will draw all the rects that match the grids, which may not hold if picture decides to improve the accuracy of the results.

BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/199083004

git-svn-id: http://skia.googlecode.com/svn/trunk@13827 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFast implementation of QuadTree
commit-bot@chromium.org [Mon, 17 Mar 2014 10:38:34 +0000 (10:38 +0000)]
Fast implementation of QuadTree

Rewritten to avoid memory allocations.

BUG=skia:2242
R=tomhudson@google.com, mtklein@google.com, reed@google.com, robertphillips@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/187233002

git-svn-id: http://skia.googlecode.com/svn/trunk@13826 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Mon, 17 Mar 2014 03:02:17 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13825 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd NewRasterDirect for creating a canvas drawing to pre-allocated pixels
commit-bot@chromium.org [Mon, 17 Mar 2014 02:13:07 +0000 (02:13 +0000)]
add NewRasterDirect for creating a canvas drawing to pre-allocated pixels

R=reed@google.com
TBR=scroggo@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/196923004

git-svn-id: http://skia.googlecode.com/svn/trunk@13824 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove SkNoSaveLayerCanvas.h to include/utils
robertphillips@google.com [Sun, 16 Mar 2014 21:59:11 +0000 (21:59 +0000)]
Move SkNoSaveLayerCanvas.h to include/utils

https://codereview.chromium.org/197243005

git-svn-id: http://skia.googlecode.com/svn/trunk@13823 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoProposed SkCanvas API for preLoading textures to VRAM v2.0
commit-bot@chromium.org [Sun, 16 Mar 2014 19:46:36 +0000 (19:46 +0000)]
Proposed SkCanvas API for preLoading textures to VRAM v2.0

This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)).

Committed: http://code.google.com/p/skia/source/detail?r=13810

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/197123003

git-svn-id: http://skia.googlecode.com/svn/trunk@13822 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselining stragglers.
senorblanco@chromium.org [Sat, 15 Mar 2014 14:20:35 +0000 (14:20 +0000)]
Rebaselining stragglers.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/197283024

git-svn-id: http://skia.googlecode.com/svn/trunk@13821 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 15 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13820 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore imagefiltersclipped and displacement rebaselines.
senorblanco@chromium.org [Sat, 15 Mar 2014 00:37:33 +0000 (00:37 +0000)]
More imagefiltersclipped and displacement rebaselines.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/197283022

git-svn-id: http://skia.googlecode.com/svn/trunk@13819 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemoves bench expectations files. New place is skia-autogen svn repo. See https:...
commit-bot@chromium.org [Fri, 14 Mar 2014 23:42:16 +0000 (23:42 +0000)]
Removes bench expectations files. New place is skia-autogen svn repo. See https://codereview.chromium.org/196653010/

BUG=skia:2225
NOTRY=true
NOTREECHECKS=true
TBR=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/199143004

git-svn-id: http://skia.googlecode.com/svn/trunk@13818 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange tooBitForLCD to compare against linear size of the text, not the area
commit-bot@chromium.org [Fri, 14 Mar 2014 22:59:05 +0000 (22:59 +0000)]
change tooBitForLCD to compare against linear size of the text, not the area

BUG=skia:
R=bungeman@google.com, alokp@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/200643003

git-svn-id: http://skia.googlecode.com/svn/trunk@13817 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for displacement, imagefiltersclipped GMs.
senorblanco@chromium.org [Fri, 14 Mar 2014 21:55:15 +0000 (21:55 +0000)]
New baselines for displacement, imagefiltersclipped GMs.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/196383021

git-svn-id: http://skia.googlecode.com/svn/trunk@13816 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGet correct text metrics for distance fields, and fix dropouts due to thin features.
commit-bot@chromium.org [Fri, 14 Mar 2014 21:22:38 +0000 (21:22 +0000)]
Get correct text metrics for distance fields, and fix dropouts due to thin features.

BUG=skia:2173
R=robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/200423003

git-svn-id: http://skia.googlecode.com/svn/trunk@13815 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix a leak
commit-bot@chromium.org [Fri, 14 Mar 2014 21:22:22 +0000 (21:22 +0000)]
fix a leak

R=sugoi@chromium.org, bungeman@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/195763025

git-svn-id: http://skia.googlecode.com/svn/trunk@13814 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agodon't reference config() -- use colorType() instead
reed@google.com [Fri, 14 Mar 2014 20:48:05 +0000 (20:48 +0000)]
don't reference config() -- use colorType() instead

BUG=skia:

Review URL: https://codereview.chromium.org/200853002

git-svn-id: http://skia.googlecode.com/svn/trunk@13813 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSuppress imagefilterscropexpand GM temporarily to fix Win Debug failures.
commit-bot@chromium.org [Fri, 14 Mar 2014 19:02:15 +0000 (19:02 +0000)]
Suppress imagefilterscropexpand GM temporarily to fix Win Debug failures.
NOTREECHECKS=true
NOTRY=true
R=halcanary@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/200703002

git-svn-id: http://skia.googlecode.com/svn/trunk@13812 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r13810 (Proposed SkCanvas API for preLoading textures to VRAM v2.0)
robertphillips@google.com [Fri, 14 Mar 2014 18:50:07 +0000 (18:50 +0000)]
Revert r13810 (Proposed SkCanvas API for preLoading textures to VRAM v2.0)

git-svn-id: http://skia.googlecode.com/svn/trunk@13811 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoProposed SkCanvas API for preLoading textures to VRAM v2.0
commit-bot@chromium.org [Fri, 14 Mar 2014 18:23:12 +0000 (18:23 +0000)]
Proposed SkCanvas API for preLoading textures to VRAM v2.0

This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)).

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/197123003

git-svn-id: http://skia.googlecode.com/svn/trunk@13810 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement support for expanding crop rects in image filters
senorblanco@chromium.org [Fri, 14 Mar 2014 17:44:41 +0000 (17:44 +0000)]
Implement support for expanding crop rects in image filters

NOTE: this patch set is based on https://codereview.chromium.org/189913021/,
and needs that patch to land first.

Until now, crop rects in Skia have only been able to reduce
the size of the destination bounds, but not expand them.
SVG semantics require the latter as well. The heart of
the change is in applyCropRect(), which now assigns each
edge, instead of doing an intersection with the crop rect.

In order to support this (and still work well with tiled
drawing) we need to clip the resulting crop rect to the
clipping region of the filters. This uses the Context struct
previously landed from https://codereview.chromium.org/189913021/.

Many of the pixel loops are not yet ready to handle a
destination rect larger than the source rect. So we provide
a convenience version of applyCropRect() which creates an
offscreen and pads it out with transparent black. Once the
pixel loops and shaders have been fixed to support larger
destination bounds, they should be switched back to the
non-drawing version of applyCropRect().

BUG=skia:
R=bsalomon@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13805

Review URL: https://codereview.chromium.org/198003008

git-svn-id: http://skia.googlecode.com/svn/trunk@13809 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG
reed@google.com [Fri, 14 Mar 2014 17:26:15 +0000 (17:26 +0000)]
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG

BUG=skia:

Review URL: https://codereview.chromium.org/200533002

git-svn-id: http://skia.googlecode.com/svn/trunk@13808 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES
reed@google.com [Fri, 14 Mar 2014 17:24:05 +0000 (17:24 +0000)]
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES

BUG=skia:

Review URL: https://codereview.chromium.org/195763023

git-svn-id: http://skia.googlecode.com/svn/trunk@13807 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Implement support for expanding crop rects in image filters"
senorblanco@chromium.org [Fri, 14 Mar 2014 16:48:39 +0000 (16:48 +0000)]
Revert "Implement support for expanding crop rects in image filters"

Breaking ImageFilterTests unit test.

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/196353021

git-svn-id: http://skia.googlecode.com/svn/trunk@13806 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement support for expanding crop rects in image filters
senorblanco@chromium.org [Fri, 14 Mar 2014 16:35:08 +0000 (16:35 +0000)]
Implement support for expanding crop rects in image filters

NOTE: this patch set is based on https://codereview.chromium.org/189913021/,
and needs that patch to land first.

Until now, crop rects in Skia have only been able to reduce
the size of the destination bounds, but not expand them.
SVG semantics require the latter as well. The heart of
the change is in applyCropRect(), which now assigns each
edge, instead of doing an intersection with the crop rect.

In order to support this (and still work well with tiled
drawing) we need to clip the resulting crop rect to the
clipping region of the filters. This uses the Context struct
previously landed from https://codereview.chromium.org/189913021/.

Many of the pixel loops are not yet ready to handle a
destination rect larger than the source rect. So we provide
a convenience version of applyCropRect() which creates an
offscreen and pads it out with transparent black. Once the
pixel loops and shaders have been fixed to support larger
destination bounds, they should be switched back to the
non-drawing version of applyCropRect().

BUG=skia:
R=bsalomon@google.com, reed@google.com

Review URL: https://codereview.chromium.org/198003008

git-svn-id: http://skia.googlecode.com/svn/trunk@13805 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agotools/roll_deps: add '-m tryserver.chromium' to git-cl-try
commit-bot@chromium.org [Fri, 14 Mar 2014 15:50:39 +0000 (15:50 +0000)]
tools/roll_deps:  add '-m tryserver.chromium' to git-cl-try

R=rmistry@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/200203003

git-svn-id: http://skia.googlecode.com/svn/trunk@13804 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement support for a Context parameter in image filters
senorblanco@chromium.org [Fri, 14 Mar 2014 15:44:01 +0000 (15:44 +0000)]
Implement support for a Context parameter in image filters

Some upcoming work (support for expanding crop rects) requires
the clip bounds to be available during filter traversal. This change
replaces the SkMatrix parameter in the onFilterImage() traversals
with a Context parameter. It contains the CTM, as well as the clip
bounds.

BUG=skia:
R=reed@google.com

Review URL: https://codereview.chromium.org/189913021

git-svn-id: http://skia.googlecode.com/svn/trunk@13803 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agocheck for null-device pixels in onWritePixels, so we don't crash
reed@google.com [Fri, 14 Mar 2014 14:02:58 +0000 (14:02 +0000)]
check for null-device pixels in onWritePixels, so we don't crash

https://code.google.com/p/chromium/issues/detail?id=352616

Review URL: https://codereview.chromium.org/196223013

git-svn-id: http://skia.googlecode.com/svn/trunk@13802 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agokeep kVector enum in legacy mode for getDeviceProperties
reed@google.com [Fri, 14 Mar 2014 12:32:07 +0000 (12:32 +0000)]
keep kVector enum in legacy mode for getDeviceProperties

git-svn-id: http://skia.googlecode.com/svn/trunk@13801 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 14 Mar 2014 03:02:26 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13800 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDe-virtualize SkCanvas matrix ops.
commit-bot@chromium.org [Thu, 13 Mar 2014 20:03:58 +0000 (20:03 +0000)]
De-virtualize SkCanvas matrix ops.

This moves the matrix management logic into non-virtual SkCanvas
methods, and turns the virtuals into protected notifiers.

R=reed@google.com, robertphillips@google.com, bsalomon@google.com
BUG=skia:2297

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/195793012

git-svn-id: http://skia.googlecode.com/svn/trunk@13799 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdded Z scale when X and Y scale to spot lights and point lights
commit-bot@chromium.org [Thu, 13 Mar 2014 19:45:41 +0000 (19:45 +0000)]
Added Z scale when X and Y scale to spot lights and point lights

Z scale is set as the average of X scale and Y scale.

BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/198013002

git-svn-id: http://skia.googlecode.com/svn/trunk@13798 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogetDeviceCapabilities is no longer need, so remove it
commit-bot@chromium.org [Thu, 13 Mar 2014 19:38:10 +0000 (19:38 +0000)]
getDeviceCapabilities is no longer need, so remove it

BUG=skia:
R=bungeman@google.com, vandebo@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/198943003

git-svn-id: http://skia.googlecode.com/svn/trunk@13797 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAttempt to fix -1->unsigned warning on mac 10.6
bsalomon@google.com [Thu, 13 Mar 2014 19:20:32 +0000 (19:20 +0000)]
Attempt to fix -1->unsigned warning on mac 10.6

TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/199433002

git-svn-id: http://skia.googlecode.com/svn/trunk@13796 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow toString capability to be toggled independent of developer mode.
commit-bot@chromium.org [Thu, 13 Mar 2014 18:02:17 +0000 (18:02 +0000)]
Allow toString capability to be toggled independent of developer mode.

This change is motivated by the desire to see the text information in the debugger when not in developer mode. It is structured so user's can disable it if the capability is not wanted.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/197763008

git-svn-id: http://skia.googlecode.com/svn/trunk@13795 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd effect-based clip for nine-patch SkRRects.
commit-bot@chromium.org [Thu, 13 Mar 2014 18:01:05 +0000 (18:01 +0000)]
Add effect-based clip for nine-patch SkRRects.

BUG=skia:2181
R=jvanverth@google.com, robertphillips@google.com, rmistry@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/194703011

git-svn-id: http://skia.googlecode.com/svn/trunk@13794 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd comment for gcc compiler bug work-around for SK_COMPILE_ASSERT.
bungeman@google.com [Thu, 13 Mar 2014 17:51:05 +0000 (17:51 +0000)]
Add comment for gcc compiler bug work-around for SK_COMPILE_ASSERT.

If this comment had existed previously, I could have avoided breaking
some bots.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/196473013

git-svn-id: http://skia.googlecode.com/svn/trunk@13793 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake rebaseline_server client check schema version number
commit-bot@chromium.org [Thu, 13 Mar 2014 17:44:01 +0000 (17:44 +0000)]
make rebaseline_server client check schema version number

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/195763013

git-svn-id: http://skia.googlecode.com/svn/trunk@13792 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix distance field edge detection.
commit-bot@chromium.org [Thu, 13 Mar 2014 17:11:44 +0000 (17:11 +0000)]
Fix distance field edge detection.

When computing the initial edges for distance field generation, I was skipping
the outer pixels of glyphs to avoid accessing out of range memory. However,
there might be an edge transition on those pixels. This detects those cases.

R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/197423003

git-svn-id: http://skia.googlecode.com/svn/trunk@13791 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd schema version to rebaseline_server intermediate JSON
commit-bot@chromium.org [Thu, 13 Mar 2014 16:33:36 +0000 (16:33 +0000)]
add schema version to rebaseline_server intermediate JSON

NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/196343009

git-svn-id: http://skia.googlecode.com/svn/trunk@13790 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChanges to SkFontHost_linux
commit-bot@chromium.org [Thu, 13 Mar 2014 16:24:49 +0000 (16:24 +0000)]
Changes to SkFontHost_linux

* Use SkOSPath::SkPathJoin() rather than append so that
  SK_FONT_FILE_PREFIX does not have to end in a '/'.

* Add another font to the default font list.

Motivation: Some tests fail when there are no default fonts.

BUG=skia:2282
R=bungeman@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/195733007

git-svn-id: http://skia.googlecode.com/svn/trunk@13789 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark strokerects_gpu GM as ignore-failure on Win7/Perspective
commit-bot@chromium.org [Thu, 13 Mar 2014 16:23:20 +0000 (16:23 +0000)]
Mark strokerects_gpu GM as ignore-failure on Win7/Perspective

BUG=skia:2295
R=bsalomon@google.com, epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/198923003

git-svn-id: http://skia.googlecode.com/svn/trunk@13788 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago--dryRun flag for bench
commit-bot@chromium.org [Thu, 13 Mar 2014 16:22:00 +0000 (16:22 +0000)]
--dryRun flag for bench

causes bench to print out what tests it would be running, without actually running them.

BUG=skia:2294
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/197873010

git-svn-id: http://skia.googlecode.com/svn/trunk@13787 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix memory leak introduced in 9e5f85e8
commit-bot@chromium.org [Thu, 13 Mar 2014 16:18:49 +0000 (16:18 +0000)]
fix memory leak introduced in 9e5f85e8

R=sugoi@chromium.org, robertphillips@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/199173002

git-svn-id: http://skia.googlecode.com/svn/trunk@13786 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago--dryRun flag for gm
commit-bot@chromium.org [Thu, 13 Mar 2014 16:16:36 +0000 (16:16 +0000)]
--dryRun flag for gm

Causes gm to not actually run any tests / create any directories, just print its normal output.  Useful for showing what tests would be run without actually taking the time to run them.

BUG=skia:2294
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/199093002

git-svn-id: http://skia.googlecode.com/svn/trunk@13785 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew GPU baselines for colormatrix GM.
senorblanco@chromium.org [Thu, 13 Mar 2014 15:33:02 +0000 (15:33 +0000)]
New GPU baselines for colormatrix GM.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/198973003

git-svn-id: http://skia.googlecode.com/svn/trunk@13784 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: generate JSON that can be viewed without a live server
commit-bot@chromium.org [Thu, 13 Mar 2014 14:56:29 +0000 (14:56 +0000)]
rebaseline_server: generate JSON that can be viewed without a live server

BUG=skia:1919
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/195943004

git-svn-id: http://skia.googlecode.com/svn/trunk@13783 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 13 Mar 2014 03:02:23 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13782 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd required parens for r13779.
bungeman@google.com [Wed, 12 Mar 2014 21:56:23 +0000 (21:56 +0000)]
Add required parens for r13779.

git-svn-id: http://skia.googlecode.com/svn/trunk@13781 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_COPYTO_CONFIG
commit-bot@chromium.org [Wed, 12 Mar 2014 21:47:51 +0000 (21:47 +0000)]
remove SK_SUPPORT_LEGACY_COPYTO_CONFIG

TBR=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/196413009

git-svn-id: http://skia.googlecode.com/svn/trunk@13780 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix (1 << 31) to (1u << 31) in SkOTTable_OS_2.
bungeman@google.com [Wed, 12 Mar 2014 21:41:06 +0000 (21:41 +0000)]
Fix (1 << 31) to (1u << 31) in SkOTTable_OS_2.

When ints are 32 bits, (1 << 31) is undefined.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13757

Review URL: https://codereview.chromium.org/189093020

git-svn-id: http://skia.googlecode.com/svn/trunk@13779 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix GPU colormatrix color filter with saturated alpha.
senorblanco@chromium.org [Wed, 12 Mar 2014 21:37:42 +0000 (21:37 +0000)]
Fix GPU colormatrix color filter with saturated alpha.

Clamp RGBA values before unpremultiplying, to match the raster path. This causes a problem when the resulting
alpha is >1.0, resulting in overly saturated RGB.

Covered by the setYUV2RGB() test case in the colormatrix GM.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/196133006

git-svn-id: http://skia.googlecode.com/svn/trunk@13778 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd gm to show bug in stroked-text in drawPosText
commit-bot@chromium.org [Wed, 12 Mar 2014 20:31:24 +0000 (20:31 +0000)]
add gm to show bug in stroked-text in drawPosText

BUG=skia:
R=fmalita@google.com, bungeman@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/198083003

git-svn-id: http://skia.googlecode.com/svn/trunk@13777 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDe-virtualize SkCanvas save/restore.
commit-bot@chromium.org [Wed, 12 Mar 2014 20:21:48 +0000 (20:21 +0000)]
De-virtualize SkCanvas save/restore.

This moves the state management logic into non-virtual SkCanvas methods,
and turns the virtuals into protected notifiers.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/194713008

git-svn-id: http://skia.googlecode.com/svn/trunk@13776 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorender_pictures unittests: run over a dir with multiple SKPs, like production
commit-bot@chromium.org [Wed, 12 Mar 2014 20:09:46 +0000 (20:09 +0000)]
render_pictures unittests: run over a dir with multiple SKPs, like production

BUG=skia:1942
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/194563004

git-svn-id: http://skia.googlecode.com/svn/trunk@13775 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agosupport direct writing to top layer, and hide getTopLayer()
reed@google.com [Wed, 12 Mar 2014 18:28:35 +0000 (18:28 +0000)]
support direct writing to top layer, and hide getTopLayer()

this should remove many of the chrome callers that today call
accessBitmap on the toplayer, so they can read/write those pixels.

The ultimate fix will be to support custom allocation of raster layers
(via GDI/cairo/mac) so we can remove PlatformDevice subclassing in
skia/ext

BUG=skia:
R=bsalomon@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/197433002

git-svn-id: http://skia.googlecode.com/svn/trunk@13774 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove unused zero_fill() in GrAtlas.cpp
fmalita@google.com [Wed, 12 Mar 2014 17:31:20 +0000 (17:31 +0000)]
Remove unused zero_fill() in GrAtlas.cpp

Triggers warnings with some local clang builds.

R=jvanverth@google.com

Review URL: https://codereview.chromium.org/197663003

git-svn-id: http://skia.googlecode.com/svn/trunk@13773 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix unit tests
bsalomon@google.com [Wed, 12 Mar 2014 17:29:46 +0000 (17:29 +0000)]
Fix unit tests

Review URL: https://codereview.chromium.org/197823002

git-svn-id: http://skia.googlecode.com/svn/trunk@13772 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix for test failure
robertphillips@google.com [Wed, 12 Mar 2014 17:16:59 +0000 (17:16 +0000)]
Fix for test failure

git-svn-id: http://skia.googlecode.com/svn/trunk@13771 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd compile flag to force usage of distance fields for all SkPaints.
commit-bot@chromium.org [Wed, 12 Mar 2014 17:05:46 +0000 (17:05 +0000)]
Add compile flag to force usage of distance fields for all SkPaints.

BUG=skia:2173
R=reed@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/195213003

git-svn-id: http://skia.googlecode.com/svn/trunk@13770 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd capture snapshot as data to SkWriter32, use it to optimise record->playback.
commit-bot@chromium.org [Wed, 12 Mar 2014 17:04:28 +0000 (17:04 +0000)]
Add capture snapshot as data to SkWriter32, use it to optimise record->playback.
This is a new way of implementing https://codereview.chromium.org/155863005/
It uses copy on write semantics to return a buffer without copying it, so that record -> playback does not need to copy the buffer.

BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com, iancottrell@chromium.org

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/167113003

git-svn-id: http://skia.googlecode.com/svn/trunk@13769 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoClean up SkImageFilter.
commit-bot@chromium.org [Wed, 12 Mar 2014 16:36:08 +0000 (16:36 +0000)]
Clean up SkImageFilter.

Rename more occurences of 'target' to 'kernelOffset'.
This is a follow-up patch to
https://codereview.chromium.org/182983003/

BUG=skia:2187
R=senorblanco@chromium.org

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/197013003

git-svn-id: http://skia.googlecode.com/svn/trunk@13768 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStores per-iteration bench values in BenchDataPoint.
commit-bot@chromium.org [Wed, 12 Mar 2014 16:23:33 +0000 (16:23 +0000)]
Stores per-iteration bench values in BenchDataPoint.

BUG=skia:2225
NOTRY=true
R=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/197573002

git-svn-id: http://skia.googlecode.com/svn/trunk@13767 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd elliptical-corner rrect clip effect. Currently only handles the case where all...
commit-bot@chromium.org [Wed, 12 Mar 2014 15:32:50 +0000 (15:32 +0000)]
Add elliptical-corner rrect clip effect. Currently only handles the case where all corners have the same pair of radii.

BUG=skia:2181
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/194603004

git-svn-id: http://skia.googlecode.com/svn/trunk@13766 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview...
commit-bot@chromium.org [Wed, 12 Mar 2014 15:08:22 +0000 (15:08 +0000)]
Revert of Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/196323003/)

Reason for revert:
Pulling out to rename the virtuals.

Original issue's description:
> Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/)
>
> Reason for revert:
> Re-landing after roll fix.
>
> Original issue's description:
> > Revert "De-virtualize SkCanvas save/restore."
> >
> > (To allow a roll fix into the tree).
> >
> > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b.
> >
> > R=halcanary@google.com
> >
> > Committed: https://code.google.com/p/skia/source/detail?r=13748
>
> TBR=halcanary@google.com,fmalita@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=13754

R=halcanary@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, halcanary@google.com
NOTREECHECKS=true
NOTRY=true

Author: fmalita@google.com

Review URL: https://codereview.chromium.org/197553002

git-svn-id: http://skia.googlecode.com/svn/trunk@13765 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixing SkPicture serialization
commit-bot@chromium.org [Wed, 12 Mar 2014 14:46:41 +0000 (14:46 +0000)]
Fixing SkPicture serialization

Fixed a few issues while attempting to use the new
serialization path for SkPicture inside a fuzzer:
- SkReadBuffer and SkValidatingReadBuffer both had a fReader
member instead of sharing the same member, which leads to
problems if a base class function is used
- In SkPicture, a header is now written as a single chunk of
data, so it also has to be read as a single chunk of data
- In the SkPicturePlayback destructor, a bad deserialization
would lead to a crash if we don't safely unref fOpData
- Also in SkPicturePlayback, if we only use a ReadBuffer for
the whole deserialization, additional tags must be added to
parseBufferTag()
- SkValidatingReadBuffer::readBitmap() was broken, but this
path wasn't usen't since the only use case for
SkValidatingReadBuffer is currently image filters and
bitmaps are unflattened as part of the deserialization of
SkBitmapSource
- SkPictureImageFilter was not deserializable. Added it to
SkGlobalInitialization*
- Added a test that exercises the SkPicture serialization /
deserialization code

BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, robertphillips@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/195223003

git-svn-id: http://skia.googlecode.com/svn/trunk@13764 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd NVPR configs to DM
commit-bot@chromium.org [Wed, 12 Mar 2014 14:46:31 +0000 (14:46 +0000)]
Add NVPR configs to DM

Add NVPR configs to DM. The bench and gm parts support NVPR already.

R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/196633005

git-svn-id: http://skia.googlecode.com/svn/trunk@13763 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for imagefiltersclipped, offsetimagefilter GMs.
senorblanco@chromium.org [Wed, 12 Mar 2014 14:01:48 +0000 (14:01 +0000)]
New baselines for imagefiltersclipped, offsetimagefilter GMs.

These were modified by
https://code.google.com/p/skia/source/detail?r=13744

TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/196603005

git-svn-id: http://skia.googlecode.com/svn/trunk@13762 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline performance triggers for Mac10.6 & N7
robertphillips@google.com [Wed, 12 Mar 2014 13:35:23 +0000 (13:35 +0000)]
Rebaseline performance triggers for Mac10.6 & N7

https://codereview.chromium.org/196573006/

git-svn-id: http://skia.googlecode.com/svn/trunk@13761 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago[WIP] Add Context to SkDrawLooper.
commit-bot@chromium.org [Wed, 12 Mar 2014 09:42:01 +0000 (09:42 +0000)]
[WIP] Add Context to SkDrawLooper.

SkDrawLooper carries some state during draws. This CL extracts this state into
a separate class Context, which is then passed by the users of SkDrawLooper
into the appropriate methods.
This is a step towards making SkDrawLooper immutable.

BUG=skia:2141
R=scroggo@google.com, reed@google.com, sugoi@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/155513012

git-svn-id: http://skia.googlecode.com/svn/trunk@13760 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert the rest of r13757.
bungeman@google.com [Wed, 12 Mar 2014 04:00:25 +0000 (04:00 +0000)]
Revert the rest of r13757.

git-svn-id: http://skia.googlecode.com/svn/trunk@13759 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert 13757.
bungeman@google.com [Wed, 12 Mar 2014 03:46:48 +0000 (03:46 +0000)]
Revert 13757.

git-svn-id: http://skia.googlecode.com/svn/trunk@13758 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix (1 << 31) to (1u << 31) in SkOTTable_OS_2.
bungeman@google.com [Wed, 12 Mar 2014 03:13:48 +0000 (03:13 +0000)]
Fix (1 << 31) to (1u << 31) in SkOTTable_OS_2.

When ints are 32 bits, (1 << 31) is undefined.

R=reed@google.com

Review URL: https://codereview.chromium.org/189093020

git-svn-id: http://skia.googlecode.com/svn/trunk@13757 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake onReadPixels protected and have default impl (so we can remove chrome override)
commit-bot@chromium.org [Wed, 12 Mar 2014 03:04:08 +0000 (03:04 +0000)]
make onReadPixels protected and have default impl (so we can remove chrome override)

R=reed@google.com
TBR=bsalomon@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/196543004

git-svn-id: http://skia.googlecode.com/svn/trunk@13756 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 12 Mar 2014 03:02:18 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13755 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium...
commit-bot@chromium.org [Tue, 11 Mar 2014 23:47:35 +0000 (23:47 +0000)]
Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/)

Reason for revert:
Re-landing after roll fix.

Original issue's description:
> Revert "De-virtualize SkCanvas save/restore."
>
> (To allow a roll fix into the tree).
>
> This reverts commit edf702204be42c945254191f9f9cd6585b3d189b.
>
> R=halcanary@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=13748

R=halcanary@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, halcanary@google.com
NOTREECHECKS=true
NOTRY=true

Author: fmalita@google.com

Review URL: https://codereview.chromium.org/196323003

git-svn-id: http://skia.googlecode.com/svn/trunk@13754 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_COPYTO_CONFIG
commit-bot@chromium.org [Tue, 11 Mar 2014 22:58:24 +0000 (22:58 +0000)]
remove SK_SUPPORT_LEGACY_COPYTO_CONFIG

R=halcanary@google.com
TBR=halcanary@google.com
NOTRY=True
NOTREECHECK=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/196003003

git-svn-id: http://skia.googlecode.com/svn/trunk@13753 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAlter bench_pictures to "respect" the logPerIter flag.
commit-bot@chromium.org [Tue, 11 Mar 2014 22:58:00 +0000 (22:58 +0000)]
Alter bench_pictures to "respect" the logPerIter flag.

When --logPerIters is set and --repeat is great then 2 then bench_pictures will run each test "repeat" times (to generate the correct number of timings) by rendering 5 times.

This CL also adds a swapBuffers in addition to the pre-existing flush calls.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/194973003

git-svn-id: http://skia.googlecode.com/svn/trunk@13752 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFirst pass at a web app that lets you run Skia code and see the results.
commit-bot@chromium.org [Tue, 11 Mar 2014 22:57:50 +0000 (22:57 +0000)]
First pass at a web app that lets you run Skia code and see the results.

BUG=skia:
R=reed@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/195143004

git-svn-id: http://skia.googlecode.com/svn/trunk@13751 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoOnly set USE_ANDROID_NDK_CPU_FEATURES if it's not already been explicitly set
commit-bot@chromium.org [Tue, 11 Mar 2014 22:57:21 +0000 (22:57 +0000)]
Only set USE_ANDROID_NDK_CPU_FEATURES if it's not already been explicitly set

R=djsollen@google.com, reed@google.com
BUG=skia:

Author: george@mozilla.com

Review URL: https://codereview.chromium.org/189263015

git-svn-id: http://skia.googlecode.com/svn/trunk@13750 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix build error in chromium
commit-bot@chromium.org [Tue, 11 Mar 2014 21:50:00 +0000 (21:50 +0000)]
fix build error in chromium

NOTREECHECKS=true
NOTRY=true
R=fmalita@google.com, jvanverth@google.com, fmalita@chromium.org
TBR=fmalita@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/195223004

git-svn-id: http://skia.googlecode.com/svn/trunk@13749 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "De-virtualize SkCanvas save/restore."
fmalita@google.com [Tue, 11 Mar 2014 21:46:56 +0000 (21:46 +0000)]
Revert "De-virtualize SkCanvas save/restore."

(To allow a roll fix into the tree).

This reverts commit edf702204be42c945254191f9f9cd6585b3d189b.

R=halcanary@google.com

Review URL: https://codereview.chromium.org/194923008

git-svn-id: http://skia.googlecode.com/svn/trunk@13748 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDe-virtualize SkCanvas save/restore.
fmalita@google.com [Tue, 11 Mar 2014 21:04:41 +0000 (21:04 +0000)]
De-virtualize SkCanvas save/restore.

This moves the state management logic into non-virtual SkCanvas methods,
and turns the virtuals into protected notifiers.

R=robertphillips@google.com, reed@google.com

Review URL: https://codereview.chromium.org/194713008

git-svn-id: http://skia.googlecode.com/svn/trunk@13747 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDrop executable flag from headers so that they can be packaged
robertphillips@google.com [Tue, 11 Mar 2014 19:55:51 +0000 (19:55 +0000)]
Drop executable flag from headers so that they can be packaged

https://codereview.chromium.org/194883004/

git-svn-id: http://skia.googlecode.com/svn/trunk@13746 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix linking errors on android builds due to cdd0f92b1ac
commit-bot@chromium.org [Tue, 11 Mar 2014 19:12:44 +0000 (19:12 +0000)]
Fix linking errors on android builds due to cdd0f92b1ac

NOTREECHECKS=true
NOTRY=true
R=iancottrell@google.com, tomhudson@google.com
TBR=tomhudson@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/194563003

git-svn-id: http://skia.googlecode.com/svn/trunk@13745 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix SkOffsetImageFilter to use a temporary for bounds computations.
senorblanco@chromium.org [Tue, 11 Mar 2014 18:29:42 +0000 (18:29 +0000)]
Fix SkOffsetImageFilter to use a temporary for bounds computations.

SkOffsetImageFilter::onFilterBounds() was writing to *dst, and later
referring to src. These may be the same memory location, so the results
were incorrect.

Covered by the 5th test case in offsetimagefilter.

BUG=skia:

Review URL: https://codereview.chromium.org/195163004

git-svn-id: http://skia.googlecode.com/svn/trunk@13744 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew version of the bbh shootout.
commit-bot@chromium.org [Tue, 11 Mar 2014 17:27:07 +0000 (17:27 +0000)]
New version of the bbh shootout.
There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree.
The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed.
Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO.

Doing this so I can reasonably compare the new QuadTree implementation.
BUG=skia:2242

Committed: http://code.google.com/p/skia/source/detail?r=13736

R=tomhudson@google.com, mtklein@google.com, reed@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/186973005

git-svn-id: http://skia.googlecode.com/svn/trunk@13743 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix radical assumption that 0.5 in double is exactly convertible to float.
bsalomon@google.com [Tue, 11 Mar 2014 17:09:17 +0000 (17:09 +0000)]
Fix radical assumption that 0.5 in double is exactly convertible to float.

BUG=skia:2181

Review URL: https://codereview.chromium.org/195423002

git-svn-id: http://skia.googlecode.com/svn/trunk@13742 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEnable use of distance fields via SkPaint flag.
commit-bot@chromium.org [Tue, 11 Mar 2014 17:07:15 +0000 (17:07 +0000)]
Enable use of distance fields via SkPaint flag.

Now that distance field generation is fast enough to make it practical, this makes distances field fonts easily available to anyone who wants to try them out (i.e Chromium).

BUG=skia:2173
R=reed@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/193163003

git-svn-id: http://skia.googlecode.com/svn/trunk@13741 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd new module for distance field generation.
commit-bot@chromium.org [Tue, 11 Mar 2014 15:57:40 +0000 (15:57 +0000)]
Add new module for distance field generation.

This improves the speed over the previous method by 10x+, and makes using distance fields practical.

BUG=skia:2173

Committed: http://code.google.com/p/skia/source/detail?r=13729

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/178543007

git-svn-id: http://skia.googlecode.com/svn/trunk@13740 2bbb7eff-a529-9590-31e7-b0007b416f81