Fabio M. De Francesco [Fri, 24 Sep 2021 12:27:01 +0000 (14:27 +0200)]
staging: r8188eu: Remove a test from usbctrl_vendorreq()
Remove an unnecessary 'if' test from usbctrl_vendorreq() because
"length" is never greater than MAX_VENDOR_REQ_CMD_SIZE.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-13-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:27:00 +0000 (14:27 +0200)]
staging: r8188eu: change the type of a variable in rtw_read16()
Change the type of "data" from __le32 to __le16. The size of the data
that usbctrl_vendorreq() will read is two bytes in little endian order,
so the most suitable type is __le16.
With the old code, since the two most significant bytes of data are not
initialized, KMSan can likely detect the reading of uninitialized data,
so this change can prevent the checker from complaining.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-12-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:59 +0000 (14:26 +0200)]
staging: r8188eu: remove a bitwise AND from rtw_writeN()
Remove an unnecessary bitwise AND because "length" can never be greater
than 0xffff since VENDOR_CMD_MAX_DATA_LEN is defined as '254'.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-11-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:58 +0000 (14:26 +0200)]
staging: r8188eu: remove a buffer from rtw_writeN()
Remove the unnecessary buffer "u8 buf[VENDOR_CMD_MAX_DATA_LEN]" and
pass directly "data" to usbctrl_vendorreq().
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-10-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:57 +0000 (14:26 +0200)]
staging: r8188eu: change the type of a variable in rtw_write16()
Change the type of "data" from __le32 to __le16 in rtw_write16(). The
argument "val", which is u16, after being conditionally swapped to little
endian, is assigned to "data"; therefore, __le16 is the most suitable type
for "data". Remove the bitwise AND of "val" with 0xffff because it is
redundant. Use cpu_to_le16() because "data" is __le16.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-9-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:56 +0000 (14:26 +0200)]
staging: r8188eu: remove casts from rtw_{read,write}*()
Remove unnecessary casts from rtw_read{8,16,32}() and from
rtw_write{8,16,32,N}().
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-8-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:55 +0000 (14:26 +0200)]
staging: r8188eu: rename symbols in rtw_read*() and rtw_write*()
Rename variables in rtw_read{8.16.32}() and in rtw_write{8,16,32,N}()
because of unnecessary 'p' (that probably stand for "pointer to") and
'w' (that probably stands for "word"):
pio_priv => io_priv;
pintfhdl => intf;
wvalue => value.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-7-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:54 +0000 (14:26 +0200)]
staging: r8188eu: remove a comment from usbctrl_vendorreq()
Remove an unnecessary comment from usbctrl_vendorreq().
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-6-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:53 +0000 (14:26 +0200)]
staging: r8188eu: reorder comments in usbctrl_vendorreq()
Reorder comments in usbctrl_vendorreq() to follow Linux coding style.
Delete two of them because they are "obvious".
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-5-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:52 +0000 (14:26 +0200)]
staging: r8188eu: remove test in usbctrl_vendorreq()
Remove unnecessary test for "!io_buf" in usbctrl_vendorreq(). This test
is not necessary because io_buf has been assigned with the address of
a region of dynamically allocated memory (dvobj->usb_alloc_vendor_req_buf)
by rtw_init_intf_priv() in os_dep/usb_intf.c.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-4-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:51 +0000 (14:26 +0200)]
staging: r8188eu: reorder declarations in usbctrl_vendorreq()
Reorder variables declarations according to the "Reverse Xmas Tree"
style.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-3-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio M. De Francesco [Fri, 24 Sep 2021 12:26:50 +0000 (14:26 +0200)]
staging: r8188eu: clean up symbols in usbctrl_vendorreq()
Clean up symbol names in usbctrl_vendorreq():
pdata => data;
pio_priv => io_priv;
pintfhdl => intf.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-2-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sat, 25 Sep 2021 07:40:13 +0000 (09:40 +0200)]
staging: r8188eu: remove ODM_CheckPowerStatus()
The function ODM_CheckPowerStatus() returns always true. Checking its
return value is not necessary. Remove the function and related code.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210925074013.14693-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Fri, 24 Sep 2021 20:49:17 +0000 (22:49 +0200)]
staging: r8188eu: remove LedStrategy from struct led_priv
LedStrategy is set but never used. Remove it from struct led_priv and
remove the now unused enum LED_STRATEGY_871x as well.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210924204917.6313-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Fri, 24 Sep 2021 20:49:16 +0000 (22:49 +0200)]
staging: r8188eu: remove _InitHWLed()
Function _InitHWLed() does nothing, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210924204917.6313-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Fri, 24 Sep 2021 20:49:15 +0000 (22:49 +0200)]
staging: r8188eu: remove unnecessary comments
The function names in rtw_led.c are self-explanatory. Remove
unnecessary comments.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210924204917.6313-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Fri, 24 Sep 2021 20:49:14 +0000 (22:49 +0200)]
staging: r8188eu: remove dead led control functions
LedStrategy is SW_LED_MODE1 in this driver. Remove led control
functions that are not used for SW_LED_MODE1.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210924204917.6313-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Fri, 24 Sep 2021 20:49:13 +0000 (22:49 +0200)]
staging: r8188eu: remove dead led blink functions
LedStrategy is SW_LED_MODE1 in this driver. Remove led blink
functions that are not used for SW_LED_MODE1.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210924204917.6313-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:20 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_tdls_cmd()
Function rtw_tdls_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-18-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:19 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_setstandby_cmd()
Function rtw_setstandby_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-17-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:18 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_setrttbl_cmd()
Function rtw_setrttbl_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-16-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:17 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_setrfreg_cmd()
Function rtw_setrfreg_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-15-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:16 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_setphy_cmd()
Function rtw_setphy_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-14-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:15 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_setbbreg_cmd()
Function rtw_setbbreg_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-13-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:14 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_setbasicrate_cmd()
Function rtw_setbasicrate_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-12-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:13 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_setassocsta_cmd()
Function rtw_setassocsta_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-11-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:12 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_set_csa_cmd()
Function rtw_set_csa_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-10-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:11 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_set_ch_cmd()
Function rtw_set_ch_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-9-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:10 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_readtssi_cmdrsp_callback()
Function rtw_readtssi_cmdrsp_callback() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:09 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_led_blink_cmd()
Function rtw_led_blink_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:08 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_getrttbl_cmd()
Function rtw_getrttbl_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:07 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_getrfreg_cmd()
Function rtw_getrfreg_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:06 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_getbbreg_cmd()
Function rtw_getbbreg_cmd() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:05 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_createbss_cmd_ex()
Function rtw_createbss_cmd_ex() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 19:09:04 +0000 (21:09 +0200)]
staging: r8188eu: remove rtw_cmd_clr_isr()
Function rtw_cmd_clr_isr() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923190920.3580-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 23 Sep 2021 16:45:56 +0000 (18:45 +0200)]
staging: r8188eu: remove rtw_proc_{init,remove}_one()
The functions rtw_proc_{init,remove}_one() are empty and can be
removed. There are non-empty versions of these functions covered by
#if 0. Remove this dead code as well.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210923164556.9492-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:58 +0000 (21:46 +0200)]
staging: r8188eu: remove odm_DynamicTxPowerInit()
Function odm_DynamicTxPowerInit() is empty now, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-9-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:57 +0000 (21:46 +0200)]
staging: r8188eu: remove DynamicTxHighPowerLvl from struct dm_priv
The field DynamicTxHighPowerLvl of struct dm_priv is set but never
used. Remove it and remove now unused variables from
odm_DynamicTxPowerInit().
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:56 +0000 (21:46 +0200)]
staging: r8188eu: remove dead code from rtl8188e_rf6052.c
In this driver DynamicTxHighPowerLvl is set to TxHighPwrLevel_Normal
and never changed. In the file rtl8188e_rf6052.c there are some if
statements that check DynamicTxHighPowerLvl for other values than
TxHighPwrLevel_Normal. The code in the if blocks is never executed.
Remove the dead code.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:55 +0000 (21:46 +0200)]
staging: r8188eu: remove PowerIndex_backup from struct dm_priv
The field PowerIndex_backup of struct dm_priv is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:54 +0000 (21:46 +0200)]
staging: r8188eu: remove write-only fields from struct dm_priv
The fields bDynamicTxPowerEnable and LastDTPLvl of struct dm_priv
are set but never used. Remove them.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:53 +0000 (21:46 +0200)]
staging: r8188eu: remove odm_DynamicTxPower()
Function odm_DynamicTxPower() does nothing, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:52 +0000 (21:46 +0200)]
staging: r8188eu: remove odm_DynamicTxPowerAP()
Function odm_DynamicTxPowerAP() is empty, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 21 Sep 2021 19:46:51 +0000 (21:46 +0200)]
staging: r8188eu: remove odm_DynamicTxPowerNIC()
Function odm_DynamicTxPowerNIC() does nothing, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210921194658.10654-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sidong Yang [Thu, 23 Sep 2021 07:31:15 +0000 (08:31 +0100)]
staging: pi433: goto abort when setting failed in tx_thread
tx_thread in pi433 works for transmitting. it reads tx_cfg and data
stored in kfifo put in pi433_write() and transmits. If it exits,
pi433_write() just store its data and no one transmits data. So,
tx_thread should not exit even when it failed for setting registers.
It seems that it's okay to go to abort and continue to loop and wait for
writing.
Signed-off-by: Sidong Yang <realwakka@gmail.com>
Link: https://lore.kernel.org/r/20210923073115.7933-1-realwakka@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:20 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_sctx_done()
Function rtw_sctx_done() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-48-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:19 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_calculate_wlan_pkt_size_by_attribue()
Function rtw_calculate_wlan_pkt_size_by_attribue() is not used,
remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-47-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:18 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_init_recvframe()
Function rtw_init_recvframe() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-46-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:17 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_enqueue_recvbuf_to_head()
Function rtw_enqueue_recvbuf_to_head() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-45-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:16 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_enqueue_recvbuf()
Function rtw_enqueue_recvbuf() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-44-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:15 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_dequeue_recvbuf()
Function rtw_dequeue_recvbuf() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-43-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:14 +0000 (22:04 +0200)]
staging: r8188eu: remove enum secondary_ch_offset
The enum secondary_ch_offset is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-42-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:13 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_set_ie_secondary_ch_offset()
Function rtw_set_ie_secondary_ch_offset() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-41-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:12 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_set_ie_mesh_ch_switch_parm()
Function rtw_set_ie_mesh_ch_switch_parm() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-40-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:11 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_set_ie_ch_switch()
Function rtw_set_ie_ch_switch() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-39-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:10 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_ies_remove_ie()
Function rtw_ies_remove_ie() is not used, remove it. It is the only
user of rtw_get_ie_ex(), remove that function as well.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-38-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:09 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_action_frame_parse()
Function rtw_action_frame_parse() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-37-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:08 +0000 (22:04 +0200)]
staging: r8188eu: remove ieee80211_is_empty_essid()
Function ieee80211_is_empty_essid() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-36-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:07 +0000 (22:04 +0200)]
staging: r8188eu: remove ieee80211_get_hdrlen()
Function ieee80211_get_hdrlen() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-35-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:06 +0000 (22:04 +0200)]
staging: r8188eu: remove secondary_ch_offset_to_hal_ch_offset()
Function secondary_ch_offset_to_hal_ch_offset() is not used, remove
it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-34-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:05 +0000 (22:04 +0200)]
staging: r8188eu: remove hal_ch_offset_to_secondary_ch_offset()
Function hal_ch_offset_to_secondary_ch_offset() is not used, remove
it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-33-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:04 +0000 (22:04 +0200)]
staging: r8188eu: remove dump_ies()
Function dump_ies() is not used, remove it. It is the only user of
the functions dump_{wps,p2p}_ie(), remove these as well.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-32-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:03 +0000 (22:04 +0200)]
staging: r8188eu: remove action_public_str()
Function action_public_str() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-31-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:02 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_IOL_cmd_buf_dump()
Function rtw_IOL_cmd_buf_dump() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-30-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:01 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_os_read_port()
Function rtw_os_read_port() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-29-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:04:00 +0000 (22:04 +0200)]
staging: r8188eu: remove rtw_cbuf_full()
Function rtw_cbuf_full() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-28-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:59 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_cbuf_push()
Function rtw_cbuf_push() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-27-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:58 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_atoi()
Function rtw_atoi() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-26-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:57 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_set_channel_plan()
Function rtw_set_channel_plan() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-25-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:56 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_validate_ssid()
Function rtw_validate_ssid() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-24-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:55 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_set_scan_mode()
Function rtw_set_scan_mode() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-23-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:54 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_set_country()
Function rtw_set_country() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-22-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:53 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_set_802_11_remove_wep()
Function rtw_set_802_11_remove_wep() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-21-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:52 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_set_802_11_remove_key()
Function rtw_set_802_11_remove_key() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-20-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:51 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_set_802_11_add_key()
Function rtw_set_802_11_add_key() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-19-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:50 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_freq2ch()
Function rtw_freq2ch() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-18-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:49 +0000 (22:03 +0200)]
staging: r8188eu: remove build_deauth_p2p_ie()
Function build_deauth_p2p_ie() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-17-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:48 +0000 (22:03 +0200)]
staging: r8188eu: remove sreset_get_wifi_status()
Function sreset_get_wifi_status() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-16-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:47 +0000 (22:03 +0200)]
staging: r8188eu: remove issue_probereq_p2p_ex()
Function issue_probereq_p2p_ex() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-15-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:46 +0000 (22:03 +0200)]
staging: r8188eu: remove issue_action_spct_ch_switch()
Function issue_action_spct_ch_switch() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-14-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:45 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_scan_abort()
Function rtw_scan_abort() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-13-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:44 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_get_timestampe_from_ie()
Function rtw_get_timestampe_from_ie() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-12-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:43 +0000 (22:03 +0200)]
staging: r8188eu: remove _rtw_enqueue_network()
Function _rtw_enqueue_network() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-11-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:42 +0000 (22:03 +0200)]
staging: r8188eu: remove _rtw_dequeue_network()
Function _rtw_dequeue_network() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-10-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:41 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_efuse_map_read()
Function rtw_efuse_map_read() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-9-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:40 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_BT_efuse_map_read()
Function rtw_BT_efuse_map_read() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:39 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_efuse_map_write()
Function rtw_efuse_map_write() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:38 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_efuse_access()
Function rtw_efuse_access() is not used, remove it. It is the only
user of the functions efuse_{read,write}8, remove these as well.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:37 +0000 (22:03 +0200)]
staging: r8188eu: remove rtw_BT_efuse_map_write()
Function rtw_BT_efuse_map_write() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:36 +0000 (22:03 +0200)]
staging: r8188eu: remove efuse_GetMaxSize()
Function efuse_GetMaxSize is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:35 +0000 (22:03 +0200)]
staging: r8188eu: remove efuse_GetCurrentSize()
Function efuse_GetCurrentSize() is not used, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 22 Sep 2021 20:03:34 +0000 (22:03 +0200)]
staging: r8188eu: remove EFUSE_ShadowRead()
Function EFUSE_ShadowRead() is not used, remove it. It is the only
user of the functions efuse_ShadowRead{1,2,4}Byte, remove these as
well.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210922200420.9693-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 19 Sep 2021 21:59:14 +0000 (18:59 -0300)]
staging: vchiq_arm: use __func__ to get function name in debug message
Avoid hardcoded function name using "%s", __func__. This prevents
potential naming conflict if the function is eventually renamed.
Reported by checkpatch.pl
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20210919215914.539805-8-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 19 Sep 2021 21:59:13 +0000 (18:59 -0300)]
staging: vchiq_arm: remove extra blank line
Remove unnecessary blank line.
Reported by checkpatch.pl
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20210919215914.539805-7-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 19 Sep 2021 21:59:12 +0000 (18:59 -0300)]
staging: vchiq_arm: fix quoted strings split across lines
Quoted strings should not be split across lines. As put it in
Documentation/process/coding-style.rst: "never break user-visible
strings such as printk messages because that breaks the ability to grep
for them."
Reported by checkpatch.pl
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20210919215914.539805-6-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 19 Sep 2021 21:59:11 +0000 (18:59 -0300)]
staging: vchiq_arm: cleanup blank lines
Remove unnecessary blank lines after open braces and before close
braces.
Reported by checkpatch.pl
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20210919215914.539805-5-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 19 Sep 2021 21:59:10 +0000 (18:59 -0300)]
staging: vchiq_arm: clarify multiplication expressions
Add spaces around '*' in multiplication expressions to enhance
readability.
Reported by checkpatch.pl
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20210919215914.539805-4-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 19 Sep 2021 21:59:09 +0000 (18:59 -0300)]
staging: vchiq_arm: remove unnecessary space in cast
As reported by checkpatch.pl, no space is necessary after a cast.
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20210919215914.539805-3-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 19 Sep 2021 21:59:08 +0000 (18:59 -0300)]
staging: vchiq_arm: cleanup code alignment issues
Fix code alignment issues.
Reported by checkpatch.pl
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20210919215914.539805-2-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Mon, 27 Sep 2021 14:45:36 +0000 (16:45 +0200)]
Merge branch 5.15-rc3 into staging-next
We need the fixes in here, and it resolves a merge issue with
drivers/staging/r8188eu/os_dep/ioctl_linux.c
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>