David Wrighton [Thu, 14 Sep 2017 21:39:25 +0000 (14:39 -0700)]
Merge pull request #13987 from davidwrighton/update_from_master
Update to latest changes from master branch
David Wrighton [Thu, 14 Sep 2017 19:26:55 +0000 (12:26 -0700)]
Update dependencies
David Wrighton [Wed, 13 Sep 2017 21:50:39 +0000 (14:50 -0700)]
Merge branch 'master' into update_from_master
Jarret Shook [Wed, 13 Sep 2017 19:50:12 +0000 (12:50 -0700)]
Merge pull request #13943 from jashook/fix_lb_build_break
Fix potentially unused variable in lb arm
Jan Kotas [Wed, 13 Sep 2017 19:49:24 +0000 (12:49 -0700)]
Fix ARM build break (#13932)
jashook [Wed, 13 Sep 2017 17:54:48 +0000 (10:54 -0700)]
Fix potentially unused variable in lb arm
Jan Vorlicek [Wed, 13 Sep 2017 17:19:20 +0000 (19:19 +0200)]
Disable PAX mprotect for native executables (#13940)
This change adds marking native executables that coreclr build produces
(corerun, coreconsole, crossgen, ilasm, ildasm, crashdump) to using the
paxctl tool to allow them running on systems with PAX configured so that
creating executable memory mappings by applications is prohibited.
Jan Kotas [Wed, 13 Sep 2017 03:32:08 +0000 (20:32 -0700)]
Fix AV in corerun on invalid filename
Before this fix, corerun would AV on certain invalid paths e.g.: corerun test.exe\
Jan Kotas [Wed, 13 Sep 2017 03:30:30 +0000 (20:30 -0700)]
Mark Span.Length as non-versionable
This allows inlining Span.Length accross versioning boundaries in R2R images. We are leaking the Span implementation details already because the Span indexer is treated as intrinsic. Marking a few more trivial methods as non-versionable should not do any future harm.
Carol Eidt [Wed, 13 Sep 2017 16:30:46 +0000 (09:30 -0700)]
Merge pull request #13806 from hqueue/arm/ryujit/issue_13739_jitstress_NYI_addr
[RyuJIT/ARM32] Add ADDR and fixup return type correctly
Tarek Mahmoud Sayed [Wed, 13 Sep 2017 15:20:46 +0000 (08:20 -0700)]
Fix Hebrew date parsing (#13929)
This fix when parsing Hevrew dat e string formatted as dd/MM/yy. we didn't encounter the same on Windows before because default short date pattern on Windows is dd MMM yyyy which we can parse it successfully.
Joseph Tremoulet [Wed, 13 Sep 2017 13:04:04 +0000 (09:04 -0400)]
Merge pull request #13903 from JosephTremoulet/PlaceReturns
Improve const return block placement
Joseph Tremoulet [Wed, 13 Sep 2017 13:03:13 +0000 (09:03 -0400)]
Merge pull request #13835 from sdmaclea/PR-ARM64-GT_MULHI
[Arm64] Add GT_MULHI
Joseph Tremoulet [Wed, 13 Sep 2017 12:58:31 +0000 (08:58 -0400)]
Merge pull request #13799 from sdmaclea/PR-ARM64-Transform-AND-CMP
[Arm64] Transform AND-CMP to TST
Konstantin Baladurin [Wed, 13 Sep 2017 12:17:55 +0000 (15:17 +0300)]
Introduce FEATURE_GDBJIT_SYMTAB (#13567)
* Introduce FEATURE_GDBJIT_SYMTAB
This commit adds new feature FEATURE_GDBJIT_SYMTAB. When it's set
ELF file with symtab section will be generated for all JITed methods.
It helps lldb and gdb correctly unwind frames of JITed methods as they
can use assembly language inspection to determine location of saved
registers on stack.
* gdbjit symtab feature: use different symbols for each function in JITed code
Jarret Shook [Wed, 13 Sep 2017 08:43:06 +0000 (01:43 -0700)]
Change how numProc is derived on Linux (#13909)
Before the decision for numProcs to run in parallel for runtests.sh
was based on _NPROCESSORS_ONLN which harware which attempts to save
power (eg arm(64)) this number may be < numProcs.
dotnet-maestro-bot [Wed, 13 Sep 2017 02:49:01 +0000 (19:49 -0700)]
Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02012-02, preview1-25713-01, preview1-25712-02, master-
20170912-0038, respectively (#13928)
Jim Ma [Wed, 13 Sep 2017 01:33:40 +0000 (09:33 +0800)]
Re-implemented the ecvt function. (#12894)
* Re-implemented the ecvt function.
Instead of leveraging snprintf, re-implement the ecvt function according to the paper: https://www.cs.indiana.edu/~dyb/pubs/FP-Printing-PLDI96.pdf
Note:
1. This commit won't fix any existing bug.
2. This is a raw implementation of the paper. The performance on Linux only gain 10%. We could tune the performance further.
Fix #10651
* Resolve a cross platform header file issue.
Fix #10651
* Fixed a minor bug. Improved the performance.
Fix #10651
* Modified code according to code review feedback.
This commit fixed most of the issue found in code review. However, some of the feedback may not be involved due to either little performance improvement or need a POC.
Fix #10651
* Try to fix constexpr compile error on Windows.
Fix #10651
* Fixed a potential overflow bug in BigNum::Compare.
Fix #10651
* Improved multiply 10 operation.
Use shift and add operation to replace actual multiply operation.
Fix #10651
* Remove old _ecvt function.
Fix #10651
* Documented the reason why we do not need m+ and m-.
Fix #10651
* Changed exp > 0 to exp != 0 to remove any confusion.
exp should fall in 1 ~ 2046 for normalized value. Denormalized value has exp = 0.
Fix #10651
* Disable the _ecvt tests.
Fix #10651
* Removed _ecvt tests.
Fix #10651
* Re-implemented LogBase2.
Fix #10651
* Use DWORD and DWORD64 for _BitScanReverse and _BitScanReverse64
Fix #10651
* Fixed x86 compile issue for _BitScanReverse64
x86 does not support _BitScanReverse64 so we have to add additional shift operations to handle it.
Fix #10651
* Implemented BitScanReverse64 and BitScanReverse in pal.h
Fix #10651
* Remove the confusion comment which is unrelated to BitScanReverse.
Fix #10651
* Introduced wmemset to enhance the perf for 0.0
Fix #10651
* Improved the performance of converting 0.0.
Fix #10651
* Renamed ecvt to DoubleToNumberWorker.
Fix #10651
* Updated code according to the code review feedback.
Fix #10651
Alex Ghiondea [Wed, 13 Sep 2017 01:30:20 +0000 (18:30 -0700)]
Update the third party notices file to reference the floating point number algorithm (#13920)
Sujin Kim [Wed, 13 Sep 2017 00:55:55 +0000 (09:55 +0900)]
[RyuJIT/ARM32] Implement CreateDictionaryLookupHelper only via helper (#13733)
* [RyuJIT/ARM32] Implement CreateDictionaryLookupHelper only via run-time helper
Implement CreateDictionaryLookupHelper only via run-time helper
* Add assertion for checking CORINFO_USEHELPER
Jan Vorlicek [Wed, 13 Sep 2017 00:30:55 +0000 (02:30 +0200)]
Fix ARM32 secure delegate bug (#13922)
This change fixes a bug that causes crashes when secure delegate is
invoked on ARM32 with legacy codegen. Register R4 was loaded with
indirection slot address and immediatelly marked as trashed, so the JIT
compiler reused it before the call that was supposed to have that value
in R4.
The fix was to move the reg trashing after the call.
There was also an incorrect marking of that address as EA_PTRSIZE
while it should be EA_BYREF, so I've fixed that too.
Ahson Ahmed Khan [Wed, 13 Sep 2017 00:29:14 +0000 (17:29 -0700)]
Make dangerous Span APIs less discoverable. (#13927)
Eugene Rozenfeld [Wed, 13 Sep 2017 00:15:08 +0000 (17:15 -0700)]
Remove redundant zero-initialization of struct temps with GC fields. (#13868)
Remove redundant zero-initialization of struct temps with GC fields.
Structs with GC pointer fields are fully zero-initialized in the prolog if compInitMem is true.
Therefore, we don't need to insert zero-initialization for the result of newobj or for inlinee locals
when they are structs with GC pointer fields and the basic bock is not in a loop.
Andy Ayers [Tue, 12 Sep 2017 22:02:54 +0000 (15:02 -0700)]
JIT: optimize case where box feeds GetType (#13710)
If the only use of a box is in a call to Type:GetType, remove the box and
obtain the type directly. Get the handle needed for obtaining the type from
the newobj call in the original box, via a new box removal option.
Also add some logging to the type optimizations done in morph.
Closes #13187.
Jarret Shook [Tue, 12 Sep 2017 20:49:13 +0000 (13:49 -0700)]
Merge pull request #13819 from sdmaclea/PR-ARM64-MOD-AND-TRANSFORM
[Arm64] Allow a%b to a&(b-1) transform
Sergey Andreenko [Tue, 12 Sep 2017 20:11:29 +0000 (13:11 -0700)]
fix stack depth in DevDiv_278523 test source code(#13912)
Mike McLaughlin [Tue, 12 Sep 2017 19:41:14 +0000 (12:41 -0700)]
Fix core dump generation on Centos. (#13887)
Fix core dump generation on Centos.
Issue #13764
Michelle McDaniel [Tue, 12 Sep 2017 18:02:12 +0000 (11:02 -0700)]
Merge pull request #13918 from adiaaida/unifyPerfConfigs
Add OptLevel and JitName configurations
Carol Eidt [Tue, 12 Sep 2017 17:26:49 +0000 (10:26 -0700)]
Merge pull request #13715 from CarolEidt/LsraInfoInLsra
Do TreeNodeInfoInit in buildIntervals
Michelle McDaniel [Tue, 12 Sep 2017 16:56:30 +0000 (09:56 -0700)]
Add OptLevel and JitName configurations
To unify the configuration names in benchview, add OptLevel and JitName
configurations in run-xunit-perf.sh. This change does not add min_opts
to perf.groovy.
Viktor Hofer [Tue, 12 Sep 2017 16:45:42 +0000 (18:45 +0200)]
Merge pull request #13242 from ViktorHofer/BinarySerializationCleanup
Binary serialization unused methods and attributes cleanup and misc code cleanup
Steve MacLean [Tue, 12 Sep 2017 15:54:11 +0000 (11:54 -0400)]
Fix formatting
Steve MacLean [Tue, 12 Sep 2017 15:44:47 +0000 (11:44 -0400)]
noway_assert to assert per review
Steve MacLean [Tue, 12 Sep 2017 15:32:26 +0000 (11:32 -0400)]
Fix formatting
Steve MacLean [Tue, 12 Sep 2017 15:22:51 +0000 (11:22 -0400)]
Simplify divisorValue calculation
Steve MacLean [Tue, 12 Sep 2017 15:15:26 +0000 (11:15 -0400)]
Add comments per review
José Rivero [Tue, 12 Sep 2017 15:15:37 +0000 (08:15 -0700)]
Fixing archiving of Linux perf artifacts. (#13911)
- Previous change did not fix archiving artifacts
Viktor Hofer [Tue, 12 Sep 2017 09:09:40 +0000 (11:09 +0200)]
ResourceSet
Viktor Hofer [Thu, 7 Sep 2017 19:21:45 +0000 (21:21 +0200)]
TextInfo
Viktor Hofer [Thu, 7 Sep 2017 17:28:18 +0000 (19:28 +0200)]
Reflection
Viktor Hofer [Thu, 24 Aug 2017 16:29:57 +0000 (18:29 +0200)]
IO
Konstantin Baladurin [Tue, 12 Sep 2017 10:44:24 +0000 (13:44 +0300)]
[GDBJIT] Specify C# language in DWARF debug information (#13720)
* [GDBJIT] Specify C# language in DWARF debug information
To correctly support C# language in lldb DWARF debug information
should contain correct information about language.
Now we use 0x9e57 constant for specify C# language.
* [GDBJIT] Introduce FEATURE_GDBJIT_LANGID_CS
If this feature is set gdbjit will use 0x9e57 as c# lang id,
otherwise it will use DW_LANG_C89.
Stephen Toub [Tue, 12 Sep 2017 06:49:53 +0000 (23:49 -0700)]
Merge pull request #13907 from stephentoub/valuetask_astask_caching
Use AsyncTaskCache in ValueTask.AsTask()
dotnet bot [Tue, 12 Sep 2017 02:54:33 +0000 (19:54 -0700)]
Merge changes from TFS (#13884)
Add new GetMethodNameFromMetadata interface member to ILGEN.
Also fix warning in the build.
[tfs-changeset: 1673078]
[Hand edited to fix break in SPMI]
Joseph Tremoulet [Mon, 11 Sep 2017 18:56:16 +0000 (14:56 -0400)]
Improve const return block placement
Tweak a few things so that generated constant return blocks get laid out
more optimally:
- Don't set BBF_DONT_REMOVE on them; it's ok to move them around, and
if all references to them get dropped, it's fine to eliminate them.
- Insert them immediately after their lexically-last predecessor when
generating them; this increases the likelihood of using fallthrough
rather than gotos to target them in the face of fgReorderBlocks'
reticence to reorder code that we don't have IBC data for and that
hasn't been marked rare.
- Make fgReorderBlocks slightly more aggressive for a pattern that now
shows up somewhat routinely for returning compound conditionals from
predicate functions.
Stephen Toub [Mon, 11 Sep 2017 21:40:57 +0000 (14:40 -0700)]
Use AsyncTaskCache in ValueTask.AsTask()
We can avoid task allocations for common values by using the same task cache that async methods do. This is important to avoid allocations in certain cases when switching from Task-returning to ValueTask-returning methods. If at some point we change Task.FromResult to use the same cache, this can be reverted.
William Godbe [Mon, 11 Sep 2017 18:49:57 +0000 (11:49 -0700)]
Merge pull request #13875 from wtgodbe/RevertLabel
Revert PreReleaseLabel to preview1
Andy Ayers [Mon, 11 Sep 2017 18:12:45 +0000 (11:12 -0700)]
JIT: optimize Enum.HasFlag (#13748)
Check for calls to `Enum.HasFlag` using the new named intrinsic support
introduced in #13815. Implement a simple recognizer for these named
intrinsics (currently just recognizing `Enum.HasFlag`).
When the call is recognized, optimize if both operands are boxes with
compatible types and both boxes can be removed. The optimization changes the
call to a simple and/compare tree on the underlying enum values.
To accomplish this, generalize the behavior of `gtTryRemoveBoxUpstreamEffects`
to add a "trial removal" mode and to optionally suppress narrowing of the
copy source.
Invoke the optimization during importation (which will catch most cases) and
again during morph (to get the post-inline cases).
Added test cases. Suprisingly there were almost no uses of HasFlag in the
current CoreCLR test suite.
Closes #5626.
Konstantin Baladurin [Mon, 11 Sep 2017 17:23:16 +0000 (20:23 +0300)]
[GDBJIT] Fix calculation of debuginfo's size. (#13899)
Information about each type is dumped once but during debuginfo's
size calculation it was taken into account several time. Due to it
size of debuginfo section could be in several times bigger than
needed that in some cases leaded to OOM.
Eric Erhardt [Mon, 11 Sep 2017 16:30:56 +0000 (11:30 -0500)]
Merge pull request #13876 from eerhardt/UpdateBuildTools
Update BuildTools automatically when new versions are available.
José Rivero [Mon, 11 Sep 2017 16:10:02 +0000 (09:10 -0700)]
Ubuntu runs are not archiving perf results because rsync does not create destination folder (#13858)
Eric Erhardt [Mon, 11 Sep 2017 14:52:39 +0000 (09:52 -0500)]
Merge branch 'master' into UpdateBuildTools
Alfred Myers [Mon, 11 Sep 2017 14:51:58 +0000 (11:51 -0300)]
fixed minor typo (#13898)
Konstantin Baladurin [Mon, 11 Sep 2017 14:48:01 +0000 (17:48 +0300)]
Fix building of rootfs for Tizen armel (#13854)
Now there isn't arm buildtarget in tizen-base repository.
Use standard one to fetch packages for rootfs.
Kevin Gosse [Mon, 11 Sep 2017 14:14:11 +0000 (16:14 +0200)]
Make order of elements consistent (#13892)
When the cache is only partially populated, MemberInfoCache.Insert will
insert the new members into the cache. But then, it will return the
original list. In subsequent calls, it will return the cached list.
However, the order of elements can be different, which can cause issues
with methods that rely on the order of elements returned by
Type.GetFields (for instance, Attribute.GetHashCode)
Stephen Toub [Mon, 11 Sep 2017 14:09:31 +0000 (10:09 -0400)]
Merge pull request #13894 from dotnet-maestro-bot/master-UpdateDependencies
Update PgoData to master-
20170911-0041 (master)
Eric Erhardt [Mon, 11 Sep 2017 14:02:42 +0000 (09:02 -0500)]
Merge branch 'master' into UpdateBuildTools
dotnet-maestro-bot [Mon, 11 Sep 2017 07:57:00 +0000 (00:57 -0700)]
Update PgoData to master-
20170911-0041
Stephen Toub [Mon, 11 Sep 2017 06:55:58 +0000 (02:55 -0400)]
Merge pull request #13893 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr to preview2-25711-01 (master)
dotnet-maestro-bot [Mon, 11 Sep 2017 00:15:37 +0000 (17:15 -0700)]
Update CoreClr to preview2-25711-01
Eric Erhardt [Sun, 10 Sep 2017 20:36:19 +0000 (15:36 -0500)]
Merge branch 'master' into UpdateBuildTools
Eric Erhardt [Sun, 10 Sep 2017 20:35:25 +0000 (15:35 -0500)]
Merge branch 'master' into UpdateBuildTools
Stephen Toub [Sun, 10 Sep 2017 13:20:14 +0000 (09:20 -0400)]
Merge pull request #13847 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, PgoData to preview2-25709-04, master-
20170910-0049, respectively (master)
dotnet-maestro-bot [Sun, 10 Sep 2017 08:06:00 +0000 (01:06 -0700)]
Update CoreClr, PgoData to preview2-25709-04, master-
20170910-0049, respectively
Stephen Toub [Sun, 10 Sep 2017 03:25:18 +0000 (23:25 -0400)]
Merge pull request #13849 from stephentoub/string_create
Add String.Create span-based method
Jan Kotas [Sun, 10 Sep 2017 01:48:20 +0000 (18:48 -0700)]
Merge pull request #13888 from jkotas/corelib-mirror
Mirror changes from dotnet/corert
Stephen Toub [Sat, 9 Sep 2017 23:44:19 +0000 (19:44 -0400)]
Merge pull request #13886 from ahsonkhan/SpanReadOnlyStruct
Marking {ReadOnly}Span with IsReadOnly attribute
Jan Kotas [Sat, 9 Sep 2017 23:32:23 +0000 (16:32 -0700)]
Finish moving files to shared CoreLib partition
Jan Kotas [Sat, 9 Sep 2017 22:51:05 +0000 (15:51 -0700)]
Move PInvoke interop related attributes to shared CoreLib partition
[tfs-changeset: 1673253]
Jan Kotas [Sat, 9 Sep 2017 16:06:21 +0000 (09:06 -0700)]
Finish moving files to shared partition
Jan Kotas [Sat, 9 Sep 2017 11:57:48 +0000 (04:57 -0700)]
Fix IntrinsicAttribute build break
Eric Erhardt [Sat, 9 Sep 2017 22:37:14 +0000 (17:37 -0500)]
Merge branch 'master' into UpdateBuildTools
Daniel Podder [Sat, 9 Sep 2017 19:33:18 +0000 (12:33 -0700)]
Enable auto-update for PGO data (#13883)
Move PgoDataPackageVersion into dependencies.props, which enables auto-update functionality.
Also, update optdata version to
20170908-1805.
Jan Kotas [Sat, 9 Sep 2017 07:28:46 +0000 (00:28 -0700)]
Cleanup Guid formatting (#13885)
ahsonkhan [Sat, 9 Sep 2017 05:23:16 +0000 (22:23 -0700)]
Marking {ReadOnly}Span with IsReadOnly attribute.
Pat Gavlin [Sat, 9 Sep 2017 04:18:07 +0000 (21:18 -0700)]
Merge pull request #13842 from dotnet-bot/from-tfs
Merge changes from TFS
Pat Gavlin [Sat, 9 Sep 2017 04:14:13 +0000 (21:14 -0700)]
Merge pull request #13110 from pgavlin/SPMIJitOptions
Add the capability to specify JIT options on the SPMI command line.
Stephanie Niu [Sat, 9 Sep 2017 02:58:35 +0000 (19:58 -0700)]
Guid span-based APIs (ctor, TryWriteBytes, TryFormat) (#13323)
* standardized style changes
* 3 span-ified guid methods
throw null exception for readonlyspan ctor
full changes
* restructured trywritebytes
* changed writebytehelper from feedback
* changed casing of switch statement
* indentation
Pat Gavlin [Sat, 9 Sep 2017 01:56:36 +0000 (18:56 -0700)]
Merge pull request #13863 from pgavlin/DevDiv491211
Properly update GTF_{ASG,EXCEPT} in call morphing.
Steve MacLean [Sat, 9 Sep 2017 01:41:42 +0000 (21:41 -0400)]
[Arm64] Optimize System.Buffer:Memmove (#13793)
* [Arm64] Optimize System.Buffer:Memmove
Enable HAS_BLOCKS
Disable code to fall back to native memmove until memmove
optimizations are merged to OS mainline
* Add links to issues
Jan Kotas [Sat, 9 Sep 2017 01:16:01 +0000 (18:16 -0700)]
Move files to shared partition (#13870)
Moved pseudo-custom attribute reflection helpers from attribute definitions to reflection to prepare attribute definitions to be moved to shared partition.
Koundinya Veluri [Sat, 9 Sep 2017 00:14:09 +0000 (17:14 -0700)]
Port some concurrent collection implementations with latest fixes from CoreFX into CoreCLR copies (#12939)
Daniel Podder [Fri, 8 Sep 2017 23:55:04 +0000 (16:55 -0700)]
Add a <clear /> to packageSources in src/NuGet.Config (#13874)
Fixes #13873
Viktor Hofer [Fri, 8 Sep 2017 22:10:51 +0000 (00:10 +0200)]
Merge pull request #13845 from ViktorHofer/DBNull-Serialization
Make DBNull serializable
Jan Kotas [Fri, 8 Sep 2017 04:33:15 +0000 (21:33 -0700)]
Non-shared changes
Jan Kotas [Sun, 3 Sep 2017 16:57:12 +0000 (09:57 -0700)]
Delete redundant PInvokes
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Sun, 3 Sep 2017 16:40:43 +0000 (09:40 -0700)]
Move HResults to shared partition
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Fri, 8 Sep 2017 22:04:56 +0000 (15:04 -0700)]
Fix CoreLib build warnings (#13851)
Eric Erhardt [Fri, 8 Sep 2017 22:02:55 +0000 (17:02 -0500)]
Update CLI version to match other dotnet repos and unblock new BuildTools
Eric Erhardt [Fri, 8 Sep 2017 21:21:15 +0000 (16:21 -0500)]
Update BuildTools automatically when new versions are available.
Koundinya Veluri [Fri, 8 Sep 2017 21:19:05 +0000 (14:19 -0700)]
Change lock used for initializing YieldProcessorNormalized from Crst to CrstStatic (#13857)
Fixes https://github.com/dotnet/coreclr/issues/13779
wtgodbe [Fri, 8 Sep 2017 21:10:10 +0000 (14:10 -0700)]
Revert PreReleaseLabel to preview1
Pat Gavlin [Fri, 8 Sep 2017 18:55:07 +0000 (11:55 -0700)]
Address PR feedback.
Matt Mitchell [Fri, 8 Sep 2017 17:26:37 +0000 (10:26 -0700)]
Only delete agent when not succesful (#13865)
Spinup for this agent is unreliable (docker fails to start a lot). Only delete when the build fails.
Pat Gavlin [Fri, 8 Sep 2017 17:19:18 +0000 (10:19 -0700)]
Properly update GTF_{ASG,EXCEPT} in call morphing.
The former is only necessary if it is set on any of the call's
arguments; the latter is necessary if the call may throw or if it is set
on any of the call's arguments.
Fixes DevDiv 491211.
Viktor Hofer [Fri, 8 Sep 2017 16:35:23 +0000 (18:35 +0200)]
Adding serializable attribute to type
Viktor Hofer [Fri, 8 Sep 2017 14:56:25 +0000 (16:56 +0200)]
PR feedback
Stephen Toub [Fri, 8 Sep 2017 01:42:42 +0000 (21:42 -0400)]
Add String.Create span-based method
Dan Moseley [Sat, 2 Sep 2017 07:47:53 +0000 (00:47 -0700)]
Fix EventProvider to build on Linux
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Steve MacLean [Fri, 8 Sep 2017 00:05:49 +0000 (20:05 -0400)]
Fix warning->error