Adeel Mujahid [Tue, 7 Jan 2020 22:12:46 +0000 (00:12 +0200)]
Fix musl condition for chroot case (#1369)
Jan Kotas [Tue, 7 Jan 2020 20:15:13 +0000 (12:15 -0800)]
Delete Tests.props (#1236)
It creates a conficting defintiion of CommonPath that is not really needed for anything
Juan Hoyos [Tue, 7 Jan 2020 18:53:20 +0000 (10:53 -0800)]
Add createdump to the sharedFramework folder to be added to runtime packages (#1345)
Youssef Victor [Tue, 7 Jan 2020 16:39:01 +0000 (18:39 +0200)]
Add vbproj to .editorconfig (#1354)
Michal Strehovský [Tue, 7 Jan 2020 16:37:10 +0000 (17:37 +0100)]
Reduce confusion in vector layout algorithm (#1356)
We special case layouts of two kinds of vectors: `Vector<T>` and `Vector64/128/256<T>`. Each gets laid out a bit differently. When porting crossgen2 changes to CoreRT (I'm still on leave of absence), it felt odd that code handling vanilla Vector was added to a class responsible for the 64/128/256 variant.
Turns out this was forced by vector handling being really messy. This commit untangles it:
* Rename the class that handles `Vector<T>` so that the name doesn't conflict with the class that handles `Vector64/128/256` and require renaming to use. Use the same name as on the CoreRT side.
* Unnest the class and move the new method `IsVectorOfTType` there.
Carol Eidt [Tue, 7 Jan 2020 16:30:13 +0000 (08:30 -0800)]
Update LSRA document (#1181)
* Update LSRA document
Carol Eidt [Tue, 7 Jan 2020 16:24:19 +0000 (08:24 -0800)]
Kill local asserts for partial write in copyBlock (#1279)
* Kill local asserts for partial write in copyBlock
Fix #1241
Jan Vorlicek [Tue, 7 Jan 2020 16:21:34 +0000 (17:21 +0100)]
Another PAL cleanup (#1359)
* Make _fullpath private
* Make _open_osfhandle private
* Remove GetWriteWatch and ResetWriteWatch
* Remove atexit
* Remove div and div_t
* Remove PAL__getcwd
* Remove STACK_ALIGN_BITS and STACK_ALIGN_REQ
* Remove couple of LANG_* constants
Michal Strehovský [Tue, 7 Jan 2020 16:21:17 +0000 (17:21 +0100)]
Update shared parts of crossgen2 (#1358)
* Port changes from CoreRT.
* Stop sharing embedded object nodes. These are becoming increasingly difficult to share and there's little value.
Egor Bogatov [Tue, 7 Jan 2020 16:12:19 +0000 (19:12 +0300)]
Fix TypeIntrinsics_il tests (#1271)
* Fix TypeIntrinsics_il.il
* Remove CLRTestPriority
Carol Eidt [Tue, 7 Jan 2020 15:43:01 +0000 (07:43 -0800)]
Fix LSRA dump of GC Kills (#1288)
Alexander Nikolaev [Tue, 7 Jan 2020 13:39:46 +0000 (14:39 +0100)]
New PhysicalAddress.TryParse methods taking span and string (#1057)
This PR introduces two new PhysicalAddress.TryParse methods taking span and string as well as adds a PhysicalAddress.Parse overload taking span.
Fixes dotnet/corefx#29780
Jan Vorlicek [Tue, 7 Jan 2020 11:14:25 +0000 (12:14 +0100)]
Require test framework assemblies crossgen to succeed (#1305)
* Require test framework assemblies crossgen to succeed
The test framework crossgen in build-test.cmd failures were ignored
before. Change that to require the crossgen of all the framework
assemblies to succeed.
I've also added a progress and status details to the output.
Equivalent changes were made to the Unix build-test.sh.
Elinor Fung [Tue, 7 Jan 2020 01:26:10 +0000 (17:26 -0800)]
Make sure default ALC is initialized before resolving satellite assembly (#1032)
Jeff Handley [Tue, 7 Jan 2020 01:17:21 +0000 (17:17 -0800)]
Fix broken docs links (#1005)
* Fix broken docs links in txt/md files under src
* Fix broken docs links found in source code
* Fix broken docs links in workflow docs
* Fix broken docs links in build commands
* Fix broken docs links in HTML resource files
* Update HTTP/SSL stress test docs for local builds
Co-Authored-By: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
* Fix a few remaining broken links
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Jan Vorlicek [Tue, 7 Jan 2020 00:48:58 +0000 (01:48 +0100)]
PAL unused functions cleanup (#1313)
* Remove some unused PAL functions
* Remove SearchPathA
* Remove most of the clr::fs stuff
* Remove GetFileInformationByHandle
* Remove CompareFileTime from public PAL surface
* Remove GetLongPathName
* Remove GetShortPathName
* Remove some directory and file related functions
Make some of the functions private, but keep them in PAL as
too many PAL tests were using them and transforming those tests would
be waste of time.
* Remove non-existent PAL tests from the paltestlist.txt
Jan Kotas [Tue, 7 Jan 2020 00:48:03 +0000 (16:48 -0800)]
Force Windows SDK to be 10.0 (#1331)
This fixes the build failures on Windows Server 2012
Adeel Mujahid [Tue, 7 Jan 2020 00:47:34 +0000 (02:47 +0200)]
Fix build on Void Linux musl (#1337)
* xstate_bv was renamed to xfeatures in torvalds/linux@400e4b2, also
see https://lore.kernel.org/patchwork/patch/939801/. Added a cmake
check to detect if old header is available on the build machine.
* Make musl-libc based distro RID detection more permissive by adapting
condition used by public-facing dotnet-install script:
https://github.com/dotnet/toolset/blob/a229608/scripts/obtain/dotnet-install.sh#L163
Alexandre Mutel [Tue, 7 Jan 2020 00:03:14 +0000 (01:03 +0100)]
Fix compMatchedVM by using osType to detect cross target compilation in case of AOT scenario (#1243)
Tanner Gooding [Tue, 7 Jan 2020 00:02:52 +0000 (16:02 -0800)]
Update cmd and batch scripts to be crlf (#1336)
Vladimir Sadov [Mon, 6 Jan 2020 22:42:52 +0000 (14:42 -0800)]
Updating `JitEEVersionIdentifier` GIUD. A follow up for removing ArrayTypeDesc. (#1330)
Bill Wert [Mon, 6 Jan 2020 22:31:11 +0000 (14:31 -0800)]
Optimize AdjustMaxWorkersActive (#1103)
@ninedan reported this function as expensive in one of the server scenarios
he monitors. The actual time is spent in `ThreadStore::GetAllThreadList`.
Moving the call to `GetTotalWorkerThreadPoolCompletionCount` should reduce this
cost.
Fixes #1079
ts2do [Mon, 6 Jan 2020 21:57:32 +0000 (15:57 -0600)]
Copy change to XsdDateTime (#1319)
I copied the change from dotnet/coreclr#7769 to XsdDateTime which eliminates extraneous iterations of the days array.
Carlos Sanchez Lopez [Mon, 6 Jan 2020 21:57:05 +0000 (13:57 -0800)]
Add documentation guidelines when adding new APIs (#1335)
* Add documentation guidelines when adding new APIs
* Update docs/coding-guidelines/adding-api-guidelines.md
Co-Authored-By: Dan Moseley <danmose@microsoft.com>
* Update docs/coding-guidelines/adding-api-guidelines.md
Co-Authored-By: Dan Moseley <danmose@microsoft.com>
* Update docs/coding-guidelines/adding-api-guidelines.md
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
* Update docs/coding-guidelines/adding-api-guidelines.md
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
* Update docs/coding-guidelines/adding-api-guidelines.md
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Eric StJohn [Mon, 6 Jan 2020 20:49:43 +0000 (12:49 -0800)]
Remove STREAM_MEMORY_OVERLOADS_AVAILABLE (#1328)
Dmitriy Maksimov [Mon, 6 Jan 2020 19:25:42 +0000 (05:25 +1000)]
Removed duplicates/unused code from src\jit\jitstd. (#1272)
make_signed/make_unsigned moved to clr_std/type_traits.
Removed pair.h and type_traits.h
Fix #27557
Elinor Fung [Mon, 6 Jan 2020 19:24:32 +0000 (11:24 -0800)]
Fix reported result for incompatible version for default ALC (#1083)
FindInLoadContext and ApplicationAssemblies stages were reporting name
mismatch instead of incompatible version
Erhan Atesoglu [Mon, 6 Jan 2020 18:34:08 +0000 (10:34 -0800)]
CoreFX Renames in System.IO PathInternal.Tests (#1017)
Andrew Arnott [Mon, 6 Jan 2020 18:29:28 +0000 (11:29 -0700)]
Fix typo: availabe -> available (#1324)
Alexandre Mutel [Mon, 6 Jan 2020 18:26:51 +0000 (19:26 +0100)]
Add CMAKE add_jit function and remove duplicated code for all JIT (#1292)
Leslie Zhai [Mon, 6 Jan 2020 18:10:42 +0000 (12:10 -0600)]
[ARM64] Change INS_bkpt to INS_brk for INS_BREAKPOINT (#892)
* [ARM64] Change INS_bkpt to INS_brk for INS_BREAKPOINT
https://github.com/dotnet/runtime/issues/606
* [ARM64] Change INS_bkpt to INS_brk for INS_BREAKPOINT
https://github.com/dotnet/runtime/issues/606
* [ARM64] Change INS_bkpt to INS_brk for INS_BREAKPOINT
https://github.com/dotnet/runtime/issues/606
* [ARM64] Change INS_bkpt to INS_brk for TARGET_UNIX
https://github.com/dotnet/runtime/issues/606
* [ARM64] Change INS_bkpt to INS_brk for TARGET_UNIX
https://github.com/dotnet/runtime/issues/606
* Fix formatting errors for INS_MULADD
mikedn [Mon, 6 Jan 2020 18:08:57 +0000 (20:08 +0200)]
Move LocalAddressVisitor to a separate file (#1306)
Tomas Weinfurt [Mon, 6 Jan 2020 17:17:50 +0000 (09:17 -0800)]
implement GetScopeId() on Linux (#1038)
Jan Kotas [Mon, 6 Jan 2020 17:15:24 +0000 (09:15 -0800)]
Add asserts to catch unintentional use of generic overloads (#1200)
* Add asserts to catch unintentional use of generic overloads
* Delete unnecessary ifdefs
Jan Kotas [Mon, 6 Jan 2020 17:07:16 +0000 (09:07 -0800)]
Move Corelib shared files under Common (#1307)
Contributes to #1232
Miha Zupan [Mon, 6 Jan 2020 11:28:15 +0000 (12:28 +0100)]
Implement HttpContent and HttpClient cancellation APIs (#686)
* Implement HttpContent and HttpClient cancellation APIs
Implements APIs approved in dotnet/corefx#32615 and dotnet/runtime#576
* Use new CreateContentReadStreamAsync overload in MultipartContent
* Expose HttpContent.SerializeToStreamAsync overload with cancellation
* Remove HTTP_DLL preprocessor directives
* Rename WIN_HTTP_HANDLER to WINHTTPHANDLER_DLL
* Use more 'var' where type is obvious
Adeel Mujahid [Mon, 6 Jan 2020 09:19:58 +0000 (11:19 +0200)]
Share compiler config code between libs and coreclr (#1072)
* Share compiler config code between libs and coreclr
Jan Kotas [Mon, 6 Jan 2020 04:08:35 +0000 (20:08 -0800)]
Delete cmake_minimum_required from PAL tests (#1312)
It is sufficient to have it in the top level file only
Sergey Andreenko [Mon, 6 Jan 2020 03:46:16 +0000 (19:46 -0800)]
Fix which platform should be excluded. (#1314)
Roman Marusyk [Mon, 6 Jan 2020 02:11:45 +0000 (04:11 +0200)]
Consolidate .netcoreapp.cs files because System.Numerics.Vectors project is no longer cross-compiled (#1310)
Sergey Andreenko [Mon, 6 Jan 2020 02:06:07 +0000 (18:06 -0800)]
Disable failing jobs in PR testing. (#1283)
* Disable failing jobs in PR testing.
* Disable the same in runtime file.
Andrew Au [Sun, 5 Jan 2020 23:14:17 +0000 (15:14 -0800)]
Make sure we update nextByte when we decode NEXT_OPCODE in x86 GCinfo (#1299)
* Make sure we update nextByte when we decode NEXT_OPCODE in x86 GCinfo
* Update src/coreclr/src/tools/crossgen2/ILCompiler.Reflection.ReadyToRun/x86/InfoHdr.cs
Co-Authored-By: Jan Vorlicek <janvorli@microsoft.com>
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
Maher Jendoubi [Sun, 5 Jan 2020 18:21:03 +0000 (19:21 +0100)]
Contributing: renaming methods (#1303)
Jan Vorlicek [Sun, 5 Jan 2020 17:52:44 +0000 (18:52 +0100)]
Fix GCRefMap for generic method calls via Unboxing stub (#1304)
Crossgen2 was generating GCRefMap for calls to generic methods via
unboxing stubs incorrectly. With unboxing stub, the caller doesn't pass
in an extra generic parameter since the reference to the boxed value
type passed to the stub serves that purpose. But the GetCallRefMap method
was generating GCRefMap entry for the extra generic argument, which was
leading to a crash when GC was scanning the arguments.
Jan Vorlicek [Sun, 5 Jan 2020 15:14:40 +0000 (16:14 +0100)]
Fix DelayLoadHelper kind for delegate ctors and IsInstanceOf (#1302)
Crossgen2 was incorrectly setting the DelayLoadHelper kind to
DelayLoad_Helper instead of DelayLoad_Helper_Obj and
DelayLoad_Helper_ObjObj. This was causing GC holes.
Ganbarukamo41 [Sat, 4 Jan 2020 23:14:01 +0000 (08:14 +0900)]
Update the path to built runtime for `build -vs` (#1295)
* After 3b9abae, the script was not updated to reflect the changes and was still setting the old path. This resulted in VSTest failing with `It was not possible to find any compatible framework version...`. This commit updates the path (albeit hard-coded; though, this is done in a few other scripts as well) to fix this for now.
Dan Moseley [Sat, 4 Jan 2020 07:11:04 +0000 (23:11 -0800)]
Fix Environment.UserInteractive on Windows (#1234)
* Implement Environment.UserInteractive
* typo
* rename
* Revert M.Win32.SE
* CR feedback
* CR feedback:
* typo
* Fix test
* GUOI declaration
* Another typo!
* Fix build break
* Update src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
* Update src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
* Update src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
* CR feedback
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Vladimir Sadov [Sat, 4 Jan 2020 05:53:15 +0000 (21:53 -0800)]
Removing ArrayTypeDesc (#1201)
* Reduce use of ArrayTpeDesc, somewhat
* remove `AsArray`. Fewer uses of ArrayTypeDesc
* remove `IsArrayType`
* remove AssertArrayTypeDescLoaded
* normalized use of GetElementType vs GetTypeParam vs GetArrayElementTypeHandle
* removed GetMethodTableOfElementType
* HasTypeParam and GetTypeParam should work for TypeHandle when array is not a TypeDesc
* Some cleanup of `IsTypeDesc` use.
* Removed `ArrayTypeDesc`
* a few fixes
* another fix
* dealt with TODOs
* couple fixes from reviewing code
* PR feedback:
Removed `CORINFO_HELP_NEWARR_1_R2R_DIRECT`
Folded a `cmp` in x86 array Address.
Removed` METHOD__BUFFER__BLOCKCOPY` from mscorlib.h
`GetMethodTableOfRootTypeParam`
`GetRootTypeParam`
Straightened `Object::GetTypeHandle`
`AsMethodTable` changes from PR feedback
* Removed `ELEMENT_TYPE_NATIVE_ARRAY_TEMPLATE_ZAPSIG`
* `TypeDesc` is ok in `canInlineTypeCheckWithObjectVTable`
* trivial `AsMethodTable` changes
* `GetVarTypeForTypeHandle` should throw `unsupported` on TypeDescs
* not digging for the root element type in `GetGCSafeTypeHandleIfPossible`
* Last PR feedback
* Fix `TypeInfoTests.Guid()`
Tarek Mahmoud Sayed [Fri, 3 Jan 2020 23:12:18 +0000 (15:12 -0800)]
Revert "Revert "Support GetCultureInfo with predefinedOnly flag (#654)" (#1257)" (#1261)
This reverts commit
4f27799093dcc168384db1ee783e5164a1723df8.
Dan Moseley [Fri, 3 Jan 2020 22:59:58 +0000 (14:59 -0800)]
Make corelib work in VS (#1284)
Andrew Au [Fri, 3 Jan 2020 22:44:52 +0000 (14:44 -0800)]
Make a copy of the image for PEReader (#1263)
Tamar Christina [Fri, 3 Jan 2020 19:20:18 +0000 (19:20 +0000)]
[runtime] Arm64: Add ZipLow, ZipHigh, UnzipOdd and UnzipEven codegen and tests. (#1190)
Dan Moseley [Fri, 3 Jan 2020 17:29:50 +0000 (09:29 -0800)]
Improve message for missing C++ workload (#1253)
* Improve message for missing C++ workload
* typo:
* Fix case of missing rootdir
Tarek Mahmoud Sayed [Fri, 3 Jan 2020 16:47:11 +0000 (08:47 -0800)]
Fix CompareInfo and SQL tests (#1254)
* Fix CompareInfo tests after Windows Regression With Kana
* Fix SQL test
* Address the feedback
Jan Kotas [Fri, 3 Jan 2020 04:21:27 +0000 (20:21 -0800)]
Move most of CoreLib interop under Common (#1247)
Contributes to #1232
Ganbarukamo41 [Fri, 3 Jan 2020 01:18:32 +0000 (10:18 +0900)]
Escape vertical bar (`|`) in the echo message (#1160)
* When `--runtime-path` is not specified, this unescaped character causes the batch file to attempt executing `--runtime-path` (which obviously is not possible) giving out very confusing failures.
Egor Chesakov [Fri, 3 Jan 2020 00:41:13 +0000 (16:41 -0800)]
Arm64: Implement AbsoluteCompare* hardware intrinsics (#1223)
Implements the following set of hardware intrinsics:
* AbsoluteCompareGreaterThan
* AbsoluteCompareGreaterThanOrEqual
* AbsoluteCompareLessThan
* AbsoluteCompareLessThanOrEqual
Implements instructions facge and facgt.
Tarek Mahmoud Sayed [Thu, 2 Jan 2020 23:31:34 +0000 (15:31 -0800)]
Revert "Support GetCultureInfo with predefinedOnly flag (#654)" (#1257)
This reverts commit
5272637ab8ae41c164a51316d792c8dd316df35d.
Tarek Mahmoud Sayed [Thu, 2 Jan 2020 23:25:42 +0000 (15:25 -0800)]
Support GetCultureInfo with predefinedOnly flag (#654)
* Support GetCultureInfo with predefinedOnly flag
Egor Chesakov [Thu, 2 Jan 2020 20:17:22 +0000 (12:17 -0800)]
Clean workspace in global-build-job.yml (#1136)
Carol Eidt [Thu, 2 Jan 2020 18:00:25 +0000 (10:00 -0800)]
More Code Cleanup for EH WriteThru (#1180)
* More Code Cleanup for EH WriteThru
These changes arose from the code reviews for the EH WriteThru work. Some are only tangentially related to EH write-thru, were suggested during that review.
* Revert change to hasEHBoundaryIn condition
* PR feedback
* More PR Feedback
* Fix comment
Tanner Gooding [Thu, 2 Jan 2020 17:57:29 +0000 (09:57 -0800)]
Allow folding of aligned loads when using the VEX encoding and optimizations are enabled (#376)
mikedn [Thu, 2 Jan 2020 16:48:20 +0000 (18:48 +0200)]
Generate struct LCL_VAR nodes in LocalAddressVisitor (#1084)
Converts trees like OBJ(ADDR(LCL_VAR)) into single struct LCL_VAR nodes. It turns out that these are pretty common, thanks to call args & impNormStructVal. Doing this transform before global morph allows local assertion propagation to catch more copies.
Adeel Mujahid [Thu, 2 Jan 2020 01:01:57 +0000 (03:01 +0200)]
Combine pal_compiler.h definitions (#1240)
Egor Chesakov [Wed, 1 Jan 2020 03:47:45 +0000 (19:47 -0800)]
Implement Arm64 comparison hardware intrinsics (#1196)
This implements the following set of hardware intrinsics:
* CompareEqual
* CompareGreaterThan
* CompareGreaterThanOrEqual
* CompareLessThan
* CompareLessThanOrEqual
* CompareTest
Tamar Christina [Tue, 31 Dec 2019 23:13:25 +0000 (23:13 +0000)]
[runtime] Arm64: Add AddAcross Codegen and Tests. (#1093)
buyaa-n [Tue, 31 Dec 2019 20:01:19 +0000 (12:01 -0800)]
Annotate System.Text.Json for nullable (#528)
Annotate System.Text.Json for nullable
mikedn [Tue, 31 Dec 2019 15:53:39 +0000 (17:53 +0200)]
Delete DumpIR code (#1202)
Mika Lehtinen [Tue, 31 Dec 2019 00:42:58 +0000 (02:42 +0200)]
Fix order of arguments in message box call (#1214)
Yaroslav Yamshchikov [Tue, 31 Dec 2019 00:27:25 +0000 (03:27 +0300)]
fixing wrong MOV asm instruction emitter for arm64 (#1216)
Ahmad Ibrahim [Tue, 31 Dec 2019 00:17:48 +0000 (02:17 +0200)]
Fix typo in exception message (#1205)
Roman Marusyk [Mon, 30 Dec 2019 12:03:17 +0000 (14:03 +0200)]
Consolidate .netcoreapp.cs files in Common project (#1178)
Marco Rossignoli [Mon, 30 Dec 2019 11:51:09 +0000 (12:51 +0100)]
Expose SocketAsyncEventArgs constructor for suppressing the execution context (#706)
Make execution context suppressing ctor public. Resolves #937.
Andrew Au [Sun, 29 Dec 2019 21:51:46 +0000 (13:51 -0800)]
More R2RDump refactoring to make it easier for ILSpy to consume the APIs (#1209)
Tanner Gooding [Sun, 29 Dec 2019 18:09:28 +0000 (10:09 -0800)]
Merge pull request #266 from ts2do/BigIntegerFix
Eliminate copy assignment of BigInteger
Sinan Kaya [Sat, 28 Dec 2019 06:58:48 +0000 (01:58 -0500)]
Remove duplicate definition (#1067)
Roman Marusyk [Sat, 28 Dec 2019 01:13:15 +0000 (03:13 +0200)]
Consolidate .netcoreapp.cs test files in System.Reflection (#1176)
* Consolidate .netcoreapp.cs files because System.Reflection project is no longer cross-compiled
* Move extensions to separate class
Dan Moseley [Fri, 27 Dec 2019 20:19:07 +0000 (12:19 -0800)]
Remove some unnecessary console noise in the build (#1146)
* More nologo/nosummary
* Avoid CMAKE logging when skipping copy
Egor Bogatov [Fri, 27 Dec 2019 19:42:39 +0000 (22:42 +0300)]
Intrinsify typeof(T).IsValueType (#1157)
Levi Broderick [Fri, 27 Dec 2019 18:52:14 +0000 (13:52 -0500)]
Remove early exit logic in GetSortKey-related code paths (#1078)
Next Turn [Fri, 27 Dec 2019 18:43:47 +0000 (02:43 +0800)]
Avoid copying in ReadSectionHeaders (#894)
Next Turn [Fri, 27 Dec 2019 18:40:11 +0000 (02:40 +0800)]
Apply FlagsAttribute to Characteristics (#837)
Levi Broderick [Fri, 27 Dec 2019 18:37:16 +0000 (13:37 -0500)]
Revert changes to EncoderNLS/DecoderNLS.Convert (#752)
Henrique Fernandes Baggio [Fri, 27 Dec 2019 17:00:45 +0000 (14:00 -0300)]
Improve ForEach micro-benchmark for ImmutableArray (#1183)
* Improve Foreach benchmark in ImmutableArray<Int32>
Analysis of the generated ASM code vs the same benchmark for Array shows
that the GetEnumerator call is not being inlined (the loop itself is).
In the case of the ValueType ImmutableArray.GetEnumerator method,
there's a call to ThrowNullRefIfNotInitialized for validation.
By adding MethodImplAttribute(MethodImplOptions.AggressiveInlining)
to both methods, we are able to force the JIT to inline the call and get
similar results in the benchmark.
Looking at the hardware counters collected in the benchmark, there are less
CacheMisses and BranchMispredictions/Op when the inlining happens.
Unfortunately, the same fix didn't seem to work for the other overloads of
GetEnumerator, for the explicit generic implementation. That still needs
more investigation.
* AggressiveInline in ThrowNullRefIfNotInitialized isn't needed to inline GetEnumerator
Ganbarukamo41 [Fri, 27 Dec 2019 15:38:19 +0000 (00:38 +0900)]
Cleanup unneeded codes regarding `unsafe` (#1188)
* Remove incorrect comments
* Remove unnecessary `unsafe` keywords
Jan Kotas [Fri, 27 Dec 2019 08:31:18 +0000 (00:31 -0800)]
Replace GetDirectoryNameOfFileAbove with GetPathOfFileAbove where possible (#1175)
Andrew Au [Fri, 27 Dec 2019 07:11:08 +0000 (23:11 -0800)]
Remove XML dumper (#1184)
Vladislav Richter [Thu, 26 Dec 2019 23:47:48 +0000 (00:47 +0100)]
only set next segment if Sequence spans multiple segments (#276)
Erhan Atesoglu [Thu, 26 Dec 2019 23:44:23 +0000 (15:44 -0800)]
CoreFX Renames (#872)
* CoreFX Renames
* Update ReadMe.SharedCode.md
* CoreFX renames to libraries
* Update ReadMe.SharedCode.md
Additions to formatting.
dhusemann [Thu, 26 Dec 2019 23:30:25 +0000 (17:30 -0600)]
Add up for grabs links to coreFX and coreCLR (#881)
* Add up for grabs links to coreFX and coreCLR
Add note under Up for grabs about issues in CoreCLR and CoreFX, until Issues are fully consolidated.
and to submit pull requests to the Runtime Repo.
Contributes to #304
* Update CONTRIBUTING.md
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Dan Moseley [Thu, 26 Dec 2019 23:22:57 +0000 (15:22 -0800)]
Organize some markdowns and fix links (#1159)
* Move files into hierarchy
* fix more links
* Fix botr and features links
* Remove bad apostrophe
* spelling
* Apply suggestions from code review
Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
* Update docs/coding-guidelines/package-projects.md
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
a-zh [Thu, 26 Dec 2019 18:10:11 +0000 (21:10 +0300)]
[doc] Add requirements for cross building (#1169)
Checked for clang building under Ubuntu 18.04 x64.
@大爷是个码农 [Wed, 25 Dec 2019 15:42:46 +0000 (23:42 +0800)]
fix typo in Hashtable.cs (#1151)
Santiago Fernandez Madero [Mon, 23 Dec 2019 23:55:31 +0000 (17:55 -0600)]
Fix .cmd scripts help arguments (#1131)
Santiago Fernandez Madero [Mon, 23 Dec 2019 22:30:33 +0000 (16:30 -0600)]
Flow archType to build script in global live build (#1133)
Dong-Heon Jung [Mon, 23 Dec 2019 19:11:43 +0000 (04:11 +0900)]
Change bIsFree check in DacValidateMethodTable (#1086)
Some commands of SOS validate a method table in DacValidateMethodTable.
In the function, it checks whether a method table is FreeObjectMethodTable or not with GetClass() value.
However, GetClass() should not be NULL. (There is an assert in GetClass())
In this patch, it compares pMT address with g_pFreeObjectMethodTable address only.
Yaroslav Yamshchikov [Mon, 23 Dec 2019 17:14:45 +0000 (20:14 +0300)]
more appropriate default rootfs-dir path (#1126)
crossbuilding of at least armel:tizen and arm64:xenial works fine
without specifying the ROOTFS_DIR environment variable (with default
path) only if changes of this PR are applied. (building coreclr using
src/coreclr/build.sh script on linux)
Yaroslav Yamshchikov [Mon, 23 Dec 2019 14:36:07 +0000 (17:36 +0300)]
chmod +x on scripts building rootfs for Tizen (#1125)
get the execute rights to Tizen scripts building the rootfs
Günther Foidl [Sun, 22 Dec 2019 06:49:11 +0000 (07:49 +0100)]
SequenceEqual picks the correct overload (#1113)
Roman Marusyk [Sun, 22 Dec 2019 06:13:14 +0000 (08:13 +0200)]
Consolidate .netcoreapp.cs files because System.Diagnostics.* projects is no longer cross-compiled (#1101)