platform/upstream/v8.git
15 years agoFix names after move of architecture dependent files.
iposva@chromium.org [Wed, 29 Apr 2009 00:01:51 +0000 (00:01 +0000)]
Fix names after move of architecture dependent files.

TBR=lrn

Review URL: http://codereview.chromium.org/100138

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix lint error
whesse@chromium.org [Tue, 28 Apr 2009 15:14:44 +0000 (15:14 +0000)]
Fix lint error
Review URL: http://codereview.chromium.org/100105

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoChange MergeTo code for virtual frames to use register indices.
whesse@chromium.org [Tue, 28 Apr 2009 13:53:15 +0000 (13:53 +0000)]
Change MergeTo code for virtual frames to use register indices.
Review URL: http://codereview.chromium.org/99052

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1808 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd stubbed-out versions of missing member functions on ARM.
kmillikin@chromium.org [Tue, 28 Apr 2009 10:53:47 +0000 (10:53 +0000)]
Add stubbed-out versions of missing member functions on ARM.

TBR=erik.corry@gmail.com

Review URL: http://codereview.chromium.org/99123

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoInline the inobject property case for named property loads.
kmillikin@chromium.org [Tue, 28 Apr 2009 10:40:36 +0000 (10:40 +0000)]
Inline the inobject property case for named property loads.
Review URL: http://codereview.chromium.org/99120

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRename profileview.js -> profile_view.js because WebInspector already has ProfileView.js.
mikhail.naganov@gmail.com [Tue, 28 Apr 2009 09:15:31 +0000 (09:15 +0000)]
Rename profileview.js -> profile_view.js because WebInspector already has ProfileView.js.

Review URL: http://codereview.chromium.org/100102

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoTickProcessor script reimplemented in JavaScript.
mikhail.naganov@gmail.com [Mon, 27 Apr 2009 13:50:42 +0000 (13:50 +0000)]
TickProcessor script reimplemented in JavaScript.

This is an effort to reuse profiler data processing code both in
TickProcessor and Dev Tools Profiler. The old Python implementation
will be removed.

The new TickProcessor works almost identical to the previous one.
However, it has some differences:

1. Not very useful "Call profile" section is replaced with a new
   WebKit-like "Bottom up (heavy) profile" which shows the most
   expensive functions together with their callers. I used it
   personally in order to find and remove bottlenecks in the
   tickprocessor script itself, and found it quite helpful.

2. Code entries with duplicate names (they occur for RegExes, stubs
   and sometimes for anonymous Function objects) are now distinguished
   by adding an occurence number inside curly brackets.

3. (Address -> code entry) mapping is more precise in boundary cases.

4. Windows version no more requires specifying .map file location.

5. Works faster.

Review URL: http://codereview.chromium.org/99054

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago1. Send 'afterCompile' event to the debug message handler.2. Process messages from...
yurys@chromium.org [Mon, 27 Apr 2009 12:38:20 +0000 (12:38 +0000)]
1. Send 'afterCompile' event to the debug message handler.2. Process messages from the debugger command queue on each event not only break and exception.3. auto_continue is always true for compilation events.
Review URL: http://codereview.chromium.org/100034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix Issue 326. Handle sorting of non-array objects correctly.
lrn@chromium.org [Mon, 27 Apr 2009 11:16:59 +0000 (11:16 +0000)]
Fix Issue 326. Handle sorting of non-array objects correctly.
Change handling of sorting to be the same for all JS-arrays.
Collect undefined values as well while removing holes.

Review URL: http://codereview.chromium.org/92123

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRemove dependency on libstdc++ from test framework.
erik.corry@gmail.com [Mon, 27 Apr 2009 10:52:44 +0000 (10:52 +0000)]
Remove dependency on libstdc++ from test framework.
Review URL: http://codereview.chromium.org/99051

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1799 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoLint.
erik.corry@gmail.com [Mon, 27 Apr 2009 09:27:18 +0000 (09:27 +0000)]
Lint.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoPrepare push of version 1.2.1 to trunk. The main reason for this push
ager@chromium.org [Mon, 27 Apr 2009 09:14:19 +0000 (09:14 +0000)]
Prepare push of version 1.2.1 to trunk.  The main reason for this push
is to get the chromium V8-latest builder working again and to move the
gyp file used for the chromium build to V8 to make it easier to roll
V8 DEPS.
Review URL: http://codereview.chromium.org/99049

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1796 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd gyp file to v8 repository.
ager@chromium.org [Mon, 27 Apr 2009 09:04:39 +0000 (09:04 +0000)]
Add gyp file to v8 repository.

Gyp is used to generate project files used to build chromium.  Moving
the v8.gyp file to the v8 repository makes it easier to have V8 and
the v8.gyp file synchronized (so a DEPS update in chromium gets the
right v8.gyp file associated with that revision of V8).

Review URL http://codereview.chromium.org/100035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1795 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix bugs 145 and 323, preemption and apply on ARM.
erik.corry@gmail.com [Mon, 27 Apr 2009 07:03:10 +0000 (07:03 +0000)]
Fix bugs 145 and 323, preemption and apply on ARM.
Review URL: http://codereview.chromium.org/93121

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoChanged the ASSERT's in the cctest's to CHECK's.
sgjesse@chromium.org [Fri, 24 Apr 2009 14:29:42 +0000 (14:29 +0000)]
Changed the ASSERT's in the cctest's to CHECK's.

There are no ASSERTS left in the cctest's.
Review URL: http://codereview.chromium.org/93120

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1793 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix V8 xcode build.
ager@chromium.org [Fri, 24 Apr 2009 13:18:40 +0000 (13:18 +0000)]
Fix V8 xcode build.

Let xcode fix a couple of things and add json-delay.js to the project.
Review URL: http://codereview.chromium.org/93122

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1792 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix Android build after arch-subdir reorganisation.
erik.corry@gmail.com [Fri, 24 Apr 2009 12:56:58 +0000 (12:56 +0000)]
Fix Android build after arch-subdir reorganisation.
Review URL: http://codereview.chromium.org/94008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1791 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago- When cloning maps to set the 'lazy loading' bit remember to clone
christian.plesner.hansen@gmail.com [Fri, 24 Apr 2009 12:45:29 +0000 (12:45 +0000)]
- When cloning maps to set the 'lazy loading' bit remember to clone
  the properties as well.  This fixes some failing tests.
- Moved json parsing into native code.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRemoved the debug message thread.
sgjesse@chromium.org [Fri, 24 Apr 2009 12:05:40 +0000 (12:05 +0000)]
Removed the debug message thread.

The debug message thread was introduced to make it possible to have the message handler callback be called from a different thread than the thread running V8 where the debug event occoured, but it never had any practical use, and prevents providing information to the message handler which is only available from the V8 thread.

In the future any thread decoupling will have do be done by the embedder.

This also removes the queue used for outbound messages.

Renamed the class Message to CommandMessage as it is only used for debugger commands from the client. Related message queue classes has also been renamed.
Review URL: http://codereview.chromium.org/93118

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1788 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdded ProfileView object for performing sorting, searching and filtering operations...
mikhail.naganov@gmail.com [Fri, 24 Apr 2009 11:37:38 +0000 (11:37 +0000)]
Added ProfileView object for performing sorting, searching and filtering operations on a profile.

It will be used both in the new tickprocessor and Dev Tools profiler.

Review URL: http://codereview.chromium.org/92120

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1786 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoMaterializing a frame element on the stack by pushing it can cause the
kmillikin@chromium.org [Fri, 24 Apr 2009 11:26:49 +0000 (11:26 +0000)]
Materializing a frame element on the stack by pushing it can cause the
stack pointer to change by more than one in a corner case.  If we push
a constant smi larger than 16 bits, we push it via a temporary
register.  Allocating the temporary can cause a register to be spilled
from the frame somewhere above the stack pointer.

As a fix, do not use pushes to materialize ranges of elements of size
larger than one.

Review URL: http://codereview.chromium.org/92121

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1785 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago- Extended lazy loading to general objects, not just functions.
christian.plesner.hansen@gmail.com [Fri, 24 Apr 2009 08:13:09 +0000 (08:13 +0000)]
- Extended lazy loading to general objects, not just functions.
- Added lazily loaded JSON object.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1784 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoMove backend specific files to separate directories.
lrn@chromium.org [Thu, 23 Apr 2009 12:06:38 +0000 (12:06 +0000)]
Move backend specific files to separate directories.
Move ia32 and arm specific files to subdirectories to make it easier to add more backends.

Review URL: http://codereview.chromium.org/92068

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago2nd try at fixing coverage of inline keyed access on IA32.
erik.corry@gmail.com [Thu, 23 Apr 2009 07:52:38 +0000 (07:52 +0000)]
2nd try at fixing coverage of inline keyed access on IA32.
Review URL: http://codereview.chromium.org/92067

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1780 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoPrepare to push version 1.2.0 to trunk. Now worker on version 1.2.1.
ager@chromium.org [Thu, 23 Apr 2009 07:32:25 +0000 (07:32 +0000)]
Prepare to push version 1.2.0 to trunk.  Now worker on version 1.2.1.
Review URL: http://codereview.chromium.org/92066

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1779 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRemove if inside contradictory if.
erik.corry@gmail.com [Thu, 23 Apr 2009 05:45:40 +0000 (05:45 +0000)]
Remove if inside contradictory if.
Review URL: http://codereview.chromium.org/93059

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1777 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix regression test by wrapping expression in a thunk^H^H^H^H^Hstring.
kmillikin@chromium.org [Wed, 22 Apr 2009 17:44:28 +0000 (17:44 +0000)]
Fix regression test by wrapping expression in a thunk^H^H^H^H^Hstring.

Review URL: http://codereview.chromium.org/95001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoMark failing test on ARM.
erik.corry@gmail.com [Wed, 22 Apr 2009 15:20:25 +0000 (15:20 +0000)]
Mark failing test on ARM.
Review URL: http://codereview.chromium.org/92014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1775 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoDevTools: Add support for eventless host message dispatching.
pfeldman@chromium.org [Wed, 22 Apr 2009 14:16:50 +0000 (14:16 +0000)]
DevTools: Add support for eventless host message dispatching.

Review URL: http://codereview.chromium.org/87026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1773 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoMake a test that excercises the preemption code in apply().
erik.corry@gmail.com [Wed, 22 Apr 2009 14:09:50 +0000 (14:09 +0000)]
Make a test that excercises the preemption code in apply().
Review URL: http://codereview.chromium.org/93015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1772 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoUse CollectAllGarbage for the gc() extension.
sgjesse@chromium.org [Wed, 22 Apr 2009 14:00:12 +0000 (14:00 +0000)]
Use CollectAllGarbage for the gc() extension.
Review URL: http://codereview.chromium.org/5666

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd setting break points by using handles.
sgjesse@chromium.org [Wed, 22 Apr 2009 13:59:48 +0000 (13:59 +0000)]
Add setting break points by using handles.

Extend the D8 break command to handle script names with :line[:column] position specification and handles using #<id>#.
Review URL: http://codereview.chromium.org/92011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoSmall changes to improve test coverage in codegen-ia32.cc.
erik.corry@gmail.com [Wed, 22 Apr 2009 13:34:35 +0000 (13:34 +0000)]
Small changes to improve test coverage in codegen-ia32.cc.
Review URL: http://codereview.chromium.org/92008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoWhen merging a frame to an expected on at block entry, the static type
kmillikin@chromium.org [Wed, 22 Apr 2009 13:19:38 +0000 (13:19 +0000)]
When merging a frame to an expected on at block entry, the static type
of elements is set to a safe lower bound.  Move the setting of the
static type out of VirtualFrame::MergeTo (which is not necessarily run
for all frames) and into VirtualFrame::PrepareMergeTo (which is).
Review URL: http://codereview.chromium.org/92009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoThis issue was introduced by http://codereview.chromium.org/67266
yurys@chromium.org [Wed, 22 Apr 2009 13:04:19 +0000 (13:04 +0000)]
This issue was introduced by codereview.chromium.org/67266
Review URL: http://codereview.chromium.org/93014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix for Issue 317 - bug in string.replace(string, "$foo").
lrn@chromium.org [Wed, 22 Apr 2009 11:43:05 +0000 (11:43 +0000)]
Fix for Issue 317 - bug in string.replace(string, "$foo").
Fix for Issue 317. Replace string with something containing dollar now works.

Review URL: http://codereview.chromium.org/94002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1764 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoChange the expectations of the ARM debugger tests once more
sgjesse@chromium.org [Wed, 22 Apr 2009 11:41:19 +0000 (11:41 +0000)]
Change the expectations of the ARM debugger tests once more

A couple of the tests actually passes now.
Review URL: http://codereview.chromium.org/93011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd missing files to the Visual Studio ARM simulator project.
sgjesse@chromium.org [Wed, 22 Apr 2009 11:39:47 +0000 (11:39 +0000)]
Add missing files to the Visual Studio ARM simulator project.
Review URL: http://codereview.chromium.org/93007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAbolish kDebug and use ifdef DEBUG throughout for consistency.
erik.corry@gmail.com [Wed, 22 Apr 2009 09:25:41 +0000 (09:25 +0000)]
Abolish kDebug and use ifdef DEBUG throughout for consistency.
Review URL: http://codereview.chromium.org/94001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1761 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoEnable flaky test that was fixed some time ago.
sgjesse@chromium.org [Wed, 22 Apr 2009 09:01:13 +0000 (09:01 +0000)]
Enable flaky test that was fixed some time ago.
Review URL: http://codereview.chromium.org/80001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoChange the expectations of the ARM debugger tests.
sgjesse@chromium.org [Wed, 22 Apr 2009 08:54:59 +0000 (08:54 +0000)]
Change the expectations of the ARM debugger tests.

Previous change r1756 caused some ARM debugger tests to fail instead of crash in release mode.
Review URL: http://codereview.chromium.org/93005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1759 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdding hidden values always turned the object slow case because the
ager@chromium.org [Wed, 22 Apr 2009 07:38:08 +0000 (07:38 +0000)]
Adding hidden values always turned the object slow case because the
hidden symbol is not an identifier.  Make sure to keep objects fast
case when adding hidden values if possible.
Review URL: http://codereview.chromium.org/93004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1758 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoHandle breaks on keyed IC loads which can have an inlined version.
sgjesse@chromium.org [Tue, 21 Apr 2009 14:48:54 +0000 (14:48 +0000)]
Handle breaks on keyed IC loads which can have an inlined version.

For keyed IC loads setting a break point now ensures that the inlined code is not used. When the break point is set the inlined map check is changed to fail causing the inlined code not to be used but the IC to be called. As long at the break point is set the map check will stay invalid.
Review URL: http://codereview.chromium.org/87025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1756 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAs long as all debugger messages are handled by a single static method we need a...
yurys@chromium.org [Tue, 21 Apr 2009 14:06:48 +0000 (14:06 +0000)]
As long as all debugger messages are handled by a single static method we need a way to identify request sender to route the response to the right handler. To accomplish this clients can send some additional data along with command text and debugger will later pass this data to the message handler along with the response text.

Review URL: http://codereview.chromium.org/67266

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago* Add code to check coverage of generated code on IA32 port.
erik.corry@gmail.com [Tue, 21 Apr 2009 13:42:12 +0000 (13:42 +0000)]
* Add code to check coverage of generated code on IA32 port.
* Move ARM coverage code to ARM-specific file and add missing
file to cover.
Review URL: http://codereview.chromium.org/88025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1754 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoreview
christian.plesner.hansen@gmail.com [Tue, 21 Apr 2009 13:28:34 +0000 (13:28 +0000)]
review

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1753 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agodoc
christian.plesner.hansen@gmail.com [Tue, 21 Apr 2009 13:28:22 +0000 (13:28 +0000)]
doc

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoforce-set
christian.plesner.hansen@gmail.com [Tue, 21 Apr 2009 13:28:11 +0000 (13:28 +0000)]
force-set

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1751 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoReduced size of Array.reduce test.
lrn@chromium.org [Tue, 21 Apr 2009 11:25:51 +0000 (11:25 +0000)]
Reduced size of Array.reduce test.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd ES5 Array methods reduce and reduceRight, with test.
lrn@chromium.org [Tue, 21 Apr 2009 09:57:30 +0000 (09:57 +0000)]
Add ES5 Array methods reduce and reduceRight, with test.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoMake it possible to add a user data object to each script compiled.
sgjesse@chromium.org [Tue, 21 Apr 2009 07:22:06 +0000 (07:22 +0000)]
Make it possible to add a user data object to each script compiled.
Review URL: http://codereview.chromium.org/90003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1748 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix style issues caught by presubmit script.
feng@chromium.org [Mon, 20 Apr 2009 17:44:39 +0000 (17:44 +0000)]
Fix style issues caught by presubmit script.

TBR = erikcorry

Review URL: http://codereview.chromium.org/83004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd ENABLE_DEBUGGER_SUPPORT macro.
feng@chromium.org [Mon, 20 Apr 2009 16:36:13 +0000 (16:36 +0000)]
Add ENABLE_DEBUGGER_SUPPORT macro.

ENABLE_DEBUGGER_SUPPORT is enabled by default unless it is on Android platform.
On Android platform, it can also enabled by passing -DENABLE_DEBUGGER_SUPPORT flag to the compiler.

This should not affect any existing build (I hope, cross my fingers) except the build in real Android environment (in other word, it only affects me now).

There are lot of room for code refactoring in stead of using #ifdef all over the place. I will leave this to v8 folks.

Review URL: http://codereview.chromium.org/77035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRemove unused runtime function.
sgjesse@chromium.org [Mon, 20 Apr 2009 12:15:27 +0000 (12:15 +0000)]
Remove unused runtime function.

The CompileScript runtime function is not used by any builtins any more.
Review URL: http://codereview.chromium.org/80003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1744 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoCorrect the marking of tests that only fail on the simulator.
ager@chromium.org [Mon, 20 Apr 2009 09:40:08 +0000 (09:40 +0000)]
Correct the marking of tests that only fail on the simulator.
Review URL: http://codereview.chromium.org/80002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1743 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd an option to the SCons build to control Microsoft Visual C++ link-time code gener...
sgjesse@chromium.org [Sat, 18 Apr 2009 00:03:15 +0000 (00:03 +0000)]
Add an option to the SCons build to control Microsoft Visual C++ link-time code generation.

Turning off Microsoft Visual C++ link-time code generation makes linking on Windows significantly which is convenient during development. There has also been a request from embedders for a way to control this for embedding application which does not use link-time code generation.

The name of the option is msvcltcg and the default value is 'on' to keep the same behaviour as before.
Review URL: http://codereview.chromium.org/69026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1742 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd a "read" extension to the shell programs. This global function
iposva@chromium.org [Fri, 17 Apr 2009 21:04:34 +0000 (21:04 +0000)]
Add a "read" extension to the shell programs. This global function
reads the contents of a file into a string and returns it.

Review URL: http://codereview.chromium.org/67262

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1741 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoImplemented a CSV parser in JavaScript.
mikhail.naganov@gmail.com [Fri, 17 Apr 2009 17:58:14 +0000 (17:58 +0000)]
Implemented a CSV parser in JavaScript.

Review URL: http://codereview.chromium.org/67253

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1740 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoImplemented Profile object that processes profiling events and calculates profiling...
mikhail.naganov@gmail.com [Fri, 17 Apr 2009 17:40:52 +0000 (17:40 +0000)]
Implemented Profile object that processes profiling events and calculates profiling data.

Review URL: http://codereview.chromium.org/77014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1739 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoImprove coverage of line 619 in stub-cache-arm.cc
erik.corry@gmail.com [Fri, 17 Apr 2009 14:34:35 +0000 (14:34 +0000)]
Improve coverage of line 619 in stub-cache-arm.cc
Review URL: http://codereview.chromium.org/77028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1738 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoLint.
erik.corry@gmail.com [Fri, 17 Apr 2009 13:57:15 +0000 (13:57 +0000)]
Lint.
Review URL: http://codereview.chromium.org/77026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1737 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago* Remove unused code from codegen-arm.cc
erik.corry@gmail.com [Fri, 17 Apr 2009 13:27:36 +0000 (13:27 +0000)]
* Remove unused code from codegen-arm.cc
* Fix fp ops on pre-EABI ARM targets.
* Fix missing TIMEVAL_TO_TIMESPEC on Android.
Review URL: http://codereview.chromium.org/77025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoIf an external string enters the symbol table, make sure to set the
ager@chromium.org [Fri, 17 Apr 2009 09:17:04 +0000 (09:17 +0000)]
If an external string enters the symbol table, make sure to set the
resource to NULL when removing it from the symbol table.  This makes
sure that the debugger can recognize the external string as being
"deleted".  Now, whenever an external resource is deleted, the
resource pointer is set to NULL.

This is really a workaround of a debugger problem.  We need to make
sure that the debugger only finds scripts in the heap that are
actually live.
Review URL: http://codereview.chromium.org/69029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1734 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago- Fix buffer overflow in the pre-allocated memory thread.
iposva@chromium.org [Fri, 17 Apr 2009 00:57:21 +0000 (00:57 +0000)]
- Fix buffer overflow in the pre-allocated memory thread.

Review URL: http://codereview.chromium.org/67248

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years ago- Fix delta time calculation in LinuxSemaphore::Wait.
iposva@chromium.org [Fri, 17 Apr 2009 00:56:52 +0000 (00:56 +0000)]
- Fix delta time calculation in LinuxSemaphore::Wait.

Review URL: http://codereview.chromium.org/69024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix building of snapshots on Windows.
sgjesse@chromium.org [Fri, 17 Apr 2009 00:15:12 +0000 (00:15 +0000)]
Fix building of snapshots on Windows.

The romoval of _HAS_EXCEPTIONS=0 from the source files was not fully complemented with changes to the compiler flags used for mksnapshot.
Review URL: http://codereview.chromium.org/67242

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1731 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoStart addressing massive arrays on the stack. There is hardly ever
iposva@chromium.org [Thu, 16 Apr 2009 21:01:05 +0000 (21:01 +0000)]
Start addressing massive arrays on the stack. There is hardly ever
a reason to stack allocate large chunks of stack space.
- Runtime_GetCFrames used to allocate a frame size of 52040 bytes.
- PreallocatedMemoryThread::Run used to allocate 32784 bytes.
- Fixed StringStream overflow conditions.

Review URL: http://codereview.chromium.org/67197

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1729 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRemove unused CodeRegion class and corresponding logging functions.
mikhail.naganov@gmail.com [Thu, 16 Apr 2009 17:30:27 +0000 (17:30 +0000)]
Remove unused CodeRegion class and corresponding logging functions.

Review URL: http://codereview.chromium.org/67221

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAllow multiple function literals to be assigned to the same var / property.
mikhail.naganov@gmail.com [Thu, 16 Apr 2009 16:34:24 +0000 (16:34 +0000)]
Allow multiple function literals to be assigned to the same var / property.

In such a case all functions get the same name. I think it's a good performance / usability tradeoff. In case a developer wants more clarity, it's up to him to give names to functions.

Review URL: http://codereview.chromium.org/67168

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoReimplement (address -> code) mapping from tickprocessor.py in JS.
mikhail.naganov@gmail.com [Thu, 16 Apr 2009 16:05:17 +0000 (16:05 +0000)]
Reimplement (address -> code) mapping from tickprocessor.py in JS.

Found a pair of bugs concerned with border cases in the original implementation.

Review URL: http://codereview.chromium.org/67191

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1726 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoMigrate a couple of old tests to mjsunit tests.
ager@chromium.org [Thu, 16 Apr 2009 13:46:55 +0000 (13:46 +0000)]
Migrate a couple of old tests to mjsunit tests.
Review URL: http://codereview.chromium.org/67215

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1725 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix lint. Accidentally commited a reindentation of a parameter list
ager@chromium.org [Thu, 16 Apr 2009 12:58:14 +0000 (12:58 +0000)]
Fix lint.  Accidentally commited a reindentation of a parameter list
that introduced line that was too long.

Review URL: http://codereview.chromium.org/67214

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1724 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoDon't blindly use blx instruction without knowing whether the CPU supports it.
erik.corry@gmail.com [Thu, 16 Apr 2009 12:12:47 +0000 (12:12 +0000)]
Don't blindly use blx instruction without knowing whether the CPU supports it.
Review URL: http://codereview.chromium.org/67213

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1723 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoChange the enumeration order for unsigned integer keys to always be
ager@chromium.org [Thu, 16 Apr 2009 11:30:55 +0000 (11:30 +0000)]
Change the enumeration order for unsigned integer keys to always be
numerical order independently of the representation of the object.

Exchanged the order of enumeration of integer and string keys so
integer keys are first instead of string keys to better match
WebKit/JSC behavior.

Added test cases that document our enumeration order choice.
Review URL: http://codereview.chromium.org/75035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1722 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRemove some unused macros from objects.cc.
kmillikin@chromium.org [Thu, 16 Apr 2009 11:30:00 +0000 (11:30 +0000)]
Remove some unused macros from objects.cc.
Review URL: http://codereview.chromium.org/67211

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1721 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAvoid a call to the runtime system when doing binary fp ops on ARM
erik.corry@gmail.com [Thu, 16 Apr 2009 09:30:23 +0000 (09:30 +0000)]
Avoid a call to the runtime system when doing binary fp ops on ARM
(at the moment only if we do not need to allocate a heap number).
Find a few more oportunities to avoid heap number allocation on IA32.
Add some infrastructure to test coverage of generated ARM code in our
tests.
Review URL: http://codereview.chromium.org/67163

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoLookup can now be performed for several handles.
yurys@chromium.org [Thu, 16 Apr 2009 06:03:17 +0000 (06:03 +0000)]
Lookup can now be performed for several handles.
Review URL: http://codereview.chromium.org/67155

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1719 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd debug command break flag for debugger host dispatch.
sgjesse@chromium.org [Wed, 15 Apr 2009 19:09:38 +0000 (19:09 +0000)]
Add debug command break flag for debugger host dispatch.

Ensure that debugger host dispatch is processed even though there are no debugger commands in the queue.
Review URL: http://codereview.chromium.org/67180

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1718 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoPrepare a push to trunk (version 1.1.10).
kasperl@chromium.org [Wed, 15 Apr 2009 13:16:51 +0000 (13:16 +0000)]
Prepare a push to trunk (version 1.1.10).
Review URL: http://codereview.chromium.org/67167

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoChange the function name collector to tolerate expressions that contain
kmillikin@chromium.org [Wed, 15 Apr 2009 13:14:23 +0000 (13:14 +0000)]
Change the function name collector to tolerate expressions that contain
multiple anonymous function literals as subexpressions.

Choose the rightmost one the one to attach a name to.
Review URL: http://codereview.chromium.org/67165

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1715 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd mjsunit test for the overriding of read-only properties.
ager@chromium.org [Wed, 15 Apr 2009 12:31:02 +0000 (12:31 +0000)]
Add mjsunit test for the overriding of read-only properties.

For compatibility, our behavior here does not match the spec.  Added a
comment to that effect in the test.
Review URL: http://codereview.chromium.org/67164

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1714 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix crash bug when loading const variable in the presence of eval.
ager@chromium.org [Wed, 15 Apr 2009 10:47:23 +0000 (10:47 +0000)]
Fix crash bug when loading const variable in the presence of eval.

The problem was a missing 'uninitialized' check.
Review URL: http://codereview.chromium.org/73076

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoA few small changes to --print-ast behavior:
kmillikin@chromium.org [Wed, 15 Apr 2009 07:41:04 +0000 (07:41 +0000)]
A few small changes to --print-ast behavior:

* Remove two horizontal spaces per indent
* Don't print an extra space between "VAR" and "(" for parameters
* Call the name on named property accesses "NAME"

Review URL: http://codereview.chromium.org/67124

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoTimeout of os.system() in d8 was timing out too soon.
erik.corry@gmail.com [Wed, 15 Apr 2009 07:15:41 +0000 (07:15 +0000)]
Timeout of os.system() in d8 was timing out too soon.
Review URL: http://codereview.chromium.org/63062

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAllow using with and eval in JS extensions in debug mode by
kasperl@chromium.org [Wed, 15 Apr 2009 06:28:07 +0000 (06:28 +0000)]
Allow using with and eval in JS extensions in debug mode by
getting rid of bogus assertion error.
Review URL: http://codereview.chromium.org/73072

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1710 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoReimplement Splay Tree in JavaScript (and add unit tests!).
mikhail.naganov@gmail.com [Wed, 15 Apr 2009 01:22:52 +0000 (01:22 +0000)]
Reimplement Splay Tree in JavaScript (and add unit tests!).

This is the first step in reimplementing tick processing scripts in
JavaScript. The goal is to have the same source both for Dev Tools and
Golem, so Python implementation will be removed to avoid code
duplication.

The implementation follows the Dev Tools style: namespaces and JSDocs
are used.

Review URL: http://codereview.chromium.org/67151

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoTo resolve functions from the call stack we need at least ids for the scripts of...
yurys@chromium.org [Wed, 15 Apr 2009 01:17:00 +0000 (01:17 +0000)]
To resolve functions from the call stack we need at least ids for the scripts of those functions. The information on the scripts is now included into the response.
Review URL: http://codereview.chromium.org/65006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoRemove definition of _HAS_EXCEPTIONS from source files.
sgjesse@chromium.org [Tue, 14 Apr 2009 14:58:23 +0000 (14:58 +0000)]
Remove definition of _HAS_EXCEPTIONS from source files.

The define _HAS_EXCEPTIONS=0 is only required on Windows and is already set in the SCons build file and Visual Studio project files.
Review URL: http://codereview.chromium.org/67116

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1707 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix the source position recorded for funtion return
sgjesse@chromium.org [Tue, 14 Apr 2009 14:56:03 +0000 (14:56 +0000)]
Fix the source position recorded for funtion return

Record the function return position as the end of the function source. Don't record function entry and return positions as statement positions.

Added a test for source position for break at function return.
Review URL: http://codereview.chromium.org/67109

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix VirtualFrame::is_used for ARM
sgjesse@chromium.org [Tue, 14 Apr 2009 14:54:41 +0000 (14:54 +0000)]
Fix VirtualFrame::is_used for ARM

Caused a compiler warning when compiling on Windows.
Review URL: http://codereview.chromium.org/67108

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFix build issue on Mac.
kasperl@chromium.org [Tue, 14 Apr 2009 14:01:00 +0000 (14:01 +0000)]
Fix build issue on Mac.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1703 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoPrepare a push to trunk (version 1.1.9).
kasperl@chromium.org [Tue, 14 Apr 2009 13:29:23 +0000 (13:29 +0000)]
Prepare a push to trunk (version 1.1.9).
Review URL: http://codereview.chromium.org/73031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1701 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoMove STATIC_ASSERT to IsShortcutCandidate to fix the
kasperl@chromium.org [Tue, 14 Apr 2009 12:10:32 +0000 (12:10 +0000)]
Move STATIC_ASSERT to IsShortcutCandidate to fix the
broken build.

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/67126

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1700 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoVerify the symbol table contents before and after all
kasperl@chromium.org [Tue, 14 Apr 2009 12:00:56 +0000 (12:00 +0000)]
Verify the symbol table contents before and after all
GCs (not just mark-compacts) and make the mark-compact
shortcutting of cons-strings identical to the scavenge
version.
Review URL: http://codereview.chromium.org/67125

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1699 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFixed issue 303 by not shortcutting cons-symbols and added
kasperl@chromium.org [Tue, 14 Apr 2009 09:58:42 +0000 (09:58 +0000)]
Fixed issue 303 by not shortcutting cons-symbols and added
symbol table verification after mark-compact GCs.
Review URL: http://codereview.chromium.org/73029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1698 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoFixed presubmit errors.
mikhail.naganov@gmail.com [Tue, 14 Apr 2009 01:33:15 +0000 (01:33 +0000)]
Fixed presubmit errors.

TBR=sgjesse@chromium.org

Review URL: http://codereview.chromium.org/73025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1697 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdd name inference for anonymous functions to facilitate debugging and profiling...
mikhail.naganov@gmail.com [Tue, 14 Apr 2009 00:51:59 +0000 (00:51 +0000)]
Add name inference for anonymous functions to facilitate debugging and profiling of JS code.

Currently function name inference is wired with AST optimization pass to avoid introducing another pass over AST. A better solution would be to rewrite AST visitors so they can be naturally combined together in a single pass, as their current implementation doesn't allow it.

For examples of cases where function names can be inferred, see the tests file.

Review URL: http://codereview.chromium.org/62146

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoReenable d8 stats timers, using the histogram mechanism
davemoore@chromium.org [Tue, 14 Apr 2009 00:30:44 +0000 (00:30 +0000)]
Reenable d8 stats timers, using the histogram mechanism

Review URL: http://codereview.chromium.org/67100

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoImplemented "no heap access" mode for JSFrame which is used for stack sampling in...
mikhail.naganov@gmail.com [Mon, 13 Apr 2009 23:12:04 +0000 (23:12 +0000)]
Implemented "no heap access" mode for JSFrame which is used for stack sampling in profiler.

As I discovered that JSFrame accesses SharedFunctionInfo only to calculate caller SP and the latter is not used in profiler's stack sampling, I disabled accessing heap objects in JSFrame when doing stack sampling. This finally made V8's profiling stable when used from Chrome on a real web app.

Review URL: http://codereview.chromium.org/73020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15 years agoAdded another check in SafeStackFrameIterator.
mikhail.naganov@gmail.com [Mon, 13 Apr 2009 14:42:01 +0000 (14:42 +0000)]
Added another check in SafeStackFrameIterator.

While playing with profiling in debug version of Chrome, I encontered a
case when assertion in StackHandlerIterator failed.

Review URL: http://codereview.chromium.org/65005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1693 ce2b1a6d-e550-0410-aec6-3dcde31c8c00