Greg Daniel [Tue, 16 May 2017 18:38:54 +0000 (14:38 -0400)]
Require copy as draws for vulkan cross context image support
Bug: skia:
Change-Id: I0eb5039146278f88b7a869c8c19d5f84d5857529
Reviewed-on: https://skia-review.googlesource.com/17108
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Mike Klein [Tue, 16 May 2017 16:03:15 +0000 (12:03 -0400)]
clamp to premul in dither
Dither can bump color values above alpha (duh), or below
zero (duh), so clamp back to premul after dithering.
BUG=skia:6644,skia:6643
Change-Id: Ida107e866380e06130af0d01467117bca929ba44
Reviewed-on: https://skia-review.googlesource.com/17070
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Osman [Tue, 16 May 2017 17:30:11 +0000 (13:30 -0400)]
Remove Windows Intel blacklisting of cross context texture
The new version of this feature creates and destroys textures
on the same context, so shouldn't encounter the bug.
Bug: skia:
Change-Id: I5ace8fd066b0198e075a53742875554637fde553
Reviewed-on: https://skia-review.googlesource.com/17101
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Herb Derby [Tue, 16 May 2017 14:51:26 +0000 (10:51 -0400)]
Move lambdas to statics.
Change-Id: I53663197de96402152c07e2ff208fd74e380b0c6
Reviewed-on: https://skia-review.googlesource.com/17061
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Hal Canary [Mon, 15 May 2017 17:35:35 +0000 (13:35 -0400)]
SkCanvas: Helpers for draw{Point,Line,Circle}
Change-Id: Ie9c7d3b8f01aee435563b23b7d27f098f07dd287
Reviewed-on: https://skia-review.googlesource.com/16909
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Florin Malita [Tue, 16 May 2017 11:44:13 +0000 (07:44 -0400)]
Add SK_LEGACY_SWEEP_GRADIENT on Android
Speculative roll fix.
Change-Id: I570c807c4f1d695fe46526a943d5376b79b358a1
Reviewed-on: https://skia-review.googlesource.com/17023
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
recipe-roller [Tue, 16 May 2017 04:01:02 +0000 (21:01 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
25c9fdc7e7213be80307a1f6712c374028deb6c4 Use service_account module in goma module (tikuta@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idca977c9451d3be62fb6c88f74aa64ed6a86be61
Reviewed-on: https://skia-review.googlesource.com/17000
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 16 May 2017 02:51:08 +0000 (19:51 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
bc0fded15f08ac584403368fb9a27af8f80ed5e2 Temporarily disable LocalOutputCache (shinyak@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I20684354c6df8b466f2a63d4c683d8fe7bc09fb4
Reviewed-on: https://skia-review.googlesource.com/16999
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 16 May 2017 02:20:13 +0000 (19:20 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
7fe83ca6ea8c7da4047d6ccd7dfd1cf76ca806f9 remove code for cleaning old goma dir (tfarina@chromium.org)
depot_tools:
https://crrev.com/
2c199e1ec4a226ccecb5282879f284965c5c9b39 gclient: return non-zero exit code on unknown command (phajdan.jr@chromium.org)
https://crrev.com/
c482674289a15e552fac358542a1b00a959bd29d Add support for hooks_os in .gclient (scottmg@chromium.org)
https://crrev.com/
8b5d230254dcd09338a4bf2c0c2a789b9afb4e44 Roll "vpython". (dnj@google.com)
https://crrev.com/
93248c5ccbaab4d3a43bc86681ff21bdbb932f6c owners: handle CLs which only have partial OWNERS (agable@chromium.org)
https://crrev.com/
e2af38e019298d7f5a2762830fdda228d8205bd9 [git retry] Fix Git wrapper fallthrough. (dnj@chromium.org)
https://crrev.com/
a3ba888db8f00dce68cbd6e36fd058ae1d471bc1 [bot_update] Remove "git retry" call. (dnj@chromium.org)
recipe_engine:
https://crrev.com/
9be63aeb7800439b172aaf2d77a156ff5d523947 [context] Fix "check_type" error. (dnj@google.com)
https://crrev.com/
b5078f1d18d40c1e8e073ca0e17c6ac382ddcb57 [test] Don't print coverage version by default. (dnj@google.com)
https://crrev.com/
def1c0f3b0bc9712e87e58031eb08e967e7ee46c [test] improve test failure message with retraining instructions. (iannucci@chromium.org)
https://crrev.com/
ea1ac7522268ac435550c701790fd1276f3e6a05 [post_process] make the check function return True if the expression is (iannucci@chromium.org)
https://crrev.com/
1a90c2644e03337ecfd91dd1e76a7c2713b42808 [platform] improve testing assertions. (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I04fd38756ab61cfe32246fba81c722b624635852
Reviewed-on: https://skia-review.googlesource.com/16998
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Florin Malita [Mon, 15 May 2017 19:06:39 +0000 (15:06 -0400)]
Always use raster pipeline for SkSweepGradient
Add an opt-in mechanism (SkShader::isRasterPipelineOnly) and switch
SkSweepGradient to always-RP.
This also repurposes the existing SK_LEGACY_SWEEP_GRADIENT guard.
Change-Id: Iabf0a701eda56f009d331120f0c987f96bd35d27
Reviewed-on: https://skia-review.googlesource.com/16912
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
recipe-roller [Tue, 16 May 2017 00:20:46 +0000 (17:20 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
f1a52bdea3939b52c096b980fdda4cdd00a45577 Switch recipes over to recipe_engine "url". (dnj@google.com)
https://crrev.com/
1dad4f223eeb2f867d5e6d7c88ad6a23afb26f16 Add 3 more android perf bots to swarming (martiniss@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1241e5ec55769bc8775f4e8d58f8c2bda2a5e30b
Reviewed-on: https://skia-review.googlesource.com/16991
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Mon, 15 May 2017 23:41:27 +0000 (16:41 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
5bf5ff865bea2479f2f50fd4829dd3a3d56943be Fix the PGO trybot slaves config. (sebmarchand@chromium.org)
https://crrev.com/
14341361190c01441ac69f599f9856604f879370 ios: Use checkout-relative paths. (dnj@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib6881e77f1eb18e058aad48f02880a7687d074f4
Reviewed-on: https://skia-review.googlesource.com/16990
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Mike Klein [Mon, 15 May 2017 22:03:52 +0000 (18:03 -0400)]
add a test that sRGB stages round trip
Change-Id: Ide8303f6fc162f3703f7db298fe210d47225a580
Reviewed-on: https://skia-review.googlesource.com/16988
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
recipe-roller [Mon, 15 May 2017 22:31:34 +0000 (15:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
f522dd62d97d12f77f41793955f68bbae2d944d3 annotated_run: Flip on use_result_proto on chromium.fyi (martiniss@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9207e5b373f7632bf2bbb132e655380501c9a94d
Reviewed-on: https://skia-review.googlesource.com/16989
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Mon, 15 May 2017 22:00:25 +0000 (15:00 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
182e9aa84d8536bb43c28ce0c0653cc8b78d6848 [remote_run] roll recipes-py to match canary (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01cae50984a1c24118a7e6a6a9a77eee267403d1
Reviewed-on: https://skia-review.googlesource.com/16987
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Mon, 15 May 2017 21:31:59 +0000 (14:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
3dd44c72ac7525343fe66f240897daeb0402855c Fix bug in recipe result handling logic (martiniss@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8c03ee08a2087389d54f3f32c662f374a514d1d
Reviewed-on: https://skia-review.googlesource.com/16985
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Mike Klein [Mon, 15 May 2017 20:32:48 +0000 (16:32 -0400)]
fix windows detection in SkExecutor.cpp
defined(SK_BUILD_FOR_WIN32) is our usual way of detecting Windows.
It's basically a roundabout defined(_WIN32).
Don't know why I picked _MSC_VER here.
BUG=skia:6635
Change-Id: I8986ec12dc1cc79a1cf16abf2a1ecbc5e0447786
Reviewed-on: https://skia-review.googlesource.com/16919
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
recipe-roller [Mon, 15 May 2017 20:50:26 +0000 (13:50 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
5ec0e7a366c2ecae11a1603aa5d91097014b34b7 Add new bots to client.boringssl. (davidben@chromium.org)
https://crrev.com/
31979e555f4e6c30109344df86232a52e73e73e3 Switch buckets for BoringSSL SDE builder. (davidben@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d867a3ead1a45f76c81a0b663a46e848420e2c5
Reviewed-on: https://skia-review.googlesource.com/16982
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Greg Daniel [Mon, 15 May 2017 20:47:46 +0000 (16:47 -0400)]
Enable CrossContextTextureSupport on vulkan
Bug: skia:
Change-Id: I49d9c697e1749972f4f2fbc89ca47a472c986b65
Reviewed-on: https://skia-review.googlesource.com/16980
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Brian Salomon [Mon, 15 May 2017 20:45:49 +0000 (16:45 -0400)]
Convert GrOvalOpFactory from GrLegacyMeshDrawOp to GrMeshDrawOp using GrSimpleDrawOpHelper.
Change-Id: Ib9f59ddf1c2c3f2bd0004ae16f842e52f45df8c9
Reviewed-on: https://skia-review.googlesource.com/16832
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
recipe-roller [Mon, 15 May 2017 20:21:41 +0000 (13:21 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
df3fabbcf94016a8a37b74014bb4604e55faa577 Add another slave to the PGO pool (sebmarchand@chromium.org)
https://crrev.com/
a1d4fe1c5b7eb1960420c1f2cc7d11f3442e9ab7 move goma_setup() and goma_teardown() into goma_utils.py (tfarina@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2de885899ed22916e360f2bb0cf33c491c0602cf
Reviewed-on: https://skia-review.googlesource.com/16916
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Mike Klein [Mon, 15 May 2017 19:55:54 +0000 (15:55 -0400)]
fix SkJumper radial gradient precision
rcp(rsqrt(x)) doesn't have enough precision when x is a coordinate.
(It's fine when x is a color, like in the softlight blend mode.)
Adds a GM to test this. It used to look quite ugly.
Change-Id: Icec295c2e2f50ae7a5e3e33c62270f632a58f65c
Reviewed-on: https://skia-review.googlesource.com/16914
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Mon, 15 May 2017 16:19:39 +0000 (12:19 -0400)]
Add sRGB support to monobench.
We'll now run non-rendering and raster benchmarks,
for simplicity choosing sRGB as the only raster configuration.
$ ninja -C out monobench; and out/monobench "linear_clamp_(3color|pos)\$"
gradient_linear_clamp_…
6257 …3color 1x …pos 1.03x
$ ninja -C out monobench; and out/monobench "linear_clamp_.*[^4][^f]\$"
gradient_linear_clamp_…
321 …shallow 1x …shallow_dither 1x …3color 1.49x …hicolor 1.5x …pos 1.52x
Change-Id: I7282a84c982eb1f11f0ea2dfe39afea66231761c
Reviewed-on: https://skia-review.googlesource.com/16877
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Hal Canary [Mon, 15 May 2017 20:16:42 +0000 (16:16 -0400)]
experimental/documentation/gerrit.md: more tricks
NOTRY=true
Change-Id: I04d371b16f7805b4c972010a5bc1eebd979169a6
Reviewed-on: https://skia-review.googlesource.com/16915
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Hal Canary [Tue, 9 May 2017 17:58:58 +0000 (13:58 -0400)]
documentaion: consistant formatting
NOTRY=true
Change-Id: I2dd9d755242ca6c3522c465e1fa00139dda71a9d
Reviewed-on: https://skia-review.googlesource.com/16220
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Mike Reed [Mon, 15 May 2017 17:27:02 +0000 (13:27 -0400)]
check for no_paint and remove some drawdrawable special-casing
Bug: skia:
Change-Id: I824980a47ddd7c8c7627dabb5efd40f8f0889b67
Reviewed-on: https://skia-review.googlesource.com/16900
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Jim Van Verth [Mon, 15 May 2017 17:49:21 +0000 (13:49 -0400)]
Allow shadow zParams to be applied to affine transformations
Change-Id: Iedfded98ce82d15945667232fde22d046d5106b3
Reviewed-on: https://skia-review.googlesource.com/16879
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Brian Salomon [Mon, 15 May 2017 17:48:50 +0000 (13:48 -0400)]
Remove kCheckAllocation_GrSurfaceFlags.
This flags was only specified in one place (per backend). However, it was specified when no allocations occur.
Change-Id: Ic892d3064598519a07fb6773ba626fe022ef2f78
Reviewed-on: https://skia-review.googlesource.com/16904
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Greg Daniel [Mon, 15 May 2017 17:50:35 +0000 (13:50 -0400)]
Add support for creating a shared vulkan test context
Bug: skia:
Change-Id: I997c6269e4676bf4cedddcd87e71d107053678bb
Reviewed-on: https://skia-review.googlesource.com/16905
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Chris Dalton [Mon, 15 May 2017 17:03:26 +0000 (11:03 -0600)]
Convert GrMesh back to a class
Specific methods that limit the data to valid configurations are better
than a runtime mega-assert.
Bug: skia:
Change-Id: Ie15f2dc79659e44cfaddd16eb474795b110fda73
Reviewed-on: https://skia-review.googlesource.com/16577
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Robert Phillips [Mon, 15 May 2017 17:06:44 +0000 (13:06 -0400)]
Rename finishOpList to finishFlush and call it less frequently
It is expected that this will fix the Vulkan perf regression associated with splitting up the opLists
Change-Id: I1bbb6f71745bb08d4a8c2f7810e5ab84cca75e84
Reviewed-on: https://skia-review.googlesource.com/16901
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Ben Wagner [Mon, 15 May 2017 15:50:34 +0000 (11:50 -0400)]
Remove old iPadMini4 jobs.
These were replaced with RPi-based jobs in
https://skia-review.googlesource.com/c/11521/. The old jobs no longer
have any bots to run them, which is causing a lot of warnings in the
task scheduler logs.
No-Try: true
Change-Id: Iae7b8371cd80fd7ee3fbe368d5dccb0a94913f14
Reviewed-on: https://skia-review.googlesource.com/16876
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Mike Klein [Mon, 15 May 2017 14:20:48 +0000 (10:20 -0400)]
add unaligned_store()
Don't know why I never wrote unaligned_store() to mirror
unaligned_load(), but now I have. This replaces all
remaining memcpy() in SkJumper_stages.cpp, which is nice.
The generated stage code didn't change.
Change-Id: I714c1072a975d7fa268a4b06c13f06557bf0c12c
Reviewed-on: https://skia-review.googlesource.com/16870
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
recipe-roller [Mon, 15 May 2017 16:41:40 +0000 (09:41 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
a2952f1cdf2d9a080b6f9d83f921a0bfe8bed2e7 [cipd_bootstrap_v2] Roll vpython. (dnj@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97353c4714722ae23fb04435d27a5027bf2f9a99
Reviewed-on: https://skia-review.googlesource.com/16878
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Jim Van Verth [Mon, 15 May 2017 14:44:22 +0000 (10:44 -0400)]
Add filled occluders to shadow_utils GM, take 2
Classifies fully visible opaque shadows differently
than transparent to avoid cache collisions.
Change-Id: Iba5aab2b2cbe08f70205c343e86fe92b0cab7497
Reviewed-on: https://skia-review.googlesource.com/16858
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Brian Salomon [Mon, 15 May 2017 15:00:58 +0000 (11:00 -0400)]
Attempt to work around iOS varying limit in GLPrograms test
Dump shaders when linking fails.
Bug: skia:6627
Change-Id: I7f1df4be039eb56d990aa64c58c8dd2a22d97dbe
Reviewed-on: https://skia-review.googlesource.com/16867
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
recipe-roller [Mon, 15 May 2017 15:11:26 +0000 (08:11 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
31740fbd20df2c1aa309ced416038d71ba6636ab Archive the PGO Profile databases. (sebmarchand@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib167bcce111352d43b0bd84cc6a5e75f7fc0b01b
Reviewed-on: https://skia-review.googlesource.com/16872
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Herb Derby [Mon, 15 May 2017 14:49:39 +0000 (10:49 -0400)]
Add evenly spaced stops and unify gradient contexts
Change-Id: I17ac13b9d1ea6765e2c1a2b53aa6975eab408856
Reviewed-on: https://skia-review.googlesource.com/16713
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Reed [Mon, 15 May 2017 14:16:04 +0000 (10:16 -0400)]
remove SkXfermode from api dox -- it is gone
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=16868
Bug: skia:1312
Change-Id: I28aafb80bcad0f3a810ca0b08caa15b70707b4a1
Reviewed-on: https://skia-review.googlesource.com/16868
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Mike Reed [Mon, 15 May 2017 13:34:22 +0000 (09:34 -0400)]
composeshader stages
needed to add two helper stages for composeshader
load_rgba, store_rgba
These just read/write the r,g,b,a registers to context memory, making no promise as to how the
memory is formatted (e.g. interleaved -vs- planar).
Note that we have similar existing stages, but they did not seem to suit:
constant_color
This guy loads 4 floats from memory, and splats them into registers. I need to load 4 entire
registers.
load_f32, store_f32
These offset where they read/write based on the 'x' register, plus they guarantee that the memory
will be interleaved ala SkPM4f.
Bug: skia:
Change-Id: Iaa81f950660b837bdb34416ab3e342d56a92239b
Reviewed-on: https://skia-review.googlesource.com/16716
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Mike Reed [Mon, 15 May 2017 13:29:18 +0000 (09:29 -0400)]
move impl for drawvertices into separate file
expect to refactor the impl, so this just makes that easier
(plus SkDraw.cpp was just too big)
Bug: skia:
Change-Id: I22c07d37429195363d9a76e56a1dca915f9c2d57
Reviewed-on: https://skia-review.googlesource.com/16863
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Matt Sarett [Fri, 12 May 2017 14:56:49 +0000 (10:56 -0400)]
Allow numerical color spaces with legacy rendering
Bug: 720083
Change-Id: Ibd4dbf6ee95ac14857e8280a441f81976710e5e8
Reviewed-on: https://skia-review.googlesource.com/16700
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
Robert Iannucci [Sat, 13 May 2017 02:09:38 +0000 (19:09 -0700)]
[skia] convert recipes and module to new context module
This is a syntax-only change to convert to the new (documented) context
module.
R=borenet@google.com
Bug: skia:
Change-Id: Id907c309d3cf38b85a46f6d8d7ce90ed58ba026f
Reviewed-on: https://skia-review.googlesource.com/16840
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Kevin Lubick [Mon, 15 May 2017 12:30:27 +0000 (08:30 -0400)]
Use CIPD->Isolate on RPI Perf tasks too
Bug: skia:
NOTRY=true
Change-Id: Ide4c5065ab6c252570a81a52b377cb5fb748d0d5
Change-Id: Ide4c5065ab6c252570a81a52b377cb5fb748d0d5
Reviewed-on: https://skia-review.googlesource.com/16862
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
recipe-roller [Mon, 15 May 2017 06:41:27 +0000 (23:41 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
a5879798e46344f83022b4da1ba28911e4d4c9d9 V8: Bump shards on slowest bots (machenbach@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibd08ca994c4a86a06ff103c3cc1af59284d7be13
Reviewed-on: https://skia-review.googlesource.com/16861
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
UpdateSKPs [Sun, 14 May 2017 07:40:33 +0000 (07:40 +0000)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=update-skps@skia.org
NO_MERGE_BUILDS
Change-Id: I85da3a796a5bf0be6bdead1b14de3a4ca01f79ac
Reviewed-on: https://skia-review.googlesource.com/16849
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
recipe-roller [Sun, 14 May 2017 02:41:39 +0000 (19:41 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/
63fd5fef30ebf0db04266b4f4723f77838979365 [url]: get_file has default (empty) test data (dnj@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib437973e7ce76059ee1f7461452356f0da80c974
Reviewed-on: https://skia-review.googlesource.com/16860
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Sat, 13 May 2017 23:41:32 +0000 (16:41 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/
e9c7176184ed588bbf66335e834834496f28cf9c [url] Cleanup, bugfix, step_test_data. (dnj@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb498433b8c6e93c36195327c25cd766d07fe64f
Reviewed-on: https://skia-review.googlesource.com/16838
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Brian Osman [Fri, 12 May 2017 15:21:36 +0000 (11:21 -0400)]
Sort all user-supplied rects before computeFastBounds
https://codereview.chromium.org/
908353002 fixed drawRect 2+ years ago, but
drawOval and drawArc were still susceptible. This version ensures that all
rects are sorted before we do the bounds check. Added a new makeSorted
helper to simplify the code, and an assert to catch any future oversight.
All other drawing functions compute their bounds rect in some way that
already ensures it is sorted.
Bug: skia:
Change-Id: I8926b2dbe9d496d0876f1ac5313bd058ae4568b7
Reviewed-on: https://skia-review.googlesource.com/16702
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
recipe-roller [Sat, 13 May 2017 18:21:23 +0000 (11:21 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/
0070123d9c8f830d813e6ec1064b9bf24a5b29db [context] Fix docstring. (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id76c262abb6f53e420fc00ecef1cf99e383a6592
Reviewed-on: https://skia-review.googlesource.com/16836
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cary Clark [Sat, 13 May 2017 17:35:35 +0000 (13:35 -0400)]
add and fix parameter names
after manually fixing missing names
needed to make documentation easier,
the bookmaker tool found a number of
additional errors.
this is why computers will take our jobs
R=reed@google.com
DOCS_PREVIEW= https://skia.org/?cl=16616
Change-Id: Ieabebf5672601769852adde9be47459602fb43ab
Change-Id: Ieabebf5672601769852adde9be47459602fb43ab
Reviewed-on: https://skia-review.googlesource.com/16616
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Mike Reed <reed@google.com>
recipe-roller [Sat, 13 May 2017 03:41:30 +0000 (20:41 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
9b46527628683523d81d7b11b9872761fa1bad1d git-cl: let 'git config gerrit.host false' work (agable@chromium.org)
https://crrev.com/
69e760e4a571d16e75f30f1e97ea1a917445f333 Switch to recipe engine "url" module. (dnj@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If8fa7b47be8a9c59565a07ddf00fdbf71d0454fc
Reviewed-on: https://skia-review.googlesource.com/16834
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Sat, 13 May 2017 01:41:27 +0000 (18:41 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
227e19e6aa342b29ee65e78075446ca7e9457681 [boringssl] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
fc81373391e1ce78f0794eaf693f4b32e9752136 [swarming+isolate] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
f2df34cef0c1f9ad8e27029dee05442e06099440 [mojo] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
5018c2d38e95c49bdd8edd02c0942a188d619694 [misc] convert recipes and module to new context module. (iannucci@chromium.org)
https://crrev.com/
03127b79eae3314fc07759456ec7a21a015ea2d7 [chromium_codesearch] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
218a9a725c37b295c01318641870286672098332 [pdfium] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
bc6f7db1d0cd860287461a512e1922d8fc8f54ed [dart] convert recipes and module to new context module. (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1378b4cf060e8116b74a7793f16a26905944f98a
Reviewed-on: https://skia-review.googlesource.com/16831
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Sat, 13 May 2017 01:11:02 +0000 (18:11 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
098e59c5c73a153e7492d963582d097199bdef84 [findit] convert recipes and module to new context module (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I759428d4ce0d650cb1c6851e4c0ecbd7fd9e2aa6
Reviewed-on: https://skia-review.googlesource.com/16830
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Sat, 13 May 2017 00:31:24 +0000 (17:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
11ec9ef87c6d6ca597a1c820225cf299ca2dd53f [flutter] convert recipes and module to new context module (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I17250e25016f5190904c2b03ee712aa61fdb7ad2
Reviewed-on: https://skia-review.googlesource.com/16829
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 23:31:26 +0000 (16:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
4fde89076103c315b8c1c1c89ecc9da70c6c6d1e chromite: Stop using self.m.path['root'] for swarming builds. (dgarrett@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id254cb85d1b8e626274dc132f360f7796df9b24d
Reviewed-on: https://skia-review.googlesource.com/16828
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 23:00:14 +0000 (16:00 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
5f26f71095d6af2bd74c035badf11122bbfabe96 Notify network-service-dev mailing list when Mojo Linux bot has a failure. (jam@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia70328b19c303b6e3f4cd31b9c0675522ba65ac8
Reviewed-on: https://skia-review.googlesource.com/16827
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 22:31:31 +0000 (15:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
384957bd4425660fb818f85f6225778bdf8db1fc Enable remote run passthrough. (dnj@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9fe088619291b00ae1c3bbaf9e296761f3508623
Reviewed-on: https://skia-review.googlesource.com/16826
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 21:40:52 +0000 (14:40 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
ef454fe8ba423c8d62dd715e560f0ef3273869f9 Enforce strict coverage for gatekeeper recipe module (phajdan.jr@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0d33fe34c385e7fc984625a3846c06ea4877497b
Reviewed-on: https://skia-review.googlesource.com/16825
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 21:11:17 +0000 (14:11 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
6423755bf44f611b0bef88c573b83701ec61ffc2 chromite: Recipe helper. (dgarrett@google.com)
https://crrev.com/
435c46700222fc7cf44380b15c877ee8f928e81d [ios] convert recipes and module to new context module (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4e8cd508d7c4f2bd8cb3d21342d3be1984a921f9
Reviewed-on: https://skia-review.googlesource.com/16824
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 20:40:57 +0000 (13:40 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
0a06a7bb858fc1a4e521c6b26a9f8d7679385e6e Opt-in Foundations team members to Kitchen. (dnj@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6ac6c03ded63a5b4236d40ca4a4fd5b6dd1d746b
Reviewed-on: https://skia-review.googlesource.com/16823
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 20:10:39 +0000 (13:10 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
53ae1cc975a30a8daae67c5471b0e8fe66554cbc Opt-in Foundations team members to Kitchen. (dnj@chromium.org)
https://crrev.com/
9f7d7ed44c3a4622b6b09013bb6e8a322c942071 Revert "Opt-in Foundations team members to Kitchen." (dnj@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I148df40d3a5915fd49d1a1305eaffca0e4e431f9
Reviewed-on: https://skia-review.googlesource.com/16822
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 19:21:46 +0000 (12:21 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
e0f67109eb83c34776076b1ef5072c4cb94a39b3 remote_run: Enable Kitchen for experimental. (dnj@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic9684914c1e46c63298cfdd3eb10fde204bbc4e5
Reviewed-on: https://skia-review.googlesource.com/16800
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Robert Phillips [Fri, 12 May 2017 18:49:16 +0000 (14:49 -0400)]
Switch ImageStorageAccess over to GrTextureProxies
Split out of: https://skia-review.googlesource.com/c/10484/ (Omnibus: Push instantiation of GrTextures later (post TextureSampler))
Change-Id: I341de6ae121620d30e50bff21450878a18bdf4f2
Reviewed-on: https://skia-review.googlesource.com/16714
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Brian Salomon [Fri, 12 May 2017 18:09:46 +0000 (14:09 -0400)]
Include non-legacy GrMeshDrawOps in GLPrograms test.
Bug: skia:
Change-Id: Ifa0c3ffb5643c84ccdcb339fae75ea5d03a8451c
Reviewed-on: https://skia-review.googlesource.com/16580
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
recipe-roller [Fri, 12 May 2017 18:00:22 +0000 (11:00 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
0bc499288c07b62fbfd66ef96b2fa1803694d2d2 [remote_run] Update canary recipe engine to
6eaacf24833ebd2565177157d368da33780fced9 (iannucci@chromium.org)
https://crrev.com/
fc3f1c8e4f94ecba499a4a77518b56b76e1fa001 [gyp] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
f92dab0066ebe0bdcc2136ae0c8e95257ae45e85 [nacl+wasm] convert recipes and module to new context module (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I307c5e87c192ca03b3deb5d3cecb78672d5f75d1
Reviewed-on: https://skia-review.googlesource.com/16715
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Matt Sarett [Fri, 12 May 2017 18:24:21 +0000 (14:24 -0400)]
Delete legacy image generator flag from bzl
NOTRY=TRUE
Bug: skia:
Change-Id: Icad74e486d957d10cb3e1091525991cd910626b7
Reviewed-on: https://skia-review.googlesource.com/16717
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
recipe-roller [Fri, 12 May 2017 17:31:25 +0000 (10:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
5e0869d351775d40442e89122c6d3854c447ac4b chromiumos.chromium: Remove x86-generic-telemetry (dnj@chromium.org)
https://crrev.com/
44274fe45b77822f5be5fc611e74eab995415d5a Use the new PGO trybot slaves. (sebmarchand@chromium.org)
https://crrev.com/
83123ff7625749c6d3dd5128523847a4ee158d01 [perf_try] convert recipes and module to new context module. (iannucci@chromium.org)
https://crrev.com/
d55b510d1af93ca2e5cdb9d23607ac65e5767bd2 [crashpad] convert recipes and module to new context module (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I385d2d7326d2d0a496833eed788fb98eb475cdfe
Reviewed-on: https://skia-review.googlesource.com/16712
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Mike Reed [Fri, 12 May 2017 17:07:46 +0000 (13:07 -0400)]
implement 4f for composeshader
Bug: skia:
Change-Id: I7ad0077345f7589528c89cd84d252539a1df6614
Reviewed-on: https://skia-review.googlesource.com/16703
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Mike Klein [Fri, 12 May 2017 16:59:24 +0000 (12:59 -0400)]
fix SkJumperHSL blend modes
I took a new, unprincipled approach here, which is to just mimic the
legacy code path exactly (e.g. hue_modeproc in SkXfermode.cpp).
This fixes how we handle alpha in these blend modes, and ought to be
faster by avoiding the unpremul.
BUG=skia:6621
Change-Id: I21635290985ff42d9421d2718f7a88cf44a85d7f
Reviewed-on: https://skia-review.googlesource.com/16711
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
recipe-roller [Fri, 12 May 2017 16:31:32 +0000 (09:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
871fd518d2177cc9252ad935255fb63d3dc11302 Roll "vpython" version on BuildBot. (dnj@chromium.org)
recipe_engine:
https://crrev.com/
60cc7f3f49737e8cf852e396b4436c2b6bd3f56d Add vpython support to Python recipe module. (dnj@chromium.org)
https://crrev.com/
c6560f3627af81c9004024079525ef63a223d33a Add "url" recipe module to base. (dnj@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic0b9db5bd0e2718a7d365466faad5214e1026d4a
Reviewed-on: https://skia-review.googlesource.com/16710
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Mike Klein [Fri, 12 May 2017 16:24:04 +0000 (12:24 -0400)]
fix legacy/SkRasterPipeline SkHighContrastFilter
Change-Id: I395be972abf571af79ccf6ed5917bf463fd2166d
Reviewed-on: https://skia-review.googlesource.com/16709
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Salomon [Fri, 12 May 2017 16:02:50 +0000 (12:02 -0400)]
Modify SkEventTracer::SetInstance to fail rather than assert if a tracer has already been installed.
Chromium usually calls SetInstance once per process. However, when run in single process more renderer threads will try to set the instance after the browser process already has done so. This allows them to fail gracefully without asserting.
Bug: skia:6603
Change-Id: Ic8a35422d787335aa67eefc07d0658f0fbe73db4
Reviewed-on: https://skia-review.googlesource.com/16664
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Matt Sarett [Fri, 12 May 2017 15:41:27 +0000 (11:41 -0400)]
Add new SkImageGenerator::getPixels() API, deprecate the old
This is fairly aggressive in that it will break any client
that is currently using SkImageGenerator with kIndex8.
I'm guessing that we don't have any clients doing that.
Bug: skia:6620
Change-Id: Ifd16f5232bb3a9f759c225315c57492d917ed9ca
Reviewed-on: https://skia-review.googlesource.com/16601
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Brian Salomon [Fri, 12 May 2017 15:36:10 +0000 (11:36 -0400)]
Make GrRenderTarget[(Proxy)|(Context)]? advertise a "full scene aa type".
Bug: skia:
Change-Id: I24549604e8305028e34e0022bfef992a8e8c33f7
Reviewed-on: https://skia-review.googlesource.com/16230
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Jim Van Verth [Fri, 12 May 2017 16:00:31 +0000 (16:00 +0000)]
Revert "Add filled occluders to shadow_utils GM"
This reverts commit
737169965fa97e4c71f2a625315b732969d00264.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Add filled occluders to shadow_utils GM
>
> Change-Id: I70a927261b6530d2352d8d5a713b309aa518e6b0
> Reviewed-on: https://skia-review.googlesource.com/16545
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
>
TBR=jvanverth@google.com,bsalomon@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: If1d71118c781cdc4065187ed4953f42a1acad0f3
Reviewed-on: https://skia-review.googlesource.com/16706
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Jim Van Verth [Fri, 12 May 2017 14:38:38 +0000 (10:38 -0400)]
Add filled occluders to shadow_utils GM
Change-Id: I70a927261b6530d2352d8d5a713b309aa518e6b0
Reviewed-on: https://skia-review.googlesource.com/16545
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Mike Reed [Fri, 12 May 2017 13:28:01 +0000 (09:28 -0400)]
fold matrices together for tricolor
Bug: skia:
Change-Id: Ic4ef679c6b5514f0fc7f895d71b5feeb812da53e
Reviewed-on: https://skia-review.googlesource.com/16606
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Brian Osman [Fri, 12 May 2017 13:46:56 +0000 (09:46 -0400)]
Cleanup SkImageGenerator, add missing fns to GrBackendTextureImageGenerator
No "real" API changes.
TBR=reed@google.com
Bug: skia:
Change-Id: I08c29f76806388394938f204f2a50b2fd6ea8942
Reviewed-on: https://skia-review.googlesource.com/16662
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Matt Sarett [Fri, 12 May 2017 12:54:13 +0000 (08:54 -0400)]
SkEncoder base class needs SK_API
Bug: skia:
Change-Id: I244da1f5f091eaa30d3f65946e11a2fc642b63ea
Reviewed-on: https://skia-review.googlesource.com/16661
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
Matt Sarett [Fri, 12 May 2017 12:38:02 +0000 (08:38 -0400)]
Pass alphaType to append_gamut_transform() to inform the clamp
BUG=skia:
Change-Id: I1a8aef36043d4091bffae95b0275fa7fa8a35c97
Reviewed-on: https://skia-review.googlesource.com/9441
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Robert Phillips [Thu, 11 May 2017 20:29:14 +0000 (16:29 -0400)]
Split up opLists (take 3)
Reland of: https://skia-review.googlesource.com/c/11581/ (Split up opLists)
https://skia-review.googlesource.com/c/13860/ (Make InstancedRendering more opList-splitting friendly) has landed so this should be good for another attempt.
TBR=egdaniel@google.com
Change-Id: I2a09729342bb035af3a16807c1895adbae432ade
Reviewed-on: https://skia-review.googlesource.com/14186
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Mike Klein [Thu, 11 May 2017 14:59:22 +0000 (10:59 -0400)]
refactor gradient stage names
This is just a name refactor and I'm happy to delay it until we're done
with the current wave of gradient CLs. The main ideas:
- we use the "linear_gradient" stages for all gradients,
so cut the "linear" and just call them "gradient";
- remind ourselves that the 2-stop stage requires even spacing, i.e.
stops at 0 and 1. This name should harmonize with Herb's new
general evenly spaced gradient stage, currently
"evenly_spaced_linear_gradient", and after it lands and I rebase,
"evenly_spaced_gradient"
- remind ourselves which polar coordinate xy_to_polar_unit returns,
the angle.
Change-Id: I0fd0c8bd4c1ead7d2d0fff45a199d318b71f34ac
Reviewed-on: https://skia-review.googlesource.com/16500
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Mike Klein [Fri, 12 May 2017 10:28:23 +0000 (10:28 +0000)]
Revert "Evenly space gradient stage."
This reverts commit
892501d09bc8608704362235c73a59bb23a386b3.
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=721682
:(
Original change's description:
> Evenly space gradient stage.
>
> This seems like an experiment at this point because I don't know how to do
> this kind of thing on arm.
>
>
> Numbers from Skylake...
> Before:
> ./out/Release/nanobench --config srgb \
> --match gradient_linear_clamp_3color gradient_linear_clamp_hicolor -q 19:48:13
> Timer overhead: 36.7ns
> ! -> high variance, ? -> moderate variance
> micros bench
> 439.92 ? gradient_linear_clamp_3color srgb
> 2697.60 gradient_linear_clamp_hicolor srgb
> 437.28 gradient_linear_clamp_3color_4f srgb
> 2700.50 gradient_linear_clamp_hicolor_4f srgb
>
>
> After:
> micros bench
> 382.35 gradient_linear_clamp_3color srgb
> 593.49 gradient_linear_clamp_hicolor srgb
> 382.36 gradient_linear_clamp_3color_4f srgb
> 565.60 gradient_linear_clamp_hicolor_4f srgb
>
>
> Numbers on my Mac Trashcan are about even; there is no
> speedup or slowdown between master and this change.
>
> Change-Id: I04402452e23c0888512362fd1d6d5436cea61719
> Reviewed-on: https://skia-review.googlesource.com/15960
> Commit-Queue: Herb Derby <herb@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
>
TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,fmalita@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Ic6a064c66686b6f238ca1417ba1abd9ce25de1b4
Reviewed-on: https://skia-review.googlesource.com/16660
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
recipe-roller [Fri, 12 May 2017 09:46:11 +0000 (02:46 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
4a09f3ac6e9f77d658391ef453268e60bb1eb7e8 [blink] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
1139918caaae11841321d01831603fad3342e3fc [libvpx] convert recipes and module to new context module (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e8e7dac4453c4efdd1c87e7ab3a5135ef3631d6
Reviewed-on: https://skia-review.googlesource.com/16618
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 09:16:21 +0000 (02:16 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
d0f7d38dcd39fe6572a1bd537cb25c2a3e9db99e [goma] convert recipes and module to new context module (iannucci@chromium.org)
https://crrev.com/
593bde85c8c149ef21e534eafe0262ebebe51e94 [webrtc] convert recipes and module to new context module. (iannucci@chromium.org)
https://crrev.com/
bbec7414daccae917fe324507fa8da37f0bce0cb [art] convert recipes and module to new context module (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If32cd5275ba0a156b4571b33572f31b8459af788
Reviewed-on: https://skia-review.googlesource.com/16617
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 08:51:27 +0000 (01:51 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
6f2b5e64048fafd0068322630faaf5d4260047b5 [v8] convert recipes and module to new context module. (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie41a730163b97fea48e0426635ad074c474c36c8
Reviewed-on: https://skia-review.googlesource.com/16615
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 07:51:47 +0000 (00:51 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
0e4aca1b687f97b725e8123c8c9708aa3b0aba48 Removes unnecessary steps from the chromium codesearch recipe (emso@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I65c5d2724e3a76fd979b9b3b0209472e7249d668
Reviewed-on: https://skia-review.googlesource.com/16614
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 07:01:26 +0000 (00:01 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
bdd12ab5df9a829df417e4b769094367ea998d68 Revert "Temporarily disable LocalOutputCache on Win." (shinyak@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I749992923ade4ee40d733759d4ed9feeb708c750
Reviewed-on: https://skia-review.googlesource.com/16613
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Fri, 12 May 2017 01:01:41 +0000 (18:01 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
0a78b954c6399edf1b28629b70daaf6e6c112005 CrOS: Update Chromite pin. (vadimsh@chromium.org)
recipe_engine:
https://crrev.com/
b7c18e0258998652eeb302c83680f6a2b1aee398 Revert of include Package proto into Result proto (patchset #3 id:40001 of https://codereview.chromium.org/
2802693003/ ) (iannucci@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib0a2effefd7ea6d2078655753157056a4e635d90
Reviewed-on: https://skia-review.googlesource.com/16612
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Thu, 11 May 2017 23:02:22 +0000 (16:02 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
ea19db587abdde3ec807a1aa2ceb3192adc0f7ab Fix typo in boringssl.py. (davidben@chromium.org)
recipe_engine:
https://crrev.com/
c7d91ef9861b04e41c6a2381382efd58d111fe19 include Package proto into Result proto (nodir@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7608cb4a54f723b518d9337ae1e7baf99cfa7fdd
Reviewed-on: https://skia-review.googlesource.com/16610
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Thu, 11 May 2017 22:31:24 +0000 (15:31 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/
6eaacf24833ebd2565177157d368da33780fced9 Fix repeated test 'mkdir' failure. (dnj@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e4b3713fcb28ea0f6a7daf9e5d340fa75d04df2
Reviewed-on: https://skia-review.googlesource.com/16608
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Matt Sarett [Thu, 11 May 2017 21:39:04 +0000 (17:39 -0400)]
Fix Ubuntu-Clang-x86_64-Release-Mini
Bug: skia:
Change-Id: Iab3dbb007ae67b5d82a727cb1fd5ced6b10b325a
Reviewed-on: https://skia-review.googlesource.com/16605
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
recipe-roller [Thu, 11 May 2017 21:30:42 +0000 (14:30 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
209fcf66599d43c99e30accc1a0fe68beae2b8bd Add builders using Intel SDE. (davidben@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22d48b1c5e1219eb5066c4ebead30a1aa1de3db8
Reviewed-on: https://skia-review.googlesource.com/16604
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Jim Van Verth [Thu, 11 May 2017 21:05:28 +0000 (17:05 -0400)]
Classify spot shadows for general shapes
Add some simple checks so we can tell whether a shadow's umbra is
completely covered by the occluder, partially covered, or less than
halfway covered.
Change-Id: I092281c4933bd0380946eb0fdd458ce04b0d713c
Reviewed-on: https://skia-review.googlesource.com/16603
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
recipe-roller [Thu, 11 May 2017 21:01:48 +0000 (14:01 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
b4752f890fef774c4d475bae30a1122507546251 Add a Win x64 PGO trybot. (sebmarchand@chromium.org)
https://crrev.com/
f0ba992bb8257ead236458f48f99f09119da7bda Use cronet-sheriff mailing list for Cronet bots in gatekeeper.json (xunjieli@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifdbd0cf3c2f0cc8fede1073e97955b37cb40c4cb
Reviewed-on: https://skia-review.googlesource.com/16602
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
herb [Thu, 11 May 2017 20:54:23 +0000 (16:54 -0400)]
Evenly space gradient stage.
This seems like an experiment at this point because I don't know how to do
this kind of thing on arm.
Numbers from Skylake...
Before:
./out/Release/nanobench --config srgb \
--match gradient_linear_clamp_3color gradient_linear_clamp_hicolor -q 19:48:13
Timer overhead: 36.7ns
! -> high variance, ? -> moderate variance
micros bench
439.92 ? gradient_linear_clamp_3color srgb
2697.60 gradient_linear_clamp_hicolor srgb
437.28 gradient_linear_clamp_3color_4f srgb
2700.50 gradient_linear_clamp_hicolor_4f srgb
After:
micros bench
382.35 gradient_linear_clamp_3color srgb
593.49 gradient_linear_clamp_hicolor srgb
382.36 gradient_linear_clamp_3color_4f srgb
565.60 gradient_linear_clamp_hicolor_4f srgb
Numbers on my Mac Trashcan are about even; there is no
speedup or slowdown between master and this change.
Change-Id: I04402452e23c0888512362fd1d6d5436cea61719
Reviewed-on: https://skia-review.googlesource.com/15960
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
recipe-roller [Thu, 11 May 2017 19:40:38 +0000 (12:40 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/
a4b6b3066ce93c6ea56e95cde90b4c538645362c [chromedriver] update to new context module (iannucci@chromium.org)
https://crrev.com/
692e5e81777e69875d2c6c35d7bf6edd2b03b0ce chromium_tests: make it possible to use custom servers for isolate and swarming (phajdan.jr@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iec8428e2e1a2dbdf543f39ff2744d45665c6b595
Reviewed-on: https://skia-review.googlesource.com/16549
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Mike Klein [Thu, 11 May 2017 19:29:31 +0000 (15:29 -0400)]
proposed: inclusive gradients, exclusive images
Change-Id: I5821f823a4c0df54d4388a2f455767f58ae646b8
Reviewed-on: https://skia-review.googlesource.com/16547
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Thu, 11 May 2017 15:29:29 +0000 (11:29 -0400)]
spin off: always clamp linear gradients
While we're refactoring how gradients work it's going to be easier
to centralized how and when we tile.
- PS2 changed linear and radial in place to alwys clamp.
- PS3 moved tiling to the base class, where it's even harder to
screw up. Sweeps don't need but don't mind tiling.
- PS4 clamps when iff evenly spaced
PS4 has image diffs for only a few GMs that I'm not familiar with.
If its logic reads as correct to you, they may be bug fixes?
Change-Id: I5e37d6e88aaea898356d4c57db0cd5bf414c0295
Reviewed-on: https://skia-review.googlesource.com/16501
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>