Samuel Iglesias Gonsálvez [Thu, 15 Jul 2021 09:15:32 +0000 (11:15 +0200)]
dEQP-VK.subgroups.*ray_tracing* missing extension check
Components: Vulkan
VK-GL-CTS issue: 3003
Affected:
dEQP-VK.subgroups.*ray_tracing*
Change-Id: I25719d00c6d0180c03726d73497727754f9539d2
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Ari Suonpaa [Wed, 4 Aug 2021 10:12:38 +0000 (13:12 +0300)]
Re-enable protected memory tests
AHB protected memory tests were previously removed due to
validation errors. This change adds them back while also
fixing the errors.
VK-GL-CTS Issue: 3030
Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.*
Components: Vulkan
Change-Id: I0ba4809eec82b069d9f36b624c65c7fe7f8df7a3
Ricardo Garcia [Mon, 2 Aug 2021 08:17:26 +0000 (10:17 +0200)]
Depth/Stencil descriptor tests
New set of tests that try to use depth/stencil images as descriptors
and/or as read-only attachments with using layouts that were previously
not covered by other CTS tests.
New tests:
dEQP-VK.image.depth_stencil_descriptor.*
Components: Vulkan
VK-GL-CTS issue: 2925
Change-Id: I00e022afb0b7bc9561e938e3c35a026d8ade2ca9
Piotr Byszewski [Thu, 14 Jan 2021 11:35:59 +0000 (12:35 +0100)]
Test multiview with different depth ranges
This change extends existing tests to also cover creation of
viewports with different depth ranges, and maked sure that
depth clipping/clamping works correctly across the different
viewports.
Issue raported by layers in existing tests were also fixed.
Components: Vulkan
VK-GL-CTS issue: 2500
Affects:
dEQP-VK.multiview.*
New tests:
dEQP-VK.multiview.depth_different_ranges.3_6_12_9_6_12_9_3_6_12_9_3
dEQP-VK.multiview.renderpass2.depth_different_ranges.3_6_12_9_6_12_9_3_6_12_9_3
Change-Id: I0085eeda3aac2e36ab7013bf5a83009ce9ea94b9
Matthew Netsch [Fri, 17 Sep 2021 19:40:57 +0000 (15:40 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master
Change-Id: Ib651fa8492c869d02b1185442b1a7ed431a2b7c6
Matthew Netsch [Fri, 17 Sep 2021 18:11:27 +0000 (14:11 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I0e58f89d8cfdfaaa400f700ea87882cb281f080f
Matthew Netsch [Fri, 17 Sep 2021 15:57:13 +0000 (11:57 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I2d3ee8a323e62c13c9f3e5ff499ff3614c802b29
Matthew Netsch [Fri, 17 Sep 2021 15:56:59 +0000 (11:56 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I521f0b1f6f4c3a86e8612239ce2134be76e5d16a
Matthew Netsch [Fri, 17 Sep 2021 15:56:48 +0000 (11:56 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: Ic1ab6043f9d70b8491192137c6d8c2fc12f2112d
root [Thu, 16 Sep 2021 17:41:53 +0000 (13:41 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master
Change-Id: I09891e0da9f54df761a1d22474d04ac0ae5fe498
root [Thu, 16 Sep 2021 17:41:40 +0000 (13:41 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I7bd0d85348a194cda0ec5922fa93a2cb5dd02e19
Piotr Byszewski [Tue, 1 Jun 2021 12:04:26 +0000 (14:04 +0200)]
Test blitting from ASTC formats
This change extends existing tests to also test blitting of all
ASTC compressed formats onto all compatible uncompressed formats.
VK-GL-CTS issue: 2366
Components: Vulkan
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.astc*
Change-Id: I62a9fcf056c9468f02ee0999734f6d1b5a438beb
Graeme Leese [Tue, 7 Sep 2021 12:55:40 +0000 (13:55 +0100)]
Fix workgroup memory tests for int16s
Most of these tests were fixed to request the correct features in
634882efd17, but the int16 and uin16 variants still didn't request the
shaderInt16 feature.
Components: Vulkan
Affects: dEQP-VK.spirv_assembly.instruction.compute.workgroup_memory.int16
dEQP-VK.spirv_assembly.instruction.compute.workgroup_memory.uint16
Change-Id: If848202fc96bd191d67be3d11cb09b7890f936d7
Ari Suonpaa [Thu, 26 Aug 2021 04:49:37 +0000 (07:49 +0300)]
Check support for EGL 1.5 or higher when using GLES3
Layered AHB tests are using GLES3 tests, but the
check for a required EGL version supporting that
was missing. Now these tests throw not supported when
the EGL version is below 1.5.
VK-GL-CTS Issue: 3076
Affects:
dEQP-EGL.functional.image.*android_native_array*
Components: EGL
Change-Id: I4e79e8447ec6a3a243b30ab1f64dbb00a4fa4e96
Graeme Leese [Fri, 27 Aug 2021 12:46:19 +0000 (13:46 +0100)]
Accept NaN as valid in atan2 precision tests
The Vulkan CTS has been updated
(https://gerrit.khronos.org/c/vk-gl-cts/+/7857) so that it is not
required to generate correct results for atan(inf, inf), and this makes
the corresponding change in GL. The GLSL spec is not as clear on what is
required here, but does say:
Built-in functions not listed above and not defined as equations of
the above have undefined precision. These include, for example, the
trigonometric functions
In general, I think that it is expected that the default state of Vulkan
is a match for GL.
Components: OpenGL
VK-GL-CTS issue: 3073
Affects: dEQP-GLES3.functional.shaders.builtin_functions.precision.atan2.highp_*
Change-Id: Ifae97a2e86962f5aff68d5eed09ba38069445468
Peter Kohaut [Fri, 10 Sep 2021 13:56:09 +0000 (15:56 +0200)]
Update Vulkan headers
Components: Vulkan
Change-Id: I1fc2ec802183e2a1efb50915b66bae7422730f8d
Stuart Brady [Tue, 19 Jan 2021 14:19:40 +0000 (14:19 +0000)]
Add tests for VK_KHR_shader_integer_dot_product
Components: Vulkan, Framework
VK-GL-CTS issue: 2729
New tests:
dEQP-VK.spirv_assembly.instruction.compute.opsdotkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opudotkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opsudotkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opsdotaccsatkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opudotaccsatkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opsudotaccsatkhr.*
Affects:
dEQP-VK.api.info.get_physical_device_properties2.features
dEQP-VK.api.info.get_physical_device_properties2.properties
Signed-off-by: Stuart Brady <stuart.brady@arm.com>
Signed-off-by: Pablo Cascón <pablo.cascon@arm.com>
Signed-off-by: Neil Hickey <neil.hickey@arm.com>
Change-Id: Ia618d9eb33369e72eedc5845342e17e1ee12da3a
(cherry picked from commit
12d5b5fe34a4cde919e1d9d3949154bf33ef21f2)
Boris Zanin [Wed, 17 Mar 2021 11:27:26 +0000 (12:27 +0100)]
Fulfill OpControlBarrier requirement
The valid usage requirement in vulkan specification 1.2.170
VUID-StandaloneSpirv-None-04641 requires: "If the Scope for
memory is Invocation, then memory semantics must be None".
New SPIRV-Tools enforces it.
Fix tests:
* dEQP-VK.spirv_assembly.instruction.graphics.barrier.in_function
* dEQP-VK.spirv_assembly.instruction.graphics.barrier.in_switch
* dEQP-VK.spirv_assembly.instruction.graphics.barrier.in_if
* dEQP-VK.spirv_assembly.instruction.graphics.barrier.after_divergent_if
* dEQP-VK.spirv_assembly.instruction.graphics.barrier.in_loop
Update tests:
* dEQP-VK.spirv_assembly.instruction.graphics.barrier.*
Components: Vulkan
Change-Id: Ie6997fdb36c0327d88a2b7b6b4826dfee690377d
Mika Väinölä [Tue, 7 Sep 2021 14:24:14 +0000 (17:24 +0300)]
Fix Clang -Wcomma warnings
Replace commas that were most likely intended to be semicolons
instead.
Components: Vulkan, OpenGL ES
VK-GL-CTS issue: 3097
Change-Id: I106292084a12db1517da33c26a88df5232ea33fd
Mika Väinölä [Tue, 7 Sep 2021 13:12:03 +0000 (16:12 +0300)]
Fix qpReleaseInfo generation with non-ASCII paths
On Windows CMake fails to generate qpReleaseInfo.inl if DE_GIT_DIR is a
path with non-ASCII characters. Specify ENCODING UTF8 for git output.
Components: Framework
VK-GL-CTS issue: 3096
Change-Id: I8368ba5e2670b723471e2d7a7beec1f11376c49f
Ari Suonpaa [Wed, 30 Jun 2021 22:11:44 +0000 (01:11 +0300)]
Add tests for VK_EXT_load_store_op_none
VK-GL-CTS Issue: 2971
New tests:
dEQP-VK.renderpass*.load_store_op_none.*
Components: Vulkan
Change-Id: If3eb79e75b14f96037d14fcaa469230d3434a729
(cherry picked from commit
b0025b814cad4fd699761578eaec575fe76f7f75)
Ilkka Saarelainen [Tue, 7 Sep 2021 13:03:46 +0000 (16:03 +0300)]
Remove invalid SPIR-V decorations
Some SPIR-V asm tests used invalid Binding and DescriptorSet decorations.
This CL removes those decorations.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.physical_pointers.complex_types_compute.*
dEQP-VK.spirv_assembly.instruction.compute.pointer_parameter.buffer_memory
dEQP-VK.spirv_assembly.instruction.graphics.pointer_parameter.buffer_memory*
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_float_16_to_16x2.scalar
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_float_16_to_16x2.vec2
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.scalar_int
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.scalar_uint
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.ivec2
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.uvec2
Components: Vulkan
VK-GL-CTS issue: 3063
Change-Id: Icfee33f9ce041bf60a19fba55aef9fdab0747148
Peter Kohaut [Tue, 7 Sep 2021 16:42:49 +0000 (18:42 +0200)]
Merge branch 'vulkan-cts-1.2.7'
Change-Id: I206c4059e348c7163a597e47e76a2146e23d7fbc
Peter Kohaut [Tue, 7 Sep 2021 16:40:35 +0000 (18:40 +0200)]
Merge branch 'vulkan-cts-1.2.6' into vulkan-cts-1.2.7
Change-Id: Iec55ddd12f12935ab70d00af5841a8b22f9a3c89
Stuart Brady [Tue, 19 Jan 2021 14:19:40 +0000 (14:19 +0000)]
Add tests for VK_KHR_shader_integer_dot_product
Components: Vulkan, Framework
VK-GL-CTS issue: 2729
New tests:
dEQP-VK.spirv_assembly.instruction.compute.opsdotkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opudotkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opsudotkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opsdotaccsatkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opudotaccsatkhr.*
dEQP-VK.spirv_assembly.instruction.compute.opsudotaccsatkhr.*
Affects:
dEQP-VK.api.info.get_physical_device_properties2.features
dEQP-VK.api.info.get_physical_device_properties2.properties
Signed-off-by: Stuart Brady <stuart.brady@arm.com>
Signed-off-by: Pablo Cascón <pablo.cascon@arm.com>
Signed-off-by: Neil Hickey <neil.hickey@arm.com>
Change-Id: Ia618d9eb33369e72eedc5845342e17e1ee12da3a
Matthew Netsch [Tue, 22 Dec 2020 19:40:32 +0000 (01:10 +0530)]
Allow GL_RGB9_E5 as a valid fbo format
If GL_QCOM_render_shared_exponent is available then treat
GL_RGB9_E5 as a valid internal format for fbo. Also, allow
copy of RGB9_E5 pixel data.
Components: OpenGL
VK-GL-CTS Issue: 2898
Affects:
KHR-GLES3.packed_pixels.rectangle.rgb9_e5
KHR-GLES3.packed_pixels.pbo_rectangle.rgb9_e5
KHR-GLES3.packed_pixels.varied_rectangle.rgb9_e5
Change-Id: Ie57d74b9bbd11cf7ccca175813077c22405a0926
(cherry picked from commit
db8e2899b1f0ab4677aa24af6fad4119f5fe1fa2)
Peter Kohaut [Fri, 3 Sep 2021 12:11:08 +0000 (14:11 +0200)]
Merge branch 'vulkan-cts-1.2.7'
Change-Id: I0034a268b5c4dd313953bf4cd8b6511fd3b5635e
Mika Väinölä [Tue, 24 Aug 2021 10:51:42 +0000 (13:51 +0300)]
Remove unreachable breaks
Fix warnings for Clang builds with -Wunreachable-code-break.
Components: Framework, OpenGL, OpenGL ES, Vulkan
VK-GL-CTS issue: 3074
Change-Id: Ib658e631bad3d06d787c6151f744e8db3e850fb4
Mohankumar Nekkarakalaya [Thu, 19 Aug 2021 19:05:36 +0000 (12:05 -0700)]
Add GL_RGB9_E5 as renderable ext format in fbo tests
-If GL_QCOM_render_shared_exponent is supported then treat
GL_RGB9_E5 as a renderable format for fbo completeness tests
Components: OpenGL
VK-GL-CTS Issue: 3066
Affects:
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb9_e5
dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.rgb9_e5
Change-Id: I74566a5b56c7528c89ac97423c5b6f9207397c70
(cherry picked from commit
d18b37f7319839e2be970a96fecdeb2cdb1db7e4)
Antto Mäkinen [Fri, 4 Jun 2021 12:15:17 +0000 (15:15 +0300)]
Add a batch of GraphicsFuzz coverage tests
This commit adds a batch of GraphicsFuzz coverage tests.
The tests have been separated by a request.
Components: Vulkan
New Tests:
dEQP-VK.graphicsfuzz.cov-dfdx-dfdy-after-nested-loops
dEQP-VK.graphicsfuzz.cov-nested-loops-float-array-select-by-fragcoord
dEQP-VK.graphicsfuzz.cov-nested-loops-set-struct-data-verify-in-function
Change-Id: I33b01c2f14318fb65b1f895eea89433828c82d51
Peter Kohaut [Fri, 3 Sep 2021 11:11:48 +0000 (13:11 +0200)]
Merge branch 'vulkan-cts-1.2.6' into vulkan-cts-1.2.7
Change-Id: I5d1960f36c445e344a36442d03b7a71a50732038
Mika Väinölä [Tue, 10 Aug 2021 05:55:03 +0000 (08:55 +0300)]
Fix GLES3 Clang UBSan errors
Fix or avoid runtime errors detected by Clang's undefined behavior
sanitizer in the GLES3 module.
Affected tests:
dEQP-GLES3.functional.shaders.operator.unary_operator.minus.*
dEQP-GLES3.functional.fragment_out.basic.*
dEQP-GLES3.functional.texture.filtering.2d.formats.*
Components: OpenGL ES, Framework
VK-GL-CTS issue: 3018
Change-Id: Ic10ae433deb2f835ceb2fe3ab9664b05f72cd3d0
Peter Kohaut [Fri, 3 Sep 2021 10:20:36 +0000 (12:20 +0200)]
Merge branch 'vulkan-cts-1.2.5' into vulkan-cts-1.2.6
Change-Id: Ia705e141206a3751d4abc2d6eccd958d7e3f2f0e
Peter Kohaut [Fri, 3 Sep 2021 07:33:02 +0000 (09:33 +0200)]
Merge branch 'vulkan-cts-1.2.4' into vulkan-cts-1.2.5
Change-Id: I952af5b744206c52b4161d8c1102b6a8c2a53f58
Peter Kohaut [Thu, 2 Sep 2021 20:22:53 +0000 (22:22 +0200)]
Merge branch 'vulkan-cts-1.2.3' into vulkan-cts-1.2.4
Change-Id: Ica9ea69514cd36415ad89f4b34e8384b0523181c
Peter Kohaut [Thu, 2 Sep 2021 17:05:54 +0000 (19:05 +0200)]
Merge remote-tracking branch 'origin/vulkan-cts-1.2.2' into vulkan-cts-1.2.3
Change-Id: I3c5b289149d9f2601b5d5ab8986d41b3f33f8bab
Antto Mäkinen [Mon, 30 Aug 2021 09:55:27 +0000 (12:55 +0300)]
Add a batch of GraphicsFuzz coverage tests
This commit adds a batch of GraphicsFuzz coverage tests.
Components: Vulkan
New Tests:
dEQP-VK.graphicsfuzz.cov-condition-bitfield-extract-integer
dEQP-VK.graphicsfuzz.cov-condition-matrix-determinant-uniform
dEQP-VK.graphicsfuzz.cov-descending-loop-index-temporary-array
dEQP-VK.graphicsfuzz.cov-do-while-switch-case-bitcount-findmsb
dEQP-VK.graphicsfuzz.cov-dummy-function-loop-array-element-increment-never-read
dEQP-VK.graphicsfuzz.cov-fragcood-multiple-conditions-function-loop-global-counter
dEQP-VK.graphicsfuzz.cov-fragcoord-multiple-conditions-function-global-loop-counter-simplified
dEQP-VK.graphicsfuzz.cov-function-nested-do-whiles-looped-once
dEQP-VK.graphicsfuzz.cov-int-initialize-from-multiple-large-arrays
dEQP-VK.graphicsfuzz.cov-loop-break-after-first-iteration-set-array-element
dEQP-VK.graphicsfuzz.cov-loop-condition-bitfield-extract-set-array-elements
dEQP-VK.graphicsfuzz.cov-loop-condition-logical-or-never-iterated
dEQP-VK.graphicsfuzz.cov-loop-fragcoord-identical-condition
dEQP-VK.graphicsfuzz.cov-loop-set-vector-components-pow-two
dEQP-VK.graphicsfuzz.cov-multiple-fragcoord-conditions-false-never-return-sample-texture
dEQP-VK.graphicsfuzz.cov-multiple-fragcoord-conditions-never-return-color-uninitialized
dEQP-VK.graphicsfuzz.cov-nested-loop-continue-inner-copy-array-element
dEQP-VK.graphicsfuzz.cov-nested-loop-not-greater-than-increment-array-element
dEQP-VK.graphicsfuzz.cov-nested-loops-float-bits-to-int-increment-array
dEQP-VK.graphicsfuzz.cov-nested-loops-global-counter-increment-single-element
dEQP-VK.graphicsfuzz.cov-nested-loops-sample-opposite-corners
dEQP-VK.graphicsfuzz.cov-two-nested-loops-switch-case-matrix-array-increment
Change-Id: Ia02cb23ec103be95184ad65da475d8b95a8d8504
Juha Heiskanen [Fri, 27 Aug 2021 09:58:24 +0000 (12:58 +0300)]
Add test for finding unknown memory property flag sets
This test retrieves all the found propertyFlags from available memory
types, and then it makes a comparison between the found memory
propertyFlags and the acceptable propertyFlag sets. If an unknown
combination of memory propertyFlags is found, the test will fail.
Components: Vulkan
VK-GL-CTS Issue: 2704
New tests: dEQP-VK.memory.requirements.memory_property_flags.check_all
Change-Id: I9c456076bb7364572183ca4976f56775ffd5e286
Mika Väinölä [Tue, 31 Aug 2021 11:56:16 +0000 (14:56 +0300)]
Fix loop over cube map faces in GL4
Found when building with Clang with -Wunreachable-code-loop-increment
enabled. TextureViewUtilities::initTextureStorage is supposed to call
glTexImage2D for all cube map faces but stops after the first one
(GL_TEXTURE_CUBE_MAP_POSITIVE_X).
Affects:
KHR-GL4*.texture_view.gettexparameter
KHR-GL4*.texture_view.errors
Components: OpenGL
VK-GL-CTS issue: 3085
Change-Id: I3d85351ab50ad0bd8b779537b1a8b3bef162f80f
Lionel Landwerlin [Thu, 26 Aug 2021 11:42:53 +0000 (14:42 +0300)]
Fix fragment shading rate validation layer warning
We passing a number of layer > 1 for an image view type of
VK_IMAGE_VIEW_TYPE_2D.
Also if we're not using ATTACHMENT_MODE_2DARRAY, then there is only
one layer for the fragment rate shading attachment, so we should check
against layer 0.
Components: Vulkan
Affects:
dEQP-VK.fragment_shading_rate.srlayered.*
VK-GL-CTS issue: 3079
Change-Id: I351f880a9bdd934f773e517713839c67ad453766
Jari Komppa [Fri, 13 Aug 2021 10:10:49 +0000 (13:10 +0300)]
Add run mode that verifies amber requirements
This change adds a new run mode that verifies that .amber file
requirements match the ones defined in CTS.
Running CTS with --deqp-runmode=amber-verify goes through all
amber test cases and outputs any mismatches in the log file.
If any mismatches are found, the run ends with internal_error.
This change also contains fixes for all of the mismatches
that exist in CTS today. A couple required update in Amber,
and thus this change also updates it.
Affects:
dEQP-VK.compute.workgroup_memory_explicit_layout.copy_memory.variable_pointers
dEQP-VK.spirv_assembly.instruction.spirv1p4.*
dEQP-VK.spirv_assembly.instruction.terminate_invocation.*
Components: Vulkan, Framework
VK-GL-CTS issue: 2967
Change-Id: Ic30b5d555d9cdf293a2ece8a690a4a2a943b1b80
Mika Väinölä [Thu, 26 Aug 2021 14:10:28 +0000 (17:10 +0300)]
Remove extra semicolons
Fix warnings for Clang builds with -Wextra-semi, -Wextra-semi-stmt and
-Wc++98-compat-extra-semi.
Components: Framework, OpenGL, OpenGL ES, Vulkan
VK-GL-CTS issue: 3080
Change-Id: I1caa81b65415a1e94797c6df48fc8a4539e9635a
Graeme Leese [Fri, 23 Jul 2021 18:00:11 +0000 (19:00 +0100)]
Fix warning in gcc-8
The code for setting up the output buffer was duplicated into each of
the cases for different input types, and the compiler doesn't understand
that DE_ASSERT marks an unreachable path. Changing to using standard
assert fixes the warning:
vktShaderFConvertTests.cpp:541:19: error: ‘outputBufferSizeInfo::memorySizeBytes’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
541 | BufferSizeInfo outputBufferSizeInfo;
| ^~~~~~~~~~~~~~~~~~~~
Component: Vulkan
Affects: dEQP-VK.glsl.builtin.precision_fconvert.*
Change-Id: Icf6302166d8bce7c3ae1447973c895c34465a726
Juha Heiskanen [Fri, 30 Jul 2021 09:10:16 +0000 (12:10 +0300)]
Enable Vulkan matrix determinant and inverse precision tests
A set of new matrix3x3/matrix4x4 determinant and inverse precision
tests for Amber.
Components: Vulkan
VK-GL-CTS Issue: 2878
New tests:
dEQP-VK.glsl.builtin.precision.determinant.highp.mat3
dEQP-VK.glsl.builtin.precision.inverse.highp.mat3
dEQP-VK.glsl.builtin.precision_fp16_storage16b.determinant.compute.mat3
dEQP-VK.glsl.builtin.precision_fp16_storage16b.inverse.compute.mat3
dEQP-VK.glsl.builtin.precision_fp16_storage32b.determinant.compute.mat3
dEQP-VK.glsl.builtin.precision_fp16_storage32b.inverse.compute.mat3
dEQP-VK.glsl.builtin.precision_double.determinant.compute.mat3
dEQP-VK.glsl.builtin.precision_double.inverse.compute.mat3
dEQP-VK.glsl.builtin.precision.determinant.highp.mat4
dEQP-VK.glsl.builtin.precision.inverse.highp.mat4
dEQP-VK.glsl.builtin.precision_fp16_storage16b.determinant.compute.mat4
dEQP-VK.glsl.builtin.precision_fp16_storage16b.inverse.compute.mat4
dEQP-VK.glsl.builtin.precision_fp16_storage32b.determinant.compute.mat4
dEQP-VK.glsl.builtin.precision_fp16_storage32b.inverse.compute.mat4
dEQP-VK.glsl.builtin.precision_double.determinant.compute.mat4
dEQP-VK.glsl.builtin.precision_double.inverse.compute.mat4
Change-Id: I5d748c1ecbaf4e8444a2d09eac8da60bfa54271c
Alex Walters [Thu, 12 Aug 2021 13:12:55 +0000 (14:12 +0100)]
Correct Vulkan multiview 'tesellation' test names
Tests are renamed from 'tesellation' to 'tessellation' but are otherwise
unchanged.
Affects:
dEQP-VK.multiview*tessellation*
Components: Vulkan
Change-Id: I1686bb6fb8a0e85e201853602f840e03e847169d
Juan A. Suarez Romero [Wed, 18 Aug 2021 11:01:15 +0000 (13:01 +0200)]
Do not overflow when copy data
As `vertexDataSize` is aligned with `nonCoherentAtomSize`, it could be
bigger than the actual size of m_data.
This is actually causing a heap-buffer overflow when executing in our
Rpi4 Vulkan driver.
Affected tests:
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.flat
Components: Vulkan
VK-GL-CTS issue: 3062
Change-Id: I6b1f449e9f0a42740adb051ed037ff911dac763a
Mike Byrne [Mon, 9 Aug 2021 11:40:07 +0000 (12:40 +0100)]
Fix protected memory ssbo pipeline barrier use
Incorrect stage flags are passed to vkCmdPipelineBarrier in the copy
buffer operation in the dEQP-VK.protected_memory.ssbo.ssbo_read.*
These tests were introduced in origin/vulkan-cts-1.1.0
Components: Vulkan
Affects:
dEQP-VK.protected_memory.ssbo.*
VK-GL-CTS Issue: 3041
Change-Id: Iccdb96fee30e32bf26dec1e26d65ea8d5600c384
Connor Abbott [Fri, 13 Aug 2021 15:37:54 +0000 (17:37 +0200)]
Don't alias image views in separate_channels subpass dependency tests
This is not allowed by the Vulkan spec:
> Multiple attachments that alias the same memory must not be used in a
> single subpass.
Instead we should have the input attachment and color attachment point
to the same attachment, which is allowed.
Components: Vulkan
Affects:
dEQP-VK.renderpass.suballocation.subpass_dependencies.separate_channels.*
dEQP-VK.renderpass2.suballocation.subpass_dependencies.separate_channels.*
VK-GL-CTS Issue: 3052
Change-Id: Iddb1111be5147f9816104fa879e023a9a3445555
Neslisah Torosdagli [Thu, 29 Jul 2021 16:20:51 +0000 (12:20 -0400)]
Issue in serial storage address computation
When serial storage and src/dst buildTypes are different, serial storage address computation is not correct. In the beginning of the test case, serial storage buildType is either set to host or device according to test case being run (cpu-built or gpu-built).
In the 2nd phase of this test case (deserialize all from the previous step to a new top-level AS) VkCopyMemoryToAccelerationStructureInfoKHR is filled with srcAddress according to testCase buildType, and dst acceleration structure is device.
In this stage, if testCase builtType is device, the serialStorage address computation is correct. However, if testCase buildType is host then the issue arises. The address is computed according to host, although device address is needed.
That is, for serial storage address computation: buildType of the acceleration structure (src or dst) should be used rather than serial storage buildType which is initially set according to test case being run.
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.header_bottom_address.*
Components: Vulkan
VK-GL-CTS issue: 3028
Change-Id: If8c0387862ce6f1db00fc61016dd0e602ff72ba8
Antto Mäkinen [Wed, 12 May 2021 07:47:10 +0000 (10:47 +0300)]
Add coverage for sampling a cubemap that has been rendered to
This test checks that a cubemap will be sampled correctly if its
contents have been modified by a draw call.
VK-GL-CTS issue: 2506
New Tests:
dEQP-VK.image.sample_cubemap.write_face_0
Components: Vulkan
Change-Id: I1ee62842d6c952b5628822fe49ee6a91c26ead04
Alexander Galazin [Fri, 20 Aug 2021 12:20:33 +0000 (14:20 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master
Change-Id: Ieb90dde42cb20ab43cebd0f2b5d3ad4091c3b57a
Alexander Galazin [Fri, 20 Aug 2021 10:14:58 +0000 (12:14 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Ieaff21c7c6228a4507325afe13ec2a3807b345cb
John Anthony [Wed, 18 Aug 2021 20:16:53 +0000 (22:16 +0200)]
Add missing vertexPipelineStoresAndAtomics checks in ray query tests
Affected tests:
dEQP-VK.ray_query.acceleration_structures.*.vertex_shader.*
dEQP-VK.ray_query.acceleration_structures.*.tess_control_shader.*
dEQP-VK.ray_query.acceleration_structures.*.tess_evaluation_shader.*
dEQP-VK.ray_query.acceleration_structures.*.geometry_shader.*
dEQP-VK.ray_query.ray_flags.vertex_shader.*
dEQP-VK.ray_query.ray_flags.tess_control_shader.*
dEQP-VK.ray_query.ray_flags.tess_evaluation_shader.*
dEQP-VK.ray_query.ray_flags.geometry_shader.*
dEQP-VK.ray_query.traversal_control.vertex_shader.*
dEQP-VK.ray_query.traversal_control.tess_control_shader.*
dEQP-VK.ray_query.traversal_control.tess_evaluation_shader.*
dEQP-VK.ray_query.traversal_control.geometry_shader.*
Components: Vulkan
VK-GL-CTS Issue: 3069
Change-Id: I49c37d292380fda47b113bf4fa14a6395f8e81a5
Vihanakangas [Tue, 17 Aug 2021 11:14:46 +0000 (14:14 +0300)]
Check support in synchronization operation tests
Synchronization tests were creating pipelines before checking for support,
causing unnecessary use of CPU time when encountering an operation
later on that was not supported.
Affects:
dEQP-VK.synchronization.op.*
Components: Vulkan
VK-GL-CTS issue: 2731
Change-Id: Ia83afde4767ced1549a1b0573cdc9e8af8526870
Slawomir Cygan [Mon, 16 Aug 2021 16:04:21 +0000 (18:04 +0200)]
Read stencil aspect from image in DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL layout
The test was using sampler to read depth aspect from image in
combined depth+stencil format and in
VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL
layout - what is invalid.
Instead, the test now reads (and tests) stencil aspect of this
image. As the test code already supported testing stencil formats,
just a few conditions are changed/added to follow the stencil path
if VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL
is used.
VK-GL-CTS Issue: 3048
Components: Vulkan
Affects: dEQP-VK.synchronization2.none_stage.*
Change-Id: I918a5cdad83bcd25b2f8b6cee642b56218c2b7fe
Ilkka Saarelainen [Wed, 11 Aug 2021 12:00:37 +0000 (15:00 +0300)]
Optimize image clearing tests
This CL optimizes image clearing tests.
The tests did a lot redundant calculation for each pixel in the verify stage.
This CL moves those calculations to outside of the pixel verify function.
Affects:
dEQP-VK.api.image_clearing.*
Components: Vulkan
VK-GL-CTS issue: 2933
Change-Id: Ie3403c591c9f084115a13cc78e0a66c54c48817c
Vihanakangas [Thu, 5 Aug 2021 06:52:05 +0000 (09:52 +0300)]
Ensure that destroying old swapchain has no effect
There should be no crash when recreating Vulkan swapchain with
old swapchain and later calling vkDestroySwapchainKHR on old swapchain.
New tests:
dEQP-VK.wsi.*.swapchain.destroy.old_swapchain
Components: Vulkan
VK-GL-CTS issue: 2935
Change-Id: I7f03e55767ececec8a6a70ef553f0676d3a3c616
marz [Sun, 6 Jun 2021 20:46:56 +0000 (22:46 +0200)]
Conservative rasterization with SampleMask
Additional test coverage for conservative rasterization Conservative
rasterization used in conjunction with various multisampling setup
including FullyCoveredEXT built-in, minSampleShading, postDepthCoverage
and SampleMask.
Components: Vulkan
VK-GL-CTS issue: 2868
Affects:
dEQP-VK.pipeline.multisample.conservative_with_full_coverage.*
Change-Id: I8c2858b81cfdf27e622acf74e273db9014499c9c
Alexander Galazin [Wed, 18 Aug 2021 09:46:04 +0000 (11:46 +0200)]
Update Vulkan headers
Components: Vulkan
Change-Id: Iefdf1bc052c5f9c63bdf9062c01c96a4c11a92c6
Italo Nicola [Tue, 27 Jul 2021 08:26:47 +0000 (05:26 -0300)]
Implement getProcAddress for surfaceless platform
Currently this virtual function is not overridden, causing a crash
whenever a test calls getProcAddress in a surfaceless context.
Affects:
KHR-GL3{0,1,2}.transform_feedback.draw_xfb_instanced_test
KHR-GL3{0,1,2}.transform_feedback.draw_xfb_stream_instanced_test
Components: Framework
VK-GL-CTS issue: 3021
Change-Id: Idb29b5ca9d70c5f3be6a32fdf2c827d5d7591050
Tapani Pälli [Fri, 30 Jul 2021 11:54:09 +0000 (14:54 +0300)]
Fix for the various multisample tests with GL 4.5
Affects:
dEQP-GLES31.functional.shaders.sample_variables.*
dEQP-GLES31.functional.sample_shading.*
dEQP-GLES31.functional.shaders.multisample_interpolation.*
dEQP-GL45.functional.shaders.sample_variables.*
dEQP-GL45.functional.sample_shading.*
dEQP-GL45.functional.shaders.multisample_interpolation.*
Components: AOSP
VK-GL-CTS issue: 3014
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I6e4297a0558a31a1dc2258da7434d3fcc1900b73
Tapani Pälli [Thu, 29 Jul 2021 17:46:56 +0000 (20:46 +0300)]
Fix to multisample texture test shaders with GL 4.5
Affects:
dEQP-GL45.functional.texture.multisample.*
Components: AOSP
Issue: 3016
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: Icf29df0c1b8cb5306ebf4a9444c63d8e1afa2d7c
Tapani Pälli [Thu, 29 Jul 2021 17:30:04 +0000 (20:30 +0300)]
Fix for the common function tests with GL 4.5
Affects:
dEQP-GL45.functional.shaders.builtin_functions.common.*
Components: AOSP
VK-GL-CTS issue: 3015
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: Icf1343225a2dab84f70e2bc986f556c247454b4c
Ilkka Saarelainen [Thu, 12 Aug 2021 07:22:22 +0000 (10:22 +0300)]
Fix error in build_apk.py
A typo caused build_apk.py to fail if required Android build
tools were missing.
Components: framework
Change-Id: Ia55b95a9057a37152e5a4c91773b1eaa3abc0156
Lowry Li (Arm Technology China) [Wed, 11 Aug 2021 10:14:41 +0000 (18:14 +0800)]
Fix partial_image_npot_diff_format_clear fail
The tests added in
fffc9484834599de9eb5559205cec7cf0105379b /
VK-GL-CTS Issue: 2678 are missing a pipeline barrier between
the new clearing operation the following transfer operation
targeting the same resource.
Components: Vulkan
Affects:
dEQP-VK.api.copy_and_blit.*.image_to_image.simple_tests.
partial_image_npot_diff_format_clear
VK-GL-CTS issue: 3056
Change-Id: I3edf4d98e697e97c4b7934238cdbfc86f2d48632
Alexander Galazin [Thu, 5 Aug 2021 08:27:20 +0000 (10:27 +0200)]
Remove shaders.arrays from the Khronos mustpass
Components: OpenGL
VK-GL-CTS issue: 2540
Affects: KHR-GLES3.shaders.arrays.*
Change-Id: I291c26f1105bd72ca16e4057f23bb2188aed6dc4
Ilkka Saarelainen [Tue, 27 Jul 2021 11:31:06 +0000 (14:31 +0300)]
Fix Android system memory requirements
This CL changes how the available system memory is defined in Android.
The actual available system memory size is now used instead of
determining the available system memory by the CDD.
Affects:
dEQP-VK.api.buffer.suballocation.*
dEQP-VK.api.buffer.dedicated_alloc.*
dEQP-VK.api.object_management.*
dEQP-VK.memory.allocation.*
dEQP-VK.memory.device_group_allocation.*
dEQP-VK.pipeline.render_to_image.*.small.*
dEQP-VK.pipeline.render_to_image.*.huge.*
Components: Framework, Vulkan
VK-GL-CTS issue: 2621
Change-Id: I92fd157ec3928313ac92c29e6cbb3413c64a5096
Piotr Byszewski [Tue, 16 Feb 2021 14:57:44 +0000 (15:57 +0100)]
Test multiViewport with different depth ranges
This change extends existing tests to also cover creation of
viewports with different depth ranges, and make sure that
depth clipping/clamping works correctly across the different
viewports.
Components: Vulkan
VK-GL-CTS issue: 2500
Affects:
dEQP-VK.draw.depth_clamp.*
Change-Id: Ifa76daa1b53f04e48871a5efe07f5d3863066ca1
Piotr Byszewski [Thu, 22 Jul 2021 13:36:51 +0000 (15:36 +0200)]
Test OpImageQueryLod when fwidth(UV) == 0
Tests verify that lambda returned by OpImageQueryLod
is -22 or lower when fwidth(UV) == 0.
Components: Vulkan
VK-GL-CTS issue: 3027
Affets:
dEQP-VK.glsl.texture_functions.query.texturequerylod.*
Change-Id: I879024646c7a62d6cef7cb4b46a154b5e4750f36
Alexander Galazin [Fri, 13 Aug 2021 07:31:42 +0000 (09:31 +0200)]
Merge vk-gl-cts/github-master into vk-gl-cts/master
Change-Id: I9bf5cb55d51036216ffb8aafde67062b6c860c1f
Alexander Galazin [Fri, 13 Aug 2021 07:30:29 +0000 (09:30 +0200)]
Merge pull request #276 from Ella-0/master
Test behaviour of color write enable with colorWriteMask
Alexander Galazin [Thu, 12 Aug 2021 15:23:45 +0000 (17:23 +0200)]
Allow Vulkan CTS 1.2.7.1
Affects: dEQP-VK.api.driver_properties.properties
Components: Vulkan
Change-Id: Ic313a2b15d7c2be5c5b1f95aa189dc6bf1adbf70
Jason Ekstrand [Wed, 26 Aug 2020 22:47:24 +0000 (17:47 -0500)]
Add tests for VK_EXT_shader_atomic_float2
New tests:
dEQP-VK.glsl.atomic_operations.*float16*
dEQP-VK.glsl.atomic_operations.min_float*
dEQP-VK.glsl.atomic_operations.max_float*
dEQP-VK.image.atomic_operations.min*r32f*
dEQP-VK.image.atomic_operations.max*r32f*
Affects:
dEQP-VK.glsl.atomic_operations.*float*
dEQP-VK.image.atomic_operations.add*r32f*
dEQP-VK.image.atomic_operations.exchange*r32f*
Components: Vulkan
VK-GL-CTS issue: 2566
Change-Id: I7462cc74e799c2245407220fa9db7e5b659f86f4
(cherry picked from commit
ca4e5aff66bccbbe88935c10e2c55a3147c1fc03)
(cherry picked from commit
218eb73c4f30e720bd19a61704f5ad6ebcd73d48)
Ricardo Garcia [Mon, 19 Apr 2021 13:56:11 +0000 (15:56 +0200)]
Tests for VK_KHR_present_id and VK_KHR_present_wait
Add tests for VK_KHR_present_id and VK_KHR_present_wait. This commit
also refactors some code so it can be reused in several places, hence
marking all WSI tests as affected.
Affected tests:
dEQP-VK.info.device_mandatory_features
dEQP-VK.wsi.*
New tests:
dEQP-VK.wsi.*.present_id_wait.*
Components: Vulkan
VK-GL-CTS issue: 2098
VK-GL-CTS issue: 2099
Change-Id: I1c95fbf031d651773a9fff1c10a23038d73f6e53
(cherry picked from commit
8bf210fd592883b3adebb57c3d6cc49188d1758e)
(cherry picked from commit
b7a8721e2ffb9153283b434658463daac7ed1313)
Alexander Galazin [Tue, 27 Jul 2021 18:59:06 +0000 (20:59 +0200)]
Update glslang, SPIR-V Tools, headers
Components: Framework
Change-Id: Ie259277466b22ba816843c362da272a4284fcb93
(cherry picked from commit
c1e67a6d8689bdaad205ee0287ea4b490141c4d3)
Alexander Galazin [Tue, 27 Jul 2021 10:57:27 +0000 (12:57 +0200)]
Update Vulkan headers
Components: Vulkan
Change-Id: Id59fb9125cac9068d68a8e5f219c3dc53a093ad0
(cherry picked from commit
ab44aa0a0a3a2c1ec5937a71c4cb8936f22fb247)
Alexander Galazin [Mon, 5 Jul 2021 14:18:18 +0000 (16:18 +0200)]
Update Vulkan headers
Components: Vulkan
Change-Id: I6000ca21cc306130dd546887e68d1cecd4dc0e1f
(cherry picked from commit
9aa91388484350028ff7c7c4c063ee87146070b6)
Alexander Galazin [Thu, 12 Aug 2021 20:25:23 +0000 (22:25 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I34e25155c4d2fc3a37f8699507a1330f86ef78a9
Alexander Galazin [Thu, 12 Aug 2021 19:53:13 +0000 (21:53 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I8d78e920b4007ea7f47e66d64852693dfed22003
Alexander Galazin [Thu, 12 Aug 2021 18:56:51 +0000 (20:56 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Id1af44b78cbe4ba82cc76c656e0a22421ac20073
Alexander Galazin [Thu, 12 Aug 2021 18:03:29 +0000 (20:03 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I13ff1ac57c064dc46bbc7c555ba1fed07e04080c
Alexander Galazin [Thu, 12 Aug 2021 18:02:19 +0000 (20:02 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: Iab13500b9aaa9b6da0e99ea9d93fe9cabc66da33
Maniraj D [Fri, 30 Jul 2021 11:32:04 +0000 (11:32 +0000)]
Do proper checking for the presence of Xorg/XCB
In XcbDisplay::hasDisplay() API, hasthe incorrect
assumption that the xcb_connection_t is always valid,
if its value isn't NULL. XcbDisplay::hasDisplay() must
ensure that there are no connection errors by
using the xcb_connection_has_error() API.
Failure to do so would result in incorrectly trying
to exercise the XCB related test cases against
other than XCB WSIs, such as Wayland, for example.
Components: Vulkan
Affected tests: dEQP-VK.wsi.*
dEQP-VK.image.swapchain_mutable.*
VK-GL-CTS issue: 3037
Change-Id: Id722b3a3b3d82161ff00096518a026701b291751
Tony Zlatinski [Wed, 28 Jul 2021 21:41:09 +0000 (16:41 -0500)]
The existence of a DRM device is not mandatory
The VK_EXT_physical_device_drm spec states:
DRM defines multiple device node types. Each physical device may
have one primary node and one render node associated.
Physical devices may have no primary node (e.g. if the device does
not have a display subsystem), may have no render node (e.g. if it is
a software rendering engine), or may have neither (e.g. if it is a
software rendering engine without a display subsystem).
According to the above statement, a DRM device does not have to
always be present for a device to be compliant with the
VK_EXT_physical_device_drm spec.
Components: Vulkan
VK-GL-CTS Issue: 3029
Affects: dEQP-VK.api.device_drm_properties.drm_files_exist
Change-Id: I6d48b15d142650ee0db2dafd5e1b7f3c30e7a837
Ilkka Saarelainen [Thu, 12 Aug 2021 05:06:20 +0000 (08:06 +0300)]
Add missing items to android cts mustpass list
Some tests were missing from Android vk-master-2021-03-01 test list.
This CL adds those tests to the list.
Components: Vulkan
VK-GL-CTS issue: 3050
Change-Id: I973508a169e70d203dd465e9f22c41405c1c24a7
SoroushIMG [Mon, 26 Jul 2021 13:36:56 +0000 (14:36 +0100)]
Fix bug in compressed PixelStorageModes tests
Compressed pixel storage modes are tested by using the extension
ARB_compressed_texture_pixel_storage.
ARB_compressed_texture_pixel_storage is a core extension since
OpenGL 4.2. Therefore, the cases testing this behaviour need to
check for its support in GL context versions before 4.2.
Without this check drivers that do not provide this extension,
will fail this test instead of being marked as not supported.
This CL adds the mentioned extension checking.
Affects:
KHR-GL33.pixelstoragemodes.compressedteximage2d.*
KHR-GL33.pixelstoragemodes.compressedteximage3d.*
Components: OpenGL
VK-GL-CTS issue: 3020
Change-Id: Ib9a4edeb57995582c07aa11c7db11c6e7bbe1984
David Emett [Mon, 26 Jul 2021 16:33:03 +0000 (16:33 +0000)]
Work around bogus GCC 9 warnings
Bogus warning can be seen with this example:
#include <stddef.h>
long broken()
{
struct
{
long a, b;
} value;
for (size_t i = 0; i < sizeof(long); ++i)
{
((char *)&value.a)[i] = (char)0xde;
((char *)&value.b)[i] = (char)0xde;
}
return value.b;
}
Compiled with -O3 -Warray-bounds GCC 9 warns:
In function 'long int broken()':
cc1plus: warning: 'void* __builtin_memset(void*, int, long unsigned int)' offset [9, 16] from the object at 'value' is out of the bounds of referenced subobject 'broken()::<unnamed struct>::a' with type 'long int' at offset 0 [-Warray-bounds]
It looks like GCC is recognising the loop as two memsets, merging them,
then forgetting that it has done this.
It seems this can be worked around by just using memset rather than
implementing it manually, which is also simpler and produces better
code.
The example compiles without warning on GCC 10+ (you can try on
https://godbolt.org/), so presumably this bug has been fixed in later
versions of gcc.
Change-Id: I09799d6dd833b1fba8608cddaa36a32e555cf861
Antto Mäkinen [Mon, 2 Aug 2021 12:00:27 +0000 (15:00 +0300)]
Fix a GraphicsFuzz coverage test
This commit simplifies the result verification at the end of cov-apfloat-module-small-number.
Affects: dEQP-VK.graphicsfuzz.cov-apfloat-module-small-number
Components: Vulkan
VK-GL-CTS issue: 3035
Change-Id: Ia0e0347880cbddc2433cd3867c96a09645c5a35d
Iago Toral Quiroga [Mon, 2 Aug 2021 09:31:14 +0000 (11:31 +0200)]
Increase error threshold for some geometry shader tests
Components: Vulkan
VK-GL-CTS issue: 3034
Affected tests:
dEQP-VK.geometry.*
Change-Id: I5ed440019ab45f6f31787d199695630d06bb2a51
Iago Toral Quiroga [Mon, 2 Aug 2021 07:33:49 +0000 (09:33 +0200)]
Fix variable pointer tests for geometry stages on tilers
On tilers we may execute any geometry stage more than once, not just
the vertex shader.
Components: Vulkan
VK-GL-CTS issue: 3033
Affected tests:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes_single_buffer_*
Change-Id: I3ee5db4aa8176d09b10720d7683338ef8e8a8098
Ricardo Garcia [Thu, 29 Jul 2021 15:13:51 +0000 (17:13 +0200)]
Fix DRM modifier list tests
* dEQP-VK.drm_format_modifiers.list_modifiers.* tests now check every
supported modifier instead of returning prematurely if any of the
modifiers was not supported for the image usage flags the tests uses.
* dEQP-VK.drm_format_modifiers.create_list_modifiers.* tests check
modifier compatibility first before attempting to use compatible
modifier lists of different lengths. Test results no longer depend on
the order of modifiers returned by the implementation and do not
return NotSupported prematurely.
* dEQP-VK.drm_format_modifiers.export_import.* tests suffered from
similar issues. They tried to detect which of the supported modifiers
for a format met a list of requirements and returned early with
NotSupported if any of them failed to match those requirements,
instead of running the tests in all possible modifiers.
Affected tests:
dEQP-VK.drm_format_modifiers.*
Components: Vulkan
VK-GL-CTS issue: 3026
Change-Id: I4c6600b87f3c2b4b9b165fdc17988efe2e0cf670
Ari Suonpaa [Fri, 6 Aug 2021 12:08:21 +0000 (15:08 +0300)]
Relax protected heap allocation tests
Some implementations have limitations on protected heap
allocations, and these limitations cannot be queried
using the Vulkan API. This change allows an out-of-memory
to happen after a certain number of allocations to
compensate that.
VK-GL-CTS Issue: 3038
Affects:
dEQP-VK.memory.*allocation.*
Components: Vulkan
Change-Id: I3a34637c8c15eb8670613dce9b6e394a622a4c71
Ari Suonpaa [Tue, 23 Mar 2021 05:45:48 +0000 (07:45 +0200)]
Added layered AHB EGL tests
Added new EGL image format tests for using Android Native
Hardware buffers with layers. They are mapped as 2D texture
arrays using EGL image API.
EGL internal test filter was also removed as the EGL AHB
tests are now using public Android API.
VK-GL-CTS Issue: 2671
New tests:
dEQP-EGL.functional.image.*android_native*
Components: EGL, Framework
Change-Id: I34a7560703bb06b75be276dc8ba5247c3763877a
Ricardo Garcia [Wed, 21 Jul 2021 10:33:51 +0000 (12:33 +0200)]
Improve buffer to buffer copy tests
Buffer to buffer copy tests were filling the source and destination
buffers with the same contents, using functions that were both used for
images and buffers.
When filling source buffers, a linear memory allocation of R32_UINT
elements was filled with color red, which resulted in all bytes
containing value 255.
When filling destination buffers, the same procedure was followed using
color white. However, due to R32_UINT only having one component, this
also resulted in every buffer byte containing value 255.
The copy operation that followed could fail (e.g. with the
implementation not doing anything) and the test could still pass. This
commit makes the destination buffer be filled with zeros so as to verify
regions are being interpreted correctly.
Affected tests:
dEQP-VK.api.copy_and_blit.*buffer_to_buffer*
Components: Vulkan
VK-GL-CTS issue: 3008
Change-Id: I49e5ea5a4843540e57be22c67107db82b7903da2
Alexander Galazin [Thu, 5 Aug 2021 08:29:18 +0000 (10:29 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master
Change-Id: Ie8036c780cda38f67032afa000852326c57b7860
Alexander Galazin [Thu, 5 Aug 2021 07:23:15 +0000 (09:23 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I2ac7dec5e1cd15b13dec902ceeff581992d2678c
Ricardo Garcia [Thu, 15 Jul 2021 10:19:46 +0000 (12:19 +0200)]
Test multiview with VK_EXT_multi_draw
Add new VK_EXT_multi_draw test variants that check multi_draws together
with multiview.
New, affected and removed tests:
dEQP-VK.draw.multi_draw.*
Components: Vulkan
VK-GL-CTS issue: 2985
Change-Id: I0e2b36efa912629b3f6457913f3c3b6d9eeebfe8
Piotr Byszewski [Thu, 8 Jul 2021 15:37:09 +0000 (17:37 +0200)]
Add sample mask test for FSR
This change adds single test that uses pipelineFragmentShadingRate
with fragmentSize {2,2}, 4xMSAA and a sample mask of 0x9.
After drawing random triangles there is a check that samples are
written only to samples present in the sample mask.
VK-GL-CTS issue: 2397
Components: Vulkan
Affects:
dEQP-VK.fragment_shading_rate.misc_tests.*
Change-Id: I38bbddeb2f8d7e8aac1c3803b171ec5be2f0c21a
Daniel Koch [Tue, 27 Jul 2021 21:14:02 +0000 (17:14 -0400)]
Fix transform_feedback.simple.multiquery* tests
Tests were using host query reset which may not be present pre-VK 1.2.
Change tests to use device query reset (there are other dedicated tests which test HOST_QUERY_RESET).
Components: Vulkan
VK-GL-CTS Issue: 2866
Affects:
dEQP-VK.transform_feedback.simple.multiquery*
Change-Id: Ib8c943a53542f4e21167f6afb0005200043477c6
Connor Abbott [Mon, 26 Jul 2021 13:48:27 +0000 (15:48 +0200)]
Fix depth/stencil subpass dependencies in renderpass allocation tests
This seems like a copy/paste error, but the last subpass should have
VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT and the current subpass
should have VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, analagous to
the color attachment case.
Affects:
dEQP-VK.renderpass.dedicated_allocation.attachment_allocation.input_output.*
Components: Vulkan
VK-GL-CTS Issue: 3019
Change-Id: I0f46316f9c5147d2391c6f0f2a37fb1e56420078