Nathan Rajlich [Mon, 21 May 2012 22:46:57 +0000 (19:46 -0300)]
repl: preserve the cursor when redisplaying the prompt on SIGCONT
Otherwise the cursor position was being reset to 0, even when there was
already part of a line, which was strange.
Part of #3295.
Nathan Rajlich [Mon, 21 May 2012 22:43:26 +0000 (19:43 -0300)]
readline: explicitly disable and re-enable "raw mode" on Ctrl+Z
Fixes #3295.
Nathan Rajlich [Mon, 21 May 2012 22:41:56 +0000 (19:41 -0300)]
readline: move the "setRawMode" logic into a private function
Oleg Efimov [Mon, 21 May 2012 17:09:40 +0000 (21:09 +0400)]
Make UNWRAP macro generic.
Andreas Madsen [Sun, 20 May 2012 13:57:24 +0000 (15:57 +0200)]
cluster: remove NODE_UNIQUE_ID from env on startup
In case a worker would spawn a new subprocess with process.env, NODE_UNIQUE_ID
would have been a part of the env. Making the new subprocess believe it is a
worker, this would result in some confusion if the subprocess where to listen to
a port, since the server handle request would then be relayed to the worker.
This patch removes the NODE_UNIQUE_ID flag from process.env on startup so any
subprocess spawned by a worker is a normal process with no cluster stuff.
Oleg Efimov [Mon, 21 May 2012 15:27:15 +0000 (19:27 +0400)]
Check for tabs in source line in DisplayExceptionLine
Fix for joyent/node#3280
Ben Noordhuis [Sun, 20 May 2012 22:31:28 +0000 (00:31 +0200)]
test: add http 'data after timeout' test
See #3234. TDB if this is or is not the desired behavior.
isaacs [Sun, 20 May 2012 12:40:10 +0000 (09:40 -0300)]
test: wait for 'close' event for stdout
At the 'exit' event, it is sometimes not done writing to stdout.
isaacs [Sun, 20 May 2012 03:42:07 +0000 (00:42 -0300)]
test: root can connect to chmod'd pipes
isaacs [Sun, 20 May 2012 03:17:18 +0000 (00:17 -0300)]
test: Solaris is not as granular with rename fs watch events
Andreas Madsen [Sat, 19 May 2012 21:05:43 +0000 (23:05 +0200)]
fs.watch should not require a listener arguments
Since fs.watch returns an event emitter where the change event is exactly
the same as the listener callback, the argument should be required
Ben Noordhuis [Thu, 17 May 2012 04:18:25 +0000 (06:18 +0200)]
doc: improve fs.open() docs
Kevin Bowman [Wed, 16 May 2012 03:24:05 +0000 (04:24 +0100)]
doc: document fs 'rs+' open mode
isaacs [Wed, 16 May 2012 00:35:42 +0000 (17:35 -0700)]
Faster fs.readFile and fs.readFileSync
isaacs [Wed, 16 May 2012 00:02:39 +0000 (17:02 -0700)]
benchmark for fs.readfile
isaacs [Wed, 16 May 2012 23:32:37 +0000 (16:32 -0700)]
Revert "Fix #3242 Actually deprecate 'binary' buffer encoding"
This reverts commit
5979f096d1b702ca2ba95664a0bbc8210109775b.
Related:
- #3279
- #3278
isaacs [Wed, 16 May 2012 02:06:15 +0000 (19:06 -0700)]
Fix #3270 Escape url.parse delims
Rather than omitting them.
isaacs [Wed, 16 May 2012 21:49:51 +0000 (14:49 -0700)]
build: Set strict_aliasing on SunOS always
A build failure was introduced on
c9676c9147e088171e60b1977ac239ded4f327df
in SmartOS systems. This makes it build properly.
isaacs [Wed, 16 May 2012 21:44:15 +0000 (14:44 -0700)]
Revert "test: stack overflow output"
This reverts commit
f8519e10b823f576ddd0efa76ab425f0598b1223.
Recent update to V8 fixes the problem where it incorrectly reports the
line number as 0 for thrown RangeErrors.
isaacs [Wed, 16 May 2012 17:15:25 +0000 (10:15 -0700)]
v8: s/echo -n/echo/. Not all sh's are bash.
isaacs [Wed, 16 May 2012 15:50:24 +0000 (08:50 -0700)]
Patches floating on V8
isaacs [Wed, 16 May 2012 02:53:16 +0000 (19:53 -0700)]
Upgrade V8 to 3.11.1
Adam Malcontenti-Wilson [Wed, 16 May 2012 14:27:34 +0000 (16:27 +0200)]
http: make http.get() accept a URL
http.get() now accepts either a URL (as a string) or an options object.
Ben Noordhuis [Wed, 16 May 2012 14:08:18 +0000 (16:08 +0200)]
doc: clarify stream 'close' event
isaacs [Wed, 16 May 2012 00:37:23 +0000 (17:37 -0700)]
lint
Kevin Bowman [Tue, 15 May 2012 22:10:25 +0000 (00:10 +0200)]
fs: add sync open flags 'rs' and 'rs+'
isaacs [Tue, 15 May 2012 21:21:22 +0000 (14:21 -0700)]
Merge branch 'master' into v0.6-merge
Conflicts:
src/node.cc
isaacs [Tue, 15 May 2012 21:19:46 +0000 (14:19 -0700)]
Re-apply http fixes from v0.6 branch properly
Sadique Ali [Tue, 1 May 2012 10:33:36 +0000 (16:03 +0530)]
build: improve c compiler detection
Ben Noordhuis [Tue, 15 May 2012 20:05:33 +0000 (22:05 +0200)]
http: fix client request.end() EPIPE race
request.end() would sometimes try to write a zero-length buffer to the socket.
Don't do that, it triggers an unnecessary EPIPE when the other end has closed
the connection.
Fixes #3257.
isaacs [Tue, 15 May 2012 20:03:56 +0000 (13:03 -0700)]
test: stack overflow output
isaacs [Tue, 15 May 2012 20:03:43 +0000 (13:03 -0700)]
lint
Ben Noordhuis [Tue, 15 May 2012 15:24:06 +0000 (17:24 +0200)]
node: make _getActiveHandles() return user objects
Before this commit, process._getActiveHandles() returned a list of internal
handles. Now, it returns the user objects that handles are attached to.
For example, a tcp_wrap handle will now return its parent net.Socket object.
It works for all handle types except timers because timer handles are shared
across multiple user objects.
Ben Noordhuis [Sun, 29 Apr 2012 22:58:15 +0000 (00:58 +0200)]
test: verify that connect reqs are cleaned up
Ben Noordhuis [Sat, 28 Apr 2012 16:45:10 +0000 (18:45 +0200)]
process: add _getActiveHandles(), _getActiveRequests()
* process._getActiveHandles() returns a list containing all active handles
(timers, sockets, etc.) that have not been unref'd.
* process._getActiveRequests() returns a list of active requests (in-flight
actions like connecting to a remote host, writing data to a socket, etc.).
Ben Noordhuis [Fri, 27 Apr 2012 16:58:30 +0000 (18:58 +0200)]
req_wrap: share process_symbol, domain_symbol
Share persistent strings process_symbol and domain_symbol across compilation
units. Avoids redefinition errors when src/node.cc includes src/req_wrap.h.
isaacs [Tue, 15 May 2012 18:37:34 +0000 (11:37 -0700)]
Merge remote-tracking branch 'ry/v0.6' into v0.6-merge
Conflicts:
ChangeLog
deps/uv/include/uv-private/uv-unix.h
deps/uv/src/unix/core.c
deps/uv/src/unix/sunos.c
deps/v8/src/runtime.cc
doc/api/crypto.markdown
lib/http.js
src/node_version.h
test/gc/test-http-client-timeout.js
wscript
isaacs [Tue, 15 May 2012 00:21:20 +0000 (17:21 -0700)]
Guard against emitting 'end' twice on http responses
Conflicts:
lib/http.js
isaacs [Fri, 11 May 2012 00:55:28 +0000 (17:55 -0700)]
Break up huge function in ClientRequest.onSocket
Conflicts:
lib/http.js
isaacs [Tue, 15 May 2012 17:21:57 +0000 (10:21 -0700)]
Now working on 0.6.19
isaacs [Tue, 15 May 2012 17:21:40 +0000 (10:21 -0700)]
Merge branch 'v0.6.18-release' into v0.6
Ben Noordhuis [Fri, 27 Apr 2012 14:54:28 +0000 (16:54 +0200)]
child_process: hook up handle wrap to owning object
Ben Noordhuis [Fri, 27 Apr 2012 14:52:06 +0000 (16:52 +0200)]
child_process: rename field _internal to _handle
Consistent with how other classes that are built around HandleWraps call it.
Ben Noordhuis [Fri, 27 Apr 2012 02:42:10 +0000 (04:42 +0200)]
net: hook up handle wrap to owning object
Ben Noordhuis [Fri, 27 Apr 2012 02:39:05 +0000 (04:39 +0200)]
fs: hook up handle wrap to owning object
Ben Noordhuis [Fri, 27 Apr 2012 02:37:27 +0000 (04:37 +0200)]
dgram: hook up handle wrap to owning object
isaacs [Mon, 14 May 2012 23:12:15 +0000 (16:12 -0700)]
2012.05.15 Version 0.6.18 (stable)
* windows: skip GetFileAttributes call when opening a file (Bert Belder)
* crypto: add PKCS12/PFX support (Sambasiva Suda)
* #3240: child_process: delete NODE_CHANNEL_FD from env in spawn (Ben Noordhuis)
* windows: add test for path.normalize with UNC paths (Bert Belder)
* windows: make path.normalize convert all slashes to backslashes (Bert Belder)
* fs: Automatically close FSWatcher on error (Bert Belder)
* #3258: fs.ReadStream.pause() emits duplicate data event (koichik)
* pipe_wrap: don't assert() on pipe accept errors (Ben Noordhuis)
* Better exception output for module load and process.nextTick (Felix Geisendörfer)
* zlib: fix error reporting (Ben Noordhuis)
* http: Don't destroy on timeout (isaacs)
* #3231: http: Don't try to emit error on a null'ed req object (isaacs)
* #3236: http: Refactor ClientRequest.onSocket (isaacs)
isaacs [Mon, 14 May 2012 23:14:12 +0000 (16:14 -0700)]
Escape leading # signs in 'make email.md'
isaacs [Tue, 15 May 2012 00:21:20 +0000 (17:21 -0700)]
Guard against emitting 'end' twice on http responses
isaacs [Mon, 14 May 2012 19:01:38 +0000 (12:01 -0700)]
Ben Noordhuis [Mon, 14 May 2012 15:34:33 +0000 (17:34 +0200)]
test: add https + .pfx client/server test
ssuda [Sun, 13 May 2012 19:38:23 +0000 (01:08 +0530)]
crypto: add PKCS12/PFX support
Fixes #2845.
Andreas Madsen [Thu, 12 Apr 2012 07:23:07 +0000 (09:23 +0200)]
child_process: allow sending a net Socket and Server object using child.send
child_process.fork() support sending native hander object, this patch add support for sending
net.Server and net.Socket object by converting the object to a native handle object and back
to a useful object again.
Note when sending a Socket there was emitted by a net Server object, the server.connections
property becomes null, because it is no longer possible to known when it is destroyed.
Andreas Madsen [Thu, 12 Apr 2012 07:18:12 +0000 (09:18 +0200)]
doc: move child.send details from child_process.fork to child.send
rsolomo [Mon, 14 May 2012 02:17:51 +0000 (19:17 -0700)]
net: make isIP() return 0 on empty input
Ben Noordhuis [Mon, 14 May 2012 05:14:18 +0000 (07:14 +0200)]
node: delete NODE_CHANNEL_FD from env
Prevents accidental inheritance by child processes. If the child process is a
node process, it would try to set up a channel with the parent and consequently
never quit because the channel kept the event loop alive.
Fixes #3240.
Bert Belder [Sun, 13 May 2012 01:29:44 +0000 (03:29 +0200)]
Windows: add test for path.normalize with UNC paths
Bert Belder [Sun, 13 May 2012 01:18:09 +0000 (03:18 +0200)]
Windows: make path.normalize convert all slashes to backslashes
Closes #3066
Bert Belder [Sat, 12 May 2012 17:37:33 +0000 (19:37 +0200)]
Automatically close FSWatcher on error
Closes #3250
koichik [Sat, 12 May 2012 01:24:46 +0000 (10:24 +0900)]
fs: fix ReadStream.pause() emits duplicate data event
Fixes #3258.
Nathan Rajlich [Sun, 6 May 2012 19:47:25 +0000 (12:47 -0700)]
buffer: make SlowBuffer inherit from Buffer
This frees us from manually having to copy over functions to SlowBuffer's
prototype (which has bitten us multiple times in the past).
As an added bonus, the `inspect()` function is now shared between Buffer
and SlowBuffer, removing some duplicate code.
Closes #3228.
isaacs [Fri, 11 May 2012 00:55:54 +0000 (17:55 -0700)]
500 is a magic number for the GC for some reason
isaacs [Fri, 11 May 2012 00:55:28 +0000 (17:55 -0700)]
Break up huge function in ClientRequest.onSocket
Ben Noordhuis [Fri, 11 May 2012 01:09:51 +0000 (03:09 +0200)]
build: fix cross-compiling
Take arch cflags in account when building libuv.
isaacs [Fri, 11 May 2012 15:49:03 +0000 (08:49 -0700)]
Fix #3058 querystring: Fix incorrect handling of empty keys
Shigeki Ohtsu [Fri, 11 May 2012 10:07:08 +0000 (19:07 +0900)]
doc: fix typo in buffer documentation
Fixes #3253.
Ben Noordhuis [Fri, 11 May 2012 02:39:20 +0000 (04:39 +0200)]
test: add failing dgram refcount test
Idle UDP sockets (reading nor writing) should not keep the event loop alive.
This will get fixed in v0.8 one way or the other.
Ben Noordhuis [Thu, 10 May 2012 14:54:17 +0000 (16:54 +0200)]
child_process: make copy of options arg
Make a copy of the options object that the user passes in, we modify it.
Ben Noordhuis [Thu, 10 May 2012 14:49:35 +0000 (16:49 +0200)]
util: make _extend() more robust
Add a better 'is object?' check, the old one let values like true slip through.
vegorov@chromium.org [Wed, 12 Oct 2011 10:35:42 +0000 (10:35 +0000)]
Runtime_NotifyDeoptimized should search for function activation in all thread stacks.
R=fschneider@chromium.org
BUG=v8:1763
Review URL: http://codereview.chromium.org/
8240004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@9588
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
isaacs [Wed, 9 May 2012 22:12:13 +0000 (15:12 -0700)]
Merge remote-tracking branch 'ry/v0.6' into v0.6-merge
Conflicts:
Makefile
lib/zlib.js
src/node.cc
src/node.js
Philip Tellis [Wed, 9 May 2012 20:39:27 +0000 (16:39 -0400)]
doc: fs.ReadableStream does not have a destroySoon method
Ben Noordhuis [Wed, 9 May 2012 21:11:14 +0000 (23:11 +0200)]
pipe_wrap: don't assert() on pipe accept errors
Pass errors to the onconnection callback.
Felix Geisendörfer [Tue, 8 May 2012 20:02:28 +0000 (22:02 +0200)]
Fix exception output for module load exceptions
So instead of:
node.js:201
throw e; // process.nextTick error, or 'error' event on first tick
^
You will now see:
path/to/foo.js:1
throw new Error('bar');
^
This is a sub-set of isaacs patch here:
https://github.com/joyent/node/issues/3235
The difference is that this patch purely adresses the exception output,
but does not try to make any behavior changes / improvements.
Felix Geisendörfer [Tue, 8 May 2012 14:07:14 +0000 (16:07 +0200)]
Fix process.nextTick throw call sites
This patch now reports the proper throw call site for exceptions
triggered within process.nextTick. So instead of this:
node.js:201
throw e; // process.nextTick error, or 'error' event on first tick
^
You will now see:
mydir/myscript.js:15
throw new Error('My Error');
^
From my testing this patch causes no performance regressions, but does
greatly simplify processing the nextTickQueue.
isaacs [Wed, 9 May 2012 17:07:02 +0000 (10:07 -0700)]
Fix #3242 Actually deprecate 'binary' buffer encoding
Alex Kocharin [Sun, 6 May 2012 09:32:49 +0000 (13:32 +0400)]
util: handle non-string return value in .inspect()
Ben Noordhuis [Wed, 9 May 2012 04:06:42 +0000 (06:06 +0200)]
stream_wrap: fix compilation errors
Bert Belder [Wed, 9 May 2012 02:58:26 +0000 (04:58 +0200)]
Net.js: fix UCS2 write crash due to inconsistent naming
Ben Noordhuis [Mon, 7 May 2012 15:04:56 +0000 (17:04 +0200)]
zlib: fix error reporting
This commit is a back-port of the changes on the master branch.
Fixes #3230.
Bert Belder [Wed, 9 May 2012 02:34:41 +0000 (04:34 +0200)]
stream_wrap.cc: fix typo
Bert Belder [Tue, 8 May 2012 18:19:38 +0000 (20:19 +0200)]
net.js: make Socket.bytesWritten work again
Earlier string write optimizations broke it.
Bert Belder [Wed, 9 May 2012 01:54:28 +0000 (03:54 +0200)]
StreamWrap::WriteBuffer: remove superfluous arguments
Bert Belder [Mon, 7 May 2012 21:30:55 +0000 (23:30 +0200)]
Optimize writing strings with Socket.write
Bert Belder [Tue, 8 May 2012 16:09:04 +0000 (18:09 +0200)]
Benchmark: add /unicode/nnn bench to http_simple.js
Bert Belder [Tue, 8 May 2012 15:38:02 +0000 (17:38 +0200)]
Benchmark: clean up http_simple.js
Bert Belder [Tue, 8 May 2012 18:17:54 +0000 (20:17 +0200)]
net.js: don't pretend that everything is okay when unwrapping fails
In case of an UNWRAP failure, the binding returns -1, which is truthy.
yangguo@chromium.org [Tue, 8 May 2012 12:38:24 +0000 (12:38 +0000)]
Force inlining CopyChars and String::Get.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10332054
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@11527
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
Ben Noordhuis [Tue, 8 May 2012 14:01:36 +0000 (16:01 +0200)]
Don't use _snprintf() on Windows, it's not safe.
_snprintf() doesn't zero-terminate the buffer on overflow. Use the hand-rolled
version that lives in src/node_internals.h.
isaacs [Mon, 7 May 2012 21:19:16 +0000 (14:19 -0700)]
Don't destroy on timeout
isaacs [Mon, 7 May 2012 21:17:17 +0000 (14:17 -0700)]
Fix #3231. Don't try to emit error on a null'ed req object
Ben Noordhuis [Mon, 7 May 2012 20:49:10 +0000 (22:49 +0200)]
test: add failing HTTP client timeout test
See #3231.
Kevin Gadd [Wed, 25 Apr 2012 07:11:06 +0000 (00:11 -0700)]
docs: add warning to vm module docs
Add a clear warning about known issues with the module and a pointer to the
GitHub issues list for the module. Describe some of the biggest known issues
with the module.
James Koval [Sun, 6 May 2012 18:23:09 +0000 (11:23 -0700)]
docs: update var names in readline docs to be consistent
Closes #3201.
isaacs [Sun, 6 May 2012 05:33:06 +0000 (22:33 -0700)]
Upgrade npm to 1.1.21
Somehow this got downgraded in the last v0.6 merge. Very strange.
isaacs [Sun, 6 May 2012 02:27:42 +0000 (19:27 -0700)]
Document http.STATUS_CODES
This is an incredibly useful thing to know about, and it
will likely never change. I can't remember why we
didn't ever document it, and people keep suggesting we
do so.
isaacs [Sat, 5 May 2012 22:07:58 +0000 (15:07 -0700)]
More cluster event consistency
Regarding discussion in #3198. Passing the worker as an argument
to an event emitted on the worker is redundant, and an unnecessary
break in consistency vs the events on the ChildProcess objects.
It was removed from 'exit', but 'listening' and others were
overlooked. This corrects that oversight.
isaacs [Sat, 5 May 2012 22:05:14 +0000 (15:05 -0700)]
Move test-fs-largefile into pummel
It's too slow.
Javier Hernández [Fri, 4 May 2012 22:06:24 +0000 (00:06 +0200)]
build: print error message if no compiler found
Make the configure script warn the user about the lack of an acceptable
C compiler on the system.
koichik [Sat, 5 May 2012 14:10:36 +0000 (23:10 +0900)]
doc: fix setEncoding()
Fixes #3209.