Eunki Hong [Sun, 19 Nov 2023 15:38:58 +0000 (00:38 +0900)]
Remove build waring [-Wpessimizing-move] (don't need to std::move at return value)
We don't need to use std::move for return value.
Change-Id: Ia2c1d156af039b38f5f6882f2f69537031eddb6b
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Fri, 17 Nov 2023 23:03:15 +0000 (23:03 +0000)]
Merge "Test harness sync" into devel/master
Adeel Kazmi [Fri, 17 Nov 2023 14:56:47 +0000 (14:56 +0000)]
DALi Version 2.2.53
Change-Id: I0f978817151cd9e2e739c7c36a21b3021c47b63d
Adeel Kazmi [Thu, 16 Nov 2023 14:55:27 +0000 (14:55 +0000)]
Merge "3D Scene Hit Testing" into devel/master
Adam Bialogonski [Mon, 13 Nov 2023 07:34:01 +0000 (07:34 +0000)]
3D Scene Hit Testing
- New functions creates mesh using list of vertices and face indices to work with NUI.
- Added the functionality to detect which mesh is hit & emit signal
Requires C# binding and NUI Model.cs update
Change-Id: Ib5bfd8ad6e7c35017db2c1173805f5c863156530
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
Adeel Kazmi [Thu, 16 Nov 2023 08:58:53 +0000 (08:58 +0000)]
Merge "Added 2.3.0 support in the doxy file" into devel/master
Eunki, Hong [Thu, 16 Nov 2023 04:52:31 +0000 (13:52 +0900)]
Check missing accessible checker code
Fix svace issue
Change-Id: I8e60b163fb39ff6481aa85ef4dc1f0ce9cfeef71
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Wed, 15 Nov 2023 17:08:37 +0000 (02:08 +0900)]
Allow bitmap 6byte utf8 glyph + Ignore build warning
The new warning option -Wstringop-overflow occured when we convert
from std::string to utf8 buffer.
Also, current dali support maximum 6 bytes utf8 glyph.
Let we also support them for BitmapFont case.
Change-Id: I3cc1f20145fa7be9071de3048d7d242cb6273bd8
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Wed, 15 Nov 2023 21:21:42 +0000 (21:21 +0000)]
Added 2.3.0 support in the doxy file
Change-Id: I2cb3471159b559bd1eb5729d7b7d5a9fabd200bb
David Steele [Wed, 15 Nov 2023 18:48:11 +0000 (18:48 +0000)]
Test harness sync
Change-Id: I9044b20f53b2a13fa87eca58d84dd719d7958337
Eunki, Hong [Wed, 8 Nov 2023 13:29:49 +0000 (22:29 +0900)]
(A11y) Let we make some way to do not create new Accessible
Add some API that we will not create new Accessible() object anymore.
It will be useful when we ignore some Disposed view's accessible action.
Change-Id: I6186f95eacf3c7d3cdb9c4ff9543edc019096552
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Tue, 14 Nov 2023 14:22:59 +0000 (23:22 +0900)]
Fix gcc-13 compile error (std::uint64_t not defined)
Change-Id: I5c0558a45b490beca55ae89d568c0dfd9457c4c4
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Tue, 14 Nov 2023 01:46:51 +0000 (10:46 +0900)]
Fix coverity issue (invalid iterator access)
We can setup ImageType freely. If some user set invalid image type into
EncodedImageBuffer, it will be crash.
To avoid this situation, let we allow to set invalid image type, and
it will works like regular image type.
Change-Id: I84757da0540755f12eb9a12850941ba6bd93bac1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Fri, 10 Nov 2023 17:42:46 +0000 (17:42 +0000)]
Merge "Remove Atlas parameter for TextureManager cache system" into devel/master
Adeel Kazmi [Fri, 10 Nov 2023 17:23:12 +0000 (17:23 +0000)]
Merge "Implement AsyncTaskManager for toolkit UTC" into devel/master
Adeel Kazmi [Fri, 10 Nov 2023 16:14:04 +0000 (16:14 +0000)]
Merge "(AnimatedVector) Cache lottie file's layer / marker info" into devel/master
Adeel Kazmi [Fri, 10 Nov 2023 16:10:54 +0000 (16:10 +0000)]
Merge "Minor optimization for image visaul and texture manager" into devel/master
Adeel Kazmi [Fri, 10 Nov 2023 09:50:02 +0000 (09:50 +0000)]
Merge "There is no function of the namespace defined in cpp, so it don't need the flag DALI_TOOLKIT_API" into devel/master
Adeel Kazmi [Fri, 10 Nov 2023 09:49:50 +0000 (09:49 +0000)]
Merge "WayPointData is a struct defined in dali-toolkit/dali-scene3d/internal/algorithm/path-finder-waypoint-data.h" into devel/master
Adam Bialogonski [Fri, 10 Nov 2023 07:42:48 +0000 (07:42 +0000)]
DALi Version 2.2.52
Change-Id: I1b00dd7c940c418fbeba87c71b93bd82ef5192f0
Eunki, Hong [Wed, 25 Oct 2023 04:30:50 +0000 (13:30 +0900)]
Implement AsyncTaskManager for toolkit UTC
Let we ignore Process() doesn't registered when we
check AsyncTask completed.
There was a lots of UTCs that randomly failed
due to the task completed and excuted at Process() timing.
Now we make async-task-manager triggered by event thread callback,
not include Process(). It will make sure that UTC who need to wait
async tasks completed is ensured.
Change-Id: I5ec2eca6e579be4459c957db3f52c90bc219602e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 26 Oct 2023 04:56:47 +0000 (13:56 +0900)]
Remove Atlas parameter for TextureManager cache system
If some visual attempt to atlas, they will use AtlasManager.
So there is no reason to keep atlas relative informations for
TextureInfo struct, what we are caching now.
+
This patch touch a lots of codes in texture-manager.
So, I also change something useless lvalue usages
Something like, const bool&
Change-Id: I6a83b75c8311377e2ab6d62d29c19864a21d7e79
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 8 Nov 2023 11:22:15 +0000 (20:22 +0900)]
(AnimatedVector) Cache lottie file's layer / marker info
GetLayerInfo and GetMarkerInfo can be called usually if we use NUI system.
(Since we call Visual::Base::CreatePropertyMap() every times we change some
properties.)
But the LayerInfo / MarkerInfo never be changed if the file is fixed.
So let we cache that information, and use cached value.
It can also reduce mutex block at plugin system internally.
Change-Id: I767bd581dc5e2a41715263d03c1ace15d2476df3
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
AdunFang [Tue, 7 Nov 2023 06:05:19 +0000 (15:05 +0900)]
There is no function of the namespace defined in cpp, so it don't need the flag DALI_TOOLKIT_API
Change-Id: If6ff6ee18d4c6edc5573c9c473471b0f67c7742d
AdunFang [Tue, 7 Nov 2023 05:22:28 +0000 (14:22 +0900)]
WayPointData is a struct defined in dali-toolkit/dali-scene3d/internal/algorithm/path-finder-waypoint-data.h
Change-Id: I61da87b6d9e792ba1bef80b87bb61bac359b7d71
Adeel Kazmi [Thu, 9 Nov 2023 17:21:25 +0000 (17:21 +0000)]
Merge changes I1b1abc2c,I47083821,Icbe72d36,I6292beb0,I14b750ac, ... into devel/master
* changes:
Test harness sync
Limited joint/weight attributes to 4 sets
Added vertex color test to model primitive
Add macro defs to shader regen
Adding debug to shader defs
Updated model loader to handle multiple attr sets
Switched joints to use UBO with larger size in PBR shader
Eunki, Hong [Thu, 2 Nov 2023 08:23:35 +0000 (17:23 +0900)]
Minor optimization for image visaul and texture manager
- Set texture index ordered bigger to smaller
Since we reserve the size of textureset internally,
set index bigger to smaller is more faster than else.
- Disconnect ObserverDestroyed what loadqueue connected
To avoid useless duplicated connection, let we disconnect
observer destroyed signal before process load queue.
Change-Id: I516406bcad2005ba628b3890fbc814df9c1a5e29
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Wed, 8 Nov 2023 04:56:41 +0000 (04:56 +0000)]
Merge "(Vector) Support EncodedImageBuffer can use for vector image" into devel/master
David Steele [Tue, 7 Nov 2023 17:25:49 +0000 (17:25 +0000)]
Test harness sync
Change-Id: I1b1abc2c020803afec166955fd52b928f57530d8
David Steele [Mon, 6 Nov 2023 18:00:49 +0000 (18:00 +0000)]
Limited joint/weight attributes to 4 sets
Total number of supported joints per vertex = 16.
Change-Id: I4708382167d98f94b8d8f9fdf534972b85213c33
David Steele [Mon, 6 Nov 2023 13:43:13 +0000 (13:43 +0000)]
Added vertex color test to model primitive
Modifying model loading to reduce shader churn
Changed ShaderManager to return shader option
Added debug across shader generation
Change-Id: Icbe72d36bc92e8e2d7735a1c13a0be73eab79312
Signed-off-by: David Steele <david.steele@samsung.com>
David Steele [Thu, 2 Nov 2023 18:13:02 +0000 (18:13 +0000)]
Add macro defs to shader regen
Change-Id: I6292beb044c8f634e5d528f465a8e16444bc58e4
David Steele [Mon, 30 Oct 2023 19:09:12 +0000 (19:09 +0000)]
Adding debug to shader defs
Change-Id: I14b750acdabb4ba6d96d9b1ab1ab259998e7e15f
David Steele [Thu, 18 May 2023 17:13:00 +0000 (18:13 +0100)]
Updated model loader to handle multiple attr sets
Modified GLTF parser for attributes to create attribute sets
for joints/weights/texcoords/colors
Added macro definitions to ShaderOptions, fixed hash to account for
macro/def strings.
Changed shader manager to create shader with extra attributes
Change-Id: Iabe2772eaf767ca3055dd415752c5a612942f0a4
David Steele [Fri, 13 Oct 2023 14:47:48 +0000 (15:47 +0100)]
Switched joints to use UBO with larger size in PBR shader
Change-Id: I816ff07f89cbbc1983dac65e6472892692f8d138
Eunki, Hong [Tue, 7 Nov 2023 11:13:41 +0000 (20:13 +0900)]
(AnimatedVector) Get marker informations
Let we make API to get marker informations from json file.
Marker information contains name, and pair of frame, start and end.
Change-Id: I21b91368addff66d41a66c14fc8e86076470ddc7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Mon, 6 Nov 2023 07:55:44 +0000 (07:55 +0000)]
Merge "Do not trace image decoding process" into devel/master
Eunki, Hong [Mon, 6 Nov 2023 05:01:35 +0000 (14:01 +0900)]
Do not trace image decoding process
It will be re-open when we can control the log level of trace filter.
Change-Id: I3c374d34e5e602ed9bdce3228656565f15f40511
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 1 Nov 2023 04:18:13 +0000 (13:18 +0900)]
Remove observer from mLoadQueue when we request to remove observer
That might be happen during ResourceReady signal observing
- Add
- Remove
If than, the added request added in mLoadQueue 2 times.
and Remove request try to remove observe there (but will be failed actually.)
So, the visual get LoadCompleted signal twice.
It might have some logical problem in AnimatedImageVisual.
So let we keep ensure that 1-observer can only emit only 1-time.
Change-Id: I3eee087118cf62761709b8416fe09cf52094d156
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 28 Oct 2023 16:17:50 +0000 (01:17 +0900)]
(Vector) Support EncodedImageBuffer can use for vector image
Support to append extension when we use imagetype
For example, if EncodedImageBuffer has VECTOR_IMAGE type, we will generate url
"enbuf://3.svg" So we can use it directly by ImageView -> SvgVisual
And also, let we support Remote animated vector image.
(Since we can load animated vector image by raw buffer.)
Change-Id: I09fd214021507cd8d29bbd3c3720d4427f5eedd7
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sun, 5 Nov 2023 14:41:11 +0000 (23:41 +0900)]
Print image decoding process log level as release
Change-Id: I0f397d1db3975f4aaead4b6ba15d87532fd344c3
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Fri, 3 Nov 2023 17:19:11 +0000 (17:19 +0000)]
Merge "Support glTF extention: KHR_mesh_quantization" into devel/master
Richard Huang [Thu, 26 Oct 2023 14:10:53 +0000 (15:10 +0100)]
Support glTF extention: KHR_mesh_quantization
Change-Id: I23fd7f3f481590f5716452813666cb31161bc8ae
Adeel Kazmi [Fri, 3 Nov 2023 11:14:19 +0000 (11:14 +0000)]
Merge "DALi Version 2.2.51" into devel/master
Richard Huang [Fri, 3 Nov 2023 10:57:53 +0000 (10:57 +0000)]
DALi Version 2.2.51
Change-Id: Ib5f22d0063657d6992e74e19ee15c34234e216cc
Eunki, Hong [Fri, 3 Nov 2023 07:42:30 +0000 (16:42 +0900)]
Register some text property one time. + Shrink custom property count
Change-Id: Ib9508a59dcbeed74d2b9ac5ddd69dbaffd100762
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
sunghyun kim [Wed, 1 Nov 2023 07:33:34 +0000 (07:33 +0000)]
Merge "Apply premultiply when external texture use mask" into devel/master
Eunki Hong [Wed, 1 Nov 2023 06:43:47 +0000 (06:43 +0000)]
Merge "(AnimatedVector) Sync AnimatedVectorRenderer for UTC" into devel/master
sunghyun kim [Wed, 1 Nov 2023 03:53:31 +0000 (12:53 +0900)]
Apply premultiply when external texture use mask
when external texture has alpha value and use mask, premultiply is not
applied.
add that patch to fix this issue
Change-Id: I9103c7a6185ea8c044a3fdfa00a5fc5a5376fe87
Seungho BAEK [Mon, 30 Oct 2023 08:27:51 +0000 (08:27 +0000)]
Merge "Fix unclear naming of member variable and function of FixedImageCache" into devel/master
Eunki Hong [Sat, 28 Oct 2023 17:27:35 +0000 (02:27 +0900)]
(AnimatedVector) Sync AnimatedVectorRenderer for UTC
Apply newly added API - Load(const Dali::Vector<uint8_t>&) in toolkit utc
Change-Id: I31d0886fed3371507a84d4887b12243a3fec2d85
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
seungho baek [Thu, 26 Oct 2023 05:49:29 +0000 (14:49 +0900)]
Fix unclear naming of member variable and function of FixedImageCache
- Some naming of member variable and function have not changed after some logic is changed.
- In current implementation, FixedImageCache not use a concept of front frame.
- This patch fixed such a unclear naming and fixed parameters to match the naming too.
Change-Id: I43baf87b2cb67941aa89e8fd6aadce33c4495565
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Eunki, Hong [Fri, 27 Oct 2023 05:04:05 +0000 (14:04 +0900)]
Add some more logs for images
- Print the size of loaded image
- Print url for SVG and Lottie
- Change the name of VisualUrl property (for line coverage)
Change-Id: I271407112975249c06175875e9430996139f44e4
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Seoyeon Kim [Mon, 30 Oct 2023 00:24:45 +0000 (00:24 +0000)]
Merge "Remove the duplicated call with Focused call" into devel/master
Eunki Hong [Fri, 27 Oct 2023 10:30:43 +0000 (10:30 +0000)]
Merge "Support NativeImageInterface can generate url" into devel/master
David Steele [Fri, 27 Oct 2023 09:35:34 +0000 (10:35 +0100)]
DALi Version 2.2.50
Change-Id: I1ccc9f25a084dbefb87acfd8325bb9b338606a57
Seoyeon Kim [Fri, 27 Oct 2023 05:35:03 +0000 (14:35 +0900)]
Remove the duplicated call with Focused call
- To call `Activate()` of IME is already called in `OnKeyInputFocusGained()`
and `OnKeyInputFocusGained()` is called by `OnTap()`.
- So, IME activate call is called twice unnecessarily.
- Also, IME properties did not be set in `OnTap`,
so the normal layout of input panel shows first,
and then another type of input panel shows again. (Issue)
- Fix this issue to erase to call `Activate` in `OnTap()`.
Change-Id: Ie18b35042b0b7878efd0a8fe3fbbd5da1d3e6def
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Eunki Hong [Thu, 26 Oct 2023 08:20:54 +0000 (17:20 +0900)]
Support NativeImageInterface can generate url
Previously, we only support to generate url only by native image source.
But now, there was some usage to generate url from NativeImageQueue.
Unfortunatly, NativeImageQueue is devel api. So, let we just support
NativeImageInterface instead of NativeImageQueue directly.
Change-Id: I722cc599b6f3d7ddfe7d0727e5a2efcb4c4fb0fb
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Tue, 24 Oct 2023 14:05:43 +0000 (23:05 +0900)]
Ensure blendshape weight between [0..1]
Let we ensure the blendshape weight is between 0 and 1.
So ignore cases when weight value is bigger than 1, less than 0.
Change-Id: I3bdd0a3f59498654e6e7ac65a4a2e665a58a9fcc
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Mon, 23 Oct 2023 11:34:24 +0000 (20:34 +0900)]
Fix minor coverity issues (phase 2)
- Move std::string
- Move std::function
- Move some Property::Map if possible
Change-Id: I1400f02aa30e37b71a8d731d108bdf41acd88e1c
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 23 Oct 2023 03:18:10 +0000 (12:18 +0900)]
Fix randomly failed UTC (2)
Change-Id: I1a7470c05fc2bb65910a643e7da5d4868c44c3f7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 21 Oct 2023 14:35:34 +0000 (23:35 +0900)]
Fix randomly failed UTC
- UtcDaliModelResourceCacheCheck
There was some logical error for that UTC.
- UtcDaliAnimatedImageVisualMultiImage01
It was possible that some AsyncTask can be processed
without event trigger. It is impossible to resolved now.
Until we make toolkit-async-task-manager, just block this UTC.
Change-Id: Id0e3a944d9dc83261180ef1a96faab754626133c
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Fri, 20 Oct 2023 09:19:34 +0000 (09:19 +0000)]
Merge "Remove Rasterize task when svg load failed" into devel/master
Adeel Kazmi [Fri, 20 Oct 2023 06:07:49 +0000 (07:07 +0100)]
DALi Version 2.2.49
Change-Id: Iff66d95be44e2194a361751108e0173bfd691f2d
Eunki, Hong [Thu, 19 Oct 2023 04:10:38 +0000 (13:10 +0900)]
Remove Rasterize task when svg load failed
Since RasterizeTask's IsReady return false; that task will not be removed
forever.
To avoid this useless task keeping, let we remove that task when svg load
failed.
Change-Id: I856fb5c88eac2234253b513b5ba9f772ffd41eba
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Thu, 19 Oct 2023 02:30:20 +0000 (02:30 +0000)]
Merge "Fix ZWJ issue" into devel/master
Bowon Ryu [Tue, 17 Oct 2023 06:36:03 +0000 (15:36 +0900)]
Fix ZWJ issue
Added ZWJ sequence to solve the issue of ZWJ not working.
this patch processes ZWJ as one sequnce.
and this condition has been merged with the previous emoji logic.
Added exception handling in editable environment.
Removed unnecessary variables related to emoji.
Change-Id: Id7825732d96c3e87a8c93b6c2e8d57e057eb7435
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Tue, 17 Oct 2023 07:38:13 +0000 (16:38 +0900)]
Let we use default white IBL image even environment info not exist
When we use ModelNode without model url, we don't follow
environment map load task. So default IBL texture can be 'empty'.
In this case, the PBR shader what dali use default, might do some
strange behaviour.
To guard this cases, let we make all Dali::Scene3D::Model use
non-empty default textures.
Change-Id: I47cd1f5b89f812b2a35c5f4cb5dfb1084b5760a3
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Mon, 16 Oct 2023 11:19:10 +0000 (20:19 +0900)]
Fix minor coverity issues
1. Remove std::string copy
2. Remove Property::Array copy
Change-Id: I9b45c0ff87588a6f79d8ae4a109909c7c016dbdf
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Fri, 13 Oct 2023 13:22:14 +0000 (13:22 +0000)]
Merge "DALi Version 2.2.48" into devel/master
Adam Bialogonski [Fri, 13 Oct 2023 10:06:44 +0000 (11:06 +0100)]
DALi Version 2.2.48
Change-Id: If68564f4b8690d7fdff4f5c3d59e586586c3b07e
Bowon Ryu [Fri, 13 Oct 2023 06:52:58 +0000 (06:52 +0000)]
Merge "Add color tag for text markup anchor" into devel/master
Bowon Ryu [Thu, 12 Oct 2023 11:51:14 +0000 (20:51 +0900)]
Add color tag for text markup anchor
"<a color='blue' clicked-color='red' href='https://www.tizen.org'>TIZEN</a>"
user can set color and clicked color in the anchor tag.
if not set, default color is applied.
Change-Id: I6ed67b3ae4bec414e306d46bc2b70d4c7a87cdf7
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki Hong [Thu, 12 Oct 2023 13:18:47 +0000 (22:18 +0900)]
Fix gcc-13 compile error (std::vector include)
Change-Id: I33ce58c0ee7862d2c5086b3f933128b38a3860ad
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
David Steele [Thu, 12 Oct 2023 10:28:45 +0000 (10:28 +0000)]
Merge "Destroy removal visuals after idler" into devel/master
David Steele [Thu, 12 Oct 2023 10:24:28 +0000 (10:24 +0000)]
Merge "Keep reference when member callback excute + Make NPatchData as RefObject" into devel/master
Eunki, Hong [Wed, 11 Oct 2023 12:53:00 +0000 (21:53 +0900)]
Destroy removal visuals after idler
There was some bug when visual destructor called during
it's emit ResourceReady.
To avoid this case, Let we keep visuals more long term,
and Discard + Destroy after some idler called.
To avoid multiple Idler callback register,
let we make that idler callback in VisualFactory.
Change-Id: Id47083b158f91bb81666d6f2100811dedb0d70f1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Thu, 12 Oct 2023 04:30:21 +0000 (04:30 +0000)]
Merge "Add TextFitArray to text label" into devel/master
Eunki, Hong [Wed, 11 Oct 2023 08:04:44 +0000 (17:04 +0900)]
Keep reference when member callback excute + Make NPatchData as RefObject
Some CallbackBase didn't hold the reference of itself.
So it was possible to call destructor of itself during it's
API was running.
It might makes some unknown issues. So let we keep reference
for some issue-comes known APIs : SvgVisual, NPatchData, and lottie
It future, we should discard visuals rather than delate it directly.
Change-Id: Ibeab31bc309869aa7c2ee65cbff8789e7bb2a721
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
David Steele [Tue, 10 Oct 2023 10:28:01 +0000 (10:28 +0000)]
Merge "Update test harness to use matching build system" into devel/master
Bowon Ryu [Thu, 5 Oct 2023 02:29:45 +0000 (11:29 +0900)]
Add TextFitArray to text label
Add a new function to satisfy the UX that
operates TextFit by considering the PointSize and MinLineSize of the text.
For example, TextFit should be able to find the one that
fits among [PointSize 24 + MinLineSize 40] or [PointSize 28 + MinLineSize 44].
But the previous TextFit only considers PointSize.
TextFitArray can solve this problem,
and this implemented it to respond to additional requirements without modifying the API.
Simple usage:
std::vector<DevelTextLabel::FitOption> fitOptions;
fitOptions.push_back(DevelTextLabel::FitOption(24, 40));
fitOptions.push_back(DevelTextLabel::FitOption(28, 44));
DevelTextLabel::SetTextFitArray(textLabel, true, fitOptions);
Change-Id: Ib608465c8f4c96c56e471f14064e4e2d24377a8f
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki Hong [Mon, 25 Sep 2023 10:21:00 +0000 (19:21 +0900)]
Safety check for control set/get property
Since some workerthread can access and try to get/set control's visual,
we might need to assert if worker thread try to use them.
Note : Current logic might got error if someone try to change API before
app create, but less care for now.
Change-Id: I68cb0ff5b822721a73c4fd40f4b86d21ddf1759f
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Tue, 10 Oct 2023 01:48:09 +0000 (01:48 +0000)]
Merge "(WebView) Set display area and Change Visual when WebView relayout" into devel/master
David Steele [Fri, 6 Oct 2023 12:10:11 +0000 (13:10 +0100)]
DALi Version 2.2.47
Change-Id: I2b52489372e6b17b9cca2a4b6d587d2b91ac60cd
David Steele [Wed, 4 Oct 2023 16:34:08 +0000 (17:34 +0100)]
Update test harness to use matching build system
Change-Id: Ie78bf75496f7fb097afe487ad3a9650d9765ccf3
Adeel Kazmi [Fri, 29 Sep 2023 13:07:41 +0000 (13:07 +0000)]
Merge "(visual-base-impl) Reduce cyclomatic complexity" into devel/master
Richard Huang [Fri, 29 Sep 2023 11:27:40 +0000 (12:27 +0100)]
DALi Version 2.2.46
Change-Id: I1a50e964f0a5bcb1a6d383e1a4cfe505976124e6
Adeel Kazmi [Fri, 29 Sep 2023 11:27:17 +0000 (12:27 +0100)]
(visual-base-impl) Reduce cyclomatic complexity
Change-Id: I37a1f691aa8d3669ec6d08177231e29a748138f9
Adeel Kazmi [Thu, 28 Sep 2023 16:53:15 +0000 (17:53 +0100)]
Reduce Cyclomatic complexity in some text related files
Change-Id: If598f647cd4a1824f67a0e8a033d4ecf9856eb0e
Bowon Ryu [Tue, 26 Sep 2023 08:21:03 +0000 (08:21 +0000)]
Merge "Add GetHeightForWidth for text visual model" into devel/master
Eunki Hong [Tue, 26 Sep 2023 07:06:19 +0000 (07:06 +0000)]
Merge "Make NPatchData always use shared pointer" into devel/master
Bowon Ryu [Tue, 26 Sep 2023 06:50:50 +0000 (15:50 +0900)]
Add GetHeightForWidth for text visual model
Use visual model's GetHeightForWidth instead of GetLayoutSize.
In the case of text label,
the height of the layout is used when returning the cached value of GetHeightForWidth.
But, this value is the height of the layout that has been Ellipsis processed.
It's not the height of the entire Text.
So, the intended height cannot be obtained.
This patch simply stores calculated values.
Change-Id: I0494fb476964fb1207d35e3c8e6eb25ece972025
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Tue, 26 Sep 2023 06:50:32 +0000 (15:50 +0900)]
Revert "Fix GetHeightForWidth for text controller"
This reverts commit
da9f7b93ae00d0aa64a959549ed9da3469a49e46.
Change-Id: I9dbcb715d65c97ff40ba9746caab50ce7231c1af
Bowon Ryu [Tue, 26 Sep 2023 06:13:33 +0000 (06:13 +0000)]
Merge "Fix GetHeightForWidth for text controller" into devel/master
Eunki Hong [Tue, 26 Sep 2023 00:48:45 +0000 (09:48 +0900)]
Make NPatchData always use shared pointer
Let we keep NPatchData user always use shared_ptr instead of raw pointer.
In this case, NPatchData itself will be safe enought even if
NPatchData removed from NPatchLoader cache.
Change-Id: I27db855888bc21c7a7282a9e1114945f3f0e758d
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 20 Sep 2023 02:05:43 +0000 (11:05 +0900)]
(WebView) Set display area and Change Visual when WebView relayout
Previously, we change display area after only at PropertyNotification time.
It will wait until 1 frame rendered.
If we change web view size by event side, the display area applied lately.
This patch make we change update area when OnRelayout, so we can apply
changeness more faster timing.
--
And also, Let we change visual when the size of webview changed.
If so, it can be reduce some flickering effect while change the udpate area.
Change-Id: Ia7d6becc11160d88353f62bbdb43f75764550b67
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Mon, 25 Sep 2023 16:18:19 +0000 (17:18 +0100)]
Reduce LOC of ImageVisual
Change-Id: Ib6ace96a0fafb6f14e35bacb29e9eeac50431883
Bowon Ryu [Thu, 21 Sep 2023 10:06:54 +0000 (19:06 +0900)]
Fix GetHeightForWidth for text controller
In the case of text label,
the height of the layout is used when returning the cached value of GetHeightForWidth.
But, this value is the height of the layout that has been Ellipsis processed.
It's not the height of the entire Text.
So, the intended height cannot be obtained.
This patch simply stores calculated values.
Change-Id: Ia5d06bdac39556776749de3e3078a3a7e230c36c
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki Hong [Mon, 25 Sep 2023 05:15:17 +0000 (05:15 +0000)]
Merge "Remove NPatchLoader observer when they request remove" into devel/master
Seungho BAEK [Mon, 25 Sep 2023 03:12:41 +0000 (03:12 +0000)]
Merge "ImageVisualShaderFactory refactoring" into devel/master