review.tizen.org Git - platform/upstream/v8.git/log

projects / platform / upstream / v8.git / log

olivf@chromium.org [Tue, 17 Sep 2013 13:02:25 +0000 (13:02 +0000)]

Add a mechanism to override the detected cpu features.

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23523060

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16772 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

rodolph.perfetta@gmail.com [Tue, 17 Sep 2013 12:37:31 +0000 (12:37 +0000)]

ARM: Tweak StoreKeyed.

Avoid corrupting its input in some cases.

BUG=none
TEST=test/mjsunit/lithium/StoreKeyed*.js
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/23600054

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Tue, 17 Sep 2013 12:37:22 +0000 (12:37 +0000)]

new gc callbacks with isolate parameters

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24065005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Tue, 17 Sep 2013 12:28:35 +0000 (12:28 +0000)]

Open new handle scope when deep copying.

R=mstarzinger@chromium.org
BUG=292903

Review URL: https://codereview.chromium.org/24201002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Tue, 17 Sep 2013 12:23:12 +0000 (12:23 +0000)]

remove js_accessor_ics flag

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24200002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Tue, 17 Sep 2013 12:22:09 +0000 (12:22 +0000)]

LLoadKeyed does not clobber double anymore.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23890031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Tue, 17 Sep 2013 12:20:41 +0000 (12:20 +0000)]

Ensure constant truncation is only done when it is safe.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23654041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

ulan@chromium.org [Tue, 17 Sep 2013 12:17:47 +0000 (12:17 +0000)]

Adjust Android test runner to push tools/profviz to device.

R=bmeurer@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23567041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16765 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Tue, 17 Sep 2013 11:54:32 +0000 (11:54 +0000)]

Fix i18n compilation after r16762.

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/23653041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16764 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Tue, 17 Sep 2013 11:37:48 +0000 (11:37 +0000)]

reland 16744: add context save for GenerateFastApiCall

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23903053

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Tue, 17 Sep 2013 11:34:20 +0000 (11:34 +0000)]

Handlify JSReceiver::HasProperty and friends.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23496058

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Tue, 17 Sep 2013 11:27:24 +0000 (11:27 +0000)]

Remove unused HIsNumberAndBranch instruction.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23691067

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16761 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Tue, 17 Sep 2013 11:01:43 +0000 (11:01 +0000)]

Handlify JSReceiver::SetProperty and friends.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23601031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16758 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Tue, 17 Sep 2013 10:57:18 +0000 (10:57 +0000)]

Don't run tests with the profiler when USE_SIMULATOR is defined.

BUG=v8:2874
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23710063

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16757 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Tue, 17 Sep 2013 10:34:30 +0000 (10:34 +0000)]

Revert "ARM: Add tests for CopyBytes."

This reverts commit r16751 for breaking arm.debug checks.

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/24198002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16756 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Tue, 17 Sep 2013 10:27:19 +0000 (10:27 +0000)]

Ensure escape analysis preserves boxed HeapNumber.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/23940005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Tue, 17 Sep 2013 09:09:44 +0000 (09:09 +0000)]

Fix typo in x64 disassembler.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23902039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

ulan@chromium.org [Tue, 17 Sep 2013 09:01:12 +0000 (09:01 +0000)]

ARM: Add tests for CopyBytes.

TEST=cctest/test-macro-assembler-arm.cc

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23480027

Patch from Bangfu Tao <bangfu.tao@samsung.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16751 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Tue, 17 Sep 2013 08:55:38 +0000 (08:55 +0000)]

Fix handling of Integer32 in HLoadNamedField and HStoreNamedField on x64.

The current implementation of Integer32 named loads and stores
is broken on x64.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/23548039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

jochen@chromium.org [Tue, 17 Sep 2013 08:31:56 +0000 (08:31 +0000)]

Use icu_gyp_path variable to reference ICU gyp file

That way, embedders can put the icu sources whereever they want and
aren't forced to put them under third_party/gyp

BUG=none
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23598011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Tue, 17 Sep 2013 07:53:56 +0000 (07:53 +0000)]

revert 16744 for breaking build

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24196002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

svenpanne@chromium.org [Tue, 17 Sep 2013 07:29:26 +0000 (07:29 +0000)]

Refactoring only: Make it clear that MOD is special.

LArithmeticD should really be 5 different instructions... :-/

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23800005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Tue, 17 Sep 2013 07:19:50 +0000 (07:19 +0000)]

add context save for GenerateFastApiCall

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23461039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16744 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

palfia@homejinni.com [Mon, 16 Sep 2013 21:59:00 +0000 (21:59 +0000)]

MIPS: Orthogonalize Lithium binary op instructions.

Port r16739 (cd8e4a21)

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23494054

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16743 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mvstanton@chromium.org [Mon, 16 Sep 2013 16:50:41 +0000 (16:50 +0000)]

Chromium 284577 needs a mitigation CL added. There is a TODO to remove
the mitigation when the cause of the bug is discovered.

BUG=
R=hpayer@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23606032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16742 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Mon, 16 Sep 2013 16:09:07 +0000 (16:09 +0000)]

Fix compile error.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23651012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16741 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Mon, 16 Sep 2013 15:34:46 +0000 (15:34 +0000)]

Add mutex when accessing concurrent recompilation output queue.

Also small refactorings.

R=mstarzinger@chromium.org
BUG=291236

Review URL: https://codereview.chromium.org/23902033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16740 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Mon, 16 Sep 2013 15:24:49 +0000 (15:24 +0000)]

Orthogonalize Lithium binary op instructions.

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23703014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16739 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

loislo@chromium.org [Mon, 16 Sep 2013 15:19:41 +0000 (15:19 +0000)]

HeapProfiler: compile fix for win x64.

BUG=none
TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/24178003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16738 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Mon, 16 Sep 2013 14:50:01 +0000 (14:50 +0000)]

Don't lookup the cache for the result of Function::New

Since isFunctionCached condition is wrong, we lookup the cache even if
doNotCache is true. As a result, Function::New always returns null
except for the first time.

BUG=272579
R=dcarney@chromium.org, mstarzinger@chromium.org, yhirano@chromium.org

Review URL: https://codereview.chromium.org/23513048

Patch from Yusuke Suzuki <yusukesuzuki@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16737 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

svenpanne@chromium.org [Mon, 16 Sep 2013 14:09:22 +0000 (14:09 +0000)]

Revert "Add flags to force or prevent setting of isolate.is_memory_constrained."

It introduces static initializers for the new "MAYBE_BOOL" kind of
flags, which is a no-no for Chrome. This has to be done differently.

TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/23621044

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

svenpanne@chromium.org [Mon, 16 Sep 2013 13:51:14 +0000 (13:51 +0000)]

In the case of shift amounts with two constants and if their sum is equal 32, then shift can also be replaced with bit rotate.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/24095002

Patch from Bangfu Tao <bangfu.tao@samsung.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

loislo@chromium.org [Mon, 16 Sep 2013 13:13:42 +0000 (13:13 +0000)]

HeapSnapshot: replace O(N*ln(N)) algorithm of sorting with O(N) one.

We have HashMap for the strings. They got id sequentially. So we could use index sort.

BUG=none
R=alph@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/24174002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16734 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

svenpanne@chromium.org [Mon, 16 Sep 2013 13:02:53 +0000 (13:02 +0000)]

Add flags to force or prevent setting of isolate.is_memory_constrained.

Also enable MAYBE_BOOL flags for when you want to only do something if the flag was explicitly set to true or false.

BUG=None
R=hpayer@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23890027

Patch from Ross McIlroy <rmcilroy@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

titzer@chromium.org [Mon, 16 Sep 2013 12:44:28 +0000 (12:44 +0000)]

Make HValue::ActualValue() traverse all idefs.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23691064

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

danno@chromium.org [Mon, 16 Sep 2013 12:41:05 +0000 (12:41 +0000)]

Tweak HConstant::EmitAtUses() to eliminate useless constant generation

BUG=2881
R=danno@chromium.org

Review URL: https://codereview.chromium.org/23811011

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16731 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Mon, 16 Sep 2013 12:38:41 +0000 (12:38 +0000)]

Make HCompareNumericAndBranch safe for snapshots on ia32.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/24078012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16730 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

svenpanne@chromium.org [Mon, 16 Sep 2013 12:08:30 +0000 (12:08 +0000)]

Fixed shared_library build on Windows.

BUG=v8:2879
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/24054008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16729 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Mon, 16 Sep 2013 11:30:10 +0000 (11:30 +0000)]

Remove unused context parameter from AddIncrementCounter().

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23622033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

rodolph.perfetta@gmail.com [Mon, 16 Sep 2013 11:28:18 +0000 (11:28 +0000)]

ARM: Tweak the integer division operation.

BUG=none
TEST=test/mjsunit/lithium/DivI.js
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23536045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

verwaest@chromium.org [Mon, 16 Sep 2013 09:30:43 +0000 (09:30 +0000)]

Rename StubType MAP_TRANSITION to TRANSITION.

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24120007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16726 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

loislo@chromium.org [Mon, 16 Sep 2013 09:16:03 +0000 (09:16 +0000)]

HeapProfiler: replace pointer based matching algorithm with string matching algorithm for strings_ member.

pros: decreased snapshot size.
cons: increased serialization time.

I've tested the implementation on gmail 90mb heap.
I saw no speed degradation on the serialization step.
The snapshot size lost ~3% of its size. 100Mb -> 97Mb.

BUG=none
R=alph@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/24120006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16725 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mvstanton@chromium.org [Mon, 16 Sep 2013 07:32:10 +0000 (07:32 +0000)]

Prepare push to trunk. Now working on version 3.21.17.

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23437040

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16722 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

plind44@gmail.com [Fri, 13 Sep 2013 15:28:15 +0000 (15:28 +0000)]

MIPS: remove getcurrent from stubs.

Port r16710 (c5203f8)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/23710046

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16721 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

plind44@gmail.com [Fri, 13 Sep 2013 15:22:45 +0000 (15:22 +0000)]

MIPS: Improve SeqStringSetChar implementation.

Port r16707 (a25d669)

TEST=/test/mjsunit/lithium/SeqStringSetChar.js
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/23484043

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mvstanton@chromium.org [Fri, 13 Sep 2013 13:50:16 +0000 (13:50 +0000)]

Every place where AllocationMemento is initialized with an
AllocationSite is now checked to be sure a valid Site goes in.

This is temporary code to diagnose chromium bug 284577.

(This is a second attempt, the first attempt ran into the problem of undefined ordering of function calls in Windows and Mac optimized builds, see the fixes in code-stubs-hydrogen.cc).

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23440035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16719 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Fri, 13 Sep 2013 13:45:53 +0000 (13:45 +0000)]

revert 16717 for breaking everything

TBR=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23708039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16718 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Fri, 13 Sep 2013 12:49:57 +0000 (12:49 +0000)]

line up crashing with chrome

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23868025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16717 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

titzer@chromium.org [Fri, 13 Sep 2013 12:35:36 +0000 (12:35 +0000)]

Add Contains(), at(), and a constructor with raw addresses to UniqueSet<T> and Unique<T>.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23872027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Fri, 13 Sep 2013 12:02:50 +0000 (12:02 +0000)]

Add missing factory method for HDebugBreak.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23619052

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16715 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Fri, 13 Sep 2013 12:01:32 +0000 (12:01 +0000)]

Intel: Branch reordering and port arm EmitNumberUntagD() Improvement

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23872026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16714 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

hpayer@chromium.org [Fri, 13 Sep 2013 11:47:54 +0000 (11:47 +0000)]

Fix heap verifier for partially constructed arrays when allocation folding is off.

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23934008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

verwaest@chromium.org [Fri, 13 Sep 2013 11:14:02 +0000 (11:14 +0000)]

Don't update ICs when the receiver has a deprecated map.

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23658047

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Fri, 13 Sep 2013 10:35:35 +0000 (10:35 +0000)]

remove OS::StackWalk

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23703013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dcarney@chromium.org [Fri, 13 Sep 2013 10:23:04 +0000 (10:23 +0000)]

remove getcurrent from stubs

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23756009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16710 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

verwaest@chromium.org [Fri, 13 Sep 2013 09:57:48 +0000 (09:57 +0000)]

Use regular map-checks to guard string-length loading.

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23702039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Fri, 13 Sep 2013 09:51:11 +0000 (09:51 +0000)]

Handlify JSObject::DeepCopy method.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22934006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Fri, 13 Sep 2013 09:13:58 +0000 (09:13 +0000)]

ARM: Improve SeqStringSetChar implementation.

TEST=/test/mjsunit/lithium/SeqStringSetChar.js
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23890007

Patch from Rodolph Perfetta <rodolph.perfetta@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16707 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mvstanton@chromium.org [Fri, 13 Sep 2013 08:44:37 +0000 (08:44 +0000)]

Revert "Every place where AllocationMemento is initialized with an"

This reverts r16705 for breaking Windows build.

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/23447031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mvstanton@chromium.org [Fri, 13 Sep 2013 08:13:17 +0000 (08:13 +0000)]

Every place where AllocationMemento is initialized with an
AllocationSite is now checked to be sure a valid Site goes in.
This is temporary code to diagnose chromium bug 284577.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23622029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

rossberg@chromium.org [Fri, 13 Sep 2013 08:13:02 +0000 (08:13 +0000)]

Array "splice" changeRecords should be emitted after the performChange has completed (per spec)

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23434008

Patch from Rafael Weinstein <rafaelw@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16704 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

rossberg@chromium.org [Fri, 13 Sep 2013 08:09:39 +0000 (08:09 +0000)]

Allow implicit conversion of acceptList values to string during Object.observe

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23464058

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16703 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Fri, 13 Sep 2013 07:59:48 +0000 (07:59 +0000)]

Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23654026

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16702 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dslomov@chromium.org [Fri, 13 Sep 2013 07:15:02 +0000 (07:15 +0000)]

Prepare push to trunk. Now working on version 3.21.16.

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23437033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16699 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

palfia@homejinni.com [Fri, 13 Sep 2013 00:10:24 +0000 (00:10 +0000)]

MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite were being passed the undefined object in some cases. Clearly separate the cases where we have an AllocationSite and where we don't in the general ArrayConstructorStub.

Port r16693 (0852d4ab)

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23451057

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16698 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

palfia@homejinni.com [Fri, 13 Sep 2013 00:04:29 +0000 (00:04 +0000)]

MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1.

Port r16688 (fcae0bcf)

Original commit message:
The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23513045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16697 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

verwaest@chromium.org [Thu, 12 Sep 2013 22:04:04 +0000 (22:04 +0000)]

Reland Handle non-JSObject heap objects using slow-path IC stub guarded by the map.

R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23578030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

palfia@homejinni.com [Thu, 12 Sep 2013 21:17:43 +0000 (21:17 +0000)]

MIPS: Improve code generation for the HRandom instruction.

Port r16684 (e0f70aa)

Original commit message:
Since the per-context random number generator is now
properly seeded upon context creation, we do not need
to check for lazy-initialization anymore, and so we
can implement the HRandom instruction w/o having to
call into the C function (which means we don't need
to MarkAsCall anymore).

TEST=cctest/test-random
BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23851028

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

palfia@homejinni.com [Thu, 12 Sep 2013 20:11:26 +0000 (20:11 +0000)]

MIPS: Fix of r16681

Use v0 for return value.

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23437032

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mvstanton@chromium.org [Thu, 12 Sep 2013 17:59:41 +0000 (17:59 +0000)]

Bugfix: array constructors that expect a type feedback cell that points
to an AllocationSite were being passed the undefined object in some
cases. Clearly separate the cases where we have an AllocationSite and
where we don't in the general ArrayConstructorStub.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23477071

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16693 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

verwaest@chromium.org [Thu, 12 Sep 2013 16:57:37 +0000 (16:57 +0000)]

Revert "Handle non-JSObject heap objects using slow-path IC stub guarded by the map."

TBR=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23475039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16692 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Thu, 12 Sep 2013 16:17:58 +0000 (16:17 +0000)]

Reland "Clean up after r16292 (disable optimization for StringWrappers)."

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/23619036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16691 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Thu, 12 Sep 2013 16:14:38 +0000 (16:14 +0000)]

NumberUntagD is faster when untagging in a temp register

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/23684056

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16690 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

verwaest@chromium.org [Thu, 12 Sep 2013 16:12:04 +0000 (16:12 +0000)]

Handle non-JSObject heap objects using slow-path IC stub guarded by the map.

BUG=chromium:280632
R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23691056

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Thu, 12 Sep 2013 14:32:14 +0000 (14:32 +0000)]

Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1.

The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=dcarney@chromium.org, mstarzinger@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16673

Review URL: https://codereview.chromium.org/23620036

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16688 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

jochen@chromium.org [Thu, 12 Sep 2013 13:50:38 +0000 (13:50 +0000)]

Snapshot i18n Javascript code

The previous attempt used Boolean instead of $Boolean.

BUG=v8:2745
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23622028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16687 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Thu, 12 Sep 2013 13:27:42 +0000 (13:27 +0000)]

Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes.

R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16642

Review URL: https://codereview.chromium.org/24093002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16686 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

titzer@chromium.org [Thu, 12 Sep 2013 13:09:33 +0000 (13:09 +0000)]

Fix compile error with CLANG.

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23475038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16685 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Thu, 12 Sep 2013 12:12:01 +0000 (12:12 +0000)]

Improve code generation for the HRandom instruction.

Since the per-context random number generator is now
properly seeded upon context creation, we do not need
to check for lazy-initialization anymore, and so we
can implement the HRandom instruction w/o having to
call into the C function (which means we don't need
to MarkAsCall anymore).

TEST=cctest/test-random
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23478031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

titzer@chromium.org [Thu, 12 Sep 2013 12:08:54 +0000 (12:08 +0000)]

First implementation of HUnique<T> and HUniqueSet<T>, which is supposed to replace UniqueValueId.

BUG=
R=rossberg@chromium.org, verwaest@chromium.org

Review URL: https://codereview.chromium.org/23609020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16683 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Thu, 12 Sep 2013 11:54:47 +0000 (11:54 +0000)]

Reland "Fix phis for non-sse2 double values"

Remove VerifyX87StackDepth from non-debug code.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23621038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16682 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Thu, 12 Sep 2013 11:30:56 +0000 (11:30 +0000)]

Simplify installing concurrently recompiled code.

Instead of overwriting the code entry of the function, we trigger
an interrupt to install the code on the main thread.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23542029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Thu, 12 Sep 2013 11:18:10 +0000 (11:18 +0000)]

Revert "Fix phis for non-sse2 double values"

Need to investigate box2d regression.

BUG=
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23437028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16680 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Thu, 12 Sep 2013 11:15:12 +0000 (11:15 +0000)]

Revert "Clean up after r16292 (disable optimization for StringWrappers)."

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23600040

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16679 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

ulan@chromium.org [Thu, 12 Sep 2013 11:03:27 +0000 (11:03 +0000)]

Implement in-place rehashing of HashTable.

The algorithm puts elements into correct positions in multiple iterations.
On the first iteration it tries to put elements at entries specified by
their first hash probe. On the second iteration -- by the second
hash probe, and so on. Overall it does O(k*n) memory accesses, where
k is the maximum number of probes required for an element and n is the
capacity of the hash table. The expectation is that k will be small.

R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23658031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Thu, 12 Sep 2013 10:55:57 +0000 (10:55 +0000)]

Clean up after r16292 (disable optimization for StringWrappers).

R=jochen@chromium.org
BUG=v8:2855

Review URL: https://codereview.chromium.org/22891028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16677 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

rodolph.perfetta@gmail.com [Thu, 12 Sep 2013 10:37:42 +0000 (10:37 +0000)]

ARM: remove the regexp specific literal pool.

It is replaced by a mov_label_offset(Register, Label*) instruction.

BUG=none
TEST=test/cctest/test-assembler-arm.cc
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23515007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Thu, 12 Sep 2013 10:03:56 +0000 (10:03 +0000)]

Revert "Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1."

TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/23431019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16675 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

yangguo@chromium.org [Thu, 12 Sep 2013 09:47:02 +0000 (09:47 +0000)]

Unnecessay SSE2 check on x64

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23619033

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16674 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Thu, 12 Sep 2013 09:09:39 +0000 (09:09 +0000)]

Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1.

The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=dcarney@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23620036

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Thu, 12 Sep 2013 09:05:27 +0000 (09:05 +0000)]

Fix phis for non-sse2 double values

Since hydrogen will try to merge phi-inputs using registers, even if
the values are spilled, we cannot mark LGoto as double clobbering
instruction.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23068038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16671 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

bmeurer@chromium.org [Thu, 12 Sep 2013 08:57:10 +0000 (08:57 +0000)]

Reland "Deuglify V8_INLINE and V8_NOINLINE."

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/23604054

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16669 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

dslomov@chromium.org [Thu, 12 Sep 2013 08:52:29 +0000 (08:52 +0000)]

Prepare push to trunk. Now working on version 3.21.15.

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23653031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16668 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

olivf@chromium.org [Thu, 12 Sep 2013 07:49:03 +0000 (07:49 +0000)]

Add a missing instruction to the ia32 disassembler.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23451024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16667 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

machenbach@chromium.org [Thu, 12 Sep 2013 07:39:44 +0000 (07:39 +0000)]

Revert "Increase test timeout on slow architectures."

This reverts commit 200c7cbdbc90ec2001ee4e0da7470cb508585e0d.

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23475036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

machenbach@chromium.org [Thu, 12 Sep 2013 07:38:37 +0000 (07:38 +0000)]

Mark flaky tests for arm.

Makes the whole test-api a non-tree-closer on arm.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23961006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16665 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Wed, 11 Sep 2013 20:04:51 +0000 (20:04 +0000)]

Revert "Fix leftover usage of OS::Allocate()."

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23691049

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16664 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

adamk@chromium.org [Wed, 11 Sep 2013 20:03:54 +0000 (20:03 +0000)]

Add access check for observed objects

This change is mostly straightforward: for 'normal' sorts of change records,
simply don't deliver a changeRecord to a given observer callback if an access
the callback's Context is not allowed to "GET" or "HAS" changeRecord.name on
changeRecord.object, or if ACCESS_KEYS is disallowed.

For 'splice' records, the question of whether to hand it to an observer is trickier, since
there are multiple properties involved, and multiple types of possible information leakage.
Given that access-checked objects are very rare (only two in Blink, Window and Location),
and that they are not normally used as Arrays, it seems better to simply not emit any splice
records for such objects rather than spending lots of logic to attempt to avoid information
leakage for something that may never happen.

BUG=v8:2778
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/22962009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16663 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Wed, 11 Sep 2013 18:30:01 +0000 (18:30 +0000)]

Revert r16648, r16641, r16638 and r16637.

Original descriptions were:
- "Refactor and cleanup VirtualMemory."
- "Fix typo."
- "Deuglify V8_INLINE and V8_NOINLINE."
- "Don't align size on allocation granularity for unaligned ReserveRegion calls."

Reasons for the revert are:
- Our mjsunit test suite slower by a factor of 5(!) in release mode.
- Flaky cctest/test-alloc/CodeRange on all architectures and platforms.
- Tankage of Sunspider by about 6% overall (unverified).

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23970004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16662 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

commit | commitdiff | tree

mstarzinger@chromium.org [Wed, 11 Sep 2013 16:27:41 +0000 (16:27 +0000)]

Revert "Unify computation of load stubs in stub cache."

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/24095005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16661 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

Domain: Web Framework / Web Engine;

RSS Atom