review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

borenet@google.com [Fri, 25 Jan 2013 20:55:35 +0000 (20:55 +0000)]

Manually parse arguments in submit_try

Argparse not supported with Python < 2.7.
Review URL: https://codereview.appspot.com/7206054

git-svn-id: http://skia.googlecode.com/svn/trunk@7403 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 20:25:30 +0000 (20:25 +0000)]

Whitespace change to test (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7402 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

vandebo@chromium.org [Fri, 25 Jan 2013 19:27:23 +0000 (19:27 +0000)]

[PDF] Handle invalid glyph IDs on drawText methods.

Review URL: https://codereview.appspot.com/7179053

git-svn-id: http://skia.googlecode.com/svn/trunk@7401 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 25 Jan 2013 19:19:20 +0000 (19:19 +0000)]

Fix nextRangeU(0, MAX_UINT) div by zero.

R=reed@google.com
Review URL: https://codereview.appspot.com/7201058

git-svn-id: http://skia.googlecode.com/svn/trunk@7400 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 18:27:34 +0000 (18:27 +0000)]

Presubmit should check that source files end in atleast one newline
Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 18:26:58 +0000 (18:26 +0000)]

Leave one and only one newline at the end of source files
Review URL: https://codereview.appspot.com/7216043

git-svn-id: http://skia.googlecode.com/svn/trunk@7398 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 25 Jan 2013 18:25:17 +0000 (18:25 +0000)]

Avoid O(n) stack space usage in qsort.

git-svn-id: http://skia.googlecode.com/svn/trunk@7397 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 25 Jan 2013 17:49:49 +0000 (17:49 +0000)]

reduce array size in debug builds for sortbench. This avoids a stack-overflow
due to (1) SkTQSort's bad behavior on repeated-keys, and (2) windows-debug doesn't
implement tail-recursion.

Not an issue, since we don't care about perf in our debug builds anyway.

git-svn-id: http://skia.googlecode.com/svn/trunk@7396 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 25 Jan 2013 17:49:03 +0000 (17:49 +0000)]

Move random from core to utils
Review URL: https://codereview.appspot.com/7193064

git-svn-id: http://skia.googlecode.com/svn/trunk@7395 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 15:28:23 +0000 (15:28 +0000)]

Whitespace change to test (SkipBuildbotRuns) locally

git-svn-id: http://skia.googlecode.com/svn/trunk@7394 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 25 Jan 2013 15:03:18 +0000 (15:03 +0000)]

Only clear the part of the texture used by the device (duh!)

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7205055

git-svn-id: http://skia.googlecode.com/svn/trunk@7393 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 25 Jan 2013 14:52:11 +0000 (14:52 +0000)]

doh: use *srcPtr instead of src (which is now obsolete) when we check for specialLine

git-svn-id: http://skia.googlecode.com/svn/trunk@7392 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 25 Jan 2013 14:47:48 +0000 (14:47 +0000)]

Hid large dashed line optimization behind compiler flag

https://codereview.appspot.com/7133078/

git-svn-id: http://skia.googlecode.com/svn/trunk@7391 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 13:30:20 +0000 (13:30 +0000)]

Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7390 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 13:09:15 +0000 (13:09 +0000)]

Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7388 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 12:16:34 +0000 (12:16 +0000)]

Triggering rebuilds after r7386

git-svn-id: http://skia.googlecode.com/svn/trunk@7387 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 25 Jan 2013 07:06:46 +0000 (07:06 +0000)]

Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7385 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Fri, 25 Jan 2013 04:54:41 +0000 (04:54 +0000)]

Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7384 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 24 Jan 2013 22:31:01 +0000 (22:31 +0000)]

Remove ConcaveToTriangles.

git-svn-id: http://skia.googlecode.com/svn/trunk@7383 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 24 Jan 2013 22:18:56 +0000 (22:18 +0000)]

Bottom-up heapsort.
https://codereview.appspot.com/7199050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7382 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 22:09:06 +0000 (22:09 +0000)]

fix missing-case-statement warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7381 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Thu, 24 Jan 2013 21:47:16 +0000 (21:47 +0000)]

shape ops work in progress

first 100,000 random cubic/cubic intersections working

git-svn-id: http://skia.googlecode.com/svn/trunk@7380 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 24 Jan 2013 21:38:51 +0000 (21:38 +0000)]

Modify submit_try to work on windows
Review URL: https://codereview.appspot.com/7199053

git-svn-id: http://skia.googlecode.com/svn/trunk@7379 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 21:03:11 +0000 (21:03 +0000)]

add optional cull-rect to patheffects, so they can do less work if their results
lie outside of the current clip-bounds (the cull rect).
Review URL: https://codereview.appspot.com/7206044

git-svn-id: http://skia.googlecode.com/svn/trunk@7378 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 24 Jan 2013 20:47:18 +0000 (20:47 +0000)]

Fix SampleApp ANGLE mode.
Review URL: https://codereview.appspot.com/7206052

git-svn-id: http://skia.googlecode.com/svn/trunk@7377 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 24 Jan 2013 19:00:02 +0000 (19:00 +0000)]

Fix spelling error.

git-svn-id: http://skia.googlecode.com/svn/trunk@7376 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 18:43:32 +0000 (18:43 +0000)]

change giantdashline test to use 4 intervals, to explicitly avoid the asPoints
special case code (which we may test separately later).

git-svn-id: http://skia.googlecode.com/svn/trunk@7375 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 18:37:53 +0000 (18:37 +0000)]

doh. drawRRect is not on SkDevice.... yet

git-svn-id: http://skia.googlecode.com/svn/trunk@7374 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 24 Jan 2013 18:28:51 +0000 (18:28 +0000)]

Fix logic bug introduced in r7346.

git-svn-id: http://skia.googlecode.com/svn/trunk@7373 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 18:27:42 +0000 (18:27 +0000)]

override drawOval and drawRRect in GatherPixelRefDevice, so we don't miss those,
and possibly crash trying to raster into an empty device.

http://code.google.com/p/skia/issues/detail?id=1086
Review URL: https://codereview.appspot.com/7193057

git-svn-id: http://skia.googlecode.com/svn/trunk@7372 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 17:33:21 +0000 (17:33 +0000)]

update to emphasis the culling aspect of the test (making the line much longer,
and adding hairline and non-hairline cases.)

git-svn-id: http://skia.googlecode.com/svn/trunk@7371 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 17:17:28 +0000 (17:17 +0000)]

add bench for giant dashed lines, to test future optimizations for culling

git-svn-id: http://skia.googlecode.com/svn/trunk@7368 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 24 Jan 2013 16:56:36 +0000 (16:56 +0000)]

use DEF_BENCH for clarity

git-svn-id: http://skia.googlecode.com/svn/trunk@7367 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 24 Jan 2013 16:38:23 +0000 (16:38 +0000)]

Remove method calls on invalid "this" pointer.
https://codereview.appspot.com/7198050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7366 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 24 Jan 2013 15:45:35 +0000 (15:45 +0000)]

The oval path bench tests used to draw a circle, but I changed them to an oval
so that we could track performance changes for ovals. However, rendering the
stroked oval cases are now ~5ms slower since they're larger. This restores them
to something close to their original performance by slightly shrinking the
bounds. This will help determine what effect r7304 may have had.

git-svn-id: http://skia.googlecode.com/svn/trunk@7365 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 24 Jan 2013 15:06:47 +0000 (15:06 +0000)]

Fix sort test.
https://codereview.appspot.com/7199050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7364 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Thu, 24 Jan 2013 15:01:22 +0000 (15:01 +0000)]

Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7363 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 24 Jan 2013 14:46:47 +0000 (14:46 +0000)]

Make all GrContext members that return a texture also ref the texture for the caller.
Review URL: https://codereview.appspot.com/7198049

git-svn-id: http://skia.googlecode.com/svn/trunk@7362 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

junov@chromium.org [Thu, 24 Jan 2013 14:38:23 +0000 (14:38 +0000)]

Move code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv

The purpose of this code move is to make it re-usable in order to implement
occlusion culling optimizations in SkPicture similar to what we have now
in SkDeferredCanvas.

BUG=https://code.google.com/p/chromium/issues/detail?id=164530
Review URL: https://codereview.appspot.com/7196046

git-svn-id: http://skia.googlecode.com/svn/trunk@7361 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 24 Jan 2013 07:06:13 +0000 (07:06 +0000)]

Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7357 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Thu, 24 Jan 2013 04:15:57 +0000 (04:15 +0000)]

Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7356 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Jan 2013 21:37:01 +0000 (21:37 +0000)]

Add deferred count to GrResource.

This will be used to determine whether a resource can either be deleted or reinserted in the cache when its ref count reaches zero.
Review URL: https://codereview.appspot.com/7202046

git-svn-id: http://skia.googlecode.com/svn/trunk@7355 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Jan 2013 21:32:32 +0000 (21:32 +0000)]

Fix bug introduced in r7348, deleting wrapped resources.

git-svn-id: http://skia.googlecode.com/svn/trunk@7354 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 23 Jan 2013 20:54:29 +0000 (20:54 +0000)]

Replace gcl_try with submit_try

submit_try supports both git and svn and hooks directly into depot_tools rather
than calling it in a subprocess.
Review URL: https://codereview.appspot.com/7202044

git-svn-id: http://skia.googlecode.com/svn/trunk@7352 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bensong@google.com [Wed, 23 Jan 2013 20:51:17 +0000 (20:51 +0000)]

Changes per-tile bench values to use the average of repetitions from new bench log output.
Corresponding logs change was done at https://codereview.appspot.com/7101060/ and this CL needs to be submitted together with that one for data consistency. Then we can turn on timePerTile.
Review URL: https://codereview.appspot.com/7193051

git-svn-id: http://skia.googlecode.com/svn/trunk@7351 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 23 Jan 2013 20:45:26 +0000 (20:45 +0000)]

Reverse sense of convex-quad-fix compiler flag

https://codereview.appspot.com/7206045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7349 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Jan 2013 20:25:22 +0000 (20:25 +0000)]

Make GrResource know whether 3D objects' lifetimes are managed by Skia or not.
Review URL: https://codereview.appspot.com/7201046

git-svn-id: http://skia.googlecode.com/svn/trunk@7348 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 23 Jan 2013 20:12:31 +0000 (20:12 +0000)]

Revert r7341

git-svn-id: http://skia.googlecode.com/svn/trunk@7347 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Jan 2013 19:53:46 +0000 (19:53 +0000)]

Reland r7342 with fixes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7346 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Jan 2013 19:09:06 +0000 (19:09 +0000)]

Revert 7342 to investigate failures.

git-svn-id: http://skia.googlecode.com/svn/trunk@7345 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Wed, 23 Jan 2013 18:56:38 +0000 (18:56 +0000)]

Update Android toolchain to NDK r8d with GCC 4.7

Review URL: https://codereview.appspot.com/7201045

git-svn-id: http://skia.googlecode.com/svn/trunk@7343 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Jan 2013 18:29:21 +0000 (18:29 +0000)]

Add GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer.

A future CL will do the unref'ing of GrResources when converting a GrDrawState to a DeferredState.
Review URL: https://codereview.appspot.com/7181049

git-svn-id: http://skia.googlecode.com/svn/trunk@7342 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 23 Jan 2013 16:08:15 +0000 (16:08 +0000)]

If getAdvance fails, getAdvanceData should not assert, but ignored.
Review URL: https://codereview.appspot.com/7127056

git-svn-id: http://skia.googlecode.com/svn/trunk@7341 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 23 Jan 2013 15:37:56 +0000 (15:37 +0000)]

add alias for MakeFromIRect (just Make)

git-svn-id: http://skia.googlecode.com/svn/trunk@7340 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Wed, 23 Jan 2013 15:31:43 +0000 (15:31 +0000)]

Use Skia style cast in SkDeviceProperties.
(Alternative to 7329.)

git-svn-id: http://skia.googlecode.com/svn/trunk@7339 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 23 Jan 2013 14:52:12 +0000 (14:52 +0000)]

add rand10 bench for sort, which makes 10% of the entries repeats
reorder sort tests to make comparisons easier to read

git-svn-id: http://skia.googlecode.com/svn/trunk@7338 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Wed, 23 Jan 2013 14:35:58 +0000 (14:35 +0000)]

Display a warning prompt in presubmit if the tree status is in 'Caution'.

Example presubmit output:

Running presubmit upload checks ...

** Presubmit Warnings **
Tree state is: caution

***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************

There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043

git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Wed, 23 Jan 2013 13:40:40 +0000 (13:40 +0000)]

Ensure that streams written using SkFlattenableBuffer's can be read with readByteArray(...)

Review URL: https://codereview.appspot.com/7138063

git-svn-id: http://skia.googlecode.com/svn/trunk@7335 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 23 Jan 2013 07:06:17 +0000 (07:06 +0000)]

Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7332 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Wed, 23 Jan 2013 05:47:03 +0000 (05:47 +0000)]

Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7331 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Wed, 23 Jan 2013 02:23:40 +0000 (02:23 +0000)]

add bench for sorting

git-svn-id: http://skia.googlecode.com/svn/trunk@7330 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 23 Jan 2013 01:46:26 +0000 (01:46 +0000)]

Speculative fix for cros_daisy compilation failure

include/core/SkDeviceProperties.h:82:51: error: narrowing conversion of '(((int)orientation) | ((int)layout))' from 'int' to 'uint8_t

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7329 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 23 Jan 2013 00:36:02 +0000 (00:36 +0000)]

Fix for oversight in r7325

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7328 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Jan 2013 22:04:13 +0000 (22:04 +0000)]

Remove declaration of unimplemented function.

git-svn-id: http://skia.googlecode.com/svn/trunk@7327 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Jan 2013 20:35:13 +0000 (20:35 +0000)]

Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7188046

git-svn-id: http://skia.googlecode.com/svn/trunk@7326 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 22 Jan 2013 20:29:16 +0000 (20:29 +0000)]

Fix bug in 1xN SkBitmapProcShader optimization

https://codereview.appspot.com/7187047/

git-svn-id: http://skia.googlecode.com/svn/trunk@7325 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Jan 2013 20:10:17 +0000 (20:10 +0000)]

Fix r7321 build errors on non-windows compilers (using forward declared but not defined class in templated function).

git-svn-id: http://skia.googlecode.com/svn/trunk@7324 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 22 Jan 2013 20:00:01 +0000 (20:00 +0000)]

Fix Android only code in SkDraw for 7317.

git-svn-id: http://skia.googlecode.com/svn/trunk@7322 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Jan 2013 19:55:59 +0000 (19:55 +0000)]

Let them eat GrEffectRef.

Changes the remaining existing code that operates on naked GrEffects to GrEffectRef.
Review URL: https://codereview.appspot.com/7124058

git-svn-id: http://skia.googlecode.com/svn/trunk@7321 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 22 Jan 2013 19:49:33 +0000 (19:49 +0000)]

Fix VC++ warning and Android only code for 7317.

git-svn-id: http://skia.googlecode.com/svn/trunk@7319 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 22 Jan 2013 19:38:46 +0000 (19:38 +0000)]

Added multi-select deletion to debugger

https://codereview.appspot.com/7190043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7318 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 22 Jan 2013 19:25:14 +0000 (19:25 +0000)]

Expose geometry and gamma on device.
https://codereview.appspot.com/6499101/

git-svn-id: http://skia.googlecode.com/svn/trunk@7317 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Tue, 22 Jan 2013 18:23:56 +0000 (18:23 +0000)]

Add wrapper for "gcl try"

Adds some validation for --bot
Review URL: https://codereview.appspot.com/7179048

git-svn-id: http://skia.googlecode.com/svn/trunk@7315 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 22 Jan 2013 18:03:56 +0000 (18:03 +0000)]

Fix saving modified skp from debugger

https://codereview.appspot.com/7181048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7314 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

junov@chromium.org [Tue, 22 Jan 2013 18:01:26 +0000 (18:01 +0000)]

Simple Build fix. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7313 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

junov@chromium.org [Tue, 22 Jan 2013 17:50:47 +0000 (17:50 +0000)]

Fixing invalid text clipping on SkPicture playback

The bug was caused by an invalid assumption that a flattend object's
index is related to its array index in SkFlatDictionary::fData.
The data in SkFlatDictionary is sorted by flattened data content,
not by index number. Problem was solved by passing down the SkFlatData*
through addPaint, rather than the index value. The bug was causing
SkPictureRecord::addFontMetricsTopBottom to use cached font metrics
from the wrong SkPaint instance.

BUG=https://code.google.com/p/chromium/issues/detail?id=170964
Review URL: https://codereview.appspot.com/7178045

git-svn-id: http://skia.googlecode.com/svn/trunk@7312 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 22 Jan 2013 14:32:09 +0000 (14:32 +0000)]

Added toString to SkXfermode-derived classes (for debugger)

https://codereview.appspot.com/7139058/

git-svn-id: http://skia.googlecode.com/svn/trunk@7308 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Tue, 22 Jan 2013 13:54:52 +0000 (13:54 +0000)]

Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type.

git-svn-id: http://skia.googlecode.com/svn/trunk@7307 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Tue, 22 Jan 2013 13:34:01 +0000 (13:34 +0000)]

Add GPU support for axis-aligned ovals:
- Add drawOval base function to SkDevice, and override in SkGpuDevice
- Move isSimilarityMatrix to SkMatrix (renamed to isSimilarity) and fixed up unit test
- Since both SkGpuDevice::drawOval() and GrContext::drawPath() can try to draw ovals, added GrContext::canDrawOval() and GrContext::internalDrawOval() to avoid duplicate code
- Hooked in axis-aligned oval fill shader
- Enabled GPU stroked circles
- Added stroked circle bench test

Review URL: https://codereview.appspot.com/7137050

git-svn-id: http://skia.googlecode.com/svn/trunk@7304 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Tue, 22 Jan 2013 12:55:54 +0000 (12:55 +0000)]

shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7303 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 21 Jan 2013 21:48:58 +0000 (21:48 +0000)]

Place fix in r7278 behind compile flag

git-svn-id: http://skia.googlecode.com/svn/trunk@7300 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Mon, 21 Jan 2013 21:18:14 +0000 (21:18 +0000)]

Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7299 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 21 Jan 2013 21:17:16 +0000 (21:17 +0000)]

Placing 1xN bitmap shader opt behind a flag to delay WebKit rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@7298 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Mon, 21 Jan 2013 03:43:21 +0000 (03:43 +0000)]

Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7297 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Sun, 20 Jan 2013 16:22:24 +0000 (16:22 +0000)]

Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7296 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sun, 20 Jan 2013 07:05:51 +0000 (07:05 +0000)]

Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7295 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Sat, 19 Jan 2013 13:22:39 +0000 (13:22 +0000)]

shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7294 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 19 Jan 2013 07:05:38 +0000 (07:05 +0000)]

Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7293 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Sat, 19 Jan 2013 04:56:36 +0000 (04:56 +0000)]

Fix bugs in r7291
TBR=reed
Review URL: https://codereview.appspot.com/7129057

git-svn-id: http://skia.googlecode.com/svn/trunk@7292 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Sat, 19 Jan 2013 04:21:27 +0000 (04:21 +0000)]

re-land r7258 with fixes and tests
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=reed
Review URL: https://codereview.appspot.com/7132060

git-svn-id: http://skia.googlecode.com/svn/trunk@7291 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 18 Jan 2013 21:53:12 +0000 (21:53 +0000)]

Partial revert of r7287 to green up the bots.

git-svn-id: http://skia.googlecode.com/svn/trunk@7290 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 18 Jan 2013 21:45:42 +0000 (21:45 +0000)]

Roll out r7258
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=robertphillips
Review URL: https://codereview.appspot.com/7138065

git-svn-id: http://skia.googlecode.com/svn/trunk@7289 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 18 Jan 2013 21:20:16 +0000 (21:20 +0000)]

Update gyp revision.
Now allows out-of-source output directories.

git-svn-id: http://skia.googlecode.com/svn/trunk@7288 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 18 Jan 2013 20:48:20 +0000 (20:48 +0000)]

(Relanding r7275 with assert fix, plus fixes from r7276, r7280, r7283.)

Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture. (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome). It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.

Committed: https://code.google.com/p/skia/source/detail?r=7275

Review URL: https://codereview.appspot.com/7033049

git-svn-id: http://skia.googlecode.com/svn/trunk@7287 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 18 Jan 2013 20:03:58 +0000 (20:03 +0000)]

gm self-test: followup to r7284
TBR=rmistry
Review URL: https://codereview.appspot.com/7128056

git-svn-id: http://skia.googlecode.com/svn/trunk@7286 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 18 Jan 2013 19:20:52 +0000 (19:20 +0000)]

Reverting chain of SkBicubicImageFilter changes (7275, 7276, 7280 & 7283)

git-svn-id: http://skia.googlecode.com/svn/trunk@7285 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 18 Jan 2013 19:19:47 +0000 (19:19 +0000)]

make gm self-test more robust
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7164043

git-svn-id: http://skia.googlecode.com/svn/trunk@7284 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 18 Jan 2013 18:31:19 +0000 (18:31 +0000)]

fix unused-variable warning in src/effects/SkBicubicImageFilter.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@7283 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 18 Jan 2013 18:06:22 +0000 (18:06 +0000)]

tools.gyp: dependencies in apfabetical order
Review URL: https://codereview.appspot.com/7127055

git-svn-id: http://skia.googlecode.com/svn/trunk@7281 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 18 Jan 2013 17:56:31 +0000 (17:56 +0000)]

Removed unused variable in SkBicubicImageFilter.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@7280 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom