Milan Crha [Sat, 8 Dec 2012 09:01:56 +0000 (10:01 +0100)]
Enable introspection scanner warnings
Matthew Barnes [Fri, 7 Dec 2012 23:04:42 +0000 (18:04 -0500)]
Add missing linker flag.
Milan Crha [Fri, 7 Dec 2012 21:48:39 +0000 (22:48 +0100)]
Introduce evolution-user-prompter service
This is used to prompt users for input, mainly from book or calendar
backends. The service is extensible, thus the backend can provide its
own dialogs and use them.
Tristan Van Berkom [Fri, 7 Dec 2012 09:00:42 +0000 (18:00 +0900)]
Fixed test-client-custom-summary to actually pass
Was missing a vcard modification to test for EVC_N component, also
enhanced test case to test both apis for each case and added one
case to check the special '%' escape char is working.
Tristan Van Berkom [Fri, 9 Nov 2012 09:33:03 +0000 (18:33 +0900)]
Reviving async client test
Now test-client-async.c also tests adding of contacts to a newly created book,
instead of relying on the system book.
Matthew Barnes [Thu, 6 Dec 2012 14:11:03 +0000 (09:11 -0500)]
Add e_queue_transfer().
Transfers the contents of one GQueue on to the tail of another GQueue.
Mostly because I'm tired of writing "while" loops, and this does it more
efficiently anyway.
Mathias Hasselmann [Thu, 6 Dec 2012 13:14:40 +0000 (14:14 +0100)]
tests: Add configured datadir to the D-Bus dirs
This helps to really pick the locally built factories for tests,
without the need to fiddle with XDG_DATA_DIRS. Ideally we'd even use
service files for the currently build's uninstalled service binaries,
but that seems too much work right now.
Mathias Hasselmann [Thu, 6 Dec 2012 12:51:23 +0000 (13:51 +0100)]
tests: Port test-client-custom-summary.c to gtest
Less copy-and-paste, easier to extend, more intuitive messages
on failed assertions, and one missing assertion caught.
Mathias Hasselmann [Thu, 6 Dec 2012 12:19:30 +0000 (13:19 +0100)]
tests: Use absolute paths for SRCDIR
That way a few tests can be run from top_builddir, instead of their builddir.
Daniel Mustieles [Wed, 5 Dec 2012 19:07:14 +0000 (20:07 +0100)]
Updated Spanish translation
Milan Crha [Wed, 5 Dec 2012 07:46:58 +0000 (08:46 +0100)]
Do not generate a ChangeLog file from 'git log'
Milan Crha [Wed, 5 Dec 2012 07:18:41 +0000 (08:18 +0100)]
Fix a script name (with-session-bus-eds.sh) in a Makefile.am
Mathias Hasselmann [Wed, 5 Dec 2012 00:00:01 +0000 (01:00 +0100)]
api-docs: Fix two small typos
Nilamdyuti Goswami [Tue, 4 Dec 2012 09:23:14 +0000 (14:53 +0530)]
Assamese translation updated
Milan Crha [Mon, 3 Dec 2012 17:55:52 +0000 (18:55 +0100)]
Bug #371469 - Add port to connection refused error messages
Milan Crha [Mon, 3 Dec 2012 17:16:21 +0000 (18:16 +0100)]
Bug #512714 - Error string "Host lookup failed: Name or Service not known"
Milan Crha [Mon, 3 Dec 2012 12:27:33 +0000 (13:27 +0100)]
Bug #529743 - Add "Any header" filter and search folder condition
Dr.T.Vasudevan [Sun, 2 Dec 2012 09:54:41 +0000 (15:24 +0530)]
Updated Tamil translation
Dr.T.Vasudevan [Sun, 2 Dec 2012 09:39:12 +0000 (15:09 +0530)]
Updated Tamil translation
Dr.T.Vasudevan [Sun, 2 Dec 2012 08:53:08 +0000 (14:23 +0530)]
Updated Tamil translation
Milan Crha [Fri, 30 Nov 2012 10:06:18 +0000 (11:06 +0100)]
Fix few issues found by Coverity scan
Milan Crha [Fri, 30 Nov 2012 07:38:21 +0000 (08:38 +0100)]
Fix Copy&Paste error found by Coverity scan
Tristan Van Berkom [Thu, 29 Nov 2012 11:34:25 +0000 (20:34 +0900)]
Adding test case for e_book_client_get_contacts_uids()
Tristan Van Berkom [Thu, 29 Nov 2012 11:32:15 +0000 (20:32 +0900)]
Extending test-client-custom-summary to try e_book_client_get_contacts_uids()
Tristan Van Berkom [Thu, 29 Nov 2012 10:07:39 +0000 (19:07 +0900)]
EBookBackendSqliteDB: Fix e_book_backend_sqlitedb_search_uids()
Since we started using table aliases, this API was missed.
Milan Crha [Thu, 29 Nov 2012 11:19:34 +0000 (12:19 +0100)]
ESourceRegistry: Disconnect signal handlers from GSettings in dispose
Matthew Barnes [Wed, 28 Nov 2012 19:31:24 +0000 (14:31 -0500)]
Use version-based GLib/GDK/GTK+ warnings.
Use GLIB_VERSION_MAX_ALLOWED and GDK_VERSION_MAX_ALLOWED to warn if we
accidentally use symbols that were introduced in versions subsequent to
our minimum requirement.
Use GLIB_VERSION_MIN_REQUIRED and GDK_VERSION_MIN_REQUIRED to suppress
deprecation warnings by version so we can clean them up incrementally.
The initial values produce no deprecation warnings.
Matthew Barnes [Wed, 28 Nov 2012 20:18:19 +0000 (15:18 -0500)]
EFlag: Suppress deprecation warning on g_cond_timed_wait().
Milan Crha [Wed, 28 Nov 2012 14:30:15 +0000 (15:30 +0100)]
Bug #671620 - Support signing with multiple OpenPGP keys
Milan Crha [Wed, 28 Nov 2012 11:43:33 +0000 (12:43 +0100)]
Bug #688366 - WebDAV book can cause high CPU usage
This fixes two issues:
a) high CPU on invalid XML response from a server
b) ensures priv->uri ends with a forward slash, thus new contacts are created
inside given folder, not on the same level as the folder
Krishnababu Krothapalli [Wed, 28 Nov 2012 10:02:28 +0000 (15:32 +0530)]
Updated Telugu Translations
Murray Cumming [Tue, 27 Nov 2012 12:13:15 +0000 (13:13 +0100)]
addressbook tests: Update the path to the service
Murray Cumming [Tue, 28 Jun 2011 09:12:56 +0000 (11:12 +0200)]
addressbook tests: Run with private D-Bus session and environment.
* tests/: Add a tools/ directory with .sh files from
libfolks/tests/tools/, to let us start and stop a private D-Bus
session, and set XDG_* environment variables for local use of EDS,
when running tests.
* tests/libebook/client/Makefile.am: Set TESTS_ENVIRONMENT to
run the tests with the private D-Bus session.
Paul Menzel [Tue, 27 Nov 2012 08:30:09 +0000 (09:30 +0100)]
Bug #684175 - Check email value in e_destination_set_contact()
Tristan Van Berkom [Mon, 26 Nov 2012 12:19:07 +0000 (21:19 +0900)]
Fix regression on fields-of-interest as much as possible.
Since the new summary configurations normalize summary column
values, it's become impossible to construct contacts from summary
columns, however this is untrue for the UID & REV fields which are
not normalized, for those fields it's still possible to construct
contacts from the summary (and UID / REV is anyway the main known use
case of the fields-of-interest feature).
Nilamdyuti Goswami [Mon, 26 Nov 2012 10:14:57 +0000 (15:44 +0530)]
Assamese translation updated
Matthew Barnes [Sat, 24 Nov 2012 02:13:07 +0000 (21:13 -0500)]
Simplify e_contact_attr_list_free().
g_list_free_full() makes it a one-liner.
Matthew Barnes [Sat, 24 Nov 2012 02:11:26 +0000 (21:11 -0500)]
Simplify e_contact_attr_list_copy().
g_list_copy_deep() makes it a one-liner.
Daniele Rondina [Fri, 23 Nov 2012 13:07:51 +0000 (14:07 +0100)]
Bug #688926 - SIGABRT on call_old_file_Sync
Tristan Van Berkom [Fri, 23 Nov 2012 09:45:33 +0000 (18:45 +0900)]
EBookBackendSqliteDB: Avoid errors on conflicting summaries
Added function introspect_summary() to derive the summary information
from a running database.
Now the initialization of the DB is a bit safer:
o First collect configured summary
o Create Database (if it doesnt exist) with the configured summary
o Now derive the summary from the existing database
This ensures that inserts/selects run with the summary configuration
which matches the actual running database, regardless if the DB was
configured with the actual ESourceBackendSummarySetup passed or previously
configured with something else.
Milan Crha [Thu, 22 Nov 2012 16:13:49 +0000 (17:13 +0100)]
Bug #688795 - Crash under e_cal_backend_contacts_start_view()
Milan Crha [Thu, 22 Nov 2012 15:15:55 +0000 (16:15 +0100)]
Bug #202576 - A way to refresh IMAP folder list
Nilamdyuti Goswami [Thu, 22 Nov 2012 14:17:43 +0000 (19:47 +0530)]
Assamese translation updated
Daniel Mustieles [Thu, 22 Nov 2012 10:30:02 +0000 (11:30 +0100)]
Updated Spanish translation
Tristan Van Berkom [Tue, 20 Nov 2012 06:40:59 +0000 (15:40 +0900)]
EBookBackendSexp: Fixed to use the new e_util_utf8_normalize() function
Tristan Van Berkom [Mon, 8 Oct 2012 07:43:06 +0000 (16:43 +0900)]
Added test case to create a book with custom summary fields and fetch a contact.
This test case configures some summary fields and indexes and then performs
some queries and asserts the results. Notably the configured summary uses multi valued
fields E_CONTACT_TEL and E_CONTACT_EMAIL.
Some extra vcards are added to the test data directory in order to have some
mixed up emails and phone numbers to test with
Tristan Van Berkom [Wed, 7 Nov 2012 08:31:10 +0000 (17:31 +0900)]
EBookBackendFile: Use the new ESourceBackendSummarySetup to configure the summary
Tristan Van Berkom [Wed, 7 Nov 2012 08:19:57 +0000 (17:19 +0900)]
EBookBackendSqliteDB: Added e_book_backend_sqlitedb_new_full()
This is a major refactor of EBookBackendSqliteDB and adds a few
features. The new_full() variant for creating the SQLiteDB makes
the summary fields and indexes configurable.
String types, Boolean Types and Attribute List types of EContactFields
are all supported by the summary.
The summary fields can all have Prefix or Suffix indexes.
In order to actually hit the created indexes, all field data
is normalized with g_utf8_casefold(), for Suffix indexes,
additional columns are maintained with the data in reverse
(this allows us to run prefix searches in reverse which use
the indexes when asked to perform a suffix search)
Furthermore the patch also deprecates:
e_book_backend_sqlitedb_is_summary_query () and
e_book_backend_sqlitedb_is_summary_fields ()
in favour of some new apis which take the given EBookBackendSqliteDB in context.
Note also that since attribute list summary fields are supported,
we've dropped the custom hackery which checks related email_1, email_2, email_3
and email_4 fields... instead the E_CONTACT_EMAIL field should simply
be used to store however many emails are assigned to a given contact.
Tristan Van Berkom [Mon, 8 Oct 2012 05:18:10 +0000 (14:18 +0900)]
Added ESourceBackendSummarySetup extension
Firstly this extension allows configuration which EContactFields
should be indexed as "summary fields".
Secondly, the configured summary fields can have indexes, those indexes
can be of type PREFIX or SUFFIX
Tristan Van Berkom [Mon, 19 Nov 2012 11:19:43 +0000 (20:19 +0900)]
Added e_util_utf8_normalize()
A utility function to lowercase/remove accents from a utf8 string
Tristan Van Berkom [Mon, 15 Oct 2012 06:45:35 +0000 (15:45 +0900)]
Added e_enum_from_string() and e_enum_to_string() utilities in e-data-server-utiils
Milan Crha [Wed, 21 Nov 2012 18:56:44 +0000 (19:56 +0100)]
Bug #680201 - Backup restore doesn't migrate accounts from GConf
Milan Crha [Wed, 21 Nov 2012 16:55:15 +0000 (17:55 +0100)]
Bug #687670 - Signing with both pgp and S/MIME causes a broken signature
Milan Crha [Wed, 21 Nov 2012 11:34:29 +0000 (12:34 +0100)]
Bug #677378 - Crash in imapx_query_auth_types_sync()
Milan Crha [Tue, 20 Nov 2012 19:08:15 +0000 (20:08 +0100)]
Bug #688479 - Empty name selector dialog on open
Paul Menzel [Tue, 20 Nov 2012 17:59:05 +0000 (18:59 +0100)]
Bug 688639 – SMTP: Correctly deal with 535 authentication error
Entering a wrong password, Evolution would fail to send messages using SMTP with the following error.
Bad authentication response from server.
The log file of the mail server – Exim 4 in this case – contains the following error.
cram_md5_server authenticator failed for myhost.example.org ([10.10.10.10]) [xx.xxx.xxx.xxx]: 535 Incorrect authentication data (set_id=joey)
Looking at the code after the rewrite in
commit
68c269a66bd484768b9c1517e7dc2dd30f682485
Author: Matthew Barnes <mbarnes@redhat.com>
Date: Sat Oct 15 09:51:35 2011 -0400
smtp: Adapt to Camel's new authentication API.
present since git tag EVOLUTION_DATA_SERVER_3_3_1, accidentally changed the logic not acting correctly, when receiving a 535 authentication error response and therefore was overridden by the next code block and the variable `result` changed to `CAMEL_AUTHENTICATION_ERROR` instead of `CAMEL_AUTHENTICATION_REJECTED`, which resulted in the situation where the password was not reset and therefore the user not asked to reenter it.
Changing the logic, so the variable is not overridden successfully fixes the issue.
Milan Crha [Tue, 20 Nov 2012 15:35:41 +0000 (16:35 +0100)]
Bug #688660 - Crash on webdav contact cache update
Daniel Mustieles [Tue, 20 Nov 2012 14:50:30 +0000 (15:50 +0100)]
Updated Spanish translation
Tristan Van Berkom [Thu, 8 Nov 2012 08:13:07 +0000 (17:13 +0900)]
Fixing e_book_backend_sexp_match_contact() for emails and phone numbers
This patch fixes the match function to match any phone number or email
found in a given vcard, not only the restrictive list of phone number
and email types defined in the EContactField enumeration.
Tristan Van Berkom [Fri, 5 Oct 2012 09:35:05 +0000 (18:35 +0900)]
EContact: Added boxed type E_CONTACT_TYPE_ATTR_LIST and e_contact_field_type()
This boxed type is used in place of pointer types for properties
installed on EContact which are returned lists of strings.
This does not effect the behavior of e_contact_set()/e_contact_get(),
only it allows e_contact_field_type() to return a distinct type
for those fields, allowing automated code to introspect those useful
contact field types.
The e_contact_field_type() convenience function is used to fetch the GType
for a given field when used with EContact (this allows more automated
routines to be written for EContactFields).
Matthew Barnes [Sun, 18 Nov 2012 12:50:49 +0000 (07:50 -0500)]
ECalClientView cleanups.
Let ECalClientView create its own D-Bus proxy object by implementing
GInitableIface and adding "connection" and "object-path" construct-only
GObject properties.
This eliminates e-cal-client-view-private.h and adds the following
public accessor functions:
e_cal_client_view_get_connection()
e_cal_client_view_get_object_path()
Matthew Barnes [Sat, 17 Nov 2012 22:47:00 +0000 (17:47 -0500)]
EBookClientView cleanups.
Let EBookClientView create its own D-Bus proxy object by implementing
GInitableIface and adding "connection" and "object-path" construct-only
GObject properties.
This eliminates e-book-client-view-private.h and adds the following
public accessor functions:
e_book_client_view_get_connection()
e_book_client_view_get_object_path()
Matthew Barnes [Sat, 17 Nov 2012 20:04:49 +0000 (15:04 -0500)]
Fix EBookClient property fetching crack.
Matthew Barnes [Sat, 17 Nov 2012 13:57:38 +0000 (08:57 -0500)]
Post-release version bump.
Matthew Barnes [Sat, 17 Nov 2012 13:31:49 +0000 (08:31 -0500)]
NEWS update for 3.7.2 release.
Matthew Barnes [Sat, 17 Nov 2012 13:33:51 +0000 (08:33 -0500)]
Missed a couple files when removing EBookBackendVCF.
Matthew Barnes [Sat, 17 Nov 2012 12:54:37 +0000 (07:54 -0500)]
Remove EBookBackendVCF.
Strolling through the commit history of this backend, I had to dig all
the way back to 2005 before I started seeing actual development work.
Since then the commits have all been code cleanups and adapting it to
backend API changes.
There is no way to create a VCF address book from Evolution, which means
this entire backend is dead code and we've been wasting our time with it.
Dump it.
Matthew Barnes [Fri, 16 Nov 2012 19:16:45 +0000 (14:16 -0500)]
Deprecate BOOK_BACKEND_PROPERTY_SUPPORTED_AUTH_METHODS.
This property is not used anywhere.
Remove all references to it from built-in backends.
The following EBook functions now simply return an empty list:
e_book_get_supported_auth_methods
e_book_async_get_supported_auth_methods
e_book_get_supported_auth_methods_async
Milan Crha [Fri, 16 Nov 2012 08:59:51 +0000 (09:59 +0100)]
Bug #674454 - Crash in e_book_backend_ldap_authenticate_user()
Milan Crha [Wed, 14 Nov 2012 22:37:24 +0000 (23:37 +0100)]
Replace deprecated Gtk+ symbols (as of Gtk+ 3.6.x)
Milan Crha [Tue, 13 Nov 2012 15:58:49 +0000 (16:58 +0100)]
Bug #688146 - Crash in Contacts calendar backend
Paul Menzel [Tue, 13 Nov 2012 13:02:38 +0000 (14:02 +0100)]
Bug #687634 - Improve camel console warning text
Milan Crha [Tue, 13 Nov 2012 07:37:40 +0000 (08:37 +0100)]
Bug #687865 - Shows old reminders for GOA accounts
Matthew Barnes [Tue, 13 Nov 2012 00:17:29 +0000 (19:17 -0500)]
Revert "EBookBackendGoogle: Make room for other authorizers."
This reverts commit
a5dae1a780f898ab453f574440ca02e108b4ebef.
Actually no, don't want to do that. Misread the code.
Matthew Barnes [Mon, 12 Nov 2012 23:56:10 +0000 (18:56 -0500)]
EBookBackendGoogle: Make room for other authorizers.
Christian Kirbach [Mon, 12 Nov 2012 21:49:34 +0000 (22:49 +0100)]
Update German translation
Matthew Barnes [Mon, 12 Nov 2012 16:44:11 +0000 (11:44 -0500)]
EDataBookFactory: Remove the GOA-specific bits.
Defer to the gnome-online-accounts module. See the previous commit.
Matthew Barnes [Mon, 12 Nov 2012 16:38:45 +0000 (11:38 -0500)]
gnome-online-accounts: Add an EDataFactory extension.
This extension takes over for the GOA bits in EDataBookFactory.
Install this extension to both the addressbook and calendar backend
directories, even though only EBookBackendGoogle uses it at present.
Matthew Barnes [Mon, 12 Nov 2012 14:31:16 +0000 (09:31 -0500)]
EDataFactory: Add a "backend-created" signal.
Allows EDataFactory extensions to catch newly-created backends and
perform additional initialization on it.
The use case I have in mind is to move all the GOA initialization in
EDataBookFactory to the gnome-online-accounts module as an extension.
Note this uses one of the reserved pointer slots in EDataFactoryClass
and therefore does not break ABI.
Matthew Barnes [Mon, 12 Nov 2012 11:54:26 +0000 (06:54 -0500)]
Remove unused OAUTH_CFLAGS / OAUTH_LIBS.
Missed these when I removed the liboauth dependency.
Matthew Barnes [Sat, 10 Nov 2012 02:54:46 +0000 (21:54 -0500)]
Coding style and whitespace cleanup.
Piotr Drąg [Fri, 9 Nov 2012 23:29:49 +0000 (00:29 +0100)]
Updated POTFILES.in
Matthew Barnes [Fri, 9 Nov 2012 16:25:13 +0000 (11:25 -0500)]
EBookBackendSqliteDB cleanups.
Improve error handling and make commits/rollbacks less awkward.
Matthew Barnes [Fri, 9 Nov 2012 12:49:33 +0000 (07:49 -0500)]
Use g_type_ensure() where applicable.
Matthew Barnes [Fri, 9 Nov 2012 11:29:21 +0000 (06:29 -0500)]
CamelIMAPXServer: Work around crash in imapx_exit_idle().
g_cond_clear() doesn't like being given an uninitialized GCond.
The "start_watch_cond" and "start_watch_exit" structures are being
cleared unconditionally, so we should initialize them unconditionally.
Matej Urbančič [Thu, 8 Nov 2012 20:36:46 +0000 (21:36 +0100)]
Updated Slovenian translation
Matthew Barnes [Thu, 8 Nov 2012 13:30:22 +0000 (08:30 -0500)]
Restore e_flag_timed_wait().
Just deprecate the function, don't delete it. GTimeVal isn't going
away any time soon. It's not worth a libedataserver soname bump.
Tristan Van Berkom [Thu, 8 Nov 2012 11:28:06 +0000 (20:28 +0900)]
Disabled debug print in EBookBackendFile
This was somehow missed in my last commit.
Tristan Van Berkom [Mon, 29 Oct 2012 06:33:09 +0000 (15:33 +0900)]
Local file backend modified to use sqlite db exclusively
Patch includes a migration routine to migrate data from a previously
installed BDB.
Tristan Van Berkom [Mon, 29 Oct 2012 05:40:47 +0000 (14:40 +0900)]
EBookBackendSqliteDB: Added e_book_backend_sqlitedb_get/set_revision()
In preperation for the migration, there needs to be a way to persist the
overall addressbook revision. This patch also increments the internal
SQLite DB format version and adds the new revision column to for main
folders table of an addressbook (and increments the stored DB version)
if the DB version is out of date.
Tristan Van Berkom [Mon, 29 Oct 2012 05:34:55 +0000 (14:34 +0900)]
EBookBackendSqliteDB: Fixed sexp interpretation for 'id' field.
In the sqlite backend, the 'id' is stored as the 'uid' column.
Matthew Barnes [Wed, 7 Nov 2012 13:31:52 +0000 (08:31 -0500)]
Revert "calendar: Drop old ECalSourceTypeEnum from introspected API"
This reverts commit
3183733023f022a89980cbf3f7292bde0bbd9954.
We no longer introspect deprecated API. Remove the cruft.
Matthew Barnes [Wed, 7 Nov 2012 12:53:56 +0000 (07:53 -0500)]
Disable runtime check in source_registry_initable_init().
Rationale explained in the source code.
Dan Williams [Wed, 7 Nov 2012 11:59:51 +0000 (06:59 -0500)]
Bug 687694 - imapx_untagged_vanished() is inefficient
For uid->len = 318320, timing the loop yields:
g_list_append(): 60+ seconds
g_list_prepend(): 0.3 seconds
Milan Crha [Wed, 7 Nov 2012 12:08:51 +0000 (13:08 +0100)]
Bug #687642 - Crash under caldav_synch_slave_loop()
Andreas Kohn [Wed, 7 Nov 2012 11:32:28 +0000 (12:32 +0100)]
Bug #669082 - Workaround crash in imapx_command_copy_messages_step_done()
Giovanni Campagna [Sun, 28 Oct 2012 15:24:46 +0000 (16:24 +0100)]
Google: allow writing X-GOOGLE-SYSTEM-GROUP-IDS
We expose GData system groups as an extended attribute with that
name, but if we found it in the EContact we would turn it into
an extended property. Instead, marshal the system group IDs into
Evolution categories, and then those into GData groups or system
groups.
https://bugzilla.gnome.org/show_bug.cgi?id=687051
Milan Crha [Tue, 6 Nov 2012 17:58:12 +0000 (18:58 +0100)]
Bug #687776 - E-D-S crash in local address book
Milan Crha [Tue, 6 Nov 2012 10:07:07 +0000 (11:07 +0100)]
Introduce --enable-strict configure option
This is currently used to add extra AM_CPPFLAGS to disable
deprecated symbols from GLib.
Kjartan Maraas [Mon, 5 Nov 2012 20:06:43 +0000 (21:06 +0100)]
Updated Norwegian bokmål translation