Krzysztof Wicher [Thu, 5 Apr 2018 00:27:09 +0000 (17:27 -0700)]
reenable test cases disabled in 27740 (dotnet/corefx#28829)
Commit migrated from https://github.com/dotnet/corefx/commit/
9695cbbd8d9779e50177c672913f32567ea3f14e
Paulo Janotti [Wed, 4 Apr 2018 23:54:06 +0000 (16:54 -0700)]
Re-enable PostAsync_RedirectWith307_LargePayload dotnet/corefx#23768 (dotnet/corefx#28828)
Fixes dotnet/corefx#23768
Commit migrated from https://github.com/dotnet/corefx/commit/
28dcece5c5e7d30446ae90e027076722513b716f
dotnet-maestro-bot [Wed, 4 Apr 2018 23:45:54 +0000 (18:45 -0500)]
Update BuildTools, CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-02704-01, preview3-26404-06, preview3-26404-01, beta-26404-00, beta-26404-00, respectively (dotnet/corefx#28826)
Commit migrated from https://github.com/dotnet/corefx/commit/
c7d405571636eec1485872f7163a1b7f41641ac7
Stephen Toub [Wed, 4 Apr 2018 23:15:27 +0000 (16:15 -0700)]
Delete unnecessary long.MinValue formatting code (dotnet/corefx#28820)
The argument for this code is that -long.MinValue overflows to -long.MinValue, but casting -long.MinValue to ulong does the "right thing".
Commit migrated from https://github.com/dotnet/corefx/commit/
85062446c4e5af0c205f646e0ae720e160b20e85
Santiago Fernandez Madero [Wed, 4 Apr 2018 22:26:23 +0000 (17:26 -0500)]
Update netfx queues to use rs3 machines with .net471 installed (dotnet/corefx#28572)
* Update netfx queues to use rs3 machines with .net471 installed
* Use Open queue for CI runs
* Official build netfx queues to RS2 to match CI runs
* Disable BinaryFormatterTests.ValidateAgainstBlobs for NETFX
* Fix RSA EncrypDecrypt test for netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
5d669ef9823a20ec589fc3b7d47a7f5aa1070893
Alexandre Teoi [Wed, 4 Apr 2018 21:40:07 +0000 (18:40 -0300)]
Rethrown exception call stack tests (dotnet/corefx#28059)
* Added tests to verify the reported call stacks for rethrown exceptions, as specified by dotnet/coreclrdotnet/corefx#15780.
1. Exception rethrown in a method different than the method where it was originally thrown: the stack trace contains both the location in the method where the exception was originally thrown, and the location where the method that threw the exception was called.
2. Exception is thrown and later rethrown in the same method: the stack trace only contains the location where the exception was originally thrown and does not include the location where the exception was rethrown.
* - Make test work with full framework. Test will fail after porting dotnet/coredotnet/corefx#15780 to full framework.
- Fixed variable name
* Write reported call stack to console
Writing call stack to console to debug test errors on NETFX and Linux.
* Add netfx configuration to test project
* Remove redundant throw
A redundant throw in "ThrowAndRethrowOtherMethod" was being removed by the optimizer and causing error in exception line calculation.
* Remove full call stack verification
Verify only the rethrown stack frame due to inconsistencies found on build/release exception call stacks - https://github.com/dotnet/corefx/pull/28059#issuecomment-
378335456
Commit migrated from https://github.com/dotnet/corefx/commit/
8d2f167da549322f0ed41b5fafa5c735aaf7d62e
Koundinya Veluri [Wed, 4 Apr 2018 21:12:30 +0000 (14:12 -0700)]
Enable a thread pool bound handle test on uap (dotnet/corefx#28824)
Commit migrated from https://github.com/dotnet/corefx/commit/
76be44e809eedda866d66c218df7e1076d6f98f2
Stephen Toub [Wed, 4 Apr 2018 20:04:25 +0000 (13:04 -0700)]
Update WhenAllOrAnyFailed test helper with aggregation timeout (dotnet/corefx#28811)
I suspect that some of the sporadic failures we've seen in CI in networking tests have included misleading exceptions. This is an attempt to address that.
A bunch of our tests use a WhenAllOrAnyFailed helper. It's used in situations where we have a client task and server task, and we want to wait for both of them to complete, but because they interact with each other, we don't want to deadlock in a situation where one of them failing means the other will never complete. However, since the helper ends up propagating the exception from whichever completes first, it also means in some situations, for example, the client might fail with an exception that highlights the real reason for the overall failure, but we could end up recording the exception the server then incurs due to the client tearing down the connection.
This commit modifies the helper. On the success path where both tasks complete successfully, nothing is different. On the failure path, though, rather than just immediately propagating the first exception we got, we wait for up to 3 seconds for additional tasks to complete. Once either they've all completed or we've reached the timeout, we then loop through all of the tasks and gather up all of the exceptions, and propagate those in an aggregate, hopefully providing more details for the real reason the test failed.
Commit migrated from https://github.com/dotnet/corefx/commit/
e752319943d3a3d409937ff71e8e8a63721a1579
Stephen Toub [Wed, 4 Apr 2018 19:31:40 +0000 (12:31 -0700)]
Add perf tests for {U}Int32/64 ToString/TryFormat/Parse (dotnet/corefx#28812)
These are ports of the equivalent tests from the Utf8Formatter tests in System.Memory.
Commit migrated from https://github.com/dotnet/corefx/commit/
7a118af732b709543a35031f12138b4a9d1f73d1
David Shulman [Wed, 4 Apr 2018 19:24:49 +0000 (12:24 -0700)]
Update download link for PerfView tool (dotnet/corefx#28822)
The PerfView tool has been moved to open-source. Updating the documentation link to point to the most recent place for downloading the tool.
Commit migrated from https://github.com/dotnet/corefx/commit/
81e82818527c1fab743ced76ad33441f61af2636
Max Kerr [Wed, 4 Apr 2018 18:26:29 +0000 (11:26 -0700)]
Improve parsing of WinINet default proxy strings in SocketsHttpHandler (dotnet/corefx#28671)
This is a partial fix for dotnet/corefx#28603.
Commit migrated from https://github.com/dotnet/corefx/commit/
22e88da0b430d16def339e52891acf0e0563dbf6
Stephen Toub [Wed, 4 Apr 2018 18:22:40 +0000 (11:22 -0700)]
Disable draining test on CurlHandler (dotnet/corefx#28814)
Commit migrated from https://github.com/dotnet/corefx/commit/
0a61dafdf643f436373c1ad1aba3da4a9a8b19bc
buddyabaddon [Wed, 4 Apr 2018 18:01:22 +0000 (11:01 -0700)]
build-native.sh fails when using 'uname -p' to determine arch. (dotnet/corefx#28762)
* build-native.sh fails when using 'uname -p' to determine arch.
uname -p actually returns the processor type, not the 'platform' as the comment suggested.
Quote the $CPUName variable when referencing it as the processor type returned via 'uname -p' can contain spaces.
Examples:
> uname -p
Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz
> uname -p
Intel(R) Core(TM)2 Duo CPU E6750 @ 2.66GHz
* Rely on 'uname -m' for arch type as 'uname -p' gives processor type.
Commit migrated from https://github.com/dotnet/corefx/commit/
9693747e046fc3e4da7ac5da8a1b101e549e8e01
Matt White [Wed, 4 Apr 2018 17:43:51 +0000 (13:43 -0400)]
Prefix WWW-Authenticate header with scheme per RFC 4559 (dotnet/corefx#27755)
Fixes: dotnet/corefx#26606
Commit migrated from https://github.com/dotnet/corefx/commit/
0b6a914dd83c0ddafb4e0698f16517515b3e1ee9
Stephen Toub [Wed, 4 Apr 2018 16:59:09 +0000 (09:59 -0700)]
Make default SocketsHttpHandler SslProtocols include Tls11/12 on Win7/2008R2 (dotnet/corefx#28788)
Windows 7 and Windows 2008 R2 support TLS 1.1 and 1.2, but for legacy reasons by default those protocols are not enabled when a developer elects to use the system default. However, in .NET Core 2.0 and earlier, HttpClientHandler would enable them, due to being a wrapper for WinHTTP, which enabled them. Both for compatibility and because we prefer those higher protocols whenever possible, SocketsHttpHandler also pretends they're part of the default when running on Win7/2008R2.
Commit migrated from https://github.com/dotnet/corefx/commit/
0c7a1de0448c9dee76723d0bedd90f76c3436662
Stephen Toub [Wed, 4 Apr 2018 16:58:51 +0000 (09:58 -0700)]
Use cached IdnMapping instances (dotnet/corefx#28800)
IdnMapping isn't currently documented to be thread-safe, but other than the properties which these uses don't change, it is. Since all of this is part of netcoreapp, it's fine to rely on that implementation detail, and we can avoid allocating a new IdnMapping instance per use.
Commit migrated from https://github.com/dotnet/corefx/commit/
4ba8b544132ace3b66702c546dc78dd84daf36f7
dotnet-maestro-bot [Wed, 4 Apr 2018 15:30:06 +0000 (10:30 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-02703-02, preview3-26403-06, preview3-26403-04, preview3-26403-03, beta-26403-00, beta-26403-00, respectively (master) (dotnet/corefx#28742)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-02703-02, preview3-26403-06, preview3-26403-04, preview3-26403-03, beta-26403-00, beta-26403-00, respectively
* Adding suppresion for package downgrade on Microsoft.NETCore.Platforms
Commit migrated from https://github.com/dotnet/corefx/commit/
82260de25bc75648ceb04048191ecf1c33b06c79
Caesar Chen [Tue, 3 Apr 2018 23:49:01 +0000 (16:49 -0700)]
disable test (dotnet/corefx#28789)
Commit migrated from https://github.com/dotnet/corefx/commit/
e4521cbd572764f3a140366cce7b39402e1a14cc
Jose Perez Rodriguez [Tue, 3 Apr 2018 23:16:23 +0000 (16:16 -0700)]
Removing unused Target
This target was only really for my testing and it accidentally made it to the final merge, so I'm reverting that piece now.
Commit migrated from https://github.com/dotnet/corefx/commit/
2ed087eff0c2a9d8882dbbc1f22a92ae014625a3
Krzysztof Wicher [Tue, 3 Apr 2018 21:50:55 +0000 (14:50 -0700)]
SslStream IDN mapping host name on Windows (dotnet/corefx#28725)
* SslStream IDN mapping host name on Windows
* Update SniHelper.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
e43901d03a3183c62dba9f354e51130a5c514a30
Jose Perez Rodriguez [Tue, 3 Apr 2018 20:28:53 +0000 (13:28 -0700)]
Adding support for ncurses 6.1 TERM format on System.Console (dotnet/corefx#28786)
Commit migrated from https://github.com/dotnet/corefx/commit/
d8ee1a7389a8a9fd52fb08eb1da60f17ad0c82b0
Anirudh Agnihotry [Tue, 3 Apr 2018 19:07:36 +0000 (12:07 -0700)]
Existing Directory ReadOnlyVolume Disabled for alpine (dotnet/corefx#28783)
Commit migrated from https://github.com/dotnet/corefx/commit/
9403c51f2b14a2e31f5ad952c9ce28a75d4060c3
Daniel Imms [Tue, 3 Apr 2018 19:06:53 +0000 (12:06 -0700)]
Fix grammar issue that made sentence ambiguous (dotnet/corefx#28785)
Commit migrated from https://github.com/dotnet/corefx/commit/
52897e9d76186004c3f8c6b1100fe7d6ff0a6089
Jose Perez Rodriguez [Tue, 3 Apr 2018 18:48:52 +0000 (11:48 -0700)]
Adding test execution to the allConfigurations leg (dotnet/corefx#28663)
* Adding test execution to the allConfigurations leg
* Changing the root of tests to avoid long path issues
* Excluding NuGetFallbackFolder
* Test
* Fixing exclude so that NuGetFallbackFolder doesn't get copied
Commit migrated from https://github.com/dotnet/corefx/commit/
f16ba601a2746a99ec9219adde277cb67bfd2da7
Wes Haggard [Tue, 3 Apr 2018 17:35:47 +0000 (10:35 -0700)]
Merge pull request dotnet/corefx#28779 from weshaggard/PinPlatformAbstractionVersions_m
Pin PlatformAbstraction version to last stable
Commit migrated from https://github.com/dotnet/corefx/commit/
495fa7bb44a04645c9baf8f50ec867ebdfac6aa3
Stephen Toub [Tue, 3 Apr 2018 17:08:52 +0000 (10:08 -0700)]
Improve throughput of Uri construction (dotnet/corefx#28776)
Commit migrated from https://github.com/dotnet/corefx/commit/
46c1fa7c5b26b85e5adece79fc4a45e472e476fa
Tarek Mahmoud Sayed [Tue, 3 Apr 2018 17:06:31 +0000 (10:06 -0700)]
Fix allocated Encoding memory initialization (dotnet/corefx#28720)
* Fix allocated Encoding memory initialization
We allocate native memory using GlobalHAlloc which usually doesn’t zero out the allocated memory and that cause a problem when using this memory. We fixed similar issue before in SBCS but looks we missed the DBCS one.
* Use Unsafe.InitBlockUnaligned
* remove un-needed empty line
* remove space
* Include System.Runtime.CompilerServices.Unsafe to inbox packag
* fix package build breaks
Commit migrated from https://github.com/dotnet/corefx/commit/
d5b142984587ac3c1b8562a76c83d5dede117289
Stephen Toub [Tue, 3 Apr 2018 16:57:29 +0000 (09:57 -0700)]
Stop artificially rooting SocketAsyncEventArgs (dotnet/corefx#28767)
SocketAsyncEventArgs creates an overlapped object that references the SAEA. That overlapped object creates an async pinning handle in the runtime, which roots the SocketAsyncEventArgs. The cycle from SAEA->Overlapped->handle->SAEA involving the root means that a dropped SAEA that's not Dispose'd will end up leaking.
This commit fixes that by adding a level of indirection between the handle and the SAEA. Rather than wrapping the SAEA directly, the handle is given an intermediate object that references the SAEA, and the SAEA then stores itself as a reference into that object only while an active operation is in progress. Once the operation completes, the reference in that object is nulled out, and the SAEA will no longer be kept alive by the pinning handle.
Commit migrated from https://github.com/dotnet/corefx/commit/
4d6521c572c44c5872281c125d8e341af054eec3
Wes Haggard [Fri, 30 Mar 2018 00:59:34 +0000 (17:59 -0700)]
Pin PlatformAbstraction version to last stable
We cannot depend on the latest PlatformAbstractions package
which is built from core-setup as it adds a cycle which we cannot
have in our source-build. To fix this temporarily we are pinning
to the last stable version 2.0.4.
See issue https://github.com/dotnet/corefx/issues/28620.
Commit migrated from https://github.com/dotnet/corefx/commit/
bcc792badda16ef8bc8babf87ab67817d568219d
Stephen Toub [Tue, 3 Apr 2018 16:00:59 +0000 (09:00 -0700)]
Fix ProxyExplicitlyProvided_DefaultCredentials_Ignored test (dotnet/corefx#28770)
I couldn't get it to fail locally, but I believe the issue was that sporadically WinHttpHandler would not reuse the original connection, in which case it would either not close the first and the test would hang because nothing was accepting the second connection, or it would close the first and fail because the server was expecting a second request on the connection. This fixes it by using Connection: close on the first response so that the client won't reuse the same connection.
Commit migrated from https://github.com/dotnet/corefx/commit/
586cffcdfdf23ad6c193a4bf37fce88a1bf69508
Jan Vorlicek [Tue, 3 Apr 2018 15:38:24 +0000 (17:38 +0200)]
Fix build with xcode 9.3 (dotnet/corefx#28768)
The c_static_assert definition is causing build problems on OSX.
The compiler complains about the typedef we use to implement the
c_static_assert:
declaration shadows a typedef in the global scope [-Werror,-Wshadow]
This is due to multiple static asserts
To fix it, I have modified the c_static_assert to use _Static_assert
C feature that's available in clang.
Commit migrated from https://github.com/dotnet/corefx/commit/
133d190320ecb2ff3f13a4e95c90b8e59bdd75e5
Matt Galbraith [Tue, 3 Apr 2018 15:32:24 +0000 (08:32 -0700)]
Merge pull request dotnet/corefx#28744 from MattGal/debian-94-stuff
Add new Debian.9.Amd64 queue
Commit migrated from https://github.com/dotnet/corefx/commit/
d0c47fa0569cf024fcd7cc7dc3dfc4f4eeb71882
Stephen Toub [Tue, 3 Apr 2018 13:45:33 +0000 (06:45 -0700)]
Add char.ToLower/Upper perf tests (dotnet/corefx#28765)
Commit migrated from https://github.com/dotnet/corefx/commit/
0ce0f2a2d55a4298d9d06ea29d26a28f14373ea3
Stephen Toub [Tue, 3 Apr 2018 11:02:09 +0000 (04:02 -0700)]
Add more functional and perf tests for string.ToLower/Upper (dotnet/corefx#28748)
* Add more functional tests for string.ToLower/Upper{Invariant}
* Add more string.ToLower/Upper perf tests
Commit migrated from https://github.com/dotnet/corefx/commit/
fd239bc73b05447a24cef9938c277f43171c1e06
Matt Galbraith [Tue, 3 Apr 2018 01:29:48 +0000 (18:29 -0700)]
Add new Debian.9.Amd64 queue. Debian's Azure versioning is unusual, so this queue represents "newest available".
Commit migrated from https://github.com/dotnet/corefx/commit/
fac2bf7062f534f5c7b2dcffb5702c7f89db82c9
Anirudh Agnihotry [Mon, 2 Apr 2018 23:06:45 +0000 (16:06 -0700)]
Tests for Directory Exists (dotnet/corefx#28732)
Commit migrated from https://github.com/dotnet/corefx/commit/
f759243d724f462da0bcef54e86588f8a55352c6
Koundinya Veluri [Mon, 2 Apr 2018 22:11:34 +0000 (15:11 -0700)]
Switch threading perf tests to use constant instead of Benchmark.InnerIteration (dotnet/corefx#28728)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd8c8ed26d74c10d03e8b7b66864effddf2c6e19
dotnet-maestro-bot [Mon, 2 Apr 2018 22:11:08 +0000 (17:11 -0500)]
Update CoreFx, CoreSetup to preview3-26402-05, preview3-26402-02, respectively (dotnet/corefx#28731)
Commit migrated from https://github.com/dotnet/corefx/commit/
78bdc6e9b0f1dfcb805c2f8e9cf62d7854d88d90
Tomas Weinfurt [Mon, 2 Apr 2018 20:45:51 +0000 (13:45 -0700)]
add proxy bypass list processing for windows (dotnet/corefx#28210)
* add bypass list processing
* remove 10.37.129.2
* update assembly references
* add bypass list processing
* remove 10.37.129.2
* update assembly references
* use Regex.Escape to escape . and [. Add more test cases.
* feedback from reviews
* fix some of the style comments. more changes to come.
* feedback from @stephentoub
* use UriHostNameType and IdnHost consistently to possibly avoid allocations. Add new test for various unexpected input
* replace String.Compare with string.Compare
Commit migrated from https://github.com/dotnet/corefx/commit/
c9d1ec1764f421f35cfe0bbc71bf2f81bc8f0f8d
Ben Adams [Mon, 2 Apr 2018 19:12:18 +0000 (20:12 +0100)]
Use a non-contigous Dictionary for tests (dotnet/corefx#28643)
Commit migrated from https://github.com/dotnet/corefx/commit/
25c5878a7309b1361178e4eb3441af5b3e767c85
Daniel Henry [Mon, 2 Apr 2018 19:09:20 +0000 (15:09 -0400)]
Slight grammar improvement to coding-style.md (dotnet/corefx#28723)
i.e. was being used when it really should have been e.g. (see: https://www.grammarly.com/blog/know-your-latin-i-e-vs-e-g/)
Commit migrated from https://github.com/dotnet/corefx/commit/
aca57537adf4015a8a69e0ae386970d45bd60c9a
dotnet-maestro-bot [Mon, 2 Apr 2018 18:47:00 +0000 (13:47 -0500)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-26402-06, preview3-26402-02, preview3-26402-01, beta-26402-01, beta-26402-01, respectively (dotnet/corefx#28710)
Commit migrated from https://github.com/dotnet/corefx/commit/
54a988a8a3f91bcc0bbb0d4a92a656b9ab0b76c8
Caesar Chen [Mon, 2 Apr 2018 18:26:29 +0000 (11:26 -0700)]
Fix ipv6 address format in Host header (dotnet/corefx#28578)
* fix ipv6 format in host header
* address feedback
* address feedback
* fix common case
* reduce allocation
* address feedback
* fix indexof issue
* disable on curlhandler
* revert to simple fix
* address feedback and add comment
* address test issue, enable on curlhandler
* fix framework failure
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
24889e293731f12b11f1205b641cd3e6cb3a3b90
Jeremy Barton [Mon, 2 Apr 2018 18:25:04 +0000 (11:25 -0700)]
Fix the message for Cryptography_InvalidPadding
Also audited all usages of this string to ensure they had the "the padding is wrong"
semantic instead of the "I don't know how to do this padding" semantic. Only
one usage was seemingly wrong, and while it's in a Debug.Fail block it got fixed
anyways.
Commit migrated from https://github.com/dotnet/corefx/commit/
5f574a5673026d9e361e6cf938b4a0f112e5bab2
Ben Adams [Mon, 2 Apr 2018 18:23:14 +0000 (19:23 +0100)]
ArrayMemoryPoolBuffer should only implement IMemoryOwner<T> (dotnet/corefx#28690)
* ArrayMemoryPoolBuffer should only implement IMemoryOwner<T>
* React pipelines to changes
Commit migrated from https://github.com/dotnet/corefx/commit/
d67ea510c68dbce13e735bc18b7356822a0df235
Koundinya Veluri [Mon, 2 Apr 2018 17:41:14 +0000 (10:41 -0700)]
Increase iteration counts in threading perf tests (dotnet/corefx#28712)
Relevant to https://github.com/dotnet/coreclr/issues/17345
Commit migrated from https://github.com/dotnet/corefx/commit/
b01e361a6f8422b673c54c427c46710ab19b6e92
dotnet-maestro-bot [Mon, 2 Apr 2018 05:40:13 +0000 (00:40 -0500)]
Update CoreFx to preview3-26402-01 (dotnet/corefx#28706)
Commit migrated from https://github.com/dotnet/corefx/commit/
6ae0da1563e6e701bac61012c62ede8f8737f065
Stephen Toub [Mon, 2 Apr 2018 03:12:13 +0000 (23:12 -0400)]
Fix comment in AuthenticationHelper.NtAuth.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
6bcfd33ec5e6c3a8ebc81bd0cde0254f4f5a22b0
dotnet-maestro-bot [Mon, 2 Apr 2018 01:25:40 +0000 (20:25 -0500)]
Update CoreClr, CoreSetup to preview3-26402-01, preview3-26401-02, respectively (dotnet/corefx#28705)
Commit migrated from https://github.com/dotnet/corefx/commit/
176dea50327c9fb49365872c11913e0f3c92019c
Geoff Kizer [Mon, 2 Apr 2018 01:06:52 +0000 (18:06 -0700)]
if server sends invalid challenge, don't continue processing (dotnet/corefx#28704)
Commit migrated from https://github.com/dotnet/corefx/commit/
660dc94410cdaaba1bfc5bd6720e78eee5c5786c
dotnet-maestro-bot [Sun, 1 Apr 2018 13:45:21 +0000 (06:45 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview3-26401-03, preview3-26401-02, preview3-26401-01, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
ff79c494f80b92ea260df24f9d8ae6bf959c6c5d
Paulo Janotti [Sun, 1 Apr 2018 12:28:37 +0000 (05:28 -0700)]
Fix intermittent crashes on FileSystemEnumeration on Unix (dotnet/corefx#28692)
* Marking tests affected by 27740 as active issue
* ActiveIssue for other test in XmlSchema using TempDirectory
* Fix intermittent crash in FileSystemEnumerator for Unix
Commit migrated from https://github.com/dotnet/corefx/commit/
b96c29aedf9b2f4197d161f632b4387a17be72f8
Koundinya Veluri [Sun, 1 Apr 2018 11:26:11 +0000 (04:26 -0700)]
Fix thread constructor test on newer kernels (dotnet/corefx#28613)
Works around and closes https://github.com/dotnet/coreclr/issues/17170
- Works around an issue on linux-arm64 where pthread_create appears to reserve less stack space than requested without failing, and limits the max reserved stack size to the ulimit-configued value, leading to seg fault when the requested size of stack space is attempted to be used
- Fixed to write every page in the stack region that is being checked, to guarantee hitting the guard page in case of failure. The JIT's stack probe for stackalloc should cover this, https://github.com/dotnet/coreclr/issues/16827 details why that was not happening, in any case this test is not intended to test stack probing behavior, so this change makes the test a bit stronger in what it actually intends to test.
Commit migrated from https://github.com/dotnet/corefx/commit/
d73eb9141ea4b8ca526881e7bbaebe5b36db0fe1
Marco Rossignoli [Sun, 1 Apr 2018 00:19:54 +0000 (02:19 +0200)]
Cleanup Console.WriteLine() (dotnet/corefx#28687)
* cleanup
* cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
dfd9930b3471c3ed03281912506c9da5681f3b21
Alexander Radchenko [Sat, 31 Mar 2018 19:05:42 +0000 (02:05 +0700)]
Corrected a typo 'nanager' to 'manager' (dotnet/corefx#28684)
Commit migrated from https://github.com/dotnet/corefx/commit/
f6a0db6b4d9fe1656eae0e1973b950fd595f8ab5
Saurabh Singh [Sat, 31 Mar 2018 19:04:44 +0000 (12:04 -0700)]
Update issue-guide.md (dotnet/corefx#28685)
Commit migrated from https://github.com/dotnet/corefx/commit/
66c9cdc6d438b8a01c0afbdb65e2348cba9eb803
dotnet-maestro-bot [Sat, 31 Mar 2018 13:46:14 +0000 (08:46 -0500)]
Update CoreClr, CoreFx, CoreSetup to preview3-26331-05, preview3-26331-04, preview3-26331-02, respectively (dotnet/corefx#28677)
Commit migrated from https://github.com/dotnet/corefx/commit/
54d131f4174491bc2a7f5d6e4b0b8b725d299a8f
Stephen Toub [Sat, 31 Mar 2018 13:14:03 +0000 (06:14 -0700)]
Avoid unnecessarily propagating ExecutionContext in SocketAsyncEngine (dotnet/corefx#28676)
SocketAsyncEngines are created lazily on-demand. If we happen to create one at a point where there's a non-default ExecutionContext, we end up capturing that context onto the event loop thread, such that all subsequent dispatches capture and restore that ExecutionContext.
Commit migrated from https://github.com/dotnet/corefx/commit/
ec5fb4162c8376cf8ced69f1d2442c586e9197f3
Paulo Janotti [Sat, 31 Mar 2018 12:57:25 +0000 (05:57 -0700)]
Marking tests affected by 27740 in XmlSchemaValidatorApi as active issue (dotnet/corefx#28679)
* Marking tests affected by 27740 as active issue
* ActiveIssue for other test in XmlSchema using TempDirectory
Commit migrated from https://github.com/dotnet/corefx/commit/
fe0edc425686dc6d1229745daba253c3f6abde91
Stephen Toub [Sat, 31 Mar 2018 05:01:45 +0000 (01:01 -0400)]
Disable frequently failing GetAsync_SupportedSSLVersion_Succeeds test
Commit migrated from https://github.com/dotnet/corefx/commit/
031e40a64bd7a148f43e5a49055abbf5743b4543
Stephen Toub [Sat, 31 Mar 2018 05:00:37 +0000 (22:00 -0700)]
Stop blocking explicit opt-in to Ssl2/3 in SslStream and HttpClient (dotnet/corefx#28639)
By default, .NET Core defaults to allowing TLSv1, TLSv1.1, and TLSv1.2. However, whereas .NET Framework allows a developer to opt-in to SSLv2/SSLv3, .NET Core currently blocks it. This means developers are unable to use .NET Core when they need to communicate with an endpoint they don't control and that's unfortunately limited to one of these protocols, which blocks adoption of .NET Core.
This commit stops blocking these protocols. They're still disabled by default, and compiling against them still results in a deprecation warning, but if a developer chooses to ignore the warning and explicitly sets SslProtocols, they are at least able to use the protocols, subject to whatever the underlying operating system allows (e.g. Windows stops supporting SSLv2 as of v1607).
Commit migrated from https://github.com/dotnet/corefx/commit/
3cc6fda0c6abe76eea222c165ebdf816e83df564
Cory Rivera [Sat, 31 Mar 2018 04:34:20 +0000 (21:34 -0700)]
Bump System.Data.SqlClient assembly version to 4.4.0. (dotnet/corefx#27011)
* Bump System.Data.SqlClient assembly version to 4.4.0.
Add UAP build configuration to SqlClient.
* Add build config for uap10.0.16299.
* Re-add uap to sqlclient package config.
Commit migrated from https://github.com/dotnet/corefx/commit/
307401c673c3e25ab8402664f22fba271b1dabb5
Ahson Khan [Sat, 31 Mar 2018 04:24:49 +0000 (21:24 -0700)]
Add tests for calling Span APIs via reflection to verify graceful failures. (dotnet/corefx#28674)
* Add tests for calling Span APIs via reflection to verify graceful failures.
* Add Span reflection tests to verify graceful failures
* Address PR feedback (test cleanup and rename)
* Fix up some test names
* Minor tweak: Reorder the tests
* Exclude running the reflection tests for portable span (netfx)
* Remove unused constant from csproj
Commit migrated from https://github.com/dotnet/corefx/commit/
a7b59b08f3f92038011ff967efcc250fc305c925
dotnet-maestro-bot [Sat, 31 Mar 2018 03:36:41 +0000 (22:36 -0500)]
Update BuildTools, CoreClr, CoreFx to preview3-02631-01, preview3-26331-01, preview3-26331-02, respectively (dotnet/corefx#28670)
Commit migrated from https://github.com/dotnet/corefx/commit/
808edc21eb60ef03f792fefc019f594caf936aab
Jeremy Barton [Sat, 31 Mar 2018 03:22:55 +0000 (20:22 -0700)]
React to X509Chain changes in macOS 10.13.4 (dotnet/corefx#28673)
10.13.4 changed some of the detail codes for building the X509ChainStatusFlag values.
"ValidLeaf" (etc) => "TemporalValidity"
"WeakLeaf" (etc) => "WeakKeySize"
new "MissingIntermediate" when the chain didn't complete instead of "AnchorTrusted" lower down.
Commit migrated from https://github.com/dotnet/corefx/commit/
e49a617ba2a98a54b10c8a520b17cb05e9618b30
Dan Moseley [Sat, 31 Mar 2018 03:04:22 +0000 (20:04 -0700)]
Emit less junk from Process test (dotnet/corefx#28669)
Commit migrated from https://github.com/dotnet/corefx/commit/
2a7568d64228249a9ec1d40a56130c576213b159
Anirudh Agnihotry [Sat, 31 Mar 2018 01:31:57 +0000 (18:31 -0700)]
Adding test checking working Directory in childProcess (dotnet/corefx#28628)
Commit migrated from https://github.com/dotnet/corefx/commit/
415e0aa8d5c9988ccb1cc73276bb0145f7901e11
Stephen Toub [Sat, 31 Mar 2018 01:27:39 +0000 (18:27 -0700)]
Merge pull request dotnet/corefx#28638 from stephentoub/shhallocs
Some more allocation reduction in SocketsHttpHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
26f3de6527bdde97d589134d10780a418dd9ff98
Krzysztof Wicher [Sat, 31 Mar 2018 01:23:30 +0000 (18:23 -0700)]
SslStream mutates state of options (dotnet/corefx#28666)
* decouple SslState from SslServerAuthenticationOptions
* rename certCallback to certSelectionCallback
* remove mutable ServerCertSelectionCallback from SslServerAuthenticationOptions
* remove mutable RemoteCertValidationCallback from SslServerAuthenticationOptions
* fix FakeSslState to match args
Commit migrated from https://github.com/dotnet/corefx/commit/
00bcad0f047186047d3021584b732a8c5d124376
Santiago Fernandez Madero [Sat, 31 Mar 2018 00:57:59 +0000 (19:57 -0500)]
FontFamily.Equals in Linux use .Name instead of NativeFamily pointer which is not a singleton (dotnet/corefx#28650)
* FontFamily.Equals in Linux use .Name instead of NativeFamily pointer which is not a singleton
* Fix tests and PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6f38488ee5097d0b9b9332a8eb173dd03ae8e49f
dotnet-maestro-bot [Sat, 31 Mar 2018 00:29:32 +0000 (19:29 -0500)]
Update BuildTools to preview3-02630-02 (dotnet/corefx#28619)
Commit migrated from https://github.com/dotnet/corefx/commit/
906d23f764ffd84f9d8ba2c5e1bc2468a79a0c68
Konst Khurin [Sat, 31 Mar 2018 00:25:19 +0000 (17:25 -0700)]
Removing System.Runtime.Caching/src/MatchingRefApiCompatBaseline.txt (dotnet/corefx#28665)
Commit migrated from https://github.com/dotnet/corefx/commit/
a9ecb8ed5647881a6ccbf6f80bac1b031e1a9d21
Jiayi Yu [Fri, 30 Mar 2018 22:26:46 +0000 (15:26 -0700)]
remove empty baseline files (dotnet/corefx#28656)
Commit migrated from https://github.com/dotnet/corefx/commit/
e3694f9b8a69d21d1cb0e30412b7e52079ae69d6
Wes Haggard [Fri, 30 Mar 2018 22:25:07 +0000 (15:25 -0700)]
Merge pull request dotnet/corefx#28659 from weshaggard/EnableOptionalToolsInNoTestDef
Enable optional tools in no-test build definition
Commit migrated from https://github.com/dotnet/corefx/commit/
62614491cedaff7ae85f0f8dd4e906bd0d6edc2a
Stephen Toub [Fri, 30 Mar 2018 21:34:33 +0000 (17:34 -0400)]
Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
9f9b34a2dd82cbd19766c720748bf50f37968752
Ahson Khan [Fri, 30 Mar 2018 21:30:48 +0000 (14:30 -0700)]
Split OwnedMemory into MemoryManager and IMemoryOwner (dotnet/corefx#28640)
* Update IRetainable, OwnedMemory, and MemoryHandle APIs
* Split OwnedMemory into MemoryManager and IMemoryOwner
* Update ReadOnlySequence, ArrayMemoryPool, and BufferSegment
* Update System.Memory and System.IO.Pipeline tests
* Temporarily skipping the failing Pipelines tests until impl is corrected.
* Update the reference assembly to match implementation and cleanup
* Update API compat baseline for UAPAOT and add GenFacadesIgnoreMissingTypes
* Fix the System.Runtime ref
* Add back the Pin methods to the uapaot api compat baseline
* Clone the API compat baseline from uapaot and add it for uap as well.
* Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-02630-01, preview3-26330-08, preview3-26330-06, preview3-26330-04, beta-26330-00, beta-26330-00, respectively
* Fix pipelines tests and update the api compat baseline shim for uapaot
* Add empty Unpin override to pipe pool test.
* Fix the System.Net.Http Functional tests
Commit migrated from https://github.com/dotnet/corefx/commit/
f592e887e2349ed52af6a83070c42adb9d26408c
Stephen Toub [Fri, 30 Mar 2018 21:25:29 +0000 (14:25 -0700)]
Fix race condition on read ahead task in SocketsHttpHandler (dotnet/corefx#28637)
We're supposed to only use a ValueTask<int> once. But there's a race condition where we may not only use one more than once, we might do so concurrently, resulting in a variety of different exceptions depending on how the race condition manifests.
When we take a connection out of the connection pool, we want to check whether it's still valid for use. We could poll, but since the request/response is going to need to issue at least one read anyway, we just do so preemptively, then checking whether the read completed synchronously (if it did, we can't use the connection). This gets stored in a field on the HttpConnection that can later be read. However, we may also create the read ahead task in another situation, which is if we're unable to easily fish out the underlying socket used by the connection (as happens with tunneling), when the pool periodically scavenges and looks for dead connections, rather than polling it just issues that read even earlier. Doing so, however, means that we'll have kicked off tasks that are likely to complete with an exception if the connection is terminated in an unfriendly manner. To avoid such exceptions spamming TaskScheduler.UnobservedTaskException, we check this stored task when disposing the connection.
That, however, creates the race condition. If the connection is disposed (e.g. due to cancellation) at just the wrong time, the request/response may be in the process of working with that initial read just as the disposal goes to interact with that same read ahead task. Badness results.
The fix is to add a tiny amount of synchronization, such that just one call site can take ownership of the read ahead task.
Commit migrated from https://github.com/dotnet/corefx/commit/
366496832fbf9c893a33ebed176d6e053c721ca1
Stephen Toub [Fri, 30 Mar 2018 21:23:56 +0000 (14:23 -0700)]
Remove buffer argument from WebSocket.CreateFromStream (dotnet/corefx#28649)
Commit migrated from https://github.com/dotnet/corefx/commit/
bf38b7b8c56e7fbe10796dcfa1918a36377a1cd6
Wes Haggard [Fri, 30 Mar 2018 21:18:48 +0000 (14:18 -0700)]
Enable optional tools in no-test build definition
We produce our nuget packages in the allconfigurations leg
which uses the notest build definition. In order for us to
embed optimization data we need to enable the optional tools
and pass in the EnableProfileGuidedOptimization=true property
Commit migrated from https://github.com/dotnet/corefx/commit/
9919aa9e7ed18a6a74960e535638a35b5d2103f0
Jose Perez Rodriguez [Fri, 30 Mar 2018 21:18:21 +0000 (14:18 -0700)]
Fixing two additional package tests (dotnet/corefx#28654)
Commit migrated from https://github.com/dotnet/corefx/commit/
2d4a49d7a9c609042391f56b2a6cdce1179aaabd
Jeremy Barton [Fri, 30 Mar 2018 17:46:18 +0000 (10:46 -0700)]
Fix 1DES and RC2 CryptoServiceProvider CreateTransform tests on Unix
Commit migrated from https://github.com/dotnet/corefx/commit/
3f376c305c214d3f621ab2158dc4b9e804035d49
Jeremy Barton [Thu, 29 Mar 2018 22:54:53 +0000 (15:54 -0700)]
Make TripleDESCryptoServiceProvider CreateTransform behave like netfx
.NET Framework's TripleDESCryptoServiceProvider rejects small inputs, but
accepts oversized IVs (effectively truncating them to the block size). This
change makes the .NET Core type behave the same way, and adds a test to
codify all of the oversized IV relationships with the CryptoServiceProvider
compat types. (DES and RC2 apparently already allowed it)
Commit migrated from https://github.com/dotnet/corefx/commit/
78357cf19232383d8e6b5356b760bf4c2f0e2f09
Krzysztof Wicher [Fri, 30 Mar 2018 21:00:44 +0000 (14:00 -0700)]
Add server-side SNI support (dotnet/corefx#28278)
* add initial implementation for server side SNI support
* remove analyzerdata
* add braces around single line if statements and inline simple functions
* fix deadlock on linux
* add test with special characters
* IDN decoding
* idn unmapping (with fallback)
* apply feedback, fix netfx/uwp
* rename the SNIHelper to SniHelper
* rename test file as well (git does not like renames on windows)
* change file casing in csproj
* test should expect AuthenticationException
* add SniHelper tests
* apply review feedback
* shorten SNI (limit is 63 bytes)
* replace remaining constants
* test behavior on truncated client hello
* add structures descriptions
* apply review feedback
* get rid of the new dependency and add a test for invalid utf-8 bytes
Commit migrated from https://github.com/dotnet/corefx/commit/
2d39212fc69a6c0a78c48a3ad8e191ca94872548
Konst Khurin [Fri, 30 Mar 2018 20:24:51 +0000 (13:24 -0700)]
Making types listed in dotnet/corefx#27980 internal (dotnet/corefx#28636)
Commit migrated from https://github.com/dotnet/corefx/commit/
f6ff5c214bc9ad1d409913c789398be3e5546948
Omar Tawfik [Fri, 30 Mar 2018 19:58:55 +0000 (15:58 -0400)]
Fix Microsoft.VisualBasic Ref API surface issues (dotnet/corefx#28531)
* Fix Microsoft.VisualBasic Ref API surface issues
* PR Comments
Commit migrated from https://github.com/dotnet/corefx/commit/
74126cad20a1d86e44b52e0f12983f9c855886a1
Anirudh Agnihotry [Fri, 30 Mar 2018 19:35:45 +0000 (12:35 -0700)]
Using random string for temp files (dotnet/corefx#28589)
Commit migrated from https://github.com/dotnet/corefx/commit/
73e8a1f8130a792e6661819e6236533576fca45a
Gene Lee [Fri, 30 Mar 2018 18:51:15 +0000 (11:51 -0700)]
Fix ConnectionTimeoutTestWithThread test (dotnet/corefx#28618)
Commit migrated from https://github.com/dotnet/corefx/commit/
94fe40287a5f61e96b09acaabacce55210ced8a0
Gene Lee [Fri, 30 Mar 2018 18:50:41 +0000 (11:50 -0700)]
Fix MatchingRefApiCompat issues (dotnet/corefx#28369)
Commit migrated from https://github.com/dotnet/corefx/commit/
7cd16376a835ffd4fd981d2e9b813b82a6985d91
Pavel Krymets [Fri, 30 Mar 2018 18:40:39 +0000 (11:40 -0700)]
Do not resume reader on 0-byte FlushAsync (dotnet/corefx#28550)
Commit migrated from https://github.com/dotnet/corefx/commit/
82518b91848023b521621a18896270b72aaf0ae3
Jiayi Yu [Fri, 30 Mar 2018 18:30:35 +0000 (11:30 -0700)]
Fix MatchingRefApiCompat issues in Serialization libraries (dotnet/corefx#28552)
* Fixes: System.Xml.XmlSerializer/src/MatchingRefApiCompatBaseline.uap.txt
* fixes System.Xml.XmlSerializer/src/MatchingRefApiCompatBaseline.uapaot.txt
* Fixes: System.Xml.XmlSerializer/src/MatchingRefApiCompatBaseline.netcoreapp.txt
* Fixes: System.Runtime.Serialization.Xml/src/MatchingRefApiCompatBaseline.txt
* Bring back ReadString() as it is used somewhere else
* fix build errors
Commit migrated from https://github.com/dotnet/corefx/commit/
3d6e00c9be13dc047810d2ca877671b3bed6fd41
Stephen Toub [Fri, 30 Mar 2018 16:54:08 +0000 (09:54 -0700)]
Make AuthenticationException message less platform-specific (dotnet/corefx#28645)
SSPI is a Windows thing.
Commit migrated from https://github.com/dotnet/corefx/commit/
d1d5135ef69f0b64001694d93a6a9fc4cd23d23b
Stephen Toub [Fri, 30 Mar 2018 16:53:26 +0000 (09:53 -0700)]
Reduce buffering in ManagedWebSocket.ReceiveAsync (dotnet/corefx#28577)
* Change SocketsHttpHandler's 101 response stream to buffer response reads
The connection already has a buffer; use it.
* Reduce buffering in ManagedWebSocket.ReceiveAsync
Today we use a big-ish receive buffer, reading all data into the receive buffer and then copying from there into the caller-provided destination buffer. With this change, we assume that the underlying stream is providing the desired level of buffering, and thus only use a buffer small enough to handle message headers and control payloads (the latter for simplicity, as no caller-supplied buffer is available there).
* Change ClientWebSocket to avoid creating a large buffer
Commit migrated from https://github.com/dotnet/corefx/commit/
06aa6f0ce4cdf78985f029f218007a7d55f8965f
Eric StJohn [Fri, 30 Mar 2018 15:04:00 +0000 (08:04 -0700)]
Merge pull request dotnet/corefx#28600 from ericstj/packageTesting
Fix package testing infrastructure and fix issues.
Commit migrated from https://github.com/dotnet/corefx/commit/
ef52017da09efe47200479001988e924720598b0
Eric Erhardt [Fri, 30 Mar 2018 13:51:54 +0000 (08:51 -0500)]
Update dogfood instructions with current SDK version (dotnet/corefx#28601)
Commit migrated from https://github.com/dotnet/corefx/commit/
458ee023de704eb468f0a7cbaa5924828e57aeb0
Eric Erhardt [Fri, 30 Mar 2018 13:14:54 +0000 (08:14 -0500)]
Support musl-libc based linux RIDs (dotnet/corefx#28560)
* Support musl-libc based linux RIDs
- Add `linux-musl` RID
- Set `alpine`'s parent to `linux-musl`
- Add `alpine.3.7` to the graph
- Fix up `android` to inherit from `unix` while we are here
Fixes https://github.com/dotnet/core-setup/issues/3817
* Change linux-musl to be parented to linux.
* Reparent android RID to linux.
Commit migrated from https://github.com/dotnet/corefx/commit/
81ba6280047eb1129fd4938e54626d1f973fd281
Stephen Toub [Thu, 29 Mar 2018 06:06:11 +0000 (23:06 -0700)]
Pool SocketAsyncEventArgs used to establish connections
SocketAsyncEventArgs is a heavy object to use once and throw away. This change lets us pool and reuse them.
Commit migrated from https://github.com/dotnet/corefx/commit/
da8c62d22bc68eed381f1a3c7b895150e5b21946
Stephen Toub [Thu, 29 Mar 2018 05:51:47 +0000 (22:51 -0700)]
Split ConcurrentQueue<T>.Segment into its own file
Commit migrated from https://github.com/dotnet/corefx/commit/
fdfc497e7c22f8513ee785ce94a5148632e84645
Stephen Toub [Thu, 29 Mar 2018 05:04:40 +0000 (22:04 -0700)]
Remove string allocation from CookieContainer ctor
There's no need to recompute the same string every time a CookieContainer is created.
Commit migrated from https://github.com/dotnet/corefx/commit/
e7a796128e12d618be00aecda8e80708e0cba865
Stephen Toub [Thu, 29 Mar 2018 04:44:27 +0000 (21:44 -0700)]
Dispose connections immediately when returned to a pool with zero timeouts
Commit migrated from https://github.com/dotnet/corefx/commit/
b4301aad9ee8de67e47345a7cc40fcdd95a286ca
Stephen Toub [Thu, 29 Mar 2018 04:29:08 +0000 (21:29 -0700)]
Avoid creating cleaning timer if no connections will ever be added to pool
Commit migrated from https://github.com/dotnet/corefx/commit/
48719a0c3b49ad788320fe3c65b918b0ff97810c