Tom Tromey [Tue, 29 Jan 2013 18:54:24 +0000 (18:54 +0000)]
* value.c (deprecated_set_value_modifiable): Remove.
* value.h (deprecated_set_value_modifiable): Remove.
Roland McGrath [Tue, 29 Jan 2013 17:33:22 +0000 (17:33 +0000)]
gas/
* config/tc-arm.c (md_apply_fix): Use as_bad_where for "bad
immediate value for 8-bit offset" error so it shows line info.
Nick Clifton [Tue, 29 Jan 2013 08:55:09 +0000 (08:55 +0000)]
* readelf.c (process_version_sections): Fix overflow checks to
avoid undefined behaviour.
Cary Coutant [Tue, 29 Jan 2013 01:06:56 +0000 (01:06 +0000)]
gold/
* dwp.cc (File_list): New typedef.
(Dwo_name_info_reader): New class.
(Dwo_id_info_reader::Dwo_id_info_reader): Remove unused parameters.
(Dwo_id_info_reader::visit_top_die): Remove unused member function.
(Dwo_file::~Dwo_file): Delete input_file_ after obj_.
(Dwo_file::read_executable): New function.
(Dwo_file::read): Move common setup code to ...
(Dwo_file::make_object): ... here.
(dwp_options): Add --exec/-e.
(usage): Likewise.
(main): Likewise.
gdbadmin [Tue, 29 Jan 2013 00:00:42 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Mon, 28 Jan 2013 23:00:05 +0000 (23:00 +0000)]
daily update
Doug Evans [Mon, 28 Jan 2013 18:02:48 +0000 (18:02 +0000)]
* dwarf2loc.c (dwarf2_find_location_expression): Don't add base address
to addresses from dwo files.
testsuite/
* gdb.dwarf2/fission-loclists.exp: New file.
* gdb.dwarf2/fission-loclists.S: New file.
Doug Evans [Mon, 28 Jan 2013 17:49:40 +0000 (17:49 +0000)]
* dwarf.c (display_gdb_index): Handle .gdb_index version 8.
Nick Clifton [Mon, 28 Jan 2013 15:28:40 +0000 (15:28 +0000)]
PR gas/15069
* tic6x-opcode-table.h: Fix encoding of BNOP instruction.
* gas/tic6x/insns-c674x-pcrel.s: Add test of BNOP instruction
within header based fetch packet.
* gas/tic6x/insns-c674x-pcrel.d: Update expected disassembly.
Alan Modra [Mon, 28 Jan 2013 12:30:17 +0000 (12:30 +0000)]
* elf64-ppc.c: Use %T to print symbols names and remove redundant
"relocation" in error messages throughout file.
(ppc64_elf_relocate_section): Remove sibling call error message,
replace with "call lacks nop". Specially report errors for
branches to function entry points via OPD lookup and branches
to stubs. Remove NULL symbol handling now done by %T.
Nick Clifton [Mon, 28 Jan 2013 10:06:51 +0000 (10:06 +0000)]
* simops.c (v850_rotl): New function.
(v850_bins): New function.
* simops.h: Add prototypes fir v850_rotl and v850_bins.
* v850-dc: Add entries for V850e3v5.
* v850.igen: Add support for v850e3v5.
(ld.dw, st.dw, rotl, bins): New patterns.
Alan Modra [Mon, 28 Jan 2013 09:31:01 +0000 (09:31 +0000)]
* objcopy.c (parse_flags): Add merge and strings section flags.
Alan Modra [Mon, 28 Jan 2013 07:58:16 +0000 (07:58 +0000)]
* archive.c (bfd_generic_archive_p): Return target and keep
ardata on partial matches.
* format.c (bfd_check_format_matches): Adjust for above
change. Remove bfd_error_file_ambiguously_recognized dead
code.
gdbadmin [Mon, 28 Jan 2013 00:00:03 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Sun, 27 Jan 2013 23:00:05 +0000 (23:00 +0000)]
daily update
Mike Frysinger [Sun, 27 Jan 2013 16:58:44 +0000 (16:58 +0000)]
mention fixed bug in ChangeLog
gdbadmin [Sun, 27 Jan 2013 00:00:36 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Sat, 26 Jan 2013 23:00:06 +0000 (23:00 +0000)]
daily update
Jan Kratochvil [Sat, 26 Jan 2013 18:43:43 +0000 (18:43 +0000)]
gdb/testsuite/
Code cleanup.
* gdb.base/restore.exp: Replace gdb_compile, gdb_exit, gdb_start,
gdb_reinitialize_dir and gdb_load by standard_testfile, set executable
and prepare_for_testing.
* gdb.base/store.exp: Likewise.
Alan Modra [Sat, 26 Jan 2013 02:08:01 +0000 (02:08 +0000)]
* bfd.c (struct bfd_preserve, bfd_preserve_save, bfd_preserve_restore,
bfd_preserve_finish): Move to..
* format.c: ..here, splitting out..
(bfd_reinit): ..this. New function.
(bfd_check_format_matches): Use bfd_preserve_save/restore to
keep bfd state for a match.
* elfcode.h (elf_object_p): Don't use bfd_preserve_save/restore.
* elfcore.h (elf_core_file_p): Likewise.
* mach-o.c (bfd_mach_o_header_p): Likewise.
* pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise.
* xsym.c (bfd_sym_object_p): Likewise.
* mmo.c (mmo_scan): Clear abfd->symcount.
* opncls.c (_bfd_new_bfd): Use a smaller section hash table.
* section.c (bfd_section_list_clear): Clear section_htab.count.
* bfd-in2.h: Regenerate.
gdbadmin [Sat, 26 Jan 2013 00:00:04 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Fri, 25 Jan 2013 23:00:05 +0000 (23:00 +0000)]
daily update
Siva Chandra Reddy [Fri, 25 Jan 2013 22:31:43 +0000 (22:31 +0000)]
* valops.c (find_overload_match): Remove unused argument 'lax'.
* value.h: Remove unused argument 'lax' from the declaration of
find_overload_match.
* eval.c (value_subexp_standard): Do not pass a 'lax' argument
to find_overload_match.
* valarith.c (value_user_defined_cpp_op): Do not pass a 'lax'
argument to find_overload_match.
Cary Coutant [Fri, 25 Jan 2013 21:15:54 +0000 (21:15 +0000)]
binutils/
* dwarf.c (display_loc_list): Update offset for each line
printed.
(print_addr_index): New function.
(display_loc_list_dwo): Update offset for each line printed.
Fix problems displaying loclists in .dwo files. Add support
for type 4 entries.
(display_debug_loc): Remove custom header for .dwo files.
(display_debug_addr): Adjust formatting.
Tom Tromey [Fri, 25 Jan 2013 17:59:29 +0000 (17:59 +0000)]
* gdb.python/py-explore.exp: Expect the gdb prompt.
Tom Tromey [Fri, 25 Jan 2013 17:57:31 +0000 (17:57 +0000)]
* dwarf2read.c (processing_has_namespace_info): Remove.
(struct dwarf2_cu) <processing_has_namespace_info>: New field.
(process_die, read_func_scope, dwarf2_start_symtab)
(new_symbol_full): Update.
Tom Tromey [Fri, 25 Jan 2013 17:55:24 +0000 (17:55 +0000)]
* cp-namespace.c (cp_set_block_scope): Remove.
* cp-support.h (cp_set_block_scope): Remove.
* dbxread.c: Include block.h.
(cp_set_block_scope): New function.
(process_one_symbol): Update.
* dwarf2read.c (read_func_scope): Use block_set_scope.
Pedro Alves [Fri, 25 Jan 2013 17:38:00 +0000 (17:38 +0000)]
Fix add_current_inferior_and_thread's describing comment.
add_current_inferior_and_thread tries the stop reply first. Tweak its
comment to reflect reality.
2013-01-25 Pedro Alves <palves@redhat.com>
* remote.c (add_current_inferior_and_thread): Tweak comment.
Tom Tromey [Fri, 25 Jan 2013 17:36:01 +0000 (17:36 +0000)]
* cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
(cp_add_using_directive): Add 'copy_names' argument.
* cp-support.h (cp_add_using_directive): Update.
(struct using_direct) <import_src, import_dest, alias,
declaration>: Now const.
* dwarf2read.c (read_import_statement): Use obconcat.
Don't copy names passed to cp_add_using_directive.
Tom Tromey [Fri, 25 Jan 2013 17:34:03 +0000 (17:34 +0000)]
* c-exp.y (qualified_name): Use TYPE_SAFE_NAME.
Pedro Alves [Fri, 25 Jan 2013 17:25:59 +0000 (17:25 +0000)]
Fix GDB internal error against targets that return a thread in T stop replies but don't support qC.
Yao writes:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GDB gets an internal error when it connects to GDBserver started with
'--disable-packet=qC'.
Sending packet: $QNonStop:0#8c...Packet received: OK
Sending packet: $?#3f...Packet received: T0505:
00000000;04:
00f0ffbf;08:
b0c2e44c;thread:p4255.4255;core:1;
Sending packet: $Hc-1#09...Packet received: E01
Sending packet: $qC#b4...Packet received:
Sending packet: $qAttached:a410#bf...Packet received: E01
Packet qAttached (query-attached) is supported
warning: Remote failure reply: E01
Sending packet: $qOffsets#4b...Packet received:
../../../git/gdb/target.c:3248: internal-error: Can't determine the current address space of thread Thread 16981
When start remote, the call chain is as follows,
remote_start_remote
add_current_inferior_and_thread <--[1]
...
start_remote
wait_for_inferior
remote_wait_as
process_stop_reply
get_thread_arch_regcache <--[2]
remote_notice_new_inferior <--[3]
GDB sends packet "qC" in [1] and adds the thread/inferior if the remote
stubs understands "qC". In [2], GDB looks for the inferior to build a
regcache, and notices a new inferior in [3]. As we can see, GDB assumes
that the inferior can be found in [2]. Once the remote stub doesn't
support "qC", GDB can't look for the inferior in [2], and emits an
internal error.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Right after the initial connection, we query the target for its state,
with the ? packet. We store the resulting wait status / stop reply
aside, and query the target for the current thread, using qC, which
fails, so we fake a ptid for the target's thread. We then later,
after the initial setup, end up consuming that set-aside wait status,
parsing the T stop reply, which contains a "thread" "register" (which
was the thread the target would have replied to qC). We get into
trouble because the ptid in that stop reply doesn't match our faked up
ptid in the initial setup, although the target threads are the same...
So we had the T stop reply handy all along. We might as well extract
the thread's ptid from it, and avoid all the resulting issues.
qC is also used after vRun, in order to discover the new process'es
main thread. But, vRun's reply is also a wait status, just like
'?''s, which is quite convenient.
This means that if we have a "Txx thread: ptid" reply, then we don't
really need qC. The patch makes GDB look in the T reply first, and if
not found, try with qC. The packet handling seems to have been added
in gdb-4.18 (1999), and I see that in that same release, "Txx thread:
ptid" didn't exist yet, which probably explains why nobody though of
doing this before.
Regression tested against a gdbserver with qC disabled (and then
enabled), on x86_64 Fedora 17.
2013-01-25 Pedro Alves <palves@redhat.com>
* remote.c (stop_reply_extract_thread): New.
(add_current_inferior_and_thread): New parameter 'wait_status'.
Handle it.
(remote_start_remote): Pass wait status to
add_current_inferior_and_thread.
(extended_remote_run): Update comment.
(extended_remote_create_inferior_1): Pass wait status to
add_current_inferior_and_thread.
Andrew Burgess [Fri, 25 Jan 2013 17:16:43 +0000 (17:16 +0000)]
sourceware.org/ml/gdb-patches/2012-11/msg00312.html
gdb/ChangeLog
* valarith.c (value_vector_widen): New function for replicating a
scalar into a vector.
(value_binop): Use value_vector_widen to widen scalar to vector
rather than casting, this better matches gcc C behaviour.
* valops.c (value_casst): Update logic for casting between vector
types, and for casting from scalar to vector, try to match gcc C
behaviour.
* value.h (value_vector_widen): Declare.
* opencl-lang.c (opencl_value_cast): New opencl specific casting
function, handle special case for casting scalar to vector.
(opencl_relop): Use opencl_value_cast.
(evaluate_subexp_opencl): Use opencl_value_cast instead of
value_cast, and handle BINOP_ASSIGN, UNOP_CAST, and UNOP_CAST_TYPE
in order to use opencl_value_cast.
gdb/testsuite/ChangeLog
* gdb.base/gnu_vector.c: New variable for use in tests.
* gdb.base/gnu_vector.exp: Update and extend tests to reflect
changes in scalar to vector casting and widening.
* gdb.python/py-type.c: New variables for use in tests.
* gdb.python/py-type.exp: Update vector related tests to reflect
changes in scalar to vector casting and widening.
Nick Clifton [Fri, 25 Jan 2013 14:22:10 +0000 (14:22 +0000)]
* elf32-h8300.c (elf32_h8_relax_section): When checking for a
second reloc, make sure that the reloc potentially exists first.
Yao Qi [Fri, 25 Jan 2013 14:17:10 +0000 (14:17 +0000)]
gdb/
* event-loop.c: Include "queue.h".
(gdb_event_p): New typedef.
(DECLARE_QUEUE_P): Use.
(DEFINE_QUEUE_P): Use.
(async_queue_event): Remove.
(gdb_event_xfree): New.
(initialize_event_loop): New.
(process_event): Use QUEUE macros.
(event_queue): Remove.
(gdb_wait_for_event): Caller update.
(check_async_event_handlers): Likewise.
(poll_timers): Likewise.
* event-loop.h (initialize_event_loop): Declare.
* event-loop.c (gdb_event_xfree): New.
* top.c (gdb_init): Call initialize_event_loop.
Yao Qi [Fri, 25 Jan 2013 14:14:18 +0000 (14:14 +0000)]
gdb/
* event-loop.c (async_queue_event): Remove one parameter
'position'. Remove code handling 'position' == TAIL.
(gdb_wait_for_event): Caller update.
(check_async_event_handlers): Caller update.
(poll_timers): Caller update.
* event-loop.h (enum queue_position): Remove.
Yao Qi [Fri, 25 Jan 2013 14:12:02 +0000 (14:12 +0000)]
gdb/gdbserver
* event-loop.c: Include "queue.h".
(gdb_event_p): New typedef.
(struct gdb_event) <next_event>: Remove.
(event_queue): Change to QUEUE(gdb_event_p).
(async_queue_event): Remove.
(gdb_event_xfree): New.
(initialize_event_loop): New.
(process_event): Use API from QUEUE.
(wait_for_event): Likewise.
* server.c (main): Call initialize_event_loop.
* server.h (initialize_event_loop): Declare.
Kai Tietz [Fri, 25 Jan 2013 11:39:42 +0000 (11:39 +0000)]
* deffilep.y (def_image_name): Adjust type of base-address
argument.
(%union): Add new type bfd_vma as vma.
(VMA): New rule.
(opt_base): Use VMA instead of NUMBER rule to evaluate value.
(def_file_print): Use bfd's fprintf_vma to output base-address.
Nick Clifton [Fri, 25 Jan 2013 11:32:44 +0000 (11:32 +0000)]
* objcopy.c : Enable long section names for OPTION_ADD_GNU_DEBUGLINK.
Maxim Kuvyrkov [Fri, 25 Jan 2013 04:22:01 +0000 (04:22 +0000)]
* MAINTAINERS: Update my email.
Joseph Myers [Fri, 25 Jan 2013 02:02:21 +0000 (02:02 +0000)]
* config/tc-ppc.c (md_assemble): Do not generate APUinfo sections
for 64-bit output.
Yao Qi [Fri, 25 Jan 2013 00:46:19 +0000 (00:46 +0000)]
gdb/
* main.c (print_gdb_help): Remove "--epoch" from the help
message.
gdbadmin [Fri, 25 Jan 2013 00:00:35 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Thu, 24 Jan 2013 23:00:04 +0000 (23:00 +0000)]
daily update
Tiago Daitx [Thu, 24 Jan 2013 20:36:03 +0000 (20:36 +0000)]
gdb/
* symtab.c (skip_prologue_using_sal): Consider a file
change the same as an increased line number
gdb/testsuite/
* gdb.base/prologue-include.c: New file.
* gdb.base/prologue-include.exp: New file.
* gdb.base/prologue-include.h: New file.
Tiago Daitx [Thu, 24 Jan 2013 20:25:18 +0000 (20:25 +0000)]
gdb/
* MAINTAINERS (Write After Approval): Add myself to the list.
Doug Evans [Thu, 24 Jan 2013 20:24:44 +0000 (20:24 +0000)]
* dwarf.c (display_debug_addr): Add missing parentheses to expression.
Sriraman Tallam [Thu, 24 Jan 2013 18:49:55 +0000 (18:49 +0000)]
Default text reordering fix with a flag to turn it off.
2013-01-24 Sriraman Tallam <tmsriram@google.com>
* layout.cc (Layout::layout): Check for option text_reorder.
(Layout::make_output_section): Ditto.
* options.h (text_reorder): New option.
* output.cc (Input_section_sort_compare): Remove special ordering
of section names.
(Output_section::
Input_section_sort_section_name_special_ordering_compare::
operator()): New function.
(Output_section::sort_attached_input_sections): Use new sort function
for .text.
* output.h (Input_section_sort_section_name_special_ordering_compare):
New struct.
* testsuite/Makefile.am (text_section_grouping): Test option
--no-text-reorder
* testsuite/Makefile.in: Regenerate.
* testsuite/text_section_grouping.sh: Check order of functions without
default text reordering.
Tom Tromey [Thu, 24 Jan 2013 18:04:34 +0000 (18:04 +0000)]
* ada-lang.h (ada_decode_symbol): Make return type const.
* ada-lang.c (ada_decode_symbol): Likewise.
Nick Clifton [Thu, 24 Jan 2013 16:51:56 +0000 (16:51 +0000)]
* v850.h: Add e3v5 support.
Nick Clifton [Thu, 24 Jan 2013 11:14:05 +0000 (11:14 +0000)]
Add support for V850E3V5 architecture
Hafiz Abid Qadeer [Thu, 24 Jan 2013 10:29:09 +0000 (10:29 +0000)]
2013-01-24 Hafiz Abid Qadeer <abidh@codesourcery.com>
PR gdb/13443
* gdb.mi/mi-var-block.exp: Make test messages unique.
gdbadmin [Thu, 24 Jan 2013 00:00:04 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Wed, 23 Jan 2013 23:00:08 +0000 (23:00 +0000)]
daily update
Tom Tromey [Wed, 23 Jan 2013 21:04:45 +0000 (21:04 +0000)]
* gdb.dwarf2/dw2-error.exp: Pass test name to "file" test.
Tom Tromey [Wed, 23 Jan 2013 20:34:22 +0000 (20:34 +0000)]
* gdb.cp/converts.cc (main): Initialize 'a'.
Doug Evans [Wed, 23 Jan 2013 20:07:39 +0000 (20:07 +0000)]
* linespec.c (find_linespec_symbols): Make static.
Sergio Durigan Junior [Wed, 23 Jan 2013 20:03:18 +0000 (20:03 +0000)]
2013-01-23 Tiago Stürmer Daitx <tdaitx@linux.vnet.ibm.com>
* ppc-sysv-tdep.c (ppc64_sysv_abi_return_value): Set correct
type on float conversion for complex type.
Siva Chandra Reddy [Wed, 23 Jan 2013 19:59:13 +0000 (19:59 +0000)]
Add a new class gdb.Architecture which exposes GDB's
internal representation of architecture via GDB Python API.
* Makefile.in: Add entries corresponding to the new file
python/py-arch.c.
* NEWS (Python Scripting): Add entries for the new class
gdb.Architecture and the new method gdb.Frame.architecture.
* python/py-arch.c: Implement gdb.Architecture class.
* python/py-frame.c (frapy_arch): Implement the method
gdb.Frame.architecture().
(frame_object_methods): Add 'architecture' to the method table.
* python/python-internal.h: Add declarations of new utility
functions.
* python/python.c (_initialize_python): Initialize
gdb.Architecture class.
* doc/gdb.texinfo (Architectures In Python): New sub-sub-section
describing the gdb.Architecture class.
(Frames In Python): Add description about the new method
gdb.Frame.architecture().
* testsuite/gdb.python/frame.exp: Add a test for
gdb.Frame.architecture() method.
Doug Evans [Wed, 23 Jan 2013 18:47:51 +0000 (18:47 +0000)]
Work around binutils/15021.
* dwarf2read.c (dwarf2_per_cu_data): Split imported_symtabs and
type_unit_group out of union s. All uses updated.
(read_index_from_section): Watch for index version 8.
(follow_die_sig): If using .gdb_index version <= 7, record the TU as
an imported symtab.
(write_psymtabs_to_index): Increment version number to 8.
doc/
* gdb.texinfo (Index Section Format): Document .gdb_index version 8.
Nick Clifton [Wed, 23 Jan 2013 15:12:01 +0000 (15:12 +0000)]
PR ld/15041
* scripttempl/pep.sc (.pdata): Only accept .pdata sections.
(.xdata): Similarly.
(.debug_frame): Similarly.
Nick Clifton [Wed, 23 Jan 2013 12:41:32 +0000 (12:41 +0000)]
* elf32-metag.c: Error on HIADDR16/LOADDR16 in shared link.
Nick Clifton [Wed, 23 Jan 2013 12:01:12 +0000 (12:01 +0000)]
PR gas/15039
* config/tc-avr.c: Include dwarf2dbg.h.
Nick Clifton [Wed, 23 Jan 2013 11:56:02 +0000 (11:56 +0000)]
PR ld/15037
* scripttempl/avr.sc (.eeprom): Keep it.
Alan Modra [Wed, 23 Jan 2013 10:31:13 +0000 (10:31 +0000)]
* Makefile.am (ALL_64_EMULATION_SOURCES): Add eelf64rdos.c.
(eelf64rdos.c): New rule.
* emulparams/elf64rdos.sh: New file.
* configure.tgt (x86_64-*-rdos*): Use above.
* Makefile.in: Regenerate.
Alan Modra [Wed, 23 Jan 2013 10:29:42 +0000 (10:29 +0000)]
* config.bfd (x86_64-*-rdos*): Remove targ_selvecs.
Andreas Krebbel [Wed, 23 Jan 2013 08:45:19 +0000 (08:45 +0000)]
2013-01-23 Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
* readelf.c: Add strings for NT_S390_LAST_BREAK and
NT_S390_SYSTEM_CALL.
gdbadmin [Wed, 23 Jan 2013 00:00:41 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Tue, 22 Jan 2013 23:00:05 +0000 (23:00 +0000)]
daily update
Roland McGrath [Tue, 22 Jan 2013 22:07:34 +0000 (22:07 +0000)]
ld/
* emultempl/elf32.em (gld${EMULATION_NAME}_before_parse): Set
new_dtags to TRUE for *-*-nacl* targets.
Pedro Alves [Tue, 22 Jan 2013 20:22:39 +0000 (20:22 +0000)]
If a breakpoint is not user visible, then there's no point in
bothering the frontend about it... This is the exact same check MI
does.
I also smoke tested Emacs 23 in gud-gdb mode, both annotations=2
and annotations=3. I didn't notice anything break.
gdb/
2013-01-22 Pedro Alves <palves@redhat.com>
* annotate.c (breakpoint_changed): Skip if breakpoint is not
user-visible.
gdb/testsuite/
2013-01-22 Pedro Alves <palves@redhat.com>
* gdb.base/annota1.exp (signal sent): No longer expect
breakpoints-invalid.
* gdb.cp/annota2.exp (continue until exit)
(watch triggered on a.x): Ditto.
Pedro Alves [Tue, 22 Jan 2013 20:19:40 +0000 (20:19 +0000)]
All annotate_breakpoints_changed calls are along-side
observer_notify_breakpoints_changed calls. All, except the
init_raw_breakpoint one. But that one is actually wrong. The
breakpoint is being constructed at that point, and hasn't been placed
on the breakpoint chain yet. It would be better placed in
install_breakpoint, and I actually started out that way. But once the
annotate_breakpoints_changed are parallel to the observer calls, we
can fully move annotations to observers too.
One issue is that this changes the order of annotations a bit.
Before, we'd emit the annotation, and after call "mention()" on the
breakpoint (which prints the breakpoint number, etc.). But, we call
the observers _after_ mention is called, so the annotation output will
change a little:
void
install_breakpoint (int internal, struct breakpoint *b, int update_gll)
{
add_to_breakpoint_chain (b);
set_breakpoint_number (internal, b);
if (is_tracepoint (b))
set_tracepoint_count (breakpoint_count);
if (!internal)
mention (b);
observer_notify_breakpoint_created (b);
if (update_gll)
update_global_location_list (1);
}
I believe this order doesn't really matter (the frontend needs to wait
for the prompt anyway), so I just adjust the expected output in the
tests. Emacs in annotations mode doesn't seem to complain. Couple
that with the previous patch that suppressed duplicated annotations,
and, the fact that some annotations calls were actually missing (were
we do have observer calls), more changes to the tests are needed
anyway.
Tested on x86_64 Fedora 17.
gdb/
2013-01-22 Pedro Alves <palves@redhat.com>
* annotate.c (annotate_breakpoints_changed): Rename to ...
(annotate_breakpoints_invalid): ... this. Make static.
(breakpoint_changed): Adjust.
(_initialize_annotate): Always install the observers. Install a
"breakpoint_created" observer.
* annotate.h (annotate_breakpoints_changed): Delete declaration.
* breakpoint.c (set_breakpoint_condition)
(breakpoint_set_commands, do_map_commands_command)
(init_raw_breakpoint, clear_command, set_ignore_count)
(enable_breakpoint_disp): No longer call
annotate_breakpoints_changed.
gdb/testsuite/
2013-01-22 Pedro Alves <palves@redhat.com>
* gdb.base/annota1.exp (breakpoints_invalid): New variable.
Adjust tests to breakpoints-invalid changes.
* gdb.cp/annota2.exp (breakpoints_invalid, frames_invalid): New
variables.
Adjust tests to breakpoints-invalid changes.
Pedro Alves [Tue, 22 Jan 2013 20:17:10 +0000 (20:17 +0000)]
With some changes to how software single-step (SSS) breakpoints are
handled, one of those being to place SSS breakpoints on the breakpoint
chain as all other breakpoints, annota1.exp times out with lots and
lots of breakpoint-invalid and frame-changed annotations. All those
extra annotations are actually unnecessary. For one, SSS breakpoints
are internal breakpoints, so the frontend shouldn't care if they were
added, removed or changed. Then, there's really no point in emitting
"breakpoints-invalid" or "frames-invalid" more than once between times
the frontend/user can actually issues GDB commands; the frontend will
have to wait for the GDB prompt to refresh its state, so emitting
those annotations at most once between prompts is enough. Non-stop or
async would complicate this, but no frontend will be using annotations
in those modes (one of goes of emacs switching to MI was non-stop mode
support, AFAIK). The previous patch reveals there has been an
intention in the past to suppress multiple breakpoints-invalid
annotations caused by ignore count changes. As the previous patch
shows, that's always been broken, but in any case, this patch actually
makes it work. The next patch will remove several annotation-specific
calls in breakpoint.c in favor of always using the breakpoint modified
& friends observers, and that causes yet more of these annotations,
because several calls to the corresponding annotate_* functions in
breakpoint.c are missing, particularly in newer code.
So all in all, here's a simple mechanism that avoids sending the same
annotation to the frontend more than once until gdb is ready to accept
further commands.
Tested on x86_64 Fedora 17.
2013-01-22 Pedro Alves <palves@redhat.com>
* annotate.c: Include "inferior.h".
(frames_invalid_emitted)
(breakpoints_invalid_emitted): New globals.
(async_background_execution_p): New function.
(annotate_breakpoints_changed, annotate_frames_invalid): Skip
emitting the annotation if it has already been emitted.
(annotate_display_prompt): New function.
* annotate.h (annotate_display_prompt): New declaration.
* event-top.c: Include annotate.h.
(display_gdb_prompt): Call annotate_display_prompt.
Pedro Alves [Tue, 22 Jan 2013 20:08:30 +0000 (20:08 +0000)]
There's code in annotate.c and breakpoint.c that is supposed to
suppress multiple breakpoints-invalid annotations when the ignore
count of a breakpoint changes, up until the target actually stops.
But, the code is bogus:
void
annotate_breakpoints_changed (void)
{
if (annotation_level == 2)
{
target_terminal_ours ();
printf_unfiltered (("\n\032\032breakpoints-invalid\n"));
if (ignore_count_changed)
ignore_count_changed = 0; /* Avoid multiple break annotations. */
}
}
The "ignore_count_changed" flag isn't actually guarding the output of
the annotation at all. It would have been better written something
like:
void
annotate_breakpoints_changed (void)
{
if (annotation_level == 2 && !ignore_count_changed)
{
target_terminal_ours ();
printf_unfiltered (("\n\032\032breakpoints-invalid\n"));
ignore_count_changed = 0; /* Avoid multiple break annotations. */
}
}
but, it wasn't. AFAICS, that goes all the way back to the original
patch'es submission and check in, at
<http://sourceware.org/ml/gdb-patches/1999-q4/msg00106.html>. I
looked a tar of HP's wdb from 1999, and even though that contains
local changes in the annotate code, this suppression seems borked
there too to me.
The original patch added a test to supposedly exercise this
suppression, but, it actually doesn't. It merely tests that
"breakpoints-invalid" is output after "stopped", but doesn't check
whether the duplicates supression actually works (IOW, check that only
_one_ annotation is seen). I was going to simply delete the tests
too, but a following patch will eliminate the duplicates in a
different way (which I needed for a different reason), so instead, I'm
making the tests actually fail if a duplicate annotation is seen.
Worry not, the test doesn't actually fail! The reason is that
breakpoint.c does:
else if (b->ignore_count > 0)
{
b->ignore_count--;
annotate_ignore_count_change ();
bs->stop = 0;
/* Increase the hit count even though we don't stop. */
++(b->hit_count);
observer_notify_breakpoint_modified (b);
}
where the annotate_ignore_count_change call is meant to inform the
"breakpoint_modified" annotation observer to ignore the notification.
All sounds good. But, the trouble is that nowadays annotate.c only
installs the observers if GDB is started with annotations enabled with
a command line option (gdb --annotate=2):
void
_initialize_annotate (void)
{
if (annotation_level == 2)
{
observer_attach_breakpoint_deleted (breakpoint_changed);
observer_attach_breakpoint_modified (breakpoint_changed);
}
}
and annota1.exp, to enable annotations, starts GDB normally, and
afterwards does "set annotate 2", so the observers aren't installed
when annota1.exp is run, and therefore changing the ignore count isn't
triggering any annotation at all...
gdb/
2013-01-22 Pedro Alves <palves@redhat.com>
* annotate.c (ignore_count_changed): Delete.
(annotate_breakpoints_changed): Don't clear ignore_count_changed.
(annotate_ignore_count_change): Delete.
(annotate_stopped): Don't emit a delayed breakpoints-changed
annotation.
* annotate.h (annotate_ignore_count_change): Delete.
* breakpoint.c (bpstat_check_breakpoint_conditions): Don't call
annotate_ignore_count_change.
gdb/testsuite/
2013-01-22 Pedro Alves <palves@redhat.com>
* gdb.base/annota1.exp (annotate ignore count change): Add
expected output for failure case.
Tom Tromey [Tue, 22 Jan 2013 15:57:28 +0000 (15:57 +0000)]
* dwarf2loc.c (dwarf2_compile_expr_to_ax) <DW_OP_fbreg>: Only
require_rvalue for a register location.
Tom Tromey [Tue, 22 Jan 2013 15:47:54 +0000 (15:47 +0000)]
* gdb.gdb/selftest.exp (do_steps_and_nexts): Handle bfd_init
call.
Marc Khouzam [Tue, 22 Jan 2013 00:06:26 +0000 (00:06 +0000)]
Updated Changelog and testsuite/Changelog because of bad formatting.
gdbadmin [Tue, 22 Jan 2013 00:00:33 +0000 (00:00 +0000)]
*** empty log message ***
Marc Khouzam [Mon, 21 Jan 2013 23:58:00 +0000 (23:58 +0000)]
2013-01-21 Marc Khouzam <marc.khouzam@ericsson.com>
* breakpoint.c (print_one_breakpoint_location): Add MI
field 'thread-groups' when printing a breakpoint.
(output_thread_groups): New function.
2013-01-21 Marc Khouzam <marc.khouzam@ericsson.com>
* gdb.texinfo (GDB/MI Breakpoint Commands): Document new
'thread-groups' field when printing a breakpoint in MI.
2013-01-21 Marc Khouzam <marc.khouzam@ericsson.com>
* gdb.mi/mi-break.exp: Expect new 'thread-groups' field.
* gdb.mi/mi-nsmoribund.exp: Expect new 'thread-groups' field.
Also handle 'thread' field.
* gdb.mi/mi-simplerun.exp: Expect new 'thread-groups' field.
* gdb.mi/mi-watch.exp: Ditto.
* lib/mi-support.exp: Ditto.
Alan Modra [Mon, 21 Jan 2013 23:00:04 +0000 (23:00 +0000)]
daily update
Siva Chandra Reddy [Mon, 21 Jan 2013 21:44:57 +0000 (21:44 +0000)]
* python/lib/gdb/commands/explore.py
(CompoundExplorer.explore_expr): Correct the name of a method
being invoked.
(ExploreTypeCommand.invoke): Add a missing 'return'.
* testsuite/gdb.python/py-explore.exp: Improve a test
Tom Tromey [Mon, 21 Jan 2013 18:15:32 +0000 (18:15 +0000)]
* gdb_obstack.h (obconcat): Move declaration here, from...
* symfile.h (obconcat): ... here.
* gdb_obstack.c: New file.
(obconcat): Move from...
* symfile.c (obconcat): ... here.
* Makefile.in (SFILES): Add gdb_obstack.c.
(COMMON_OBS): Add gdb_obstack.o.
Tom Tromey [Mon, 21 Jan 2013 18:13:14 +0000 (18:13 +0000)]
* symfile.h (obsavestring): Don't declare.
* symfile.c (obsavestring): Remove.
* ada-exp.y: Use obstack_copy0, not obsavestring.
* ada-lang.c: Use obstack_copy0, not obsavestring.
* coffread.c: Use obstack_copy0, not obsavestring.
* cp-namespace.c: Use obstack_copy0, not obsavestring.
* dbxread.c: Use obstack_copy0, not obsavestring.
* dwarf2read.c: Use obstack_copy0, not obsavestring.
* jit.c: Use obstack_copy0, not obsavestring.
* mdebugread.c: Use obstack_copy0, not obsavestring.
* psymtab.c: Use obstack_copy0, not obsavestring.
* stabsread.c: Use obstack_copy0, not obsavestring.
* xcoffread.c: Use obstack_copy0, not obsavestring.
Tom Tromey [Mon, 21 Jan 2013 18:10:33 +0000 (18:10 +0000)]
* dwarf2read.c (fixup_go_packaging): Save package name
on objfile obstack.
* gdbtypes.c (init_type): Don't copy name.
Tom Tromey [Mon, 21 Jan 2013 18:08:53 +0000 (18:08 +0000)]
* dwarf2read.c (struct partial_die_info) <name, scope>: Now
const.
(struct attribute) <u.str>: Now const.
(struct fnfieldlist) <name>: Now const.
(dw2_get_file_names_reader, init_cutu_and_read_dies): Update.
(partial_die_parent_scope): Make return type const.
(partial_die_full_name, add_partial_symbol): Update.
(dwarf2_compute_name, dwarf2_full_name, dwarf2_physname): Make
'name' const.
(find_file_and_directory): Make 'name' and 'comp_dir' const.
(read_file_scope, read_func_scope, dwarf2_add_field)
(dwarf2_add_member_fn, read_structure_type)
(process_enumeration_scope, read_array_type, read_module_type)
(read_base_type, read_subrange_type): Update.
(dwarf2_start_symtab): Make 'name' and 'comp_dir' const.
(new_symbol_full, guess_full_die_structure_name): Update.
(dwarf2_canonicalize_name): Return const type. Make 'name' const.
(dwarf2_name): Return const type.
(dwarf_decode_macro_bytes, dwarf_decode_macros): Make 'comp_dir'
const.
Tom Tromey [Mon, 21 Jan 2013 18:07:03 +0000 (18:07 +0000)]
* gdbtypes.c (init_type): Make 'name' const.
* gdbtypes.h (init_type): Update.
Tom Tromey [Mon, 21 Jan 2013 18:05:13 +0000 (18:05 +0000)]
* buildsym.c (patch_subfile_names): Use set_last_source_file.
(start_symtab): Make 'name' and 'dirname' const. Use
set_last_source_file.
(restart_symtab, reset_symtab_globals): Use set_last_source_file.
(last_source_file): Define. Now static.
(set_last_source_file, get_last_source_file): New functions.
* buildsym.h (last_source_file): Don't declare.
(start_symtab): Update.
(set_last_source_file, get_last_source_file): Declare.
* coffread.c (complete_symtab): Use set_last_source_file.
(coff_end_symtab): Likewise.
(coff_symtab_read): Use set_last_source_file, get_last_source_file.
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Use
set_last_source_file.
(process_one_symbol): Use get_last_source_file.
* mdebugread.c (parse_partial_symbols): Use set_last_source_file.
(psymtab_to_symtab_1): Use get_last_source_file.
* xcoffread.c (process_linenos): Use get_last_source_file.
(complete_symtab): Use set_last_source_file.
(read_xcoff_symtab): Use set_last_source_file, get_last_source_file.
(scan_xcoff_symtab): Use set_last_source_file.
Tom Tromey [Mon, 21 Jan 2013 18:03:08 +0000 (18:03 +0000)]
* symtab.c (struct demangled_name_entry) <mangled>: Now const.
(symbol_set_names): Remove casts. Handle field const-ness.
Tom Tromey [Mon, 21 Jan 2013 18:01:34 +0000 (18:01 +0000)]
* dwarf2read.c (new_symbol_full): Remove cast.
* symtab.c (symbol_set_demangled_name): Make 'name' const.
* symtab.h (symbol_set_demangled_name): Update.
Tom Tromey [Mon, 21 Jan 2013 17:32:10 +0000 (17:32 +0000)]
* main.c (captured_main): Call bfd_init.
Tom Tromey [Mon, 21 Jan 2013 17:29:39 +0000 (17:29 +0000)]
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Don't set default ABI.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Set default ABI.
* minsyms.c (install_minimal_symbols): Don't check for _Z symbols.
* NEWS: Update.
Jan Kratochvil [Mon, 21 Jan 2013 17:14:33 +0000 (17:14 +0000)]
gdb/
* symmisc.c (maintenance_print_msymbols): Check also ST_DEV.
Jan Kratochvil [Mon, 21 Jan 2013 16:46:12 +0000 (16:46 +0000)]
gdb/
Fix gdb.fortran/common-block.exp crash in PIE mode.
* dwarf2read.c (new_symbol_full) <DW_TAG_common_block>: Use
LOC_COMMON_BLOCK.
* f-valprint.c (info_common_command_for_block): Expect
LOC_COMMON_BLOCK in gdb_assert.
* symtab.h (struct general_symbol_info): Update comment for the
common_block member.
(domain_enum): Extend comment for the COMMON_BLOCK_DOMAIN member.
(enum address_class): New member LOC_COMMON_BLOCK.
Mike Frysinger [Mon, 21 Jan 2013 08:21:46 +0000 (08:21 +0000)]
ld: enable new dtags by default for linux/gnu targets
The "new" dtags options have been around for 14+ years now, so for Linux
and GNU targets, enable them by default.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Alan Modra [Mon, 21 Jan 2013 02:38:37 +0000 (02:38 +0000)]
* ld-size/size.exp (build_tests <size-7, size-8>): Pass
--no-as-needed in cflags.
gdbadmin [Mon, 21 Jan 2013 00:00:39 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Sun, 20 Jan 2013 23:00:07 +0000 (23:00 +0000)]
daily update
gdbadmin [Sun, 20 Jan 2013 00:00:03 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Sat, 19 Jan 2013 23:00:04 +0000 (23:00 +0000)]
daily update
H.J. Lu [Sat, 19 Jan 2013 19:36:37 +0000 (19:36 +0000)]
Add HOSTING_SCRT0 for PIE test
ld/
* Makefile.am (HOSTING_SCRT0): New.
* configure.host (HOSTING_SCRT0): New. Used for PIE.
* configure.in (HOSTING_SCRT0): New AC_SUBST.
* Makefile.in: Regenerated.
* configure: Likewise.
ld/testsuite/
* config/default.exp (get_target_emul): Also set HOSTING_SCRT0.
* lib/ld-lib.exp (default_ld_link): Use HOSTING_SCRT0 for -pie.
gdbadmin [Sat, 19 Jan 2013 00:00:04 +0000 (00:00 +0000)]
*** empty log message ***