Stephen White [Tue, 26 Jun 2018 14:41:27 +0000 (10:41 -0400)]
GrTessellator: fix edge winding merged to zero.
[cherry-pick of
531a48ed788c5fabfe21704286b54d7567f35469 to M68.]
Occasionally, the top edge of a split edge can be merged out of
existence (if it can't be mathematically distinguished from one of its
adjacent edges). In this case, we need to save its winding count
before it's merged so that the other half of the split doesn't also
get zero winding.
NOTE: this adds a new test case to the concavepaths GM.
No-Tree-Checks: true
No-Try: true
No-Presubmit: true
Bug: skia:7785
Change-Id: Iff8b0a2ed3065e57b737ff915ff436146987caf6
Reviewed-On: https://skia-review.googlesource.com/131223
Reviewed-By: Robert Phillips <robertphillips@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-on: https://skia-review.googlesource.com/137600
Brian Salomon [Mon, 25 Jun 2018 19:51:58 +0000 (15:51 -0400)]
Alternative fix for stale MIP maps on texture export/import.
This change assumes imported textures in SkImages have dirty mip levels
and disables regenerating the MIP levels on export (added in
https://skia.googlesource.com/skia/+/
930f939c48af1be6005af12bb6f709ca5da9d118).
This is being done temporarily because it is a simpler change to cherry
pick to earlier branches than
https://skia.googlesource.com/skia/+/
930f939c48af1be6005af12bb6f709ca5da9d118
No-Tree-Checks: true
No-Try: true
No-Presubmit: true
Bug: chromium:850617
Change-Id: I7c90da782a0ed9014acd6a54ffdee1a0b34fa00c
Reviewed-On: https://skia-review.googlesource.com/136788
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-By: Greg Daniel <egdaniel@google.com>
Reviewed-on: https://skia-review.googlesource.com/137131
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-on: https://skia-review.googlesource.com/137398
skia-bookmaker [Thu, 24 May 2018 06:29:18 +0000 (06:29 +0000)]
Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: Ife9566f2c606183fcaaf55aabea65a286af48816
Reviewed-on: https://skia-review.googlesource.com/129892
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
recipe-roller [Thu, 24 May 2018 05:47:47 +0000 (22:47 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
4e9b50ab86b9b9f8ebf0b9ba6bd4954217ebeff9 Revert recent gclient.py changes to fix Chrome releases. (mmoss@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia0c8cba2b76d939d8e6f94dbbb836eb6d83ae594
Reviewed-on: https://skia-review.googlesource.com/129922
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
angle-skia-autoroll [Thu, 24 May 2018 03:02:39 +0000 (03:02 +0000)]
Roll third_party/externals/angle2/
586750168..
b001528ff (4 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
58675016832d..
b001528ffa00
$ git log
586750168..
b001528ff --date=short --no-merges --format='%ad %ae %s'
2018-05-18 courtneygo Use libnativewindow for Android builds
2018-04-27 brandon1.jones Add initial specification for EGL_ANGLE_explicit_context Extension
2018-05-23 tobine Update required Windows SDK version to 10.0.17134
2018-05-23 geofflang Refactor a hex streaming into a generic FmtHex function.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: I3de68a031d87ecee87626ec873411579501547cc
Reviewed-on: https://skia-review.googlesource.com/129888
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
recipe-roller [Thu, 24 May 2018 02:37:39 +0000 (19:37 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
083eb25f9acbe034db94a1bd5c1659125b6ebf98 gclient: Don't allow URL to be None. (ehmaldonado@chromium.org)
https://crrev.com/
428e7c14de188f6b5cab6908e24e41165628dd1b roll-dep: Add tests. (ehmaldonado@chromium.org)
https://crrev.com/
398fb44e286670871e4a9bd6b84c3f29ede23d00 Print access errors using logging.error (rharrison@chromium.org)
https://crrev.com/
54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9 gclient: Refactor PrintRevInfo (ehmaldonado@chromium.org)
https://crrev.com/
ebdd0db493b20f0abeab8960e6ea0ceb7c6b379a gclient: Remove URLs from hierarchy. (ehmaldonado@chromium.org)
https://crrev.com/
1f156687a2014f50548eacfffb825fb4f38c44d7 gerrit/api.py: Add get_revision() helper. (agrieve@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I366d059eff87e530d1d5863eeaf8920c353e46e8
Reviewed-on: https://skia-review.googlesource.com/129920
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Khushal [Thu, 24 May 2018 01:16:00 +0000 (18:16 -0700)]
Reland fonts: Cleanup cache miss logging for font remoting.
This reverts commit
fc6cf92e4b21c92ead769fae557534056eac6d83.
TBR=herb@google.com
Bug: skia:7913
Change-Id: I93301e49839fdb895a5f1f5845bb9975981c69fc
Reviewed-on: https://skia-review.googlesource.com/129880
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Khushal [Wed, 23 May 2018 22:45:01 +0000 (15:45 -0700)]
Reland fonts: Add support for distance field text to font remoting.
This reverts commit
7257e22e43a56a5f4f772b687034580061cd011f.
TBR=herb@google.com, bsalomon@google.com
Bug: skia:7913
Change-Id: I51ca5bccdda64cd98e2ad59874e7136ee58cec10
Reviewed-on: https://skia-review.googlesource.com/129809
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Chris Dalton [Wed, 23 May 2018 23:11:09 +0000 (17:11 -0600)]
ccpr: Handle winding and even-odd in the same shader
We are already waiting for an entire texture lookup anyway. A couple
extra flops should still complete before the texture fetch. This also
gives us better batching.
TBR=bsalomon@google.com
Bug: skia:
Change-Id: I7b8e3021c8baad200af99600c9592df5ed0e46bd
Reviewed-on: https://skia-review.googlesource.com/129881
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Auto-Submit: Chris Dalton <csmartdalton@google.com>
Chris Dalton [Wed, 23 May 2018 22:51:22 +0000 (22:51 +0000)]
Revert "ccpr: Handle winding and even-odd in the same shader"
This reverts commit
5dd3fccb3c7d9fce2663803a1284734237d8546d.
Reason for revert: fma() not supported pre-3.1
Original change's description:
> ccpr: Handle winding and even-odd in the same shader
>
> We are already waiting for an entire texture lookup anyway. A couple
> extra flops should still complete before the texture fetch. This also
> gives us better batching.
>
> Bug: skia:
> Change-Id: I83a7a8ba6c05cd1ad6b1756a987429233e69ed6c
> Reviewed-on: https://skia-review.googlesource.com/129422
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,csmartdalton@google.com
Change-Id: Iaa6b72686fdf89b58a0ea8418296985c2a3dc27e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/129900
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Florin Malita [Wed, 23 May 2018 20:35:56 +0000 (16:35 -0400)]
[skottie] SK_API-export public classes
TBR=
Change-Id: I14fcbf0932ff5c6de6fc4b500647f74d55d72266
Reviewed-on: https://skia-review.googlesource.com/129463
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Leon Scroggins III [Wed, 23 May 2018 20:15:09 +0000 (16:15 -0400)]
Alternate between two SkBitmaps in SkAnimatedImage
Bug:
78866720
The client in Android calls newPictureSnapshot, which results in copying
the mutable SkBitmap into a newly allocated one in each frame. Avoid
this by calling SkMakeImageFromRasterBitmap with
kNever_SkCopyPixelsMode. Make SkAnimatedImage copy on write, by copying
before decoding if the bitmap's pixel ref is not unique.
Android's AnimatedImageDrawable's current architecture only decodes one
frame in advance, so it will never need to perform the copy on write.
This will save one bitmap allocation per GIF frame.
Add a test to verify that copy on write works as expected.
Change-Id: I87eb6e84089096cd2d618b91fb627fc58677e66a
Reviewed-on: https://skia-review.googlesource.com/129841
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Leon Scroggins III [Wed, 23 May 2018 20:12:32 +0000 (16:12 -0400)]
Make DNG decodes single threaded on Android
Bug:
78878033
Test: testWarpedDng in CtsGraphicsTestCases
Previously this was set to 4 threads. For some images, this requires
allocating close to 2 GB of memory. This is not something we can support
on all devices. Unfortunately, we cannot tell the difference between
images that will allocate so much memory, so just use one thread all the
time.
Change-Id: I9fb9a65af97efd63fac8f6b282525ff3b650968d
Reviewed-on: https://skia-review.googlesource.com/129840
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Chris Dalton [Wed, 23 May 2018 00:58:22 +0000 (18:58 -0600)]
ccpr: Handle winding and even-odd in the same shader
We are already waiting for an entire texture lookup anyway. A couple
extra flops should still complete before the texture fetch. This also
gives us better batching.
Bug: skia:
Change-Id: I83a7a8ba6c05cd1ad6b1756a987429233e69ed6c
Reviewed-on: https://skia-review.googlesource.com/129422
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
angle-skia-autoroll [Wed, 23 May 2018 17:32:39 +0000 (17:32 +0000)]
Roll third_party/externals/angle2/
be7f44fb5..
586750168 (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
be7f44fb5741..
58675016832d
$ git log
be7f44fb5..
586750168 --date=short --no-merges --format='%ad %ae %s'
2018-05-22 jmadill Vulkan: Refactor CopyTexImage to use readPixelsImpl.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: I970544fa6645b088a8d6425712046ed6f2ec4981
Reviewed-on: https://skia-review.googlesource.com/129749
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Chris Dalton [Wed, 23 May 2018 18:00:07 +0000 (12:00 -0600)]
ccpr: Add a mechanism to detach and merge pending paths
Bug: skia:7988
Change-Id: Ie3fd7c5d57abdf70db40d309b7a83333045ad972
Reviewed-on: https://skia-review.googlesource.com/129622
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Weiliang Chen [Tue, 22 May 2018 22:44:02 +0000 (18:44 -0400)]
Add usage of SkYUVAIndex as pre-step to transfer to new YUVA API
The plan foward is to have a new API on SkImage to make from YUVA
textures which a combination of array of textures and array of
SkYUVAIndex struct indicating which texture and channel to read for
each plane. This is a pre-step to let the old API use these ideas.
Bug: skia: 7903
Change-Id: I6a696db31a574247eb2abff60f2186a74b640142
Reviewed-on: https://skia-review.googlesource.com/128601
Commit-Queue: Weiliang Chen <weiliangc@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Weiliang Chen [Tue, 22 May 2018 13:03:43 +0000 (09:03 -0400)]
Update clang-format matching more of Chromium
This CL does one thing: disallow short if/loop becoming a single
line.
Skia style guide prefers to always have braces. Though always
have braces isn't achievable by clang-format, always breaking into
multiple lines can be set.
Bug: skia:
Change-Id: I70b504dea01b4c916901ea2247ac0e052d468051
Reviewed-on: https://skia-review.googlesource.com/128688
Commit-Queue: Weiliang Chen <weiliangc@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Brian Osman [Wed, 23 May 2018 17:12:18 +0000 (13:12 -0400)]
Replace ICC profile in CodecTest with AdobeRGB
Change-Id: I00ca97ce7f584bdcc042f7e76fb0f8116978b799
Reviewed-on: https://skia-review.googlesource.com/129761
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Ben Wagner [Wed, 23 May 2018 16:52:43 +0000 (12:52 -0400)]
Remove include/gpu/mtl from include directories.
Prefer to use "mtl/" to set apart such includes and lessen the include
directory pollution. In addition no users of Skia want to add this
include directory to their includes list, so this change keeps that
setup working by having Skia build this way as well.
Change-Id: I5742e2c981e4cdb95b5af18dd39ec877162788de
Reviewed-on: https://skia-review.googlesource.com/129655
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Mike Klein [Wed, 23 May 2018 16:43:42 +0000 (12:43 -0400)]
update ColorSpaceTest.cpp to remove MakeICC
The upperLeft and upperRight profiles are A2B/B2A-only, and so cannot be
represented as SkColorSpace using SkColorSpace::Make(skcms_ICCProfile).
They do parse fine, of course.
Change-Id: Iaf51911c2b06b985037d3d5e74b043fb344e320e
Reviewed-on: https://skia-review.googlesource.com/129653
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Mike Reed [Wed, 23 May 2018 16:12:21 +0000 (12:12 -0400)]
fix 0.
499999f rounding case for triangles
Bug: skia:7994
Change-Id: I83bb309a2c8fb0bddaf78ba32c0a07537e483900
Reviewed-on: https://skia-review.googlesource.com/129648
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Chris Dalton [Wed, 23 May 2018 16:17:17 +0000 (10:17 -0600)]
ccpr: Remove GrCCDrawPathsOp's back-pointer into CCPR
Bug: skia:7988
Change-Id: Ia05173e90fa2cda28de6ae2a9aaee577eaf4bc65
Reviewed-on: https://skia-review.googlesource.com/129621
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Mike Klein [Wed, 23 May 2018 16:09:41 +0000 (12:09 -0400)]
remove SkColorSpace::MakeICC() fuzzer
We're removing SkColorSpace::MakeICC() and replacing it with skcms.
The equivalent skcms_Parse() is already fuzzed.
Change-Id: Ic5c8f8c71976859b9892fdc6991aea90dac04eff
Reviewed-on: https://skia-review.googlesource.com/129652
Auto-Submit: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Brian Osman [Wed, 23 May 2018 15:52:00 +0000 (11:52 -0400)]
Use skcms for ICC parsing in HP codec test
Change-Id: I6319b00ae35a15ffeaf8a785dde874b730f42c13
Reviewed-on: https://skia-review.googlesource.com/129649
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Brian Osman [Wed, 23 May 2018 14:58:18 +0000 (10:58 -0400)]
Remove ColorCodecBench
This wasn't being run (AFAICT) and was built on pre-skcms color management.
Change-Id: I506e8767f716bc6e4590ce255c5e40f1064fc152
Reviewed-on: https://skia-review.googlesource.com/129644
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Roll skia/third_party/skcms
5bfec77..
b01dbd2 (1 commits)
https://skia.googlesource.com/skcms.git/+log/
5bfec77..
b01dbd2
2018-05-23 brianosman@google.com Recover the original primaries (using CHAD) when emitting gamut diagrams
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@google.com
Change-Id: I7501f2628fa30a57f445c99ade1184eea6a8bdcc
Reviewed-on: https://skia-review.googlesource.com/129709
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Derek Sollenberger [Tue, 22 May 2018 18:19:39 +0000 (14:19 -0400)]
Remove "/" from the generated jUnit method names.
The "/" character is not a valid character for method names in the
CTS testing environment and is causing problems with some of the
tooling so we are replacing the "/" with "_".
Bug: b/
80096930
Change-Id: Icdf790b0975f7c4205153887ffabaaaa85f07592
Reviewed-on: https://skia-review.googlesource.com/129581
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
Ben Wagner [Tue, 22 May 2018 19:50:07 +0000 (15:50 -0400)]
Upgrade Pixel devices.
No-Try: true
Change-Id: Icb326a4b49ad945046d5e471d1f6e8a2a22d4d86
Reviewed-on: https://skia-review.googlesource.com/129641
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Mike Reed [Wed, 23 May 2018 14:08:53 +0000 (10:08 -0400)]
reduce clip-limit for scan converter to avoid quad-edge overflow
For raster drawing, we already have a more conservative guard in SkBitmapDevice,
which "tiles" the drawing on 8K boundaries (the smaller limit needed for antialiasing
scan converters). This change is just needed for non-drawing uses of the scan converter.
Bug: skia:7998
Bug: oss-fuzz:8483
Change-Id: Icfee9ca1ffcf93a2a8a3078d9ee10494fa04a6c7
Reviewed-on: https://skia-review.googlesource.com/129628
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Chris Dalton [Tue, 22 May 2018 22:17:48 +0000 (16:17 -0600)]
Delete GrDrawOp::wasRecorded
Bug: skia:7988
Change-Id: I8d12beec835767f22302a1e167fcef46ee5e5ffc
Reviewed-on: https://skia-review.googlesource.com/129555
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Mike Reed [Wed, 23 May 2018 12:30:04 +0000 (08:30 -0400)]
tweak tolerance again for cubics
Bug: 845489
Bug: skia:7995
Change-Id: I05554377bd5630b7134864b6db282358613f1030
Reviewed-on: https://skia-review.googlesource.com/129721
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Robert Phillips [Wed, 23 May 2018 12:43:04 +0000 (08:43 -0400)]
Add a Win10/QuadroP400 SKPBench bot
This will be the baseline (aka non-DDL) bot with which we can compare the DDL times
Change-Id: I9a949447845d31560136d591a0c1a17e7be57ac9
Reviewed-on: https://skia-review.googlesource.com/129506
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Mike Klein [Tue, 22 May 2018 14:32:20 +0000 (10:32 -0400)]
Reland "start cleaning up non-skcms SkColorSpaceXforms"
This is a reland of
339133f82c30cd3080672db28e6f72c894cba05a
Original change's description:
> start cleaning up non-skcms SkColorSpaceXforms
>
> I think this gets rid of
> - SkColorSpaceXform_Base
> - SkColorSpaceXform_XYZ
> - SkColorSpaceXform_A2B
> and lots of support code. Might be more left to clean up?
>
> Change-Id: I560d974d1e879dfd6a63ee2244a3dd88bd495c8a
> Reviewed-on: https://skia-review.googlesource.com/129512
> Commit-Queue: Brian Osman <brianosman@google.com>
> Auto-Submit: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Brian Osman <brianosman@google.com>
Change-Id: I33ee0d8bcfd72c401823a2e7d5168c9ecc9a5181
Reviewed-on: https://skia-review.googlesource.com/129624
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Ben Wagner [Wed, 23 May 2018 07:59:02 +0000 (03:59 -0400)]
Update gn
The currrent gn is quite old. The new gn, among other fixes, now supports
checking includes.
The values come from
https://chromium.googlesource.com/chromium/buildtools.git/+/
893eb86b02b2571894e328f05551112b96df1cce
Change-Id: Ia2e47e18c7bbd3219a258fd6cc9063bf38588d00
Reviewed-on: https://skia-review.googlesource.com/129720
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
angle-skia-autoroll [Wed, 23 May 2018 08:07:46 +0000 (08:07 +0000)]
Roll third_party/externals/angle2/
64ac5d9eb..
be7f44fb5 (4 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
64ac5d9eb62e..
be7f44fb5741
$ git log
64ac5d9eb..
be7f44fb5 --date=short --no-merges --format='%ad %ae %s'
2018-05-21 jie.a.chen Vulkan: Use push constant for masked clear color
2018-05-17 jiawei.shao ES31: Implement EXT_geometry_shader framebuffer default layers on OpenGL
2018-05-21 tobine Roll fwd ANGLE chromium DEPs
2018-05-18 jgilbert Add `formatType` arg to computeSkipBytes.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: Iedeca631b97786477b4d27499e33c8cef6ee2abb
Reviewed-on: https://skia-review.googlesource.com/129702
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Mike Klein [Wed, 23 May 2018 00:15:37 +0000 (00:15 +0000)]
Revert "fonts: Add support for distance field text to font remoting."
This reverts commit
35e0a1a6908492c754156d1abb785da3a9ce2a6b.
Reason for revert: looks like we're leaking paths?
https://chromium-swarm.appspot.com/task?id=
3da25e2f0cadb210&refresh=10
Original change's description:
> fonts: Add support for distance field text to font remoting.
>
> R=​jvanverth@google.com, herb@google.com
>
> Bug: skia:7913
> Change-Id: Id3f5b3e75005be9a7234df774268359b406c99a8
> Reviewed-on: https://skia-review.googlesource.com/128970
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
TBR=jvanverth@google.com,bsalomon@google.com,bungeman@google.com,herb@google.com,khushalsagar@chromium.org
Change-Id: I37c54c8748db9b20e1f48016d8298808a1999fdb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7913
Reviewed-on: https://skia-review.googlesource.com/129681
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Mike Klein [Wed, 23 May 2018 00:16:47 +0000 (00:16 +0000)]
Revert "fonts: Cleanup cache miss logging for font remoting."
This reverts commit
2b8a0d1844ed236259284fbc2efe08dab0ed539f.
Reason for revert: reverting a CL this builds on
Original change's description:
> fonts: Cleanup cache miss logging for font remoting.
>
> Add hooks to notify the embedder if there is a cache miss during draw.
> Also remove the reference to SkStrikeClient from SkTypefaceProxy and
> SkScalerContextProxy, since the proxies can outlive the client.
>
> R=​herb@google.com
>
> Bug: 829622
> Change-Id: Ib2fd1b91ebd057856c1d4e717cf50b49f08c903b
> Reviewed-on: https://skia-review.googlesource.com/129402
> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
> Reviewed-by: Herb Derby <herb@google.com>
TBR=herb@google.com,khushalsagar@chromium.org
Change-Id: I8a331545988885c620685008f4b60240d80f3712
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829622
Reviewed-on: https://skia-review.googlesource.com/129682
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Mike Klein [Wed, 23 May 2018 00:06:33 +0000 (00:06 +0000)]
Revert "start cleaning up non-skcms SkColorSpaceXforms"
This reverts commit
339133f82c30cd3080672db28e6f72c894cba05a.
Reason for revert: broke NinePatchDrawableTest.testGetPadding? stranger things have happened.
Original change's description:
> start cleaning up non-skcms SkColorSpaceXforms
>
> I think this gets rid of
> - SkColorSpaceXform_Base
> - SkColorSpaceXform_XYZ
> - SkColorSpaceXform_A2B
> and lots of support code. Might be more left to clean up?
>
> Change-Id: I560d974d1e879dfd6a63ee2244a3dd88bd495c8a
> Reviewed-on: https://skia-review.googlesource.com/129512
> Commit-Queue: Brian Osman <brianosman@google.com>
> Auto-Submit: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Brian Osman <brianosman@google.com>
TBR=mtklein@chromium.org,brianosman@google.com
Change-Id: I9e76195481b8658b34936aeece278d81c286c0fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/129680
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
angle-skia-autoroll [Tue, 22 May 2018 22:44:39 +0000 (22:44 +0000)]
Roll third_party/externals/angle2/
534b00dbd..
64ac5d9eb (2 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
534b00dbda3e..
64ac5d9eb62e
$ git log
534b00dbd..
64ac5d9eb --date=short --no-merges --format='%ad %ae %s'
2018-05-22 lucferron Vulkan: Quick rename of member variable in DynamicBuffer
2018-05-18 geofflang Make sure the DisplayImpl is terminated if it fails to fully initialize.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: I1fdcf33e11be25d5ed0e51d6ad68fc5b7b574ca1
Reviewed-on: https://skia-review.googlesource.com/129556
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Khushal [Tue, 22 May 2018 21:30:52 +0000 (14:30 -0700)]
fonts: Cleanup cache miss logging for font remoting.
Add hooks to notify the embedder if there is a cache miss during draw.
Also remove the reference to SkStrikeClient from SkTypefaceProxy and
SkScalerContextProxy, since the proxies can outlive the client.
R=herb@google.com
Bug: 829622
Change-Id: Ib2fd1b91ebd057856c1d4e717cf50b49f08c903b
Reviewed-on: https://skia-review.googlesource.com/129402
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Ben Wagner [Tue, 22 May 2018 20:44:53 +0000 (16:44 -0400)]
IWYU for tools/fiddle/egl_context.cpp
There is no reason for this particular file to pull in the massive
fiddle_main.h.
Change-Id: I4ac8fa6195a78ce5adf2890cab694cfb2bd0660c
Reviewed-on: https://skia-review.googlesource.com/129452
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Brian Osman [Tue, 22 May 2018 20:56:40 +0000 (16:56 -0400)]
Clip to perspective quad in viewer
For GMs that draw content outside the window, this ensures that fake
and real perspective look more similar.
Change-Id: I5fd2372a21a0b6c04cb33ddef4ff53aebda1c43d
Reviewed-on: https://skia-review.googlesource.com/129454
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Greg Daniel [Tue, 22 May 2018 20:33:53 +0000 (16:33 -0400)]
MoltenVk fix for fuchsia again.
Bug: skia:
Change-Id: I57365b69c4c764079512dce9e6d1bb624a199d1f
Reviewed-on: https://skia-review.googlesource.com/129449
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Ben Wagner [Tue, 22 May 2018 19:26:43 +0000 (15:26 -0400)]
Remove include/gpu/vk from include paths.
The public.bzl doesn't yet support vulkan, Chromium adds this include
path but appears to do so for the one header fixed in this CL, and
Android seems to be fine with this change.
Change-Id: I3869776a7653c420b584129936c302b8c8e9e8fa
Reviewed-on: https://skia-review.googlesource.com/129640
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Khushal [Tue, 22 May 2018 19:13:12 +0000 (12:13 -0700)]
fonts: Add support for distance field text to font remoting.
R=jvanverth@google.com, herb@google.com
Bug: skia:7913
Change-Id: Id3f5b3e75005be9a7234df774268359b406c99a8
Reviewed-on: https://skia-review.googlesource.com/128970
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Chris Dalton [Tue, 22 May 2018 19:09:48 +0000 (13:09 -0600)]
ccpr: Remove local matrix data from path instances
Uses the built-in local matrix code instead trying to bake it into the
path instance data. If we find a case that can benefit from this type
of optimization in the future, we can use something like a texel
buffer and send in all of the coord transform data -- not just the
local matrix.
Bug: skia:
Change-Id: I194bc9e4f83e588f8aa93a1a4d40097475d84977
Reviewed-on: https://skia-review.googlesource.com/129332
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Greg Daniel [Tue, 22 May 2018 17:25:15 +0000 (13:25 -0400)]
Reland "Move gn setup for vulkan library/headers into their own third_party directory."
This reverts commit
2c2a119f945eedaced4bf081347a53f05cf0c39c.
Reason for revert: Relanding with fixes
Original change's description:
> Revert "Move gn setup for vulkan library/headers into their own third_party directory."
>
> This reverts commit
477094250cd55a38d4d796ab6c50eb57bdba65e1.
>
> Reason for revert:
> I think we know this broke the MoltenVK bots. It also appears to have broken the Fuchsia roll: https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%
2F8945885190914943680%2F%2B%2Fsteps%2Fbuild%2F0%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fgn_gen%2F0%2Fstdout
>
> Original change's description:
> > Move gn setup for vulkan library/headers into their own third_party directory.
> >
> > Bug: skia:
> > Change-Id: I4605f0d962271efb77bf3c17f1b0daaaddfb51c8
> > Reviewed-on: https://skia-review.googlesource.com/128540
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> > Reviewed-by: Ben Wagner <bungeman@google.com>
>
> TBR=egdaniel@google.com,mtklein@google.com,bungeman@google.com
>
> Change-Id: I6e41d98e39883eff34424a2f352b0c8adec178db
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/129444
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>
Bug: skia:
Change-Id: I26b4b1f7196dd1bd8bf2e7641ef741c90c742c81
Reviewed-on: https://skia-review.googlesource.com/129445
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Ben Wagner [Tue, 22 May 2018 17:17:03 +0000 (13:17 -0400)]
Remove include/gpu/gl from include paths.
This path is not used as an include path by public.bzl nor by Chromium.
Remove this include path to avoid breaking these clients and generally
make these includes more specific.
Change-Id: I9391d38d5241870086bf47cb8e49146736dc4ded
Reviewed-on: https://skia-review.googlesource.com/129561
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Brian Salomon [Tue, 22 May 2018 18:14:07 +0000 (14:14 -0400)]
Use layered templates for optional vertex attributes in GrTextureOp.
Also, use templated member function rather than macro to generate vertices.
Use enum class instead of bool for multitexturing template param.
Change-Id: I2ef26c1e0db91b39cfde2e9661f3483988831469
Reviewed-on: https://skia-review.googlesource.com/129600
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Mike Klein [Tue, 22 May 2018 14:32:20 +0000 (10:32 -0400)]
start cleaning up non-skcms SkColorSpaceXforms
I think this gets rid of
- SkColorSpaceXform_Base
- SkColorSpaceXform_XYZ
- SkColorSpaceXform_A2B
and lots of support code. Might be more left to clean up?
Change-Id: I560d974d1e879dfd6a63ee2244a3dd88bd495c8a
Reviewed-on: https://skia-review.googlesource.com/129512
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Greg Daniel [Tue, 22 May 2018 17:13:18 +0000 (13:13 -0400)]
Add more blacklists for intel 405 vulkan perf bot.
Bug: skia:
Change-Id: I39cae17623e1b186607258cdd6929d797fcd6e15
Reviewed-on: https://skia-review.googlesource.com/129511
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Herb Derby [Tue, 22 May 2018 16:01:50 +0000 (12:01 -0400)]
Remove SkTextBox
Change-Id: I697135475fa9c1b7e803500b743f10c3877c1e10
Reviewed-on: https://skia-review.googlesource.com/129560
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Ben Wagner [Tue, 22 May 2018 14:48:08 +0000 (10:48 -0400)]
Revert "Revert "IWYU for tests starting with 'D'.""
This reverts commit
edf8449d2c3663350b6b6e30d2fa4c70da02deef.
Change-Id: Ibeedd9965855b3ccfe44486d15307bf3da15fd9c
Reviewed-on: https://skia-review.googlesource.com/129516
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Stephen White [Tue, 22 May 2018 15:51:32 +0000 (11:51 -0400)]
GrTessellator: fix crash on merging a dead edge.
When merging coincident vertices, sometimes merging an edge will cause
the next edge in the list to die. But since merge_vertices() retrieves
the next edge before merging the current one, we then try to merge its
lifeless corpse, bringing it back as a zombie. The fix is to leave
dead edges, dead.
This was revealed by
ec79c39a770205910f0abd762de7e19a96c986ca, but was
likely a real bug that was being mishandled before that.
Bug: 844873
Bug: skia:7982
Change-Id: I752c45f7551df4278fa4cb4587e7ead48cd16a21
Reviewed-on: https://skia-review.googlesource.com/129524
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Ben Wagner [Tue, 22 May 2018 14:46:15 +0000 (10:46 -0400)]
Rename SwiftShader bots from CPU to GPU.
Bug: skia:7671
Change-Id: I1d6b2a07ca93acbe53c1e93d70335f5284cd494e
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129500
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Ben Wagner [Tue, 22 May 2018 15:24:21 +0000 (11:24 -0400)]
Update SampleLua and lua files.
The lua files were moved at one point without the internal path
references being updated. This updates them so that the SampleLua slides
can be seen in their full glory.
Change-Id: I4dd09c847be48d80fa61d3b9864d34a4aa9bb2f5
Reviewed-on: https://skia-review.googlesource.com/129515
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Joe Gregorio [Tue, 22 May 2018 15:29:03 +0000 (15:29 +0000)]
Revert "Update docs preview URL in presubmit"
This reverts commit
5c646cf10fd9f4db788d3993ea73093649306e80.
Reason for revert: I figured out how to make a preview in seconds,
as opposed to the minute that it used to be, so a special server
for previews isn't needed.
Original change's description:
> Update docs preview URL in presubmit
>
> NoTry: true
> Bug: skia:
> Change-Id: Id5b374f707ac44770a5142f104202d6509410767
> Reviewed-on: https://skia-review.googlesource.com/129505
> Reviewed-by: Joe Gregorio <jcgregorio@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
TBR=rmistry@google.com,jcgregorio@google.com
Change-Id: I1bbf557729ad4124e93c15f529c7369f68397892
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/129447
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Brian Salomon [Tue, 22 May 2018 14:48:49 +0000 (10:48 -0400)]
GrTextureOp: Rename template params "V" instead of "Vertex".
Avoids confusion with TextureGeometryProcessor::Vertex.
Change-Id: Ie47bc6431e803a5987d5a44e03faf3c60c9121b1
Reviewed-on: https://skia-review.googlesource.com/129513
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
angle-skia-autoroll [Tue, 22 May 2018 13:19:39 +0000 (13:19 +0000)]
Roll third_party/externals/angle2/
787338f9b..
534b00dbd (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
787338f9be51..
534b00dbda3e
$ git log
787338f9b..
534b00dbd --date=short --no-merges --format='%ad %ae %s'
2018-05-18 lucferron Vulkan: readPixels improvement - use DynamicBuffer
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: I167aee2741644afcb40cc004a54a8715ddc7fd8f
Reviewed-on: https://skia-review.googlesource.com/129437
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Mike Klein [Tue, 22 May 2018 13:47:52 +0000 (13:47 +0000)]
Reland "strip down SkICC.cpp"
This reverts commit
27fe397bc0cc1b091f9f85863c62b88156239cf0.
Reason for revert: time to fly.
Original change's description:
> Revert "strip down SkICC.cpp"
>
> This reverts commit
eab50eb9c6117c2a9d0e5648f89cebbb4dbd9d30
> and this tiny bit of
e61b969a07ba3ebe9e47e61381ad16c5d2c549a2:
>
> https://skia-review.googlesource.com/c/skia/+/127122/3/tests/ICCTest.cpp
>
> Change-Id: I4306e5118a4e5eb88c05078186a28bd443fd76f7
> Reviewed-on: https://skia-review.googlesource.com/127305
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,brianosman@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I93a6cfb66f0da0e098fdcb77ac1cd619e41614b1
Reviewed-on: https://skia-review.googlesource.com/129446
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Stephen White [Fri, 18 May 2018 21:17:57 +0000 (17:17 -0400)]
GrTessellator: remove 64K vertex limit.
This is some code I cargo-culted in from an another path renderer and
is not necessary since we don't used indexed geometry. I tested
locally up to 64M points in a path, and it seems fine (up to my
patience).
Bug: skia:7952
Change-Id: Id7745cd1ffe905bdd8a7a505174ba083f8ea91ee
Reviewed-on: https://skia-review.googlesource.com/129246
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Ravi Mistry [Tue, 22 May 2018 12:37:24 +0000 (08:37 -0400)]
Update docs preview URL in presubmit
NoTry: true
Bug: skia:
Change-Id: Id5b374f707ac44770a5142f104202d6509410767
Reviewed-on: https://skia-review.googlesource.com/129505
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Mike Klein [Tue, 22 May 2018 12:25:43 +0000 (12:25 +0000)]
Revert "Move gn setup for vulkan library/headers into their own third_party directory."
This reverts commit
477094250cd55a38d4d796ab6c50eb57bdba65e1.
Reason for revert:
I think we know this broke the MoltenVK bots. It also appears to have broken the Fuchsia roll: https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%
2F8945885190914943680%2F%2B%2Fsteps%2Fbuild%2F0%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fgn_gen%2F0%2Fstdout
Original change's description:
> Move gn setup for vulkan library/headers into their own third_party directory.
>
> Bug: skia:
> Change-Id: I4605f0d962271efb77bf3c17f1b0daaaddfb51c8
> Reviewed-on: https://skia-review.googlesource.com/128540
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Ben Wagner <bungeman@google.com>
TBR=egdaniel@google.com,mtklein@google.com,bungeman@google.com
Change-Id: I6e41d98e39883eff34424a2f352b0c8adec178db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/129444
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Mike Klein [Tue, 22 May 2018 12:23:12 +0000 (12:23 +0000)]
Revert "IWYU for tests starting with 'D'."
This reverts commit
b5f2897ab5be37e86ccce4ed474a2e02001a9040.
Reason for revert: looks like this broke the build for DM in Google3. Need more include dirs there?
Original change's description:
> IWYU for tests starting with 'D'.
>
> Change-Id: I9189e4b56ce1635b627119733447c2ed4220753d
> Reviewed-on: https://skia-review.googlesource.com/129319
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Ben Wagner <bungeman@google.com>
TBR=bsalomon@google.com,bungeman@google.com,herb@google.com
Change-Id: I01aac7dae6114685a0652cbde3defccc8a42caea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/129443
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Mike Klein [Tue, 22 May 2018 12:19:13 +0000 (12:19 +0000)]
Revert "remove fragile hack in addOval to avoid computing bounds"
This reverts commit
bc721ba4be626e3ba753f55341a7019d98044102.
Reason for revert: I think we'll want to reland with guards for layout tests. https://test-results.appspot.com/data/layout_results/linux_trusty_blink_rel/29630/layout-test-results/results.html
Original change's description:
> remove fragile hack in addOval to avoid computing bounds
>
> Bug: skia:
> Change-Id: Ide917f54633370f1fce46a115fa923794b981e2e
> Reviewed-on: https://skia-review.googlesource.com/129461
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=mtklein@google.com,reed@google.com
Change-Id: Ibadac8bbeca2b162d696e7cca51d580121afe71f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/129442
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
skia-bookmaker [Tue, 22 May 2018 06:29:31 +0000 (06:29 +0000)]
Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: Ia2d2df24589f6f35726f28d4e8c84223a3f7f5f3
Reviewed-on: https://skia-review.googlesource.com/129431
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
angle-skia-autoroll [Tue, 22 May 2018 01:32:39 +0000 (01:32 +0000)]
Roll third_party/externals/angle2/
42cf958ce..
787338f9b (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
42cf958ce8fa..
787338f9be51
$ git log
42cf958ce..
787338f9b --date=short --no-merges --format='%ad %ae %s'
2018-05-07 jgilbert Add headers to build file lists.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: I27a743ad2e400a4bccbae04079323a02d7927674
Reviewed-on: https://skia-review.googlesource.com/129428
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Kevin Lubick [Tue, 22 May 2018 01:17:15 +0000 (21:17 -0400)]
Fix FuzzCanvas - drawPath
Without this, our fuzzer would not be able to find
https://bugs.chromium.org/p/chromium/issues/detail?id=844457
on its own.
Bug: skia:
Change-Id: I61146242e9eca29821d13abfd6f777df2199df97
Reviewed-on: https://skia-review.googlesource.com/129502
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Herb Derby [Mon, 21 May 2018 20:10:17 +0000 (16:10 -0400)]
drawPosText no longer obeys paint alignment
Change-Id: Iac498b54dea4aa1b203d2b9c58e15bb5f2147f82
Reviewed-on: https://skia-review.googlesource.com/129462
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Chris Dalton [Mon, 21 May 2018 15:10:53 +0000 (09:10 -0600)]
ccpr: Abstract the draws list in a separate class
Bug: skia:
Change-Id: I583c1bdc470e5830d041955d14b164fc00d5d014
Reviewed-on: https://skia-review.googlesource.com/129227
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Mike Reed [Mon, 21 May 2018 20:50:01 +0000 (16:50 -0400)]
remove fragile hack in addOval to avoid computing bounds
Bug: skia:
Change-Id: Ide917f54633370f1fce46a115fa923794b981e2e
Reviewed-on: https://skia-review.googlesource.com/129461
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Herb Derby [Mon, 21 May 2018 17:46:38 +0000 (13:46 -0400)]
Simplify aligment for DFT drawText
The original code had to compensate for the alignment
that was passed in throught the paint. You can
simplifiy the code by just changing the paint to
left alignment.
Change-Id: I532ae5224ea5de078c6cd6255f03fc1db06baa83
Reviewed-on: https://skia-review.googlesource.com/129360
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Herb Derby [Wed, 20 Sep 2017 15:56:00 +0000 (11:56 -0400)]
Remove sk_64_isS32 and sk_64_asS32
This is an API change. I assume that only Skia uses these routines.
Change-Id: Iefc98fa5c0b83eb4f52c478e345fd99121ecb254
Reviewed-on: https://skia-review.googlesource.com/129440
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Kevin Lubick [Mon, 21 May 2018 19:47:14 +0000 (15:47 -0400)]
Make ASAN setup of Android bots more fault tolerant
Bug: skia:7975
Change-Id: I3f123337913870a921d1c09714873eaf2949e88f
Reviewed-on: https://skia-review.googlesource.com/129364
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Ben Wagner [Tue, 17 Apr 2018 21:42:08 +0000 (17:42 -0400)]
IWYU for tests starting with 'D'.
Change-Id: I9189e4b56ce1635b627119733447c2ed4220753d
Reviewed-on: https://skia-review.googlesource.com/129319
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Mike Klein [Tue, 1 May 2018 14:36:42 +0000 (10:36 -0400)]
Reland "Retry enabling skcms on Android"
This is a reland of
05b5e40519ae18939867f8de5d48f7c7a173f745
Original change's description:
> Retry enabling skcms on Android
>
> Since we tried this last, DM has a direct skcms dependency
> via tests/ColorSpaceTest.cpp, so I've rearranged gn_to_bp.py slightly.
>
> We need to keep our eyes out for BitmapRGBAF16Test.testGetPixel in CTS.
>
> Change-Id: I3630bbebb4574522c43362c359d1a14da3bdd480
> Reviewed-on: https://skia-review.googlesource.com/124720
> Commit-Queue: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
Change-Id: I67041fb00687f789c80b7ba41acd3bf2cf257cf3
Reviewed-on: https://skia-review.googlesource.com/126825
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Brian Salomon [Mon, 21 May 2018 18:37:49 +0000 (14:37 -0400)]
Remove mask-filters and aa from SkPaint in SkCanvas for nine-patch/lattice.
Remove GPU fallback code which would have applied AA and mask filter
separately to each lattice cell.
Change-Id: I43d50f337d24bb34b94f3d0ea6cca686a2e11a50
Reviewed-on: https://skia-review.googlesource.com/129318
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Ben Wagner [Mon, 21 May 2018 18:47:03 +0000 (14:47 -0400)]
Omit failing test.
Bug: skia:7046
Change-Id: Iea1ec862adedeabe05d227c0bd8e635e42fab27d
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129362
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Adrienne Walker [Mon, 21 May 2018 18:05:48 +0000 (11:05 -0700)]
Fix unit tests when workarounds are enabled
Change-Id: Ia660a6d91aa3615e0fa21fba67f5029c131b1ba2
Reviewed-on: https://skia-review.googlesource.com/128983
Commit-Queue: Adrienne Walker <enne@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Greg Daniel [Thu, 3 May 2018 20:54:03 +0000 (16:54 -0400)]
Reland "Remove GrBackendObject and all related functions from Skia."
This is a reland of
ccd4cfc23ebbbecbc6b292359352aad335ad7b73
Original change's description:
> Remove GrBackendObject and all related functions from Skia.
>
> Bug: skia:
> Change-Id: I59434b7477c0bc26fd982bd81eb97ab94bbba073
> Reviewed-on: https://skia-review.googlesource.com/125822
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>
Bug: skia:
Change-Id: Ibd1b9bd04b36840d9d872e2f0970dd6bac378bc9
Reviewed-on: https://skia-review.googlesource.com/129380
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Brian Salomon [Mon, 21 May 2018 16:54:39 +0000 (12:54 -0400)]
Add perspective support to GrTextureOp.
Bug: skia:
Change-Id: Idea4ffae37dc2c2f339af60a2b74ded476091758
Reviewed-on: https://skia-review.googlesource.com/127600
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Greg Daniel [Mon, 21 May 2018 17:48:03 +0000 (13:48 -0400)]
Move gn setup for vulkan library/headers into their own third_party directory.
Bug: skia:
Change-Id: I4605f0d962271efb77bf3c17f1b0daaaddfb51c8
Reviewed-on: https://skia-review.googlesource.com/128540
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Cary Clark [Mon, 21 May 2018 15:56:57 +0000 (11:56 -0400)]
remove defines and add commas
Preparation for generating bookmaker files for all remaining
interfaces
Standardize enum and enum classes by including a comma after
the last entry.
Replace flatten-related #define in public interfaces
with their equivalent.
The motivation is to give documentation something to refer to.
An alternative would be to move part or all of this out of the
public interface; something I can work on in a follow-up CL.
R=reed@google.com,bsalomon@google.com
Bug: skia:6898
Change-Id: I4b865f6ec3d8f5d31e50448fef7d2714510302f0
Reviewed-on: https://skia-review.googlesource.com/129312
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
skia-recreate-skps [Mon, 21 May 2018 15:34:43 +0000 (15:34 +0000)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I86e4a692f30ef9f6455216c68602b88070d68e85
Reviewed-on: https://skia-review.googlesource.com/129331
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Herb Derby [Mon, 21 May 2018 14:47:13 +0000 (10:47 -0400)]
Add SkMakeUnique to gn
Change-Id: Ic1bee4551d471c4451837a93c14d49edc7c0f760
Reviewed-on: https://skia-review.googlesource.com/129314
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Jim Van Verth [Mon, 21 May 2018 14:36:55 +0000 (10:36 -0400)]
Disable perspective for emoji fallback
Bug: skia:7562
Change-Id: Icc7182c8ae2ec403b2ea2659539d4f9561eddd02
Reviewed-on: https://skia-review.googlesource.com/113200
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Florin Malita [Mon, 21 May 2018 13:14:35 +0000 (09:14 -0400)]
Roll third_party/rapidjson to
af223d44f4e8d3772cb1ac0ce8bc2a132b51717f
Includes https://github.com/Tencent/rapidjson/pull/1261.
Bug: oss-fuzz:8301
Change-Id: I119dc65fe1f0176b26164589939c9c9bd476b3bb
Reviewed-on: https://skia-review.googlesource.com/129310
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Greg Daniel [Thu, 3 May 2018 20:53:46 +0000 (16:53 -0400)]
Reland "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter."
This is a reland of
333031b921264508ca1869769c1021bc08e4e07a
Original change's description:
> Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter.
>
> Bug: skia:
> Change-Id: I2c8c116f825278cae4001d169aaef42ce9a21873
> Reviewed-on: https://skia-review.googlesource.com/125725
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
Bug: skia:
Change-Id: Ibb8f89f1d3559a8484976f6a07f9a01d28394c48
Reviewed-on: https://skia-review.googlesource.com/129341
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Cary Clark [Sun, 20 May 2018 23:15:43 +0000 (23:15 +0000)]
Revert "remove toString"
This reverts commit
5191880cbf3ee4d122b0d11b4945fbab0784fda7.
Reason for revert: broke flutter
Original change's description:
> remove toString
>
> toString may have been used by obsolete debugger only
> find out if that is so
>
> R=​brianosman@google.com,bsalomon@google.com
>
> Docs-Preview: https://skia.org/?cl=119894
> Bug:830651
> Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
> Reviewed-on: https://skia-review.googlesource.com/119894
> Commit-Queue: Cary Clark <caryclark@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org
Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 830651
Reviewed-on: https://skia-review.googlesource.com/129340
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
Cary Clark [Fri, 18 May 2018 14:02:02 +0000 (10:02 -0400)]
remove toString
toString may have been used by obsolete debugger only
find out if that is so
R=brianosman@google.com,bsalomon@google.com
Docs-Preview: https://skia.org/?cl=119894
Bug:830651
Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
Reviewed-on: https://skia-review.googlesource.com/119894
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Brian Osman [Fri, 18 May 2018 20:59:13 +0000 (16:59 -0400)]
Add drawBitmapLattice to SkDebugCanvas
One more step to full coverage of SkCanvas API. (Also, it would be nice
to implement fromJSON for both lattice types, I'll attempt that in a
follow up CL).
Change-Id: I5fe55ca90b7859e40f5e8ec83bc12b7938674b60
Reviewed-on: https://skia-review.googlesource.com/129245
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Ravi Mistry [Sun, 20 May 2018 14:46:04 +0000 (10:46 -0400)]
Omit "espn" from key_mobile_sites_smooth in RecreateSKPs bot
We already have a espn page set in Skia. Removing it from the chromium page
set does not lose us coverage.
NoTry: true
Bug: skia:7917
Change-Id: Ie5456ee7f8053ad904eb858eddfe564e3781249a
Reviewed-on: https://skia-review.googlesource.com/129303
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Roll third_party/externals/angle2/
78b7f3a8e..
42cf958ce (3 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
78b7f3a8e813..
42cf958ce8fa
$ git log
78b7f3a8e..
42cf958ce --date=short --no-merges --format='%ad %ae %s'
2018-05-17 jmadill Make UNIMPLEMENTED a warning.
2018-05-17 jmadill dEQP: Use overload of CreateWindow.
2018-05-17 jmadill dEQP: Format display factory and clean up style.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I50cea3083e11fc547615cbc92b32e60c277ad889
Reviewed-on: https://skia-review.googlesource.com/129236
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Roll third_party/externals/angle2/
a9ab0f37c..
78b7f3a8e (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
a9ab0f37cf8f..
78b7f3a8e813
$ git log
a9ab0f37c..
78b7f3a8e --date=short --no-merges --format='%ad %ae %s'
2018-05-18 lfy GLES1: New packed enums for materials and lighting
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I914e6378546fa11911cac14d67b695b6faa86b23
Reviewed-on: https://skia-review.googlesource.com/129234
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Roll third_party/externals/angle2/
8688bf46f..
a9ab0f37c (4 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
8688bf46f183..
a9ab0f37cf8f
$ git log
8688bf46f..
a9ab0f37c --date=short --no-merges --format='%ad %ae %s'
2018-05-17 lucferron Vulkan: Fix DynamicBuffer usages, need to use specific alignment
2018-05-10 geofflang Don't make redundant calls to Display::makeCurrent.
2018-05-18 jmadill Documentation maintenance.
2018-05-18 lucferron Revert "Vulkan: readPixels improvement - use DynamicBuffer"
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: Ia2199cfb46c19d850a3244b7064f4e1f27de5fe4
Reviewed-on: https://skia-review.googlesource.com/129232
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Mike Reed [Fri, 18 May 2018 20:29:11 +0000 (16:29 -0400)]
harden line2d effect
Suggested by https://fuzzer.skia.org/category/n32_canvas/file/c3JjL2NvcmUvU2tTdHJva2UuY3Bw?
Bug: skia:
Change-Id: I8ec48f844bfa5d063f0ab1bdfe0612ec4673ada3
Reviewed-on: https://skia-review.googlesource.com/129260
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Herb Derby [Fri, 18 May 2018 19:09:41 +0000 (15:09 -0400)]
Add rules for cmake 3.11 to not error
As of cmake 3.11, the add_library target must have sources
associated with it. If there are sources, just compile
the file empty.cpp.
Change-Id: I7fec03dc0f0d2e6098572ed6e9fcdfaac3811024
Reviewed-on: https://skia-review.googlesource.com/129189
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Mike Reed [Fri, 18 May 2018 18:07:57 +0000 (14:07 -0400)]
tweak conservative bounds value to save aberrant cubic
Bug: 844457
Change-Id: Ia3c7c0592df59022cf04f6747b1fe30975431ea4
Reviewed-on: https://skia-review.googlesource.com/129200
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Timothy Liang [Fri, 18 May 2018 18:38:19 +0000 (14:38 -0400)]
added global variable and multi-texture support to metal sksl backend
Bug: skia:
Change-Id: If676774ec0a30c5b536ccffbff2220d180b7fa59
Reviewed-on: https://skia-review.googlesource.com/129187
Commit-Queue: Timothy Liang <timliang@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
projects / platform / upstream / libSkiaSharp.git / log