Fixed unittest error of secure resource provider.

Change-Id: If0a7be512046ab14e7539a6ad2d03a3078d98550
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13787
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix for "UNUSED" redefined warning

The #define UNUSED is present in openjdk's jni.h and
in the arduino libraries. Resulting in the compilar
warning.

We already have OC_UNUSED defined in octypes.h which
was already avalible for all of the files that were
using UNUSED from logger.h.

The #define UNUSED was deleted from logger.h.
Any place UNUSED was used was renamed to OC_UNUSED.

Change-Id: If94ac13dc29eb3323e036eec750a18893895fb3d
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13353
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

tizen: install more headers needed for iotcon

Change-Id: I5ae3d61c97e1d4e0138e40d77add85edc132f4a3
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
(cherry picked from commit 9b4069da2add23ddc9dd0488465f994ac761e275)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13563

Add credential verification API and add logs for debugging

Change-Id: Ib23f99acd7e82fa1dc9fec42cc08c5179294a5eb
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13477
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1473] Modify the return value of MOT related API.

Change-Id: I9e2a6d79358538896c64e5870d96c0ca796a0b6e
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13687
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Add missing SVR DB for MOT sample client.

Change-Id: I299782b9d4f94d66b88348d69b26587c9f1344ce
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13485
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Remove not required OCStopMulticastServer() function call in RD

this is required but it is being moved to app layer, as it is
conflicting with the local and cloud scenarios. It would require
update to the local rd sample to call this function instead.
Also OCStopMulticastServer has to be made available to the
application developer, right now it is just a C API.

Change-Id: I7a51c29b7bc88416df81966f9d98898bc2b3ab08
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13645
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

fix process onPut message of roomclient app

Change-Id: I465fe65db563f9784ff0c3a2c41d861f5521a403
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13741
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fixed static analysis issues in RI.

Add null check and initial value

Change-Id: I25121862916dabd1771bbd578f3b506d01272e05
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13679
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Remove Routing check from OCDevAddr

Applications had a dependency to either define EP or GW
in build scripts.
Its required to be removed only in octypes.h as its
automatically taken care-of in other files by csdk build
scripts.

Change-Id: I4570aa63681779b463dc250cdb53ab90c4338a40
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13639
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1478] add stop scan logic for BLE, when stack is terminated

Change-Id: I2454bb3f24c0aa3f821a24d494d8ab7db2d52bf2
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13717
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fix to calculate the length of the remain data segment for BLE adapter.

Change-Id: I12c7b639c3429ac1bf97f29d77265bbffb5fd1e3
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13715
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

modified CAReceiveBlockWiseData() to skip unnecessary logic

Unless there is not error code on the received message,
it is not needed to create a CABlockDataID.

Change-Id: I8dfc581ca802f51d12a36c07644df24110eb7d06
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13605
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix IOT-1465

Ownership transfer manager expects the CA_DTLS_AUTHENTICATION_FAILURE
in case of handshake error

Change-Id: I984ec32de52a0547e449d6b0580fa8299d678d8e
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13641
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit af80659dbee1c692df602697d4bdac806a794cb4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13651

Updated with Valgrind memory leak fixes for Notification Provider and consumer.
Updated NS sample App to allow/deny consumer subscription.

Patch 2 : updated valgrind fixes and updated review comments
patch 3 : rebased the code.
patch 4 : resolved merge conflicts

Change-Id: Icdcc0b71fb865fbbb5dd472045e71cef2689d2c6
Signed-off-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

DoxyGen file update

Change-Id: I5eb473f98b4815a1189a219424888c814f5223ad
Signed-off-by: uzchoi <uzchoi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13373
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13733

Add store app workaround for Windows network monitor

Also fix some typos in run.bat

Change-Id: I0060b833a5c984bfb0555168927db845bee76c3e
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13635
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>

[IOT-1361][Tizen]Using getifaddrs for get ipaddr instead of ioctl

Using getifaddrs to support getting ipv6 address in CAGetNetworkInfo()
Remove ioctl code and using getifaddrs for get ipv6 address.

Change-Id: I31816d605424833ed9324a05ab3b1e1492aab5c7
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12249
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1477] fix presenceclient sample for linux.

There was some miss codes from
https://gerrit.iotivity.org/gerrit/#/c/13261

Change-Id: I04814c14084acbca13c40c983e2fe9addc29cc4d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13669
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1361][Android]Using netlink for get ipaddr instead of ioctl

Using netlink to support getting ipv6 address in CAGetNetworkInfo()
Remove ioctl code and using netlink.

Change-Id: I94dd5bebd2f8dde95cb589e4f64a44c2a1a428f1
https://jira.iotivity.org/browse/IOT-1361
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12879
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1468] fix unicast presence issue which get error response.

unicast presence subcribe should not send oic/ad message to presence server.

Change-Id: I3b1798b705b58646873de02e6d8a882fe84e1b64
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13673
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1361]Change "CAFindInterfaceChange()" to support IPv4/6

Change "CAFindInterfaceChange" return type to listen for multicast packets from
both of IPv4/IPv6 Address bind in one physical Network Interface.
As is: CAInterface_t *CAFindInterfaceChange();
To be: u_arraylist_t *CAFindInterfaceChange();

Change-Id: I8c30f46669ca5c22962c4f629c2e2e4649cb54b5
https://jira.iotivity.org/browse/IOT-1361
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12737
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

tizen: Don't build sqlite sources

As Tizen already ship sqlite package

Change-Id: Ic39c41f5ae07fab2c2ff820283c871489d3fd15c
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12895
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
(cherry picked from commit 3756f85ca83901e16cca09f1258f51afb28d1e99)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13045
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>

[IOT-1463] Fix for getting and setting host address from secured OCResource object.

OCResource object was returning "coap+tcp" even if it is secured resource.
OCResource::setHost() fails to create OCDevAddr for host containing "coaps+tcp".

Change-Id: I2273d08b40e94f66fe95e339e876c2c316986c71
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13489
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Junghyun Oh <junghyun.oh@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit ae38269f723939c2e3c8c8a722185067bdb783d1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13637

[IOT-1371] Use both addr and port to identify the endpoint of the
block transfer data.

Change-Id: I11a378aa611adb6b1cbfe5eacd4e45f34f1a649f
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12505
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add missing tests for Secure Resource Provider

Change-Id: Ib65bbbe69a09cb371fa22b536b0b1ea8a64cfac6
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13625
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2f553451724239cdbd32d0a128134bd3ed433066)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13675

[IOT-1413,IOT-1415] Fixed request handling bugs for /oic/ping resource

- /oic/ping resource is responding with 5.00(internal server error)
when it receives a GET/POST/PUT request with baseline query
- /oic/ping resource is successfully registering and deregistering
observe requests, even though it is shown as non observable resource
in discovery response.

Change-Id: I86db52f17b0b42750906fdfa8b377c78a85ef822
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13089
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 41e04322a0b5684ed05e3b7968f44fc172a664a6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13223
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>

Changed the property of /oic/ping resource

The resource property of /oic/ping is changed from DISCOVERABLE to
NONE.

Change-Id: Ibb1d8d80f859fdbb34a75a22b19bd66979fa6b13
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13439
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
(cherry picked from commit a23f545b5ed285d51e34f4faea939db847959e92)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13601

[IOT-1451] Keep client callback when receiving error result

when Client receive error code from some server after request
oic/res. clientCB is removed by return value "OC_STACK_DELETE_
TRANSACTION"

Change-Id: Ibf42740078f0ed6a97ee3b18d22559b0d2fbdf43
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13237
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: MyeongGi Jeong <myeong.jeong@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 2cfef2e49066614eaed9aed40806d9cebc0b5cb5)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13599

Fix for bug while building x86_64 architecture

Change-Id: I9c2538617a897c2b1c4e9129f55bf9623053308b
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13653
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix to get only single credential entry

Old function(GetCredResourceDataByCredId) return not only the indicated credential entry but also all linked entries.

Change-Id: I0466b4c25a21395f08664a11ecfa6fd51a94b258
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13547
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

coap: use upstream libcoap header if desired

Change-Id: I94540c72d320ebf87b996d5ddd614c898b8c157f
Origin: https://gerrit.iotivity.org/gerrit/#/c/13615/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13615
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: David Antler <david.a.antler@intel.com>

Added null check logic for JniOnPublishResourceListener

Added null check logic for JniOnPublishResourceListener

Change-Id: I8967028583b951d2af049a46eb618ba0963db72f
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13399
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 86c3e7a2500b689a074d2099017cb96a5ea1f0e9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13603
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

fix jenkins build failure related setErrorCode

this issue causes by https://gerrit.iotivity.org/gerrit/#/c/13151/

Change-Id: I7eb1a208f65bd6a1f6a207de85363fd540bd2705
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13647
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1237] Client discovers all resources sending discovery request with "rt" query param.

Change-Id: I54904ef0789c5ee4655c20e4c8c82eb9b7d0ac0a
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11031
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

coap-http-proxy: Fix coap headers path

It failed to build on Tizen:2.3.1:Wearable

Change-Id: I1069ab17f11a946605093454b89205a6c208c902
Origin: https://gerrit.iotivity.org/gerrit/#/c/12061/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12061
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12487

Bug fixes.

1)Fixing logic related to conversion of MediaContents to consider NULL object.
2) Fixing bug in switch statement .

Change-Id: I615aca6e55d2bf39b7686331ec59d50f72deb5c4
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13629
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix enrollee sample application's crach issue

Before OCStop() is called, listen thread for calling OCProcess() should
be terminated.

Change-Id: Ibe4f702bb7c71beaf8bb58a8fe21acb873ad06d6
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13583
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
(cherry picked from commit 9331e5eddab194f9f17bf09c3b0c70da5c87ab77)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13593
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove unnecessary setter/getter related errorcode for response

There are invalid APIs setErrorCode/getErrorCode in C++ layer.
It can be caused a big confusion to user.
Since the value never transfer on network. it just set in class inside.
Thur, It is better to remove the methods.

Change-Id: Iab863b1c16095ec77b9733bd3ff0ea38167b2dba
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13151
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add macro about registered topic data.

This patch include,
It added a macro to delete the data that was registered topic.

Change-Id: Ie83b23b7276bb5aaf07388c0faba34b47bce7f16
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13473
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Changes to SSL adapter unit tests
caTrustedCrl discarded due to needlessness

Change-Id: I7b7e9bb0d85474a6f0ecf8f23019b072715c08bd
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13553
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 4c6b0de1730df1addff1a85410f3de7a83ac0271)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13575

Fixed sign-compare warning

In the ParseChain function the bufLen and pos varaible were
changed from int to size_t.  Every location that ParseChain
is called is passing in a size_t as the bufLen an unsigned
type. The pos variable is never negative and should be the
same type as the bufLen.

While in the function the documentation was cleaned up and
comemnts were added to quickly identify the contents of the
pemCertHeader and pemCerFooter byte arrays. As well as clarify
the need of the goto `exit:` label when using the
CHECK_MBEDTLS_RET macro.

Change-Id: I1f063dddea29a2a00ae6e47c7b2240794bcaf5bb
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

linux: Support also armeabi-v7a TARGET_ARCH

This EABI is used in Tizen, this way iotivity
 can be rebuild on Tizen using "linux" profile (TARGET_OS).

For instance unsupported older tizen profiles can be rebuilt using gbs
 (ie Tizen:2.3:Wearable).

Change-Id: Ia84cb173add8efbb10cb2a9632a7637cf6202114
Origin: https://gerrit.iotivity.org/gerrit/#/c/12417/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12417
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13613

Fixed static analysis issues in RI.

Change-Id: Id6a1b8edb41b3863ba722db43285d28e264dfda8
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13133
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1458] fix to handle unexpected disconnected state for BLE

Change-Id: I83ba76e61eb57fce91c42d32c434a3b2735d2aa3
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13371
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

tizen: Scons sqlite puller should not be used

Tizen wants to link with system's sqlite package

Change-Id: I685af2816d21c592e7ef67be3451bb42c4ff338d
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13043
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add a maximum observer TTL of 24 hours

A server that transmits notifications mostly in non-confirmable
messages MUST send a notification in a confirmable message instead of
a non-confirmable message at least every 24 hours. This prevents a
client that went away or is no longer interested from remaining in the
list of observers indefinitely.

Change-Id: Ie676f9f5f394fa094b4f2d9fd3a72e2d38d21b24
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11497
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix aircon_controller crash issue

1. Fix crash issue

Change-Id: I6033e3272ce8f085730e1b579e026ef079bd7097
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1459]Add CA API which returns selected transport adapter

Add CA API which returns selected transport adapter.
Returns bit combinations of CATransportAdapter_t enumeration
which indicate enabled adapter.
CATransportAdapter_t CAGetSelectedNetwork();

Change-Id: If9116991585ab20b56303875d2d83a79316d2387
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13391
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1445] Add ins value when publishing a resource to rd

The ins value has to be included when publishing a resource
to resource-directory. Otherwise resource-directory will
return error code.
Currently, The ins is not included because the return value
of OCGetResourceIns() was not checked properly.

Change-Id: I11b1f405e000f36bb76ca7d24c8dbbbd6e7586fe
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13159
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit b5d331d2d779172bceebb9b92cc73eecc6d6cdae)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13225

Start building json2cbor for Windows.

Change-Id: I9a1e43969c597eed68eac0df28b90571c67de931
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13521
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

License added to cloud codes

License information added to clous codes

Change-Id: Ic16fbb9f76a858e6c98a01389dfdd55e50b4de1e
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13551
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit f188154d6af64981563f2dc4499ea9759613468b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13557

Bug fix about semicolon of if statement.

this patch include,
bug fix about invalid statement.

Change-Id: Ifd9762161058ab1381be2341bf92f0a5184371d9
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

tizen: Apply mbedtls ocf.patch only once

It has been tested with:
  scons -f resource/csdk/stack/samples/tizen/build/SConscript \
    TARGET_OS=tizen LOGGING=TRUE RELEASE=0 \
    SECURED=1 WITH_TCP=1 TARGET_TRANSPORT=IP,BT

Related to:
  https://gerrit.iotivity.org/gerrit/#/c/12029

Change-Id: I1b140503a1e4b3c52cc95d41c27c00bdd4a47ccf
Credit-to: Randeep Singh <randeep.s@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/12965/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12965
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
(cherry picked from commit 54966d90b2cf9f8c844bbaa1b1aa4f876fc91a7e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13517

tizen: Use sqlite from system not scon puller

Change-Id: Id4382d37d34e5ac7d023e38bebd60228c6e6860e
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12913
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit d1ee9e78d898746b842a2439f88d26fd30a377bc)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13041

Modified connectivityType on calling getDeviceInfo API at CPP Sample

Modified connectivityType on calling getDeviceInfo API at CPP Sample
Invalid connectivityType is used after merging below patch.
https://gerrit.iotivity.org/gerrit/#/c/13143

Change-Id: Ia881159af02f1eae984d4cda770e23cf6205741a
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13261
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 0ba523056a0174479befe2a147d420be63f62d35)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13541
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Ship renamed libuuid into RPM for SDK

This way produced RPM can be installed on target or imported in SDK.

libuuid.so.1 is pulled by pkgconfig from com-oic-ri.spec
 then it will be installed correctly if using "rpm -i *.rpm",

Overiding system libs in packaging, is not encouraged:
Observed issue on Tizen:2.4:Mobile (TM1) :

  sdb shell su -c "rpm -i /opt/usr/media/Others/GBS-ROOT-RI-OIC/*.rpm"
  file /usr/lib/libuuid.so.1 from install of com-oic-ri-1.2.0-0.armv7l \
  conflicts with file from package libuuid-2.20.2-4.139.slp.armv7l

But if we want to unpack RPM contents to be used along Tizen-sdk,
 as app, then uuid is also needed
 (because SDK is missing it from its sysroot).
 So application need to be linked with -luuid1 (same just renamed),
 to avoid collision.

For more details about building IoTivity for Tizen along SDK,
 please check:

https://wiki.iotivity.org/tizen

Change-Id: Iabed0221618d0d602f440e3527e1824177395ee1
Bug: https://jira.iotivity.org/browse/IOT-1343
Origin: https://gerrit.iotivity.org/gerrit/#/c/12471
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12471
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 8a3ea331f4c08296a2e11185a780de7f17d42956)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12719

tizen: Disable Bluetooth transport for Tizen:2.3

Tizen:2.3:Wearable (Samsung GearS) builds at least.
Because it's not building using outdated capi BT packages.

Change-Id: Id1b37df55bbdebd7ada1413935f5306ccd1e0002
Bug: https://jira.iotivity.org/browse/IOT-1320
Origin: https://gerrit.iotivity.org/gerrit/#/c/12475/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 8fe95f36541c5191439af915396055c667404269)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13511

tizen: Disable Bluetooth for Tizen:IVI (capi outdated)

Make sure capi-network-bluetooth-devel
 is shipping bluetooth_internal.h.

For instance, 0.1.39 does not have it, while 0.1.52 have it.

In that case it will fail to build and report a message like:

   resource/csdk/connectivity/src/bt_edr_adapter/tizen/\
   caedrclient.c:30:32: \
   fatal error: bluetooth_internal.h: No such file or directory

This need to be checked for other Tizen profiles:
 Tizen:2.3.1:Wearable, Tizen:2.4:Mobile have it.

Bug: https://jira.iotivity.org/browse/IOT-1343
Change-Id: I028f3c4fd8c9526b5d06a55b0f2a5f5c6c113d3d
Origin: https://gerrit.iotivity.org/gerrit/#/c/12355/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12355
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 61382c1df95115ef595b06e023d59bcca8bad22c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13509

Merge 1.2-rel cloud project into master

1. Overwrite 1.2-rel cloud project into master

Change-Id: I9271607595166fce4bda9011f028a40514908fec
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Yeonghun Nam <yeonghun.nam@samsung.com>

tizen: Enable Bluetooth along IP

Revert "Change build option - IP only"

This reverts commit 28d898d2dab5a4463ba5f7ea380258a4f4362578.

Change-Id: Ia3223a2ab09ba219bf8048aa28014744e19ed4b0
Author: Yungjae Shin <yj99.shin@samsung.com>
Origin: https://review.tizen.org/gerrit/#/c/63051/
Bug: https://jira.iotivity.org/browse/IOT-1343
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12353
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit cf0b4cbec478e84f4f6a4cc4fa118a96f6cdffb2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13507

tizen: Simplify missing license macro for Tizen:2.3

Change-Id: I6c2ceec4f37589db6c110a0f04df501c689a3fde
Origin: https://gerrit.iotivity.org/gerrit/#/c/12897/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12897
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 0d1a98d360977b8d967129282ff8644f363c5e79)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13513

tizen: Can support linux as fallback TARGET_OS

It can be helpful for platform developers
 to bypass tizen APIs on Tizen devices.

Might be useful for other RPM based distro,
 like Fedora for ARTIK, or (obsolete) Tizen profiles
 (with outdated Tizen packages).

Reformat options list to make nicer patches
 when configuration is changed (single word == single line).

Bug: https://jira.iotivity.org/browse/IOT-1320
Change-Id: Id1b37df55bbdebd7ada1413935f5306ccd1e0001
Origin: https://gerrit.iotivity.org/gerrit/#/c/12473/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12473
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 9ce88ac4271b9fa8fb400e4db4b8b43b5af5d6a8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13505

tizen: avoid en_speedpython for Tizen:2.4

May be squashed into:
https://review.tizen.org/gerrit/#/c/82272/3/packaging/iotivity.spec

Change-Id: I2d0e8b5e8b9404760ce58ee634348ef6bc3ade1d
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12053
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 4405f658bf7d1004f6a97b7ff211ae88267eee85)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12489

Update run.bat to allow argument overrides

Add arguments to the run.bat cmdline to enable building
for both x86 and amd64 architecture, turning off tests,
enabling logging and building release binaries.

Change-Id: Ic381d258bf8465399d94319a93499365db7f8f24
Signed-off-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13355
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

tizen: Introduce speedpython macro to speedup build

revise build time

Change-Id: I674157a6b446c8fad54cb7c8a2a937007f04db8a
Author: Youngjae Shin <yj99.shin@samsung.com>
Origin: https://review.tizen.org/gerrit/#/c/82272/3
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12051
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit ae5114229c8dd6759795a7f545c4699909bdd5b7)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12221

tizen: Disable TCP by default

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Icd0973c3bc0140d2320b2018de85ba589eae51fc
Origin: https://gerrit.iotivity.org/gerrit/#/c/12099/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 32510b62640f4aa5b7b6d82508ae9ee5d88ee9e6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12491

tizen: Disable WITH_CLOUD by default

Even if the code is building, I have disabled it by default,
 to align default values set in ./build_common/SConscript

If needed it can be enabled, but make sure a value is set to it.

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Id075b0479185aea2e13396df51ffecd56a9e183f
Origin: https://gerrit.iotivity.org/gerrit/#/c/11305/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11737
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 7252457fc2f63a43e89c64ac8c3dff8c19dc7d1a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11305

tizen: Use installed sqlite3

Change-Id: I2cc6cb804bd9c28473cf1dfc2b4c85c4da6cb982
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12911
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8173

fixed typo in resource/docs/c-doc/Doxfile

Change-Id: I553ad3f3278a0183a3fcc3a1b13ff0bf17ea3791
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13469
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: byonggon chun <bg.chun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

remove warning issue fragmentation and rdclient

this warning was came from analysis tool
- remove unreachable code.
- apply to check return value in rdclient example.

Change-Id: I2466e15e56f11344ffbc2712527d12c7ae326a0a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11673
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1434] fix subscribe presence for multicast.

it causes a big memory issue to add in serverRequestList.
because this request never remove

and subscribe presence for multicast should be not sent
on network.
since it is just for register clientCB in stack.

Change-Id: I14c9701009350ad52dfdf4e72db64522fc591705
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 45b9f4b4dade573f698f307c421c107d6190653f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13383

[IOT-1436] fix scons build issue related sqlite3 with unsecured mode

sqlite3 is triggering to download by default.
it causes a storage memory waste in user side.
scons build script should check any option for download that lib

Change-Id: I701752bb450dc79d3604304fc7130375586e5356
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13071
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 651887dd94864cf0f8eda52f5a8d7ec93dc27d0e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13381

[IOT-1391] fix BLE scan logic which create thread.

scan thread was made by unicast/multicast request in BLE client.
it causes a big problem which memory overflow issue related Thread.
so, scan thread will be working as one thread.

Change-Id: I87564f88b67d88781366523ae014c29fe1b13e2e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12781
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

replace singly linked-list Data structure with red-black tree for serverRequest

Since every data structure used in stack is singly linked-list,
it would be quite inefficient for some data which can be stored massively
like received request info on server.
So I replaced it with red-black tree.
(tree.h from openBSD : http://openbsd.su/src/sys/sys/tree.h)

Change-Id: I68a9b7d00f7f1f9f6aecacee04e0627b72a4ff6b
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Prevent empty credential to be added

Prevent empty credential to be added
(e.g. only rowneruuid is sent)

Patch #1: initial upload
Patch #2-3: fix arduino build error

Change-Id: I7802dcb76daab3269eb0a9638659087643b0c141
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13379
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 9366b7f721f6fe0c526832baf26b102984c7dcee)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13445

SVACE issue fixes

Change-Id: I4cd1fb23818a560449ae1ff3f2635c14ef093da7
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13435
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2ee97889f591fccaec860fb7ae7d0d95148c9311)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13447

Update the return value of MOT releated API.

Change-Id: I97a6ee6f0b9eecafd2a28e717887a04decd9209d
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13449
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 1ae2de1ec129cd8ad6de9cabae7cccff755ff170)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13461

Update build script for RE android sample app.

When building of RE android sample app,
we need to execute of scons build and also need additional android studio build.
With this patch, can build android sample app by only scons build.

Change-Id: Ife7142cf89993531bc15bf4b9f655090f50a1bad
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13369
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

fix issues relates to wrong syncInfo received

Change-Id: I77f9ce5d0fa3e7c40e0fe390b42f210e5a188a50
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13451
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Multiple Ownership Transfer support.

[NOTE] This patch includes the following patches for MOT :
   https://gerrit.iotivity.org/gerrit/#/c/12063/
   https://gerrit.iotivity.org/gerrit/#/c/13375/
   https://gerrit.iotivity.org/gerrit/#/c/13341/
   https://gerrit.iotivity.org/gerrit/#/c/13343/

[Overview]
This patch is to support the multiple ownership transfer(MOT).
We assume the MOT authenticated client is the SubOwner.
SubOwner can access the ALL resources with full permsion except the DOXM, ACL and CRED.

This patch includes following changes :
1. Update the doxm resource to include MOT related properties.
   - New Properties
     . x.org.iotivity.mom : Mode of MOT
     . x.org.iotivity.subowneruuid : List of SubOwner
   - SubOwner has READ permission for DOXM.
   - The resource server will be update subowner list of doxm
     when MOT authentication successfully done.

2. Update the cred, acl resource to include MOT related property.
   - New Properties
     . x.org.iotivity.eowneruuid : entry owner uuid for each entry.
   - SubOwner should set the eowner as subowner's UUID
     when provision the ACL and CRED.
   - SubOwner can access only those resources that registered as eowner.

3. Update the PolicyEngine for SubOwner's access control as following :
   - DOXM : READ ONLY
   - CRED/ACL : SubOwner can access only those resources that registerd as eowner.
     . SubOwner can not provision ACL which is include the DOXM, CRED, ACL, PSTAT.
   - PSTAT : FULL permission
   - Application Resources : FULL permission

4. Add Preconfigured-PIN OxM

5. Update the sample codes
   - Test Preconfigured PIN based MOT
     1. Run the sampleserver_justworks
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Perform the MOT enabled device discovery [Menu:13]
        - Check the discovered device list.
     8. POST the preconfigured-PIN credential [Menu:71]
         - sample's preconfigured-PIN is '12341234'
     9. Change the server's 'oxmsel' [Menu:72]
         - '3' is preconfigured-PIN OxM
     10. Run the subownerclient
     [On the subownerclient]
     11. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     12. Perform the MOT [Menu:20]
     13. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     14. Perform the ACL provisioning TEST [Menu:40]

   - Test Random PIN based MOT
     1. Run the sampleserver_randompin
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Run the subownerclient
     [On the subownerclient]
     8. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     9. Perform the MOT [Menu:20]
         In case of random PIN based MOT, PIN input required.
     [On the sampleserver_randompin]
     10. Press 'G' or 'g' on the sampleserver_randompin.
         server will generate and display the random PIN.
     11. Input the server's PIN number on the subownerclient side.
     12. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     13. Perform the ACL provisioning TEST [Menu:40]
     14. Press 'E' or 'e' on the sampleserver_randompin to exit server.

Change-Id: I25d029839b3567455743031afafb34d2fc78278c
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13419
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix bug for invalid return variable.

Invalid return variable is fixed.
1. invalid boolean -> pointer
2. invalid pointer -> boolean

Change-Id: I16cb2338b28ba5bb725ed6eb8d640f04216f7933
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13317
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update discovery when connection was changed.

When connection state was changed try to unicast discovery.

Change-Id: I7fe8f16039e9ead5002282742d6e51d805fc9225
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13319
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated NS Sample App for testing Sync and sending complete NSMessage

Change-Id: I8bf14b020b1e5ec42dcf5710fe30a1b6beefbe4b
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for Memory leak results from static analyzer for NS C++ Wrapper.

Change-Id: I97ca331ce6fcd7352350fd36426366433a5521a2
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Build issue for soname for NS Libraries

Change-Id: I07416d904e5ac63bbb389081e99f6849acfff842
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13413
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

setting received  ttl value  by consumer.

Change-Id: I1de504edf851d39d761dfa2a189a77116fca8a85
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13387
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

fix issue related to wrong messageId

Change-Id: I6008dfe8fc3dc648841f0527e993bd698275f7e4
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13385
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Unit tests for SSL adapter update

Change-Id: Ib108dd1ce76632f1393383e6402e73c7ba2e60d7
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2fe020f4bc86b7dcecc4a8853b7f772b591a010c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13363

build: ignore debian generated files

Change-Id: I963a02a548344f5c6e9955a4286de595801e9f93
Origin: https://gerrit.iotivity.org/gerrit/#/c/11811/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12967
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit ee74ca52a64302ba39c2d5cce7762fbd4c35427d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11811

tizen: Use upstream packaging file as aligned

Note, for dependencies libraries.
It's easier to maintain them as patches over upstream git.

More details on downstream maintenance at:
https://wiki.iotivity.org/tizen

Change-Id: Id630e6a06bff11c750a106e8fc0cffb9a154f87b
Bug: https://review.tizen.org/gerrit/#/c/82260/
Origin: https://github.com/tizenteam/iotivity/tree/sandbox/pcoval/on/master/tizen
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11683
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11407

fix android build failure issue with WITH_CLOUD=1 and secure mode

Change-Id: I1f1cca166866fda08e2d644032eca7e721bf8db8
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12861
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit ec9364d7abdbd06a406d2028cdfa27b315aefffe)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13061

added error code (4.03 / 5.00) in ocstack result

Change-Id: I311c0b76a2faa7704be8f4a8b89088a0ae471c6a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13135
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: byonggon chun <bg.chun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1388] fixed duplicate start server in EDR adapter.

when both mode(server and client) in App is set.
startDiscoveryServer and startListenningServer is calling.
and then both accept thread
and receive thread is running redundantly

Change-Id: I70395ace6115d52d28d2c034ea24c70aafeb671e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12799
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13065

modify about rule of coding.

this patch include,
1. modify if statement and while statement about rule of coding.
2. remove unused function.

Change-Id: I73117fcc15581dfaff435cd5922f14c91356c358
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13357
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Bug fix about result of static anlayzer.

this patch include,
bug fix about memory leak and coding idiom.

Change-Id: I6fba4a8b182ce88cda44571ebb490c7573812c01
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13267
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix crash in Android provisioning client App.

Catch exception in provision Android client for setDeviceId API.

Change-Id: I19918e47eac9f040d490e3805964c6cc7d5d3fba
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13345
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit add0610e0eafe8c51d669151fa77aeca5ee59bd6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13347

Update a logic to check an availability of cloud server resource

Rather than URI, resource type of the cloud server resource is more
confirmable to check the availability.

Change-Id: I61f3b63412b39fc56e993a3041ac007d0886368b
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add null checking for observe request in easy setup

Checking if entityHandlerRequest is NULL is added.

Change-Id: I79bf75c9f53f28b9c0c679a5dd7371552764b5cd
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13323
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix for all discovered devices to include a secure port

This patch prevent to add the device that does not have a secure port to discovered device list

Change-Id: Ia7283b37b7820e045f4a51ad03395205b4240dd3
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13299
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 44d8220a5c20a0077cfc4c65fbd9919b37129278)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13303