Jan Janssen [Wed, 8 Apr 2015 14:49:25 +0000 (16:49 +0200)]
systemctl: Use logind for --firmware-setup if possible
Zbigniew Jędrzejewski-Szmek [Wed, 8 Apr 2015 12:50:35 +0000 (08:50 -0400)]
Indentation
Zbigniew Jędrzejewski-Szmek [Fri, 3 Apr 2015 12:28:21 +0000 (08:28 -0400)]
man: remove 'fs' from 'rootfsflags'
rootfsflags does not appear anywhere else.
Zbigniew Jędrzejewski-Szmek [Fri, 3 Apr 2015 02:58:39 +0000 (22:58 -0400)]
core/automount: beef up error message
This should not happen... but when it does more information is nice.
Zbigniew Jędrzejewski-Szmek [Fri, 3 Apr 2015 02:54:35 +0000 (22:54 -0400)]
shell-completion: systemctl switch-root verb
The completion is rudimentary (all files). I think this is OK since
this is used so rarely. But not having it proposed at all is annoying.
Lennart Poettering [Wed, 8 Apr 2015 15:24:23 +0000 (17:24 +0200)]
update TODO
Lennart Poettering [Wed, 8 Apr 2015 15:23:27 +0000 (17:23 +0200)]
resolved: maintain order when writing resolv.conf entries
http://lists.freedesktop.org/archives/systemd-devel/2015-March/029850.html
Lennart Poettering [Wed, 8 Apr 2015 15:22:15 +0000 (17:22 +0200)]
util: add minimal OrderedSet type
OrderedSet implements a Set-like structure, but maintains insertion
ordered. It is hence to Set what OrderedHashmap is for Hashmap.
Internally, this is only a wrapper around OrderedHashmap for now, but
this could one day be improved and be added to hashmap.c natively.
Lennart Poettering [Wed, 8 Apr 2015 11:02:45 +0000 (13:02 +0200)]
TODO: yeah, now it makes sense
Alexander Sverdlin [Wed, 8 Apr 2015 10:59:40 +0000 (12:59 +0200)]
missing.h: Define IFA_F_NOPREFIXROUTE
Fixes second systemd compilation problem against Linux 3.12 uapi
headers.
IFA_F_NOPREFIXROUTE is a usual #define appeared in Linux 3.14, so
AC_CHECK_DECLS is not necessary.
Lennart Poettering [Wed, 8 Apr 2015 10:53:50 +0000 (12:53 +0200)]
sd-rtnl: properly size attribute array if IFA_FLAGS was missing
Sylvain Plantefève [Tue, 7 Apr 2015 22:40:33 +0000 (00:40 +0200)]
po: update French translation
Add strings introduced by
5bdf22430e367799dfa66c724144b624c5479518
Ronny Chevalier [Tue, 7 Apr 2015 23:15:32 +0000 (01:15 +0200)]
remove duplicated includes
Ronny Chevalier [Tue, 7 Apr 2015 23:09:11 +0000 (01:09 +0200)]
timedatectl: trim --help output to 80 chars
Ronny Chevalier [Tue, 7 Apr 2015 18:14:28 +0000 (20:14 +0200)]
zsh-completion: update hostnamectl
Ronny Chevalier [Tue, 7 Apr 2015 17:35:57 +0000 (19:35 +0200)]
zsh-completion: add missing -M completion for journalctl
Ronny Chevalier [Tue, 7 Apr 2015 17:35:13 +0000 (19:35 +0200)]
zsh-completion: update loginctl
Ronny Chevalier [Mon, 16 Mar 2015 19:24:39 +0000 (20:24 +0100)]
test-socket-util: add test for in_addr_to_string
Thomas Hindoe Paaboel Andersen [Sat, 21 Mar 2015 20:08:00 +0000 (21:08 +0100)]
configure: sign-compare is part of extra
Remove sign-compare as we already get it from extra
Thomas Hindoe Paaboel Andersen [Tue, 7 Apr 2015 17:34:40 +0000 (19:34 +0200)]
device: remove unused null check
We dereference the variable right before the null check. We never reach
this point with a null value anyway so let's just remove it.
Lennart Poettering [Tue, 7 Apr 2015 19:08:07 +0000 (21:08 +0200)]
logind: drop "interactive" parameter from SetRebootToFirmwareSetup() bus call
Newer dbus versions have an "allow interactive authentication" bit in
the message header, hence it is not necessary to take a boolean for this
explicitly.
Lennart Poettering [Tue, 7 Apr 2015 19:07:54 +0000 (21:07 +0200)]
update TODO
Lennart Poettering [Tue, 7 Apr 2015 19:07:19 +0000 (21:07 +0200)]
missing.h: define IFA_FLAGS if it is missing
Thomas Hindoe Paaboel Andersen [Tue, 7 Apr 2015 18:28:27 +0000 (20:28 +0200)]
test-util: don't mix declarations and code
Lennart Poettering [Tue, 7 Apr 2015 16:47:47 +0000 (18:47 +0200)]
update TODO
Lennart Poettering [Tue, 7 Apr 2015 16:47:35 +0000 (18:47 +0200)]
socket: minor modernizations
Jan Janssen [Fri, 3 Apr 2015 16:03:06 +0000 (18:03 +0200)]
logind,systemctl: add reboot to EFI firmware support
Lennart Poettering [Tue, 7 Apr 2015 15:25:26 +0000 (17:25 +0200)]
update TODO
Richard Maw [Tue, 7 Apr 2015 14:53:05 +0000 (15:53 +0100)]
man: fix typos in machinectl
The s/now/not/ unfortunately inverted the meaning.
Richard Maw [Tue, 7 Apr 2015 14:53:04 +0000 (15:53 +0100)]
man: Resolve how to refer to derived names for machinectl containers
"the name it is" is clumsy english, and since the most recently referred
to thing was a name anyway we can just leave the "it is".
This matches later uses in the same document.
Lennart Poettering [Tue, 7 Apr 2015 14:45:09 +0000 (16:45 +0200)]
update TODO
Lennart Poettering [Tue, 7 Apr 2015 14:43:37 +0000 (16:43 +0200)]
timedatectl: avoid specifically referring to NTP
systemd-timesyncd not only does NTP, but also manages clock monotonicity
using a flags file. In future, it might learn PTP support. Hence don't
expose its enablement state as "NTP" but use the more generic term
"network time synchronization". After all, for similar reasons
systemd-timesyncd is not called systemd-ntpd.
Lennart Poettering [Tue, 7 Apr 2015 14:29:21 +0000 (16:29 +0200)]
man: update timedatectl(1)'s examples
The output didn't match what we output these days. Also, "set-ntp"
cannot be used to control chronyd anymore.
Lennart Poettering [Tue, 7 Apr 2015 14:23:16 +0000 (16:23 +0200)]
man: document in timedatectl(1) that the NTP state shown reflects whether timesyncd is enabled
Lennart Poettering [Tue, 7 Apr 2015 14:03:45 +0000 (16:03 +0200)]
path-util: fix more path_is_mount
e792e890f fallout
Lennart Poettering [Mon, 6 Apr 2015 18:28:37 +0000 (20:28 +0200)]
update TODO
Lennart Poettering [Mon, 6 Apr 2015 18:34:11 +0000 (20:34 +0200)]
man: document default timeouts and start limit parameters
Lennart Poettering [Mon, 6 Apr 2015 18:25:56 +0000 (20:25 +0200)]
polkit: rename bus_verify_polkit() to bus_test_polkit() and make it strictly non-interactive
Interactive authorization should only happen asynchronously, hence
disallow it in synchronous bus_verify_polkit(), and rename it to
bus_test_polkit(). This way even if the bus message header asks for
interactive authorization, we'll ask for non-interactive authorization
which is actually the desired behaviour if CanSuspend, CanHibernate and
friends, which call this function.
Lennart Poettering [Mon, 6 Apr 2015 18:11:41 +0000 (20:11 +0200)]
util: rework cunescape(), improve error handling
Change cunescape() to return a normal error code, so that we can
distuingish OOM errors from parse errors.
This also adds a flags parameter to control whether "relaxed" or normal
parsing shall be done. If set no parse failures are generated, and the
only reason why cunescape() can fail is OOM.
David Herrmann [Tue, 7 Apr 2015 12:03:44 +0000 (14:03 +0200)]
core: fix mount setup to work with non-existing mount points
We must not fail on ENOENT. We properly create the mount-point in
mount-setup, so there's really no reason to skip the mount. Make sure we
just skip the mount on unexpected failures or if it's already mounted.
David Herrmann [Tue, 7 Apr 2015 11:11:18 +0000 (13:11 +0200)]
device: fix sysattr newline cutter
Right now, we always drop the last character of all values we write to
sysfs. Fix this!
Hans de Goede [Fri, 3 Apr 2015 10:07:32 +0000 (12:07 +0200)]
udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER
input_id already (tries to) tag accelerometers as such, but this only works
for absolute accelerometers. Recent kernels mark accelerometers through an
input prop. Trust that prop and always tag devices with it with
ID_INPUT_ACCELEROMETER.
Note that detection by the prop bit works the same as the existing detection
and will ensure that no other tags get set on the device.
Peter Hutterer [Thu, 26 Mar 2015 04:08:35 +0000 (14:08 +1000)]
udev: input_id: tag pointing sticks as ID_INPUT_POINTINGSTICK
Also referred to as trackpoint, trackstick. These are marked by recent kernels
through an input prop. Forward that prop as udev property so userspace can
easily determine whether there is a pointing stick present.
These devices were previously marked as ID_INPUT_MOUSE, for backwards
compatibility we keep that in place, the new property is an addition.
Daniel Mack [Mon, 6 Apr 2015 22:44:15 +0000 (00:44 +0200)]
core: mount-setup: handle non-existing mountpoints gracefully
Commit
e792e890f ("path-util: don't eat up ENOENT in
path_is_mount_point()") changed path_is_mount_point() so it doesn't hide
-ENOENT from its caller. This causes all boots to fail early in case
any of the mount points does not exist (for instance, when kdbus isn't
loaded, /sys/fs/kdbus is missing).
Fix this by returning 0 from mount_one() if path_is_mount_point()
returned -ENOENT.
Zbigniew Jędrzejewski-Szmek [Mon, 6 Apr 2015 19:44:30 +0000 (15:44 -0400)]
build-sys: fix typo
Lennart Poettering [Mon, 6 Apr 2015 13:27:18 +0000 (15:27 +0200)]
update TODO
Lennart Poettering [Mon, 6 Apr 2015 13:26:59 +0000 (15:26 +0200)]
btrfs: add support for recursive btrfs snapshotting
Lennart Poettering [Mon, 6 Apr 2015 12:55:45 +0000 (14:55 +0200)]
btrfs: missing endian conversion fix
Lennart Poettering [Mon, 6 Apr 2015 09:47:25 +0000 (11:47 +0200)]
btrfs: make btrfs_subvol_snapshot() parameters a flags field
Lennart Poettering [Mon, 6 Apr 2015 08:57:17 +0000 (10:57 +0200)]
btrfs: support recursively removing btrfs snapshots
Lennart Poettering [Sun, 5 Apr 2015 09:28:04 +0000 (11:28 +0200)]
machined: drop btrfs subvolumes when removing container images
Lennart Poettering [Sun, 5 Apr 2015 09:26:58 +0000 (11:26 +0200)]
path-util: don't eat up ENOENT in path_is_mount_point()
There's no reason to eat up ENOENT, it should be OK to simply report the
error back.
Lennart Poettering [Sun, 5 Apr 2015 09:12:16 +0000 (11:12 +0200)]
path-util: make sure fd_is_mount_point() returns true for root directory
Lennart Poettering [Sat, 4 Apr 2015 17:22:00 +0000 (19:22 +0200)]
rm-rf: add support for recursively removing btrfs subvolumes
Lennart Poettering [Sat, 4 Apr 2015 17:20:56 +0000 (19:20 +0200)]
path-util: if parent can do name_to_handle() but relevant dir not, it's a mount point
Lennart Poettering [Sat, 4 Apr 2015 12:42:39 +0000 (14:42 +0200)]
rm-rf: never cross mount points
Lennart Poettering [Sat, 4 Apr 2015 09:52:57 +0000 (11:52 +0200)]
util: rework rm_rf() logic
- Move to its own file rm-rf.c
- Change parameters into a single flags parameter
- Remove "honour sticky" logic, it's unused these days
Lennart Poettering [Fri, 3 Apr 2015 13:10:20 +0000 (15:10 +0200)]
update TODO
Shawn Landden [Sun, 5 Apr 2015 17:03:37 +0000 (10:03 -0700)]
bootchart: fix check for no fd
found with coverty report
Tom Gundersen [Sun, 5 Apr 2015 10:17:29 +0000 (12:17 +0200)]
sd-device: don't use alloca() within loops
I shall not use alloca() within loops
I shall not use alloca() within loops
I shall not use alloca() within loops
I shall not use alloca() within loops
...
Thomas Hindoe Paaboel Andersen [Sun, 5 Apr 2015 06:30:49 +0000 (08:30 +0200)]
libudev-util: check length before accesing the array
Thomas Hindoe Paaboel Andersen [Sun, 5 Apr 2015 06:28:27 +0000 (08:28 +0200)]
service: remove unnecessary forward declare
Tom Gundersen [Fri, 3 Apr 2015 20:51:09 +0000 (22:51 +0200)]
sd-device,udevd: fix spelling /ammend/amend/
Tom Gundersen [Fri, 3 Apr 2015 19:04:48 +0000 (21:04 +0200)]
sd-device: fix deserialization from netlink
Use the standard FOREACH_WORD* macros.
The current code was broken in the devlink case so the last one received
was being dropped, causing https://bugs.freedesktop.org/show_bug.cgi?id=89894
Tom Gundersen [Fri, 3 Apr 2015 19:05:42 +0000 (21:05 +0200)]
sd-device: get_properties_{nulstr,strv} - don't recreate the buffer unnecessarily
Tom Gundersen [Fri, 3 Apr 2015 15:43:13 +0000 (17:43 +0200)]
sd-device: get_sysattr_value - don't leak returned value
This was getting leaked as a copy was added to the hashmap, simply add the
returned value instead.
This should fix CID #1292806.
Tom Gundersen [Fri, 3 Apr 2015 15:27:45 +0000 (17:27 +0200)]
test: udev, valgrind - track origins of uninitiaziled memory
Tom Gundersen [Fri, 3 Apr 2015 15:27:00 +0000 (17:27 +0200)]
sd-device: initialize variable
sysnum would not be initialized if sysname had no trailing digits.
Tom Gundersen [Fri, 3 Apr 2015 13:21:03 +0000 (15:21 +0200)]
networkd: improve logging when processing links and addresses
Daniel Mack [Thu, 2 Apr 2015 22:40:01 +0000 (00:40 +0200)]
bootchart: assorted coding style fixes
* kill unnecessary {}
* add newlines where appropriate
* remove dead code
* reorder variable declarations
* fix more return code logic
* pass O_CLOEXEC to all open*() calles
* use safe_close() where possible
Daniel Mack [Thu, 2 Apr 2015 13:15:43 +0000 (15:15 +0200)]
bootchart: kill a bunch of global variables
This code is in a confusingly bad shape. Kill a bunch of global variables
and pass needed variables around in function calls.
Daniel Mack [Thu, 2 Apr 2015 12:15:33 +0000 (14:15 +0200)]
bootchart: clean up sysfd and proc handling
Retrieve the handle to procfs in main(), and pass it functions
that need it. Kill the global variables.
Also, refactor lots of code in svg_title(). There's no need to access any
global variables from there either, and we really should return proper
errors from there as well.
Daniel Mack [Thu, 2 Apr 2015 11:43:18 +0000 (13:43 +0200)]
bootchart: clean up control flow logic
Don't blindly exit() from random functions, but return a proper error
and upchain error conditions.
squash! bootchart: clean up control flow logic
When pread() returns "0", it's a read failure, so don't make the caller think
log_sample() was successful, return meaningful error code instead of 0.
Daniel Mack [Thu, 2 Apr 2015 11:24:30 +0000 (13:24 +0200)]
bootchart: switch to log_* helpers
Let the helper functions take care of the string message output.
Lennart Poettering [Fri, 3 Apr 2015 12:34:59 +0000 (14:34 +0200)]
update TODO
Lennart Poettering [Fri, 3 Apr 2015 12:32:32 +0000 (14:32 +0200)]
units: explicitly require /var, /tmp and /var/tmp to be mounted before basic.target
We support /var, /tmp and /var/tmp on NFS. NFS shares however are by
default ordered only before remote-fs.target which is a late-boot
service. /var, /tmp, /var/tmp need to be around earlier though, hence
explicitly order them before basic.target.
Note that this change simply makes explicit what was implicit before,
since many early-boot services pulled in parts of /var anyway early.
Lennart Poettering [Fri, 3 Apr 2015 12:31:35 +0000 (14:31 +0200)]
units: explicitly order systemd-user-sessions.service after nss-user-lookup.target
We should not allow logins before NIS/LDAP users are available.
Lennart Poettering [Fri, 3 Apr 2015 12:27:16 +0000 (14:27 +0200)]
units: move After=systemd-hwdb-update.service dependency from udev to udev-trigger
Let's move the hwdb regeneration a bit later. Given that hwdb is
non-essential it should be OK to allow udev to run without it until we
do the full trigger.
http://lists.freedesktop.org/archives/systemd-devel/2015-April/030074.html
Lennart Poettering [Fri, 3 Apr 2015 12:26:22 +0000 (14:26 +0200)]
CODING_STYLE: mention that dup() should not be used
Lennart Poettering [Thu, 2 Apr 2015 10:15:53 +0000 (12:15 +0200)]
timedatectl: many fixes
- print runtime warnings with log_warning()
- save and restore $TZ properly
- Get rid of exit() pseudo error handling
- Using time() is OK when connecting to a local container or when
showing data about local host, but certainly not for remote hosts.
Lennart Poettering [Thu, 2 Apr 2015 10:14:57 +0000 (12:14 +0200)]
man: don't mention "journalctl /dev/sda"
It never worked, and nobody ever worked on it, hence don't mention it.
Lennart Poettering [Thu, 2 Apr 2015 10:14:51 +0000 (12:14 +0200)]
update TODO
Lennart Poettering [Thu, 2 Apr 2015 10:14:43 +0000 (12:14 +0200)]
CODING_STYLE: clarify that exit() is never OK to call
Tom Gundersen [Wed, 1 Apr 2015 11:55:20 +0000 (13:55 +0200)]
libudev: device - replace by a thin wrapper around sd-device
Tom Gundersen [Wed, 1 Apr 2015 12:33:02 +0000 (14:33 +0200)]
fsck: port from libudev to sd-device
Tom Gundersen [Wed, 1 Apr 2015 12:26:47 +0000 (14:26 +0200)]
cryptsetup: port from libudev to sd-device
Tom Gundersen [Fri, 5 Dec 2014 00:16:05 +0000 (01:16 +0100)]
networkctl: port from libudev to sd-device
Tom Gundersen [Wed, 1 Apr 2015 11:50:31 +0000 (13:50 +0200)]
libsystemd: add sd-device library
This provides equivalent functionality to libudev-device, but in the
systemd style. The public API only caters to creating sd_device objects
from for devices that already exist in /sys, there is no support for
listening for monitoring events or creating devices received over
the udev netlink protocol.
The private API contains the necessary functionality to make sd-device
a drop-in replacement for libudev-device, but which we would not
otherwise want to export.
Tom Gundersen [Wed, 1 Apr 2015 21:34:19 +0000 (23:34 +0200)]
udev: net_id - improve comments
The dev_port concept is a bit confusing, expand on the comment a bit.
Tom Gundersen [Wed, 1 Apr 2015 14:51:02 +0000 (16:51 +0200)]
udev: net_id - support multi-port enpo* device names
I'd argue that having firmware labels for such devices makes
no sense, but they exist, so make sure we handle them as best
as we can.
Tom Gundersen [Wed, 1 Apr 2015 14:41:41 +0000 (16:41 +0200)]
udev: net_id - fix copy-paste error
In case pci_slot overflows we were truncating pci_path instead.
Tom Gundersen [Wed, 1 Apr 2015 11:55:52 +0000 (13:55 +0200)]
libudev: monitor - improve logging
Tom Gundersen [Wed, 1 Apr 2015 11:46:59 +0000 (13:46 +0200)]
shared: set - make argument to set_remove() const
Michal Sekletar [Wed, 1 Apr 2015 11:08:25 +0000 (13:08 +0200)]
mount: fix up wording in the comment
Lukas Nykryn [Mon, 30 Mar 2015 12:42:02 +0000 (14:42 +0200)]
mount: don't run quotaon only for network filesystems
If you have for example ext4 on iscsi devices it is possible to setup
qoutas there. Unfortunately, because such fstab entry contains _netdev,
systemd will not add dependency to quotaon.service.
Marcel Holtmann [Tue, 31 Mar 2015 20:59:12 +0000 (22:59 +0200)]
hwdb: Update database of Bluetooth company identifiers
Alban Crequy [Tue, 31 Mar 2015 15:14:48 +0000 (17:14 +0200)]
nspawn: fallback on bind mount when mknod fails
Some systems abusively restrict mknod, even when the device node already
exists in /dev. This is unfortunate because it prevents systemd-nspawn
from creating the basic devices in /dev in the container.
This patch implements a workaround: when mknod fails, fallback on bind
mounts.
Additionally, /dev/console was created with a mknod with the same
major/minor as /dev/null before bind mounting a pts on it. This patch
removes the mknod and creates an empty regular file instead.
In order to test this patch, I used the following configuration, which I
think should replicate the system with the abusive restriction on mknod:
# grep devices /proc/self/cgroup
4:devices:/user.slice/restrict
# cat /sys/fs/cgroup/devices/user.slice/restrict/devices.list
c 1:9 r
c 5:2 rw
c 136:* rw
# systemd-nspawn --register=false -D .
v2:
- remove "bind", it is not needed since there is already MS_BIND
v3:
- fix error management when calling touch()
- fix lowercase in error message
Lennart Poettering [Tue, 31 Mar 2015 13:34:01 +0000 (15:34 +0200)]
nspawn: drop sd_booted() check
We have no such check in any of the other tools, hence don't have one in
nspawn either.
(This should make things nicer for Rocket, among other things)
Note: removing this check does not mean that we support running nspawn
on non-systemd. We explicitly don't. It just means that we remove the
check for running it like that. You are still on your own if you do...
Iago López Galeiras [Tue, 31 Mar 2015 09:50:29 +0000 (11:50 +0200)]
nspawn: change filesystem type from "bind" to NULL in mount() syscalls
Try to keep syscalls as minimal as possible.
Lennart Poettering [Tue, 31 Mar 2015 13:32:43 +0000 (15:32 +0200)]
man: fix line breaks in code examples