Jee-Yong Um [Thu, 8 Jan 2015 06:47:24 +0000 (15:47 +0900)]
elm_image: Fixed to have exact size using elm_image_fill_outside_set()
Summary:
There was a problem that image is stretched over its size
when elm_image_fill_outside_set() is applied.
This patch fixed that.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1854
ChunEon Park [Thu, 8 Jan 2015 02:13:02 +0000 (11:13 +0900)]
genlist: fix crash issue.
"selected" list has the eo list, not elm_gen_item.
this is side effect caused while on refactoring genlist.
Nibha Sharma [Thu, 8 Jan 2015 01:46:05 +0000 (10:46 +0900)]
elm_font: Fixed resource leak in function elm_font_available_hash_add
Summary: @Fix
Reviewers: raster, singh.amitesh, seoz, kimcinoo, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1849
ChunEon Park [Thu, 8 Jan 2015 01:34:12 +0000 (10:34 +0900)]
theme: fix misprint in popup style alias name
@fix
Reviewers: cedric, raster, seoz
Subscribers: reutskiy.v.v
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D1848
Carsten Haitzler (Rasterman) [Wed, 7 Jan 2015 10:33:27 +0000 (19:33 +0900)]
elm filesel - fix eio access of widget data after de in eio threads
@fix
ChunEon Park [Wed, 7 Jan 2015 09:11:51 +0000 (18:11 +0900)]
genlist: add more arguments validation checks
Carsten Haitzler (Rasterman) [Wed, 7 Jan 2015 07:49:08 +0000 (16:49 +0900)]
elm progressbar - fix invalid access to freed units string
@fix
Marcel Hollerbach [Wed, 7 Jan 2015 06:17:46 +0000 (15:17 +0900)]
fileselector: added a search icon
Summary:
fileselector: redirect keystrokes to the searchbar
Keystrokes like a-z A-Z 0-9 are redirected to the searchbar, so you dont
need to click arround to search files in the fileselector.
The search icon is from ApB (Apostolos B.), thx for that! :)
@feature Improved the searchbar
Reviewers: raster, seoz
Subscribers: ryuan.choi, cedric, seoz
Differential Revision: https://phab.enlightenment.org/D1237
Conflicts:
src/lib/elc_fileselector.c
ChunEon Park [Wed, 7 Jan 2015 06:49:19 +0000 (15:49 +0900)]
genlist: + parent validation check
ChunEon Park [Wed, 7 Jan 2015 06:20:45 +0000 (15:20 +0900)]
genlist: code refactoring.
type check than boolean(to be removed)
ChunEon Park [Wed, 7 Jan 2015 06:18:01 +0000 (15:18 +0900)]
genlist: use simple macro
ChunEon Park [Wed, 7 Jan 2015 05:39:34 +0000 (14:39 +0900)]
genlist: null check++
ChunEon Park [Wed, 7 Jan 2015 05:38:25 +0000 (14:38 +0900)]
genlist: clean up missing resources in genlist_clear()
ChunEon Park [Wed, 7 Jan 2015 05:10:18 +0000 (14:10 +0900)]
genlist: cancel multi selected items.
cancel multi selected items if the multi-select mode is canceled.
@fix
ChunEon Park [Wed, 7 Jan 2015 02:42:08 +0000 (11:42 +0900)]
colorselector: memory leak fix in _color_bars_add
Summary:
this function is called at least twice: in _smart_add and every time _theme_apply is called.
so we need either correctly free sd->cb_data or reuse it
@fix
Reviewers: seoz, cedric, raster, Hermet
Subscribers: reutskiy.v.v
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D1841
Nak-Gyeong Kim [Wed, 7 Jan 2015 02:22:07 +0000 (11:22 +0900)]
elm_segment_control: Fix elm_object_item_text_set bug.
Summary:
Cause : When part name is NULL, edje_object_part_text_escaped_set is not called.
Measure : Add code for each conditions.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1847
woochan lee [Wed, 7 Jan 2015 02:16:38 +0000 (11:16 +0900)]
elm_diskselector.c: idle enterer add condition changed.
Summary:
The idle enterer added even after deleted sd for diskselector.
it makes crash.
@fix
Test Plan:
1. Run elementary_test
2. Execution diskselector.
3. Close diskselector sample window.
4. Crash occured.
Reviewers: Hermet, seoz, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1843
Mike Blumenkrantz [Tue, 6 Jan 2015 21:53:59 +0000 (16:53 -0500)]
win INLINE_IMAGE test now crashes as expected when trying to use it in a non-useless manner
ref T1973
Mike Blumenkrantz [Tue, 6 Jan 2015 20:19:00 +0000 (15:19 -0500)]
elm_image now inherits edje signal emit
@feature
Stephen Houston [Tue, 6 Jan 2015 19:49:55 +0000 (13:49 -0600)]
thumb: Make sure to stop pulse animation on thumbs that failed to generate
ChunEon Park [Tue, 6 Jan 2015 11:17:03 +0000 (20:17 +0900)]
genlist: refactor code.
select/unselect items by using common select function.
Carsten Haitzler (Rasterman) [Tue, 6 Jan 2015 09:48:50 +0000 (18:48 +0900)]
theme - more efm icons from appb
fixes T1582
ChunEon Park [Tue, 6 Jan 2015 06:50:30 +0000 (15:50 +0900)]
genlist: use macro as possible.
ChunEon Park [Tue, 6 Jan 2015 06:46:35 +0000 (15:46 +0900)]
gelnist: unswallow makes sense. not smart member del.
Chris Michael [Mon, 5 Jan 2015 18:48:45 +0000 (13:48 -0500)]
elementary: Fix issue with event data causing an invalid free
Summary: Since we end up calling free on the event->data parameter
after a drop is completed, we should actually be allocating a string
for this data (to be free'd later). This also fixes an issue where the
event length was not being set.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 5 Jan 2015 17:17:03 +0000 (12:17 -0500)]
elementary: Fix return values to use Eina_Bool
Summary: This function is expecting Eina_Bool as the return value, not
ints so let's use EINA_FALSE here.
NB: this just fixes a copy/paste issue
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 5 Jan 2015 17:05:50 +0000 (12:05 -0500)]
elementary: Fix DnD to work again in wayland
Summary: In order for ecore_wl to start a drag, we need to send the
parent window of the object being dragged. Previous code was not
getting the parent window properly.
NB: This patch also fixes an issue where the data being sent to the
drop callback was being incorrectly sent.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
ChunEon Park [Mon, 5 Jan 2015 13:17:12 +0000 (22:17 +0900)]
genlist: keep the item class as given argument.
ChunEon Park [Mon, 5 Jan 2015 11:43:58 +0000 (20:43 +0900)]
genlist: Fix genlist index get bug
Because not all item block have "max_items_per_block" number of items in it's block.
So the calculation is not correct when items are added & removed in each block.
Anyhow, we need more efficient way for this API because genlist uses inlinst.
ChunEon Park [Mon, 5 Jan 2015 11:21:26 +0000 (20:21 +0900)]
genlist: add some comment in code.
ChunEon Park [Mon, 5 Jan 2015 06:56:27 +0000 (15:56 +0900)]
genlist: use macro as possible.
ChunEon Park [Mon, 5 Jan 2015 06:55:39 +0000 (15:55 +0900)]
genlist: use ELM_NEW
ChunEon Park [Mon, 5 Jan 2015 06:42:22 +0000 (15:42 +0900)]
genilst: unselect items if the genlist select mode is display only or none.
make it behavior same with elm_genlist_item_select_mode_set()
@fix
ChunEon Park [Mon, 5 Jan 2015 06:37:41 +0000 (15:37 +0900)]
genlist: unselect item if the select mode is display only or none.
@fix
ChunEon Park [Mon, 5 Jan 2015 06:03:37 +0000 (15:03 +0900)]
ggenlist: code refactoring.
don't do anything if same mode is applied.
Dave Andreoli [Sun, 4 Jan 2015 14:38:37 +0000 (15:38 +0100)]
Improve win dialog test to also include a test for standard_win
Daniel Hirt [Sun, 4 Jan 2015 11:54:03 +0000 (13:54 +0200)]
Elm_Entry: Fix dropped text data insertion
Fixes bad drag&drop into entry widgets, since the drop callback
assumed that the dropped text ends with a NULL character.
How to reproduce:
1. Open 'elementary_test -to Entry'
2. Open some application (e.g. Firefox)
3. Select some (preferably short) text, and drag&drop it to the entry
widget. This sometimes pastes additional corrupted text (better try
with a 1-3 characters text).
@fix
Dave Andreoli [Sat, 3 Jan 2015 13:13:35 +0000 (14:13 +0100)]
Added the elm_win_util_dialog_add() API function
This new @feature is just a convenient way to create dialogs, It
mimic the elm_win_util_standard_add() function but crete a
standard dialog, with background and the parent set.
WinDialog test changed to use the new function.
Dave Andreoli [Sat, 3 Jan 2015 11:49:08 +0000 (12:49 +0100)]
Icon: added documentation for the new fdo icon names
ChunEon Park [Fri, 2 Jan 2015 11:18:24 +0000 (20:18 +0900)]
genlist: remove useless deco texts.
ChunEon Park [Fri, 2 Jan 2015 11:04:55 +0000 (20:04 +0900)]
genlist: + null check
ChunEon Park [Fri, 2 Jan 2015 10:59:39 +0000 (19:59 +0900)]
genlist: code refactoring
refactor _item_content_realize() prototype to keep the consistency with state,text_realize()
ChunEon Park [Fri, 2 Jan 2015 10:45:48 +0000 (19:45 +0900)]
genlist: code refactoring.
apply facade at _view_inflate() for simple item realization.
ChunEon Park [Fri, 2 Jan 2015 10:04:34 +0000 (19:04 +0900)]
genlist: code refactoring.
remove contents_obj but use contents instead.
ChunEon Park [Fri, 2 Jan 2015 08:34:05 +0000 (17:34 +0900)]
genlist: code refactoring.
remove target states strings in the widget item.
ChunEon Park [Fri, 2 Jan 2015 07:54:01 +0000 (16:54 +0900)]
genlist: code refactoring.
just clean up code. no logic change.
ChunEon Park [Fri, 2 Jan 2015 07:48:29 +0000 (16:48 +0900)]
genlist: refactoring code.
removed invalid content string free call.
and renamed flip_content_objs -> flip_contents.
ChunEon Park [Fri, 2 Jan 2015 07:17:16 +0000 (16:17 +0900)]
genlist: code refactoring.
remove contents string list that doesn't needed to keep in widget data.
next code refactoring based on this patch will be coming.
ChunEon Park [Fri, 2 Jan 2015 03:14:41 +0000 (12:14 +0900)]
genlist: exceptional handling.
just be hidden if contents are failed to swallow.
Mike Blumenkrantz [Wed, 31 Dec 2014 20:30:57 +0000 (15:30 -0500)]
box layout should not silently fail when size is less than min size hint
this broke box display in any case where the user had manually changed size hints, eg. when using box align
@fix
ChunEon Park [Wed, 31 Dec 2014 10:55:09 +0000 (19:55 +0900)]
genlist: free selected items when genlist is cleared.
ChunEon Park [Wed, 31 Dec 2014 10:10:40 +0000 (19:10 +0900)]
genlist: send reorder signal to decoration item and views.
Previous logic was too much stick to special case for *tizen*
let decide item styles in theme as possible.
This might break reorder group item ui, but it won't be critical.
because tizen ui only depeneded on the scenario and they don't use them anymore.
This will be much better for multiple scenario in the future.
ChunEon Park [Wed, 31 Dec 2014 09:59:28 +0000 (18:59 +0900)]
genlist: let group item set reorder style as it needs.
we don't need to limit the group item it's reorder style.
woochan lee [Wed, 31 Dec 2014 08:38:28 +0000 (17:38 +0900)]
test_gengrid.c: Fixed Item_Data array size for prevent buffer overflow.
Summary:
Item_Data size set as 144 before. but test_gengrid_speed function called create_gengrid function with 5000 items.
it makes crash.
@fix
Test Plan:
1. run elementary_test.
2. click Gengrid update Speed.
3. crash.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1834
Amitesh Singh [Wed, 31 Dec 2014 08:33:32 +0000 (17:33 +0900)]
test_glview_simple: opimize draw code.
Summary:
There is no need to call glVertexAttribPointer &
glEnableVertexAttribArray() while rendering.
Reviewers: seoz, jpeg, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1827
Dave Andreoli [Tue, 30 Dec 2014 22:02:24 +0000 (23:02 +0100)]
Icon theme: added standard freedesktop names.
OK, this commit try to fix the mess we have done with icon names in elm.
I just added standard names to icons yet existing in the elm theme, the
old name are, of course, preserved. But I marked them as -deprecated-.
Also added a new test: Icon Standard. It show all the icon that have standard
fdo names. This can be really usefull for user that need to choose icons to use.
I put some guidelines comment in the icons.edc files, I hope people will follow
the rules from now on... or will recive my personal spanking :D
I will work on those icons more in the next days: will add the new names to
elm docs, will try to match better fdo icon names, and maybe also add some
new icons...
Suggestions are always welcome.
@feature (maybe)
Daniel Juyung Seo [Tue, 30 Dec 2014 16:05:07 +0000 (01:05 +0900)]
Revert "gesture_layer: Remove unnecessary value assignment."
This reverts commit
d389a44b42d482414d1bfb2f4d0ccebbda510d7b.
Tasn said this value needs to be used. Let's fix it correctly later.
Thanks Tom.
Daniel Juyung Seo [Tue, 30 Dec 2014 15:12:57 +0000 (00:12 +0900)]
gesture_layer: Remove unnecessary value assignment.
This fixes coverity CID 1261280.
But this is not critical.
ChunEon Park [Tue, 30 Dec 2014 08:56:24 +0000 (17:56 +0900)]
genlist: + warning msg for user notice
don't unrealize reordering item.
ChunEon Park [Tue, 30 Dec 2014 08:36:14 +0000 (17:36 +0900)]
genlist: use convenient macro.
ChunEon Park [Tue, 30 Dec 2014 06:44:19 +0000 (15:44 +0900)]
Revert "genlist: return as possible as soon."
This reverts commit
ef56ed167206612f146d2c70f5b35a7bcd62c4c6.
This caused logic change. should not be changed.
ChunEon Park [Tue, 30 Dec 2014 06:43:20 +0000 (15:43 +0900)]
Revert "genlist: return as possible as soon"
This reverts commit
1e6736c3a13d58c4e1a01d7e23983c721051be08.
This caused logic. should not be changed.
ChunEon Park [Tue, 30 Dec 2014 06:32:41 +0000 (15:32 +0900)]
genlist: return as possible as soon
Jee-Yong Um [Tue, 30 Dec 2014 04:11:50 +0000 (13:11 +0900)]
elm_colorselector: Fixed to get proper min size with picker only mode
Summary:
Fixed to make colorselector have proper min size
when colorselector is in ELM_COLORSELECTOR_PICKER mode
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1832
ChunEon Park [Tue, 30 Dec 2014 02:16:56 +0000 (11:16 +0900)]
genlist: removed unnecessary check
Daniel Juyung Seo [Mon, 29 Dec 2014 16:31:43 +0000 (01:31 +0900)]
genlist: Fix internal comments.
Daniel Juyung Seo [Mon, 29 Dec 2014 15:35:24 +0000 (00:35 +0900)]
test_genlist: Add clicked,right test case.
ChunEon Park [Mon, 29 Dec 2014 13:58:38 +0000 (22:58 +0900)]
genlist: return as possible as soon.
ChunEon Park [Mon, 29 Dec 2014 13:51:39 +0000 (22:51 +0900)]
genlist: clean up code.
repositioned function and remove unnecessary prototype declaration.
ChunEon Park [Mon, 29 Dec 2014 13:34:45 +0000 (22:34 +0900)]
genlist: remove duplicated signal registration.
ChunEon Park [Mon, 29 Dec 2014 13:27:28 +0000 (22:27 +0900)]
genlist: send an additional signal
send flip disabled signal when it's state is switched.
ChunEon Park [Mon, 29 Dec 2014 13:15:16 +0000 (22:15 +0900)]
genlist: send a signal internally.
send a signal so that item set it's style according to it's depth
Dave Andreoli [Mon, 29 Dec 2014 12:46:50 +0000 (13:46 +0100)]
Fileselector: beautify the search entry
Entry moved to the top-right corner and added the guide text
ChunEon Park [Mon, 29 Dec 2014 12:44:07 +0000 (21:44 +0900)]
genlist: send a disabled signal when the decorated item is unrealized.
Dave Andreoli [Mon, 29 Dec 2014 11:45:43 +0000 (12:45 +0100)]
Hover and derivates: dismiss with every mouse buttons, not only 1
Dave Andreoli [Mon, 29 Dec 2014 11:17:41 +0000 (12:17 +0100)]
List: new signal: clicked,right with simple test
@feature
ChunEon Park [Mon, 29 Dec 2014 10:49:19 +0000 (19:49 +0900)]
genlist: code refactoring
declare/use const strings for internal signals
Dave Andreoli [Mon, 29 Dec 2014 10:38:17 +0000 (11:38 +0100)]
Gengrid: new signal: clicked,right with proper test
@feature
Dave Andreoli [Mon, 29 Dec 2014 10:19:21 +0000 (11:19 +0100)]
Genlist: do not fire clicked,right while dragging in progress
ChunEon Park [Mon, 29 Dec 2014 09:59:14 +0000 (18:59 +0900)]
genlist: add "scroll" smart call
@feature
Daniel Juyung Seo [Sat, 27 Dec 2014 13:25:24 +0000 (22:25 +0900)]
test_transit: Cast integer to pointer correctly to support 64 bit system.
Amitesh Singh [Sat, 27 Dec 2014 13:12:30 +0000 (22:12 +0900)]
test_glview: Refractored the shader/program log code.
Summary:
Added a function print_glerror_log to handle both shaders and programs
logs.
Test Plan: elementary_test -> glview
Reviewers: raster, jpeg, seoz
Reviewed By: seoz
Subscribers: anand.km, seoz
Differential Revision: https://phab.enlightenment.org/D1826
Dave Andreoli [Fri, 26 Dec 2014 17:46:28 +0000 (18:46 +0100)]
Improve -clicked- detection code by accept only if the mouse do not move too much
Too much in this case is a fixed 4px. As fingers do not have a right button I think
that taking into account finger size is not needed here.
Also someone argued about the signal name is not really correct...
should I change it to somethig like: clicked,secondary ?
Dave Andreoli [Fri, 26 Dec 2014 16:29:51 +0000 (17:29 +0100)]
Genlist: added the clicked,right event on items
@feature
Dave Andreoli [Fri, 26 Dec 2014 14:19:56 +0000 (15:19 +0100)]
Genlist: better text style for the default_style selected style
When the genlist item is selected it change the text effect from
shadow to glow, this has 2 side effects:
1. the text gets an unwanted 2px offset (because glow require more space, I think)
2. the text color the user has set usually looks ugly with the glow color
This commit change the style to always use a normal shadow, whenever the item
is selected or not. Only apply to the default_style item style.
Amitesh Singh [Fri, 26 Dec 2014 11:22:57 +0000 (20:22 +0900)]
list/genlist/gengrid: Fix memory leak.
Summary: @Fix
Reviewers: kimcinoo, SanghyeonLee, raster, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1825
Daniel Juyung Seo [Fri, 26 Dec 2014 09:45:29 +0000 (18:45 +0900)]
gengrid: Enhance realized_items_get performance.
Daniel Juyung Seo [Fri, 26 Dec 2014 09:40:14 +0000 (18:40 +0900)]
gengrid, genlist, list, toolbar: Fix memory leak and enhance performance.
1. Fix memory leak by freeing eina_list.
2. Enhance performance by getting the item list when it is really
needed.
@fix
Daniel Juyung Seo [Fri, 26 Dec 2014 05:36:36 +0000 (14:36 +0900)]
genlist: Return the correct pointer for object item.
No backport needed.
Daniel Juyung Seo [Fri, 26 Dec 2014 05:33:32 +0000 (14:33 +0900)]
gengrid: Add missing "moved" callback call on item reorder by key.
This is a gengrid version of
de75e6c0e852a2664c0ed022a6f79d6f431f64a0.
@fix
Andrii Kroitor [Fri, 26 Dec 2014 05:21:02 +0000 (14:21 +0900)]
elm_genlist: add missing callback call
Summary:
Added missing "moved" callback call when reordering items with keyboard
"up" and "down" arrows
@fix
Reviewers: cedric, raster, seoz
Reviewed By: seoz
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1818
Andrii Kroitor [Fri, 26 Dec 2014 02:26:42 +0000 (11:26 +0900)]
elm_toolbar: fix memory leak in _elm_toolbar_nearest_visible_item_get
@fix
Reviewers: cedric, seoz, Hermet, raster
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1822
ChunEon Park [Fri, 26 Dec 2014 02:22:02 +0000 (11:22 +0900)]
transit: revise tween sample
Mike Blumenkrantz [Fri, 26 Dec 2014 01:38:54 +0000 (20:38 -0500)]
genlist should ignore no-select items when moving with the keyboard
@fix
Jee-Yong Um [Fri, 26 Dec 2014 01:27:15 +0000 (10:27 +0900)]
elm_transit: Append Elm_Transit_Tween_Mode sample to elementary_test
Summary:
A sample for elm_transit_tween mode which can be executed via
"Effects"-"Transit Tween Mode" button in elementary_test
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1817
Mike Blumenkrantz [Wed, 24 Dec 2014 22:58:37 +0000 (17:58 -0500)]
add clipper for gadget popup shine
@fix
jiin.moon [Wed, 24 Dec 2014 05:07:32 +0000 (14:07 +0900)]
image: fix clipped image issue if x or y is less than zero
Summary:
After applying clipping patch about image on outside,
the width or height of the image be decreased
if x or y of an image is less than zero.
The way to calculate width/height has changed.
This fixes a side effect added in
2839881f37ea85b3469d8fd37cfaa4f9d67458fa
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1810
Jee-Yong Um [Tue, 23 Dec 2014 00:50:52 +0000 (09:50 +0900)]
elm_colorselector: Fix layout broken in ELM_COLORSELECTOR_ALL mode
Summary:
Fix layout broken in ELM_COLORSELECTOR_ALL mode
due to missing part for layout sizing evaluation
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1802
Jaehyun Cho [Tue, 23 Dec 2014 00:39:28 +0000 (09:39 +0900)]
elm_transit: Support rotation keeping current map effect.
Summary:
Support rotation keeping current map effect.
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1806
Jaehyun Cho [Tue, 23 Dec 2014 00:36:37 +0000 (09:36 +0900)]
elm_transit: Support zoom keeping current map effect.
Summary:
Support zoom keeping current map effect.
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1805