EgorBo [Thu, 30 Jan 2020 16:26:57 +0000 (19:26 +0300)]
Add RunSample target to mono.proj
Eirik Tsarpalis [Thu, 30 Jan 2020 07:59:30 +0000 (07:59 +0000)]
Nullable annotate System.Reflection.MetadataLoadContext.
* Nullable annotate System.Reflection.MetadataLoadContext
* address feedback
* address feedback
* undo accidental change
* address more feedback
* Revert "address more feedback"
This reverts commit
6519238856c318186ef225e360f732780038d435.
Andrew Arnott [Thu, 30 Jan 2020 07:19:45 +0000 (00:19 -0700)]
Hide redundant members from debugger views (#2361)
Egor Chesakov [Thu, 30 Jan 2020 03:32:38 +0000 (19:32 -0800)]
For a destination register use scalar forms (i.e. Sd, Hd, Bd) instead of vector ones (i.e. Vd.2S, Vd.4H, Vd.2B) for instructions that return scalar result (e.g. addv, smaxv, umaxv) in emitDispIns in emitarm64.cpp (#2324)
Egor Chesakov [Thu, 30 Jan 2020 03:31:52 +0000 (19:31 -0800)]
[Arm64] Support Vector64<double>, Vector64<long>, and Vector64<ulong> (#1747)
* Add "LoadVector64" for Vector64<double>, Vector64<long> and Vector64<ulong> in AdvSimd.PlatformNotSupported.cs AdvSimd.cs
* Update "Abs" and "AbsScalar" in AdvSimd.PlatformNotSupported.cs AdvSimd.cs
* Update "AbsoluteCompareGreaterThan" and "AbsoluteCompareGreaterThanScalar" in AdvSimd.PlatformNotSupported.cs AdvSimd.cs
* Update "AbsoluteCompareGreaterThanOrEqual" and "AbsoluteCompareGreaterThanOrEqualScalar" in AdvSimd.PlatformNotSupported.cs AdvSimd.cs
* Update "AbsoluteCompareLessThan" and "AbsoluteCompareLessThanScalar" in AdvSimd.PlatformNotSupported.cs AdvSimd.cs
* Update "AbsoluteCompareLessThanOrEqual" and "AbsoluteCompareLessThanOrEqualScalar" in AdvSimd.PlatformNotSupported.cs AdvSimd.cs
* Add "AbsoluteDifferenceScalar" in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "AddScalar" in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "BitwiseSelect" in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareEqual" and "CompareEqualScalar" in AdvSimd.Arm64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Re-order "CompareEqual" in AdvSimd in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareGreaterThan" and "CompareGreaterThanScalar" in AdvSimd.Arm64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareGreaterThan" in AdvSimd in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareGreaterThanOrEqual" and "CompareGreaterThanOrEqualScalar" in AdvSimd.Arm64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareGreaterThanOrEqual" in AdvSimd in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareLessThan" and "CompareLessThanScalar" in AdvSimd.Arm64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareLessThan" in AdvSimd in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareLessThanOrEqual" and "CompareLessThanOrEqualScalar" in AdvSimd.Arm64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareLessThanOrEqual" in AdvSimd in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareTest" and "CompareTestScalar" in AdvSimd.Arm64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "CompareTest" in AdvSimd in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "LeadingSignCount" in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "LeadingZeroCount" in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update "PopCount" in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
* Update System.Runtime.Intrinsics.Experimental.cs
* Re-order "AbsScalar" in hwintrinsiclistarm64.h
* Re-order "TransposeEven" and "TransposeOdd" in hwintrinsiclistarm64.h
* Update "Abs" in AdvSimd and AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Update "AbsScalar" in AdvSimd and AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Update "AbsoluteCompareGreaterThan" and "AbsoluteCompareGreaterThanScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Update "AbsoluteCompareGreaterThanOrEqual" and "AbsoluteCompareGreaterThanOrEqualScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Update "AbsoluteCompareLessThan" and "AbsoluteCompareLessThanScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Update "AbsoluteCompareLessThanOrEqual" and "AbsoluteCompareLessThanOrEqualScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Add "AbsoluteDifferenceScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Update "AddScalar" in AdvSimd in hwintrinsiclistarm64.h
* Update "Add" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Add "CompareEqualScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Add "CompareGreaterThanScalar" and "CompareGreaterThanOrEqualScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Add "CompareLessThanScalar" and "CompareLessThanOrEqualScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Add "CompareTestScalar" in AdvSimd_Arm64 in hwintrinsiclistarm64.h
* Add AdvSimd_Arm64_CompareLessThanScalar AdvSimd_Arm64_CompareLessThanOrEqualScalar AdvSimd_Arm64_AbsoluteCompareLessThanScalar AdvSimd_Arm64_AbsoluteCompareLessThanOrEqualScalar in hwintrinsiccodegenarm64.cpp
* Support Vector64<double>, Vector64<long> and Vector64<ulong> in Compiler::getBaseTypeAndSizeOfSIMDType() in compiler.h simd.cpp
* Stop treating Vector64<long>, Vector64<ulong> and Vector64<double> as unsupported types in MethodTable::GetVectorSize() in class.cpp
* Support scalar comparison operations in emitarm64.cpp
* For SimpleSIMD instructions that operates on 64x1 type remove INS_OPTS_1D in hwintrinsiccodegenarm64.cpp
* Add special hanling for SIMDIntrinsicInit for Vector64<double> in CodeGen::genSIMDIntrinsicInit in codegenarm64.cpp
* Add an assertion since INS_dup does not have .1D encoding in emitarm64.cpp
* Add LoadVector64 tests for Vector64<double>, Vector64<long> and Vector64<ulong> in GenerateTests.csx
* Add "Add" in Helpers.cs Helpers.tt
* Add "Abs" in Helpers.cs Helpers.tt
* Update "Abs" in AdvSimd in GenerateTests.csx
* Update "AbsScalar" in AdvSimd in GenerateTests.csx
* Update "Abs" and "AbsScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "AbsoluteCompare*" in AdvSimd in GenerateTests.csx
* Update "AbsoluteCompare*" in AdvSimd.Arm64 in GenerateTests.csx
* Update "AbsoluteDifference" in AdvSimd in GenerateTests.csx
* Update "AbsoluteDifference" in AdvSimd.Arm64 in GenerateTests.csx
* Update "Add" in AdvSimd in GenerateTests.csx
* Update "AddScalar" in AdvSimd in GenerateTests.csx
* Update "AddScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "BitwiseSelect" in AdvSimd in GenerateTests.csx
* Update "AddAcross" in AdvSimd.Arm64 in GenerateTests.csx
* Update "CompareEqual" in AdvSimd in GenerateTests.csx
* Update "CompareEqual" and "CompareEqualScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "CompareGreaterThan" in AdvSimd in GenerateTests.csx
* Update "CompareGreaterThan" and "CompareGreaterThanScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "CompareGreaterThanOrEqual" in AdvSimd in GenerateTests.csx
* Update "CompareGreaterThanOrEqual" and "CompareGreaterThanOrEqualScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "CompareLessThan" in AdvSimd in GenerateTests.csx
* Update "CompareLessThan" and "CompareLessThanScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "CompareLessThanOrEqual" in AdvSimd in GenerateTests.csx
* Update "CompareLessThanOrEqual" and "CompareLessThanOrEqualScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "CompareTest" in AdvSimd in GenerateTests.csx
* Update "CompareTest" and "CompareTestScalar" in AdvSimd.Arm64 in GenerateTests.csx
* Update "LeadingSignCount" in AdvSimd in GenerateTests.csx
* Update "LeadingZeroCount" in AdvSimd in GenerateTests.csx
* Update "PopCount" in AdvSimd in GenerateTests.csx
* Update "LoadVector64" in AdvSimd in GenerateTests.csx
* Update "LoadVector128" in AdvSimd in GenerateTests.csx
* Use ValidateIterResult in LoadUnOpTest.template
* Update AdvSimd/ AdvSimd.Arm64/
Jeremy Barton [Thu, 30 Jan 2020 01:14:24 +0000 (17:14 -0800)]
Update test OS matrix
* Update all docker-based configurations to the latest tags
* Remove Alpine 3.8 (near EOL)
* Add Alpine 3.11
* Remove Fedora 28 (EOL)
* Add Fedora 30
* Add OSX 10.15 to fullMatrix runs
Tomáš Rylek [Thu, 30 Jan 2020 00:49:13 +0000 (01:49 +0100)]
Add periodic schedule for the R2R pipeline (#2358)
Andrew Au [Thu, 30 Jan 2020 00:16:59 +0000 (16:16 -0800)]
Improve GC stress tests (#2166)
monojenkins [Thu, 30 Jan 2020 00:16:28 +0000 (19:16 -0500)]
[wasm][debugger] Initial support for proxying flat sessions (#2263)
Initial support means handling the browser endpoint and proxying any sessionId values, along with making sure we load pdbs as things start initializing
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Adeel Mujahid [Wed, 29 Jan 2020 23:50:36 +0000 (01:50 +0200)]
Add a fallback condition for musl ldd check (#2336)
If ldd fails with Exec format error, attempt to locate musl token
in the output of `strings /path/ldd`.
Jeremy Koritzinsky [Wed, 29 Jan 2020 22:49:13 +0000 (14:49 -0800)]
Use Arcade-provided IBCMerge support for System.Private.CoreLib. (#2308)
* Use Arcade-provided IBCMerge support.
* Clean up build.sh as well.
* Restore internal tools on Windows and Unix instead of just Windows.
* Remove unused item metadata.
Stephen Toub [Wed, 29 Jan 2020 22:07:50 +0000 (17:07 -0500)]
Disable Regex long pattern string test on .NET Framework (#2366)
Prashanth Govindarajan [Wed, 29 Jan 2020 21:53:40 +0000 (13:53 -0800)]
Fix parsing of '-' when inside a range (#1075)
Eirik Tsarpalis [Wed, 29 Jan 2020 21:13:05 +0000 (21:13 +0000)]
Revert "Nullable annotate System.Reflection.MetadataLoadContext (#1943)" (#2360)
This reverts commit
c541ea976b7cdae36462392d774b02bad7ea328e.
Pent Ploompuu [Wed, 29 Jan 2020 19:37:51 +0000 (21:37 +0200)]
Fix double expansion of AggregateException.Flatten message (#605)
* Fix double expansion of AggregateException.Flatten message
* Update tests
Jan Kotas [Wed, 29 Jan 2020 18:02:22 +0000 (10:02 -0800)]
Merging small assemblies (part 1/N) (#2189)
* Delete unnecessary ClsCompliant
* Merge System.Diagnostics.Tools\src into CoreLib
* Merge System.Security.Pricipal\src into CoreLib
* Delete System.IO.UnmanagedMemoryStream\ref\System.IO.UnmanagedMemoryStream.cs
* Delete System.Reflection\ref\System.Reflection.cs
* Delete System.Threading.Timer\src\ApiCompatBaseline.uapaot.txt
* Delete System.Buffers\src\Resources\Strings.resx
* Merge System.Buffers\ref into System.Runtime
* Merge System.Diagnostics.Debug\ref into System.Runtime
* Delete *\MatchingRefApiCompatBaseline.txt
* Merge System.Diagnostics.Tools into System.Runtime\ref
* Merge System.Resources.ResourceManager into System.Runtime\ref
* Cleanup System.IO.* project references
* Cleanup System.Reflection project references
* Cleanup System.Runtime.Handles project references
* Merge System.Threading.Thread\src into CoreLib
* Merge System.Threading.Timer\ref into System.Runtime
* Merge System.Threading.Tasks\ref into System.Runtime
Jan Kotas [Wed, 29 Jan 2020 17:01:10 +0000 (09:01 -0800)]
Revert "Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 (#2264)" (#2344)
This reverts commit
5fca04171171f118bca0f93aa9741f205b8cdc29.
John Smith [Wed, 29 Jan 2020 16:45:30 +0000 (16:45 +0000)]
typo - removed unneeded word in a comment (#2331)
Steve MacLean [Wed, 29 Jan 2020 16:16:06 +0000 (11:16 -0500)]
Limit jit format.py to src/coreclr/src/jit (#2328)
monojenkins [Wed, 29 Jan 2020 15:03:12 +0000 (10:03 -0500)]
[merp] MONO_DEBUG=no-gdb-stacktrace shouldn't disable MERP (#2149)
Only prevent `gdb` or `lldb` from being invoked.
MERP is controlled by separate mechanisms --- configure flags for crash
reporting and an explicit opt-in icall.
The existing code collects crashed process data in-process, but it writes the
data out (using mono_merp_invoke) in the forked child process. This is a bit
surprising, but in the interest of not disturbing the code too much, this PR
doesn't change that. We should revisit `dump_native_stacktrace` again in the
future and rationalize these decisions.
Addresses https://github.com/mono/mono/issues/18565
Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
Eirik Tsarpalis [Wed, 29 Jan 2020 14:29:58 +0000 (14:29 +0000)]
Nullable annotate System.Reflection.MetadataLoadContext (#1943)
* Nullable annotate System.Reflection.MetadataLoadContext
* address feedback
* address feedback
* undo accidental change
* address more feedback
Vladimir Sadov [Wed, 29 Jan 2020 14:18:25 +0000 (06:18 -0800)]
Refactor handling of non-SOH generations (#1688)
* refactoring
* ploh-->uoh
* fix Linux build
PR feedback
* some PR feedback
* more PR feedback
more PR feedback
* more PR feedback
* address comments in UpdatePreGCCounters
* removed a confusing comment
* stress fix in background sweep
* use `saved_sweep_ephemeral_seg` in background sweep.
* fixed `GCPerHeapHistory_V3` event.
* re-implemented https://github.com/dotnet/runtime/pull/2103 on top of refactoring (it was hard to merge)
Michal Strehovský [Wed, 29 Jan 2020 13:06:11 +0000 (14:06 +0100)]
Construct TypedReference on top of ByReference (#2216)
CoreCLR and Crossgen2 need to special case TypedReference because it's not a regular byref-like type (constructed on top of `ByReference<T>` fields). This gets rid of the special casing.
Viktor Hofer [Wed, 29 Jan 2020 10:01:49 +0000 (11:01 +0100)]
Use different artifact name for Mono vs CoreCLR (#2292)
Currently during a build-job, we overwrite existing artifacts as CoreCLR
and Mono use the same artifact name. Adding the runtime flavor name as
a differentiator.
Michal Strehovský [Wed, 29 Jan 2020 09:34:25 +0000 (10:34 +0100)]
Emit Partial/PlatformNeutralSource flags in R2R header (#2282)
I added the partial flag to the legacy crossgen in dotnet/coreclr#22680 but crossgen2 was missing it. Also added platform neutral source since it's easy.
Michal Strehovský [Wed, 29 Jan 2020 09:30:39 +0000 (10:30 +0100)]
Delete dead code in Crossgen's Program.cs (#2304)
* We don't need a workaround for a desktop framework bug since we don't have an ambition to run on desktop framework anymore.
* We don't need the entrypoint module.
Andy Ayers [Wed, 29 Jan 2020 08:47:56 +0000 (00:47 -0800)]
Enable inline type checks for all type equality cases (#2276)
Now that method tables are not shared by distinct types, we can always emit
inlined type equality tests.
Closes #1258.
monojenkins [Wed, 29 Jan 2020 08:05:00 +0000 (03:05 -0500)]
[interp] Fix virtual calls in mixed mode (#2299)
Alternative to https://github.com/mono/mono/pull/18475 which doesn't ignore mixed mode virtual call performance. It is 20% faster with this approach.
Fixes https://github.com/mono/mono/issues/14206
Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
Anirudh Agnihotry [Wed, 29 Jan 2020 06:36:54 +0000 (22:36 -0800)]
Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 (#2264)
* deadending Microsoft.Csharp Package and bumping the assembly versions
* retargeting and clean up
* Update Microsoft.CSharp.csproj
* fixing the build
* reference -> projectreference
* adding ignored reference
Koundinya Veluri [Wed, 29 Jan 2020 03:05:08 +0000 (19:05 -0800)]
Revert "Disable test based on #129 (#130)" (#2310)
This reverts commit
3a2dc0f8429b922fa254a1ba6f751b79259275b1.
Fixed by https://github.com/dotnet/runtime/pull/1457. Closes https://github.com/dotnet/runtime/issues/129.
Stephen Toub [Wed, 29 Jan 2020 02:17:53 +0000 (21:17 -0500)]
Add support for multiple char classes in FindFirstChars (#2254)
* Add a "multi first" check for FindFirstChars
FindFirstChars already has multiple things it checks for:
- If the expression is anchored, it checks the current position for that anchor.
- If we were able to compute a min required length, it checks for that much space remaining.
- If we were able to analyze the expression and come up with a string of text of multiple characters that must be at the beginning of any expression, we use Boyer-Moore to find it.
- If we were able to analyze the expression to come up with a character class that must match the first character in the input, we iterate through looking for that (and if possible, use IndexOf{Any} to speed that along).
This PR extends that last check to try to create a character class not just for the first character in the input, but for the first N characters in the input. The check isn't as robust, mainly focused on expressions beginning with an alternation (often when it's global), so it's a separate check we try first, and only fall back to the more robust single-class analysis if we were unsuccessful.
By checking multiple characters, we're able to stay in a tighter loop inside of FindFirstChars. In the future, we could look at replacing this with something potentially even better, such as a vectorized search for multiple starting strings.
* Address PR feedback
Alexander Köplinger [Wed, 29 Jan 2020 02:12:47 +0000 (03:12 +0100)]
Disable System.Net.* tests on Mono that are also disabled on CoreCLR (#2318)
Should help with https://github.com/dotnet/runtime/issues/2316
Steve MacLean [Wed, 29 Jan 2020 01:49:43 +0000 (20:49 -0500)]
Remove format.patch (#2323)
Thies file was added accidentally as part of #1735
Santiago Fernandez Madero [Wed, 29 Jan 2020 01:01:36 +0000 (17:01 -0800)]
Move libraries internal restore before repo restore, produce a restore binlog and increase verbosity (#2311)
* Move libraries internal restore before repo restore, produce a restore binlog and increase verbosity
* Use SDK from global.json
Davis Goodin [Wed, 29 Jan 2020 00:24:24 +0000 (18:24 -0600)]
Add build skip functionality for servicing builds (#2291)
Andy Ayers [Wed, 29 Jan 2020 00:01:09 +0000 (16:01 -0800)]
JIT: remove inlining restriction for some methods that throw (#2232)
We were blocking inlines for methods that throw with more than one thing on the
evaluation stack. There was already logic for the non-inlining case to flush
the stack and preserve pending side effects. So we can simply remove the
inlining restriction.
Fixes #2156.
Koundinya Veluri [Tue, 28 Jan 2020 22:19:27 +0000 (14:19 -0800)]
Improve call counting mechanism (#1457)
Improve call counting mechanism
- Call counting through the prestub is fairly expensive and can be seen immediately after call counting begins
- Added call counting stubs. When starting call counting for a method:
- A `CallCountingInfo` is created and initializes a remaining call count with a threshold
- A `CallCountingStub` is created. It contains a small amount of code that decrements the remaining call count and checks for zero. When nonzero, it jumps to the code version's native code entry point. When zero, it forwards to a helper function that handles tier promotion.
- When the call count threshold is reached, the helper call enqueues completion of call counting for background processing
- When completing call counting, the code version is enqueued for promotion, and the call counting stub is removed from the call chain
- Once all work queued for promotion is completed and methods transitioned to optimized tier, call counting stubs are deleted based on some heuristics and under runtime suspension
- The `CallCountingManager` is the main class with most of the logic. Its private subclasses are just simple data structures.
- Call counting is done at a `NativeCodeVersion` level (stub association is with the code version)
- The code versioning lock is used for data structures used for call counting. Since installing a call counting stub requires that we know what the currently active code version is, it made sense to use the same lock.
- Call counting stubs have hardcoded code. x64 has short and long stubs, short stubs are used when possible (often) and use IP-relative branches to the method's code and helper stub. Other platforms have only one type of stub (a short stub).
- For tiered methods that don't have a precode (virtual and interface methods), a forwarder stub (a precode) is created and it forwards to the call counting stub. This is so that the call counting stub can be safely and easily deleted. The forwarder stubs are only used when counting calls, there is one per method (not per code version), and they are not deleted. See `CallCountingManager::SetCodeEntryPoint()` for more info.
- The `OnCallCountThresholdReachedStub()` takes a "stub-identifying token". The helper call gets a stub address from it, and tells whether it's a short or long stub. From the stub, the remaining call count pointer is used to get the `CallCountingInfo`, and from it gets the `NativeCodeVersion` associated with the stub.
- The `CallCountingStubManager` traces through a call counting stub so that VS-like debuggers can step into a method through the call counting stub
- Exceptions (OOM)
- On foreground threads, exceptions are propagated unless they can be handled without any compromise
- On background threads, exceptions are caught and logged as before. Tried to limit scope of exception to one per method or code version such that a loop over many would not all be aborted by one exception.
- Fixed a latent race where a method is recorded for call counting and then the method's code entry point is set to tier 0 code
- With that order, the tiering delay may expire and the method's entry point may be updated for call counting in the background before the code entry point is set by the recording thread, and that last action would disable call counting for the method and cause it to not be optimized. The only thing protecting from this happening was the delay itself, but a configured shorter delay increases the possibility of this happening.
- Inverted the order such that the method's code entry point is set before recording it for call counting, both on first and subsequent calls
- Changed the tiered compilation lock to be an any-GC-mode lock so that it can be taken inside the code versioning lock, as some things were more naturally placed inside the code versioning lock where we know the active code version, like checking for the tiering delay to delay call counting and promoting the code version when the call count threshold is reached
- Unfortunately, that makes code inside the lock a GC-no-trigger scope and things like scheduling a timer or queuing a work item to the thread pool could not be done inside that scope. This tradeoff seems to be better than alternatives, so refactored those pieces to occur outside that scope.
- Publishing an entry point after changing the active code version now takes call counting into account, fixes https://github.com/dotnet/coreclr/issues/22426
- After the changes:
- Call counting overhead is much smaller and is not many orders of magnitude greater than a method call
- Some config modes for tuning tiering are now much more reasonable and do not affect perf negatively nearly as much as before - increasing call count threshold, disabling or decreasing the tiering delay. Enables dynamic thresholds in the future, which is not feasible due to the overhead currently.
- No change to startup or steady-state perf
- Left for later
- Eventing work to report call counting stub code ranges and method name (also needs to be done for other stubs)
- Some tests that consume events to verify run-time behavior in a few config modes
- Debugger test to verify debugging while call-counting. Debugger tests also need to be fixed for tiering.
- The call count threshold has not been changed for now. As we don't have many tests that measure the performance in-between startup and steady-state, some will need to be created maybe from existing tests, to determine the effects
- Fixes https://github.com/dotnet/coreclr/issues/23596
Next Turn [Tue, 28 Jan 2020 22:03:24 +0000 (06:03 +0800)]
Use process_vm_readv to read remote memory when available on createdump
Elinor Fung [Tue, 28 Jan 2020 21:28:59 +0000 (13:28 -0800)]
Include error details when stream can't be opened for parsing in host (#2287)
Santiago Fernandez Madero [Tue, 28 Jan 2020 18:54:52 +0000 (10:54 -0800)]
Remove workaround for Build.SourcesDirectory variable in containers (#2261)
Ben Adams [Tue, 28 Jan 2020 18:44:36 +0000 (18:44 +0000)]
Make string._stringLength readonly (#2001)
buyaa-n [Tue, 28 Jan 2020 18:42:23 +0000 (10:42 -0800)]
Annotate System.Security.AccessControl for nullable (#1992)
* Annotate System.Security.AccessControl for nullable
Tom Deseyn [Tue, 28 Jan 2020 18:38:50 +0000 (19:38 +0100)]
SmtpClientTest: re-enable TestZeroTimeout (#2085)
Jan Jahoda [Tue, 28 Jan 2020 18:37:41 +0000 (19:37 +0100)]
Remove "ActiveIssue" attribute from test (#2146)
Johonis [Tue, 28 Jan 2020 18:28:04 +0000 (19:28 +0100)]
Update SerialPort.Linux.cs (#2009)
* Update SerialPort.Linux.cs
add ttyGSX devices to supported devices
* Apply suggestions from code review
Entry can only be ttyGSx. when its not ttySx
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
* Update SerialPort.Linux.cs
ttyGSx creates a file in "/sys/class/tty/ttyGS0" named "dev" - use this file as an additional check
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Stephen Toub [Tue, 28 Jan 2020 18:17:54 +0000 (13:17 -0500)]
Add more diagnostics to DroppedIncompleteStateMachine_RaisesIncompleteAsyncMethodEvent test (#2283)
Stephen Toub [Tue, 28 Jan 2020 18:16:30 +0000 (13:16 -0500)]
Disable HttpListener test on Mono (#2285)
Santiago Fernandez Madero [Tue, 28 Jan 2020 18:01:36 +0000 (10:01 -0800)]
Attempt to fix restore internal tools (#2255)
* Force re-install of nuget authenticator
* Update dotnet tools to latest daily build
* Remove AddUntrackedResourcesForSourceLink workaround for sourcelink
mikedn [Tue, 28 Jan 2020 16:44:59 +0000 (18:44 +0200)]
Prevent LocalAddressVisitor from morphing x86 vararg params (#2157)
fgMorphStackArgForVarArgs has no support for local address node nor LCL_FLD nodes.
John Tur [Tue, 28 Jan 2020 13:46:57 +0000 (09:46 -0400)]
Use HashCode.Add rather than HashCode.Combine (#2200)
Michal Strehovský [Tue, 28 Jan 2020 13:22:04 +0000 (14:22 +0100)]
Merge ReadyToRunCodegenNodeFactory into NodeFactory (#2277)
This split existed because of a failed attempt to share too much of crossgen2 with the full AOT compiler. Now that we're sharing source files instead of entire assemblies, ILCompiler.ReadyToRun is free to claim the NodeFactory name.
Andy Ayers [Tue, 28 Jan 2020 06:41:17 +0000 (22:41 -0800)]
JIT: emit gc updates from RRR instruction forms (#2197)
These do not produce GC refs, so make sure we end any GC liveness for the
destination register.
Also, make sure all gc stress modes announce themselves in the jit dump log.
Fixes #2186.
Charles Stoner [Tue, 28 Jan 2020 06:37:41 +0000 (22:37 -0800)]
Port Microsoft.VisualBasic.CompilerServices.Utils.GetResourceString() (#1911)
Dong-Heon Jung [Tue, 28 Jan 2020 03:01:30 +0000 (12:01 +0900)]
Convert AssemblyNative::Load to QCall (#1929)
* Convert AssemblyNative::Load to QCall
- FCall uses libunwind to find Method description.
- Get rid of the libunwind overhead in AssemblyNative::Load
by converting to QCall
* Add workaround for https://github.com/dotnet/runtime/issues/2240
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Jan Kotas [Tue, 28 Jan 2020 02:57:55 +0000 (18:57 -0800)]
Fix incorrect BAD_FORMAT_NOTHROW_ASSERTs in casting (#2237)
Andrew Au [Tue, 28 Jan 2020 02:08:00 +0000 (18:08 -0800)]
Allow allocating large object from free list while background sweeping SOH (#2103)
Steve MacLean [Tue, 28 Jan 2020 01:11:15 +0000 (20:11 -0500)]
Fix compilation of dbgtransportsession (#2247)
Fix unused variable warnings when RIGHT_SIDE_COMPILE is not defined
Steve MacLean [Tue, 28 Jan 2020 01:10:36 +0000 (20:10 -0500)]
Add FEATURE_REMOTE_PROC_MEM (#2244)
The /proc/mem filesystem is only available on Linux hosts. Revise #ifdef
to use FEATURE_PROC_MEM to enable disable the use of /proc/mem on the
debug target shim. Enable only when HOST and target are Unix, but not
Darwin.
Ganbarukamo41 [Tue, 28 Jan 2020 01:09:20 +0000 (10:09 +0900)]
Fix local test failures for System.Xml.Xsl.XslTransformApi.Tests & Rename old build variable in csproj (#1268)
The only failure in coreclr is not related to this change, merging it.
Thank you for your contribution @Gnbrkm41
Santiago Fernandez Madero [Tue, 28 Jan 2020 00:47:19 +0000 (16:47 -0800)]
Merge pull request #2260 from dotnet/BatchCoreclrCi
Batch CI builds for PRI2 testing of CoreCLR
Santiago Fernandez Madero [Tue, 28 Jan 2020 00:15:05 +0000 (16:15 -0800)]
Batch CI builds for PRI2 testing of CoreCLR
Andrew Au [Mon, 27 Jan 2020 22:21:56 +0000 (14:21 -0800)]
Make sure R2RDump write to console in case --out is not specified (#2239)
Anirudh Agnihotry [Mon, 27 Jan 2020 22:05:28 +0000 (14:05 -0800)]
Updating the IL.Sdk package to latest (#2235)
* using the latest il sdk package
* correcting the package version
* updating il.sdk version in versions.props as well
Tomáš Rylek [Mon, 27 Jan 2020 22:04:44 +0000 (23:04 +0100)]
Fix concurrency issues in the regression test b426654 (#2211)
After fixing the interruptible ranges by aligning intrinsics
inlined by Crossgen1 / 2 I have verified that the concurrency and
rooting fixes suggested by Kount finally fix the Crossgen2 build
of the test. I have made the following changes:
1) I have shortened the test to 5 seconds and I changed the add
instruction to xor so that the test cannot randomly start
overflowing again on some future faster HW.
2) I have changed the synchronization static s_timeUp to a volatile.
This probably doesn't matter on Intel but will most likely matter
a lot on ARM.
3) I have added a call to Dispose for the timeout timer to make
sure it remains rooted for the duration of the test.
Thanks
Tomas
Jan Vorlicek [Mon, 27 Jan 2020 20:42:34 +0000 (21:42 +0100)]
Crossgen2 - precompile generic instantiations (#2154)
* Crossgen2 - precompile generic instantiations
This change adds precompilation of all methods on generic instantiations
of types that are encountered during compilation. In my powershell
startup time experiments, it shaved off about 110 methods from the ones
that needed to be jitted at runtime and looking at e.g.
System.Private.CoreLib.dll precompilation result, it is much closer to
the version we get from the old crossgen now.
* Create a new node type to carry the method dependecies
Santiago Fernandez Madero [Mon, 27 Jan 2020 20:13:14 +0000 (12:13 -0800)]
Remove workarounds in build scripts for netcoreapp and netfx versionless (#1841)
* Remove workarounds in build scripts for netcoreapp and netfx versionless
* Don't pass down netcoreapp in yml builds
* PR Feedback and condition passing -framework arg when not empty in yml files
* Condition TargetGroup global property in helix.yml
* PR Feedback to not use targetgroup for allconfigurations in sendtohelix
* Change from PackageTesting to BuildAllConfigurations
Santiago Fernandez Madero [Mon, 27 Jan 2020 20:12:51 +0000 (12:12 -0800)]
Move official builds to OSX 10.14 pool (#2159)
* Move official builds to OSX 10.14 pool
* Use vmImage instead
Eugene Rozenfeld [Mon, 27 Jan 2020 20:03:06 +0000 (12:03 -0800)]
Fix method and basic block flags used by early opts. (#2126)
Fix method and basic block flags used by early opts.
Add missing BBF_HAS_NULLCHECK in loop test transformation.
This change had no diffs in frameworks and benchmark.
Add missing OMF_HAS_ARRAYREF and BBF_HAS_IDX_LEN in many places.
This change had diffs in frameworks and benchmark since the optimization
replacing GT_ARRLENGTH with a constant fires much more often.
Fix inlining to not lose basic block flags when the inlinee basic block
has a ret expr but no statements.
Change propGetType condition in optDoEarlyPropForFunc to check for OMF_HAS_NEWARRAY
in addition to OMF_HAS_NEWOBJ.
Check that methods and basic blocks that have calls to object allocation
helpers have OMF_HAS_NEWOBJ and BBF_HAS_NEWOBJ set.
Check that methods and basic blocks that have calls to array allocation
helpers have OMF_HAS_NEWARRAY and BBF_HAS_NEWARRAY set.
Check that methods and basic blocks that have GT_NULLCHECK nodes
helpers have OMF_HAS_NULLCHECK and BBF_HAS_NULLCHECK set.
Check that methods and basic blocks that access MethodTable
via GT_IND on a ref have OMF_HAS_VTABLEREF and BBF_HAS_VTABLEREF set.
Check that methods and basic blocks that have GT_ARRLENGTH
have OMF_HAS_ARRAYREF and BBF_HAS_IDX_LEN set.
Fix fgOptWhileLoop that could lose BBF_HAS_NEWOBJ and BBF_HAS_NEWARRAY.
Add asserts to make sure we don't have diverging codegen
in debug/checked/release because of early opts.
Add BBF_HAS_VTABREF to BBF_COMPACT_UPD and BBF_SPLIT_GAINED.
Stephen Toub [Mon, 27 Jan 2020 19:56:04 +0000 (14:56 -0500)]
Factor common prefix text out of Regex alternations (#2171)
* Factor common prefix text out of Regex alternations
Given a regex like "this|that|there", we will now factor out the common prefix into a new node concatenated with the alternation, e.g. "th(?:is|at|ere)". This has a few benefits, including exposing more text to FindFirstChar if this is at the beginning of the sequence, reducing backtracking, and enabling further reduction/optimization opportunities in the alternation.
* Address PR feedback
* Update RegexBoyerMoore.cs
Günther Foidl [Mon, 27 Jan 2020 19:18:14 +0000 (20:18 +0100)]
Fixed Base64 EncodeToUtf8 / DecodeFromUtf8 return states (Done | NeedMoreData) (#281)
Jan Kotas [Mon, 27 Jan 2020 19:04:23 +0000 (11:04 -0800)]
Delete unused code related to ExtensibleClassFactory (#2224)
Brian Sullivan [Mon, 27 Jan 2020 19:01:25 +0000 (11:01 -0800)]
Fix for IlAsm round-trip issue #803 (#2168)
Remove the unnecessary assignment m_pCustomDescrList = NULL;
from the method RecordTypeConstraints that was added with my original fix.
Stephen Toub [Mon, 27 Jan 2020 18:29:52 +0000 (13:29 -0500)]
Delete dead ctor in RegexParseException (#2229)
It'll never be used because the exception gets serialized as its base type and thus is never deserialized.
monojenkins [Mon, 27 Jan 2020 18:25:00 +0000 (13:25 -0500)]
[utils] Default to g_print in mono_counters_dump if the stream is NULL (#2178)
This makes `mono_counters_dump` actually work on Android. If either this added default behavior or the macro is too terrible I can explore other options, but I'm tired and this was fast.
Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
Zoltan Varga [Mon, 27 Jan 2020 18:11:29 +0000 (13:11 -0500)]
[mono-corelib] Embed linker descriptor. (#2141)
Import illink.targets correctly for Mono System.Private.CoreLib.
This causes an issue when running tests so disable trimming for now.
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Stephen Toub [Mon, 27 Jan 2020 17:43:12 +0000 (12:43 -0500)]
Avoid large switch in compiled FindFirstChar (#2169)
* Avoid large switch in compiled FindFirstChar
Rather than branching for each value, we can get the value from a lookup table.
* Address PR feedback
Along with some additional style cleanup while addressing that feedback.
Eric StJohn [Mon, 27 Jan 2020 17:08:35 +0000 (09:08 -0800)]
Use latest System.Memory for ns2.0 refs (#2112)
monojenkins [Mon, 27 Jan 2020 16:59:33 +0000 (11:59 -0500)]
[runtime] Miscellaneous printf cleanup (#2177)
Done to unblock the externs. More work should probably be done, see mono/mono#18580.
Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
Steve Pfister [Mon, 27 Jan 2020 16:11:32 +0000 (11:11 -0500)]
Remove obsolete files from mono netcore. (#2223)
Since we moved to dotnet/runtime, they are no longer needed.
monojenkins [Mon, 27 Jan 2020 15:56:03 +0000 (10:56 -0500)]
Update locale tables - add Tatar CLDR files tt.xml and tt_RU.xml (#2219)
Fixes mono/mono#18524
The `tt.xml` and `tt_RU.xml` files were added in CLDR 34: http://cldr.unicode.org/index/downloads/cldr-34
Upgrading to v34 (or the latest v36) introduced a larger number of new cultures. I went with the smallest change possible to have Tatar added.
I wasn't sure if this warranted a test in `CultureInfoTest.cs`, let me know if that would be required and I am happy to add.
Co-authored-by: Adrian <adrianluisgonzalez@gmail.com>
Marek Safar [Mon, 27 Jan 2020 14:46:23 +0000 (15:46 +0100)]
Add pull requests guide doc (#2145)
* Add pull requests guide doc
Co-Authored-By: Ryan Lucia <ryan@luciaonline.net>
Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Michal Strehovský [Mon, 27 Jan 2020 14:11:42 +0000 (15:11 +0100)]
Delete AvailableType/ExternalTypeNode (#2218)
These nodes didn't do anything.
Michal Strehovský [Mon, 27 Jan 2020 14:01:30 +0000 (15:01 +0100)]
Delete orphaned file (#2217)
Became orphaned in #172.
Tomáš Rylek [Mon, 27 Jan 2020 13:04:51 +0000 (14:04 +0100)]
Minor R2RDump facelift w.r.t. diffing dump (#2184)
Based on offline chat with JanV I added initial provisions to simplify
diffing Crossgen1- and 2-compiled SPC. In essence, the --diff option
newly ends up emitting two extra files with the ".r2rdump" extension
representing the methods common to the left and right R2R file. This
is formerly untrodden territory, I'm pioneering R2RDump usability for
this purpose.
Thanks
Tomas
Marie Píchová [Mon, 27 Jan 2020 10:54:22 +0000 (11:54 +0100)]
Config for CredScan suppresions (#2212)
monojenkins [Mon, 27 Jan 2020 10:21:29 +0000 (05:21 -0500)]
Fix for -mminimal-toc detection, enable BTLS on FreeBSD PowerPC (#2175)
Fixes mono/mono#18554 by making autoconf actually check if `-mminimal-toc` works instead of assuming on powerpc. Tested with FreeBSD 12.x and 13.x on powerpc64 ELFv2.
While we are in here, also enable BTLS which has passed testing.
Co-authored-by: Phil Jaenke <prj@rootwyrm.com>
monojenkins [Mon, 27 Jan 2020 10:19:26 +0000 (05:19 -0500)]
Allow passing IntPtr values with UnmanagedType.AsAny. (#2039)
This is used by the SplashScreen class of WindowsBase in .NET Core to pass a NULL pointer.
Co-authored-by: Vincent Povirk <madewokherd@gmail.com>
Alexis Christoforides [Mon, 27 Jan 2020 10:13:32 +0000 (05:13 -0500)]
[mono-corelib] Throw exception on an invalid use of short form opcodes for locals. (#2201)
Cory Nelson [Mon, 27 Jan 2020 07:50:54 +0000 (23:50 -0800)]
Add HTTP/3 draft 25 support. (#1294)
Jan Kotas [Mon, 27 Jan 2020 02:24:51 +0000 (18:24 -0800)]
Unify remaining CoreLib interop files (#2203)
Fixes #1232
Zoltan Varga [Sun, 26 Jan 2020 19:31:17 +0000 (14:31 -0500)]
Merge pull request #2206 from vargaz/disable-lldb
[runtime] Disable lldb backtrace display on osx, it hangs on attaching in lldb.
Michal Strehovský [Sun, 26 Jan 2020 17:52:08 +0000 (18:52 +0100)]
Make JIT configuration a single-init static (#2208)
This fixes two things:
* UseJitPath on compilation builder doesn't make sense for any other backends this file is shared with (CppCodegen/LLVM). Moving that to ReadyToRunCodenCompilationBuilder.
* JitConfigProvider made it look like a configurable JIT path and configurable COMPlus RyuJIT options are a thing, but they're in fact per process and can only be initialized once (first is an implementation limitation in CorInfoImpl, the second is a RyuJIT limitation). Making the config class static+throwing for double-initialization to make this very clear.
Zoltan Varga [Sun, 26 Jan 2020 13:22:05 +0000 (08:22 -0500)]
[runtime] Disable lldb backtrace display on osx, it hangs on attaching in lldb.
Thays Grazia [Sun, 26 Jan 2020 02:59:45 +0000 (23:59 -0300)]
Merge pull request #2079 from monojenkins/sync-pr-18537-from-mono
[debugger] Access invalid memory address using PointerValue Command.
thaystg [Sun, 26 Jan 2020 00:23:38 +0000 (00:23 +0000)]
[debugger] Access invalid memory address using PointerValue Command.
Creating a fork process to access address that came from IDE using PointerValue. The IDE can send an invalid address and it was crashing mono.
Fixes mono/mono#18191
Jan Kotas [Sat, 25 Jan 2020 23:56:23 +0000 (15:56 -0800)]
CPU utilization computation fixes (#2196)
* CPU utilization computation fixes
- On Unix, move scalling for total number of processors from PAL to managed side, so that it can use container limit aware ProcessorCount
- Delete asserts for CPU utilization being between 0 and 100. These asserts can fail due to races or rounding errors.
- Converted a few classes to structs
Fixes #2195
* Fix buildbreak
monojenkins [Sat, 25 Jan 2020 18:55:53 +0000 (13:55 -0500)]
Fix typos (#2179)
Co-authored-by: Maher Jendoubi <maher.jendoubi@gmail.com>
Stephen Toub [Sat, 25 Jan 2020 18:29:32 +0000 (13:29 -0500)]
Reduce execution time of RegexCharacterSetTests (#2194)
I recently wrote a large, exhaustive set of tests to validate our handling of regex character sets. Unfortunately it ends up being too much for our CI system. We were validating ~440 different character sets, for both RegexOptions.None and RegexOptions.Compiled, and for each validating all 65,536 character inputs... that's ~58M regex matches. In most cases locally it was taking around 15s, but on a loaded, underwhelming CI machine, it was taking minutes in some cases.
I've reduced the load (primarily by only validating the specified characters that should be included or excluded in cases where we're already testing both the positive and negative variants of the same set), while trying to keep a reasonable semblence of the coverage.
I also made it outerloop, and moved a few other longer-running regex tests to outerloop as well.
Kevin Jones [Sat, 25 Jan 2020 18:00:12 +0000 (13:00 -0500)]
Initialize HashSizeValue for digest algorithms.
The abstract types SHAx and MD5 did not set HashSizeValue, which
would lead to derived types to have HashSize a value of 0. This
initializes the field to match .NET Framework behavior.
Zoltan Varga [Sat, 25 Jan 2020 14:20:20 +0000 (09:20 -0500)]
Merge pull request #2081 from monojenkins/sync-pr-18552-from-mono
[jit] Compute has_references correctly for gshared types whose constraint is a generic valuetype.