platform/upstream/dotnet/runtime.git
7 years agoAdd System.ServiceModel.Syndication owners
Karel Zikmund [Tue, 26 Sep 2017 19:28:25 +0000 (12:28 -0700)]
Add System.ServiceModel.Syndication owners

Commit migrated from https://github.com/dotnet/corefx/commit/9588da150eac4f552a8c62a0cf45bda511d997fa

7 years agoAdd System.ServiceModel.Syndication
Karel Zikmund [Tue, 26 Sep 2017 19:25:06 +0000 (12:25 -0700)]
Add System.ServiceModel.Syndication

Commit migrated from https://github.com/dotnet/corefx/commit/afa7ed8e6732b328d80cbf97c3b28efd4173440c

7 years agoMerge pull request dotnet/corefx#24262 from MattGal/Conditional_Plugin_install
Matt Galbraith [Tue, 26 Sep 2017 19:08:57 +0000 (12:08 -0700)]
Merge pull request dotnet/corefx#24262 from MattGal/Conditional_Plugin_install

Temporarily hard-code signType to 'real' to unblock plugin installation step

Commit migrated from https://github.com/dotnet/corefx/commit/771053ef0bb4388ff9074230b23d6ec648c16e4c

7 years agoTemporarily hard-code signType to 'real' to unblock this step since Pipebuild does...
Matt Galbraith [Tue, 26 Sep 2017 19:04:56 +0000 (12:04 -0700)]
Temporarily hard-code signType to 'real' to unblock this step since Pipebuild does not understand conditional build step logic.

Commit migrated from https://github.com/dotnet/corefx/commit/a430af72c029bb8109e4259831847a195a1bb486

7 years agoMerge pull request dotnet/corefx#24261 from MattGal/Conditional_Plugin_install
Matt Galbraith [Tue, 26 Sep 2017 18:13:54 +0000 (11:13 -0700)]
Merge pull request dotnet/corefx#24261 from MattGal/Conditional_Plugin_install

Use conditional execution for signing plugin (does not support OSS).

Commit migrated from https://github.com/dotnet/corefx/commit/39c65a488f1200b36bdb29f17f77296917f4c295

7 years agoUse conditional execution for signing plugin (does not support OSS).
Matt Galbraith [Tue, 26 Sep 2017 18:09:09 +0000 (11:09 -0700)]
Use conditional execution for signing plugin (does not support OSS).

See https://docs.microsoft.com/en-us/vsts/build-release/concepts/process/conditions

Commit migrated from https://github.com/dotnet/corefx/commit/c1cc15b958c17263bde0847957d6b98c105eaa47

7 years agoMerge pull request dotnet/corefx#24258 from MattGal/reenable_publish
Matt Galbraith [Tue, 26 Sep 2017 17:07:51 +0000 (10:07 -0700)]
Merge pull request dotnet/corefx#24258 from MattGal/reenable_publish

Renable some publish scenarios

Commit migrated from https://github.com/dotnet/corefx/commit/bbea46f9ea09c8724e589a99b122bb01916221b1

7 years agoRenable some publish scenarios
Matt Galbraith [Tue, 26 Sep 2017 17:02:02 +0000 (10:02 -0700)]
Renable some publish scenarios

Commit migrated from https://github.com/dotnet/corefx/commit/38f2f234594dc86bbb5cae7de441fe99ea5f9b3e

7 years agoMake ConnectHelper.ConnectAsync return ValueTask<Stream> (dotnet/corefx#24244)
Stephen Toub [Tue, 26 Sep 2017 14:30:44 +0000 (10:30 -0400)]
Make ConnectHelper.ConnectAsync return ValueTask<Stream> (dotnet/corefx#24244)

Minor optimization via playing a bit better perf-wise with changes being made in coreclr.

Commit migrated from https://github.com/dotnet/corefx/commit/c45e6b3d58af63299aea992848370fced532c6e8

7 years agoFix some missing ConfigureAwaits in ManagedHandler (dotnet/corefx#24248)
Stephen Toub [Tue, 26 Sep 2017 14:30:13 +0000 (10:30 -0400)]
Fix some missing ConfigureAwaits in ManagedHandler (dotnet/corefx#24248)

Commit migrated from https://github.com/dotnet/corefx/commit/2f981c6efcd00b4ecee5309697ef07d58605993a

7 years agoDisable RecursiveDelete_DeepNesting (Issue dotnet/corefx#24242). (dotnet/corefx#24243)
Eric Mellino [Tue, 26 Sep 2017 03:12:23 +0000 (20:12 -0700)]
Disable RecursiveDelete_DeepNesting (Issue dotnet/corefx#24242). (dotnet/corefx#24243)

Commit migrated from https://github.com/dotnet/corefx/commit/6cee65c560f1b853f67c7871345c0feacd95a070

7 years agoMerge pull request dotnet/corefx#24238 from hughbe/matrix-same-multiply
Eric Mellino [Tue, 26 Sep 2017 00:01:51 +0000 (17:01 -0700)]
Merge pull request dotnet/corefx#24238 from hughbe/matrix-same-multiply

Fix multiplying a matrix by the same matrix

Commit migrated from https://github.com/dotnet/corefx/commit/634f767771b7c1946d7b10aeb77dbbc0ccb9f622

7 years agoBigInteger based random testing of System.Decimal (dotnet/corefx#24053)
Pent Ploompuu [Mon, 25 Sep 2017 22:36:29 +0000 (01:36 +0300)]
BigInteger based random testing of System.Decimal (dotnet/corefx#24053)

* BigInteger based random testing of Decimal

* Comments for random testing of Decimal

* Parallelize random testing of Decimal

* Simplified BigDecimal.Div for Decimal tests

Commit migrated from https://github.com/dotnet/corefx/commit/d23561261a8c98a9b1f9c46838fae3ecfca31998

7 years agoMerge pull request dotnet/corefx#24218 from MattGal/Support_test_signing
Matt Galbraith [Mon, 25 Sep 2017 20:51:24 +0000 (13:51 -0700)]
Merge pull request dotnet/corefx#24218 from MattGal/Support_test_signing

Changes to propagate PB_SignType variable through the PipeBuild process (was always 'real' before)

Commit migrated from https://github.com/dotnet/corefx/commit/591c28432236eae28f132cd4e07b53f1a55c6ca7

7 years agoFix multiplying a matrix by the same matrix
Hugh Bellamy [Mon, 25 Sep 2017 20:11:52 +0000 (21:11 +0100)]
Fix multiplying a matrix by the same matrix

Commit migrated from https://github.com/dotnet/corefx/commit/cd7559c1e00d60853b542ea6d1737f56ce733b74

7 years agoChanges to actually propate PB_SignType through the PipeBuild process
Matt Galbraith [Fri, 22 Sep 2017 22:59:47 +0000 (15:59 -0700)]
Changes to actually propate PB_SignType through the PipeBuild process

Commit migrated from https://github.com/dotnet/corefx/commit/553c51c985ceaaf0897393ce20d1a8f3b13e2602

7 years agoApplying remaining code review comment from dotnet/corefx#24078 (dotnet/corefx#24237)
Maryam Ariyan [Mon, 25 Sep 2017 19:48:11 +0000 (15:48 -0400)]
Applying remaining code review comment from dotnet/corefx#24078 (dotnet/corefx#24237)

Commit migrated from https://github.com/dotnet/corefx/commit/b625ab61a7b5835ca32b5f2f257cc64eabb8029d

7 years agoUse Docker host's tools version for cleanup (dotnet/corefx#24235)
JC Aguilera [Mon, 25 Sep 2017 19:19:52 +0000 (12:19 -0700)]
Use Docker host's tools version for cleanup (dotnet/corefx#24235)

When doing Cleanup VSTS agent, we should use the tools in Docker host. For CentOS-6 using non-sand boxed tools failed with "Aborted (core dumped)". https://github.com/dotnet/core-eng/issues/1807

Commit migrated from https://github.com/dotnet/corefx/commit/e265052fa2ef0bee145e0a5281d6b18ce3cd966f

7 years agoSkipping ComponentModel failing test on netfx in CI (dotnet/corefx#24236)
Maryam Ariyan [Mon, 25 Sep 2017 19:01:55 +0000 (15:01 -0400)]
Skipping ComponentModel failing test on netfx in CI (dotnet/corefx#24236)

Fixes dotnet/corefx#24233

Commit migrated from https://github.com/dotnet/corefx/commit/18e7272babd6e72b418ae108deb7f2138367e95a

7 years agoMerge pull request dotnet/corefx#24195 from qmfrederik/fixes/metafiletests-x11
Eric Mellino [Mon, 25 Sep 2017 17:19:06 +0000 (10:19 -0700)]
Merge pull request dotnet/corefx#24195 from qmfrederik/fixes/metafiletests-x11

Don't depend on X11 in the MetafileTests

Commit migrated from https://github.com/dotnet/corefx/commit/c2b14b597ad855c159431f12cecf61f5331c9174

7 years agoUpdate Standard to preview1-25725-01 (dotnet/corefx#24231)
dotnet-maestro-bot [Mon, 25 Sep 2017 17:04:04 +0000 (12:04 -0500)]
Update Standard to preview1-25725-01 (dotnet/corefx#24231)

Commit migrated from https://github.com/dotnet/corefx/commit/65e31fc7c96f9aa2720f1cf60a72360c85bb6dd8

7 years agoUpdated link to HTTP Protocol proposal and minor fixes (dotnet/corefx#24216)
Alfred Myers [Mon, 25 Sep 2017 13:41:07 +0000 (10:41 -0300)]
Updated link to HTTP Protocol proposal and minor fixes (dotnet/corefx#24216)

Commit migrated from https://github.com/dotnet/corefx/commit/b3033e6bd586fb7bdc2e1afdd1694e790272ce6e

7 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-25725-00, beta-25725-00, respectively...
dotnet-maestro-bot [Mon, 25 Sep 2017 13:40:17 +0000 (08:40 -0500)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25725-00, beta-25725-00, respectively (dotnet/corefx#24230)

Commit migrated from https://github.com/dotnet/corefx/commit/a25a55f438160ea29602c157efbb262ca74070a3

7 years agoIPAddress: Change to faster algo to bigendian->littleendian flip of numbers (dotnet...
Tim Seaward [Sun, 24 Sep 2017 17:58:02 +0000 (18:58 +0100)]
IPAddress: Change to faster algo to bigendian->littleendian flip of numbers (dotnet/corefx#24224)

* Change to faster algo to bigendian->litteendian flip of numbers

* Added a better unit test for byte reversing

* Fixed the test number and made sure int and long are both tested

* Set test numbers to have different nibbles to ensure no flipping

Commit migrated from https://github.com/dotnet/corefx/commit/1f434a9665d666542497250a0b4e211ce20b40df

7 years agoUse stackalloc directly into Span (dotnet/corefx#24212)
Stephen Toub [Sun, 24 Sep 2017 13:45:07 +0000 (09:45 -0400)]
Use stackalloc directly into Span (dotnet/corefx#24212)

* Use stackalloc directly into Span

We have a few places in corefx where we were stackalloc'ing into a temporary pointer and then creating a Span from that.  Now that we're using a C# compiler which supports stackalloc'ing directly into span, use that feature instead.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/a7f6f470cb2c4cdaafdc3ad85e2520992a8db265

7 years agoExpose/test Guid.{Try}Parse{Exact} span-based methods (dotnet/corefx#24204)
Stephen Toub [Sat, 23 Sep 2017 14:32:21 +0000 (10:32 -0400)]
Expose/test Guid.{Try}Parse{Exact} span-based methods (dotnet/corefx#24204)

Just adds the methods to the refs and copies/updates the existing parsing tests to work with the new span-based methods.

Commit migrated from https://github.com/dotnet/corefx/commit/f25f97d837a33534f5a6e2f7da9c0989210d3f4c

7 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-25723-00, beta-25723-00, respectively...
dotnet-maestro-bot [Sat, 23 Sep 2017 06:35:11 +0000 (01:35 -0500)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25723-00, beta-25723-00, respectively (dotnet/corefx#24222)

Commit migrated from https://github.com/dotnet/corefx/commit/cb3a8bdb50dfc1a005b11cfe77669da9eb295c46

7 years agoSSLStream : Fixed spelling mistake in file name (extra a) (dotnet/corefx#24221)
Tim Seaward [Sat, 23 Sep 2017 03:55:27 +0000 (04:55 +0100)]
SSLStream : Fixed spelling mistake in file name (extra a) (dotnet/corefx#24221)

* Fixed spelling mistake in file name

* Fix csproj

Commit migrated from https://github.com/dotnet/corefx/commit/ae0502a88778bf055e5d59efc508c87a2b567216

7 years agoSsl Stream Async Write (dotnet/corefx#23715)
Tim Seaward [Sat, 23 Sep 2017 00:44:54 +0000 (01:44 +0100)]
Ssl Stream Async Write  (dotnet/corefx#23715)

* Change from APM to Async/Await for write side

* Added nameof

* Reacting to review

* Reacting to review

Commit migrated from https://github.com/dotnet/corefx/commit/680579331a336e1eeb2bbe0e3b4a5b42207666c7

7 years agoRemove stale SetStateMachine call in test
Stephen Toub [Sat, 23 Sep 2017 00:40:09 +0000 (20:40 -0400)]
Remove stale SetStateMachine call in test

Commit migrated from https://github.com/dotnet/corefx/commit/52bd372e160f9c1c9e84fb5345326da865ed6a12

7 years agoMerge pull request dotnet/corefx#24215 from janvorli/revert-mikem-llvm3.9
Jan Kotas [Sat, 23 Sep 2017 00:12:12 +0000 (17:12 -0700)]
Merge pull request dotnet/corefx#24215 from janvorli/revert-mikem-llvm3.9

Revert "Update build to clang/llvm 3.9 (dotnet/corefx#24177)"

Commit migrated from https://github.com/dotnet/corefx/commit/c1b7a0a4d600bd79a6bc84150c134519cccfd120

7 years agoRevert "Update build to clang/llvm 3.9 (dotnet/corefx#24177)"
Jan Vorlicek [Fri, 22 Sep 2017 22:35:01 +0000 (15:35 -0700)]
Revert "Update build to clang/llvm 3.9 (dotnet/corefx#24177)"

This reverts commit dotnet/corefx@21e008a3401a4d76ef5123df8f072e9f3c7823bb.

Commit migrated from https://github.com/dotnet/corefx/commit/092318d2e898b05581e6da1ef18e3521b5384302

7 years agoFix typo
Frederik Carlier [Fri, 22 Sep 2017 21:27:18 +0000 (23:27 +0200)]
Fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/9bff663a650c6e6f47db5581913a77f6dad35cd6

7 years agoMerge pull request dotnet/corefx#24202 from shmao/AddSyndication
Shin Mao [Fri, 22 Sep 2017 20:17:01 +0000 (13:17 -0700)]
Merge pull request dotnet/corefx#24202 from shmao/AddSyndication

Moving Microsoft.ServiceModel.Syndication from wcf to corefx.

Commit migrated from https://github.com/dotnet/corefx/commit/feb04e0219ad8c7aab795511f421934b8e731dab

7 years agoRemove the line that will copy the generated serializer to the pack. (dotnet/corefx...
Huangli Wu [Fri, 22 Sep 2017 17:19:42 +0000 (10:19 -0700)]
Remove the line that will copy the generated serializer to the pack. (dotnet/corefx#24199)

Commit migrated from https://github.com/dotnet/corefx/commit/93cd36bbe1102752087554bf2411b66cbe4bac72

7 years agoDisable two tests on Unix
Frederik Carlier [Fri, 22 Sep 2017 14:45:26 +0000 (16:45 +0200)]
Disable two tests on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/f62de76bf7b2ce2495a7707d618d81b64faa08ac

7 years agoUpdate ProjectNTfs, ProjectNTfsTestILC, Standard to beta-25722-00, beta-25722-00...
dotnet-maestro-bot [Fri, 22 Sep 2017 14:44:11 +0000 (09:44 -0500)]
Update ProjectNTfs, ProjectNTfsTestILC, Standard to beta-25722-00, beta-25722-00, preview1-25722-01, respectively (dotnet/corefx#24207)

Commit migrated from https://github.com/dotnet/corefx/commit/7f1a79ed43b35f28b18047774410676207aa54c0

7 years agoNope - filename can be invalid.
Frederik Carlier [Fri, 22 Sep 2017 14:06:01 +0000 (16:06 +0200)]
Nope - filename can be invalid.

Commit migrated from https://github.com/dotnet/corefx/commit/633b2b5d43377a10698939c5b1b452c552d331ad

7 years agoCheck for invalid filenames on Unix
Frederik Carlier [Fri, 22 Sep 2017 13:35:02 +0000 (15:35 +0200)]
Check for invalid filenames on Unix
Fix test

Commit migrated from https://github.com/dotnet/corefx/commit/6c7809ca6284ab51c74a88c8c6dc6ff1364a70f1

7 years agoUpdate build to clang/llvm 3.9 (dotnet/corefx#24177)
Mike McLaughlin [Fri, 22 Sep 2017 08:17:33 +0000 (01:17 -0700)]
Update build to clang/llvm 3.9 (dotnet/corefx#24177)

Update scripts, docs and build pipeline docker images to clang/llvm/lldb 3.9

Commit migrated from https://github.com/dotnet/corefx/commit/21e008a3401a4d76ef5123df8f072e9f3c7823bb

7 years agoDon't test for exceptions on long filenames on Unix (it doesn't matter there)
Frederik Carlier [Fri, 22 Sep 2017 06:46:44 +0000 (08:46 +0200)]
Don't test for exceptions on long filenames on Unix (it doesn't matter there)
Finetune Ctor_InvalidPathII_ThrowsArgumentException

Commit migrated from https://github.com/dotnet/corefx/commit/8e10bd0066854399eca0d8a53a281a7b0e7c8b94

7 years agoThrow an exception when the filename length > MAX_PATH
Frederik Carlier [Fri, 22 Sep 2017 06:46:12 +0000 (08:46 +0200)]
Throw an exception when the filename length > MAX_PATH

Commit migrated from https://github.com/dotnet/corefx/commit/926c12917fac0e7d6ec2ed1ff25dd5f03ad0665a

7 years agoMerge pull request dotnet/corefx#24173 from stephentoub/managedhandler_optin
Stephen Toub [Fri, 22 Sep 2017 03:14:57 +0000 (20:14 -0700)]
Merge pull request dotnet/corefx#24173 from stephentoub/managedhandler_optin

Provide an (at least temporary) non-global ManagedHandler opt-in mechanism

Commit migrated from https://github.com/dotnet/corefx/commit/1adc5b27283de6e9627e183ef24e0631ee7bab9a

7 years agoExpose/test String.Create span-based method (dotnet/corefx#23872)
Stephen Toub [Fri, 22 Sep 2017 02:35:33 +0000 (19:35 -0700)]
Expose/test String.Create span-based method (dotnet/corefx#23872)

* Expose/test String.Create span-based method

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8cc35f2e402b77fa666e1362696df735a9529027

7 years agoIncrease file descriptor limit in S.N.Http tests on macOS
Stephen Toub [Fri, 22 Sep 2017 01:31:49 +0000 (21:31 -0400)]
Increase file descriptor limit in S.N.Http tests on macOS

Commit migrated from https://github.com/dotnet/corefx/commit/2bce06e38f5c16ec6d6eed96a2c4410110fe5ec6

7 years agoMerge pull request dotnet/corefx#24187 from dotnet-maestro-bot/master-UpdateDependencies
Stephen Toub [Fri, 22 Sep 2017 00:26:07 +0000 (17:26 -0700)]
Merge pull request dotnet/corefx#24187 from dotnet-maestro-bot/master-UpdateDependencies

Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25720-03, preview1-25719-04, beta-25721-01, beta-25721-01, preview1-25721-01, respectively (master)

Commit migrated from https://github.com/dotnet/corefx/commit/6ae4ff347a28f80891c2a96f5d0455c54e45c804

7 years agoDisable Build of S.SM.Syndication.
Xing Mao [Thu, 21 Sep 2017 23:43:32 +0000 (16:43 -0700)]
Disable Build of S.SM.Syndication.

Commit migrated from https://github.com/dotnet/corefx/commit/e35e0cb7c8ea17ed654f5ec31c274ac314709464

7 years agoMerge pull request dotnet/corefx#24151 from qmfrederik/drawing/metafile-mono-tests
Eric Mellino [Thu, 21 Sep 2017 23:42:50 +0000 (16:42 -0700)]
Merge pull request dotnet/corefx#24151 from qmfrederik/drawing/metafile-mono-tests

Add unit tests for System.Drawing.Imaging.Metafile based on Mono's unit tests

Commit migrated from https://github.com/dotnet/corefx/commit/95f68c449ece32f30fa19f08c97c3d2fcff69d5c

7 years agoMerge branch 'lab' of C:\GitMV\wcf into AddSyndication
Xing Mao [Thu, 21 Sep 2017 23:41:34 +0000 (16:41 -0700)]
Merge branch 'lab' of C:\GitMV\wcf into AddSyndication

Commit migrated from https://github.com/dotnet/corefx/commit/01152591f9fa0ec29a4b1702843276ad1af1fa38

7 years agoMove Syndication to root/src
Xing Mao [Thu, 21 Sep 2017 23:36:46 +0000 (16:36 -0700)]
Move Syndication to root/src

Commit migrated from https://github.com/dotnet/corefx/commit/c7b485f7867f60055cba7c1d395581711f0a7077

7 years agoStreamline path validation
Frederik Carlier [Thu, 21 Sep 2017 22:05:40 +0000 (00:05 +0200)]
Streamline path validation

Commit migrated from https://github.com/dotnet/corefx/commit/0a39831efef20d7c2c71510b0b42a5ea3e7bfcdb

7 years agoTry to emulate NetFX exception behavior.
Frederik Carlier [Thu, 21 Sep 2017 13:59:22 +0000 (15:59 +0200)]
Try to emulate NetFX exception behavior.

Commit migrated from https://github.com/dotnet/corefx/commit/4649003222ca46b3e16df3524b470f154775325b

7 years agoWorkaround libgdiplus glitches
Frederik Carlier [Wed, 20 Sep 2017 21:28:15 +0000 (23:28 +0200)]
Workaround libgdiplus glitches

Don't test metafileHeader.Bounds when using libgdiplus.
Don't test metafile.GetBounds on Unix, force MetafileHeader.Bounds to return an empty rectangle when MetafileSize == 0
Don't validate graphicsUnit on Unix.

Commit migrated from https://github.com/dotnet/corefx/commit/825ef7c0d16798739f4cb69d3a4f1e924ef7ff18

7 years agoDon't depend on X11 in the MetafileTests
Frederik Carlier [Wed, 20 Sep 2017 20:30:54 +0000 (22:30 +0200)]
Don't depend on X11 in the MetafileTests

Commit migrated from https://github.com/dotnet/corefx/commit/6f55b588730ce3d2f341c4ed6af1bc536a570a1d

7 years agoWorkaround libgdiplus glitches
Frederik Carlier [Wed, 20 Sep 2017 21:28:15 +0000 (23:28 +0200)]
Workaround libgdiplus glitches

Don't test metafileHeader.Bounds when using libgdiplus.
Don't test metafile.GetBounds on Unix, force MetafileHeader.Bounds to return an empty rectangle when MetafileSize == 0
Don't validate graphicsUnit on Unix.

Commit migrated from https://github.com/dotnet/corefx/commit/abfd51d0f2019b204a6d29836381d183f3390d2e

7 years agoRemove X11 dependency for tests which are enabled on Unix.
Frederik Carlier [Thu, 21 Sep 2017 20:17:08 +0000 (22:17 +0200)]
Remove X11 dependency for tests which are enabled on Unix.

Commit migrated from https://github.com/dotnet/corefx/commit/8f3f06625346bbb0b39a75105024d64a4139cd26

7 years agoRemove duplicate tests, fix typo
Frederik Carlier [Wed, 20 Sep 2017 19:12:58 +0000 (21:12 +0200)]
Remove duplicate tests, fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/d284084addaee43add43a0a31272352eb25aeb11

7 years agoPR feedback
Frederik Carlier [Wed, 20 Sep 2017 17:58:10 +0000 (19:58 +0200)]
PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8e151ad37220a64e122d5406eee6935e14595e30

7 years agoAssert.False(Object.ReferenceEquals => Assert.NotSame
Frederik Carlier [Wed, 20 Sep 2017 17:53:32 +0000 (19:53 +0200)]
Assert.False(Object.ReferenceEquals => Assert.NotSame

Commit migrated from https://github.com/dotnet/corefx/commit/966a10e90ad495e0b0e57895005b0fe448bfe151

7 years agoDon't catch an ArgumentException just to get a NullReferenceException instead.
Frederik Carlier [Wed, 20 Sep 2017 17:49:34 +0000 (19:49 +0200)]
Don't catch an ArgumentException just to get a NullReferenceException instead.

Commit migrated from https://github.com/dotnet/corefx/commit/e12abadaaed28128232e1972d1aa94a467ab11ac

7 years agoSimplify tests, remove duplicate test
Frederik Carlier [Wed, 20 Sep 2017 17:37:01 +0000 (19:37 +0200)]
Simplify tests, remove duplicate test

Commit migrated from https://github.com/dotnet/corefx/commit/8ffcab504ef7ebe503a15ed18d994774d7fb3bb2

7 years agoFix Metafile exception behavior
Frederik Carlier [Wed, 20 Sep 2017 17:35:01 +0000 (19:35 +0200)]
Fix Metafile exception behavior

Commit migrated from https://github.com/dotnet/corefx/commit/cb271af10e2f1cee2e5e02ee4d860979968f2b1c

7 years agoUpdate project file
Frederik Carlier [Wed, 20 Sep 2017 15:17:00 +0000 (17:17 +0200)]
Update project file

Commit migrated from https://github.com/dotnet/corefx/commit/b138dba1a93207dee4bc63e0a378c96027b5a1c6

7 years agoRationalize using statements
Frederik Carlier [Wed, 20 Sep 2017 11:28:25 +0000 (13:28 +0200)]
Rationalize using statements

Commit migrated from https://github.com/dotnet/corefx/commit/a82017b65894c66980c4c6524ac610ee23f19cb3

7 years agoMetafileTests: Remove duplicates, and re-enable tests on Unix which are now working.
Frederik Carlier [Wed, 20 Sep 2017 11:23:59 +0000 (13:23 +0200)]
MetafileTests: Remove duplicates, and re-enable tests on Unix which are now working.
Delete duplicate MetaHeadertests

Commit migrated from https://github.com/dotnet/corefx/commit/367ab73d9d57186dd3f090da6a0000756186a93d

7 years agoUpdate project file
Frederik Carlier [Tue, 19 Sep 2017 20:39:06 +0000 (22:39 +0200)]
Update project file

Commit migrated from https://github.com/dotnet/corefx/commit/af4e3dfeca56dff633f9b58de9226ec87a2e3980

7 years agoAdd Metafile and MetaHeader tests based on Mono's System.Drawing unit tests
Frederik Carlier [Tue, 19 Sep 2017 20:38:53 +0000 (22:38 +0200)]
Add Metafile and MetaHeader tests based on Mono's System.Drawing unit tests

Commit migrated from https://github.com/dotnet/corefx/commit/22f2ee1bb825065536ae9760bd26e865461bb409

7 years agoMerge pull request dotnet/corefx#24194 from mellinoe/system.drawing-finish-consolidation
Eric Mellino [Thu, 21 Sep 2017 21:27:36 +0000 (14:27 -0700)]
Merge pull request dotnet/corefx#24194 from mellinoe/system.drawing-finish-consolidation

[Drawing] Move remaining "Unix" files into regular directory structure

Commit migrated from https://github.com/dotnet/corefx/commit/0f14a8cd6b06bcba290e796a641d0acd6a7706b1

7 years agoChange AsSpan to property Span and rename AsMemory to Memory
ahsonkhan [Tue, 19 Sep 2017 02:54:45 +0000 (19:54 -0700)]
Change AsSpan to property Span and rename AsMemory to Memory

Commit migrated from https://github.com/dotnet/corefx/commit/786195a51ca0b751f5aec127faf655fe358c6993

7 years agoMerge pull request dotnet/corefx#24183 from maryamariyan/odbc-temp
Eric Mellino [Thu, 21 Sep 2017 19:21:36 +0000 (12:21 -0700)]
Merge pull request dotnet/corefx#24183 from maryamariyan/odbc-temp

Adding System.Data.Odbc package and including in metapackage

Commit migrated from https://github.com/dotnet/corefx/commit/a7575a74be9a3e7ea161298acc6af477f38b7161

7 years ago[Drawing] Move remaining "Unix" files into regular directory structure
Eric Mellino [Thu, 21 Sep 2017 19:03:22 +0000 (12:03 -0700)]
[Drawing] Move remaining "Unix" files into regular directory structure

* As part of this, the "Windows" version of ImageFormat.cs is now being
  used everywhere. This file just contains a bunch of GUID's that are not
  platform-specific in any way.

Commit migrated from https://github.com/dotnet/corefx/commit/74a3d566ecee00e442f05157fd6952f389ff08e2

7 years agoMerge pull request dotnet/corefx#24184 from hughbe/brush-mt
Eric Mellino [Thu, 21 Sep 2017 19:06:51 +0000 (12:06 -0700)]
Merge pull request dotnet/corefx#24184 from hughbe/brush-mt

Fix MultiplyTransform with a disposed brush

Commit migrated from https://github.com/dotnet/corefx/commit/eb851a2b0243859be21e0d9d6fc3c4a4c5f9c7c5

7 years agoCoreFx dotnet/corefx#22406 Span based APIs - Text Reader Writer (dotnet/corefx#23786)
Mandar Sahasrabuddhe [Thu, 21 Sep 2017 17:39:23 +0000 (23:09 +0530)]
CoreFx dotnet/corefx#22406 Span based APIs - Text Reader Writer (dotnet/corefx#23786)

Commit migrated from https://github.com/dotnet/corefx/commit/c09ce65e6de10572abe4058f514338db2ef47ed9

7 years agoUpdate CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1...
dotnet-maestro-bot [Thu, 21 Sep 2017 17:17:58 +0000 (10:17 -0700)]
Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25720-03, preview1-25719-04, beta-25721-01, beta-25721-01, preview1-25721-01, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/04dd4993ae020bafd633c9f5b1a49fcf1cf882a7

7 years agoSwitch tests to use thread-local switch for ManagedHandler
Stephen Toub [Thu, 21 Sep 2017 12:26:44 +0000 (08:26 -0400)]
Switch tests to use thread-local switch for ManagedHandler

And as a result re-enable parallelism of the test suite, which on my machine reduces the running time of the outerloop tests from 150s to 45s.

Commit migrated from https://github.com/dotnet/corefx/commit/3db504ec31fb03162b33e0658870aef5af4e4abe

7 years agoFix for 2nd Connection hangs in Mirroring Environment (dotnet/corefx#24181)
Gene Lee [Thu, 21 Sep 2017 09:25:47 +0000 (02:25 -0700)]
Fix for 2nd Connection hangs in Mirroring Environment (dotnet/corefx#24181)

Commit migrated from https://github.com/dotnet/corefx/commit/dd48b05151c56fcf92cacc071f80fd39c099cadc

7 years agoFix MultiplyTransform with a disposed brush
Hugh Bellamy [Thu, 21 Sep 2017 09:00:29 +0000 (10:00 +0100)]
Fix MultiplyTransform with a disposed brush

Commit migrated from https://github.com/dotnet/corefx/commit/cde07104a9369b2542098e426bc5fa399741272b

7 years agoAdding System.Data.Odbc package and including in metapackage
Maryam Ariyan [Thu, 21 Sep 2017 03:33:02 +0000 (23:33 -0400)]
Adding System.Data.Odbc package and including in metapackage

Commit migrated from https://github.com/dotnet/corefx/commit/c895e10bfce739bcc77b4aead77f911dec6774d6

7 years agoRemove unused FEATURE_RANDOMIZED_STRING_HASHING (dotnet/corefx#24178)
Kevin Gosse [Wed, 20 Sep 2017 22:24:04 +0000 (00:24 +0200)]
Remove unused FEATURE_RANDOMIZED_STRING_HASHING (dotnet/corefx#24178)

Commit migrated from https://github.com/dotnet/corefx/commit/b73daf35e0188c1202be727806dede253f3b4332

7 years agoMerge pull request dotnet/corefx#24150 from qmfrederik/drawing/graphics-mono-tests
Eric Mellino [Wed, 20 Sep 2017 21:56:16 +0000 (14:56 -0700)]
Merge pull request dotnet/corefx#24150 from qmfrederik/drawing/graphics-mono-tests

System.Drawing - Add Graphics tests based on Mono's test suite

Commit migrated from https://github.com/dotnet/corefx/commit/de59a4244556433aee39faba347402a30801f03c

7 years agoFix memory map imports (dotnet/corefx#24176)
Jeremy Kuhne [Wed, 20 Sep 2017 21:13:40 +0000 (14:13 -0700)]
Fix memory map imports (dotnet/corefx#24176)

* Fix memory map imports

Imports lost the last error attribute. Add it back and change the results to be the more correct "bool". Tweak the usage based on the new return type.

dotnet/corefx#24159

* Move spin wait

Commit migrated from https://github.com/dotnet/corefx/commit/b0a91f4a19784d87f51c678baadbfe266440f4c0

7 years agoMerge pull request dotnet/corefx#23932 from JonHanna/biginteger_reach_minvalue_opt
Eric Mellino [Wed, 20 Sep 2017 19:31:22 +0000 (12:31 -0700)]
Merge pull request dotnet/corefx#23932 from JonHanna/biginteger_reach_minvalue_opt

Make BigInteger ctor opt path for == int.MinValue reachable.

Commit migrated from https://github.com/dotnet/corefx/commit/2a650d568dba1724b0fe136af6714d7133aab745

7 years agoMerge pull request dotnet/corefx#24166 from hughbe/hatchbrush-fixes
Eric Mellino [Wed, 20 Sep 2017 19:29:24 +0000 (12:29 -0700)]
Merge pull request dotnet/corefx#24166 from hughbe/hatchbrush-fixes

Fix HatchBrush constructor validation, renable more passing tests on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/aa1ff5efc54ee788687c8a912afe2937f4538858

7 years agoMerge pull request dotnet/corefx#24086 from mellinoe/system.drawing-mono-win32-cleanup
Eric Mellino [Wed, 20 Sep 2017 19:24:42 +0000 (12:24 -0700)]
Merge pull request dotnet/corefx#24086 from mellinoe/system.drawing-mono-win32-cleanup

Consolidate more code in the "System.Drawing" namespace.

Commit migrated from https://github.com/dotnet/corefx/commit/dce54eac6369631bf9e0af274cb0abd484edb331

7 years agoPR feedback
Frederik Carlier [Wed, 20 Sep 2017 19:21:50 +0000 (21:21 +0200)]
PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5d1ee6567cd0cae92b66a49168b5bfdcb91a53f7

7 years agoAddress PR feedback
Hugh Bellamy [Wed, 20 Sep 2017 18:35:44 +0000 (19:35 +0100)]
Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5fbce4b45c94c6f7246d9c58e28c6761dbee7dd9

7 years agoMerge pull request dotnet/corefx#24170 from danmosemsft/fix.threadsleep
Eric Mellino [Wed, 20 Sep 2017 18:09:33 +0000 (11:09 -0700)]
Merge pull request dotnet/corefx#24170 from danmosemsft/fix.threadsleep

Remove Thread.Sleep workaround

Commit migrated from https://github.com/dotnet/corefx/commit/0b2dc05d223938570724da180a3fadbbb0a9052d

7 years agoAdd thread-local based switch to opt-in to ManagedHandler
Stephen Toub [Wed, 20 Sep 2017 12:34:22 +0000 (08:34 -0400)]
Add thread-local based switch to opt-in to ManagedHandler

Commit migrated from https://github.com/dotnet/corefx/commit/7c851fcea84b3e10528c8da9fe4a6edb503e8773

7 years agoUpdate BuildTools to prerelease-02020-01 (dotnet/corefx#24172)
Drew Scoggins [Wed, 20 Sep 2017 17:45:20 +0000 (10:45 -0700)]
Update BuildTools to prerelease-02020-01 (dotnet/corefx#24172)

Commit migrated from https://github.com/dotnet/corefx/commit/933ffa4d80a4183951deddfbc4510a94fb12b3f1

7 years agoRemove Thread.Sleep workaround
danmosemsft [Wed, 20 Sep 2017 17:00:35 +0000 (10:00 -0700)]
Remove Thread.Sleep workaround

Commit migrated from https://github.com/dotnet/corefx/commit/7af1113607a94a22fa2e340863408b90211c2f53

7 years agoRenable some already passing tests
Hugh Bellamy [Wed, 20 Sep 2017 11:15:50 +0000 (12:15 +0100)]
Renable some already passing tests

Commit migrated from https://github.com/dotnet/corefx/commit/fa1422e4b4c608be2b98542736776de1e10c0460

7 years agoRemove references to historical Mono bug IDs
Frederik Carlier [Wed, 20 Sep 2017 11:10:17 +0000 (13:10 +0200)]
Remove references to historical Mono bug IDs

Commit migrated from https://github.com/dotnet/corefx/commit/822338b447ed336c5e60d23066f1fe347909abe0

7 years agoDelete accidentally duplicated HatchBrush tests in LinearGradientBrushTests
Hugh Bellamy [Wed, 20 Sep 2017 10:51:57 +0000 (11:51 +0100)]
Delete accidentally duplicated HatchBrush tests in LinearGradientBrushTests

Commit migrated from https://github.com/dotnet/corefx/commit/c8767bc47a4a365ad1fc362733b9ba0c36b3707a

7 years agoValidate HatchStyle passed to HatchBrush ctor
Hugh Bellamy [Wed, 20 Sep 2017 10:50:58 +0000 (11:50 +0100)]
Validate HatchStyle passed to HatchBrush ctor

Commit migrated from https://github.com/dotnet/corefx/commit/6406e382af893765a21eab1d2e11431cb838afde

7 years agoCleanup - Add/simplify using statements of disposable resources (Graphics, Bitmap)
Frederik Carlier [Wed, 20 Sep 2017 10:09:34 +0000 (12:09 +0200)]
Cleanup - Add/simplify using statements of disposable resources (Graphics, Bitmap)

Commit migrated from https://github.com/dotnet/corefx/commit/0b5b1e4113ee848041c89256589d6aec5b9672b8

7 years agoBump System.Drawing.Common.TestData to 1.0.6 (dotnet/corefx#24149)
Frederik Carlier [Tue, 19 Sep 2017 21:54:58 +0000 (23:54 +0200)]
Bump System.Drawing.Common.TestData to 1.0.6 (dotnet/corefx#24149)

* Bump system.drawing.common.testdata to 1.0.6

* Fix path to test data

* Fix whitespace

Commit migrated from https://github.com/dotnet/corefx/commit/c4e03f00fe667aed5a4a79a4b039a8c842fdfcc4

7 years agoAdd an error code fixup to Bitmap.Unix.cs to match Windows.
Eric Mellino [Tue, 19 Sep 2017 21:44:46 +0000 (14:44 -0700)]
Add an error code fixup to Bitmap.Unix.cs to match Windows.

Commit migrated from https://github.com/dotnet/corefx/commit/a4e548c30693ab6e7922a2d8b1444847265fc1f1

7 years agoFix multiplying TextureBrush with a disposed matrix on Unix (dotnet/corefx#24109)
Hugh Bellamy [Tue, 19 Sep 2017 21:28:44 +0000 (22:28 +0100)]
Fix multiplying TextureBrush with a disposed matrix on Unix (dotnet/corefx#24109)

* Fix multiplying TextureBrush with a disposed matrix on Unix

* Enable another passing test

* Fix accidentally committed file

Commit migrated from https://github.com/dotnet/corefx/commit/15f9a31fd45f9a7d667765ef08ecfd1cefddde3a

7 years agoRemove duplicate tests.
Frederik Carlier [Tue, 19 Sep 2017 21:06:10 +0000 (23:06 +0200)]
Remove duplicate tests.

Commit migrated from https://github.com/dotnet/corefx/commit/6cdccce2ef06ae448aa99ecface2085157b0c72d

7 years agoAdd conditionals for recent versions of mono
Frederik Carlier [Tue, 19 Sep 2017 20:34:28 +0000 (22:34 +0200)]
Add conditionals for recent versions of mono

Commit migrated from https://github.com/dotnet/corefx/commit/a379e9cff54b001eecf37c4653de88b5142c1363