Piotr Byszewski [Fri, 4 Oct 2019 12:17:42 +0000 (14:17 +0200)]
VkPhysicalDeviceVulkan1{1,2}Features in framework
Use VkPhysicalDeviceVulkan11Features and
VkPhysicalDeviceVulkan12Features in DefaultDevice chain.
This change also adds Context::isDeviceFunctionalitySupported and
Context::isInstanceFunctionalitySupported methods that checks if
extension are available and if proper feature bit are set (when
needed).
Components: Framework
VK-GL-CTS issue: 2005
Affects:
dEQP-VK.*
Change-Id: I81cf677fe46ae5bd870fde37253e97bdfcc4ae3a
Ricardo Garcia [Thu, 13 Jun 2019 09:43:52 +0000 (11:43 +0200)]
Enable validation layers for custom devices and instances
Honor the --deqp-validation=enable command line option in tests using
custom devices and instances.
Affected tests:
dEQP-VK.api.buffer.*
dEQP-VK.api.device_init.*
dEQP-VK.api.external.memory.*
dEQP-VK.api.info.*
dEQP-VK.api.object_management.*
dEQP-VK.api.version_check.*
dEQP-VK.compute.basic.*
dEQP-VK.compute.device_group.*
dEQP-VK.device_group.*
dEQP-VK.image.swapchain_mutable.*
dEQP-VK.memory.allocation.*
dEQP-VK.memory.device_group_allocation.*
dEQP-VK.multiview.*
dEQP-VK.pipeline.push_descriptor.*
dEQP-VK.protected_memory.*
dEQP-VK.robustness.*
dEQP-VK.sparse_resources.*
dEQP-VK.synchronization.basic.semaphore.*
dEQP-VK.synchronization.cross_instance.*
dEQP-VK.synchronization.internally_synchronized_objects.*
dEQP-VK.synchronization.op.multi_queue.*
dEQP-VK.synchronization.smoke.*
dEQP-VK.synchronization.win32_keyed_mutex.*
dEQP-VK.wsi.*
dEQP-VK.ycbcr.format.*
Components: Vulkan
VK-GL-CTS issue: 1831
Change-Id: I569f2362cfbc2446ba099d38da48d58be451ebeb
Alexander Galazin [Tue, 22 Oct 2019 17:00:27 +0000 (19:00 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: I3cb15875a0283934251bddc35af68cab1c3394c5
Lionel Landwerlin [Wed, 16 Oct 2019 18:39:50 +0000 (21:39 +0300)]
Fix waitSemaphoreCount value in signal ordering tests
VK-GL-CTS Issue: 2059
Components: Vulkan
Affects: dEQP-VK.synchronization.signal_order.*timeline_semaphore.*
Change-Id: I25b86f1ae2b8e3650e061f9f2e345147c01419c6
Arkadiusz Sarwa [Thu, 17 Oct 2019 15:02:40 +0000 (17:02 +0200)]
Fix external memory import
Fix adds checking for flag
VK_EXTERNAL_MEMORY_FEATURE_DEDICATED_ONLY_BIT
when external memory is being imported.
Affects:
dEQP-VK.synchronization.signal_order.*
Components: Vulkan
VK-GL-CTS issue: 2063
Change-Id: Iebc72ba0ed89ba3ca2b83a5b97d6b24ab7871edb
Jeff Bolz [Fri, 18 Oct 2019 17:05:46 +0000 (12:05 -0500)]
Fix LAYOUT_UNDEFINED transitions in descriptor_indexing tests
Commit
7b7ba4e0 caused the UNDEFINED->COLOR layout transition to be applied four
times, corrupting 3/4 of the image. Change the tests to do the layout transition
once, right after the framebuffer is created.
VK-GL-CTS Issue: 2064
Components: Vulkan
Affects: dEQP-VK.descriptor_indexing.*
Change-Id: Ie599ba76ba75af6fee1f4163bd96ea2bd6e4c145
Alexander Galazin [Thu, 17 Oct 2019 20:13:33 +0000 (22:13 +0200)]
Whitelist Vulkan CTS 1.2.0.1
Components: Vulkan
Change-Id: Ic95049203b246c17b535d86fcaad2ee431c6b751
Alexander Galazin [Thu, 17 Oct 2019 18:33:19 +0000 (20:33 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: I5955793c43464b3046180ca90c1a64fa0e9379b3
Alexander Galazin [Thu, 17 Oct 2019 17:58:35 +0000 (19:58 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: I2aa94658d6c8b6543fd9c4899f7da481ba1120a1
Alexander Galazin [Thu, 17 Oct 2019 15:46:59 +0000 (17:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I0954d6799d7b0e4a527cd0fbbdcf61237ca7e9a7
Alan Baker [Sun, 25 Aug 2019 17:57:24 +0000 (13:57 -0400)]
Remove float16 derivatives tests
SPIR-V restricts derivatives to 32-floating point scalars and vectors
only.
Component: Vulkan
VK-GL-CTS Issue: 1931
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.float16.derivative_*.*
Change-Id: Icc5341e697b797045080cc55428dbc2c02d71def
(cherry picked from commit
436d6dd5e7a0c0811bf1b6059542d1cdbccb9566)
Alex Walters [Mon, 14 Oct 2019 16:32:12 +0000 (17:32 +0100)]
Make texture aniso basic self tests less sensitive
The tests cases first check with a fuzzy diff that the images are more
or less the same.
The second diff then checks with a standard image comparison + tolerance
that the images are not identical.
Some of IMG's implementations produce a closer image than the test is
currently expecting - we need to lower the tolerance from 0.05 to 0.02
in order for the diff algorithm to detect that the images are
different 'enough'.
Though there is no actual spec requirement, it is 'generally going to
be the case', for any implementation, that the images will have some
amount of difference. It is potentially useful to still have this test
inplace to check againsty aniso being accidently disabled in the tested
implementation, rather than remove it altogether.
Affects:
dEQP-VK.texture.filtering_anisotropy.basic.*
Components: Vulkan
VK-GL-CTS Issue: 2047
Change-Id: Ia9148e12172ac1c4757f5007e57b3a2b3a3434eb
Matthew Netsch [Fri, 4 Oct 2019 18:57:40 +0000 (14:57 -0400)]
Relaxes line rasterization tolerances
Components: Framework
VK-GL-CTS Issue: 2033
Affects:
dEQP-VK.rasterization.*
Change-Id: Ib41552b1bb6d9aa2b25d0cbc6f02d51ce997f4e3
Alexander Galazin [Thu, 17 Oct 2019 15:11:04 +0000 (11:11 -0400)]
Revert "Fixes VS num instances assumption"
This reverts commit
bac8df251bb6103d7844bfeacbb29bf14011b7cb.
Change-Id: I60aa83d860b0b11ec7fc58fb97806635a1eebdca
Piers Daniell [Fri, 6 Sep 2019 18:27:31 +0000 (12:27 -0600)]
Generate a non-zero exit code on test failure
If there are any failed tests, or the test run was not
compelte, the process will now generate EXIT_FAILURE (1)
instead of EXIT_SUCCESS (0).
Affects:
dEQP-VK.*
Components: Framework
VK-GL-CTS issue: 1982
Change-Id: I061d9a3b6703e1f23c48ce8a31e943744f915c92
(cherry picked from commit
cfa72a70ef8371eab29da003dbb4d932adba189a)
Alexander Galazin [Wed, 16 Oct 2019 13:01:00 +0000 (15:01 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: I01ffb4e6195d7754314ec4a72be0c03f595b6e02
Alexander Galazin [Wed, 16 Oct 2019 11:44:00 +0000 (13:44 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: Iea7706e036758d8a648ef7938b3d08e21321a087
Joerg Wagner [Wed, 9 Oct 2019 18:53:46 +0000 (20:53 +0200)]
Fix wrong wait stage mask
The wait stage mask wasn't accounting for the
stages the readers actually operate in, hence
being effectless.
Track the union of the reader's stage masks
and use that to block execution on the semaphore.
Affects:
dEQP-VK.synchronization.signal_order.*
Components: Vulkan
VK-GL-CTS issue: 2044
Change-Id: Ia4d5c7bcb9dd6eec25e7245dc41754acccd1b995
Panagiotis Apostolou [Thu, 10 Oct 2019 13:33:32 +0000 (15:33 +0200)]
Fix in shadercacheLoad
There is a slim chance that function shadercacheLoad() can pass a null
pointer into the std::string constructor, causing an exception. This can
happen in the case there is a mismatch between the calculated hash and
the one stored in the cache file.
This commit makes the code more robust, handling this case as a miss.
Components: Vulkan
VK-GL-CTS issue: 2052
Change-Id: I84a382dec51f487314304ec9057cefdff22920c3
Pawel Ksiezopolski [Wed, 9 Oct 2019 08:53:05 +0000 (10:53 +0200)]
Relax deviceName and deviceInfo string comparison
Change deMemCmp() to strncmp() for two char arrays in
VkPhysicalDeviceVulkan12Properties struct, so that we don't
compare bytes after null termination character.
Affects:
dEQP-VK.api.info.vulkan1p2.properties
Components: Vulkan
VK-GL-CTS issue: 2040
Change-Id: I312575c5b29705c1cb2010f2a2d247055680bf97
Alexander Galazin [Fri, 11 Oct 2019 10:13:41 +0000 (12:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: Ie09cc3cac8462a7669c3fa0c25edb40d8e05d062
Alexander Galazin [Fri, 11 Oct 2019 09:52:19 +0000 (11:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: Ibb2b736bbe1c62688044aa21dc75205f6fa32f1c
Alexander Galazin [Fri, 11 Oct 2019 09:50:16 +0000 (11:50 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I79fdf16146cf659aeae510fb6fb2ad72f641ba3e
Alexander Galazin [Fri, 11 Oct 2019 09:48:34 +0000 (11:48 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ia0d88c0631e427241c7795931a834d9baf43e5a3
Lionel Landwerlin [Fri, 27 Sep 2019 11:28:23 +0000 (14:28 +0300)]
Skip test with no display plane is available
Similarly to dEQP-VK.wsi.display.get_display_properties that skips
when no display available.
Components: Vulkan
Affects: dEQP-VK.wsi.display.get_display_plane_capabilities2
Change-Id: I46af976a9ba3e77e250504d0164dec6ac4cdd607
(cherry picked from commit
fd915c2d0ec7b544b670192447223061fe4b6cf3)
Piers Daniell [Thu, 5 Sep 2019 18:19:24 +0000 (12:19 -0600)]
Limit the apiVersion of the instance within the CTS framework
This CL allows older CTS tests to run on implementations that
support a newer instance version not supported by this version
of CTS.
The dEQP-VK.api.version_check.version test was modified to
fail if this version of CTS is run on an implementation
it does not support. This is to stop old CTS from passing
on newer implementations, where the newer CTS should have
been used.
Affects:
dEQP-VK.api.version_check.version
dEQP-VK.*
Components: Vulkan
VK-GL-CTS issue: 1979
Change-Id: I97cd17b0aae9b3cba7c2e000d21636ad37c1fd80
Alexander Galazin [Fri, 11 Oct 2019 08:45:43 +0000 (10:45 +0200)]
Fix SEMAPHORE_TYPE_TIMELINE enum
Components: Vulkan
Change-Id: Id4949383bed578436e321c621a8ff495157da895
Alexander Galazin [Fri, 11 Oct 2019 08:32:13 +0000 (10:32 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I6597defb9bda8c8e6393033bf444befd4b9301fb
John Corbally [Wed, 2 Oct 2019 16:31:55 +0000 (17:31 +0100)]
Fix relaxed precision and no perspective dEQP tests
In the RelaxedPrecision case, change epsilon to 2e-3 for a 16-bit float.
In the NoPerspective case, change epsilon to 3e-7 for a 32-bit float.
The epsilon is now relative to the correct value.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.*
Components: Vulkan
VK-GL-CTS issue: 1818
Change-Id: Id21382ce4b1cb58458ec3fb521630ab75e1910a3
Alexander Galazin [Thu, 10 Oct 2019 15:31:00 +0000 (17:31 +0200)]
Update glslang
Affects: dEQP-VK.binding_model.buffer_device_address.*
Components: Vulkan
VK-GL-CTS issue: 2046
Change-Id: I60e3579df3bb3f81732fec0c46803a97fc00953a
Peter Quayle [Wed, 9 Oct 2019 16:43:32 +0000 (17:43 +0100)]
Fixed flags used to select queue in dEQP-VK.synchronization.op.multi_queue
getDefaultQueue takes a VkQueueFlags argument and returns an appropriate VkQueue.
This function was being called with inappropriate arguments
causing the wrong queue to be returned. This could ultimately lead to work
being submitted to a queue which lacked support for it (e.g. graphics work
on a sparse queue).
Affects:
dEQP-VK.synchronization.op.multi_queue*
Components: Vulkan
VK-GL-CTS issue: 2043
Change-Id: I7887d1b4da8c916aed032433c6634c99b723f285
(cherry picked from commit
1bd32d3221dd65087de14ae061f798b78ac7ce0d)
Peter Quayle [Wed, 9 Oct 2019 16:43:32 +0000 (17:43 +0100)]
Fixed flags used to select queue in dEQP-VK.synchronization.op.multi_queue
getDefaultQueue takes a VkQueueFlags argument and returns an appropriate VkQueue.
This function was being called with inappropriate arguments
causing the wrong queue to be returned. This could ultimately lead to work
being submitted to a queue which lacked support for it (e.g. graphics work
on a sparse queue).
Affects:
dEQP-VK.synchronization.op.multi_queue*
Components: Vulkan
VK-GL-CTS issue: 2043
Change-Id: I7887d1b4da8c916aed032433c6634c99b723f285
Peter Quayle [Tue, 8 Oct 2019 16:35:04 +0000 (17:35 +0100)]
Fix semaphore creation in smoke tests
The test was calling createSemaphore instead of createSemaphoreType,
meaning that the semaphoreType value would incorrectly be interpreted
as a VkSemaphoreCreateFlags.
Additionally, the VkTimelineSemaphoreSubmitInfo struct was not being
added into the pNext chain of the submits. This probably went unnoticed
because the first bug could cause the test to use binary semaphores
even if semaphoreType was TIMELINE.
Affects:
dEQP-VK.synchronization.smoke.binary_semaphores
dEQP-VK.synchronization.smoke.timeline_semaphores
Components: Vulkan
VK-GL-CTS issue: 2041
Change-Id: I6936013b7f5a7e25f4af1fb4776d4d7273243d7a
(cherry picked from commit
a8238c0aa023c121f79f09c6565875e235292f27)
Peter Quayle [Tue, 8 Oct 2019 16:35:04 +0000 (17:35 +0100)]
Fix semaphore creation in smoke tests
The test was calling createSemaphore instead of createSemaphoreType,
meaning that the semaphoreType value would incorrectly be interpreted
as a VkSemaphoreCreateFlags.
Additionally, the VkTimelineSemaphoreSubmitInfo struct was not being
added into the pNext chain of the submits. This probably went unnoticed
because the first bug could cause the test to use binary semaphores
even if semaphoreType was TIMELINE.
Affects:
dEQP-VK.synchronization.smoke.binary_semaphores
dEQP-VK.synchronization.smoke.timeline_semaphores
Components: Vulkan
VK-GL-CTS issue: 2041
Change-Id: I6936013b7f5a7e25f4af1fb4776d4d7273243d7a
Mike Byrne [Mon, 30 Sep 2019 13:57:05 +0000 (14:57 +0100)]
Split descriptor set indexing render pass workload
The render pass workload for descriptor set indexing tests should be
split into multiple submissions to prevent timeouts observed in tests
for the VK_DESCRIPTOR_TYPE_SAMPLER,
VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER and
VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE descriptor types.
Affects: dEQP-VK.descriptor_indexing*
Components: Vulkan
VK-GL-CTS Issue: 2026
Change-Id: I3b4876ec204fe1c1ebf174e06328653f0a5532d3
Alexander Galazin [Thu, 10 Oct 2019 11:21:55 +0000 (13:21 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: I288a90fcda0d3cbd7fbb1f8d622dee03f6b74f62
Alexander Galazin [Thu, 10 Oct 2019 09:38:02 +0000 (11:38 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I45e2e3c52d89424f714c43c76fc2dd9aea2a793d
Jeff Bolz [Mon, 30 Sep 2019 14:06:29 +0000 (09:06 -0500)]
Share device across synchronization tests (again)
This change reverts the deletion of this logic in the cross_instance
tests, and ports the logic to the new timeline semaphore tests.
Components: Vulkan
Affects: dEQP-VK.synchronization.cross_instance.*
Affects: dEQP-VK.synchronization.timeline_semaphore.*
Affects: dEQP-VK.synchronization.signal_order.*
Change-Id: I6dec095a8314aea3062f2ad532a4b4bdede398eb
Chris Forbes [Wed, 25 Sep 2019 23:51:40 +0000 (16:51 -0700)]
Add feature requirements to existing amber files
Updates the amber files themselves to mirror the constraints enforced on the C++ side.
Components: Vulkan
Change-Id: I698a39732b02cb99fe1aeb369f1054ac9a769bfb
VK-GL-CTS: 1965
Chris Forbes [Thu, 29 Aug 2019 04:31:39 +0000 (21:31 -0700)]
Add variable pointers requirement for vktSpvAsmPtrAccessChainTests
These tests did not check for the variablePointers feature they need.
Components: Vulkan
VK-GL-CTS Issue: 1965
Affects: dEQP-VK.spirv_assembly.instruction.compute.ptr_access_chain.*
Change-Id: Ied75a1c5661755549cc599b2397a18345bc727f9
Matthew Netsch [Fri, 4 Oct 2019 21:09:39 +0000 (17:09 -0400)]
Fixes VS num instances assumption
Components: Vulkan
VK-GL-CTS Issue: 2022
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes*
Change-Id: Ie1d784733774ae357698cf8a5672fcccdb0c1e1e
Boris Zanin [Thu, 26 Sep 2019 08:57:58 +0000 (10:57 +0200)]
Check extension limits
Add extension limits validaty check. The tests are per-extention.
Add tests:
* dEQP-VK.api.info.vulkan1p2_limits_validation.khr_push_descriptor
* dEQP-VK.api.info.vulkan1p2_limits_validation.khr_multiview
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_discard_rectangles
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_sample_locations
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_external_memory_host
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_blend_operation_advanced
* dEQP-VK.api.info.vulkan1p2_limits_validation.khr_maintenance_3
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_conservative_rasterization
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_descriptor_indexing
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_inline_uniform_block
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_vertex_attribute_divisor
* dEQP-VK.api.info.vulkan1p2_limits_validation.nv_mesh_shader
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_transform_feedback
* dEQP-VK.api.info.vulkan1p2_limits_validation.fragment_density_map
* dEQP-VK.api.info.vulkan1p2_limits_validation.nv_ray_tracing
* dEQP-VK.api.info.vulkan1p2_limits_validation.timeline_semaphore
* dEQP-VK.api.info.vulkan1p2_limits_validation.ext_line_rasterization
Rename and update test:
* dEQP-VK.api.info.vulkan1p2.limits_validation
to
* dEQP-VK.api.info.vulkan1p2_limits_validation.general
Components: vulkan
VK-GL-CTS issue: 2008
Change-Id: I5350ef499ba70e0194d360008a893209242a28a8
Alexander Galazin [Wed, 9 Oct 2019 07:12:17 +0000 (09:12 +0200)]
Remove unnecessary initializers
Components: Vulkan
Affects: dEQP-VK.glsl.shader_clock.*
Change-Id: I4526c05cdd5464f26450bba67f573b467881f4ff
Alexander Galazin [Tue, 8 Oct 2019 17:58:13 +0000 (19:58 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: I3a4a19f9d8bba49c51d01cc6f07fda4ceb496b45
Igor Ostrowski [Thu, 26 Sep 2019 13:09:28 +0000 (15:09 +0200)]
Check timeline semaphore features only when used.
Affects:
dEQP-VK.synchronization.op.multi_queue.*
Components: Vulkan
VK-GL-CTS issue: 2025
Change-Id: I8c586bcb0199ab00fe6fffb9290abd2b06523916
(cherry picked from commit
c20bf2e3023cb209ae3ec04b6e6339f8c3930dfb)
Alexander Galazin [Tue, 8 Oct 2019 17:28:47 +0000 (19:28 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: I44be4e273707047428a95e8243734259c859fe0a
Alexander Galazin [Tue, 8 Oct 2019 14:24:57 +0000 (16:24 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Ifd05cb161b5f393a1d5539f18a1d521482a2039f
Piers Daniell [Fri, 4 Oct 2019 21:15:21 +0000 (15:15 -0600)]
Whitelist newly supported VK_KHR* extensions in CTS 1.1.5
The following extensions are now supported by
vulkan-cts-1.1.5.2:
- VK_KHR_timeline_semaphore
- VK_KHR_shader_clock
Affects:
dEQP-VK.api.info.device.extensions
Change-Id: I6fc4bbc5ab95557ac83c8ff8172679a343d46b23
Components: Vulkan
Eric Werness [Fri, 16 Nov 2018 21:50:40 +0000 (13:50 -0800)]
Support Python3 as well in gen_release_info.py
The CMake file version check can end up picking python3 in some cases -
making the Python code compatible with python3 seems easier than
adjusting the version check.
Components: Frameworks
Change-Id: Iab37090ab813dcb7839490225ca2a4bf2f721c12
Aaron Hagan [Mon, 20 May 2019 19:22:08 +0000 (15:22 -0400)]
Add tests for VK_KHR_shader_clock
Affects:
dEQP-VK.glsl.shader_clock.*
Components: Vulkan
VK-GL-CTS issue: https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/1758
(cherry picked from commit
9de5b8e48869ab025ed11982c6362e7f7082115f)
Change-Id: Iaca2d845ffb7a3037cee0c9cf38ff4844e7c9a48
Lionel Landwerlin [Wed, 11 Sep 2019 16:17:24 +0000 (19:17 +0300)]
Fix print of uninitialized value
Just fixing a printout in the result file.
Change-Id: Id1b4d3ee9879a07f452c5f5a0310a16d72051848
(cherry picked from commit
2d48a5baf07daeabeca8412ca6ff56d9ac92e2ca)
Lionel Landwerlin [Tue, 10 Sep 2019 11:36:19 +0000 (14:36 +0300)]
Add signal ordering tests
We want to verify that the signaling of semaphores in multiple
VkSubmitInfo a vkQueueSubmit() is ordered.
Add tests:
dEQP-VK.synchronization.signal_order.*
Change-Id: Ibf47e7e4105f479ab33b5bafeda3efdd4c2782b5
(cherry picked from commit
70ed33e49cd109a494b85a0daeb73ff40d3157f9)
Lionel Landwerlin [Fri, 1 Mar 2019 17:03:15 +0000 (17:03 +0000)]
Add tests for VK_KHR_timeline_semaphore
Renames existing semaphore tests from .*semaphore.* into .*binary_semaphore.*
Affects: dEQP-VK.synchronization.*
Change-Id: I48173432da6410a609c0d2000f21c379d4a64429
Components: Vulkan
(cherry picked from commit
a86d535bb75d21445df66cdfcce0b9dc79c37604)
Jari Komppa [Wed, 31 Jul 2019 10:29:15 +0000 (13:29 +0300)]
Speed up hierarchy traversal, part 2
Some of the tests do premature heavy work during test hierarchy
traversal, meaning that they waste time regardless of whether the tests
are run or not. These changes move some of that work to later stage of
test run, or otherwise speed things up a bit.
Affects:
dEQP-VK.pipeline.stencil.*
dEQP-VK.synchronization.cross_instance.*
dEQP-VK.synchronization.op.multi_queue.*
dEQP-VK.transform_feedback.fuzz.*
Components: Vulkan
VK-GL-CTS issue: 1830
Change-Id: I1c124cbf17068e56375ef2e467036e959cde8aa4
(cherry picked from commit
41527af467623bae596b2bd319b0694c11f8cbf8)
Jeff Bolz [Thu, 18 Jul 2019 19:45:02 +0000 (14:45 -0500)]
Share instance/device across test case instances in dEQP-VK.synchronization.*
Some of the dEQP-VK.synchronization.* test groups create new devices or new
instances for each test case. This is a really expensive thing to do tens of
thousands of times, and makes this the longest-running test group in the CTS.
This change uses singleton objects to store the instance/device, and adds
cleanup callbacks to destroy the singletons when the group is finished.
VK-GL-CTS Issue: 1886
Components: Vulkan
Affects: dEQP-VK.synchronization.*
Change-Id: If935b457276790faf4a86e6f2afb5fd911987a85
(cherry picked from commit
90e05499c49c88fc4063748574931c3be5652b07)
Alexander Galazin [Thu, 3 Oct 2019 15:33:04 +0000 (17:33 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: Idcd78cbc60325522a070c7c777317f0d811377c7
Piotr Byszewski [Fri, 27 Sep 2019 14:00:31 +0000 (16:00 +0200)]
Fix 64bit type promotions in subgroup tests
VK-GL-CTS issue: 1948
Components: Vulkan
Affects:
dEQP-VK.subgroups.*.ext_shader_subgroup_ballot.*
Change-Id: I7b8a1a8979bb16f1f4f4fcfd8579c764aa3820f0
(cherry picked from commit
57e251b094d00ad5332e1500af9cbfb490dcbe90)
Alexander Galazin [Thu, 3 Oct 2019 09:13:32 +0000 (11:13 +0200)]
Whitelist Vulkan CTS 1.1.5.2
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: I4a372accb5bc99345f55cea56140bd013b96b3f2
Yahan Zhou [Mon, 30 Sep 2019 22:12:45 +0000 (15:12 -0700)]
Extended: texel_view_compatible: image: fix image coord
Image coords in compute shaders need manual +0.5.
Affects:
dEQP-VK.image.texel_view_compatible.compute.extended.*.texture.*
Components: Vulkan
VK-GL-CTS issue: 1890
Change-Id: Iec93340004807252b0956e3d2fa19bacb899ff7b
Gary Sweet [Thu, 1 Aug 2019 11:50:40 +0000 (12:50 +0100)]
Account for precision loss in unorm depth pipeline
https://gerrit.khronos.org/#/c/4049/ introduced a regression
related to the use of depths other than 0.0 and 1.0 in the round-trip
to the depth buffer and back.
The test can now write 1.0/255.0 to gl_FragDepth and expects to see
exactly 1.0/255.0 when it is read back in the input attachment.
The unorm depth formats are only specified to be exact for the integer
values (0.0 and 1.0). We can differ by 1-bit after the round-trip.
This change adds an epsilon range check for the unorm depth tests
that resolve the issue.
Affected tests:
dEQP-VK.renderpass.dedicated_allocation.*
dEQP-VK.renderpass.suballocation.*
dEQP-VK.renderpass2.dedicated_allocation.*
dEQP-VK.renderpass2.suballocation.*
Components: Vulkan
VK_GL_CTS issue: 1908
Change-Id: Iaec3503595afd3409d2c21d8af72b469467d6673
(cherry picked from commit
611bdb3a21879d726d11a42d87639c686531ae79)
Jeff Bolz [Tue, 24 Sep 2019 22:01:10 +0000 (17:01 -0500)]
uvec2 tests for VK_KHR_buffer_device_address
Add variants of the 'convert' tests that convert to and from uvec2
rather than uint64_t.
Components: Vulkan
VK-GL-CTS Issue: 2018
Affects: dEQP-VK.binding_model.buffer_device_address.*
Change-Id: I9e1a2f031e295b9200faff571aae2fc5cbb9005c
Alexander Galazin [Tue, 1 Oct 2019 11:21:46 +0000 (13:21 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: Iac0fcad25eac20577e603b022f59b4f87cb9055a
Alexander Galazin [Tue, 1 Oct 2019 10:36:16 +0000 (12:36 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: Iada24773960c88053e0a1f2fed3700a0e0df408a
Alexander Galazin [Tue, 1 Oct 2019 09:52:37 +0000 (11:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I7df0259f0457521714e530c44ef34b741d230d37
Marcin Kańtoch [Mon, 23 Sep 2019 16:41:58 +0000 (18:41 +0200)]
Add check if usage is supported for image format
dEQP-VK.image.swapchain_mutable* tests do not check
if the required usage is supported for image format
and image view format.
Components: Vulkan
Affects:
dEQP-VK.image.swapchain_mutable*
VK-GL-CTS issue: 2015
Change-Id: I6680d9e6ef1b03462afa01349b6f34d82ef40a17
Chris Forbes [Thu, 26 Sep 2019 14:51:32 +0000 (07:51 -0700)]
Exclude dEQP-VK.ssbo.layout.random.scalar.75 from Android CTS
This is already excluded from the Khronos mustpass lists.
VK-GL-CTS Issue: 1829
Google bug: b/
141657868
Google bug: b/
135200048
Components: Android
Change-Id: I6b453819314cc2e8245ac9d518ef4b481fe90887
Alexander Galazin [Mon, 30 Sep 2019 19:15:50 +0000 (21:15 +0200)]
Update SPIR-V Tools/Headers
Components: Framework
Affects: dEQP-VK.*
Change-Id: I2e30638ba282c2bfb6582c0934f351be0b7904bd
Alexander Galazin [Mon, 30 Sep 2019 17:11:16 +0000 (19:11 +0200)]
Update headers
Components: Vulkan
Change-Id: I269c5d33a4cc2dfcfac9db21fa2980f7d8d01771
Alexander Galazin [Mon, 30 Sep 2019 13:42:49 +0000 (15:42 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: I2a0e4c9ff079fa45ea23994cafeaae72ec97831b
Lionel Landwerlin [Wed, 11 Sep 2019 16:17:24 +0000 (19:17 +0300)]
Fix print of uninitialized value
Just fixing a printout in the result file.
Change-Id: Id1b4d3ee9879a07f452c5f5a0310a16d72051848
(cherry picked from commit
2d48a5baf07daeabeca8412ca6ff56d9ac92e2ca)
Igor Ostrowski [Thu, 26 Sep 2019 13:09:28 +0000 (15:09 +0200)]
Check timeline semaphore features only when used.
Affects:
dEQP-VK.synchronization.op.multi_queue.*
Components: Vulkan
VK-GL-CTS issue: 2025
Change-Id: I8c586bcb0199ab00fe6fffb9290abd2b06523916
Alexander Galazin [Mon, 30 Sep 2019 11:47:33 +0000 (13:47 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: I6bb3fb9e6349caed5b4d8f936772051eb4bca529
Lionel Landwerlin [Tue, 10 Sep 2019 11:36:19 +0000 (14:36 +0300)]
Add signal ordering tests
We want to verify that the signaling of semaphores in multiple
VkSubmitInfo a vkQueueSubmit() is ordered.
Add tests:
dEQP-VK.synchronization.signal_order.*
Change-Id: Ibf47e7e4105f479ab33b5bafeda3efdd4c2782b5
(cherry picked from commit
70ed33e49cd109a494b85a0daeb73ff40d3157f9)
Chris Forbes [Fri, 6 Sep 2019 21:01:18 +0000 (22:01 +0100)]
Always require glslang and spirv-tools to be present
The prebuilt shader paths are no longer used. Just require both
dependencies to be present and drop the !DEQP_HAVE_GLSLANG /
!DEQP_HAVE_SPIRV_TOOLS paths.
Mention of prebuilt binaries is removed from the Vulkan CTS readme.
The machinery to actually build all the shaders upfront is left
in place for now as it has value as a presubmit check.
Components: Vulkan, OpenGL
VK-GL-CTS Issue: 1951
Change-Id: I6a79766a07e5aeb3c9c43236a3a220f8b654511e
(cherry picked from commit
d936e5f039f3a8137594bd5f39ab46140ff3079b)
Alexander Galazin [Mon, 30 Sep 2019 09:52:36 +0000 (11:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Ia87303a933940e5483b80b97139f750e5debec10
Pawel Ksiezopolski [Wed, 18 Sep 2019 12:16:22 +0000 (14:16 +0200)]
gen_ext_deps.py made independent from VK versions
Script gen_ext_deps.py has been modified so that it's independent
from incoming Vulkan versions ( it uses <feature> information
from vk.xml to establish what VK versions will be required ).
Accompanying CTS tests have been modified to take advantage
of this modification.
Components: Vulkan Framework
VK-GL-CTS issue: 1954
Change-Id: I2b691e1bd64a6bcb8d1cb7193318aca6bc70655c
(cherry picked from commit
a8ff253688dccdf42da109f4b53c462ac9b9bc1f)
Graeme Leese [Fri, 6 Sep 2019 10:39:27 +0000 (11:39 +0100)]
Use a single test source for quad tests
Rather than repeat this through all the various combinations, just keep
one copy of the test source, so that changing it is not such a massive
pain.
Also, use a single source for the extension enables in the tests.
Components: Vulkan
Affects: dEQP-VK.subgroups.quad.*
Change-Id: Ie3a5734c9ebeaa12c96600c7bd764a62afe7a68e
Mike Byrne [Wed, 18 Sep 2019 14:50:31 +0000 (15:50 +0100)]
Check write vertex support in descriptor indexing
The descriptor indexing tests which are intended to test vertex write
check if the vertexPipelineStoresAndAtomics feature is supported before
loading the descriptorIndexing_vertx_shaderWrites shader. The vertex
write verifcation needs the same check to ensure the verification is
not run when the shader is not present.
Affects: dEQP-VK.descriptor_indexing*
VK-GL-CTS Issue: 2013
Change-Id: I3870b95b65c0b657708788b9bd2a7adcb5bd8f3d
Components: Vulkan
Boris Zanin [Wed, 18 Sep 2019 14:13:55 +0000 (16:13 +0200)]
Request features with VkPhysicalDeviceVulkan12Features
Test creates device requesting feature activation using one of core
structures:
* VkPhysicalDeviceVulkan11Features
* VkPhysicalDeviceVulkan12Features
or appropriate extention structure
Add test:
* dEQP-VK.api.info.vulkan1p2.feature_bits_influence
Components: vulkan
VK-GL-CTS issue: 1993
Change-Id: I1068a5f412cb6d4027656bc6f821184ad4072023
Jason Ekstrand [Wed, 25 Sep 2019 18:59:39 +0000 (13:59 -0500)]
vulkan: Adjust the required max*UpdateAfterBindInputAttachments
Components: Vulkan
VK-GL-CTS issue: 2020
Affects: dEQP-VK.api.info.vulkan1p2.limits_validation
Change-Id: Id1d1ecf19edcdaa9a68bb099d5b7334e347eec22
Lingfeng Yang [Thu, 15 Aug 2019 22:41:23 +0000 (15:41 -0700)]
1d_image: enforce height 1 in decompress stage as well
Affects:
dEQP-VK.image.texel_view_compatible.compute.basic.1d_image*
Components: Vulkan
VK-GL-CTS issue: 1920
Change-Id: Id98f0a8dd132da5bcd6a3f1426021c8f36a48149
Yahan Zhou [Wed, 7 Aug 2019 19:44:50 +0000 (12:44 -0700)]
1d_image: basic: compute: texel_view_compatible: set size.y to 1
1d images need to have size.y=1. Otherwise Vulkan validation layer will
complain.
Affects:
dEQP-VK.image.texel_view_compatible.compute.basic.1d_image*
Components: Vulkan
VK-GL-CTS issue: 1920
Change-Id: I0dd24d612aafb416a74b5eb6f16bb55c76175a0f
Yahan Zhou [Fri, 9 Aug 2019 18:35:15 +0000 (11:35 -0700)]
Texel view compatible: Image: proper check for image format supports
The queried image usage is different from what is acutally used. Fix it
so that we would not end up with an unsupported usage.
Affects:
dEQP-VK.image.texel_view_compatible*
Components: Vulkan
Google bug:
139193497
VK-GL-CTS issue: 1920
Change-Id: Ib8db61808db5f9391a54b7722f965b6608e7e694
Graeme Leese [Mon, 9 Sep 2019 14:18:15 +0000 (15:18 +0100)]
Re-enable non-const broadcast tests
Components: Vulkan
VK-GL-CTS issue: 1933
New tests: dEQP-VK.subgroups.ballot_broadcast.*_nonconst_*
Change-Id: I626f6d17bba6c2c82e019d9695f7fcdd787e4edd
Alexander Galazin [Sun, 22 Sep 2019 08:23:16 +0000 (10:23 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: I943694007a4e5e2512a3f93c257d5c08e7e50218
Jarred Davies [Fri, 13 Sep 2019 17:24:55 +0000 (18:24 +0100)]
Fix depth store flag in seperate_channels tests
Depth wasn't being stored despite being used.
Affects:
dEQP-VK.renderpass*.suballocation.subpass_dependencies.separate_channels.*
Components: Vulkan
VK-GL-CTS Issue: 2002
Change-Id: Ib2c678dcaef1f0c87756424c23057fb1df1c311e
(cherry picked from commit
f5e267274daff5f11ad8e18f81d0abdbc064043d)
Graeme Leese [Thu, 19 Sep 2019 16:01:07 +0000 (17:01 +0100)]
Update glslang
Change-Id: I2ac91546c86305cd72d69ced4c5a6d12d51287db
Jeff Bolz [Fri, 13 Sep 2019 19:57:48 +0000 (14:57 -0500)]
Initialize output buffer in fragment_shader_interlock tests
In discard tests, not all output elements are written by the shader.
Clear the output buffer to zero to match what the test expects. The
output image was already being cleared.
Components: Vulkan
VK-GL-CTS issue: 2004
Affects: dEQP-VK.fragment_shader_interlock.*
Change-Id: Ie1049765ec4b7187b39e3d46261e9abef9f5104d
(cherry picked from commit
7b1cb5b16f44bd9598a2bc4726e78f7c13c84ea7)
Jeff Bolz [Fri, 13 Sep 2019 19:57:48 +0000 (14:57 -0500)]
Initialize output buffer in fragment_shader_interlock tests
In discard tests, not all output elements are written by the shader.
Clear the output buffer to zero to match what the test expects. The
output image was already being cleared.
Components: Vulkan
VK-GL-CTS issue: 2004
Affects: dEQP-VK.fragment_shader_interlock.*
Change-Id: Ie1049765ec4b7187b39e3d46261e9abef9f5104d
Jari Komppa [Tue, 17 Sep 2019 08:27:59 +0000 (11:27 +0300)]
Add build option for amber to use shared C runtime
Adding build option for Amber to avoid C runtime conflicts with CTS
Affects: None
Components: Vulkan, Framework
VK-GL-CTS issue: 2001
Change-Id: Ie9f9d8efee887996de843e545b808ff200e5103a
(cherry picked from commit
6500c70cbbbf32709a80417f1a54b35e568fd9d7)
Jari Komppa [Tue, 17 Sep 2019 08:27:59 +0000 (11:27 +0300)]
Add build option for amber to use shared C runtime
Adding build option for Amber to avoid C runtime conflicts with CTS
Affects: None
Components: Vulkan, Framework
VK-GL-CTS issue: 2001
Change-Id: Ie9f9d8efee887996de843e545b808ff200e5103a
Boris Zanin [Mon, 16 Sep 2019 06:47:45 +0000 (08:47 +0200)]
Check only Vulkan 1.1 and 1.2 limits
Removce all extension limits check. They are expected to be tested
in a per-extension separate tests. The per-extension tests are
expected to be committed in a separate commit.
Update test:
* dEQP-VK.api.info.vulkan1p2.limits_validation
Components: vulkan
VK-GL-CTS issue: 1999, 1924, 2008
Change-Id: Ice55c8f61500699dcfd7715df7dd3270193774b7
Alexander Galazin [Wed, 18 Sep 2019 19:14:03 +0000 (21:14 +0200)]
Update headers
Components: Vulkan
Change-Id: Id0a9c7f59e1557e53d9074ad73b73a80bcf2ef22
Alexander Galazin [Wed, 18 Sep 2019 16:12:50 +0000 (18:12 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: Iec182e5892633045b5f1b821e9f6259bd1c3d40c
Graeme Leese [Mon, 2 Sep 2019 16:49:51 +0000 (17:49 +0100)]
Combine ARB and Core subgroupBroadcast code
The ARB and core tests are attempting to do the same thing but using
slightly different names for the functions. Parameterise the names so
that we only have to maintain one copy of the test logic.
Also, make it so that we only have to write out the extensions that we
need once.
Components: Vulkan
Affects: dEQP-VK.subgroups.ballot_broadcast.*
Change-Id: I259249abba2b352dbd217aa4c26100ab7dbee637
(cherry picked from commit
84ddfc07a5b15a580590d5b405e1c5ff55b70fd9)
Piers Daniell [Tue, 10 Sep 2019 22:33:58 +0000 (16:33 -0600)]
Increase the sleep measurement tolerance to 100ms
The calibration_test works by measuring the "before"
device time, sleeping the thread for 200ms, and then
measuring the "after" device time. It then checks
the "after"-"before" delta is not more than 200ms
plus/minus 10ms.
This 10ms is too short for many systems and may
result in false failures. If the system is heavily
loaded the thread may sleep for more than 200ms.
Increasing the tolerance to 100ms appears to
eliminate the false failure I've been seeing.
Affects:
dEQP-VK.pipeline.timestamp.calibrated.calibration_test
Components: Vulkan
VK-GL-CTS issue: 1990
Change-Id: Ifc7f877daf8e361e39b3cd9ee447445529fd01d7
Gary Sweet [Wed, 11 Sep 2019 10:44:27 +0000 (11:44 +0100)]
Require standardSampleLocations for imageless fb resolve tests
The resolve tests require known sample locations in order to check
the results. If standardSampleLocations is not supported, report
these tests as unsupported.
Affects: dEQP-VK.imageless_framebuffer.*
Components: Vulkan
VK-GL-CTS issue: 1987
Change-Id: I4dbec37df8606ecb994d3b343dee42c5dee6738d
Marcin Kańtoch [Fri, 13 Sep 2019 14:42:54 +0000 (16:42 +0200)]
Fix indexing a push constant array member
gl_VertexIndex is used to index a push constant array member.
Vulkan spec says: Any member of a push constant block that is
declared as an array must only be accessed with dynamically
uniform indices. But gl_VertexIndex is not dynamically uniform.
Changed the test to use dynamically uniform indexing.
Affects:
dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.vert_pc_entry_point
Components: Vulkan
VK-GL-CTS issue: 2000
Change-Id: I767aacfe0fde27e083f7b4a82f808cb99fb31d16
Alexander Galazin [Thu, 12 Sep 2019 18:08:56 +0000 (19:08 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.2.0
Change-Id: I138bdc04aecc86f159b8b755ad80fb9f84b11681
Alexander Galazin [Thu, 12 Sep 2019 17:26:06 +0000 (18:26 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5
Change-Id: I3b42845035fc496956deb9880ae222aa6eea1ad4