Kai Koehne [Wed, 31 Aug 2011 07:23:45 +0000 (09:23 +0200)]
Debugger: Add private header warning to all _p.h files
Change-Id: Ib5cccd8a2f252a2e67c8e0fdf979c3e8114ff131
Reviewed-on: http://codereview.qt.nokia.com/3940
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Kai Koehne [Wed, 31 Aug 2011 07:19:57 +0000 (09:19 +0200)]
Debugger: Canonalize header defines
Change-Id: I2cbe704326e993c47dd78182683787394f598ae4
Reviewed-on: http://codereview.qt.nokia.com/3939
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Wed, 31 Aug 2011 07:17:57 +0000 (09:17 +0200)]
Debugger: Add missing QT_BEGIN_NAMESPACE, QT_END_NAMESPACE
Change-Id: I7cb404eac7a3f469fc6b1d40398ab0c40787cc8d
Reviewed-on: http://codereview.qt.nokia.com/3938
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Wed, 31 Aug 2011 07:15:05 +0000 (09:15 +0200)]
Debugger: Fix indentation & trailing whitespace
Change-Id: I4b85b205a359e4c3adc1fcb6682945724a0910c5
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Reviewed-on: http://codereview.qt.nokia.com/3937
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Kai Koehne [Wed, 31 Aug 2011 09:30:31 +0000 (11:30 +0200)]
Debugger: Also fix the name of the qdeclarativedebug autotest
Change-Id: Ia9d31f9228b9d9e63eccaf2577bf24b3929e5fad
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Reviewed-on: http://codereview.qt.nokia.com/3936
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Kim Motoyoshi Kalland [Wed, 31 Aug 2011 15:40:42 +0000 (17:40 +0200)]
Exported QSGShaderEffectMesh.
Reintroduced the possibility to set the ShaderEffect::mesh
property to any object deriving from QSGShaderEffectMesh.
Change-Id: Idf91b2289d4e7b8fd12993a4a2bc1647dfba0ae0
Reviewed-on: http://codereview.qt.nokia.com/4003
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Bea Lam [Fri, 2 Sep 2011 08:04:00 +0000 (18:04 +1000)]
Ensure layout is done after delayed deletion of items
Regression from
1dd8b509074ba60da671f7671f8cf09c3fc001ae
Change-Id: I5957444e2f1493aa8fbf3b532fd1ef704deec50c
Reviewed-on: http://codereview.qt.nokia.com/4118
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Damian Jansen [Fri, 26 Aug 2011 05:38:56 +0000 (15:38 +1000)]
Update more examples to QtQuick 2.0
Minehunt and abstractitemmodel examples use QSGview
Snake now using Particles 2.0
Minor examples and twitter have updated imports
Removed duplicate delegate example
Change-Id: I04f8f8aeb8ef34ab2a8678ccc1d6d594b9db166e
Reviewed-on: http://codereview.qt.nokia.com/3630
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Damian Jansen [Fri, 26 Aug 2011 01:51:32 +0000 (11:51 +1000)]
Update various examples to QtQuick 2.0
And remove many duplicate and obsolete files
Change-Id: I5416b2b276893d85233918b1a24a30659830d42e
Reviewed-on: http://codereview.qt.nokia.com/3623
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Damian Jansen [Fri, 26 Aug 2011 00:31:39 +0000 (10:31 +1000)]
Update text examples to QtQuick 2.0, remove obsolete files
Change-Id: I7181c3d26e85459597f06bba174885ced40ffe1d
Reviewed-on: http://codereview.qt.nokia.com/3618
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Damian Jansen [Thu, 25 Aug 2011 23:23:28 +0000 (09:23 +1000)]
Update modelviews examples to QtQuick 2.0
Also make abstractitemmodel example compile in 5.0 and
remove obsolete files.
Change-Id: Ic09f3878bb0b070e0f77398599d39952758acb8f
Reviewed-on: http://codereview.qt.nokia.com/3615
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Damian Jansen [Thu, 25 Aug 2011 05:11:13 +0000 (15:11 +1000)]
Update rssnews, focus and positioners examples to QtQuick 2.0
Change-Id: I187acb734e78552088b85503dd3542e1b1101944
Reviewed-on: http://codereview.qt.nokia.com/3556
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Damian Jansen [Thu, 25 Aug 2011 03:55:54 +0000 (13:55 +1000)]
Update calculator, i18n, imageelements examples to QtQuick 2.0
Change-Id: Ib506f6b1daf431135c6608bdf1c5ea3afe08b213
Reviewed-on: http://codereview.qt.nokia.com/3551
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Damian Jansen [Thu, 25 Aug 2011 02:46:03 +0000 (12:46 +1000)]
Update animation examples to QtQuick 2.0 and remove obsolete files.
Change-Id: If29cf056b37fbc45e29d81dac43414261aa74034
Reviewed-on: http://codereview.qt.nokia.com/3545
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Damian Jansen [Wed, 24 Aug 2011 04:51:35 +0000 (14:51 +1000)]
Update toys examples to QtQuick 2.0 and remove obsolete files
Change-Id: I5ca6a459df532a5c551430f3f1029ec961a75233
Reviewed-on: http://codereview.qt.nokia.com/3441
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Bea Lam [Thu, 1 Sep 2011 03:52:23 +0000 (13:52 +1000)]
Don't emit attached add() and remove() for moved items
Regression from
6fbc4b7e7e5aed8739ca1143e0fc1e38b8c8e17a
Change-Id: I0bcd55548dca1559deea0d66112e7cdeb3da4ed9
Reviewed-on: http://codereview.qt.nokia.com/4023
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Chris Adams [Mon, 22 Aug 2011 05:51:28 +0000 (15:51 +1000)]
Allow conversion of QObject Module API to QVariant
This commit adds a conversion codepath for QV8TypeResource to QVariant
where the resource contains a QObject module API. This allows such a
module API to be used as the "target" in a Connections element.
Task-number: QTBUG-20937
Change-Id: I9214b531968f2e6981a86e643859a97297c6a02a
Reviewed-on: http://codereview.qt.nokia.com/3286
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Michael Brasser [Wed, 31 Aug 2011 02:36:32 +0000 (12:36 +1000)]
Allow reference to signals using 'on' handler syntax.
This will allow APIs like the following:
trigger: mouseArea.onClicked
However, signal handlers will not be callable from QML:
mouseArea.onClicked() //throws exception
Change-Id: I2ef5cb4e1f3ed4814ef590962391e1b14e3f0c43
Reviewed-on: http://codereview.qt.nokia.com/3683
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Bea Lam [Tue, 30 Aug 2011 06:02:41 +0000 (16:02 +1000)]
Remove scheduleLayout() and layoutScheduled
No longer necessary since views now call QSGItem::polish() which
does its own layout scheduling and only does layouts when
necessary
Change-Id: I7d265fcf4177344c4ba10600b551a5545284316f
Reviewed-on: http://codereview.qt.nokia.com/3843
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Mon, 29 Aug 2011 05:33:36 +0000 (15:33 +1000)]
Batch view changes instead of applying them immediately
If there are multiple changes to be applied to a view before the next
repaint, collate them using QDeclarativeChangeSet and apply the changes
as a group on the next layout(). (Note that changes to the current index
are applied in sequence as changes are received, since changing it out
of order produces different results.)
Previously, any itemsInserted(), itemsRemoved() and itemsMoved() changes
were immediately applied and items were repositioned immediately. In
this situation if the same indexes changed multiple times between
repaints, this could lead to redundant changes and bugs arising from
multiple changes to the same items.
Functions that will execute differently depending on whether pending
view changes have been applied (e.g. count(), currentIndex(),
highlight()) now call applyPendingChanges() before proceeding to ensure
they are executed on a view that is up to date.
Also, itemsMoved() operations that moved item/s backwards will now
properly move backwards instead of being adjusted to a forward movement
(which was implemented recently with
e2b5681b1adab83555c7307b05f508d796a1152b) since backwards movements can
be implemented more easily with the batched changes which translates
moves into insert/remove actions.
Change-Id: If9b39755898e8d2ed7e4bc61288206d5f1d653fd
Reviewed-on: http://codereview.qt.nokia.com/3697
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Marco Bubke [Wed, 31 Aug 2011 16:29:13 +0000 (18:29 +0200)]
Add bounding rectangle for rendering images in designer support
Elements can be outside the root items bounding rectange. So we compute
the bounding rectangle of an item and its children on the designer side. We
exclude all children which are the designer created.
Change-Id: I3c4f9ca5291c8f65e3670be1fd0900edf449b46f
Reviewed-on: http://codereview.qt.nokia.com/3963
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Kai Koehne [Wed, 31 Aug 2011 07:12:39 +0000 (09:12 +0200)]
Debugger: Rename qdeclarativedebug* to qdeclarativeenginedebug*
Change-Id: I0c289bdf555aa317dc12c5dbcff0168ebcc7bd50
Reviewed-on: http://codereview.qt.nokia.com/3935
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Tue, 30 Aug 2011 15:21:30 +0000 (17:21 +0200)]
Rename QDeclarativeEngineDebugServer to ~Service
And fix the file names/location, too
Change-Id: If2d5ec0896332896ad11af748ec8f75c39e1555c
Reviewed-on: http://codereview.qt.nokia.com/3890
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Tor Arne Vestbø [Wed, 31 Aug 2011 11:50:21 +0000 (13:50 +0200)]
Fix build with Clang
We have to qualify calls to baseclass functions in templates. See:
http://clang.llvm.org/compatibility.html#dep_lookup_bases
Change-Id: If779f1789d269f20a0255d63b1a7d6b9fef0118e
Reviewed-on: http://codereview.qt.nokia.com/3961
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Kai Koehne [Wed, 31 Aug 2011 07:05:00 +0000 (09:05 +0200)]
Autotests: Silence gdb warning about deprecated conversion
Fix "warning: deprecated conversion from string constant to ‘char*"
Change-Id: Ie8a4b0caba351e5920cc7d3249ee023bfe7675bc
Reviewed-on: http://codereview.qt.nokia.com/3934
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Marco Bubke [Tue, 30 Aug 2011 15:34:39 +0000 (17:34 +0200)]
Add an abstraction layer for the qml designer
The Qml Designer for Qt4 is using private headers but this broke very
often because nobody outside of the designer team was aware of it. This
is an attempt to define a clear interface which the designer is using.
Change-Id: I9ad2db234043da8e787024d3c2d346356bbbef47
Reviewed-on: http://codereview.qt.nokia.com/3608
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Alan Alpert [Wed, 31 Aug 2011 07:53:38 +0000 (17:53 +1000)]
Add #version 120 in more places.
Desktop GL implementations don't seem bothered, but not all the ES 2
ones could handle it.
Change-Id: I93af18be342d8d418067a54769d69efc87442886
Reviewed-on: http://codereview.qt.nokia.com/3916
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Alan Alpert [Tue, 30 Aug 2011 02:58:45 +0000 (12:58 +1000)]
Rename PointAttractor x,y to pointX,pointY
Avoid hiding the Item properties, which still have an effect.
Change-Id: I2449c376fe0f2c769792e4bb7b23899672cce5e1
Reviewed-on: http://codereview.qt.nokia.com/3837
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Chris Adams [Wed, 17 Aug 2011 07:46:54 +0000 (17:46 +1000)]
Allow initial property values to be defined with QSGLoader
This commit adds an "active" property to QSGLoader, which can be
used to delay instantiation of the item until the user wishes to
activate the loader. The property is true by default in order to
maintain compatibility with previous behaviour.
The commit also adds a "setSource(v8object)" function to QSGLoader,
which behaves identically to setSource() property mutator except that
it takes a JavaScript object parameter which defines the initial
property values of the item (in a manner similar to that of
QDeclarativeComponent::createObject()).
Task-number: QTBUG-17009
Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1
Reviewed-on: http://codereview.qt.nokia.com/3364
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Alan Alpert [Mon, 29 Aug 2011 08:49:24 +0000 (18:49 +1000)]
setting only colorVariation now works
Wasn't realizing it needed colored shaders for it.
Change-Id: I9d5693d8f8f470d3239339d4457c576f5b40fe3f
Reviewed-on: http://codereview.qt.nokia.com/3723
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Martin Jones [Wed, 31 Aug 2011 05:54:54 +0000 (15:54 +1000)]
QtDeclarative does not use libQtSvg
Change-Id: Iac81489c651e5252a7966eaff462d5fd37bf37d3
Reviewed-on: http://codereview.qt.nokia.com/3910
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Michael Brasser [Wed, 31 Aug 2011 04:07:32 +0000 (14:07 +1000)]
Support QT_TRID_NOOP in ListElement.
Task-number: QTBUG-21070
Change-Id: I91f68467ed96c89fe18726372348ebe809099f60
Reviewed-on: http://codereview.qt.nokia.com/3906
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Alan Alpert [Tue, 30 Aug 2011 04:35:09 +0000 (14:35 +1000)]
Custom Particle now supplies default code
Attributes and a sample function are now prepended to the vertex shader,
allowing many to become simple again.
Change-Id: Ie1fbc864bd0d58647cb67994b96c2cb88db92f10
Reviewed-on: http://codereview.qt.nokia.com/3839
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Glenn Watson <glenn.watson@nokia.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Chris Adams [Mon, 22 Aug 2011 07:01:04 +0000 (17:01 +1000)]
Add enums support to QObject module APIs
This commit adds support for retrieving enum values from QObject
module APIs.
Task-number: QTBUG-21033
Task-number: QTBUG-21056
Change-Id: Ib2bd107f3f5905e2d2d35f8a20c55045ef9bb322
Reviewed-on: http://codereview.qt.nokia.com/3291
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Caio Marcelo de Oliveira Filho [Mon, 29 Aug 2011 13:11:31 +0000 (10:11 -0300)]
Do not deliver hover events when item is not visible
This patch change the code to also skip invisible items (it was
done for disabled already) when deciding whether or not deliver the
hover events to an item. The rationale here is to follow the same
rule as the other mouse events.
Change-Id: If0fe6d64d1f7cfb8679ce11edda7c02dc3783f9b
Reviewed-on: http://codereview.qt.nokia.com/3861
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Caio Marcelo de Oliveira Filho [Mon, 29 Aug 2011 13:08:45 +0000 (10:08 -0300)]
Fix extra hover enter events being sent by QSGCanvas
This fixes two issues: when one item is entered it is getting the
enter event twice. When we are moving from two items that share the
same parent, the parent is getting enter event -- which shouldn't
happen.
Change-Id: If0fe6d64d1f7cfb8679ce11edda7c02dc3783f9a
Reviewed-on: http://codereview.qt.nokia.com/3860
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Roberto Raggi [Tue, 30 Aug 2011 09:45:36 +0000 (11:45 +0200)]
Fix the directory cache for case insensitive file systems.
Authored-by: Martin Jones
Change-Id: Iebedfa077487f4fa1cab6d159cc4bd1e7b0b7184
Reviewed-on: http://codereview.qt.nokia.com/3870
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 29 Aug 2011 12:10:12 +0000 (14:10 +0200)]
Fix diagnostic messages.
Change-Id: Id06ff4237129ef5525032c9a2510e4316be52ae2
Reviewed-on: http://codereview.qt.nokia.com/3802
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 29 Aug 2011 09:52:17 +0000 (11:52 +0200)]
Fix merge errors introduced while rebasing.
Change-Id: I14973b94f404f9e4fe06b192ef177f01e0f5ef01
Reviewed-on: http://codereview.qt.nokia.com/3801
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 25 Aug 2011 07:21:28 +0000 (09:21 +0200)]
Fix the tst_qdeclarativedebug auto test.
The creation order in QML is not defined.
Change-Id: I4bc3d9e56e32a0c907cdaef9994ae66c3869a4ea
Reviewed-on: http://codereview.qt.nokia.com/3800
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Tue, 23 Aug 2011 16:17:51 +0000 (18:17 +0200)]
Fix the search of QML types.
Stop iterating the multi hash as soon as we find an element with
a different key.
Change-Id: Ie474708229b4040e66b17ceffc5be787856bc905
Reviewed-on: http://codereview.qt.nokia.com/3799
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Tue, 23 Aug 2011 14:55:32 +0000 (16:55 +0200)]
Fix wrong assertion in StringRef::load.
Change-Id: Ib39804b87027bda8cc6694b26e98e18bbc3a159f
Reviewed-on: http://codereview.qt.nokia.com/3798
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Tue, 23 Aug 2011 01:41:50 +0000 (11:41 +1000)]
Move all QML file parsing into the QDeclarativeScript namespace
Change-Id: I5969686a796cbfb2eeb3729014df7f01e51b0620
Reviewed-on: http://codereview.qt.nokia.com/3797
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Roberto Raggi [Mon, 22 Aug 2011 14:36:04 +0000 (16:36 +0200)]
Collect the source locations of the single and multiline comments.
Change-Id: I7a8f2eec7a45f7a9a1212680f477cc5edd2aaad5
Reviewed-on: http://codereview.qt.nokia.com/3796
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 22 Aug 2011 13:27:04 +0000 (15:27 +0200)]
Fix the qmldir parser diagnostic messages.
Change-Id: I752d5cf334faa5761007f553caf49e64d0e1f411
Reviewed-on: http://codereview.qt.nokia.com/3795
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 22 Aug 2011 13:26:10 +0000 (15:26 +0200)]
Update the tst_qdeclarativelanguage::errors() auto test.
Change-Id: I953eecefbf177c7d415b64814cea5ca2611787c3
Reviewed-on: http://codereview.qt.nokia.com/3794
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 22 Aug 2011 11:46:33 +0000 (13:46 +0200)]
Fix lookup of non scriptable default properties.
Change-Id: I027169a54dc0041212d38aefc99164930c31d2b2
Reviewed-on: http://codereview.qt.nokia.com/3793
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 18 Aug 2011 14:36:10 +0000 (16:36 +0200)]
Fix property lookup in QDeclarativePropertyCache::create.
Search for the property in the current meta object.
Change-Id: I085f4285298ae952d9c50ee93c47b4009dbe900f
Reviewed-on: http://codereview.qt.nokia.com/3792
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 18 Aug 2011 14:35:56 +0000 (16:35 +0200)]
Fix compilation.
Change-Id: I75433c3c716b6df33b75d32805fcca822f49a202
Reviewed-on: http://codereview.qt.nokia.com/3791
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 18 Aug 2011 11:01:05 +0000 (13:01 +0200)]
Fix type of valuetype alias properties.
Update the type and the typename after changing the value of
aliasProperty.
Change-Id: Id0b9d9a66f14524fec6bf23c375ae9af448cbbf3
Reviewed-on: http://codereview.qt.nokia.com/3790
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 18 Aug 2011 09:39:22 +0000 (11:39 +0200)]
Fix the source location of the T_ELSE token.
Change-Id: I9cb9effad495ae7b20a56c5a8943efbeae95c179
Reviewed-on: http://codereview.qt.nokia.com/3789
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Wed, 17 Aug 2011 12:27:37 +0000 (14:27 +0200)]
Fix parsing of numeric literals.
Store the value in a double.
Change-Id: I17b90d2917a2710d434a92b5f6b297f755156c31
Reviewed-on: http://codereview.qt.nokia.com/3788
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Tue, 16 Aug 2011 14:52:50 +0000 (16:52 +0200)]
Fix the computation of the start token position.
Rewind the buffer pointer only when necessary.
Change-Id: Idd78edc068b1c55d79c5674facd9c55270e536a8
Reviewed-on: http://codereview.qt.nokia.com/3787
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Roberto Raggi [Mon, 15 Aug 2011 13:31:07 +0000 (15:31 +0200)]
Fix initialization order.
Change-Id: I7a7121f658f85c88b3a5260481cf4e05df2dd218
Reviewed-on: http://codereview.qt.nokia.com/3786
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 25 Jul 2011 15:05:02 +0000 (17:05 +0200)]
Replace the hash tables with simple association lists.
Change-Id: If4fdd14bba6d800699be1bfd9f6b147bb5279a30
Reviewed-on: http://codereview.qt.nokia.com/3785
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 25 Jul 2011 06:31:21 +0000 (08:31 +0200)]
Merge IR::Module and IR::Function.
V4 compiles one function at time. There is no reson to keep
IR::Module and IR::Function as separate classes.
Change-Id: Ia6bf971d0d499b14847c3ca725f9cdf5c7e3916c
Reviewed-on: http://codereview.qt.nokia.com/3784
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Tue, 9 Aug 2011 13:04:14 +0000 (15:04 +0200)]
Set the name of the default property
Change-Id: I4f69b9e4e33a789215941f8021b8937c8aa2e7c1
Reviewed-on: http://codereview.qt.nokia.com/3783
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Roberto Raggi [Thu, 4 Aug 2011 09:21:19 +0000 (11:21 +0200)]
Fix wrong usage of QStringHash iterators.
The code was creating circular lists of overloads.
Change-Id: I126140dae90fbdf71a53fc8163fe2b56bb069312
Reviewed-on: http://codereview.qt.nokia.com/3782
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Tue, 2 Aug 2011 07:57:01 +0000 (09:57 +0200)]
Recompute the token length after the scan of a regexp.
Change-Id: I9042f261b374bee1a3f9cb8d2dc40e381a66732b
Reviewed-on: http://codereview.qt.nokia.com/3781
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 1 Aug 2011 16:04:30 +0000 (18:04 +0200)]
Fix visit of list-like AST nodes.
The method finish() of a list-like node will convert the circular
list to a single-list. The right way to iterate is by looking
at the member `next' and by invokign finish().
Change-Id: I85a45b691a6c7089cd1a765871a11a7c60c3cdff
Reviewed-on: http://codereview.qt.nokia.com/3780
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 1 Aug 2011 16:03:41 +0000 (18:03 +0200)]
Fix possible crash when using the QML lexer without an engine.
Change-Id: Ia7d820cf1a63eaf42041ab78e1f111d31358e4dd
Reviewed-on: http://codereview.qt.nokia.com/3779
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 1 Aug 2011 15:08:06 +0000 (17:08 +0200)]
Fix initialization of QDeclarativeVMEMetaData::PropertyData for variant properties.
The propertyType member for variant properties needs to be initialized to -1 (at least
according to QDeclarativeVMEMetaObject::metaCall).
Change-Id: I44f226f2bce3732f3a4220fe24617b5cb2292f97
Reviewed-on: http://codereview.qt.nokia.com/3778
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 1 Aug 2011 14:49:08 +0000 (16:49 +0200)]
Fix comparison.
Change-Id: I58ae5237f3458ee4bada89d1d676645e575d681f
Reviewed-on: http://codereview.qt.nokia.com/3777
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Mon, 1 Aug 2011 14:48:33 +0000 (16:48 +0200)]
Compile.
Change-Id: Id8af2a65e54317a9300289a034c042d59b2c69bd
Reviewed-on: http://codereview.qt.nokia.com/3776
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 28 Jul 2011 11:20:49 +0000 (13:20 +0200)]
Remove deprecated QChar to ushort conversions.
Change-Id: I2411d2221e70685d1a1518e2f5eb2e693261e00d
Reviewed-on: http://codereview.qt.nokia.com/3775
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Martin Jones [Fri, 22 Jul 2011 07:23:16 +0000 (17:23 +1000)]
Faster check for revisioned properties.
Change-Id: I8122c15d0467019bcd333ca111d2b248c5ca2d91
Reviewed-on: http://codereview.qt.nokia.com/3774
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Fri, 22 Jul 2011 06:18:06 +0000 (16:18 +1000)]
Special case integers and strings in lexer
Reduces the amount of copying for integer numbers and uses a raw
QStringRef for unescaped strings.
Change-Id: I2ad29f4c67be72495e3209081761b9a1bb503f26
Reviewed-on: http://codereview.qt.nokia.com/3773
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Fri, 22 Jul 2011 04:40:37 +0000 (14:40 +1000)]
Reduce allocations
Change-Id: I230424147ad195239d725359fcd6dc5568f102a7
Reviewed-on: http://codereview.qt.nokia.com/3772
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Martin Jones [Fri, 22 Jul 2011 06:08:51 +0000 (16:08 +1000)]
less toUtf8()
Change-Id: I9c4b599511e755b8f93d8bb8a7cd3732ca380de0
Reviewed-on: http://codereview.qt.nokia.com/3771
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Martin Jones [Fri, 22 Jul 2011 04:52:08 +0000 (14:52 +1000)]
Remove some QString <-> utf8 conversions.
Change-Id: I4478ec805f5b1e05025baafaf7035b8fb57f9854
Reviewed-on: http://codereview.qt.nokia.com/3770
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Fri, 22 Jul 2011 03:32:47 +0000 (13:32 +1000)]
Optimize default property resolution in compiler
Change-Id: I90b677a190c0c59ba681a7643a9b13cfb938d5a1
Reviewed-on: http://codereview.qt.nokia.com/3769
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Fri, 22 Jul 2011 01:51:41 +0000 (11:51 +1000)]
Use the cached property data when possible
Change-Id: I6690208b9a4d99e485874c5253d69cb82938c8a6
Reviewed-on: http://codereview.qt.nokia.com/3768
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Thu, 21 Jul 2011 13:08:53 +0000 (23:08 +1000)]
Introduce QHashField for use in "contains" tests.
Change-Id: I35aadace15b71b44c1b9e30a76eadf79fe03afad
Reviewed-on: http://codereview.qt.nokia.com/3767
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Thu, 21 Jul 2011 07:38:30 +0000 (17:38 +1000)]
Use QFieldList to manage dynamic properties, signals and slots
Change-Id: I27282a035a631dde30ee97412d3968ab525b2502
Reviewed-on: http://codereview.qt.nokia.com/3766
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Thu, 21 Jul 2011 10:01:07 +0000 (20:01 +1000)]
Calculate the hash inside QHashedString
This avoids calling into V8 to calculate the hash. This improves
performance and removes the dependency on V8.
Change-Id: I8ccb405cba15c7eda51a1d56652784164789de7f
Reviewed-on: http://codereview.qt.nokia.com/3765
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Thu, 21 Jul 2011 04:20:05 +0000 (14:20 +1000)]
Use strings more conservatively
Also adds the ability to efficiently estimate the length of, and
write out to, UTF8 from QHashedStringRef.
Change-Id: I8b6226ba41d855246ddf7d6268f8045c92ae219e
Reviewed-on: http://codereview.qt.nokia.com/3764
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Wed, 20 Jul 2011 07:47:57 +0000 (17:47 +1000)]
Add QFastMetaBuilder
This is a faster, but less convenient, version of QMetaObjectBuilder.
The aim is to reduce allocations made during building the meta object
by doing it in two passes - first you reserve all the strings needed
and then you provide their data.
Change-Id: Id9caf9c9c6c2ab6a5219e5cea9363463a4ebf822
Reviewed-on: http://codereview.qt.nokia.com/3763
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Martin Jones [Fri, 22 Jul 2011 00:40:01 +0000 (10:40 +1000)]
Inline a couple of often used methods.
Change-Id: I6fdcebd45835e7700fc470790a259e256fa68066
Reviewed-on: http://codereview.qt.nokia.com/3762
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 21 Jul 2011 13:09:15 +0000 (15:09 +0200)]
Compile
Change-Id: Id7a5520d0e344b708aabacd0b0aefa705b47b197
Reviewed-on: http://codereview.qt.nokia.com/3761
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Thu, 21 Jul 2011 12:47:26 +0000 (14:47 +0200)]
Speedup the V4 code generation.
Skip discarded code and use QVarLengthArray instead of
QByteArray to store the bytecode.
Change-Id: I4c574e7a817595bc8942ed9a927e79339a2d7b40
Reviewed-on: http://codereview.qt.nokia.com/3760
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Wed, 20 Jul 2011 10:51:12 +0000 (12:51 +0200)]
Use QDeclarativePool to allocate the V4 instructions.
Change-Id: Ib4a9748bf81392a901c8ae94a8746f2e52f7284e
Reviewed-on: http://codereview.qt.nokia.com/3759
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Tue, 19 Jul 2011 13:12:40 +0000 (15:12 +0200)]
Change the V4 IR so it can be stored in a memory pool.
That is, remove members with a non-trivial destructor from IR::Stmt
and IR::Expr (that's because we don't destroy the objects
allocated in the pool).
Added the method MemoryPool::reset() so we can clear the pool
without disposing the allocated memory.
Change-Id: I126332be387c016578c086db8b3aa8098b2507f6
Reviewed-on: http://codereview.qt.nokia.com/3758
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Tue, 19 Jul 2011 09:16:33 +0000 (11:16 +0200)]
Removed QDeclarativeJS::NodePool
Change-Id: I69d39ef005900803f6c620ea8f1ca00d054dc8d2
Reviewed-on: http://codereview.qt.nokia.com/3757
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Martin Jones [Thu, 21 Jul 2011 09:05:45 +0000 (19:05 +1000)]
Some lexer improvement, mostly by avoiding QChar::isWhatever()
Change-Id: I330a45a2f611a594d9b0e9bb24ebef028654a8d8
Reviewed-on: http://codereview.qt.nokia.com/3756
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Roberto Raggi [Wed, 20 Jul 2011 13:08:05 +0000 (15:08 +0200)]
Improved parsing of numeric literals
Change-Id: Id02b5b0b0ab590b7ea5d20098472459e1fd986a6
Reviewed-on: http://codereview.qt.nokia.com/3755
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Martin Jones [Wed, 20 Jul 2011 04:03:03 +0000 (14:03 +1000)]
Optimizations to imports.
Change-Id: If4a51ad3b7c0ecc2261eea1d07a949119c3ad860
Reviewed-on: http://codereview.qt.nokia.com/3754
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Mon, 18 Jul 2011 06:21:21 +0000 (16:21 +1000)]
Don't unnecessarily construct QMetaPropertys
As we store everything as a QDeclarativePropertyCache::Data internally
anyway, operate exclusively against this structure.
Change-Id: Id963bc001ce56ebf07b9b13082bb082d5d93ddd2
Reviewed-on: http://codereview.qt.nokia.com/3753
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Martin Jones [Mon, 18 Jul 2011 04:28:10 +0000 (14:28 +1000)]
Clearing a hash makes its length 0.
Change-Id: Ie5b1251212b504d7a7621abdd7fe4e9305790846
Reviewed-on: http://codereview.qt.nokia.com/3752
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Fri, 15 Jul 2011 08:08:51 +0000 (18:08 +1000)]
Remove unnecessary toString()
Change-Id: I0c39bf9c96d65ba1ed4faffffebfd9b89016b3d7
Reviewed-on: http://codereview.qt.nokia.com/3751
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Fri, 15 Jul 2011 07:46:43 +0000 (17:46 +1000)]
Improve performance of the QML front-end
Introduced a new lexer and a more efficient representation of
the AST. Instead of creating unique name ids, we simply use
QStringRef(s).
Change-Id: I403472fa2bb74d2c87dd6314065306499677a3bf
Authored-by: Roberto Raggi
Reviewed-on: http://codereview.qt.nokia.com/3750
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Martin Jones [Fri, 15 Jul 2011 07:37:23 +0000 (17:37 +1000)]
Remove invalid assert
Change-Id: Ia0544cf8c1d236977f193ad4c5726217035cabcb
Reviewed-on: http://codereview.qt.nokia.com/3749
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Martin Jones [Fri, 15 Jul 2011 07:19:17 +0000 (17:19 +1000)]
Cache QML import directories and qmldir files.
Also a little less toUtf8().
Change-Id: Iefb255fad9e27553f29b184418e66ce317f1cd89
Reviewed-on: http://codereview.qt.nokia.com/3748
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Thu, 14 Jul 2011 07:34:06 +0000 (17:34 +1000)]
Remove some QHash and QLists.
Change-Id: I153fa1abbe27f0724e453c5c979f740e956819c9
Reviewed-on: http://codereview.qt.nokia.com/3747
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Fri, 15 Jul 2011 06:28:40 +0000 (16:28 +1000)]
QStringHash improvements
Change-Id: I1844460095f4de4980d458dc696c0aab8b504c23
Reviewed-on: http://codereview.qt.nokia.com/3746
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Thu, 14 Jul 2011 05:35:39 +0000 (15:35 +1000)]
Improve QStringHash
We now support reserving nodes, and keys that are ASCII strings.
Change-Id: I9cc04438a1e9ceee1081cb1216e0273227551222
Reviewed-on: http://codereview.qt.nokia.com/3745
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Wed, 13 Jul 2011 04:12:21 +0000 (14:12 +1000)]
Use memory more conservatively during QML compilation
Change-Id: I63af79e575345bce00d724f1e7c87606156d1479
Reviewed-on: http://codereview.qt.nokia.com/3744
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Tue, 12 Jul 2011 05:22:40 +0000 (15:22 +1000)]
Move tools classes into their own directory
Change-Id: Ic8a3a35f36259659cb83b5e11641af47bd8b18a9
Reviewed-on: http://codereview.qt.nokia.com/3743
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Mon, 11 Jul 2011 01:03:31 +0000 (11:03 +1000)]
Remove some QByteArray<->QString conversions
Change-Id: Ieba3e1754d6438bb13fe7bf9963456a29d122129
Reviewed-on: http://codereview.qt.nokia.com/3742
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Aaron Kennedy [Wed, 6 Jul 2011 03:43:47 +0000 (13:43 +1000)]
More efficient type name cache
Instead of creating completely separate hashes for all the types used
by every QML file, we simply link to the QDeclarativeTypeModule. This
uses much less memory, and is faster to construct at startup.
Change-Id: I28bc2807074f9c6f38096d6e4ce8be744159d023
Reviewed-on: http://codereview.qt.nokia.com/3741
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Kent Hansen [Tue, 30 Aug 2011 10:19:32 +0000 (12:19 +0200)]
Include v8-debug.h from the right location
Now that V8 is its own module in Qt, the V8
headers are accessible as <private/v8*>.
Change-Id: Ieedf2e2618ec5fae62e6d277e469553f1b0f96f1
Reviewed-on: http://codereview.qt.nokia.com/3872
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>