framework/uifw/ecore.git
12 years agoEcore_Wayland: Cleanup header inclusions. Fix issues with efl wayland
devilhorns [Tue, 24 Apr 2012 16:59:35 +0000 (16:59 +0000)]
Ecore_Wayland: Cleanup header inclusions. Fix issues with efl wayland
clients not moving or resizing properly with most recent git wayland.
Make use of wayland's new 'serial' stuff in place of timestamps (where
appropriate). Add code to handle new wayland 'ping' events.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70443 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoseveral fixes for the doxygen docs.
sanjeev [Mon, 23 Apr 2012 23:31:38 +0000 (23:31 +0000)]
several fixes for the doxygen docs.

Author : Jérôme Pinot <ngc891@gmail.com>

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70426 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoCleanup Doxygen Warnings - ecore 5
gastal [Mon, 23 Apr 2012 20:09:58 +0000 (20:09 +0000)]
Cleanup Doxygen Warnings - ecore 5

Files modified:
ecore/src/lib/ecore_win32/Ecore_Win32.h
ecore/src/lib/ecore_wince/Ecore_WinCE.h
ecore/src/lib/ecore_x/Ecore_X.h

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70425 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoCleanup Doxygen Warnings - ecore 4
gastal [Mon, 23 Apr 2012 20:09:55 +0000 (20:09 +0000)]
Cleanup Doxygen Warnings - ecore 4

Files modified:
ecore/src/lib/ecore_wayland/ecore_wl_window.c
ecore/src/lib/ecore_x/xcb/ecore_xcb.c
ecore/src/lib/ecore_x/xcb/ecore_xcb_randr.c
ecore/src/lib/ecore_x/xcb/ecore_xcb_window.c
ecore/src/lib/ecore_x/xcb/ecore_xcb_window_shadow.c
ecore/src/lib/ecore_x/xlib/ecore_x.c
ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c
ecore/src/lib/ecore_x/xlib/ecore_x_window.c
ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70424 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoCleanup Doxygen Warnings - ecore 3
gastal [Mon, 23 Apr 2012 20:09:51 +0000 (20:09 +0000)]
Cleanup Doxygen Warnings - ecore 3

Files modified:
ecore/src/lib/ecore_file/Ecore_File.h
ecore/src/lib/ecore_file/ecore_file_monitor.c
ecore/src/lib/ecore_imf/Ecore_IMF.h
ecore/src/lib/ecore_imf/ecore_imf_context.c

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70423 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoCleanup Doxygen Warnings - ecore 2
gastal [Mon, 23 Apr 2012 20:09:48 +0000 (20:09 +0000)]
Cleanup Doxygen Warnings - ecore 2

Files modified:
ecore/src/lib/ecore_evas/Ecore_Evas.h
ecore/src/lib/ecore_evas/ecore_evas_fb.c
ecore/src/lib/ecore_evas/ecore_evas_sdl.c
ecore/src/lib/ecore_evas/ecore_evas_util.c
ecore/src/lib/ecore_evas/ecore_evas_x.c
ecore/src/lib/ecore_fb/ecore_fb_li.c

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70422 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoCleanup Doxygen Warnings - ecore 1
gastal [Mon, 23 Apr 2012 20:09:44 +0000 (20:09 +0000)]
Cleanup Doxygen Warnings - ecore 1

Files modified:
ecore/doc/Doxyfile.in
ecore/src/lib/ecore/Ecore.h
ecore/src/lib/ecore/ecore.c
ecore/src/lib/ecore/ecore_getopt.c
ecore/src/lib/ecore/ecore_main.c
ecore/src/lib/ecore_con/Ecore_Con.h

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70421 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoupdate po's
raster [Sat, 21 Apr 2012 01:50:49 +0000 (01:50 +0000)]
update po's

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70372 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Evas (win32): add override_set() support
caro [Fri, 20 Apr 2012 14:53:06 +0000 (14:53 +0000)]
Ecore_Evas (win32): add override_set() support

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70366 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Win32: fix ecore_win32_window_override_new() behavior
caro [Fri, 20 Apr 2012 14:47:15 +0000 (14:47 +0000)]
Ecore_Win32: fix ecore_win32_window_override_new() behavior

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70365 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore: don't track build files.
cedric [Wed, 18 Apr 2012 10:32:17 +0000 (10:32 +0000)]
ecore: don't track build files.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70302 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agosmall cleanup - set root prop after others are in place for wm
raster [Wed, 18 Apr 2012 05:19:35 +0000 (05:19 +0000)]
small cleanup - set root prop after others are in place for wm
detection.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70286 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore: Moved more API documentation to header.
seoz [Wed, 18 Apr 2012 01:24:30 +0000 (01:24 +0000)]
ecore: Moved more API documentation to header.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70285 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Evas (wayland_shm): Calculate shm pool size based on output size.
devilhorns [Tue, 17 Apr 2012 21:56:03 +0000 (21:56 +0000)]
Ecore_Evas (wayland_shm): Calculate shm pool size based on output size.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70283 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Wayland: Update ecore_wayland client code to handle using
devilhorns [Tue, 17 Apr 2012 21:55:25 +0000 (21:55 +0000)]
Ecore_Wayland: Update ecore_wayland client code to handle using
'serial' rather than timestamp. Trap in ecore_wl_screen_size_get for
the case where display->output is NULL.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70282 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Wayland: Update to latest wayland from git.
devilhorns [Tue, 17 Apr 2012 19:06:23 +0000 (19:06 +0000)]
Ecore_Wayland: Update to latest wayland from git.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70280 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoMake ecore_fd_handler docs clearer.
gastal [Tue, 17 Apr 2012 17:01:27 +0000 (17:01 +0000)]
Make ecore_fd_handler docs clearer.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70277 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoreturn true on SUCCESSS, not failure.
raster [Tue, 17 Apr 2012 02:28:06 +0000 (02:28 +0000)]
return true on SUCCESSS, not failure.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70251 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_X(cb): And simplify the checking for success. 'ret' is already
devilhorns [Mon, 16 Apr 2012 22:05:10 +0000 (22:05 +0000)]
Ecore_X(cb): And simplify the checking for success. 'ret' is already
false, so we can just check reply->status for success.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70248 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_X(cb): Fix xcb_change_pointer_control call to operate properly.
devilhorns [Mon, 16 Apr 2012 21:54:33 +0000 (21:54 +0000)]
Ecore_X(cb): Fix xcb_change_pointer_control call to operate properly.

NB: If an xcb function requires a xcb_request_check, then be sure to
use the 'checked' version of that function.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70246 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: cnook <kimcinoo@gmail.com>
raster [Mon, 16 Apr 2012 06:46:25 +0000 (06:46 +0000)]
From: cnook <kimcinoo@gmail.com>
Subject: Re: [E-devel] [Patch][Ecore][Win32] Checking control character

I missed the updating WinCE. and..
Mr. Vincent Torri enlighten me about ChangeLog and NEWS also. Thanks!

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70219 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoupdate po's
raster [Mon, 16 Apr 2012 06:46:05 +0000 (06:46 +0000)]
update po's

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70218 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore/scim-immodule: fix wrong upload in 70206
jihoon [Mon, 16 Apr 2012 06:02:52 +0000 (06:02 +0000)]
ecore/scim-immodule: fix wrong upload in 70206

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70207 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore/NEWS: fix typos
jihoon [Mon, 16 Apr 2012 06:00:16 +0000 (06:00 +0000)]
ecore/NEWS: fix typos

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70206 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore -> news up to date
raster [Mon, 16 Apr 2012 04:46:19 +0000 (04:46 +0000)]
ecore -> news up to date

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70203 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore ecore_evas_basics_example.c: Fixed formatting.
seoz [Mon, 16 Apr 2012 00:22:29 +0000 (00:22 +0000)]
ecore ecore_evas_basics_example.c: Fixed formatting.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70200 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore examples: Fixed formatting.
seoz [Mon, 16 Apr 2012 00:22:26 +0000 (00:22 +0000)]
ecore examples: Fixed formatting.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70199 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: cnook <kimcinoo@gmail.com>
raster [Sun, 15 Apr 2012 03:28:49 +0000 (03:28 +0000)]
From: cnook <kimcinoo@gmail.com>
Subject: [E-devel] [Patch][Ecore][Win32] Checking control character

The control characters are generated by holding down the Control key while
you strike another letter or symbol key.
Because of this reason, The Evas_Event_Key_Down in the
EVAS_CALLBACK_KEY_DOWN callback does not have proper keyname.
So I have shifted the control character to printing character. Please
review the patch and give any feedbacks. Thanks.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70186 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agostop leaking every ecore system signal event.
barbieri [Fri, 13 Apr 2012 15:44:02 +0000 (15:44 +0000)]
stop leaking every ecore system signal event.

People, when you go and change ecore_event_add() to
_ecore_event_add(), please NOTICE THAT THE FREE FUNCTION IS NOT
AUTOMATICALLY SPECIFIED!

So specify these functions to _ecore_event_add() to stop leaking every
signal we receive from system.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70177 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoremove EAPI from _ecore_event_signal_user_new().
barbieri [Fri, 13 Apr 2012 15:36:42 +0000 (15:36 +0000)]
remove EAPI from _ecore_event_signal_user_new().

It should never be exported outside of libecore.so

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70176 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Evas (wayland_shm): Allocate the shm_pool according to output
devilhorns [Thu, 12 Apr 2012 20:46:48 +0000 (20:46 +0000)]
Ecore_Evas (wayland_shm): Allocate the shm_pool according to output
size. Don't set the engine destination until we have created the pool
& buffer.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70159 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: Jérôme Pinot <ngc891@gmail.com>
discomfitor [Thu, 12 Apr 2012 06:55:08 +0000 (06:55 +0000)]
From: Jérôme Pinot <ngc891@gmail.com>
Subject: [E-devel] [patch] ecore doxygen doc (3)
Date: Thu, 12 Apr 2012 15:39:16 +0900

Some leftovers, fix:

/tmp/ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c:1202: warning: The following parameters of ecore_x_randr_crtc_pos_relative_set(Ecore_X_Window root, Ecore_X_Randr_Crtc crtc_r1, Ecore_X_Randr_Crtc crtc_r2, Ecore_X_Randr_Output_Policy policy, Ecore_X_Randr_Relative_Alignment alignment) are not documented:
  parameter 'root'
/tmp/ecore/src/lib/ecore_x/xcb/ecore_xcb_randr.c:921: warning: The following parameters of ecore_x_randr_mode_size_get(Ecore_X_Window root, Ecore_X_Randr_Mode mode, int *w, int *h) are not documented:
  parameter 'root'
/tmp/ecore/doc/examples.dox:242: warning: unable to resolve reference to `ecore_event_example.c' for \ref command

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70119 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: Jérôme Pinot <ngc891@gmail.com>
discomfitor [Thu, 12 Apr 2012 03:51:36 +0000 (03:51 +0000)]
From: Jérôme Pinot <ngc891@gmail.com>
Subject: [E-devel] [patch] ecore doxygen doc (2)
Date: Thu, 12 Apr 2012 12:46:04 +0900

Hi,

This is a big patch. It fixes:
- undef #EINA_{TRUE,FALSE} links
- @c for NULL and EINA_{TRUE,FALSE}
- some formatting/spello
- several missing return types

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@70117 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Evas (wayland): Update ecore_evas_wayland engines to match
devilhorns [Tue, 10 Apr 2012 17:02:24 +0000 (17:02 +0000)]
Ecore_Evas (wayland): Update ecore_evas_wayland engines to match
recent changes in ecore_wayland. Implement the wl_shm_pool interface
also for wayland_shm engine.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69998 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Wayland: Rework ecore_wayland to match current wayland git wrt
devilhorns [Tue, 10 Apr 2012 17:00:56 +0000 (17:00 +0000)]
Ecore_Wayland: Rework ecore_wayland to match current wayland git wrt
pointer grabs, shm_pool interface. Rename fields of the
wl_event_mouse_in/out structures to match other ecore event structs.
Add API functions for getting a list of outputs, for getting a windows
shell_surface, and for setting a windows parent.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69997 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore ecore_main.c: Added ecore_main_loop_iterate_may_block()
seoz [Tue, 10 Apr 2012 09:12:12 +0000 (09:12 +0000)]
ecore ecore_main.c: Added ecore_main_loop_iterate_may_block()
documentation.
I didn't add the API declaration into the header yet because the API
name/parameter might be changed before release.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69990 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore ecore_job.c: Fixed formatting.
seoz [Tue, 10 Apr 2012 09:12:08 +0000 (09:12 +0000)]
ecore ecore_job.c: Fixed formatting.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69989 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf: fix some doxygen warnings
jihoon [Sat, 7 Apr 2012 14:11:22 +0000 (14:11 +0000)]
ecore_imf: fix some doxygen warnings

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69957 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore ecore_poll.c: Fixed formatting.
seoz [Fri, 6 Apr 2012 04:14:25 +0000 (04:14 +0000)]
ecore ecore_poll.c: Fixed formatting.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69940 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: doc fixes
caro [Thu, 5 Apr 2012 07:00:42 +0000 (07:00 +0000)]
Ecore: doc fixes

Patch by Jérôme Pinot

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69928 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoNew simpler ecore event example.
gastal [Wed, 4 Apr 2012 17:31:24 +0000 (17:31 +0000)]
New simpler ecore event example.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69921 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf: fix doxygen
jihoon [Tue, 3 Apr 2012 04:10:24 +0000 (04:10 +0000)]
ecore_imf: fix doxygen

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69884 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore: Fixed documentation.
seoz [Mon, 2 Apr 2012 23:47:00 +0000 (23:47 +0000)]
ecore: Fixed documentation.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69875 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoImproved ecore event docs.
gastal [Mon, 2 Apr 2012 20:51:51 +0000 (20:51 +0000)]
Improved ecore event docs.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69873 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFixing typo in docs.
gastal [Mon, 2 Apr 2012 20:51:47 +0000 (20:51 +0000)]
Fixing typo in docs.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69872 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: Jérôme Pinot <ngc891@gmail.com>
raster [Sat, 31 Mar 2012 12:03:05 +0000 (12:03 +0000)]
From: Jérôme Pinot <ngc891@gmail.com>
Subject: [E-devel] [patch] ecore doxygen doc

Here is a patch to correct some problems in ecore doxygen doc.
It fixes:

/tmp/ecore/doc/examples.dox:1173: warning: Unsupported xml/html tag
<some_num> found
/tmp/ecore/doc/examples.dox:1174: warning: Unsupported xml/html tag
<some_path> found
/tmp/ecore/doc/examples.dox:1176: warning: Unsupported xml/html tag
<some_num> found
/tmp/ecore/src/lib/ecore_con/ecore_con_ssl.c:714: warning: The
following parameters of
ecore_con_ssl_server_privkey_add(Ecore_Con_Server *svr, const char
*key_file) are not documented:
  parameter 'svr'
  /tmp/ecore/src/lib/ecore_con/Ecore_Con.h:1360: warning: The
following parameters of ecore_con_url_http_version_set(Ecore_Con_Url
*url_con, Ecore_Con_Url_Http_Version version) are not documented:
  parameter 'url_con'
  /tmp/ecore/src/lib/ecore_evas/Ecore_Evas.h:530: warning: argument
'demand_attention' of command @param is not found in the argument list
of ecore_evas_demand_attention_set(Ecore_Evas *ee, Eina_Bool demand)
/tmp/ecore/src/lib/ecore_evas/Ecore_Evas.h:530: warning: The following
parameters of ecore_evas_demand_attention_set(Ecore_Evas *ee,
Eina_Bool demand) are not documented:
  parameter 'demand'
  /tmp/ecore/src/lib/ecore_x/xcb/ecore_xcb_damage.c:129: warning:
Unsupported xml/html tag <empty> found

There are more things to fix due to API change but it's not so obvious
for me. I will first continue to check/correct trivial things in the
others efl doxygen doc.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69820 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agotry fix to refactor of ecore where thread_count went negative as it
raster [Thu, 29 Mar 2012 11:05:59 +0000 (11:05 +0000)]
try fix to refactor of ecore where thread_count went negative as it
was --'d when a no_queue thread finished too.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69741 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: 이병우 <bw80.lee@samsung.com>
raster [Thu, 29 Mar 2012 10:36:23 +0000 (10:36 +0000)]
From: 이병우 <bw80.lee@samsung.com>

I found a bug in ecore main loop while debuging cpu 100% issue on RSS
application.

 1. [RSS] RSS application register two io watch callbacks(for G_IO_IN,
    G_IO_OUT seperately)  for a GIOChannel with g_io_add_watch().
 2. [ecore] In _ecore_glib_context_query() function, g_main_context_query()
    returns a fd list, and it has 2 fd items for the GIOChannel (channel
    id = 20).

    itr[0] (16, 1, 0)
    itr[1] (15, 1, 0)
    itr[2] (20, 1, 0) (G_IO_IN, 0)
    itr[3] (20, 4, 0) (G_IO_OUT, 0)
    itr[4] (18, 1, 0)

3. [ecore] In _ecore_glib_context_poll_from() function, create read, write,
   exception fd list according to the events flags of each fd item.

   [6 15 16 18 20], [20], []

4. [ecore] in _ecore_glib_select__locked() function, get active fd number from
   select() call

   select(21, [6 15 16 18 20], [20], [], NULL) = 1 (out [20])

5. [ecore] In _ecore_glib_context_poll_to() function, there is a bug on
   setting revents flag.

   (because of incorrect condition check - currently, the logic of the
   function cannot handle this case)

   itr[0] (16, 1, 0)
   itr[1] (15, 1, 0)
   itr[2] (20, 1, 4) (set incorrectly)
   itr[3] (20, 4, 0)  => this should be set as (20, 4, 4)!!!!
   itr[4] (18, 1, 0)

6. [ecore] In _ecore_glib_select__locked(), g_main_context_check() function
   returns false because of the above bug, so g_main_context_dispatch()
   function will not be called.

>> After this, the 2~6 flow is executed repeatedly on ecore main loop
   (because 20 out is still active fd) and this makes cpu 100% problem.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69739 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoremvoe unused func too
raster [Thu, 29 Mar 2012 09:25:48 +0000 (09:25 +0000)]
remvoe unused func too

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69733 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_x: fix some typos
jihoon [Thu, 29 Mar 2012 09:02:22 +0000 (09:02 +0000)]
ecore_x: fix some typos

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69729 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoand kill warnings (-Wshadow) in ecore_getopt. pointed out that
raster [Thu, 29 Mar 2012 08:56:10 +0000 (08:56 +0000)]
and kill warnings (-Wshadow) in ecore_getopt. pointed out that
ecore_getopt_help() cant be called from a thread either in the process.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69728 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agomain loop checks for all of ecore -> back. (removed by cedric last year)
raster [Thu, 29 Mar 2012 08:52:25 +0000 (08:52 +0000)]
main loop checks for all of ecore -> back. (removed by cedric last year)

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69727 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agopur RAPI's on the .c file funcs.. TOO! so we can see which are api
raster [Thu, 29 Mar 2012 08:43:11 +0000 (08:43 +0000)]
pur RAPI's on the .c file funcs.. TOO! so we can see which are api
calls and whats internal!

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69726 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years ago* Fix range of issues with ecore_fb and even ecore_evas where
raster [Thu, 29 Mar 2012 05:57:41 +0000 (05:57 +0000)]
* Fix range of issues with ecore_fb and even ecore_evas where
it didn't work right on the fb. (timestamps wrong, focus
handling etc.). This makes it work fully again.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69715 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore Ecore.h: Fixed documentation typo.
seoz [Thu, 29 Mar 2012 05:09:58 +0000 (05:09 +0000)]
ecore Ecore.h: Fixed documentation typo.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69713 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agolet's use ()'s to group our logic better?
raster [Thu, 29 Mar 2012 03:15:36 +0000 (03:15 +0000)]
let's use ()'s to group our logic better?

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69712 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Evas (wayland): Be sure to call 'iterate' if this is the first
devilhorns [Thu, 29 Mar 2012 01:28:28 +0000 (01:28 +0000)]
Ecore_Evas (wayland): Be sure to call 'iterate' if this is the first
initialize of ecore_wl (needed for running clients under the Weston
Compositor). Remove extra flush call when rendering.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69708 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Wayland: Add an API function which calls wl_display_iterate(readable).
devilhorns [Thu, 29 Mar 2012 01:26:30 +0000 (01:26 +0000)]
Ecore_Wayland: Add an API function which calls wl_display_iterate(readable).

Fix ecore_wl_window surface attach of the buffer for shm and egl types.

NB: This ensures that both efl/elm clients work under the Wayland
Compositor AND the E17 Compositor.

NB: The issue here is that clients (when run under the Wayland
compositor) need to make sure 'iterate' has
been called before creating surfaces so that the wl_compositor is
setup. However, the actual E17 Compositor will hang if 'iterate' is called
to early.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69707 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf: remove NULL check prior to EINA_LIST_FREE
jihoon [Wed, 28 Mar 2012 11:03:11 +0000 (11:03 +0000)]
ecore_imf: remove NULL check prior to EINA_LIST_FREE
EINA_LIST_FREE checks whether its parameter is NULL or not
Thanks, Sebastian.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69703 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf: describe about Ecore IMF Context more detail
jihoon [Wed, 28 Mar 2012 02:23:57 +0000 (02:23 +0000)]
ecore_imf: describe about Ecore IMF Context more detail

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69683 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Wayland: Remove dependency on egl (handled in compositors).
devilhorns [Tue, 27 Mar 2012 17:50:40 +0000 (17:50 +0000)]
Ecore_Wayland: Remove dependency on egl (handled in compositors).
Handle 'axis' events from multi-touch devices (also handles mouse
wheel).
Remove wl_buffer_damage calls (obsolete in newest wayland).

NB: This will require the 'latest' wayland code from their git repo as
of 2012-03-27.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69672 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Wayland: Add doxy & since for dpi function.
devilhorns [Tue, 27 Mar 2012 15:15:21 +0000 (15:15 +0000)]
Ecore_Wayland: Add doxy & since for dpi function.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69670 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoscim-immodule: fix bug candidate window covers the preedit string when preedit string...
jihoon [Tue, 27 Mar 2012 09:05:00 +0000 (09:05 +0000)]
scim-immodule: fix bug candidate window covers the preedit string when preedit string appears in 2 line.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69664 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoscim_imcontext.cpp: remove trailing whitespace
jihoon [Tue, 27 Mar 2012 08:58:35 +0000 (08:58 +0000)]
scim_imcontext.cpp: remove trailing whitespace

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69663 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: Fix botched merge of ChangeLog.
devilhorns [Tue, 27 Mar 2012 07:09:03 +0000 (07:09 +0000)]
Ecore: Fix botched merge of ChangeLog.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69655 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: Update ChangeLog
devilhorns [Tue, 27 Mar 2012 02:36:00 +0000 (02:36 +0000)]
Ecore: Update ChangeLog

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69647 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: Fix configure.ac detection of the egl library (needs version >=
devilhorns [Tue, 27 Mar 2012 02:18:40 +0000 (02:18 +0000)]
Ecore: Fix configure.ac detection of the egl library (needs version >=
7.10).

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69646 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Evas (wayland):
devilhorns [Tue, 27 Mar 2012 02:17:22 +0000 (02:17 +0000)]
Ecore_Evas (wayland):

- Add ecore_wl_sync to ecore_evas_wayland_* (needed for some
compositors).
- Implement ecore_evas_wayland_type_set (for setting window types).
- Implement ecore_evas_wayland_pointer_set (for setting pointer
hotspots).
- Fix ecore_evas_alpha/transparent set.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69645 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Wayland:
devilhorns [Tue, 27 Mar 2012 02:13:34 +0000 (02:13 +0000)]
Ecore_Wayland:

- Comment out display_iterate during intialize (hangs compositor
initialize).
- Simplify ecore_wl_flush routine and avoid possible hangs in
wl_display_roundtrip.
- Add function (for trip ;) ) to be able to return the screen dpi.
- Implement functions for input grab/ungrab.
- Set root.x/y in mouse events.
- Remove freeing of mouse_move event (already handled generically).
- Handle setting output mm width/height (for calc of dpi).
- Implement setting surface input & opaque regions.
- Implement popup windows.
- Implement ecore_wl_window_transparent_set function.
- Implement function to allow setting Ecore_Wl_Window type.
- Implement setting the wayland mouse pointer to an image (via
ecore_wl_window_pointer_set).
- Comment out wl_display_iterate during initialize (can cause hangs in
compositor).
- Simplify ecore_wl_flush (to avoid compositor hangs).

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69644 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Win32/WinCE: also do not autorepeat the Win key
caro [Mon, 26 Mar 2012 17:33:10 +0000 (17:33 +0000)]
Ecore_Win32/WinCE: also do not autorepeat the Win key

Patch by Shinwoo Kim

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69638 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Win32/WinCE: do not autorepeat Ctrl, Shift and Alt keys
caro [Mon, 26 Mar 2012 06:31:39 +0000 (06:31 +0000)]
Ecore_Win32/WinCE: do not autorepeat Ctrl, Shift and Alt keys

Patch by Shinwoo Kim

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69628 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: fix shm_open() check (can be in libc or librt)
caro [Sun, 25 Mar 2012 17:25:04 +0000 (17:25 +0000)]
Ecore: fix shm_open() check (can be in libc or librt)

  This works in linux and windows, and should fix shm_detection on BSD (including Mac)

  BSD, Mac and solaris users : please check that it compiles and shm_open is detected

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69616 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agorevert. gettext 0.18 is problematic on some platforms
caro [Sat, 24 Mar 2012 18:57:21 +0000 (18:57 +0000)]
revert. gettext 0.18 is problematic on some platforms

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69602 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoBump gettext
ravenlock [Sat, 24 Mar 2012 15:48:38 +0000 (15:48 +0000)]
Bump gettext

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69600 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_X.h: musst -> must in doxygen
jihoon [Fri, 23 Mar 2012 09:23:46 +0000 (09:23 +0000)]
Ecore_X.h: musst -> must in doxygen

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69587 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf_context.c: fix typos in doxygen
jihoon [Fri, 23 Mar 2012 08:37:13 +0000 (08:37 +0000)]
ecore_imf_context.c: fix typos in doxygen

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69586 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore_Evas.h: fix typos
jihoon [Fri, 23 Mar 2012 08:36:37 +0000 (08:36 +0000)]
Ecore_Evas.h: fix typos

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69585 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore.h: fix typos
jihoon [Fri, 23 Mar 2012 05:44:46 +0000 (05:44 +0000)]
Ecore.h: fix typos

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69578 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: Vikram Narayanan <vikram186@gmail.com>
raster [Thu, 22 Mar 2012 06:01:59 +0000 (06:01 +0000)]
From: Vikram Narayanan <vikram186@gmail.com>
Subject: [E-devel] [PATCH] ecore/ecore_fb: Tweaks in _ecore_fb_size_get

As the width and height are defined as static, no need to initialize it
again to zero. Also removed checks for 'valid pointers' as it is redundant.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69556 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore FD handler docs.
gastal [Wed, 21 Mar 2012 14:14:50 +0000 (14:14 +0000)]
Ecore FD handler docs.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69540 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoand fix ecore_evas...
caro [Tue, 20 Mar 2012 22:57:05 +0000 (22:57 +0000)]
and fix ecore_evas...

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69528 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: fix compilation
caro [Tue, 20 Mar 2012 22:44:21 +0000 (22:44 +0000)]
Ecore: fix compilation

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69527 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: add ecore_wince_window_focus_get() and ecore_win32_window_focus_get()
caro [Tue, 20 Mar 2012 04:35:18 +0000 (04:35 +0000)]
Ecore: add ecore_wince_window_focus_get() and ecore_win32_window_focus_get()

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69514 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore: rename ecore_win32_focus_set() to ecore_win32_focus() and add ecore_wince_focus()
caro [Tue, 20 Mar 2012 04:09:51 +0000 (04:09 +0000)]
Ecore: rename ecore_win32_focus_set() to ecore_win32_focus() and add ecore_wince_focus()

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69513 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf: add free memory code in ecore_imf_context_preedit_string_with_attributes_g...
jihoon [Sat, 17 Mar 2012 10:44:04 +0000 (10:44 +0000)]
ecore_imf: add free memory code in ecore_imf_context_preedit_string_with_attributes_get example

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69487 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoand work more on getting release in shape - version requirements.
raster [Sat, 17 Mar 2012 06:25:41 +0000 (06:25 +0000)]
and work more on getting release in shape - version requirements.

(god this is a pain in the butt)

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69484 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agomissing flags
caro [Sat, 17 Mar 2012 05:42:47 +0000 (05:42 +0000)]
missing flags

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69483 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoadd back in libs.private/requires to pc files with some fixes for
raster [Sat, 17 Mar 2012 05:37:25 +0000 (05:37 +0000)]
add back in libs.private/requires to pc files with some fixes for
missing.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69482 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agogear up svn for release. one of many steps/things to do.
raster [Sat, 17 Mar 2012 04:17:29 +0000 (04:17 +0000)]
gear up svn for release. one of many steps/things to do.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69481 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf_evas: add example code in doxygen
jihoon [Fri, 16 Mar 2012 06:44:54 +0000 (06:44 +0000)]
ecore_imf_evas: add example code in doxygen

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69450 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore_imf: add example code in doxygen
jihoon [Fri, 16 Mar 2012 06:44:05 +0000 (06:44 +0000)]
ecore_imf: add example code in doxygen

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69449 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore poller docs.
gastal [Thu, 15 Mar 2012 19:31:09 +0000 (19:31 +0000)]
Ecore poller docs.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69424 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore: fix Ecore_Thread memory leak.
cedric [Wed, 14 Mar 2012 17:51:38 +0000 (17:51 +0000)]
ecore: fix Ecore_Thread memory leak.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69343 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoEcore event functions docs improvements.
gastal [Wed, 14 Mar 2012 13:22:20 +0000 (13:22 +0000)]
Ecore event functions docs improvements.

Moved docs to header file.
Fixed some typos.
Added @brief.
Add failure information to @return.
Other random improvements.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69337 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoDo not cut off \0 anymore.
leif [Tue, 13 Mar 2012 19:57:06 +0000 (19:57 +0000)]
Do not cut off \0 anymore.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69301 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoBetter ecore event docs.
gastal [Tue, 13 Mar 2012 18:29:31 +0000 (18:29 +0000)]
Better ecore event docs.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69299 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoupdate client flush properly, fixing bug spotted by raoulh
discomfitor [Tue, 13 Mar 2012 13:44:18 +0000 (13:44 +0000)]
update client flush properly, fixing bug spotted by raoulh

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69296 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoFrom: Bluezery <ohpowel@gmail.com>
discomfitor [Mon, 12 Mar 2012 04:53:47 +0000 (04:53 +0000)]
From: Bluezery <ohpowel@gmail.com>
Subject: [E-devel] [Patch][ecore_con] Simple bug fix
Date: Mon, 12 Mar 2012 13:45:02 +0900

Hello,

This is patch to prevent a segfault if curlmsg == NULL.

Thanks.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69217 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoecore: fix Ecore_Thread double free and update ChangeLog/NEWS.
cedric [Sat, 10 Mar 2012 12:47:54 +0000 (12:47 +0000)]
ecore: fix Ecore_Thread double free and update ChangeLog/NEWS.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69172 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

12 years agoImprovements to ecore timer docs.
gastal [Fri, 9 Mar 2012 19:21:52 +0000 (19:21 +0000)]
Improvements to ecore timer docs.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@69115 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33