Jan Kotas [Fri, 9 Feb 2018 17:40:42 +0000 (09:40 -0800)]
Revert "Debugger api to set a breakpoint on offset 0 of all methods (#15819)"
This reverts commit
3d689d00843618105e735c5647e1cb64e721a333.
Jan Kotas [Fri, 9 Feb 2018 17:40:36 +0000 (09:40 -0800)]
Revert "fix for issue #16289 (#16291)"
This reverts commit
cd3f6e77757729d3d02dfbec4af21cdfe83f5435.
Koundinya Veluri [Fri, 9 Feb 2018 16:28:59 +0000 (08:28 -0800)]
Fix GC reporting for slow tail calls with by-ref-like args (#16264)
Fix GC reporting for slow tail calls with by-ref-like args
Fixes https://github.com/dotnet/coreclr/issues/16229:
- Offsets recorded in the GC layout are intended to be offsets from the top of the stack, fixed by calculating the proper offset
Tanner Gooding [Thu, 8 Feb 2018 15:57:49 +0000 (07:57 -0800)]
Change compliement to complement
Tanner Gooding [Thu, 8 Feb 2018 00:47:04 +0000 (16:47 -0800)]
Fixing up the emitOutput handling for RR/RRR instructions
Tanner Gooding [Wed, 7 Feb 2018 04:38:51 +0000 (20:38 -0800)]
Enabling the named intrinsic support on SSE4.1 hardware for Math.Round, Math.Ceiling, and Math.Floor
Tanner Gooding [Wed, 7 Feb 2018 04:38:24 +0000 (20:38 -0800)]
Updating the emitter to more generally handle 4-Byte SSE4 instructions.
David Mason [Fri, 9 Feb 2018 08:30:02 +0000 (00:30 -0800)]
fix for issue #16289 (#16291)
Brian Sullivan [Fri, 9 Feb 2018 01:57:04 +0000 (17:57 -0800)]
Merge pull request #15595 from mikedn/rc-binop
Remove useless RangeCheck::Limit::keArray
Bruce Forstall [Fri, 9 Feb 2018 01:00:10 +0000 (17:00 -0800)]
Change corefx test process (#16263)
Instead of using the `/p:CoreCLROverridePath` switch when building
corefx, to bring in coreclr, build corefx normally. This builds
against the coreclr packages that corefx has already been validated
against in the CI, so the build should always work. Then, copy
over our built coreclr bits before testing. This method is expected
to have better behavior in most breaking change scenarios.
Wes Haggard [Fri, 9 Feb 2018 00:53:25 +0000 (16:53 -0800)]
Merge pull request #16281 from alpencolt/clr-extra-args-4-cmake
[Unix] Passing extra CMake args
Bruce Forstall [Thu, 8 Feb 2018 23:25:17 +0000 (15:25 -0800)]
Merge pull request #16278 from BredPet/fix_cfi_unwind_info
[RyuJIT/ARM32] Fix crash while generating CFI unwind info
Victor "Nate" Graf [Thu, 8 Feb 2018 23:07:20 +0000 (15:07 -0800)]
Adjust expected file size if ZapDisable is true (#16240)
Jarret Shook [Thu, 8 Feb 2018 22:43:24 +0000 (14:43 -0800)]
Merge pull request #15673 from tannergooding/generatelayout-switch
Updating build.cmd to support 'generatelayout' when 'skiptests' is specified.
David Mason [Thu, 8 Feb 2018 22:35:01 +0000 (14:35 -0800)]
Debugger api to set a breakpoint on offset 0 of all methods (#15819)
* Debugger api to set a breakpoint on offset 0 of all methods
* code review feedback
* more code review feedback
* respect IsIl in CorDbFunctionBreakoint()
* change SIMPLIFYING_ASSERT to SIMPLIFYING_ASSUMPTION_SUCCEEDED for hrs, it outputs a much better diagnostic message
Noah Falk [Thu, 8 Feb 2018 21:59:26 +0000 (13:59 -0800)]
Updating runtime version for tests (#16271)
Change
93ec62347a4e97b920513296eefb27bdacbecfe9 removed Span.NonPortableCast from System.Private.CoreLib.dll requiring tests
to use an updated version of System.Memory.dll that no longer refers to it.
Brian Robbins [Thu, 8 Feb 2018 21:24:52 +0000 (13:24 -0800)]
Explictly initialize EventData.Reserved for System.Private.CoreLib. (#16283)
Anirudh Agnihotry [Thu, 8 Feb 2018 21:03:50 +0000 (13:03 -0800)]
Extra semicolons left at the end of Combine function taking 4 paths. (#16284)
Jacek Blaszczynski [Wed, 7 Feb 2018 22:29:30 +0000 (23:29 +0100)]
Add tests for Sse2 memory fence instructions
Jacek Blaszczynski [Wed, 7 Feb 2018 22:28:38 +0000 (23:28 +0100)]
Implement Sse2 memory fence instructions
Carol Eidt [Thu, 8 Feb 2018 19:43:00 +0000 (11:43 -0800)]
Merge pull request #16268 from CarolEidt/Fix16254
Check mismatched types for SIMD copy
Carol Eidt [Thu, 8 Feb 2018 17:35:31 +0000 (09:35 -0800)]
Merge pull request #16260 from sdmaclea/PR-ARM64-Remove-SIMD-hacks
[Arm64] Remove SIMD hacks to get*TypeForStruct
Alexander Soldatov [Thu, 8 Feb 2018 17:26:59 +0000 (20:26 +0300)]
[Unix] Passing extra CMake args
Added support for compiler and linker additional arguments in CMake.
By using CLR_ADDITIONAL_LINKER_FLAGS and CLR_ADDITIONAL_COMPILER_OPTIONS
it's possible to pass toolchain options without changing Makefile.
Bruce Forstall [Thu, 8 Feb 2018 16:40:00 +0000 (08:40 -0800)]
Merge pull request #16279 from BruceForstall/FixArmCorefxAbsolutePaths
Make paths used by ARM corefx test script absolute
Bruce Forstall [Thu, 8 Feb 2018 16:31:09 +0000 (08:31 -0800)]
Make paths used by ARM corefx test script absolute
Jan Kotas [Thu, 8 Feb 2018 13:48:59 +0000 (05:48 -0800)]
Cleanup redundant stale COR header definition (#16261)
Petr Bred [Thu, 8 Feb 2018 12:04:44 +0000 (15:04 +0300)]
[RyuJIT/ARM32] Fix crash while generating CFI unwind info
Signed-off-by: Petr Bred <bredpetr@gmail.com>
Maryam Ariyan [Thu, 8 Feb 2018 06:55:11 +0000 (01:55 -0500)]
Throwing IO Related exception only on FileStream.Dispose(disposing:true) (#16250)
* Making Unix and Windows FileStream Dispose behavior more consistent and throwing IO related exception only on Dispose(true)
Fixes: #26734
* Commenting out SecurityException, also providing reason
Michal Strehovský [Thu, 8 Feb 2018 06:54:39 +0000 (07:54 +0100)]
Make it possible to Reflection.Emit default interface methods (#16257)
Fixes #15648.
John Doe [Thu, 8 Feb 2018 06:05:32 +0000 (22:05 -0800)]
Agruments -> Arguments (#16273)
Carol Eidt [Thu, 8 Feb 2018 01:31:34 +0000 (17:31 -0800)]
Check mismatched types for SIMD copy
If we have a block copy from an enregisterable struct (today, that's just SIMD) to a different type target, it needs to be makred as address-taken, because the destination type is what's used for the copy, and all non-enregisterable destination types expect their source in memory.
Fix #16254
dotnet-maestro-bot [Thu, 8 Feb 2018 01:06:29 +0000 (19:06 -0600)]
Update BuildTools, CoreClr to preview2-02507-02, preview2-26207-11, respectively (#16256)
Anirudh Agnihotry [Thu, 8 Feb 2018 00:49:31 +0000 (16:49 -0800)]
Removes Extra allocations for corner cases in CombineNochecks (#16255)
* Added String Overload
Brian Robbins [Wed, 7 Feb 2018 22:47:25 +0000 (14:47 -0800)]
Initialize stack allocated data structures. (#16259)
Steve MacLean [Wed, 7 Feb 2018 14:47:39 +0000 (09:47 -0500)]
[Arm64] Remove SIMD hacks to get*TypeForStruct
Martin Andersen [Wed, 7 Feb 2018 17:16:38 +0000 (18:16 +0100)]
Fix various typos in the readme (#16251)
Michelle McDaniel [Wed, 7 Feb 2018 17:10:13 +0000 (09:10 -0800)]
Add configuration to options to submission.py (#16127)
Matt Mitchell [Wed, 7 Feb 2018 16:49:54 +0000 (08:49 -0800)]
Fix publishing errors (#16253)
Fix two errors:
* Remove unneeded signed symbol catalog injection
* Build definition is not importing becuase of duplicated task name.
Noah Falk [Wed, 7 Feb 2018 10:10:28 +0000 (02:10 -0800)]
Archive CI perf results (#16230)
* Archive CI perf results
I need to diagnose a failure that only reproes in CI but the CI scripts don't archive the logs on failure. This change should fix that.
* Adding pipeline build per feedback
Tarek Mahmoud Sayed [Wed, 7 Feb 2018 04:40:10 +0000 (20:40 -0800)]
Fix Hebrew calendar month names list (#16247)
* Fix Hebrew calendar month names list
Steve MacLean [Wed, 7 Feb 2018 03:00:01 +0000 (22:00 -0500)]
Disable crossgen for types containing intrinsic types (#16213)
Bruce Forstall [Wed, 7 Feb 2018 02:01:06 +0000 (18:01 -0800)]
Merge pull request #16241 from BruceForstall/FixJobNames
Fix name of OSX10.12 and Ubuntu innerloop jobs
Sung Yoon Whang [Wed, 7 Feb 2018 01:57:46 +0000 (17:57 -0800)]
Fix stacktrace formatting to make it work on CoreRT as well (#16245)
Andy Ayers [Wed, 7 Feb 2018 00:05:00 +0000 (16:05 -0800)]
Add test case for contstructor devirtualization example (#16239)
See #16198 for discussion.
Koundinya Veluri [Tue, 6 Feb 2018 23:59:42 +0000 (15:59 -0800)]
Fix GC reproting for by-ref-like structs (#16231)
Fix GC reproting for by-ref-like structs
Fixes https://github.com/dotnet/coreclr/issues/16044:
- Divide by pointer size was removed to produce the proper offset
- Fixed some assertion failures seen in https://github.com/dotnet/coreclr/issues/16229
Carol Eidt [Tue, 6 Feb 2018 22:51:23 +0000 (14:51 -0800)]
Merge pull request #16200 from fiigii/loadstore
Implement AVX/AVX2/SSE3 Load* intrinsics
Fei Peng [Mon, 5 Feb 2018 20:14:52 +0000 (12:14 -0800)]
Implement AVX2 LoadAlignedVector256/128NonTemporal
Fei Peng [Sun, 4 Feb 2018 19:33:51 +0000 (11:33 -0800)]
Implement SSE3 LoadAndDuplicateToVector128 and LoadDquVector128
Fei Peng [Sun, 4 Feb 2018 07:40:04 +0000 (23:40 -0800)]
Implement AVX LoadAlignedVector256, LoadDquVector256, and LoadVector256
Carol Eidt [Tue, 6 Feb 2018 20:58:38 +0000 (12:58 -0800)]
Merge pull request #16228 from fiigii/store
Implement AVX/SSE2 Store* intrinsics
Carol Eidt [Tue, 6 Feb 2018 20:55:13 +0000 (12:55 -0800)]
Merge pull request #16235 from CarolEidt/FixPrefetchBuildBreak
Disable prefetch instructions for LEGACY_BACKEND
Bruce Forstall [Tue, 6 Feb 2018 19:33:33 +0000 (11:33 -0800)]
Fix name of OSX10.12 and Ubuntu innerloop jobs
Bruce Forstall [Tue, 6 Feb 2018 19:28:09 +0000 (11:28 -0800)]
Merge pull request #16006 from BruceForstall/AddWindowsArmCoreFxTesting
Enable Windows ARM32 corefx testing
Eugene Rozenfeld [Tue, 6 Feb 2018 19:19:32 +0000 (11:19 -0800)]
Don't remove the first non-internal block that has profile weight. (#16227)
When using profile weights, fgComputeEdgeWeights expects the first non-internal block to have profile weight.
Make sure we don't break that invariant when removing an empty block.
This fixes VSO 546031.
Jan Kotas [Tue, 6 Feb 2018 19:11:47 +0000 (11:11 -0800)]
Fix handling of return code for system() calls (#16225)
The value returned from system() is encoded bag of bits that gets
misinterpretted once it starts propagate through the system. Normalize
it to 0/1.
Bruce Forstall [Thu, 25 Jan 2018 00:27:52 +0000 (16:27 -0800)]
Enable Windows ARM32 corefx testing
We create a flow job for each arm32 corefx mode, e.g.
arm_cross_checked_windows_nt_corefx_jitstress1_flow_prtest. This
depends on a build job that is specific to the stress mode, e.g.
arm_cross_checked_windows_nt_corefx_jitstress1_bld_prtest, which
(on x64) builds CoreCLR, then clones and builds CoreFX using run-corefx-tests.py.
In particular, it only builds the CoreFX tests; it doesn't run them.
Note that because the CoreFX test build embeds the stress mode environment
variables in its generated RunTests.cmd scripts, we need a different
corefx build dependency for each corefx test run; we can't share the
builds. The build script then ZIPs up the CoreFX tests and generated
CoreFX runtime (which will include the coreclr runtime because we built
CoreFX with the `/p:CoreCLROverridePath` argument), and archives these.
The test job, which runs on an arm64 machine, then copies the ZIPed
tests and runtime, unzips them, and runs a batch script to run each
RunTests.cmd file. Note that we don't use any existing mechanism to
run each test (such as msbuild), and I believe the CoreFX msbuild
harness doesn't have any mechanism to just run a previously built set of tests.
There is a very simple test exclusion mechanism: an entire test assembly
can be excluded by putting its name (e.g., System.IO.Ports.Tests), in
a file (e.g., tests\arm\corefx_test_exclusions.txt).
Note that this corefx testing mechanism is only enabled for arm
(aka arm32), not armlb or arm64.
Carol Eidt [Tue, 6 Feb 2018 18:17:16 +0000 (10:17 -0800)]
Replace comment inadvertently removed
Carol Eidt [Tue, 6 Feb 2018 17:53:00 +0000 (09:53 -0800)]
Disable prefetch instructions for LEGACY_BACKEND
Jan Kotas [Tue, 6 Feb 2018 08:22:13 +0000 (00:22 -0800)]
Move String.Manipulation.cs to shared (#16226)
Fei Peng [Tue, 6 Feb 2018 07:15:12 +0000 (23:15 -0800)]
Implement SSE2 Store* intrinsics
Fei Peng [Tue, 6 Feb 2018 06:25:07 +0000 (22:25 -0800)]
Implement AVX Store* intrinsics
Tanner Gooding [Sat, 3 Feb 2018 17:30:11 +0000 (09:30 -0800)]
Adding tests for the StoreFence/Prefetch* APIs and the new Sse scalar overloads.
Tanner Gooding [Sat, 3 Feb 2018 17:28:56 +0000 (09:28 -0800)]
Adding support for the StoreFence/Prefetch* APIs and the new Sse scalar overloads.
Jan Kotas [Tue, 6 Feb 2018 05:24:50 +0000 (21:24 -0800)]
Reimplement string.Replace in managed code (#16214)
Tanner Gooding [Tue, 6 Feb 2018 00:45:46 +0000 (16:45 -0800)]
Removing the Sse2.LoadScalarVector128 overloads that are invalid.
Anirudh Agnihotry [Tue, 6 Feb 2018 01:39:37 +0000 (17:39 -0800)]
Implementation of GetFullPath(string path, string basePath) (#15579)
GetFullPathAPI Overload
Tanner Gooding [Sat, 3 Feb 2018 22:32:27 +0000 (14:32 -0800)]
Moving a number of the Sse2 hwintrinsic tests to use the test template.
Tanner Gooding [Sat, 3 Feb 2018 18:06:54 +0000 (10:06 -0800)]
Adding tests for the SSE2 LoadVector128, LoadAlignedVector128, and LoadScalarVector128 intrinsics.
Tanner Gooding [Sat, 3 Feb 2018 17:53:54 +0000 (09:53 -0800)]
Adding support for the SSE2 LoadVector128, LoadAlignedVector128, and LoadScalarVector128 intrinsics.
Brian Robbins [Tue, 6 Feb 2018 00:15:55 +0000 (16:15 -0800)]
Remove FEATURE_ACTIVITYSAMPLING and associated code. (#16185)
Brian Sullivan [Mon, 5 Feb 2018 23:08:55 +0000 (15:08 -0800)]
Merge pull request #16218 from briansull/revert-15910
Revert #15910 [R2R] add a virtualStubParamInfo as an argument
Brian Sullivan [Mon, 5 Feb 2018 21:36:31 +0000 (13:36 -0800)]
Revert #15910 [R2R] add a virtualStubParamInfo as an argument
David Fowler [Mon, 5 Feb 2018 20:52:08 +0000 (12:52 -0800)]
Added a factory to FileStreamCompletionSource (#16190)
* Merged FileStreamCompletionSource and MemoryCompletionSource
- Change FileStreamCompletionSource to take a ReadOnlyMemory<byte> instead of byte[]
- Delegate to memory.Retain if the underlying ReadOnlyMemory<byte> is backed by an array that isn't the stream's internal buffer.
* Brought back MemoryFileStreamCompletionSource
- Added a factory method to FileStreamCompletionSource that
picks the an impl or FileStreamCompletionSource or MemoryFileStreamCompletionSource based on the buffer matching the underlying stream's internal buffer.
* PR feedback
- Cleanup the condition
- Flip to Debug.Assert in FileStreamCompletionSource
* Check for null before using the PreAllocatedOverlapped
Brian Sullivan [Mon, 5 Feb 2018 18:00:36 +0000 (10:00 -0800)]
Merge pull request #16103 from mikedn/xorps
Use xorps instead of xorpd
dotnet-maestro-bot [Mon, 5 Feb 2018 16:22:11 +0000 (10:22 -0600)]
Update CoreClr to preview2-26205-05 (#16205)
Alex [Mon, 5 Feb 2018 04:17:03 +0000 (06:17 +0200)]
Use stackalloc in string.Split (#15435)
* Use stackalloc in string.Split
* Added initial usage of ValueListBuilder
* Added usage of list builder to string separator Split overloads
Jan Kotas [Sun, 4 Feb 2018 22:34:11 +0000 (14:34 -0800)]
Merge pull request #16199 from dotnet/revert-15944-CorefxTestUseCorrectVersion
Revert "For corefx testing, use a matching corefx repo version git hash"
Jan Kotas [Sun, 4 Feb 2018 19:08:05 +0000 (11:08 -0800)]
Revert "For corefx testing, use a matching corefx repo version git hash"
dotnet-maestro-bot [Sun, 4 Feb 2018 18:21:46 +0000 (12:21 -0600)]
Update CoreClr to preview2-26204-05 (#16191)
Carol Eidt [Sun, 4 Feb 2018 15:23:01 +0000 (07:23 -0800)]
Merge pull request #16182 from CarolEidt/FixDD543057
Consider specialPutArgs for jitStressRegs
Sung Yoon Whang [Sat, 3 Feb 2018 23:58:22 +0000 (15:58 -0800)]
Fix failfast stacktrace (#15895)
* attempt to fix stacktrace getting printed twice
* Fix some default parameter issues, and wrong commit from last commit
* Fix build errors, switch call from Debug.Assert to new FailFast FCall
* Fix signature to allow more types of exception title
* cleanup
* Addressing comments from PR
* More PR comments
* remove useless using
* Address comments on GC hole and few naming changes
Noah Falk [Sat, 3 Feb 2018 23:03:30 +0000 (15:03 -0800)]
JitBench harness improvements (#15151)
* Improvements to JitBench perf test
1) More of the scenario setup is delegated to the scripts in the JitBench repo. The run now consists of (a) acquire source (b) RunBenchmark.ps1 -SetupOnly (c) run dotnet MusicStore.dll over and over to get measurements.
2) A specific last known good framework version is used instead of an open-ended latest version. This should make the test more reliable day-to-day at the cost that we have to bump the version when breaking changes occur.
3) Added an option to test with a local copy of JitBench instead of acquiring one from github. This is useful to for testing simultaneous changes in both repos.
4) Updated the output parsing to account for the changes I made in MusicStore's console spew.
* Code review feedback
* Don't use precompiled views by default
In order to match the previous benchmark results we should avoid
using precompiled views.
* Fixed JitBench local repo issue
In my earlier change I accidentally broke the normal scenario when you do not use a local copy of JitBench repo. This case was failing with an exception in SetupStatics because the null directory didn't exist.
Tanner Gooding [Sat, 3 Feb 2018 08:13:27 +0000 (00:13 -0800)]
Updating the templated x86 hwintrinsic tests to validate Load and LoadAligned
Tanner Gooding [Tue, 30 Jan 2018 05:20:08 +0000 (21:20 -0800)]
Updating the HWIntrinsic codegen to support marking LoadVector128 and LoadAlignedVector128 as contained.
Ben Adams [Sat, 3 Feb 2018 05:29:30 +0000 (05:29 +0000)]
Remove AsyncMethodBuilder from shared partition (#16149)
* Remove AsyncMethodBuilder from shared partition
* AsyncMethodBuilder => AsyncMethodBuilderCore
Ahson Khan [Sat, 3 Feb 2018 03:30:25 +0000 (19:30 -0800)]
Changing Span/Memory to return default on null instead of throwing. (#16186)
* Additional changes based on feedback (bounds checks)
* Adding remaining bounds checks
dotnet-maestro-bot [Sat, 3 Feb 2018 03:27:20 +0000 (21:27 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02502-01, preview2-26203-01, preview2-26202-05, respectively (#16180)
Marco Rossignoli [Sat, 3 Feb 2018 03:08:43 +0000 (04:08 +0100)]
Dictionary exposes internal type comparer (#16151)
Fixes dotnet/corefx#26033
mikedn [Sat, 3 Feb 2018 02:58:33 +0000 (04:58 +0200)]
Delete unused SSA_FEATURE_USEDEF ifdefs (#15654)
Koundinya Veluri [Sat, 3 Feb 2018 01:55:39 +0000 (17:55 -0800)]
Fix GetILToNativeMapping3 to return mappings for the specified code start address (#16146)
Fix GetILToNativeMapping3 to return mappings for the specified code start address
Fix for https://github.com/dotnet/coreclr/issues/16145 in master:
- Previously, it was getting or creating the current entry point's corresponding DebugJitInfo and determining that the specified code address is not within the code range
- Fixed to get or create a DebugJitInfo corresponding to the specified code address and return that
Andy Ayers [Sat, 3 Feb 2018 01:20:48 +0000 (17:20 -0800)]
Fix AV in crossgen when generating PDBs (#16184)
I missed updating one of the callers of `ReadyToRunInfo::GetEntryPoint`
in #15801. Fix by making the last arg explicit so this kind of type
confusion error is less likely, and updating the missed call site.
Closes #16177.
Tarek Mahmoud Sayed [Fri, 2 Feb 2018 22:32:46 +0000 (14:32 -0800)]
Fix mirroring build break
Tarek Mahmoud Sayed [Fri, 2 Feb 2018 19:40:39 +0000 (11:40 -0800)]
Span factoring (dotnet/corefx#26667)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Eric Erhardt [Fri, 2 Feb 2018 23:55:52 +0000 (17:55 -0600)]
Merge pull request #16133 from eerhardt/AddVectorToCoreLib
Add Vector<T> to CoreLib.
Carol Eidt [Fri, 2 Feb 2018 22:19:38 +0000 (14:19 -0800)]
Consider specialPutArgs for jitStressRegs
When we have a lclVar that is being kept alive between its `PUTARG_REG` and the call, we need to take that into account in determining the minimum register requirement for a node.
Adam Sitnik [Fri, 2 Feb 2018 22:07:25 +0000 (23:07 +0100)]
Event Pipe File V3 (#16107)
* write missing information to the event pipe file (pointer size to make it work fo x86)
* define where the events start, not only where they end
* include process Id in the event pipe file, bump the version so old consumers get clear error message
* write the missing EndObject tag to close the header
* include expected CPU sampling rate in the event pipe header file
* include keywords in V3 of EventPipe metadata, fixes #11934
* remove forward references
* entry object comes after the header and ends after it's data, before the event block objects
* introduce event block
* fix the GC contracts
* generate metadata ids
* end the file with null reference tag
* getting it work
* 4 byte alignment of serialized event data
* Revert "include keywords in V3 of EventPipe metadata, fixes #11934"
This reverts commit
98ef2f588e271f928fd051e96da526dc1e0f017c.
* remove event Id and event version from metadata buffer (it was duplicated with native code)
* increase the block size to be the same as buffer size
* Write the last event block to the file after disabling the event pipe, right after last events
* include the sife in itself
* the native part was supposed to not duplicate the event id and version, not manged
* ensure 4 byte alignment
* build metadata when it's not provided, so payload is never empty (no need to serialize length)
* this todo is no longer valid
* don't align everything, just the content of event block as suggested by @vancem
* improvements after code review
* update TraceEvent dependency, make the test verify new feature
* InterlockedIncrement(Int32) is not available for non-Windows OSes
* code improvements after Skype code review from @jorive
Brian Robbins [Fri, 2 Feb 2018 19:20:49 +0000 (11:20 -0800)]
Add assert for failure to open a file in FastSerializer. (#16178)
dotnet-maestro-bot [Fri, 2 Feb 2018 17:39:31 +0000 (11:39 -0600)]
Update CoreClr, CoreFx to preview2-26202-06, preview2-26202-01, respectively (master) (#16169)
* Update CoreClr, CoreFx to preview2-26202-06, preview2-26202-01, respectively
* Re-enable and fix the Sse hwintrinsic tests that had API name changes.
Carol Eidt [Fri, 2 Feb 2018 17:17:32 +0000 (09:17 -0800)]
Merge pull request #16157 from dotnetrt/sse2fix
Fix validation code in Sse2.MultiplyLow tests
mikedn [Fri, 2 Feb 2018 15:00:26 +0000 (17:00 +0200)]
Ifdef out Compiler::lvaVarPref (#15329)