Yang Gu [Mon, 10 May 2010 10:38:51 +0000 (18:38 +0800)]
test-stkutil: Add unit test for play tone parser
Yang Gu [Mon, 10 May 2010 10:38:50 +0000 (18:38 +0800)]
stkutil: Refactor parser for tone objects
Yang Gu [Mon, 10 May 2010 10:38:49 +0000 (18:38 +0800)]
Replace check_text with check_common_text
Yang Gu [Mon, 10 May 2010 10:38:48 +0000 (18:38 +0800)]
stkutil: Add play tone proactive command parser
Yang Gu [Mon, 10 May 2010 10:38:46 +0000 (18:38 +0800)]
stk: Unify variable names to use abbreviation
Yang Gu [Mon, 10 May 2010 10:38:47 +0000 (18:38 +0800)]
test-stkutil: Use enum for icon_id
Yang Gu [Mon, 10 May 2010 10:38:45 +0000 (18:38 +0800)]
test-stkutil: Add unit test for get input parser
Yang Gu [Mon, 10 May 2010 10:38:44 +0000 (18:38 +0800)]
stkutil: Free default text for get input parser
Kristen Carlson Accardi [Mon, 10 May 2010 22:17:22 +0000 (15:17 -0700)]
ppp: fix another hardcode of ppp_packet size
Zhenhua Zhang [Tue, 11 May 2010 01:04:28 +0000 (09:04 +0800)]
Fix Use hashtable to record udev path
Sometimes, Udev device 'remove' event could not report correct parent
node of current udev_device. Current code replies on the devpath
attached on the parent node to find modem and then remove it.
This fix is to change the way to store the devpath info into a
hashtable. So that we search hashtable to get devpath and remove the
modem.
Denis Kenzior [Tue, 11 May 2010 14:10:58 +0000 (09:10 -0500)]
atmodem: Fix crashes related to unremoved timeouts
Any timeouts set must be removed using g_source_remove. Failure to do
so results in sigsegvs when the modem is randomly removed during the
initialization cycle.
Denis Kenzior [Mon, 10 May 2010 21:36:33 +0000 (16:36 -0500)]
gsmdial: Shut down cleanly when ppp link dies
Denis Kenzior [Mon, 10 May 2010 21:28:23 +0000 (16:28 -0500)]
ppp: Keep these defines private
Kristen Carlson Accardi [Mon, 10 May 2010 20:06:37 +0000 (13:06 -0700)]
ppp: set address and control field
Before sending to hdlc, set the address and control field.
Fix hardcode of ppp header size.
Kristen Carlson Accardi [Mon, 10 May 2010 18:39:43 +0000 (11:39 -0700)]
gsmdial: use g_at_ppp_new_from_io()
Kristen Carlson Accardi [Mon, 10 May 2010 18:39:42 +0000 (11:39 -0700)]
gatchat: implement g_at_chat_get_io()
Kristen Carlson Accardi [Mon, 10 May 2010 18:39:41 +0000 (11:39 -0700)]
gsmdial: use g_at_chat_suspend
Kristen Carlson Accardi [Mon, 10 May 2010 19:12:45 +0000 (12:12 -0700)]
ppp: transition to dead when lcp finished
Transition to DEAD when lcp is finished and ignore any io
disconnects if we are already dead.
Andrzej Zaborowski [Fri, 7 May 2010 00:26:48 +0000 (02:26 +0200)]
Fix: Don't remove wrong atoms
When the state goes from INSERTED to NOT PRESENT and we have not
advanced past the SIM PIN entry, we remove the pre_sim atoms.
Similarly, if we advanced past the SIM PIN stage and subsequently
removed the SIM, the pre_sim atom list should not be tampered with.
Zhenhua Zhang [Thu, 6 May 2010 06:28:13 +0000 (14:28 +0800)]
Fix check data device before register the modem
To avoid the race condition that modem is registered before we retrieve
the data device property.
Torgny Johansson [Mon, 3 May 2010 07:04:45 +0000 (09:04 +0200)]
add vid/pid for Dell 5541 and 5542
Denis Kenzior [Fri, 30 Apr 2010 20:32:54 +0000 (15:32 -0500)]
atmodem: Port gprs-context to new PPP api
Denis Kenzior [Fri, 30 Apr 2010 20:32:45 +0000 (15:32 -0500)]
gsmdial: Port to new PPP api
Denis Kenzior [Fri, 30 Apr 2010 20:31:26 +0000 (15:31 -0500)]
ppp: Refactor connect / disconnect callbacks
Right now it is very hard to figure out whether we should be calling the
connect callback or the disconnect callback. So refactor as follows:
- Connect callback is only called once the net is actually up
- Disconnect callback is called once ppp is down, with a reason
for why it is so.
Denis Kenzior [Fri, 30 Apr 2010 19:37:17 +0000 (14:37 -0500)]
ppp: get rid of ppp_enter_phase
This function simply didn't have the context of why the phase was being
entered. Instead have each protocol notify GAtPPP as to what is
happening. We already had this more or less for IPCP and AUTH events,
this just now formalizes it for LCP as well.
Denis Kenzior [Fri, 30 Apr 2010 15:52:16 +0000 (10:52 -0500)]
ppp: Add _from_io constructor
Kristen Carlson Accardi [Thu, 29 Apr 2010 23:25:50 +0000 (16:25 -0700)]
ppp: fix return of drop_packet for NETWORK phase
Denis Kenzior [Thu, 29 Apr 2010 20:50:57 +0000 (15:50 -0500)]
gathdlc: Add from_io constructor
Johan Hedberg [Thu, 29 Apr 2010 22:23:45 +0000 (01:23 +0300)]
Fix parent path introspection data invalidation for multiple levels
In the case that parent path data needs to be invalidated we shouldn't
stop at the immediate parent if it doesn't have our own handler
registered but should continue upwards in the tree until we reach root
or our own handler.
Johan Hedberg [Thu, 29 Apr 2010 21:27:54 +0000 (00:27 +0300)]
Fix memory leak in g_dbus_register_interface
Kristen Carlson Accardi [Thu, 29 Apr 2010 19:18:29 +0000 (12:18 -0700)]
ppp: silently drop invalid packets
Kristen Carlson Accardi [Thu, 29 Apr 2010 18:03:09 +0000 (11:03 -0700)]
ppp: transition to dead when read io destroyed
remove call to signal_close for lcp object, it is redundent. If
our io is destroyed we are dead, so transition the ppp phase to
DEAD so our disconnect callback can be called.
Denis Kenzior [Thu, 29 Apr 2010 01:25:10 +0000 (20:25 -0500)]
ppp: Hang set_recording off the GAtPPP object
Marcel: recording right now only works for PPP, so we'd need some sort
of multi-protocol support.
So for now expose set_recording to be used through the main PPP object.
HDLC object recording support needs to be extended.
Yang Gu [Wed, 28 Apr 2010 12:39:34 +0000 (20:39 +0800)]
Add unit test for get inkey parser
Denis Kenzior [Wed, 28 Apr 2010 22:24:36 +0000 (17:24 -0500)]
ppp: Re-add capability to detect io down events
Denis Kenzior [Wed, 28 Apr 2010 22:15:07 +0000 (17:15 -0500)]
gathdlc: Add accessor for GAtIO
Denis Kenzior [Wed, 28 Apr 2010 22:06:03 +0000 (17:06 -0500)]
gathdlc: Port GAtHDLC to use GAtIO
Denis Kenzior [Wed, 28 Apr 2010 22:05:06 +0000 (17:05 -0500)]
ppp: Don't crash if the interface wasn't created
Denis Kenzior [Wed, 28 Apr 2010 21:06:39 +0000 (16:06 -0500)]
ppp: Accept 1500 byte MTUs
Denis Kenzior [Wed, 28 Apr 2010 20:55:16 +0000 (15:55 -0500)]
gsmdial: Use set recording on the HDLC object
Denis Kenzior [Wed, 28 Apr 2010 20:54:58 +0000 (15:54 -0500)]
ppp: Add getter for HDLC object
Denis Kenzior [Wed, 28 Apr 2010 20:31:59 +0000 (15:31 -0500)]
ppp: Initial port of PPP to use GAtHDLC
Denis Kenzior [Wed, 28 Apr 2010 20:31:01 +0000 (15:31 -0500)]
ppp: Make pppcp functions const correct
Denis Kenzior [Wed, 28 Apr 2010 20:29:55 +0000 (15:29 -0500)]
ppp: Make ppp_chap_process_packet const correct
Denis Kenzior [Wed, 28 Apr 2010 20:29:22 +0000 (15:29 -0500)]
ppp: Make ppp_net_process_packet const correct
Denis Kenzior [Wed, 28 Apr 2010 14:49:58 +0000 (09:49 -0500)]
gathdlc: Add recording support, ported from PPP
For protocol examination using wireshark
Denis Kenzior [Wed, 28 Apr 2010 04:37:53 +0000 (23:37 -0500)]
gathdlc: Add receive ACCM support
Denis Kenzior [Wed, 28 Apr 2010 04:25:28 +0000 (23:25 -0500)]
gathdlc: Support transmit ACCM
Denis Kenzior [Wed, 28 Apr 2010 03:46:46 +0000 (22:46 -0500)]
gatchat: Don't try to cleanup twice
In case we get unrefed from the disconnect callback
Denis Kenzior [Wed, 28 Apr 2010 03:46:23 +0000 (22:46 -0500)]
gatchat: Use GAtIO for write watchers
Denis Kenzior [Wed, 28 Apr 2010 03:43:25 +0000 (22:43 -0500)]
gatio: support for blocking / nonblocking writes
Denis Kenzior [Wed, 28 Apr 2010 01:29:50 +0000 (20:29 -0500)]
gatchat: get_channel should return one from GAtIO
Denis Kenzior [Wed, 28 Apr 2010 01:28:59 +0000 (20:28 -0500)]
gatchat: Channel is now setup by GAtIO
Denis Kenzior [Wed, 28 Apr 2010 01:07:47 +0000 (20:07 -0500)]
gatchat: Better re-entrancy handling
Denis Kenzior [Tue, 27 Apr 2010 22:20:10 +0000 (17:20 -0500)]
gsmdial: Get rid of g_at_chat_shutdown usage
Denis Kenzior [Tue, 27 Apr 2010 22:10:42 +0000 (17:10 -0500)]
gsmdial: Unref the chat instead of using shutdown
Denis Kenzior [Tue, 27 Apr 2010 22:10:18 +0000 (17:10 -0500)]
gatmux: Unref the chat instead of using shutdown
Denis Kenzior [Tue, 27 Apr 2010 22:09:37 +0000 (17:09 -0500)]
Fix: For now calling g_at_chat_unref is fine
Same as g_at_chat_shutdown in this case
Denis Kenzior [Tue, 27 Apr 2010 22:09:22 +0000 (17:09 -0500)]
Fix: g_at_chat_shutdown usage in test-mux
Denis Kenzior [Tue, 27 Apr 2010 22:07:37 +0000 (17:07 -0500)]
Fix: Remove easy uses of g_at_chat_shutdown
Denis Kenzior [Tue, 27 Apr 2010 22:06:53 +0000 (17:06 -0500)]
gatchat: Only set debug on IO if we have it
Denis Kenzior [Tue, 27 Apr 2010 22:05:58 +0000 (17:05 -0500)]
gatchat: Replace shutdown by suspend/resume
Shutdown was actually pointless and according to Marcel he only had it
in mind for PPP useage.
Denis Kenzior [Tue, 27 Apr 2010 21:28:10 +0000 (16:28 -0500)]
gatchat: port gatchat to use gatio
Denis Kenzior [Tue, 27 Apr 2010 21:26:54 +0000 (16:26 -0500)]
gatio: Remove g_at_io_shutdown
Denis Kenzior [Tue, 27 Apr 2010 19:48:11 +0000 (14:48 -0500)]
gatio: Get re-entrancy correct
Denis Kenzior [Tue, 27 Apr 2010 19:47:38 +0000 (14:47 -0500)]
gatio: Style fix for gsource id comparisons
Denis Kenzior [Tue, 27 Apr 2010 19:46:54 +0000 (14:46 -0500)]
gatio: Kill the reader when no more space
Denis Kenzior [Tue, 27 Apr 2010 17:32:40 +0000 (12:32 -0500)]
gatchat: Remove g_at_chat_set_syntax
Never used and too unsafe in its current form
Denis Kenzior [Tue, 27 Apr 2010 16:07:53 +0000 (11:07 -0500)]
gatchat: Add initial GAtIO implementation
Aki Niemi [Tue, 27 Apr 2010 12:12:57 +0000 (15:12 +0300)]
Add sane default to dial-number script
Aki Niemi [Tue, 27 Apr 2010 12:12:32 +0000 (15:12 +0300)]
gisi: remove misplaced define
Aki Niemi [Tue, 27 Apr 2010 12:12:17 +0000 (15:12 +0300)]
gisi: refactor client implementation
Aki Niemi [Tue, 27 Apr 2010 20:08:10 +0000 (23:08 +0300)]
Fix typo in gprs driver
Aki Niemi [Tue, 27 Apr 2010 12:11:53 +0000 (15:11 +0300)]
Fix faulty logic in netreg driver
Also add missing tech param.
Aki Niemi [Tue, 27 Apr 2010 12:10:55 +0000 (15:10 +0300)]
Fix remove ops in isimodem drivers
Aki Niemi [Sat, 24 Apr 2010 01:58:01 +0000 (04:58 +0300)]
Fix style issues in isimodem
Yang Gu [Tue, 27 Apr 2010 09:47:12 +0000 (17:47 +0800)]
stkutil: Make get inkey parser use its own struct
Yang Gu [Tue, 27 Apr 2010 09:47:11 +0000 (17:47 +0800)]
stkutil: Use char* instead of char**
char ** should only be used for character arrays that are allocated by
the parser. Static buffers should be passed as char*
Yang Gu [Tue, 27 Apr 2010 09:47:10 +0000 (17:47 +0800)]
test-stkutil: Add unit test for more time parser
Yang Gu [Tue, 27 Apr 2010 09:47:09 +0000 (17:47 +0800)]
stkutil: Add 'more time' proactive command parser
Yang Gu [Tue, 27 Apr 2010 09:47:08 +0000 (17:47 +0800)]
test-stkutil: Refactor display text unit tests
Yang Gu [Tue, 27 Apr 2010 09:47:07 +0000 (17:47 +0800)]
stkutil: Use struct to represent frame id
Use a field has_id to indicate if we have frame id or not. Originally
we use 0xFF to indicate we don't have frame id. But in that way, we
have to initialize each test case of proactive command when it doesn't
have this comprehension tlv to be 0xFF. To use has_id will save this
effort, and keep consistency with other implementations.
Yang Gu [Tue, 27 Apr 2010 09:47:06 +0000 (17:47 +0800)]
stkutil: Move advance of ctlv to parse_dataobj
Not all the proactive commands have comprehension tlv other than
command details and device identities. So the appropriate code should
be moved to parse_dataobj() from stk_command_new_from_pdu().
Kristen Carlson Accardi [Mon, 26 Apr 2010 18:44:36 +0000 (11:44 -0700)]
ppp: use default ACCM when sending LCP codes 1-7
According to the spec, you must transmit all Link Configuration,
Termination, and Code-Reject packets as if no options had been
negotiated. This requires that when encoding we use the
default ACCM of 0xffffffff when sending these types of packets.
Kristen Carlson Accardi [Mon, 26 Apr 2010 17:28:41 +0000 (10:28 -0700)]
ppp: discard non-LCP packets in ESTABLISHMENT phase
Yang Gu [Mon, 26 Apr 2010 10:29:21 +0000 (18:29 +0800)]
stkutil: Fix the assignment to minimum set
Pekka Pessi [Fri, 23 Apr 2010 15:17:16 +0000 (18:17 +0300)]
Fix: transaction id usage in gisi/server.c
Marcel Holtmann [Sat, 24 Apr 2010 17:12:30 +0000 (19:12 +0200)]
Fix broken HDLC flag handling
Marcel Holtmann [Sat, 24 Apr 2010 17:02:04 +0000 (19:02 +0200)]
Fix wrong escape character check in HDLC transmit
Marcel Holtmann [Sat, 24 Apr 2010 17:00:54 +0000 (19:00 +0200)]
Allow real wrapping around of HDLC transmit ring buffer
Marcel Holtmann [Sat, 24 Apr 2010 16:59:44 +0000 (18:59 +0200)]
Add offset parameter to ring_buffer_write_ptr() function
Marcel Holtmann [Sat, 24 Apr 2010 16:54:34 +0000 (18:54 +0200)]
Add support for wrapping of HDLC transmit ring buffer
Yang Gu [Thu, 22 Apr 2010 15:12:30 +0000 (23:12 +0800)]
stkutil: Add parser for broadcast network info
Yang Gu [Thu, 22 Apr 2010 15:12:29 +0000 (23:12 +0800)]
stkutil: Add parser for activate descriptor
Yang Gu [Thu, 22 Apr 2010 15:12:28 +0000 (23:12 +0800)]
stkutil: Add parser for registry app data objects
Yang Gu [Thu, 22 Apr 2010 15:12:27 +0000 (23:12 +0800)]
stkutil: Add parser for last envelope objects
Yang Gu [Thu, 22 Apr 2010 15:12:26 +0000 (23:12 +0800)]
stkutil: Add parser for MMS notification objects
Yang Gu [Thu, 22 Apr 2010 15:12:25 +0000 (23:12 +0800)]
stkutil: Add parser for mm cid objects
Yang Gu [Thu, 22 Apr 2010 15:12:24 +0000 (23:12 +0800)]
stkutil: Add parser for MMS transfer status
Yang Gu [Thu, 22 Apr 2010 15:12:23 +0000 (23:12 +0800)]
stkutil: Add parser for MMS identifier objects