review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

robertphillips@google.com [Sun, 10 Nov 2013 14:40:21 +0000 (14:40 +0000)]

Re-enable SK_ATTR_DEPRECATED (i.e., revert r12067)

git-svn-id: http://skia.googlecode.com/svn/trunk@12209 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 9 Nov 2013 07:02:23 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12208 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Sat, 9 Nov 2013 04:45:18 +0000 (04:45 +0000)]

More new baselines for stragglerbots.

TBR=epoger
BUG=

Review URL: https://codereview.chromium.org/63173014

git-svn-id: http://skia.googlecode.com/svn/trunk@12207 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 9 Nov 2013 01:37:30 +0000 (01:37 +0000)]

add GM case nonclosedpaths. The 2 bugs below showed some non-closed paths which are easy to get wrong rendering results. So add a GM case for this kind paths to avoid potential bugs to be introduced.

BUG=skia:1782
BUG=skia:1811
R=bsalomon@google.com, caryclark@google.com, reed@google.com, robertphillips@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/64173009

git-svn-id: http://skia.googlecode.com/svn/trunk@12206 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 21:24:40 +0000 (21:24 +0000)]

Blur rebaselines for some straggler bots that just caught up.

R=epoger
BUG=

Review URL: https://codereview.chromium.org/58853007

git-svn-id: http://skia.googlecode.com/svn/trunk@12205 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 20:49:04 +0000 (20:49 +0000)]

SSE2 implementation of RGBA box blurs. This yields ~2X perf improvement on Xeon ES-2690.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/61643011

git-svn-id: http://skia.googlecode.com/svn/trunk@12204 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 20:14:16 +0000 (20:14 +0000)]

Add sk_float_rsqrt with SSE + NEON fast paths.

Current numbers:

N4:
running bench [640 480]      math_fastIsqrt    NONRENDERING: cmsecs =      3.12
running bench [640 480]      math_slowIsqrt    NONRENDERING: cmsecs =      4.82
running bench [640 480] math_sk_float_rsqrt    NONRENDERING: cmsecs =      1.99

Desktop:
running bench [640 480]      math_fastIsqrt    NONRENDERING: cmsecs =      0.89
running bench [640 480]      math_slowIsqrt    NONRENDERING: cmsecs =      0.94
running bench [640 480] math_sk_float_rsqrt    NONRENDERING: cmsecs =      0.09

Haven't found any other benches where this is a significant effect yet.

BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/60083014

git-svn-id: http://skia.googlecode.com/svn/trunk@12203 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 19:22:57 +0000 (19:22 +0000)]

Adding error checks to SkRBuffer

BUG=
R=robertphillips@google.com, bsalomon@google.com, reed@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/61913002

git-svn-id: http://skia.googlecode.com/svn/trunk@12202 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 18:45:27 +0000 (18:45 +0000)]

Fix stale assert in GrDrawTarget::print

Fix stale assert in GrDrawTarget::print.

R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/66333002

git-svn-id: http://skia.googlecode.com/svn/trunk@12201 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 8 Nov 2013 18:11:08 +0000 (18:11 +0000)]

fix compile error

git-svn-id: http://skia.googlecode.com/svn/trunk@12200 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 8 Nov 2013 18:05:02 +0000 (18:05 +0000)]

optimize floating pt, save a few instructions

git-svn-id: http://skia.googlecode.com/svn/trunk@12199 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 8 Nov 2013 18:02:53 +0000 (18:02 +0000)]

Add ability to ninepatch blurred rounded rectangle

Speed up drawing large blurry round rectangles by converting them to
nine patches.

SkDraw:
Add drawRRect.

SkBitmapDevice:
Call SkDraw::drawRRect instead of converting SkRRect to an SkPath.

SkMaskFilter/SkBlurMaskFilter:
Create a nine patch of a blurred round rect and draw it instead of
drawing the entire thing.

SkPDFDevice:
Override drawRRect to perform the old behavior in
SkBitmapDevice::drawRect.

Depends on https://codereview.chromium.org/52703003

Tests are in https://codereview.chromium.org/52793005

BUG=https://b.corp.google.com/issue?id=11174385
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/48623006

git-svn-id: http://skia.googlecode.com/svn/trunk@12198 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 8 Nov 2013 18:00:01 +0000 (18:00 +0000)]

fix line intersection

git-svn-id: http://skia.googlecode.com/svn/trunk@12197 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 8 Nov 2013 17:50:14 +0000 (17:50 +0000)]

remove bogus assert, and remove outdated #ifdef

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/66923002

git-svn-id: http://skia.googlecode.com/svn/trunk@12196 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 8 Nov 2013 17:23:54 +0000 (17:23 +0000)]

rebaseline_server: improve thread locks to allow read access during updates
(SkipBuildbotRuns)
TBR=jcgregorio

Review URL: https://codereview.chromium.org/66803004

git-svn-id: http://skia.googlecode.com/svn/trunk@12195 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 16:47:01 +0000 (16:47 +0000)]

New baselines for all currently-failing tests. All of these are minor pixel diffs, except for dashcubics_gpu on Tegra, whose baseline was previously missing.

TBR=robertphillips
BUG=

Review URL: https://codereview.chromium.org/67013002

git-svn-id: http://skia.googlecode.com/svn/trunk@12194 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 8 Nov 2013 16:25:25 +0000 (16:25 +0000)]

rebaseline_server: add pixel diffs, and sorting by diff metrics
(SkipBuildbotRuns)

R=bsalomon@google.com, jcgregorio@google.com

Review URL: https://codereview.chromium.org/59283006

git-svn-id: http://skia.googlecode.com/svn/trunk@12193 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 16:16:05 +0000 (16:16 +0000)]

ARM Skia NEON patches - 31 - Xfermode: xfer16
Xfermode: xfer16

This adds support for 16bit Xfermodes. It also tunes the gcc test
macros in xfer32() to add compatibility for gcc > 4.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/33063002

git-svn-id: http://skia.googlecode.com/svn/trunk@12192 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 15:51:12 +0000 (15:51 +0000)]

use quads for mixed radius rrects

Create a specialized version of adding a pair of corner quads
that avoids the overhead of the full arc machinery.

This is on the way to changing Chrome to calling Skia directly to create fully general round rects rather than rolling their own.

R=robertphillips@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/60203002

git-svn-id: http://skia.googlecode.com/svn/trunk@12190 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 15:24:12 +0000 (15:24 +0000)]

Removed unnecessary define

BUG=
R=bsalomon@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/59033009

git-svn-id: http://skia.googlecode.com/svn/trunk@12189 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 15:09:22 +0000 (15:09 +0000)]

Update bleed GM to use HQ filtering.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/61133002

git-svn-id: http://skia.googlecode.com/svn/trunk@12188 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 8 Nov 2013 14:42:56 +0000 (14:42 +0000)]

Revert "Do not apply hairline optimization for paths if nv_path_rendering is used"

This reverts commit r12185.

Review URL: https://codereview.chromium.org/66813002

git-svn-id: http://skia.googlecode.com/svn/trunk@12187 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 8 Nov 2013 07:01:56 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12186 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 06:19:34 +0000 (06:19 +0000)]

Do not apply hairline optimization for paths if nv_path_rendering is used

Do not convert thin, non-hairline paths to hairline paths if
nv_path_rendering is used.

The current nv_path_rendering implementation does not render
hairlines. Rendering the hairlines with normal renderers cause
unneccessary gl program changes, which is quite slow.

Changes the behavior of non-nv_path_rendering paths to always perform
the optimization if the shape ends up being painted by the
path-drawing code (GrContext::drawPathInternal). Previously the
optimization was applied only when callgraph started with
SkCanvas::drawPath. This changes drawlooper_msaa4, dashing3_msaa4 and
dashing3_gpu

R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/38573007

git-svn-id: http://skia.googlecode.com/svn/trunk@12185 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 8 Nov 2013 04:08:34 +0000 (04:08 +0000)]

Rebaseline verylargebitmap test

Review URL: https://codereview.chromium.org/60733013

git-svn-id: http://skia.googlecode.com/svn/trunk@12184 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 02:31:52 +0000 (02:31 +0000)]

New baselines for all imageblur-related tests.

TBR=robertphillips

Review URL: https://codereview.chromium.org/60803006

git-svn-id: http://skia.googlecode.com/svn/trunk@12183 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 7 Nov 2013 22:43:04 +0000 (22:43 +0000)]

Can't be leaving that crucial newline off the end of a file

git-svn-id: http://skia.googlecode.com/svn/trunk@12182 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 7 Nov 2013 22:25:21 +0000 (22:25 +0000)]

Add GM to verify removal of 32767 limit in SkBlurMaskFilter::filterRectsToNine is okay

https://codereview.chromium.org/60513013/

git-svn-id: http://skia.googlecode.com/svn/trunk@12181 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 7 Nov 2013 22:20:31 +0000 (22:20 +0000)]

"Fix" bug in debug canvas

https://codereview.chromium.org/59073008/

git-svn-id: http://skia.googlecode.com/svn/trunk@12180 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 7 Nov 2013 22:07:34 +0000 (22:07 +0000)]

pdfviewr: include what you use (stdio)

Review URL: https://codereview.chromium.org/64913003

git-svn-id: http://skia.googlecode.com/svn/trunk@12179 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 7 Nov 2013 22:06:08 +0000 (22:06 +0000)]

Added support for Chrome's gpu command buffer extension BindUniformLocation.

R=bsalomon@google.com, bsalomon

Author: skaslev@chromium.org

Review URL: https://codereview.chromium.org/62163004

git-svn-id: http://skia.googlecode.com/svn/trunk@12178 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 7 Nov 2013 20:33:17 +0000 (20:33 +0000)]

pdfviewer: fix typos (|| instead of |)

Review URL: https://codereview.chromium.org/65263002

git-svn-id: http://skia.googlecode.com/svn/trunk@12176 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 7 Nov 2013 19:40:35 +0000 (19:40 +0000)]

fix broken build on mac due to compiler warning

R=epoger@google.com

Review URL: https://codereview.chromium.org/64423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12175 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 7 Nov 2013 19:24:06 +0000 (19:24 +0000)]

update skpdiff visualization (image magnification with alpha mask)

R=epoger@google.com

Review URL: https://codereview.chromium.org/29103005

git-svn-id: http://skia.googlecode.com/svn/trunk@12174 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 7 Nov 2013 18:35:12 +0000 (18:35 +0000)]

Implement the y-transpose optimization in image (RGBA) blurs. This gives ~38% performance improvement on my Linux box. Also unify the box blur functions with a template.

R=mtklein@google.com, mtklein, reed@google.com

Review URL: https://codereview.chromium.org/59133006

git-svn-id: http://skia.googlecode.com/svn/trunk@12171 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 7 Nov 2013 18:22:18 +0000 (18:22 +0000)]

Fix Mac warning in PdfViewer.

Move a function only used by code guarded by #ifdef PDF_REPORT inside
guard.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/60763003

git-svn-id: http://skia.googlecode.com/svn/trunk@12170 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 7 Nov 2013 16:36:46 +0000 (16:36 +0000)]

Mark Xoom scaled_tilemodes_npot GPU images as ignore

BUG=skia:1814

Review URL: https://codereview.chromium.org/61763011

git-svn-id: http://skia.googlecode.com/svn/trunk@12169 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 7 Nov 2013 16:34:53 +0000 (16:34 +0000)]

Fix for thin filled and hairline roundrects.

The roundrect renderer was dropping into the
ConvexPathRenderer when it didn't need to -- if a stroke is
just on the edge of being acceptable it will now use the
roundrect renderer.

BUG=Skia:1802
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/59903005

git-svn-id: http://skia.googlecode.com/svn/trunk@12168 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 7 Nov 2013 16:06:53 +0000 (16:06 +0000)]

Revert "Revert "speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values.""

This reverts commit 3c77887b3eb2d32ab668ab4e5f2f9e79103956e8.

BUG=

Review URL: https://codereview.chromium.org/50673005

git-svn-id: http://skia.googlecode.com/svn/trunk@12167 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 7 Nov 2013 15:57:32 +0000 (15:57 +0000)]

ARM Skia NEON patches - 33 - Convolution filter
NEON version of the convolutionProcs

The bitmap_scale benchmark is now twice as fast on ARM.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12154

R=djsollen@google.com, mtklein@google.com, humper@google.com, epoger@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/27533004

git-svn-id: http://skia.googlecode.com/svn/trunk@12166 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 7 Nov 2013 13:43:03 +0000 (13:43 +0000)]

Whitespace change to trigger builds after r12163

Review URL: https://codereview.chromium.org/64283003

git-svn-id: http://skia.googlecode.com/svn/trunk@12165 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Thu, 7 Nov 2013 12:18:35 +0000 (12:18 +0000)]

Whitespace change to test master responsiveness.

git-svn-id: http://skia.googlecode.com/svn/trunk@12162 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 7 Nov 2013 07:02:19 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12161 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 7 Nov 2013 04:22:46 +0000 (04:22 +0000)]

whitespace change after killing trybots
BUG=skia:1810

git-svn-id: http://skia.googlecode.com/svn/trunk@12160 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 6 Nov 2013 20:58:25 +0000 (20:58 +0000)]

2nd whitespace change after git-repo filtering
BUG=skia:1808

git-svn-id: http://skia.googlecode.com/svn/trunk@12159 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 6 Nov 2013 20:44:12 +0000 (20:44 +0000)]

Whitespace commit after git-repo filtering
BUG=skia:1808

git-svn-id: http://skia.googlecode.com/svn/trunk@12158 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

vandebo@chromium.org [Wed, 6 Nov 2013 16:32:15 +0000 (16:32 +0000)]

Update gm flags so that it can be run without a pdf rasterizer.

BUG=1806
R=edisonn@google.com

Review URL: https://codereview.chromium.org/61643004

git-svn-id: http://skia.googlecode.com/svn/trunk@12157 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 6 Nov 2013 15:49:04 +0000 (15:49 +0000)]

Revert r12154
BUG=skia:1807

git-svn-id: http://skia.googlecode.com/svn/trunk@12156 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Wed, 6 Nov 2013 15:07:44 +0000 (15:07 +0000)]

New SkRTConf macro SK_CONF_TRY_SET: no complaint on missing configuration

SK_CONF_TRY_SET() is like SK_CONF_SET(), but doesn't complain if
confname can't be found.  This is useful if the SK_CONF_DECLARE is
inside a source file whose linkage is dependent on the system.

Internally to the SkRTConf system, SkRTConfRegistry::set() was given
an additional parameter controling wanrings.

A new RuntimeConfig unit test was introduced.  It should run silently.
In the future, it should be expanded to cover all of the SkRTConf
functionality.

(For example, the images.jpeg.suppressDecoderWarnings variable is
defined and used only in SkImageDecoder_libjpeg.cpp, but on MacOS, we
use Core Graphics via SkImageDecoder_CG.cpp - SkImageDecoder_libjpeg
is never linked in.  The same is true of the Windows Imaging Component
on Windows.)

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/54503007

git-svn-id: http://skia.googlecode.com/svn/trunk@12155 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 6 Nov 2013 15:02:46 +0000 (15:02 +0000)]

ARM Skia NEON patches - 33 - Convolution filter
NEON version of the convolutionProcs

The bitmap_scale benchmark is now twice as fast on ARM.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com, humper@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/27533004

git-svn-id: http://skia.googlecode.com/svn/trunk@12154 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 6 Nov 2013 15:01:37 +0000 (15:01 +0000)]

Fix installing the release build sample app apk

The android_setup.sh parses command line arguments and stores the ones
it does not use to APP_ARGS variable.

R=djsollen@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/61553002

git-svn-id: http://skia.googlecode.com/svn/trunk@12153 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Wed, 6 Nov 2013 14:18:46 +0000 (14:18 +0000)]

Fix a bug which caused crash in SkRTConfig whith string values in environment variables

A minor change to SkRTConfRegistry::parse() fixes this

BUG=skia:1717
R=scroggo@google.com

Review URL: https://codereview.chromium.org/26373008

git-svn-id: http://skia.googlecode.com/svn/trunk@12152 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 6 Nov 2013 10:08:38 +0000 (10:08 +0000)]

Perlin issue fixed

BUG=skia:1799
R=sugoi@chromium.org, sugoi@google.com, senorblanco@chromium.org

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/59173005

git-svn-id: http://skia.googlecode.com/svn/trunk@12150 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 6 Nov 2013 10:08:30 +0000 (10:08 +0000)]

Break up SkLazyPixelRef functionally into class hierarchy.

The reason for this CL is to allow greater decoder flexibility.
Chrome currently uses its own decoding functions.  These allow for
greater flexibility in dealing with images with multiple frames or
partial data.  The DecodeProc function was not flexible enough to
handle these.  Instead of asking the decoder to squeeze everything
into the DecodeProc, we now ask the downstream library to inherit from
SkCachingPixelRef.  If WebKit's LazyDecodingPixelRef is re-tooled to
inherit from SkCachingPixelRef, then it can make use of Skia's caching
ability while still allowing it to deal with multiple frames, scaling,
subsetting, and partial data.

-   The abstract SkCachingPixelRef class handles caching the decoded
    data in a SkScaledImageCache.  This class relies on the virtual
    functions onDecodeInfo() and onDecode() to do the actual decoding
    of data.

-   The SkLazyCachingPixelRef class is derived from SkCachingPixelRef.
    It provides an implementation of onDecodeInfo() and onDecode() in
    terms of calls to a SkBitmapFactory::DecodeProc function.  It also
    provides an Install() static method which installs a new
    SkLazyCachingPixelRef into a SkBitmap.

SkLazyCachingPixelRef exists for two reasons: to test
SkCachingPixelRef within Skia and as an example for downstream
developers to make their own classes that inherit from
SkCachingPixelRef.

-   The CachedDecodingPixelRefTest was updated to test the
    SkLazyCachingPixelRef class and indirectly the SkCachingPixelRef
    class.

BUG=
R=reed@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/54203006

git-svn-id: http://skia.googlecode.com/svn/trunk@12149 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 6 Nov 2013 10:08:21 +0000 (10:08 +0000)]

Add bevel-stroke support in GrAARectRenderer

Committed: http://code.google.com/p/skia/source/detail?r=12082

R=robertphillips@google.com, bsalomon@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/23712005

git-svn-id: http://skia.googlecode.com/svn/trunk@12148 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 6 Nov 2013 07:02:11 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12147 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 5 Nov 2013 22:04:53 +0000 (22:04 +0000)]

blurroundrect gm: disable one set of tests in attempt to fix bug
BUG=skia:1801
R=scroggo@google.com

Review URL: https://codereview.chromium.org/61073002

git-svn-id: http://skia.googlecode.com/svn/trunk@12146 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 21:22:04 +0000 (21:22 +0000)]

Fix overzealous IntToScalar.

git-svn-id: http://skia.googlecode.com/svn/trunk@12145 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 21:10:58 +0000 (21:10 +0000)]

Fixes for blurroundrect gm/bench.

Simplify naming/various cases.
Have an atlas of gms, rather than several different images.
In the bench, pull non rendering out of the loop.
Use meaningful enums instead of integers where appropriate.
Add comments.

Addresses comments in https://codereview.chromium.org/52793005/

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/59983004

git-svn-id: http://skia.googlecode.com/svn/trunk@12144 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 5 Nov 2013 21:00:24 +0000 (21:00 +0000)]

rebaseline_server was not allowing tests to be marked ignore-failure
(SkipBuildbotRuns)
TBR=jcgregorio

Review URL: https://codereview.chromium.org/59063005

git-svn-id: http://skia.googlecode.com/svn/trunk@12143 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 5 Nov 2013 20:55:32 +0000 (20:55 +0000)]

Mark blurs-gpu test as known-to-fail on Nexus4
BUG=skia:1791
(SkipBuildbotRuns)

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/59943004

git-svn-id: http://skia.googlecode.com/svn/trunk@12142 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 17:29:23 +0000 (17:29 +0000)]

Int to scalar (again)

git-svn-id: http://skia.googlecode.com/svn/trunk@12139 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 17:27:01 +0000 (17:27 +0000)]

Another int to scalar fix.

git-svn-id: http://skia.googlecode.com/svn/trunk@12138 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 17:02:07 +0000 (17:02 +0000)]

More IntToScalars

Fix build.

git-svn-id: http://skia.googlecode.com/svn/trunk@12137 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 16:40:15 +0000 (16:40 +0000)]

And fix the similar bench.

git-svn-id: http://skia.googlecode.com/svn/trunk@12136 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 16:28:38 +0000 (16:28 +0000)]

Build fix number 2.

Use SkColors instead of numbers.

git-svn-id: http://skia.googlecode.com/svn/trunk@12135 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 16:19:32 +0000 (16:19 +0000)]

Fix build.

Fix some warnings.

git-svn-id: http://skia.googlecode.com/svn/trunk@12134 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 15:57:21 +0000 (15:57 +0000)]

Add gms and benchmarks for drawing blurry round rects.

Further changes (https://codereview.chromium.org/48623006) will change
the speed at which the bench draws and the drawing of the gm (the gm
change is small).

One of these round rects causes slow drawing in a webpage that we have
observed.

BUG=https://b.corp.google.com/issue?id=11174385

Review URL: https://codereview.chromium.org/52793005

git-svn-id: http://skia.googlecode.com/svn/trunk@12133 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 5 Nov 2013 15:54:42 +0000 (15:54 +0000)]

Add SkRRect::transform.

Much like SkPath::transform, it transforms an SkRRect based on an
SkMatrix. Unlike SkPath::transform, it will fail for matrices that
contain perspective or skewing.

Required by a future change (https://codereview.chromium.org/48623006)
to speed up drawing large blurry rounded rectangles by using ninepatches.

TODO: This could easily support 90 degree rotations, if desired.

BUG=https://b.corp.google.com/issue?id=11174385
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/52703003

git-svn-id: http://skia.googlecode.com/svn/trunk@12132 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 5 Nov 2013 15:47:48 +0000 (15:47 +0000)]

Check that Mode is valid for ModeColorFilterEffect

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/53983005

git-svn-id: http://skia.googlecode.com/svn/trunk@12131 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 5 Nov 2013 15:46:56 +0000 (15:46 +0000)]

Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.

BUG=
R=reed@google.com, mtklein@google.com, senorblanco@chromium.org

Committed: https://code.google.com/p/skia/source/detail?r=12114

Committed: https://code.google.com/p/skia/source/detail?r=12119

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/41253002

git-svn-id: http://skia.googlecode.com/svn/trunk@12130 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 5 Nov 2013 15:03:26 +0000 (15:03 +0000)]

Add SK_PREFETCH and use in SkBlurImageFilter.

Relative speed is 1.2-1.6x on desktop, 1.0-1.2x on Nexus 4.

(Division remains the bottleneck, now more so.)

BUG=
R=senorblanco@google.com, reed@google.com, senorblanco@chromium.org

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/57823003

git-svn-id: http://skia.googlecode.com/svn/trunk@12129 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 5 Nov 2013 15:03:19 +0000 (15:03 +0000)]

Make it possible to pass GYP_DEFINES to Android builds

Pass possibly existing GYP_DEFINES from shell to gyp when building
for Android. Makes it possible to use custom build flags such as
skia_nv_path_rendering=1.

R=djsollen@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/51003007

git-svn-id: http://skia.googlecode.com/svn/trunk@12128 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 5 Nov 2013 15:03:08 +0000 (15:03 +0000)]

Avoid re-rendering stencil clip for every draw with reducable clip stack

Fixes the cases where clip stack reduction would cause clip to be
re-rendered to stencil for each draw call. This causes unneeded
slowdown.

Stencil cache would not be used because the clip stack generation id communicated
by the clip stack element list would be invalid. This happended due to

a) clip stack reduction creating new elements in the element list.

b) purging logic removing the generation id, but reduction logic
selecting already purged element, and thus the generation id, as
the representative state of the clip.

Cases of a) where reduction would flatten the stack to a single new
element were fixed by assigning the generation id of the top-most
element of the clip stack as the generation id of the new
element. This is not strictly minimal, but enables more caching than
using invalid id.

Cases of a) where reduction would substitute a stack element with a
new element the generation id of the substituted element is used.

The b) part was fixed by removing the purging logic. It was not
exactly correct, as the previously purged states were actually
used. The purging was not used for anything.

Changes SkClipStack API to highlight that invalid generation id is
never returned by SkClipStack. Empty stacks are wide open. Changes the
clients to reflect this.

Fixes a crash when not passing anti-alias out parameter to
GrReducedClip::ReduceClipStack. The crash is not exercised in the
current code.

Committed: http://code.google.com/p/skia/source/detail?r=12084

R=bsalomon@google.com, robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/48593003

git-svn-id: http://skia.googlecode.com/svn/trunk@12127 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 4 Nov 2013 21:35:55 +0000 (21:35 +0000)]

Revert "Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream."

This reverts commit 6bc22e8ef1ea70a1b58409aa21254358c50f149a.

git-svn-id: http://skia.googlecode.com/svn/trunk@12124 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Mon, 4 Nov 2013 21:22:45 +0000 (21:22 +0000)]

We always read out of bounds here. Fix that.

Turns out the comment wasn't lying!

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/58473002

git-svn-id: http://skia.googlecode.com/svn/trunk@12123 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 4 Nov 2013 20:57:36 +0000 (20:57 +0000)]

Revert "speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values."

This reverts commit d615e839b71f75df895de6850b774a9e1c28ad2a.

Revert "must initialize SkDraw.fClip"

This reverts commit 108e46d29b5f57927fc8b8c403bb52019d8cb16d.

BUG=

Review URL: https://codereview.chromium.org/57883006

git-svn-id: http://skia.googlecode.com/svn/trunk@12122 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Mon, 4 Nov 2013 20:38:18 +0000 (20:38 +0000)]

rebaseline scaled_tilemode_npot gpu images on RHB and rebaseline SGX tilemode gpu

BUG=skia:1789

Review URL: https://codereview.chromium.org/47263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12121 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 4 Nov 2013 20:31:40 +0000 (20:31 +0000)]

must initialize SkDraw.fClip

git-svn-id: http://skia.googlecode.com/svn/trunk@12120 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Mon, 4 Nov 2013 20:28:23 +0000 (20:28 +0000)]

Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.

BUG=
R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12114

Review URL: https://codereview.chromium.org/41253002

git-svn-id: http://skia.googlecode.com/svn/trunk@12119 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 4 Nov 2013 20:10:33 +0000 (20:10 +0000)]

speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values.

R=bsalomon@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/56453002

git-svn-id: http://skia.googlecode.com/svn/trunk@12118 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Mon, 4 Nov 2013 18:13:00 +0000 (18:13 +0000)]

rebaseline blurs_gpu
BUG=skia:1791
TBR=robertphillips

Review URL: https://codereview.chromium.org/57433005

git-svn-id: http://skia.googlecode.com/svn/trunk@12116 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Mon, 4 Nov 2013 18:06:12 +0000 (18:06 +0000)]

Revert r12114 due to https://code.google.com/p/skia/issues/detail?id=1794 ('Assertion failures on various buildbots as of r12114')

git-svn-id: http://skia.googlecode.com/svn/trunk@12115 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Mon, 4 Nov 2013 16:18:15 +0000 (16:18 +0000)]

Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/41253002

git-svn-id: http://skia.googlecode.com/svn/trunk@12114 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 4 Nov 2013 16:07:33 +0000 (16:07 +0000)]

Change SkBlurImageFilter to use fixed-point division. Yields ~1.8X speedup on
MacBookPro.

Note: this will require defining SK_DISABLE_BLUR_DIVISION_OPTIMIZATION in
Chrome, a la https://codereview.chromium.org/49973005.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/57513002

git-svn-id: http://skia.googlecode.com/svn/trunk@12113 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Mon, 4 Nov 2013 12:57:42 +0000 (12:57 +0000)]

fix baselines for arcofzorro hairlines shadertext shadertext2

git-svn-id: http://skia.googlecode.com/svn/trunk@12109 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 3 Nov 2013 13:40:34 +0000 (13:40 +0000)]

Fix for Chromium-side compilation complaint:

src/pathops/SkIntersectionHelper.h:10:13: error: #if with no expression

git-svn-id: http://skia.googlecode.com/svn/trunk@12108 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 2 Nov 2013 07:02:02 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12101 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 21:15:01 +0000 (21:15 +0000)]

fix more expectations for shadertext shadertext2 hairlines

git-svn-id: http://skia.googlecode.com/svn/trunk@12099 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

vandebo@chromium.org [Fri, 1 Nov 2013 21:10:17 +0000 (21:10 +0000)]

Update missed expectations for xfermodes

ref: r12034, r12053

Review URL: https://codereview.chromium.org/56473003

git-svn-id: http://skia.googlecode.com/svn/trunk@12098 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 20:45:49 +0000 (20:45 +0000)]

update ignored tests with rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@12097 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 20:34:24 +0000 (20:34 +0000)]

fix shadertext2 expectations

git-svn-id: http://skia.googlecode.com/svn/trunk@12096 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 20:25:47 +0000 (20:25 +0000)]

fix shadedtext expectations

git-svn-id: http://skia.googlecode.com/svn/trunk@12095 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 20:16:50 +0000 (20:16 +0000)]

fix hairline expectations

git-svn-id: http://skia.googlecode.com/svn/trunk@12094 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 20:02:16 +0000 (20:02 +0000)]

fix expectations for arcofzorro

git-svn-id: http://skia.googlecode.com/svn/trunk@12093 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 19:28:33 +0000 (19:28 +0000)]

ignore gm roundrect errors including arcofzorro

git-svn-id: http://skia.googlecode.com/svn/trunk@12092 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 1 Nov 2013 19:22:42 +0000 (19:22 +0000)]

Reverting r12082 (Add bevel-stroke support in GrAARectRenderer) due to GM failures

git-svn-id: http://skia.googlecode.com/svn/trunk@12091 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 19:18:59 +0000 (19:18 +0000)]

ignore gm roundrect errors

git-svn-id: http://skia.googlecode.com/svn/trunk@12090 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 1 Nov 2013 17:36:03 +0000 (17:36 +0000)]

pathops work in progress

BUG=

Review URL: https://codereview.chromium.org/52653002

git-svn-id: http://skia.googlecode.com/svn/trunk@12089 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 1 Nov 2013 16:46:41 +0000 (16:46 +0000)]

rebaseline_server: make default landing page list supported query URLs
(SkipBuildbotRuns)

Originally, the default landing page redirected to view.html?resultsToLoad=all
(which displays all results, and can take a while).
Instead, start with a fast-loading page that shows the user all the result
sets that are available.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/46413004

git-svn-id: http://skia.googlecode.com/svn/trunk@12088 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom