Mikhail Maltsev [Mon, 19 Oct 2020 17:30:51 +0000 (18:30 +0100)]
[clang] Use SourceLocation as key in std::map, NFCI
SourceLocation implements `operator<`, so `SourceLocation`-s can be used
as keys in `std::map` directly, there is no need to extract the internal
representation.
Since the `operator<` simply compares the internal representations of
its operands, this patch does not introduce any functional changes.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D89705
Florian Hahn [Mon, 19 Oct 2020 16:25:34 +0000 (17:25 +0100)]
[SCEV] Add tests where assumes can be used to improve tripe multiple.
This patch adds a set of tests where information from assumes can be
used to improve the trip multiple.
See PR47904.
Louis Dionne [Fri, 16 Oct 2020 18:19:39 +0000 (14:19 -0400)]
[libc++] Add more tests for operator<< on std::complex
Amy Kwan [Thu, 15 Oct 2020 16:24:21 +0000 (11:24 -0500)]
[DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook, Use isOperationLegalOrCustom directly instead.
MULH is often expanded on targets.
This patch removes the isMulhCheaperThanMulShift hook and uses
isOperationLegalOrCustom instead.
Differential Revision: https://reviews.llvm.org/D80485
Jonas Devlieghere [Mon, 19 Oct 2020 17:18:20 +0000 (10:18 -0700)]
[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools
For testing purposes I need a way to build and install FileCheck and
yaml2obj. I had to choose between making FileCheck an LLVM tool and
making obj2yaml and yaml2obj utilities. I think the distinction is
rather arbitrary but my understanding is that tools are things meant for
the toolchain while utilities are more used for things like testing,
which is the case here.
The functional difference is that these tools now end up in the
${LLVM_UTILS_INSTALL_DIR}, which defaults to the ${LLVM_TOOLS_INSTALL_DIR}.
Unless you specified a different value or you added obj2yaml and
yaml2obj to ${LLVM_TOOLCHAIN_TOOLS}, this patch shouldn't change
anything.
Differential revision: https://reviews.llvm.org/D89357
Tony [Mon, 19 Oct 2020 01:04:06 +0000 (01:04 +0000)]
[AMDGPU] Simplify cumode handling in SIMemoryLegalizer
Differential Revision: https://reviews.llvm.org/D89663
Tony [Sat, 17 Oct 2020 22:38:04 +0000 (22:38 +0000)]
[AMDGPU] Extend hip-toolchin-features.hip test
- Extend hip-toolchin-features.hip to also check the lld attributes
are passed correctly.
- Add check for cumode attributes.
Differential Revision: https://reviews.llvm.org/D89636
Tony [Sat, 17 Oct 2020 21:59:54 +0000 (21:59 +0000)]
[AMDGPU] Correct hsa-diag-v3.s test
- Use file_check -LABEL markers to prevent false positives being
reported due to messages from different tests causing success to be
reported.
- Add checks for all the run commands for more robust testing.
- Add checks for the absence of errors.
- Name and order tests more sensibly.
Differential Revision: https://reviews.llvm.org/D89635
Mircea Trofin [Mon, 19 Oct 2020 16:13:47 +0000 (09:13 -0700)]
[NFC][MC] Type [MC]Register uses in MachineTraceMetrics
Differential Revision: https://reviews.llvm.org/D89710
Alex Richardson [Mon, 19 Oct 2020 16:22:54 +0000 (17:22 +0100)]
[libc++] Skip tests using constexpr destructors with older clang versions
It appears that the released version of clang that supports constexpr
destructors is clang 10 and the oldest one that accepts -std=c++2a is 5,
so mark these as UNSUPPORTED for clang-5 to clang-9.
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D89704
sameeran joshi [Tue, 6 Oct 2020 04:51:06 +0000 (10:21 +0530)]
[Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct.
From OpenACC 3.0 Standards document
840 • A program may not branch into or out of an OpenACC parallel construct.
Exits are allowed provided it does not cause an exit outside the parallel region.
Test case exits out of the inner do loop, but it is still inside the parallel region.
Patch tries to extract labels from block attached to a construct,
If the exit is to a label not in the collected list then flags an error.
Reviewed By: tskeith
Differential Revision: https://reviews.llvm.org/D87906
Louis Dionne [Fri, 16 Oct 2020 14:33:18 +0000 (10:33 -0400)]
[libc++] Refactor the fuzzing tests
Define all the fuzzing tests in libcxx/test/libcxx/fuzzing, and get
rid of the ad-hoc libcxx/fuzzing directory, which wasn't properly
integrated with the build system or test suite.
As a fly-by change, this also reduces the dependencies of fuzzing tests
on large library components like <iostream>, to make them work on more
platforms.
Lang Hames [Mon, 19 Oct 2020 15:45:38 +0000 (08:45 -0700)]
[ORC] Fix unused variable warning.
Simon Pilgrim [Mon, 19 Oct 2020 16:05:38 +0000 (17:05 +0100)]
[InstCombine] foldOrOfICmps - only fold (icmp_eq B, 0) | (icmp_ult/gt A, B) for integer types
Fixes a number of stage2 buildbots that were failing when I generalized the m_ConstantInt() logic - that didn't match for pointer types but m_Zero() does......
Mircea Trofin [Sat, 17 Oct 2020 15:40:44 +0000 (08:40 -0700)]
[ML] Add final reward logging facility.
Allow logging final rewards. A final reward is logged only once, and is
serialized as all-zero values, except for the last one.
Differential Revision: https://reviews.llvm.org/D89626
Nabeel Omer [Mon, 19 Oct 2020 15:38:49 +0000 (16:38 +0100)]
[Dexter][NFC] Add Missing Commands to Commands.md Contents
NFC patch simply updates the commands.md documentation contents with missing
links to the DexLimitSteps and DexLabel command documentation.
Differential Revision: https://reviews.llvm.org/D89689
Author: Nabeel Omer <nabeel.omer@sony.com>
Louis Dionne [Tue, 1 Oct 2019 13:34:58 +0000 (09:34 -0400)]
[libc++] Define new/delete in libc++abi only by default
Previously, we would define new/delete in both libc++ and libc++abi.
Not only does this cause code bloat, but also it's technically an ODR
violation since we don't know which operator will be selected. Furthermore,
since those are weak definitions, we should strive to have as few of them
as possible (to improve load times).
My preferred choice would have been to put the operators in libc++ only
by default, however that would create a circular dependency between
libc++ and libc++abi, which GNU linkers don't handle.
Folks who want to ship new/delete in libc++ instead of libc++abi are
free to do so by turning on LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS at
CMake configure time.
On Apple platforms, this shouldn't be an ABI break because we re-export
the new/delete symbols from libc++abi. This change actually makes libc++
behave closer to the system libc++ shipped on Apple platforms.
On other platforms, this is an ABI break for people linking against libc++
but not libc++abi. However, vendors have been consulted in D68269 and no
objection was raised. Furthermore, the definitions can be controlled to
appear in libc++ instead with the CMake option.
Differential Revision: https://reviews.llvm.org/D68269
Casey Carter [Mon, 19 Oct 2020 15:33:58 +0000 (08:33 -0700)]
[libc++][test] Portably silence warnings
... in `<numbers>` tests with `[[maybe_unused]]`.
Alex Richardson [Mon, 19 Oct 2020 15:21:10 +0000 (16:21 +0100)]
[lit] Avoid calling realpath() for every printed message
I did some profiling of lit while trying to optimize the libc++ test
startup for remote hosts and it turns out that there is a realpath() call
for every message printed and this shows up in the profile.
The inspect.getframeinfo() function calls realpath() internally and
moreover we don't need most of the other information returned from it.
This patch uses inspect.getsourcefile() and os.path.abspath() to remove
../ from the path instead. Not resolving symlinks reduces the startup time
for running a single test with lit by about 50ms for me.
Reviewed By: ldionne, yln
Differential Revision: https://reviews.llvm.org/D89186
Simon Pilgrim [Mon, 19 Oct 2020 15:03:21 +0000 (16:03 +0100)]
Revert rGa704d8238c86bac: "[InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3)) uniform vector support"
This reverts commit
a704d8238c86bac524f14adb6b04e0908a324e15.
Causing stage2 build failures on some bots.
Nathan James [Mon, 19 Oct 2020 14:57:46 +0000 (15:57 +0100)]
[clang-tidy] Add scoped enum constants to identifier naming check
Added option `ScopedEnumConstant(Prefix|Case|Suffix)` to readability-identitied-naming.
This controls the style for constants in scoped enums, declared as enum (class|struct).
If this option is unspecified the EnumConstant style will be used instead.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D89407
Peter Steinfeld [Sat, 17 Oct 2020 01:27:51 +0000 (18:27 -0700)]
[flang] Add name match checks for interface procedures
We had neglected to check for name mismatches for procedure definitions that
appear in interfaces.
I also changed label11.f90 to an error test since I think they're better than
"FileCheck" tests.
Differential Revision: https://reviews.llvm.org/D89611
Sam McCall [Mon, 19 Oct 2020 14:45:32 +0000 (16:45 +0200)]
[clangd] Add test for structured-binding completion. NFC
George Mitenkov [Mon, 19 Oct 2020 14:20:11 +0000 (17:20 +0300)]
[MLIR][SPIRVToLLVM] Updated documentation for composite ops
Added a section on composite ops (`spv.CompositeExtract` and
`spv.CompositeInsert`) conversion.
Reviewed By: antiagainst
Differential Revision: https://reviews.llvm.org/D89658
Simon Pilgrim [Mon, 19 Oct 2020 14:41:07 +0000 (15:41 +0100)]
[InstCombine] Add (icmp ne A, 0) | (icmp ne B, 0) --> (icmp ne (A|B), 0) vector support
Scalar cases were already being handled by foldLogOpOfMaskedICmps (so this was dead code), but refactoring to support non-uniform vectors will take some time, so tweak this fold in the meantime.
Aaron Ballman [Mon, 19 Oct 2020 14:36:15 +0000 (10:36 -0400)]
Revert "Extend tests of run-clang-tidy"
This reverts commit
627c01bee0deb353b3e3e90c1b8d0b6d73464466.
Some failing build bots:
http://lab.llvm.org:8011/#/builders/109/builds/690
http://lab.llvm.org:8011/#/builders/14/builds/476
Paul C. Anagnostopoulos [Thu, 15 Oct 2020 22:42:27 +0000 (18:42 -0400)]
[Aarch64] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans.
Differential Revision: https://reviews.llvm.org/D89551
Alexander Lanin [Mon, 19 Oct 2020 14:28:21 +0000 (10:28 -0400)]
Extend tests of run-clang-tidy
new test: parsing and using compile_commands
new test: export fixes to yaml file
old test extended with CHECK-MESSAGES in order to ensure that they "fail as intended"
Simon Pilgrim [Mon, 19 Oct 2020 14:23:35 +0000 (15:23 +0100)]
[InstCombine] Add (icmp eq B, 0) | (icmp ult/gt A, B) -> (icmp ule A, B-1) vector support
Nathan James [Mon, 19 Oct 2020 14:21:05 +0000 (15:21 +0100)]
[clang-tidy] Better support for Override function in RenamerClangTidy based checks
Methods that override virtual methods will now get renamed if the initial virtual method has a name violation.
Addresses https://bugs.llvm.org/show_bug.cgi?id=34879
Reviewed By: alexfh
Differential Revision: https://reviews.llvm.org/D79674
Kadir Cetinkaya [Mon, 19 Oct 2020 10:33:35 +0000 (12:33 +0200)]
[clangd] Rename edge name for filesymbols to slabs in memorytree
This was causing duplicate `symbols` components on the path as both the
edge from an index to filesymbols and filesymbols to symbolslabs were named
symbols.
Differential Revision: https://reviews.llvm.org/D89685
Simon Pilgrim [Mon, 19 Oct 2020 13:55:18 +0000 (14:55 +0100)]
[InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3)) uniform vector support
Simon Pilgrim [Mon, 19 Oct 2020 13:05:29 +0000 (14:05 +0100)]
[InstCombine] foldOrOfICmps - pull out repeated getOperand() calls. NFCI.
Simon Pilgrim [Mon, 19 Oct 2020 12:55:33 +0000 (13:55 +0100)]
[InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3)) vector tests
Paul C. Anagnostopoulos [Sun, 18 Oct 2020 14:47:07 +0000 (10:47 -0400)]
[TableGen] Enhance !empty and !size to handle strings and DAGs.
Fix bug in the type checking for !empty, !head, !size, !tail.
David Carlier [Mon, 19 Oct 2020 13:04:49 +0000 (14:04 +0100)]
[clang] update of the DragonFlyBSD's driver for the 5.8.x releases
Reviewers: sepavloff, jyknight
Reviewed By: sepavloff
Differential Revision: https://reviews.llvm.org/D89690
Sam McCall [Mon, 19 Oct 2020 12:58:31 +0000 (14:58 +0200)]
[ADT] Avoid use of result_of_t in function_ref
It has bugs on some old libc++ versions and we don't need the power.
See https://reviews.llvm.org/D88977
Piotr Sobczak [Fri, 16 Oct 2020 07:11:01 +0000 (09:11 +0200)]
[AMDGPU] Do not generate S_CMP_LG_U64 on gfx7
S_CMP_LG_U64 was added in gfx8 and is guarded by hasScalarCompareEq64().
Rewrite S_CMP_LG_U64 to S_OR_B32 + S_CMP_LG_U32 for targets that
do not support 64-bit scalar compare.
Differential Revision: https://reviews.llvm.org/D89536
Simon Pilgrim [Mon, 19 Oct 2020 12:42:41 +0000 (13:42 +0100)]
[InstCombine] Add (icmp ne A, 0) | (icmp ne B, 0) --> (icmp ne (A|B), 0) tests
Luís Marques [Mon, 19 Oct 2020 12:40:34 +0000 (13:40 +0100)]
[RISCV][ASAN] Fix TLS offsets
Fix a RISC-V ASan test failure: `TestCases/Linux/static_tls.cpp`.
Differential Revision: https://reviews.llvm.org/D89244
Hans Wennborg [Mon, 19 Oct 2020 12:38:53 +0000 (14:38 +0200)]
Fix compiler-rt build on Windows after D89640
It moved the cmake code from the else-branch to the if-branch
but forgot to flip the condition.
Kazushi (Jam) Marukawa [Sun, 18 Oct 2020 00:20:34 +0000 (09:20 +0900)]
[VE] Add setcc for fp128
Add setcc for fp128 and clean existing ISel patterns. Also add
a regression test.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89683
Kazushi (Jam) Marukawa [Sat, 17 Oct 2020 17:30:28 +0000 (02:30 +0900)]
[VE] Add cast to/from fp128 patterns
Add cast to/from fp128 patterns. Clean other cast patterns too.
Update a regression test by adding missing tests.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89682
Georgii Rymar [Mon, 19 Oct 2020 12:13:01 +0000 (15:13 +0300)]
[yaml2obj] - Fix comments. NFC.
This addressed post commit comments for D89391.
Georgii Rymar [Wed, 14 Oct 2020 11:20:38 +0000 (14:20 +0300)]
[llvm-readobj/elf] - Change the behavior of handing DT_SONAME.
The current situation/behavior is:
1) llvm-readelf doesn't need a string that is specified by `DT_SONAME`.
2) llvm-readobj/elf always tries to read it, even when there is no `DT_SONAME` tag.
3) Because of that both tools reports a warning for many our test cases.
This patch delays getting a SOName string and changes the behavior (llvm-readobj) to
only report a warning when there is a `DT_SONAME` and a string cab't be read.
Warning is not reported for llvm-readelf, as it never tries to dump it.
Differential revision: https://reviews.llvm.org/D89384
Sam Parker [Mon, 19 Oct 2020 11:26:44 +0000 (12:26 +0100)]
[LangRef] Correct return type llvm.test.set.loop.iterations.*
The langref description for llvm.test.set.loop.iterations.* were
missing the i1 return type.
Differential Revision: https://reviews.llvm.org/D89564
Patch by: Janek van Oirschot
Nathan James [Mon, 19 Oct 2020 11:53:51 +0000 (12:53 +0100)]
[nfc][clang-change-namespace] Remove unnecessary isScoped EnumDecl Matcher
Alexander Belyaev [Sat, 17 Oct 2020 11:15:31 +0000 (13:15 +0200)]
[mlir][nfc] Move BaseOpWithOffsetSizesAndStrides to the beginning of Ops.td.
Move the class to where all base classes are defined.
Also remove all the builders since they are definted in subclasses anyway.
Differential Revision: https://reviews.llvm.org/D89620
Marcel Koester [Wed, 16 Sep 2020 10:31:08 +0000 (12:31 +0200)]
[mlir] Refactored BufferPlacement transformation.
The current BufferPlacement transformation contains several concepts for
hoisting allocations. However, more advanced hoisting techniques should not be
integrated into the BufferPlacement transformation. Hence, this CL refactors the
current BufferPlacement pass into three separate pieces: BufferDeallocation and
BufferAllocation(Loop)Hoisting. Moreover, it extends the hoisting functionality
by allowing to move allocations out of loops.
Differential Revision: https://reviews.llvm.org/D87756
Simon Pilgrim [Mon, 19 Oct 2020 10:46:21 +0000 (11:46 +0100)]
[InstCombine] Add (icmp eq B, 0) | (icmp ult A, B) -> (icmp ule A, B-1) vector tests
Simon Pilgrim [Mon, 19 Oct 2020 10:15:38 +0000 (11:15 +0100)]
Fix MSVC "not all control paths return a value" warning. NFCI.
Jan Kratochvil [Mon, 19 Oct 2020 09:26:16 +0000 (11:26 +0200)]
[nfc] [lldb] Move LookupAddress to DWARFCompileUnit
LookupAddress makes no sense for DWARFTypeUnit.
Also make GetNonSkeletonUnit to preserve the called type.
Differential Revision: https://reviews.llvm.org/D89646
Hans Wennborg [Mon, 19 Oct 2020 10:23:22 +0000 (12:23 +0200)]
Revert "[PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting"
This broke Chromium's PGO build, it seems because hot-cold-splitting got turned
on unintentionally. See comment on the code review for repro etc.
> This patch adds -f[no-]split-cold-code CC1 options to clang. This allows
> the splitting pass to be toggled on/off. The current method of passing
> `-mllvm -hot-cold-split=true` to clang isn't ideal as it may not compose
> correctly (say, with `-O0` or `-Oz`).
>
> To implement the -fsplit-cold-code option, an attribute is applied to
> functions to indicate that they may be considered for splitting. This
> removes some complexity from the old/new PM pipeline builders, and
> behaves as expected when LTO is enabled.
>
> Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org>
> Differential Revision: https://reviews.llvm.org/D57265
> Reviewed By: Aditya Kumar, Vedant Kumar
> Reviewers: Teresa Johnson, Aditya Kumar, Fedor Sergeev, Philip Pfaffe, Vedant Kumar
This reverts commit
273c299d5d649a0222fbde03c9a41e41913751b4.
Kadir Cetinkaya [Mon, 12 Oct 2020 22:10:04 +0000 (00:10 +0200)]
[clangd] Add $/memoryUsage LSP extension
Performs a detailed profiling of clangd lsp server and conveys the
result to the client as a json object. It is of the form:
{
"_self": 0,
"_total": 8,
"child1": {
"_self": 4,
"_total": 4,
}
"child2": {
"_self": 2,
"_total": 4,
"child_deep": {
"_self": 2,
"_total": 2,
}
}
}
Differential Revision: https://reviews.llvm.org/D89277
Simon Pilgrim [Fri, 16 Oct 2020 15:06:14 +0000 (16:06 +0100)]
[InstCombine] Support vectors-with-undef in and(logicalshift(1,X),1) --> zext(X == 0) fold
Simon Pilgrim [Fri, 16 Oct 2020 14:56:05 +0000 (15:56 +0100)]
[InstCombine] Add vectors-with-undef tests for and(logicalshift(1,X),1) --> zext(X == 0)
David Sherwood [Mon, 19 Oct 2020 09:44:17 +0000 (10:44 +0100)]
Kazushi (Jam) Marukawa [Sat, 17 Oct 2020 13:09:50 +0000 (22:09 +0900)]
[VE] Support select_cc
Add missing ISel patterns related to select_cc DAG nodes.
Add regression test of all combination of possible scalar types.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89672
Kazushi (Jam) Marukawa [Sun, 18 Oct 2020 09:47:45 +0000 (18:47 +0900)]
[VE] Add VBRD/VMV instructions
Add VBRD/VMV vector instructions. In order to do that, also support
VM512 registers and RV instruction format in MC layer. Also add
regression tests for new instructions.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89641
Kazushi (Jam) Marukawa [Thu, 15 Oct 2020 21:43:57 +0000 (06:43 +0900)]
[VE] Add LSV/LVS/LVM/SVM instructions
Add LSV/LVS/LVM/SVM vector instructions and regression tests.
Also update AsmParser to support new format of operands.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89499
Kazushi (Jam) Marukawa [Sat, 17 Oct 2020 14:45:18 +0000 (23:45 +0900)]
[VE] Support br_cc comparing fp128
Support br_cc instruction comparing fp128 values. Add a br_cc.ll
regression test for all kind of br_cc instructions. And, clean
existing branch regression tests, this time. Clean a brcond.ll
regression test for brcond instruction. Remove mixed branch1.ll
regression test.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89627
Kazushi (Jam) Marukawa [Thu, 15 Oct 2020 21:24:29 +0000 (06:24 +0900)]
[VE] Update ISel patterns for select instruction
Add an ISel pattern for fp128 select instruction and optimize generated
code for other types' select. instructions. Add a regression test also.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89509
Alex Zinenko [Fri, 16 Oct 2020 16:30:08 +0000 (18:30 +0200)]
[mlir] Use `let arguments =` syntax instead of inheritance in LLVM dialect
LLVM dialect has been defining Op arguments by deriving the `Arguments` ODS
class. This has arguably worse readability due to large indentation caused by
multiple derivations, and is inconsistent with other ODS files. Use the `let
arguments` form instead.
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D89560
Lang Hames [Fri, 16 Oct 2020 23:50:24 +0000 (16:50 -0700)]
[ORC] Break up C-API header Orc.h, and add JITEventListener support.
This patch breaks Orc.h up into Orc.h, LLJIT.h and OrcEE.h.
Orc.h contain core Orc utilities.
LLJIT.h contains LLJIT specific types and functions.
OrcEE.h contains types and functions that depend on ExecutionEngine.
The intent is that these headers should match future library divisions: Clients
who only use Orc.h should only need to link againt the Orc core libraries,
clients using LLJIT.h will also need to link against LLVM core, and clients
using OrcEE.h will also have to link against ExecutionEngine.
In addition to breaking up the Orc.h header this patch introduces functions to:
(1) Set the object linking layer creation function on LLJITBuilder.
(2) Create an RTDyldObjectLinkingLayer instance (particularly for use in (1)).
(3) Register JITEventListeners with an RTDyldObjectLinkingLayer.
Together (1), (2) and (3) can be used to force use of RTDyldObjectLinkingLayer
as the underlying JIT linker for LLJIT, rather than the platform default, and
to register event listeners with the RTDyldObjectLinkingLayer.
Lang Hames [Mon, 19 Oct 2020 08:36:14 +0000 (01:36 -0700)]
[ORC] Add function to get pool entry string.
Patch by Andres Freund. Thanks Andres!
Lang Hames [Fri, 16 Oct 2020 03:33:22 +0000 (20:33 -0700)]
[ORC] Add C API support for defining absolute symbols.
Also tweaks the definition of TryToGenerate to make it dovetail more neatly
with the new function.
Lang Hames [Fri, 16 Oct 2020 00:33:16 +0000 (17:33 -0700)]
[ORC] Add support for custom generators to the C bindings.
C API clients can now define a custom definition generator by providing a
callback function (to implement DefinitionGenerator::tryToGenerate) and context
object. All arguments for the DefinitionGenerator::tryToGenerate method have
been given C API counterparts, and the API allows for optionally asynchronous
generation.
Lang Hames [Fri, 16 Oct 2020 00:31:14 +0000 (17:31 -0700)]
[Support] Add a C-API function to create a StringError instance.
This will allow C API clients to return errors from callbacks. This
functionality will be used in upcoming Orc C-bindings functions.
Lang Hames [Thu, 15 Oct 2020 01:40:49 +0000 (18:40 -0700)]
[ORC] Add an OrcV2 ResourceTracker / Removable-code example.
Lang Hames [Thu, 15 Oct 2020 00:17:44 +0000 (17:17 -0700)]
[ORC] Add basic ResourceTracker support to the OrcV2 C Bindings.
Based on a patch by Andres Freund. Thanks Andres!
Lang Hames [Wed, 14 Oct 2020 19:13:00 +0000 (12:13 -0700)]
[ORC] Rename LLVMOrcJITDylibDefinitionGeneratorRef.
The DefinitionGenerator class has been moved out of JITDylib. This updates
the C API type and function names to reflect that.
Lang Hames [Wed, 14 Oct 2020 18:35:37 +0000 (11:35 -0700)]
[ORC] Fix C API function name.
Patch by Andres Freund. Thanks Andres!
Lang Hames [Fri, 2 Oct 2020 04:12:19 +0000 (21:12 -0700)]
[ORC] Add C API functions to obtain and clear the symbol string pool.
Symbol string pool entries are ref counted, but not automatically cleared.
This can cause the size of the pool to grow without bound if it's not
periodically cleared. These functions allow that to be done via the C API.
Lang Hames [Thu, 1 Oct 2020 18:24:34 +0000 (11:24 -0700)]
[ORC] Add a C API function to set the ExecutionSession error reporter.
Lang Hames [Thu, 1 Oct 2020 22:25:06 +0000 (15:25 -0700)]
[ORC] Fix a memory leak in the OrcV2 C API (and some comment typos).
The LLVMOrcLLJITAddLLVMIRModule function was leaking its
LLVMOrcThreadSafeModuleRef argument. Wrapping the argument in a unique_ptr
fixes this.
Lang Hames [Wed, 14 Oct 2020 00:24:18 +0000 (17:24 -0700)]
[ORC] Update Symbol Lookup / DefinitionGenerator system.
This patch moves definition generation out from the session lock, instead
running it under a per-dylib generator lock. It also makes the
DefinitionGenerator::tryToGenerate method optionally asynchronous: Generators
are handed an opaque LookupState object which can be captured to stop/restart
the lookup process.
The new scheme provides the following benefits and guarantees:
(1) Queries that do not need to attempt definition generation (because all
requested symbols matched against existing definitions in the JITDylib)
can proceed without being blocked by any running definition generators.
(2) Definition generators can capture the LookupState to continue their work
asynchronously. This allows generators to run for an arbitrary amount of
time without blocking a thread. Definition generators that do not need to
run asynchronously can return without capturing the LookupState to eliminate
unnecessary recursion and improve lookup performance.
(3) Definition generators still do not need to worry about concurrency or
re-entrance: Since they are still run under a (per-dylib) lock, generators
will never be re-entered concurrently, or given overlapping symbol sets to
generate.
Finally, the new system distinguishes between symbols that are candidates for
generation (generation candidates) and symbols that failed to match for a query
(due to symbol visibility). This fixes a bug where an unresolved symbol could
trigger generation of a duplicate definition for an existing hidden symbol.
Lang Hames [Thu, 1 Oct 2020 21:40:08 +0000 (14:40 -0700)]
[ORC] Move DefinitionGenerator out of JITDylib.
This will make it easier to implement asynchronous definition generators.
Lang Hames [Fri, 2 Oct 2020 22:36:01 +0000 (15:36 -0700)]
[ORC] Move MaterializationResponsibility methods to ExecutionSession.
MaterializationResponsibility, JITDylib, and ExecutionSession collectively
manage the OrcV2 core JIT state. Responsibility for maintaining and
updating this state has previously been spread among these classes, resulting
in implementations that are each non-trivial, but all tightly coupled. This has
in turn made reading the code and reasoning about state update and locking
rules difficult.
The core state model can be simplified by thinking of
MaterializationResponsibility and JITDylib as facets of ExecutionSession. This
commit is the first in a series intended to refactor Core.cpp to reflect this
model. Operations on MaterializationResponsibility and JITDylib will forward to
implementation methods inside ExecutionSession. Raw state will remain with the
original classes, but in most cases will only be modified by the
ExecutionSession.
Evgeny Leviant [Mon, 19 Oct 2020 08:37:54 +0000 (11:37 +0300)]
[ARM][SchedModels] Convert IsPredicatedPred to MCSchedPredicate
Differential revision: https://reviews.llvm.org/D89553
Pavel Labath [Mon, 19 Oct 2020 08:28:47 +0000 (10:28 +0200)]
[lldb] Make DW_AT_declaration-with-children.s test more realistic
(Re)add DW_AT_specification and DW_AT_object_pointer attributes. These
were removed in
fa89f641c, as they were bogus due to bad test case
reduction.
Evgeny Leviant [Mon, 19 Oct 2020 08:02:53 +0000 (11:02 +0300)]
[TableGen] Remove test case
Differential revision: https://reviews.llvm.org/D89114
Roman Lebedev [Mon, 19 Oct 2020 07:57:26 +0000 (10:57 +0300)]
[NFC][SCEV] Rename SCEVCastExpr into SCEVIntegralCastExpr
All existing SCEV cast types operate on integers.
D89456 will add SCEVPtrToIntExpr cast expression type.
I believe this is best for consistency.
Reviewed By: mkazantsev
Differential Revision: https://reviews.llvm.org/D89455
Kiran Chandramohan [Sat, 17 Oct 2020 21:24:27 +0000 (22:24 +0100)]
[OpenMP][MLIR] Fix for nested parallel regions
Usage of nested parallel regions were not working correctly and leading
to assertion failures. Fix contains the following changes,
1) Don't set the insertion point in the body callback.
2) Save the continuation IP in a stack and set the branch to
continuationIP at the terminator.
Reviewed By: SouraVX, jdoerfert, ftynse
Differential Revision: https://reviews.llvm.org/D88720
Haojian Wu [Mon, 19 Oct 2020 07:44:29 +0000 (09:44 +0200)]
[clang-rename] Fix rename on variable templates.
This patch adds support for renaming variable templates.
Differential Revision: https://reviews.llvm.org/D89300
David Sherwood [Tue, 29 Sep 2020 11:08:40 +0000 (12:08 +0100)]
[SVE][CodeGen] Replace more TypeSize comparison operators with their scalar equivalents
In certain places in llvm/lib/CodeGen we were relying upon the TypeSize
comparison operators when in fact the code was only ever expecting
either scalar values or fixed width vectors. This patch changes a few
functions that were always expecting to work on scalar or fixed width
types:
1. DAGCombiner::mergeTruncStores - deals with scalar integers only.
2. DAGCombiner::ReduceLoadWidth - not valid for vectors.
3. DAGCombiner::createBuildVecShuffle - should only be used for
fixed width vectors.
4. SelectionDAGLegalize::ExpandFCOPYSIGN and
SelectionDAGLegalize::getSignAsIntValue - only work on scalars.
Differential Revision: https://reviews.llvm.org/D88562
Lang Hames [Mon, 19 Oct 2020 07:33:31 +0000 (00:33 -0700)]
[examples] Fix test: Kaleidoscope Chapter 4 no longer supports redefinition.
This may be fixed in the future, but since redefinition in OrcV2 requires more
manual work on the JIT client's part it was left out of the most recent update
to the tutorials.
Haojian Wu [Mon, 19 Oct 2020 07:26:32 +0000 (09:26 +0200)]
[clang-rename] Fix rename on function template specializations.
previously, we missed to rename occurrences to explicit function template
specilizations.
Differential Revision: https://reviews.llvm.org/D89221
David Sherwood [Tue, 29 Sep 2020 11:08:40 +0000 (12:08 +0100)]
[SVE][CodeGen][NFC] Replace TypeSize comparison operators with their scalar equivalents
In certain places in llvm/lib/CodeGen we were relying upon the TypeSize
comparison operators when in fact the code was only ever expecting
either scalar values or fixed width vectors. I've changed some of these
places to use the equivalent scalar operator.
Differential Revision: https://reviews.llvm.org/D88482
Lang Hames [Mon, 19 Oct 2020 07:25:15 +0000 (00:25 -0700)]
[examples] Fix Kaleidoscope-Ch3, which was broken by
ad92f16ccc5.
David Sherwood [Wed, 7 Oct 2020 07:26:17 +0000 (08:26 +0100)]
[SVE] Replace TypeSize comparison operators in llvm/utils/TableGen
In CodeGenDAGPatterns.cpp we were relying upon TypeSize comparison
operators for ordering types, when we can actually just use the known
minimum size since the scalable property is already being taken into
account. Also, in TypeInfer::EnforceSameSize I fixed some implicit
TypeSize->uint64_t casts by changing the code to test the equality
of TypeSize objects instead.
In other places I have replaced calls to getSizeInBits() with
getFixedSizeInBits() because we are only ever expecting integer values.
Differential Revision: https://reviews.llvm.org/D88947
Lang Hames [Mon, 19 Oct 2020 07:15:58 +0000 (00:15 -0700)]
[ORC] Move SimpleResourceManager function object inits out of constructor.
MSVC doesn't seem to like capturing references to variables in lambdas passed to
the variable's constructor. This should fix the windows bots that have been
unable to build the new ResourceTracker unit test.
Lang Hames [Mon, 19 Oct 2020 06:24:39 +0000 (23:24 -0700)]
[ORC] Add a missing '&'.
David Sherwood [Tue, 29 Sep 2020 07:03:13 +0000 (08:03 +0100)]
[SVE][CodeGen] Replace uses of TypeSize comparison operators
In certain places in the code we can never end up in a situation where
we're mixing fixed width and scalable vector types. For example,
we can't have truncations and extends that change the lane count. Also,
in other places such as GenWidenVectorStores and GenWidenVectorLoads we
know from the behaviour of FindMemType that we can never choose a vector
type with a different scalable property.
In various places I have used EVT::bitsXY functions instead of
TypeSize::isKnownXY, where it probably makes sense to keep an assert
that scalable properties match.
Differential Revision: https://reviews.llvm.org/D88654
David Sherwood [Fri, 9 Oct 2020 11:03:20 +0000 (12:03 +0100)]
[SVE][AArch64] Replace TypeSize comparisons with their integer equivalents
In many places in the AArch64 backend we are comparing TypeSize objects,
but in fact we are only ever expecting fixed width types. I've changed
all such comparisons to use their integer equivalents by replacing
calls to getSizeInBits() with getFixedSizeInBits(), etc.
Differential Revision: https://reviews.llvm.org/D89116
Max Kazantsev [Mon, 19 Oct 2020 06:38:20 +0000 (13:38 +0700)]
[Test] Add one more SCEV range test
Max Kazantsev [Mon, 19 Oct 2020 05:55:35 +0000 (12:55 +0700)]
[NFC][SCEV] Use getMinusOne where possible
Christian Sigg [Wed, 14 Oct 2020 08:31:08 +0000 (10:31 +0200)]
[mlir][gpu] NFC: Make room for more than one GPU rewrite pattern.
AllReduceLowering is currently the only GPU rewrite pattern, but more are coming. This is a preparation change.
Reviewed By: herhut
Differential Revision: https://reviews.llvm.org/D89370
Fangrui Song [Mon, 19 Oct 2020 05:36:58 +0000 (22:36 -0700)]
[PrologEpilogInserter] Fix prolog-params.mir
Christian Sigg [Sun, 18 Oct 2020 05:40:42 +0000 (07:40 +0200)]
[mlir] Allow space literals (` `) in assemblyFormat.
Spaces are only printed, not parsed.
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D89585
Kai Luo [Mon, 19 Oct 2020 03:41:05 +0000 (03:41 +0000)]
[PowerPC] Skip combining (uint_to_fp x) if x is not simple type
Current powerpc64le backend hits
```
Combining: t7: f64 = uint_to_fp t6
llc: llvm-project/llvm/include/llvm/CodeGen/ValueTypes.h:291: llvm::MVT llvm::EVT::getSimpleVT() const: Assertion `isSimple() && "Expected a SimpleValueType!"' failed.
```
This patch fixes it by skipping combination if `t6` is not simple type.
Fixed https://bugs.llvm.org/show_bug.cgi?id=47660.
Reviewed By: #powerpc, steven.zhang
Differential Revision: https://reviews.llvm.org/D88388