jochen@chromium.org [Mon, 15 Sep 2014 14:48:01 +0000 (14:48 +0000)]
Compile V8 with extra optimization in GN Release mode.
This matches the GYP build which does 'optimize': 'max' on the corresponding targets.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
567073003
Patch from Brett Wilson <brettw@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23952
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 15 Sep 2014 14:28:06 +0000 (14:28 +0000)]
Skip octane/pdfjs for now in debug mode because slow.
TBR=rossberg@chromium.org
TEST=benchmarks/octane/pdfjs
Review URL: https://codereview.chromium.org/
569243002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23950
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
titzer@chromium.org [Mon, 15 Sep 2014 13:57:56 +0000 (13:57 +0000)]
Fix schedule for interleaved floating control by wiring one floating control structure per block.
R=mstarzinger@chromium.org, bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
564403003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23949
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Mon, 15 Sep 2014 13:27:46 +0000 (13:27 +0000)]
Reset context disposed counter after executing the idle garbage collection operation.
BUG=
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
552723004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23948
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 15 Sep 2014 13:04:44 +0000 (13:04 +0000)]
Explicitly mask enum values to work around probable VS/Win64 compiler bug
TBR=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
564413003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23947
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
v8-autoroll@chromium.org [Mon, 15 Sep 2014 13:01:31 +0000 (13:01 +0000)]
[Auto-roll] Bump up version to 3.29.65.0
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23946
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Mon, 15 Sep 2014 13:00:32 +0000 (13:00 +0000)]
Make timeout configurable in performance test runner.
BUG=374740
LOG=n
TBR=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
569213002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23945
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 15 Sep 2014 12:48:55 +0000 (12:48 +0000)]
Enable typed pipeline for the benchmark tests.
R=rossberg@chromium.org
TEST=benchmarks
Review URL: https://codereview.chromium.org/
567293003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23944
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 15 Sep 2014 12:06:14 +0000 (12:06 +0000)]
Make type bitsets explicitly unsigned
TBR=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
556733003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23943
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Mon, 15 Sep 2014 11:47:47 +0000 (11:47 +0000)]
Remove benchmark runner.
This has been renamed to run_perf.
BUG=374740
LOG=n
TBR=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
564373003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23942
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 15 Sep 2014 11:19:20 +0000 (11:19 +0000)]
Moar prints
TBR=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
567363002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23941
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Mon, 15 Sep 2014 11:17:00 +0000 (11:17 +0000)]
Currently, a new isolate is created in an uninitialized state, and
several API methods will automatically initialize it. During this
uninitialized state, code event handlers and function entry handlers can
be attached to the isolate.
This CL deprecates SetFunctionEntryHook and moves the configuration of
those handlers to the Isolate factory method.
This will allow for initializing the Isolate at creation time in the
future.
Users of V8::SetFunctionEntryHook should pass the entry hook to
Isolate::New instead. V8::SetJitCodeEventHandler should either be passed
to Isolate::New as well, or (if startup events are not required) invoked
via the Isolate.
BUG=none
LOG=y
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
570993002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23940
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 15 Sep 2014 10:57:52 +0000 (10:57 +0000)]
Use memcpy to read double value in the deoptimizer.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
568043002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23939
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 15 Sep 2014 10:54:49 +0000 (10:54 +0000)]
Reland "Remove V8_HOST_CAN_READ_UNALIGNED and its uses."
BUG=chromium:412967
LOG=N
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
571903002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23938
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 15 Sep 2014 10:50:37 +0000 (10:50 +0000)]
moar printf
TBR=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
571913002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23937
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 15 Sep 2014 09:40:23 +0000 (09:40 +0000)]
Reland "Use unsigned type bitsets to limit undefined behaviour"
Temporary debug attempt; adds output to failing test in test-types.cc, otherwise unchanged.
Windows f
R=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
567333002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23936
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
baptiste.afsa@arm.com [Mon, 15 Sep 2014 09:27:42 +0000 (09:27 +0000)]
[turbofan] InstructionSelector tests for ARM64 comparisons.
R=bmeurer@chromium.org, ulan@chromium.org
Review URL: https://codereview.chromium.org/
567323002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23935
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jarin@chromium.org [Mon, 15 Sep 2014 09:21:39 +0000 (09:21 +0000)]
Remove deoptimization by patching the call stack.
We go back to patching the code for lazy deoptimization because ICs need the on-stack return address to read/update the IC address/state.
The change also fixes bunch of tests, mostly by adding more deoptimization points.
(We still need to add code to ensure lazy deopt patching does not overwrite ICs and other lazy deopts; this is coming next.)
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
568783002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23934
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 15 Sep 2014 09:11:57 +0000 (09:11 +0000)]
Fix over-long line
TBR=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
560553006
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23933
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Mon, 15 Sep 2014 09:09:45 +0000 (09:09 +0000)]
[turbofan] Remove extra attributes from SimplifiedOperatorBuilder methods.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
560103003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23932
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 15 Sep 2014 09:03:59 +0000 (09:03 +0000)]
Fixpoint typing has to consider all imprecise nodes
R=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
568743003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23931
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
v8-autoroll@chromium.org [Sat, 13 Sep 2014 09:31:36 +0000 (09:31 +0000)]
[Auto-roll] Bump up version to 3.29.63.0
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23927
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Sat, 13 Sep 2014 07:35:04 +0000 (07:35 +0000)]
Whitespace change to kick off bots.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23926
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 12 Sep 2014 21:11:09 +0000 (21:11 +0000)]
Revert "Remove V8_HOST_CAN_READ_UNALIGNED and its uses."
This reverts r23915.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
569783003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23925
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
arv@chromium.org [Fri, 12 Sep 2014 16:17:27 +0000 (16:17 +0000)]
ES6: String(symbol) should work like symbol.toString
Using String as a function and passing a symbol should return the
same value as if Symbol.prototype.toString was called.
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-string-constructor-string-value
BUG=v8:3554
LOG=Y
R=rossberg@chromium.org, rossberg
Review URL: https://codereview.chromium.org/
564863002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23923
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Fri, 12 Sep 2014 16:13:05 +0000 (16:13 +0000)]
Revert r23916, r23917 for breaking 64-bit tests.
"Use unsigned type bitsets to limit undefined behaviour".
TBR=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
563283003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23922
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Fri, 12 Sep 2014 15:09:51 +0000 (15:09 +0000)]
[turbofan] Use correct register_save_area_size with OOL constant pool.
Follow-up to r23843.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
565693002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23921
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
arv@chromium.org [Fri, 12 Sep 2014 15:07:43 +0000 (15:07 +0000)]
Arrow functions: Cleanup handling of the prototype property
The old code did not work correctly in case of optimizations. I
found this out when implementing concise methods and we now plumb
through the function kind so we know what kind of Map to create for
the function.
BUG=v8:2700
LOG=y
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
562253002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23920
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
v8-autoroll@chromium.org [Fri, 12 Sep 2014 15:01:46 +0000 (15:01 +0000)]
[Auto-roll] Bump up version to 3.29.62.0
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23919
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 12 Sep 2014 14:49:07 +0000 (14:49 +0000)]
Cleanup and simplify TurboFan generic lowering.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
565893002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23918
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Fri, 12 Sep 2014 13:36:08 +0000 (13:36 +0000)]
Fix tests
TBR=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
565173002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23917
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Fri, 12 Sep 2014 13:03:53 +0000 (13:03 +0000)]
Use unsigned type bitsets to limit undefined behaviour
R=bmeurer@chromium.org, svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
555153003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23916
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 12 Sep 2014 12:42:02 +0000 (12:42 +0000)]
Remove V8_HOST_CAN_READ_UNALIGNED and its uses.
R=jkummerow@chromium.org
BUG=chromium:412967
LOG=Y
Review URL: https://codereview.chromium.org/
568753002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23915
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Fri, 12 Sep 2014 11:59:26 +0000 (11:59 +0000)]
[turbofan] Some common operators are globally shared singletons.
TEST=compiler-unittests,cctest
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
565753004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23913
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 12 Sep 2014 11:32:05 +0000 (11:32 +0000)]
Enable typed pipeline on ARM and ARM64 for TurboFan.
R=bmeurer@chromium.org
BUG=v8:3553
LOG=N
Review URL: https://codereview.chromium.org/
552943003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23912
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sigurds@chromium.org [Fri, 12 Sep 2014 11:06:37 +0000 (11:06 +0000)]
Reland
- "Switch inlining to use simplified instead of machine loads."
- "Add copy support in inliner."
Reland fixes:
- size_t conversion for 64bit arches
- Don't call front() on empty vector
(triggers assertion on windows)
- turbo_inlining now implies turbo_types, as
it requires simplified lowering.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
559843004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23911
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jarin@chromium.org [Fri, 12 Sep 2014 10:58:43 +0000 (10:58 +0000)]
Reland "Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic."
This relands commit r23899.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
565093002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23910
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 12 Sep 2014 10:47:32 +0000 (10:47 +0000)]
Simplify test-debug/ProcessDebugMessagesThreaded and add debug output.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
567933002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23909
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 12 Sep 2014 10:43:27 +0000 (10:43 +0000)]
Allow more runtime functions to accept Int32s instead of Smis.
R=yangguo@chromium.org
TEST=mjsunit/array-join
Review URL: https://codereview.chromium.org/
563223002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23908
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
v8-autoroll@chromium.org [Fri, 12 Sep 2014 10:01:31 +0000 (10:01 +0000)]
[Auto-roll] Bump up version to 3.29.61.0
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23907
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
baptiste.afsa@arm.com [Fri, 12 Sep 2014 09:31:26 +0000 (09:31 +0000)]
[turbofan] Tests and fixes for ARM64 load/store with immediate offset.
R=bmeurer@chromium.org, ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
550113002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23906
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
baptiste.afsa@arm.com [Fri, 12 Sep 2014 09:18:43 +0000 (09:18 +0000)]
[turbofan] Fix double register swap in ARM and ARM64 backends.
R=bmeurer@chromium.org, mstarzinger@chromium.org
BUG=v8:3553
LOG=N
Review URL: https://codereview.chromium.org/
562443004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23905
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
marja@chromium.org [Fri, 12 Sep 2014 09:12:08 +0000 (09:12 +0000)]
Add script streaming API.
Blink will use this API to stream script data into V8 as the scripts
load. During loading, V8 can already parse the scripts. They will be then
compiled and executed when the loading is complete.
This is a reincarnation of https://codereview.chromium.org/
366153002/
with fixes.
BUG=
R=jochen@chromium.org, rossberg@chromium.org, svenpanne@chromium.org, yangguo@chromium.org
Review URL: https://codereview.chromium.org/
566553002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23904
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Fri, 12 Sep 2014 08:50:38 +0000 (08:50 +0000)]
[arm] Disable --turbo-types by default instead of ignoring the flag.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
561913004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23903
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jarin@chromium.org [Fri, 12 Sep 2014 08:49:22 +0000 (08:49 +0000)]
Revert "Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic."
This reverts commit r23899.
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/
552253003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23902
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 12 Sep 2014 08:44:14 +0000 (08:44 +0000)]
Fix Smi vs. HeapObject confusion in HConstants.
Representation and HType should agree with each other.
BUG=chromium:412215
LOG=y
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
556563005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23901
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Fri, 12 Sep 2014 08:43:27 +0000 (08:43 +0000)]
X87: Eliminate Turbofan shims with CodeFactory
port r23877.
original commit message:
Turbofan needs a code handle and a CallInterfaceDescriptor. At the same time we spread knowledge about how to create the initial IC code object too widely. Consolidate code creation and unify it with a descriptor via CodeFactory.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
567953002
Patch from Jing Bao <jing.bao@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23900
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jarin@chromium.org [Fri, 12 Sep 2014 08:18:29 +0000 (08:18 +0000)]
Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic.
This makes the syntactic order consistent with the evaluation order.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
561133005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23899
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Fri, 12 Sep 2014 07:51:39 +0000 (07:51 +0000)]
X87: Added CallInterfaceDescriptors to all code stubs.
port r23854.
original commit message:
Added CallInterfaceDescriptors to all code stubs. A handful
of code stubs are too complex to be described this way, and
they are encoded with the macro
DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR().
Along the way:
* allowed inheritance of CallInterfaceDescriptors.
* Defined static Register methods for some of the new
CallInterfaceDescriptors. We could go a lot further here, but
it doesn't have to be done immediately.
* Added Representation arrays to some CallInterfaceDescriptors,
especially where future hydrogen versions of the stubs could
benefit from this knowledge.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
566843004
Patch from Jing Bao <jing.bao@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23898
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Fri, 12 Sep 2014 07:06:50 +0000 (07:06 +0000)]
[turbofan] Most simplified operators are globally shared singletons.
TEST=compiler-unittests,cctest
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
554403003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23896
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Fri, 12 Sep 2014 07:02:11 +0000 (07:02 +0000)]
X87: Rename ascii to one-byte where applicable.
port r23840.
original commit message:
Rename ascii to one-byte where applicable.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
565853002
Patch from Jing Bao <jing.bao@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23895
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Fri, 12 Sep 2014 06:41:13 +0000 (06:41 +0000)]
X87: Get CallInterfaceDescriptor directly from CodeStub.
port r23778.
original commit message:
Get CallInterfaceDescriptor directly from CodeStub.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
562983003
Patch from Jing Bao <jing.bao@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23894
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Fri, 12 Sep 2014 05:49:01 +0000 (05:49 +0000)]
Disable typed pipeline for non-turbofan arch's after r23859.
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
568663002
Patch from Paul Lind <paul.lind@imgtec.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23893
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
v8-autoroll@chromium.org [Fri, 12 Sep 2014 05:01:15 +0000 (05:01 +0000)]
[Auto-roll] Bump up version to 3.29.60.0
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23892
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Fri, 12 Sep 2014 04:35:19 +0000 (04:35 +0000)]
[turbofan] Mark operator constructors as const in MachineOperatorBuilder.
TEST=compiler-unittests
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
559413002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23891
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Fri, 12 Sep 2014 02:12:15 +0000 (02:12 +0000)]
X87: Initialize CodeStubInterfaceDescriptor in the constructor.
port r23773.
original commit message:
Initialize CodeStubInterfaceDescriptor in the constructor.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
563133002
Patch from Jing Bao <jing.bao@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23890
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Fri, 12 Sep 2014 01:39:25 +0000 (01:39 +0000)]
X87: Encapsulate megamorphic load/tail-call in hydrogen
port r23772.
original commit message:
To aid vector-based load ic work, we need to be able to handle
the megamorphic load case in hydrogen. A simple approach is to
wrap the probe activity in a hydrogen instruction.
The instruction is novel in that it always tail-calls away.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
564683002
Patch from Jing Bao <jing.bao@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23889
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
v8-autoroll@chromium.org [Thu, 11 Sep 2014 20:31:35 +0000 (20:31 +0000)]
[Auto-roll] Bump up version to 3.29.58.0
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23885
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
balazs.kilvady@imgtec.com [Thu, 11 Sep 2014 17:02:28 +0000 (17:02 +0000)]
MIPS: Turbofan needs a code handle and a CallInterfaceDescriptor.
Port r23877 (bd09296)
Original commit message:
At the same time we spread knowledge about how to create the initial IC code object too widely. Consolidate code creation and unify it with a descriptor via CodeFactory.
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
564883002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23884
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 11 Sep 2014 16:09:21 +0000 (16:09 +0000)]
Fix typed lowering of JSAdd on non-number inputs.
R=rossberg@chromium.org
TEST=mjsunit/regress/regress-3476
Review URL: https://codereview.chromium.org/
564823003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23883
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Thu, 11 Sep 2014 15:19:17 +0000 (15:19 +0000)]
Nuke support for running MSan without a simulator.
We've abandoned that approach. The ARM64 simulator is the only supported way of
running V8 under MSan.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
493923003
Patch from Sergey Matveev <earthdok@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23882
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 11 Sep 2014 15:13:59 +0000 (15:13 +0000)]
Also disable typed pipeline on ARM after r23859.
R=ulan@chromium.org
BUG=v8:3553
LOG=N
Review URL: https://codereview.chromium.org/
562913003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23881
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Thu, 11 Sep 2014 13:39:37 +0000 (13:39 +0000)]
Update test262-es6
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
558013003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23880
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Thu, 11 Sep 2014 13:18:58 +0000 (13:18 +0000)]
Turbofan needs a code handle and a CallInterfaceDescriptor. At the same time we spread knowledge about how to create the initial IC code object too widely. Consolidate code creation and unify it with a descriptor via CodeFactory.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
567433002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23877
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 11 Sep 2014 12:51:05 +0000 (12:51 +0000)]
Do not use wide reads in CopyCharsUnsigned.
R=jkummerow@chromium.org
BUG=chromium:412967
LOG=Y
Review URL: https://codereview.chromium.org/
566583002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23876
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 11 Sep 2014 12:38:16 +0000 (12:38 +0000)]
Fix typed lowering of ToBoolean on NaN input.
R=rossberg@chromium.org
TEST=webkit/convert-nan-to-bool
Review URL: https://codereview.chromium.org/
565493003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23875
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 11 Sep 2014 12:16:33 +0000 (12:16 +0000)]
Expect access check in JSObject::DefineAccessor.
R=ulan@chromium.org, verwaest@chromium.org
BUG=chromium:411793
LOG=N
Review URL: https://codereview.chromium.org/
559403002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23874
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Thu, 11 Sep 2014 12:13:34 +0000 (12:13 +0000)]
Fix inaccurate type condition in Hydrogen
R=bmeurer@chromium.org
BUG=chromium:412210
LOG=Y
Review URL: https://codereview.chromium.org/
550453003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23873
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
balazs.kilvady@imgtec.com [Thu, 11 Sep 2014 12:13:09 +0000 (12:13 +0000)]
MIPS: Added CallInterfaceDescriptors to all code stubs.
Port r23854 (3870059)
Original commit message:
Added CallInterfaceDescriptors to all code stubs. A handful
of code stubs are too complex to be described this way, and
they are encoded with the macro
DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR().
Along the way:
* allowed inheritance of CallInterfaceDescriptors.
* Defined static Register methods for some of the new
CallInterfaceDescriptors. We could go a lot further here, but
it doesn't have to be done immediately.
* Added Representation arrays to some CallInterfaceDescriptors,
especially where future hydrogen versions of the stubs could
benefit from this knowledge.
BUG=
R=dusan.milosavljevic@imgtec.com
Review URL: https://codereview.chromium.org/
562153002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23872
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Thu, 11 Sep 2014 11:54:49 +0000 (11:54 +0000)]
Do full GC for small heaps in idle time handler.
BUG=407593
LOG=N
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
563573002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23871
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Thu, 11 Sep 2014 11:49:39 +0000 (11:49 +0000)]
Skip long running test variants for NaCL.
BUG=
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
566543002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23870
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Thu, 11 Sep 2014 11:47:39 +0000 (11:47 +0000)]
Fix regress-crbug-412203.js
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
563733002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23869
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
marja@chromium.org [Thu, 11 Sep 2014 11:29:28 +0000 (11:29 +0000)]
Revert "Add script streaming API."
This reverts r23865
Revert "Fix compilation after r23865."
This reverts r23867
Reason: the test contains characters too special for Windows's taste.
TBR=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
545203003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23868
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
marja@chromium.org [Thu, 11 Sep 2014 11:13:40 +0000 (11:13 +0000)]
Fix compilation after r23865.
TBR=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
549043003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23867
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alph@chromium.org [Thu, 11 Sep 2014 11:08:40 +0000 (11:08 +0000)]
Add AccessorInfo handling into heap profiler.
BUG=
R=svenpanne@chromium.org, yurys@chromium.org
Review URL: https://codereview.chromium.org/
564433003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23866
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
marja@chromium.org [Thu, 11 Sep 2014 11:06:26 +0000 (11:06 +0000)]
Add script streaming API.
Blink will use this API to stream script data into V8 as the scripts
load. During loading, V8 can already parse the scripts. They will be then
compiled and executed when the loading is complete.
BUG=
R=jochen@chromium.org, rossberg@chromium.org, svenpanne@chromium.org, yangguo@chromium.org
Review URL: https://codereview.chromium.org/
366153002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23865
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Thu, 11 Sep 2014 10:37:49 +0000 (10:37 +0000)]
[turbofan] Machine operators are globally shared singletons.
TEST=compiler-unittests,cctest
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
547233003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23864
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Thu, 11 Sep 2014 10:04:13 +0000 (10:04 +0000)]
Fix ElementsKind handling of prototypes in Array.concat
Double elements, typed elements, and sloppy arguments elements were all erroneously marked UNREACHABLE.
BUG=chromium:412203
LOG=n
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
560463002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23863
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Thu, 11 Sep 2014 09:58:58 +0000 (09:58 +0000)]
Add a script that can generate simple test cases for user-exposed JS builtins
(we won't check in any such tests; they can be generated on the fly when needed)
R=mbarbella@chromium.org
Review URL: https://codereview.chromium.org/
554683002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23862
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
marja@chromium.org [Thu, 11 Sep 2014 09:52:36 +0000 (09:52 +0000)]
Parser cleanup: less member variables.
Parser had unnecessary member pointers to stuff stored in the
CompilationInfo (which Parser also points to).
As we add more parsing code paths (in particular, script streaming), this gets
confusing and Parser and CompilationInfo can get out of sync.
BUG=
R=jochen@chromium.org, rossberg@chromium.org
Review URL: https://codereview.chromium.org/
527233003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23861
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 11 Sep 2014 09:48:56 +0000 (09:48 +0000)]
Expect requiring access check on objects with hidden properties.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
563723002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23860
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 11 Sep 2014 09:44:44 +0000 (09:44 +0000)]
Enable typed pipeline for TurboFan (again).
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
554413003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23859
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
aandrey@chromium.org [Thu, 11 Sep 2014 09:43:30 +0000 (09:43 +0000)]
Fix crash in ScriptDebugServer::wrapCallFrames
The crash happens in DebugEventListener that gets called for an unhandled exception thrown by TryCatch.ReThrow().
In DevTools some parts of DebugEventListener are implemented in JavaScript, thus we should allow JavaScript execution while handling ReThrow exception in debugger.
BUG=411196
LOG=Y
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
553043002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23858
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 11 Sep 2014 09:02:18 +0000 (09:02 +0000)]
Make --turbo-inlining available on the command line.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
565593002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23857
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
baptiste.afsa@arm.com [Thu, 11 Sep 2014 08:50:48 +0000 (08:50 +0000)]
ARM64: Change some incorect uses of ptrdiff_t to int64_t.
R=bmeurer@chromium.org, ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
559073003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23856
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Thu, 11 Sep 2014 08:01:24 +0000 (08:01 +0000)]
Improve x32 detection macro.
When targeting the Microsoft ABI in 64bit mode, clang defines __x86_64__ but
doesn't define __LP64__ (Microsoft uses LLP64), so it would fall down the x32
path. cl.exe doesn't define __x86_64__ in the first place, so it didn't have
this problem.
Rather than trying to guess pointer size by looking at __x86_64__ and __LP64__,
check for pointer size directly using __POINTER_SIZE__. This is defined by both
gcc and clang, and eliminiates this problem.
This should fix hundreds of "error(clang): unknown type name 'Atomic64'" when
compiling v8 on Windows with clang for 64 bit.
BUG=chromium:82385
LOG=n
R=haitao.feng@intel.com, jochen@chromium.org
Review URL: https://codereview.chromium.org/
560903002
Patch from Nico Weber <thakis@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23855
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Thu, 11 Sep 2014 07:11:10 +0000 (07:11 +0000)]
Added CallInterfaceDescriptors to all code stubs. A handful
of code stubs are too complex to be described this way, and
they are encoded with the macro
DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR().
Along the way:
* allowed inheritance of CallInterfaceDescriptors.
* Defined static Register methods for some of the new
CallInterfaceDescriptors. We could go a lot further here, but
it doesn't have to be done immediately.
* Added Representation arrays to some CallInterfaceDescriptors,
especially where future hydrogen versions of the stubs could
benefit from this knowledge.
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
551043005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23854
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Thu, 11 Sep 2014 05:30:19 +0000 (05:30 +0000)]
X87: Do not cache CodeStubInterfaceDescriptor on the isolate.
port r23744.
original commit message:
Do not cache CodeStubInterfaceDescriptor on the isolate.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
560793002
Patch from Jing Bao <jing.bao@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23853
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
v8-autoroll@chromium.org [Wed, 10 Sep 2014 23:01:28 +0000 (23:01 +0000)]
[Auto-roll] Bump up version to 3.29.56.0
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23849
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
paul.lind@imgtec.com [Wed, 10 Sep 2014 19:18:28 +0000 (19:18 +0000)]
MIPS: Rename ascii to one-byte where applicable.
Port r23840 (5463c43)
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
542193003
Patch from Balazs Kilvady <balazs.kilvady@imgtec.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23848
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
arv@chromium.org [Wed, 10 Sep 2014 17:36:00 +0000 (17:36 +0000)]
Remove runtime test for concise methods
The runtime tests have been removed.
LOG=N
BUG=None
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
560893002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23847
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
arv@chromium.org [Wed, 10 Sep 2014 16:39:42 +0000 (16:39 +0000)]
ES6: Add support for method shorthand in object literals
This is governed by the harmony-object-literals flag.
BUG=v8:3516
LOG=Y
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
477263002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23846
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Wed, 10 Sep 2014 16:19:42 +0000 (16:19 +0000)]
Fix status file after r23840.
TBR=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
557323004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23845
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 10 Sep 2014 15:58:23 +0000 (15:58 +0000)]
Fix awesomeness in X64 assembler.
R=ulan@chromium.org
TEST=mjsunit --turbo-types
Review URL: https://codereview.chromium.org/
559123003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23844
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Wed, 10 Sep 2014 14:40:59 +0000 (14:40 +0000)]
[turbofan] Save OOL constant pool pointer in CodeGenerator::AssemblePrologue.
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
541733002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23843
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 10 Sep 2014 13:41:09 +0000 (13:41 +0000)]
Actually disabled typed pipeline after r23830.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
558183002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23842
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 10 Sep 2014 12:56:19 +0000 (12:56 +0000)]
Also rename ascii to one-byte in tool scripts.
TBR=marja@chromium.org
Review URL: https://codereview.chromium.org/
561743002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23841
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 10 Sep 2014 12:38:12 +0000 (12:38 +0000)]
Rename ascii to one-byte where applicable.
R=dcarney@chromium.org, marja@chromium.org
Review URL: https://codereview.chromium.org/
559913002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23840
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 10 Sep 2014 12:31:13 +0000 (12:31 +0000)]
Fix JSReceiver::HasHiddenProperties wrt access-checked objects.
R=jkummerow@chromium.org
BUG=chromium:411877
LOG=N
Review URL: https://codereview.chromium.org/
564443002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23839
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Wed, 10 Sep 2014 12:29:48 +0000 (12:29 +0000)]
[turbofan] Lower JSStoreProperty during JS typed lowering.
Note that we cannot yet emit a diamond here (patch is ready), because
the scheduler is still broken wrt. free floating control (seems related
although this diamond is not free floating).
TEST=cctest
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
557123005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23838
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00