Eric Engestrom [Tue, 11 Jul 2023 20:25:14 +0000 (21:25 +0100)]
ci: replace radeonsi_file_list anchor with reference
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 20:24:48 +0000 (21:24 +0100)]
ci: replace radv_file_list anchor with reference
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 20:24:18 +0000 (21:24 +0100)]
ci: replace iris_file_list anchor with reference
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 20:23:59 +0000 (21:23 +0100)]
ci: replace lavapipe_file_list anchor with reference
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 20:23:31 +0000 (21:23 +0100)]
ci: replace softpipe_file_list anchor with reference
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 20:22:43 +0000 (21:22 +0100)]
ci: replace llvmpipe_file_list anchor with reference
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 22:35:31 +0000 (23:35 +0100)]
ci: add .gallium-core-rules and use it instead of gallium_core_file_list anchor
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 20:19:16 +0000 (21:19 +0100)]
ci: add .llvmpipe-manual-rules and use it
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Eric Engestrom [Tue, 11 Jul 2023 15:37:27 +0000 (16:37 +0100)]
ci: use !reference for scheduled_pipeline retry rule
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24099>
Rohan Garg [Thu, 29 Jun 2023 17:10:10 +0000 (19:10 +0200)]
intel/genxml: set a default value for "Pixel Position Offset Enable" in genxml
Set the default value for "Pixel Position Offset Enable" when emitting
3DSTATE_MULTISAMPLE in the genxml so that we can drop it from blorp
and genX_state.
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23936>
David Rosca [Mon, 17 Jul 2023 10:34:40 +0000 (12:34 +0200)]
radeonsi/vcn: Enable full/limited range support for H264/HEVC/AV1
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24174>
David Rosca [Mon, 17 Jul 2023 12:18:41 +0000 (14:18 +0200)]
radeonsi/vcn: Set HEVC video signal parameters in bitstream
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24174>
David Rosca [Mon, 17 Jul 2023 10:34:29 +0000 (12:34 +0200)]
radeonsi/vcn: Set H264 video signal parameters in bitstream
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24174>
David Rosca [Mon, 17 Jul 2023 10:22:41 +0000 (12:22 +0200)]
frontends/va: Add postproc support for converting to full range
Acked-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24174>
David Rosca [Mon, 17 Jul 2023 12:13:18 +0000 (14:13 +0200)]
frontends/va: Parse HEVC SPS for video signal parameters
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24174>
David Rosca [Sun, 16 Jul 2023 18:26:18 +0000 (20:26 +0200)]
frontends/va: Parse H264 SPS for video signal parameters
Since packed headers support is now advertised for H264,
it also fixes encoding into mkv with ffmpeg.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3524
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24174>
David Rosca [Sun, 16 Jul 2023 15:34:20 +0000 (17:34 +0200)]
radeonsi/vcn: Don't use chroma in AV1 encode with RGB input
Fixes:
64eab1f3ae
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Thong Thai <thong.thai@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24170>
David Rosca [Sat, 15 Jul 2023 14:30:04 +0000 (16:30 +0200)]
frontends/va: Don't use EFC with scaling or filtering enabled
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24170>
David Rosca [Sat, 15 Jul 2023 12:46:53 +0000 (14:46 +0200)]
frontends/va: Skip processing buffers already converted with EFC
Since the EFC conversion reallocates the dst buffer with new format,
any subsequent VA postproc calls on the same surface will fall back
to vl_compositor conversion.
This is the case in ffmpeg where the postproc filter output
buffers are reused instead of allocated for each frame.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24170>
Yiwei Zhang [Tue, 18 Jul 2023 18:27:40 +0000 (18:27 +0000)]
venus: reduce to use 4K mem suballoc align on platforms known to fit
This is a workaround for low ram arm devices before fixing:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/9351
Test: patch to prior higher limit 16384 and run
dEQP-VK.api.object_management.max_concurrent.query_pool
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24219>
Kenneth Graunke [Tue, 18 Jul 2023 06:26:39 +0000 (23:26 -0700)]
iris: Re-emit 3DSTATE_DS for each primitive (workaround
14019750404)
Some platforms require us to re-emit 3DSTATE_DS before every 3DPRIMITIVE
when tessellation is enabled. See workaround
14019750404.
Cc: 23.2 <mesa-stable>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24150>
Iván Briano [Thu, 6 Jul 2023 20:02:29 +0000 (13:02 -0700)]
anv: implement Wa_14019750404
Cc: 23.2 <mesa-stable>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8931
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24150>
Iván Briano [Wed, 5 Jul 2023 22:40:52 +0000 (15:40 -0700)]
anv: ensure mesh is disabled on context init
It turns out the hardware doesn't save the whole state on a context
switch, as the kernel expects when it creates the golden context.
For some HW units, only the state that was explicitly programmed will be
part of it, so we need to make sure mesh shading is disabled on context
creation, or we risk being context switched with an application that
uses mesh, and when ours gets to run again, the mesh state won't be
reset, and submitting a legacy 3D pipeline while the HW thinks mesh is
enabled causes us to hang.
Cc: 23.2 <mesa-stable>
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24150>
Iván Briano [Wed, 5 Jul 2023 22:40:52 +0000 (15:40 -0700)]
iris: ensure mesh is disabled on context init
It turns out the hardware doesn't save the whole state on a context
switch, as the kernel expects when it creates the golden context.
For some HW units, only the state that was explicitly programmed will be
part of it, so we need to make sure mesh shading is disabled on context
creation, or we risk being context switched with an application that
uses mesh, and when ours gets to run again, the mesh state won't be
reset, and submitting a legacy 3D pipeline while the HW thinks mesh is
enabled causes us to hang.
Cc: 23.2 <mesa-stable>
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24150>
Gert Wollny [Mon, 17 Jul 2023 15:36:32 +0000 (17:36 +0200)]
r600/sfn: Print more info if scheduling fails
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Mon, 17 Jul 2023 15:26:19 +0000 (17:26 +0200)]
r600/sfn: Add some tests for proper register access
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Mon, 17 Jul 2023 15:25:13 +0000 (17:25 +0200)]
r600/sfn: reorder the value factory class member declaration a bit
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Mon, 17 Jul 2023 15:24:28 +0000 (17:24 +0200)]
r600/sfn: Add peephole optimization to move a dest to the previous op
This is mostly tailored to the register store op where we get a sequence
ALU OP S1.x : ...
ALU MOV R1.x = S1.x
but it can help elsewhere too.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Mon, 17 Jul 2023 15:21:00 +0000 (17:21 +0200)]
r600/sfn: Increase LDS fetch schedule priority
Otherwise we may end up scheduling the value read before the
value fetch.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Mon, 17 Jul 2023 15:19:31 +0000 (17:19 +0200)]
r600/sfn: Handle indirect array load/store dependencies better
Indirect access must depend on all writes to the array
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Mon, 17 Jul 2023 15:14:00 +0000 (17:14 +0200)]
r600/sfn: Allow for larger ALU CF's
We should get as close as possible to the limit the hardware and the
assembler backend allows for.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Mon, 10 Jul 2023 17:42:11 +0000 (19:42 +0200)]
r600/sfn/tests: add simple copy-prop test with register source
Just to make sure the register intrinsic conversion doesn't need the helpers.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Gert Wollny [Thu, 6 Jul 2023 14:23:21 +0000 (16:23 +0200)]
r600/sfn: Switch to register intrinsics
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Alyssa Rosenzweig [Fri, 26 May 2023 16:13:07 +0000 (12:13 -0400)]
r600/sfn: Remove nir_register unit tests
These tests will be obsolete soon and are just extra users of an API that will
be removed. Drop them.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24212>
Samuel Pitoiset [Mon, 17 Jul 2023 14:59:57 +0000 (16:59 +0200)]
radv: make radv_get_pa_su_sc_mode_cntl() static
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24192>
Samuel Pitoiset [Thu, 29 Jun 2023 14:59:46 +0000 (16:59 +0200)]
radv: remove support for VK_INDIRECT_COMMANDS_TOKEN_TYPE_STATE_FLAGS_NV
This isn't used by vkd3d-proton which is the only user of DGC, no need
to overcomplicate this.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24192>
Marek Olšák [Sun, 16 Jul 2023 07:44:53 +0000 (03:44 -0400)]
util/u_queue: always enable UTIL_QUEUE_INIT_SCALE_THREADS, remove the flag
It means that threads are created on demand except for the first one.
It reduces process startup time.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24173>
Marek Olšák [Sun, 16 Jul 2023 07:24:21 +0000 (03:24 -0400)]
util/u_queue: fix util_queue_finish deadlock by merging lock and finish_lock
and by disabling the on-demand thread creation, which breaks the finish logic.
Fixes:
3713dc6b2a7 - util/u_queue: add UTIL_QUEUE_INIT_SCALE_THREADS flag
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8363
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24173>
Alyssa Rosenzweig [Mon, 17 Jul 2023 20:54:58 +0000 (16:54 -0400)]
panfrost: Fix transform feedback on v9
We were using a stale FAU buffer which meant we wrote to garbage addresses. I'm
guessing this was fallout from the big sysval rework but not 100% sure.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24199>
Iván Briano [Tue, 18 Jul 2023 04:37:10 +0000 (21:37 -0700)]
anv: ensure CFE_STATE is emitted for ray tracing pipelines
Fixes sporadic failures in dEQP-VK.robustness.robustness2.*.rgen
Fixes:
ecb709c8535 ("anv: only emit CFE_STATE when scratch space increases")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9382
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24206>
David Heidelberg [Tue, 18 Jul 2023 00:09:10 +0000 (02:09 +0200)]
ci/freedreno: add a530 flakes, remove one fail which recently started passing
dEQP-GLES31.functional.texture.texture_buffer.render.as_vertex_array_as_index_array_as_fragment_texture.offset_1_alignments
seems to got fixed by accident?
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24203>
David Heidelberg [Mon, 17 Jul 2023 23:08:19 +0000 (01:08 +0200)]
ci/microsoft: when re-enabling Windows Farm, always run the container
Otherwise, Marge queue has to wait for someone manually trigger it.
Fixes:
d3b66356 ("ci/microsoft: partly revert rename from container-rules to manual-rules")
Acked-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24048>
Robert Foss [Fri, 23 Jun 2023 15:50:12 +0000 (17:50 +0200)]
egl: Rename _eglAddDevice() to _eglFindDevice()
_eglAddDevice() is now only used to look up eglDevices,
which means that the function name is a bit misleading.
Since this function is only used for finding the
eglDevice, it should also no longer support adding
a device to the egl devices list.
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23742>
Robert Foss [Fri, 23 Jun 2023 15:50:12 +0000 (17:50 +0200)]
egl: Rename _eglAddDevice() to _eglFindDevice()
_eglAddDevice() is now only used to look up eglDevices,
which means that the function name is a bit misleading.
Since this function is only used for finding the
eglDevice, it should also no longer support adding
a device to the egl devices list.
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23742>
Robert Foss [Tue, 13 Jun 2023 11:50:29 +0000 (13:50 +0200)]
egl/android: Use EGL DeviceList instead drmGetDevices2()
droid_open_device() lists all of the DRM devices available,
but since EGL already already has created such a list use that
instead.
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23742>
Robert Foss [Tue, 13 Jun 2023 11:57:45 +0000 (13:57 +0200)]
egl/surfaceless: Use EGL DeviceList instead of drmGetDevices2()
surfaceless_probe_device() lists all of the DRM devices available,
but since EGL already already has created such a list use that instead.
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23742>
Robert Foss [Tue, 13 Jun 2023 11:56:36 +0000 (13:56 +0200)]
egl: Refresh DeviceList during eglInitialize()
eglInitialize() must be called before the dri2 platforms probe
in order for the EGL DeviceList to be populate with devices.
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23742>
Robert Foss [Mon, 19 Jun 2023 12:15:04 +0000 (14:15 +0200)]
egl: Rename _eglRefreshDeviceList() to _eglDeviceRefreshList()
Rename this function to better reflect it's location
and what structs it relates to.
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23742>
Robert Foss [Mon, 19 Jun 2023 11:55:22 +0000 (13:55 +0200)]
egl: Expose access to DeviceList
In order to not have the different dri2 platforms all build
lists of available devices, use the device list provided by EGL.
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23742>
Eric Engestrom [Mon, 17 Jul 2023 18:07:43 +0000 (19:07 +0100)]
ci: drop leftover kernel configs
Fixes:
23158e9a3f7c1c3155bf ("ci: build kernel in gfx-ci/linux and just use binaries in Mesa3D CI")
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24195>
Alyssa Rosenzweig [Fri, 14 Jul 2023 14:13:29 +0000 (10:13 -0400)]
radv: Rely on workgroup_size initialization
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24158>
Alyssa Rosenzweig [Fri, 14 Jul 2023 14:07:36 +0000 (10:07 -0400)]
v3dv: Rely on nir_builder setting workgroup size
Now the default.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24158>
Alyssa Rosenzweig [Fri, 14 Jul 2023 14:07:04 +0000 (10:07 -0400)]
nir: Initialize workgroup_size in builder_init_simple_shader
It can't be 0 in Vulkan.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24158>
Danylo Piliaiev [Mon, 17 Jul 2023 16:28:43 +0000 (18:28 +0200)]
ir3: Use NIR info to enable per sample shading
NIR is tracking this better than us.
New CTS tests seem to add the requirement where in the presence of some
builtin's like gl_SampleID in a shader, even if unused, sample shading
is expected to be enabled.
See https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/3712
Fixes:
dEQP-VK.draw.*.implicit_sample_shading.sample_id_static_use
dEQP-VK.draw.*.implicit_sample_shading.sample_position_static_use
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24193>
David Heidelberg [Fri, 7 Jul 2023 23:48:31 +0000 (01:48 +0200)]
ci: add quirk for GitLab assuming changes is always true for scheduled runs
Sadly GitLab CI always evaluate `rules:changes` as true, when running
scheduled runs. So we have to add explicit condition to ignore it there.
Every line using `rules:changes` has to have following condition
ignoring "schedule" runes.
Cc: mesa-stable
Reported-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24051>
Alyssa Rosenzweig [Fri, 14 Jul 2023 14:33:22 +0000 (10:33 -0400)]
ir3: Use nir_lower_tess_coord_z
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24159>
Alyssa Rosenzweig [Fri, 14 Jul 2023 14:30:14 +0000 (10:30 -0400)]
r600: Use nir_lower_tess_coord_xy
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24159>
Alyssa Rosenzweig [Fri, 14 Jul 2023 14:28:37 +0000 (10:28 -0400)]
nir: Add nir_lower_tess_coord_z pass
Lowers tess_coord to tess_coord_xy and math. Based on ir3's version.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24159>
Alyssa Rosenzweig [Fri, 14 Jul 2023 14:26:47 +0000 (10:26 -0400)]
nir: Promote tess_coord_r600 to tess_coord_xy
This intrinsic (vec2 tess_coord) is generally useful for non-r600 backends.
Promote it.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24159>
Eric Engestrom [Tue, 11 Jul 2023 20:25:47 +0000 (21:25 +0100)]
ci: replace copy of nouveau rules with reference
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24190>
Marek Olšák [Mon, 17 Jul 2023 14:41:57 +0000 (10:41 -0400)]
freedreno,lima,zink: update CI fixes and flakes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24165>
Marek Olšák [Fri, 14 Jul 2023 19:35:05 +0000 (15:35 -0400)]
mesa: fix 38% decrease in display list performance of Viewperf2020/NX8_StudioAA
It happened because glCallList was restoring varying_vp_inputs, which
caused every glCallList to process the state change again.
This loosely reverts commit
3a294ff01fb9d1d8b4f984a364ed7ef469624c49
"mesa: move the _mesa_set_varying_vp_inputs call to where the state changes".
Fixes:
3a294ff01fb9d1d8b - "mesa: move the _mesa_set_varying_vp_inputs call to where the state changes"
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24165>
Guilherme Gallo [Mon, 17 Jul 2023 04:30:59 +0000 (01:30 -0300)]
bin/ci: Ensure that all jobs have nodes in DAG
Some automatic jobs, such as 'rustfmt' and 'clang-format', are skipped
during the graph sweep because their parents are already included in the
node set.
This commit ensures all visited jobs are in DAG and fixes iteration
modification using deepcopy.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9376
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24176>
Rhys Perry [Tue, 4 Jul 2023 11:41:11 +0000 (12:41 +0100)]
nir/tests: add test for unsigned_upper_bound with loop header phis
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23990>
Rhys Perry [Mon, 3 Jul 2023 17:36:28 +0000 (18:36 +0100)]
nir/unsigned_upper_bound: fix phi(bcsel)
This was looking at the wrong sources. src0 is the condition.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Fixes:
72ac3f60261 ("nir: add nir_unsigned_upper_bound and nir_addition_might_overflow")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23990>
Leo Liu [Fri, 14 Jul 2023 15:45:58 +0000 (11:45 -0400)]
radeonsi: add AV1 profile to supported profile
With fully supported profile, we will get info based on querying to
the kernel.
Signed-off-by: Leo Liu <leo.liu@amd.com>
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24161>
Rohan Garg [Mon, 17 Jul 2023 11:34:51 +0000 (13:34 +0200)]
intel/perf: add perf query support for Intel Raptorlake
Fixes:
4e0eca7dc3 ("intel/dev: Add device info for RPL")
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24180>
Marek Olšák [Sat, 15 Jul 2023 12:22:37 +0000 (08:22 -0400)]
glthread: determine global locking once every 64 batches to fix get_time perf
This mitigates a large perf degradation when the clock source is HPET instead of TSC.
Just call get_time less frequently.
Fixes:
3ed141e9 - glthread: add a heuristic to stop locking global mutexes with multiple contexts
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8910
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24168>
Rhys Perry [Wed, 12 Jul 2023 20:14:26 +0000 (21:14 +0100)]
ac/nir: always round cube array layers
It seems this is still necessary if conformant_trunc_coord=true.
Fixes various dEQP-VK.texture.shadow.cube_array.* and
dEQP-VK.glsl.texture_functions.texture*samplercubearray* failures with
conformant_trunc_coord.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Cc: 23.2 <mesa-stable>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24137>
Rhys Perry [Wed, 12 Jul 2023 19:51:14 +0000 (20:51 +0100)]
radv: don't unset TRUNC_COORD if conformant_trunc_coord=true
This isn't necessary.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24137>
Rhys Perry [Wed, 12 Jul 2023 19:50:53 +0000 (20:50 +0100)]
radv: add conformant_trunc_coord to cache UUID
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24137>
Rhys Perry [Thu, 13 Jul 2023 15:37:11 +0000 (16:37 +0100)]
ac/llvm: skip ballot zext for 32-bit dest with wave32-as-wave64
NGG lowering can ballots with a 32-bit destination even if the ballot bit
size is 64.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24140>
Rhys Perry [Thu, 13 Jul 2023 13:46:49 +0000 (14:46 +0100)]
ac/llvm: fix wave32 ac_build_mbcnt_add with 64-bit mask
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24140>
Rhys Perry [Thu, 13 Jul 2023 13:37:15 +0000 (14:37 +0100)]
radv: fix radv_get_ballot_bit_size with CS
For wave64-as-wave32, this would return 32.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24140>
Rhys Perry [Thu, 13 Jul 2023 13:25:04 +0000 (14:25 +0100)]
ac/llvm: fix AC_TM_CHECK_IR
This was using the wrong pass.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Fixes:
3f272fd15e9 ("ac/llvm: fix build with LLVM 17")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24140>
Lucas Stach [Fri, 14 Jul 2023 17:01:51 +0000 (19:01 +0200)]
etnaviv: remove bogus comment about replacing resource storage
While we might want to employ this orphaning trick one day to avoid stalls
on busy resources it's certainly not as easy as the comment implies, as
this would involve changing all relocs in cached state objects referencing
the resource.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 16:59:56 +0000 (18:59 +0200)]
etnaviv: remove always true assert in etna_transfer_unmap
The level parameter is already checked in etna_transfer_map, so there
is no way that the unmap could end up violating the assert.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 16:53:57 +0000 (18:53 +0200)]
etnaviv: remove superfluous braces
etnaviv gernerally uses the style where no braces are used if the
statement inside a conditional clause fits on a single line. Remove
some superfluous braces to be more consistent.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 16:50:46 +0000 (18:50 +0200)]
etnaviv: move buffer range tracking into the PIPE_MAP_WRITE clause
Move the valid buffer range tracking next to all the other things we
do on write mapping.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 16:30:48 +0000 (18:30 +0200)]
etnaviv: remove huge outdated comment
The comment makes it seem like we don't track resource status, which might
have been the case long ago, before the driver was even merged in upstream
Mesa, but is definitely no longer true. The kernel driver keeps track of
submitted work on BOs, the Mesa driver properly tracks unsubmitted usages
of any resource.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 16:26:25 +0000 (18:26 +0200)]
etnaviv: reword comment about staging resource usage
The current wording isn't really accurate. It talks about depth surfaces,
while in reality any surface used by the PE can have TS allocated. Also
with compression the TS doesn't only track "holes" aka clear tiles, but
instead carries the compression tags.
Reword to hopefully match reality a bit better.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 16:09:59 +0000 (18:09 +0200)]
etnaviv: check for valid TS as condition to create the staging resource
Presence of the TS buffer doesn't necessarily mean that there is valid
TS information that we need to take into account. This is pretty harmless
as the blit into the staging resource will just ignore invalid TS data
and most TS enabled resources are (super-)tiled anyways, which we will
handle with a staging resource nonetheless, but better not keep this bad
example around and replace with the appropriate check.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 15:54:45 +0000 (17:54 +0200)]
etnaviv: don't allocate full resource as transfer staging
The transfer only targets a specific level of a resource, so we don't
need to allocate all potential resource levels for the staging resource,
but instead shrink the allocation to a single level.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Lucas Stach [Fri, 14 Jul 2023 15:47:07 +0000 (17:47 +0200)]
etnaviv: split etna_copy_resource_box levels parameter in src/dst
Allow to copy between different level in the source and destination
resource.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24164>
Rohan Garg [Sat, 15 Jul 2023 13:59:50 +0000 (15:59 +0200)]
iris: fix iris for WA
16013000631
iris needs to emit a PIPE_CONTROL_INSTRUCTION_INVALIDATE for the
aforementioned WA.
Fixes:
83716b08c ('iris: migrate WA
14013910100 to use the WA framework')
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24171>
Lionel Landwerlin [Thu, 13 Jul 2023 09:27:06 +0000 (12:27 +0300)]
isl: add a tool to query surface parameters
$ ./build/src/intel/isl/isl_query -p dg2 -w 128 -h 64 -l 4
Surface parameters:
dim: 2d
dim_layout: 0
msaa_layout: 0
tiling: 64
format: R8G8B8A8_UNORM
img_align_el: 128x128x1
logical_level0_px: 128x64x1x1
phys_level0_sa: 128x64x1x1
levels: 4
samples: 1x
size_B: 131072
alignment_B: 65536
row_pitch_B: 512
array_pitch_el_rows: 256
tile_info:
tiling: 64
format_bpb: 32
logical_extent_el: 128x128x1x1
phys_extent_B: 512x128 = 65536
$./build/src/intel/isl/isl_query -p skl -w 128 -h 64 -l 4 -f R8G8B8_UINT
Surface parameters:
dim: 2d
dim_layout: 0
msaa_layout: 0
tiling: Y0
format: R8G8B8_UINT
img_align_el: 16x4x1
logical_level0_px: 128x64x1x1
phys_level0_sa: 128x64x1x1
levels: 4
samples: 1x
size_B: 36864
alignment_B: 4096
row_pitch_B: 384
array_pitch_el_rows: 96
tile_info:
tiling: Y0
format_bpb: 8
logical_extent_el: 128x32x1x1
phys_extent_B: 128x32 = 4096
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24142>
David Heidelberg [Sun, 16 Jul 2023 00:11:07 +0000 (02:11 +0200)]
ci/freedreno: add another a530 flakes
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
David Heidelberg [Sun, 16 Jul 2023 00:09:27 +0000 (02:09 +0200)]
ci/freedreno: fix unexpectedpass flake on a630
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
David Heidelberg [Fri, 14 Jul 2023 16:53:40 +0000 (18:53 +0200)]
ci/lima: EGL testing was disabled when fp16 fail was removed
fd4d0e1cc23f ("st/mesa: Set gl_config.floatMode based on color_format"),
fixed this functionality across multiple drivers, but EGL testing on
Mali was disabled back then, theofore it still fails here.
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Acked-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
David Heidelberg [Fri, 14 Jul 2023 00:52:15 +0000 (02:52 +0200)]
ci/radeonsi: stoney arb_timer_query got fixed between kernel 6.3.1..13
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Acked-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
David Heidelberg [Fri, 14 Jul 2023 00:51:16 +0000 (02:51 +0200)]
Revert "lima/ci: temporarily disable deqp-egl tests due to timeouts"
This reverts commit
be2619766be3f4ee0b22a10f8db179dc1e3c5773.
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Acked-by: Erico Nunes <nunes.erico@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
David Heidelberg [Tue, 11 Jul 2023 22:19:58 +0000 (00:19 +0200)]
ci/freedreno: add fails introduced by upreving to 6.3.13
Some of these fails/crashes was already present when trying 6.3.4,
two disappeared, one new crash appeared. Identical `.config`.
See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9247
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Acked-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
David Heidelberg [Mon, 10 Jul 2023 23:46:05 +0000 (01:46 +0200)]
ci: update kernel to 6.3.13
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Acked-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
David Heidelberg [Sat, 10 Jun 2023 03:16:56 +0000 (05:16 +0200)]
ci: build kernel in gfx-ci/linux and just use binaries in Mesa3D CI
This bring visible speedup while preparing the rootfs and containers.
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Acked-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24079>
Alyssa Rosenzweig [Thu, 13 Jul 2023 21:08:18 +0000 (17:08 -0400)]
nir: Devendor load_sample_mask
AGX will use this too for its MSAA lowerings.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24148>
Alyssa Rosenzweig [Thu, 8 Jun 2023 13:24:13 +0000 (09:24 -0400)]
nir: Add fence_{pbe,mem}_to_tex(_pixel)_agx intrinsics
Read-after-write hazards require special handling on AGX, since image loads are
implemented with texturing. Add intrinsics to handle these hazards.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24148>
Faith Ekstrand [Sat, 15 Jul 2023 05:15:12 +0000 (00:15 -0500)]
nv50/ir: Support vector movs
nir_opt_mov and nir_op_vecN are only the same if the mov is only a
single component. Otherwise the vec loop will try to access src[c]
where c > 0 which breaks for nir_op_mov. It's uncommon but scalar
back-ends can see vector movs so we need to handle this correctly.
Fixes:
6513c675ad31 ("nv50/ir/nir: implement nir_alu_instr handling")
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: M Henning <drawoc@darkrefraction.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24167>
Semjon Kravtsenko [Wed, 21 Jun 2023 07:50:44 +0000 (10:50 +0300)]
glx: Assign unique serial number to GLXBadFBConfig error
Fixes:
e89e1f5049d ("glx: Fix error handling yet again in CreateContextAttribs")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9171
Tested-by: yan12125
Co-authored-by: XRevan86
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23762>
WinLinux1028 [Tue, 11 Jul 2023 09:16:01 +0000 (18:16 +0900)]
radeonsi: prefix function with si_ to prevent name collision
Fixed a build error caused by multiple gfx11_init_query symbols when building with iris and radeonsi specified in gallium-drivers.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9238
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24045>
Sagar Ghuge [Tue, 2 May 2023 02:55:19 +0000 (19:55 -0700)]
isl: Disable MCS compression just on ACM platform
We're still seeing failures with render target reads of multisampled
images on Alchemist platforms, but Meteorlake doesn't appear to have
that issue. Enable MCS on Meteorlake.
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22802>